{"action":"created","issue":{"url":"https://api.github.com/repos/metomi/isodatetime/issues/101","repository_url":"https://api.github.com/repos/metomi/isodatetime","labels_url":"https://api.github.com/repos/metomi/isodatetime/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/metomi/isodatetime/issues/101/comments","events_url":"https://api.github.com/repos/metomi/isodatetime/issues/101/events","html_url":"https://github.com/metomi/isodatetime/pull/101","id":366701866,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMzA5NDg4","number":101,"title":"WIP Invert order of checks when time ticks","user":{"login":"kinow","id":304786,"node_id":"MDQ6VXNlcjMwNDc4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/304786?v=4","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"kinow","id":304786,"node_id":"MDQ6VXNlcjMwNDc4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/304786?v=4","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false},"assignees":[{"login":"kinow","id":304786,"node_id":"MDQ6VXNlcjMwNDc4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/304786?v=4","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/metomi/isodatetime/milestones/13","html_url":"https://github.com/metomi/isodatetime/milestone/13","labels_url":"https://api.github.com/repos/metomi/isodatetime/milestones/13/labels","id":3644095,"node_id":"MDk6TWlsZXN0b25lMzY0NDA5NQ==","number":13,"title":"next-release","description":"Release 11","creator":{"login":"matthewrmshin","id":908613,"node_id":"MDQ6VXNlcjkwODYxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/908613?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":10,"state":"open","created_at":"2018-09-11T13:31:09Z","updated_at":"2018-10-08T09:55:23Z","due_on":"2018-12-31T08:00:00Z","closed_at":null},"comments":3,"created_at":"2018-10-04T09:34:07Z","updated_at":"2018-10-11T08:02:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/metomi/isodatetime/pulls/101","html_url":"https://github.com/metomi/isodatetime/pull/101","diff_url":"https://github.com/metomi/isodatetime/pull/101.diff","patch_url":"https://github.com/metomi/isodatetime/pull/101.patch"},"body":"Hi @oliver-sanders \r\n\r\nI was browsing issues when I found #80 reported via a Cylc issue. I was curious to see in which part of the code it was happening. But then after debugging it once, it occurred to me that a possible solution would be to invert the order of the checks (i.e. the `if/else`'s) when the time is \"ticked\" and corrected when adding truncated `TimePoint`s.\r\n\r\nBut... even though I wrote a quick test and the possible fix, I am still not confident that that's the solution. Would you mind have a look at this one whenever you have time, please?\r\n\r\nI am assuming that different than\r\n\r\n>2000-01-01T00:00:00Z + 03-30T00:00:00Z = 2000-03-02T00:00:00Z\r\n\r\nthe expected result was actually\r\n\r\n>2000-01-01T00:00:00Z + 03-30T00:00:00Z = 2000-03-30T00:00:00Z\r\n\r\nIf this assumption is wrong, then you probably don't even have to spend time looking at the code/test :grimacing: \r\n\r\nCheers\r\nBruno\r\n\r\nps: in the Cylc ticket you mentioned other cases where the result was strange... I haven't tested those scenarios... maybe it could fix that too, or there could be other parts that need some fix..."},"comment":{"url":"https://api.github.com/repos/metomi/isodatetime/issues/comments/428859569","html_url":"https://github.com/metomi/isodatetime/pull/101#issuecomment-428859569","issue_url":"https://api.github.com/repos/metomi/isodatetime/issues/101","id":428859569,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODg1OTU2OQ==","user":{"login":"benfitzpatrick","id":1138333,"node_id":"MDQ6VXNlcjExMzgzMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1138333?v=4","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T08:02:26Z","updated_at":"2018-10-11T08:02:26Z","author_association":"MEMBER","body":"Thanks very much!"}}
{"actor":{"display_login":"benfitzpatrick"}}