{"action":"closed","number":1594,"pull_request":{"url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/1594","id":229909046,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTA5MDQ2","html_url":"https://github.com/PHPMailer/PHPMailer/pull/1594","diff_url":"https://github.com/PHPMailer/PHPMailer/pull/1594.diff","patch_url":"https://github.com/PHPMailer/PHPMailer/pull/1594.patch","issue_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/1594","number":1594,"state":"closed","locked":false,"title":"Use dedicated assertContains assertion","user":{"login":"carusogabriel","id":16328050,"node_id":"MDQ6VXNlcjE2MzI4MDUw","avatar_url":"https://avatars3.githubusercontent.com/u/16328050?v=4","gravatar_id":"","url":"https://api.github.com/users/carusogabriel","html_url":"https://github.com/carusogabriel","followers_url":"https://api.github.com/users/carusogabriel/followers","following_url":"https://api.github.com/users/carusogabriel/following{/other_user}","gists_url":"https://api.github.com/users/carusogabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/carusogabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carusogabriel/subscriptions","organizations_url":"https://api.github.com/users/carusogabriel/orgs","repos_url":"https://api.github.com/users/carusogabriel/repos","events_url":"https://api.github.com/users/carusogabriel/events{/privacy}","received_events_url":"https://api.github.com/users/carusogabriel/received_events","type":"User","site_admin":false},"body":"This will help us with better error messages. For example\r\n\r\n```diff\r\n-$this->assertTrue(strpos($this->Mail->Body, 'src=\"/etc/hostname\"') !== false); // Failed asserting that false is true.\r\n+$this->assertContains('src=\"/etc/hostname\"', $this->Mail->Body); // Failed asserting that a string contains 'src=\"/etc/hostname\"'.\r\n```","created_at":"2018-11-10T19:38:07Z","updated_at":"2018-11-11T15:34:55Z","closed_at":"2018-11-11T15:34:55Z","merged_at":"2018-11-11T15:34:55Z","merge_commit_sha":"43b774272bc91435ccb9479eedaa0446ce628188","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/1594/commits","review_comments_url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/1594/comments","review_comment_url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/1594/comments","statuses_url":"https://api.github.com/repos/PHPMailer/PHPMailer/statuses/749b46e79f9a749aa567e673b4bd04afae533697","head":{"label":"carusogabriel:assert-contains","ref":"assert-contains","sha":"749b46e79f9a749aa567e673b4bd04afae533697","user":{"login":"carusogabriel","id":16328050,"node_id":"MDQ6VXNlcjE2MzI4MDUw","avatar_url":"https://avatars3.githubusercontent.com/u/16328050?v=4","gravatar_id":"","url":"https://api.github.com/users/carusogabriel","html_url":"https://github.com/carusogabriel","followers_url":"https://api.github.com/users/carusogabriel/followers","following_url":"https://api.github.com/users/carusogabriel/following{/other_user}","gists_url":"https://api.github.com/users/carusogabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/carusogabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carusogabriel/subscriptions","organizations_url":"https://api.github.com/users/carusogabriel/orgs","repos_url":"https://api.github.com/users/carusogabriel/repos","events_url":"https://api.github.com/users/carusogabriel/events{/privacy}","received_events_url":"https://api.github.com/users/carusogabriel/received_events","type":"User","site_admin":false},"repo":{"id":157014531,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcwMTQ1MzE=","name":"PHPMailer","full_name":"carusogabriel/PHPMailer","private":false,"owner":{"login":"carusogabriel","id":16328050,"node_id":"MDQ6VXNlcjE2MzI4MDUw","avatar_url":"https://avatars3.githubusercontent.com/u/16328050?v=4","gravatar_id":"","url":"https://api.github.com/users/carusogabriel","html_url":"https://github.com/carusogabriel","followers_url":"https://api.github.com/users/carusogabriel/followers","following_url":"https://api.github.com/users/carusogabriel/following{/other_user}","gists_url":"https://api.github.com/users/carusogabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/carusogabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carusogabriel/subscriptions","organizations_url":"https://api.github.com/users/carusogabriel/orgs","repos_url":"https://api.github.com/users/carusogabriel/repos","events_url":"https://api.github.com/users/carusogabriel/events{/privacy}","received_events_url":"https://api.github.com/users/carusogabriel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carusogabriel/PHPMailer","description":"The classic email sending library for PHP","fork":true,"url":"https://api.github.com/repos/carusogabriel/PHPMailer","forks_url":"https://api.github.com/repos/carusogabriel/PHPMailer/forks","keys_url":"https://api.github.com/repos/carusogabriel/PHPMailer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carusogabriel/PHPMailer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carusogabriel/PHPMailer/teams","hooks_url":"https://api.github.com/repos/carusogabriel/PHPMailer/hooks","issue_events_url":"https://api.github.com/repos/carusogabriel/PHPMailer/issues/events{/number}","events_url":"https://api.github.com/repos/carusogabriel/PHPMailer/events","assignees_url":"https://api.github.com/repos/carusogabriel/PHPMailer/assignees{/user}","branches_url":"https://api.github.com/repos/carusogabriel/PHPMailer/branches{/branch}","tags_url":"https://api.github.com/repos/carusogabriel/PHPMailer/tags","blobs_url":"https://api.github.com/repos/carusogabriel/PHPMailer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carusogabriel/PHPMailer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carusogabriel/PHPMailer/git/refs{/sha}","trees_url":"https://api.github.com/repos/carusogabriel/PHPMailer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carusogabriel/PHPMailer/statuses/{sha}","languages_url":"https://api.github.com/repos/carusogabriel/PHPMailer/languages","stargazers_url":"https://api.github.com/repos/carusogabriel/PHPMailer/stargazers","contributors_url":"https://api.github.com/repos/carusogabriel/PHPMailer/contributors","subscribers_url":"https://api.github.com/repos/carusogabriel/PHPMailer/subscribers","subscription_url":"https://api.github.com/repos/carusogabriel/PHPMailer/subscription","commits_url":"https://api.github.com/repos/carusogabriel/PHPMailer/commits{/sha}","git_commits_url":"https://api.github.com/repos/carusogabriel/PHPMailer/git/commits{/sha}","comments_url":"https://api.github.com/repos/carusogabriel/PHPMailer/comments{/number}","issue_comment_url":"https://api.github.com/repos/carusogabriel/PHPMailer/issues/comments{/number}","contents_url":"https://api.github.com/repos/carusogabriel/PHPMailer/contents/{+path}","compare_url":"https://api.github.com/repos/carusogabriel/PHPMailer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carusogabriel/PHPMailer/merges","archive_url":"https://api.github.com/repos/carusogabriel/PHPMailer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carusogabriel/PHPMailer/downloads","issues_url":"https://api.github.com/repos/carusogabriel/PHPMailer/issues{/number}","pulls_url":"https://api.github.com/repos/carusogabriel/PHPMailer/pulls{/number}","milestones_url":"https://api.github.com/repos/carusogabriel/PHPMailer/milestones{/number}","notifications_url":"https://api.github.com/repos/carusogabriel/PHPMailer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carusogabriel/PHPMailer/labels{/name}","releases_url":"https://api.github.com/repos/carusogabriel/PHPMailer/releases{/id}","deployments_url":"https://api.github.com/repos/carusogabriel/PHPMailer/deployments","created_at":"2018-11-10T19:32:12Z","updated_at":"2018-11-10T19:32:15Z","pushed_at":"2018-11-10T19:47:26Z","git_url":"git://github.com/carusogabriel/PHPMailer.git","ssh_url":"git@github.com:carusogabriel/PHPMailer.git","clone_url":"https://github.com/carusogabriel/PHPMailer.git","svn_url":"https://github.com/carusogabriel/PHPMailer","homepage":null,"size":4685,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PHPMailer:master","ref":"master","sha":"c482b207240b3a32fe8ae800999fd294cc9c6568","user":{"login":"PHPMailer","id":3959702,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTk3MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3959702?v=4","gravatar_id":"","url":"https://api.github.com/users/PHPMailer","html_url":"https://github.com/PHPMailer","followers_url":"https://api.github.com/users/PHPMailer/followers","following_url":"https://api.github.com/users/PHPMailer/following{/other_user}","gists_url":"https://api.github.com/users/PHPMailer/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPMailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPMailer/subscriptions","organizations_url":"https://api.github.com/users/PHPMailer/orgs","repos_url":"https://api.github.com/users/PHPMailer/repos","events_url":"https://api.github.com/users/PHPMailer/events{/privacy}","received_events_url":"https://api.github.com/users/PHPMailer/received_events","type":"Organization","site_admin":false},"repo":{"id":2253830,"node_id":"MDEwOlJlcG9zaXRvcnkyMjUzODMw","name":"PHPMailer","full_name":"PHPMailer/PHPMailer","private":false,"owner":{"login":"PHPMailer","id":3959702,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTk3MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3959702?v=4","gravatar_id":"","url":"https://api.github.com/users/PHPMailer","html_url":"https://github.com/PHPMailer","followers_url":"https://api.github.com/users/PHPMailer/followers","following_url":"https://api.github.com/users/PHPMailer/following{/other_user}","gists_url":"https://api.github.com/users/PHPMailer/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPMailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPMailer/subscriptions","organizations_url":"https://api.github.com/users/PHPMailer/orgs","repos_url":"https://api.github.com/users/PHPMailer/repos","events_url":"https://api.github.com/users/PHPMailer/events{/privacy}","received_events_url":"https://api.github.com/users/PHPMailer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PHPMailer/PHPMailer","description":"The classic email sending library for PHP","fork":false,"url":"https://api.github.com/repos/PHPMailer/PHPMailer","forks_url":"https://api.github.com/repos/PHPMailer/PHPMailer/forks","keys_url":"https://api.github.com/repos/PHPMailer/PHPMailer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PHPMailer/PHPMailer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PHPMailer/PHPMailer/teams","hooks_url":"https://api.github.com/repos/PHPMailer/PHPMailer/hooks","issue_events_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/events{/number}","events_url":"https://api.github.com/repos/PHPMailer/PHPMailer/events","assignees_url":"https://api.github.com/repos/PHPMailer/PHPMailer/assignees{/user}","branches_url":"https://api.github.com/repos/PHPMailer/PHPMailer/branches{/branch}","tags_url":"https://api.github.com/repos/PHPMailer/PHPMailer/tags","blobs_url":"https://api.github.com/repos/PHPMailer/PHPMailer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PHPMailer/PHPMailer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PHPMailer/PHPMailer/git/refs{/sha}","trees_url":"https://api.github.com/repos/PHPMailer/PHPMailer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PHPMailer/PHPMailer/statuses/{sha}","languages_url":"https://api.github.com/repos/PHPMailer/PHPMailer/languages","stargazers_url":"https://api.github.com/repos/PHPMailer/PHPMailer/stargazers","contributors_url":"https://api.github.com/repos/PHPMailer/PHPMailer/contributors","subscribers_url":"https://api.github.com/repos/PHPMailer/PHPMailer/subscribers","subscription_url":"https://api.github.com/repos/PHPMailer/PHPMailer/subscription","commits_url":"https://api.github.com/repos/PHPMailer/PHPMailer/commits{/sha}","git_commits_url":"https://api.github.com/repos/PHPMailer/PHPMailer/git/commits{/sha}","comments_url":"https://api.github.com/repos/PHPMailer/PHPMailer/comments{/number}","issue_comment_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/comments{/number}","contents_url":"https://api.github.com/repos/PHPMailer/PHPMailer/contents/{+path}","compare_url":"https://api.github.com/repos/PHPMailer/PHPMailer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PHPMailer/PHPMailer/merges","archive_url":"https://api.github.com/repos/PHPMailer/PHPMailer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PHPMailer/PHPMailer/downloads","issues_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues{/number}","pulls_url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls{/number}","milestones_url":"https://api.github.com/repos/PHPMailer/PHPMailer/milestones{/number}","notifications_url":"https://api.github.com/repos/PHPMailer/PHPMailer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PHPMailer/PHPMailer/labels{/name}","releases_url":"https://api.github.com/repos/PHPMailer/PHPMailer/releases{/id}","deployments_url":"https://api.github.com/repos/PHPMailer/PHPMailer/deployments","created_at":"2011-08-23T07:57:17Z","updated_at":"2018-11-11T15:11:05Z","pushed_at":"2018-11-11T15:34:55Z","git_url":"git://github.com/PHPMailer/PHPMailer.git","ssh_url":"git@github.com:PHPMailer/PHPMailer.git","clone_url":"https://github.com/PHPMailer/PHPMailer.git","svn_url":"https://github.com/PHPMailer/PHPMailer","homepage":null,"size":4720,"stargazers_count":12049,"watchers_count":12049,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6651,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":6651,"open_issues":33,"watchers":12049,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/1594"},"html":{"href":"https://github.com/PHPMailer/PHPMailer/pull/1594"},"issue":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/1594"},"comments":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/1594/comments"},"review_comments":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/1594/comments"},"review_comment":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/1594/commits"},"statuses":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/statuses/749b46e79f9a749aa567e673b4bd04afae533697"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Synchro","id":81561,"node_id":"MDQ6VXNlcjgxNTYx","avatar_url":"https://avatars2.githubusercontent.com/u/81561?v=4","gravatar_id":"","url":"https://api.github.com/users/Synchro","html_url":"https://github.com/Synchro","followers_url":"https://api.github.com/users/Synchro/followers","following_url":"https://api.github.com/users/Synchro/following{/other_user}","gists_url":"https://api.github.com/users/Synchro/gists{/gist_id}","starred_url":"https://api.github.com/users/Synchro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Synchro/subscriptions","organizations_url":"https://api.github.com/users/Synchro/orgs","repos_url":"https://api.github.com/users/Synchro/repos","events_url":"https://api.github.com/users/Synchro/events{/privacy}","received_events_url":"https://api.github.com/users/Synchro/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":24,"changed_files":1}}
{"actor":{"display_login":"Synchro"}}