{"action":"created","comment":{"url":"https://api.github.com/repos/FTSRG/ingraph/pulls/comments/216160866","pull_request_review_id":153584784,"id":216160866,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjE2MDg2Ng==","diff_hunk":"@@ -207,7 +207,7 @@ object GPlanResolver {\n         case expr.PropertyAttribute(name, elementAttribute, _) => expr.PropertyAttribute(name,\n           // see \"scoped name resolver shorthand\" above\n           elementAttribute.transform(expressionNameResolver(snr)).asInstanceOf[expr.ElementAttribute],\n-          snr.resolve(s\"${elementAttribute.name}$$${name}\", rn))\n+          snr.resolve(s\"${elementAttribute.name}.${name}\", rn))","path":"compiler/src/main/scala/ingraph/compiler/cypher2gplan/GPlanResolver.scala","position":5,"original_position":5,"commit_id":"35f194d5f1823fe2f3cb760633656223d2fc3bec","original_commit_id":"b37d62f4f3918e39bbddcf76de7ed3139414c56d","user":{"login":"marci543","id":17354718,"node_id":"MDQ6VXNlcjE3MzU0NzE4","avatar_url":"https://avatars0.githubusercontent.com/u/17354718?v=4","gravatar_id":"","url":"https://api.github.com/users/marci543","html_url":"https://github.com/marci543","followers_url":"https://api.github.com/users/marci543/followers","following_url":"https://api.github.com/users/marci543/following{/other_user}","gists_url":"https://api.github.com/users/marci543/gists{/gist_id}","starred_url":"https://api.github.com/users/marci543/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marci543/subscriptions","organizations_url":"https://api.github.com/users/marci543/orgs","repos_url":"https://api.github.com/users/marci543/repos","events_url":"https://api.github.com/users/marci543/events{/privacy}","received_events_url":"https://api.github.com/users/marci543/received_events","type":"User","site_admin":false},"body":"@szarnyasg\r\nIs there a specific case when `.` must be escaped?\r\nIt seems to me that removing the escaping doesn't cause any problem.","created_at":"2018-09-09T15:36:49Z","updated_at":"2018-09-09T15:36:49Z","html_url":"https://github.com/FTSRG/ingraph/pull/367#discussion_r216160866","pull_request_url":"https://api.github.com/repos/FTSRG/ingraph/pulls/367","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/comments/216160866"},"html":{"href":"https://github.com/FTSRG/ingraph/pull/367#discussion_r216160866"},"pull_request":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/367"}}},"pull_request":{"url":"https://api.github.com/repos/FTSRG/ingraph/pulls/367","id":214118956,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTE4OTU2","html_url":"https://github.com/FTSRG/ingraph/pull/367","diff_url":"https://github.com/FTSRG/ingraph/pull/367.diff","patch_url":"https://github.com/FTSRG/ingraph/pull/367.patch","issue_url":"https://api.github.com/repos/FTSRG/ingraph/issues/367","number":367,"state":"open","locked":false,"title":"Use parsed text from query as name for unnamed columns","user":{"login":"marci543","id":17354718,"node_id":"MDQ6VXNlcjE3MzU0NzE4","avatar_url":"https://avatars0.githubusercontent.com/u/17354718?v=4","gravatar_id":"","url":"https://api.github.com/users/marci543","html_url":"https://github.com/marci543","followers_url":"https://api.github.com/users/marci543/followers","following_url":"https://api.github.com/users/marci543/following{/other_user}","gists_url":"https://api.github.com/users/marci543/gists{/gist_id}","starred_url":"https://api.github.com/users/marci543/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marci543/subscriptions","organizations_url":"https://api.github.com/users/marci543/orgs","repos_url":"https://api.github.com/users/marci543/repos","events_url":"https://api.github.com/users/marci543/events{/privacy}","received_events_url":"https://api.github.com/users/marci543/received_events","type":"User","site_admin":false},"body":"Use expression instead of `_expr` as column name if the column has no alias, e.g. `count(*)`.\r\nhttps://github.com/FTSRG/ingraph/blob/db71f51f5ead36a6c7aeee9bbb61b68c8df5b729/compiler/src/main/scala/ingraph/compiler/cypher2gplan/GPlanResolver.scala#L151\r\n\r\nTest case: https://github.com/FTSRG/ingraph/pull/367/commits/dc1cb5956e358769588da21d522e75a9e416cb00#diff-7c3111ac35db49278487e33313f7bc2fR217","created_at":"2018-09-08T23:16:00Z","updated_at":"2018-09-09T15:36:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cf3c771b554ccc458dd106e825423b0eadd7aaf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FTSRG/ingraph/pulls/367/commits","review_comments_url":"https://api.github.com/repos/FTSRG/ingraph/pulls/367/comments","review_comment_url":"https://api.github.com/repos/FTSRG/ingraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FTSRG/ingraph/issues/367/comments","statuses_url":"https://api.github.com/repos/FTSRG/ingraph/statuses/35f194d5f1823fe2f3cb760633656223d2fc3bec","head":{"label":"FTSRG:unnamed-columns","ref":"unnamed-columns","sha":"35f194d5f1823fe2f3cb760633656223d2fc3bec","user":{"login":"FTSRG","id":6715687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTU2ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/6715687?v=4","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"repo":{"id":56909416,"node_id":"MDEwOlJlcG9zaXRvcnk1NjkwOTQxNg==","name":"ingraph","full_name":"FTSRG/ingraph","owner":{"login":"FTSRG","id":6715687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTU2ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/6715687?v=4","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FTSRG/ingraph","description":"Incremental view maintenance for openCypher graph queries.","fork":false,"url":"https://api.github.com/repos/FTSRG/ingraph","forks_url":"https://api.github.com/repos/FTSRG/ingraph/forks","keys_url":"https://api.github.com/repos/FTSRG/ingraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FTSRG/ingraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FTSRG/ingraph/teams","hooks_url":"https://api.github.com/repos/FTSRG/ingraph/hooks","issue_events_url":"https://api.github.com/repos/FTSRG/ingraph/issues/events{/number}","events_url":"https://api.github.com/repos/FTSRG/ingraph/events","assignees_url":"https://api.github.com/repos/FTSRG/ingraph/assignees{/user}","branches_url":"https://api.github.com/repos/FTSRG/ingraph/branches{/branch}","tags_url":"https://api.github.com/repos/FTSRG/ingraph/tags","blobs_url":"https://api.github.com/repos/FTSRG/ingraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FTSRG/ingraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FTSRG/ingraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/FTSRG/ingraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FTSRG/ingraph/statuses/{sha}","languages_url":"https://api.github.com/repos/FTSRG/ingraph/languages","stargazers_url":"https://api.github.com/repos/FTSRG/ingraph/stargazers","contributors_url":"https://api.github.com/repos/FTSRG/ingraph/contributors","subscribers_url":"https://api.github.com/repos/FTSRG/ingraph/subscribers","subscription_url":"https://api.github.com/repos/FTSRG/ingraph/subscription","commits_url":"https://api.github.com/repos/FTSRG/ingraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/FTSRG/ingraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/FTSRG/ingraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/FTSRG/ingraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/FTSRG/ingraph/contents/{+path}","compare_url":"https://api.github.com/repos/FTSRG/ingraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FTSRG/ingraph/merges","archive_url":"https://api.github.com/repos/FTSRG/ingraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FTSRG/ingraph/downloads","issues_url":"https://api.github.com/repos/FTSRG/ingraph/issues{/number}","pulls_url":"https://api.github.com/repos/FTSRG/ingraph/pulls{/number}","milestones_url":"https://api.github.com/repos/FTSRG/ingraph/milestones{/number}","notifications_url":"https://api.github.com/repos/FTSRG/ingraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FTSRG/ingraph/labels{/name}","releases_url":"https://api.github.com/repos/FTSRG/ingraph/releases{/id}","deployments_url":"https://api.github.com/repos/FTSRG/ingraph/deployments","created_at":"2016-04-23T08:41:41Z","updated_at":"2018-08-25T08:57:53Z","pushed_at":"2018-09-09T11:37:33Z","git_url":"git://github.com/FTSRG/ingraph.git","ssh_url":"git@github.com:FTSRG/ingraph.git","clone_url":"https://github.com/FTSRG/ingraph.git","svn_url":"https://github.com/FTSRG/ingraph","homepage":"http://docs.inf.mit.bme.hu/ingraph/","size":36088,"stargazers_count":25,"watchers_count":25,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":5,"open_issues":36,"watchers":25,"default_branch":"master"}},"base":{"label":"FTSRG:master","ref":"master","sha":"9485a2020508272b4d69abda4223401f10e154bf","user":{"login":"FTSRG","id":6715687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTU2ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/6715687?v=4","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"repo":{"id":56909416,"node_id":"MDEwOlJlcG9zaXRvcnk1NjkwOTQxNg==","name":"ingraph","full_name":"FTSRG/ingraph","owner":{"login":"FTSRG","id":6715687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTU2ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/6715687?v=4","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FTSRG/ingraph","description":"Incremental view maintenance for openCypher graph queries.","fork":false,"url":"https://api.github.com/repos/FTSRG/ingraph","forks_url":"https://api.github.com/repos/FTSRG/ingraph/forks","keys_url":"https://api.github.com/repos/FTSRG/ingraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FTSRG/ingraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FTSRG/ingraph/teams","hooks_url":"https://api.github.com/repos/FTSRG/ingraph/hooks","issue_events_url":"https://api.github.com/repos/FTSRG/ingraph/issues/events{/number}","events_url":"https://api.github.com/repos/FTSRG/ingraph/events","assignees_url":"https://api.github.com/repos/FTSRG/ingraph/assignees{/user}","branches_url":"https://api.github.com/repos/FTSRG/ingraph/branches{/branch}","tags_url":"https://api.github.com/repos/FTSRG/ingraph/tags","blobs_url":"https://api.github.com/repos/FTSRG/ingraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FTSRG/ingraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FTSRG/ingraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/FTSRG/ingraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FTSRG/ingraph/statuses/{sha}","languages_url":"https://api.github.com/repos/FTSRG/ingraph/languages","stargazers_url":"https://api.github.com/repos/FTSRG/ingraph/stargazers","contributors_url":"https://api.github.com/repos/FTSRG/ingraph/contributors","subscribers_url":"https://api.github.com/repos/FTSRG/ingraph/subscribers","subscription_url":"https://api.github.com/repos/FTSRG/ingraph/subscription","commits_url":"https://api.github.com/repos/FTSRG/ingraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/FTSRG/ingraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/FTSRG/ingraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/FTSRG/ingraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/FTSRG/ingraph/contents/{+path}","compare_url":"https://api.github.com/repos/FTSRG/ingraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FTSRG/ingraph/merges","archive_url":"https://api.github.com/repos/FTSRG/ingraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FTSRG/ingraph/downloads","issues_url":"https://api.github.com/repos/FTSRG/ingraph/issues{/number}","pulls_url":"https://api.github.com/repos/FTSRG/ingraph/pulls{/number}","milestones_url":"https://api.github.com/repos/FTSRG/ingraph/milestones{/number}","notifications_url":"https://api.github.com/repos/FTSRG/ingraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FTSRG/ingraph/labels{/name}","releases_url":"https://api.github.com/repos/FTSRG/ingraph/releases{/id}","deployments_url":"https://api.github.com/repos/FTSRG/ingraph/deployments","created_at":"2016-04-23T08:41:41Z","updated_at":"2018-08-25T08:57:53Z","pushed_at":"2018-09-09T11:37:33Z","git_url":"git://github.com/FTSRG/ingraph.git","ssh_url":"git@github.com:FTSRG/ingraph.git","clone_url":"https://github.com/FTSRG/ingraph.git","svn_url":"https://github.com/FTSRG/ingraph","homepage":"http://docs.inf.mit.bme.hu/ingraph/","size":36088,"stargazers_count":25,"watchers_count":25,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":5,"open_issues":36,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/367"},"html":{"href":"https://github.com/FTSRG/ingraph/pull/367"},"issue":{"href":"https://api.github.com/repos/FTSRG/ingraph/issues/367"},"comments":{"href":"https://api.github.com/repos/FTSRG/ingraph/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/FTSRG/ingraph/statuses/35f194d5f1823fe2f3cb760633656223d2fc3bec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"marci543"}}