{"action":"created","comment":{"url":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/comments/191122010","pull_request_review_id":123635070,"id":191122010,"diff_hunk":"@@ -678,9 +699,20 @@ export default class HlsAdapter extends BaseMediaSourceAdapter {\n         HlsAdapter._logger.error(\"cannot recover, last media error recovery failed\");\n       }\n     }\n+    this._videoElement.addEventListener(EventType.LOADED_METADATA, this._onRecoveredCallback);","path":"src/hls-adapter.js","position":55,"original_position":55,"commit_id":"8a263220db8bf9ee1a302850594c4a9b32ff2c43","original_commit_id":"8a263220db8bf9ee1a302850594c4a9b32ff2c43","user":{"login":"OrenMe","id":5461862,"avatar_url":"https://avatars1.githubusercontent.com/u/5461862?v=4","gravatar_id":"","url":"https://api.github.com/users/OrenMe","html_url":"https://github.com/OrenMe","followers_url":"https://api.github.com/users/OrenMe/followers","following_url":"https://api.github.com/users/OrenMe/following{/other_user}","gists_url":"https://api.github.com/users/OrenMe/gists{/gist_id}","starred_url":"https://api.github.com/users/OrenMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrenMe/subscriptions","organizations_url":"https://api.github.com/users/OrenMe/orgs","repos_url":"https://api.github.com/users/OrenMe/repos","events_url":"https://api.github.com/users/OrenMe/events{/privacy}","received_events_url":"https://api.github.com/users/OrenMe/received_events","type":"User","site_admin":false},"body":"@odedhutzler you would want to this only `if (recover) { ... }`.\r\n\r\nActually, because we only add the listener after we call `_recoverDecodingError` or `_recoverSwapAudioCodec` there's a chance that this might not even pick up, so better return this to be inlined twice, above and before each call to the recover handlers","created_at":"2018-05-28T06:37:15Z","updated_at":"2018-05-28T06:37:19Z","html_url":"https://github.com/kaltura/playkit-js-hls/pull/61#discussion_r191122010","pull_request_url":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/61","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/comments/191122010"},"html":{"href":"https://github.com/kaltura/playkit-js-hls/pull/61#discussion_r191122010"},"pull_request":{"href":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/61","id":189941523,"html_url":"https://github.com/kaltura/playkit-js-hls/pull/61","diff_url":"https://github.com/kaltura/playkit-js-hls/pull/61.diff","patch_url":"https://github.com/kaltura/playkit-js-hls/pull/61.patch","issue_url":"https://api.github.com/repos/kaltura/playkit-js-hls/issues/61","number":61,"state":"open","locked":false,"title":"fix(FEC-8233): handle media & error recovering","user":{"login":"odedhutzler","id":31587052,"avatar_url":"https://avatars2.githubusercontent.com/u/31587052?v=4","gravatar_id":"","url":"https://api.github.com/users/odedhutzler","html_url":"https://github.com/odedhutzler","followers_url":"https://api.github.com/users/odedhutzler/followers","following_url":"https://api.github.com/users/odedhutzler/following{/other_user}","gists_url":"https://api.github.com/users/odedhutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/odedhutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedhutzler/subscriptions","organizations_url":"https://api.github.com/users/odedhutzler/orgs","repos_url":"https://api.github.com/users/odedhutzler/repos","events_url":"https://api.github.com/users/odedhutzler/events{/privacy}","received_events_url":"https://api.github.com/users/odedhutzler/received_events","type":"User","site_admin":false},"body":"If the media recovered successfully, trigger media recovered event\r\n\r\n### CheckLists\r\n\r\n- [ ] changes have been done against master branch, and PR does not conflict\r\n- [ ] new unit / functional tests have been added (whenever applicable)\r\n- [ ] test are passing in local environment \r\n- [ ] Travis tests are passing (or test results are not worse than on master branch :))\r\n- [ ] Docs have been updated\r\n","created_at":"2018-05-23T11:24:49Z","updated_at":"2018-05-28T06:37:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e733bb6fe4d9d7fa09edc6ee9f2653123d933e9","assignee":{"login":"odedhutzler","id":31587052,"avatar_url":"https://avatars2.githubusercontent.com/u/31587052?v=4","gravatar_id":"","url":"https://api.github.com/users/odedhutzler","html_url":"https://github.com/odedhutzler","followers_url":"https://api.github.com/users/odedhutzler/followers","following_url":"https://api.github.com/users/odedhutzler/following{/other_user}","gists_url":"https://api.github.com/users/odedhutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/odedhutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedhutzler/subscriptions","organizations_url":"https://api.github.com/users/odedhutzler/orgs","repos_url":"https://api.github.com/users/odedhutzler/repos","events_url":"https://api.github.com/users/odedhutzler/events{/privacy}","received_events_url":"https://api.github.com/users/odedhutzler/received_events","type":"User","site_admin":false},"assignees":[{"login":"odedhutzler","id":31587052,"avatar_url":"https://avatars2.githubusercontent.com/u/31587052?v=4","gravatar_id":"","url":"https://api.github.com/users/odedhutzler","html_url":"https://github.com/odedhutzler","followers_url":"https://api.github.com/users/odedhutzler/followers","following_url":"https://api.github.com/users/odedhutzler/following{/other_user}","gists_url":"https://api.github.com/users/odedhutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/odedhutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedhutzler/subscriptions","organizations_url":"https://api.github.com/users/odedhutzler/orgs","repos_url":"https://api.github.com/users/odedhutzler/repos","events_url":"https://api.github.com/users/odedhutzler/events{/privacy}","received_events_url":"https://api.github.com/users/odedhutzler/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"yairans","id":17685520,"avatar_url":"https://avatars3.githubusercontent.com/u/17685520?v=4","gravatar_id":"","url":"https://api.github.com/users/yairans","html_url":"https://github.com/yairans","followers_url":"https://api.github.com/users/yairans/followers","following_url":"https://api.github.com/users/yairans/following{/other_user}","gists_url":"https://api.github.com/users/yairans/gists{/gist_id}","starred_url":"https://api.github.com/users/yairans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yairans/subscriptions","organizations_url":"https://api.github.com/users/yairans/orgs","repos_url":"https://api.github.com/users/yairans/repos","events_url":"https://api.github.com/users/yairans/events{/privacy}","received_events_url":"https://api.github.com/users/yairans/received_events","type":"User","site_admin":false},{"login":"dan-ziv","id":21081590,"avatar_url":"https://avatars2.githubusercontent.com/u/21081590?v=4","gravatar_id":"","url":"https://api.github.com/users/dan-ziv","html_url":"https://github.com/dan-ziv","followers_url":"https://api.github.com/users/dan-ziv/followers","following_url":"https://api.github.com/users/dan-ziv/following{/other_user}","gists_url":"https://api.github.com/users/dan-ziv/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-ziv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-ziv/subscriptions","organizations_url":"https://api.github.com/users/dan-ziv/orgs","repos_url":"https://api.github.com/users/dan-ziv/repos","events_url":"https://api.github.com/users/dan-ziv/events{/privacy}","received_events_url":"https://api.github.com/users/dan-ziv/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/61/commits","review_comments_url":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/61/comments","review_comment_url":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/playkit-js-hls/issues/61/comments","statuses_url":"https://api.github.com/repos/kaltura/playkit-js-hls/statuses/8a263220db8bf9ee1a302850594c4a9b32ff2c43","head":{"label":"kaltura:FEC-8233","ref":"FEC-8233","sha":"8a263220db8bf9ee1a302850594c4a9b32ff2c43","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":83971648,"name":"playkit-js-hls","full_name":"kaltura/playkit-js-hls","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/playkit-js-hls","description":" HLS.JS Adapter for the PlayKit JS Player","fork":false,"url":"https://api.github.com/repos/kaltura/playkit-js-hls","forks_url":"https://api.github.com/repos/kaltura/playkit-js-hls/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-js-hls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-js-hls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-js-hls/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-js-hls/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-js-hls/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-js-hls/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-js-hls/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-js-hls/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-js-hls/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-js-hls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-js-hls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-js-hls/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-js-hls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-js-hls/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-js-hls/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-js-hls/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-js-hls/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-js-hls/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-js-hls/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-js-hls/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-js-hls/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-js-hls/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-js-hls/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-js-hls/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-js-hls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-js-hls/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-js-hls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-js-hls/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-js-hls/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-js-hls/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-js-hls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-js-hls/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-js-hls/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-js-hls/deployments","created_at":"2017-03-05T13:23:28Z","updated_at":"2018-05-10T10:22:16Z","pushed_at":"2018-05-24T06:42:37Z","git_url":"git://github.com/kaltura/playkit-js-hls.git","ssh_url":"git@github.com:kaltura/playkit-js-hls.git","clone_url":"https://github.com/kaltura/playkit-js-hls.git","svn_url":"https://github.com/kaltura/playkit-js-hls","homepage":"","size":1102,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"kaltura:master","ref":"master","sha":"3aa9febc59bdd58f2f9277193b87266b3fbc0552","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":83971648,"name":"playkit-js-hls","full_name":"kaltura/playkit-js-hls","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/playkit-js-hls","description":" HLS.JS Adapter for the PlayKit JS Player","fork":false,"url":"https://api.github.com/repos/kaltura/playkit-js-hls","forks_url":"https://api.github.com/repos/kaltura/playkit-js-hls/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-js-hls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-js-hls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-js-hls/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-js-hls/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-js-hls/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-js-hls/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-js-hls/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-js-hls/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-js-hls/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-js-hls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-js-hls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-js-hls/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-js-hls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-js-hls/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-js-hls/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-js-hls/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-js-hls/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-js-hls/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-js-hls/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-js-hls/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-js-hls/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-js-hls/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-js-hls/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-js-hls/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-js-hls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-js-hls/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-js-hls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-js-hls/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-js-hls/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-js-hls/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-js-hls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-js-hls/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-js-hls/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-js-hls/deployments","created_at":"2017-03-05T13:23:28Z","updated_at":"2018-05-10T10:22:16Z","pushed_at":"2018-05-24T06:42:37Z","git_url":"git://github.com/kaltura/playkit-js-hls.git","ssh_url":"git@github.com:kaltura/playkit-js-hls.git","clone_url":"https://github.com/kaltura/playkit-js-hls.git","svn_url":"https://github.com/kaltura/playkit-js-hls","homepage":"","size":1102,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/61"},"html":{"href":"https://github.com/kaltura/playkit-js-hls/pull/61"},"issue":{"href":"https://api.github.com/repos/kaltura/playkit-js-hls/issues/61"},"comments":{"href":"https://api.github.com/repos/kaltura/playkit-js-hls/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/playkit-js-hls/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/playkit-js-hls/statuses/8a263220db8bf9ee1a302850594c4a9b32ff2c43"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"OrenMe"}}