{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1063","repository_url":"https://api.github.com/repos/kubernetes-incubator/cri-o","labels_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1063/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1063/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1063/events","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1063","id":268222736,"number":1063,"title":"Revert Revert \"Idempotent Swapping\"","user":{"login":"cevich","id":1183438,"avatar_url":"https://avatars2.githubusercontent.com/u/1183438?v=4","gravatar_id":"","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"labels":[{"id":484626496,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":676478956,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels/size/L","name":"size/L","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2017-10-24T23:45:56Z","updated_at":"2018-02-05T14:26:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1063","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1063","diff_url":"https://github.com/kubernetes-incubator/cri-o/pull/1063.diff","patch_url":"https://github.com/kubernetes-incubator/cri-o/pull/1063.patch"},"body":"This puts back the better qualified Idempotent Swapping, but\r\nadds two variables which control whether or not swapping is\r\nenabled during testing.  This addresses a short-term issue of\r\noccasionally failing integration tests under some scenarios,\r\nbut not others.\r\n\r\nThe integration OOM-test isn't properly failing because\r\nthe cgroup memory control doesn't account for swap usage\r\n(by design) in ``limit_in_bytes``.\r\n\r\nFixing this for the long-term requires repairing the\r\ntest to also set ``memory.memsw.limit_in_bytes=0``\r\n(in addition to memory.limit_in_bytes=5m).\r\n\r\nN/B: Normally these things are passed down from k8s,\r\nwhich is why the same fix isn't currently needed\r\nfor the e2e tests - hence the new variable is ``True`` by\r\ndefault.\r\n\r\nSigned-off-by: Chris Evich <cevich@redhat.com>"},"comment":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/comments/363099573","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1063#issuecomment-363099573","issue_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1063","id":363099573,"user":{"login":"cevich","id":1183438,"avatar_url":"https://avatars2.githubusercontent.com/u/1183438?v=4","gravatar_id":"","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T14:26:49Z","updated_at":"2018-02-05T14:26:49Z","author_association":"CONTRIBUTOR","body":"thinking..."}}
{"actor":{"display_login":"cevich"}}