{"action":"closed","number":11625,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/11625","id":147970475,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQ3OTcwNDc1","html_url":"https://github.com/magento/magento2/pull/11625","diff_url":"https://github.com/magento/magento2/pull/11625.diff","patch_url":"https://github.com/magento/magento2/pull/11625.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/11625","number":11625,"state":"closed","locked":false,"title":"Remove \"Undefined fields\" from app folder","user":{"login":"adrian-martinez-interactiv4","id":17545750,"node_id":"MDQ6VXNlcjE3NTQ1NzUw","avatar_url":"https://avatars1.githubusercontent.com/u/17545750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-martinez-interactiv4","html_url":"https://github.com/adrian-martinez-interactiv4","followers_url":"https://api.github.com/users/adrian-martinez-interactiv4/followers","following_url":"https://api.github.com/users/adrian-martinez-interactiv4/following{/other_user}","gists_url":"https://api.github.com/users/adrian-martinez-interactiv4/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-martinez-interactiv4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-martinez-interactiv4/subscriptions","organizations_url":"https://api.github.com/users/adrian-martinez-interactiv4/orgs","repos_url":"https://api.github.com/users/adrian-martinez-interactiv4/repos","events_url":"https://api.github.com/users/adrian-martinez-interactiv4/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-martinez-interactiv4/received_events","type":"User","site_admin":false},"body":"Remove \"Undefined fields\" from app folder\r\n\r\n### Description\r\nThis PR adds missing properties to class, and optimize / reorder imports, under app folder.\r\n\r\n### Fixed Issues (if relevant)\r\nNone, improvement, since it's not really a problem, it makes no sense to backport it.\r\n\r\n### Manual testing scenarios\r\n<img width=\"720\" alt=\"captura de pantalla 2017-10-22 a las 3 13 02\" src=\"https://user-images.githubusercontent.com/17545750/31857180-84cea256-b6d7-11e7-8c9c-f9d66167d3cd.png\">\r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2017-10-22T01:18:36Z","updated_at":"2018-08-28T09:54:26Z","closed_at":"2018-08-28T09:54:26Z","merged_at":null,"merge_commit_sha":"3ef780018a196800267dcc0158f2e81107032660","assignee":{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},"assignees":[{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},{"login":"ihor-sviziev","id":1873745,"node_id":"MDQ6VXNlcjE4NzM3NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1873745?v=4","gravatar_id":"","url":"https://api.github.com/users/ihor-sviziev","html_url":"https://github.com/ihor-sviziev","followers_url":"https://api.github.com/users/ihor-sviziev/followers","following_url":"https://api.github.com/users/ihor-sviziev/following{/other_user}","gists_url":"https://api.github.com/users/ihor-sviziev/gists{/gist_id}","starred_url":"https://api.github.com/users/ihor-sviziev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihor-sviziev/subscriptions","organizations_url":"https://api.github.com/users/ihor-sviziev/orgs","repos_url":"https://api.github.com/users/ihor-sviziev/repos","events_url":"https://api.github.com/users/ihor-sviziev/events{/privacy}","received_events_url":"https://api.github.com/users/ihor-sviziev/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":428739444,"node_id":"MDU6TGFiZWw0Mjg3Mzk0NDQ=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Config","name":"Component: Config","color":"7fb703","default":false},{"id":883455843,"node_id":"MDU6TGFiZWw4ODM0NTU4NDM=","url":"https://api.github.com/repos/magento/magento2/labels/Partner:%20Interactiv4","name":"Partner: Interactiv4","color":"f9d0c4","default":false},{"id":161563561,"node_id":"MDU6TGFiZWwxNjE1NjM1NjE=","url":"https://api.github.com/repos/magento/magento2/labels/Progress:%20needs%20update","name":"Progress: needs update","color":"b60205","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false},{"id":882948356,"node_id":"MDU6TGFiZWw4ODI5NDgzNTY=","url":"https://api.github.com/repos/magento/magento2/labels/partners-contribution","name":"partners-contribution","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/11625/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/11625/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/11625/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/85bd65c93355220ec5dbbbd4aa8865d6751fe4ef","head":{"label":"adrian-martinez-interactiv4:FR#THEME-INDEXER-DECLARE-DATA-CLASS-PROPERTY","ref":"FR#THEME-INDEXER-DECLARE-DATA-CLASS-PROPERTY","sha":"85bd65c93355220ec5dbbbd4aa8865d6751fe4ef","user":{"login":"adrian-martinez-interactiv4","id":17545750,"node_id":"MDQ6VXNlcjE3NTQ1NzUw","avatar_url":"https://avatars1.githubusercontent.com/u/17545750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-martinez-interactiv4","html_url":"https://github.com/adrian-martinez-interactiv4","followers_url":"https://api.github.com/users/adrian-martinez-interactiv4/followers","following_url":"https://api.github.com/users/adrian-martinez-interactiv4/following{/other_user}","gists_url":"https://api.github.com/users/adrian-martinez-interactiv4/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-martinez-interactiv4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-martinez-interactiv4/subscriptions","organizations_url":"https://api.github.com/users/adrian-martinez-interactiv4/orgs","repos_url":"https://api.github.com/users/adrian-martinez-interactiv4/repos","events_url":"https://api.github.com/users/adrian-martinez-interactiv4/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-martinez-interactiv4/received_events","type":"User","site_admin":false},"repo":{"id":89414464,"node_id":"MDEwOlJlcG9zaXRvcnk4OTQxNDQ2NA==","name":"magento2","full_name":"adrian-martinez-interactiv4/magento2","owner":{"login":"adrian-martinez-interactiv4","id":17545750,"node_id":"MDQ6VXNlcjE3NTQ1NzUw","avatar_url":"https://avatars1.githubusercontent.com/u/17545750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-martinez-interactiv4","html_url":"https://github.com/adrian-martinez-interactiv4","followers_url":"https://api.github.com/users/adrian-martinez-interactiv4/followers","following_url":"https://api.github.com/users/adrian-martinez-interactiv4/following{/other_user}","gists_url":"https://api.github.com/users/adrian-martinez-interactiv4/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-martinez-interactiv4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-martinez-interactiv4/subscriptions","organizations_url":"https://api.github.com/users/adrian-martinez-interactiv4/orgs","repos_url":"https://api.github.com/users/adrian-martinez-interactiv4/repos","events_url":"https://api.github.com/users/adrian-martinez-interactiv4/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-martinez-interactiv4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrian-martinez-interactiv4/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2","forks_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/forks","keys_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/teams","hooks_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/hooks","issue_events_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/events","assignees_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/tags","blobs_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/languages","stargazers_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/stargazers","contributors_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/contributors","subscribers_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/subscribers","subscription_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/subscription","commits_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/merges","archive_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/downloads","issues_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/labels{/name}","releases_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/deployments","created_at":"2017-04-25T23:01:10Z","updated_at":"2018-02-06T01:27:06Z","pushed_at":"2018-08-13T02:05:53Z","git_url":"git://github.com/adrian-martinez-interactiv4/magento2.git","ssh_url":"git@github.com:adrian-martinez-interactiv4/magento2.git","clone_url":"https://github.com/adrian-martinez-interactiv4/magento2.git","svn_url":"https://github.com/adrian-martinez-interactiv4/magento2","homepage":"http://www.magento.com","size":463936,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":15,"watchers":1,"default_branch":"develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"c6e891d69ecae47138f699dd2da811a433b5c5be","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"node_id":"MDEwOlJlcG9zaXRvcnkyODg0MTEx","name":"magento2","full_name":"magento/magento2","owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-08-28T09:46:59Z","pushed_at":"2018-08-28T09:46:18Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":478151,"stargazers_count":5991,"watchers_count":5991,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5142,"mirror_url":null,"archived":false,"open_issues_count":1278,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5142,"open_issues":1278,"watchers":5991,"default_branch":"2.2-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/11625"},"html":{"href":"https://github.com/magento/magento2/pull/11625"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/11625"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/11625/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/11625/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/11625/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/85bd65c93355220ec5dbbbd4aa8865d6751fe4ef"}},"author_association":"COLLABORATOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":11,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1138,"deletions":223,"changed_files":147}}
{"actor":{"display_login":"sidolov"}}