{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/204044680","pull_request_review_id":139057325,"id":204044680,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDA0NDY4MA==","diff_hunk":"@@ -37,7 +37,7 @@ def verify_pickle(self, indices):\n     def test_pickle_compat_construction(self):\n         # this is testing for pickle compat\n         if self._holder is None:\n-            return","path":"pandas/tests/indexes/common.py","position":4,"original_position":4,"commit_id":"7f74578b2df971d5b1d104781b4eeb2273446181","original_commit_id":"7f74578b2df971d5b1d104781b4eeb2273446181","user":{"login":"h-vetinari","id":33685575,"node_id":"MDQ6VXNlcjMzNjg1NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"body":"I don't know, I didn't write these tests, and the inner workings of `indexes/common.py` are not immediately apparent (which files call it, what do they fill `indices` with, etc.).","created_at":"2018-07-20T13:32:03Z","updated_at":"2018-07-20T13:32:03Z","html_url":"https://github.com/pandas-dev/pandas/pull/21902#discussion_r204044680","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21902","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/204044680"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/21902#discussion_r204044680"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21902"}},"in_reply_to_id":204036205},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21902","id":201403086,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDAzMDg2","html_url":"https://github.com/pandas-dev/pandas/pull/21902","diff_url":"https://github.com/pandas-dev/pandas/pull/21902.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/21902.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21902","number":21902,"state":"open","locked":false,"title":"TST/CLN: correctly skip in indexes/common; add test for duplicated","user":{"login":"h-vetinari","id":33685575,"node_id":"MDQ6VXNlcjMzNjg1NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"body":"Splitting up #21645 \r\n\r\n* Added tests for `duplicated`\r\n* Following https://github.com/pandas-dev/pandas/pull/21645#discussion_r202192191, turned several blank `return` statements (which falsely pass the test)  into `pytest.skip`.\r\n","created_at":"2018-07-13T21:20:41Z","updated_at":"2018-07-20T13:32:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2d084ba3e3b2b57fa9d199688cf19f9be201663","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":127685,"node_id":"MDU6TGFiZWwxMjc2ODU=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Testing","name":"Testing","color":"C4A000","default":false}],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55","html_url":"https://github.com/pandas-dev/pandas/milestone/55","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55/labels","id":3228419,"node_id":"MDk6TWlsZXN0b25lMzIyODQxOQ==","number":55,"title":"0.24.0","description":"","creator":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"open_issues":101,"closed_issues":310,"state":"open","created_at":"2018-03-29T12:00:12Z","updated_at":"2018-07-20T13:29:26Z","due_on":"2018-08-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21902/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21902/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21902/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/7f74578b2df971d5b1d104781b4eeb2273446181","head":{"label":"h-vetinari:tst_index_common_skip","ref":"tst_index_common_skip","sha":"7f74578b2df971d5b1d104781b4eeb2273446181","user":{"login":"h-vetinari","id":33685575,"node_id":"MDQ6VXNlcjMzNjg1NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"repo":{"id":125207159,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyMDcxNTk=","name":"pandas","full_name":"h-vetinari/pandas","owner":{"login":"h-vetinari","id":33685575,"node_id":"MDQ6VXNlcjMzNjg1NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/h-vetinari/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/h-vetinari/pandas","forks_url":"https://api.github.com/repos/h-vetinari/pandas/forks","keys_url":"https://api.github.com/repos/h-vetinari/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h-vetinari/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h-vetinari/pandas/teams","hooks_url":"https://api.github.com/repos/h-vetinari/pandas/hooks","issue_events_url":"https://api.github.com/repos/h-vetinari/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/h-vetinari/pandas/events","assignees_url":"https://api.github.com/repos/h-vetinari/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/h-vetinari/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/h-vetinari/pandas/tags","blobs_url":"https://api.github.com/repos/h-vetinari/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h-vetinari/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h-vetinari/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/h-vetinari/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h-vetinari/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/h-vetinari/pandas/languages","stargazers_url":"https://api.github.com/repos/h-vetinari/pandas/stargazers","contributors_url":"https://api.github.com/repos/h-vetinari/pandas/contributors","subscribers_url":"https://api.github.com/repos/h-vetinari/pandas/subscribers","subscription_url":"https://api.github.com/repos/h-vetinari/pandas/subscription","commits_url":"https://api.github.com/repos/h-vetinari/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/h-vetinari/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/h-vetinari/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/h-vetinari/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/h-vetinari/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/h-vetinari/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h-vetinari/pandas/merges","archive_url":"https://api.github.com/repos/h-vetinari/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h-vetinari/pandas/downloads","issues_url":"https://api.github.com/repos/h-vetinari/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/h-vetinari/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/h-vetinari/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/h-vetinari/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h-vetinari/pandas/labels{/name}","releases_url":"https://api.github.com/repos/h-vetinari/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/h-vetinari/pandas/deployments","created_at":"2018-03-14T12:12:19Z","updated_at":"2018-07-16T13:00:20Z","pushed_at":"2018-07-17T07:19:32Z","git_url":"git://github.com/h-vetinari/pandas.git","ssh_url":"git@github.com:h-vetinari/pandas.git","clone_url":"https://github.com/h-vetinari/pandas.git","svn_url":"https://github.com/h-vetinari/pandas","homepage":"http://pandas.pydata.org","size":127167,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"272bbdc72fa2d32d7019bb76ab91817eb5afeaf5","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-07-20T13:30:08Z","pushed_at":"2018-07-20T13:29:27Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":127778,"stargazers_count":15177,"watchers_count":15177,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6111,"mirror_url":null,"archived":false,"open_issues_count":2636,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6111,"open_issues":2636,"watchers":15177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21902"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/21902"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/21902"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/21902/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21902/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21902/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/7f74578b2df971d5b1d104781b4eeb2273446181"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"h-vetinari"}}