{"action":"created","comment":{"url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/comments/185716948","pull_request_review_id":117160767,"id":185716948,"diff_hunk":"@@ -3,7 +3,8 @@\n int main(int argc, char **argv)\n {\n   ros::init(argc, argv, \"autopilot\");\n-  autopilot::AutoPilot autopilot;\n+  autopilot::AutoPilot<position_controller::PositionController,","path":"control/autopilot/src/autopilot_node.cpp","position":5,"original_position":5,"commit_id":"d6dd6ab60cee868567478ed8409a32efa25bffff","original_commit_id":"d6dd6ab60cee868567478ed8409a32efa25bffff","user":{"login":"foehnph","id":17403970,"avatar_url":"https://avatars2.githubusercontent.com/u/17403970?v=4","gravatar_id":"","url":"https://api.github.com/users/foehnph","html_url":"https://github.com/foehnph","followers_url":"https://api.github.com/users/foehnph/followers","following_url":"https://api.github.com/users/foehnph/following{/other_user}","gists_url":"https://api.github.com/users/foehnph/gists{/gist_id}","starred_url":"https://api.github.com/users/foehnph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foehnph/subscriptions","organizations_url":"https://api.github.com/users/foehnph/orgs","repos_url":"https://api.github.com/users/foehnph/repos","events_url":"https://api.github.com/users/foehnph/events{/privacy}","received_events_url":"https://api.github.com/users/foehnph/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-05-03T07:45:53Z","updated_at":"2018-05-03T07:45:54Z","html_url":"https://github.com/uzh-rpg/rpg_quadrotor_control/pull/60#discussion_r185716948","pull_request_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/60","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/comments/185716948"},"html":{"href":"https://github.com/uzh-rpg/rpg_quadrotor_control/pull/60#discussion_r185716948"},"pull_request":{"href":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/60"}},"in_reply_to_id":184299802},"pull_request":{"url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/60","id":184054558,"html_url":"https://github.com/uzh-rpg/rpg_quadrotor_control/pull/60","diff_url":"https://github.com/uzh-rpg/rpg_quadrotor_control/pull/60.diff","patch_url":"https://github.com/uzh-rpg/rpg_quadrotor_control/pull/60.patch","issue_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/issues/60","number":60,"state":"open","locked":false,"title":"Bring MPC to the new flight stack","user":{"login":"foehnph","id":17403970,"avatar_url":"https://avatars2.githubusercontent.com/u/17403970?v=4","gravatar_id":"","url":"https://api.github.com/users/foehnph","html_url":"https://github.com/foehnph","followers_url":"https://api.github.com/users/foehnph/followers","following_url":"https://api.github.com/users/foehnph/following{/other_user}","gists_url":"https://api.github.com/users/foehnph/gists{/gist_id}","starred_url":"https://api.github.com/users/foehnph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foehnph/subscriptions","organizations_url":"https://api.github.com/users/foehnph/orgs","repos_url":"https://api.github.com/users/foehnph/repos","events_url":"https://api.github.com/users/foehnph/events{/privacy}","received_events_url":"https://api.github.com/users/foehnph/received_events","type":"User","site_admin":false},"body":"I made some changes to allow compatibility with our new MPC.\r\nIt includes mainly templating the autopilot on the controller type and parameter type, which requires the autopilot.cpp to move to the header file, solved as a head include.\r\n\r\nFurther changes were also mentioned in #5 and we concluded that references are always given in the form of a `Trajectory` (and no longer `TrajectoryPoint`) to the controller.\r\nThe position controller would then just take the first point in it, while the MPC can use the first (for a single reference) or a whole lookahead on a trajectory.\r\n\r\nI made several changes and would be happy to hear your comments.\r\n\r\n@internals: also take a look at: https://github.com/uzh-rpg/rpg_mpc/pull/5","created_at":"2018-04-25T14:25:54Z","updated_at":"2018-05-03T07:45:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78b836fc28a2d573cfc5b35753959f05f5d8c208","assignee":{"login":"foehnph","id":17403970,"avatar_url":"https://avatars2.githubusercontent.com/u/17403970?v=4","gravatar_id":"","url":"https://api.github.com/users/foehnph","html_url":"https://github.com/foehnph","followers_url":"https://api.github.com/users/foehnph/followers","following_url":"https://api.github.com/users/foehnph/following{/other_user}","gists_url":"https://api.github.com/users/foehnph/gists{/gist_id}","starred_url":"https://api.github.com/users/foehnph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foehnph/subscriptions","organizations_url":"https://api.github.com/users/foehnph/orgs","repos_url":"https://api.github.com/users/foehnph/repos","events_url":"https://api.github.com/users/foehnph/events{/privacy}","received_events_url":"https://api.github.com/users/foehnph/received_events","type":"User","site_admin":false},"assignees":[{"login":"foehnph","id":17403970,"avatar_url":"https://avatars2.githubusercontent.com/u/17403970?v=4","gravatar_id":"","url":"https://api.github.com/users/foehnph","html_url":"https://github.com/foehnph","followers_url":"https://api.github.com/users/foehnph/followers","following_url":"https://api.github.com/users/foehnph/following{/other_user}","gists_url":"https://api.github.com/users/foehnph/gists{/gist_id}","starred_url":"https://api.github.com/users/foehnph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foehnph/subscriptions","organizations_url":"https://api.github.com/users/foehnph/orgs","repos_url":"https://api.github.com/users/foehnph/repos","events_url":"https://api.github.com/users/foehnph/events{/privacy}","received_events_url":"https://api.github.com/users/foehnph/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tcies","id":4147796,"avatar_url":"https://avatars0.githubusercontent.com/u/4147796?v=4","gravatar_id":"","url":"https://api.github.com/users/tcies","html_url":"https://github.com/tcies","followers_url":"https://api.github.com/users/tcies/followers","following_url":"https://api.github.com/users/tcies/following{/other_user}","gists_url":"https://api.github.com/users/tcies/gists{/gist_id}","starred_url":"https://api.github.com/users/tcies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcies/subscriptions","organizations_url":"https://api.github.com/users/tcies/orgs","repos_url":"https://api.github.com/users/tcies/repos","events_url":"https://api.github.com/users/tcies/events{/privacy}","received_events_url":"https://api.github.com/users/tcies/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":779892624,"url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/60/commits","review_comments_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/60/comments","review_comment_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/issues/60/comments","statuses_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/statuses/d6dd6ab60cee868567478ed8409a32efa25bffff","head":{"label":"uzh-rpg:dev/new_interface","ref":"dev/new_interface","sha":"d6dd6ab60cee868567478ed8409a32efa25bffff","user":{"login":"uzh-rpg","id":1941290,"avatar_url":"https://avatars2.githubusercontent.com/u/1941290?v=4","gravatar_id":"","url":"https://api.github.com/users/uzh-rpg","html_url":"https://github.com/uzh-rpg","followers_url":"https://api.github.com/users/uzh-rpg/followers","following_url":"https://api.github.com/users/uzh-rpg/following{/other_user}","gists_url":"https://api.github.com/users/uzh-rpg/gists{/gist_id}","starred_url":"https://api.github.com/users/uzh-rpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uzh-rpg/subscriptions","organizations_url":"https://api.github.com/users/uzh-rpg/orgs","repos_url":"https://api.github.com/users/uzh-rpg/repos","events_url":"https://api.github.com/users/uzh-rpg/events{/privacy}","received_events_url":"https://api.github.com/users/uzh-rpg/received_events","type":"Organization","site_admin":false},"repo":{"id":114392520,"name":"rpg_quadrotor_control","full_name":"uzh-rpg/rpg_quadrotor_control","owner":{"login":"uzh-rpg","id":1941290,"avatar_url":"https://avatars2.githubusercontent.com/u/1941290?v=4","gravatar_id":"","url":"https://api.github.com/users/uzh-rpg","html_url":"https://github.com/uzh-rpg","followers_url":"https://api.github.com/users/uzh-rpg/followers","following_url":"https://api.github.com/users/uzh-rpg/following{/other_user}","gists_url":"https://api.github.com/users/uzh-rpg/gists{/gist_id}","starred_url":"https://api.github.com/users/uzh-rpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uzh-rpg/subscriptions","organizations_url":"https://api.github.com/users/uzh-rpg/orgs","repos_url":"https://api.github.com/users/uzh-rpg/repos","events_url":"https://api.github.com/users/uzh-rpg/events{/privacy}","received_events_url":"https://api.github.com/users/uzh-rpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uzh-rpg/rpg_quadrotor_control","description":"Quadrotor control framework developed by the Robotics and Perception Group","fork":false,"url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control","forks_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/forks","keys_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/teams","hooks_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/hooks","issue_events_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/issues/events{/number}","events_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/events","assignees_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/assignees{/user}","branches_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/branches{/branch}","tags_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/tags","blobs_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/git/refs{/sha}","trees_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/statuses/{sha}","languages_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/languages","stargazers_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/stargazers","contributors_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/contributors","subscribers_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/subscribers","subscription_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/subscription","commits_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/commits{/sha}","git_commits_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/git/commits{/sha}","comments_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/comments{/number}","issue_comment_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/issues/comments{/number}","contents_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/contents/{+path}","compare_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/merges","archive_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/downloads","issues_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/issues{/number}","pulls_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls{/number}","milestones_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/milestones{/number}","notifications_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/labels{/name}","releases_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/releases{/id}","deployments_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/deployments","created_at":"2017-12-15T16:51:51Z","updated_at":"2018-05-02T16:30:39Z","pushed_at":"2018-05-02T18:52:05Z","git_url":"git://github.com/uzh-rpg/rpg_quadrotor_control.git","ssh_url":"git@github.com:uzh-rpg/rpg_quadrotor_control.git","clone_url":"https://github.com/uzh-rpg/rpg_quadrotor_control.git","svn_url":"https://github.com/uzh-rpg/rpg_quadrotor_control","homepage":"","size":6805,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7,"open_issues":4,"watchers":27,"default_branch":"master"}},"base":{"label":"uzh-rpg:master","ref":"master","sha":"a77a60885641af05b1ea91468afba4cb24e3db85","user":{"login":"uzh-rpg","id":1941290,"avatar_url":"https://avatars2.githubusercontent.com/u/1941290?v=4","gravatar_id":"","url":"https://api.github.com/users/uzh-rpg","html_url":"https://github.com/uzh-rpg","followers_url":"https://api.github.com/users/uzh-rpg/followers","following_url":"https://api.github.com/users/uzh-rpg/following{/other_user}","gists_url":"https://api.github.com/users/uzh-rpg/gists{/gist_id}","starred_url":"https://api.github.com/users/uzh-rpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uzh-rpg/subscriptions","organizations_url":"https://api.github.com/users/uzh-rpg/orgs","repos_url":"https://api.github.com/users/uzh-rpg/repos","events_url":"https://api.github.com/users/uzh-rpg/events{/privacy}","received_events_url":"https://api.github.com/users/uzh-rpg/received_events","type":"Organization","site_admin":false},"repo":{"id":114392520,"name":"rpg_quadrotor_control","full_name":"uzh-rpg/rpg_quadrotor_control","owner":{"login":"uzh-rpg","id":1941290,"avatar_url":"https://avatars2.githubusercontent.com/u/1941290?v=4","gravatar_id":"","url":"https://api.github.com/users/uzh-rpg","html_url":"https://github.com/uzh-rpg","followers_url":"https://api.github.com/users/uzh-rpg/followers","following_url":"https://api.github.com/users/uzh-rpg/following{/other_user}","gists_url":"https://api.github.com/users/uzh-rpg/gists{/gist_id}","starred_url":"https://api.github.com/users/uzh-rpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uzh-rpg/subscriptions","organizations_url":"https://api.github.com/users/uzh-rpg/orgs","repos_url":"https://api.github.com/users/uzh-rpg/repos","events_url":"https://api.github.com/users/uzh-rpg/events{/privacy}","received_events_url":"https://api.github.com/users/uzh-rpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uzh-rpg/rpg_quadrotor_control","description":"Quadrotor control framework developed by the Robotics and Perception Group","fork":false,"url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control","forks_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/forks","keys_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/teams","hooks_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/hooks","issue_events_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/issues/events{/number}","events_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/events","assignees_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/assignees{/user}","branches_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/branches{/branch}","tags_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/tags","blobs_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/git/refs{/sha}","trees_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/statuses/{sha}","languages_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/languages","stargazers_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/stargazers","contributors_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/contributors","subscribers_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/subscribers","subscription_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/subscription","commits_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/commits{/sha}","git_commits_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/git/commits{/sha}","comments_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/comments{/number}","issue_comment_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/issues/comments{/number}","contents_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/contents/{+path}","compare_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/merges","archive_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/downloads","issues_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/issues{/number}","pulls_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls{/number}","milestones_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/milestones{/number}","notifications_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/labels{/name}","releases_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/releases{/id}","deployments_url":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/deployments","created_at":"2017-12-15T16:51:51Z","updated_at":"2018-05-02T16:30:39Z","pushed_at":"2018-05-02T18:52:05Z","git_url":"git://github.com/uzh-rpg/rpg_quadrotor_control.git","ssh_url":"git@github.com:uzh-rpg/rpg_quadrotor_control.git","clone_url":"https://github.com/uzh-rpg/rpg_quadrotor_control.git","svn_url":"https://github.com/uzh-rpg/rpg_quadrotor_control","homepage":"","size":6805,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7,"open_issues":4,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/60"},"html":{"href":"https://github.com/uzh-rpg/rpg_quadrotor_control/pull/60"},"issue":{"href":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/issues/60"},"comments":{"href":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/uzh-rpg/rpg_quadrotor_control/statuses/d6dd6ab60cee868567478ed8409a32efa25bffff"}},"author_association":"NONE"}}
{"actor":{"display_login":"foehnph"}}