{"action":"created","issue":{"url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/1831","repository_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk","labels_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/1831/labels{/name}","comments_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/1831/comments","events_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/1831/events","html_url":"https://github.com/matrix-org/matrix-react-sdk/pull/1831","id":312871902,"number":1831,"title":"Improve group join/leave feedback","user":{"login":"lukebarnard1","id":6750344,"avatar_url":"https://avatars1.githubusercontent.com/u/6750344?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebarnard1","html_url":"https://github.com/lukebarnard1","followers_url":"https://api.github.com/users/lukebarnard1/followers","following_url":"https://api.github.com/users/lukebarnard1/following{/other_user}","gists_url":"https://api.github.com/users/lukebarnard1/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebarnard1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebarnard1/subscriptions","organizations_url":"https://api.github.com/users/lukebarnard1/orgs","repos_url":"https://api.github.com/users/lukebarnard1/repos","events_url":"https://api.github.com/users/lukebarnard1/events{/privacy}","received_events_url":"https://api.github.com/users/lukebarnard1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lukebarnard1","id":6750344,"avatar_url":"https://avatars1.githubusercontent.com/u/6750344?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebarnard1","html_url":"https://github.com/lukebarnard1","followers_url":"https://api.github.com/users/lukebarnard1/followers","following_url":"https://api.github.com/users/lukebarnard1/following{/other_user}","gists_url":"https://api.github.com/users/lukebarnard1/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebarnard1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebarnard1/subscriptions","organizations_url":"https://api.github.com/users/lukebarnard1/orgs","repos_url":"https://api.github.com/users/lukebarnard1/repos","events_url":"https://api.github.com/users/lukebarnard1/events{/privacy}","received_events_url":"https://api.github.com/users/lukebarnard1/received_events","type":"User","site_admin":false},"assignees":[{"login":"lukebarnard1","id":6750344,"avatar_url":"https://avatars1.githubusercontent.com/u/6750344?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebarnard1","html_url":"https://github.com/lukebarnard1","followers_url":"https://api.github.com/users/lukebarnard1/followers","following_url":"https://api.github.com/users/lukebarnard1/following{/other_user}","gists_url":"https://api.github.com/users/lukebarnard1/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebarnard1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebarnard1/subscriptions","organizations_url":"https://api.github.com/users/lukebarnard1/orgs","repos_url":"https://api.github.com/users/lukebarnard1/repos","events_url":"https://api.github.com/users/lukebarnard1/events{/privacy}","received_events_url":"https://api.github.com/users/lukebarnard1/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-04-10T10:55:39Z","updated_at":"2018-04-10T12:14:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/pulls/1831","html_url":"https://github.com/matrix-org/matrix-react-sdk/pull/1831","diff_url":"https://github.com/matrix-org/matrix-react-sdk/pull/1831.diff","patch_url":"https://github.com/matrix-org/matrix-react-sdk/pull/1831.patch"},"body":" - Display changes to memberlist, summary (for settings cog), rooms (some rooms might only be visible to joined users.\r\n - Leave settings page after clicking \"Leave\"\r\n - Show membership spinner next to \"Leave\"/\"Join\" button once clicked\r\n\r\nMight fix https://github.com/vector-im/riot-web/issues/6475"},"comment":{"url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/comments/380076953","html_url":"https://github.com/matrix-org/matrix-react-sdk/pull/1831#issuecomment-380076953","issue_url":"https://api.github.com/repos/matrix-org/matrix-react-sdk/issues/1831","id":380076953,"user":{"login":"lukebarnard1","id":6750344,"avatar_url":"https://avatars1.githubusercontent.com/u/6750344?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebarnard1","html_url":"https://github.com/lukebarnard1","followers_url":"https://api.github.com/users/lukebarnard1/followers","following_url":"https://api.github.com/users/lukebarnard1/following{/other_user}","gists_url":"https://api.github.com/users/lukebarnard1/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebarnard1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebarnard1/subscriptions","organizations_url":"https://api.github.com/users/lukebarnard1/orgs","repos_url":"https://api.github.com/users/lukebarnard1/repos","events_url":"https://api.github.com/users/lukebarnard1/events{/privacy}","received_events_url":"https://api.github.com/users/lukebarnard1/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T12:14:28Z","updated_at":"2018-04-10T12:14:28Z","author_association":"CONTRIBUTOR","body":"Actually if we split it out we don't have to worry about someone assuming that the click handler is only called in one place and making changes to it that cause bugs on the other path. "}}
{"actor":{"display_login":"lukebarnard1"}}