{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/22303","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22303/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22303/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22303/events","html_url":"https://github.com/cms-sw/cmssw/pull/22303","id":299411330,"number":22303,"title":"Implementation of 2017 MVA Electron ID : 94X MiniAOD","user":{"login":"lsoffi","id":4738925,"avatar_url":"https://avatars0.githubusercontent.com/u/4738925?v=4","gravatar_id":"","url":"https://api.github.com/users/lsoffi","html_url":"https://github.com/lsoffi","followers_url":"https://api.github.com/users/lsoffi/followers","following_url":"https://api.github.com/users/lsoffi/following{/other_user}","gists_url":"https://api.github.com/users/lsoffi/gists{/gist_id}","starred_url":"https://api.github.com/users/lsoffi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsoffi/subscriptions","organizations_url":"https://api.github.com/users/lsoffi/orgs","repos_url":"https://api.github.com/users/lsoffi/repos","events_url":"https://api.github.com/users/lsoffi/events{/privacy}","received_events_url":"https://api.github.com/users/lsoffi/received_events","type":"User","site_admin":false},"labels":[{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":541952670,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/requires-external","name":"requires-external","color":"0000ff","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/74","html_url":"https://github.com/cms-sw/cmssw/milestone/74","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/74/labels","id":3115777,"number":74,"title":"CMSSW_9_4_MAOD_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":4,"state":"open","created_at":"2018-02-14T09:01:01Z","updated_at":"2018-02-27T21:52:35Z","due_on":null,"closed_at":null},"comments":31,"created_at":"2018-02-22T16:07:07Z","updated_at":"2018-02-28T11:28:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22303","html_url":"https://github.com/cms-sw/cmssw/pull/22303","diff_url":"https://github.com/cms-sw/cmssw/pull/22303.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22303.patch"},"body":"Already reviewed and merged in the master (PR #21838) \r\nLink to PR #21838: https://github.com/cms-sw/cmssw/pull/21838"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/369211048","html_url":"https://github.com/cms-sw/cmssw/pull/22303#issuecomment-369211048","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22303","id":369211048,"user":{"login":"Sam-Harper","id":5021403,"avatar_url":"https://avatars2.githubusercontent.com/u/5021403?v=4","gravatar_id":"","url":"https://api.github.com/users/Sam-Harper","html_url":"https://github.com/Sam-Harper","followers_url":"https://api.github.com/users/Sam-Harper/followers","following_url":"https://api.github.com/users/Sam-Harper/following{/other_user}","gists_url":"https://api.github.com/users/Sam-Harper/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam-Harper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam-Harper/subscriptions","organizations_url":"https://api.github.com/users/Sam-Harper/orgs","repos_url":"https://api.github.com/users/Sam-Harper/repos","events_url":"https://api.github.com/users/Sam-Harper/events{/privacy}","received_events_url":"https://api.github.com/users/Sam-Harper/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T11:28:35Z","updated_at":"2018-02-28T11:28:35Z","author_association":"CONTRIBUTOR","body":"@perrotta, oh no problem, its tricky with everything flying about, we will try to document better.\r\n\r\nSo right now, I'm just talking about re-miniAOD V2 which I now realise you might not be.  In the re-miniAOD V2, they are removed. In reconstruction proper that hasnt happened yet but will soon for CMSSW_10_1_X deadline (some triage is on going right now). \r\n\r\nThe old ids are removed and new ones added here:\r\nhttps://github.com/cms-sw/cmssw/pull/22308/files#diff-76dede28e7751d7bb6c5c9542de4155c\r\n\r\nand then this file removes the values from going into the pat::Electrons/Photons:\r\nhttps://github.com/Sam-Harper/cmssw/blob/0907db7305731609efea7d17440f91aabe15c623/RecoEgamma/EgammaTools/python/egammaObjectModificationsInMiniAOD_cff.py\r\n\r\nE/gamma would like both 2016 and 2017 IDs run for both 2016 + 2017 MC. Its useful for studies and debugging. \r\n"}}
{"actor":{"display_login":"Sam-Harper"}}