{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/ShipChain/engine/pulls/29","id":234787213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Nzg3MjEz","html_url":"https://github.com/ShipChain/engine/pull/29","diff_url":"https://github.com/ShipChain/engine/pull/29.diff","patch_url":"https://github.com/ShipChain/engine/pull/29.patch","issue_url":"https://api.github.com/repos/ShipChain/engine/issues/29","number":29,"state":"closed","locked":false,"title":"Upgrade Node.js to latest Active LTS","user":{"login":"mlclay","id":38572212,"node_id":"MDQ6VXNlcjM4NTcyMjEy","avatar_url":"https://avatars1.githubusercontent.com/u/38572212?v=4","gravatar_id":"","url":"https://api.github.com/users/mlclay","html_url":"https://github.com/mlclay","followers_url":"https://api.github.com/users/mlclay/followers","following_url":"https://api.github.com/users/mlclay/following{/other_user}","gists_url":"https://api.github.com/users/mlclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mlclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlclay/subscriptions","organizations_url":"https://api.github.com/users/mlclay/orgs","repos_url":"https://api.github.com/users/mlclay/repos","events_url":"https://api.github.com/users/mlclay/events{/privacy}","received_events_url":"https://api.github.com/users/mlclay/received_events","type":"User","site_admin":false},"body":"Node.js 8.11.2 goes in to Maintenance status in [January 2019](https://github.com/nodejs/Release#release-schedule).  Engine should migrate to the latest Active LTS 10.14.0.\r\n\r\nAll modules have been reinstalled at their latest versions with this upgrade to Node.  Some modules are no longer required and have been removed from `package.json`.  Minor changes to correct TypeScript property errors post-upgrade have been included.\r\n\r\nAdditionally, Engine is migrating to Yarn instead of NPM for package management.  The secp256k1 package used by EthCrypto & Eccrypto has [issues](https://github.com/cryptocoinjs/secp256k1-node/issues/130) installing with NPM in Node 10; Yarn is preferred.","created_at":"2018-11-29T21:10:42Z","updated_at":"2018-11-29T21:37:41Z","closed_at":"2018-11-29T21:37:41Z","merged_at":"2018-11-29T21:37:41Z","merge_commit_sha":"e898b86c7dbefc9e8bf79e06fe63354de9ca2704","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1034655713,"node_id":"MDU6TGFiZWwxMDM0NjU1NzEz","url":"https://api.github.com/repos/ShipChain/engine/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/ShipChain/engine/pulls/29/commits","review_comments_url":"https://api.github.com/repos/ShipChain/engine/pulls/29/comments","review_comment_url":"https://api.github.com/repos/ShipChain/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ShipChain/engine/issues/29/comments","statuses_url":"https://api.github.com/repos/ShipChain/engine/statuses/5c938ad98e03cf8995742077e64e64271d118666","head":{"label":"ShipChain:feature/upgrade-nodejs-lts","ref":"feature/upgrade-nodejs-lts","sha":"5c938ad98e03cf8995742077e64e64271d118666","user":{"login":"ShipChain","id":33128412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTI4NDEy","avatar_url":"https://avatars2.githubusercontent.com/u/33128412?v=4","gravatar_id":"","url":"https://api.github.com/users/ShipChain","html_url":"https://github.com/ShipChain","followers_url":"https://api.github.com/users/ShipChain/followers","following_url":"https://api.github.com/users/ShipChain/following{/other_user}","gists_url":"https://api.github.com/users/ShipChain/gists{/gist_id}","starred_url":"https://api.github.com/users/ShipChain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShipChain/subscriptions","organizations_url":"https://api.github.com/users/ShipChain/orgs","repos_url":"https://api.github.com/users/ShipChain/repos","events_url":"https://api.github.com/users/ShipChain/events{/privacy}","received_events_url":"https://api.github.com/users/ShipChain/received_events","type":"Organization","site_admin":false},"repo":{"id":146036447,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMzY0NDc=","name":"engine","full_name":"ShipChain/engine","private":false,"owner":{"login":"ShipChain","id":33128412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTI4NDEy","avatar_url":"https://avatars2.githubusercontent.com/u/33128412?v=4","gravatar_id":"","url":"https://api.github.com/users/ShipChain","html_url":"https://github.com/ShipChain","followers_url":"https://api.github.com/users/ShipChain/followers","following_url":"https://api.github.com/users/ShipChain/following{/other_user}","gists_url":"https://api.github.com/users/ShipChain/gists{/gist_id}","starred_url":"https://api.github.com/users/ShipChain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShipChain/subscriptions","organizations_url":"https://api.github.com/users/ShipChain/orgs","repos_url":"https://api.github.com/users/ShipChain/repos","events_url":"https://api.github.com/users/ShipChain/events{/privacy}","received_events_url":"https://api.github.com/users/ShipChain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ShipChain/engine","description":"An RPC server that exposes a Typescript abstraction layer on top of the Web3 bindings for ShipChain's Ethereum smart contracts.","fork":false,"url":"https://api.github.com/repos/ShipChain/engine","forks_url":"https://api.github.com/repos/ShipChain/engine/forks","keys_url":"https://api.github.com/repos/ShipChain/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShipChain/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShipChain/engine/teams","hooks_url":"https://api.github.com/repos/ShipChain/engine/hooks","issue_events_url":"https://api.github.com/repos/ShipChain/engine/issues/events{/number}","events_url":"https://api.github.com/repos/ShipChain/engine/events","assignees_url":"https://api.github.com/repos/ShipChain/engine/assignees{/user}","branches_url":"https://api.github.com/repos/ShipChain/engine/branches{/branch}","tags_url":"https://api.github.com/repos/ShipChain/engine/tags","blobs_url":"https://api.github.com/repos/ShipChain/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShipChain/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShipChain/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShipChain/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShipChain/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ShipChain/engine/languages","stargazers_url":"https://api.github.com/repos/ShipChain/engine/stargazers","contributors_url":"https://api.github.com/repos/ShipChain/engine/contributors","subscribers_url":"https://api.github.com/repos/ShipChain/engine/subscribers","subscription_url":"https://api.github.com/repos/ShipChain/engine/subscription","commits_url":"https://api.github.com/repos/ShipChain/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShipChain/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShipChain/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShipChain/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShipChain/engine/contents/{+path}","compare_url":"https://api.github.com/repos/ShipChain/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShipChain/engine/merges","archive_url":"https://api.github.com/repos/ShipChain/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShipChain/engine/downloads","issues_url":"https://api.github.com/repos/ShipChain/engine/issues{/number}","pulls_url":"https://api.github.com/repos/ShipChain/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ShipChain/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ShipChain/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShipChain/engine/labels{/name}","releases_url":"https://api.github.com/repos/ShipChain/engine/releases{/id}","deployments_url":"https://api.github.com/repos/ShipChain/engine/deployments","created_at":"2018-08-24T20:23:29Z","updated_at":"2018-11-28T15:35:59Z","pushed_at":"2018-11-29T21:37:41Z","git_url":"git://github.com/ShipChain/engine.git","ssh_url":"git@github.com:ShipChain/engine.git","clone_url":"https://github.com/ShipChain/engine.git","svn_url":"https://github.com/ShipChain/engine","homepage":"https://shipchain.io","size":365,"stargazers_count":11,"watchers_count":11,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":11,"default_branch":"master"}},"base":{"label":"ShipChain:master","ref":"master","sha":"6e6464a2d75b6161ea550472e591409bdab90b7d","user":{"login":"ShipChain","id":33128412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTI4NDEy","avatar_url":"https://avatars2.githubusercontent.com/u/33128412?v=4","gravatar_id":"","url":"https://api.github.com/users/ShipChain","html_url":"https://github.com/ShipChain","followers_url":"https://api.github.com/users/ShipChain/followers","following_url":"https://api.github.com/users/ShipChain/following{/other_user}","gists_url":"https://api.github.com/users/ShipChain/gists{/gist_id}","starred_url":"https://api.github.com/users/ShipChain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShipChain/subscriptions","organizations_url":"https://api.github.com/users/ShipChain/orgs","repos_url":"https://api.github.com/users/ShipChain/repos","events_url":"https://api.github.com/users/ShipChain/events{/privacy}","received_events_url":"https://api.github.com/users/ShipChain/received_events","type":"Organization","site_admin":false},"repo":{"id":146036447,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMzY0NDc=","name":"engine","full_name":"ShipChain/engine","private":false,"owner":{"login":"ShipChain","id":33128412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTI4NDEy","avatar_url":"https://avatars2.githubusercontent.com/u/33128412?v=4","gravatar_id":"","url":"https://api.github.com/users/ShipChain","html_url":"https://github.com/ShipChain","followers_url":"https://api.github.com/users/ShipChain/followers","following_url":"https://api.github.com/users/ShipChain/following{/other_user}","gists_url":"https://api.github.com/users/ShipChain/gists{/gist_id}","starred_url":"https://api.github.com/users/ShipChain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShipChain/subscriptions","organizations_url":"https://api.github.com/users/ShipChain/orgs","repos_url":"https://api.github.com/users/ShipChain/repos","events_url":"https://api.github.com/users/ShipChain/events{/privacy}","received_events_url":"https://api.github.com/users/ShipChain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ShipChain/engine","description":"An RPC server that exposes a Typescript abstraction layer on top of the Web3 bindings for ShipChain's Ethereum smart contracts.","fork":false,"url":"https://api.github.com/repos/ShipChain/engine","forks_url":"https://api.github.com/repos/ShipChain/engine/forks","keys_url":"https://api.github.com/repos/ShipChain/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShipChain/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShipChain/engine/teams","hooks_url":"https://api.github.com/repos/ShipChain/engine/hooks","issue_events_url":"https://api.github.com/repos/ShipChain/engine/issues/events{/number}","events_url":"https://api.github.com/repos/ShipChain/engine/events","assignees_url":"https://api.github.com/repos/ShipChain/engine/assignees{/user}","branches_url":"https://api.github.com/repos/ShipChain/engine/branches{/branch}","tags_url":"https://api.github.com/repos/ShipChain/engine/tags","blobs_url":"https://api.github.com/repos/ShipChain/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShipChain/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShipChain/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShipChain/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShipChain/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ShipChain/engine/languages","stargazers_url":"https://api.github.com/repos/ShipChain/engine/stargazers","contributors_url":"https://api.github.com/repos/ShipChain/engine/contributors","subscribers_url":"https://api.github.com/repos/ShipChain/engine/subscribers","subscription_url":"https://api.github.com/repos/ShipChain/engine/subscription","commits_url":"https://api.github.com/repos/ShipChain/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShipChain/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShipChain/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShipChain/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShipChain/engine/contents/{+path}","compare_url":"https://api.github.com/repos/ShipChain/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShipChain/engine/merges","archive_url":"https://api.github.com/repos/ShipChain/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShipChain/engine/downloads","issues_url":"https://api.github.com/repos/ShipChain/engine/issues{/number}","pulls_url":"https://api.github.com/repos/ShipChain/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ShipChain/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ShipChain/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShipChain/engine/labels{/name}","releases_url":"https://api.github.com/repos/ShipChain/engine/releases{/id}","deployments_url":"https://api.github.com/repos/ShipChain/engine/deployments","created_at":"2018-08-24T20:23:29Z","updated_at":"2018-11-28T15:35:59Z","pushed_at":"2018-11-29T21:37:41Z","git_url":"git://github.com/ShipChain/engine.git","ssh_url":"git@github.com:ShipChain/engine.git","clone_url":"https://github.com/ShipChain/engine.git","svn_url":"https://github.com/ShipChain/engine","homepage":"https://shipchain.io","size":365,"stargazers_count":11,"watchers_count":11,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ShipChain/engine/pulls/29"},"html":{"href":"https://github.com/ShipChain/engine/pull/29"},"issue":{"href":"https://api.github.com/repos/ShipChain/engine/issues/29"},"comments":{"href":"https://api.github.com/repos/ShipChain/engine/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/ShipChain/engine/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/ShipChain/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ShipChain/engine/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/ShipChain/engine/statuses/5c938ad98e03cf8995742077e64e64271d118666"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mlclay","id":38572212,"node_id":"MDQ6VXNlcjM4NTcyMjEy","avatar_url":"https://avatars1.githubusercontent.com/u/38572212?v=4","gravatar_id":"","url":"https://api.github.com/users/mlclay","html_url":"https://github.com/mlclay","followers_url":"https://api.github.com/users/mlclay/followers","following_url":"https://api.github.com/users/mlclay/following{/other_user}","gists_url":"https://api.github.com/users/mlclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mlclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlclay/subscriptions","organizations_url":"https://api.github.com/users/mlclay/orgs","repos_url":"https://api.github.com/users/mlclay/repos","events_url":"https://api.github.com/users/mlclay/events{/privacy}","received_events_url":"https://api.github.com/users/mlclay/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":5,"additions":7981,"deletions":11733,"changed_files":13}}
{"actor":{"display_login":"mlclay"}}