{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/49903","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/49903/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/49903/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/49903/events","html_url":"https://github.com/NixOS/nixpkgs/pull/49903","id":378735943,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzY3OTI4","number":49903,"title":"inkscape: Add optional dependency scour","user":{"login":"bennylb","id":1306542,"node_id":"MDQ6VXNlcjEzMDY1NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1306542?v=4","gravatar_id":"","url":"https://api.github.com/users/bennylb","html_url":"https://github.com/bennylb","followers_url":"https://api.github.com/users/bennylb/followers","following_url":"https://api.github.com/users/bennylb/following{/other_user}","gists_url":"https://api.github.com/users/bennylb/gists{/gist_id}","starred_url":"https://api.github.com/users/bennylb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennylb/subscriptions","organizations_url":"https://api.github.com/users/bennylb/orgs","repos_url":"https://api.github.com/users/bennylb/repos","events_url":"https://api.github.com/users/bennylb/events{/privacy}","received_events_url":"https://api.github.com/users/bennylb/received_events","type":"User","site_admin":false},"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731734101,"node_id":"MDU6TGFiZWw3MzE3MzQxMDE=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%2011-100","name":"10.rebuild-linux: 11-100","color":"fbca04","default":false},{"id":9820195,"node_id":"MDU6TGFiZWw5ODIwMTk1","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20python","name":"6.topic: python","color":"fef2c0","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-08T13:41:22Z","updated_at":"2018-11-08T16:48:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/49903","html_url":"https://github.com/NixOS/nixpkgs/pull/49903","diff_url":"https://github.com/NixOS/nixpkgs/pull/49903.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/49903.patch"},"body":"###### Motivation for this change\r\n\r\nInkscape has an option to export to an optimised svg. To do this it requires [scour](http://www.codedread.com/scour/). This PR adds scour as an optional dependency.\r\n\r\n###### Things done\r\n\r\nAdded:\r\n\r\n- `pythonPackages.scour`\r\n- scour to `python-packages.nix`\r\n- `scourSupport` option to `inkscape/default.nix` arguments\r\n- Myself to `maintainers-list.nix`\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/437072836","html_url":"https://github.com/NixOS/nixpkgs/pull/49903#issuecomment-437072836","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/49903","id":437072836,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzA3MjgzNg==","user":{"login":"worldofpeace","id":28888242,"node_id":"MDQ6VXNlcjI4ODg4MjQy","avatar_url":"https://avatars0.githubusercontent.com/u/28888242?v=4","gravatar_id":"","url":"https://api.github.com/users/worldofpeace","html_url":"https://github.com/worldofpeace","followers_url":"https://api.github.com/users/worldofpeace/followers","following_url":"https://api.github.com/users/worldofpeace/following{/other_user}","gists_url":"https://api.github.com/users/worldofpeace/gists{/gist_id}","starred_url":"https://api.github.com/users/worldofpeace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldofpeace/subscriptions","organizations_url":"https://api.github.com/users/worldofpeace/orgs","repos_url":"https://api.github.com/users/worldofpeace/repos","events_url":"https://api.github.com/users/worldofpeace/events{/privacy}","received_events_url":"https://api.github.com/users/worldofpeace/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T16:48:40Z","updated_at":"2018-11-08T16:48:40Z","author_association":"CONTRIBUTOR","body":"I already added scour to nixpkgs https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/graphics/scour/default.nix"}}
{"actor":{"display_login":"worldofpeace"}}