{"action":"closed","number":18965,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/18965","id":171117814,"html_url":"https://github.com/nodejs/node/pull/18965","diff_url":"https://github.com/nodejs/node/pull/18965.diff","patch_url":"https://github.com/nodejs/node/pull/18965.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/18965","number":18965,"state":"closed","locked":false,"title":"module: fix cyclical dynamic import","user":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"body":"ensures that instantiation result is only used during initial loading. current loading mechanism would use the empty promise sentinel if the `import()` fired in a cyclic manner.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\nmodule","created_at":"2018-02-23T21:13:56Z","updated_at":"2018-03-05T20:30:06Z","closed_at":"2018-03-05T20:30:06Z","merged_at":null,"merge_commit_sha":"d724069286a55bbedf2bcda6ed4ddd1a6d28364b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":690799345,"url":"https://api.github.com/repos/nodejs/node/labels/ES%20Modules","name":"ES Modules","color":"0052cc","default":false},{"id":754449534,"url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/18965/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/18965/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/18965/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/881ae753809d8d1b31f8e128d8d930af4a1dcb85","head":{"label":"bmeck:fix-cyclic-dynamic-import","ref":"fix-cyclic-dynamic-import","sha":"881ae753809d8d1b31f8e128d8d930af4a1dcb85","user":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"repo":{"id":35897935,"name":"node","full_name":"bmeck/node","owner":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmeck/node","description":"What should go in this box? https://github.com/nodejs/io.js/issues/1714","fork":true,"url":"https://api.github.com/repos/bmeck/node","forks_url":"https://api.github.com/repos/bmeck/node/forks","keys_url":"https://api.github.com/repos/bmeck/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmeck/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmeck/node/teams","hooks_url":"https://api.github.com/repos/bmeck/node/hooks","issue_events_url":"https://api.github.com/repos/bmeck/node/issues/events{/number}","events_url":"https://api.github.com/repos/bmeck/node/events","assignees_url":"https://api.github.com/repos/bmeck/node/assignees{/user}","branches_url":"https://api.github.com/repos/bmeck/node/branches{/branch}","tags_url":"https://api.github.com/repos/bmeck/node/tags","blobs_url":"https://api.github.com/repos/bmeck/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmeck/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmeck/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmeck/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmeck/node/statuses/{sha}","languages_url":"https://api.github.com/repos/bmeck/node/languages","stargazers_url":"https://api.github.com/repos/bmeck/node/stargazers","contributors_url":"https://api.github.com/repos/bmeck/node/contributors","subscribers_url":"https://api.github.com/repos/bmeck/node/subscribers","subscription_url":"https://api.github.com/repos/bmeck/node/subscription","commits_url":"https://api.github.com/repos/bmeck/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmeck/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmeck/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmeck/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmeck/node/contents/{+path}","compare_url":"https://api.github.com/repos/bmeck/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmeck/node/merges","archive_url":"https://api.github.com/repos/bmeck/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmeck/node/downloads","issues_url":"https://api.github.com/repos/bmeck/node/issues{/number}","pulls_url":"https://api.github.com/repos/bmeck/node/pulls{/number}","milestones_url":"https://api.github.com/repos/bmeck/node/milestones{/number}","notifications_url":"https://api.github.com/repos/bmeck/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmeck/node/labels{/name}","releases_url":"https://api.github.com/repos/bmeck/node/releases{/id}","deployments_url":"https://api.github.com/repos/bmeck/node/deployments","created_at":"2015-05-19T17:35:11Z","updated_at":"2017-09-04T20:53:11Z","pushed_at":"2018-03-05T15:41:29Z","git_url":"git://github.com/bmeck/node.git","ssh_url":"git@github.com:bmeck/node.git","clone_url":"https://github.com/bmeck/node.git","svn_url":"https://github.com/bmeck/node","homepage":"https://iojs.org","size":313056,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"c111e133ae58f0d3a6a0e464abc047879edd66bf","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-03-05T19:07:29Z","pushed_at":"2018-03-05T20:25:23Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":351978,"stargazers_count":46093,"watchers_count":46093,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9656,"mirror_url":null,"archived":false,"open_issues_count":809,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9656,"open_issues":809,"watchers":46093,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/18965"},"html":{"href":"https://github.com/nodejs/node/pull/18965"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/18965"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/18965/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/18965/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/18965/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/881ae753809d8d1b31f8e128d8d930af4a1dcb85"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"joyeecheung"}}