{"action":"opened","issue":{"url":"https://api.github.com/repos/iotaledger/iota.lib.java/issues/98","repository_url":"https://api.github.com/repos/iotaledger/iota.lib.java","labels_url":"https://api.github.com/repos/iotaledger/iota.lib.java/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/iotaledger/iota.lib.java/issues/98/comments","events_url":"https://api.github.com/repos/iotaledger/iota.lib.java/issues/98/events","html_url":"https://github.com/iotaledger/iota.lib.java/issues/98","id":308954499,"number":98,"title":"Tag is not accurate","user":{"login":"TimC71","id":35205865,"avatar_url":"https://avatars1.githubusercontent.com/u/35205865?v=4","gravatar_id":"","url":"https://api.github.com/users/TimC71","html_url":"https://github.com/TimC71","followers_url":"https://api.github.com/users/TimC71/followers","following_url":"https://api.github.com/users/TimC71/following{/other_user}","gists_url":"https://api.github.com/users/TimC71/gists{/gist_id}","starred_url":"https://api.github.com/users/TimC71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimC71/subscriptions","organizations_url":"https://api.github.com/users/TimC71/orgs","repos_url":"https://api.github.com/users/TimC71/repos","events_url":"https://api.github.com/users/TimC71/events{/privacy}","received_events_url":"https://api.github.com/users/TimC71/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-27T12:49:12Z","updated_at":"2018-03-27T12:49:12Z","closed_at":null,"author_association":"NONE","body":"If use IotaAPI.sendTransfer send three meta transaction with three specified diffrent tag, and more with a value transfer transaction, the last one tag will be used in the input transaction and signature output meta transaction and remainder output transaction, which is not match with the expected.\r\nPlease see this:\r\nhttps://github.com/iotaledger/iota.lib.java/blob/42e1eb5fd5a2938ac417449f213c3a1f8e1bd8d6/jota/src/main/java/jota/IotaAPI.java#L422\r\nThe tag is not reset to empty when code run out of the for loop, and will effect the following code:\r\nhttps://github.com/iotaledger/iota.lib.java/blob/42e1eb5fd5a2938ac417449f213c3a1f8e1bd8d6/jota/src/main/java/jota/IotaAPI.java#L447\r\nhttps://github.com/iotaledger/iota.lib.java/blob/42e1eb5fd5a2938ac417449f213c3a1f8e1bd8d6/jota/src/main/java/jota/IotaAPI.java#L486\r\nhttps://github.com/iotaledger/iota.lib.java/blob/42e1eb5fd5a2938ac417449f213c3a1f8e1bd8d6/jota/src/main/java/jota/IotaAPI.java#L497\r\n\r\nMy opinon is to change the tag variable to in-loop local variable, and remove the tag parameter from the addRemainder method. The tag parameter is not passed from the IotaAPI.sendTransfer method after all.\r\nhttps://github.com/iotaledger/iota.lib.java/blob/42e1eb5fd5a2938ac417449f213c3a1f8e1bd8d6/jota/src/main/java/jota/IotaAPI.java#L1104-L1111\r\nThere is no tag parameter in sendTransfer method declaration.\r\nhttps://github.com/iotaledger/iota.lib.java/blob/42e1eb5fd5a2938ac417449f213c3a1f8e1bd8d6/jota/src/main/java/jota/IotaAPI.java#L815"}}
{"actor":{"display_login":"TimC71"}}