{"action":"created","comment":{"url":"https://api.github.com/repos/storageos/go-api/pulls/comments/208532548","pull_request_review_id":144358448,"id":208532548,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODUzMjU0OA==","diff_hunk":"@@ -7,12 +7,12 @@ import (\n \t\"strings\"\n )\n \n-// addrsFromNodes takes a list of node hosts and attempts to return a list of hosts in ip:port\n+// AddressesFromNodes takes a list of node hosts and attempts to return a list of hosts in ip:port\n // format along with any error encountered.\n //\n // The function accepts node hosts in URL, ip, ip:port, resolvable-name and resolvable-name:port\n // formats and will append the default port value if needed.\n-func addrsFromNodes(nodes []string) ([]string, error) {\n+func AddressesFromNodes(nodes []string) ([]string, error) {","path":"netutil/parsers.go","position":11,"original_position":11,"commit_id":"b1b53846ab49ebc7e80cc3d9c66475db7fa7fdb6","original_commit_id":"b1b53846ab49ebc7e80cc3d9c66475db7fa7fdb6","user":{"login":"savage-engineer","id":9120151,"node_id":"MDQ6VXNlcjkxMjAxNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9120151?v=4","gravatar_id":"","url":"https://api.github.com/users/savage-engineer","html_url":"https://github.com/savage-engineer","followers_url":"https://api.github.com/users/savage-engineer/followers","following_url":"https://api.github.com/users/savage-engineer/following{/other_user}","gists_url":"https://api.github.com/users/savage-engineer/gists{/gist_id}","starred_url":"https://api.github.com/users/savage-engineer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savage-engineer/subscriptions","organizations_url":"https://api.github.com/users/savage-engineer/orgs","repos_url":"https://api.github.com/users/savage-engineer/repos","events_url":"https://api.github.com/users/savage-engineer/events{/privacy}","received_events_url":"https://api.github.com/users/savage-engineer/received_events","type":"User","site_admin":false},"body":"I agree. I don't see any reason why we would need to explicitly make sure that hostnames resolve at this stage.","created_at":"2018-08-08T10:32:15Z","updated_at":"2018-08-08T10:32:15Z","html_url":"https://github.com/storageos/go-api/pull/47#discussion_r208532548","pull_request_url":"https://api.github.com/repos/storageos/go-api/pulls/47","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/storageos/go-api/pulls/comments/208532548"},"html":{"href":"https://github.com/storageos/go-api/pull/47#discussion_r208532548"},"pull_request":{"href":"https://api.github.com/repos/storageos/go-api/pulls/47"}},"in_reply_to_id":208521455},"pull_request":{"url":"https://api.github.com/repos/storageos/go-api/pulls/47","id":206671868,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjcxODY4","html_url":"https://github.com/storageos/go-api/pull/47","diff_url":"https://github.com/storageos/go-api/pull/47.diff","patch_url":"https://github.com/storageos/go-api/pull/47.patch","issue_url":"https://api.github.com/repos/storageos/go-api/issues/47","number":47,"state":"open","locked":false,"title":"Feature/dev 2352 cli should support http proxies","user":{"login":"savage-engineer","id":9120151,"node_id":"MDQ6VXNlcjkxMjAxNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9120151?v=4","gravatar_id":"","url":"https://api.github.com/users/savage-engineer","html_url":"https://github.com/savage-engineer","followers_url":"https://api.github.com/users/savage-engineer/followers","following_url":"https://api.github.com/users/savage-engineer/following{/other_user}","gists_url":"https://api.github.com/users/savage-engineer/gists{/gist_id}","starred_url":"https://api.github.com/users/savage-engineer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savage-engineer/subscriptions","organizations_url":"https://api.github.com/users/savage-engineer/orgs","repos_url":"https://api.github.com/users/savage-engineer/repos","events_url":"https://api.github.com/users/savage-engineer/events{/privacy}","received_events_url":"https://api.github.com/users/savage-engineer/received_events","type":"User","site_admin":false},"body":"Adds the capability for the API client to support HTTP proxies. To do this the multidialer functionality has been removed and imitated around the HTTP client Do calls. ","created_at":"2018-08-07T11:52:01Z","updated_at":"2018-08-08T10:32:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fa281713aa43e53ffb452b68f0663d08de6aa60","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/storageos/go-api/pulls/47/commits","review_comments_url":"https://api.github.com/repos/storageos/go-api/pulls/47/comments","review_comment_url":"https://api.github.com/repos/storageos/go-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/storageos/go-api/issues/47/comments","statuses_url":"https://api.github.com/repos/storageos/go-api/statuses/b1b53846ab49ebc7e80cc3d9c66475db7fa7fdb6","head":{"label":"storageos:feature/DEV-2352-cli-should-support-http-proxies","ref":"feature/DEV-2352-cli-should-support-http-proxies","sha":"b1b53846ab49ebc7e80cc3d9c66475db7fa7fdb6","user":{"login":"storageos","id":16239814,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjM5ODE0","avatar_url":"https://avatars1.githubusercontent.com/u/16239814?v=4","gravatar_id":"","url":"https://api.github.com/users/storageos","html_url":"https://github.com/storageos","followers_url":"https://api.github.com/users/storageos/followers","following_url":"https://api.github.com/users/storageos/following{/other_user}","gists_url":"https://api.github.com/users/storageos/gists{/gist_id}","starred_url":"https://api.github.com/users/storageos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storageos/subscriptions","organizations_url":"https://api.github.com/users/storageos/orgs","repos_url":"https://api.github.com/users/storageos/repos","events_url":"https://api.github.com/users/storageos/events{/privacy}","received_events_url":"https://api.github.com/users/storageos/received_events","type":"Organization","site_admin":false},"repo":{"id":80067229,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA2NzIyOQ==","name":"go-api","full_name":"storageos/go-api","owner":{"login":"storageos","id":16239814,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjM5ODE0","avatar_url":"https://avatars1.githubusercontent.com/u/16239814?v=4","gravatar_id":"","url":"https://api.github.com/users/storageos","html_url":"https://github.com/storageos","followers_url":"https://api.github.com/users/storageos/followers","following_url":"https://api.github.com/users/storageos/following{/other_user}","gists_url":"https://api.github.com/users/storageos/gists{/gist_id}","starred_url":"https://api.github.com/users/storageos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storageos/subscriptions","organizations_url":"https://api.github.com/users/storageos/orgs","repos_url":"https://api.github.com/users/storageos/repos","events_url":"https://api.github.com/users/storageos/events{/privacy}","received_events_url":"https://api.github.com/users/storageos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/storageos/go-api","description":"Golang API for StorageOS","fork":false,"url":"https://api.github.com/repos/storageos/go-api","forks_url":"https://api.github.com/repos/storageos/go-api/forks","keys_url":"https://api.github.com/repos/storageos/go-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storageos/go-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storageos/go-api/teams","hooks_url":"https://api.github.com/repos/storageos/go-api/hooks","issue_events_url":"https://api.github.com/repos/storageos/go-api/issues/events{/number}","events_url":"https://api.github.com/repos/storageos/go-api/events","assignees_url":"https://api.github.com/repos/storageos/go-api/assignees{/user}","branches_url":"https://api.github.com/repos/storageos/go-api/branches{/branch}","tags_url":"https://api.github.com/repos/storageos/go-api/tags","blobs_url":"https://api.github.com/repos/storageos/go-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storageos/go-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storageos/go-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/storageos/go-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storageos/go-api/statuses/{sha}","languages_url":"https://api.github.com/repos/storageos/go-api/languages","stargazers_url":"https://api.github.com/repos/storageos/go-api/stargazers","contributors_url":"https://api.github.com/repos/storageos/go-api/contributors","subscribers_url":"https://api.github.com/repos/storageos/go-api/subscribers","subscription_url":"https://api.github.com/repos/storageos/go-api/subscription","commits_url":"https://api.github.com/repos/storageos/go-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/storageos/go-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/storageos/go-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/storageos/go-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/storageos/go-api/contents/{+path}","compare_url":"https://api.github.com/repos/storageos/go-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storageos/go-api/merges","archive_url":"https://api.github.com/repos/storageos/go-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storageos/go-api/downloads","issues_url":"https://api.github.com/repos/storageos/go-api/issues{/number}","pulls_url":"https://api.github.com/repos/storageos/go-api/pulls{/number}","milestones_url":"https://api.github.com/repos/storageos/go-api/milestones{/number}","notifications_url":"https://api.github.com/repos/storageos/go-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storageos/go-api/labels{/name}","releases_url":"https://api.github.com/repos/storageos/go-api/releases{/id}","deployments_url":"https://api.github.com/repos/storageos/go-api/deployments","created_at":"2017-01-25T23:10:19Z","updated_at":"2018-08-03T15:29:25Z","pushed_at":"2018-08-07T16:36:28Z","git_url":"git://github.com/storageos/go-api.git","ssh_url":"git@github.com:storageos/go-api.git","clone_url":"https://github.com/storageos/go-api.git","svn_url":"https://github.com/storageos/go-api","homepage":"https://storageos.com","size":228,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":1,"watchers":10,"default_branch":"master"}},"base":{"label":"storageos:master","ref":"master","sha":"7865a9972ccc987ae335ab7c37a7497ce0963921","user":{"login":"storageos","id":16239814,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjM5ODE0","avatar_url":"https://avatars1.githubusercontent.com/u/16239814?v=4","gravatar_id":"","url":"https://api.github.com/users/storageos","html_url":"https://github.com/storageos","followers_url":"https://api.github.com/users/storageos/followers","following_url":"https://api.github.com/users/storageos/following{/other_user}","gists_url":"https://api.github.com/users/storageos/gists{/gist_id}","starred_url":"https://api.github.com/users/storageos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storageos/subscriptions","organizations_url":"https://api.github.com/users/storageos/orgs","repos_url":"https://api.github.com/users/storageos/repos","events_url":"https://api.github.com/users/storageos/events{/privacy}","received_events_url":"https://api.github.com/users/storageos/received_events","type":"Organization","site_admin":false},"repo":{"id":80067229,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA2NzIyOQ==","name":"go-api","full_name":"storageos/go-api","owner":{"login":"storageos","id":16239814,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjM5ODE0","avatar_url":"https://avatars1.githubusercontent.com/u/16239814?v=4","gravatar_id":"","url":"https://api.github.com/users/storageos","html_url":"https://github.com/storageos","followers_url":"https://api.github.com/users/storageos/followers","following_url":"https://api.github.com/users/storageos/following{/other_user}","gists_url":"https://api.github.com/users/storageos/gists{/gist_id}","starred_url":"https://api.github.com/users/storageos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storageos/subscriptions","organizations_url":"https://api.github.com/users/storageos/orgs","repos_url":"https://api.github.com/users/storageos/repos","events_url":"https://api.github.com/users/storageos/events{/privacy}","received_events_url":"https://api.github.com/users/storageos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/storageos/go-api","description":"Golang API for StorageOS","fork":false,"url":"https://api.github.com/repos/storageos/go-api","forks_url":"https://api.github.com/repos/storageos/go-api/forks","keys_url":"https://api.github.com/repos/storageos/go-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storageos/go-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storageos/go-api/teams","hooks_url":"https://api.github.com/repos/storageos/go-api/hooks","issue_events_url":"https://api.github.com/repos/storageos/go-api/issues/events{/number}","events_url":"https://api.github.com/repos/storageos/go-api/events","assignees_url":"https://api.github.com/repos/storageos/go-api/assignees{/user}","branches_url":"https://api.github.com/repos/storageos/go-api/branches{/branch}","tags_url":"https://api.github.com/repos/storageos/go-api/tags","blobs_url":"https://api.github.com/repos/storageos/go-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storageos/go-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storageos/go-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/storageos/go-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storageos/go-api/statuses/{sha}","languages_url":"https://api.github.com/repos/storageos/go-api/languages","stargazers_url":"https://api.github.com/repos/storageos/go-api/stargazers","contributors_url":"https://api.github.com/repos/storageos/go-api/contributors","subscribers_url":"https://api.github.com/repos/storageos/go-api/subscribers","subscription_url":"https://api.github.com/repos/storageos/go-api/subscription","commits_url":"https://api.github.com/repos/storageos/go-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/storageos/go-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/storageos/go-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/storageos/go-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/storageos/go-api/contents/{+path}","compare_url":"https://api.github.com/repos/storageos/go-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storageos/go-api/merges","archive_url":"https://api.github.com/repos/storageos/go-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storageos/go-api/downloads","issues_url":"https://api.github.com/repos/storageos/go-api/issues{/number}","pulls_url":"https://api.github.com/repos/storageos/go-api/pulls{/number}","milestones_url":"https://api.github.com/repos/storageos/go-api/milestones{/number}","notifications_url":"https://api.github.com/repos/storageos/go-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storageos/go-api/labels{/name}","releases_url":"https://api.github.com/repos/storageos/go-api/releases{/id}","deployments_url":"https://api.github.com/repos/storageos/go-api/deployments","created_at":"2017-01-25T23:10:19Z","updated_at":"2018-08-03T15:29:25Z","pushed_at":"2018-08-07T16:36:28Z","git_url":"git://github.com/storageos/go-api.git","ssh_url":"git@github.com:storageos/go-api.git","clone_url":"https://github.com/storageos/go-api.git","svn_url":"https://github.com/storageos/go-api","homepage":"https://storageos.com","size":228,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/storageos/go-api/pulls/47"},"html":{"href":"https://github.com/storageos/go-api/pull/47"},"issue":{"href":"https://api.github.com/repos/storageos/go-api/issues/47"},"comments":{"href":"https://api.github.com/repos/storageos/go-api/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/storageos/go-api/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/storageos/go-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/storageos/go-api/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/storageos/go-api/statuses/b1b53846ab49ebc7e80cc3d9c66475db7fa7fdb6"}},"author_association":"NONE"}}
{"actor":{"display_login":"savage-engineer"}}