{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/openenclave/pulls/comments/228154771","pull_request_review_id":168357861,"id":228154771,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODE1NDc3MQ==","diff_hunk":"@@ -0,0 +1,12 @@\n+// Copyright (c) Microsoft Corporation. All rights reserved.\n+// Licensed under the MIT License.\n+\n+#include <openenclave/internal/enclavelibc.h>\n+\n+uint64_t _rdrand(void)\n+{\n+    uint64_t r;\n+    __asm__ volatile(\"rdrand %0\\n\\t\" : \"=r\"(r));","path":"common/rand.c","position":9,"original_position":9,"commit_id":"2871b9fd324e7288ffb2bd00b0ba9ccc69fc0884","original_commit_id":"2871b9fd324e7288ffb2bd00b0ba9ccc69fc0884","user":{"login":"ihaller","id":31476121,"node_id":"MDQ6VXNlcjMxNDc2MTIx","avatar_url":"https://avatars3.githubusercontent.com/u/31476121?v=4","gravatar_id":"","url":"https://api.github.com/users/ihaller","html_url":"https://github.com/ihaller","followers_url":"https://api.github.com/users/ihaller/followers","following_url":"https://api.github.com/users/ihaller/following{/other_user}","gists_url":"https://api.github.com/users/ihaller/gists{/gist_id}","starred_url":"https://api.github.com/users/ihaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihaller/subscriptions","organizations_url":"https://api.github.com/users/ihaller/orgs","repos_url":"https://api.github.com/users/ihaller/repos","events_url":"https://api.github.com/users/ihaller/events{/privacy}","received_events_url":"https://api.github.com/users/ihaller/received_events","type":"User","site_admin":false},"body":"MSVC does not support inline assembly for x64 code.","created_at":"2018-10-25T12:37:52Z","updated_at":"2018-10-25T12:37:52Z","html_url":"https://github.com/Microsoft/openenclave/pull/972#discussion_r228154771","pull_request_url":"https://api.github.com/repos/Microsoft/openenclave/pulls/972","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/comments/228154771"},"html":{"href":"https://github.com/Microsoft/openenclave/pull/972#discussion_r228154771"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/972"}},"in_reply_to_id":228010274},"pull_request":{"url":"https://api.github.com/repos/Microsoft/openenclave/pulls/972","id":225376060,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1Mzc2MDYw","html_url":"https://github.com/Microsoft/openenclave/pull/972","diff_url":"https://github.com/Microsoft/openenclave/pull/972.diff","patch_url":"https://github.com/Microsoft/openenclave/pull/972.patch","issue_url":"https://api.github.com/repos/Microsoft/openenclave/issues/972","number":972,"state":"open","locked":false,"title":"Making single implementation for random functionality at common/rand.c,for both oecore and oelibcoelibc.","user":{"login":"vishnumohan1991","id":36887687,"node_id":"MDQ6VXNlcjM2ODg3Njg3","avatar_url":"https://avatars1.githubusercontent.com/u/36887687?v=4","gravatar_id":"","url":"https://api.github.com/users/vishnumohan1991","html_url":"https://github.com/vishnumohan1991","followers_url":"https://api.github.com/users/vishnumohan1991/followers","following_url":"https://api.github.com/users/vishnumohan1991/following{/other_user}","gists_url":"https://api.github.com/users/vishnumohan1991/gists{/gist_id}","starred_url":"https://api.github.com/users/vishnumohan1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishnumohan1991/subscriptions","organizations_url":"https://api.github.com/users/vishnumohan1991/orgs","repos_url":"https://api.github.com/users/vishnumohan1991/repos","events_url":"https://api.github.com/users/vishnumohan1991/events{/privacy}","received_events_url":"https://api.github.com/users/vishnumohan1991/received_events","type":"User","site_admin":false},"body":"The random generator function _rdrand in enclave/core/entropy.c is moved to common/rand.c\r\nIn  arc4random  used _rdrand  instead of _rdrand32_step \r\nMade  common/rand.c implementation available for both oecore and oelibc  ","created_at":"2018-10-24T12:06:42Z","updated_at":"2018-10-25T12:37:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df1ee1c898701b31de30434399a993f2b4fafcf1","assignee":{"login":"CodeMonkeyLeet","id":31784195,"node_id":"MDQ6VXNlcjMxNzg0MTk1","avatar_url":"https://avatars3.githubusercontent.com/u/31784195?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeMonkeyLeet","html_url":"https://github.com/CodeMonkeyLeet","followers_url":"https://api.github.com/users/CodeMonkeyLeet/followers","following_url":"https://api.github.com/users/CodeMonkeyLeet/following{/other_user}","gists_url":"https://api.github.com/users/CodeMonkeyLeet/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeMonkeyLeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeMonkeyLeet/subscriptions","organizations_url":"https://api.github.com/users/CodeMonkeyLeet/orgs","repos_url":"https://api.github.com/users/CodeMonkeyLeet/repos","events_url":"https://api.github.com/users/CodeMonkeyLeet/events{/privacy}","received_events_url":"https://api.github.com/users/CodeMonkeyLeet/received_events","type":"User","site_admin":false},"assignees":[{"login":"CodeMonkeyLeet","id":31784195,"node_id":"MDQ6VXNlcjMxNzg0MTk1","avatar_url":"https://avatars3.githubusercontent.com/u/31784195?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeMonkeyLeet","html_url":"https://github.com/CodeMonkeyLeet","followers_url":"https://api.github.com/users/CodeMonkeyLeet/followers","following_url":"https://api.github.com/users/CodeMonkeyLeet/following{/other_user}","gists_url":"https://api.github.com/users/CodeMonkeyLeet/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeMonkeyLeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeMonkeyLeet/subscriptions","organizations_url":"https://api.github.com/users/CodeMonkeyLeet/orgs","repos_url":"https://api.github.com/users/CodeMonkeyLeet/repos","events_url":"https://api.github.com/users/CodeMonkeyLeet/events{/privacy}","received_events_url":"https://api.github.com/users/CodeMonkeyLeet/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":975049837,"node_id":"MDU6TGFiZWw5NzUwNDk4Mzc=","url":"https://api.github.com/repos/Microsoft/openenclave/labels/engineering","name":"engineering","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/openenclave/pulls/972/commits","review_comments_url":"https://api.github.com/repos/Microsoft/openenclave/pulls/972/comments","review_comment_url":"https://api.github.com/repos/Microsoft/openenclave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/openenclave/issues/972/comments","statuses_url":"https://api.github.com/repos/Microsoft/openenclave/statuses/2871b9fd324e7288ffb2bd00b0ba9ccc69fc0884","head":{"label":"Microsoft:rand_implement#290","ref":"rand_implement#290","sha":"2871b9fd324e7288ffb2bd00b0ba9ccc69fc0884","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":101804230,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE4MDQyMzA=","name":"openenclave","full_name":"Microsoft/openenclave","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/openenclave","description":"SDK for developing enclaves","fork":false,"url":"https://api.github.com/repos/Microsoft/openenclave","forks_url":"https://api.github.com/repos/Microsoft/openenclave/forks","keys_url":"https://api.github.com/repos/Microsoft/openenclave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/openenclave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/openenclave/teams","hooks_url":"https://api.github.com/repos/Microsoft/openenclave/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/openenclave/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/openenclave/events","assignees_url":"https://api.github.com/repos/Microsoft/openenclave/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/openenclave/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/openenclave/tags","blobs_url":"https://api.github.com/repos/Microsoft/openenclave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/openenclave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/openenclave/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/openenclave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/openenclave/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/openenclave/languages","stargazers_url":"https://api.github.com/repos/Microsoft/openenclave/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/openenclave/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/openenclave/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/openenclave/subscription","commits_url":"https://api.github.com/repos/Microsoft/openenclave/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/openenclave/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/openenclave/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/openenclave/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/openenclave/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/openenclave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/openenclave/merges","archive_url":"https://api.github.com/repos/Microsoft/openenclave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/openenclave/downloads","issues_url":"https://api.github.com/repos/Microsoft/openenclave/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/openenclave/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/openenclave/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/openenclave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/openenclave/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/openenclave/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/openenclave/deployments","created_at":"2017-08-29T20:31:38Z","updated_at":"2018-10-25T02:07:42Z","pushed_at":"2018-10-25T09:16:16Z","git_url":"git://github.com/Microsoft/openenclave.git","ssh_url":"git@github.com:Microsoft/openenclave.git","clone_url":"https://github.com/Microsoft/openenclave.git","svn_url":"https://github.com/Microsoft/openenclave","homepage":null,"size":33546,"stargazers_count":53,"watchers_count":53,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":130,"watchers":53,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"26cc675586d2857329cbdc679826571a55804b6a","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":101804230,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE4MDQyMzA=","name":"openenclave","full_name":"Microsoft/openenclave","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/openenclave","description":"SDK for developing enclaves","fork":false,"url":"https://api.github.com/repos/Microsoft/openenclave","forks_url":"https://api.github.com/repos/Microsoft/openenclave/forks","keys_url":"https://api.github.com/repos/Microsoft/openenclave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/openenclave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/openenclave/teams","hooks_url":"https://api.github.com/repos/Microsoft/openenclave/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/openenclave/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/openenclave/events","assignees_url":"https://api.github.com/repos/Microsoft/openenclave/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/openenclave/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/openenclave/tags","blobs_url":"https://api.github.com/repos/Microsoft/openenclave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/openenclave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/openenclave/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/openenclave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/openenclave/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/openenclave/languages","stargazers_url":"https://api.github.com/repos/Microsoft/openenclave/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/openenclave/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/openenclave/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/openenclave/subscription","commits_url":"https://api.github.com/repos/Microsoft/openenclave/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/openenclave/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/openenclave/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/openenclave/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/openenclave/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/openenclave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/openenclave/merges","archive_url":"https://api.github.com/repos/Microsoft/openenclave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/openenclave/downloads","issues_url":"https://api.github.com/repos/Microsoft/openenclave/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/openenclave/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/openenclave/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/openenclave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/openenclave/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/openenclave/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/openenclave/deployments","created_at":"2017-08-29T20:31:38Z","updated_at":"2018-10-25T02:07:42Z","pushed_at":"2018-10-25T09:16:16Z","git_url":"git://github.com/Microsoft/openenclave.git","ssh_url":"git@github.com:Microsoft/openenclave.git","clone_url":"https://github.com/Microsoft/openenclave.git","svn_url":"https://github.com/Microsoft/openenclave","homepage":null,"size":33546,"stargazers_count":53,"watchers_count":53,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":130,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/972"},"html":{"href":"https://github.com/Microsoft/openenclave/pull/972"},"issue":{"href":"https://api.github.com/repos/Microsoft/openenclave/issues/972"},"comments":{"href":"https://api.github.com/repos/Microsoft/openenclave/issues/972/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/972/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/972/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/openenclave/statuses/2871b9fd324e7288ffb2bd00b0ba9ccc69fc0884"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ihaller"}}