{"action":"created","comment":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/comments/212441322","pull_request_review_id":149076358,"id":212441322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjQ0MTMyMg==","diff_hunk":"@@ -47,26 +37,25 @@ class SearchSources extends React.Component {\n     });\n   }\n \n-  render() {\n+  renderSources(sources, results, idx) {\n+    if (idx >= sources.length) {\n+      return this.renderResults(results);\n+    }\n+    let Source = sources[idx];\n     return (\n-      <ApiSource {...this.props}>\n-        {apiArgs => (\n-          <FormSource {...this.props}>\n-            {formFieldArgs => (\n-              <RouteSource {...this.props}>\n-                {routeArgs => (\n-                  <CommandSource {...this.props}>\n-                    {commandArgs =>\n-                      this.renderResults(apiArgs, formFieldArgs, routeArgs, commandArgs)}\n-                  </CommandSource>\n-                )}\n-              </RouteSource>\n-            )}\n-          </FormSource>\n-        )}\n-      </ApiSource>\n+      <Source {...this.props}>\n+        {args => {\n+          results[idx] = args;","path":"src/sentry/static/sentry/app/components/search/sources/index.jsx","position":60,"original_position":60,"commit_id":"794e224df6d91ff98eefc03ec60d05c72972dab2","original_commit_id":"794e224df6d91ff98eefc03ec60d05c72972dab2","user":{"login":"billyvg","id":79684,"node_id":"MDQ6VXNlcjc5Njg0","avatar_url":"https://avatars3.githubusercontent.com/u/79684?v=4","gravatar_id":"","url":"https://api.github.com/users/billyvg","html_url":"https://github.com/billyvg","followers_url":"https://api.github.com/users/billyvg/followers","following_url":"https://api.github.com/users/billyvg/following{/other_user}","gists_url":"https://api.github.com/users/billyvg/gists{/gist_id}","starred_url":"https://api.github.com/users/billyvg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billyvg/subscriptions","organizations_url":"https://api.github.com/users/billyvg/orgs","repos_url":"https://api.github.com/users/billyvg/repos","events_url":"https://api.github.com/users/billyvg/events{/privacy}","received_events_url":"https://api.github.com/users/billyvg/received_events","type":"User","site_admin":false},"body":"The recursive call and mutating `results` feels wrong to me, but I can't think of another solution.","created_at":"2018-08-23T20:11:31Z","updated_at":"2018-08-23T20:12:04Z","html_url":"https://github.com/getsentry/sentry/pull/9467#discussion_r212441322","pull_request_url":"https://api.github.com/repos/getsentry/sentry/pulls/9467","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments/212441322"},"html":{"href":"https://github.com/getsentry/sentry/pull/9467#discussion_r212441322"},"pull_request":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/9467"}}},"pull_request":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/9467","id":210007501,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDA3NTAx","html_url":"https://github.com/getsentry/sentry/pull/9467","diff_url":"https://github.com/getsentry/sentry/pull/9467.diff","patch_url":"https://github.com/getsentry/sentry/pull/9467.patch","issue_url":"https://api.github.com/repos/getsentry/sentry/issues/9467","number":9467,"state":"open","locked":false,"title":"ref(search): Make Search component reusable","user":{"login":"adhiraj","id":693121,"node_id":"MDQ6VXNlcjY5MzEyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/693121?v=4","gravatar_id":"","url":"https://api.github.com/users/adhiraj","html_url":"https://github.com/adhiraj","followers_url":"https://api.github.com/users/adhiraj/followers","following_url":"https://api.github.com/users/adhiraj/following{/other_user}","gists_url":"https://api.github.com/users/adhiraj/gists{/gist_id}","starred_url":"https://api.github.com/users/adhiraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adhiraj/subscriptions","organizations_url":"https://api.github.com/users/adhiraj/orgs","repos_url":"https://api.github.com/users/adhiraj/repos","events_url":"https://api.github.com/users/adhiraj/events{/privacy}","received_events_url":"https://api.github.com/users/adhiraj/received_events","type":"User","site_admin":false},"body":"This parametrizes the Search component with the sources to be used, whereas previously it was hard-coded. Will be used in a future PR.","created_at":"2018-08-22T02:53:59Z","updated_at":"2018-08-23T20:12:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50069dfca194ccc60741d6472dceb480a5732884","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/getsentry/sentry/pulls/9467/commits","review_comments_url":"https://api.github.com/repos/getsentry/sentry/pulls/9467/comments","review_comment_url":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsentry/sentry/issues/9467/comments","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/794e224df6d91ff98eefc03ec60d05c72972dab2","head":{"label":"getsentry:search","ref":"search","sha":"794e224df6d91ff98eefc03ec60d05c72972dab2","user":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"node_id":"MDEwOlJlcG9zaXRvcnk4NzMzMjg=","name":"sentry","full_name":"getsentry/sentry","owner":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/sentry","description":"Sentry is cross-platform application monitoring, with a focus on error reporting.","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2018-08-23T19:56:17Z","pushed_at":"2018-08-23T20:06:36Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://sentry.io","size":91625,"stargazers_count":17808,"watchers_count":17808,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2069,"mirror_url":null,"archived":false,"open_issues_count":901,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2069,"open_issues":901,"watchers":17808,"default_branch":"master"}},"base":{"label":"getsentry:master","ref":"master","sha":"716666028090920835c513cb5925bea24169cab8","user":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"node_id":"MDEwOlJlcG9zaXRvcnk4NzMzMjg=","name":"sentry","full_name":"getsentry/sentry","owner":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/sentry","description":"Sentry is cross-platform application monitoring, with a focus on error reporting.","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2018-08-23T19:56:17Z","pushed_at":"2018-08-23T20:06:36Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://sentry.io","size":91625,"stargazers_count":17808,"watchers_count":17808,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2069,"mirror_url":null,"archived":false,"open_issues_count":901,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2069,"open_issues":901,"watchers":17808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/9467"},"html":{"href":"https://github.com/getsentry/sentry/pull/9467"},"issue":{"href":"https://api.github.com/repos/getsentry/sentry/issues/9467"},"comments":{"href":"https://api.github.com/repos/getsentry/sentry/issues/9467/comments"},"review_comments":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/9467/comments"},"review_comment":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/9467/commits"},"statuses":{"href":"https://api.github.com/repos/getsentry/sentry/statuses/794e224df6d91ff98eefc03ec60d05c72972dab2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"billyvg"}}