{"action":"created","comment":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments/170683589","pull_request_review_id":99402202,"id":170683589,"diff_hunk":"@@ -834,31 +817,30 @@ private void setFonts() throws Exception {\n         data.headerImageHeight = m.getHeight() * 0.0625;\n \n         byte[] imageData = new byte[(int) imageFile.getContent().getSize()];\n-        KettleVFS.getInputStream( imageFile ).read( imageData );\n+        imageStream = KettleVFS.getInputStream( imageFile );\n+        imageStream.read( imageData );\n \n         data.headerImage = new WritableImage( 0, 0, data.headerImageWidth, data.headerImageHeight, imageData );\n       } catch ( Exception e ) {\n         throw new KettleException( e );\n       } finally {\n-        if ( imageFile != null ) {\n+        if ( imageStream != null ) {","path":"engine/src/main/java/org/pentaho/di/trans/steps/exceloutput/ExcelOutput.java","position":189,"original_position":189,"commit_id":"d777b874085ab775f37250b932516de8a6fc66a8","original_commit_id":"d777b874085ab775f37250b932516de8a6fc66a8","user":{"login":"mchen-len-son","id":17137219,"avatar_url":"https://avatars3.githubusercontent.com/u/17137219?v=4","gravatar_id":"","url":"https://api.github.com/users/mchen-len-son","html_url":"https://github.com/mchen-len-son","followers_url":"https://api.github.com/users/mchen-len-son/followers","following_url":"https://api.github.com/users/mchen-len-son/following{/other_user}","gists_url":"https://api.github.com/users/mchen-len-son/gists{/gist_id}","starred_url":"https://api.github.com/users/mchen-len-son/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchen-len-son/subscriptions","organizations_url":"https://api.github.com/users/mchen-len-son/orgs","repos_url":"https://api.github.com/users/mchen-len-son/repos","events_url":"https://api.github.com/users/mchen-len-son/events{/privacy}","received_events_url":"https://api.github.com/users/mchen-len-son/received_events","type":"User","site_admin":false},"body":"this block became unnecessary since imageFile is closed as AutoClosable, and it closes the inputStream as well","created_at":"2018-02-26T18:09:48Z","updated_at":"2018-02-26T18:15:19Z","html_url":"https://github.com/pentaho/pentaho-kettle/pull/4956#discussion_r170683589","pull_request_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/4956","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments/170683589"},"html":{"href":"https://github.com/pentaho/pentaho-kettle/pull/4956#discussion_r170683589"},"pull_request":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/4956"}}},"pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/4956","id":170691247,"html_url":"https://github.com/pentaho/pentaho-kettle/pull/4956","diff_url":"https://github.com/pentaho/pentaho-kettle/pull/4956.diff","patch_url":"https://github.com/pentaho/pentaho-kettle/pull/4956.patch","issue_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/4956","number":4956,"state":"open","locked":false,"title":"[PDI-16273]-Several places where input streams are not closed","user":{"login":"SergeyTravin","id":7590068,"avatar_url":"https://avatars3.githubusercontent.com/u/7590068?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyTravin","html_url":"https://github.com/SergeyTravin","followers_url":"https://api.github.com/users/SergeyTravin/followers","following_url":"https://api.github.com/users/SergeyTravin/following{/other_user}","gists_url":"https://api.github.com/users/SergeyTravin/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyTravin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyTravin/subscriptions","organizations_url":"https://api.github.com/users/SergeyTravin/orgs","repos_url":"https://api.github.com/users/SergeyTravin/repos","events_url":"https://api.github.com/users/SergeyTravin/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyTravin/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-22T09:06:05Z","updated_at":"2018-02-26T18:15:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4fa4163fbe1397f1e68605a4b986499767ae1ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/4956/commits","review_comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/4956/comments","review_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/4956/comments","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/d777b874085ab775f37250b932516de8a6fc66a8","head":{"label":"SergeyTravin:PDI-16273","ref":"PDI-16273","sha":"d777b874085ab775f37250b932516de8a6fc66a8","user":{"login":"SergeyTravin","id":7590068,"avatar_url":"https://avatars3.githubusercontent.com/u/7590068?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyTravin","html_url":"https://github.com/SergeyTravin","followers_url":"https://api.github.com/users/SergeyTravin/followers","following_url":"https://api.github.com/users/SergeyTravin/following{/other_user}","gists_url":"https://api.github.com/users/SergeyTravin/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyTravin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyTravin/subscriptions","organizations_url":"https://api.github.com/users/SergeyTravin/orgs","repos_url":"https://api.github.com/users/SergeyTravin/repos","events_url":"https://api.github.com/users/SergeyTravin/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyTravin/received_events","type":"User","site_admin":false},"repo":{"id":19818812,"name":"pentaho-kettle","full_name":"SergeyTravin/pentaho-kettle","owner":{"login":"SergeyTravin","id":7590068,"avatar_url":"https://avatars3.githubusercontent.com/u/7590068?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyTravin","html_url":"https://github.com/SergeyTravin","followers_url":"https://api.github.com/users/SergeyTravin/followers","following_url":"https://api.github.com/users/SergeyTravin/following{/other_user}","gists_url":"https://api.github.com/users/SergeyTravin/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyTravin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyTravin/subscriptions","organizations_url":"https://api.github.com/users/SergeyTravin/orgs","repos_url":"https://api.github.com/users/SergeyTravin/repos","events_url":"https://api.github.com/users/SergeyTravin/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyTravin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SergeyTravin/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":true,"url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle","forks_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/releases{/id}","deployments_url":"https://api.github.com/repos/SergeyTravin/pentaho-kettle/deployments","created_at":"2014-05-15T12:42:29Z","updated_at":"2016-01-15T11:50:23Z","pushed_at":"2018-02-26T13:40:54Z","git_url":"git://github.com/SergeyTravin/pentaho-kettle.git","ssh_url":"git@github.com:SergeyTravin/pentaho-kettle.git","clone_url":"https://github.com/SergeyTravin/pentaho-kettle.git","svn_url":"https://github.com/SergeyTravin/pentaho-kettle","homepage":null,"size":534367,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pentaho:master","ref":"master","sha":"0829b49636f98f61a1c8d4f060f7da7021f4f1bd","user":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars3.githubusercontent.com/u/1022787?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":13421878,"name":"pentaho-kettle","full_name":"pentaho/pentaho-kettle","owner":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars3.githubusercontent.com/u/1022787?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pentaho/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":false,"url":"https://api.github.com/repos/pentaho/pentaho-kettle","forks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/pentaho/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/pentaho/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/pentaho-kettle/releases{/id}","deployments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/deployments","created_at":"2013-10-08T18:27:11Z","updated_at":"2018-02-24T19:41:46Z","pushed_at":"2018-02-26T17:37:04Z","git_url":"git://github.com/pentaho/pentaho-kettle.git","ssh_url":"git@github.com:pentaho/pentaho-kettle.git","clone_url":"https://github.com/pentaho/pentaho-kettle.git","svn_url":"https://github.com/pentaho/pentaho-kettle","homepage":null,"size":541707,"stargazers_count":1472,"watchers_count":1472,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1240,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1240,"open_issues":31,"watchers":1472,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/4956"},"html":{"href":"https://github.com/pentaho/pentaho-kettle/pull/4956"},"issue":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/4956"},"comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/4956/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/4956/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/4956/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/d777b874085ab775f37250b932516de8a6fc66a8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mchen-len-son"}}