{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/comments/229119050","pull_request_review_id":169542863,"id":229119050,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTExOTA1MA==","diff_hunk":"@@ -48,7 +47,7 @@\n \n \n \t@Override\n-\tpublic PlanNode getPlan(ShaclSailConnection shaclSailConnection, NodeShape nodeShape) {\n+\tpublic PlanNode getPlan(ShaclSailConnection shaclSailConnection, NodeShape nodeShape, boolean printPlans, boolean assumeBaseSailValid) {","path":"shacl/src/main/java/org/eclipse/rdf4j/sail/shacl/AST/DatatypePropertyShape.java","position":13,"original_position":13,"commit_id":"d73d7d8c183d9d0d478ed1e54274240d964d3576","original_commit_id":"f649a01a1dd0b98ee5291dfe6da25bb32a60d53d","user":{"login":"jeenbroekstra","id":728776,"node_id":"MDQ6VXNlcjcyODc3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/728776?v=4","gravatar_id":"","url":"https://api.github.com/users/jeenbroekstra","html_url":"https://github.com/jeenbroekstra","followers_url":"https://api.github.com/users/jeenbroekstra/followers","following_url":"https://api.github.com/users/jeenbroekstra/following{/other_user}","gists_url":"https://api.github.com/users/jeenbroekstra/gists{/gist_id}","starred_url":"https://api.github.com/users/jeenbroekstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeenbroekstra/subscriptions","organizations_url":"https://api.github.com/users/jeenbroekstra/orgs","repos_url":"https://api.github.com/users/jeenbroekstra/repos","events_url":"https://api.github.com/users/jeenbroekstra/events{/privacy}","received_events_url":"https://api.github.com/users/jeenbroekstra/received_events","type":"User","site_admin":false},"body":"We can leave this for later if you prefer, I can look at it as part of the refactoring once this PR is complete and merged ","created_at":"2018-10-29T22:18:35Z","updated_at":"2018-10-29T22:18:36Z","html_url":"https://github.com/eclipse/rdf4j-storage/pull/109#discussion_r229119050","pull_request_url":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/109","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/comments/229119050"},"html":{"href":"https://github.com/eclipse/rdf4j-storage/pull/109#discussion_r229119050"},"pull_request":{"href":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/109"}},"in_reply_to_id":228767778},"pull_request":{"url":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/109","id":217860340,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3ODYwMzQw","html_url":"https://github.com/eclipse/rdf4j-storage/pull/109","diff_url":"https://github.com/eclipse/rdf4j-storage/pull/109.diff","patch_url":"https://github.com/eclipse/rdf4j-storage/pull/109.patch","issue_url":"https://api.github.com/repos/eclipse/rdf4j-storage/issues/109","number":109,"state":"open","locked":false,"title":"Feature/106 sh or","user":{"login":"hmottestad","id":797185,"node_id":"MDQ6VXNlcjc5NzE4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/797185?v=4","gravatar_id":"","url":"https://api.github.com/users/hmottestad","html_url":"https://github.com/hmottestad","followers_url":"https://api.github.com/users/hmottestad/followers","following_url":"https://api.github.com/users/hmottestad/following{/other_user}","gists_url":"https://api.github.com/users/hmottestad/gists{/gist_id}","starred_url":"https://api.github.com/users/hmottestad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmottestad/subscriptions","organizations_url":"https://api.github.com/users/hmottestad/orgs","repos_url":"https://api.github.com/users/hmottestad/repos","events_url":"https://api.github.com/users/hmottestad/events{/privacy}","received_events_url":"https://api.github.com/users/hmottestad/received_events","type":"User","site_admin":false},"body":"This PR addresses GitHub issue: #106  .\r\n\r\nBriefly describe the changes proposed in this PR:\r\n\r\n* support for sh:or\r\n* \r\n* \r\n","created_at":"2018-09-25T05:36:55Z","updated_at":"2018-10-29T22:18:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"235191e1bdb387b9f0bf9ce7aa2d84d17ac2666b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/109/commits","review_comments_url":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/109/comments","review_comment_url":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/rdf4j-storage/issues/109/comments","statuses_url":"https://api.github.com/repos/eclipse/rdf4j-storage/statuses/d73d7d8c183d9d0d478ed1e54274240d964d3576","head":{"label":"eclipse:feature/106_sh_or","ref":"feature/106_sh_or","sha":"d73d7d8c183d9d0d478ed1e54274240d964d3576","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":102874275,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI4NzQyNzU=","name":"rdf4j-storage","full_name":"eclipse/rdf4j-storage","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/rdf4j-storage","description":"RDF4J Storage Library","fork":false,"url":"https://api.github.com/repos/eclipse/rdf4j-storage","forks_url":"https://api.github.com/repos/eclipse/rdf4j-storage/forks","keys_url":"https://api.github.com/repos/eclipse/rdf4j-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/rdf4j-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/rdf4j-storage/teams","hooks_url":"https://api.github.com/repos/eclipse/rdf4j-storage/hooks","issue_events_url":"https://api.github.com/repos/eclipse/rdf4j-storage/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/rdf4j-storage/events","assignees_url":"https://api.github.com/repos/eclipse/rdf4j-storage/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/rdf4j-storage/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/rdf4j-storage/tags","blobs_url":"https://api.github.com/repos/eclipse/rdf4j-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/rdf4j-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/rdf4j-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/rdf4j-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/rdf4j-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/rdf4j-storage/languages","stargazers_url":"https://api.github.com/repos/eclipse/rdf4j-storage/stargazers","contributors_url":"https://api.github.com/repos/eclipse/rdf4j-storage/contributors","subscribers_url":"https://api.github.com/repos/eclipse/rdf4j-storage/subscribers","subscription_url":"https://api.github.com/repos/eclipse/rdf4j-storage/subscription","commits_url":"https://api.github.com/repos/eclipse/rdf4j-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/rdf4j-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/rdf4j-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/rdf4j-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/rdf4j-storage/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/rdf4j-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/rdf4j-storage/merges","archive_url":"https://api.github.com/repos/eclipse/rdf4j-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/rdf4j-storage/downloads","issues_url":"https://api.github.com/repos/eclipse/rdf4j-storage/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/rdf4j-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/rdf4j-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/rdf4j-storage/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/rdf4j-storage/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/rdf4j-storage/deployments","created_at":"2017-09-08T15:10:00Z","updated_at":"2018-10-25T04:27:35Z","pushed_at":"2018-10-29T22:14:45Z","git_url":"git://github.com/eclipse/rdf4j-storage.git","ssh_url":"git@github.com:eclipse/rdf4j-storage.git","clone_url":"https://github.com/eclipse/rdf4j-storage.git","svn_url":"https://github.com/eclipse/rdf4j-storage","homepage":null,"size":11613,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":13,"open_issues":4,"watchers":6,"default_branch":"master"}},"base":{"label":"eclipse:develop","ref":"develop","sha":"c4087747456c46beead20be70b9c0f0b12dac3ee","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":102874275,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI4NzQyNzU=","name":"rdf4j-storage","full_name":"eclipse/rdf4j-storage","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/rdf4j-storage","description":"RDF4J Storage Library","fork":false,"url":"https://api.github.com/repos/eclipse/rdf4j-storage","forks_url":"https://api.github.com/repos/eclipse/rdf4j-storage/forks","keys_url":"https://api.github.com/repos/eclipse/rdf4j-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/rdf4j-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/rdf4j-storage/teams","hooks_url":"https://api.github.com/repos/eclipse/rdf4j-storage/hooks","issue_events_url":"https://api.github.com/repos/eclipse/rdf4j-storage/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/rdf4j-storage/events","assignees_url":"https://api.github.com/repos/eclipse/rdf4j-storage/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/rdf4j-storage/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/rdf4j-storage/tags","blobs_url":"https://api.github.com/repos/eclipse/rdf4j-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/rdf4j-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/rdf4j-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/rdf4j-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/rdf4j-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/rdf4j-storage/languages","stargazers_url":"https://api.github.com/repos/eclipse/rdf4j-storage/stargazers","contributors_url":"https://api.github.com/repos/eclipse/rdf4j-storage/contributors","subscribers_url":"https://api.github.com/repos/eclipse/rdf4j-storage/subscribers","subscription_url":"https://api.github.com/repos/eclipse/rdf4j-storage/subscription","commits_url":"https://api.github.com/repos/eclipse/rdf4j-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/rdf4j-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/rdf4j-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/rdf4j-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/rdf4j-storage/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/rdf4j-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/rdf4j-storage/merges","archive_url":"https://api.github.com/repos/eclipse/rdf4j-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/rdf4j-storage/downloads","issues_url":"https://api.github.com/repos/eclipse/rdf4j-storage/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/rdf4j-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/rdf4j-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/rdf4j-storage/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/rdf4j-storage/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/rdf4j-storage/deployments","created_at":"2017-09-08T15:10:00Z","updated_at":"2018-10-25T04:27:35Z","pushed_at":"2018-10-29T22:14:45Z","git_url":"git://github.com/eclipse/rdf4j-storage.git","ssh_url":"git@github.com:eclipse/rdf4j-storage.git","clone_url":"https://github.com/eclipse/rdf4j-storage.git","svn_url":"https://github.com/eclipse/rdf4j-storage","homepage":null,"size":11613,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":13,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/109"},"html":{"href":"https://github.com/eclipse/rdf4j-storage/pull/109"},"issue":{"href":"https://api.github.com/repos/eclipse/rdf4j-storage/issues/109"},"comments":{"href":"https://api.github.com/repos/eclipse/rdf4j-storage/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/rdf4j-storage/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/rdf4j-storage/statuses/d73d7d8c183d9d0d478ed1e54274240d964d3576"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jeenbroekstra"}}