{"action":"created","issue":{"url":"https://api.github.com/repos/well-typed/generics-sop/issues/77","repository_url":"https://api.github.com/repos/well-typed/generics-sop","labels_url":"https://api.github.com/repos/well-typed/generics-sop/issues/77/labels{/name}","comments_url":"https://api.github.com/repos/well-typed/generics-sop/issues/77/comments","events_url":"https://api.github.com/repos/well-typed/generics-sop/issues/77/events","html_url":"https://github.com/well-typed/generics-sop/pull/77","id":355988122,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzg5Mjg0","number":77,"title":"Remove most uses of 'error' using EmptyCase","user":{"login":"RyanGlScott","id":2364661,"node_id":"MDQ6VXNlcjIzNjQ2NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2364661?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanGlScott","html_url":"https://github.com/RyanGlScott","followers_url":"https://api.github.com/users/RyanGlScott/followers","following_url":"https://api.github.com/users/RyanGlScott/following{/other_user}","gists_url":"https://api.github.com/users/RyanGlScott/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanGlScott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanGlScott/subscriptions","organizations_url":"https://api.github.com/users/RyanGlScott/orgs","repos_url":"https://api.github.com/users/RyanGlScott/repos","events_url":"https://api.github.com/users/RyanGlScott/events{/privacy}","received_events_url":"https://api.github.com/users/RyanGlScott/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-08-31T13:48:13Z","updated_at":"2018-08-31T14:34:54Z","closed_at":"2018-08-31T14:34:39Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/well-typed/generics-sop/pulls/77","html_url":"https://github.com/well-typed/generics-sop/pull/77","diff_url":"https://github.com/well-typed/generics-sop/pull/77.diff","patch_url":"https://github.com/well-typed/generics-sop/pull/77.patch"},"body":"Despite having lots of fancy types at its disposal, `generics-sop` bails out to `error` clauses in several places, which feels silly. This removes as many `error` cases as possible using the `EmptyCase` extension, which has the benefit of making several functions actually total.\r\n\r\nThis is a bit of a breaking change in that the TH-generated code now requires the `EmptyCase` extension. If this is a step too far, I could revert that part and only submit the remaining patch (since the rest of it does not constitute a breaking change by itself).\r\n\r\nFixes #57."},"comment":{"url":"https://api.github.com/repos/well-typed/generics-sop/issues/comments/417683423","html_url":"https://github.com/well-typed/generics-sop/pull/77#issuecomment-417683423","issue_url":"https://api.github.com/repos/well-typed/generics-sop/issues/77","id":417683423,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzY4MzQyMw==","user":{"login":"kosmikus","id":293191,"node_id":"MDQ6VXNlcjI5MzE5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/293191?v=4","gravatar_id":"","url":"https://api.github.com/users/kosmikus","html_url":"https://github.com/kosmikus","followers_url":"https://api.github.com/users/kosmikus/followers","following_url":"https://api.github.com/users/kosmikus/following{/other_user}","gists_url":"https://api.github.com/users/kosmikus/gists{/gist_id}","starred_url":"https://api.github.com/users/kosmikus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kosmikus/subscriptions","organizations_url":"https://api.github.com/users/kosmikus/orgs","repos_url":"https://api.github.com/users/kosmikus/repos","events_url":"https://api.github.com/users/kosmikus/events{/privacy}","received_events_url":"https://api.github.com/users/kosmikus/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T14:34:54Z","updated_at":"2018-08-31T14:34:54Z","author_association":"MEMBER","body":"Thanks a lot @RyanGlScott !"}}
{"actor":{"display_login":"kosmikus"}}