{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/veneur/issues/488","repository_url":"https://api.github.com/repos/stripe/veneur","labels_url":"https://api.github.com/repos/stripe/veneur/issues/488/labels{/name}","comments_url":"https://api.github.com/repos/stripe/veneur/issues/488/comments","events_url":"https://api.github.com/repos/stripe/veneur/issues/488/events","html_url":"https://github.com/stripe/veneur/pull/488","id":322123337,"number":488,"title":"Avoid logging spurious errors during reconnects","user":{"login":"sdboyer-stripe","id":35501011,"avatar_url":"https://avatars1.githubusercontent.com/u/35501011?v=4","gravatar_id":"","url":"https://api.github.com/users/sdboyer-stripe","html_url":"https://github.com/sdboyer-stripe","followers_url":"https://api.github.com/users/sdboyer-stripe/followers","following_url":"https://api.github.com/users/sdboyer-stripe/following{/other_user}","gists_url":"https://api.github.com/users/sdboyer-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/sdboyer-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdboyer-stripe/subscriptions","organizations_url":"https://api.github.com/users/sdboyer-stripe/orgs","repos_url":"https://api.github.com/users/sdboyer-stripe/repos","events_url":"https://api.github.com/users/sdboyer-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/sdboyer-stripe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-10T23:46:54Z","updated_at":"2018-05-10T23:49:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/stripe/veneur/pulls/488","html_url":"https://github.com/stripe/veneur/pull/488","diff_url":"https://github.com/stripe/veneur/pull/488.diff","patch_url":"https://github.com/stripe/veneur/pull/488.patch"},"body":"<!-- Checklist For PRs\r\n\r\n* Ensure you've written tests where applicable\r\n* Add a CHANGELOG.md entry describing your change, thank yourself!\r\n* Document any changes to metrics or configuration\r\n-->\r\n\r\n\r\n#### Summary\r\n<!-- Simple summary of what the code does or what you have changed. -->\r\n\r\nWhile connections were cycling (e.g., on target sink restarts), it was possible for some RPCs to erroneously emit an error log. This _should_ preclude that possibility.\r\n\r\n#### Motivation\r\n<!-- Why are you making this change? -->\r\n\r\nUnnecessary error-level logs are alerty and badsauce.\r\n\r\n#### Test plan\r\n<!-- How did you test this change? This can be as simple as “I wrote automated tests.” -->\r\n\r\nIt's hard to construct an artificial test, so testing in production works much better.\r\n\r\n#### Rollout/monitoring/revert plan\r\n<!-- Instructions for deploying, monitoring, and reverting this change. -->\r\n\r\nTest first, then merge if it appears to behave correctly."},"comment":{"url":"https://api.github.com/repos/stripe/veneur/issues/comments/388219055","html_url":"https://github.com/stripe/veneur/pull/488#issuecomment-388219055","issue_url":"https://api.github.com/repos/stripe/veneur/issues/488","id":388219055,"user":{"login":"stripe-ci","id":1864323,"avatar_url":"https://avatars1.githubusercontent.com/u/1864323?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe-ci","html_url":"https://github.com/stripe-ci","followers_url":"https://api.github.com/users/stripe-ci/followers","following_url":"https://api.github.com/users/stripe-ci/following{/other_user}","gists_url":"https://api.github.com/users/stripe-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe-ci/subscriptions","organizations_url":"https://api.github.com/users/stripe-ci/orgs","repos_url":"https://api.github.com/users/stripe-ci/repos","events_url":"https://api.github.com/users/stripe-ci/events{/privacy}","received_events_url":"https://api.github.com/users/stripe-ci/received_events","type":"User","site_admin":false},"created_at":"2018-05-10T23:49:30Z","updated_at":"2018-05-10T23:49:30Z","author_association":"NONE","body":"#### [Gerald Rule: Copy Observability on Veneur and Unilog pull requests](https://cibot.corp.stripe.com/gerald/rules/rule_Ar8VKbsoMAZQmy)\ncc @stripe/observability\ncc @stripe/observability-stripe"}}
{"actor":{"display_login":"stripe-ci"}}