{"action":"created","issue":{"url":"https://api.github.com/repos/eventbrite/javascript/issues/74","repository_url":"https://api.github.com/repos/eventbrite/javascript","labels_url":"https://api.github.com/repos/eventbrite/javascript/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/eventbrite/javascript/issues/74/comments","events_url":"https://api.github.com/repos/eventbrite/javascript/issues/74/events","html_url":"https://github.com/eventbrite/javascript/pull/74","id":330076148,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTc0NDEw","number":74,"title":"Inverts the ESLint rule that forces us to remove padding within curly braces of object literals","user":{"login":"Golodhros","id":190833,"node_id":"MDQ6VXNlcjE5MDgzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/190833?v=4","gravatar_id":"","url":"https://api.github.com/users/Golodhros","html_url":"https://github.com/Golodhros","followers_url":"https://api.github.com/users/Golodhros/followers","following_url":"https://api.github.com/users/Golodhros/following{/other_user}","gists_url":"https://api.github.com/users/Golodhros/gists{/gist_id}","starred_url":"https://api.github.com/users/Golodhros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Golodhros/subscriptions","organizations_url":"https://api.github.com/users/Golodhros/orgs","repos_url":"https://api.github.com/users/Golodhros/repos","events_url":"https://api.github.com/users/Golodhros/events{/privacy}","received_events_url":"https://api.github.com/users/Golodhros/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-06-07T00:22:29Z","updated_at":"2018-06-27T14:04:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/eventbrite/javascript/pulls/74","html_url":"https://github.com/eventbrite/javascript/pull/74","diff_url":"https://github.com/eventbrite/javascript/pull/74.diff","patch_url":"https://github.com/eventbrite/javascript/pull/74.patch"},"body":"This rule is a stylistic requirement that forces us to remove the padding between values of an object literal, and that mainly applies when we are destructuring values from an object or in parameter destructuring in the signature of a function.\r\n\r\nThe proposed change is making it the contrary, that means, to force us to add padding with spaces on this cases. The benefits I consider this brings are twofold:\r\n\r\nFirst, we improve the readability of our code, being:\r\n\r\n     let { velocity } = parameters;\r\n     const fn = ({ velocity }) => velocity;\r\n\r\nMore readable than:\r\n\r\n     let {velocity} = parameters;\r\n     const fn = ({velocity}) => velocity;\r\n\r\nSecond, we are more in sync with what the JavaScript community in general does, as this rule is set up the proposed way in a code style guide as important as the AirBnB one. Also, a lot of examples out there use the padded version.\r\n\r\nIn this case, I understand this is more a stylistic proposal, although I really think the readability benefits are real."},"comment":{"url":"https://api.github.com/repos/eventbrite/javascript/issues/comments/400683526","html_url":"https://github.com/eventbrite/javascript/pull/74#issuecomment-400683526","issue_url":"https://api.github.com/repos/eventbrite/javascript/issues/74","id":400683526,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDY4MzUyNg==","user":{"login":"jcreamer898","id":472487,"node_id":"MDQ6VXNlcjQ3MjQ4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/472487?v=4","gravatar_id":"","url":"https://api.github.com/users/jcreamer898","html_url":"https://github.com/jcreamer898","followers_url":"https://api.github.com/users/jcreamer898/followers","following_url":"https://api.github.com/users/jcreamer898/following{/other_user}","gists_url":"https://api.github.com/users/jcreamer898/gists{/gist_id}","starred_url":"https://api.github.com/users/jcreamer898/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcreamer898/subscriptions","organizations_url":"https://api.github.com/users/jcreamer898/orgs","repos_url":"https://api.github.com/users/jcreamer898/repos","events_url":"https://api.github.com/users/jcreamer898/events{/privacy}","received_events_url":"https://api.github.com/users/jcreamer898/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T14:04:45Z","updated_at":"2018-06-27T14:04:45Z","author_association":"NONE","body":"ESLint and Prettier can handle this in zero seconds flat."}}
{"actor":{"display_login":"jcreamer898"}}