{"action":"created","comment":{"url":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/comments/203506322","pull_request_review_id":138410358,"id":203506322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzUwNjMyMg==","diff_hunk":"@@ -0,0 +1,112 @@\n+import React from \"react\";\n+import PropTypes from \"prop-types\";\n+import classnames from \"classnames\";\n+import queryString from \"query-string\";\n+\n+import {fetchCubes} from \"./actions/fetch\";\n+import {loadControl, setStatePromise} from \"./actions/loadstate\";\n+import AreaChart from \"./components/AreaChart\";\n+import AreaLoading from \"./components/AreaLoading\";","path":"packages/vizbuilder/src/index.js","position":9,"original_position":9,"commit_id":"7db131fa35c1147b771f39f330fdcff1967cf8ab","original_commit_id":"01fe5ffa7398ff2c397e9fba10f1b5d69fec7d88","user":{"login":"frabarz","id":11713191,"node_id":"MDQ6VXNlcjExNzEzMTkx","avatar_url":"https://avatars2.githubusercontent.com/u/11713191?v=4","gravatar_id":"","url":"https://api.github.com/users/frabarz","html_url":"https://github.com/frabarz","followers_url":"https://api.github.com/users/frabarz/followers","following_url":"https://api.github.com/users/frabarz/following{/other_user}","gists_url":"https://api.github.com/users/frabarz/gists{/gist_id}","starred_url":"https://api.github.com/users/frabarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frabarz/subscriptions","organizations_url":"https://api.github.com/users/frabarz/orgs","repos_url":"https://api.github.com/users/frabarz/repos","events_url":"https://api.github.com/users/frabarz/events{/privacy}","received_events_url":"https://api.github.com/users/frabarz/received_events","type":"User","site_admin":false},"body":"Good catch, is basically the same code. However canon's Loading includes the translate HOC and the redux plug, and so it uses redux's values for the loading progress.\r\nThe vizbuilder is pretty much a capsuled app, all the data, including the progress counter and loading state, is inside the main component. In its current state, the vizbuilder could run both in a canon app or in a create-react-app app. Also, adding canon as a dependency of vizbuilder only to use its Loading component is a bit overkill.","created_at":"2018-07-18T19:46:58Z","updated_at":"2018-07-18T19:46:58Z","html_url":"https://github.com/Datawheel/datawheel-canon/pull/122#discussion_r203506322","pull_request_url":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/122","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/comments/203506322"},"html":{"href":"https://github.com/Datawheel/datawheel-canon/pull/122#discussion_r203506322"},"pull_request":{"href":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/122"}},"in_reply_to_id":202769338},"pull_request":{"url":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/122","id":201107596,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTA3NTk2","html_url":"https://github.com/Datawheel/datawheel-canon/pull/122","diff_url":"https://github.com/Datawheel/datawheel-canon/pull/122.diff","patch_url":"https://github.com/Datawheel/datawheel-canon/pull/122.patch","issue_url":"https://api.github.com/repos/Datawheel/datawheel-canon/issues/122","number":122,"state":"open","locked":false,"title":"Vizbuilder 0.1","user":{"login":"frabarz","id":11713191,"node_id":"MDQ6VXNlcjExNzEzMTkx","avatar_url":"https://avatars2.githubusercontent.com/u/11713191?v=4","gravatar_id":"","url":"https://api.github.com/users/frabarz","html_url":"https://github.com/frabarz","followers_url":"https://api.github.com/users/frabarz/followers","following_url":"https://api.github.com/users/frabarz/following{/other_user}","gists_url":"https://api.github.com/users/frabarz/gists{/gist_id}","starred_url":"https://api.github.com/users/frabarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frabarz/subscriptions","organizations_url":"https://api.github.com/users/frabarz/orgs","repos_url":"https://api.github.com/users/frabarz/repos","events_url":"https://api.github.com/users/frabarz/events{/privacy}","received_events_url":"https://api.github.com/users/frabarz/received_events","type":"User","site_admin":false},"body":"First stable version for the vizbuilder.\r\nInternal components were designed for extendability, so future changes should not extend too much through the codebase.\r\n\r\nCloses #105 \r\nCloses #108 \r\nCloses #118 ","created_at":"2018-07-12T19:51:11Z","updated_at":"2018-07-18T19:46:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"706481a35a0240b4b937ddd1d7a757acda4b2f2b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/122/commits","review_comments_url":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/122/comments","review_comment_url":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Datawheel/datawheel-canon/issues/122/comments","statuses_url":"https://api.github.com/repos/Datawheel/datawheel-canon/statuses/7db131fa35c1147b771f39f330fdcff1967cf8ab","head":{"label":"Datawheel:vizbuilder-0.1","ref":"vizbuilder-0.1","sha":"7db131fa35c1147b771f39f330fdcff1967cf8ab","user":{"login":"Datawheel","id":12820474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIwNDc0","avatar_url":"https://avatars3.githubusercontent.com/u/12820474?v=4","gravatar_id":"","url":"https://api.github.com/users/Datawheel","html_url":"https://github.com/Datawheel","followers_url":"https://api.github.com/users/Datawheel/followers","following_url":"https://api.github.com/users/Datawheel/following{/other_user}","gists_url":"https://api.github.com/users/Datawheel/gists{/gist_id}","starred_url":"https://api.github.com/users/Datawheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Datawheel/subscriptions","organizations_url":"https://api.github.com/users/Datawheel/orgs","repos_url":"https://api.github.com/users/Datawheel/repos","events_url":"https://api.github.com/users/Datawheel/events{/privacy}","received_events_url":"https://api.github.com/users/Datawheel/received_events","type":"Organization","site_admin":false},"repo":{"id":81867207,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg2NzIwNw==","name":"datawheel-canon","full_name":"Datawheel/datawheel-canon","owner":{"login":"Datawheel","id":12820474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIwNDc0","avatar_url":"https://avatars3.githubusercontent.com/u/12820474?v=4","gravatar_id":"","url":"https://api.github.com/users/Datawheel","html_url":"https://github.com/Datawheel","followers_url":"https://api.github.com/users/Datawheel/followers","following_url":"https://api.github.com/users/Datawheel/following{/other_user}","gists_url":"https://api.github.com/users/Datawheel/gists{/gist_id}","starred_url":"https://api.github.com/users/Datawheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Datawheel/subscriptions","organizations_url":"https://api.github.com/users/Datawheel/orgs","repos_url":"https://api.github.com/users/Datawheel/repos","events_url":"https://api.github.com/users/Datawheel/events{/privacy}","received_events_url":"https://api.github.com/users/Datawheel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Datawheel/datawheel-canon","description":"Reusable React environment and components for creating visualization engines.","fork":false,"url":"https://api.github.com/repos/Datawheel/datawheel-canon","forks_url":"https://api.github.com/repos/Datawheel/datawheel-canon/forks","keys_url":"https://api.github.com/repos/Datawheel/datawheel-canon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Datawheel/datawheel-canon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Datawheel/datawheel-canon/teams","hooks_url":"https://api.github.com/repos/Datawheel/datawheel-canon/hooks","issue_events_url":"https://api.github.com/repos/Datawheel/datawheel-canon/issues/events{/number}","events_url":"https://api.github.com/repos/Datawheel/datawheel-canon/events","assignees_url":"https://api.github.com/repos/Datawheel/datawheel-canon/assignees{/user}","branches_url":"https://api.github.com/repos/Datawheel/datawheel-canon/branches{/branch}","tags_url":"https://api.github.com/repos/Datawheel/datawheel-canon/tags","blobs_url":"https://api.github.com/repos/Datawheel/datawheel-canon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Datawheel/datawheel-canon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Datawheel/datawheel-canon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Datawheel/datawheel-canon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Datawheel/datawheel-canon/statuses/{sha}","languages_url":"https://api.github.com/repos/Datawheel/datawheel-canon/languages","stargazers_url":"https://api.github.com/repos/Datawheel/datawheel-canon/stargazers","contributors_url":"https://api.github.com/repos/Datawheel/datawheel-canon/contributors","subscribers_url":"https://api.github.com/repos/Datawheel/datawheel-canon/subscribers","subscription_url":"https://api.github.com/repos/Datawheel/datawheel-canon/subscription","commits_url":"https://api.github.com/repos/Datawheel/datawheel-canon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Datawheel/datawheel-canon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Datawheel/datawheel-canon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Datawheel/datawheel-canon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Datawheel/datawheel-canon/contents/{+path}","compare_url":"https://api.github.com/repos/Datawheel/datawheel-canon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Datawheel/datawheel-canon/merges","archive_url":"https://api.github.com/repos/Datawheel/datawheel-canon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Datawheel/datawheel-canon/downloads","issues_url":"https://api.github.com/repos/Datawheel/datawheel-canon/issues{/number}","pulls_url":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls{/number}","milestones_url":"https://api.github.com/repos/Datawheel/datawheel-canon/milestones{/number}","notifications_url":"https://api.github.com/repos/Datawheel/datawheel-canon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Datawheel/datawheel-canon/labels{/name}","releases_url":"https://api.github.com/repos/Datawheel/datawheel-canon/releases{/id}","deployments_url":"https://api.github.com/repos/Datawheel/datawheel-canon/deployments","created_at":"2017-02-13T20:17:04Z","updated_at":"2018-07-16T19:32:34Z","pushed_at":"2018-07-17T18:23:10Z","git_url":"git://github.com/Datawheel/datawheel-canon.git","ssh_url":"git@github.com:Datawheel/datawheel-canon.git","clone_url":"https://github.com/Datawheel/datawheel-canon.git","svn_url":"https://github.com/Datawheel/datawheel-canon","homepage":null,"size":4785,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":31,"watchers":8,"default_branch":"master"}},"base":{"label":"Datawheel:master","ref":"master","sha":"b18ec37d727bce21c790fa8cf1e1b713f318db50","user":{"login":"Datawheel","id":12820474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIwNDc0","avatar_url":"https://avatars3.githubusercontent.com/u/12820474?v=4","gravatar_id":"","url":"https://api.github.com/users/Datawheel","html_url":"https://github.com/Datawheel","followers_url":"https://api.github.com/users/Datawheel/followers","following_url":"https://api.github.com/users/Datawheel/following{/other_user}","gists_url":"https://api.github.com/users/Datawheel/gists{/gist_id}","starred_url":"https://api.github.com/users/Datawheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Datawheel/subscriptions","organizations_url":"https://api.github.com/users/Datawheel/orgs","repos_url":"https://api.github.com/users/Datawheel/repos","events_url":"https://api.github.com/users/Datawheel/events{/privacy}","received_events_url":"https://api.github.com/users/Datawheel/received_events","type":"Organization","site_admin":false},"repo":{"id":81867207,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg2NzIwNw==","name":"datawheel-canon","full_name":"Datawheel/datawheel-canon","owner":{"login":"Datawheel","id":12820474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIwNDc0","avatar_url":"https://avatars3.githubusercontent.com/u/12820474?v=4","gravatar_id":"","url":"https://api.github.com/users/Datawheel","html_url":"https://github.com/Datawheel","followers_url":"https://api.github.com/users/Datawheel/followers","following_url":"https://api.github.com/users/Datawheel/following{/other_user}","gists_url":"https://api.github.com/users/Datawheel/gists{/gist_id}","starred_url":"https://api.github.com/users/Datawheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Datawheel/subscriptions","organizations_url":"https://api.github.com/users/Datawheel/orgs","repos_url":"https://api.github.com/users/Datawheel/repos","events_url":"https://api.github.com/users/Datawheel/events{/privacy}","received_events_url":"https://api.github.com/users/Datawheel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Datawheel/datawheel-canon","description":"Reusable React environment and components for creating visualization engines.","fork":false,"url":"https://api.github.com/repos/Datawheel/datawheel-canon","forks_url":"https://api.github.com/repos/Datawheel/datawheel-canon/forks","keys_url":"https://api.github.com/repos/Datawheel/datawheel-canon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Datawheel/datawheel-canon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Datawheel/datawheel-canon/teams","hooks_url":"https://api.github.com/repos/Datawheel/datawheel-canon/hooks","issue_events_url":"https://api.github.com/repos/Datawheel/datawheel-canon/issues/events{/number}","events_url":"https://api.github.com/repos/Datawheel/datawheel-canon/events","assignees_url":"https://api.github.com/repos/Datawheel/datawheel-canon/assignees{/user}","branches_url":"https://api.github.com/repos/Datawheel/datawheel-canon/branches{/branch}","tags_url":"https://api.github.com/repos/Datawheel/datawheel-canon/tags","blobs_url":"https://api.github.com/repos/Datawheel/datawheel-canon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Datawheel/datawheel-canon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Datawheel/datawheel-canon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Datawheel/datawheel-canon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Datawheel/datawheel-canon/statuses/{sha}","languages_url":"https://api.github.com/repos/Datawheel/datawheel-canon/languages","stargazers_url":"https://api.github.com/repos/Datawheel/datawheel-canon/stargazers","contributors_url":"https://api.github.com/repos/Datawheel/datawheel-canon/contributors","subscribers_url":"https://api.github.com/repos/Datawheel/datawheel-canon/subscribers","subscription_url":"https://api.github.com/repos/Datawheel/datawheel-canon/subscription","commits_url":"https://api.github.com/repos/Datawheel/datawheel-canon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Datawheel/datawheel-canon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Datawheel/datawheel-canon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Datawheel/datawheel-canon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Datawheel/datawheel-canon/contents/{+path}","compare_url":"https://api.github.com/repos/Datawheel/datawheel-canon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Datawheel/datawheel-canon/merges","archive_url":"https://api.github.com/repos/Datawheel/datawheel-canon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Datawheel/datawheel-canon/downloads","issues_url":"https://api.github.com/repos/Datawheel/datawheel-canon/issues{/number}","pulls_url":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls{/number}","milestones_url":"https://api.github.com/repos/Datawheel/datawheel-canon/milestones{/number}","notifications_url":"https://api.github.com/repos/Datawheel/datawheel-canon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Datawheel/datawheel-canon/labels{/name}","releases_url":"https://api.github.com/repos/Datawheel/datawheel-canon/releases{/id}","deployments_url":"https://api.github.com/repos/Datawheel/datawheel-canon/deployments","created_at":"2017-02-13T20:17:04Z","updated_at":"2018-07-16T19:32:34Z","pushed_at":"2018-07-17T18:23:10Z","git_url":"git://github.com/Datawheel/datawheel-canon.git","ssh_url":"git@github.com:Datawheel/datawheel-canon.git","clone_url":"https://github.com/Datawheel/datawheel-canon.git","svn_url":"https://github.com/Datawheel/datawheel-canon","homepage":null,"size":4785,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":31,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/122"},"html":{"href":"https://github.com/Datawheel/datawheel-canon/pull/122"},"issue":{"href":"https://api.github.com/repos/Datawheel/datawheel-canon/issues/122"},"comments":{"href":"https://api.github.com/repos/Datawheel/datawheel-canon/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Datawheel/datawheel-canon/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/Datawheel/datawheel-canon/statuses/7db131fa35c1147b771f39f330fdcff1967cf8ab"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"frabarz"}}