{"action":"created","comment":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/238091946","pull_request_review_id":180554830,"id":238091946,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA5MTk0Ng==","diff_hunk":"@@ -79,61 +87,53 @@ describe('Modal', () => {\n \n   describe('callbacks', () => {\n     it(`should trigger the onAfterOpen function`, () => {\n-      props.onAfterOpen = sinon.spy();\n+      props.onAfterOpen = jest.fn();\n \n       createDriver(<Modal {...props} />);\n-      expect(props.onAfterOpen.calledOnce).toBeTruthy();\n+      expect(props.onAfterOpen.mock.calls).toHaveLength(1);\n     });\n \n     it(`should trigger the onRequestClose function when clicking the overlay`, () => {\n-      props.onRequestClose = sinon.spy();\n+      props.onRequestClose = jest.fn();\n       props.shouldCloseOnOverlayClick = true;\n       props.closeTimeoutMS = 0;\n \n       const driver = createDriver(<Modal {...props} />);\n       driver.clickOnOverlay();\n \n-      expect(props.onRequestClose.calledOnce).toBeTruthy();\n+      expect(props.onRequestClose.mock.calls).toHaveLength(1);","path":"src/Modal/Modal.spec.js","position":70,"original_position":69,"commit_id":"f4c5cb68e5e7dc0229bfb969485b3091307a232b","original_commit_id":"0ff6b5686a86bae82e5520e17d3f4b9e8c636579","user":{"login":"hepiyellow","id":6338722,"node_id":"MDQ6VXNlcjYzMzg3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6338722?v=4","gravatar_id":"","url":"https://api.github.com/users/hepiyellow","html_url":"https://github.com/hepiyellow","followers_url":"https://api.github.com/users/hepiyellow/followers","following_url":"https://api.github.com/users/hepiyellow/following{/other_user}","gists_url":"https://api.github.com/users/hepiyellow/gists{/gist_id}","starred_url":"https://api.github.com/users/hepiyellow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hepiyellow/subscriptions","organizations_url":"https://api.github.com/users/hepiyellow/orgs","repos_url":"https://api.github.com/users/hepiyellow/repos","events_url":"https://api.github.com/users/hepiyellow/events{/privacy}","received_events_url":"https://api.github.com/users/hepiyellow/received_events","type":"User","site_admin":false},"body":"thanks","created_at":"2018-12-02T09:57:06Z","updated_at":"2018-12-02T09:57:06Z","html_url":"https://github.com/wix/wix-style-react/pull/2516#discussion_r238091946","pull_request_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2516","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/238091946"},"html":{"href":"https://github.com/wix/wix-style-react/pull/2516#discussion_r238091946"},"pull_request":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2516"}},"in_reply_to_id":237451550},"pull_request":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/2516","id":234449522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDQ5NTIy","html_url":"https://github.com/wix/wix-style-react/pull/2516","diff_url":"https://github.com/wix/wix-style-react/pull/2516.diff","patch_url":"https://github.com/wix/wix-style-react/pull/2516.patch","issue_url":"https://api.github.com/repos/wix/wix-style-react/issues/2516","number":2516,"state":"open","locked":false,"title":"`<Modal/>` - component test - do proper cleanup of document.body between tests","user":{"login":"hepiyellow","id":6338722,"node_id":"MDQ6VXNlcjYzMzg3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6338722?v=4","gravatar_id":"","url":"https://api.github.com/users/hepiyellow","html_url":"https://github.com/hepiyellow","followers_url":"https://api.github.com/users/hepiyellow/followers","following_url":"https://api.github.com/users/hepiyellow/following{/other_user}","gists_url":"https://api.github.com/users/hepiyellow/gists{/gist_id}","starred_url":"https://api.github.com/users/hepiyellow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hepiyellow/subscriptions","organizations_url":"https://api.github.com/users/hepiyellow/orgs","repos_url":"https://api.github.com/users/hepiyellow/repos","events_url":"https://api.github.com/users/hepiyellow/events{/privacy}","received_events_url":"https://api.github.com/users/hepiyellow/received_events","type":"User","site_admin":false},"body":"Resolved https://github.com/wix-private/wsr-issues/issues/331\r\n\r\n- Add a driver method `isUnmountSideEffectsDone`. This method can be used by consumers to verify that the Modal was removed from the body.\r\n\r\n## Open issues\r\n- [ ] how to name this function? `isUnmountSideEffectsDone` is a bit long\r\n- [ ] I also export this `isUnmountSideEffectsDone` apart from the driver, since it does not require an element (since it is supposed to be called after the component has unmounted). In fact, the fact that the `isUnmountSideEffectsDone` is included in the driver is a bit weird, but could be convenient.\r\n\r\n### Also in this PR\r\n- Use ReactDomTestContainer - so we unmount the Modal after each test\r\n- Move testkit sanity to smoke test\r\n- Remove jasmine timeout control (we are running in jest)\r\n- Remove use of sinon (use jest mocks)","created_at":"2018-11-28T22:43:57Z","updated_at":"2018-12-02T09:57:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83d8c9132c3e8baf982e9a772d8b09659c7f021e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"argshook","id":4284659,"node_id":"MDQ6VXNlcjQyODQ2NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4284659?v=4","gravatar_id":"","url":"https://api.github.com/users/argshook","html_url":"https://github.com/argshook","followers_url":"https://api.github.com/users/argshook/followers","following_url":"https://api.github.com/users/argshook/following{/other_user}","gists_url":"https://api.github.com/users/argshook/gists{/gist_id}","starred_url":"https://api.github.com/users/argshook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argshook/subscriptions","organizations_url":"https://api.github.com/users/argshook/orgs","repos_url":"https://api.github.com/users/argshook/repos","events_url":"https://api.github.com/users/argshook/events{/privacy}","received_events_url":"https://api.github.com/users/argshook/received_events","type":"User","site_admin":false},{"login":"mykas","id":8919190,"node_id":"MDQ6VXNlcjg5MTkxOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8919190?v=4","gravatar_id":"","url":"https://api.github.com/users/mykas","html_url":"https://github.com/mykas","followers_url":"https://api.github.com/users/mykas/followers","following_url":"https://api.github.com/users/mykas/following{/other_user}","gists_url":"https://api.github.com/users/mykas/gists{/gist_id}","starred_url":"https://api.github.com/users/mykas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykas/subscriptions","organizations_url":"https://api.github.com/users/mykas/orgs","repos_url":"https://api.github.com/users/mykas/repos","events_url":"https://api.github.com/users/mykas/events{/privacy}","received_events_url":"https://api.github.com/users/mykas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2516/commits","review_comments_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2516/comments","review_comment_url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/wix-style-react/issues/2516/comments","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/f4c5cb68e5e7dc0229bfb969485b3091307a232b","head":{"label":"wix:modal/proper_test_cleanup","ref":"modal/proper_test_cleanup","sha":"f4c5cb68e5e7dc0229bfb969485b3091307a232b","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":73713311,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcxMzMxMQ==","name":"wix-style-react","full_name":"wix/wix-style-react","private":false,"owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wix/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":false,"url":"https://api.github.com/repos/wix/wix-style-react","forks_url":"https://api.github.com/repos/wix/wix-style-react/forks","keys_url":"https://api.github.com/repos/wix/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-style-react/teams","hooks_url":"https://api.github.com/repos/wix/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-style-react/events","assignees_url":"https://api.github.com/repos/wix/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-style-react/tags","blobs_url":"https://api.github.com/repos/wix/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/wix/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-style-react/subscription","commits_url":"https://api.github.com/repos/wix/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-style-react/merges","archive_url":"https://api.github.com/repos/wix/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-style-react/downloads","issues_url":"https://api.github.com/repos/wix/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-style-react/deployments","created_at":"2016-11-14T14:37:00Z","updated_at":"2018-11-30T13:53:00Z","pushed_at":"2018-12-02T08:55:17Z","git_url":"git://github.com/wix/wix-style-react.git","ssh_url":"git@github.com:wix/wix-style-react.git","clone_url":"https://github.com/wix/wix-style-react.git","svn_url":"https://github.com/wix/wix-style-react","homepage":"https://wix-wix-style-react.surge.sh","size":9971,"stargazers_count":436,"watchers_count":436,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":105,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":95,"open_issues":105,"watchers":436,"default_branch":"master"}},"base":{"label":"wix:master","ref":"master","sha":"1ff4b3faf99762cf053de3e30e63ea3b543538ad","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":73713311,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcxMzMxMQ==","name":"wix-style-react","full_name":"wix/wix-style-react","private":false,"owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wix/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":false,"url":"https://api.github.com/repos/wix/wix-style-react","forks_url":"https://api.github.com/repos/wix/wix-style-react/forks","keys_url":"https://api.github.com/repos/wix/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-style-react/teams","hooks_url":"https://api.github.com/repos/wix/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-style-react/events","assignees_url":"https://api.github.com/repos/wix/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-style-react/tags","blobs_url":"https://api.github.com/repos/wix/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/wix/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-style-react/subscription","commits_url":"https://api.github.com/repos/wix/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-style-react/merges","archive_url":"https://api.github.com/repos/wix/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-style-react/downloads","issues_url":"https://api.github.com/repos/wix/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-style-react/deployments","created_at":"2016-11-14T14:37:00Z","updated_at":"2018-11-30T13:53:00Z","pushed_at":"2018-12-02T08:55:17Z","git_url":"git://github.com/wix/wix-style-react.git","ssh_url":"git@github.com:wix/wix-style-react.git","clone_url":"https://github.com/wix/wix-style-react.git","svn_url":"https://github.com/wix/wix-style-react","homepage":"https://wix-wix-style-react.surge.sh","size":9971,"stargazers_count":436,"watchers_count":436,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":105,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":95,"open_issues":105,"watchers":436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2516"},"html":{"href":"https://github.com/wix/wix-style-react/pull/2516"},"issue":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/2516"},"comments":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/2516/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2516/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2516/commits"},"statuses":{"href":"https://api.github.com/repos/wix/wix-style-react/statuses/f4c5cb68e5e7dc0229bfb969485b3091307a232b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hepiyellow"}}