{"action":"created","issue":{"url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/79","repository_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb","labels_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/79/comments","events_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/79/events","html_url":"https://github.com/ipld/js-ipld-dag-pb/issues/79","id":346268356,"node_id":"MDU6SXNzdWUzNDYyNjgzNTY=","number":79,"title":"Support CIDs in dag-pb links","user":{"login":"olizilla","id":58871,"node_id":"MDQ6VXNlcjU4ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/58871?v=4","gravatar_id":"","url":"https://api.github.com/users/olizilla","html_url":"https://github.com/olizilla","followers_url":"https://api.github.com/users/olizilla/followers","following_url":"https://api.github.com/users/olizilla/following{/other_user}","gists_url":"https://api.github.com/users/olizilla/gists{/gist_id}","starred_url":"https://api.github.com/users/olizilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olizilla/subscriptions","organizations_url":"https://api.github.com/users/olizilla/orgs","repos_url":"https://api.github.com/users/olizilla/repos","events_url":"https://api.github.com/users/olizilla/events{/privacy}","received_events_url":"https://api.github.com/users/olizilla/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"vmx","id":42839,"node_id":"MDQ6VXNlcjQyODM5","avatar_url":"https://avatars3.githubusercontent.com/u/42839?v=4","gravatar_id":"","url":"https://api.github.com/users/vmx","html_url":"https://github.com/vmx","followers_url":"https://api.github.com/users/vmx/followers","following_url":"https://api.github.com/users/vmx/following{/other_user}","gists_url":"https://api.github.com/users/vmx/gists{/gist_id}","starred_url":"https://api.github.com/users/vmx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmx/subscriptions","organizations_url":"https://api.github.com/users/vmx/orgs","repos_url":"https://api.github.com/users/vmx/repos","events_url":"https://api.github.com/users/vmx/events{/privacy}","received_events_url":"https://api.github.com/users/vmx/received_events","type":"User","site_admin":false},"assignees":[{"login":"vmx","id":42839,"node_id":"MDQ6VXNlcjQyODM5","avatar_url":"https://avatars3.githubusercontent.com/u/42839?v=4","gravatar_id":"","url":"https://api.github.com/users/vmx","html_url":"https://github.com/vmx","followers_url":"https://api.github.com/users/vmx/followers","following_url":"https://api.github.com/users/vmx/following{/other_user}","gists_url":"https://api.github.com/users/vmx/gists{/gist_id}","starred_url":"https://api.github.com/users/vmx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmx/subscriptions","organizations_url":"https://api.github.com/users/vmx/orgs","repos_url":"https://api.github.com/users/vmx/repos","events_url":"https://api.github.com/users/vmx/events{/privacy}","received_events_url":"https://api.github.com/users/vmx/received_events","type":"User","site_admin":false},{"login":"diasdavid","id":1211152,"node_id":"MDQ6VXNlcjEyMTExNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1211152?v=4","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-31T16:40:19Z","updated_at":"2018-07-31T17:09:20Z","closed_at":null,"author_association":"MEMBER","body":"js-ipld-dag-pb assumes that links will be multihashes\r\nhttps://github.com/ipld/js-ipld-dag-pb/blob/70b0cd53148fa26dc3e75fe250c0f1ad8161a59e/src/dag-link/index.js#L8-L23\r\n\r\nHere is a dag-pb node where one of the links is a CIDv1\r\nhttps://ipfs.io/api/v0/dag/get?arg=QmViWi5az9iiPzESM6ruHf84TcmHSAVQ2KQdNveoDH7eaY/refs/heads\r\n\r\n```\r\n// 20180731162407\r\n// https://ipfs.io/api/v0/dag/get?arg=QmViWi5az9iiPzESM6ruHf84TcmHSAVQ2KQdNveoDH7eaY/refs/heads\r\n\r\n{\r\n  \"data\": \"CAE=\",\r\n  \"links\": [\r\n    {\r\n      \"Name\": \"archive\",\r\n      \"Size\": 83,\r\n      \"Cid\": {\r\n        \"/\": \"QmfBgo8BAB26hFtyGNGK46rqYkKLFvWYfTqjrGdbUEjnUU\"\r\n      }\r\n    },\r\n    {\r\n      \"Name\": \"master\",\r\n      \"Size\": 42,\r\n      \"Cid\": {\r\n        \"/\": \"z8mWaJHXieAVxxLagBpdaNWFEBKVWmMiE\"\r\n      }\r\n    }\r\n  ]\r\n}\r\n```\r\n\r\nI assume we need to upgrade `DagLink` to support CIDs, but I've never seen one like that before, so I first want to verify that such a thing _should_ be possible."},"comment":{"url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/comments/409296673","html_url":"https://github.com/ipld/js-ipld-dag-pb/issues/79#issuecomment-409296673","issue_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/79","id":409296673,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTI5NjY3Mw==","user":{"login":"Stebalien","id":310393,"node_id":"MDQ6VXNlcjMxMDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T17:09:20Z","updated_at":"2018-07-31T17:09:20Z","author_association":"NONE","body":"Yes, they can be CIDv1 links. Specifically, unixfs can store CIDv1 pointers to *raw* blocks. That's how we implement the raw leaves feature (where we store file chunks as raw data instead of wrapping them in protobufs)."}}
{"actor":{"display_login":"Stebalien"}}