{"action":"created","comment":{"url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/comments/167243813","pull_request_review_id":95439464,"id":167243813,"diff_hunk":"@@ -72,6 +72,15 @@ class=\"form-control simple-select\">\n                                    class=\"form-control\"\n                                    value=\"<?php echo get_setting('smtp_server_address', '', true); ?>\">\n                         </div>\n+                        \n+                        <div class=\"form-group\">\n+                            <label for=\"settings[smtp_mail_from]\">\n+                                <?php _trans('smtp_mail_from'); ?>\n+                            </label>\n+                            <input type=\"text\" name=\"settings[smtp_mail_from]\" id=\"settings[smtp_mail_from]\"","path":"application/modules/settings/views/partial_settings_email.php","position":9,"original_position":9,"commit_id":"135acac1578e078e8bf4168c885e40b9d20c4b16","original_commit_id":"135acac1578e078e8bf4168c885e40b9d20c4b16","user":{"login":"kalimerre","id":5664180,"avatar_url":"https://avatars3.githubusercontent.com/u/5664180?v=4","gravatar_id":"","url":"https://api.github.com/users/kalimerre","html_url":"https://github.com/kalimerre","followers_url":"https://api.github.com/users/kalimerre/followers","following_url":"https://api.github.com/users/kalimerre/following{/other_user}","gists_url":"https://api.github.com/users/kalimerre/gists{/gist_id}","starred_url":"https://api.github.com/users/kalimerre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalimerre/subscriptions","organizations_url":"https://api.github.com/users/kalimerre/orgs","repos_url":"https://api.github.com/users/kalimerre/repos","events_url":"https://api.github.com/users/kalimerre/events{/privacy}","received_events_url":"https://api.github.com/users/kalimerre/received_events","type":"User","site_admin":false},"body":"Yes but on the phone it’s hard to write tags haha ! \r\n\r\nI don’t know if there is other validator in the settings for mail but I guess. Maybe add this field to the fields validated for mails no ? ","created_at":"2018-02-09T14:39:51Z","updated_at":"2018-02-09T14:39:51Z","html_url":"https://github.com/InvoicePlane/InvoicePlane/pull/597#discussion_r167243813","pull_request_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/597","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/comments/167243813"},"html":{"href":"https://github.com/InvoicePlane/InvoicePlane/pull/597#discussion_r167243813"},"pull_request":{"href":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/597"}},"in_reply_to_id":167241139},"pull_request":{"url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/597","id":167962492,"html_url":"https://github.com/InvoicePlane/InvoicePlane/pull/597","diff_url":"https://github.com/InvoicePlane/InvoicePlane/pull/597.diff","patch_url":"https://github.com/InvoicePlane/InvoicePlane/pull/597.patch","issue_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/issues/597","number":597,"state":"open","locked":false,"title":"[IP-596] Add Email Mailsender","user":{"login":"cornelinux","id":1908620,"avatar_url":"https://avatars1.githubusercontent.com/u/1908620?v=4","gravatar_id":"","url":"https://api.github.com/users/cornelinux","html_url":"https://github.com/cornelinux","followers_url":"https://api.github.com/users/cornelinux/followers","following_url":"https://api.github.com/users/cornelinux/following{/other_user}","gists_url":"https://api.github.com/users/cornelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/cornelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornelinux/subscriptions","organizations_url":"https://api.github.com/users/cornelinux/orgs","repos_url":"https://api.github.com/users/cornelinux/repos","events_url":"https://api.github.com/users/cornelinux/events{/privacy}","received_events_url":"https://api.github.com/users/cornelinux/received_events","type":"User","site_admin":false},"body":"Closes IP-596","created_at":"2018-02-08T12:48:12Z","updated_at":"2018-02-09T14:39:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28c4085b010c0a4cc5c065cdd8f4f6b538e9105b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/597/commits","review_comments_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/597/comments","review_comment_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/issues/597/comments","statuses_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/statuses/135acac1578e078e8bf4168c885e40b9d20c4b16","head":{"label":"cornelinux:IP596/configure-mail-from","ref":"IP596/configure-mail-from","sha":"135acac1578e078e8bf4168c885e40b9d20c4b16","user":{"login":"cornelinux","id":1908620,"avatar_url":"https://avatars1.githubusercontent.com/u/1908620?v=4","gravatar_id":"","url":"https://api.github.com/users/cornelinux","html_url":"https://github.com/cornelinux","followers_url":"https://api.github.com/users/cornelinux/followers","following_url":"https://api.github.com/users/cornelinux/following{/other_user}","gists_url":"https://api.github.com/users/cornelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/cornelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornelinux/subscriptions","organizations_url":"https://api.github.com/users/cornelinux/orgs","repos_url":"https://api.github.com/users/cornelinux/repos","events_url":"https://api.github.com/users/cornelinux/events{/privacy}","received_events_url":"https://api.github.com/users/cornelinux/received_events","type":"User","site_admin":false},"repo":{"id":81755293,"name":"InvoicePlane","full_name":"cornelinux/InvoicePlane","owner":{"login":"cornelinux","id":1908620,"avatar_url":"https://avatars1.githubusercontent.com/u/1908620?v=4","gravatar_id":"","url":"https://api.github.com/users/cornelinux","html_url":"https://github.com/cornelinux","followers_url":"https://api.github.com/users/cornelinux/followers","following_url":"https://api.github.com/users/cornelinux/following{/other_user}","gists_url":"https://api.github.com/users/cornelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/cornelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornelinux/subscriptions","organizations_url":"https://api.github.com/users/cornelinux/orgs","repos_url":"https://api.github.com/users/cornelinux/repos","events_url":"https://api.github.com/users/cornelinux/events{/privacy}","received_events_url":"https://api.github.com/users/cornelinux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cornelinux/InvoicePlane","description":"A free and open source invoicing application. Find out more at https://invoiceplane.com","fork":true,"url":"https://api.github.com/repos/cornelinux/InvoicePlane","forks_url":"https://api.github.com/repos/cornelinux/InvoicePlane/forks","keys_url":"https://api.github.com/repos/cornelinux/InvoicePlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cornelinux/InvoicePlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cornelinux/InvoicePlane/teams","hooks_url":"https://api.github.com/repos/cornelinux/InvoicePlane/hooks","issue_events_url":"https://api.github.com/repos/cornelinux/InvoicePlane/issues/events{/number}","events_url":"https://api.github.com/repos/cornelinux/InvoicePlane/events","assignees_url":"https://api.github.com/repos/cornelinux/InvoicePlane/assignees{/user}","branches_url":"https://api.github.com/repos/cornelinux/InvoicePlane/branches{/branch}","tags_url":"https://api.github.com/repos/cornelinux/InvoicePlane/tags","blobs_url":"https://api.github.com/repos/cornelinux/InvoicePlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cornelinux/InvoicePlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cornelinux/InvoicePlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/cornelinux/InvoicePlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cornelinux/InvoicePlane/statuses/{sha}","languages_url":"https://api.github.com/repos/cornelinux/InvoicePlane/languages","stargazers_url":"https://api.github.com/repos/cornelinux/InvoicePlane/stargazers","contributors_url":"https://api.github.com/repos/cornelinux/InvoicePlane/contributors","subscribers_url":"https://api.github.com/repos/cornelinux/InvoicePlane/subscribers","subscription_url":"https://api.github.com/repos/cornelinux/InvoicePlane/subscription","commits_url":"https://api.github.com/repos/cornelinux/InvoicePlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/cornelinux/InvoicePlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/cornelinux/InvoicePlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/cornelinux/InvoicePlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/cornelinux/InvoicePlane/contents/{+path}","compare_url":"https://api.github.com/repos/cornelinux/InvoicePlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cornelinux/InvoicePlane/merges","archive_url":"https://api.github.com/repos/cornelinux/InvoicePlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cornelinux/InvoicePlane/downloads","issues_url":"https://api.github.com/repos/cornelinux/InvoicePlane/issues{/number}","pulls_url":"https://api.github.com/repos/cornelinux/InvoicePlane/pulls{/number}","milestones_url":"https://api.github.com/repos/cornelinux/InvoicePlane/milestones{/number}","notifications_url":"https://api.github.com/repos/cornelinux/InvoicePlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cornelinux/InvoicePlane/labels{/name}","releases_url":"https://api.github.com/repos/cornelinux/InvoicePlane/releases{/id}","deployments_url":"https://api.github.com/repos/cornelinux/InvoicePlane/deployments","created_at":"2017-02-12T20:36:21Z","updated_at":"2017-02-12T20:36:24Z","pushed_at":"2018-02-09T14:10:41Z","git_url":"git://github.com/cornelinux/InvoicePlane.git","ssh_url":"git@github.com:cornelinux/InvoicePlane.git","clone_url":"https://github.com/cornelinux/InvoicePlane.git","svn_url":"https://github.com/cornelinux/InvoicePlane","homepage":"","size":19576,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"InvoicePlane:v1.5.7","ref":"v1.5.7","sha":"864c6f6734ef1b110fc1594ec222eb44df4d94ce","user":{"login":"InvoicePlane","id":7656602,"avatar_url":"https://avatars1.githubusercontent.com/u/7656602?v=4","gravatar_id":"","url":"https://api.github.com/users/InvoicePlane","html_url":"https://github.com/InvoicePlane","followers_url":"https://api.github.com/users/InvoicePlane/followers","following_url":"https://api.github.com/users/InvoicePlane/following{/other_user}","gists_url":"https://api.github.com/users/InvoicePlane/gists{/gist_id}","starred_url":"https://api.github.com/users/InvoicePlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InvoicePlane/subscriptions","organizations_url":"https://api.github.com/users/InvoicePlane/orgs","repos_url":"https://api.github.com/users/InvoicePlane/repos","events_url":"https://api.github.com/users/InvoicePlane/events{/privacy}","received_events_url":"https://api.github.com/users/InvoicePlane/received_events","type":"Organization","site_admin":false},"repo":{"id":20021038,"name":"InvoicePlane","full_name":"InvoicePlane/InvoicePlane","owner":{"login":"InvoicePlane","id":7656602,"avatar_url":"https://avatars1.githubusercontent.com/u/7656602?v=4","gravatar_id":"","url":"https://api.github.com/users/InvoicePlane","html_url":"https://github.com/InvoicePlane","followers_url":"https://api.github.com/users/InvoicePlane/followers","following_url":"https://api.github.com/users/InvoicePlane/following{/other_user}","gists_url":"https://api.github.com/users/InvoicePlane/gists{/gist_id}","starred_url":"https://api.github.com/users/InvoicePlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InvoicePlane/subscriptions","organizations_url":"https://api.github.com/users/InvoicePlane/orgs","repos_url":"https://api.github.com/users/InvoicePlane/repos","events_url":"https://api.github.com/users/InvoicePlane/events{/privacy}","received_events_url":"https://api.github.com/users/InvoicePlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/InvoicePlane/InvoicePlane","description":"A free and open source invoicing application. Find out more at https://invoiceplane.com","fork":false,"url":"https://api.github.com/repos/InvoicePlane/InvoicePlane","forks_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/forks","keys_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/teams","hooks_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/hooks","issue_events_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/issues/events{/number}","events_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/events","assignees_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/assignees{/user}","branches_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/branches{/branch}","tags_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/tags","blobs_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/statuses/{sha}","languages_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/languages","stargazers_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/stargazers","contributors_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/contributors","subscribers_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/subscribers","subscription_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/subscription","commits_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/contents/{+path}","compare_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/merges","archive_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/downloads","issues_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/issues{/number}","pulls_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls{/number}","milestones_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/milestones{/number}","notifications_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/labels{/name}","releases_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/releases{/id}","deployments_url":"https://api.github.com/repos/InvoicePlane/InvoicePlane/deployments","created_at":"2014-05-21T12:52:29Z","updated_at":"2018-02-08T20:10:21Z","pushed_at":"2018-02-09T14:10:43Z","git_url":"git://github.com/InvoicePlane/InvoicePlane.git","ssh_url":"git@github.com:InvoicePlane/InvoicePlane.git","clone_url":"https://github.com/InvoicePlane/InvoicePlane.git","svn_url":"https://github.com/InvoicePlane/InvoicePlane","homepage":"","size":19406,"stargazers_count":1039,"watchers_count":1039,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":394,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":394,"open_issues":55,"watchers":1039,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/597"},"html":{"href":"https://github.com/InvoicePlane/InvoicePlane/pull/597"},"issue":{"href":"https://api.github.com/repos/InvoicePlane/InvoicePlane/issues/597"},"comments":{"href":"https://api.github.com/repos/InvoicePlane/InvoicePlane/issues/597/comments"},"review_comments":{"href":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/597/comments"},"review_comment":{"href":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/InvoicePlane/InvoicePlane/pulls/597/commits"},"statuses":{"href":"https://api.github.com/repos/InvoicePlane/InvoicePlane/statuses/135acac1578e078e8bf4168c885e40b9d20c4b16"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kalimerre"}}