{"action":"created","comment":{"url":"https://api.github.com/repos/pypa/pip/pulls/comments/231854738","pull_request_review_id":172915114,"id":231854738,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTg1NDczOA==","diff_hunk":"@@ -315,7 +321,21 @@ def run(self, options, args):\n                         ignore_installed=options.ignore_installed,\n                         isolated=options.isolated_mode,\n                     )\n+                    top_level_reqs = list(requirement_set.requirements.keys())\n                     resolver.resolve(requirement_set)\n+                    if options.deps_only:\n+                        if options.editables:\n+                            raise CommandError(\"Cannot use --deps-only \"\n+                                               \"with editable installations\")\n+                        if options.requirements:\n+                            raise CommandError(\"Cannot use --deps-only with \"\n+                                               \"requirements files\")\n+\n+                        for target in top_level_reqs:\n+                            del requirement_set.requirements[target]","path":"src/pip/_internal/commands/install.py","position":28,"original_position":28,"commit_id":"3537248d5aeff80d622d2bea8b51100235fd13ce","original_commit_id":"3537248d5aeff80d622d2bea8b51100235fd13ce","user":{"login":"pfmoore","id":1110419,"node_id":"MDQ6VXNlcjExMTA0MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1110419?v=4","gravatar_id":"","url":"https://api.github.com/users/pfmoore","html_url":"https://github.com/pfmoore","followers_url":"https://api.github.com/users/pfmoore/followers","following_url":"https://api.github.com/users/pfmoore/following{/other_user}","gists_url":"https://api.github.com/users/pfmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/pfmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfmoore/subscriptions","organizations_url":"https://api.github.com/users/pfmoore/orgs","repos_url":"https://api.github.com/users/pfmoore/repos","events_url":"https://api.github.com/users/pfmoore/events{/privacy}","received_events_url":"https://api.github.com/users/pfmoore/received_events","type":"User","site_admin":false},"body":"No time to do a thorough review, but won't this have the following impact (I'll do this with \"pure\" requirements, not with extras, just to simplify the argument):\r\n\r\nSuppose you have `A` and `B` and B depends on A. Then `pip install --deps-only B` will install A, but `pip install --deps-only A B` won't. Meaning that we *haven't* installed the dependencies of B, like the user asked us to.\r\n\r\nIt also means that\r\n```\r\npip install --deps-only A B\r\n```\r\nand\r\n```\r\npip install --deps-only A\r\npip install --deps-only B\r\n```\r\nwill behave differently, which is possibly confusing.\r\n\r\nI'm not sure there's an \"obvious\" best answer to this, but (a) I think the behaviour should be clearly specified (and that means there's probably a need for a docs patch here as well) and (b) I think the logic of what \"dependencies only\" should mean needs to be more clearly thought through for cases like this that maybe aren't the \"intended\" use of the feature (#4783 is the intended use) but which may crop up once people have the chance to use the feature.\r\n\r\nIt's possible that the behaviour as implemented here is \"good enough\", so all of the above is theoretical and not worth worrying about - but again, let's be explicit rather than simply leaving it assumed.","created_at":"2018-11-08T11:35:38Z","updated_at":"2018-11-08T11:35:38Z","html_url":"https://github.com/pypa/pip/pull/5950#discussion_r231854738","pull_request_url":"https://api.github.com/repos/pypa/pip/pulls/5950","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pypa/pip/pulls/comments/231854738"},"html":{"href":"https://github.com/pypa/pip/pull/5950#discussion_r231854738"},"pull_request":{"href":"https://api.github.com/repos/pypa/pip/pulls/5950"}}},"pull_request":{"url":"https://api.github.com/repos/pypa/pip/pulls/5950","id":226304364,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzA0MzY0","html_url":"https://github.com/pypa/pip/pull/5950","diff_url":"https://github.com/pypa/pip/pull/5950.diff","patch_url":"https://github.com/pypa/pip/pull/5950.patch","issue_url":"https://api.github.com/repos/pypa/pip/issues/5950","number":5950,"state":"open","locked":false,"title":"Implement --deps-only install mode","user":{"login":"lkollar","id":791741,"node_id":"MDQ6VXNlcjc5MTc0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/791741?v=4","gravatar_id":"","url":"https://api.github.com/users/lkollar","html_url":"https://github.com/lkollar","followers_url":"https://api.github.com/users/lkollar/followers","following_url":"https://api.github.com/users/lkollar/following{/other_user}","gists_url":"https://api.github.com/users/lkollar/gists{/gist_id}","starred_url":"https://api.github.com/users/lkollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkollar/subscriptions","organizations_url":"https://api.github.com/users/lkollar/orgs","repos_url":"https://api.github.com/users/lkollar/repos","events_url":"https://api.github.com/users/lkollar/events{/privacy}","received_events_url":"https://api.github.com/users/lkollar/received_events","type":"User","site_admin":false},"body":"Specifying `--deps-only` will skip the top level targets and install dependencies only. This can be useful for setting up a development environment without installing the main package itself.\r\n\r\nResolves: #4783","created_at":"2018-10-27T16:00:52Z","updated_at":"2018-11-08T11:35:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf5639b13759030c0da0ac0342b9cab187ceef4a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1030368955,"node_id":"MDU6TGFiZWwxMDMwMzY4OTU1","url":"https://api.github.com/repos/pypa/pip/labels/C:%20cli","name":"C: cli","color":"0052cc","default":false},{"id":737427126,"node_id":"MDU6TGFiZWw3Mzc0MjcxMjY=","url":"https://api.github.com/repos/pypa/pip/labels/C:%20extras","name":"C: extras","color":"0052cc","default":false},{"id":82424,"node_id":"MDU6TGFiZWw4MjQyNA==","url":"https://api.github.com/repos/pypa/pip/labels/T:%20enhancement","name":"T: enhancement","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pypa/pip/pulls/5950/commits","review_comments_url":"https://api.github.com/repos/pypa/pip/pulls/5950/comments","review_comment_url":"https://api.github.com/repos/pypa/pip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypa/pip/issues/5950/comments","statuses_url":"https://api.github.com/repos/pypa/pip/statuses/3537248d5aeff80d622d2bea8b51100235fd13ce","head":{"label":"lkollar:no-deps-install","ref":"no-deps-install","sha":"3537248d5aeff80d622d2bea8b51100235fd13ce","user":{"login":"lkollar","id":791741,"node_id":"MDQ6VXNlcjc5MTc0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/791741?v=4","gravatar_id":"","url":"https://api.github.com/users/lkollar","html_url":"https://github.com/lkollar","followers_url":"https://api.github.com/users/lkollar/followers","following_url":"https://api.github.com/users/lkollar/following{/other_user}","gists_url":"https://api.github.com/users/lkollar/gists{/gist_id}","starred_url":"https://api.github.com/users/lkollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkollar/subscriptions","organizations_url":"https://api.github.com/users/lkollar/orgs","repos_url":"https://api.github.com/users/lkollar/repos","events_url":"https://api.github.com/users/lkollar/events{/privacy}","received_events_url":"https://api.github.com/users/lkollar/received_events","type":"User","site_admin":false},"repo":{"id":153523384,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM1MjMzODQ=","name":"pip","full_name":"lkollar/pip","private":false,"owner":{"login":"lkollar","id":791741,"node_id":"MDQ6VXNlcjc5MTc0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/791741?v=4","gravatar_id":"","url":"https://api.github.com/users/lkollar","html_url":"https://github.com/lkollar","followers_url":"https://api.github.com/users/lkollar/followers","following_url":"https://api.github.com/users/lkollar/following{/other_user}","gists_url":"https://api.github.com/users/lkollar/gists{/gist_id}","starred_url":"https://api.github.com/users/lkollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkollar/subscriptions","organizations_url":"https://api.github.com/users/lkollar/orgs","repos_url":"https://api.github.com/users/lkollar/repos","events_url":"https://api.github.com/users/lkollar/events{/privacy}","received_events_url":"https://api.github.com/users/lkollar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lkollar/pip","description":"The PyPA recommended tool for installing Python packages","fork":true,"url":"https://api.github.com/repos/lkollar/pip","forks_url":"https://api.github.com/repos/lkollar/pip/forks","keys_url":"https://api.github.com/repos/lkollar/pip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lkollar/pip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lkollar/pip/teams","hooks_url":"https://api.github.com/repos/lkollar/pip/hooks","issue_events_url":"https://api.github.com/repos/lkollar/pip/issues/events{/number}","events_url":"https://api.github.com/repos/lkollar/pip/events","assignees_url":"https://api.github.com/repos/lkollar/pip/assignees{/user}","branches_url":"https://api.github.com/repos/lkollar/pip/branches{/branch}","tags_url":"https://api.github.com/repos/lkollar/pip/tags","blobs_url":"https://api.github.com/repos/lkollar/pip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lkollar/pip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lkollar/pip/git/refs{/sha}","trees_url":"https://api.github.com/repos/lkollar/pip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lkollar/pip/statuses/{sha}","languages_url":"https://api.github.com/repos/lkollar/pip/languages","stargazers_url":"https://api.github.com/repos/lkollar/pip/stargazers","contributors_url":"https://api.github.com/repos/lkollar/pip/contributors","subscribers_url":"https://api.github.com/repos/lkollar/pip/subscribers","subscription_url":"https://api.github.com/repos/lkollar/pip/subscription","commits_url":"https://api.github.com/repos/lkollar/pip/commits{/sha}","git_commits_url":"https://api.github.com/repos/lkollar/pip/git/commits{/sha}","comments_url":"https://api.github.com/repos/lkollar/pip/comments{/number}","issue_comment_url":"https://api.github.com/repos/lkollar/pip/issues/comments{/number}","contents_url":"https://api.github.com/repos/lkollar/pip/contents/{+path}","compare_url":"https://api.github.com/repos/lkollar/pip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lkollar/pip/merges","archive_url":"https://api.github.com/repos/lkollar/pip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lkollar/pip/downloads","issues_url":"https://api.github.com/repos/lkollar/pip/issues{/number}","pulls_url":"https://api.github.com/repos/lkollar/pip/pulls{/number}","milestones_url":"https://api.github.com/repos/lkollar/pip/milestones{/number}","notifications_url":"https://api.github.com/repos/lkollar/pip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lkollar/pip/labels{/name}","releases_url":"https://api.github.com/repos/lkollar/pip/releases{/id}","deployments_url":"https://api.github.com/repos/lkollar/pip/deployments","created_at":"2018-10-17T21:02:38Z","updated_at":"2018-10-17T21:02:41Z","pushed_at":"2018-10-27T16:59:10Z","git_url":"git://github.com/lkollar/pip.git","ssh_url":"git@github.com:lkollar/pip.git","clone_url":"https://github.com/lkollar/pip.git","svn_url":"https://github.com/lkollar/pip","homepage":"https://pip.pypa.io/","size":49028,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pypa:master","ref":"master","sha":"ebfa66361e92b3cac7c259956effcd55617c1486","user":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":1446467,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2NDY3","name":"pip","full_name":"pypa/pip","private":false,"owner":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pypa/pip","description":"The PyPA recommended tool for installing Python packages","fork":false,"url":"https://api.github.com/repos/pypa/pip","forks_url":"https://api.github.com/repos/pypa/pip/forks","keys_url":"https://api.github.com/repos/pypa/pip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/pip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/pip/teams","hooks_url":"https://api.github.com/repos/pypa/pip/hooks","issue_events_url":"https://api.github.com/repos/pypa/pip/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/pip/events","assignees_url":"https://api.github.com/repos/pypa/pip/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/pip/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/pip/tags","blobs_url":"https://api.github.com/repos/pypa/pip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/pip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/pip/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/pip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/pip/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/pip/languages","stargazers_url":"https://api.github.com/repos/pypa/pip/stargazers","contributors_url":"https://api.github.com/repos/pypa/pip/contributors","subscribers_url":"https://api.github.com/repos/pypa/pip/subscribers","subscription_url":"https://api.github.com/repos/pypa/pip/subscription","commits_url":"https://api.github.com/repos/pypa/pip/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/pip/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/pip/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/pip/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/pip/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/pip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/pip/merges","archive_url":"https://api.github.com/repos/pypa/pip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/pip/downloads","issues_url":"https://api.github.com/repos/pypa/pip/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/pip/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/pip/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/pip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/pip/labels{/name}","releases_url":"https://api.github.com/repos/pypa/pip/releases{/id}","deployments_url":"https://api.github.com/repos/pypa/pip/deployments","created_at":"2011-03-06T14:30:46Z","updated_at":"2018-11-08T11:16:36Z","pushed_at":"2018-11-08T11:18:43Z","git_url":"git://github.com/pypa/pip.git","ssh_url":"git@github.com:pypa/pip.git","clone_url":"https://github.com/pypa/pip.git","svn_url":"https://github.com/pypa/pip","homepage":"https://pip.pypa.io/","size":52304,"stargazers_count":4955,"watchers_count":4955,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1668,"mirror_url":null,"archived":false,"open_issues_count":573,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1668,"open_issues":573,"watchers":4955,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/pip/pulls/5950"},"html":{"href":"https://github.com/pypa/pip/pull/5950"},"issue":{"href":"https://api.github.com/repos/pypa/pip/issues/5950"},"comments":{"href":"https://api.github.com/repos/pypa/pip/issues/5950/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/pip/pulls/5950/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/pip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypa/pip/pulls/5950/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/pip/statuses/3537248d5aeff80d622d2bea8b51100235fd13ce"}},"author_association":"NONE"}}
{"actor":{"display_login":"pfmoore"}}