{"action":"created","comment":{"url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments/190316662","pull_request_review_id":122668376,"id":190316662,"diff_hunk":"@@ -0,0 +1,121 @@\n+# Run ipa-client-install on puppet clients\n+#\n+# @param ensure\n+#   'present' to install, 'absent' to uninstall\n+#\n+# @param enroll\n+#   Be smart about when to run `ipa-client-install`\n+#\n+# @param ip_address\n+#   IP address of host being connected\n+#\n+# @param hostname\n+#   Hostname of the host being connected\n+#\n+# @param password\n+#   Admin or host-based one-time-password generated by `ipa host-add` or the GUI\n+#\n+# @param server\n+#   IPA server to connect to\n+#\n+# @param domain\n+#   IPA Domain\n+#\n+# @param realm\n+#   IPA Realm\n+#\n+# @param no_ac\n+#   Run without authconfig","path":"manifests/ipa/install.pp","position":28,"original_position":28,"commit_id":"de444fffa45ebe0a778da17d72b3dfd1af626668","original_commit_id":"de444fffa45ebe0a778da17d72b3dfd1af626668","user":{"login":"jeefberkey","id":8931085,"avatar_url":"https://avatars2.githubusercontent.com/u/8931085?v=4","gravatar_id":"","url":"https://api.github.com/users/jeefberkey","html_url":"https://github.com/jeefberkey","followers_url":"https://api.github.com/users/jeefberkey/followers","following_url":"https://api.github.com/users/jeefberkey/following{/other_user}","gists_url":"https://api.github.com/users/jeefberkey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeefberkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeefberkey/subscriptions","organizations_url":"https://api.github.com/users/jeefberkey/orgs","repos_url":"https://api.github.com/users/jeefberkey/repos","events_url":"https://api.github.com/users/jeefberkey/events{/privacy}","received_events_url":"https://api.github.com/users/jeefberkey/received_events","type":"User","site_admin":false},"body":"I don't want to obscure any functionality of `ipa-client-install`, and this module might be run on systems where authconfig is used as intended. It still defaults to true.","created_at":"2018-05-23T16:31:34Z","updated_at":"2018-05-23T16:31:34Z","html_url":"https://github.com/simp/pupmod-simp-simp/pull/154#discussion_r190316662","pull_request_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/154","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments/190316662"},"html":{"href":"https://github.com/simp/pupmod-simp-simp/pull/154#discussion_r190316662"},"pull_request":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/154"}},"in_reply_to_id":190260730},"pull_request":{"url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/154","id":186400340,"html_url":"https://github.com/simp/pupmod-simp-simp/pull/154","diff_url":"https://github.com/simp/pupmod-simp-simp/pull/154.diff","patch_url":"https://github.com/simp/pupmod-simp-simp/pull/154.patch","issue_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/154","number":154,"state":"open","locked":false,"title":"(SIMP-4857) Add class to join IPA domains","user":{"login":"jeefberkey","id":8931085,"avatar_url":"https://avatars2.githubusercontent.com/u/8931085?v=4","gravatar_id":"","url":"https://api.github.com/users/jeefberkey","html_url":"https://github.com/jeefberkey","followers_url":"https://api.github.com/users/jeefberkey/followers","following_url":"https://api.github.com/users/jeefberkey/following{/other_user}","gists_url":"https://api.github.com/users/jeefberkey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeefberkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeefberkey/subscriptions","organizations_url":"https://api.github.com/users/jeefberkey/orgs","repos_url":"https://api.github.com/users/jeefberkey/repos","events_url":"https://api.github.com/users/jeefberkey/events{/privacy}","received_events_url":"https://api.github.com/users/jeefberkey/received_events","type":"User","site_admin":false},"body":"This commit adds a preliminary class for joining IPA domains with Puppet\r\n\r\nSIMP-4857 #comment POC code pushed","created_at":"2018-05-07T16:32:25Z","updated_at":"2018-05-23T16:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6d18a8da8b979bf8eae3ca5cd1ee0f7eae0cf03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/154/commits","review_comments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/154/comments","review_comment_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/154/comments","statuses_url":"https://api.github.com/repos/simp/pupmod-simp-simp/statuses/de444fffa45ebe0a778da17d72b3dfd1af626668","head":{"label":"jeefberkey:SIMP-4857-ipa-enrollment","ref":"SIMP-4857-ipa-enrollment","sha":"de444fffa45ebe0a778da17d72b3dfd1af626668","user":{"login":"jeefberkey","id":8931085,"avatar_url":"https://avatars2.githubusercontent.com/u/8931085?v=4","gravatar_id":"","url":"https://api.github.com/users/jeefberkey","html_url":"https://github.com/jeefberkey","followers_url":"https://api.github.com/users/jeefberkey/followers","following_url":"https://api.github.com/users/jeefberkey/following{/other_user}","gists_url":"https://api.github.com/users/jeefberkey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeefberkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeefberkey/subscriptions","organizations_url":"https://api.github.com/users/jeefberkey/orgs","repos_url":"https://api.github.com/users/jeefberkey/repos","events_url":"https://api.github.com/users/jeefberkey/events{/privacy}","received_events_url":"https://api.github.com/users/jeefberkey/received_events","type":"User","site_admin":false},"repo":{"id":41604145,"name":"pupmod-simp-simp","full_name":"jeefberkey/pupmod-simp-simp","owner":{"login":"jeefberkey","id":8931085,"avatar_url":"https://avatars2.githubusercontent.com/u/8931085?v=4","gravatar_id":"","url":"https://api.github.com/users/jeefberkey","html_url":"https://github.com/jeefberkey","followers_url":"https://api.github.com/users/jeefberkey/followers","following_url":"https://api.github.com/users/jeefberkey/following{/other_user}","gists_url":"https://api.github.com/users/jeefberkey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeefberkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeefberkey/subscriptions","organizations_url":"https://api.github.com/users/jeefberkey/orgs","repos_url":"https://api.github.com/users/jeefberkey/repos","events_url":"https://api.github.com/users/jeefberkey/events{/privacy}","received_events_url":"https://api.github.com/users/jeefberkey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeefberkey/pupmod-simp-simp","description":"The SIMP simp Puppet Module","fork":true,"url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp","forks_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/forks","keys_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/teams","hooks_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/hooks","issue_events_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/issues/events{/number}","events_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/events","assignees_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/assignees{/user}","branches_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/branches{/branch}","tags_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/tags","blobs_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/statuses/{sha}","languages_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/languages","stargazers_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/stargazers","contributors_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/contributors","subscribers_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/subscribers","subscription_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/subscription","commits_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/contents/{+path}","compare_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/merges","archive_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/downloads","issues_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/issues{/number}","pulls_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/pulls{/number}","milestones_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/milestones{/number}","notifications_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/labels{/name}","releases_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/releases{/id}","deployments_url":"https://api.github.com/repos/jeefberkey/pupmod-simp-simp/deployments","created_at":"2015-08-29T19:05:35Z","updated_at":"2018-05-11T13:59:27Z","pushed_at":"2018-05-18T20:50:41Z","git_url":"git://github.com/jeefberkey/pupmod-simp-simp.git","ssh_url":"git@github.com:jeefberkey/pupmod-simp-simp.git","clone_url":"https://github.com/jeefberkey/pupmod-simp-simp.git","svn_url":"https://github.com/jeefberkey/pupmod-simp-simp","homepage":null,"size":559,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simp:master","ref":"master","sha":"658a4e36b6a800417a786099488c3558dc96ec06","user":{"login":"simp","id":12174186,"avatar_url":"https://avatars2.githubusercontent.com/u/12174186?v=4","gravatar_id":"","url":"https://api.github.com/users/simp","html_url":"https://github.com/simp","followers_url":"https://api.github.com/users/simp/followers","following_url":"https://api.github.com/users/simp/following{/other_user}","gists_url":"https://api.github.com/users/simp/gists{/gist_id}","starred_url":"https://api.github.com/users/simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simp/subscriptions","organizations_url":"https://api.github.com/users/simp/orgs","repos_url":"https://api.github.com/users/simp/repos","events_url":"https://api.github.com/users/simp/events{/privacy}","received_events_url":"https://api.github.com/users/simp/received_events","type":"Organization","site_admin":false},"repo":{"id":35873685,"name":"pupmod-simp-simp","full_name":"simp/pupmod-simp-simp","owner":{"login":"simp","id":12174186,"avatar_url":"https://avatars2.githubusercontent.com/u/12174186?v=4","gravatar_id":"","url":"https://api.github.com/users/simp","html_url":"https://github.com/simp","followers_url":"https://api.github.com/users/simp/followers","following_url":"https://api.github.com/users/simp/following{/other_user}","gists_url":"https://api.github.com/users/simp/gists{/gist_id}","starred_url":"https://api.github.com/users/simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simp/subscriptions","organizations_url":"https://api.github.com/users/simp/orgs","repos_url":"https://api.github.com/users/simp/repos","events_url":"https://api.github.com/users/simp/events{/privacy}","received_events_url":"https://api.github.com/users/simp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simp/pupmod-simp-simp","description":"The SIMP simp Puppet Module","fork":false,"url":"https://api.github.com/repos/simp/pupmod-simp-simp","forks_url":"https://api.github.com/repos/simp/pupmod-simp-simp/forks","keys_url":"https://api.github.com/repos/simp/pupmod-simp-simp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simp/pupmod-simp-simp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simp/pupmod-simp-simp/teams","hooks_url":"https://api.github.com/repos/simp/pupmod-simp-simp/hooks","issue_events_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/events{/number}","events_url":"https://api.github.com/repos/simp/pupmod-simp-simp/events","assignees_url":"https://api.github.com/repos/simp/pupmod-simp-simp/assignees{/user}","branches_url":"https://api.github.com/repos/simp/pupmod-simp-simp/branches{/branch}","tags_url":"https://api.github.com/repos/simp/pupmod-simp-simp/tags","blobs_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/refs{/sha}","trees_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simp/pupmod-simp-simp/statuses/{sha}","languages_url":"https://api.github.com/repos/simp/pupmod-simp-simp/languages","stargazers_url":"https://api.github.com/repos/simp/pupmod-simp-simp/stargazers","contributors_url":"https://api.github.com/repos/simp/pupmod-simp-simp/contributors","subscribers_url":"https://api.github.com/repos/simp/pupmod-simp-simp/subscribers","subscription_url":"https://api.github.com/repos/simp/pupmod-simp-simp/subscription","commits_url":"https://api.github.com/repos/simp/pupmod-simp-simp/commits{/sha}","git_commits_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/commits{/sha}","comments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/comments{/number}","issue_comment_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/comments{/number}","contents_url":"https://api.github.com/repos/simp/pupmod-simp-simp/contents/{+path}","compare_url":"https://api.github.com/repos/simp/pupmod-simp-simp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simp/pupmod-simp-simp/merges","archive_url":"https://api.github.com/repos/simp/pupmod-simp-simp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simp/pupmod-simp-simp/downloads","issues_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues{/number}","pulls_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls{/number}","milestones_url":"https://api.github.com/repos/simp/pupmod-simp-simp/milestones{/number}","notifications_url":"https://api.github.com/repos/simp/pupmod-simp-simp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simp/pupmod-simp-simp/labels{/name}","releases_url":"https://api.github.com/repos/simp/pupmod-simp-simp/releases{/id}","deployments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/deployments","created_at":"2015-05-19T09:49:41Z","updated_at":"2018-05-15T20:40:43Z","pushed_at":"2018-05-21T16:02:11Z","git_url":"git://github.com/simp/pupmod-simp-simp.git","ssh_url":"git@github.com:simp/pupmod-simp-simp.git","clone_url":"https://github.com/simp/pupmod-simp-simp.git","svn_url":"https://github.com/simp/pupmod-simp-simp","homepage":null,"size":606,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":18,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/154"},"html":{"href":"https://github.com/simp/pupmod-simp-simp/pull/154"},"issue":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/154"},"comments":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/statuses/de444fffa45ebe0a778da17d72b3dfd1af626668"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jeefberkey"}}