{"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit5/pulls/comments/209449170","pull_request_review_id":145468554,"id":209449170,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQ0OTE3MA==","diff_hunk":"@@ -0,0 +1,9 @@\n+package org.junit.platform.runner;\n+\n+import org.junit.platform.launcher.Launcher;\n+\n+public class BenchmarksJUnitPlatform extends JUnitPlatform {","path":"platform-tests/src/jmh/java/org/junit/platform/runner/BenchmarksJUnitPlatform.java","position":5,"original_position":5,"commit_id":"1f47fd2b7c19c150185636661b385782ed4e5440","original_commit_id":"1f47fd2b7c19c150185636661b385782ed4e5440","user":{"login":"sbrannen","id":104798,"node_id":"MDQ6VXNlcjEwNDc5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/104798?v=4","gravatar_id":"","url":"https://api.github.com/users/sbrannen","html_url":"https://github.com/sbrannen","followers_url":"https://api.github.com/users/sbrannen/followers","following_url":"https://api.github.com/users/sbrannen/following{/other_user}","gists_url":"https://api.github.com/users/sbrannen/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrannen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrannen/subscriptions","organizations_url":"https://api.github.com/users/sbrannen/orgs","repos_url":"https://api.github.com/users/sbrannen/repos","events_url":"https://api.github.com/users/sbrannen/events{/privacy}","received_events_url":"https://api.github.com/users/sbrannen/received_events","type":"User","site_admin":false},"body":"Missing JavaDoc.","created_at":"2018-08-12T09:34:00Z","updated_at":"2018-08-12T09:34:17Z","html_url":"https://github.com/junit-team/junit5/pull/1539#discussion_r209449170","pull_request_url":"https://api.github.com/repos/junit-team/junit5/pulls/1539","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/comments/209449170"},"html":{"href":"https://github.com/junit-team/junit5/pull/1539#discussion_r209449170"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/1539"}}},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit5/pulls/1539","id":207812586,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODEyNTg2","html_url":"https://github.com/junit-team/junit5/pull/1539","diff_url":"https://github.com/junit-team/junit5/pull/1539.diff","patch_url":"https://github.com/junit-team/junit5/pull/1539.patch","issue_url":"https://api.github.com/repos/junit-team/junit5/issues/1539","number":1539,"state":"open","locked":false,"title":"Add platform benchmarks.","user":{"login":"fduminy","id":143904,"node_id":"MDQ6VXNlcjE0MzkwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/143904?v=4","gravatar_id":"","url":"https://api.github.com/users/fduminy","html_url":"https://github.com/fduminy","followers_url":"https://api.github.com/users/fduminy/followers","following_url":"https://api.github.com/users/fduminy/following{/other_user}","gists_url":"https://api.github.com/users/fduminy/gists{/gist_id}","starred_url":"https://api.github.com/users/fduminy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fduminy/subscriptions","organizations_url":"https://api.github.com/users/fduminy/orgs","repos_url":"https://api.github.com/users/fduminy/repos","events_url":"https://api.github.com/users/fduminy/events{/privacy}","received_events_url":"https://api.github.com/users/fduminy/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nThis PR add following platform benchmarks : \r\n- junit 4 platform\r\n    + ```junit4_platform_noTest()``` : run a test class with no test method using junit 4 platform\r\n    + ```junit4_platform_emptyTest()``` : run a test class with an empty test method using junit 4 platform\r\n- junit jupiter platform\r\n    + using ```VintageTestEngine```\r\n        * ```junitJupiter_platform_vintage_noTest()``` : run a test class with no test method using \r\n```VintageTestEngine```\r\n        * ```junitJupiter_platform_vintage_emptyTest()``` : run a test class with an empty test method using ```VintageTestEngine```\r\n    + using ```JupiterTestEngine```\r\n        * ```junitJupiter_platform_noTest()``` : run a test class with no test method using ```JupiterTestEngine```\r\n        * ```junitJupiter_platform_emptyTest()``` : run a test class with an empty test method using ```JupiterTestEngine```\r\n\r\n---\r\n\r\nI hereby agree to the terms of the [JUnit Contributor License Agreement](https://github.com/junit-team/junit5/blob/002a0052926ddee57cf90580fa49bc37e5a72427/CONTRIBUTING.md#junit-contributor-license-agreement).\r\n\r\n---\r\n\r\n### Definition of Done\r\n\r\n- [x] There are no TODOs left in the code\r\n- [ ] Method [preconditions](http://junit.org/junit5/docs/snapshot/api/org/junit/platform/commons/util/Preconditions.html) are checked and documented in the method's Javadoc\r\n- [ ] [Coding conventions](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#coding-conventions) (e.g. for logging) have been followed\r\n- [ ] Change is covered by [automated tests](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#tests) including corner cases, errors, and exception handling\r\n- [ ] Public API has [Javadoc](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#javadoc) and [`@API` annotations](http://junit.org/junit5/docs/snapshot/api/org/junit/platform/commons/meta/API.html)\r\n- [ ] Change is documented in the [User Guide](http://junit.org/junit5/docs/snapshot/user-guide/) and [Release Notes](http://junit.org/junit5/docs/snapshot/user-guide/#release-notes)\r\n- [ ] All [continuous integration builds](https://github.com/junit-team/junit5#continuous-integration-builds) pass\r\n","created_at":"2018-08-12T09:23:56Z","updated_at":"2018-08-12T09:34:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a8378bcdfb3765279668053ae0033d4d8395a75","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/junit-team/junit5/pulls/1539/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit5/pulls/1539/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/junit-team/junit5/issues/1539/comments","statuses_url":"https://api.github.com/repos/junit-team/junit5/statuses/1f47fd2b7c19c150185636661b385782ed4e5440","head":{"label":"fduminy:add_platform_benchmarks","ref":"add_platform_benchmarks","sha":"1f47fd2b7c19c150185636661b385782ed4e5440","user":{"login":"fduminy","id":143904,"node_id":"MDQ6VXNlcjE0MzkwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/143904?v=4","gravatar_id":"","url":"https://api.github.com/users/fduminy","html_url":"https://github.com/fduminy","followers_url":"https://api.github.com/users/fduminy/followers","following_url":"https://api.github.com/users/fduminy/following{/other_user}","gists_url":"https://api.github.com/users/fduminy/gists{/gist_id}","starred_url":"https://api.github.com/users/fduminy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fduminy/subscriptions","organizations_url":"https://api.github.com/users/fduminy/orgs","repos_url":"https://api.github.com/users/fduminy/repos","events_url":"https://api.github.com/users/fduminy/events{/privacy}","received_events_url":"https://api.github.com/users/fduminy/received_events","type":"User","site_admin":false},"repo":{"id":86150043,"node_id":"MDEwOlJlcG9zaXRvcnk4NjE1MDA0Mw==","name":"junit5","full_name":"fduminy/junit5","owner":{"login":"fduminy","id":143904,"node_id":"MDQ6VXNlcjE0MzkwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/143904?v=4","gravatar_id":"","url":"https://api.github.com/users/fduminy","html_url":"https://github.com/fduminy","followers_url":"https://api.github.com/users/fduminy/followers","following_url":"https://api.github.com/users/fduminy/following{/other_user}","gists_url":"https://api.github.com/users/fduminy/gists{/gist_id}","starred_url":"https://api.github.com/users/fduminy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fduminy/subscriptions","organizations_url":"https://api.github.com/users/fduminy/orgs","repos_url":"https://api.github.com/users/fduminy/repos","events_url":"https://api.github.com/users/fduminy/events{/privacy}","received_events_url":"https://api.github.com/users/fduminy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fduminy/junit5","description":"The next generation of JUnit.","fork":true,"url":"https://api.github.com/repos/fduminy/junit5","forks_url":"https://api.github.com/repos/fduminy/junit5/forks","keys_url":"https://api.github.com/repos/fduminy/junit5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fduminy/junit5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fduminy/junit5/teams","hooks_url":"https://api.github.com/repos/fduminy/junit5/hooks","issue_events_url":"https://api.github.com/repos/fduminy/junit5/issues/events{/number}","events_url":"https://api.github.com/repos/fduminy/junit5/events","assignees_url":"https://api.github.com/repos/fduminy/junit5/assignees{/user}","branches_url":"https://api.github.com/repos/fduminy/junit5/branches{/branch}","tags_url":"https://api.github.com/repos/fduminy/junit5/tags","blobs_url":"https://api.github.com/repos/fduminy/junit5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fduminy/junit5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fduminy/junit5/git/refs{/sha}","trees_url":"https://api.github.com/repos/fduminy/junit5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fduminy/junit5/statuses/{sha}","languages_url":"https://api.github.com/repos/fduminy/junit5/languages","stargazers_url":"https://api.github.com/repos/fduminy/junit5/stargazers","contributors_url":"https://api.github.com/repos/fduminy/junit5/contributors","subscribers_url":"https://api.github.com/repos/fduminy/junit5/subscribers","subscription_url":"https://api.github.com/repos/fduminy/junit5/subscription","commits_url":"https://api.github.com/repos/fduminy/junit5/commits{/sha}","git_commits_url":"https://api.github.com/repos/fduminy/junit5/git/commits{/sha}","comments_url":"https://api.github.com/repos/fduminy/junit5/comments{/number}","issue_comment_url":"https://api.github.com/repos/fduminy/junit5/issues/comments{/number}","contents_url":"https://api.github.com/repos/fduminy/junit5/contents/{+path}","compare_url":"https://api.github.com/repos/fduminy/junit5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fduminy/junit5/merges","archive_url":"https://api.github.com/repos/fduminy/junit5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fduminy/junit5/downloads","issues_url":"https://api.github.com/repos/fduminy/junit5/issues{/number}","pulls_url":"https://api.github.com/repos/fduminy/junit5/pulls{/number}","milestones_url":"https://api.github.com/repos/fduminy/junit5/milestones{/number}","notifications_url":"https://api.github.com/repos/fduminy/junit5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fduminy/junit5/labels{/name}","releases_url":"https://api.github.com/repos/fduminy/junit5/releases{/id}","deployments_url":"https://api.github.com/repos/fduminy/junit5/deployments","created_at":"2017-03-25T10:40:54Z","updated_at":"2018-08-12T08:49:48Z","pushed_at":"2018-08-12T09:14:04Z","git_url":"git://github.com/fduminy/junit5.git","ssh_url":"git@github.com:fduminy/junit5.git","clone_url":"https://github.com/fduminy/junit5.git","svn_url":"https://github.com/fduminy/junit5","homepage":"http://junit.org/junit5/","size":123893,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"junit-team:master","ref":"master","sha":"db51ef451da5ea898b63236f997c76589991bd3b","user":{"login":"junit-team","id":874086,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NDA4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/874086?v=4","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":29102367,"node_id":"MDEwOlJlcG9zaXRvcnkyOTEwMjM2Nw==","name":"junit5","full_name":"junit-team/junit5","owner":{"login":"junit-team","id":874086,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NDA4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/874086?v=4","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit5","description":"The next generation of JUnit.","fork":false,"url":"https://api.github.com/repos/junit-team/junit5","forks_url":"https://api.github.com/repos/junit-team/junit5/forks","keys_url":"https://api.github.com/repos/junit-team/junit5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit5/teams","hooks_url":"https://api.github.com/repos/junit-team/junit5/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit5/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit5/events","assignees_url":"https://api.github.com/repos/junit-team/junit5/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit5/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit5/tags","blobs_url":"https://api.github.com/repos/junit-team/junit5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit5/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit5/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit5/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit5/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit5/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit5/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit5/subscription","commits_url":"https://api.github.com/repos/junit-team/junit5/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit5/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit5/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit5/issues/comments{/number}","contents_url":"https://api.github.com/repos/junit-team/junit5/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit5/merges","archive_url":"https://api.github.com/repos/junit-team/junit5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit5/downloads","issues_url":"https://api.github.com/repos/junit-team/junit5/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit5/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit5/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit5/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit5/releases{/id}","deployments_url":"https://api.github.com/repos/junit-team/junit5/deployments","created_at":"2015-01-11T19:06:10Z","updated_at":"2018-08-12T06:27:09Z","pushed_at":"2018-08-12T09:23:57Z","git_url":"git://github.com/junit-team/junit5.git","ssh_url":"git@github.com:junit-team/junit5.git","clone_url":"https://github.com/junit-team/junit5.git","svn_url":"https://github.com/junit-team/junit5","homepage":"https://junit.org","size":506146,"stargazers_count":2337,"watchers_count":2337,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":528,"mirror_url":null,"archived":false,"open_issues_count":160,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":528,"open_issues":160,"watchers":2337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/1539"},"html":{"href":"https://github.com/junit-team/junit5/pull/1539"},"issue":{"href":"https://api.github.com/repos/junit-team/junit5/issues/1539"},"comments":{"href":"https://api.github.com/repos/junit-team/junit5/issues/1539/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/1539/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/1539/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit5/statuses/1f47fd2b7c19c150185636661b385782ed4e5440"}},"author_association":"NONE"}}
{"actor":{"display_login":"sbrannen"}}