{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-security/pulls/comments/242334824","pull_request_review_id":185822000,"id":242334824,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjMzNDgyNA==","diff_hunk":"@@ -40,17 +40,6 @@\n \t@Mock\n \tprivate Method method;\n \n-\t@Test(expected = IllegalStateException.class)","path":"web/src/test/java/org/springframework/security/web/authentication/session/ChangeSessionIdAuthenticationStrategyTests.java","position":4,"original_position":4,"commit_id":"dbfd5760580b0430666d2fd35b6b45fb3ee52ebb","original_commit_id":"dbfd5760580b0430666d2fd35b6b45fb3ee52ebb","user":{"login":"raphaelDL","id":5624449,"node_id":"MDQ6VXNlcjU2MjQ0NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5624449?v=4","gravatar_id":"","url":"https://api.github.com/users/raphaelDL","html_url":"https://github.com/raphaelDL","followers_url":"https://api.github.com/users/raphaelDL/followers","following_url":"https://api.github.com/users/raphaelDL/following{/other_user}","gists_url":"https://api.github.com/users/raphaelDL/gists{/gist_id}","starred_url":"https://api.github.com/users/raphaelDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphaelDL/subscriptions","organizations_url":"https://api.github.com/users/raphaelDL/orgs","repos_url":"https://api.github.com/users/raphaelDL/repos","events_url":"https://api.github.com/users/raphaelDL/events{/privacy}","received_events_url":"https://api.github.com/users/raphaelDL/received_events","type":"User","site_admin":false},"body":"Another question, now that the reflection operation is removed, what should we test instead of this??\r\n\r\n```java \r\n\r\n@Test\r\n\t\tpublic void applySessionFixation() throws Exception {\r\n\t\t\tspy(ReflectionUtils.class);\r\n \t\tMethod method = mock(Method.class);\r\n \t\tMockHttpServletRequest request = new MockHttpServletRequest();\r\n \t\trequest.getSession();\r\n \t\twhen(ReflectionUtils.findMethod(HttpServletRequest.class, \"changeSessionId\"))\r\n \t\t\t\t.thenReturn(method);\r\n \r\n \t\tnew ChangeSessionIdAuthenticationStrategy().applySessionFixation(request);\r\n \r\n \t\tverifyStatic(ReflectionUtils.class);\r\n \t\tReflectionUtils.invokeMethod(same(method), eq(request));\r\n```\r\n\r\n\r\nI was thinking on something like this, maybe\r\n\r\n```java\r\n@Test\r\n\tpublic void applySessionFixation() {\r\n\t\tMockHttpServletRequest request = new MockHttpServletRequest();\r\n\t\tString beforeSessionFixation = request.getSession().getId();\r\n\r\n\t\t\tnew ChangeSessionIdAuthenticationStrategy().applySessionFixation(request);\r\n\r\n\t\tString afterSessionFixation = request.getSession().getId();\r\n\r\n\t\tAssert.assertNotEquals(beforeSessionFixation,afterSessionFixation);\r\n\t}\r\n```\r\n\r\n\r\nwhat do you think???\r\n","created_at":"2018-12-17T22:09:04Z","updated_at":"2018-12-17T22:09:04Z","html_url":"https://github.com/spring-projects/spring-security/pull/6297#discussion_r242334824","pull_request_url":"https://api.github.com/repos/spring-projects/spring-security/pulls/6297","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/comments/242334824"},"html":{"href":"https://github.com/spring-projects/spring-security/pull/6297#discussion_r242334824"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/6297"}},"in_reply_to_id":242284253},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-security/pulls/6297","id":239252882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjUyODgy","html_url":"https://github.com/spring-projects/spring-security/pull/6297","diff_url":"https://github.com/spring-projects/spring-security/pull/6297.diff","patch_url":"https://github.com/spring-projects/spring-security/pull/6297.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-security/issues/6297","number":6297,"state":"open","locked":false,"title":"Remove Servlet 2.5 Support for Session Fixation","user":{"login":"raphaelDL","id":5624449,"node_id":"MDQ6VXNlcjU2MjQ0NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5624449?v=4","gravatar_id":"","url":"https://api.github.com/users/raphaelDL","html_url":"https://github.com/raphaelDL","followers_url":"https://api.github.com/users/raphaelDL/followers","following_url":"https://api.github.com/users/raphaelDL/following{/other_user}","gists_url":"https://api.github.com/users/raphaelDL/gists{/gist_id}","starred_url":"https://api.github.com/users/raphaelDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphaelDL/subscriptions","organizations_url":"https://api.github.com/users/raphaelDL/orgs","repos_url":"https://api.github.com/users/raphaelDL/repos","events_url":"https://api.github.com/users/raphaelDL/events{/privacy}","received_events_url":"https://api.github.com/users/raphaelDL/received_events","type":"User","site_admin":false},"body":"This commit removes existence validation of a method only available in Servlet 3.1.\r\nSpring Framework baseline is Servlet 3.1 so is not longer required.\r\n\r\nFixes: gh-6259\r\n\r\n","created_at":"2018-12-17T19:10:35Z","updated_at":"2018-12-17T22:09:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4604e2244b9d9fefa9d11b3e96b80dc32bba8ecd","assignee":{"login":"jzheaux","id":3627351,"node_id":"MDQ6VXNlcjM2MjczNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3627351?v=4","gravatar_id":"","url":"https://api.github.com/users/jzheaux","html_url":"https://github.com/jzheaux","followers_url":"https://api.github.com/users/jzheaux/followers","following_url":"https://api.github.com/users/jzheaux/following{/other_user}","gists_url":"https://api.github.com/users/jzheaux/gists{/gist_id}","starred_url":"https://api.github.com/users/jzheaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzheaux/subscriptions","organizations_url":"https://api.github.com/users/jzheaux/orgs","repos_url":"https://api.github.com/users/jzheaux/repos","events_url":"https://api.github.com/users/jzheaux/events{/privacy}","received_events_url":"https://api.github.com/users/jzheaux/received_events","type":"User","site_admin":false},"assignees":[{"login":"jzheaux","id":3627351,"node_id":"MDQ6VXNlcjM2MjczNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3627351?v=4","gravatar_id":"","url":"https://api.github.com/users/jzheaux","html_url":"https://github.com/jzheaux","followers_url":"https://api.github.com/users/jzheaux/followers","following_url":"https://api.github.com/users/jzheaux/following{/other_user}","gists_url":"https://api.github.com/users/jzheaux/gists{/gist_id}","starred_url":"https://api.github.com/users/jzheaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzheaux/subscriptions","organizations_url":"https://api.github.com/users/jzheaux/orgs","repos_url":"https://api.github.com/users/jzheaux/repos","events_url":"https://api.github.com/users/jzheaux/events{/privacy}","received_events_url":"https://api.github.com/users/jzheaux/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":322225082,"node_id":"MDU6TGFiZWwzMjIyMjUwODI=","url":"https://api.github.com/repos/spring-projects/spring-security/labels/Improvement","name":"Improvement","color":"eeeeee","default":false},{"id":322225078,"node_id":"MDU6TGFiZWwzMjIyMjUwNzg=","url":"https://api.github.com/repos/spring-projects/spring-security/labels/Web","name":"Web","color":"000000","default":false},{"id":202036840,"node_id":"MDU6TGFiZWwyMDIwMzY4NDA=","url":"https://api.github.com/repos/spring-projects/spring-security/labels/duplicate","name":"duplicate","color":"eeeeee","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-security/pulls/6297/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-security/pulls/6297/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-security/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-security/issues/6297/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-security/statuses/dbfd5760580b0430666d2fd35b6b45fb3ee52ebb","head":{"label":"raphaelDL:gh-6259","ref":"gh-6259","sha":"dbfd5760580b0430666d2fd35b6b45fb3ee52ebb","user":{"login":"raphaelDL","id":5624449,"node_id":"MDQ6VXNlcjU2MjQ0NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5624449?v=4","gravatar_id":"","url":"https://api.github.com/users/raphaelDL","html_url":"https://github.com/raphaelDL","followers_url":"https://api.github.com/users/raphaelDL/followers","following_url":"https://api.github.com/users/raphaelDL/following{/other_user}","gists_url":"https://api.github.com/users/raphaelDL/gists{/gist_id}","starred_url":"https://api.github.com/users/raphaelDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphaelDL/subscriptions","organizations_url":"https://api.github.com/users/raphaelDL/orgs","repos_url":"https://api.github.com/users/raphaelDL/repos","events_url":"https://api.github.com/users/raphaelDL/events{/privacy}","received_events_url":"https://api.github.com/users/raphaelDL/received_events","type":"User","site_admin":false},"repo":{"id":124954156,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5NTQxNTY=","name":"spring-security","full_name":"raphaelDL/spring-security","private":false,"owner":{"login":"raphaelDL","id":5624449,"node_id":"MDQ6VXNlcjU2MjQ0NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5624449?v=4","gravatar_id":"","url":"https://api.github.com/users/raphaelDL","html_url":"https://github.com/raphaelDL","followers_url":"https://api.github.com/users/raphaelDL/followers","following_url":"https://api.github.com/users/raphaelDL/following{/other_user}","gists_url":"https://api.github.com/users/raphaelDL/gists{/gist_id}","starred_url":"https://api.github.com/users/raphaelDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphaelDL/subscriptions","organizations_url":"https://api.github.com/users/raphaelDL/orgs","repos_url":"https://api.github.com/users/raphaelDL/repos","events_url":"https://api.github.com/users/raphaelDL/events{/privacy}","received_events_url":"https://api.github.com/users/raphaelDL/received_events","type":"User","site_admin":false},"html_url":"https://github.com/raphaelDL/spring-security","description":"Spring Security","fork":true,"url":"https://api.github.com/repos/raphaelDL/spring-security","forks_url":"https://api.github.com/repos/raphaelDL/spring-security/forks","keys_url":"https://api.github.com/repos/raphaelDL/spring-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raphaelDL/spring-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raphaelDL/spring-security/teams","hooks_url":"https://api.github.com/repos/raphaelDL/spring-security/hooks","issue_events_url":"https://api.github.com/repos/raphaelDL/spring-security/issues/events{/number}","events_url":"https://api.github.com/repos/raphaelDL/spring-security/events","assignees_url":"https://api.github.com/repos/raphaelDL/spring-security/assignees{/user}","branches_url":"https://api.github.com/repos/raphaelDL/spring-security/branches{/branch}","tags_url":"https://api.github.com/repos/raphaelDL/spring-security/tags","blobs_url":"https://api.github.com/repos/raphaelDL/spring-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raphaelDL/spring-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raphaelDL/spring-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/raphaelDL/spring-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raphaelDL/spring-security/statuses/{sha}","languages_url":"https://api.github.com/repos/raphaelDL/spring-security/languages","stargazers_url":"https://api.github.com/repos/raphaelDL/spring-security/stargazers","contributors_url":"https://api.github.com/repos/raphaelDL/spring-security/contributors","subscribers_url":"https://api.github.com/repos/raphaelDL/spring-security/subscribers","subscription_url":"https://api.github.com/repos/raphaelDL/spring-security/subscription","commits_url":"https://api.github.com/repos/raphaelDL/spring-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/raphaelDL/spring-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/raphaelDL/spring-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/raphaelDL/spring-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/raphaelDL/spring-security/contents/{+path}","compare_url":"https://api.github.com/repos/raphaelDL/spring-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raphaelDL/spring-security/merges","archive_url":"https://api.github.com/repos/raphaelDL/spring-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raphaelDL/spring-security/downloads","issues_url":"https://api.github.com/repos/raphaelDL/spring-security/issues{/number}","pulls_url":"https://api.github.com/repos/raphaelDL/spring-security/pulls{/number}","milestones_url":"https://api.github.com/repos/raphaelDL/spring-security/milestones{/number}","notifications_url":"https://api.github.com/repos/raphaelDL/spring-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raphaelDL/spring-security/labels{/name}","releases_url":"https://api.github.com/repos/raphaelDL/spring-security/releases{/id}","deployments_url":"https://api.github.com/repos/raphaelDL/spring-security/deployments","created_at":"2018-03-12T21:31:53Z","updated_at":"2018-12-17T17:58:28Z","pushed_at":"2018-12-17T19:11:43Z","git_url":"git://github.com/raphaelDL/spring-security.git","ssh_url":"git@github.com:raphaelDL/spring-security.git","clone_url":"https://github.com/raphaelDL/spring-security.git","svn_url":"https://github.com/raphaelDL/spring-security","homepage":"http://spring.io/spring-security","size":32775,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"3bcb1d945881a9d64902308f159cfd4d027ac173","user":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":3148979,"node_id":"MDEwOlJlcG9zaXRvcnkzMTQ4OTc5","name":"spring-security","full_name":"spring-projects/spring-security","private":false,"owner":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spring-projects/spring-security","description":"Spring Security","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-security","forks_url":"https://api.github.com/repos/spring-projects/spring-security/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-security/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-security/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-security/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-security/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-security/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-security/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-security/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-security/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-security/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-security/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-security/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-security/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-security/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-security/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-security/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-security/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-security/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-security/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-security/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-security/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-security/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-security/deployments","created_at":"2012-01-10T21:50:57Z","updated_at":"2018-12-17T21:13:06Z","pushed_at":"2018-12-17T21:12:55Z","git_url":"git://github.com/spring-projects/spring-security.git","ssh_url":"git@github.com:spring-projects/spring-security.git","clone_url":"https://github.com/spring-projects/spring-security.git","svn_url":"https://github.com/spring-projects/spring-security","homepage":"http://spring.io/spring-security","size":33326,"stargazers_count":3036,"watchers_count":3036,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2809,"mirror_url":null,"archived":false,"open_issues_count":899,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2809,"open_issues":899,"watchers":3036,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/6297"},"html":{"href":"https://github.com/spring-projects/spring-security/pull/6297"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-security/issues/6297"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-security/issues/6297/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/6297/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/6297/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-security/statuses/dbfd5760580b0430666d2fd35b6b45fb3ee52ebb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"raphaelDL"}}