{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/dusk/issues/492","repository_url":"https://api.github.com/repos/laravel/dusk","labels_url":"https://api.github.com/repos/laravel/dusk/issues/492/labels{/name}","comments_url":"https://api.github.com/repos/laravel/dusk/issues/492/comments","events_url":"https://api.github.com/repos/laravel/dusk/issues/492/events","html_url":"https://github.com/laravel/dusk/pull/492","id":306263458,"number":492,"title":"[Proposal] Artisan command for updating ChromeDriver","user":{"login":"staudenmeir","id":1853169,"avatar_url":"https://avatars3.githubusercontent.com/u/1853169?v=4","gravatar_id":"","url":"https://api.github.com/users/staudenmeir","html_url":"https://github.com/staudenmeir","followers_url":"https://api.github.com/users/staudenmeir/followers","following_url":"https://api.github.com/users/staudenmeir/following{/other_user}","gists_url":"https://api.github.com/users/staudenmeir/gists{/gist_id}","starred_url":"https://api.github.com/users/staudenmeir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staudenmeir/subscriptions","organizations_url":"https://api.github.com/users/staudenmeir/orgs","repos_url":"https://api.github.com/users/staudenmeir/repos","events_url":"https://api.github.com/users/staudenmeir/events{/privacy}","received_events_url":"https://api.github.com/users/staudenmeir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-18T17:56:07Z","updated_at":"2018-03-18T20:41:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/laravel/dusk/pulls/492","html_url":"https://github.com/laravel/dusk/pull/492","diff_url":"https://github.com/laravel/dusk/pull/492.diff","patch_url":"https://github.com/laravel/dusk/pull/492.patch"},"body":"This PR proposes an Artisan command for updating the ChromeDriver binaries:\r\n\r\n    php artisan dusk:update\r\n\r\nIt can be used to immediately get the latest ChromeDriver version after its release.\r\nPeople with Laravel 5.4 can use it to keep their Dusk 1.* installation alive (#490).\r\nBy running it after `composer install/update` it could also replace shipping the binaries with Dusk altogether.\r\n\r\nI tested it on Linux and Windows. Can someone please test it on a Mac?\r\n\r\nThe command requires the [PHP Zip extension](http://www.php.net/manual/en/book.zip.php).\r\n\r\nIt currently downloads the binaries for all three operating systems.\r\nI thought about only updating the ChromeDriver for the running OS. But there could be cases where people run Homestead on Mac/Windows and accidentally execute the update command on the Host OS. Then they would still be using the old ChromeDriver in Homestead.\r\nWe could also add the option to specify the OS (e.g. `--linux`).\r\n\r\nAnother improvement could be to compare the installed ChromeDriver version with the latest release to avoid unnecessary downloads. I just wanted to get some feedback before implementing those.\r\n"},"comment":{"url":"https://api.github.com/repos/laravel/dusk/issues/comments/374044345","html_url":"https://github.com/laravel/dusk/pull/492#issuecomment-374044345","issue_url":"https://api.github.com/repos/laravel/dusk/issues/492","id":374044345,"user":{"login":"staudenmeir","id":1853169,"avatar_url":"https://avatars3.githubusercontent.com/u/1853169?v=4","gravatar_id":"","url":"https://api.github.com/users/staudenmeir","html_url":"https://github.com/staudenmeir","followers_url":"https://api.github.com/users/staudenmeir/followers","following_url":"https://api.github.com/users/staudenmeir/following{/other_user}","gists_url":"https://api.github.com/users/staudenmeir/gists{/gist_id}","starred_url":"https://api.github.com/users/staudenmeir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staudenmeir/subscriptions","organizations_url":"https://api.github.com/users/staudenmeir/orgs","repos_url":"https://api.github.com/users/staudenmeir/repos","events_url":"https://api.github.com/users/staudenmeir/events{/privacy}","received_events_url":"https://api.github.com/users/staudenmeir/received_events","type":"User","site_admin":false},"created_at":"2018-03-18T20:41:37Z","updated_at":"2018-03-18T20:41:37Z","author_association":"CONTRIBUTOR","body":"If the binaries get removed from the repository and the command is the only way to get them, we could add an alternative like [PclZip](https://packagist.org/packages/pclzip/pclzip)."}}
{"actor":{"display_login":"staudenmeir"}}