{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-amplify/issues/633","repository_url":"https://api.github.com/repos/aws/aws-amplify","labels_url":"https://api.github.com/repos/aws/aws-amplify/issues/633/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-amplify/issues/633/comments","events_url":"https://api.github.com/repos/aws/aws-amplify/issues/633/events","html_url":"https://github.com/aws/aws-amplify/pull/633","id":313357979,"number":633,"title":"Doc : Add errors from API handling examples","user":{"login":"seblegall","id":3866325,"avatar_url":"https://avatars1.githubusercontent.com/u/3866325?v=4","gravatar_id":"","url":"https://api.github.com/users/seblegall","html_url":"https://github.com/seblegall","followers_url":"https://api.github.com/users/seblegall/followers","following_url":"https://api.github.com/users/seblegall/following{/other_user}","gists_url":"https://api.github.com/users/seblegall/gists{/gist_id}","starred_url":"https://api.github.com/users/seblegall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seblegall/subscriptions","organizations_url":"https://api.github.com/users/seblegall/orgs","repos_url":"https://api.github.com/users/seblegall/repos","events_url":"https://api.github.com/users/seblegall/events{/privacy}","received_events_url":"https://api.github.com/users/seblegall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-11T14:48:35Z","updated_at":"2018-04-11T14:55:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aws/aws-amplify/pulls/633","html_url":"https://github.com/aws/aws-amplify/pull/633","diff_url":"https://github.com/aws/aws-amplify/pull/633.diff","patch_url":"https://github.com/aws/aws-amplify/pull/633.patch"},"body":"*Fix Issue #582*\r\n\r\nI found out, by reading the source code, that aws-amplify is using Axios to handle http calls. This choice introduce a particular way of manage errors coming from API comparing to Fetch. (see [this issue](https://github.com/axios/axios/issues/960) )\r\n\r\nThis PR is a proposal for explicitly tell developers that Axios is used.\r\n\r\nBy doing this, it also makes much clearer the use of an `init` object (called `myInit` in the examples) as a parameter of the `get()`, `post()`, etc. methods. This object is indeed, at the end, the documented `param` parameter in the corresponding methods in Axios.\r\n\r\nIt also warn the developers that status code > 299 are thrown as an exception. Which is not obvious when using Fetch.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n"},"comment":{"url":"https://api.github.com/repos/aws/aws-amplify/issues/comments/380482189","html_url":"https://github.com/aws/aws-amplify/pull/633#issuecomment-380482189","issue_url":"https://api.github.com/repos/aws/aws-amplify/issues/633","id":380482189,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T14:55:14Z","updated_at":"2018-04-11T14:55:14Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/aws/aws-amplify/pull/633?src=pr&el=h1) Report\n> :exclamation: No coverage uploaded for pull request base (`master@a414b1c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/aws/aws-amplify/pull/633/graphs/tree.svg?src=pr&token=C198gleAiM&width=650&height=150)](https://codecov.io/gh/aws/aws-amplify/pull/633?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##             master     #633   +/-   ##\n=========================================\n  Coverage          ?   89.19%           \n=========================================\n  Files             ?       69           \n  Lines             ?     3221           \n  Branches          ?      612           \n=========================================\n  Hits              ?     2873           \n  Misses            ?      330           \n  Partials          ?       18\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/aws/aws-amplify/pull/633?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/aws/aws-amplify/pull/633?src=pr&el=footer). Last update [a414b1c...ebbda0c](https://codecov.io/gh/aws/aws-amplify/pull/633?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}