{"action":"created","issue":{"url":"https://api.github.com/repos/awslabs/aws-cdk/issues/694","repository_url":"https://api.github.com/repos/awslabs/aws-cdk","labels_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/694/labels{/name}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/694/comments","events_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/694/events","html_url":"https://github.com/awslabs/aws-cdk/issues/694","id":359431718,"node_id":"MDU6SXNzdWUzNTk0MzE3MTg=","number":694,"title":"Improve \"cdk diff\" for complex values","user":{"login":"eladb","id":598796,"node_id":"MDQ6VXNlcjU5ODc5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/598796?v=4","gravatar_id":"","url":"https://api.github.com/users/eladb","html_url":"https://github.com/eladb","followers_url":"https://api.github.com/users/eladb/followers","following_url":"https://api.github.com/users/eladb/following{/other_user}","gists_url":"https://api.github.com/users/eladb/gists{/gist_id}","starred_url":"https://api.github.com/users/eladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladb/subscriptions","organizations_url":"https://api.github.com/users/eladb/orgs","repos_url":"https://api.github.com/users/eladb/repos","events_url":"https://api.github.com/users/eladb/events{/privacy}","received_events_url":"https://api.github.com/users/eladb/received_events","type":"User","site_admin":false},"labels":[{"id":1118286494,"node_id":"MDU6TGFiZWwxMTE4Mjg2NDk0","url":"https://api.github.com/repos/awslabs/aws-cdk/labels/%F0%9F%9B%A0%20toolkit","name":"🛠 toolkit","color":"c1a203","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-12T11:11:23Z","updated_at":"2018-11-07T09:58:12Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"This is not very useful:\r\n\r\n```\r\n[~] 🛠 Updating PipelineNuGetRoleDefaultPolicy84E02308 (type: AWS::IAM::Policy)\r\n └─ [~] .PolicyDocument:\r\n     └─ [~] .Statement:\r\n         ├─ [-] Old value: [{\"Action\":[\"s3:GetObject*\",\"s3:GetBucket*\",\"s3:List*\"],\"Effect\":\"Allow\",\"Resource\":[{\"Fn::GetAtt\":[\"PipelineReleases5C76C352\",\"Arn\"]},{\"Fn::Join\":[\"\",[{\"Fn::GetAtt\":[\"PipelineReleases5C76C352\",\"Arn\"]},\"/\",\"*\"]]}]},{\"Action\":[\"logs:CreateLogGroup\",\"logs:CreateLogStream\",\"logs:PutLogEvents\"],\"Effect\":\"Allow\",\"Resource\":[{\"Fn::Join\":[\"\",[\"arn\",\":\",{\"Ref\":\"AWS::Partition\"},\":\",\"logs\",\":\",{\"Ref\":\"AWS::Region\"},\":\",{\"Ref\":\"AWS::AccountId\"},\":\",\"log-group\",\":\",\"/aws/codebuild/\",{\"Ref\":\"PipelineNuGetC3DF492B\"}]]},{\"Fn::Join\":[\"\",[{\"Fn::Join\":[\"\",[\"arn\",\":\",{\"Ref\":\"AWS::Partition\"},\":\",\"logs\",\":\",{\"Ref\":\"AWS::Region\"},\":\",{\"Ref\":\"AWS::AccountId\"},\":\",\"log-group\",\":\",\"/aws/codebuild/\",{\"Ref\":\"PipelineNuGetC3DF492B\"}]]},\":*\"]]}]},{\"Action\":[\"s3:GetObject*\",\"s3:GetBucket*\",\"s3:List*\"],\"Effect\":\"Allow\",\"Resource\":[{\"Fn::Join\":[\"\",[\"arn\",\":\",{\"Ref\":\"AWS::Partition\"},\":\",\"s3\",\":\",\"\",\":\",\"\",\":\",{\"Ref\":\"PipelineNuGetScriptDirectoryS3Bucket3A6047B2\"}]]},{\"Fn::Join\":[\"\",[{\"Fn::Join\":[\"\",[\"arn\",\":\",{\"Ref\":\"AWS::Partition\"},\":\",\"s3\",\":\",\"\",\":\",\"\",\":\",{\"Ref\":\"PipelineNuGetScriptDirectoryS3Bucket3A6047B2\"}]]},\"/\",{\"Fn::Join\":[\"\",[{\"Fn::Select\":[0,{\"Fn::Split\":[\"||\",{\"Ref\":\"PipelineNuGetScriptDirectoryS3VersionKeyB4B82356\"}]}]},\"*\"]]}]]}]},{\"Action\":[\"secretsmanager:ListSecrets\",\"secretsmanager:DescribeSecret\",\"secretsmanager:GetSecretValue\"],\"Effect\":\"Allow\",\"Resource\":\"arn:aws:secretsmanager:us-east-1:585695036304:secret:benisrae-nuget-publish-PbXG8J\"},{\"Action\":\"kms:Decrypt\",\"Effect\":\"Allow\",\"Resource\":\"arn:aws:kms:us-east-1:585695036304:key/0dc7ab85-2ad3-4e85-b3aa-9108e508f89f\"},{\"Action\":[\"s3:GetObject*\",\"s3:GetBucket*\",\"s3:List*\",\"s3:DeleteObject*\",\"s3:PutObject*\",\"s3:Abort*\"],\"Effect\":\"Allow\",\"Resource\":[{\"Fn::GetAtt\":[\"PipelineBuildPipelineArtifactsBucket1264F2DB\",\"Arn\"]},{\"Fn::Join\":[\"\",[{\"Fn::GetAtt\":[\"PipelineBuildPipelineArtifactsBucket1264F2DB\",\"Arn\"]},\"/\",\"*\"]]}]}]\r\n         └─ [+] New value: [{\"Action\":[\"s3:GetObject*\",\"s3:GetBucket*\",\"s3:List*\"],\"Effect\":\"Allow\",\"Resource\":[{\"Fn::GetAtt\":[\"PipelineReleases5C76C352\",\"Arn\"]},{\"Fn::Join\":[\"\",[{\"Fn::GetAtt\":[\"PipelineReleases5C76C352\",\"Arn\"]},\"/\",\"*\"]]}]},{\"Action\":[\"logs:CreateLogGroup\",\"logs:CreateLogStream\",\"logs:PutLogEvents\"],\"Effect\":\"Allow\",\"Resource\":[{\"Fn::Join\":[\"\",[\"arn\",\":\",{\"Ref\":\"AWS::Partition\"},\":\",\"logs\",\":\",{\"Ref\":\"AWS::Region\"},\":\",{\"Ref\":\"AWS::AccountId\"},\":\",\"log-group\",\":\",\"/aws/codebuild/\",{\"Ref\":\"PipelineNuGetC3DF492B\"}]]},{\"Fn::Join\":[\"\",[{\"Fn::Join\":[\"\",[\"arn\",\":\",{\"Ref\":\"AWS::Partition\"},\":\",\"logs\",\":\",{\"Ref\":\"AWS::Region\"},\":\",{\"Ref\":\"AWS::AccountId\"},\":\",\"log-group\",\":\",\"/aws/codebuild/\",{\"Ref\":\"PipelineNuGetC3DF492B\"}]]},\":*\"]]}]},{\"Action\":[\"s3:GetObject*\",\"s3:GetBucket*\",\"s3:List*\"],\"Effect\":\"Allow\",\"Resource\":[{\"Fn::Join\":[\"\",[\"arn\",\":\",{\"Ref\":\"AWS::Partition\"},\":\",\"s3\",\":\",\"\",\":\",\"\",\":\",{\"Ref\":\"PipelineNuGetScriptDirectoryS3Bucket3A6047B2\"}]]},{\"Fn::Join\":[\"\",[{\"Fn::Join\":[\"\",[\"arn\",\":\",{\"Ref\":\"AWS::Partition\"},\":\",\"s3\",\":\",\"\",\":\",\"\",\":\",{\"Ref\":\"PipelineNuGetScriptDirectoryS3Bucket3A6047B2\"}]]},\"/\",{\"Fn::Join\":[\"\",[{\"Fn::Select\":[0,{\"Fn::Split\":[\"||\",{\"Ref\":\"PipelineNuGetScriptDirectoryS3VersionKeyB4B82356\"}]}]},\"*\"]]}]]}]},{\"Action\":[\"secretsmanager:ListSecrets\",\"secretsmanager:DescribeSecret\",\"secretsmanager:GetSecretValue\"],\"Effect\":\"Allow\",\"Resource\":\"arn:aws:secretsmanager:us-east-1:585695036304:secret:benisrae-nuget-publish-PbXG8J\"},{\"Action\":\"kms:Decrypt\",\"Effect\":\"Allow\",\"Resource\":\"arn:aws:kms:us-east-1:585695036304:key/0dc7ab85-2ad3-4e85-b3aa-9108e508f89\"},{\"Action\":[\"s3:GetObject*\",\"s3:GetBucket*\",\"s3:List*\",\"s3:DeleteObject*\",\"s3:PutObject*\",\"s3:Abort*\"],\"Effect\":\"Allow\",\"Resource\":[{\"Fn::GetAtt\":[\"PipelineBuildPipelineArtifactsBucket1264F2DB\",\"Arn\"]},{\"Fn::Join\":[\"\",[{\"Fn::GetAtt\":[\"PipelineBuildPipelineArtifactsBucket1264F2DB\",\"Arn\"]},\"/\",\"*\"]]}]}]\r\n```\r\n\r\nWould be nice if we could show a more specific JSON diff of these two values. Perhaps even special-case IAM policy documents and show added/removed permissions, etc."},"comment":{"url":"https://api.github.com/repos/awslabs/aws-cdk/issues/comments/436569283","html_url":"https://github.com/awslabs/aws-cdk/issues/694#issuecomment-436569283","issue_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/694","id":436569283,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjU2OTI4Mw==","user":{"login":"rix0rrr","id":524162,"node_id":"MDQ6VXNlcjUyNDE2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/524162?v=4","gravatar_id":"","url":"https://api.github.com/users/rix0rrr","html_url":"https://github.com/rix0rrr","followers_url":"https://api.github.com/users/rix0rrr/followers","following_url":"https://api.github.com/users/rix0rrr/following{/other_user}","gists_url":"https://api.github.com/users/rix0rrr/gists{/gist_id}","starred_url":"https://api.github.com/users/rix0rrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rix0rrr/subscriptions","organizations_url":"https://api.github.com/users/rix0rrr/orgs","repos_url":"https://api.github.com/users/rix0rrr/repos","events_url":"https://api.github.com/users/rix0rrr/events{/privacy}","received_events_url":"https://api.github.com/users/rix0rrr/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T09:58:12Z","updated_at":"2018-11-07T09:58:12Z","author_association":"CONTRIBUTOR","body":"Related: https://github.com/awslabs/aws-cdk/issues/978"}}
{"actor":{"display_login":"rix0rrr"}}