{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/213287444","pull_request_review_id":150090639,"id":213287444,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzI4NzQ0NA==","diff_hunk":"@@ -450,6 +450,28 @@ static void test_ipv6_addr_best_src__other_subnet(void)\n     TEST_ASSERT(!ipv6_addr_is_unspecified(out));\n }\n \n+static void test_ipv6_addr_best_src__ula_src_dst(void)\n+{\n+    static const ipv6_addr_t ula_src = { .u8 = NETIF0_IPV6_ULA };\n+    static const ipv6_addr_t ula_dst = { .u8 = { ULA1, ULA2, ULA3, ULA4,\n+                                                 ULA5, ULA6, ULA7, ULA8,\n+                                                 0, 0, 0, 0, 0, 0, 0, 1 } };\n+    ipv6_addr_t *out = NULL;\n+    int idx;\n+\n+    test_ipv6_addr_add__success();\n+    TEST_ASSERT(0 <= (idx = gnrc_netif_ipv6_addr_add_internal(netifs[0], &ula_src, 64U,","path":"tests/gnrc_netif/main.c","position":14,"original_position":14,"commit_id":"c1926414ab79879e63cea97c92a4df62a2756430","original_commit_id":"c1926414ab79879e63cea97c92a4df62a2756430","user":{"login":"smlng","id":10532675,"node_id":"MDQ6VXNlcjEwNTMyNjc1","avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"body":"well the TENTATIVE case should be tested for ULAs too, bc that's what we also want to verify, right? Adding tests for real/global addresses could be another PR.","created_at":"2018-08-28T12:12:13Z","updated_at":"2018-08-28T12:12:13Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/9748#discussion_r213287444","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9748","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/213287444"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/9748#discussion_r213287444"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9748"}},"in_reply_to_id":209508436},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9748","id":207257156,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjU3MTU2","html_url":"https://github.com/RIOT-OS/RIOT/pull/9748","diff_url":"https://github.com/RIOT-OS/RIOT/pull/9748.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/9748.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9748","number":9748,"state":"open","locked":false,"title":"tests/gnrc_netif: add test for ULA source selection","user":{"login":"miri64","id":675644,"node_id":"MDQ6VXNlcjY3NTY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"body":"### Contribution description\r\nAdds a test case for ULA source selection. For me it passes, but this test is an edge-case, as link-local addresses (`fe80::/64`) and ULAs (`fd00::/8`) are very close to matching so if something is messed up in the implementation this might fail.\r\n\r\n### Issues/PRs references\r\nDiscussed in https://github.com/RIOT-OS/RIOT/pull/9522#issuecomment-411688679","created_at":"2018-08-09T09:40:34Z","updated_at":"2018-08-28T12:12:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7390b37ff0bf02948f5f6f86cd752ec2732f20a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":872251341,"node_id":"MDU6TGFiZWw4NzIyNTEzNDE=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/CI:%20run%20tests","name":"CI: run tests","color":"8cd633","default":false},{"id":174449864,"node_id":"MDU6TGFiZWwxNzQ0NDk4NjQ=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/GNRC","name":"GNRC","color":"d4c5f9","default":false},{"id":214816571,"node_id":"MDU6TGFiZWwyMTQ4MTY1NzE=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Ready%20for%20CI%20build","name":"Ready for CI build","color":"bfdadc","default":false},{"id":86443543,"node_id":"MDU6TGFiZWw4NjQ0MzU0Mw==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/network","name":"network","color":"8f00cc","default":false},{"id":89588546,"node_id":"MDU6TGFiZWw4OTU4ODU0Ng==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/tests","name":"tests","color":"00fb75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9748/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9748/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9748/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/c1926414ab79879e63cea97c92a4df62a2756430","head":{"label":"miri64:tests/enh/ula-src","ref":"tests/enh/ula-src","sha":"c1926414ab79879e63cea97c92a4df62a2756430","user":{"login":"miri64","id":675644,"node_id":"MDQ6VXNlcjY3NTY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"repo":{"id":7667624,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY3NjI0","name":"RIOT","full_name":"miri64/RIOT","owner":{"login":"miri64","id":675644,"node_id":"MDQ6VXNlcjY3NTY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miri64/RIOT","description":"RIOT OS -  The revolutionary IoT OS","fork":true,"url":"https://api.github.com/repos/miri64/RIOT","forks_url":"https://api.github.com/repos/miri64/RIOT/forks","keys_url":"https://api.github.com/repos/miri64/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miri64/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miri64/RIOT/teams","hooks_url":"https://api.github.com/repos/miri64/RIOT/hooks","issue_events_url":"https://api.github.com/repos/miri64/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/miri64/RIOT/events","assignees_url":"https://api.github.com/repos/miri64/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/miri64/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/miri64/RIOT/tags","blobs_url":"https://api.github.com/repos/miri64/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miri64/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miri64/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/miri64/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miri64/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/miri64/RIOT/languages","stargazers_url":"https://api.github.com/repos/miri64/RIOT/stargazers","contributors_url":"https://api.github.com/repos/miri64/RIOT/contributors","subscribers_url":"https://api.github.com/repos/miri64/RIOT/subscribers","subscription_url":"https://api.github.com/repos/miri64/RIOT/subscription","commits_url":"https://api.github.com/repos/miri64/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/miri64/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/miri64/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/miri64/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/miri64/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/miri64/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miri64/RIOT/merges","archive_url":"https://api.github.com/repos/miri64/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miri64/RIOT/downloads","issues_url":"https://api.github.com/repos/miri64/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/miri64/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/miri64/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/miri64/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miri64/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/miri64/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/miri64/RIOT/deployments","created_at":"2013-01-17T14:31:57Z","updated_at":"2018-08-16T13:55:39Z","pushed_at":"2018-08-24T14:12:44Z","git_url":"git://github.com/miri64/RIOT.git","ssh_url":"git@github.com:miri64/RIOT.git","clone_url":"https://github.com/miri64/RIOT.git","svn_url":"https://github.com/miri64/RIOT","homepage":"","size":56452,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"2164c97441c981c59641efff1c452c9b3de86972","user":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcwMjQx","name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-08-28T11:54:14Z","pushed_at":"2018-08-28T12:03:50Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":56551,"stargazers_count":1945,"watchers_count":1945,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1117,"mirror_url":null,"archived":false,"open_issues_count":780,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1117,"open_issues":780,"watchers":1945,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9748"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/9748"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9748"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9748/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9748/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9748/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/c1926414ab79879e63cea97c92a4df62a2756430"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"smlng"}}