{"action":"created","comment":{"url":"https://api.github.com/repos/heptio/authenticator/pulls/comments/177520929","pull_request_review_id":107406591,"id":177520929,"diff_hunk":"@@ -219,4 +219,17 @@ server:\n   mapAccounts:\n   - \"012345678901\"\n   - \"456789012345\"\n+\n+  # map nodes that should conform to the username \"system:node:<private-DNS>\".  This\n+  # requires the authenticator to query the EC2 API in order to discover the private\n+  # DNS of the EC2 instance originating the authentication request.  Optionally, you\n+  # may specify a role that should be assumed before querying the EC2 API with the\n+  # top level key \"defaultEC2DescribeInstancesRoleARN\"\n+  defaultEC2DescribeInstancesRoleARN: arn:aws:iam::000000000000:role/DescribeInstancesRole\n+  mapNodes:","path":"README.md","position":11,"original_position":11,"commit_id":"fff0eb1df64b09d0dfac3de37c004ae4d84ec4b2","original_commit_id":"9eec90fc9128972b1e0b29ee306d4931a15454b4","user":{"login":"nckturner","id":1205393,"avatar_url":"https://avatars3.githubusercontent.com/u/1205393?v=4","gravatar_id":"","url":"https://api.github.com/users/nckturner","html_url":"https://github.com/nckturner","followers_url":"https://api.github.com/users/nckturner/followers","following_url":"https://api.github.com/users/nckturner/following{/other_user}","gists_url":"https://api.github.com/users/nckturner/gists{/gist_id}","starred_url":"https://api.github.com/users/nckturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nckturner/subscriptions","organizations_url":"https://api.github.com/users/nckturner/orgs","repos_url":"https://api.github.com/users/nckturner/repos","events_url":"https://api.github.com/users/nckturner/events{/privacy}","received_events_url":"https://api.github.com/users/nckturner/received_events","type":"User","site_admin":false},"body":"Gave that approach a go in https://github.com/heptio/authenticator/pull/65","created_at":"2018-03-27T18:11:26Z","updated_at":"2018-03-27T18:11:26Z","html_url":"https://github.com/heptio/authenticator/pull/61#discussion_r177520929","pull_request_url":"https://api.github.com/repos/heptio/authenticator/pulls/61","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/heptio/authenticator/pulls/comments/177520929"},"html":{"href":"https://github.com/heptio/authenticator/pull/61#discussion_r177520929"},"pull_request":{"href":"https://api.github.com/repos/heptio/authenticator/pulls/61"}},"in_reply_to_id":177246836},"pull_request":{"url":"https://api.github.com/repos/heptio/authenticator/pulls/61","id":176923475,"html_url":"https://github.com/heptio/authenticator/pull/61","diff_url":"https://github.com/heptio/authenticator/pull/61.diff","patch_url":"https://github.com/heptio/authenticator/pull/61.patch","issue_url":"https://api.github.com/repos/heptio/authenticator/issues/61","number":61,"state":"open","locked":false,"title":"Add a NodeMapping that automatically maps a role to the name used by kubelet","user":{"login":"nckturner","id":1205393,"avatar_url":"https://avatars3.githubusercontent.com/u/1205393?v=4","gravatar_id":"","url":"https://api.github.com/users/nckturner","html_url":"https://github.com/nckturner","followers_url":"https://api.github.com/users/nckturner/followers","following_url":"https://api.github.com/users/nckturner/following{/other_user}","gists_url":"https://api.github.com/users/nckturner/gists{/gist_id}","starred_url":"https://api.github.com/users/nckturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nckturner/subscriptions","organizations_url":"https://api.github.com/users/nckturner/orgs","repos_url":"https://api.github.com/users/nckturner/repos","events_url":"https://api.github.com/users/nckturner/events{/privacy}","received_events_url":"https://api.github.com/users/nckturner/received_events","type":"User","site_admin":false},"body":"- kubelet reports itself as `system:node:<aws-private-dns>`\r\n- modifies authenticator to be able to discover an ec2 instance's private dns\r\n   and use it for the node name when the role is part of a NodeMapping\r\n- allows a role to be specified in the config file to assume for the describe\r\n   instances call, in case it is in a separate account.\r\n\r\nAddresses [issues/57](https://github.com/heptio/authenticator/issues/57)","created_at":"2018-03-22T22:09:39Z","updated_at":"2018-03-27T18:11:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9ce9a0eb3be94ed7e747ee5011140ec975e1d35","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":659737622,"url":"https://api.github.com/repos/heptio/authenticator/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/heptio/authenticator/pulls/61/commits","review_comments_url":"https://api.github.com/repos/heptio/authenticator/pulls/61/comments","review_comment_url":"https://api.github.com/repos/heptio/authenticator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heptio/authenticator/issues/61/comments","statuses_url":"https://api.github.com/repos/heptio/authenticator/statuses/fff0eb1df64b09d0dfac3de37c004ae4d84ec4b2","head":{"label":"heptio:kubelet-username","ref":"kubelet-username","sha":"fff0eb1df64b09d0dfac3de37c004ae4d84ec4b2","user":{"login":"heptio","id":22035492,"avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"repo":{"id":99036030,"name":"authenticator","full_name":"heptio/authenticator","owner":{"login":"heptio","id":22035492,"avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heptio/authenticator","description":"A tool for using AWS IAM credentials to authenticate to a Kubernetes cluster","fork":false,"url":"https://api.github.com/repos/heptio/authenticator","forks_url":"https://api.github.com/repos/heptio/authenticator/forks","keys_url":"https://api.github.com/repos/heptio/authenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heptio/authenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heptio/authenticator/teams","hooks_url":"https://api.github.com/repos/heptio/authenticator/hooks","issue_events_url":"https://api.github.com/repos/heptio/authenticator/issues/events{/number}","events_url":"https://api.github.com/repos/heptio/authenticator/events","assignees_url":"https://api.github.com/repos/heptio/authenticator/assignees{/user}","branches_url":"https://api.github.com/repos/heptio/authenticator/branches{/branch}","tags_url":"https://api.github.com/repos/heptio/authenticator/tags","blobs_url":"https://api.github.com/repos/heptio/authenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heptio/authenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heptio/authenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/heptio/authenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heptio/authenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/heptio/authenticator/languages","stargazers_url":"https://api.github.com/repos/heptio/authenticator/stargazers","contributors_url":"https://api.github.com/repos/heptio/authenticator/contributors","subscribers_url":"https://api.github.com/repos/heptio/authenticator/subscribers","subscription_url":"https://api.github.com/repos/heptio/authenticator/subscription","commits_url":"https://api.github.com/repos/heptio/authenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/heptio/authenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/heptio/authenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/heptio/authenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/heptio/authenticator/contents/{+path}","compare_url":"https://api.github.com/repos/heptio/authenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heptio/authenticator/merges","archive_url":"https://api.github.com/repos/heptio/authenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heptio/authenticator/downloads","issues_url":"https://api.github.com/repos/heptio/authenticator/issues{/number}","pulls_url":"https://api.github.com/repos/heptio/authenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/heptio/authenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/heptio/authenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heptio/authenticator/labels{/name}","releases_url":"https://api.github.com/repos/heptio/authenticator/releases{/id}","deployments_url":"https://api.github.com/repos/heptio/authenticator/deployments","created_at":"2017-08-01T19:29:39Z","updated_at":"2018-03-27T17:25:28Z","pushed_at":"2018-03-27T18:10:57Z","git_url":"git://github.com/heptio/authenticator.git","ssh_url":"git@github.com:heptio/authenticator.git","clone_url":"https://github.com/heptio/authenticator.git","svn_url":"https://github.com/heptio/authenticator","homepage":"","size":18668,"stargazers_count":295,"watchers_count":295,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":32,"open_issues":29,"watchers":295,"default_branch":"master"}},"base":{"label":"heptio:master","ref":"master","sha":"d844e9e50816e807f514f231eb5a98981b744e9b","user":{"login":"heptio","id":22035492,"avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"repo":{"id":99036030,"name":"authenticator","full_name":"heptio/authenticator","owner":{"login":"heptio","id":22035492,"avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heptio/authenticator","description":"A tool for using AWS IAM credentials to authenticate to a Kubernetes cluster","fork":false,"url":"https://api.github.com/repos/heptio/authenticator","forks_url":"https://api.github.com/repos/heptio/authenticator/forks","keys_url":"https://api.github.com/repos/heptio/authenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heptio/authenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heptio/authenticator/teams","hooks_url":"https://api.github.com/repos/heptio/authenticator/hooks","issue_events_url":"https://api.github.com/repos/heptio/authenticator/issues/events{/number}","events_url":"https://api.github.com/repos/heptio/authenticator/events","assignees_url":"https://api.github.com/repos/heptio/authenticator/assignees{/user}","branches_url":"https://api.github.com/repos/heptio/authenticator/branches{/branch}","tags_url":"https://api.github.com/repos/heptio/authenticator/tags","blobs_url":"https://api.github.com/repos/heptio/authenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heptio/authenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heptio/authenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/heptio/authenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heptio/authenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/heptio/authenticator/languages","stargazers_url":"https://api.github.com/repos/heptio/authenticator/stargazers","contributors_url":"https://api.github.com/repos/heptio/authenticator/contributors","subscribers_url":"https://api.github.com/repos/heptio/authenticator/subscribers","subscription_url":"https://api.github.com/repos/heptio/authenticator/subscription","commits_url":"https://api.github.com/repos/heptio/authenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/heptio/authenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/heptio/authenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/heptio/authenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/heptio/authenticator/contents/{+path}","compare_url":"https://api.github.com/repos/heptio/authenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heptio/authenticator/merges","archive_url":"https://api.github.com/repos/heptio/authenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heptio/authenticator/downloads","issues_url":"https://api.github.com/repos/heptio/authenticator/issues{/number}","pulls_url":"https://api.github.com/repos/heptio/authenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/heptio/authenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/heptio/authenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heptio/authenticator/labels{/name}","releases_url":"https://api.github.com/repos/heptio/authenticator/releases{/id}","deployments_url":"https://api.github.com/repos/heptio/authenticator/deployments","created_at":"2017-08-01T19:29:39Z","updated_at":"2018-03-27T17:25:28Z","pushed_at":"2018-03-27T18:10:57Z","git_url":"git://github.com/heptio/authenticator.git","ssh_url":"git@github.com:heptio/authenticator.git","clone_url":"https://github.com/heptio/authenticator.git","svn_url":"https://github.com/heptio/authenticator","homepage":"","size":18668,"stargazers_count":295,"watchers_count":295,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":32,"open_issues":29,"watchers":295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heptio/authenticator/pulls/61"},"html":{"href":"https://github.com/heptio/authenticator/pull/61"},"issue":{"href":"https://api.github.com/repos/heptio/authenticator/issues/61"},"comments":{"href":"https://api.github.com/repos/heptio/authenticator/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/heptio/authenticator/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/heptio/authenticator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heptio/authenticator/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/heptio/authenticator/statuses/fff0eb1df64b09d0dfac3de37c004ae4d84ec4b2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nckturner"}}