{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/50254","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/50254/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/50254/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/50254/events","html_url":"https://github.com/rust-lang/rust/pull/50254","id":318146876,"number":50254,"title":"[beta] Remove dependency on `parking_lot`","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"aturon","id":709807,"avatar_url":"https://avatars2.githubusercontent.com/u/709807?v=4","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"assignees":[{"login":"aturon","id":709807,"avatar_url":"https://avatars2.githubusercontent.com/u/709807?v=4","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-04-26T18:29:14Z","updated_at":"2018-04-26T18:29:18Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/50254","html_url":"https://github.com/rust-lang/rust/pull/50254","diff_url":"https://github.com/rust-lang/rust/pull/50254.diff","patch_url":"https://github.com/rust-lang/rust/pull/50254.patch"},"body":"Unfortunately the `parking_lot` crate enables the `synchapi` feature of the\r\n`winapi` crate which activates a dependency on `libsynchronization.a`. The MinGW\r\nversion of `libsynchronization.a` pulls in a dependency\r\n`api-ms-core-synch-l1-2-0.dll` which causes rustc to not work on Windows 7\r\n(tracked in #49438)\r\n\r\nThe `parking_lot` crate is not currently used in the compiler unless parallel\r\nqueries are enabled. This feature is not enabled by default and not used at all\r\nin the beta/stable compilers. As a result the dependency in this commit was\r\nremoved and the CI build which checks parallel queries was disabled.\r\n\r\nThis isn't a great long-term solution but should hopefully be enough of a patch\r\nfor beta to buy us some more time to figure this out."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/384744110","html_url":"https://github.com/rust-lang/rust/pull/50254#issuecomment-384744110","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/50254","id":384744110,"user":{"login":"rust-highfive","id":7378925,"avatar_url":"https://avatars3.githubusercontent.com/u/7378925?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-highfive","html_url":"https://github.com/rust-highfive","followers_url":"https://api.github.com/users/rust-highfive/followers","following_url":"https://api.github.com/users/rust-highfive/following{/other_user}","gists_url":"https://api.github.com/users/rust-highfive/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-highfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-highfive/subscriptions","organizations_url":"https://api.github.com/users/rust-highfive/orgs","repos_url":"https://api.github.com/users/rust-highfive/repos","events_url":"https://api.github.com/users/rust-highfive/events{/privacy}","received_events_url":"https://api.github.com/users/rust-highfive/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T18:29:18Z","updated_at":"2018-04-26T18:29:18Z","author_association":"COLLABORATOR","body":"<img src=\"http://www.joshmatthews.net/warning.svg\" alt=\"warning\" height=20> **Warning** <img src=\"http://www.joshmatthews.net/warning.svg\" alt=\"warning\" height=20>\n\n* Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!"}}
{"actor":{"display_login":"rust-highfive"}}