{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/comments/227153250","pull_request_review_id":167127796,"id":227153250,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzE1MzI1MA==","diff_hunk":"@@ -60,6 +61,7 @@\n           'controller_address' => '172.17.10.101',  \n           'node_label' => 'foo',   \n           'container_runtime' => 'docker',  \n+          'ignore_preflight_errors' => '',  ","path":"spec/classes/cluster_roles_spec.rb","position":14,"original_position":14,"commit_id":"c7d0ff95aa44e58c4bbad19daf9508a70436a0b4","original_commit_id":"c7d0ff95aa44e58c4bbad19daf9508a70436a0b4","user":{"login":"scotje","id":9058,"node_id":"MDQ6VXNlcjkwNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9058?v=4","gravatar_id":"","url":"https://api.github.com/users/scotje","html_url":"https://github.com/scotje","followers_url":"https://api.github.com/users/scotje/followers","following_url":"https://api.github.com/users/scotje/following{/other_user}","gists_url":"https://api.github.com/users/scotje/gists{/gist_id}","starred_url":"https://api.github.com/users/scotje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scotje/subscriptions","organizations_url":"https://api.github.com/users/scotje/orgs","repos_url":"https://api.github.com/users/scotje/repos","events_url":"https://api.github.com/users/scotje/events{/privacy}","received_events_url":"https://api.github.com/users/scotje/received_events","type":"User","site_admin":false},"body":"It's not `kubeadm` complaining about it being a `String`, it's Puppet. Because the parameter has the type `Optional[Array]` it can only be passed into the Puppet manifest as `undef` or an `Array`.","created_at":"2018-10-22T21:58:31Z","updated_at":"2018-10-22T21:58:32Z","html_url":"https://github.com/puppetlabs/puppetlabs-kubernetes/pull/171#discussion_r227153250","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/171","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/comments/227153250"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-kubernetes/pull/171#discussion_r227153250"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/171"}},"in_reply_to_id":227062748},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/171","id":223184261,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMTg0MjYx","html_url":"https://github.com/puppetlabs/puppetlabs-kubernetes/pull/171","diff_url":"https://github.com/puppetlabs/puppetlabs-kubernetes/pull/171.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-kubernetes/pull/171.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/issues/171","number":171,"state":"open","locked":false,"title":"[Fix][Kuberneres 1.10.7] - issue with ignore-preflight-errors while workers are joining masters","user":{"login":"Lord-Y","id":8832734,"node_id":"MDQ6VXNlcjg4MzI3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8832734?v=4","gravatar_id":"","url":"https://api.github.com/users/Lord-Y","html_url":"https://github.com/Lord-Y","followers_url":"https://api.github.com/users/Lord-Y/followers","following_url":"https://api.github.com/users/Lord-Y/following{/other_user}","gists_url":"https://api.github.com/users/Lord-Y/gists{/gist_id}","starred_url":"https://api.github.com/users/Lord-Y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lord-Y/subscriptions","organizations_url":"https://api.github.com/users/Lord-Y/orgs","repos_url":"https://api.github.com/users/Lord-Y/repos","events_url":"https://api.github.com/users/Lord-Y/events{/privacy}","received_events_url":"https://api.github.com/users/Lord-Y/received_events","type":"User","site_admin":false},"body":"With version 3.0.1, workers failed to join masters:\r\n\r\n`Notice: /Stage[main]/Kubernetes::Cluster_roles/Kubernetes::Kubeadm_join[worker01]/Exec[kubeadm join]/returns:      [ERROR CRI]: unable to check if the container runtime at \"/var/run/dockershim.sock\" is running: exit status 1\r\nNotice: /Stage[main]/Kubernetes::Cluster_roles/Kubernetes::Kubeadm_join[worker01]/Exec[kubeadm join]/returns: [preflight] If you know what you are doing, you can make a check non-fatal with `--ignore-preflight-errors=...`\r\nError: kubeadm join 'X.X.X.X:6443' --discovery-token-ca-cert-hash 'sha256:TOKEN_SHA256' --ignore-preflight-errors '' --token 'TOKEN' returned 2 instead of one of [0]\r\nError: /Stage[main]/Kubernetes::Cluster_roles/Kubernetes::Kubeadm_join[worker01]/Exec[kubeadm join]/returns: change from notrun to 0 failed: kubeadm join 'X.X.X.X:6443' --discovery-token-ca-cert-hash 'sha256:TOKEN_SHA256' --ignore-preflight-errors '' --token 'TOKEN' returned 2 instead of one of [0]\r\n`\r\n\r\nThe socket file is present but the preflight check is failing:\r\n`root@worker01:/var/run# ls -lrta dockershim.sock \r\nsrwxr-xr-x 1 root root 0 oct.  16 10:40 dockershim.sock\r\n`\r\n\r\nSo to avoid the issue, now you need to add `kubernetes::ignore_preflight_errors: ['cri']` in your yaml file if necessary","created_at":"2018-10-16T09:50:54Z","updated_at":"2018-10-22T21:58:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dd4a056406cfab9eeb91ea38bfa5d24e390dfe7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/171/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/171/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/issues/171/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/statuses/c7d0ff95aa44e58c4bbad19daf9508a70436a0b4","head":{"label":"Lord-Y:master","ref":"master","sha":"c7d0ff95aa44e58c4bbad19daf9508a70436a0b4","user":{"login":"Lord-Y","id":8832734,"node_id":"MDQ6VXNlcjg4MzI3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8832734?v=4","gravatar_id":"","url":"https://api.github.com/users/Lord-Y","html_url":"https://github.com/Lord-Y","followers_url":"https://api.github.com/users/Lord-Y/followers","following_url":"https://api.github.com/users/Lord-Y/following{/other_user}","gists_url":"https://api.github.com/users/Lord-Y/gists{/gist_id}","starred_url":"https://api.github.com/users/Lord-Y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lord-Y/subscriptions","organizations_url":"https://api.github.com/users/Lord-Y/orgs","repos_url":"https://api.github.com/users/Lord-Y/repos","events_url":"https://api.github.com/users/Lord-Y/events{/privacy}","received_events_url":"https://api.github.com/users/Lord-Y/received_events","type":"User","site_admin":false},"repo":{"id":136491702,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0OTE3MDI=","name":"puppetlabs-kubernetes","full_name":"Lord-Y/puppetlabs-kubernetes","private":false,"owner":{"login":"Lord-Y","id":8832734,"node_id":"MDQ6VXNlcjg4MzI3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8832734?v=4","gravatar_id":"","url":"https://api.github.com/users/Lord-Y","html_url":"https://github.com/Lord-Y","followers_url":"https://api.github.com/users/Lord-Y/followers","following_url":"https://api.github.com/users/Lord-Y/following{/other_user}","gists_url":"https://api.github.com/users/Lord-Y/gists{/gist_id}","starred_url":"https://api.github.com/users/Lord-Y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lord-Y/subscriptions","organizations_url":"https://api.github.com/users/Lord-Y/orgs","repos_url":"https://api.github.com/users/Lord-Y/repos","events_url":"https://api.github.com/users/Lord-Y/events{/privacy}","received_events_url":"https://api.github.com/users/Lord-Y/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Lord-Y/puppetlabs-kubernetes","description":"This module install and configures a Kubernetes cluster","fork":true,"url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes","forks_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/forks","keys_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/teams","hooks_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/events","assignees_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/tags","blobs_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/languages","stargazers_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/subscription","commits_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/merges","archive_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/downloads","issues_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/Lord-Y/puppetlabs-kubernetes/deployments","created_at":"2018-06-07T14:48:29Z","updated_at":"2018-10-19T19:10:21Z","pushed_at":"2018-10-19T19:10:19Z","git_url":"git://github.com/Lord-Y/puppetlabs-kubernetes.git","ssh_url":"git@github.com:Lord-Y/puppetlabs-kubernetes.git","clone_url":"https://github.com/Lord-Y/puppetlabs-kubernetes.git","svn_url":"https://github.com/Lord-Y/puppetlabs-kubernetes","homepage":null,"size":328,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"43a1a54492e073aa1650d66328f95c756095b990","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":102576190,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NzYxOTA=","name":"puppetlabs-kubernetes","full_name":"puppetlabs/puppetlabs-kubernetes","private":false,"owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/puppetlabs/puppetlabs-kubernetes","description":"This module install and configures a Kubernetes cluster","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/deployments","created_at":"2017-09-06T07:19:28Z","updated_at":"2018-10-16T23:32:00Z","pushed_at":"2018-10-19T19:10:20Z","git_url":"git://github.com/puppetlabs/puppetlabs-kubernetes.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-kubernetes.git","clone_url":"https://github.com/puppetlabs/puppetlabs-kubernetes.git","svn_url":"https://github.com/puppetlabs/puppetlabs-kubernetes","homepage":null,"size":332,"stargazers_count":43,"watchers_count":43,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":9,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/171"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-kubernetes/pull/171"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/issues/171"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-kubernetes/statuses/c7d0ff95aa44e58c4bbad19daf9508a70436a0b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"scotje"}}