{"action":"created","issue":{"url":"https://api.github.com/repos/exodev/social/issues/381","repository_url":"https://api.github.com/repos/exodev/social","labels_url":"https://api.github.com/repos/exodev/social/issues/381/labels{/name}","comments_url":"https://api.github.com/repos/exodev/social/issues/381/comments","events_url":"https://api.github.com/repos/exodev/social/issues/381/events","html_url":"https://github.com/exodev/social/pull/381","id":327670665,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNDA2MzI4","number":381,"title":"PLF-8026 Errors During Migration eXo platform from 4.4.4 to 5.0.0","user":{"login":"nttuyen","id":243502,"node_id":"MDQ6VXNlcjI0MzUwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/243502?v=4","gravatar_id":"","url":"https://api.github.com/users/nttuyen","html_url":"https://github.com/nttuyen","followers_url":"https://api.github.com/users/nttuyen/followers","following_url":"https://api.github.com/users/nttuyen/following{/other_user}","gists_url":"https://api.github.com/users/nttuyen/gists{/gist_id}","starred_url":"https://api.github.com/users/nttuyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nttuyen/subscriptions","organizations_url":"https://api.github.com/users/nttuyen/orgs","repos_url":"https://api.github.com/users/nttuyen/repos","events_url":"https://api.github.com/users/nttuyen/events{/privacy}","received_events_url":"https://api.github.com/users/nttuyen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-30T10:31:45Z","updated_at":"2018-06-02T01:56:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/exodev/social/pulls/381","html_url":"https://github.com/exodev/social/pull/381","diff_url":"https://github.com/exodev/social/pull/381.diff","patch_url":"https://github.com/exodev/social/pull/381.patch"},"body":"- The cause of the bug is that with Mysql 5.7.22, it's default to have the option: NO_ZERO_DATE , mean that the table column with TIMESTAMP data type , if having contraint NOT NULL , must have a valid default value\r\n\r\n- Solution: apply ${now} variable as default value of timestamp column of social change log"},"comment":{"url":"https://api.github.com/repos/exodev/social/issues/comments/394048567","html_url":"https://github.com/exodev/social/pull/381#issuecomment-394048567","issue_url":"https://api.github.com/repos/exodev/social/issues/381","id":394048567,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDA0ODU2Nw==","user":{"login":"nttuyen","id":243502,"node_id":"MDQ6VXNlcjI0MzUwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/243502?v=4","gravatar_id":"","url":"https://api.github.com/users/nttuyen","html_url":"https://github.com/nttuyen","followers_url":"https://api.github.com/users/nttuyen/followers","following_url":"https://api.github.com/users/nttuyen/following{/other_user}","gists_url":"https://api.github.com/users/nttuyen/gists{/gist_id}","starred_url":"https://api.github.com/users/nttuyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nttuyen/subscriptions","organizations_url":"https://api.github.com/users/nttuyen/orgs","repos_url":"https://api.github.com/users/nttuyen/repos","events_url":"https://api.github.com/users/nttuyen/events{/privacy}","received_events_url":"https://api.github.com/users/nttuyen/received_events","type":"User","site_admin":false},"created_at":"2018-06-02T01:56:58Z","updated_at":"2018-06-02T01:56:58Z","author_association":"MEMBER","body":"@thomasdelhomenie , the PR works for me. But i can't reproduce the exception with the indexing service\r\n\r\ni created a PLF db with PLF 4.4.4, and the mysql 5.6 (that doesn't has default strict mode on date like 5.7.22) and make sure the SOC_SPACES table has the column CREATED_DATE with the default value is : '0000-00-00'\r\n\r\nthen i upgrade the DB to 5.7.22, with the strict mode on date\r\nnow the SQL that liquibase run will be fail: ALTER TABLE SOC_SPACES ADD BANNER_LAST_UPDATED timestamp NULL --> raise error on CREATED_DATE column can not has 0 default value\r\n\r\nthen i apply this PR and migrate the DB with PLF 5.0.0, no error any more , and the default value for CREATED_DATE column is now : CURRENT_TIMESTAMP"}}
{"actor":{"display_login":"nttuyen"}}