{"action":"created","comment":{"url":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/comments/172451176","pull_request_review_id":101466319,"id":172451176,"diff_hunk":"@@ -0,0 +1,54 @@\n+== Architecture Style\n+\n+There are three common variants to participate in XMPP communication and manage server configurations: As XMPP-server plugin, XMPP component or an XMPP Client/Bot.\n+\n+The implementation style fundamentally restricts the set of implementation languages and has a profound impact on the fundamental architecture. \n+\n+The following aspects must be taken into account to find the most suitable architecture style:\n+\n+* All required management functionality must be supported over the available APIs and protocols.\n+* Compatibility with most XMPP servers\n+* Keep the implementation complexity as low as possible\n+\n+=== Considered Options\n+\n+* XMPP server plugin, e.g. for http://download.igniterealtime.org/openfire/docs/latest/documentation/plugin-dev-guide.html[Openfire Plugin].\n+* XMPP Component (https://xmpp.org/extensions/xep-0114.html[XEP-0114]).\n+* XMPP Client/Bot\n+\n+=== Decision Outcome\n+\n+Chosen option: XMPP Client/bot, because it is not coupled to a specific XMPP server as the Server Plugin and, in contrast to the XMPP Component, supports strong authentication.\n+\n+Positive Consequences:\n+\n+* A standard XMPP client library can be used to implement the application.\n+\n+Negative consequences:\n+\n+* The application must run in a daemon, which must handle concurrent XMPP communication.","path":"documents/architectural-decisions/architecture-style.adoc","position":null,"original_position":29,"commit_id":"e9db09732320a2727c4f731a6a272635dbdb2167","original_commit_id":"50a49b9a497cf579e656f342f86eb8d590ee890b","user":{"login":"fabianhauser","id":368799,"avatar_url":"https://avatars0.githubusercontent.com/u/368799?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianhauser","html_url":"https://github.com/fabianhauser","followers_url":"https://api.github.com/users/fabianhauser/followers","following_url":"https://api.github.com/users/fabianhauser/following{/other_user}","gists_url":"https://api.github.com/users/fabianhauser/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianhauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianhauser/subscriptions","organizations_url":"https://api.github.com/users/fabianhauser/orgs","repos_url":"https://api.github.com/users/fabianhauser/repos","events_url":"https://api.github.com/users/fabianhauser/events{/privacy}","received_events_url":"https://api.github.com/users/fabianhauser/received_events","type":"User","site_admin":false},"body":"As discussed, I removed the Positive/Negative Consequences part.","created_at":"2018-03-06T09:13:40Z","updated_at":"2018-03-06T09:13:40Z","html_url":"https://github.com/xmpp-grid-broker/documents/pull/8#discussion_r172451176","pull_request_url":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/8","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/comments/172451176"},"html":{"href":"https://github.com/xmpp-grid-broker/documents/pull/8#discussion_r172451176"},"pull_request":{"href":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/8"}},"in_reply_to_id":172419822},"pull_request":{"url":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/8","id":172993128,"html_url":"https://github.com/xmpp-grid-broker/documents/pull/8","diff_url":"https://github.com/xmpp-grid-broker/documents/pull/8.diff","patch_url":"https://github.com/xmpp-grid-broker/documents/pull/8.patch","issue_url":"https://api.github.com/repos/xmpp-grid-broker/documents/issues/8","number":8,"state":"open","locked":false,"title":"XGB 69 architecutral decision: Architectural style","user":{"login":"fabianhauser","id":368799,"avatar_url":"https://avatars0.githubusercontent.com/u/368799?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianhauser","html_url":"https://github.com/fabianhauser","followers_url":"https://api.github.com/users/fabianhauser/followers","following_url":"https://api.github.com/users/fabianhauser/following{/other_user}","gists_url":"https://api.github.com/users/fabianhauser/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianhauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianhauser/subscriptions","organizations_url":"https://api.github.com/users/fabianhauser/orgs","repos_url":"https://api.github.com/users/fabianhauser/repos","events_url":"https://api.github.com/users/fabianhauser/events{/privacy}","received_events_url":"https://api.github.com/users/fabianhauser/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-05T21:35:38Z","updated_at":"2018-03-06T09:13:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1f29a4c5314c3191b242049d062b229e611d6aa","assignee":{"login":"raphiz","id":605630,"avatar_url":"https://avatars0.githubusercontent.com/u/605630?v=4","gravatar_id":"","url":"https://api.github.com/users/raphiz","html_url":"https://github.com/raphiz","followers_url":"https://api.github.com/users/raphiz/followers","following_url":"https://api.github.com/users/raphiz/following{/other_user}","gists_url":"https://api.github.com/users/raphiz/gists{/gist_id}","starred_url":"https://api.github.com/users/raphiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphiz/subscriptions","organizations_url":"https://api.github.com/users/raphiz/orgs","repos_url":"https://api.github.com/users/raphiz/repos","events_url":"https://api.github.com/users/raphiz/events{/privacy}","received_events_url":"https://api.github.com/users/raphiz/received_events","type":"User","site_admin":false},"assignees":[{"login":"raphiz","id":605630,"avatar_url":"https://avatars0.githubusercontent.com/u/605630?v=4","gravatar_id":"","url":"https://api.github.com/users/raphiz","html_url":"https://github.com/raphiz","followers_url":"https://api.github.com/users/raphiz/followers","following_url":"https://api.github.com/users/raphiz/following{/other_user}","gists_url":"https://api.github.com/users/raphiz/gists{/gist_id}","starred_url":"https://api.github.com/users/raphiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphiz/subscriptions","organizations_url":"https://api.github.com/users/raphiz/orgs","repos_url":"https://api.github.com/users/raphiz/repos","events_url":"https://api.github.com/users/raphiz/events{/privacy}","received_events_url":"https://api.github.com/users/raphiz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/8/commits","review_comments_url":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/8/comments","review_comment_url":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xmpp-grid-broker/documents/issues/8/comments","statuses_url":"https://api.github.com/repos/xmpp-grid-broker/documents/statuses/e9db09732320a2727c4f731a6a272635dbdb2167","head":{"label":"xmpp-grid-broker:XGB-69-implementation-style","ref":"XGB-69-implementation-style","sha":"e9db09732320a2727c4f731a6a272635dbdb2167","user":{"login":"xmpp-grid-broker","id":36620782,"avatar_url":"https://avatars1.githubusercontent.com/u/36620782?v=4","gravatar_id":"","url":"https://api.github.com/users/xmpp-grid-broker","html_url":"https://github.com/xmpp-grid-broker","followers_url":"https://api.github.com/users/xmpp-grid-broker/followers","following_url":"https://api.github.com/users/xmpp-grid-broker/following{/other_user}","gists_url":"https://api.github.com/users/xmpp-grid-broker/gists{/gist_id}","starred_url":"https://api.github.com/users/xmpp-grid-broker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmpp-grid-broker/subscriptions","organizations_url":"https://api.github.com/users/xmpp-grid-broker/orgs","repos_url":"https://api.github.com/users/xmpp-grid-broker/repos","events_url":"https://api.github.com/users/xmpp-grid-broker/events{/privacy}","received_events_url":"https://api.github.com/users/xmpp-grid-broker/received_events","type":"Organization","site_admin":false},"repo":{"id":122037204,"name":"documents","full_name":"xmpp-grid-broker/documents","owner":{"login":"xmpp-grid-broker","id":36620782,"avatar_url":"https://avatars1.githubusercontent.com/u/36620782?v=4","gravatar_id":"","url":"https://api.github.com/users/xmpp-grid-broker","html_url":"https://github.com/xmpp-grid-broker","followers_url":"https://api.github.com/users/xmpp-grid-broker/followers","following_url":"https://api.github.com/users/xmpp-grid-broker/following{/other_user}","gists_url":"https://api.github.com/users/xmpp-grid-broker/gists{/gist_id}","starred_url":"https://api.github.com/users/xmpp-grid-broker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmpp-grid-broker/subscriptions","organizations_url":"https://api.github.com/users/xmpp-grid-broker/orgs","repos_url":"https://api.github.com/users/xmpp-grid-broker/repos","events_url":"https://api.github.com/users/xmpp-grid-broker/events{/privacy}","received_events_url":"https://api.github.com/users/xmpp-grid-broker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xmpp-grid-broker/documents","description":"Bachelor thesis documents  📃","fork":false,"url":"https://api.github.com/repos/xmpp-grid-broker/documents","forks_url":"https://api.github.com/repos/xmpp-grid-broker/documents/forks","keys_url":"https://api.github.com/repos/xmpp-grid-broker/documents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xmpp-grid-broker/documents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xmpp-grid-broker/documents/teams","hooks_url":"https://api.github.com/repos/xmpp-grid-broker/documents/hooks","issue_events_url":"https://api.github.com/repos/xmpp-grid-broker/documents/issues/events{/number}","events_url":"https://api.github.com/repos/xmpp-grid-broker/documents/events","assignees_url":"https://api.github.com/repos/xmpp-grid-broker/documents/assignees{/user}","branches_url":"https://api.github.com/repos/xmpp-grid-broker/documents/branches{/branch}","tags_url":"https://api.github.com/repos/xmpp-grid-broker/documents/tags","blobs_url":"https://api.github.com/repos/xmpp-grid-broker/documents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xmpp-grid-broker/documents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xmpp-grid-broker/documents/git/refs{/sha}","trees_url":"https://api.github.com/repos/xmpp-grid-broker/documents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xmpp-grid-broker/documents/statuses/{sha}","languages_url":"https://api.github.com/repos/xmpp-grid-broker/documents/languages","stargazers_url":"https://api.github.com/repos/xmpp-grid-broker/documents/stargazers","contributors_url":"https://api.github.com/repos/xmpp-grid-broker/documents/contributors","subscribers_url":"https://api.github.com/repos/xmpp-grid-broker/documents/subscribers","subscription_url":"https://api.github.com/repos/xmpp-grid-broker/documents/subscription","commits_url":"https://api.github.com/repos/xmpp-grid-broker/documents/commits{/sha}","git_commits_url":"https://api.github.com/repos/xmpp-grid-broker/documents/git/commits{/sha}","comments_url":"https://api.github.com/repos/xmpp-grid-broker/documents/comments{/number}","issue_comment_url":"https://api.github.com/repos/xmpp-grid-broker/documents/issues/comments{/number}","contents_url":"https://api.github.com/repos/xmpp-grid-broker/documents/contents/{+path}","compare_url":"https://api.github.com/repos/xmpp-grid-broker/documents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xmpp-grid-broker/documents/merges","archive_url":"https://api.github.com/repos/xmpp-grid-broker/documents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xmpp-grid-broker/documents/downloads","issues_url":"https://api.github.com/repos/xmpp-grid-broker/documents/issues{/number}","pulls_url":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls{/number}","milestones_url":"https://api.github.com/repos/xmpp-grid-broker/documents/milestones{/number}","notifications_url":"https://api.github.com/repos/xmpp-grid-broker/documents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xmpp-grid-broker/documents/labels{/name}","releases_url":"https://api.github.com/repos/xmpp-grid-broker/documents/releases{/id}","deployments_url":"https://api.github.com/repos/xmpp-grid-broker/documents/deployments","created_at":"2018-02-19T08:44:32Z","updated_at":"2018-02-26T10:18:53Z","pushed_at":"2018-03-06T09:13:00Z","git_url":"git://github.com/xmpp-grid-broker/documents.git","ssh_url":"git@github.com:xmpp-grid-broker/documents.git","clone_url":"https://github.com/xmpp-grid-broker/documents.git","svn_url":"https://github.com/xmpp-grid-broker/documents","homepage":"https://xmpp-grid-broker.github.io/","size":2112,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"xmpp-grid-broker:master","ref":"master","sha":"4cbb3f8d36d9ee43ae2b2605e9de85d93b4fb598","user":{"login":"xmpp-grid-broker","id":36620782,"avatar_url":"https://avatars1.githubusercontent.com/u/36620782?v=4","gravatar_id":"","url":"https://api.github.com/users/xmpp-grid-broker","html_url":"https://github.com/xmpp-grid-broker","followers_url":"https://api.github.com/users/xmpp-grid-broker/followers","following_url":"https://api.github.com/users/xmpp-grid-broker/following{/other_user}","gists_url":"https://api.github.com/users/xmpp-grid-broker/gists{/gist_id}","starred_url":"https://api.github.com/users/xmpp-grid-broker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmpp-grid-broker/subscriptions","organizations_url":"https://api.github.com/users/xmpp-grid-broker/orgs","repos_url":"https://api.github.com/users/xmpp-grid-broker/repos","events_url":"https://api.github.com/users/xmpp-grid-broker/events{/privacy}","received_events_url":"https://api.github.com/users/xmpp-grid-broker/received_events","type":"Organization","site_admin":false},"repo":{"id":122037204,"name":"documents","full_name":"xmpp-grid-broker/documents","owner":{"login":"xmpp-grid-broker","id":36620782,"avatar_url":"https://avatars1.githubusercontent.com/u/36620782?v=4","gravatar_id":"","url":"https://api.github.com/users/xmpp-grid-broker","html_url":"https://github.com/xmpp-grid-broker","followers_url":"https://api.github.com/users/xmpp-grid-broker/followers","following_url":"https://api.github.com/users/xmpp-grid-broker/following{/other_user}","gists_url":"https://api.github.com/users/xmpp-grid-broker/gists{/gist_id}","starred_url":"https://api.github.com/users/xmpp-grid-broker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmpp-grid-broker/subscriptions","organizations_url":"https://api.github.com/users/xmpp-grid-broker/orgs","repos_url":"https://api.github.com/users/xmpp-grid-broker/repos","events_url":"https://api.github.com/users/xmpp-grid-broker/events{/privacy}","received_events_url":"https://api.github.com/users/xmpp-grid-broker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xmpp-grid-broker/documents","description":"Bachelor thesis documents  📃","fork":false,"url":"https://api.github.com/repos/xmpp-grid-broker/documents","forks_url":"https://api.github.com/repos/xmpp-grid-broker/documents/forks","keys_url":"https://api.github.com/repos/xmpp-grid-broker/documents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xmpp-grid-broker/documents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xmpp-grid-broker/documents/teams","hooks_url":"https://api.github.com/repos/xmpp-grid-broker/documents/hooks","issue_events_url":"https://api.github.com/repos/xmpp-grid-broker/documents/issues/events{/number}","events_url":"https://api.github.com/repos/xmpp-grid-broker/documents/events","assignees_url":"https://api.github.com/repos/xmpp-grid-broker/documents/assignees{/user}","branches_url":"https://api.github.com/repos/xmpp-grid-broker/documents/branches{/branch}","tags_url":"https://api.github.com/repos/xmpp-grid-broker/documents/tags","blobs_url":"https://api.github.com/repos/xmpp-grid-broker/documents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xmpp-grid-broker/documents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xmpp-grid-broker/documents/git/refs{/sha}","trees_url":"https://api.github.com/repos/xmpp-grid-broker/documents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xmpp-grid-broker/documents/statuses/{sha}","languages_url":"https://api.github.com/repos/xmpp-grid-broker/documents/languages","stargazers_url":"https://api.github.com/repos/xmpp-grid-broker/documents/stargazers","contributors_url":"https://api.github.com/repos/xmpp-grid-broker/documents/contributors","subscribers_url":"https://api.github.com/repos/xmpp-grid-broker/documents/subscribers","subscription_url":"https://api.github.com/repos/xmpp-grid-broker/documents/subscription","commits_url":"https://api.github.com/repos/xmpp-grid-broker/documents/commits{/sha}","git_commits_url":"https://api.github.com/repos/xmpp-grid-broker/documents/git/commits{/sha}","comments_url":"https://api.github.com/repos/xmpp-grid-broker/documents/comments{/number}","issue_comment_url":"https://api.github.com/repos/xmpp-grid-broker/documents/issues/comments{/number}","contents_url":"https://api.github.com/repos/xmpp-grid-broker/documents/contents/{+path}","compare_url":"https://api.github.com/repos/xmpp-grid-broker/documents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xmpp-grid-broker/documents/merges","archive_url":"https://api.github.com/repos/xmpp-grid-broker/documents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xmpp-grid-broker/documents/downloads","issues_url":"https://api.github.com/repos/xmpp-grid-broker/documents/issues{/number}","pulls_url":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls{/number}","milestones_url":"https://api.github.com/repos/xmpp-grid-broker/documents/milestones{/number}","notifications_url":"https://api.github.com/repos/xmpp-grid-broker/documents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xmpp-grid-broker/documents/labels{/name}","releases_url":"https://api.github.com/repos/xmpp-grid-broker/documents/releases{/id}","deployments_url":"https://api.github.com/repos/xmpp-grid-broker/documents/deployments","created_at":"2018-02-19T08:44:32Z","updated_at":"2018-02-26T10:18:53Z","pushed_at":"2018-03-06T09:13:00Z","git_url":"git://github.com/xmpp-grid-broker/documents.git","ssh_url":"git@github.com:xmpp-grid-broker/documents.git","clone_url":"https://github.com/xmpp-grid-broker/documents.git","svn_url":"https://github.com/xmpp-grid-broker/documents","homepage":"https://xmpp-grid-broker.github.io/","size":2112,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/8"},"html":{"href":"https://github.com/xmpp-grid-broker/documents/pull/8"},"issue":{"href":"https://api.github.com/repos/xmpp-grid-broker/documents/issues/8"},"comments":{"href":"https://api.github.com/repos/xmpp-grid-broker/documents/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xmpp-grid-broker/documents/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/xmpp-grid-broker/documents/statuses/e9db09732320a2727c4f731a6a272635dbdb2167"}},"author_association":"OWNER"}}
{"actor":{"display_login":"fabianhauser"}}