{"action":"created","comment":{"url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/comments/230977901","pull_request_review_id":171838688,"id":230977901,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDk3NzkwMQ==","diff_hunk":"@@ -222,14 +234,26 @@ export default {\n         time: barPointer,\n       };\n \n-      bucket = apiBucketsIndex < tradeHistory.apiBuckets.length ? tradeHistory.apiBuckets[apiBucketsIndex] : null;\n+      bucket = apiBucketsIndex < apiBuckets.length ? apiBuckets[apiBucketsIndex] : null;\n       trade = tradesIndex < trades.length ? trades[tradesIndex] : null;\n       while (trade && trade.tradeTime < from) {\n         tradesIndex += 1;\n         trade = tradesIndex < trades.length ? trades[tradesIndex] : null;\n       }\n \n-      if (bucket && bucket.time * 1000 === barPointer) {\n+      if (tradesIndex >= trades.length && trade === null) {\n+        break;","path":"src/renderer/services/dex.js","position":null,"original_position":60,"commit_id":"4a9e139f1cc8209bd531212f3239f088dc3ebd4c","original_commit_id":"b5decae0337a6d58c631de520ca440218bd3ff0c","user":{"login":"apheliontoken","id":32698425,"node_id":"MDQ6VXNlcjMyNjk4NDI1","avatar_url":"https://avatars0.githubusercontent.com/u/32698425?v=4","gravatar_id":"","url":"https://api.github.com/users/apheliontoken","html_url":"https://github.com/apheliontoken","followers_url":"https://api.github.com/users/apheliontoken/followers","following_url":"https://api.github.com/users/apheliontoken/following{/other_user}","gists_url":"https://api.github.com/users/apheliontoken/gists{/gist_id}","starred_url":"https://api.github.com/users/apheliontoken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apheliontoken/subscriptions","organizations_url":"https://api.github.com/users/apheliontoken/orgs","repos_url":"https://api.github.com/users/apheliontoken/repos","events_url":"https://api.github.com/users/apheliontoken/events{/privacy}","received_events_url":"https://api.github.com/users/apheliontoken/received_events","type":"User","site_admin":false},"body":"nice fix","created_at":"2018-11-06T01:50:27Z","updated_at":"2018-11-06T01:50:27Z","html_url":"https://github.com/aphtoken/aph-wallet-gui/pull/227#discussion_r230977901","pull_request_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/227","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/comments/230977901"},"html":{"href":"https://github.com/aphtoken/aph-wallet-gui/pull/227#discussion_r230977901"},"pull_request":{"href":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/227"}},"in_reply_to_id":230622709},"pull_request":{"url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/227","id":228190916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTkwOTE2","html_url":"https://github.com/aphtoken/aph-wallet-gui/pull/227","diff_url":"https://github.com/aphtoken/aph-wallet-gui/pull/227.diff","patch_url":"https://github.com/aphtoken/aph-wallet-gui/pull/227.patch","issue_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/issues/227","number":227,"state":"open","locked":false,"title":"TradingView Chart: Datafeed updates and general code cleanup","user":{"login":"rlucas6130","id":10226077,"node_id":"MDQ6VXNlcjEwMjI2MDc3","avatar_url":"https://avatars3.githubusercontent.com/u/10226077?v=4","gravatar_id":"","url":"https://api.github.com/users/rlucas6130","html_url":"https://github.com/rlucas6130","followers_url":"https://api.github.com/users/rlucas6130/followers","following_url":"https://api.github.com/users/rlucas6130/following{/other_user}","gists_url":"https://api.github.com/users/rlucas6130/gists{/gist_id}","starred_url":"https://api.github.com/users/rlucas6130/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlucas6130/subscriptions","organizations_url":"https://api.github.com/users/rlucas6130/orgs","repos_url":"https://api.github.com/users/rlucas6130/repos","events_url":"https://api.github.com/users/rlucas6130/events{/privacy}","received_events_url":"https://api.github.com/users/rlucas6130/received_events","type":"User","site_admin":false},"body":"## Ticket\r\n* N/A\r\n\r\n## Changes\r\n* Switching intervals now makes a calls to the 'buckets' API. \r\n* Uses both bucket and trade data to compose 'bars' \r\n* Optimized getBars method\r\n* Scrolling for left or right now will automatically request specific time frames as they are scrolled over (think of infinite scroll) \r\n* Real-time update now uses 'tradeHistory.getBars' (previously used datafeed.getBars which is now unnecessary) \r\n\r\n## Screenshots\r\n![image](https://user-images.githubusercontent.com/10226077/47966365-becbee80-e00e-11e8-90a5-76fa0eb15d5d.png)\r\n\r\n\r\n## Code Coverage\r\n","created_at":"2018-11-04T17:34:36Z","updated_at":"2018-11-06T01:50:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8250db7226507eec84e7e694ebbb8d3eb53e2df9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jsolman","id":4105414,"node_id":"MDQ6VXNlcjQxMDU0MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4105414?v=4","gravatar_id":"","url":"https://api.github.com/users/jsolman","html_url":"https://github.com/jsolman","followers_url":"https://api.github.com/users/jsolman/followers","following_url":"https://api.github.com/users/jsolman/following{/other_user}","gists_url":"https://api.github.com/users/jsolman/gists{/gist_id}","starred_url":"https://api.github.com/users/jsolman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsolman/subscriptions","organizations_url":"https://api.github.com/users/jsolman/orgs","repos_url":"https://api.github.com/users/jsolman/repos","events_url":"https://api.github.com/users/jsolman/events{/privacy}","received_events_url":"https://api.github.com/users/jsolman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/227/commits","review_comments_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/227/comments","review_comment_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/issues/227/comments","statuses_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/statuses/4a9e139f1cc8209bd531212f3239f088dc3ebd4c","head":{"label":"aphtoken:rl/ChartUpdates2","ref":"rl/ChartUpdates2","sha":"4a9e139f1cc8209bd531212f3239f088dc3ebd4c","user":{"login":"aphtoken","id":32698505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjk4NTA1","avatar_url":"https://avatars3.githubusercontent.com/u/32698505?v=4","gravatar_id":"","url":"https://api.github.com/users/aphtoken","html_url":"https://github.com/aphtoken","followers_url":"https://api.github.com/users/aphtoken/followers","following_url":"https://api.github.com/users/aphtoken/following{/other_user}","gists_url":"https://api.github.com/users/aphtoken/gists{/gist_id}","starred_url":"https://api.github.com/users/aphtoken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphtoken/subscriptions","organizations_url":"https://api.github.com/users/aphtoken/orgs","repos_url":"https://api.github.com/users/aphtoken/repos","events_url":"https://api.github.com/users/aphtoken/events{/privacy}","received_events_url":"https://api.github.com/users/aphtoken/received_events","type":"Organization","site_admin":false},"repo":{"id":117622126,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc2MjIxMjY=","name":"aph-wallet-gui","full_name":"aphtoken/aph-wallet-gui","private":false,"owner":{"login":"aphtoken","id":32698505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjk4NTA1","avatar_url":"https://avatars3.githubusercontent.com/u/32698505?v=4","gravatar_id":"","url":"https://api.github.com/users/aphtoken","html_url":"https://github.com/aphtoken","followers_url":"https://api.github.com/users/aphtoken/followers","following_url":"https://api.github.com/users/aphtoken/following{/other_user}","gists_url":"https://api.github.com/users/aphtoken/gists{/gist_id}","starred_url":"https://api.github.com/users/aphtoken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphtoken/subscriptions","organizations_url":"https://api.github.com/users/aphtoken/orgs","repos_url":"https://api.github.com/users/aphtoken/repos","events_url":"https://api.github.com/users/aphtoken/events{/privacy}","received_events_url":"https://api.github.com/users/aphtoken/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aphtoken/aph-wallet-gui","description":"Aphelion wallet","fork":false,"url":"https://api.github.com/repos/aphtoken/aph-wallet-gui","forks_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/forks","keys_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/teams","hooks_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/hooks","issue_events_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/issues/events{/number}","events_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/events","assignees_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/assignees{/user}","branches_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/branches{/branch}","tags_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/tags","blobs_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/languages","stargazers_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/stargazers","contributors_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/contributors","subscribers_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/subscribers","subscription_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/subscription","commits_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/contents/{+path}","compare_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/merges","archive_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/downloads","issues_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/issues{/number}","pulls_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/labels{/name}","releases_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/releases{/id}","deployments_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/deployments","created_at":"2018-01-16T02:45:31Z","updated_at":"2018-11-05T03:37:40Z","pushed_at":"2018-11-06T00:03:20Z","git_url":"git://github.com/aphtoken/aph-wallet-gui.git","ssh_url":"git@github.com:aphtoken/aph-wallet-gui.git","clone_url":"https://github.com/aphtoken/aph-wallet-gui.git","svn_url":"https://github.com/aphtoken/aph-wallet-gui","homepage":null,"size":19749,"stargazers_count":52,"watchers_count":52,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":2,"watchers":52,"default_branch":"development"}},"base":{"label":"aphtoken:development","ref":"development","sha":"c4ba5ade540f2740a99bca1431bf9e3c5d105a53","user":{"login":"aphtoken","id":32698505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjk4NTA1","avatar_url":"https://avatars3.githubusercontent.com/u/32698505?v=4","gravatar_id":"","url":"https://api.github.com/users/aphtoken","html_url":"https://github.com/aphtoken","followers_url":"https://api.github.com/users/aphtoken/followers","following_url":"https://api.github.com/users/aphtoken/following{/other_user}","gists_url":"https://api.github.com/users/aphtoken/gists{/gist_id}","starred_url":"https://api.github.com/users/aphtoken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphtoken/subscriptions","organizations_url":"https://api.github.com/users/aphtoken/orgs","repos_url":"https://api.github.com/users/aphtoken/repos","events_url":"https://api.github.com/users/aphtoken/events{/privacy}","received_events_url":"https://api.github.com/users/aphtoken/received_events","type":"Organization","site_admin":false},"repo":{"id":117622126,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc2MjIxMjY=","name":"aph-wallet-gui","full_name":"aphtoken/aph-wallet-gui","private":false,"owner":{"login":"aphtoken","id":32698505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjk4NTA1","avatar_url":"https://avatars3.githubusercontent.com/u/32698505?v=4","gravatar_id":"","url":"https://api.github.com/users/aphtoken","html_url":"https://github.com/aphtoken","followers_url":"https://api.github.com/users/aphtoken/followers","following_url":"https://api.github.com/users/aphtoken/following{/other_user}","gists_url":"https://api.github.com/users/aphtoken/gists{/gist_id}","starred_url":"https://api.github.com/users/aphtoken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphtoken/subscriptions","organizations_url":"https://api.github.com/users/aphtoken/orgs","repos_url":"https://api.github.com/users/aphtoken/repos","events_url":"https://api.github.com/users/aphtoken/events{/privacy}","received_events_url":"https://api.github.com/users/aphtoken/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aphtoken/aph-wallet-gui","description":"Aphelion wallet","fork":false,"url":"https://api.github.com/repos/aphtoken/aph-wallet-gui","forks_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/forks","keys_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/teams","hooks_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/hooks","issue_events_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/issues/events{/number}","events_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/events","assignees_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/assignees{/user}","branches_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/branches{/branch}","tags_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/tags","blobs_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/languages","stargazers_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/stargazers","contributors_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/contributors","subscribers_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/subscribers","subscription_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/subscription","commits_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/contents/{+path}","compare_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/merges","archive_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/downloads","issues_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/issues{/number}","pulls_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/labels{/name}","releases_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/releases{/id}","deployments_url":"https://api.github.com/repos/aphtoken/aph-wallet-gui/deployments","created_at":"2018-01-16T02:45:31Z","updated_at":"2018-11-05T03:37:40Z","pushed_at":"2018-11-06T00:03:20Z","git_url":"git://github.com/aphtoken/aph-wallet-gui.git","ssh_url":"git@github.com:aphtoken/aph-wallet-gui.git","clone_url":"https://github.com/aphtoken/aph-wallet-gui.git","svn_url":"https://github.com/aphtoken/aph-wallet-gui","homepage":null,"size":19749,"stargazers_count":52,"watchers_count":52,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":2,"watchers":52,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/227"},"html":{"href":"https://github.com/aphtoken/aph-wallet-gui/pull/227"},"issue":{"href":"https://api.github.com/repos/aphtoken/aph-wallet-gui/issues/227"},"comments":{"href":"https://api.github.com/repos/aphtoken/aph-wallet-gui/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aphtoken/aph-wallet-gui/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/aphtoken/aph-wallet-gui/statuses/4a9e139f1cc8209bd531212f3239f088dc3ebd4c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"apheliontoken"}}