{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/CakeDC/auth/pulls/32","id":241549338,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTQ5MzM4","html_url":"https://github.com/CakeDC/auth/pull/32","diff_url":"https://github.com/CakeDC/auth/pull/32.diff","patch_url":"https://github.com/CakeDC/auth/pull/32.patch","issue_url":"https://api.github.com/repos/CakeDC/auth/issues/32","number":32,"state":"closed","locked":false,"title":"Update ApiKeyAuthenticate.md","user":{"login":"challgren","id":88909,"node_id":"MDQ6VXNlcjg4OTA5","avatar_url":"https://avatars1.githubusercontent.com/u/88909?v=4","gravatar_id":"","url":"https://api.github.com/users/challgren","html_url":"https://github.com/challgren","followers_url":"https://api.github.com/users/challgren/followers","following_url":"https://api.github.com/users/challgren/following{/other_user}","gists_url":"https://api.github.com/users/challgren/gists{/gist_id}","starred_url":"https://api.github.com/users/challgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/challgren/subscriptions","organizations_url":"https://api.github.com/users/challgren/orgs","repos_url":"https://api.github.com/users/challgren/repos","events_url":"https://api.github.com/users/challgren/events{/privacy}","received_events_url":"https://api.github.com/users/challgren/received_events","type":"User","site_admin":false},"body":"Updating the documentation for ApiKeyAuthenticate to detail about how underscores in headers are dropped by Ngnix and Apache 2.4.x\r\n\r\nNgnix https://www.nginx.com/resources/wiki/start/topics/tutorials/config_pitfalls/?highlight=disappearing%20http%20headers#missing-disappearing-http-headers\r\n`\r\nIf you do not explicitly set underscores_in_headers on;, NGINX will silently drop HTTP headers with underscores (which are perfectly valid according to the HTTP standard). This is done in order to prevent ambiguities when mapping headers to CGI variables as both dashes and underscores are mapped to underscores during that process.\r\n`\r\n\r\nApache https://httpd.apache.org/docs/trunk/new_features_2_4.html\r\n`\r\nTranslation of headers to environment variables is more strict than before to mitigate some possible cross-site-scripting attacks via header injection. Headers containing invalid characters (including underscores) are now silently dropped. Environment Variables in Apache has some pointers on how to work around broken legacy clients which require such headers. (This affects all modules which use these environment variables.)`","created_at":"2018-12-31T10:36:11Z","updated_at":"2018-12-31T15:59:24Z","closed_at":"2018-12-31T15:59:24Z","merged_at":"2018-12-31T15:59:24Z","merge_commit_sha":"f0375d4ee4f8d5351510090c35af62a6727f6137","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CakeDC/auth/pulls/32/commits","review_comments_url":"https://api.github.com/repos/CakeDC/auth/pulls/32/comments","review_comment_url":"https://api.github.com/repos/CakeDC/auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CakeDC/auth/issues/32/comments","statuses_url":"https://api.github.com/repos/CakeDC/auth/statuses/bedbead1e2de0133374f730c9c9fb151ff9e4587","head":{"label":"challgren:patch-2","ref":"patch-2","sha":"bedbead1e2de0133374f730c9c9fb151ff9e4587","user":{"login":"challgren","id":88909,"node_id":"MDQ6VXNlcjg4OTA5","avatar_url":"https://avatars1.githubusercontent.com/u/88909?v=4","gravatar_id":"","url":"https://api.github.com/users/challgren","html_url":"https://github.com/challgren","followers_url":"https://api.github.com/users/challgren/followers","following_url":"https://api.github.com/users/challgren/following{/other_user}","gists_url":"https://api.github.com/users/challgren/gists{/gist_id}","starred_url":"https://api.github.com/users/challgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/challgren/subscriptions","organizations_url":"https://api.github.com/users/challgren/orgs","repos_url":"https://api.github.com/users/challgren/repos","events_url":"https://api.github.com/users/challgren/events{/privacy}","received_events_url":"https://api.github.com/users/challgren/received_events","type":"User","site_admin":false},"repo":{"id":163659694,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM2NTk2OTQ=","name":"auth","full_name":"challgren/auth","private":false,"owner":{"login":"challgren","id":88909,"node_id":"MDQ6VXNlcjg4OTA5","avatar_url":"https://avatars1.githubusercontent.com/u/88909?v=4","gravatar_id":"","url":"https://api.github.com/users/challgren","html_url":"https://github.com/challgren","followers_url":"https://api.github.com/users/challgren/followers","following_url":"https://api.github.com/users/challgren/following{/other_user}","gists_url":"https://api.github.com/users/challgren/gists{/gist_id}","starred_url":"https://api.github.com/users/challgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/challgren/subscriptions","organizations_url":"https://api.github.com/users/challgren/orgs","repos_url":"https://api.github.com/users/challgren/repos","events_url":"https://api.github.com/users/challgren/events{/privacy}","received_events_url":"https://api.github.com/users/challgren/received_events","type":"User","site_admin":false},"html_url":"https://github.com/challgren/auth","description":"Auth objects for CakePHP","fork":true,"url":"https://api.github.com/repos/challgren/auth","forks_url":"https://api.github.com/repos/challgren/auth/forks","keys_url":"https://api.github.com/repos/challgren/auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/challgren/auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/challgren/auth/teams","hooks_url":"https://api.github.com/repos/challgren/auth/hooks","issue_events_url":"https://api.github.com/repos/challgren/auth/issues/events{/number}","events_url":"https://api.github.com/repos/challgren/auth/events","assignees_url":"https://api.github.com/repos/challgren/auth/assignees{/user}","branches_url":"https://api.github.com/repos/challgren/auth/branches{/branch}","tags_url":"https://api.github.com/repos/challgren/auth/tags","blobs_url":"https://api.github.com/repos/challgren/auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/challgren/auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/challgren/auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/challgren/auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/challgren/auth/statuses/{sha}","languages_url":"https://api.github.com/repos/challgren/auth/languages","stargazers_url":"https://api.github.com/repos/challgren/auth/stargazers","contributors_url":"https://api.github.com/repos/challgren/auth/contributors","subscribers_url":"https://api.github.com/repos/challgren/auth/subscribers","subscription_url":"https://api.github.com/repos/challgren/auth/subscription","commits_url":"https://api.github.com/repos/challgren/auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/challgren/auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/challgren/auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/challgren/auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/challgren/auth/contents/{+path}","compare_url":"https://api.github.com/repos/challgren/auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/challgren/auth/merges","archive_url":"https://api.github.com/repos/challgren/auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/challgren/auth/downloads","issues_url":"https://api.github.com/repos/challgren/auth/issues{/number}","pulls_url":"https://api.github.com/repos/challgren/auth/pulls{/number}","milestones_url":"https://api.github.com/repos/challgren/auth/milestones{/number}","notifications_url":"https://api.github.com/repos/challgren/auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/challgren/auth/labels{/name}","releases_url":"https://api.github.com/repos/challgren/auth/releases{/id}","deployments_url":"https://api.github.com/repos/challgren/auth/deployments","created_at":"2018-12-31T10:22:39Z","updated_at":"2018-12-31T10:22:42Z","pushed_at":"2018-12-31T10:28:47Z","git_url":"git://github.com/challgren/auth.git","ssh_url":"git@github.com:challgren/auth.git","clone_url":"https://github.com/challgren/auth.git","svn_url":"https://github.com/challgren/auth","homepage":null,"size":119,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CakeDC:master","ref":"master","sha":"b2e742073fa74c6ad1eb463bc76d0d13ce613541","user":{"login":"CakeDC","id":204531,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDUzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/204531?v=4","gravatar_id":"","url":"https://api.github.com/users/CakeDC","html_url":"https://github.com/CakeDC","followers_url":"https://api.github.com/users/CakeDC/followers","following_url":"https://api.github.com/users/CakeDC/following{/other_user}","gists_url":"https://api.github.com/users/CakeDC/gists{/gist_id}","starred_url":"https://api.github.com/users/CakeDC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CakeDC/subscriptions","organizations_url":"https://api.github.com/users/CakeDC/orgs","repos_url":"https://api.github.com/users/CakeDC/repos","events_url":"https://api.github.com/users/CakeDC/events{/privacy}","received_events_url":"https://api.github.com/users/CakeDC/received_events","type":"Organization","site_admin":false},"repo":{"id":84848130,"node_id":"MDEwOlJlcG9zaXRvcnk4NDg0ODEzMA==","name":"auth","full_name":"CakeDC/auth","private":false,"owner":{"login":"CakeDC","id":204531,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDUzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/204531?v=4","gravatar_id":"","url":"https://api.github.com/users/CakeDC","html_url":"https://github.com/CakeDC","followers_url":"https://api.github.com/users/CakeDC/followers","following_url":"https://api.github.com/users/CakeDC/following{/other_user}","gists_url":"https://api.github.com/users/CakeDC/gists{/gist_id}","starred_url":"https://api.github.com/users/CakeDC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CakeDC/subscriptions","organizations_url":"https://api.github.com/users/CakeDC/orgs","repos_url":"https://api.github.com/users/CakeDC/repos","events_url":"https://api.github.com/users/CakeDC/events{/privacy}","received_events_url":"https://api.github.com/users/CakeDC/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CakeDC/auth","description":"Auth objects for CakePHP","fork":false,"url":"https://api.github.com/repos/CakeDC/auth","forks_url":"https://api.github.com/repos/CakeDC/auth/forks","keys_url":"https://api.github.com/repos/CakeDC/auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CakeDC/auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CakeDC/auth/teams","hooks_url":"https://api.github.com/repos/CakeDC/auth/hooks","issue_events_url":"https://api.github.com/repos/CakeDC/auth/issues/events{/number}","events_url":"https://api.github.com/repos/CakeDC/auth/events","assignees_url":"https://api.github.com/repos/CakeDC/auth/assignees{/user}","branches_url":"https://api.github.com/repos/CakeDC/auth/branches{/branch}","tags_url":"https://api.github.com/repos/CakeDC/auth/tags","blobs_url":"https://api.github.com/repos/CakeDC/auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CakeDC/auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CakeDC/auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/CakeDC/auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CakeDC/auth/statuses/{sha}","languages_url":"https://api.github.com/repos/CakeDC/auth/languages","stargazers_url":"https://api.github.com/repos/CakeDC/auth/stargazers","contributors_url":"https://api.github.com/repos/CakeDC/auth/contributors","subscribers_url":"https://api.github.com/repos/CakeDC/auth/subscribers","subscription_url":"https://api.github.com/repos/CakeDC/auth/subscription","commits_url":"https://api.github.com/repos/CakeDC/auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/CakeDC/auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/CakeDC/auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/CakeDC/auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/CakeDC/auth/contents/{+path}","compare_url":"https://api.github.com/repos/CakeDC/auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CakeDC/auth/merges","archive_url":"https://api.github.com/repos/CakeDC/auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CakeDC/auth/downloads","issues_url":"https://api.github.com/repos/CakeDC/auth/issues{/number}","pulls_url":"https://api.github.com/repos/CakeDC/auth/pulls{/number}","milestones_url":"https://api.github.com/repos/CakeDC/auth/milestones{/number}","notifications_url":"https://api.github.com/repos/CakeDC/auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CakeDC/auth/labels{/name}","releases_url":"https://api.github.com/repos/CakeDC/auth/releases{/id}","deployments_url":"https://api.github.com/repos/CakeDC/auth/deployments","created_at":"2017-03-13T16:15:19Z","updated_at":"2018-10-04T13:00:10Z","pushed_at":"2018-12-31T15:59:24Z","git_url":"git://github.com/CakeDC/auth.git","ssh_url":"git@github.com:CakeDC/auth.git","clone_url":"https://github.com/CakeDC/auth.git","svn_url":"https://github.com/CakeDC/auth","homepage":null,"size":115,"stargazers_count":14,"watchers_count":14,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":3,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CakeDC/auth/pulls/32"},"html":{"href":"https://github.com/CakeDC/auth/pull/32"},"issue":{"href":"https://api.github.com/repos/CakeDC/auth/issues/32"},"comments":{"href":"https://api.github.com/repos/CakeDC/auth/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/CakeDC/auth/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/CakeDC/auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CakeDC/auth/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/CakeDC/auth/statuses/bedbead1e2de0133374f730c9c9fb151ff9e4587"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"steinkel","id":151761,"node_id":"MDQ6VXNlcjE1MTc2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/151761?v=4","gravatar_id":"","url":"https://api.github.com/users/steinkel","html_url":"https://github.com/steinkel","followers_url":"https://api.github.com/users/steinkel/followers","following_url":"https://api.github.com/users/steinkel/following{/other_user}","gists_url":"https://api.github.com/users/steinkel/gists{/gist_id}","starred_url":"https://api.github.com/users/steinkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinkel/subscriptions","organizations_url":"https://api.github.com/users/steinkel/orgs","repos_url":"https://api.github.com/users/steinkel/repos","events_url":"https://api.github.com/users/steinkel/events{/privacy}","received_events_url":"https://api.github.com/users/steinkel/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"steinkel"}}