{"action":"closed","number":4700,"pull_request":{"url":"https://api.github.com/repos/eclipse/sumo/pulls/4700","id":222211311,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjExMzEx","html_url":"https://github.com/eclipse/sumo/pull/4700","diff_url":"https://github.com/eclipse/sumo/pull/4700.diff","patch_url":"https://github.com/eclipse/sumo/pull/4700.patch","issue_url":"https://api.github.com/repos/eclipse/sumo/issues/4700","number":4700,"state":"closed","locked":false,"title":"Fix some memory leaks in NLTriggerBuilder (Re #4699)","user":{"login":"seb-ehm","id":32466614,"node_id":"MDQ6VXNlcjMyNDY2NjE0","avatar_url":"https://avatars1.githubusercontent.com/u/32466614?v=4","gravatar_id":"","url":"https://api.github.com/users/seb-ehm","html_url":"https://github.com/seb-ehm","followers_url":"https://api.github.com/users/seb-ehm/followers","following_url":"https://api.github.com/users/seb-ehm/following{/other_user}","gists_url":"https://api.github.com/users/seb-ehm/gists{/gist_id}","starred_url":"https://api.github.com/users/seb-ehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seb-ehm/subscriptions","organizations_url":"https://api.github.com/users/seb-ehm/orgs","repos_url":"https://api.github.com/users/seb-ehm/repos","events_url":"https://api.github.com/users/seb-ehm/events{/privacy}","received_events_url":"https://api.github.com/users/seb-ehm/received_events","type":"User","site_admin":false},"body":"At several places in the file, memory is allocated and owned by\r\na pointer named trigger. If the condition \"file == \"\" \" is not\r\nfulfilled, a memory leak occurs, as trigger is not deleted. I've added\r\nthe appropriate delete calls for these cases.\r\nI suspect that even in the regular case (file==\"\"), the memory also\r\nleaks, as I could not identify any corresponding delete calls in the\r\nparents/owners of trigger (see issue #4699).\r\n\r\nSigned-off-by: Sebastian Ehmann <sebastian@dipolmoment.de>","created_at":"2018-10-11T17:00:49Z","updated_at":"2018-10-12T11:38:39Z","closed_at":"2018-10-12T11:38:38Z","merged_at":null,"merge_commit_sha":"1333e79ae767fd81109f5c2aae4f9dfa4ccf28b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/sumo/pulls/4700/commits","review_comments_url":"https://api.github.com/repos/eclipse/sumo/pulls/4700/comments","review_comment_url":"https://api.github.com/repos/eclipse/sumo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/sumo/issues/4700/comments","statuses_url":"https://api.github.com/repos/eclipse/sumo/statuses/3f8e17127ac1ea561726e5de6bff65e3609293bf","head":{"label":"seb-ehm:fix-nltrigger-mem-leak","ref":"fix-nltrigger-mem-leak","sha":"3f8e17127ac1ea561726e5de6bff65e3609293bf","user":{"login":"seb-ehm","id":32466614,"node_id":"MDQ6VXNlcjMyNDY2NjE0","avatar_url":"https://avatars1.githubusercontent.com/u/32466614?v=4","gravatar_id":"","url":"https://api.github.com/users/seb-ehm","html_url":"https://github.com/seb-ehm","followers_url":"https://api.github.com/users/seb-ehm/followers","following_url":"https://api.github.com/users/seb-ehm/following{/other_user}","gists_url":"https://api.github.com/users/seb-ehm/gists{/gist_id}","starred_url":"https://api.github.com/users/seb-ehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seb-ehm/subscriptions","organizations_url":"https://api.github.com/users/seb-ehm/orgs","repos_url":"https://api.github.com/users/seb-ehm/repos","events_url":"https://api.github.com/users/seb-ehm/events{/privacy}","received_events_url":"https://api.github.com/users/seb-ehm/received_events","type":"User","site_admin":false},"repo":{"id":123626611,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2MjY2MTE=","name":"sumo","full_name":"seb-ehm/sumo","private":false,"owner":{"login":"seb-ehm","id":32466614,"node_id":"MDQ6VXNlcjMyNDY2NjE0","avatar_url":"https://avatars1.githubusercontent.com/u/32466614?v=4","gravatar_id":"","url":"https://api.github.com/users/seb-ehm","html_url":"https://github.com/seb-ehm","followers_url":"https://api.github.com/users/seb-ehm/followers","following_url":"https://api.github.com/users/seb-ehm/following{/other_user}","gists_url":"https://api.github.com/users/seb-ehm/gists{/gist_id}","starred_url":"https://api.github.com/users/seb-ehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seb-ehm/subscriptions","organizations_url":"https://api.github.com/users/seb-ehm/orgs","repos_url":"https://api.github.com/users/seb-ehm/repos","events_url":"https://api.github.com/users/seb-ehm/events{/privacy}","received_events_url":"https://api.github.com/users/seb-ehm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/seb-ehm/sumo","description":"SUMO is an open source, highly portable, microscopic and continuous road traffic simulation package designed to handle large road networks. It allows for intermodal simulation including pedestrians and comes with a large set of tools for scenario creation.","fork":true,"url":"https://api.github.com/repos/seb-ehm/sumo","forks_url":"https://api.github.com/repos/seb-ehm/sumo/forks","keys_url":"https://api.github.com/repos/seb-ehm/sumo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seb-ehm/sumo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seb-ehm/sumo/teams","hooks_url":"https://api.github.com/repos/seb-ehm/sumo/hooks","issue_events_url":"https://api.github.com/repos/seb-ehm/sumo/issues/events{/number}","events_url":"https://api.github.com/repos/seb-ehm/sumo/events","assignees_url":"https://api.github.com/repos/seb-ehm/sumo/assignees{/user}","branches_url":"https://api.github.com/repos/seb-ehm/sumo/branches{/branch}","tags_url":"https://api.github.com/repos/seb-ehm/sumo/tags","blobs_url":"https://api.github.com/repos/seb-ehm/sumo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seb-ehm/sumo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seb-ehm/sumo/git/refs{/sha}","trees_url":"https://api.github.com/repos/seb-ehm/sumo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seb-ehm/sumo/statuses/{sha}","languages_url":"https://api.github.com/repos/seb-ehm/sumo/languages","stargazers_url":"https://api.github.com/repos/seb-ehm/sumo/stargazers","contributors_url":"https://api.github.com/repos/seb-ehm/sumo/contributors","subscribers_url":"https://api.github.com/repos/seb-ehm/sumo/subscribers","subscription_url":"https://api.github.com/repos/seb-ehm/sumo/subscription","commits_url":"https://api.github.com/repos/seb-ehm/sumo/commits{/sha}","git_commits_url":"https://api.github.com/repos/seb-ehm/sumo/git/commits{/sha}","comments_url":"https://api.github.com/repos/seb-ehm/sumo/comments{/number}","issue_comment_url":"https://api.github.com/repos/seb-ehm/sumo/issues/comments{/number}","contents_url":"https://api.github.com/repos/seb-ehm/sumo/contents/{+path}","compare_url":"https://api.github.com/repos/seb-ehm/sumo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seb-ehm/sumo/merges","archive_url":"https://api.github.com/repos/seb-ehm/sumo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seb-ehm/sumo/downloads","issues_url":"https://api.github.com/repos/seb-ehm/sumo/issues{/number}","pulls_url":"https://api.github.com/repos/seb-ehm/sumo/pulls{/number}","milestones_url":"https://api.github.com/repos/seb-ehm/sumo/milestones{/number}","notifications_url":"https://api.github.com/repos/seb-ehm/sumo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seb-ehm/sumo/labels{/name}","releases_url":"https://api.github.com/repos/seb-ehm/sumo/releases{/id}","deployments_url":"https://api.github.com/repos/seb-ehm/sumo/deployments","created_at":"2018-03-02T20:20:03Z","updated_at":"2018-10-11T15:20:16Z","pushed_at":"2018-10-11T15:20:48Z","git_url":"git://github.com/seb-ehm/sumo.git","ssh_url":"git@github.com:seb-ehm/sumo.git","clone_url":"https://github.com/seb-ehm/sumo.git","svn_url":"https://github.com/seb-ehm/sumo","homepage":"http://sumo.dlr.de","size":450232,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"d6aa3c9859ec41d84b54700c9d2f513444ffa860","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":108592307,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg1OTIzMDc=","name":"sumo","full_name":"eclipse/sumo","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/sumo","description":"SUMO is an open source, highly portable, microscopic and continuous road traffic simulation package designed to handle large road networks. It allows for intermodal simulation including pedestrians and comes with a large set of tools for scenario creation.","fork":false,"url":"https://api.github.com/repos/eclipse/sumo","forks_url":"https://api.github.com/repos/eclipse/sumo/forks","keys_url":"https://api.github.com/repos/eclipse/sumo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/sumo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/sumo/teams","hooks_url":"https://api.github.com/repos/eclipse/sumo/hooks","issue_events_url":"https://api.github.com/repos/eclipse/sumo/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/sumo/events","assignees_url":"https://api.github.com/repos/eclipse/sumo/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/sumo/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/sumo/tags","blobs_url":"https://api.github.com/repos/eclipse/sumo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/sumo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/sumo/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/sumo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/sumo/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/sumo/languages","stargazers_url":"https://api.github.com/repos/eclipse/sumo/stargazers","contributors_url":"https://api.github.com/repos/eclipse/sumo/contributors","subscribers_url":"https://api.github.com/repos/eclipse/sumo/subscribers","subscription_url":"https://api.github.com/repos/eclipse/sumo/subscription","commits_url":"https://api.github.com/repos/eclipse/sumo/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/sumo/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/sumo/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/sumo/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/sumo/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/sumo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/sumo/merges","archive_url":"https://api.github.com/repos/eclipse/sumo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/sumo/downloads","issues_url":"https://api.github.com/repos/eclipse/sumo/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/sumo/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/sumo/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/sumo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/sumo/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/sumo/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/sumo/deployments","created_at":"2017-10-27T20:23:17Z","updated_at":"2018-10-12T11:17:44Z","pushed_at":"2018-10-12T11:17:42Z","git_url":"git://github.com/eclipse/sumo.git","ssh_url":"git@github.com:eclipse/sumo.git","clone_url":"https://github.com/eclipse/sumo.git","svn_url":"https://github.com/eclipse/sumo","homepage":"http://sumo.dlr.de","size":430971,"stargazers_count":224,"watchers_count":224,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":1086,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":112,"open_issues":1086,"watchers":224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/sumo/pulls/4700"},"html":{"href":"https://github.com/eclipse/sumo/pull/4700"},"issue":{"href":"https://api.github.com/repos/eclipse/sumo/issues/4700"},"comments":{"href":"https://api.github.com/repos/eclipse/sumo/issues/4700/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/sumo/pulls/4700/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/sumo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/sumo/pulls/4700/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/sumo/statuses/3f8e17127ac1ea561726e5de6bff65e3609293bf"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"seb-ehm"}}