{"action":"closed","issue":{"url":"https://api.github.com/repos/choefele/CCHMapClusterController/issues/149","repository_url":"https://api.github.com/repos/choefele/CCHMapClusterController","labels_url":"https://api.github.com/repos/choefele/CCHMapClusterController/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/choefele/CCHMapClusterController/issues/149/comments","events_url":"https://api.github.com/repos/choefele/CCHMapClusterController/issues/149/events","html_url":"https://github.com/choefele/CCHMapClusterController/issues/149","id":355245980,"node_id":"MDU6SXNzdWUzNTUyNDU5ODA=","number":149,"title":"Removing Annotations doesn't work correctly","user":{"login":"edwardmp","id":1686739,"node_id":"MDQ6VXNlcjE2ODY3Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1686739?v=4","gravatar_id":"","url":"https://api.github.com/users/edwardmp","html_url":"https://github.com/edwardmp","followers_url":"https://api.github.com/users/edwardmp/followers","following_url":"https://api.github.com/users/edwardmp/following{/other_user}","gists_url":"https://api.github.com/users/edwardmp/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardmp/subscriptions","organizations_url":"https://api.github.com/users/edwardmp/orgs","repos_url":"https://api.github.com/users/edwardmp/repos","events_url":"https://api.github.com/users/edwardmp/events{/privacy}","received_events_url":"https://api.github.com/users/edwardmp/received_events","type":"User","site_admin":false},"labels":[{"id":67222274,"node_id":"MDU6TGFiZWw2NzIyMjI3NA==","url":"https://api.github.com/repos/choefele/CCHMapClusterController/labels/question","name":"question","color":"cc317c","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-29T16:47:13Z","updated_at":"2018-09-04T12:41:34Z","closed_at":"2018-09-04T12:41:34Z","author_association":"NONE","body":"Hi,\r\n\r\nI just tried this library as a replacement for MapKit clustering, as there are several severe bugs in MapKit clustering.. so libraries such as this are still quite useful.\r\n\r\nHowever, I noticed some issues in using this library as well. Eventually I tracked this down to the fact that the annotations are never removed when I call `removeAnnotations` on the clustermanager. I logged the count of number of annotations before and after the remove operation and it keeps increasing.\r\n\r\nSome context: I frequently fetch a list of locations from a server, then remove all existing annotations, and add the updated list of locations to the map.\r\n\r\nShould `self.mapClusterController.removeAnnotations(self.mapView.annotations)`  work?\r\nAnd should I only add new annotations when the completionhandler of removeAnnotations is called?\r\n"}}
{"actor":{"display_login":"choefele"}}