{"action":"created","issue":{"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/1113","repository_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom","labels_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/1113/labels{/name}","comments_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/1113/comments","events_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/1113/events","html_url":"https://github.com/chocolate-doom/chocolate-doom/pull/1113","id":386527690,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjM4MjQ2","number":1113,"title":"Doom: don't divide by zero, but call I_Error instead.","user":{"login":"jkbenaim","id":2214896,"node_id":"MDQ6VXNlcjIyMTQ4OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2214896?v=4","gravatar_id":"","url":"https://api.github.com/users/jkbenaim","html_url":"https://github.com/jkbenaim","followers_url":"https://api.github.com/users/jkbenaim/followers","following_url":"https://api.github.com/users/jkbenaim/following{/other_user}","gists_url":"https://api.github.com/users/jkbenaim/gists{/gist_id}","starred_url":"https://api.github.com/users/jkbenaim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkbenaim/subscriptions","organizations_url":"https://api.github.com/users/jkbenaim/orgs","repos_url":"https://api.github.com/users/jkbenaim/repos","events_url":"https://api.github.com/users/jkbenaim/events{/privacy}","received_events_url":"https://api.github.com/users/jkbenaim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-02T05:08:50Z","updated_at":"2018-12-02T05:11:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/1113","html_url":"https://github.com/chocolate-doom/chocolate-doom/pull/1113","diff_url":"https://github.com/chocolate-doom/chocolate-doom/pull/1113.diff","patch_url":"https://github.com/chocolate-doom/chocolate-doom/pull/1113.patch"},"body":"When loading from a save game, vanilla Doom forgets to initialize some\r\nvariables related to the final boss/Romero's head. In particular, a\r\ncount of the number of spawn points can end up being set to zero. Later,\r\nwhen selecting a spawn target, a division by zero can occur. Vanilla\r\nwill simply crash. In Chocolate Doom, we should exit out gracefully\r\ninstead."},"comment":{"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/comments/443482308","html_url":"https://github.com/chocolate-doom/chocolate-doom/pull/1113#issuecomment-443482308","issue_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/1113","id":443482308,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzQ4MjMwOA==","user":{"login":"jkbenaim","id":2214896,"node_id":"MDQ6VXNlcjIyMTQ4OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2214896?v=4","gravatar_id":"","url":"https://api.github.com/users/jkbenaim","html_url":"https://github.com/jkbenaim","followers_url":"https://api.github.com/users/jkbenaim/followers","following_url":"https://api.github.com/users/jkbenaim/following{/other_user}","gists_url":"https://api.github.com/users/jkbenaim/gists{/gist_id}","starred_url":"https://api.github.com/users/jkbenaim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkbenaim/subscriptions","organizations_url":"https://api.github.com/users/jkbenaim/orgs","repos_url":"https://api.github.com/users/jkbenaim/repos","events_url":"https://api.github.com/users/jkbenaim/events{/privacy}","received_events_url":"https://api.github.com/users/jkbenaim/received_events","type":"User","site_admin":false},"created_at":"2018-12-02T05:11:28Z","updated_at":"2018-12-02T05:11:28Z","author_association":"CONTRIBUTOR","body":"To trigger this:\r\n1. Start Doom 2, go to map 30, and go through the teleporter.\r\n2. Once a spawn cube is in flight, save the game.\r\n3. Quit the game, start the game again, and load the save.\r\n4. **Without this patch:** the game crashes with a floating point exception. **With this patch:** the game exits with an I_Error."}}
{"actor":{"display_login":"jkbenaim"}}