{"action":"created","comment":{"url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments/174868118","pull_request_review_id":104305581,"id":174868118,"diff_hunk":"@@ -12,9 +12,11 @@ import {pick} from 'lodash';\n  * @param {Number} options.thumbnailMaxWidth\n  * @param {Number} options.thumbnailMaxHeight\n  * @param {Boolean} options.enableThumbnails\n+ * @param {Object} options.logger\n  * @returns {Promise<Array>} Buffer, Dimensions, thumbnailDimensions\n  */\n-export default function processImage({\n+// eslint-disable-next-line import/prefer-default-export","path":"packages/node_modules/@ciscospark/helper-image/src/process-image.js","position":8,"original_position":8,"commit_id":"9adf98e6d436246337c60ceccbeb73ba4a324e45","original_commit_id":"9adf98e6d436246337c60ceccbeb73ba4a324e45","user":{"login":"adamweeks","id":190647,"avatar_url":"https://avatars2.githubusercontent.com/u/190647?v=4","gravatar_id":"","url":"https://api.github.com/users/adamweeks","html_url":"https://github.com/adamweeks","followers_url":"https://api.github.com/users/adamweeks/followers","following_url":"https://api.github.com/users/adamweeks/following{/other_user}","gists_url":"https://api.github.com/users/adamweeks/gists{/gist_id}","starred_url":"https://api.github.com/users/adamweeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamweeks/subscriptions","organizations_url":"https://api.github.com/users/adamweeks/orgs","repos_url":"https://api.github.com/users/adamweeks/repos","events_url":"https://api.github.com/users/adamweeks/events{/privacy}","received_events_url":"https://api.github.com/users/adamweeks/received_events","type":"User","site_admin":false},"body":"Any reason why the default was removed? [Our reasoning](https://github.com/ciscospark/web-styleguide/tree/master/javascript#modules--prefer-default-export) behind the rule.","created_at":"2018-03-15T17:34:13Z","updated_at":"2018-03-15T17:34:13Z","html_url":"https://github.com/ciscospark/spark-js-sdk/pull/849#discussion_r174868118","pull_request_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/849","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments/174868118"},"html":{"href":"https://github.com/ciscospark/spark-js-sdk/pull/849#discussion_r174868118"},"pull_request":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/849"}}},"pull_request":{"url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/849","id":174805890,"html_url":"https://github.com/ciscospark/spark-js-sdk/pull/849","diff_url":"https://github.com/ciscospark/spark-js-sdk/pull/849.diff","patch_url":"https://github.com/ciscospark/spark-js-sdk/pull/849.patch","issue_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/849","number":849,"state":"open","locked":false,"title":"fix(internal-plugin-avatar): profile image orientation","user":{"login":"saurjai3","id":22205801,"avatar_url":"https://avatars0.githubusercontent.com/u/22205801?v=4","gravatar_id":"","url":"https://api.github.com/users/saurjai3","html_url":"https://github.com/saurjai3","followers_url":"https://api.github.com/users/saurjai3/followers","following_url":"https://api.github.com/users/saurjai3/following{/other_user}","gists_url":"https://api.github.com/users/saurjai3/gists{/gist_id}","starred_url":"https://api.github.com/users/saurjai3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurjai3/subscriptions","organizations_url":"https://api.github.com/users/saurjai3/orgs","repos_url":"https://api.github.com/users/saurjai3/repos","events_url":"https://api.github.com/users/saurjai3/events{/privacy}","received_events_url":"https://api.github.com/users/saurjai3/received_events","type":"User","site_admin":false},"body":"# Pull Request Template\r\n\r\n## Description\r\n\r\nFixes issue with the image orientation on profile avatars. The code for the same was earlier available as part of internal-plugin-conversation, but that is moved to helper-image so that the same code with minimal changes could be utilized for internal-plugin-avatar.\r\n\r\nFixes # (issue)\r\nhttps://jira-eng-gpk2.cisco.com/jira/browse/SPARK-2864\r\n\r\n## Type of Change\r\n\r\nPlease delete options that are not relevant.\r\n\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] This change requires a documentation update\r\n\r\n## Test Coverage\r\n\r\nPlease describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration\r\n\r\n- Test images to reproduce and verify the existing bug could be referred from: https://github.com/recurser/exif-orientation-examples\r\n\r\n**Test Configuration**:\r\n* SDK Version\r\n* Node/Browser Version\r\n* NPM Version\r\n\r\n## Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project\r\n- [x] I have performed a self-review of my own code\r\n- [ ] I have commented my code, particularly in hard-to-understand areas\r\n- [ ] I have made corresponding changes to the documentation\r\n- [x] My changes generate no new warnings\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [x] New and existing unit tests pass locally with my changes\r\n- [ ] Any dependent changes have been merged and published in downstream modules\r\n","created_at":"2018-03-13T22:19:11Z","updated_at":"2018-03-15T17:34:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c0e15f718168b8690eb89eba5df75ab40f2cfac","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bzang","id":99547,"avatar_url":"https://avatars3.githubusercontent.com/u/99547?v=4","gravatar_id":"","url":"https://api.github.com/users/bzang","html_url":"https://github.com/bzang","followers_url":"https://api.github.com/users/bzang/followers","following_url":"https://api.github.com/users/bzang/following{/other_user}","gists_url":"https://api.github.com/users/bzang/gists{/gist_id}","starred_url":"https://api.github.com/users/bzang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzang/subscriptions","organizations_url":"https://api.github.com/users/bzang/orgs","repos_url":"https://api.github.com/users/bzang/repos","events_url":"https://api.github.com/users/bzang/events{/privacy}","received_events_url":"https://api.github.com/users/bzang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/849/commits","review_comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/849/comments","review_comment_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/849/comments","statuses_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/9adf98e6d436246337c60ceccbeb73ba4a324e45","head":{"label":"saurjai3:fixavatarupload","ref":"fixavatarupload","sha":"9adf98e6d436246337c60ceccbeb73ba4a324e45","user":{"login":"saurjai3","id":22205801,"avatar_url":"https://avatars0.githubusercontent.com/u/22205801?v=4","gravatar_id":"","url":"https://api.github.com/users/saurjai3","html_url":"https://github.com/saurjai3","followers_url":"https://api.github.com/users/saurjai3/followers","following_url":"https://api.github.com/users/saurjai3/following{/other_user}","gists_url":"https://api.github.com/users/saurjai3/gists{/gist_id}","starred_url":"https://api.github.com/users/saurjai3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurjai3/subscriptions","organizations_url":"https://api.github.com/users/saurjai3/orgs","repos_url":"https://api.github.com/users/saurjai3/repos","events_url":"https://api.github.com/users/saurjai3/events{/privacy}","received_events_url":"https://api.github.com/users/saurjai3/received_events","type":"User","site_admin":false},"repo":{"id":68249486,"name":"spark-js-sdk","full_name":"saurjai3/spark-js-sdk","owner":{"login":"saurjai3","id":22205801,"avatar_url":"https://avatars0.githubusercontent.com/u/22205801?v=4","gravatar_id":"","url":"https://api.github.com/users/saurjai3","html_url":"https://github.com/saurjai3","followers_url":"https://api.github.com/users/saurjai3/followers","following_url":"https://api.github.com/users/saurjai3/following{/other_user}","gists_url":"https://api.github.com/users/saurjai3/gists{/gist_id}","starred_url":"https://api.github.com/users/saurjai3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurjai3/subscriptions","organizations_url":"https://api.github.com/users/saurjai3/orgs","repos_url":"https://api.github.com/users/saurjai3/repos","events_url":"https://api.github.com/users/saurjai3/events{/privacy}","received_events_url":"https://api.github.com/users/saurjai3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saurjai3/spark-js-sdk","description":null,"fork":true,"url":"https://api.github.com/repos/saurjai3/spark-js-sdk","forks_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/forks","keys_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/teams","hooks_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/events","assignees_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/tags","blobs_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/languages","stargazers_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/subscription","commits_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/merges","archive_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/downloads","issues_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/saurjai3/spark-js-sdk/deployments","created_at":"2016-09-14T22:48:15Z","updated_at":"2016-09-14T22:48:17Z","pushed_at":"2018-03-14T20:46:07Z","git_url":"git://github.com/saurjai3/spark-js-sdk.git","ssh_url":"git@github.com:saurjai3/spark-js-sdk.git","clone_url":"https://github.com/saurjai3/spark-js-sdk.git","svn_url":"https://github.com/saurjai3/spark-js-sdk","homepage":"https://ciscospark.github.io/spark-js-sdk/","size":29050,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ciscospark:master","ref":"master","sha":"9a67c1c3af5098b192f7d719b7bd8de92a81dc4b","user":{"login":"ciscospark","id":15900782,"avatar_url":"https://avatars0.githubusercontent.com/u/15900782?v=4","gravatar_id":"","url":"https://api.github.com/users/ciscospark","html_url":"https://github.com/ciscospark","followers_url":"https://api.github.com/users/ciscospark/followers","following_url":"https://api.github.com/users/ciscospark/following{/other_user}","gists_url":"https://api.github.com/users/ciscospark/gists{/gist_id}","starred_url":"https://api.github.com/users/ciscospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciscospark/subscriptions","organizations_url":"https://api.github.com/users/ciscospark/orgs","repos_url":"https://api.github.com/users/ciscospark/repos","events_url":"https://api.github.com/users/ciscospark/events{/privacy}","received_events_url":"https://api.github.com/users/ciscospark/received_events","type":"Organization","site_admin":false},"repo":{"id":62836827,"name":"spark-js-sdk","full_name":"ciscospark/spark-js-sdk","owner":{"login":"ciscospark","id":15900782,"avatar_url":"https://avatars0.githubusercontent.com/u/15900782?v=4","gravatar_id":"","url":"https://api.github.com/users/ciscospark","html_url":"https://github.com/ciscospark","followers_url":"https://api.github.com/users/ciscospark/followers","following_url":"https://api.github.com/users/ciscospark/following{/other_user}","gists_url":"https://api.github.com/users/ciscospark/gists{/gist_id}","starred_url":"https://api.github.com/users/ciscospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciscospark/subscriptions","organizations_url":"https://api.github.com/users/ciscospark/orgs","repos_url":"https://api.github.com/users/ciscospark/repos","events_url":"https://api.github.com/users/ciscospark/events{/privacy}","received_events_url":"https://api.github.com/users/ciscospark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciscospark/spark-js-sdk","description":"JavaScript SDK for CiscoSpark","fork":false,"url":"https://api.github.com/repos/ciscospark/spark-js-sdk","forks_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/forks","keys_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/teams","hooks_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/events","assignees_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/tags","blobs_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/languages","stargazers_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/subscription","commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/merges","archive_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/downloads","issues_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/deployments","created_at":"2016-07-07T20:41:12Z","updated_at":"2018-03-14T15:45:02Z","pushed_at":"2018-03-15T15:03:43Z","git_url":"git://github.com/ciscospark/spark-js-sdk.git","ssh_url":"git@github.com:ciscospark/spark-js-sdk.git","clone_url":"https://github.com/ciscospark/spark-js-sdk.git","svn_url":"https://github.com/ciscospark/spark-js-sdk","homepage":"https://ciscospark.github.io/spark-js-sdk/","size":42497,"stargazers_count":55,"watchers_count":55,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":74,"open_issues":114,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/849"},"html":{"href":"https://github.com/ciscospark/spark-js-sdk/pull/849"},"issue":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/849"},"comments":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/849/comments"},"review_comments":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/849/comments"},"review_comment":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/849/commits"},"statuses":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/9adf98e6d436246337c60ceccbeb73ba4a324e45"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adamweeks"}}