{"action":"created","comment":{"url":"https://api.github.com/repos/redaxo/redaxo/pulls/comments/218851950","pull_request_review_id":156882949,"id":218851950,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODg1MTk1MA==","diff_hunk":"@@ -51,13 +52,23 @@\n     $sel_mailer->addOption($type, $type);\n }\n \n+$sel_security_mode = new rex_select();\n+$sel_security_mode->setId('security_mode');\n+$sel_security_mode->setName('settings[security_mode]');\n+$sel_security_mode->setSize(1);\n+$sel_security_mode->setAttribute('class', 'form-control selectpicker');\n+$sel_security_mode->setSelected($this->getConfig('security_mode'));\n+foreach ([0 => $this->i18n('security_mode_manual'), 1 => $this->i18n('security_mode_auto')] as $i => $type) {\n+    $sel_security_mode->addOption($type, $i);\n+}\n+\n $sel_smtpauth = new rex_select();\n $sel_smtpauth->setId('phpmailer-smtpauth');\n $sel_smtpauth->setName('settings[smtpauth]');\n $sel_smtpauth->setSize(1);\n $sel_smtpauth->setAttribute('class', 'form-control selectpicker');\n $sel_smtpauth->setSelected($this->getConfig('smtpauth'));\n-foreach ([0 => 'false', 1 => 'true'] as $i => $type) {\n+foreach ([0 => $this->i18n('smtp_auth_off'), 1 => $this->i18n('smtp_auth_on')] as $i => $type) {","path":"redaxo/src/addons/phpmailer/pages/config.php","position":29,"original_position":29,"commit_id":"52c76749e924c2e48a3f0cc95597436f6774ece9","original_commit_id":"52c76749e924c2e48a3f0cc95597436f6774ece9","user":{"login":"staabm","id":120441,"node_id":"MDQ6VXNlcjEyMDQ0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/120441?v=4","gravatar_id":"","url":"https://api.github.com/users/staabm","html_url":"https://github.com/staabm","followers_url":"https://api.github.com/users/staabm/followers","following_url":"https://api.github.com/users/staabm/following{/other_user}","gists_url":"https://api.github.com/users/staabm/gists{/gist_id}","starred_url":"https://api.github.com/users/staabm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staabm/subscriptions","organizations_url":"https://api.github.com/users/staabm/orgs","repos_url":"https://api.github.com/users/staabm/repos","events_url":"https://api.github.com/users/staabm/events{/privacy}","received_events_url":"https://api.github.com/users/staabm/received_events","type":"User","site_admin":false},"body":"@skerbis ich hab hier mal je option genauer die unteroptionen definiert im lang-file statt so allgemeine \"yes\", \"no\", \"true\", \"false\" etc. keys.","created_at":"2018-09-19T15:29:41Z","updated_at":"2018-09-19T15:29:42Z","html_url":"https://github.com/redaxo/redaxo/pull/2000#discussion_r218851950","pull_request_url":"https://api.github.com/repos/redaxo/redaxo/pulls/2000","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/redaxo/redaxo/pulls/comments/218851950"},"html":{"href":"https://github.com/redaxo/redaxo/pull/2000#discussion_r218851950"},"pull_request":{"href":"https://api.github.com/repos/redaxo/redaxo/pulls/2000"}}},"pull_request":{"url":"https://api.github.com/repos/redaxo/redaxo/pulls/2000","id":214166984,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTY2OTg0","html_url":"https://github.com/redaxo/redaxo/pull/2000","diff_url":"https://github.com/redaxo/redaxo/pull/2000.diff","patch_url":"https://github.com/redaxo/redaxo/pull/2000.patch","issue_url":"https://api.github.com/repos/redaxo/redaxo/issues/2000","number":2000,"state":"closed","locked":false,"title":"PHPMailer :: Verschlüsselungsoption + UI-Änderungen","user":{"login":"skerbis","id":791247,"node_id":"MDQ6VXNlcjc5MTI0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/791247?v=4","gravatar_id":"","url":"https://api.github.com/users/skerbis","html_url":"https://github.com/skerbis","followers_url":"https://api.github.com/users/skerbis/followers","following_url":"https://api.github.com/users/skerbis/following{/other_user}","gists_url":"https://api.github.com/users/skerbis/gists{/gist_id}","starred_url":"https://api.github.com/users/skerbis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skerbis/subscriptions","organizations_url":"https://api.github.com/users/skerbis/orgs","repos_url":"https://api.github.com/users/skerbis/repos","events_url":"https://api.github.com/users/skerbis/events{/privacy}","received_events_url":"https://api.github.com/users/skerbis/received_events","type":"User","site_admin":false},"body":"1) kleine Übersetzungskorrekturen en\r\n2) Readme ergänzt\r\n3) SMTP Authentifizierung case sensitive \r\n4) Die Darstellung der Spalten ist geändert. \r\nE-Mail und SMTP-Optionen befinden sich nun in einer Spalte\r\nAlle weiteren Einstellungen in der Zweiten Spalte. \r\n\r\nSo ist sichergestellt, dass der E-Mail-Test immer am Ende (mobil) oder unten rechts (Desktop) ist.\r\n\r\n<img width=\"1416\" alt=\"bildschirmfoto 2018-09-15 um 19 51 03\" src=\"https://user-images.githubusercontent.com/791247/45589136-e2cd5680-b920-11e8-87a9-523432eae2e4.png\">\r\n\r\n5 ) Es kann nun zwischen automischer Verschlüsselung (AutoTLS) und Manueller Auswahl (keine,tls,ssh) gewählt werden. \r\n\r\nWarum? Der Vendor ist per default auf AutoTLS gestellt. Was auch empfehlenswert ist. Für das lokale Testing oder bei Auswahl von localhost als Server, kann dies jedoch problematisch sein. \r\n\r\n6. Debug Info und Optionen überarbeitet","created_at":"2018-09-09T21:53:37Z","updated_at":"2018-09-19T15:29:41Z","closed_at":"2018-09-19T15:27:42Z","merged_at":"2018-09-19T15:27:42Z","merge_commit_sha":"372b488d2fa8dc8803b615197a284a231fd50088","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gharlan","id":330436,"node_id":"MDQ6VXNlcjMzMDQzNg==","avatar_url":"https://avatars0.githubusercontent.com/u/330436?v=4","gravatar_id":"","url":"https://api.github.com/users/gharlan","html_url":"https://github.com/gharlan","followers_url":"https://api.github.com/users/gharlan/followers","following_url":"https://api.github.com/users/gharlan/following{/other_user}","gists_url":"https://api.github.com/users/gharlan/gists{/gist_id}","starred_url":"https://api.github.com/users/gharlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gharlan/subscriptions","organizations_url":"https://api.github.com/users/gharlan/orgs","repos_url":"https://api.github.com/users/gharlan/repos","events_url":"https://api.github.com/users/gharlan/events{/privacy}","received_events_url":"https://api.github.com/users/gharlan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":708681103,"node_id":"MDU6TGFiZWw3MDg2ODExMDM=","url":"https://api.github.com/repos/redaxo/redaxo/labels/Developer%20Experience%20(DX)","name":"Developer Experience (DX)","color":"fbca04","default":false},{"id":8175338,"node_id":"MDU6TGFiZWw4MTc1MzM4","url":"https://api.github.com/repos/redaxo/redaxo/labels/Enhancement","name":"Enhancement","color":"02e10c","default":false},{"id":572356757,"node_id":"MDU6TGFiZWw1NzIzNTY3NTc=","url":"https://api.github.com/repos/redaxo/redaxo/labels/PHPMailer","name":"PHPMailer","color":"333333","default":false}],"milestone":{"url":"https://api.github.com/repos/redaxo/redaxo/milestones/13","html_url":"https://github.com/redaxo/redaxo/milestone/13","labels_url":"https://api.github.com/repos/redaxo/redaxo/milestones/13/labels","id":3378565,"node_id":"MDk6TWlsZXN0b25lMzM3ODU2NQ==","number":13,"title":"REDAXO 5.7","description":null,"creator":{"login":"tbaddade","id":338267,"node_id":"MDQ6VXNlcjMzODI2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/338267?v=4","gravatar_id":"","url":"https://api.github.com/users/tbaddade","html_url":"https://github.com/tbaddade","followers_url":"https://api.github.com/users/tbaddade/followers","following_url":"https://api.github.com/users/tbaddade/following{/other_user}","gists_url":"https://api.github.com/users/tbaddade/gists{/gist_id}","starred_url":"https://api.github.com/users/tbaddade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbaddade/subscriptions","organizations_url":"https://api.github.com/users/tbaddade/orgs","repos_url":"https://api.github.com/users/tbaddade/repos","events_url":"https://api.github.com/users/tbaddade/events{/privacy}","received_events_url":"https://api.github.com/users/tbaddade/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":44,"state":"open","created_at":"2018-05-26T20:39:25Z","updated_at":"2018-09-19T15:27:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/redaxo/redaxo/pulls/2000/commits","review_comments_url":"https://api.github.com/repos/redaxo/redaxo/pulls/2000/comments","review_comment_url":"https://api.github.com/repos/redaxo/redaxo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redaxo/redaxo/issues/2000/comments","statuses_url":"https://api.github.com/repos/redaxo/redaxo/statuses/52c76749e924c2e48a3f0cc95597436f6774ece9","head":{"label":"skerbis:phpmailer-config","ref":"phpmailer-config","sha":"52c76749e924c2e48a3f0cc95597436f6774ece9","user":{"login":"skerbis","id":791247,"node_id":"MDQ6VXNlcjc5MTI0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/791247?v=4","gravatar_id":"","url":"https://api.github.com/users/skerbis","html_url":"https://github.com/skerbis","followers_url":"https://api.github.com/users/skerbis/followers","following_url":"https://api.github.com/users/skerbis/following{/other_user}","gists_url":"https://api.github.com/users/skerbis/gists{/gist_id}","starred_url":"https://api.github.com/users/skerbis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skerbis/subscriptions","organizations_url":"https://api.github.com/users/skerbis/orgs","repos_url":"https://api.github.com/users/skerbis/repos","events_url":"https://api.github.com/users/skerbis/events{/privacy}","received_events_url":"https://api.github.com/users/skerbis/received_events","type":"User","site_admin":false},"repo":{"id":148067139,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgwNjcxMzk=","name":"redaxo","full_name":"skerbis/redaxo","private":false,"owner":{"login":"skerbis","id":791247,"node_id":"MDQ6VXNlcjc5MTI0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/791247?v=4","gravatar_id":"","url":"https://api.github.com/users/skerbis","html_url":"https://github.com/skerbis","followers_url":"https://api.github.com/users/skerbis/followers","following_url":"https://api.github.com/users/skerbis/following{/other_user}","gists_url":"https://api.github.com/users/skerbis/gists{/gist_id}","starred_url":"https://api.github.com/users/skerbis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skerbis/subscriptions","organizations_url":"https://api.github.com/users/skerbis/orgs","repos_url":"https://api.github.com/users/skerbis/repos","events_url":"https://api.github.com/users/skerbis/events{/privacy}","received_events_url":"https://api.github.com/users/skerbis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/skerbis/redaxo","description":"REDAXO, a PHP-based CMS since 2004. Both simple and flexible.","fork":true,"url":"https://api.github.com/repos/skerbis/redaxo","forks_url":"https://api.github.com/repos/skerbis/redaxo/forks","keys_url":"https://api.github.com/repos/skerbis/redaxo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skerbis/redaxo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skerbis/redaxo/teams","hooks_url":"https://api.github.com/repos/skerbis/redaxo/hooks","issue_events_url":"https://api.github.com/repos/skerbis/redaxo/issues/events{/number}","events_url":"https://api.github.com/repos/skerbis/redaxo/events","assignees_url":"https://api.github.com/repos/skerbis/redaxo/assignees{/user}","branches_url":"https://api.github.com/repos/skerbis/redaxo/branches{/branch}","tags_url":"https://api.github.com/repos/skerbis/redaxo/tags","blobs_url":"https://api.github.com/repos/skerbis/redaxo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skerbis/redaxo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skerbis/redaxo/git/refs{/sha}","trees_url":"https://api.github.com/repos/skerbis/redaxo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skerbis/redaxo/statuses/{sha}","languages_url":"https://api.github.com/repos/skerbis/redaxo/languages","stargazers_url":"https://api.github.com/repos/skerbis/redaxo/stargazers","contributors_url":"https://api.github.com/repos/skerbis/redaxo/contributors","subscribers_url":"https://api.github.com/repos/skerbis/redaxo/subscribers","subscription_url":"https://api.github.com/repos/skerbis/redaxo/subscription","commits_url":"https://api.github.com/repos/skerbis/redaxo/commits{/sha}","git_commits_url":"https://api.github.com/repos/skerbis/redaxo/git/commits{/sha}","comments_url":"https://api.github.com/repos/skerbis/redaxo/comments{/number}","issue_comment_url":"https://api.github.com/repos/skerbis/redaxo/issues/comments{/number}","contents_url":"https://api.github.com/repos/skerbis/redaxo/contents/{+path}","compare_url":"https://api.github.com/repos/skerbis/redaxo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skerbis/redaxo/merges","archive_url":"https://api.github.com/repos/skerbis/redaxo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skerbis/redaxo/downloads","issues_url":"https://api.github.com/repos/skerbis/redaxo/issues{/number}","pulls_url":"https://api.github.com/repos/skerbis/redaxo/pulls{/number}","milestones_url":"https://api.github.com/repos/skerbis/redaxo/milestones{/number}","notifications_url":"https://api.github.com/repos/skerbis/redaxo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skerbis/redaxo/labels{/name}","releases_url":"https://api.github.com/repos/skerbis/redaxo/releases{/id}","deployments_url":"https://api.github.com/repos/skerbis/redaxo/deployments","created_at":"2018-09-09T21:25:52Z","updated_at":"2018-09-09T21:25:56Z","pushed_at":"2018-09-19T15:24:27Z","git_url":"git://github.com/skerbis/redaxo.git","ssh_url":"git@github.com:skerbis/redaxo.git","clone_url":"https://github.com/skerbis/redaxo.git","svn_url":"https://github.com/skerbis/redaxo","homepage":"https://redaxo.org","size":22831,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redaxo:master","ref":"master","sha":"9ee29bc0e4b89ee4182faef55eec7a8388a82407","user":{"login":"redaxo","id":280216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MDIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/280216?v=4","gravatar_id":"","url":"https://api.github.com/users/redaxo","html_url":"https://github.com/redaxo","followers_url":"https://api.github.com/users/redaxo/followers","following_url":"https://api.github.com/users/redaxo/following{/other_user}","gists_url":"https://api.github.com/users/redaxo/gists{/gist_id}","starred_url":"https://api.github.com/users/redaxo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redaxo/subscriptions","organizations_url":"https://api.github.com/users/redaxo/orgs","repos_url":"https://api.github.com/users/redaxo/repos","events_url":"https://api.github.com/users/redaxo/events{/privacy}","received_events_url":"https://api.github.com/users/redaxo/received_events","type":"Organization","site_admin":false},"repo":{"id":756485,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0ODU=","name":"redaxo","full_name":"redaxo/redaxo","private":false,"owner":{"login":"redaxo","id":280216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MDIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/280216?v=4","gravatar_id":"","url":"https://api.github.com/users/redaxo","html_url":"https://github.com/redaxo","followers_url":"https://api.github.com/users/redaxo/followers","following_url":"https://api.github.com/users/redaxo/following{/other_user}","gists_url":"https://api.github.com/users/redaxo/gists{/gist_id}","starred_url":"https://api.github.com/users/redaxo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redaxo/subscriptions","organizations_url":"https://api.github.com/users/redaxo/orgs","repos_url":"https://api.github.com/users/redaxo/repos","events_url":"https://api.github.com/users/redaxo/events{/privacy}","received_events_url":"https://api.github.com/users/redaxo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/redaxo/redaxo","description":"REDAXO, a PHP-based CMS since 2004. Both simple and flexible.","fork":false,"url":"https://api.github.com/repos/redaxo/redaxo","forks_url":"https://api.github.com/repos/redaxo/redaxo/forks","keys_url":"https://api.github.com/repos/redaxo/redaxo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redaxo/redaxo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redaxo/redaxo/teams","hooks_url":"https://api.github.com/repos/redaxo/redaxo/hooks","issue_events_url":"https://api.github.com/repos/redaxo/redaxo/issues/events{/number}","events_url":"https://api.github.com/repos/redaxo/redaxo/events","assignees_url":"https://api.github.com/repos/redaxo/redaxo/assignees{/user}","branches_url":"https://api.github.com/repos/redaxo/redaxo/branches{/branch}","tags_url":"https://api.github.com/repos/redaxo/redaxo/tags","blobs_url":"https://api.github.com/repos/redaxo/redaxo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redaxo/redaxo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redaxo/redaxo/git/refs{/sha}","trees_url":"https://api.github.com/repos/redaxo/redaxo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redaxo/redaxo/statuses/{sha}","languages_url":"https://api.github.com/repos/redaxo/redaxo/languages","stargazers_url":"https://api.github.com/repos/redaxo/redaxo/stargazers","contributors_url":"https://api.github.com/repos/redaxo/redaxo/contributors","subscribers_url":"https://api.github.com/repos/redaxo/redaxo/subscribers","subscription_url":"https://api.github.com/repos/redaxo/redaxo/subscription","commits_url":"https://api.github.com/repos/redaxo/redaxo/commits{/sha}","git_commits_url":"https://api.github.com/repos/redaxo/redaxo/git/commits{/sha}","comments_url":"https://api.github.com/repos/redaxo/redaxo/comments{/number}","issue_comment_url":"https://api.github.com/repos/redaxo/redaxo/issues/comments{/number}","contents_url":"https://api.github.com/repos/redaxo/redaxo/contents/{+path}","compare_url":"https://api.github.com/repos/redaxo/redaxo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redaxo/redaxo/merges","archive_url":"https://api.github.com/repos/redaxo/redaxo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redaxo/redaxo/downloads","issues_url":"https://api.github.com/repos/redaxo/redaxo/issues{/number}","pulls_url":"https://api.github.com/repos/redaxo/redaxo/pulls{/number}","milestones_url":"https://api.github.com/repos/redaxo/redaxo/milestones{/number}","notifications_url":"https://api.github.com/repos/redaxo/redaxo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redaxo/redaxo/labels{/name}","releases_url":"https://api.github.com/repos/redaxo/redaxo/releases{/id}","deployments_url":"https://api.github.com/repos/redaxo/redaxo/deployments","created_at":"2010-07-04T16:46:03Z","updated_at":"2018-09-19T15:27:47Z","pushed_at":"2018-09-19T15:27:43Z","git_url":"git://github.com/redaxo/redaxo.git","ssh_url":"git@github.com:redaxo/redaxo.git","clone_url":"https://github.com/redaxo/redaxo.git","svn_url":"https://github.com/redaxo/redaxo","homepage":"https://redaxo.org","size":23235,"stargazers_count":202,"watchers_count":202,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":339,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":70,"open_issues":339,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redaxo/redaxo/pulls/2000"},"html":{"href":"https://github.com/redaxo/redaxo/pull/2000"},"issue":{"href":"https://api.github.com/repos/redaxo/redaxo/issues/2000"},"comments":{"href":"https://api.github.com/repos/redaxo/redaxo/issues/2000/comments"},"review_comments":{"href":"https://api.github.com/repos/redaxo/redaxo/pulls/2000/comments"},"review_comment":{"href":"https://api.github.com/repos/redaxo/redaxo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redaxo/redaxo/pulls/2000/commits"},"statuses":{"href":"https://api.github.com/repos/redaxo/redaxo/statuses/52c76749e924c2e48a3f0cc95597436f6774ece9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"staabm"}}