{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/224954351","pull_request_review_id":164456858,"id":224954351,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk1NDM1MQ==","diff_hunk":"@@ -0,0 +1,57 @@\n+{ config, lib, pkgs, ... }: with lib;\n+\n+let\n+  cfg = config.services.dnscrypt-proxy2;\n+\n+  json = pkgs.writeText \"dnscrypt-proxy.json\" (builtins.toJSON cfg.config);\n+\n+  toml = pkgs.runCommand \"dnscrypt-proxy.toml\" {} ''\n+    ${pkgs.remarshal}/bin/json2toml < ${json} > $out\n+  '';\n+in\n+\n+{\n+  options.services.dnscrypt-proxy2 = {\n+    enable = mkEnableOption \"dnscrypt-proxy\";\n+\n+    config = mkOption {\n+      description = ''\n+        Attrset that is converted and passed as TOML config file.\n+        For available params, see: https://git.io/fxBne\n+      '';\n+      example = literalExample ''\n+        {\n+          sources.public-resolvers = {","path":"nixos/modules/services/networking/dnscrypt-proxy2.nix","position":24,"original_position":24,"commit_id":"1864f6b30031a277a1843c8b1873881f2123a7e5","original_commit_id":"1864f6b30031a277a1843c8b1873881f2123a7e5","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"This could become the default value no?","created_at":"2018-10-13T09:04:02Z","updated_at":"2018-10-13T09:04:03Z","html_url":"https://github.com/NixOS/nixpkgs/pull/48289#discussion_r224954351","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48289","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/224954351"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/48289#discussion_r224954351"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48289"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48289","id":222593539,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTkzNTM5","html_url":"https://github.com/NixOS/nixpkgs/pull/48289","diff_url":"https://github.com/NixOS/nixpkgs/pull/48289.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/48289.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48289","number":48289,"state":"open","locked":false,"title":"dnscrypt-proxy2: 2.0.15 -> 2.0.17, add NixOS module","user":{"login":"yegortimoshenko","id":1643293,"node_id":"MDQ6VXNlcjE2NDMyOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1643293?v=4","gravatar_id":"","url":"https://api.github.com/users/yegortimoshenko","html_url":"https://github.com/yegortimoshenko","followers_url":"https://api.github.com/users/yegortimoshenko/followers","following_url":"https://api.github.com/users/yegortimoshenko/following{/other_user}","gists_url":"https://api.github.com/users/yegortimoshenko/gists{/gist_id}","starred_url":"https://api.github.com/users/yegortimoshenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yegortimoshenko/subscriptions","organizations_url":"https://api.github.com/users/yegortimoshenko/orgs","repos_url":"https://api.github.com/users/yegortimoshenko/repos","events_url":"https://api.github.com/users/yegortimoshenko/events{/privacy}","received_events_url":"https://api.github.com/users/yegortimoshenko/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nResolves https://github.com/NixOS/nixpkgs/issues/43298.\r\n\r\ncc @joachifm @Shados \r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-10-12T21:41:11Z","updated_at":"2018-10-13T09:04:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b5b7b10acd359d66e525c81dc97c3ddc6d055fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48289/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48289/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48289/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/1864f6b30031a277a1843c8b1873881f2123a7e5","head":{"label":"transumption:201810/dnscrypt-proxy2","ref":"201810/dnscrypt-proxy2","sha":"1864f6b30031a277a1843c8b1873881f2123a7e5","user":{"login":"transumption","id":43579847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTc5ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/43579847?v=4","gravatar_id":"","url":"https://api.github.com/users/transumption","html_url":"https://github.com/transumption","followers_url":"https://api.github.com/users/transumption/followers","following_url":"https://api.github.com/users/transumption/following{/other_user}","gists_url":"https://api.github.com/users/transumption/gists{/gist_id}","starred_url":"https://api.github.com/users/transumption/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transumption/subscriptions","organizations_url":"https://api.github.com/users/transumption/orgs","repos_url":"https://api.github.com/users/transumption/repos","events_url":"https://api.github.com/users/transumption/events{/privacy}","received_events_url":"https://api.github.com/users/transumption/received_events","type":"Organization","site_admin":false},"repo":{"id":152794887,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3OTQ4ODc=","name":"nixpkgs","full_name":"transumption/nixpkgs","private":false,"owner":{"login":"transumption","id":43579847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTc5ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/43579847?v=4","gravatar_id":"","url":"https://api.github.com/users/transumption","html_url":"https://github.com/transumption","followers_url":"https://api.github.com/users/transumption/followers","following_url":"https://api.github.com/users/transumption/following{/other_user}","gists_url":"https://api.github.com/users/transumption/gists{/gist_id}","starred_url":"https://api.github.com/users/transumption/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transumption/subscriptions","organizations_url":"https://api.github.com/users/transumption/orgs","repos_url":"https://api.github.com/users/transumption/repos","events_url":"https://api.github.com/users/transumption/events{/privacy}","received_events_url":"https://api.github.com/users/transumption/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transumption/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/transumption/nixpkgs","forks_url":"https://api.github.com/repos/transumption/nixpkgs/forks","keys_url":"https://api.github.com/repos/transumption/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transumption/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transumption/nixpkgs/teams","hooks_url":"https://api.github.com/repos/transumption/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/transumption/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/transumption/nixpkgs/events","assignees_url":"https://api.github.com/repos/transumption/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/transumption/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/transumption/nixpkgs/tags","blobs_url":"https://api.github.com/repos/transumption/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transumption/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transumption/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/transumption/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transumption/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/transumption/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/transumption/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/transumption/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/transumption/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/transumption/nixpkgs/subscription","commits_url":"https://api.github.com/repos/transumption/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/transumption/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/transumption/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/transumption/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/transumption/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/transumption/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transumption/nixpkgs/merges","archive_url":"https://api.github.com/repos/transumption/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transumption/nixpkgs/downloads","issues_url":"https://api.github.com/repos/transumption/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/transumption/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/transumption/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/transumption/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transumption/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/transumption/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/transumption/nixpkgs/deployments","created_at":"2018-10-12T18:52:28Z","updated_at":"2018-10-12T18:53:06Z","pushed_at":"2018-10-13T01:17:19Z","git_url":"git://github.com/transumption/nixpkgs.git","ssh_url":"git@github.com:transumption/nixpkgs.git","clone_url":"https://github.com/transumption/nixpkgs.git","svn_url":"https://github.com/transumption/nixpkgs","homepage":null,"size":814278,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"1bde5ec7e036501ae1e0fbd91e4e01af1dcd3a8b","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-10-13T09:03:31Z","pushed_at":"2018-10-13T08:59:09Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":868402,"stargazers_count":2889,"watchers_count":2889,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3063,"mirror_url":null,"archived":false,"open_issues_count":3306,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3063,"open_issues":3306,"watchers":2889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48289"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/48289"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48289"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48289/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48289/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48289/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/1864f6b30031a277a1843c8b1873881f2123a7e5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Mic92"}}