{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-cli/issues/3683","repository_url":"https://api.github.com/repos/aws/aws-cli","labels_url":"https://api.github.com/repos/aws/aws-cli/issues/3683/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-cli/issues/3683/comments","events_url":"https://api.github.com/repos/aws/aws-cli/issues/3683/events","html_url":"https://github.com/aws/aws-cli/pull/3683","id":374161817,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTI3MjA1","number":3683,"title":"[#3619] eks update-kubeconfig set env from --profile/AWS_PROFILE env","user":{"login":"mbarrien","id":1753192,"node_id":"MDQ6VXNlcjE3NTMxOTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1753192?v=4","gravatar_id":"","url":"https://api.github.com/users/mbarrien","html_url":"https://github.com/mbarrien","followers_url":"https://api.github.com/users/mbarrien/followers","following_url":"https://api.github.com/users/mbarrien/following{/other_user}","gists_url":"https://api.github.com/users/mbarrien/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarrien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarrien/subscriptions","organizations_url":"https://api.github.com/users/mbarrien/orgs","repos_url":"https://api.github.com/users/mbarrien/repos","events_url":"https://api.github.com/users/mbarrien/events{/privacy}","received_events_url":"https://api.github.com/users/mbarrien/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-25T22:44:37Z","updated_at":"2018-11-07T20:35:56Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aws/aws-cli/pulls/3683","html_url":"https://github.com/aws/aws-cli/pull/3683","diff_url":"https://github.com/aws/aws-cli/pull/3683.diff","patch_url":"https://github.com/aws/aws-cli/pull/3683.patch"},"body":"This PR closes #3619 by reading the value of profile from the session. It is set either by --profile CLI flag or the AWS_PROFILE environment variable. If present, it adds a env to the kubeconfig dictionary for the user's exec.\r\n\r\nCurrent questions:\r\n* Should there be a flag that either turns on this feature, or disables it at the command line?\r\n* Do we only want this to be set if the user actually set --profile at the command line, but not if it's coming from AWS_PROFILE? (In such case, this can be rewritten to read from parsed_globals.profile instead).\r\n* Should this be done in a more general way by allowing the user to set arbitrary environment variables, instead of special casing for profile?>"},"comment":{"url":"https://api.github.com/repos/aws/aws-cli/issues/comments/436768187","html_url":"https://github.com/aws/aws-cli/pull/3683#issuecomment-436768187","issue_url":"https://api.github.com/repos/aws/aws-cli/issues/3683","id":436768187,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjc2ODE4Nw==","user":{"login":"mbarrien","id":1753192,"node_id":"MDQ6VXNlcjE3NTMxOTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1753192?v=4","gravatar_id":"","url":"https://api.github.com/users/mbarrien","html_url":"https://github.com/mbarrien","followers_url":"https://api.github.com/users/mbarrien/followers","following_url":"https://api.github.com/users/mbarrien/following{/other_user}","gists_url":"https://api.github.com/users/mbarrien/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarrien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarrien/subscriptions","organizations_url":"https://api.github.com/users/mbarrien/orgs","repos_url":"https://api.github.com/users/mbarrien/repos","events_url":"https://api.github.com/users/mbarrien/events{/privacy}","received_events_url":"https://api.github.com/users/mbarrien/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T20:35:56Z","updated_at":"2018-11-07T20:35:56Z","author_association":"NONE","body":"How do I get attention on this PR? Pinging @stealthycoin who recently worked in this area of code."}}
{"actor":{"display_login":"mbarrien"}}