{"action":"created","issue":{"url":"https://api.github.com/repos/fabric8-launcher/launcher-frontend/issues/339","repository_url":"https://api.github.com/repos/fabric8-launcher/launcher-frontend","labels_url":"https://api.github.com/repos/fabric8-launcher/launcher-frontend/issues/339/labels{/name}","comments_url":"https://api.github.com/repos/fabric8-launcher/launcher-frontend/issues/339/comments","events_url":"https://api.github.com/repos/fabric8-launcher/launcher-frontend/issues/339/events","html_url":"https://github.com/fabric8-launcher/launcher-frontend/issues/339","id":319941144,"number":339,"title":"Environment variables","user":{"login":"edewit","id":51133,"avatar_url":"https://avatars1.githubusercontent.com/u/51133?v=4","gravatar_id":"","url":"https://api.github.com/users/edewit","html_url":"https://github.com/edewit","followers_url":"https://api.github.com/users/edewit/followers","following_url":"https://api.github.com/users/edewit/following{/other_user}","gists_url":"https://api.github.com/users/edewit/gists{/gist_id}","starred_url":"https://api.github.com/users/edewit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edewit/subscriptions","organizations_url":"https://api.github.com/users/edewit/orgs","repos_url":"https://api.github.com/users/edewit/repos","events_url":"https://api.github.com/users/edewit/events{/privacy}","received_events_url":"https://api.github.com/users/edewit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-03T14:19:50Z","updated_at":"2018-05-03T14:40:45Z","closed_at":null,"author_association":"OWNER","body":"we have one build for prod and pre-prod, right now environment variables are \"inserted\" with `sed` into the settings.json file and index.hml. We need a better / more robust way of handling this. Maybe add perl to NGINX and serve the settings like that? "},"comment":{"url":"https://api.github.com/repos/fabric8-launcher/launcher-frontend/issues/comments/386318983","html_url":"https://github.com/fabric8-launcher/launcher-frontend/issues/339#issuecomment-386318983","issue_url":"https://api.github.com/repos/fabric8-launcher/launcher-frontend/issues/339","id":386318983,"user":{"login":"gastaldi","id":54133,"avatar_url":"https://avatars1.githubusercontent.com/u/54133?v=4","gravatar_id":"","url":"https://api.github.com/users/gastaldi","html_url":"https://github.com/gastaldi","followers_url":"https://api.github.com/users/gastaldi/followers","following_url":"https://api.github.com/users/gastaldi/following{/other_user}","gists_url":"https://api.github.com/users/gastaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/gastaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gastaldi/subscriptions","organizations_url":"https://api.github.com/users/gastaldi/orgs","repos_url":"https://api.github.com/users/gastaldi/repos","events_url":"https://api.github.com/users/gastaldi/events{/privacy}","received_events_url":"https://api.github.com/users/gastaldi/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T14:40:45Z","updated_at":"2018-05-03T14:40:45Z","author_association":"COLLABORATOR","body":"Useful links: \r\nhttps://hackerbox.io/articles/dockerised-nginx-env-vars/\r\nhttps://medium.com/comparethemarket/environment-configuration-with-react-nginx-2444e1f11a4c\r\n\r\n"}}
{"actor":{"display_login":"gastaldi"}}