{"action":"created","issue":{"url":"https://api.github.com/repos/fxcm/RestAPI/issues/12","repository_url":"https://api.github.com/repos/fxcm/RestAPI","labels_url":"https://api.github.com/repos/fxcm/RestAPI/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/fxcm/RestAPI/issues/12/comments","events_url":"https://api.github.com/repos/fxcm/RestAPI/issues/12/events","html_url":"https://github.com/fxcm/RestAPI/issues/12","id":394136136,"node_id":"MDU6SXNzdWUzOTQxMzYxMzY=","number":12,"title":"python thread clean exit","user":{"login":"prodipta","id":10256042,"node_id":"MDQ6VXNlcjEwMjU2MDQy","avatar_url":"https://avatars0.githubusercontent.com/u/10256042?v=4","gravatar_id":"","url":"https://api.github.com/users/prodipta","html_url":"https://github.com/prodipta","followers_url":"https://api.github.com/users/prodipta/followers","following_url":"https://api.github.com/users/prodipta/following{/other_user}","gists_url":"https://api.github.com/users/prodipta/gists{/gist_id}","starred_url":"https://api.github.com/users/prodipta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prodipta/subscriptions","organizations_url":"https://api.github.com/users/prodipta/orgs","repos_url":"https://api.github.com/users/prodipta/repos","events_url":"https://api.github.com/users/prodipta/events{/privacy}","received_events_url":"https://api.github.com/users/prodipta/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-26T10:22:21Z","updated_at":"2018-12-31T14:58:06Z","closed_at":"2018-12-31T14:58:06Z","author_association":"NONE","body":"Hi, the connection thread sometimes causes a problem if the main thread raises exceptions. Can we please set this thread as daemon to make sure the program exits gracefully if the main thread exits: at below \r\n[here](https://github.com/fxcm/RestAPI/blob/master/fxcmpy/fxcmpy/fxcmpy.py#L279) add: \r\n\r\n`self.socket_thread.daemon = True` \r\n\r\nOr let me know if you suggest some other workaround if this is not feasible. Thx vm."},"comment":{"url":"https://api.github.com/repos/fxcm/RestAPI/issues/comments/450654948","html_url":"https://github.com/fxcm/RestAPI/issues/12#issuecomment-450654948","issue_url":"https://api.github.com/repos/fxcm/RestAPI/issues/12","id":450654948,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDY1NDk0OA==","user":{"login":"FXCMAPI","id":13039151,"node_id":"MDQ6VXNlcjEzMDM5MTUx","avatar_url":"https://avatars3.githubusercontent.com/u/13039151?v=4","gravatar_id":"","url":"https://api.github.com/users/FXCMAPI","html_url":"https://github.com/FXCMAPI","followers_url":"https://api.github.com/users/FXCMAPI/followers","following_url":"https://api.github.com/users/FXCMAPI/following{/other_user}","gists_url":"https://api.github.com/users/FXCMAPI/gists{/gist_id}","starred_url":"https://api.github.com/users/FXCMAPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FXCMAPI/subscriptions","organizations_url":"https://api.github.com/users/FXCMAPI/orgs","repos_url":"https://api.github.com/users/FXCMAPI/repos","events_url":"https://api.github.com/users/FXCMAPI/events{/privacy}","received_events_url":"https://api.github.com/users/FXCMAPI/received_events","type":"User","site_admin":false},"created_at":"2018-12-31T14:58:06Z","updated_at":"2018-12-31T14:58:06Z","author_association":"COLLABORATOR","body":"Hello Prodipta\r\n\r\nthank you for your suggestion, \r\nwe are looking into it, will update you the progress. \r\n\r\nBest regards\r\nLei \r\n"}}
{"actor":{"display_login":"FXCMAPI"}}