{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/241905061","pull_request_review_id":185302411,"id":241905061,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTkwNTA2MQ==","diff_hunk":"@@ -1,10 +1,9 @@\n-/* Note that this is a sample function for the purpose of running the below CustomFunctionsMappings test. */\n-function addTen(n: number) {\n+/* Note that this is a sample function for the purpose of running the below CustomFunctions.Associate() test */\n+function add10(n: number) {\n     return n + 10;\n }\n \n-/* Assume that the function id for addTen in the function's JSON metadata is specified as ADDTEN. */\n-CustomFunctionMappings.ADDTEN = addTen;\n+CustomFunctions.Associate('ADD10', add10);","path":"types/custom-functions-runtime/custom-functions-runtime-tests.ts","position":10,"original_position":10,"commit_id":"fbae72d0427efe81144c34a1c615482ca90d618b","original_commit_id":"fbae72d0427efe81144c34a1c615482ca90d618b","user":{"login":"shaofengzhu","id":8461388,"node_id":"MDQ6VXNlcjg0NjEzODg=","avatar_url":"https://avatars1.githubusercontent.com/u/8461388?v=4","gravatar_id":"","url":"https://api.github.com/users/shaofengzhu","html_url":"https://github.com/shaofengzhu","followers_url":"https://api.github.com/users/shaofengzhu/followers","following_url":"https://api.github.com/users/shaofengzhu/following{/other_user}","gists_url":"https://api.github.com/users/shaofengzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/shaofengzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaofengzhu/subscriptions","organizations_url":"https://api.github.com/users/shaofengzhu/orgs","repos_url":"https://api.github.com/users/shaofengzhu/repos","events_url":"https://api.github.com/users/shaofengzhu/events{/privacy}","received_events_url":"https://api.github.com/users/shaofengzhu/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nCustomFunctions.associate('ADD10', add10);\r\n```","created_at":"2018-12-14T22:07:25Z","updated_at":"2018-12-14T22:09:20Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31346#discussion_r241905061","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31346","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/241905061"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31346#discussion_r241905061"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31346"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31346","id":238233522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjMzNTIy","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31346","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31346.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31346.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/31346","number":31346,"state":"open","locked":false,"title":"Update to custom-functions-runtime, eliminates CustomFunctions.Mapping() and adds CustomFunctions.Associate()","user":{"login":"mscharlock","id":26179395,"node_id":"MDQ6VXNlcjI2MTc5Mzk1","avatar_url":"https://avatars1.githubusercontent.com/u/26179395?v=4","gravatar_id":"","url":"https://api.github.com/users/mscharlock","html_url":"https://github.com/mscharlock","followers_url":"https://api.github.com/users/mscharlock/followers","following_url":"https://api.github.com/users/mscharlock/following{/other_user}","gists_url":"https://api.github.com/users/mscharlock/gists{/gist_id}","starred_url":"https://api.github.com/users/mscharlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscharlock/subscriptions","organizations_url":"https://api.github.com/users/mscharlock/orgs","repos_url":"https://api.github.com/users/mscharlock/repos","events_url":"https://api.github.com/users/mscharlock/events{/privacy}","received_events_url":"https://api.github.com/users/mscharlock/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: I don't have a URL, I work directly with the engineers who make this \r\n- [x] Increase the version number in the header if appropriate.\r\n- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.","created_at":"2018-12-13T01:04:22Z","updated_at":"2018-12-14T22:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28d6d20c69971353665e0ad24de5ee641619d08c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":798737478,"node_id":"MDU6TGFiZWw3OTg3Mzc0Nzg=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Author%20is%20Owner","name":"Author is Owner","color":"6fede0","default":false},{"id":397523192,"node_id":"MDU6TGFiZWwzOTc1MjMxOTI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":644095236,"node_id":"MDU6TGFiZWw2NDQwOTUyMzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Merge:Express","name":"Merge:Express","color":"00AA00","default":false},{"id":1160801752,"node_id":"MDU6TGFiZWwxMTYwODAxNzUy","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/requires%20external%20approval","name":"requires external approval","color":"d12e95","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31346/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31346/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/31346/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/fbae72d0427efe81144c34a1c615482ca90d618b","head":{"label":"mscharlock:michelle-custfuncassociate","ref":"michelle-custfuncassociate","sha":"fbae72d0427efe81144c34a1c615482ca90d618b","user":{"login":"mscharlock","id":26179395,"node_id":"MDQ6VXNlcjI2MTc5Mzk1","avatar_url":"https://avatars1.githubusercontent.com/u/26179395?v=4","gravatar_id":"","url":"https://api.github.com/users/mscharlock","html_url":"https://github.com/mscharlock","followers_url":"https://api.github.com/users/mscharlock/followers","following_url":"https://api.github.com/users/mscharlock/following{/other_user}","gists_url":"https://api.github.com/users/mscharlock/gists{/gist_id}","starred_url":"https://api.github.com/users/mscharlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscharlock/subscriptions","organizations_url":"https://api.github.com/users/mscharlock/orgs","repos_url":"https://api.github.com/users/mscharlock/repos","events_url":"https://api.github.com/users/mscharlock/events{/privacy}","received_events_url":"https://api.github.com/users/mscharlock/received_events","type":"User","site_admin":false},"repo":{"id":148819411,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg4MTk0MTE=","name":"DefinitelyTyped","full_name":"mscharlock/DefinitelyTyped","private":false,"owner":{"login":"mscharlock","id":26179395,"node_id":"MDQ6VXNlcjI2MTc5Mzk1","avatar_url":"https://avatars1.githubusercontent.com/u/26179395?v=4","gravatar_id":"","url":"https://api.github.com/users/mscharlock","html_url":"https://github.com/mscharlock","followers_url":"https://api.github.com/users/mscharlock/followers","following_url":"https://api.github.com/users/mscharlock/following{/other_user}","gists_url":"https://api.github.com/users/mscharlock/gists{/gist_id}","starred_url":"https://api.github.com/users/mscharlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscharlock/subscriptions","organizations_url":"https://api.github.com/users/mscharlock/orgs","repos_url":"https://api.github.com/users/mscharlock/repos","events_url":"https://api.github.com/users/mscharlock/events{/privacy}","received_events_url":"https://api.github.com/users/mscharlock/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mscharlock/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/mscharlock/DefinitelyTyped","forks_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/mscharlock/DefinitelyTyped/deployments","created_at":"2018-09-14T17:12:52Z","updated_at":"2018-09-27T22:29:50Z","pushed_at":"2018-12-13T01:19:21Z","git_url":"git://github.com/mscharlock/DefinitelyTyped.git","ssh_url":"git@github.com:mscharlock/DefinitelyTyped.git","clone_url":"https://github.com/mscharlock/DefinitelyTyped.git","svn_url":"https://github.com/mscharlock/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":387622,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"1f639cd8d8cf01026a32257835ca3f8e0043107e","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-12-14T19:59:49Z","pushed_at":"2018-12-14T22:06:29Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":388716,"stargazers_count":19086,"watchers_count":19086,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15763,"mirror_url":null,"archived":false,"open_issues_count":2663,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15763,"open_issues":2663,"watchers":19086,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31346"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31346"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/31346"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/31346/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31346/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31346/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/fbae72d0427efe81144c34a1c615482ca90d618b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shaofengzhu"}}