{"push_id":2424790750,"size":2,"distinct_size":2,"ref":"refs/heads/validate-handle-inheritance-fix","head":"f86ba39883502a00bbb802ac9c731b7c743aad55","before":"96c63f479dd5c593831201cb3f41a800dccc8933","commits":[{"sha":"520d069bc88fbff3b817efb241f026f09071ce3e","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Spawn nodes without handle inheritance on Win/Core\n\nOn Windows, processes by default inherit standard stream handles from\ntheir parent process. This can cause a process that is waiting on\ntermination of a given process to wait on its children as well while\nwaiting for the streams to close.\n\nWe want our worker nodes (when launched with `/nodeReuse:true`) to\nentirely disconnect from their parent and live past its lifetime. On\nWindows, that means we need to avoid inheriting handles.\n\nWe had code to p/invoke `CreateProcess` instead of using\n`Process.Start`, but it was #ifdef'ed to full framework only. Changing\nthat to be a runtime check for `IsWindows`.","distinct":true,"url":"https://api.github.com/repos/rainersigwald/msbuild/commits/520d069bc88fbff3b817efb241f026f09071ce3e"},{"sha":"f86ba39883502a00bbb802ac9c731b7c743aad55","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Inherit handles on Windows\n\nThe stdout/stdin/stderr handles are manually disconnected, but handles\nfor IPC must be inherited or the child node can't connect to its parent.","distinct":true,"url":"https://api.github.com/repos/rainersigwald/msbuild/commits/f86ba39883502a00bbb802ac9c731b7c743aad55"}]}
{"actor":{"display_login":"rainersigwald"}}