{"action":"closed","issue":{"url":"https://api.github.com/repos/OpenLiberty/draft-guide-microprofile-jwt/issues/23","repository_url":"https://api.github.com/repos/OpenLiberty/draft-guide-microprofile-jwt","labels_url":"https://api.github.com/repos/OpenLiberty/draft-guide-microprofile-jwt/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/OpenLiberty/draft-guide-microprofile-jwt/issues/23/comments","events_url":"https://api.github.com/repos/OpenLiberty/draft-guide-microprofile-jwt/issues/23/events","html_url":"https://github.com/OpenLiberty/draft-guide-microprofile-jwt/issues/23","id":303160887,"number":23,"title":"SME Review from Chunlong","user":{"login":"JunyiSun","id":12009928,"avatar_url":"https://avatars0.githubusercontent.com/u/12009928?v=4","gravatar_id":"","url":"https://api.github.com/users/JunyiSun","html_url":"https://github.com/JunyiSun","followers_url":"https://api.github.com/users/JunyiSun/followers","following_url":"https://api.github.com/users/JunyiSun/following{/other_user}","gists_url":"https://api.github.com/users/JunyiSun/gists{/gist_id}","starred_url":"https://api.github.com/users/JunyiSun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JunyiSun/subscriptions","organizations_url":"https://api.github.com/users/JunyiSun/orgs","repos_url":"https://api.github.com/users/JunyiSun/repos","events_url":"https://api.github.com/users/JunyiSun/events{/privacy}","received_events_url":"https://api.github.com/users/JunyiSun/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-07T16:12:13Z","updated_at":"2018-03-08T21:35:53Z","closed_at":"2018-03-08T21:35:53Z","author_association":"MEMBER","body":"- [x] draft-guide-microprofile-jwt/finish/backendServices/src/main/java/io/openliberty/guides/inventory/InventoryResource.java \r\nYou have a comment \"@DeclareRoles({\"admin\", \"user\"}) // important to have here, otherwise test will fail \". \r\nCan you verify this again? This issue is supposed to be fixed in 17.0.0.4.\r\n\r\n- [x] https://qa-guides.mybluemix.net/guides/microprofile-jwt.html\r\n\r\nA. \"keyName\"\r\nChange\r\n\"Specifies the JWT signature validation key, should match the key in the truststore in the SSL configuration\"\r\nTo\r\n\"Specify the key alias name to locate public key for JWT signature validation, must be in the truststore in the SSL configuration\"\r\n\r\nAnd from last time:\r\n\r\nSME Feedback:\r\n\r\nIt is a great article!\r\n\r\nI have reviewed the article, but I do not have chance to follow the lab yet (I will do it when I get time, and may provide more feedback).\r\n\r\n- [x] Backend: We do not need configure jwtBuilder for back end, and we could just use microProfile-1.2 instead of listing all required features. (We decided against doing this right?)\r\n(See attached file: server.xml)\r\n\r\n - [x] Front end: The LoginBean.java should consider create a json array for groups."}}
{"actor":{"display_login":"JunyiSun"}}