{"action":"created","comment":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/comments/201763798","pull_request_review_id":136328220,"id":201763798,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTc2Mzc5OA==","diff_hunk":"@@ -17,30 +17,59 @@ env:\n     #   See https://docs.travis-ci.com/api#external-apis.\n     - secure: \"qQ3vMSXUybUyKljJjgcVT9YaWcZ0PkdLZSFj6BVuo82SWO7e4L+hC8pqsa1Sm/EjyetVwfKk5lkvruPpro++8hDPLq3ahNOMmm4axfcWvACpW+acD/VCA5D8Dxz2ohrvpwsqo7BmIV6OUtIO5JeePHP1SqaIdVZFJ0pIAZToEWQ=\"\n     - CONDA_ROOT_PYTHON_VERSION: \"2.7\"\n-    - NUMPY_VERSION=1.11.1\n-    - PANDAS_VERSION=0.18.1\n-    - SCIPY_VERSION=0.17.1\n+  matrix:\n+    - PANDAS_18=1","path":".travis.yml","position":8,"original_position":8,"commit_id":"d6e3d135b04964cd51bc1d994705ec94c1a06711","original_commit_id":"d6e3d135b04964cd51bc1d994705ec94c1a06711","user":{"login":"ssanderson","id":1588357,"node_id":"MDQ6VXNlcjE1ODgzNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1588357?v=4","gravatar_id":"","url":"https://api.github.com/users/ssanderson","html_url":"https://github.com/ssanderson","followers_url":"https://api.github.com/users/ssanderson/followers","following_url":"https://api.github.com/users/ssanderson/following{/other_user}","gists_url":"https://api.github.com/users/ssanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/ssanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssanderson/subscriptions","organizations_url":"https://api.github.com/users/ssanderson/orgs","repos_url":"https://api.github.com/users/ssanderson/repos","events_url":"https://api.github.com/users/ssanderson/events{/privacy}","received_events_url":"https://api.github.com/users/ssanderson/received_events","type":"User","site_admin":false},"body":"> Will there be transition periods where we support three versions briefly, or do you think the cut-overs will cleanly update the NEW version?\r\n\r\nI don't think it's going to be feasible for us to realistically support more than two build configurations given the resources we currently have. I think the most likely model for transitions will be that we'll either update `OLD_PANDAS` to match `NEW_PANDAS`, in which case they'll be the same for a bit (and maybe we comment out the `NEW_PANDAS` builds temporarily) or we update `OLD_PANDAS` to some newer version that's still not as new as the newest (e.g., if we want to bump the version on Quantopian but can't upgrade all the way to the latest for some reason).\r\n\r\n> When I go to the travis build matrix, I actually find it useful to know what versions are being tested, without having to click through to see that NEW=0.22.\r\n\r\nI feel like we update pandas versions infrequently enough that it's not too hard to keep track of the OLD/NEW versions.\r\n\r\nOverall, my instinct is that making it easier to just increase the `NEW_PANDAS` version will make it more likely that we actually keep the new version up to date, and that seems more valuable to me than the points you raised. I don't have a super strong opinion about this though.","created_at":"2018-07-11T16:43:40Z","updated_at":"2018-07-11T16:43:41Z","html_url":"https://github.com/quantopian/zipline/pull/2244#discussion_r201763798","pull_request_url":"https://api.github.com/repos/quantopian/zipline/pulls/2244","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments/201763798"},"html":{"href":"https://github.com/quantopian/zipline/pull/2244#discussion_r201763798"},"pull_request":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2244"}},"in_reply_to_id":201722470},"pull_request":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/2244","id":200727669,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzI3NjY5","html_url":"https://github.com/quantopian/zipline/pull/2244","diff_url":"https://github.com/quantopian/zipline/pull/2244.diff","patch_url":"https://github.com/quantopian/zipline/pull/2244.patch","issue_url":"https://api.github.com/repos/quantopian/zipline/issues/2244","number":2244,"state":"open","locked":false,"title":"OSX CI on Travis","user":{"login":"richafrank","id":2123660,"node_id":"MDQ6VXNlcjIxMjM2NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2123660?v=4","gravatar_id":"","url":"https://api.github.com/users/richafrank","html_url":"https://github.com/richafrank","followers_url":"https://api.github.com/users/richafrank/followers","following_url":"https://api.github.com/users/richafrank/following{/other_user}","gists_url":"https://api.github.com/users/richafrank/gists{/gist_id}","starred_url":"https://api.github.com/users/richafrank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richafrank/subscriptions","organizations_url":"https://api.github.com/users/richafrank/orgs","repos_url":"https://api.github.com/users/richafrank/repos","events_url":"https://api.github.com/users/richafrank/events{/privacy}","received_events_url":"https://api.github.com/users/richafrank/received_events","type":"User","site_admin":false},"body":"OSX testing and packages","created_at":"2018-07-11T14:51:05Z","updated_at":"2018-07-11T16:43:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3a416a8772166b13c629a869dbb1386eeb1ef46","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/quantopian/zipline/pulls/2244/commits","review_comments_url":"https://api.github.com/repos/quantopian/zipline/pulls/2244/comments","review_comment_url":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quantopian/zipline/issues/2244/comments","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/d6e3d135b04964cd51bc1d994705ec94c1a06711","head":{"label":"quantopian:and-osx","ref":"and-osx","sha":"d6e3d135b04964cd51bc1d994705ec94c1a06711","user":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjk3NTIw","name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2018-07-11T15:28:55Z","pushed_at":"2018-07-11T15:36:12Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"http://www.zipline.io/","size":153745,"stargazers_count":7298,"watchers_count":7298,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2316,"mirror_url":null,"archived":false,"open_issues_count":238,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2316,"open_issues":238,"watchers":7298,"default_branch":"master"}},"base":{"label":"quantopian:master","ref":"master","sha":"c8a5e52e46d76b1cc51d5dfc5d24a3afa8432140","user":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjk3NTIw","name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2018-07-11T15:28:55Z","pushed_at":"2018-07-11T15:36:12Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"http://www.zipline.io/","size":153745,"stargazers_count":7298,"watchers_count":7298,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2316,"mirror_url":null,"archived":false,"open_issues_count":238,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2316,"open_issues":238,"watchers":7298,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2244"},"html":{"href":"https://github.com/quantopian/zipline/pull/2244"},"issue":{"href":"https://api.github.com/repos/quantopian/zipline/issues/2244"},"comments":{"href":"https://api.github.com/repos/quantopian/zipline/issues/2244/comments"},"review_comments":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2244/comments"},"review_comment":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2244/commits"},"statuses":{"href":"https://api.github.com/repos/quantopian/zipline/statuses/d6e3d135b04964cd51bc1d994705ec94c1a06711"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ssanderson"}}