{"action":"created","comment":{"url":"https://api.github.com/repos/primer/octicons/pulls/comments/199241841","pull_request_review_id":133329116,"id":199241841,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTI0MTg0MQ==","diff_hunk":"@@ -0,0 +1 @@\n+8","path":"lib/octicons_react/.nvmrc","position":1,"original_position":1,"commit_id":"b61e03c0ff17843adfe0a1defb5333f32b5693e4","original_commit_id":"b61e03c0ff17843adfe0a1defb5333f32b5693e4","user":{"login":"shawnbot","id":113896,"node_id":"MDQ6VXNlcjExMzg5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/113896?v=4","gravatar_id":"","url":"https://api.github.com/users/shawnbot","html_url":"https://github.com/shawnbot","followers_url":"https://api.github.com/users/shawnbot/followers","following_url":"https://api.github.com/users/shawnbot/following{/other_user}","gists_url":"https://api.github.com/users/shawnbot/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnbot/subscriptions","organizations_url":"https://api.github.com/users/shawnbot/orgs","repos_url":"https://api.github.com/users/shawnbot/repos","events_url":"https://api.github.com/users/shawnbot/events{/privacy}","received_events_url":"https://api.github.com/users/shawnbot/received_events","type":"User","site_admin":true},"body":"This is for development. I've added the equivalent to `engines.node` in the `package.json` as well.","created_at":"2018-06-29T18:17:51Z","updated_at":"2018-06-29T18:17:52Z","html_url":"https://github.com/primer/octicons/pull/222#discussion_r199241841","pull_request_url":"https://api.github.com/repos/primer/octicons/pulls/222","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/primer/octicons/pulls/comments/199241841"},"html":{"href":"https://github.com/primer/octicons/pull/222#discussion_r199241841"},"pull_request":{"href":"https://api.github.com/repos/primer/octicons/pulls/222"}}},"pull_request":{"url":"https://api.github.com/repos/primer/octicons/pulls/222","id":193697684,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjk3Njg0","html_url":"https://github.com/primer/octicons/pull/222","diff_url":"https://github.com/primer/octicons/pull/222.diff","patch_url":"https://github.com/primer/octicons/pull/222.patch","issue_url":"https://api.github.com/repos/primer/octicons/issues/222","number":222,"state":"open","locked":false,"title":"[WIP] React Octicons!","user":{"login":"shawnbot","id":113896,"node_id":"MDQ6VXNlcjExMzg5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/113896?v=4","gravatar_id":"","url":"https://api.github.com/users/shawnbot","html_url":"https://github.com/shawnbot","followers_url":"https://api.github.com/users/shawnbot/followers","following_url":"https://api.github.com/users/shawnbot/following{/other_user}","gists_url":"https://api.github.com/users/shawnbot/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnbot/subscriptions","organizations_url":"https://api.github.com/users/shawnbot/orgs","repos_url":"https://api.github.com/users/shawnbot/repos","events_url":"https://api.github.com/users/shawnbot/events{/privacy}","received_events_url":"https://api.github.com/users/shawnbot/received_events","type":"User","site_admin":true},"body":"### TODO\r\n- [x] Add new tests for React Octicons\r\n- [x] Get tests passing\r\n- [x] Update `README.md` with new API (see [rendered](https://github.com/primer/octicons/tree/reocticons/lib/octicons_react/README.md))\r\n\r\nThis is a rehash of #196 that looks at what it would be like to have a React component API along the lines of:\r\n\r\n```jsx\r\nimport Octicon, {Zap} from 'react-octicons'\r\n\r\nexport default () => <Octicon><Zap /></Octicon>\r\n// or\r\nexport default () => <Octicon icon={Zap} />\r\n```\r\n\r\nWith credit to @hiendv for the inspiration in  https://github.com/primer/octicons/pull/196#issuecomment-377674252 :beers:\r\n\r\nNote that there's one wild assumption in the generated per-icon components here, and it's that the SVG from the `octicons` package is valid XML, which is what allows us to use it in JSX without munging it. I've checked the generated icon component JS into git so that we can look at it without the module having to publish.\r\n\r\n/cc @josh @keithamus for tree-shaking module bizness","created_at":"2018-06-08T19:01:43Z","updated_at":"2018-06-29T18:17:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45ba88e5485109b56e66159a122c8bae1f3ed657","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/primer/octicons/pulls/222/commits","review_comments_url":"https://api.github.com/repos/primer/octicons/pulls/222/comments","review_comment_url":"https://api.github.com/repos/primer/octicons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/primer/octicons/issues/222/comments","statuses_url":"https://api.github.com/repos/primer/octicons/statuses/b61e03c0ff17843adfe0a1defb5333f32b5693e4","head":{"label":"primer:reocticons","ref":"reocticons","sha":"b61e03c0ff17843adfe0a1defb5333f32b5693e4","user":{"login":"primer","id":7143434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNDM0MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7143434?v=4","gravatar_id":"","url":"https://api.github.com/users/primer","html_url":"https://github.com/primer","followers_url":"https://api.github.com/users/primer/followers","following_url":"https://api.github.com/users/primer/following{/other_user}","gists_url":"https://api.github.com/users/primer/gists{/gist_id}","starred_url":"https://api.github.com/users/primer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primer/subscriptions","organizations_url":"https://api.github.com/users/primer/orgs","repos_url":"https://api.github.com/users/primer/repos","events_url":"https://api.github.com/users/primer/events{/privacy}","received_events_url":"https://api.github.com/users/primer/received_events","type":"Organization","site_admin":false},"repo":{"id":20893207,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg5MzIwNw==","name":"octicons","full_name":"primer/octicons","owner":{"login":"primer","id":7143434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNDM0MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7143434?v=4","gravatar_id":"","url":"https://api.github.com/users/primer","html_url":"https://github.com/primer","followers_url":"https://api.github.com/users/primer/followers","following_url":"https://api.github.com/users/primer/following{/other_user}","gists_url":"https://api.github.com/users/primer/gists{/gist_id}","starred_url":"https://api.github.com/users/primer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primer/subscriptions","organizations_url":"https://api.github.com/users/primer/orgs","repos_url":"https://api.github.com/users/primer/repos","events_url":"https://api.github.com/users/primer/events{/privacy}","received_events_url":"https://api.github.com/users/primer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/primer/octicons","description":"A scalable set of icons handcrafted with <3 by GitHub","fork":false,"url":"https://api.github.com/repos/primer/octicons","forks_url":"https://api.github.com/repos/primer/octicons/forks","keys_url":"https://api.github.com/repos/primer/octicons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/primer/octicons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/primer/octicons/teams","hooks_url":"https://api.github.com/repos/primer/octicons/hooks","issue_events_url":"https://api.github.com/repos/primer/octicons/issues/events{/number}","events_url":"https://api.github.com/repos/primer/octicons/events","assignees_url":"https://api.github.com/repos/primer/octicons/assignees{/user}","branches_url":"https://api.github.com/repos/primer/octicons/branches{/branch}","tags_url":"https://api.github.com/repos/primer/octicons/tags","blobs_url":"https://api.github.com/repos/primer/octicons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/primer/octicons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/primer/octicons/git/refs{/sha}","trees_url":"https://api.github.com/repos/primer/octicons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/primer/octicons/statuses/{sha}","languages_url":"https://api.github.com/repos/primer/octicons/languages","stargazers_url":"https://api.github.com/repos/primer/octicons/stargazers","contributors_url":"https://api.github.com/repos/primer/octicons/contributors","subscribers_url":"https://api.github.com/repos/primer/octicons/subscribers","subscription_url":"https://api.github.com/repos/primer/octicons/subscription","commits_url":"https://api.github.com/repos/primer/octicons/commits{/sha}","git_commits_url":"https://api.github.com/repos/primer/octicons/git/commits{/sha}","comments_url":"https://api.github.com/repos/primer/octicons/comments{/number}","issue_comment_url":"https://api.github.com/repos/primer/octicons/issues/comments{/number}","contents_url":"https://api.github.com/repos/primer/octicons/contents/{+path}","compare_url":"https://api.github.com/repos/primer/octicons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/primer/octicons/merges","archive_url":"https://api.github.com/repos/primer/octicons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/primer/octicons/downloads","issues_url":"https://api.github.com/repos/primer/octicons/issues{/number}","pulls_url":"https://api.github.com/repos/primer/octicons/pulls{/number}","milestones_url":"https://api.github.com/repos/primer/octicons/milestones{/number}","notifications_url":"https://api.github.com/repos/primer/octicons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/primer/octicons/labels{/name}","releases_url":"https://api.github.com/repos/primer/octicons/releases{/id}","deployments_url":"https://api.github.com/repos/primer/octicons/deployments","created_at":"2014-06-16T17:10:25Z","updated_at":"2018-06-29T14:04:17Z","pushed_at":"2018-06-29T18:15:07Z","git_url":"git://github.com/primer/octicons.git","ssh_url":"git@github.com:primer/octicons.git","clone_url":"https://github.com/primer/octicons.git","svn_url":"https://github.com/primer/octicons","homepage":"https://octicons.github.com/","size":18639,"stargazers_count":4614,"watchers_count":4614,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":365,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":365,"open_issues":21,"watchers":4614,"default_branch":"master"}},"base":{"label":"primer:master","ref":"master","sha":"4adadb633d628745eacfcdac96982aaac95ea740","user":{"login":"primer","id":7143434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNDM0MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7143434?v=4","gravatar_id":"","url":"https://api.github.com/users/primer","html_url":"https://github.com/primer","followers_url":"https://api.github.com/users/primer/followers","following_url":"https://api.github.com/users/primer/following{/other_user}","gists_url":"https://api.github.com/users/primer/gists{/gist_id}","starred_url":"https://api.github.com/users/primer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primer/subscriptions","organizations_url":"https://api.github.com/users/primer/orgs","repos_url":"https://api.github.com/users/primer/repos","events_url":"https://api.github.com/users/primer/events{/privacy}","received_events_url":"https://api.github.com/users/primer/received_events","type":"Organization","site_admin":false},"repo":{"id":20893207,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg5MzIwNw==","name":"octicons","full_name":"primer/octicons","owner":{"login":"primer","id":7143434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNDM0MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7143434?v=4","gravatar_id":"","url":"https://api.github.com/users/primer","html_url":"https://github.com/primer","followers_url":"https://api.github.com/users/primer/followers","following_url":"https://api.github.com/users/primer/following{/other_user}","gists_url":"https://api.github.com/users/primer/gists{/gist_id}","starred_url":"https://api.github.com/users/primer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primer/subscriptions","organizations_url":"https://api.github.com/users/primer/orgs","repos_url":"https://api.github.com/users/primer/repos","events_url":"https://api.github.com/users/primer/events{/privacy}","received_events_url":"https://api.github.com/users/primer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/primer/octicons","description":"A scalable set of icons handcrafted with <3 by GitHub","fork":false,"url":"https://api.github.com/repos/primer/octicons","forks_url":"https://api.github.com/repos/primer/octicons/forks","keys_url":"https://api.github.com/repos/primer/octicons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/primer/octicons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/primer/octicons/teams","hooks_url":"https://api.github.com/repos/primer/octicons/hooks","issue_events_url":"https://api.github.com/repos/primer/octicons/issues/events{/number}","events_url":"https://api.github.com/repos/primer/octicons/events","assignees_url":"https://api.github.com/repos/primer/octicons/assignees{/user}","branches_url":"https://api.github.com/repos/primer/octicons/branches{/branch}","tags_url":"https://api.github.com/repos/primer/octicons/tags","blobs_url":"https://api.github.com/repos/primer/octicons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/primer/octicons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/primer/octicons/git/refs{/sha}","trees_url":"https://api.github.com/repos/primer/octicons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/primer/octicons/statuses/{sha}","languages_url":"https://api.github.com/repos/primer/octicons/languages","stargazers_url":"https://api.github.com/repos/primer/octicons/stargazers","contributors_url":"https://api.github.com/repos/primer/octicons/contributors","subscribers_url":"https://api.github.com/repos/primer/octicons/subscribers","subscription_url":"https://api.github.com/repos/primer/octicons/subscription","commits_url":"https://api.github.com/repos/primer/octicons/commits{/sha}","git_commits_url":"https://api.github.com/repos/primer/octicons/git/commits{/sha}","comments_url":"https://api.github.com/repos/primer/octicons/comments{/number}","issue_comment_url":"https://api.github.com/repos/primer/octicons/issues/comments{/number}","contents_url":"https://api.github.com/repos/primer/octicons/contents/{+path}","compare_url":"https://api.github.com/repos/primer/octicons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/primer/octicons/merges","archive_url":"https://api.github.com/repos/primer/octicons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/primer/octicons/downloads","issues_url":"https://api.github.com/repos/primer/octicons/issues{/number}","pulls_url":"https://api.github.com/repos/primer/octicons/pulls{/number}","milestones_url":"https://api.github.com/repos/primer/octicons/milestones{/number}","notifications_url":"https://api.github.com/repos/primer/octicons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/primer/octicons/labels{/name}","releases_url":"https://api.github.com/repos/primer/octicons/releases{/id}","deployments_url":"https://api.github.com/repos/primer/octicons/deployments","created_at":"2014-06-16T17:10:25Z","updated_at":"2018-06-29T14:04:17Z","pushed_at":"2018-06-29T18:15:07Z","git_url":"git://github.com/primer/octicons.git","ssh_url":"git@github.com:primer/octicons.git","clone_url":"https://github.com/primer/octicons.git","svn_url":"https://github.com/primer/octicons","homepage":"https://octicons.github.com/","size":18639,"stargazers_count":4614,"watchers_count":4614,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":365,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":365,"open_issues":21,"watchers":4614,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/primer/octicons/pulls/222"},"html":{"href":"https://github.com/primer/octicons/pull/222"},"issue":{"href":"https://api.github.com/repos/primer/octicons/issues/222"},"comments":{"href":"https://api.github.com/repos/primer/octicons/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/primer/octicons/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/primer/octicons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/primer/octicons/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/primer/octicons/statuses/b61e03c0ff17843adfe0a1defb5333f32b5693e4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"shawnbot"}}