{"action":"created","comment":{"url":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/comments/242650281","pull_request_review_id":186212443,"id":242650281,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjY1MDI4MQ==","diff_hunk":"@@ -28,23 +28,23 @@ def test_grid_grid(self):\n         self.assertIsInstance(grid_covar, KroneckerProductLazyTensor)\n         grid_eval = kernel(grid_data, grid_data).evaluate()\n         actual_eval = base_kernel(grid_data, grid_data).evaluate()\n-        self.assertLess(torch.norm(grid_eval - actual_eval), 1e-5)\n+        self.assertLess(torch.norm(grid_eval - actual_eval), 2e-5)\n \n     def test_nongrid_grid(self):\n         base_kernel = RBFKernel()\n         data = torch.randn(5, 2)\n         kernel = GridKernel(base_kernel, grid)\n         grid_eval = kernel(grid_data, data).evaluate()\n         actual_eval = base_kernel(grid_data, data).evaluate()\n-        self.assertLess(torch.norm(grid_eval - actual_eval), 1e-5)\n+        self.assertLess(torch.norm(grid_eval - actual_eval), 2e-5)\n \n     def test_nongrid_nongrid(self):\n         base_kernel = RBFKernel()\n         data = torch.randn(5, 2)\n         kernel = GridKernel(base_kernel, grid)\n         grid_eval = kernel(data, data).evaluate()\n         actual_eval = base_kernel(data, data).evaluate()\n-        self.assertLess(torch.norm(grid_eval - actual_eval), 1e-5)\n+        self.assertLess(torch.norm(grid_eval - actual_eval), 2e-5)","path":"test/kernels/test_grid_kernel.py","position":23,"original_position":23,"commit_id":"ed40be9f34cfbfa4c3ee0f6864a18f5fa4f733f8","original_commit_id":"ed40be9f34cfbfa4c3ee0f6864a18f5fa4f733f8","user":{"login":"gpleiss","id":824157,"node_id":"MDQ6VXNlcjgyNDE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/824157?v=4","gravatar_id":"","url":"https://api.github.com/users/gpleiss","html_url":"https://github.com/gpleiss","followers_url":"https://api.github.com/users/gpleiss/followers","following_url":"https://api.github.com/users/gpleiss/following{/other_user}","gists_url":"https://api.github.com/users/gpleiss/gists{/gist_id}","starred_url":"https://api.github.com/users/gpleiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpleiss/subscriptions","organizations_url":"https://api.github.com/users/gpleiss/orgs","repos_url":"https://api.github.com/users/gpleiss/repos","events_url":"https://api.github.com/users/gpleiss/events{/privacy}","received_events_url":"https://api.github.com/users/gpleiss/received_events","type":"User","site_admin":false},"body":"I think the reason you have to increase these error bounds is because of the way we're computing the kernel.","created_at":"2018-12-18T18:22:47Z","updated_at":"2018-12-18T18:35:37Z","html_url":"https://github.com/cornellius-gp/gpytorch/pull/434#discussion_r242650281","pull_request_url":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/434","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/comments/242650281"},"html":{"href":"https://github.com/cornellius-gp/gpytorch/pull/434#discussion_r242650281"},"pull_request":{"href":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/434"}}},"pull_request":{"url":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/434","id":239207036,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjA3MDM2","html_url":"https://github.com/cornellius-gp/gpytorch/pull/434","diff_url":"https://github.com/cornellius-gp/gpytorch/pull/434.diff","patch_url":"https://github.com/cornellius-gp/gpytorch/pull/434.patch","issue_url":"https://api.github.com/repos/cornellius-gp/gpytorch/issues/434","number":434,"state":"open","locked":false,"title":"Fix kernel memory usage","user":{"login":"jacobrgardner","id":4016393,"node_id":"MDQ6VXNlcjQwMTYzOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/4016393?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobrgardner","html_url":"https://github.com/jacobrgardner","followers_url":"https://api.github.com/users/jacobrgardner/followers","following_url":"https://api.github.com/users/jacobrgardner/following{/other_user}","gists_url":"https://api.github.com/users/jacobrgardner/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobrgardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobrgardner/subscriptions","organizations_url":"https://api.github.com/users/jacobrgardner/orgs","repos_url":"https://api.github.com/users/jacobrgardner/repos","events_url":"https://api.github.com/users/jacobrgardner/events{/privacy}","received_events_url":"https://api.github.com/users/jacobrgardner/received_events","type":"User","site_admin":false},"body":"We were trying to be too clean with recent changes to kernel computations for our own good with using `create_input_grid`, and ended up using `O(dn^2)` memory accidentally. This makes our kernels correctly use `O(n^2)` memory (for exact GPs).\r\n\r\nAn example of the difference this makes is that exact GPs can be run on the `elevators` dataset after the fix but not before it.","created_at":"2018-12-17T16:31:46Z","updated_at":"2018-12-18T18:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daf5ea4678e944374ed77daa4ad20e9cefc35518","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/434/commits","review_comments_url":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/434/comments","review_comment_url":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cornellius-gp/gpytorch/issues/434/comments","statuses_url":"https://api.github.com/repos/cornellius-gp/gpytorch/statuses/ed40be9f34cfbfa4c3ee0f6864a18f5fa4f733f8","head":{"label":"cornellius-gp:kernel_mem_fix","ref":"kernel_mem_fix","sha":"ed40be9f34cfbfa4c3ee0f6864a18f5fa4f733f8","user":{"login":"cornellius-gp","id":36548216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTQ4MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/36548216?v=4","gravatar_id":"","url":"https://api.github.com/users/cornellius-gp","html_url":"https://github.com/cornellius-gp","followers_url":"https://api.github.com/users/cornellius-gp/followers","following_url":"https://api.github.com/users/cornellius-gp/following{/other_user}","gists_url":"https://api.github.com/users/cornellius-gp/gists{/gist_id}","starred_url":"https://api.github.com/users/cornellius-gp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornellius-gp/subscriptions","organizations_url":"https://api.github.com/users/cornellius-gp/orgs","repos_url":"https://api.github.com/users/cornellius-gp/repos","events_url":"https://api.github.com/users/cornellius-gp/events{/privacy}","received_events_url":"https://api.github.com/users/cornellius-gp/received_events","type":"Organization","site_admin":false},"repo":{"id":93868719,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg2ODcxOQ==","name":"gpytorch","full_name":"cornellius-gp/gpytorch","private":false,"owner":{"login":"cornellius-gp","id":36548216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTQ4MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/36548216?v=4","gravatar_id":"","url":"https://api.github.com/users/cornellius-gp","html_url":"https://github.com/cornellius-gp","followers_url":"https://api.github.com/users/cornellius-gp/followers","following_url":"https://api.github.com/users/cornellius-gp/following{/other_user}","gists_url":"https://api.github.com/users/cornellius-gp/gists{/gist_id}","starred_url":"https://api.github.com/users/cornellius-gp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornellius-gp/subscriptions","organizations_url":"https://api.github.com/users/cornellius-gp/orgs","repos_url":"https://api.github.com/users/cornellius-gp/repos","events_url":"https://api.github.com/users/cornellius-gp/events{/privacy}","received_events_url":"https://api.github.com/users/cornellius-gp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cornellius-gp/gpytorch","description":"A highly efficient and modular implementation of Gaussian Processes in PyTorch","fork":false,"url":"https://api.github.com/repos/cornellius-gp/gpytorch","forks_url":"https://api.github.com/repos/cornellius-gp/gpytorch/forks","keys_url":"https://api.github.com/repos/cornellius-gp/gpytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cornellius-gp/gpytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cornellius-gp/gpytorch/teams","hooks_url":"https://api.github.com/repos/cornellius-gp/gpytorch/hooks","issue_events_url":"https://api.github.com/repos/cornellius-gp/gpytorch/issues/events{/number}","events_url":"https://api.github.com/repos/cornellius-gp/gpytorch/events","assignees_url":"https://api.github.com/repos/cornellius-gp/gpytorch/assignees{/user}","branches_url":"https://api.github.com/repos/cornellius-gp/gpytorch/branches{/branch}","tags_url":"https://api.github.com/repos/cornellius-gp/gpytorch/tags","blobs_url":"https://api.github.com/repos/cornellius-gp/gpytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cornellius-gp/gpytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cornellius-gp/gpytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/cornellius-gp/gpytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cornellius-gp/gpytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/cornellius-gp/gpytorch/languages","stargazers_url":"https://api.github.com/repos/cornellius-gp/gpytorch/stargazers","contributors_url":"https://api.github.com/repos/cornellius-gp/gpytorch/contributors","subscribers_url":"https://api.github.com/repos/cornellius-gp/gpytorch/subscribers","subscription_url":"https://api.github.com/repos/cornellius-gp/gpytorch/subscription","commits_url":"https://api.github.com/repos/cornellius-gp/gpytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/cornellius-gp/gpytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/cornellius-gp/gpytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/cornellius-gp/gpytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/cornellius-gp/gpytorch/contents/{+path}","compare_url":"https://api.github.com/repos/cornellius-gp/gpytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cornellius-gp/gpytorch/merges","archive_url":"https://api.github.com/repos/cornellius-gp/gpytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cornellius-gp/gpytorch/downloads","issues_url":"https://api.github.com/repos/cornellius-gp/gpytorch/issues{/number}","pulls_url":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/cornellius-gp/gpytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/cornellius-gp/gpytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cornellius-gp/gpytorch/labels{/name}","releases_url":"https://api.github.com/repos/cornellius-gp/gpytorch/releases{/id}","deployments_url":"https://api.github.com/repos/cornellius-gp/gpytorch/deployments","created_at":"2017-06-09T14:48:20Z","updated_at":"2018-12-18T12:52:39Z","pushed_at":"2018-12-18T15:59:58Z","git_url":"git://github.com/cornellius-gp/gpytorch.git","ssh_url":"git@github.com:cornellius-gp/gpytorch.git","clone_url":"https://github.com/cornellius-gp/gpytorch.git","svn_url":"https://github.com/cornellius-gp/gpytorch","homepage":"","size":9173,"stargazers_count":970,"watchers_count":970,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":109,"open_issues":36,"watchers":970,"default_branch":"master"}},"base":{"label":"cornellius-gp:master","ref":"master","sha":"21b9b735bad29c7aab9509eef960be1315e266c4","user":{"login":"cornellius-gp","id":36548216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTQ4MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/36548216?v=4","gravatar_id":"","url":"https://api.github.com/users/cornellius-gp","html_url":"https://github.com/cornellius-gp","followers_url":"https://api.github.com/users/cornellius-gp/followers","following_url":"https://api.github.com/users/cornellius-gp/following{/other_user}","gists_url":"https://api.github.com/users/cornellius-gp/gists{/gist_id}","starred_url":"https://api.github.com/users/cornellius-gp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornellius-gp/subscriptions","organizations_url":"https://api.github.com/users/cornellius-gp/orgs","repos_url":"https://api.github.com/users/cornellius-gp/repos","events_url":"https://api.github.com/users/cornellius-gp/events{/privacy}","received_events_url":"https://api.github.com/users/cornellius-gp/received_events","type":"Organization","site_admin":false},"repo":{"id":93868719,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg2ODcxOQ==","name":"gpytorch","full_name":"cornellius-gp/gpytorch","private":false,"owner":{"login":"cornellius-gp","id":36548216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTQ4MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/36548216?v=4","gravatar_id":"","url":"https://api.github.com/users/cornellius-gp","html_url":"https://github.com/cornellius-gp","followers_url":"https://api.github.com/users/cornellius-gp/followers","following_url":"https://api.github.com/users/cornellius-gp/following{/other_user}","gists_url":"https://api.github.com/users/cornellius-gp/gists{/gist_id}","starred_url":"https://api.github.com/users/cornellius-gp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornellius-gp/subscriptions","organizations_url":"https://api.github.com/users/cornellius-gp/orgs","repos_url":"https://api.github.com/users/cornellius-gp/repos","events_url":"https://api.github.com/users/cornellius-gp/events{/privacy}","received_events_url":"https://api.github.com/users/cornellius-gp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cornellius-gp/gpytorch","description":"A highly efficient and modular implementation of Gaussian Processes in PyTorch","fork":false,"url":"https://api.github.com/repos/cornellius-gp/gpytorch","forks_url":"https://api.github.com/repos/cornellius-gp/gpytorch/forks","keys_url":"https://api.github.com/repos/cornellius-gp/gpytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cornellius-gp/gpytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cornellius-gp/gpytorch/teams","hooks_url":"https://api.github.com/repos/cornellius-gp/gpytorch/hooks","issue_events_url":"https://api.github.com/repos/cornellius-gp/gpytorch/issues/events{/number}","events_url":"https://api.github.com/repos/cornellius-gp/gpytorch/events","assignees_url":"https://api.github.com/repos/cornellius-gp/gpytorch/assignees{/user}","branches_url":"https://api.github.com/repos/cornellius-gp/gpytorch/branches{/branch}","tags_url":"https://api.github.com/repos/cornellius-gp/gpytorch/tags","blobs_url":"https://api.github.com/repos/cornellius-gp/gpytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cornellius-gp/gpytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cornellius-gp/gpytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/cornellius-gp/gpytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cornellius-gp/gpytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/cornellius-gp/gpytorch/languages","stargazers_url":"https://api.github.com/repos/cornellius-gp/gpytorch/stargazers","contributors_url":"https://api.github.com/repos/cornellius-gp/gpytorch/contributors","subscribers_url":"https://api.github.com/repos/cornellius-gp/gpytorch/subscribers","subscription_url":"https://api.github.com/repos/cornellius-gp/gpytorch/subscription","commits_url":"https://api.github.com/repos/cornellius-gp/gpytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/cornellius-gp/gpytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/cornellius-gp/gpytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/cornellius-gp/gpytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/cornellius-gp/gpytorch/contents/{+path}","compare_url":"https://api.github.com/repos/cornellius-gp/gpytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cornellius-gp/gpytorch/merges","archive_url":"https://api.github.com/repos/cornellius-gp/gpytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cornellius-gp/gpytorch/downloads","issues_url":"https://api.github.com/repos/cornellius-gp/gpytorch/issues{/number}","pulls_url":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/cornellius-gp/gpytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/cornellius-gp/gpytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cornellius-gp/gpytorch/labels{/name}","releases_url":"https://api.github.com/repos/cornellius-gp/gpytorch/releases{/id}","deployments_url":"https://api.github.com/repos/cornellius-gp/gpytorch/deployments","created_at":"2017-06-09T14:48:20Z","updated_at":"2018-12-18T12:52:39Z","pushed_at":"2018-12-18T15:59:58Z","git_url":"git://github.com/cornellius-gp/gpytorch.git","ssh_url":"git@github.com:cornellius-gp/gpytorch.git","clone_url":"https://github.com/cornellius-gp/gpytorch.git","svn_url":"https://github.com/cornellius-gp/gpytorch","homepage":"","size":9173,"stargazers_count":970,"watchers_count":970,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":109,"open_issues":36,"watchers":970,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/434"},"html":{"href":"https://github.com/cornellius-gp/gpytorch/pull/434"},"issue":{"href":"https://api.github.com/repos/cornellius-gp/gpytorch/issues/434"},"comments":{"href":"https://api.github.com/repos/cornellius-gp/gpytorch/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cornellius-gp/gpytorch/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/cornellius-gp/gpytorch/statuses/ed40be9f34cfbfa4c3ee0f6864a18f5fa4f733f8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gpleiss"}}