{"action":"created","issue":{"url":"https://api.github.com/repos/knative/serving/issues/2567","repository_url":"https://api.github.com/repos/knative/serving","labels_url":"https://api.github.com/repos/knative/serving/issues/2567/labels{/name}","comments_url":"https://api.github.com/repos/knative/serving/issues/2567/comments","events_url":"https://api.github.com/repos/knative/serving/issues/2567/events","html_url":"https://github.com/knative/serving/pull/2567","id":385142597,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MTc4OTUw","number":2567,"title":"Set terminationGrace of a pod according to the timeout of the revision.","user":{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},"labels":[{"id":859767870,"node_id":"MDU6TGFiZWw4NTk3Njc4NzA=","url":"https://api.github.com/repos/knative/serving/labels/size/M","name":"size/M","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-28T07:52:41Z","updated_at":"2018-11-28T07:52:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2567","html_url":"https://github.com/knative/serving/pull/2567","diff_url":"https://github.com/knative/serving/pull/2567.diff","patch_url":"https://github.com/knative/serving/pull/2567.patch"},"body":"<!--\r\nRequest Prow to automatically lint any go code in this PR:\r\n\r\n/lint\r\n-->\r\n\r\nFixes #1197\r\n\r\nAs per title. We should give a Pod as much time to shutdown as we give requests on it to complete. That ensures that no connections are dropped due to autoscaling, which may shutdown pods at any time.\r\n\r\n**Release Note**\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n```release-note\r\nLong-running operations are no longer dropped intermittently due to autoscaling.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/knative/serving/issues/comments/442352265","html_url":"https://github.com/knative/serving/pull/2567#issuecomment-442352265","issue_url":"https://api.github.com/repos/knative/serving/issues/2567","id":442352265,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjM1MjI2NQ==","user":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T07:52:49Z","updated_at":"2018-11-28T07:52:49Z","author_association":"NONE","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/knative/serving/pull/2567#\" title=\"Author self-approved\">markusthoemmes</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approvers: **ericklawitter**, **grantr**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @ericklawitter @grantr` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/reconciler/OWNERS](https://github.com/knative/serving/blob/master/pkg/reconciler/OWNERS)**\n- **[test/OWNERS](https://github.com/knative/serving/blob/master/test/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"ericklawitter\",\"grantr\"]} -->"}}
{"actor":{"display_login":"knative-prow-robot"}}