{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/comments/237652230","pull_request_review_id":180005919,"id":237652230,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzY1MjIzMA==","diff_hunk":"@@ -18,34 +18,20 @@ public override bool CanConvert(Type objectType)\n \n         public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)\n         {\n-            bool fValidString = true;\n             if (reader.TokenType == JsonToken.String)\n             {\n                 var colorString = defaultSerializer.Deserialize(reader, objectType) as string;\n-                // We need to have a string in the format #AARRGGBB or #RRGGBB\n-                if (!string.IsNullOrEmpty(colorString) && (colorString.Length == 7 || colorString.Length == 9) && colorString[0] == '#')\n+                // We need to have a string in the format #AARRGGBB or #RRGGBB               ","path":"source/dotnet/Library/AdaptiveCards/HashColorConverter.cs","position":10,"original_position":10,"commit_id":"8e24855eaa90a6cefeb0f772b7ee4e7f2f5be3a5","original_commit_id":"8e24855eaa90a6cefeb0f772b7ee4e7f2f5be3a5","user":{"login":"paulcam206","id":16614499,"node_id":"MDQ6VXNlcjE2NjE0NDk5","avatar_url":"https://avatars0.githubusercontent.com/u/16614499?v=4","gravatar_id":"","url":"https://api.github.com/users/paulcam206","html_url":"https://github.com/paulcam206","followers_url":"https://api.github.com/users/paulcam206/followers","following_url":"https://api.github.com/users/paulcam206/following{/other_user}","gists_url":"https://api.github.com/users/paulcam206/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcam206/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcam206/subscriptions","organizations_url":"https://api.github.com/users/paulcam206/orgs","repos_url":"https://api.github.com/users/paulcam206/repos","events_url":"https://api.github.com/users/paulcam206/events{/privacy}","received_events_url":"https://api.github.com/users/paulcam206/received_events","type":"User","site_admin":false},"body":">                [](start = 78, length = 15)\r\n\r\nplease configure your editor to use [editorconfig](https://editorconfig.org/)","created_at":"2018-11-29T20:46:29Z","updated_at":"2018-11-29T20:46:30Z","html_url":"https://github.com/Microsoft/AdaptiveCards/pull/2195#discussion_r237652230","pull_request_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/2195","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/comments/237652230"},"html":{"href":"https://github.com/Microsoft/AdaptiveCards/pull/2195#discussion_r237652230"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/2195"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/2195","id":234768425,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzY4NDI1","html_url":"https://github.com/Microsoft/AdaptiveCards/pull/2195","diff_url":"https://github.com/Microsoft/AdaptiveCards/pull/2195.diff","patch_url":"https://github.com/Microsoft/AdaptiveCards/pull/2195.patch","issue_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/2195","number":2195,"state":"open","locked":false,"title":"Add class to validate and parse colors","user":{"login":"almedina-ms","id":35784165,"node_id":"MDQ6VXNlcjM1Nzg0MTY1","avatar_url":"https://avatars0.githubusercontent.com/u/35784165?v=4","gravatar_id":"","url":"https://api.github.com/users/almedina-ms","html_url":"https://github.com/almedina-ms","followers_url":"https://api.github.com/users/almedina-ms/followers","following_url":"https://api.github.com/users/almedina-ms/following{/other_user}","gists_url":"https://api.github.com/users/almedina-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/almedina-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almedina-ms/subscriptions","organizations_url":"https://api.github.com/users/almedina-ms/orgs","repos_url":"https://api.github.com/users/almedina-ms/repos","events_url":"https://api.github.com/users/almedina-ms/events{/privacy}","received_events_url":"https://api.github.com/users/almedina-ms/received_events","type":"User","site_admin":false},"body":"Merges the two methods for .NET into a shared one. The added class also includes the color validation used by the parsing process.\r\n\r\nFixes this: https://github.com/microsoft/adaptivecards/issues/2120","created_at":"2018-11-29T20:02:20Z","updated_at":"2018-11-29T20:46:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c0bff1df9d95976fbb6113ecc60b467738ba8d8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"khouzam","id":6656040,"node_id":"MDQ6VXNlcjY2NTYwNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6656040?v=4","gravatar_id":"","url":"https://api.github.com/users/khouzam","html_url":"https://github.com/khouzam","followers_url":"https://api.github.com/users/khouzam/followers","following_url":"https://api.github.com/users/khouzam/following{/other_user}","gists_url":"https://api.github.com/users/khouzam/gists{/gist_id}","starred_url":"https://api.github.com/users/khouzam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khouzam/subscriptions","organizations_url":"https://api.github.com/users/khouzam/orgs","repos_url":"https://api.github.com/users/khouzam/repos","events_url":"https://api.github.com/users/khouzam/events{/privacy}","received_events_url":"https://api.github.com/users/khouzam/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/2195/commits","review_comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/2195/comments","review_comment_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/2195/comments","statuses_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/8e24855eaa90a6cefeb0f772b7ee4e7f2f5be3a5","head":{"label":"Microsoft:user/almedina-ms/NormalizeColorValidation","ref":"user/almedina-ms/NormalizeColorValidation","sha":"8e24855eaa90a6cefeb0f772b7ee4e7f2f5be3a5","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":75978731,"node_id":"MDEwOlJlcG9zaXRvcnk3NTk3ODczMQ==","name":"AdaptiveCards","full_name":"Microsoft/AdaptiveCards","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/AdaptiveCards","description":"A new way for developers to exchange card content in a common and consistent way.","fork":false,"url":"https://api.github.com/repos/Microsoft/AdaptiveCards","forks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/forks","keys_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/teams","hooks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/events","assignees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/tags","blobs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/languages","stargazers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscription","commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/merges","archive_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/downloads","issues_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/deployments","created_at":"2016-12-08T22:00:33Z","updated_at":"2018-11-29T19:02:18Z","pushed_at":"2018-11-29T20:02:21Z","git_url":"git://github.com/Microsoft/AdaptiveCards.git","ssh_url":"git@github.com:Microsoft/AdaptiveCards.git","clone_url":"https://github.com/Microsoft/AdaptiveCards.git","svn_url":"https://github.com/Microsoft/AdaptiveCards","homepage":"https://adaptivecards.io","size":102686,"stargazers_count":405,"watchers_count":405,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":390,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":119,"open_issues":390,"watchers":405,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"4e74d25af36e29eb84a2da98908d5665402e2f13","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":75978731,"node_id":"MDEwOlJlcG9zaXRvcnk3NTk3ODczMQ==","name":"AdaptiveCards","full_name":"Microsoft/AdaptiveCards","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/AdaptiveCards","description":"A new way for developers to exchange card content in a common and consistent way.","fork":false,"url":"https://api.github.com/repos/Microsoft/AdaptiveCards","forks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/forks","keys_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/teams","hooks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/events","assignees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/tags","blobs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/languages","stargazers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscription","commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/merges","archive_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/downloads","issues_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/deployments","created_at":"2016-12-08T22:00:33Z","updated_at":"2018-11-29T19:02:18Z","pushed_at":"2018-11-29T20:02:21Z","git_url":"git://github.com/Microsoft/AdaptiveCards.git","ssh_url":"git@github.com:Microsoft/AdaptiveCards.git","clone_url":"https://github.com/Microsoft/AdaptiveCards.git","svn_url":"https://github.com/Microsoft/AdaptiveCards","homepage":"https://adaptivecards.io","size":102686,"stargazers_count":405,"watchers_count":405,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":390,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":119,"open_issues":390,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/2195"},"html":{"href":"https://github.com/Microsoft/AdaptiveCards/pull/2195"},"issue":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/2195"},"comments":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/2195/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/2195/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/2195/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/8e24855eaa90a6cefeb0f772b7ee4e7f2f5be3a5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"paulcam206"}}