{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/188289639","pull_request_review_id":120236369,"id":188289639,"diff_hunk":"@@ -11,23 +11,91 @@ exports_files([\n # This ensures that package.json in subdirectories get installed as well.\n alias(\n     name = \"install\",\n-    actual = \"@yarn//:yarn\",\n+    actual = \"@nodejs//:yarn\",\n )\n \n node_modules_filegroup(\n     name = \"node_modules\",\n     packages = [\n+        \"ajv\",","path":"BUILD.bazel","position":11,"original_position":11,"commit_id":"b227ba1eeffc90b25f5b5e9a2c7361201815adb4","original_commit_id":"b227ba1eeffc90b25f5b5e9a2c7361201815adb4","user":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars2.githubusercontent.com/u/47395?v=4","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"body":"This looks very difficult to maintain. Why not include *all* the packages?\r\nEven better, Angular should move to a `yarn_install` rule with a separate compile-time deps `package.json`\r\n\r\nIn any of these cases, there will be a ton of inputs to every nodejs action, I wonder how it will affect performance.","created_at":"2018-05-15T13:38:15Z","updated_at":"2018-05-15T13:38:15Z","html_url":"https://github.com/angular/angular/pull/23845#discussion_r188289639","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/23845","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/188289639"},"html":{"href":"https://github.com/angular/angular/pull/23845#discussion_r188289639"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/23845"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/23845","id":187379013,"html_url":"https://github.com/angular/angular/pull/23845","diff_url":"https://github.com/angular/angular/pull/23845.diff","patch_url":"https://github.com/angular/angular/pull/23845.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/23845","number":23845,"state":"open","locked":false,"title":"WIP: Turn on preserve-symlinks","user":{"login":"gregmagolan","id":520826,"avatar_url":"https://avatars1.githubusercontent.com/u/520826?v=4","gravatar_id":"","url":"https://api.github.com/users/gregmagolan","html_url":"https://github.com/gregmagolan","followers_url":"https://api.github.com/users/gregmagolan/followers","following_url":"https://api.github.com/users/gregmagolan/following{/other_user}","gists_url":"https://api.github.com/users/gregmagolan/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmagolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmagolan/subscriptions","organizations_url":"https://api.github.com/users/gregmagolan/orgs","repos_url":"https://api.github.com/users/gregmagolan/repos","events_url":"https://api.github.com/users/gregmagolan/events{/privacy}","received_events_url":"https://api.github.com/users/gregmagolan/received_events","type":"User","site_admin":false},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [ ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[ ] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\nIssue Number: N/A\r\n\r\n\r\n## What is the new behavior?\r\n\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[ ] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\n","created_at":"2018-05-11T06:36:23Z","updated_at":"2018-05-15T13:38:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa6068bdb2537e46f5fa45716328770bde0c4596","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/23845/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/23845/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/23845/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/b227ba1eeffc90b25f5b5e9a2c7361201815adb4","head":{"label":"gregmagolan:preserve-symlinks","ref":"preserve-symlinks","sha":"b227ba1eeffc90b25f5b5e9a2c7361201815adb4","user":{"login":"gregmagolan","id":520826,"avatar_url":"https://avatars1.githubusercontent.com/u/520826?v=4","gravatar_id":"","url":"https://api.github.com/users/gregmagolan","html_url":"https://github.com/gregmagolan","followers_url":"https://api.github.com/users/gregmagolan/followers","following_url":"https://api.github.com/users/gregmagolan/following{/other_user}","gists_url":"https://api.github.com/users/gregmagolan/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmagolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmagolan/subscriptions","organizations_url":"https://api.github.com/users/gregmagolan/orgs","repos_url":"https://api.github.com/users/gregmagolan/repos","events_url":"https://api.github.com/users/gregmagolan/events{/privacy}","received_events_url":"https://api.github.com/users/gregmagolan/received_events","type":"User","site_admin":false},"repo":{"id":118185908,"name":"angular","full_name":"gregmagolan/angular","owner":{"login":"gregmagolan","id":520826,"avatar_url":"https://avatars1.githubusercontent.com/u/520826?v=4","gravatar_id":"","url":"https://api.github.com/users/gregmagolan","html_url":"https://github.com/gregmagolan","followers_url":"https://api.github.com/users/gregmagolan/followers","following_url":"https://api.github.com/users/gregmagolan/following{/other_user}","gists_url":"https://api.github.com/users/gregmagolan/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmagolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmagolan/subscriptions","organizations_url":"https://api.github.com/users/gregmagolan/orgs","repos_url":"https://api.github.com/users/gregmagolan/repos","events_url":"https://api.github.com/users/gregmagolan/events{/privacy}","received_events_url":"https://api.github.com/users/gregmagolan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregmagolan/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/gregmagolan/angular","forks_url":"https://api.github.com/repos/gregmagolan/angular/forks","keys_url":"https://api.github.com/repos/gregmagolan/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregmagolan/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregmagolan/angular/teams","hooks_url":"https://api.github.com/repos/gregmagolan/angular/hooks","issue_events_url":"https://api.github.com/repos/gregmagolan/angular/issues/events{/number}","events_url":"https://api.github.com/repos/gregmagolan/angular/events","assignees_url":"https://api.github.com/repos/gregmagolan/angular/assignees{/user}","branches_url":"https://api.github.com/repos/gregmagolan/angular/branches{/branch}","tags_url":"https://api.github.com/repos/gregmagolan/angular/tags","blobs_url":"https://api.github.com/repos/gregmagolan/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregmagolan/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregmagolan/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregmagolan/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregmagolan/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/gregmagolan/angular/languages","stargazers_url":"https://api.github.com/repos/gregmagolan/angular/stargazers","contributors_url":"https://api.github.com/repos/gregmagolan/angular/contributors","subscribers_url":"https://api.github.com/repos/gregmagolan/angular/subscribers","subscription_url":"https://api.github.com/repos/gregmagolan/angular/subscription","commits_url":"https://api.github.com/repos/gregmagolan/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregmagolan/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregmagolan/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregmagolan/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregmagolan/angular/contents/{+path}","compare_url":"https://api.github.com/repos/gregmagolan/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregmagolan/angular/merges","archive_url":"https://api.github.com/repos/gregmagolan/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregmagolan/angular/downloads","issues_url":"https://api.github.com/repos/gregmagolan/angular/issues{/number}","pulls_url":"https://api.github.com/repos/gregmagolan/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/gregmagolan/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/gregmagolan/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregmagolan/angular/labels{/name}","releases_url":"https://api.github.com/repos/gregmagolan/angular/releases{/id}","deployments_url":"https://api.github.com/repos/gregmagolan/angular/deployments","created_at":"2018-01-19T22:29:41Z","updated_at":"2018-05-15T06:07:00Z","pushed_at":"2018-05-15T06:07:01Z","git_url":"git://github.com/gregmagolan/angular.git","ssh_url":"git@github.com:gregmagolan/angular.git","clone_url":"https://github.com/gregmagolan/angular.git","svn_url":"https://github.com/gregmagolan/angular","homepage":"https://angular.io","size":80571,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"d4b6c41a5f8ca84082f90a5d738b23d3ba71bbb0","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-05-15T11:48:53Z","pushed_at":"2018-05-15T06:07:04Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":80918,"stargazers_count":36246,"watchers_count":36246,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8790,"mirror_url":null,"archived":false,"open_issues_count":2376,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8790,"open_issues":2376,"watchers":36246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/23845"},"html":{"href":"https://github.com/angular/angular/pull/23845"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/23845"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/23845/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/23845/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/23845/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/b227ba1eeffc90b25f5b5e9a2c7361201815adb4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alexeagle"}}