{"action":"created","issue":{"url":"https://api.github.com/repos/friendica/friendica/issues/5506","repository_url":"https://api.github.com/repos/friendica/friendica","labels_url":"https://api.github.com/repos/friendica/friendica/issues/5506/labels{/name}","comments_url":"https://api.github.com/repos/friendica/friendica/issues/5506/comments","events_url":"https://api.github.com/repos/friendica/friendica/issues/5506/events","html_url":"https://github.com/friendica/friendica/pull/5506","id":345014749,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Mjc0MjE4","number":5506,"title":"Possible fix for #5470 and empty() usage","user":{"login":"Quix0r","id":470798,"node_id":"MDQ6VXNlcjQ3MDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/470798?v=4","gravatar_id":"","url":"https://api.github.com/users/Quix0r","html_url":"https://github.com/Quix0r","followers_url":"https://api.github.com/users/Quix0r/followers","following_url":"https://api.github.com/users/Quix0r/following{/other_user}","gists_url":"https://api.github.com/users/Quix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Quix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quix0r/subscriptions","organizations_url":"https://api.github.com/users/Quix0r/orgs","repos_url":"https://api.github.com/users/Quix0r/repos","events_url":"https://api.github.com/users/Quix0r/events{/privacy}","received_events_url":"https://api.github.com/users/Quix0r/received_events","type":"User","site_admin":false},"labels":[{"id":46563623,"node_id":"MDU6TGFiZWw0NjU2MzYyMw==","url":"https://api.github.com/repos/friendica/friendica/labels/Bug","name":"Bug","color":"e11d21","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/friendica/friendica/milestones/13","html_url":"https://github.com/friendica/friendica/milestone/13","labels_url":"https://api.github.com/repos/friendica/friendica/milestones/13/labels","id":3207058,"node_id":"MDk6TWlsZXN0b25lMzIwNzA1OA==","number":13,"title":"2018.08","description":"","creator":{"login":"tobiasd","id":433490,"node_id":"MDQ6VXNlcjQzMzQ5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/433490?v=4","gravatar_id":"","url":"https://api.github.com/users/tobiasd","html_url":"https://github.com/tobiasd","followers_url":"https://api.github.com/users/tobiasd/followers","following_url":"https://api.github.com/users/tobiasd/following{/other_user}","gists_url":"https://api.github.com/users/tobiasd/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasd/subscriptions","organizations_url":"https://api.github.com/users/tobiasd/orgs","repos_url":"https://api.github.com/users/tobiasd/repos","events_url":"https://api.github.com/users/tobiasd/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasd/received_events","type":"User","site_admin":false},"open_issues":157,"closed_issues":282,"state":"open","created_at":"2018-03-21T18:22:36Z","updated_at":"2018-07-26T22:27:13Z","due_on":"2018-08-26T07:00:00Z","closed_at":null},"comments":5,"created_at":"2018-07-26T21:38:08Z","updated_at":"2018-07-27T19:03:23Z","closed_at":"2018-07-26T22:27:13Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/friendica/friendica/pulls/5506","html_url":"https://github.com/friendica/friendica/pull/5506","diff_url":"https://github.com/friendica/friendica/pull/5506.diff","patch_url":"https://github.com/friendica/friendica/pull/5506.patch"},"body":"This PR fixes invalid array/object mixture:\r\n- $data is not an object like stdClass but an array\r\n- newer PHP versions doesn't allow cross-access like following:\r\n\r\n  $object['foo'] = 123;\r\n  $array->foo = 123;\r\n\r\n- added type-hints for private methods for above cases\r\n- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty\r\n  E_NOTICE\r\n- added some empty lines for better readability"},"comment":{"url":"https://api.github.com/repos/friendica/friendica/issues/comments/408511222","html_url":"https://github.com/friendica/friendica/pull/5506#issuecomment-408511222","issue_url":"https://api.github.com/repos/friendica/friendica/issues/5506","id":408511222,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODUxMTIyMg==","user":{"login":"MrPetovan","id":925415,"node_id":"MDQ6VXNlcjkyNTQxNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/925415?v=4","gravatar_id":"","url":"https://api.github.com/users/MrPetovan","html_url":"https://github.com/MrPetovan","followers_url":"https://api.github.com/users/MrPetovan/followers","following_url":"https://api.github.com/users/MrPetovan/following{/other_user}","gists_url":"https://api.github.com/users/MrPetovan/gists{/gist_id}","starred_url":"https://api.github.com/users/MrPetovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrPetovan/subscriptions","organizations_url":"https://api.github.com/users/MrPetovan/orgs","repos_url":"https://api.github.com/users/MrPetovan/repos","events_url":"https://api.github.com/users/MrPetovan/events{/privacy}","received_events_url":"https://api.github.com/users/MrPetovan/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T19:03:23Z","updated_at":"2018-07-27T19:03:23Z","author_association":"COLLABORATOR","body":"Just put the second parameter to all `json_encode()` calls to true."}}
{"actor":{"display_login":"MrPetovan"}}