{"action":"created","issue":{"url":"https://api.github.com/repos/ContextInstitute/bfcom/issues/37","repository_url":"https://api.github.com/repos/ContextInstitute/bfcom","labels_url":"https://api.github.com/repos/ContextInstitute/bfcom/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/ContextInstitute/bfcom/issues/37/comments","events_url":"https://api.github.com/repos/ContextInstitute/bfcom/issues/37/events","html_url":"https://github.com/ContextInstitute/bfcom/issues/37","id":364250511,"node_id":"MDU6SXNzdWUzNjQyNTA1MTE=","number":37,"title":"conform our existing code to our standards","user":{"login":"rgilman","id":615052,"node_id":"MDQ6VXNlcjYxNTA1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/615052?v=4","gravatar_id":"","url":"https://api.github.com/users/rgilman","html_url":"https://github.com/rgilman","followers_url":"https://api.github.com/users/rgilman/followers","following_url":"https://api.github.com/users/rgilman/following{/other_user}","gists_url":"https://api.github.com/users/rgilman/gists{/gist_id}","starred_url":"https://api.github.com/users/rgilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgilman/subscriptions","organizations_url":"https://api.github.com/users/rgilman/orgs","repos_url":"https://api.github.com/users/rgilman/repos","events_url":"https://api.github.com/users/rgilman/events{/privacy}","received_events_url":"https://api.github.com/users/rgilman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"rgilman","id":615052,"node_id":"MDQ6VXNlcjYxNTA1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/615052?v=4","gravatar_id":"","url":"https://api.github.com/users/rgilman","html_url":"https://github.com/rgilman","followers_url":"https://api.github.com/users/rgilman/followers","following_url":"https://api.github.com/users/rgilman/following{/other_user}","gists_url":"https://api.github.com/users/rgilman/gists{/gist_id}","starred_url":"https://api.github.com/users/rgilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgilman/subscriptions","organizations_url":"https://api.github.com/users/rgilman/orgs","repos_url":"https://api.github.com/users/rgilman/repos","events_url":"https://api.github.com/users/rgilman/events{/privacy}","received_events_url":"https://api.github.com/users/rgilman/received_events","type":"User","site_admin":false},"assignees":[{"login":"rgilman","id":615052,"node_id":"MDQ6VXNlcjYxNTA1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/615052?v=4","gravatar_id":"","url":"https://api.github.com/users/rgilman","html_url":"https://github.com/rgilman","followers_url":"https://api.github.com/users/rgilman/followers","following_url":"https://api.github.com/users/rgilman/following{/other_user}","gists_url":"https://api.github.com/users/rgilman/gists{/gist_id}","starred_url":"https://api.github.com/users/rgilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgilman/subscriptions","organizations_url":"https://api.github.com/users/rgilman/orgs","repos_url":"https://api.github.com/users/rgilman/repos","events_url":"https://api.github.com/users/rgilman/events{/privacy}","received_events_url":"https://api.github.com/users/rgilman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-09-26T23:30:10Z","updated_at":"2018-09-29T21:29:29Z","closed_at":"2018-09-28T22:04:00Z","author_association":"MEMBER","body":"We should at least do this for the files we have created or modified.\r\n\r\nI did a comparison between BFCom and JointsWP. The issues I found are:\r\n\r\n- parts/nav-bftop.php and parts/nav-bfsubmenu.php – the 'nav- ...' structure meshes with get_template_part() which is a WP function so we need to stay with that structure. We could rename the files nav-bfc_top.php and nav-bfc_submenu.php. I'm using underscores so the part after nav- gets treated as a block. The code in the files should also be conformed with our standards.\r\n- header.php contains a 'get_template_part' reference to ('parts/nav', 'bftop') that would need to be updated to match the new file name.\r\n- /assets/styles/style.css – any new code in here should be checked for coding standards.\r\n- /functions/bfcom-fn.php – this should likely be changed to bfc-functions.php\r\n- /functions.php contains a reference to bfcom-fn.php that would need to be updated.\r\n\r\nI'm willing to do this clean-up."},"comment":{"url":"https://api.github.com/repos/ContextInstitute/bfcom/issues/comments/425676756","html_url":"https://github.com/ContextInstitute/bfcom/issues/37#issuecomment-425676756","issue_url":"https://api.github.com/repos/ContextInstitute/bfcom/issues/37","id":425676756,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTY3Njc1Ng==","user":{"login":"rgilman","id":615052,"node_id":"MDQ6VXNlcjYxNTA1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/615052?v=4","gravatar_id":"","url":"https://api.github.com/users/rgilman","html_url":"https://github.com/rgilman","followers_url":"https://api.github.com/users/rgilman/followers","following_url":"https://api.github.com/users/rgilman/following{/other_user}","gists_url":"https://api.github.com/users/rgilman/gists{/gist_id}","starred_url":"https://api.github.com/users/rgilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgilman/subscriptions","organizations_url":"https://api.github.com/users/rgilman/orgs","repos_url":"https://api.github.com/users/rgilman/repos","events_url":"https://api.github.com/users/rgilman/events{/privacy}","received_events_url":"https://api.github.com/users/rgilman/received_events","type":"User","site_admin":false},"created_at":"2018-09-29T21:29:29Z","updated_at":"2018-09-29T21:29:29Z","author_association":"MEMBER","body":"I agree it looks odd. I'll test `nav-bfc-submenu.php` locally. If there are now issues, I'd be happy to update."}}
{"actor":{"display_login":"rgilman"}}