{"action":"created","comment":{"url":"https://api.github.com/repos/pytroll/satpy/pulls/comments/177399031","pull_request_review_id":107259979,"id":177399031,"diff_hunk":"@@ -96,7 +96,7 @@ def get_test_content(self, filename, filename_info, filetype_info):\n                     if key + '/attr/' + a in file_content:\n                         attrs[a] = file_content[key + '/attr/' + a]\n                 if val.ndim > 1:\n-                    file_content[key] = DataArray(val, dims=('y', 'x'), attrs=attrs)\n+                    file_content[key] = DataArray(val, dims=('lines', 'elements'), attrs=attrs)","path":"satpy/tests/reader_tests/test_geocat.py","position":5,"original_position":5,"commit_id":"c0be224e26b200a66f2639952f5a4facf81aeb97","original_commit_id":"c0be224e26b200a66f2639952f5a4facf81aeb97","user":{"login":"davidh-ssec","id":1828519,"avatar_url":"https://avatars3.githubusercontent.com/u/1828519?v=4","gravatar_id":"","url":"https://api.github.com/users/davidh-ssec","html_url":"https://github.com/davidh-ssec","followers_url":"https://api.github.com/users/davidh-ssec/followers","following_url":"https://api.github.com/users/davidh-ssec/following{/other_user}","gists_url":"https://api.github.com/users/davidh-ssec/gists{/gist_id}","starred_url":"https://api.github.com/users/davidh-ssec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidh-ssec/subscriptions","organizations_url":"https://api.github.com/users/davidh-ssec/orgs","repos_url":"https://api.github.com/users/davidh-ssec/repos","events_url":"https://api.github.com/users/davidh-ssec/events{/privacy}","received_events_url":"https://api.github.com/users/davidh-ssec/received_events","type":"User","site_admin":false},"body":"The test is meant to represent what is in the file. The NetCDF4 utility wrapper does not rename any dimensions so in the geocat files the dimensions are actually lines and elements.","created_at":"2018-03-27T12:04:41Z","updated_at":"2018-03-27T12:04:41Z","html_url":"https://github.com/pytroll/satpy/pull/239#discussion_r177399031","pull_request_url":"https://api.github.com/repos/pytroll/satpy/pulls/239","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytroll/satpy/pulls/comments/177399031"},"html":{"href":"https://github.com/pytroll/satpy/pull/239#discussion_r177399031"},"pull_request":{"href":"https://api.github.com/repos/pytroll/satpy/pulls/239"}},"in_reply_to_id":177316804},"pull_request":{"url":"https://api.github.com/repos/pytroll/satpy/pulls/239","id":177444732,"html_url":"https://github.com/pytroll/satpy/pull/239","diff_url":"https://github.com/pytroll/satpy/pull/239.diff","patch_url":"https://github.com/pytroll/satpy/pull/239.patch","issue_url":"https://api.github.com/repos/pytroll/satpy/issues/239","number":239,"state":"open","locked":false,"title":"Add CSPP Geo (geocat) AHI reading support","user":{"login":"davidh-ssec","id":1828519,"avatar_url":"https://avatars3.githubusercontent.com/u/1828519?v=4","gravatar_id":"","url":"https://api.github.com/users/davidh-ssec","html_url":"https://github.com/davidh-ssec","followers_url":"https://api.github.com/users/davidh-ssec/followers","following_url":"https://api.github.com/users/davidh-ssec/following{/other_user}","gists_url":"https://api.github.com/users/davidh-ssec/gists{/gist_id}","starred_url":"https://api.github.com/users/davidh-ssec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidh-ssec/subscriptions","organizations_url":"https://api.github.com/users/davidh-ssec/orgs","repos_url":"https://api.github.com/users/davidh-ssec/repos","events_url":"https://api.github.com/users/davidh-ssec/events{/privacy}","received_events_url":"https://api.github.com/users/davidh-ssec/received_events","type":"User","site_admin":false},"body":"This PR adds AHI dataset identifiers to the geocat reader which will allow full support for CSPP Geo AHI products. Without this added to the reader config the datasets would not have an associated wavelength.\r\n\r\nThis PR also includes a large-ish change to the base readers and file handlers with a `sensor_names` property. Previously this was just an instance attribute. The default behavior is the same as before. The difference happens for any file handler that redefines `sensor_names` which will be used to determine what sensor's files have been loaded. This was needed for the geocat reader which supports multiple sensors including ABI and AHI. Some of the composite entries for these sensors conflict and in the previous implementation it was loading both ABI and AHI configs and which one took priority was unspecified.\r\n\r\n - [ ] Tests added <!-- for all bug fixes or enhancements -->\r\n - [x] Tests passed <!-- for all non-documentation changes) -->\r\n - [x] Passes ``git diff origin/develop **/*py | flake8 --diff`` <!-- remove if you did not edit any Python files -->\r\n","created_at":"2018-03-26T13:23:38Z","updated_at":"2018-03-27T12:04:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"970086e2d09e7dc845c8fa8011f11c0b63b56e98","assignee":{"login":"davidh-ssec","id":1828519,"avatar_url":"https://avatars3.githubusercontent.com/u/1828519?v=4","gravatar_id":"","url":"https://api.github.com/users/davidh-ssec","html_url":"https://github.com/davidh-ssec","followers_url":"https://api.github.com/users/davidh-ssec/followers","following_url":"https://api.github.com/users/davidh-ssec/following{/other_user}","gists_url":"https://api.github.com/users/davidh-ssec/gists{/gist_id}","starred_url":"https://api.github.com/users/davidh-ssec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidh-ssec/subscriptions","organizations_url":"https://api.github.com/users/davidh-ssec/orgs","repos_url":"https://api.github.com/users/davidh-ssec/repos","events_url":"https://api.github.com/users/davidh-ssec/events{/privacy}","received_events_url":"https://api.github.com/users/davidh-ssec/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidh-ssec","id":1828519,"avatar_url":"https://avatars3.githubusercontent.com/u/1828519?v=4","gravatar_id":"","url":"https://api.github.com/users/davidh-ssec","html_url":"https://github.com/davidh-ssec","followers_url":"https://api.github.com/users/davidh-ssec/followers","following_url":"https://api.github.com/users/davidh-ssec/following{/other_user}","gists_url":"https://api.github.com/users/davidh-ssec/gists{/gist_id}","starred_url":"https://api.github.com/users/davidh-ssec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidh-ssec/subscriptions","organizations_url":"https://api.github.com/users/davidh-ssec/orgs","repos_url":"https://api.github.com/users/davidh-ssec/repos","events_url":"https://api.github.com/users/davidh-ssec/events{/privacy}","received_events_url":"https://api.github.com/users/davidh-ssec/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":841946101,"url":"https://api.github.com/repos/pytroll/satpy/labels/component:readers","name":"component:readers","color":"1d76db","default":false},{"id":323805264,"url":"https://api.github.com/repos/pytroll/satpy/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/pytroll/satpy/milestones/2","html_url":"https://github.com/pytroll/satpy/milestone/2","labels_url":"https://api.github.com/repos/pytroll/satpy/milestones/2/labels","id":2979810,"number":2,"title":"v0.9","description":"Xarray and dask","creator":{"login":"mraspaud","id":167802,"avatar_url":"https://avatars1.githubusercontent.com/u/167802?v=4","gravatar_id":"","url":"https://api.github.com/users/mraspaud","html_url":"https://github.com/mraspaud","followers_url":"https://api.github.com/users/mraspaud/followers","following_url":"https://api.github.com/users/mraspaud/following{/other_user}","gists_url":"https://api.github.com/users/mraspaud/gists{/gist_id}","starred_url":"https://api.github.com/users/mraspaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mraspaud/subscriptions","organizations_url":"https://api.github.com/users/mraspaud/orgs","repos_url":"https://api.github.com/users/mraspaud/repos","events_url":"https://api.github.com/users/mraspaud/events{/privacy}","received_events_url":"https://api.github.com/users/mraspaud/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":19,"state":"open","created_at":"2017-12-14T12:48:31Z","updated_at":"2018-03-26T13:23:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pytroll/satpy/pulls/239/commits","review_comments_url":"https://api.github.com/repos/pytroll/satpy/pulls/239/comments","review_comment_url":"https://api.github.com/repos/pytroll/satpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytroll/satpy/issues/239/comments","statuses_url":"https://api.github.com/repos/pytroll/satpy/statuses/c0be224e26b200a66f2639952f5a4facf81aeb97","head":{"label":"pytroll:feature-geocat-ahi-xarray","ref":"feature-geocat-ahi-xarray","sha":"c0be224e26b200a66f2639952f5a4facf81aeb97","user":{"login":"pytroll","id":13004956,"avatar_url":"https://avatars0.githubusercontent.com/u/13004956?v=4","gravatar_id":"","url":"https://api.github.com/users/pytroll","html_url":"https://github.com/pytroll","followers_url":"https://api.github.com/users/pytroll/followers","following_url":"https://api.github.com/users/pytroll/following{/other_user}","gists_url":"https://api.github.com/users/pytroll/gists{/gist_id}","starred_url":"https://api.github.com/users/pytroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytroll/subscriptions","organizations_url":"https://api.github.com/users/pytroll/orgs","repos_url":"https://api.github.com/users/pytroll/repos","events_url":"https://api.github.com/users/pytroll/events{/privacy}","received_events_url":"https://api.github.com/users/pytroll/received_events","type":"Organization","site_admin":false},"repo":{"id":51397392,"name":"satpy","full_name":"pytroll/satpy","owner":{"login":"pytroll","id":13004956,"avatar_url":"https://avatars0.githubusercontent.com/u/13004956?v=4","gravatar_id":"","url":"https://api.github.com/users/pytroll","html_url":"https://github.com/pytroll","followers_url":"https://api.github.com/users/pytroll/followers","following_url":"https://api.github.com/users/pytroll/following{/other_user}","gists_url":"https://api.github.com/users/pytroll/gists{/gist_id}","starred_url":"https://api.github.com/users/pytroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytroll/subscriptions","organizations_url":"https://api.github.com/users/pytroll/orgs","repos_url":"https://api.github.com/users/pytroll/repos","events_url":"https://api.github.com/users/pytroll/events{/privacy}","received_events_url":"https://api.github.com/users/pytroll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytroll/satpy","description":"Python package for earth-observing satellite data processing","fork":false,"url":"https://api.github.com/repos/pytroll/satpy","forks_url":"https://api.github.com/repos/pytroll/satpy/forks","keys_url":"https://api.github.com/repos/pytroll/satpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytroll/satpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytroll/satpy/teams","hooks_url":"https://api.github.com/repos/pytroll/satpy/hooks","issue_events_url":"https://api.github.com/repos/pytroll/satpy/issues/events{/number}","events_url":"https://api.github.com/repos/pytroll/satpy/events","assignees_url":"https://api.github.com/repos/pytroll/satpy/assignees{/user}","branches_url":"https://api.github.com/repos/pytroll/satpy/branches{/branch}","tags_url":"https://api.github.com/repos/pytroll/satpy/tags","blobs_url":"https://api.github.com/repos/pytroll/satpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytroll/satpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytroll/satpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytroll/satpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytroll/satpy/statuses/{sha}","languages_url":"https://api.github.com/repos/pytroll/satpy/languages","stargazers_url":"https://api.github.com/repos/pytroll/satpy/stargazers","contributors_url":"https://api.github.com/repos/pytroll/satpy/contributors","subscribers_url":"https://api.github.com/repos/pytroll/satpy/subscribers","subscription_url":"https://api.github.com/repos/pytroll/satpy/subscription","commits_url":"https://api.github.com/repos/pytroll/satpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytroll/satpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytroll/satpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytroll/satpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytroll/satpy/contents/{+path}","compare_url":"https://api.github.com/repos/pytroll/satpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytroll/satpy/merges","archive_url":"https://api.github.com/repos/pytroll/satpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytroll/satpy/downloads","issues_url":"https://api.github.com/repos/pytroll/satpy/issues{/number}","pulls_url":"https://api.github.com/repos/pytroll/satpy/pulls{/number}","milestones_url":"https://api.github.com/repos/pytroll/satpy/milestones{/number}","notifications_url":"https://api.github.com/repos/pytroll/satpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytroll/satpy/labels{/name}","releases_url":"https://api.github.com/repos/pytroll/satpy/releases{/id}","deployments_url":"https://api.github.com/repos/pytroll/satpy/deployments","created_at":"2016-02-09T20:29:43Z","updated_at":"2018-03-12T14:06:52Z","pushed_at":"2018-03-26T14:31:32Z","git_url":"git://github.com/pytroll/satpy.git","ssh_url":"git@github.com:pytroll/satpy.git","clone_url":"https://github.com/pytroll/satpy.git","svn_url":"https://github.com/pytroll/satpy","homepage":"http://satpy.readthedocs.org/en/latest/","size":4604,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":35,"open_issues":58,"watchers":41,"default_branch":"master"}},"base":{"label":"pytroll:develop","ref":"develop","sha":"422c02fb1afdfc3bfcc2cdd9b3c77a0061b9278f","user":{"login":"pytroll","id":13004956,"avatar_url":"https://avatars0.githubusercontent.com/u/13004956?v=4","gravatar_id":"","url":"https://api.github.com/users/pytroll","html_url":"https://github.com/pytroll","followers_url":"https://api.github.com/users/pytroll/followers","following_url":"https://api.github.com/users/pytroll/following{/other_user}","gists_url":"https://api.github.com/users/pytroll/gists{/gist_id}","starred_url":"https://api.github.com/users/pytroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytroll/subscriptions","organizations_url":"https://api.github.com/users/pytroll/orgs","repos_url":"https://api.github.com/users/pytroll/repos","events_url":"https://api.github.com/users/pytroll/events{/privacy}","received_events_url":"https://api.github.com/users/pytroll/received_events","type":"Organization","site_admin":false},"repo":{"id":51397392,"name":"satpy","full_name":"pytroll/satpy","owner":{"login":"pytroll","id":13004956,"avatar_url":"https://avatars0.githubusercontent.com/u/13004956?v=4","gravatar_id":"","url":"https://api.github.com/users/pytroll","html_url":"https://github.com/pytroll","followers_url":"https://api.github.com/users/pytroll/followers","following_url":"https://api.github.com/users/pytroll/following{/other_user}","gists_url":"https://api.github.com/users/pytroll/gists{/gist_id}","starred_url":"https://api.github.com/users/pytroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytroll/subscriptions","organizations_url":"https://api.github.com/users/pytroll/orgs","repos_url":"https://api.github.com/users/pytroll/repos","events_url":"https://api.github.com/users/pytroll/events{/privacy}","received_events_url":"https://api.github.com/users/pytroll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytroll/satpy","description":"Python package for earth-observing satellite data processing","fork":false,"url":"https://api.github.com/repos/pytroll/satpy","forks_url":"https://api.github.com/repos/pytroll/satpy/forks","keys_url":"https://api.github.com/repos/pytroll/satpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytroll/satpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytroll/satpy/teams","hooks_url":"https://api.github.com/repos/pytroll/satpy/hooks","issue_events_url":"https://api.github.com/repos/pytroll/satpy/issues/events{/number}","events_url":"https://api.github.com/repos/pytroll/satpy/events","assignees_url":"https://api.github.com/repos/pytroll/satpy/assignees{/user}","branches_url":"https://api.github.com/repos/pytroll/satpy/branches{/branch}","tags_url":"https://api.github.com/repos/pytroll/satpy/tags","blobs_url":"https://api.github.com/repos/pytroll/satpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytroll/satpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytroll/satpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytroll/satpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytroll/satpy/statuses/{sha}","languages_url":"https://api.github.com/repos/pytroll/satpy/languages","stargazers_url":"https://api.github.com/repos/pytroll/satpy/stargazers","contributors_url":"https://api.github.com/repos/pytroll/satpy/contributors","subscribers_url":"https://api.github.com/repos/pytroll/satpy/subscribers","subscription_url":"https://api.github.com/repos/pytroll/satpy/subscription","commits_url":"https://api.github.com/repos/pytroll/satpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytroll/satpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytroll/satpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytroll/satpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytroll/satpy/contents/{+path}","compare_url":"https://api.github.com/repos/pytroll/satpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytroll/satpy/merges","archive_url":"https://api.github.com/repos/pytroll/satpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytroll/satpy/downloads","issues_url":"https://api.github.com/repos/pytroll/satpy/issues{/number}","pulls_url":"https://api.github.com/repos/pytroll/satpy/pulls{/number}","milestones_url":"https://api.github.com/repos/pytroll/satpy/milestones{/number}","notifications_url":"https://api.github.com/repos/pytroll/satpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytroll/satpy/labels{/name}","releases_url":"https://api.github.com/repos/pytroll/satpy/releases{/id}","deployments_url":"https://api.github.com/repos/pytroll/satpy/deployments","created_at":"2016-02-09T20:29:43Z","updated_at":"2018-03-12T14:06:52Z","pushed_at":"2018-03-26T14:31:32Z","git_url":"git://github.com/pytroll/satpy.git","ssh_url":"git@github.com:pytroll/satpy.git","clone_url":"https://github.com/pytroll/satpy.git","svn_url":"https://github.com/pytroll/satpy","homepage":"http://satpy.readthedocs.org/en/latest/","size":4604,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":35,"open_issues":58,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytroll/satpy/pulls/239"},"html":{"href":"https://github.com/pytroll/satpy/pull/239"},"issue":{"href":"https://api.github.com/repos/pytroll/satpy/issues/239"},"comments":{"href":"https://api.github.com/repos/pytroll/satpy/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/pytroll/satpy/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/pytroll/satpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytroll/satpy/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/pytroll/satpy/statuses/c0be224e26b200a66f2639952f5a4facf81aeb97"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davidh-ssec"}}