{"action":"closed","issue":{"url":"https://api.github.com/repos/zkSNACKs/WalletWasabi/issues/795","repository_url":"https://api.github.com/repos/zkSNACKs/WalletWasabi","labels_url":"https://api.github.com/repos/zkSNACKs/WalletWasabi/issues/795/labels{/name}","comments_url":"https://api.github.com/repos/zkSNACKs/WalletWasabi/issues/795/comments","events_url":"https://api.github.com/repos/zkSNACKs/WalletWasabi/issues/795/events","html_url":"https://github.com/zkSNACKs/WalletWasabi/issues/795","id":376900757,"node_id":"MDU6SXNzdWUzNzY5MDA3NTc=","number":795,"title":"Fix Tor exception handling on non-English Linux","user":{"login":"nopara73","id":9156103,"node_id":"MDQ6VXNlcjkxNTYxMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/9156103?v=4","gravatar_id":"","url":"https://api.github.com/users/nopara73","html_url":"https://github.com/nopara73","followers_url":"https://api.github.com/users/nopara73/followers","following_url":"https://api.github.com/users/nopara73/following{/other_user}","gists_url":"https://api.github.com/users/nopara73/gists{/gist_id}","starred_url":"https://api.github.com/users/nopara73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nopara73/subscriptions","organizations_url":"https://api.github.com/users/nopara73/orgs","repos_url":"https://api.github.com/users/nopara73/repos","events_url":"https://api.github.com/users/nopara73/events{/privacy}","received_events_url":"https://api.github.com/users/nopara73/received_events","type":"User","site_admin":false},"labels":[{"id":351882671,"node_id":"MDU6TGFiZWwzNTE4ODI2NzE=","url":"https://api.github.com/repos/zkSNACKs/WalletWasabi/labels/debug","name":"debug","color":"ee0701","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-02T17:25:59Z","updated_at":"2018-11-02T21:52:08Z","closed_at":"2018-11-02T21:52:08Z","author_association":"COLLABORATOR","body":"We had this issue on non-English Windows, which we fixed, but I think non-English Tor also ruins it, since I got an error report about it.  \r\n\r\n```cs\r\ntry\r\n\t\t\t\t{\r\n\t\t\t\t\tawait TcpClient.ConnectAsync(TorSocks5EndPoint.Address, TorSocks5EndPoint.Port);\r\n\t\t\t\t}\r\n\t\t\t\t// ex.Message must be checked, because I'm having difficulty catching SocketExceptionFactory+ExtendedSocketException\r\n\t\t\t\tcatch (Exception ex) when (ex.Message.StartsWith(\r\n\t\t\t\t\t\t\t\t\t\t\t   \"No connection could be made because the target machine actively refused it\")\r\n\t\t\t\t\t\t\t\t\t\t   || ex.Message.StartsWith(\"Connection refused\"))\r\n\t\t\t\t{\r\n\t\t\t\t\terror = ex;\r\n\t\t\t\t}\r\n\t\t\t\tcatch (SocketException ex) when (ex.ErrorCode == 10061)\r\n\t\t\t\t{\r\n\t\t\t\t\terror = ex;\r\n\t\t\t\t}\r\n\t\t\t\tif (error != null)\r\n\t\t\t\t\tthrow new ConnectionException(\r\n\t\t\t\t\t\t$\"Couldn't connect to Tor SOCKSPort at {TorSocks5EndPoint.Address}:{TorSocks5EndPoint.Port}. Is Tor running?\", error);\r\n```\r\n\r\nI think `catch (SocketException ex) when (ex.ErrorCode == 10061)` doesn't catch the error on non-English Linux."}}
{"actor":{"display_login":"nopara73"}}