{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/190972050","pull_request_review_id":123465974,"id":190972050,"diff_hunk":"@@ -2,18 +2,67 @@\n // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n \n using System;\n+using System.Collections;\n+using System.Collections.Generic;\n+using Microsoft.AspNetCore.Mvc.Infrastructure;\n using Microsoft.Extensions.Localization;\n \n namespace Microsoft.AspNetCore.Mvc.DataAnnotations\n {\n     /// <summary>\n     /// Provides programmatic configuration for DataAnnotations localization in the MVC framework.\n     /// </summary>\n-    public class MvcDataAnnotationsLocalizationOptions\n+    public class MvcDataAnnotationsLocalizationOptions : IEnumerable<ICompatibilitySwitch>\n     {\n+        private readonly CompatibilitySwitch<bool> _allowDataAnnotationsLocalizationForEnumDisplayAttributes;\n+        private readonly ICompatibilitySwitch[] _switches;\n+\n         /// <summary>\n         /// The delegate to invoke for creating <see cref=\"IStringLocalizer\"/>.\n         /// </summary>\n         public Func<Type, IStringLocalizerFactory, IStringLocalizer> DataAnnotationLocalizerProvider;\n+\n+        public MvcDataAnnotationsLocalizationOptions()","path":"src/Microsoft.AspNetCore.Mvc.DataAnnotations/MvcDataAnnotationsLocalizationOptions.cs","position":25,"original_position":25,"commit_id":"eb65aa5c43756b61fedf7ac83e6ce5ba858c6d73","original_commit_id":"eb65aa5c43756b61fedf7ac83e6ce5ba858c6d73","user":{"login":"NTaylorMullen","id":2008729,"avatar_url":"https://avatars3.githubusercontent.com/u/2008729?v=4","gravatar_id":"","url":"https://api.github.com/users/NTaylorMullen","html_url":"https://github.com/NTaylorMullen","followers_url":"https://api.github.com/users/NTaylorMullen/followers","following_url":"https://api.github.com/users/NTaylorMullen/following{/other_user}","gists_url":"https://api.github.com/users/NTaylorMullen/gists{/gist_id}","starred_url":"https://api.github.com/users/NTaylorMullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTaylorMullen/subscriptions","organizations_url":"https://api.github.com/users/NTaylorMullen/orgs","repos_url":"https://api.github.com/users/NTaylorMullen/repos","events_url":"https://api.github.com/users/NTaylorMullen/events{/privacy}","received_events_url":"https://api.github.com/users/NTaylorMullen/received_events","type":"User","site_admin":false},"body":"Need to doc comment the ctor now.","created_at":"2018-05-25T18:14:17Z","updated_at":"2018-05-25T18:30:26Z","html_url":"https://github.com/aspnet/Mvc/pull/7812#discussion_r190972050","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/7812","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/190972050"},"html":{"href":"https://github.com/aspnet/Mvc/pull/7812#discussion_r190972050"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/7812"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/7812","id":189802417,"html_url":"https://github.com/aspnet/Mvc/pull/7812","diff_url":"https://github.com/aspnet/Mvc/pull/7812.diff","patch_url":"https://github.com/aspnet/Mvc/pull/7812.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/7812","number":7812,"state":"open","locked":false,"title":"Localize DataAnnotation enums","user":{"login":"ryanbrandenburg","id":14987221,"avatar_url":"https://avatars0.githubusercontent.com/u/14987221?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanbrandenburg","html_url":"https://github.com/ryanbrandenburg","followers_url":"https://api.github.com/users/ryanbrandenburg/followers","following_url":"https://api.github.com/users/ryanbrandenburg/following{/other_user}","gists_url":"https://api.github.com/users/ryanbrandenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbrandenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbrandenburg/subscriptions","organizations_url":"https://api.github.com/users/ryanbrandenburg/orgs","repos_url":"https://api.github.com/users/ryanbrandenburg/repos","events_url":"https://api.github.com/users/ryanbrandenburg/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbrandenburg/received_events","type":"User","site_admin":false},"body":"Fixes #7748.\r\n\r\nSince this is a breaking change it's hidden behind a compat swtich. I've included @NTaylorMullen specifically to review the compat switch/options stuff just because I don't have a lot of experience with it.\r\n\r\nOtherwise, the majority of this is test changes.","created_at":"2018-05-22T21:50:01Z","updated_at":"2018-05-25T18:30:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d27bef4d24db99e8876d05713bdcfaba9e94e733","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mkArtakMSFT","id":34246760,"avatar_url":"https://avatars3.githubusercontent.com/u/34246760?v=4","gravatar_id":"","url":"https://api.github.com/users/mkArtakMSFT","html_url":"https://github.com/mkArtakMSFT","followers_url":"https://api.github.com/users/mkArtakMSFT/followers","following_url":"https://api.github.com/users/mkArtakMSFT/following{/other_user}","gists_url":"https://api.github.com/users/mkArtakMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/mkArtakMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkArtakMSFT/subscriptions","organizations_url":"https://api.github.com/users/mkArtakMSFT/orgs","repos_url":"https://api.github.com/users/mkArtakMSFT/repos","events_url":"https://api.github.com/users/mkArtakMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/mkArtakMSFT/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/7812/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/7812/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/7812/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/eb65aa5c43756b61fedf7ac83e6ce5ba858c6d73","head":{"label":"aspnet:rybrande/EnumLocalize","ref":"rybrande/EnumLocalize","sha":"eb65aa5c43756b61fedf7ac83e6ce5ba858c6d73","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2018-05-25T10:51:01Z","pushed_at":"2018-05-24T21:53:56Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":69885,"stargazers_count":5318,"watchers_count":5318,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2085,"mirror_url":null,"archived":false,"open_issues_count":200,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2085,"open_issues":200,"watchers":5318,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"49c653ed0baf829cb91bb51bb575306c9f1ec0fa","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2018-05-25T10:51:01Z","pushed_at":"2018-05-24T21:53:56Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":69885,"stargazers_count":5318,"watchers_count":5318,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2085,"mirror_url":null,"archived":false,"open_issues_count":200,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2085,"open_issues":200,"watchers":5318,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/7812"},"html":{"href":"https://github.com/aspnet/Mvc/pull/7812"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/7812"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/7812/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/7812/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/7812/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/eb65aa5c43756b61fedf7ac83e6ce5ba858c6d73"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"NTaylorMullen"}}