{"action":"closed","issue":{"url":"https://api.github.com/repos/MicrosoftDocs/windows-ai-docs/issues/15","repository_url":"https://api.github.com/repos/MicrosoftDocs/windows-ai-docs","labels_url":"https://api.github.com/repos/MicrosoftDocs/windows-ai-docs/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/MicrosoftDocs/windows-ai-docs/issues/15/comments","events_url":"https://api.github.com/repos/MicrosoftDocs/windows-ai-docs/issues/15/events","html_url":"https://github.com/MicrosoftDocs/windows-ai-docs/issues/15","id":354953972,"node_id":"MDU6SXNzdWUzNTQ5NTM5NzI=","number":15,"title":"Minor code best practices and feedback","user":{"login":"azchohfi","id":527713,"node_id":"MDQ6VXNlcjUyNzcxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/527713?v=4","gravatar_id":"","url":"https://api.github.com/users/azchohfi","html_url":"https://github.com/azchohfi","followers_url":"https://api.github.com/users/azchohfi/followers","following_url":"https://api.github.com/users/azchohfi/following{/other_user}","gists_url":"https://api.github.com/users/azchohfi/gists{/gist_id}","starred_url":"https://api.github.com/users/azchohfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azchohfi/subscriptions","organizations_url":"https://api.github.com/users/azchohfi/orgs","repos_url":"https://api.github.com/users/azchohfi/repos","events_url":"https://api.github.com/users/azchohfi/events{/privacy}","received_events_url":"https://api.github.com/users/azchohfi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"eliotcowley","id":3965482,"node_id":"MDQ6VXNlcjM5NjU0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/3965482?v=4","gravatar_id":"","url":"https://api.github.com/users/eliotcowley","html_url":"https://github.com/eliotcowley","followers_url":"https://api.github.com/users/eliotcowley/followers","following_url":"https://api.github.com/users/eliotcowley/following{/other_user}","gists_url":"https://api.github.com/users/eliotcowley/gists{/gist_id}","starred_url":"https://api.github.com/users/eliotcowley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliotcowley/subscriptions","organizations_url":"https://api.github.com/users/eliotcowley/orgs","repos_url":"https://api.github.com/users/eliotcowley/repos","events_url":"https://api.github.com/users/eliotcowley/events{/privacy}","received_events_url":"https://api.github.com/users/eliotcowley/received_events","type":"User","site_admin":false},"assignees":[{"login":"eliotcowley","id":3965482,"node_id":"MDQ6VXNlcjM5NjU0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/3965482?v=4","gravatar_id":"","url":"https://api.github.com/users/eliotcowley","html_url":"https://github.com/eliotcowley","followers_url":"https://api.github.com/users/eliotcowley/followers","following_url":"https://api.github.com/users/eliotcowley/following{/other_user}","gists_url":"https://api.github.com/users/eliotcowley/gists{/gist_id}","starred_url":"https://api.github.com/users/eliotcowley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliotcowley/subscriptions","organizations_url":"https://api.github.com/users/eliotcowley/orgs","repos_url":"https://api.github.com/users/eliotcowley/repos","events_url":"https://api.github.com/users/eliotcowley/events{/privacy}","received_events_url":"https://api.github.com/users/eliotcowley/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-29T00:46:24Z","updated_at":"2018-09-17T17:26:38Z","closed_at":"2018-09-17T17:26:38Z","author_association":"NONE","body":"A few things that might be better explained:\n1) Why do we need to change the solution Platform to x64?\n2) Do not use async void. LoadModel method should return and Task as actually be LoadModelAsync.\n3) The initialization is redundant for 2 of the 3 variables. Initialize the variables only when needed.\n    private mnistModel ModelGen;\n    private mnistInput ModelInput;\n    private mnistOutput ModelOutput;\n4) VectorImage and ImageList variable are local. They should be lowercased.\n\n\n---\n#### Document Details\n\n⚠ *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*\n\n* ID: 4db9595e-6600-0a29-1ec5-a105bc0f1cc7\n* Version Independent ID: bdbf508e-f549-44c4-7e74-91b52cce7250\n* Content: [Create a Windows Machine Learning UWP application (C#)](https://docs.microsoft.com/en-us/windows/ai/get-started-uwp#feedback)\n* Content Source: [docs/get-started-uwp.md](https://github.com/MicrosoftDocs/windows-ai-docs/blob/master/docs/get-started-uwp.md)\n* Product: **windows**\n* GitHub Login: @serenaz\n* Microsoft Alias: **sezhen**"}}
{"actor":{"display_login":"eliotcowley"}}