{"action":"created","comment":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/comments/225301970","pull_request_review_id":164877510,"id":225301970,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTMwMTk3MA==","diff_hunk":"@@ -0,0 +1,178 @@\n+class RemoteNotificationsOperationsController {\n+    private let apiController: RemoteNotificationsAPIController\n+    private let modelController: RemoteNotificationsModelController?\n+    private let deadlineController: RemoteNotificationsOperationsDeadlineController?\n+\n+    private let syncRepeatingTime: Int = 15","path":"WMF Framework/Remote Notifications/RemoteNotificationsOperationsController.swift","position":6,"original_position":6,"commit_id":"6df1720b516084c11aaff512b22dfa0a22c23c9e","original_commit_id":"6df1720b516084c11aaff512b22dfa0a22c23c9e","user":{"login":"montehurd","id":3143487,"node_id":"MDQ6VXNlcjMxNDM0ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/3143487?v=4","gravatar_id":"","url":"https://api.github.com/users/montehurd","html_url":"https://github.com/montehurd","followers_url":"https://api.github.com/users/montehurd/followers","following_url":"https://api.github.com/users/montehurd/following{/other_user}","gists_url":"https://api.github.com/users/montehurd/gists{/gist_id}","starred_url":"https://api.github.com/users/montehurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montehurd/subscriptions","organizations_url":"https://api.github.com/users/montehurd/orgs","repos_url":"https://api.github.com/users/montehurd/repos","events_url":"https://api.github.com/users/montehurd/events{/privacy}","received_events_url":"https://api.github.com/users/montehurd/received_events","type":"User","site_admin":false},"body":"Does this mean it's still checking every 15 seconds? Oh, related, should this polling be reachability aware?","created_at":"2018-10-15T20:17:05Z","updated_at":"2018-10-15T20:17:06Z","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/2663#discussion_r225301970","pull_request_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/2663","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/comments/225301970"},"html":{"href":"https://github.com/wikimedia/wikipedia-ios/pull/2663#discussion_r225301970"},"pull_request":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/2663"}}},"pull_request":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/2663","id":218255821,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MjU1ODIx","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/2663","diff_url":"https://github.com/wikimedia/wikipedia-ios/pull/2663.diff","patch_url":"https://github.com/wikimedia/wikipedia-ios/pull/2663.patch","issue_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/2663","number":2663,"state":"open","locked":false,"title":"Edit Notifications","user":{"login":"nambatee","id":9299317,"node_id":"MDQ6VXNlcjkyOTkzMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9299317?v=4","gravatar_id":"","url":"https://api.github.com/users/nambatee","html_url":"https://github.com/nambatee","followers_url":"https://api.github.com/users/nambatee/followers","following_url":"https://api.github.com/users/nambatee/following{/other_user}","gists_url":"https://api.github.com/users/nambatee/gists{/gist_id}","starred_url":"https://api.github.com/users/nambatee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nambatee/subscriptions","organizations_url":"https://api.github.com/users/nambatee/orgs","repos_url":"https://api.github.com/users/nambatee/repos","events_url":"https://api.github.com/users/nambatee/events{/privacy}","received_events_url":"https://api.github.com/users/nambatee/received_events","type":"User","site_admin":false},"body":"Things to look out for:\r\n\r\n- Thread safety\r\n- Handling Core Data failures\r\n\r\nDoing\r\n\r\n- [x] Fetch and save notifications that appeared in the account after first authorized wikidata description edit\r\n- [x] Stop polling after 24h\r\n- [x] UI\r\n- [x] Localizations\r\n\r\nMerge after #2676 \r\n\r\nTesting:\r\n\r\nPrerequisites:\r\n1. You have to make at least one authorized (logged in) Wikidata description edit\r\n\r\nIf you have any old `reverted` notifications in your account:\r\n1. Open the affected article on the device\r\n2. Comment out age validation on line 163-165 in `RemoteNotificationsModelController`\r\n\r\nI if you don't have any old `reverted` notifications, you can use the test account in 1P ","created_at":"2018-09-26T10:00:09Z","updated_at":"2018-10-15T20:17:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b0ca39a9548214e81ebe02ed1077182e57c72e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1030107505,"node_id":"MDU6TGFiZWwxMDMwMTA3NTA1","url":"https://api.github.com/repos/wikimedia/wikipedia-ios/labels/6.1","name":"6.1","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/2663/commits","review_comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/2663/comments","review_comment_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/2663/comments","statuses_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/statuses/6df1720b516084c11aaff512b22dfa0a22c23c9e","head":{"label":"wikimedia:feature/T203167","ref":"feature/T203167","sha":"6df1720b516084c11aaff512b22dfa0a22c23c9e","user":{"login":"wikimedia","id":56668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjY4","avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":13863130,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2MzEzMA==","name":"wikipedia-ios","full_name":"wikimedia/wikipedia-ios","private":false,"owner":{"login":"wikimedia","id":56668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjY4","avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wikimedia/wikipedia-ios","description":" 📱The official Wikipedia iOS app.","fork":false,"url":"https://api.github.com/repos/wikimedia/wikipedia-ios","forks_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/forks","keys_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/teams","hooks_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/events","assignees_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/tags","blobs_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/languages","stargazers_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/subscription","commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/merges","archive_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/downloads","issues_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/releases{/id}","deployments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/deployments","created_at":"2013-10-25T14:36:56Z","updated_at":"2018-10-15T12:55:50Z","pushed_at":"2018-10-15T20:08:43Z","git_url":"git://github.com/wikimedia/wikipedia-ios.git","ssh_url":"git@github.com:wikimedia/wikipedia-ios.git","clone_url":"https://github.com/wikimedia/wikipedia-ios.git","svn_url":"https://github.com/wikimedia/wikipedia-ios","homepage":"https://www.mediawiki.org/wiki/Wikimedia_Apps","size":561042,"stargazers_count":1484,"watchers_count":1484,"language":"Objective-C","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":441,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":441,"open_issues":2,"watchers":1484,"default_branch":"develop"}},"base":{"label":"wikimedia:develop","ref":"develop","sha":"250a19264016aaca0b15263d4fa55c743d7ad596","user":{"login":"wikimedia","id":56668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjY4","avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":13863130,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2MzEzMA==","name":"wikipedia-ios","full_name":"wikimedia/wikipedia-ios","private":false,"owner":{"login":"wikimedia","id":56668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjY4","avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wikimedia/wikipedia-ios","description":" 📱The official Wikipedia iOS app.","fork":false,"url":"https://api.github.com/repos/wikimedia/wikipedia-ios","forks_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/forks","keys_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/teams","hooks_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/events","assignees_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/tags","blobs_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/languages","stargazers_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/subscription","commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/merges","archive_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/downloads","issues_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/releases{/id}","deployments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/deployments","created_at":"2013-10-25T14:36:56Z","updated_at":"2018-10-15T12:55:50Z","pushed_at":"2018-10-15T20:08:43Z","git_url":"git://github.com/wikimedia/wikipedia-ios.git","ssh_url":"git@github.com:wikimedia/wikipedia-ios.git","clone_url":"https://github.com/wikimedia/wikipedia-ios.git","svn_url":"https://github.com/wikimedia/wikipedia-ios","homepage":"https://www.mediawiki.org/wiki/Wikimedia_Apps","size":561042,"stargazers_count":1484,"watchers_count":1484,"language":"Objective-C","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":441,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":441,"open_issues":2,"watchers":1484,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/2663"},"html":{"href":"https://github.com/wikimedia/wikipedia-ios/pull/2663"},"issue":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/2663"},"comments":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/2663/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/2663/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/2663/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/statuses/6df1720b516084c11aaff512b22dfa0a22c23c9e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"montehurd"}}