{"action":"created","issue":{"url":"https://api.github.com/repos/ceeac/simutrans/issues/1","repository_url":"https://api.github.com/repos/ceeac/simutrans","labels_url":"https://api.github.com/repos/ceeac/simutrans/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/ceeac/simutrans/issues/1/comments","events_url":"https://api.github.com/repos/ceeac/simutrans/issues/1/events","html_url":"https://github.com/ceeac/simutrans/pull/1","id":374181103,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTQyNDMy","number":1,"title":"Major path overhaul","user":{"login":"dodomorandi","id":350168,"node_id":"MDQ6VXNlcjM1MDE2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/350168?v=4","gravatar_id":"","url":"https://api.github.com/users/dodomorandi","html_url":"https://github.com/dodomorandi","followers_url":"https://api.github.com/users/dodomorandi/followers","following_url":"https://api.github.com/users/dodomorandi/following{/other_user}","gists_url":"https://api.github.com/users/dodomorandi/gists{/gist_id}","starred_url":"https://api.github.com/users/dodomorandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dodomorandi/subscriptions","organizations_url":"https://api.github.com/users/dodomorandi/orgs","repos_url":"https://api.github.com/users/dodomorandi/repos","events_url":"https://api.github.com/users/dodomorandi/events{/privacy}","received_events_url":"https://api.github.com/users/dodomorandi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-26T00:19:18Z","updated_at":"2018-10-30T13:13:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ceeac/simutrans/pulls/1","html_url":"https://github.com/ceeac/simutrans/pull/1","diff_url":"https://github.com/ceeac/simutrans/pull/1.diff","patch_url":"https://github.com/ceeac/simutrans/pull/1.patch"},"body":"I really appreciated your work on porting the old building system to CMake. I think that is a big step forward in order to improve the project maintainability.\r\n\r\nSaid that, I decided to perform a path overhaul, moving every source file inside a `src` directory. I also splitted the list of files that must be compiled in a single `CMakeLists.txt` for each directory, in order to make things more easy to maintain.\r\n\r\nThere are many things left to do, but this is can be a starting point. Leave me your feedbacks!"},"comment":{"url":"https://api.github.com/repos/ceeac/simutrans/issues/comments/434295480","html_url":"https://github.com/ceeac/simutrans/pull/1#issuecomment-434295480","issue_url":"https://api.github.com/repos/ceeac/simutrans/issues/1","id":434295480,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDI5NTQ4MA==","user":{"login":"ceeac","id":28988143,"node_id":"MDQ6VXNlcjI4OTg4MTQz","avatar_url":"https://avatars3.githubusercontent.com/u/28988143?v=4","gravatar_id":"","url":"https://api.github.com/users/ceeac","html_url":"https://github.com/ceeac","followers_url":"https://api.github.com/users/ceeac/followers","following_url":"https://api.github.com/users/ceeac/following{/other_user}","gists_url":"https://api.github.com/users/ceeac/gists{/gist_id}","starred_url":"https://api.github.com/users/ceeac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceeac/subscriptions","organizations_url":"https://api.github.com/users/ceeac/orgs","repos_url":"https://api.github.com/users/ceeac/repos","events_url":"https://api.github.com/users/ceeac/events{/privacy}","received_events_url":"https://api.github.com/users/ceeac/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T13:13:58Z","updated_at":"2018-10-30T13:13:58Z","author_association":"OWNER","body":"I already did send a patch a couple of weeks ago, but iirc it was shot down because they want to keep the Makefile and VS project file based build systems, and also because CMake does not work too well on MinGW (I have not tested that myself). Also I'm not sure whether CMake 3.8 is available on all OSes Simutrans supports, so a direct replacement of all build systems is not feasible anyway."}}
{"actor":{"display_login":"ceeac"}}