{"action":"created","comment":{"url":"https://api.github.com/repos/georchestra/georchestra/pulls/comments/173097357","pull_request_review_id":102226436,"id":173097357,"diff_hunk":"@@ -519,12 +523,21 @@ private Role createRoleFromRequestBody(ServletInputStream is) throws IOException\n \t\t\t\tthrow new IllegalArgumentException(RoleSchema.COMMON_NAME_KEY + \" is required\" );\n \t\t\t}\n \n+\t\t\t// Capitalize role name and check format\n+\t\t\tcommonName = commonName.toUpperCase();\n+\t\t\tPattern p = Pattern.compile(\"[A-Z0-9_]+\");\n+\t\t\tif(!p.matcher(commonName).matches())\n+\t\t\t\tthrow new IllegalArgumentException(RoleSchema.COMMON_NAME_KEY +\n+\t\t\t\t\t\t\" must only contains upper case letter, digits and underscore\" );","path":"console/src/main/java/org/georchestra/console/ws/backoffice/roles/RolesController.java","position":49,"original_position":49,"commit_id":"0be3d9dbde743dca63b0043ab2cca503a9d1613d","original_commit_id":"0be3d9dbde743dca63b0043ab2cca503a9d1613d","user":{"login":"fvanderbiest","id":265319,"avatar_url":"https://avatars1.githubusercontent.com/u/265319?v=4","gravatar_id":"","url":"https://api.github.com/users/fvanderbiest","html_url":"https://github.com/fvanderbiest","followers_url":"https://api.github.com/users/fvanderbiest/followers","following_url":"https://api.github.com/users/fvanderbiest/following{/other_user}","gists_url":"https://api.github.com/users/fvanderbiest/gists{/gist_id}","starred_url":"https://api.github.com/users/fvanderbiest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvanderbiest/subscriptions","organizations_url":"https://api.github.com/users/fvanderbiest/orgs","repos_url":"https://api.github.com/users/fvanderbiest/repos","events_url":"https://api.github.com/users/fvanderbiest/events{/privacy}","received_events_url":"https://api.github.com/users/fvanderbiest/received_events","type":"User","site_admin":false},"body":"\"should only contain uppercased letters, digits and underscores (not leading nor ending with)\"","created_at":"2018-03-08T09:00:35Z","updated_at":"2018-03-08T09:00:35Z","html_url":"https://github.com/georchestra/georchestra/pull/1925#discussion_r173097357","pull_request_url":"https://api.github.com/repos/georchestra/georchestra/pulls/1925","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/comments/173097357"},"html":{"href":"https://github.com/georchestra/georchestra/pull/1925#discussion_r173097357"},"pull_request":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/1925"}}},"pull_request":{"url":"https://api.github.com/repos/georchestra/georchestra/pulls/1925","id":173496463,"html_url":"https://github.com/georchestra/georchestra/pull/1925","diff_url":"https://github.com/georchestra/georchestra/pull/1925.diff","patch_url":"https://github.com/georchestra/georchestra/pull/1925.patch","issue_url":"https://api.github.com/repos/georchestra/georchestra/issues/1925","number":1925,"state":"open","locked":false,"title":"Capitalize role name","user":{"login":"Vampouille","id":7067560,"avatar_url":"https://avatars1.githubusercontent.com/u/7067560?v=4","gravatar_id":"","url":"https://api.github.com/users/Vampouille","html_url":"https://github.com/Vampouille","followers_url":"https://api.github.com/users/Vampouille/followers","following_url":"https://api.github.com/users/Vampouille/following{/other_user}","gists_url":"https://api.github.com/users/Vampouille/gists{/gist_id}","starred_url":"https://api.github.com/users/Vampouille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vampouille/subscriptions","organizations_url":"https://api.github.com/users/Vampouille/orgs","repos_url":"https://api.github.com/users/Vampouille/repos","events_url":"https://api.github.com/users/Vampouille/events{/privacy}","received_events_url":"https://api.github.com/users/Vampouille/received_events","type":"User","site_admin":false},"body":"This force capitalized name for roles and check role name against following regexp : [A-Z0-9_]+","created_at":"2018-03-07T16:03:15Z","updated_at":"2018-03-08T09:00:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c284caa67c9fc453db1995fe49eabd698b65591","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/georchestra/georchestra/pulls/1925/commits","review_comments_url":"https://api.github.com/repos/georchestra/georchestra/pulls/1925/comments","review_comment_url":"https://api.github.com/repos/georchestra/georchestra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/georchestra/georchestra/issues/1925/comments","statuses_url":"https://api.github.com/repos/georchestra/georchestra/statuses/0be3d9dbde743dca63b0043ab2cca503a9d1613d","head":{"label":"Vampouille:capitalize_role","ref":"capitalize_role","sha":"0be3d9dbde743dca63b0043ab2cca503a9d1613d","user":{"login":"Vampouille","id":7067560,"avatar_url":"https://avatars1.githubusercontent.com/u/7067560?v=4","gravatar_id":"","url":"https://api.github.com/users/Vampouille","html_url":"https://github.com/Vampouille","followers_url":"https://api.github.com/users/Vampouille/followers","following_url":"https://api.github.com/users/Vampouille/following{/other_user}","gists_url":"https://api.github.com/users/Vampouille/gists{/gist_id}","starred_url":"https://api.github.com/users/Vampouille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vampouille/subscriptions","organizations_url":"https://api.github.com/users/Vampouille/orgs","repos_url":"https://api.github.com/users/Vampouille/repos","events_url":"https://api.github.com/users/Vampouille/events{/privacy}","received_events_url":"https://api.github.com/users/Vampouille/received_events","type":"User","site_admin":false},"repo":{"id":44601091,"name":"georchestra","full_name":"Vampouille/georchestra","owner":{"login":"Vampouille","id":7067560,"avatar_url":"https://avatars1.githubusercontent.com/u/7067560?v=4","gravatar_id":"","url":"https://api.github.com/users/Vampouille","html_url":"https://github.com/Vampouille","followers_url":"https://api.github.com/users/Vampouille/followers","following_url":"https://api.github.com/users/Vampouille/following{/other_user}","gists_url":"https://api.github.com/users/Vampouille/gists{/gist_id}","starred_url":"https://api.github.com/users/Vampouille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vampouille/subscriptions","organizations_url":"https://api.github.com/users/Vampouille/orgs","repos_url":"https://api.github.com/users/Vampouille/repos","events_url":"https://api.github.com/users/Vampouille/events{/privacy}","received_events_url":"https://api.github.com/users/Vampouille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vampouille/georchestra","description":"This is the main geOrchestra Spatial Data Infrastructure repository","fork":true,"url":"https://api.github.com/repos/Vampouille/georchestra","forks_url":"https://api.github.com/repos/Vampouille/georchestra/forks","keys_url":"https://api.github.com/repos/Vampouille/georchestra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vampouille/georchestra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vampouille/georchestra/teams","hooks_url":"https://api.github.com/repos/Vampouille/georchestra/hooks","issue_events_url":"https://api.github.com/repos/Vampouille/georchestra/issues/events{/number}","events_url":"https://api.github.com/repos/Vampouille/georchestra/events","assignees_url":"https://api.github.com/repos/Vampouille/georchestra/assignees{/user}","branches_url":"https://api.github.com/repos/Vampouille/georchestra/branches{/branch}","tags_url":"https://api.github.com/repos/Vampouille/georchestra/tags","blobs_url":"https://api.github.com/repos/Vampouille/georchestra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vampouille/georchestra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vampouille/georchestra/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vampouille/georchestra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vampouille/georchestra/statuses/{sha}","languages_url":"https://api.github.com/repos/Vampouille/georchestra/languages","stargazers_url":"https://api.github.com/repos/Vampouille/georchestra/stargazers","contributors_url":"https://api.github.com/repos/Vampouille/georchestra/contributors","subscribers_url":"https://api.github.com/repos/Vampouille/georchestra/subscribers","subscription_url":"https://api.github.com/repos/Vampouille/georchestra/subscription","commits_url":"https://api.github.com/repos/Vampouille/georchestra/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vampouille/georchestra/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vampouille/georchestra/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vampouille/georchestra/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vampouille/georchestra/contents/{+path}","compare_url":"https://api.github.com/repos/Vampouille/georchestra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vampouille/georchestra/merges","archive_url":"https://api.github.com/repos/Vampouille/georchestra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vampouille/georchestra/downloads","issues_url":"https://api.github.com/repos/Vampouille/georchestra/issues{/number}","pulls_url":"https://api.github.com/repos/Vampouille/georchestra/pulls{/number}","milestones_url":"https://api.github.com/repos/Vampouille/georchestra/milestones{/number}","notifications_url":"https://api.github.com/repos/Vampouille/georchestra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vampouille/georchestra/labels{/name}","releases_url":"https://api.github.com/repos/Vampouille/georchestra/releases{/id}","deployments_url":"https://api.github.com/repos/Vampouille/georchestra/deployments","created_at":"2015-10-20T11:15:11Z","updated_at":"2015-10-20T11:15:31Z","pushed_at":"2018-03-07T17:20:44Z","git_url":"git://github.com/Vampouille/georchestra.git","ssh_url":"git@github.com:Vampouille/georchestra.git","clone_url":"https://github.com/Vampouille/georchestra.git","svn_url":"https://github.com/Vampouille/georchestra","homepage":"http://www.georchestra.org/","size":236185,"stargazers_count":0,"watchers_count":0,"language":"Game Maker Language","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"15.06"}},"base":{"label":"georchestra:master","ref":"master","sha":"8021b1569bdce88ebe84b4e30ebac89ccdbd4093","user":{"login":"georchestra","id":773831,"avatar_url":"https://avatars1.githubusercontent.com/u/773831?v=4","gravatar_id":"","url":"https://api.github.com/users/georchestra","html_url":"https://github.com/georchestra","followers_url":"https://api.github.com/users/georchestra/followers","following_url":"https://api.github.com/users/georchestra/following{/other_user}","gists_url":"https://api.github.com/users/georchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/georchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georchestra/subscriptions","organizations_url":"https://api.github.com/users/georchestra/orgs","repos_url":"https://api.github.com/users/georchestra/repos","events_url":"https://api.github.com/users/georchestra/events{/privacy}","received_events_url":"https://api.github.com/users/georchestra/received_events","type":"Organization","site_admin":false},"repo":{"id":6066709,"name":"georchestra","full_name":"georchestra/georchestra","owner":{"login":"georchestra","id":773831,"avatar_url":"https://avatars1.githubusercontent.com/u/773831?v=4","gravatar_id":"","url":"https://api.github.com/users/georchestra","html_url":"https://github.com/georchestra","followers_url":"https://api.github.com/users/georchestra/followers","following_url":"https://api.github.com/users/georchestra/following{/other_user}","gists_url":"https://api.github.com/users/georchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/georchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georchestra/subscriptions","organizations_url":"https://api.github.com/users/georchestra/orgs","repos_url":"https://api.github.com/users/georchestra/repos","events_url":"https://api.github.com/users/georchestra/events{/privacy}","received_events_url":"https://api.github.com/users/georchestra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/georchestra/georchestra","description":"This is the main geOrchestra Spatial Data Infrastructure repository, which hosts the source code.","fork":false,"url":"https://api.github.com/repos/georchestra/georchestra","forks_url":"https://api.github.com/repos/georchestra/georchestra/forks","keys_url":"https://api.github.com/repos/georchestra/georchestra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georchestra/georchestra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georchestra/georchestra/teams","hooks_url":"https://api.github.com/repos/georchestra/georchestra/hooks","issue_events_url":"https://api.github.com/repos/georchestra/georchestra/issues/events{/number}","events_url":"https://api.github.com/repos/georchestra/georchestra/events","assignees_url":"https://api.github.com/repos/georchestra/georchestra/assignees{/user}","branches_url":"https://api.github.com/repos/georchestra/georchestra/branches{/branch}","tags_url":"https://api.github.com/repos/georchestra/georchestra/tags","blobs_url":"https://api.github.com/repos/georchestra/georchestra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georchestra/georchestra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georchestra/georchestra/git/refs{/sha}","trees_url":"https://api.github.com/repos/georchestra/georchestra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georchestra/georchestra/statuses/{sha}","languages_url":"https://api.github.com/repos/georchestra/georchestra/languages","stargazers_url":"https://api.github.com/repos/georchestra/georchestra/stargazers","contributors_url":"https://api.github.com/repos/georchestra/georchestra/contributors","subscribers_url":"https://api.github.com/repos/georchestra/georchestra/subscribers","subscription_url":"https://api.github.com/repos/georchestra/georchestra/subscription","commits_url":"https://api.github.com/repos/georchestra/georchestra/commits{/sha}","git_commits_url":"https://api.github.com/repos/georchestra/georchestra/git/commits{/sha}","comments_url":"https://api.github.com/repos/georchestra/georchestra/comments{/number}","issue_comment_url":"https://api.github.com/repos/georchestra/georchestra/issues/comments{/number}","contents_url":"https://api.github.com/repos/georchestra/georchestra/contents/{+path}","compare_url":"https://api.github.com/repos/georchestra/georchestra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georchestra/georchestra/merges","archive_url":"https://api.github.com/repos/georchestra/georchestra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georchestra/georchestra/downloads","issues_url":"https://api.github.com/repos/georchestra/georchestra/issues{/number}","pulls_url":"https://api.github.com/repos/georchestra/georchestra/pulls{/number}","milestones_url":"https://api.github.com/repos/georchestra/georchestra/milestones{/number}","notifications_url":"https://api.github.com/repos/georchestra/georchestra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georchestra/georchestra/labels{/name}","releases_url":"https://api.github.com/repos/georchestra/georchestra/releases{/id}","deployments_url":"https://api.github.com/repos/georchestra/georchestra/deployments","created_at":"2012-10-03T20:55:45Z","updated_at":"2018-03-04T16:17:31Z","pushed_at":"2018-03-07T18:08:04Z","git_url":"git://github.com/georchestra/georchestra.git","ssh_url":"git@github.com:georchestra/georchestra.git","clone_url":"https://github.com/georchestra/georchestra.git","svn_url":"https://github.com/georchestra/georchestra","homepage":"http://www.georchestra.org/","size":237900,"stargazers_count":44,"watchers_count":44,"language":"Game Maker Language","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":360,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":65,"open_issues":360,"watchers":44,"default_branch":"17.12"}},"_links":{"self":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/1925"},"html":{"href":"https://github.com/georchestra/georchestra/pull/1925"},"issue":{"href":"https://api.github.com/repos/georchestra/georchestra/issues/1925"},"comments":{"href":"https://api.github.com/repos/georchestra/georchestra/issues/1925/comments"},"review_comments":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/1925/comments"},"review_comment":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/1925/commits"},"statuses":{"href":"https://api.github.com/repos/georchestra/georchestra/statuses/0be3d9dbde743dca63b0043ab2cca503a9d1613d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fvanderbiest"}}