{"action":"created","comment":{"url":"https://api.github.com/repos/TYPO3/Surf/pulls/comments/191473660","pull_request_review_id":124051944,"id":191473660,"diff_hunk":"@@ -202,4 +202,15 @@ protected function ensureApplicationIsTypo3Cms(Application $application)\n                 1420210955);\n         }\n     }\n+\n+    /**\n+     * @param array $options\n+     *\n+     * @return string\n+     */\n+    protected function getCliDispatchScriptFileName(array $options = array())\n+    {\n+        $webDirectory = isset($options['webDirectory']) ? trim($options['webDirectory'], '\\\\/') : '';\n+        return $webDirectory !== '' ? sprintf('%s/typo3/cli_dispatch.phpsh', $webDirectory) : 'typo3/cli_dispatch.phpsh';","path":"src/Task/TYPO3/CMS/AbstractCliTask.php","position":13,"original_position":13,"commit_id":"12524f545c3e354c841e287bf1233d04753b3335","original_commit_id":"12524f545c3e354c841e287bf1233d04753b3335","user":{"login":"sabbelasichon","id":13050560,"avatar_url":"https://avatars3.githubusercontent.com/u/13050560?v=4","gravatar_id":"","url":"https://api.github.com/users/sabbelasichon","html_url":"https://github.com/sabbelasichon","followers_url":"https://api.github.com/users/sabbelasichon/followers","following_url":"https://api.github.com/users/sabbelasichon/following{/other_user}","gists_url":"https://api.github.com/users/sabbelasichon/gists{/gist_id}","starred_url":"https://api.github.com/users/sabbelasichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabbelasichon/subscriptions","organizations_url":"https://api.github.com/users/sabbelasichon/orgs","repos_url":"https://api.github.com/users/sabbelasichon/repos","events_url":"https://api.github.com/users/sabbelasichon/events{/privacy}","received_events_url":"https://api.github.com/users/sabbelasichon/received_events","type":"User","site_admin":false},"body":"Any quick suggestions, what we can do? I think no one is using coreapi anyway in version TYPO3 8","created_at":"2018-05-29T15:39:27Z","updated_at":"2018-05-29T15:39:27Z","html_url":"https://github.com/TYPO3/Surf/pull/153#discussion_r191473660","pull_request_url":"https://api.github.com/repos/TYPO3/Surf/pulls/153","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/TYPO3/Surf/pulls/comments/191473660"},"html":{"href":"https://github.com/TYPO3/Surf/pull/153#discussion_r191473660"},"pull_request":{"href":"https://api.github.com/repos/TYPO3/Surf/pulls/153"}},"in_reply_to_id":191470171},"pull_request":{"url":"https://api.github.com/repos/TYPO3/Surf/pulls/153","id":190554068,"html_url":"https://github.com/TYPO3/Surf/pull/153","diff_url":"https://github.com/TYPO3/Surf/pull/153.diff","patch_url":"https://github.com/TYPO3/Surf/pull/153.patch","issue_url":"https://api.github.com/repos/TYPO3/Surf/issues/153","number":153,"state":"open","locked":false,"title":"[BUGFIX] Fix wrong execution path with coreapi","user":{"login":"sabbelasichon","id":13050560,"avatar_url":"https://avatars3.githubusercontent.com/u/13050560?v=4","gravatar_id":"","url":"https://api.github.com/users/sabbelasichon","html_url":"https://github.com/sabbelasichon","followers_url":"https://api.github.com/users/sabbelasichon/followers","following_url":"https://api.github.com/users/sabbelasichon/following{/other_user}","gists_url":"https://api.github.com/users/sabbelasichon/gists{/gist_id}","starred_url":"https://api.github.com/users/sabbelasichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabbelasichon/subscriptions","organizations_url":"https://api.github.com/users/sabbelasichon/orgs","repos_url":"https://api.github.com/users/sabbelasichon/repos","events_url":"https://api.github.com/users/sabbelasichon/events{/privacy}","received_events_url":"https://api.github.com/users/sabbelasichon/received_events","type":"User","site_admin":false},"body":"- Fixes #73","created_at":"2018-05-25T11:02:28Z","updated_at":"2018-05-29T15:39:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5049366f2853c3ffaf28139eb58fee05a48d4cdb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TYPO3/Surf/pulls/153/commits","review_comments_url":"https://api.github.com/repos/TYPO3/Surf/pulls/153/comments","review_comment_url":"https://api.github.com/repos/TYPO3/Surf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TYPO3/Surf/issues/153/comments","statuses_url":"https://api.github.com/repos/TYPO3/Surf/statuses/12524f545c3e354c841e287bf1233d04753b3335","head":{"label":"TYPO3:bugfix/issue-73-take-webdirectory-into-account","ref":"bugfix/issue-73-take-webdirectory-into-account","sha":"12524f545c3e354c841e287bf1233d04753b3335","user":{"login":"TYPO3","id":88698,"avatar_url":"https://avatars0.githubusercontent.com/u/88698?v=4","gravatar_id":"","url":"https://api.github.com/users/TYPO3","html_url":"https://github.com/TYPO3","followers_url":"https://api.github.com/users/TYPO3/followers","following_url":"https://api.github.com/users/TYPO3/following{/other_user}","gists_url":"https://api.github.com/users/TYPO3/gists{/gist_id}","starred_url":"https://api.github.com/users/TYPO3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TYPO3/subscriptions","organizations_url":"https://api.github.com/users/TYPO3/orgs","repos_url":"https://api.github.com/users/TYPO3/repos","events_url":"https://api.github.com/users/TYPO3/events{/privacy}","received_events_url":"https://api.github.com/users/TYPO3/received_events","type":"Organization","site_admin":false},"repo":{"id":49432015,"name":"Surf","full_name":"TYPO3/Surf","owner":{"login":"TYPO3","id":88698,"avatar_url":"https://avatars0.githubusercontent.com/u/88698?v=4","gravatar_id":"","url":"https://api.github.com/users/TYPO3","html_url":"https://github.com/TYPO3","followers_url":"https://api.github.com/users/TYPO3/followers","following_url":"https://api.github.com/users/TYPO3/following{/other_user}","gists_url":"https://api.github.com/users/TYPO3/gists{/gist_id}","starred_url":"https://api.github.com/users/TYPO3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TYPO3/subscriptions","organizations_url":"https://api.github.com/users/TYPO3/orgs","repos_url":"https://api.github.com/users/TYPO3/repos","events_url":"https://api.github.com/users/TYPO3/events{/privacy}","received_events_url":"https://api.github.com/users/TYPO3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TYPO3/Surf","description":"Easy and powerful deployment tool","fork":false,"url":"https://api.github.com/repos/TYPO3/Surf","forks_url":"https://api.github.com/repos/TYPO3/Surf/forks","keys_url":"https://api.github.com/repos/TYPO3/Surf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TYPO3/Surf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TYPO3/Surf/teams","hooks_url":"https://api.github.com/repos/TYPO3/Surf/hooks","issue_events_url":"https://api.github.com/repos/TYPO3/Surf/issues/events{/number}","events_url":"https://api.github.com/repos/TYPO3/Surf/events","assignees_url":"https://api.github.com/repos/TYPO3/Surf/assignees{/user}","branches_url":"https://api.github.com/repos/TYPO3/Surf/branches{/branch}","tags_url":"https://api.github.com/repos/TYPO3/Surf/tags","blobs_url":"https://api.github.com/repos/TYPO3/Surf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TYPO3/Surf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TYPO3/Surf/git/refs{/sha}","trees_url":"https://api.github.com/repos/TYPO3/Surf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TYPO3/Surf/statuses/{sha}","languages_url":"https://api.github.com/repos/TYPO3/Surf/languages","stargazers_url":"https://api.github.com/repos/TYPO3/Surf/stargazers","contributors_url":"https://api.github.com/repos/TYPO3/Surf/contributors","subscribers_url":"https://api.github.com/repos/TYPO3/Surf/subscribers","subscription_url":"https://api.github.com/repos/TYPO3/Surf/subscription","commits_url":"https://api.github.com/repos/TYPO3/Surf/commits{/sha}","git_commits_url":"https://api.github.com/repos/TYPO3/Surf/git/commits{/sha}","comments_url":"https://api.github.com/repos/TYPO3/Surf/comments{/number}","issue_comment_url":"https://api.github.com/repos/TYPO3/Surf/issues/comments{/number}","contents_url":"https://api.github.com/repos/TYPO3/Surf/contents/{+path}","compare_url":"https://api.github.com/repos/TYPO3/Surf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TYPO3/Surf/merges","archive_url":"https://api.github.com/repos/TYPO3/Surf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TYPO3/Surf/downloads","issues_url":"https://api.github.com/repos/TYPO3/Surf/issues{/number}","pulls_url":"https://api.github.com/repos/TYPO3/Surf/pulls{/number}","milestones_url":"https://api.github.com/repos/TYPO3/Surf/milestones{/number}","notifications_url":"https://api.github.com/repos/TYPO3/Surf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TYPO3/Surf/labels{/name}","releases_url":"https://api.github.com/repos/TYPO3/Surf/releases{/id}","deployments_url":"https://api.github.com/repos/TYPO3/Surf/deployments","created_at":"2016-01-11T14:36:37Z","updated_at":"2018-05-27T16:39:01Z","pushed_at":"2018-05-29T15:34:17Z","git_url":"git://github.com/TYPO3/Surf.git","ssh_url":"git@github.com:TYPO3/Surf.git","clone_url":"https://github.com/TYPO3/Surf.git","svn_url":"https://github.com/TYPO3/Surf","homepage":"","size":722,"stargazers_count":57,"watchers_count":57,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":35,"open_issues":31,"watchers":57,"default_branch":"master"}},"base":{"label":"TYPO3:master","ref":"master","sha":"338db07c8eb76912987d3af0dc287d749b25bc5c","user":{"login":"TYPO3","id":88698,"avatar_url":"https://avatars0.githubusercontent.com/u/88698?v=4","gravatar_id":"","url":"https://api.github.com/users/TYPO3","html_url":"https://github.com/TYPO3","followers_url":"https://api.github.com/users/TYPO3/followers","following_url":"https://api.github.com/users/TYPO3/following{/other_user}","gists_url":"https://api.github.com/users/TYPO3/gists{/gist_id}","starred_url":"https://api.github.com/users/TYPO3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TYPO3/subscriptions","organizations_url":"https://api.github.com/users/TYPO3/orgs","repos_url":"https://api.github.com/users/TYPO3/repos","events_url":"https://api.github.com/users/TYPO3/events{/privacy}","received_events_url":"https://api.github.com/users/TYPO3/received_events","type":"Organization","site_admin":false},"repo":{"id":49432015,"name":"Surf","full_name":"TYPO3/Surf","owner":{"login":"TYPO3","id":88698,"avatar_url":"https://avatars0.githubusercontent.com/u/88698?v=4","gravatar_id":"","url":"https://api.github.com/users/TYPO3","html_url":"https://github.com/TYPO3","followers_url":"https://api.github.com/users/TYPO3/followers","following_url":"https://api.github.com/users/TYPO3/following{/other_user}","gists_url":"https://api.github.com/users/TYPO3/gists{/gist_id}","starred_url":"https://api.github.com/users/TYPO3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TYPO3/subscriptions","organizations_url":"https://api.github.com/users/TYPO3/orgs","repos_url":"https://api.github.com/users/TYPO3/repos","events_url":"https://api.github.com/users/TYPO3/events{/privacy}","received_events_url":"https://api.github.com/users/TYPO3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TYPO3/Surf","description":"Easy and powerful deployment tool","fork":false,"url":"https://api.github.com/repos/TYPO3/Surf","forks_url":"https://api.github.com/repos/TYPO3/Surf/forks","keys_url":"https://api.github.com/repos/TYPO3/Surf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TYPO3/Surf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TYPO3/Surf/teams","hooks_url":"https://api.github.com/repos/TYPO3/Surf/hooks","issue_events_url":"https://api.github.com/repos/TYPO3/Surf/issues/events{/number}","events_url":"https://api.github.com/repos/TYPO3/Surf/events","assignees_url":"https://api.github.com/repos/TYPO3/Surf/assignees{/user}","branches_url":"https://api.github.com/repos/TYPO3/Surf/branches{/branch}","tags_url":"https://api.github.com/repos/TYPO3/Surf/tags","blobs_url":"https://api.github.com/repos/TYPO3/Surf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TYPO3/Surf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TYPO3/Surf/git/refs{/sha}","trees_url":"https://api.github.com/repos/TYPO3/Surf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TYPO3/Surf/statuses/{sha}","languages_url":"https://api.github.com/repos/TYPO3/Surf/languages","stargazers_url":"https://api.github.com/repos/TYPO3/Surf/stargazers","contributors_url":"https://api.github.com/repos/TYPO3/Surf/contributors","subscribers_url":"https://api.github.com/repos/TYPO3/Surf/subscribers","subscription_url":"https://api.github.com/repos/TYPO3/Surf/subscription","commits_url":"https://api.github.com/repos/TYPO3/Surf/commits{/sha}","git_commits_url":"https://api.github.com/repos/TYPO3/Surf/git/commits{/sha}","comments_url":"https://api.github.com/repos/TYPO3/Surf/comments{/number}","issue_comment_url":"https://api.github.com/repos/TYPO3/Surf/issues/comments{/number}","contents_url":"https://api.github.com/repos/TYPO3/Surf/contents/{+path}","compare_url":"https://api.github.com/repos/TYPO3/Surf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TYPO3/Surf/merges","archive_url":"https://api.github.com/repos/TYPO3/Surf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TYPO3/Surf/downloads","issues_url":"https://api.github.com/repos/TYPO3/Surf/issues{/number}","pulls_url":"https://api.github.com/repos/TYPO3/Surf/pulls{/number}","milestones_url":"https://api.github.com/repos/TYPO3/Surf/milestones{/number}","notifications_url":"https://api.github.com/repos/TYPO3/Surf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TYPO3/Surf/labels{/name}","releases_url":"https://api.github.com/repos/TYPO3/Surf/releases{/id}","deployments_url":"https://api.github.com/repos/TYPO3/Surf/deployments","created_at":"2016-01-11T14:36:37Z","updated_at":"2018-05-27T16:39:01Z","pushed_at":"2018-05-29T15:34:17Z","git_url":"git://github.com/TYPO3/Surf.git","ssh_url":"git@github.com:TYPO3/Surf.git","clone_url":"https://github.com/TYPO3/Surf.git","svn_url":"https://github.com/TYPO3/Surf","homepage":"","size":722,"stargazers_count":57,"watchers_count":57,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":35,"open_issues":31,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TYPO3/Surf/pulls/153"},"html":{"href":"https://github.com/TYPO3/Surf/pull/153"},"issue":{"href":"https://api.github.com/repos/TYPO3/Surf/issues/153"},"comments":{"href":"https://api.github.com/repos/TYPO3/Surf/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/TYPO3/Surf/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/TYPO3/Surf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TYPO3/Surf/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/TYPO3/Surf/statuses/12524f545c3e354c841e287bf1233d04753b3335"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sabbelasichon"}}