{"action":"created","issue":{"url":"https://api.github.com/repos/projectatomic/libpod/issues/685","repository_url":"https://api.github.com/repos/projectatomic/libpod","labels_url":"https://api.github.com/repos/projectatomic/libpod/issues/685/labels{/name}","comments_url":"https://api.github.com/repos/projectatomic/libpod/issues/685/comments","events_url":"https://api.github.com/repos/projectatomic/libpod/issues/685/events","html_url":"https://github.com/projectatomic/libpod/pull/685","id":318189747,"number":685,"title":"Modify secrets pkg","user":{"login":"umohnani8","id":29377163,"avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-26T20:44:02Z","updated_at":"2018-04-26T21:19:10Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/projectatomic/libpod/pulls/685","html_url":"https://github.com/projectatomic/libpod/pull/685","diff_url":"https://github.com/projectatomic/libpod/pull/685.diff","patch_url":"https://github.com/projectatomic/libpod/pull/685.patch"},"body":"Made a mistake in my earlier patch. I though that if you add an empty string\r\nto an array, the length of the array would still be 0...\r\nRealised this when vendoring the secrets pkg into cri-o.\r\n\r\nSigned-off-by: umohnani8 <umohnani@redhat.com>"},"comment":{"url":"https://api.github.com/repos/projectatomic/libpod/issues/comments/384792265","html_url":"https://github.com/projectatomic/libpod/pull/685#issuecomment-384792265","issue_url":"https://api.github.com/repos/projectatomic/libpod/issues/685","id":384792265,"user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T21:19:10Z","updated_at":"2018-04-26T21:19:10Z","author_association":"COLLABORATOR","body":"@umohnani8 We should still add the check in `WithDefaultMountsFile` to make sure people don't accidentally set a bad value.\r\n\r\nIf using a string instead of []string makes this easier in Buildah and CRI-O, I'm fine with that."}}
{"actor":{"display_login":"mheon"}}