{"action":"created","issue":{"url":"https://api.github.com/repos/Adslot/adslot-ui/issues/713","repository_url":"https://api.github.com/repos/Adslot/adslot-ui","labels_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/713/labels{/name}","comments_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/713/comments","events_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/713/events","html_url":"https://github.com/Adslot/adslot-ui/pull/713","id":318247752,"number":713,"title":"Docs: fix outdated react version","user":{"login":"omgaz","id":908155,"avatar_url":"https://avatars3.githubusercontent.com/u/908155?v=4","gravatar_id":"","url":"https://api.github.com/users/omgaz","html_url":"https://github.com/omgaz","followers_url":"https://api.github.com/users/omgaz/followers","following_url":"https://api.github.com/users/omgaz/following{/other_user}","gists_url":"https://api.github.com/users/omgaz/gists{/gist_id}","starred_url":"https://api.github.com/users/omgaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omgaz/subscriptions","organizations_url":"https://api.github.com/users/omgaz/orgs","repos_url":"https://api.github.com/users/omgaz/repos","events_url":"https://api.github.com/users/omgaz/events{/privacy}","received_events_url":"https://api.github.com/users/omgaz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-27T01:24:59Z","updated_at":"2018-04-27T01:31:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Adslot/adslot-ui/pulls/713","html_url":"https://github.com/Adslot/adslot-ui/pull/713","diff_url":"https://github.com/Adslot/adslot-ui/pull/713.diff","patch_url":"https://github.com/Adslot/adslot-ui/pull/713.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\nThis is a docs change for for https://adslot.github.io/adslot-ui/\r\n\r\n## Description\r\n<!--- A few sentences describing the overall goals of the pull request's commit. -->\r\n\r\nWe upgraded pacakge json but not our CDN links.\r\n\r\nRemoved notepanel in favour of informationbox (one less component to maintain and dogfooding our own compontents a little more)\r\n\r\nChanged layout so example comes first\r\n\r\nAdded classname support for information box\r\n\r\nhide empty div in information box if no icon is present\r\n\r\nmade proptypes optional in prop types table and detect for 'emptyness' isntead of setting a prop.\r\n\r\n## Motivation and Background Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## Does this PR introduce a breaking change?\r\n<!--- If this PR contains a breaking change, please describe the impact and migration path for existing applications. -->\r\n\r\n- [ ] Yes\r\n- [x] No\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nDesign reviewed with pedros\r\n\r\n## Screenshots (if appropriate):\r\n\r\n![screen shot 2018-04-27 at 11 19 34](https://user-images.githubusercontent.com/908155/39339710-9322bfda-4a0d-11e8-9317-2b70992ee625.png)\r\n\r\n\r\n## Check-list:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the [Contributing](CONTRIBUTING.md) document.\r\n- [x] I've thought about and labelled my PR/commit message appropriately.\r\n- [x] If this PR introduces breaking changes I've described the impact and migration path for existing applications.\r\n- [ ] CI is green (coverage, linting, tests).\r\n- [x] I have updated the documentation accordingly.\r\n- [ ] I've two LGTMs/Approvals.\r\n- [ ] I've fixed or replied to all my code-review comments.\r\n- [x] I've manually tested with a buddy.\r\n- [x] I've squashed my commits into one.\r\n"},"comment":{"url":"https://api.github.com/repos/Adslot/adslot-ui/issues/comments/384836660","html_url":"https://github.com/Adslot/adslot-ui/pull/713#issuecomment-384836660","issue_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/713","id":384836660,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T01:31:22Z","updated_at":"2018-04-27T01:31:22Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/Adslot/adslot-ui/pull/713?src=pr&el=h1) Report\n> Merging [#713](https://codecov.io/gh/Adslot/adslot-ui/pull/713?src=pr&el=desc) into [master](https://codecov.io/gh/Adslot/adslot-ui/commit/fedf32412469ce19dbc55cb133b4991cf472e408?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/Adslot/adslot-ui/pull/713/graphs/tree.svg?src=pr&token=mtmpPqVPWF&width=650&height=150)](https://codecov.io/gh/Adslot/adslot-ui/pull/713?src=pr&el=tree)\n\n```diff\n@@          Coverage Diff          @@\n##           master   #713   +/-   ##\n=====================================\n  Coverage     100%   100%           \n=====================================\n  Files          54     54           \n  Lines         801    802    +1     \n  Branches      167    169    +2     \n=====================================\n+ Hits          801    802    +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/Adslot/adslot-ui/pull/713?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/components/adslot-ui/InformationBox/index.jsx](https://codecov.io/gh/Adslot/adslot-ui/pull/713/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvYWRzbG90LXVpL0luZm9ybWF0aW9uQm94L2luZGV4LmpzeA==) | `100% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/Adslot/adslot-ui/pull/713?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/Adslot/adslot-ui/pull/713?src=pr&el=footer). Last update [fedf324...f7cab43](https://codecov.io/gh/Adslot/adslot-ui/pull/713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}