{"action":"created","comment":{"url":"https://api.github.com/repos/apache/accumulo/pulls/comments/244779035","pull_request_review_id":188733532,"id":244779035,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDc3OTAzNQ==","diff_hunk":"@@ -724,32 +724,6 @@ public long holdTime() {\n     }\n   }\n \n-  public void close() {","path":"server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java","position":4,"original_position":4,"commit_id":"db34b013e540055b49fccf55a8ac44d13aacae8c","original_commit_id":"db34b013e540055b49fccf55a8ac44d13aacae8c","user":{"login":"keith-turner","id":1268739,"node_id":"MDQ6VXNlcjEyNjg3Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1268739?v=4","gravatar_id":"","url":"https://api.github.com/users/keith-turner","html_url":"https://github.com/keith-turner","followers_url":"https://api.github.com/users/keith-turner/followers","following_url":"https://api.github.com/users/keith-turner/following{/other_user}","gists_url":"https://api.github.com/users/keith-turner/gists{/gist_id}","starred_url":"https://api.github.com/users/keith-turner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keith-turner/subscriptions","organizations_url":"https://api.github.com/users/keith-turner/orgs","repos_url":"https://api.github.com/users/keith-turner/repos","events_url":"https://api.github.com/users/keith-turner/events{/privacy}","received_events_url":"https://api.github.com/users/keith-turner/received_events","type":"User","site_admin":false},"body":"Looking around the code, it seems one place it would make sense to call this function is in the `TabletServer.run()` function.  However I would not want to add the call there without a good understanding of how it may impact shutdown scenarios.","created_at":"2019-01-02T16:14:45Z","updated_at":"2019-01-02T16:14:45Z","html_url":"https://github.com/apache/accumulo/pull/863#discussion_r244779035","pull_request_url":"https://api.github.com/repos/apache/accumulo/pulls/863","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments/244779035"},"html":{"href":"https://github.com/apache/accumulo/pull/863#discussion_r244779035"},"pull_request":{"href":"https://api.github.com/repos/apache/accumulo/pulls/863"}},"in_reply_to_id":244637368},"pull_request":{"url":"https://api.github.com/repos/apache/accumulo/pulls/863","id":241409308,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDA5MzA4","html_url":"https://github.com/apache/accumulo/pull/863","diff_url":"https://github.com/apache/accumulo/pull/863.diff","patch_url":"https://github.com/apache/accumulo/pull/863.patch","issue_url":"https://api.github.com/repos/apache/accumulo/issues/863","number":863,"state":"open","locked":false,"title":"Remove unused tserver code","user":{"login":"milleruntime","id":11872539,"node_id":"MDQ6VXNlcjExODcyNTM5","avatar_url":"https://avatars3.githubusercontent.com/u/11872539?v=4","gravatar_id":"","url":"https://api.github.com/users/milleruntime","html_url":"https://github.com/milleruntime","followers_url":"https://api.github.com/users/milleruntime/followers","following_url":"https://api.github.com/users/milleruntime/following{/other_user}","gists_url":"https://api.github.com/users/milleruntime/gists{/gist_id}","starred_url":"https://api.github.com/users/milleruntime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milleruntime/subscriptions","organizations_url":"https://api.github.com/users/milleruntime/orgs","repos_url":"https://api.github.com/users/milleruntime/repos","events_url":"https://api.github.com/users/milleruntime/events{/privacy}","received_events_url":"https://api.github.com/users/milleruntime/received_events","type":"User","site_admin":false},"body":"Biggest changes being...\r\n* Removed unnecessary internal TabletCommiter interface - Comment about used for testing but never was.  If a test is added, it will still need to be mocked up. \r\n* Removed a few methods from SimpleMap interface.  - Not quite sure how these 2 methods are not used since they seem important but nothing calls them in any of the InMemoryMap implementations","created_at":"2018-12-28T23:23:56Z","updated_at":"2019-01-02T16:14:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2beaecea5360212627b994bdecca844022e791aa","assignee":null,"assignees":[],"requested_reviewers":[{"login":"keith-turner","id":1268739,"node_id":"MDQ6VXNlcjEyNjg3Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1268739?v=4","gravatar_id":"","url":"https://api.github.com/users/keith-turner","html_url":"https://github.com/keith-turner","followers_url":"https://api.github.com/users/keith-turner/followers","following_url":"https://api.github.com/users/keith-turner/following{/other_user}","gists_url":"https://api.github.com/users/keith-turner/gists{/gist_id}","starred_url":"https://api.github.com/users/keith-turner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keith-turner/subscriptions","organizations_url":"https://api.github.com/users/keith-turner/orgs","repos_url":"https://api.github.com/users/keith-turner/repos","events_url":"https://api.github.com/users/keith-turner/events{/privacy}","received_events_url":"https://api.github.com/users/keith-turner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":869765279,"node_id":"MDU6TGFiZWw4Njk3NjUyNzk=","url":"https://api.github.com/repos/apache/accumulo/labels/v2.0.0","name":"v2.0.0","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/accumulo/pulls/863/commits","review_comments_url":"https://api.github.com/repos/apache/accumulo/pulls/863/comments","review_comment_url":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/accumulo/issues/863/comments","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/db34b013e540055b49fccf55a8ac44d13aacae8c","head":{"label":"milleruntime:remove-unused","ref":"remove-unused","sha":"db34b013e540055b49fccf55a8ac44d13aacae8c","user":{"login":"milleruntime","id":11872539,"node_id":"MDQ6VXNlcjExODcyNTM5","avatar_url":"https://avatars3.githubusercontent.com/u/11872539?v=4","gravatar_id":"","url":"https://api.github.com/users/milleruntime","html_url":"https://github.com/milleruntime","followers_url":"https://api.github.com/users/milleruntime/followers","following_url":"https://api.github.com/users/milleruntime/following{/other_user}","gists_url":"https://api.github.com/users/milleruntime/gists{/gist_id}","starred_url":"https://api.github.com/users/milleruntime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milleruntime/subscriptions","organizations_url":"https://api.github.com/users/milleruntime/orgs","repos_url":"https://api.github.com/users/milleruntime/repos","events_url":"https://api.github.com/users/milleruntime/events{/privacy}","received_events_url":"https://api.github.com/users/milleruntime/received_events","type":"User","site_admin":false},"repo":{"id":62655047,"node_id":"MDEwOlJlcG9zaXRvcnk2MjY1NTA0Nw==","name":"accumulo","full_name":"milleruntime/accumulo","private":false,"owner":{"login":"milleruntime","id":11872539,"node_id":"MDQ6VXNlcjExODcyNTM5","avatar_url":"https://avatars3.githubusercontent.com/u/11872539?v=4","gravatar_id":"","url":"https://api.github.com/users/milleruntime","html_url":"https://github.com/milleruntime","followers_url":"https://api.github.com/users/milleruntime/followers","following_url":"https://api.github.com/users/milleruntime/following{/other_user}","gists_url":"https://api.github.com/users/milleruntime/gists{/gist_id}","starred_url":"https://api.github.com/users/milleruntime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milleruntime/subscriptions","organizations_url":"https://api.github.com/users/milleruntime/orgs","repos_url":"https://api.github.com/users/milleruntime/repos","events_url":"https://api.github.com/users/milleruntime/events{/privacy}","received_events_url":"https://api.github.com/users/milleruntime/received_events","type":"User","site_admin":false},"html_url":"https://github.com/milleruntime/accumulo","description":"Mirror of Apache Accumulo","fork":true,"url":"https://api.github.com/repos/milleruntime/accumulo","forks_url":"https://api.github.com/repos/milleruntime/accumulo/forks","keys_url":"https://api.github.com/repos/milleruntime/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milleruntime/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milleruntime/accumulo/teams","hooks_url":"https://api.github.com/repos/milleruntime/accumulo/hooks","issue_events_url":"https://api.github.com/repos/milleruntime/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/milleruntime/accumulo/events","assignees_url":"https://api.github.com/repos/milleruntime/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/milleruntime/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/milleruntime/accumulo/tags","blobs_url":"https://api.github.com/repos/milleruntime/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milleruntime/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milleruntime/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/milleruntime/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milleruntime/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/milleruntime/accumulo/languages","stargazers_url":"https://api.github.com/repos/milleruntime/accumulo/stargazers","contributors_url":"https://api.github.com/repos/milleruntime/accumulo/contributors","subscribers_url":"https://api.github.com/repos/milleruntime/accumulo/subscribers","subscription_url":"https://api.github.com/repos/milleruntime/accumulo/subscription","commits_url":"https://api.github.com/repos/milleruntime/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/milleruntime/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/milleruntime/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/milleruntime/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/milleruntime/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/milleruntime/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milleruntime/accumulo/merges","archive_url":"https://api.github.com/repos/milleruntime/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milleruntime/accumulo/downloads","issues_url":"https://api.github.com/repos/milleruntime/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/milleruntime/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/milleruntime/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/milleruntime/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milleruntime/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/milleruntime/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/milleruntime/accumulo/deployments","created_at":"2016-07-05T17:11:42Z","updated_at":"2018-12-12T22:29:54Z","pushed_at":"2018-12-31T23:11:34Z","git_url":"git://github.com/milleruntime/accumulo.git","ssh_url":"git@github.com:milleruntime/accumulo.git","clone_url":"https://github.com/milleruntime/accumulo.git","svn_url":"https://github.com/milleruntime/accumulo","homepage":"","size":66936,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"56b21ca4395b54e525850437d70e7ec28568d2b3","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2524488,"node_id":"MDEwOlJlcG9zaXRvcnkyNTI0NDg4","name":"accumulo","full_name":"apache/accumulo","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/accumulo","description":"Apache Accumulo","fork":false,"url":"https://api.github.com/repos/apache/accumulo","forks_url":"https://api.github.com/repos/apache/accumulo/forks","keys_url":"https://api.github.com/repos/apache/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/accumulo/teams","hooks_url":"https://api.github.com/repos/apache/accumulo/hooks","issue_events_url":"https://api.github.com/repos/apache/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/accumulo/events","assignees_url":"https://api.github.com/repos/apache/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/accumulo/tags","blobs_url":"https://api.github.com/repos/apache/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/accumulo/languages","stargazers_url":"https://api.github.com/repos/apache/accumulo/stargazers","contributors_url":"https://api.github.com/repos/apache/accumulo/contributors","subscribers_url":"https://api.github.com/repos/apache/accumulo/subscribers","subscription_url":"https://api.github.com/repos/apache/accumulo/subscription","commits_url":"https://api.github.com/repos/apache/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/accumulo/merges","archive_url":"https://api.github.com/repos/apache/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/accumulo/downloads","issues_url":"https://api.github.com/repos/apache/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/apache/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/apache/accumulo/deployments","created_at":"2011-10-06T07:00:09Z","updated_at":"2018-12-31T19:13:45Z","pushed_at":"2019-01-02T15:26:31Z","git_url":"git://github.com/apache/accumulo.git","ssh_url":"git@github.com:apache/accumulo.git","clone_url":"https://github.com/apache/accumulo.git","svn_url":"https://github.com/apache/accumulo","homepage":"https://accumulo.apache.org","size":66878,"stargazers_count":426,"watchers_count":426,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":237,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":237,"open_issues":94,"watchers":426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/863"},"html":{"href":"https://github.com/apache/accumulo/pull/863"},"issue":{"href":"https://api.github.com/repos/apache/accumulo/issues/863"},"comments":{"href":"https://api.github.com/repos/apache/accumulo/issues/863/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/accumulo/pulls/863/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/accumulo/pulls/863/commits"},"statuses":{"href":"https://api.github.com/repos/apache/accumulo/statuses/db34b013e540055b49fccf55a8ac44d13aacae8c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"keith-turner"}}