{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/184893142","pull_request_review_id":116176607,"id":184893142,"diff_hunk":"@@ -120,6 +120,7 @@ export class RatingBase extends BaseComponent<IRatingProps, IRatingState> {\n             key={ i }\n             { ...((i === Math.ceil(this.state.rating as number)) ? { 'data-is-current': true } : {}) }\n             onFocus={ this._onFocus.bind(this, i) }\n+            onClick={ this._onFocus.bind(this, i) } // For Safari & Firefox on OSX","path":"packages/office-ui-fabric-react/src/components/Rating/Rating.base.tsx","position":4,"original_position":4,"commit_id":"84be6f4449aed6452f7772480440b3ab90534919","original_commit_id":"84be6f4449aed6452f7772480440b3ab90534919","user":{"login":"dzearing","id":1110944,"avatar_url":"https://avatars3.githubusercontent.com/u/1110944?v=4","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},"body":"This means that when yo click, it will call _onFocus 2 times. Could you also adjust _onFocus to only do work if the value is different?","created_at":"2018-04-29T19:53:17Z","updated_at":"2018-04-29T19:53:17Z","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4696#discussion_r184893142","pull_request_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4696","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/184893142"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4696#discussion_r184893142"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4696"}}},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4696","id":184747750,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4696","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4696.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4696.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4696","number":4696,"state":"open","locked":false,"title":"Addressing Issue #3747 - Rating: Not working on OSX 10.10.5","user":{"login":"oengusmacinog","id":3977969,"avatar_url":"https://avatars3.githubusercontent.com/u/3977969?v=4","gravatar_id":"","url":"https://api.github.com/users/oengusmacinog","html_url":"https://github.com/oengusmacinog","followers_url":"https://api.github.com/users/oengusmacinog/followers","following_url":"https://api.github.com/users/oengusmacinog/following{/other_user}","gists_url":"https://api.github.com/users/oengusmacinog/gists{/gist_id}","starred_url":"https://api.github.com/users/oengusmacinog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oengusmacinog/subscriptions","organizations_url":"https://api.github.com/users/oengusmacinog/orgs","repos_url":"https://api.github.com/users/oengusmacinog/repos","events_url":"https://api.github.com/users/oengusmacinog/events{/privacy}","received_events_url":"https://api.github.com/users/oengusmacinog/received_events","type":"User","site_admin":false},"body":"#### Pull request checklist\r\n\r\n- [x] Addresses an existing issue: Fixes #3747 \r\n- [x] Include a change request file using `$ npm run change`\r\n\r\n#### Description of changes\r\n\r\nAdded onClick handler to rating star in the Rating component that calls _onFocus redundantly for support with Firefox & Safari on OSX.  Before you could not change the rating with a mouse click and the rating appeared broken - keyboard usage did work on those browsers.\r\n\r\nThe original implementation structured the control around **focus**.  This did make a nice keyboard experience where you can control the rating up and down with your arrow keys.  Most browsers seem to translate the click as a focus on that star element, so it makes sense that this solution seems like it would cover all bases, but Firefox and Safari on OSX systems only, seem to not 'focus on click'.\r\n\r\nThe simplest solution seemed to be to add an `onClick` handler that calls the same function as the `onFocus`.  Open to alternative solution ideas.\r\n","created_at":"2018-04-27T23:24:31Z","updated_at":"2018-04-29T19:53:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43cf91ca5df6eeaeb479107608392c9f4442fb10","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Jahnp","id":307118,"avatar_url":"https://avatars1.githubusercontent.com/u/307118?v=4","gravatar_id":"","url":"https://api.github.com/users/Jahnp","html_url":"https://github.com/Jahnp","followers_url":"https://api.github.com/users/Jahnp/followers","following_url":"https://api.github.com/users/Jahnp/following{/other_user}","gists_url":"https://api.github.com/users/Jahnp/gists{/gist_id}","starred_url":"https://api.github.com/users/Jahnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jahnp/subscriptions","organizations_url":"https://api.github.com/users/Jahnp/orgs","repos_url":"https://api.github.com/users/Jahnp/repos","events_url":"https://api.github.com/users/Jahnp/events{/privacy}","received_events_url":"https://api.github.com/users/Jahnp/received_events","type":"User","site_admin":false},{"login":"cschleiden","id":2201819,"avatar_url":"https://avatars2.githubusercontent.com/u/2201819?v=4","gravatar_id":"","url":"https://api.github.com/users/cschleiden","html_url":"https://github.com/cschleiden","followers_url":"https://api.github.com/users/cschleiden/followers","following_url":"https://api.github.com/users/cschleiden/following{/other_user}","gists_url":"https://api.github.com/users/cschleiden/gists{/gist_id}","starred_url":"https://api.github.com/users/cschleiden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cschleiden/subscriptions","organizations_url":"https://api.github.com/users/cschleiden/orgs","repos_url":"https://api.github.com/users/cschleiden/repos","events_url":"https://api.github.com/users/cschleiden/events{/privacy}","received_events_url":"https://api.github.com/users/cschleiden/received_events","type":"User","site_admin":false},{"login":"lambertwang","id":6496608,"avatar_url":"https://avatars1.githubusercontent.com/u/6496608?v=4","gravatar_id":"","url":"https://api.github.com/users/lambertwang","html_url":"https://github.com/lambertwang","followers_url":"https://api.github.com/users/lambertwang/followers","following_url":"https://api.github.com/users/lambertwang/following{/other_user}","gists_url":"https://api.github.com/users/lambertwang/gists{/gist_id}","starred_url":"https://api.github.com/users/lambertwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambertwang/subscriptions","organizations_url":"https://api.github.com/users/lambertwang/orgs","repos_url":"https://api.github.com/users/lambertwang/repos","events_url":"https://api.github.com/users/lambertwang/events{/privacy}","received_events_url":"https://api.github.com/users/lambertwang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4696/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4696/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4696/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/84be6f4449aed6452f7772480440b3ab90534919","head":{"label":"oengusmacinog:rating-osx-fix-3747","ref":"rating-osx-fix-3747","sha":"84be6f4449aed6452f7772480440b3ab90534919","user":{"login":"oengusmacinog","id":3977969,"avatar_url":"https://avatars3.githubusercontent.com/u/3977969?v=4","gravatar_id":"","url":"https://api.github.com/users/oengusmacinog","html_url":"https://github.com/oengusmacinog","followers_url":"https://api.github.com/users/oengusmacinog/followers","following_url":"https://api.github.com/users/oengusmacinog/following{/other_user}","gists_url":"https://api.github.com/users/oengusmacinog/gists{/gist_id}","starred_url":"https://api.github.com/users/oengusmacinog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oengusmacinog/subscriptions","organizations_url":"https://api.github.com/users/oengusmacinog/orgs","repos_url":"https://api.github.com/users/oengusmacinog/repos","events_url":"https://api.github.com/users/oengusmacinog/events{/privacy}","received_events_url":"https://api.github.com/users/oengusmacinog/received_events","type":"User","site_admin":false},"repo":{"id":117886046,"name":"office-ui-fabric-react","full_name":"oengusmacinog/office-ui-fabric-react","owner":{"login":"oengusmacinog","id":3977969,"avatar_url":"https://avatars3.githubusercontent.com/u/3977969?v=4","gravatar_id":"","url":"https://api.github.com/users/oengusmacinog","html_url":"https://github.com/oengusmacinog","followers_url":"https://api.github.com/users/oengusmacinog/followers","following_url":"https://api.github.com/users/oengusmacinog/following{/other_user}","gists_url":"https://api.github.com/users/oengusmacinog/gists{/gist_id}","starred_url":"https://api.github.com/users/oengusmacinog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oengusmacinog/subscriptions","organizations_url":"https://api.github.com/users/oengusmacinog/orgs","repos_url":"https://api.github.com/users/oengusmacinog/repos","events_url":"https://api.github.com/users/oengusmacinog/events{/privacy}","received_events_url":"https://api.github.com/users/oengusmacinog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oengusmacinog/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react","forks_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/deployments","created_at":"2018-01-17T19:59:50Z","updated_at":"2018-04-25T19:17:03Z","pushed_at":"2018-04-27T23:14:21Z","git_url":"git://github.com/oengusmacinog/office-ui-fabric-react.git","ssh_url":"git@github.com:oengusmacinog/office-ui-fabric-react.git","clone_url":"https://github.com/oengusmacinog/office-ui-fabric-react.git","svn_url":"https://github.com/oengusmacinog/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":28640,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"22f6f1bba5a5c7f15fb81b0793934d5149973493","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2018-04-29T19:51:18Z","pushed_at":"2018-04-29T19:51:09Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"git@github.com:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":28673,"stargazers_count":2561,"watchers_count":2561,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":545,"mirror_url":null,"archived":false,"open_issues_count":451,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":545,"open_issues":451,"watchers":2561,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4696"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4696"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4696"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4696/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4696/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4696/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/84be6f4449aed6452f7772480440b3ab90534919"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dzearing"}}