{"action":"created","comment":{"url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/comments/212520418","pull_request_review_id":149171621,"id":212520418,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjUyMDQxOA==","diff_hunk":"@@ -34,7 +34,13 @@ def clip(tiff_gt, tiff_arr, geom, no_data=-10000, clip_save_name='', is_clip_sav\n     #     0, tiff_arr_shape[1],\n     # ))\n     geom_pts = get_pts_in_geom(geom)\n+\n+    # get the geo-extent of the geo polygon","path":"src/clip.py","position":5,"original_position":5,"commit_id":"2bef77bd39ef69d62f19931fde2796166cec1824","original_commit_id":"2bef77bd39ef69d62f19931fde2796166cec1824","user":{"login":"lhviet","id":5140297,"node_id":"MDQ6VXNlcjUxNDAyOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5140297?v=4","gravatar_id":"","url":"https://api.github.com/users/lhviet","html_url":"https://github.com/lhviet","followers_url":"https://api.github.com/users/lhviet/followers","following_url":"https://api.github.com/users/lhviet/following{/other_user}","gists_url":"https://api.github.com/users/lhviet/gists{/gist_id}","starred_url":"https://api.github.com/users/lhviet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhviet/subscriptions","organizations_url":"https://api.github.com/users/lhviet/orgs","repos_url":"https://api.github.com/users/lhviet/repos","events_url":"https://api.github.com/users/lhviet/events{/privacy}","received_events_url":"https://api.github.com/users/lhviet/received_events","type":"User","site_admin":false},"body":"Yes, it is, I added to not need to go deep into the function to understand what it does.","created_at":"2018-08-24T04:43:55Z","updated_at":"2018-08-24T04:48:36Z","html_url":"https://github.com/angelswing-team/volume-calculator-for-dsm/pull/7#discussion_r212520418","pull_request_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/7","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/comments/212520418"},"html":{"href":"https://github.com/angelswing-team/volume-calculator-for-dsm/pull/7#discussion_r212520418"},"pull_request":{"href":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/7"}},"in_reply_to_id":212515083},"pull_request":{"url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/7","id":210631477,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjMxNDc3","html_url":"https://github.com/angelswing-team/volume-calculator-for-dsm/pull/7","diff_url":"https://github.com/angelswing-team/volume-calculator-for-dsm/pull/7.diff","patch_url":"https://github.com/angelswing-team/volume-calculator-for-dsm/pull/7.patch","issue_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/issues/7","number":7,"state":"open","locked":false,"title":"Add comments to explain the algorithm","user":{"login":"lhviet","id":5140297,"node_id":"MDQ6VXNlcjUxNDAyOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5140297?v=4","gravatar_id":"","url":"https://api.github.com/users/lhviet","html_url":"https://github.com/lhviet","followers_url":"https://api.github.com/users/lhviet/followers","following_url":"https://api.github.com/users/lhviet/following{/other_user}","gists_url":"https://api.github.com/users/lhviet/gists{/gist_id}","starred_url":"https://api.github.com/users/lhviet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhviet/subscriptions","organizations_url":"https://api.github.com/users/lhviet/orgs","repos_url":"https://api.github.com/users/lhviet/repos","events_url":"https://api.github.com/users/lhviet/events{/privacy}","received_events_url":"https://api.github.com/users/lhviet/received_events","type":"User","site_admin":false},"body":"Add more comments to the source code to help to explain the algorithm of **Clipping** and **Volume calculation**","created_at":"2018-08-24T03:41:29Z","updated_at":"2018-08-24T04:48:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1410e72969663036be22806e093b2cb91764825","assignee":{"login":"lhviet","id":5140297,"node_id":"MDQ6VXNlcjUxNDAyOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5140297?v=4","gravatar_id":"","url":"https://api.github.com/users/lhviet","html_url":"https://github.com/lhviet","followers_url":"https://api.github.com/users/lhviet/followers","following_url":"https://api.github.com/users/lhviet/following{/other_user}","gists_url":"https://api.github.com/users/lhviet/gists{/gist_id}","starred_url":"https://api.github.com/users/lhviet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhviet/subscriptions","organizations_url":"https://api.github.com/users/lhviet/orgs","repos_url":"https://api.github.com/users/lhviet/repos","events_url":"https://api.github.com/users/lhviet/events{/privacy}","received_events_url":"https://api.github.com/users/lhviet/received_events","type":"User","site_admin":false},"assignees":[{"login":"lhviet","id":5140297,"node_id":"MDQ6VXNlcjUxNDAyOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5140297?v=4","gravatar_id":"","url":"https://api.github.com/users/lhviet","html_url":"https://github.com/lhviet","followers_url":"https://api.github.com/users/lhviet/followers","following_url":"https://api.github.com/users/lhviet/following{/other_user}","gists_url":"https://api.github.com/users/lhviet/gists{/gist_id}","starred_url":"https://api.github.com/users/lhviet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhviet/subscriptions","organizations_url":"https://api.github.com/users/lhviet/orgs","repos_url":"https://api.github.com/users/lhviet/repos","events_url":"https://api.github.com/users/lhviet/events{/privacy}","received_events_url":"https://api.github.com/users/lhviet/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":911650687,"node_id":"MDU6TGFiZWw5MTE2NTA2ODc=","url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/labels/question","name":"question","color":"d876e3","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/7/commits","review_comments_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/7/comments","review_comment_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/issues/7/comments","statuses_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/statuses/2bef77bd39ef69d62f19931fde2796166cec1824","head":{"label":"lhviet:add-more-comments","ref":"add-more-comments","sha":"2bef77bd39ef69d62f19931fde2796166cec1824","user":{"login":"lhviet","id":5140297,"node_id":"MDQ6VXNlcjUxNDAyOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5140297?v=4","gravatar_id":"","url":"https://api.github.com/users/lhviet","html_url":"https://github.com/lhviet","followers_url":"https://api.github.com/users/lhviet/followers","following_url":"https://api.github.com/users/lhviet/following{/other_user}","gists_url":"https://api.github.com/users/lhviet/gists{/gist_id}","starred_url":"https://api.github.com/users/lhviet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhviet/subscriptions","organizations_url":"https://api.github.com/users/lhviet/orgs","repos_url":"https://api.github.com/users/lhviet/repos","events_url":"https://api.github.com/users/lhviet/events{/privacy}","received_events_url":"https://api.github.com/users/lhviet/received_events","type":"User","site_admin":false},"repo":{"id":144957644,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5NTc2NDQ=","name":"volume-calculator-for-dsm","full_name":"lhviet/volume-calculator-for-dsm","owner":{"login":"lhviet","id":5140297,"node_id":"MDQ6VXNlcjUxNDAyOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5140297?v=4","gravatar_id":"","url":"https://api.github.com/users/lhviet","html_url":"https://github.com/lhviet","followers_url":"https://api.github.com/users/lhviet/followers","following_url":"https://api.github.com/users/lhviet/following{/other_user}","gists_url":"https://api.github.com/users/lhviet/gists{/gist_id}","starred_url":"https://api.github.com/users/lhviet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhviet/subscriptions","organizations_url":"https://api.github.com/users/lhviet/orgs","repos_url":"https://api.github.com/users/lhviet/repos","events_url":"https://api.github.com/users/lhviet/events{/privacy}","received_events_url":"https://api.github.com/users/lhviet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lhviet/volume-calculator-for-dsm","description":"Calculating volume using GeoTiff DSM and ShapeFile","fork":true,"url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm","forks_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/forks","keys_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/teams","hooks_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/hooks","issue_events_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/issues/events{/number}","events_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/events","assignees_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/assignees{/user}","branches_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/branches{/branch}","tags_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/tags","blobs_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/git/refs{/sha}","trees_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/statuses/{sha}","languages_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/languages","stargazers_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/stargazers","contributors_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/contributors","subscribers_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/subscribers","subscription_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/subscription","commits_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/commits{/sha}","git_commits_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/git/commits{/sha}","comments_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/comments{/number}","issue_comment_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/issues/comments{/number}","contents_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/contents/{+path}","compare_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/merges","archive_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/downloads","issues_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/issues{/number}","pulls_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/pulls{/number}","milestones_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/milestones{/number}","notifications_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/labels{/name}","releases_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/releases{/id}","deployments_url":"https://api.github.com/repos/lhviet/volume-calculator-for-dsm/deployments","created_at":"2018-08-16T08:11:22Z","updated_at":"2018-08-17T04:27:56Z","pushed_at":"2018-08-24T03:39:53Z","git_url":"git://github.com/lhviet/volume-calculator-for-dsm.git","ssh_url":"git@github.com:lhviet/volume-calculator-for-dsm.git","clone_url":"https://github.com/lhviet/volume-calculator-for-dsm.git","svn_url":"https://github.com/lhviet/volume-calculator-for-dsm","homepage":null,"size":18,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angelswing-team:master","ref":"master","sha":"5134026afc70902946d8abc1c8b1eb2a72fc421e","user":{"login":"angelswing-team","id":38680800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjgwODAw","avatar_url":"https://avatars1.githubusercontent.com/u/38680800?v=4","gravatar_id":"","url":"https://api.github.com/users/angelswing-team","html_url":"https://github.com/angelswing-team","followers_url":"https://api.github.com/users/angelswing-team/followers","following_url":"https://api.github.com/users/angelswing-team/following{/other_user}","gists_url":"https://api.github.com/users/angelswing-team/gists{/gist_id}","starred_url":"https://api.github.com/users/angelswing-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelswing-team/subscriptions","organizations_url":"https://api.github.com/users/angelswing-team/orgs","repos_url":"https://api.github.com/users/angelswing-team/repos","events_url":"https://api.github.com/users/angelswing-team/events{/privacy}","received_events_url":"https://api.github.com/users/angelswing-team/received_events","type":"Organization","site_admin":false},"repo":{"id":130762660,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3NjI2NjA=","name":"volume-calculator-for-dsm","full_name":"angelswing-team/volume-calculator-for-dsm","owner":{"login":"angelswing-team","id":38680800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjgwODAw","avatar_url":"https://avatars1.githubusercontent.com/u/38680800?v=4","gravatar_id":"","url":"https://api.github.com/users/angelswing-team","html_url":"https://github.com/angelswing-team","followers_url":"https://api.github.com/users/angelswing-team/followers","following_url":"https://api.github.com/users/angelswing-team/following{/other_user}","gists_url":"https://api.github.com/users/angelswing-team/gists{/gist_id}","starred_url":"https://api.github.com/users/angelswing-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelswing-team/subscriptions","organizations_url":"https://api.github.com/users/angelswing-team/orgs","repos_url":"https://api.github.com/users/angelswing-team/repos","events_url":"https://api.github.com/users/angelswing-team/events{/privacy}","received_events_url":"https://api.github.com/users/angelswing-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angelswing-team/volume-calculator-for-dsm","description":"Calculating volume using GeoTiff DSM and ShapeFile","fork":false,"url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm","forks_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/forks","keys_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/teams","hooks_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/hooks","issue_events_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/issues/events{/number}","events_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/events","assignees_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/assignees{/user}","branches_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/branches{/branch}","tags_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/tags","blobs_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/git/refs{/sha}","trees_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/statuses/{sha}","languages_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/languages","stargazers_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/stargazers","contributors_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/contributors","subscribers_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/subscribers","subscription_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/subscription","commits_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/commits{/sha}","git_commits_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/git/commits{/sha}","comments_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/comments{/number}","issue_comment_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/issues/comments{/number}","contents_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/contents/{+path}","compare_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/merges","archive_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/downloads","issues_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/issues{/number}","pulls_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls{/number}","milestones_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/milestones{/number}","notifications_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/labels{/name}","releases_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/releases{/id}","deployments_url":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/deployments","created_at":"2018-04-23T22:10:23Z","updated_at":"2018-08-17T04:27:19Z","pushed_at":"2018-08-24T03:41:30Z","git_url":"git://github.com/angelswing-team/volume-calculator-for-dsm.git","ssh_url":"git@github.com:angelswing-team/volume-calculator-for-dsm.git","clone_url":"https://github.com/angelswing-team/volume-calculator-for-dsm.git","svn_url":"https://github.com/angelswing-team/volume-calculator-for-dsm","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/7"},"html":{"href":"https://github.com/angelswing-team/volume-calculator-for-dsm/pull/7"},"issue":{"href":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/issues/7"},"comments":{"href":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/angelswing-team/volume-calculator-for-dsm/statuses/2bef77bd39ef69d62f19931fde2796166cec1824"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lhviet"}}