{"action":"created","comment":{"url":"https://api.github.com/repos/keybase/client/pulls/comments/220320753","pull_request_review_id":158702142,"id":220320753,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDMyMDc1Mw==","diff_hunk":"@@ -384,6 +384,34 @@ func (t *Team) AllApplicationKeys(ctx context.Context, application keybase1.Team\n \treturn AllApplicationKeys(t.MetaContext(ctx), t.Data, application, t.chain().GetLatestGeneration())\n }\n \n+func (t *Team) AllApplicationKeysWithKBFS(ctx context.Context, application keybase1.TeamApplication) (res []keybase1.TeamApplicationKey, err error) {\n+\tteamKeys, err := t.AllApplicationKeys(ctx, application)\n+\tif err != nil {\n+\t\treturn res, err\n+\t}\n+\tkbfsKeys := t.KBFSCryptKeys(ctx, application)","path":"go/teams/teams.go","position":9,"original_position":9,"commit_id":"c9487a72b03f2a5bbccb8c9648baf77871a18579","original_commit_id":"c9487a72b03f2a5bbccb8c9648baf77871a18579","user":{"login":"mmaxim","id":1250314,"node_id":"MDQ6VXNlcjEyNTAzMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1250314?v=4","gravatar_id":"","url":"https://api.github.com/users/mmaxim","html_url":"https://github.com/mmaxim","followers_url":"https://api.github.com/users/mmaxim/followers","following_url":"https://api.github.com/users/mmaxim/following{/other_user}","gists_url":"https://api.github.com/users/mmaxim/gists{/gist_id}","starred_url":"https://api.github.com/users/mmaxim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmaxim/subscriptions","organizations_url":"https://api.github.com/users/mmaxim/orgs","repos_url":"https://api.github.com/users/mmaxim/repos","events_url":"https://api.github.com/users/mmaxim/events{/privacy}","received_events_url":"https://api.github.com/users/mmaxim/received_events","type":"User","site_admin":false},"body":"@maxtaco Are you ok with this update to this PR? This implements what we talked about last night.","created_at":"2018-09-25T19:15:42Z","updated_at":"2018-09-25T19:15:42Z","html_url":"https://github.com/keybase/client/pull/13875#discussion_r220320753","pull_request_url":"https://api.github.com/repos/keybase/client/pulls/13875","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/comments/220320753"},"html":{"href":"https://github.com/keybase/client/pull/13875#discussion_r220320753"},"pull_request":{"href":"https://api.github.com/repos/keybase/client/pulls/13875"}}},"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/13875","id":217404750,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDA0NzUw","html_url":"https://github.com/keybase/client/pull/13875","diff_url":"https://github.com/keybase/client/pull/13875.diff","patch_url":"https://github.com/keybase/client/pull/13875.patch","issue_url":"https://api.github.com/repos/keybase/client/issues/13875","number":13875,"state":"open","locked":false,"title":" hook up KBFS upgrade to migration CORE-8941","user":{"login":"mmaxim","id":1250314,"node_id":"MDQ6VXNlcjEyNTAzMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1250314?v=4","gravatar_id":"","url":"https://api.github.com/users/mmaxim","html_url":"https://github.com/mmaxim","followers_url":"https://api.github.com/users/mmaxim/followers","following_url":"https://api.github.com/users/mmaxim/following{/other_user}","gists_url":"https://api.github.com/users/mmaxim/gists{/gist_id}","starred_url":"https://api.github.com/users/mmaxim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmaxim/subscriptions","organizations_url":"https://api.github.com/users/mmaxim/orgs","repos_url":"https://api.github.com/users/mmaxim/repos","events_url":"https://api.github.com/users/mmaxim/events{/privacy}","received_events_url":"https://api.github.com/users/mmaxim/received_events","type":"User","site_admin":false},"body":"Hooks up KBFS to the automatic TLF upgrade process (disabled for KBFS on the server), and add a CLI command to manually upgrade TLFs.\r\n\r\ncc @strib ","created_at":"2018-09-21T21:21:34Z","updated_at":"2018-09-25T19:15:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1a136ccb7ecdd021edfe6ad41d8d5dac5ae08e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/client/pulls/13875/commits","review_comments_url":"https://api.github.com/repos/keybase/client/pulls/13875/comments","review_comment_url":"https://api.github.com/repos/keybase/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/client/issues/13875/comments","statuses_url":"https://api.github.com/repos/keybase/client/statuses/c9487a72b03f2a5bbccb8c9648baf77871a18579","head":{"label":"keybase:mike/CORE-8941","ref":"mike/CORE-8941","sha":"c9487a72b03f2a5bbccb8c9648baf77871a18579","user":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA5OTE4MQ==","name":"client","full_name":"keybase/client","private":false,"owner":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2018-09-25T18:56:42Z","pushed_at":"2018-09-25T19:13:47Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":269181,"stargazers_count":4137,"watchers_count":4137,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":403,"mirror_url":null,"archived":false,"open_issues_count":2376,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":403,"open_issues":2376,"watchers":4137,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"8570571a59ce47292f680295e0e0ca9a272214bb","user":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA5OTE4MQ==","name":"client","full_name":"keybase/client","private":false,"owner":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2018-09-25T18:56:42Z","pushed_at":"2018-09-25T19:13:47Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":269181,"stargazers_count":4137,"watchers_count":4137,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":403,"mirror_url":null,"archived":false,"open_issues_count":2376,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":403,"open_issues":2376,"watchers":4137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/13875"},"html":{"href":"https://github.com/keybase/client/pull/13875"},"issue":{"href":"https://api.github.com/repos/keybase/client/issues/13875"},"comments":{"href":"https://api.github.com/repos/keybase/client/issues/13875/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/client/pulls/13875/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/client/pulls/13875/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/client/statuses/c9487a72b03f2a5bbccb8c9648baf77871a18579"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mmaxim"}}