{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/207719784","pull_request_review_id":143394217,"id":207719784,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzcxOTc4NA==","diff_hunk":"@@ -0,0 +1,55 @@\n+// Licensed to the Apache Software Foundation (ASF) under one\n+// or more contributor license agreements.  See the NOTICE file\n+// distributed with this work for additional information\n+// regarding copyright ownership.  The ASF licenses this file\n+// to you under the Apache License, Version 2.0 (the\n+// \"License\"); you may not use this file except in compliance\n+// with the License.  You may obtain a copy of the License at\n+//\n+//   http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing,\n+// software distributed under the License is distributed on an\n+// \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+// KIND, either express or implied.  See the License for the\n+// specific language governing permissions and limitations\n+// under the License.\n+\n+#ifndef PARQUET_DECRYPTION_RETRIEVER_H\n+#define PARQUET_DECRYPTION_RETRIEVER_H\n+\n+#include <parquet/util/visibility.h>\n+#include <map>\n+#include <string>\n+\n+namespace parquet {\n+\n+class PARQUET_EXPORT DecryptionKeyRetriever {\n+ public:\n+  virtual std::string get_key(const std::string& key_metadata) = 0;\n+  virtual ~DecryptionKeyRetriever() {}\n+};\n+\n+// Simple integer key retriever\n+class PARQUET_EXPORT IntegerKeyIdRetriever : public DecryptionKeyRetriever {\n+ public:\n+  void put_key(uint32_t key_id, const std::string& key);","path":"src/parquet/decryption_key_retriever.h","position":36,"original_position":36,"commit_id":"6675c9f5a6439c4abd7f14472b060c2b8d20069c","original_commit_id":"6675c9f5a6439c4abd7f14472b060c2b8d20069c","user":{"login":"wesm","id":329591,"node_id":"MDQ6VXNlcjMyOTU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"PutKey","created_at":"2018-08-04T21:19:37Z","updated_at":"2018-08-04T21:45:36Z","html_url":"https://github.com/apache/parquet-cpp/pull/475#discussion_r207719784","pull_request_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/475","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/207719784"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/475#discussion_r207719784"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/475"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/475","id":200675444,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjc1NDQ0","html_url":"https://github.com/apache/parquet-cpp/pull/475","diff_url":"https://github.com/apache/parquet-cpp/pull/475.diff","patch_url":"https://github.com/apache/parquet-cpp/pull/475.patch","issue_url":"https://api.github.com/repos/apache/parquet-cpp/issues/475","number":475,"state":"open","locked":false,"title":"[PARQUET-1300] [C++] parquet encryption modular","user":{"login":"thamht4190","id":7070946,"node_id":"MDQ6VXNlcjcwNzA5NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/7070946?v=4","gravatar_id":"","url":"https://api.github.com/users/thamht4190","html_url":"https://github.com/thamht4190","followers_url":"https://api.github.com/users/thamht4190/followers","following_url":"https://api.github.com/users/thamht4190/following{/other_user}","gists_url":"https://api.github.com/users/thamht4190/gists{/gist_id}","starred_url":"https://api.github.com/users/thamht4190/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thamht4190/subscriptions","organizations_url":"https://api.github.com/users/thamht4190/orgs","repos_url":"https://api.github.com/users/thamht4190/repos","events_url":"https://api.github.com/users/thamht4190/events{/privacy}","received_events_url":"https://api.github.com/users/thamht4190/received_events","type":"User","site_admin":false},"body":"Hi team,\r\n\r\nI'm working on parquet encryption modular for my project. It's not completed yet (I committed changes only in properties, metadata, file/column writer), however, I want to get early feedback & review. I try to finish file/column reader and commit later. Please check and give me comments.\r\n\r\nThanks,\r\nTham\r\n","created_at":"2018-07-11T11:56:25Z","updated_at":"2018-08-04T21:45:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"432bf72100364b6259fce113e66c67daa8e78807","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/475/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/475/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/issues/475/comments","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/6675c9f5a6439c4abd7f14472b060c2b8d20069c","head":{"label":"thamht4190:p1300-parquet-encryption-modular","ref":"p1300-parquet-encryption-modular","sha":"6675c9f5a6439c4abd7f14472b060c2b8d20069c","user":{"login":"thamht4190","id":7070946,"node_id":"MDQ6VXNlcjcwNzA5NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/7070946?v=4","gravatar_id":"","url":"https://api.github.com/users/thamht4190","html_url":"https://github.com/thamht4190","followers_url":"https://api.github.com/users/thamht4190/followers","following_url":"https://api.github.com/users/thamht4190/following{/other_user}","gists_url":"https://api.github.com/users/thamht4190/gists{/gist_id}","starred_url":"https://api.github.com/users/thamht4190/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thamht4190/subscriptions","organizations_url":"https://api.github.com/users/thamht4190/orgs","repos_url":"https://api.github.com/users/thamht4190/repos","events_url":"https://api.github.com/users/thamht4190/events{/privacy}","received_events_url":"https://api.github.com/users/thamht4190/received_events","type":"User","site_admin":false},"repo":{"id":133141620,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxNDE2MjA=","name":"parquet-cpp","full_name":"thamht4190/parquet-cpp","owner":{"login":"thamht4190","id":7070946,"node_id":"MDQ6VXNlcjcwNzA5NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/7070946?v=4","gravatar_id":"","url":"https://api.github.com/users/thamht4190","html_url":"https://github.com/thamht4190","followers_url":"https://api.github.com/users/thamht4190/followers","following_url":"https://api.github.com/users/thamht4190/following{/other_user}","gists_url":"https://api.github.com/users/thamht4190/gists{/gist_id}","starred_url":"https://api.github.com/users/thamht4190/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thamht4190/subscriptions","organizations_url":"https://api.github.com/users/thamht4190/orgs","repos_url":"https://api.github.com/users/thamht4190/repos","events_url":"https://api.github.com/users/thamht4190/events{/privacy}","received_events_url":"https://api.github.com/users/thamht4190/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thamht4190/parquet-cpp","description":"Apache Parquet","fork":true,"url":"https://api.github.com/repos/thamht4190/parquet-cpp","forks_url":"https://api.github.com/repos/thamht4190/parquet-cpp/forks","keys_url":"https://api.github.com/repos/thamht4190/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thamht4190/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thamht4190/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/thamht4190/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/thamht4190/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/thamht4190/parquet-cpp/events","assignees_url":"https://api.github.com/repos/thamht4190/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/thamht4190/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/thamht4190/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/thamht4190/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thamht4190/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thamht4190/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/thamht4190/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thamht4190/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/thamht4190/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/thamht4190/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/thamht4190/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/thamht4190/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/thamht4190/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/thamht4190/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/thamht4190/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/thamht4190/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/thamht4190/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/thamht4190/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/thamht4190/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thamht4190/parquet-cpp/merges","archive_url":"https://api.github.com/repos/thamht4190/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thamht4190/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/thamht4190/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/thamht4190/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/thamht4190/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/thamht4190/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thamht4190/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/thamht4190/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/thamht4190/parquet-cpp/deployments","created_at":"2018-05-12T11:53:59Z","updated_at":"2018-05-31T06:25:04Z","pushed_at":"2018-08-03T11:56:07Z","git_url":"git://github.com/thamht4190/parquet-cpp.git","ssh_url":"git@github.com:thamht4190/parquet-cpp.git","clone_url":"https://github.com/thamht4190/parquet-cpp.git","svn_url":"https://github.com/thamht4190/parquet-cpp","homepage":"","size":2698,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a0d1669cf67b055cd7b724dea04886a0ded53c8f","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675634,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY3NTYzNA==","name":"parquet-cpp","full_name":"apache/parquet-cpp","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-cpp","description":"Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-cpp","forks_url":"https://api.github.com/repos/apache/parquet-cpp/forks","keys_url":"https://api.github.com/repos/apache/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/apache/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-cpp/events","assignees_url":"https://api.github.com/repos/apache/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/apache/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/apache/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-cpp/merges","archive_url":"https://api.github.com/repos/apache/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/apache/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/apache/parquet-cpp/deployments","created_at":"2014-06-10T07:00:07Z","updated_at":"2018-08-03T03:25:28Z","pushed_at":"2018-08-04T17:11:40Z","git_url":"git://github.com/apache/parquet-cpp.git","ssh_url":"git@github.com:apache/parquet-cpp.git","clone_url":"https://github.com/apache/parquet-cpp.git","svn_url":"https://github.com/apache/parquet-cpp","homepage":"","size":2643,"stargazers_count":240,"watchers_count":240,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":131,"open_issues":8,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/475"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/475"},"issue":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/475"},"comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/475/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/475/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/475/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-cpp/statuses/6675c9f5a6439c4abd7f14472b060c2b8d20069c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wesm"}}