{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/4131","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/4131/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/4131/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/4131/events","html_url":"https://github.com/status-im/status-react/pull/4131","id":320791337,"number":4131,"title":"Fix for versionCode conflicts when uploading to Play Store","user":{"login":"jakubgs","id":2212681,"avatar_url":"https://avatars2.githubusercontent.com/u/2212681?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubgs","html_url":"https://github.com/jakubgs","followers_url":"https://api.github.com/users/jakubgs/followers","following_url":"https://api.github.com/users/jakubgs/following{/other_user}","gists_url":"https://api.github.com/users/jakubgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubgs/subscriptions","organizations_url":"https://api.github.com/users/jakubgs/orgs","repos_url":"https://api.github.com/users/jakubgs/repos","events_url":"https://api.github.com/users/jakubgs/events{/privacy}","received_events_url":"https://api.github.com/users/jakubgs/received_events","type":"User","site_admin":false},"labels":[{"id":793864892,"url":"https://api.github.com/repos/status-im/status-react/labels/devops","name":"devops","color":"71b503","default":false}],"state":"open","locked":false,"assignee":{"login":"jakubgs","id":2212681,"avatar_url":"https://avatars2.githubusercontent.com/u/2212681?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubgs","html_url":"https://github.com/jakubgs","followers_url":"https://api.github.com/users/jakubgs/followers","following_url":"https://api.github.com/users/jakubgs/following{/other_user}","gists_url":"https://api.github.com/users/jakubgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubgs/subscriptions","organizations_url":"https://api.github.com/users/jakubgs/orgs","repos_url":"https://api.github.com/users/jakubgs/repos","events_url":"https://api.github.com/users/jakubgs/events{/privacy}","received_events_url":"https://api.github.com/users/jakubgs/received_events","type":"User","site_admin":false},"assignees":[{"login":"jakubgs","id":2212681,"avatar_url":"https://avatars2.githubusercontent.com/u/2212681?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubgs","html_url":"https://github.com/jakubgs","followers_url":"https://api.github.com/users/jakubgs/followers","following_url":"https://api.github.com/users/jakubgs/following{/other_user}","gists_url":"https://api.github.com/users/jakubgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubgs/subscriptions","organizations_url":"https://api.github.com/users/jakubgs/orgs","repos_url":"https://api.github.com/users/jakubgs/repos","events_url":"https://api.github.com/users/jakubgs/events{/privacy}","received_events_url":"https://api.github.com/users/jakubgs/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-05-07T12:47:21Z","updated_at":"2018-05-16T02:47:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/4131","html_url":"https://github.com/status-im/status-react/pull/4131","diff_url":"https://github.com/status-im/status-react/pull/4131.diff","patch_url":"https://github.com/status-im/status-react/pull/4131.patch"},"body":"### Summary:\r\nThis fixes how we manage build numbering. So far we simply used count of commits but that doesn't work when we cut custom release branches which vary in length. This can cause conflicts when uploading to Play Store, like in the following build:\r\nhttps://jenkins.status.im/job/status-react/job/upload_release/21/\r\nThis results in error:\r\n```\r\nGoogle Api Error: apkUpgradeVersionConflict: APK specifies a version code that has already been used.\r\n```\r\nThis is specifically caused by the `versionCode` app metadata set in `build.gradle`.\r\n\r\n### Review notes (optional):\r\nCurrently the script tags the current commit with a new `build-${number}` tag but does not push.\r\nThis is left to the user/automation, which right now is done after builds for both platforms succeed.\r\nMaybe a more correct approach would be to push right away, or only after we succeed in uploading, but I'm not sure.\r\n\r\n### Testing notes (optional):\r\nTry running it. It prints messages about what's happening to `stderr`.\r\n\r\n### Steps to test:\r\nRun `build_no.sh` with or without `--tag` and see what happens.\r\n\r\nstatus: wip\n\n<blockquote></blockquote>"},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/389377718","html_url":"https://github.com/status-im/status-react/pull/4131#issuecomment-389377718","issue_url":"https://api.github.com/repos/status-im/status-react/issues/4131","id":389377718,"user":{"login":"rasom","id":2364994,"avatar_url":"https://avatars2.githubusercontent.com/u/2364994?v=4","gravatar_id":"","url":"https://api.github.com/users/rasom","html_url":"https://github.com/rasom","followers_url":"https://api.github.com/users/rasom/followers","following_url":"https://api.github.com/users/rasom/following{/other_user}","gists_url":"https://api.github.com/users/rasom/gists{/gist_id}","starred_url":"https://api.github.com/users/rasom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasom/subscriptions","organizations_url":"https://api.github.com/users/rasom/orgs","repos_url":"https://api.github.com/users/rasom/repos","events_url":"https://api.github.com/users/rasom/events{/privacy}","received_events_url":"https://api.github.com/users/rasom/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T02:47:15Z","updated_at":"2018-05-16T02:47:15Z","author_association":"MEMBER","body":"apk uploaded to https://i.diawi.com/WtHgDH for branch PR-4131"}}
{"actor":{"display_login":"rasom"}}