{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/169639054","pull_request_review_id":98177022,"id":169639054,"diff_hunk":"@@ -97,17 +96,11 @@ namespace iroha {\n       model::TransactionResponse response;\n       response.tx_hash = hash(*transaction).to_string();\n       response.current_status =\n-          model::TransactionResponse::Status::STATELESS_VALIDATION_FAILED;\n+          model::TransactionResponse::Status::STATELESS_VALIDATION_SUCCESS;","path":"irohad/torii/processor/impl/transaction_processor_impl.cpp","position":17,"original_position":17,"commit_id":"7900f1417901a8746e55dd71242d17904228b835","original_commit_id":"7900f1417901a8746e55dd71242d17904228b835","user":{"login":"grimadas","id":5897440,"avatar_url":"https://avatars2.githubusercontent.com/u/5897440?v=4","gravatar_id":"","url":"https://api.github.com/users/grimadas","html_url":"https://github.com/grimadas","followers_url":"https://api.github.com/users/grimadas/followers","following_url":"https://api.github.com/users/grimadas/following{/other_user}","gists_url":"https://api.github.com/users/grimadas/gists{/gist_id}","starred_url":"https://api.github.com/users/grimadas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimadas/subscriptions","organizations_url":"https://api.github.com/users/grimadas/orgs","repos_url":"https://api.github.com/users/grimadas/repos","events_url":"https://api.github.com/users/grimadas/events{/privacy}","received_events_url":"https://api.github.com/users/grimadas/received_events","type":"User","site_admin":false},"body":"Probably this STATELESS_VALIDATION_SUCCESS is no longer relevant here, since we can answer it after builder. What about signatures, where are they checked?  Maybe add todo  here.","created_at":"2018-02-21T13:43:12Z","updated_at":"2018-02-21T13:47:03Z","html_url":"https://github.com/hyperledger/iroha/pull/995#discussion_r169639054","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/995","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/169639054"},"html":{"href":"https://github.com/hyperledger/iroha/pull/995#discussion_r169639054"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/995"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/995","id":170035001,"html_url":"https://github.com/hyperledger/iroha/pull/995","diff_url":"https://github.com/hyperledger/iroha/pull/995.diff","patch_url":"https://github.com/hyperledger/iroha/pull/995.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/995","number":995,"state":"open","locked":false,"title":"Query service update to sh-m","user":{"login":"kamilsa","id":9370151,"avatar_url":"https://avatars3.githubusercontent.com/u/9370151?v=4","gravatar_id":"","url":"https://api.github.com/users/kamilsa","html_url":"https://github.com/kamilsa","followers_url":"https://api.github.com/users/kamilsa/followers","following_url":"https://api.github.com/users/kamilsa/following{/other_user}","gists_url":"https://api.github.com/users/kamilsa/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilsa/subscriptions","organizations_url":"https://api.github.com/users/kamilsa/orgs","repos_url":"https://api.github.com/users/kamilsa/repos","events_url":"https://api.github.com/users/kamilsa/events{/privacy}","received_events_url":"https://api.github.com/users/kamilsa/received_events","type":"User","site_admin":false},"body":"Removed stateless validation from query processor and transaction processor\r\n\r\nSigned-off-by: kamilsa <kamilsa16@gmail.com>\r\n\r\n<!-- You will not see HTML commented line in Pull Request body -->\r\n<!-- Optional sections may be omitted. Just remove them or write None -->\r\n\r\n<!-- ### Requirements -->\r\n<!-- * Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. -->\r\n<!-- * All new code must have code coverage above 70% (https://docs.codecov.io/docs/about-code-coverage). -->\r\n<!-- * CircleCI builds must be passed. -->\r\n<!-- * Critical and blocker issues reported by Sorabot must be fixed. -->\r\n<!-- * Branch must be rebased onto base branch (https://soramitsu.atlassian.net/wiki/spaces/IS/pages/11173889/Rebase+and+merge+guide). -->\r\n\r\n\r\n### Description of the Change\r\n\r\nUpdates query service to use new model\r\n\r\n### Benefits\r\n\r\nNow stateless validation happens in query service\r\n\r\n### Possible Drawbacks \r\n\r\nBig parts of code were affected\r\n\r\n### Usage Examples or Tests\r\n\r\nOld tests were updated and now demonstrate use of new model in query service","created_at":"2018-02-19T19:11:54Z","updated_at":"2018-02-21T13:47:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddcd518708836f597a11efbb39c49c2540f60089","assignee":null,"assignees":[],"requested_reviewers":[{"login":"luckychess","id":3829208,"avatar_url":"https://avatars3.githubusercontent.com/u/3829208?v=4","gravatar_id":"","url":"https://api.github.com/users/luckychess","html_url":"https://github.com/luckychess","followers_url":"https://api.github.com/users/luckychess/followers","following_url":"https://api.github.com/users/luckychess/following{/other_user}","gists_url":"https://api.github.com/users/luckychess/gists{/gist_id}","starred_url":"https://api.github.com/users/luckychess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckychess/subscriptions","organizations_url":"https://api.github.com/users/luckychess/orgs","repos_url":"https://api.github.com/users/luckychess/repos","events_url":"https://api.github.com/users/luckychess/events{/privacy}","received_events_url":"https://api.github.com/users/luckychess/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/995/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/995/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/995/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/7900f1417901a8746e55dd71242d17904228b835","head":{"label":"hyperledger:feature/query_service_shared_model","ref":"feature/query_service_shared_model","sha":"7900f1417901a8746e55dd71242d17904228b835","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-02-21T13:31:45Z","pushed_at":"2018-02-21T13:30:17Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":45067,"stargazers_count":606,"watchers_count":606,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":198,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":198,"open_issues":59,"watchers":606,"default_branch":"master"}},"base":{"label":"hyperledger:feature/query_processor_shared_model","ref":"feature/query_processor_shared_model","sha":"c275ece5edfb52bf708e2706b2b0ef9904da2233","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-02-21T13:31:45Z","pushed_at":"2018-02-21T13:30:17Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":45067,"stargazers_count":606,"watchers_count":606,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":198,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":198,"open_issues":59,"watchers":606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/995"},"html":{"href":"https://github.com/hyperledger/iroha/pull/995"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/995"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/995/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/995/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/995/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/7900f1417901a8746e55dd71242d17904228b835"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"grimadas"}}