{"action":"created","comment":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments/224801875","pull_request_review_id":164261188,"id":224801875,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDgwMTg3NQ==","diff_hunk":"@@ -154,53 +197,60 @@ const Field3D Div(const Vector3D &v, CELL_LOC outloc) {\n const Field2D Div(const Vector2D &v, const Field2D &f, CELL_LOC outloc) {\n   TRACE(\"Div( Vector2D, Field2D )\");\n \n-  ASSERT1(v.getLocation() == f.getLocation());\n+  if (outloc == CELL_DEFAULT) {\n+    outloc = v.getLocation();\n+  }\n \n-  Mesh *localmesh = f.getMesh();\n+  ASSERT1(outloc != CELL_VSHIFT);\n \n+  Mesh *localmesh = f.getMesh();\n   Coordinates *metric = localmesh->coordinates(outloc);\n \n   // get contravariant components of v\n   Vector2D vcn = v;\n   vcn.toContravariant();\n \n   Field2D result(localmesh);\n-  result = FDDX(metric->J*vcn.x, f, outloc);\n-  result += FDDY(metric->J*vcn.y, f, outloc);\n-  result += FDDZ(metric->J*vcn.z, f, outloc);\n+  result = FDDX(metric->J * vcn.x, f, outloc);\n+  result += FDDY(metric->J * vcn.y, f, outloc);\n+  result += FDDZ(metric->J * vcn.z, f, outloc);","path":"src/field/vecops.cxx","position":216,"original_position":216,"commit_id":"77dd5bb4ee169b19c84f23b48bdd4c53b4bcc2b8","original_commit_id":"77dd5bb4ee169b19c84f23b48bdd4c53b4bcc2b8","user":{"login":"johnomotani","id":3958036,"node_id":"MDQ6VXNlcjM5NTgwMzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3958036?v=4","gravatar_id":"","url":"https://api.github.com/users/johnomotani","html_url":"https://github.com/johnomotani","followers_url":"https://api.github.com/users/johnomotani/followers","following_url":"https://api.github.com/users/johnomotani/following{/other_user}","gists_url":"https://api.github.com/users/johnomotani/gists{/gist_id}","starred_url":"https://api.github.com/users/johnomotani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnomotani/subscriptions","organizations_url":"https://api.github.com/users/johnomotani/orgs","repos_url":"https://api.github.com/users/johnomotani/repos","events_url":"https://api.github.com/users/johnomotani/events{/privacy}","received_events_url":"https://api.github.com/users/johnomotani/received_events","type":"User","site_admin":false},"body":"locations of `J` again.","created_at":"2018-10-12T14:24:25Z","updated_at":"2018-10-12T14:50:41Z","html_url":"https://github.com/boutproject/BOUT-dev/pull/1293#discussion_r224801875","pull_request_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1293","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments/224801875"},"html":{"href":"https://github.com/boutproject/BOUT-dev/pull/1293#discussion_r224801875"},"pull_request":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1293"}}},"pull_request":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1293","id":219993148,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTkzMTQ4","html_url":"https://github.com/boutproject/BOUT-dev/pull/1293","diff_url":"https://github.com/boutproject/BOUT-dev/pull/1293.diff","patch_url":"https://github.com/boutproject/BOUT-dev/pull/1293.patch","issue_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1293","number":1293,"state":"open","locked":false,"title":"Use input field/vector location for CELL_DEFAULT in vecops","user":{"login":"ZedThree","id":1486942,"node_id":"MDQ6VXNlcjE0ODY5NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1486942?v=4","gravatar_id":"","url":"https://api.github.com/users/ZedThree","html_url":"https://github.com/ZedThree","followers_url":"https://api.github.com/users/ZedThree/followers","following_url":"https://api.github.com/users/ZedThree/following{/other_user}","gists_url":"https://api.github.com/users/ZedThree/gists{/gist_id}","starred_url":"https://api.github.com/users/ZedThree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZedThree/subscriptions","organizations_url":"https://api.github.com/users/ZedThree/orgs","repos_url":"https://api.github.com/users/ZedThree/repos","events_url":"https://api.github.com/users/ZedThree/events{/privacy}","received_events_url":"https://api.github.com/users/ZedThree/received_events","type":"User","site_admin":false},"body":"Some operations used `CELL_DEFAULT` to mean `CELL_CENTRE`, others used it to mean use the input field/vector location, others didn't handle it at all. Now all vector operations use it to mean use the input field/vector location.","created_at":"2018-10-03T10:52:21Z","updated_at":"2018-10-12T14:50:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"241c6eeecaaafafd4692252cb3f89247b4532d90","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones/8","html_url":"https://github.com/boutproject/BOUT-dev/milestone/8","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones/8/labels","id":2785082,"node_id":"MDk6TWlsZXN0b25lMjc4NTA4Mg==","number":8,"title":"BOUT-4.2","description":null,"creator":{"login":"ZedThree","id":1486942,"node_id":"MDQ6VXNlcjE0ODY5NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1486942?v=4","gravatar_id":"","url":"https://api.github.com/users/ZedThree","html_url":"https://github.com/ZedThree","followers_url":"https://api.github.com/users/ZedThree/followers","following_url":"https://api.github.com/users/ZedThree/following{/other_user}","gists_url":"https://api.github.com/users/ZedThree/gists{/gist_id}","starred_url":"https://api.github.com/users/ZedThree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZedThree/subscriptions","organizations_url":"https://api.github.com/users/ZedThree/orgs","repos_url":"https://api.github.com/users/ZedThree/repos","events_url":"https://api.github.com/users/ZedThree/events{/privacy}","received_events_url":"https://api.github.com/users/ZedThree/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":35,"state":"open","created_at":"2017-09-22T11:26:04Z","updated_at":"2018-10-12T14:40:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1293/commits","review_comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1293/comments","review_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1293/comments","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/77dd5bb4ee169b19c84f23b48bdd4c53b4bcc2b8","head":{"label":"boutproject:vecops-consistent-cell-default","ref":"vecops-consistent-cell-default","sha":"77dd5bb4ee169b19c84f23b48bdd4c53b4bcc2b8","user":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"repo":{"id":12783634,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4MzYzNA==","name":"BOUT-dev","full_name":"boutproject/BOUT-dev","private":false,"owner":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/boutproject/BOUT-dev","description":"BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems","fork":false,"url":"https://api.github.com/repos/boutproject/BOUT-dev","forks_url":"https://api.github.com/repos/boutproject/BOUT-dev/forks","keys_url":"https://api.github.com/repos/boutproject/BOUT-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boutproject/BOUT-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boutproject/BOUT-dev/teams","hooks_url":"https://api.github.com/repos/boutproject/BOUT-dev/hooks","issue_events_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/events{/number}","events_url":"https://api.github.com/repos/boutproject/BOUT-dev/events","assignees_url":"https://api.github.com/repos/boutproject/BOUT-dev/assignees{/user}","branches_url":"https://api.github.com/repos/boutproject/BOUT-dev/branches{/branch}","tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/tags","blobs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/boutproject/BOUT-dev/languages","stargazers_url":"https://api.github.com/repos/boutproject/BOUT-dev/stargazers","contributors_url":"https://api.github.com/repos/boutproject/BOUT-dev/contributors","subscribers_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscribers","subscription_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscription","commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/boutproject/BOUT-dev/contents/{+path}","compare_url":"https://api.github.com/repos/boutproject/BOUT-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boutproject/BOUT-dev/merges","archive_url":"https://api.github.com/repos/boutproject/BOUT-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boutproject/BOUT-dev/downloads","issues_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues{/number}","pulls_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/boutproject/BOUT-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/labels{/name}","releases_url":"https://api.github.com/repos/boutproject/BOUT-dev/releases{/id}","deployments_url":"https://api.github.com/repos/boutproject/BOUT-dev/deployments","created_at":"2013-09-12T12:57:55Z","updated_at":"2018-10-10T15:32:49Z","pushed_at":"2018-10-12T14:40:31Z","git_url":"git://github.com/boutproject/BOUT-dev.git","ssh_url":"git@github.com:boutproject/BOUT-dev.git","clone_url":"https://github.com/boutproject/BOUT-dev.git","svn_url":"https://github.com/boutproject/BOUT-dev","homepage":"http://boutproject.github.io/","size":42975,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":157,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":157,"watchers":28,"default_branch":"master"}},"base":{"label":"boutproject:v4.2-rc","ref":"v4.2-rc","sha":"cbd4da380783a03451e1e826970428dfe99dd394","user":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"repo":{"id":12783634,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4MzYzNA==","name":"BOUT-dev","full_name":"boutproject/BOUT-dev","private":false,"owner":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/boutproject/BOUT-dev","description":"BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems","fork":false,"url":"https://api.github.com/repos/boutproject/BOUT-dev","forks_url":"https://api.github.com/repos/boutproject/BOUT-dev/forks","keys_url":"https://api.github.com/repos/boutproject/BOUT-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boutproject/BOUT-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boutproject/BOUT-dev/teams","hooks_url":"https://api.github.com/repos/boutproject/BOUT-dev/hooks","issue_events_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/events{/number}","events_url":"https://api.github.com/repos/boutproject/BOUT-dev/events","assignees_url":"https://api.github.com/repos/boutproject/BOUT-dev/assignees{/user}","branches_url":"https://api.github.com/repos/boutproject/BOUT-dev/branches{/branch}","tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/tags","blobs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/boutproject/BOUT-dev/languages","stargazers_url":"https://api.github.com/repos/boutproject/BOUT-dev/stargazers","contributors_url":"https://api.github.com/repos/boutproject/BOUT-dev/contributors","subscribers_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscribers","subscription_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscription","commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/boutproject/BOUT-dev/contents/{+path}","compare_url":"https://api.github.com/repos/boutproject/BOUT-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boutproject/BOUT-dev/merges","archive_url":"https://api.github.com/repos/boutproject/BOUT-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boutproject/BOUT-dev/downloads","issues_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues{/number}","pulls_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/boutproject/BOUT-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/labels{/name}","releases_url":"https://api.github.com/repos/boutproject/BOUT-dev/releases{/id}","deployments_url":"https://api.github.com/repos/boutproject/BOUT-dev/deployments","created_at":"2013-09-12T12:57:55Z","updated_at":"2018-10-10T15:32:49Z","pushed_at":"2018-10-12T14:40:31Z","git_url":"git://github.com/boutproject/BOUT-dev.git","ssh_url":"git@github.com:boutproject/BOUT-dev.git","clone_url":"https://github.com/boutproject/BOUT-dev.git","svn_url":"https://github.com/boutproject/BOUT-dev","homepage":"http://boutproject.github.io/","size":42975,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":157,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":157,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1293"},"html":{"href":"https://github.com/boutproject/BOUT-dev/pull/1293"},"issue":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1293"},"comments":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1293/comments"},"review_comments":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1293/comments"},"review_comment":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1293/commits"},"statuses":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/77dd5bb4ee169b19c84f23b48bdd4c53b4bcc2b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"johnomotani"}}