{"action":"created","comment":{"url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments/222505758","pull_request_review_id":161404178,"id":222505758,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjUwNTc1OA==","diff_hunk":"@@ -0,0 +1,48 @@\n+import inspect\n+import os\n+\n+from pandas import Timestamp, DatetimeIndex\n+from pandas.util.testing import network\n+\n+from pvlib.iotools import surfrad\n+\n+test_dir = os.path.dirname(\n+    os.path.abspath(inspect.getfile(inspect.currentframe())))\n+testfile = os.path.join(test_dir, '../data/surfrad-slv16001.dat')\n+network_testfile = ('ftp://aftp.cmdl.noaa.gov/data/radiation/surfrad/'\n+                    'Alamosa_CO/2016/slv16001.dat')\n+\n+\n+def test_read_surfrad():","path":"pvlib/test/test_surfrad.py","position":16,"original_position":16,"commit_id":"07d1b6c23a3da427e3e6cb3924626d57a73a9510","original_commit_id":"07d1b6c23a3da427e3e6cb3924626d57a73a9510","user":{"login":"wholmgren","id":4383303,"node_id":"MDQ6VXNlcjQzODMzMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/4383303?v=4","gravatar_id":"","url":"https://api.github.com/users/wholmgren","html_url":"https://github.com/wholmgren","followers_url":"https://api.github.com/users/wholmgren/followers","following_url":"https://api.github.com/users/wholmgren/following{/other_user}","gists_url":"https://api.github.com/users/wholmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/wholmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wholmgren/subscriptions","organizations_url":"https://api.github.com/users/wholmgren/orgs","repos_url":"https://api.github.com/users/wholmgren/repos","events_url":"https://api.github.com/users/wholmgren/events{/privacy}","received_events_url":"https://api.github.com/users/wholmgren/received_events","type":"User","site_admin":false},"body":"sorry for setting a bad example in `test_tmy.py`","created_at":"2018-10-04T00:15:05Z","updated_at":"2018-10-04T00:29:13Z","html_url":"https://github.com/pvlib/pvlib-python/pull/595#discussion_r222505758","pull_request_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/595","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments/222505758"},"html":{"href":"https://github.com/pvlib/pvlib-python/pull/595#discussion_r222505758"},"pull_request":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/595"}},"in_reply_to_id":222505697},"pull_request":{"url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/595","id":219874485,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODc0NDg1","html_url":"https://github.com/pvlib/pvlib-python/pull/595","diff_url":"https://github.com/pvlib/pvlib-python/pull/595.diff","patch_url":"https://github.com/pvlib/pvlib-python/pull/595.patch","issue_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/595","number":595,"state":"open","locked":false,"title":"Surfrad data reader","user":{"login":"lboeman","id":21206164,"node_id":"MDQ6VXNlcjIxMjA2MTY0","avatar_url":"https://avatars0.githubusercontent.com/u/21206164?v=4","gravatar_id":"","url":"https://api.github.com/users/lboeman","html_url":"https://github.com/lboeman","followers_url":"https://api.github.com/users/lboeman/followers","following_url":"https://api.github.com/users/lboeman/following{/other_user}","gists_url":"https://api.github.com/users/lboeman/gists{/gist_id}","starred_url":"https://api.github.com/users/lboeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lboeman/subscriptions","organizations_url":"https://api.github.com/users/lboeman/orgs","repos_url":"https://api.github.com/users/lboeman/repos","events_url":"https://api.github.com/users/lboeman/events{/privacy}","received_events_url":"https://api.github.com/users/lboeman/received_events","type":"User","site_admin":false},"body":"pvlib python pull request guidelines\r\n====================================\r\n\r\nThank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.\r\n\r\nYou may submit a pull request with your code at any stage of completion.\r\n\r\nThe following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:\r\n\r\n - [x] Closes #590\r\n - [x] I am familiar with the [contributing guidelines](http://pvlib-python.readthedocs.io/en/latest/contributing.html).\r\n - [x] Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.\r\n - [x] Updates entries to `docs/sphinx/source/api.rst` for API changes.\r\n - [x] Adds description and name entries in the appropriate `docs/sphinx/source/whatsnew` file for all changes.\r\n - [x] Code quality and style is sufficient. Passes LGTM and SticklerCI checks.\r\n - [x] New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.\r\n - [x] Pull request is nearly complete and ready for detailed review.\r\n\r\nBrief description of the problem and proposed solution (if not already fully described in the issue linked to above):\r\n","created_at":"2018-10-02T23:24:33Z","updated_at":"2018-10-04T00:29:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20f1ced95a3ea900a72d9c920831e625a17ad9f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":177800479,"node_id":"MDU6TGFiZWwxNzc4MDA0Nzk=","url":"https://api.github.com/repos/pvlib/pvlib-python/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":1065226181,"node_id":"MDU6TGFiZWwxMDY1MjI2MTgx","url":"https://api.github.com/repos/pvlib/pvlib-python/labels/io","name":"io","color":"f2b5e1","default":false},{"id":1065216627,"node_id":"MDU6TGFiZWwxMDY1MjE2NjI3","url":"https://api.github.com/repos/pvlib/pvlib-python/labels/solarfx2","name":"solarfx2","color":"60a5bc","default":false}],"milestone":{"url":"https://api.github.com/repos/pvlib/pvlib-python/milestones/22","html_url":"https://github.com/pvlib/pvlib-python/milestone/22","labels_url":"https://api.github.com/repos/pvlib/pvlib-python/milestones/22/labels","id":3333501,"node_id":"MDk6TWlsZXN0b25lMzMzMzUwMQ==","number":22,"title":"0.6.1","description":"","creator":{"login":"wholmgren","id":4383303,"node_id":"MDQ6VXNlcjQzODMzMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/4383303?v=4","gravatar_id":"","url":"https://api.github.com/users/wholmgren","html_url":"https://github.com/wholmgren","followers_url":"https://api.github.com/users/wholmgren/followers","following_url":"https://api.github.com/users/wholmgren/following{/other_user}","gists_url":"https://api.github.com/users/wholmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/wholmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wholmgren/subscriptions","organizations_url":"https://api.github.com/users/wholmgren/orgs","repos_url":"https://api.github.com/users/wholmgren/repos","events_url":"https://api.github.com/users/wholmgren/events{/privacy}","received_events_url":"https://api.github.com/users/wholmgren/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":6,"state":"open","created_at":"2018-05-09T15:16:47Z","updated_at":"2018-10-02T23:41:20Z","due_on":"2018-07-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/595/commits","review_comments_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/595/comments","review_comment_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/595/comments","statuses_url":"https://api.github.com/repos/pvlib/pvlib-python/statuses/07d1b6c23a3da427e3e6cb3924626d57a73a9510","head":{"label":"lboeman:surfrad","ref":"surfrad","sha":"07d1b6c23a3da427e3e6cb3924626d57a73a9510","user":{"login":"lboeman","id":21206164,"node_id":"MDQ6VXNlcjIxMjA2MTY0","avatar_url":"https://avatars0.githubusercontent.com/u/21206164?v=4","gravatar_id":"","url":"https://api.github.com/users/lboeman","html_url":"https://github.com/lboeman","followers_url":"https://api.github.com/users/lboeman/followers","following_url":"https://api.github.com/users/lboeman/following{/other_user}","gists_url":"https://api.github.com/users/lboeman/gists{/gist_id}","starred_url":"https://api.github.com/users/lboeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lboeman/subscriptions","organizations_url":"https://api.github.com/users/lboeman/orgs","repos_url":"https://api.github.com/users/lboeman/repos","events_url":"https://api.github.com/users/lboeman/events{/privacy}","received_events_url":"https://api.github.com/users/lboeman/received_events","type":"User","site_admin":false},"repo":{"id":149522755,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk1MjI3NTU=","name":"pvlib-python","full_name":"lboeman/pvlib-python","private":false,"owner":{"login":"lboeman","id":21206164,"node_id":"MDQ6VXNlcjIxMjA2MTY0","avatar_url":"https://avatars0.githubusercontent.com/u/21206164?v=4","gravatar_id":"","url":"https://api.github.com/users/lboeman","html_url":"https://github.com/lboeman","followers_url":"https://api.github.com/users/lboeman/followers","following_url":"https://api.github.com/users/lboeman/following{/other_user}","gists_url":"https://api.github.com/users/lboeman/gists{/gist_id}","starred_url":"https://api.github.com/users/lboeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lboeman/subscriptions","organizations_url":"https://api.github.com/users/lboeman/orgs","repos_url":"https://api.github.com/users/lboeman/repos","events_url":"https://api.github.com/users/lboeman/events{/privacy}","received_events_url":"https://api.github.com/users/lboeman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lboeman/pvlib-python","description":"A set of documented functions for simulating the performance of photovoltaic energy systems.","fork":true,"url":"https://api.github.com/repos/lboeman/pvlib-python","forks_url":"https://api.github.com/repos/lboeman/pvlib-python/forks","keys_url":"https://api.github.com/repos/lboeman/pvlib-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lboeman/pvlib-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lboeman/pvlib-python/teams","hooks_url":"https://api.github.com/repos/lboeman/pvlib-python/hooks","issue_events_url":"https://api.github.com/repos/lboeman/pvlib-python/issues/events{/number}","events_url":"https://api.github.com/repos/lboeman/pvlib-python/events","assignees_url":"https://api.github.com/repos/lboeman/pvlib-python/assignees{/user}","branches_url":"https://api.github.com/repos/lboeman/pvlib-python/branches{/branch}","tags_url":"https://api.github.com/repos/lboeman/pvlib-python/tags","blobs_url":"https://api.github.com/repos/lboeman/pvlib-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lboeman/pvlib-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lboeman/pvlib-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/lboeman/pvlib-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lboeman/pvlib-python/statuses/{sha}","languages_url":"https://api.github.com/repos/lboeman/pvlib-python/languages","stargazers_url":"https://api.github.com/repos/lboeman/pvlib-python/stargazers","contributors_url":"https://api.github.com/repos/lboeman/pvlib-python/contributors","subscribers_url":"https://api.github.com/repos/lboeman/pvlib-python/subscribers","subscription_url":"https://api.github.com/repos/lboeman/pvlib-python/subscription","commits_url":"https://api.github.com/repos/lboeman/pvlib-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/lboeman/pvlib-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/lboeman/pvlib-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/lboeman/pvlib-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/lboeman/pvlib-python/contents/{+path}","compare_url":"https://api.github.com/repos/lboeman/pvlib-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lboeman/pvlib-python/merges","archive_url":"https://api.github.com/repos/lboeman/pvlib-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lboeman/pvlib-python/downloads","issues_url":"https://api.github.com/repos/lboeman/pvlib-python/issues{/number}","pulls_url":"https://api.github.com/repos/lboeman/pvlib-python/pulls{/number}","milestones_url":"https://api.github.com/repos/lboeman/pvlib-python/milestones{/number}","notifications_url":"https://api.github.com/repos/lboeman/pvlib-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lboeman/pvlib-python/labels{/name}","releases_url":"https://api.github.com/repos/lboeman/pvlib-python/releases{/id}","deployments_url":"https://api.github.com/repos/lboeman/pvlib-python/deployments","created_at":"2018-09-19T23:14:18Z","updated_at":"2018-10-02T19:11:59Z","pushed_at":"2018-10-03T19:42:31Z","git_url":"git://github.com/lboeman/pvlib-python.git","ssh_url":"git@github.com:lboeman/pvlib-python.git","clone_url":"https://github.com/lboeman/pvlib-python.git","svn_url":"https://github.com/lboeman/pvlib-python","homepage":"http://pvlib-python.readthedocs.io/en/latest/","size":88700,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pvlib:master","ref":"master","sha":"bc80cbf1c134127ae94623b0f1cc9c3a942fdd84","user":{"login":"pvlib","id":11037261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDM3MjYx","avatar_url":"https://avatars3.githubusercontent.com/u/11037261?v=4","gravatar_id":"","url":"https://api.github.com/users/pvlib","html_url":"https://github.com/pvlib","followers_url":"https://api.github.com/users/pvlib/followers","following_url":"https://api.github.com/users/pvlib/following{/other_user}","gists_url":"https://api.github.com/users/pvlib/gists{/gist_id}","starred_url":"https://api.github.com/users/pvlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvlib/subscriptions","organizations_url":"https://api.github.com/users/pvlib/orgs","repos_url":"https://api.github.com/users/pvlib/repos","events_url":"https://api.github.com/users/pvlib/events{/privacy}","received_events_url":"https://api.github.com/users/pvlib/received_events","type":"Organization","site_admin":false},"repo":{"id":30895522,"node_id":"MDEwOlJlcG9zaXRvcnkzMDg5NTUyMg==","name":"pvlib-python","full_name":"pvlib/pvlib-python","private":false,"owner":{"login":"pvlib","id":11037261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDM3MjYx","avatar_url":"https://avatars3.githubusercontent.com/u/11037261?v=4","gravatar_id":"","url":"https://api.github.com/users/pvlib","html_url":"https://github.com/pvlib","followers_url":"https://api.github.com/users/pvlib/followers","following_url":"https://api.github.com/users/pvlib/following{/other_user}","gists_url":"https://api.github.com/users/pvlib/gists{/gist_id}","starred_url":"https://api.github.com/users/pvlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvlib/subscriptions","organizations_url":"https://api.github.com/users/pvlib/orgs","repos_url":"https://api.github.com/users/pvlib/repos","events_url":"https://api.github.com/users/pvlib/events{/privacy}","received_events_url":"https://api.github.com/users/pvlib/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pvlib/pvlib-python","description":"A set of documented functions for simulating the performance of photovoltaic energy systems.","fork":false,"url":"https://api.github.com/repos/pvlib/pvlib-python","forks_url":"https://api.github.com/repos/pvlib/pvlib-python/forks","keys_url":"https://api.github.com/repos/pvlib/pvlib-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvlib/pvlib-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvlib/pvlib-python/teams","hooks_url":"https://api.github.com/repos/pvlib/pvlib-python/hooks","issue_events_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/events{/number}","events_url":"https://api.github.com/repos/pvlib/pvlib-python/events","assignees_url":"https://api.github.com/repos/pvlib/pvlib-python/assignees{/user}","branches_url":"https://api.github.com/repos/pvlib/pvlib-python/branches{/branch}","tags_url":"https://api.github.com/repos/pvlib/pvlib-python/tags","blobs_url":"https://api.github.com/repos/pvlib/pvlib-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvlib/pvlib-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvlib/pvlib-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvlib/pvlib-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvlib/pvlib-python/statuses/{sha}","languages_url":"https://api.github.com/repos/pvlib/pvlib-python/languages","stargazers_url":"https://api.github.com/repos/pvlib/pvlib-python/stargazers","contributors_url":"https://api.github.com/repos/pvlib/pvlib-python/contributors","subscribers_url":"https://api.github.com/repos/pvlib/pvlib-python/subscribers","subscription_url":"https://api.github.com/repos/pvlib/pvlib-python/subscription","commits_url":"https://api.github.com/repos/pvlib/pvlib-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvlib/pvlib-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvlib/pvlib-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvlib/pvlib-python/contents/{+path}","compare_url":"https://api.github.com/repos/pvlib/pvlib-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvlib/pvlib-python/merges","archive_url":"https://api.github.com/repos/pvlib/pvlib-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvlib/pvlib-python/downloads","issues_url":"https://api.github.com/repos/pvlib/pvlib-python/issues{/number}","pulls_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls{/number}","milestones_url":"https://api.github.com/repos/pvlib/pvlib-python/milestones{/number}","notifications_url":"https://api.github.com/repos/pvlib/pvlib-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvlib/pvlib-python/labels{/name}","releases_url":"https://api.github.com/repos/pvlib/pvlib-python/releases{/id}","deployments_url":"https://api.github.com/repos/pvlib/pvlib-python/deployments","created_at":"2015-02-17T00:21:33Z","updated_at":"2018-10-02T22:09:27Z","pushed_at":"2018-10-03T19:59:12Z","git_url":"git://github.com/pvlib/pvlib-python.git","ssh_url":"git@github.com:pvlib/pvlib-python.git","clone_url":"https://github.com/pvlib/pvlib-python.git","svn_url":"https://github.com/pvlib/pvlib-python","homepage":"http://pvlib-python.readthedocs.io/en/latest/","size":87339,"stargazers_count":179,"watchers_count":179,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":213,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":213,"open_issues":69,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/595"},"html":{"href":"https://github.com/pvlib/pvlib-python/pull/595"},"issue":{"href":"https://api.github.com/repos/pvlib/pvlib-python/issues/595"},"comments":{"href":"https://api.github.com/repos/pvlib/pvlib-python/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/pvlib/pvlib-python/statuses/07d1b6c23a3da427e3e6cb3924626d57a73a9510"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wholmgren"}}