{"action":"created","issue":{"url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2131","repository_url":"https://api.github.com/repos/pmmp/PocketMine-MP","labels_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2131/labels{/name}","comments_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2131/comments","events_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2131/events","html_url":"https://github.com/pmmp/PocketMine-MP/pull/2131","id":310801090,"number":2131,"title":"Add /daylock and /alwaysday","user":{"login":"lukeeey","id":32024335,"avatar_url":"https://avatars2.githubusercontent.com/u/32024335?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeeey","html_url":"https://github.com/lukeeey","followers_url":"https://api.github.com/users/lukeeey/followers","following_url":"https://api.github.com/users/lukeeey/following{/other_user}","gists_url":"https://api.github.com/users/lukeeey/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeeey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeeey/subscriptions","organizations_url":"https://api.github.com/users/lukeeey/orgs","repos_url":"https://api.github.com/users/lukeeey/repos","events_url":"https://api.github.com/users/lukeeey/events{/privacy}","received_events_url":"https://api.github.com/users/lukeeey/received_events","type":"User","site_admin":false},"labels":[{"id":454785701,"url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels/Category:%20Core","name":"Category: Core","color":"00aa55","default":false},{"id":454787972,"url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels/PR:%20Contribution","name":"PR: Contribution","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-03T11:40:17Z","updated_at":"2018-04-05T15:34:12Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls/2131","html_url":"https://github.com/pmmp/PocketMine-MP/pull/2131","diff_url":"https://github.com/pmmp/PocketMine-MP/pull/2131.diff","patch_url":"https://github.com/pmmp/PocketMine-MP/pull/2131.patch"},"body":"## Introduction\r\nThis PR implements the `/alwaysday` command and `/daylock` command. It also removes `/time start` and `/time stop`.\r\n\r\nSince both commands act *exactly* the same, i have implemented the logic in the daylock command and just registered the class for both \"daylock\" and \"alwaysday\". Please tell me if this will have unexpected issues, but i didnt see the point in duplicating code or adding it as an alias since it should show up as a seperate command like in vanilla.\r\n\r\nWhen locking the time, it initially sets it to 5000 (like vanilla) where it will stay until you change it (and then obviously it will stay there).\r\n\r\n### Relevant issues\r\nNone that i can find.\r\n\r\n## Changes\r\n### API changes\r\n* Removed permission `pocketmine.command.time.start`\r\n* Removed permission `pocketmine.command.time.stop`\r\n* Added permission `pocketmine.command.daylock`\r\n\r\n### Behavioural changes\r\nNone.\r\n\r\n## Backwards compatibility\r\nThis will (probably) have no effect on plugins, unless they stopped the time using `Server->dispatchCommand` (which they shouldn't be doing anyway).\r\n\r\n## Follow-up\r\nTranslations required, however the command success messages should display when executed from the client.\r\n\r\nThe start/stop text will need to be removed from the `/time` command usage string.\r\n\r\n## Tests\r\nJoin a server and test the following commands:\r\n\r\n* /daylock\r\n* /alwaysday\r\n* /daylock true\r\n* /daylock false\r\n\r\nIt all works perfectly."},"comment":{"url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/comments/378978108","html_url":"https://github.com/pmmp/PocketMine-MP/pull/2131#issuecomment-378978108","issue_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2131","id":378978108,"user":{"login":"lukeeey","id":32024335,"avatar_url":"https://avatars2.githubusercontent.com/u/32024335?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeeey","html_url":"https://github.com/lukeeey","followers_url":"https://api.github.com/users/lukeeey/followers","following_url":"https://api.github.com/users/lukeeey/following{/other_user}","gists_url":"https://api.github.com/users/lukeeey/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeeey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeeey/subscriptions","organizations_url":"https://api.github.com/users/lukeeey/orgs","repos_url":"https://api.github.com/users/lukeeey/repos","events_url":"https://api.github.com/users/lukeeey/events{/privacy}","received_events_url":"https://api.github.com/users/lukeeey/received_events","type":"User","site_admin":false},"created_at":"2018-04-05T15:34:12Z","updated_at":"2018-04-05T15:34:12Z","author_association":"NONE","body":"Well PocketMine aliases dont show up in the help page so i registered it again instead"}}
{"actor":{"display_login":"lukeeey"}}