{"action":"created","issue":{"url":"https://api.github.com/repos/Ticketmaster/aurora/issues/132","repository_url":"https://api.github.com/repos/Ticketmaster/aurora","labels_url":"https://api.github.com/repos/Ticketmaster/aurora/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/Ticketmaster/aurora/issues/132/comments","events_url":"https://api.github.com/repos/Ticketmaster/aurora/issues/132/events","html_url":"https://github.com/Ticketmaster/aurora/pull/132","id":357018494,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTM1MzY1","number":132,"title":"fix(DropDown) Default label to empty string; implement placeholder","user":{"login":"mlampedx","id":20174565,"node_id":"MDQ6VXNlcjIwMTc0NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/20174565?v=4","gravatar_id":"","url":"https://api.github.com/users/mlampedx","html_url":"https://github.com/mlampedx","followers_url":"https://api.github.com/users/mlampedx/followers","following_url":"https://api.github.com/users/mlampedx/following{/other_user}","gists_url":"https://api.github.com/users/mlampedx/gists{/gist_id}","starred_url":"https://api.github.com/users/mlampedx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlampedx/subscriptions","organizations_url":"https://api.github.com/users/mlampedx/orgs","repos_url":"https://api.github.com/users/mlampedx/repos","events_url":"https://api.github.com/users/mlampedx/events{/privacy}","received_events_url":"https://api.github.com/users/mlampedx/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-05T00:04:13Z","updated_at":"2018-09-12T17:11:16Z","closed_at":"2018-09-12T00:16:40Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Ticketmaster/aurora/pulls/132","html_url":"https://github.com/Ticketmaster/aurora/pull/132","diff_url":"https://github.com/Ticketmaster/aurora/pull/132.diff","patch_url":"https://github.com/Ticketmaster/aurora/pull/132.patch"},"body":"<!--\r\nThanks for your interest in the project. Bugs filed and PRs submitted are appreciated!\r\n\r\nPlease make sure that you are familiar with and follow the Code of Conduct for\r\nthis project (found in the CODE_OF_CONDUCT.md file).\r\n\r\nAlso, please make sure you're familiar with and follow the instructions in the\r\ncontributing guidelines (found in the CONTRIBUTING.md file).\r\n\r\nPlease fill out the information below to expedite the review and (hopefully)\r\nmerge of your pull request!\r\n-->\r\n\r\n<!-- What changes are being made? (What feature/bug is being fixed here?) -->\r\n\r\n**What**: I am defaulting `label` to an empty string, rather than `null` and implementing the `placeholder` prop for `variant` 0.\r\n\r\n<!-- Why are these changes necessary? -->\r\n\r\n**Why**: I am proposing these changes to ensure `null` never appears on the front-end when a label is missing and to enable the use of a placeholder for `variant` 0.\r\n\r\n<!-- How were these changes implemented? -->\r\n\r\n**How**: I have made these changes within `src/components/Input/DropDown/DropDownGroup.js`.\r\n\r\n<!-- Have you done all of these things?  -->\r\n\r\n**Checklist**:\r\n\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n\r\n* [ ] Documentation\r\n* [ ] Tests\r\n* [ ] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n\r\n<!-- feel free to add additional comments -->\r\n"},"comment":{"url":"https://api.github.com/repos/Ticketmaster/aurora/issues/comments/420726099","html_url":"https://github.com/Ticketmaster/aurora/pull/132#issuecomment-420726099","issue_url":"https://api.github.com/repos/Ticketmaster/aurora/issues/132","id":420726099,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDcyNjA5OQ==","user":{"login":"tm-github-bot","id":39978244,"node_id":"MDQ6VXNlcjM5OTc4MjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/39978244?v=4","gravatar_id":"","url":"https://api.github.com/users/tm-github-bot","html_url":"https://github.com/tm-github-bot","followers_url":"https://api.github.com/users/tm-github-bot/followers","following_url":"https://api.github.com/users/tm-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/tm-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/tm-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tm-github-bot/subscriptions","organizations_url":"https://api.github.com/users/tm-github-bot/orgs","repos_url":"https://api.github.com/users/tm-github-bot/repos","events_url":"https://api.github.com/users/tm-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/tm-github-bot/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T17:11:16Z","updated_at":"2018-09-12T17:11:16Z","author_association":"COLLABORATOR","body":":tada: This PR is included in version 3.9.0 :tada:\n\nThe release is available on:\n- `npm package (@latest dist-tag)`\n- [GitHub release](https://github.com/Ticketmaster/aurora/releases/tag/v3.9.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:"}}
{"actor":{"display_login":"tm-github-bot"}}