{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/190782112","pull_request_review_id":123233988,"id":190782112,"diff_hunk":"@@ -98,7 +100,7 @@ class ObjectManager : public ObjectManagerInterface {\n   /// \\param object_id The object's object id.\n   /// \\param client_id The remote node's client id.","path":"src/ray/object_manager/object_manager.h","position":15,"original_position":14,"commit_id":"7f67e60ae6ff52d82c04555d335010eb5a257048","original_commit_id":"5dcc6e41aec22c60ba528f206080b61a6b6aaddb","user":{"login":"guoyuhong","id":19584326,"avatar_url":"https://avatars2.githubusercontent.com/u/19584326?v=4","gravatar_id":"","url":"https://api.github.com/users/guoyuhong","html_url":"https://github.com/guoyuhong","followers_url":"https://api.github.com/users/guoyuhong/followers","following_url":"https://api.github.com/users/guoyuhong/following{/other_user}","gists_url":"https://api.github.com/users/guoyuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/guoyuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guoyuhong/subscriptions","organizations_url":"https://api.github.com/users/guoyuhong/orgs","repos_url":"https://api.github.com/users/guoyuhong/repos","events_url":"https://api.github.com/users/guoyuhong/events{/privacy}","received_events_url":"https://api.github.com/users/guoyuhong/received_events","type":"User","site_admin":false},"body":"After talking to @raulchen and @eric-jj , I decide to change the code to waiting-list version.","created_at":"2018-05-25T03:16:59Z","updated_at":"2018-05-25T03:16:59Z","html_url":"https://github.com/ray-project/ray/pull/2133#discussion_r190782112","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/2133","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/190782112"},"html":{"href":"https://github.com/ray-project/ray/pull/2133#discussion_r190782112"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2133"}},"in_reply_to_id":190731297},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/2133","id":190167631,"html_url":"https://github.com/ray-project/ray/pull/2133","diff_url":"https://github.com/ray-project/ray/pull/2133.diff","patch_url":"https://github.com/ray-project/ray/pull/2133.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/2133","number":2133,"state":"open","locked":false,"title":"Fix infinite retry in Push function.","user":{"login":"guoyuhong","id":19584326,"avatar_url":"https://avatars2.githubusercontent.com/u/19584326?v=4","gravatar_id":"","url":"https://api.github.com/users/guoyuhong","html_url":"https://github.com/guoyuhong","followers_url":"https://api.github.com/users/guoyuhong/followers","following_url":"https://api.github.com/users/guoyuhong/following{/other_user}","gists_url":"https://api.github.com/users/guoyuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/guoyuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guoyuhong/subscriptions","organizations_url":"https://api.github.com/users/guoyuhong/orgs","repos_url":"https://api.github.com/users/guoyuhong/repos","events_url":"https://api.github.com/users/guoyuhong/events{/privacy}","received_events_url":"https://api.github.com/users/guoyuhong/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your contribution!\r\n\r\nPlease review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request.\r\n-->\r\nHello!\r\nThis is Yuhong Guo from Ant Financial. I'm trying to do some small code change to go through the full code review process. \r\n\r\n## What do these changes do?\r\n\r\n<!-- Please give a short brief about these changes. -->\r\n* Remove the infinite call in Push function.\r\n* Fix some comment mismatches.\r\n\r\n\r\n## Related issue number\r\nN/A\r\n<!-- Are there any issues opened that will be resolved by merging this change? -->\r\n","created_at":"2018-05-24T04:35:17Z","updated_at":"2018-05-25T03:16:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fde2c86610f53212799497733d26e9bd3e48bb56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/2133/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/2133/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/2133/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/7f67e60ae6ff52d82c04555d335010eb5a257048","head":{"label":"ant-tech-alliance:FixInfiniteRetry","ref":"FixInfiniteRetry","sha":"7f67e60ae6ff52d82c04555d335010eb5a257048","user":{"login":"ant-tech-alliance","id":29560905,"avatar_url":"https://avatars3.githubusercontent.com/u/29560905?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-tech-alliance","html_url":"https://github.com/ant-tech-alliance","followers_url":"https://api.github.com/users/ant-tech-alliance/followers","following_url":"https://api.github.com/users/ant-tech-alliance/following{/other_user}","gists_url":"https://api.github.com/users/ant-tech-alliance/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-tech-alliance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-tech-alliance/subscriptions","organizations_url":"https://api.github.com/users/ant-tech-alliance/orgs","repos_url":"https://api.github.com/users/ant-tech-alliance/repos","events_url":"https://api.github.com/users/ant-tech-alliance/events{/privacy}","received_events_url":"https://api.github.com/users/ant-tech-alliance/received_events","type":"Organization","site_admin":false},"repo":{"id":125461261,"name":"ray","full_name":"ant-tech-alliance/ray","owner":{"login":"ant-tech-alliance","id":29560905,"avatar_url":"https://avatars3.githubusercontent.com/u/29560905?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-tech-alliance","html_url":"https://github.com/ant-tech-alliance","followers_url":"https://api.github.com/users/ant-tech-alliance/followers","following_url":"https://api.github.com/users/ant-tech-alliance/following{/other_user}","gists_url":"https://api.github.com/users/ant-tech-alliance/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-tech-alliance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-tech-alliance/subscriptions","organizations_url":"https://api.github.com/users/ant-tech-alliance/orgs","repos_url":"https://api.github.com/users/ant-tech-alliance/repos","events_url":"https://api.github.com/users/ant-tech-alliance/events{/privacy}","received_events_url":"https://api.github.com/users/ant-tech-alliance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ant-tech-alliance/ray","description":"A high-performance distributed execution engine","fork":true,"url":"https://api.github.com/repos/ant-tech-alliance/ray","forks_url":"https://api.github.com/repos/ant-tech-alliance/ray/forks","keys_url":"https://api.github.com/repos/ant-tech-alliance/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ant-tech-alliance/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ant-tech-alliance/ray/teams","hooks_url":"https://api.github.com/repos/ant-tech-alliance/ray/hooks","issue_events_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ant-tech-alliance/ray/events","assignees_url":"https://api.github.com/repos/ant-tech-alliance/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ant-tech-alliance/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ant-tech-alliance/ray/tags","blobs_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ant-tech-alliance/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ant-tech-alliance/ray/languages","stargazers_url":"https://api.github.com/repos/ant-tech-alliance/ray/stargazers","contributors_url":"https://api.github.com/repos/ant-tech-alliance/ray/contributors","subscribers_url":"https://api.github.com/repos/ant-tech-alliance/ray/subscribers","subscription_url":"https://api.github.com/repos/ant-tech-alliance/ray/subscription","commits_url":"https://api.github.com/repos/ant-tech-alliance/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ant-tech-alliance/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ant-tech-alliance/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ant-tech-alliance/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ant-tech-alliance/ray/merges","archive_url":"https://api.github.com/repos/ant-tech-alliance/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ant-tech-alliance/ray/downloads","issues_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ant-tech-alliance/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ant-tech-alliance/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ant-tech-alliance/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ant-tech-alliance/ray/labels{/name}","releases_url":"https://api.github.com/repos/ant-tech-alliance/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ant-tech-alliance/ray/deployments","created_at":"2018-03-16T03:58:55Z","updated_at":"2018-05-23T02:04:14Z","pushed_at":"2018-05-25T03:03:59Z","git_url":"git://github.com/ant-tech-alliance/ray.git","ssh_url":"git@github.com:ant-tech-alliance/ray.git","clone_url":"https://github.com/ant-tech-alliance/ray.git","svn_url":"https://github.com/ant-tech-alliance/ray","homepage":"","size":11717,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"3509a33cf37132a4bca5c7e3bdabb091ea1b8ece","user":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"name":"ray","full_name":"ray-project/ray","owner":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray","description":"A high-performance distributed execution engine","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2018-05-24T16:19:39Z","pushed_at":"2018-05-25T03:04:00Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"","size":11408,"stargazers_count":3327,"watchers_count":3327,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":439,"mirror_url":null,"archived":false,"open_issues_count":332,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":439,"open_issues":332,"watchers":3327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2133"},"html":{"href":"https://github.com/ray-project/ray/pull/2133"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/2133"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/2133/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2133/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2133/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/7f67e60ae6ff52d82c04555d335010eb5a257048"}},"author_association":"NONE"}}
{"actor":{"display_login":"guoyuhong"}}