{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/18951","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/18951/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/18951/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/18951/events","html_url":"https://github.com/nodejs/node/pull/18951","id":299638516,"number":18951,"title":"doc: remove `Returns: {undefined}`","user":{"login":"shqld","id":19388148,"avatar_url":"https://avatars3.githubusercontent.com/u/19388148?v=4","gravatar_id":"","url":"https://api.github.com/users/shqld","html_url":"https://github.com/shqld","followers_url":"https://api.github.com/users/shqld/followers","following_url":"https://api.github.com/users/shqld/following{/other_user}","gists_url":"https://api.github.com/users/shqld/gists{/gist_id}","starred_url":"https://api.github.com/users/shqld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shqld/subscriptions","organizations_url":"https://api.github.com/users/shqld/orgs","repos_url":"https://api.github.com/users/shqld/repos","events_url":"https://api.github.com/users/shqld/events{/privacy}","received_events_url":"https://api.github.com/users/shqld/received_events","type":"User","site_admin":false},"labels":[{"id":155267517,"url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":746808418,"url":"https://api.github.com/repos/nodejs/node/labels/fast-track","name":"fast-track","color":"a989e5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-23T08:50:58Z","updated_at":"2018-02-23T10:51:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/18951","html_url":"https://github.com/nodejs/node/pull/18951","diff_url":"https://github.com/nodejs/node/pull/18951.diff","patch_url":"https://github.com/nodejs/node/pull/18951.patch"},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\nRemoved `* Returns: {undefined}` in `doc/` to prevent confusing users. Cf. https://github.com/nodejs/node/pull/18775#issuecomment-365640394\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ndoc"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/367976335","html_url":"https://github.com/nodejs/node/pull/18951#issuecomment-367976335","issue_url":"https://api.github.com/repos/nodejs/node/issues/18951","id":367976335,"user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T10:51:04Z","updated_at":"2018-02-23T10:51:04Z","author_association":"MEMBER","body":"The change itself is LG but I am wondering if it would not be better to always add the return value instead. I know that is much more work but in that case there would not be any possibility for confusion at all.\r\n\r\nWhat do others think?"}}
{"actor":{"display_login":"BridgeAR"}}