{"action":"created","comment":{"url":"https://api.github.com/repos/decred/dcrwallet/pulls/comments/199859477","pull_request_review_id":134051133,"id":199859477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTg1OTQ3Nw==","diff_hunk":"@@ -688,6 +765,48 @@ func fetchAccountName(ns walletdb.ReadBucket, account uint32) (string, error) {\n \treturn acctName, nil\n }\n \n+// fetchVotingAccountInfo retrieves the votingWalletMasterPubKey from the database\n+func fetchVotingAccountInfo(ns walletdb.ReadBucket) (*dbVotingAccountRow, error) {\n+\tbucket := ns.NestedReadBucket(acctBucketName)\n+\n+\taccountID := uint32ToBytes(VotingAddrAccount)\n+\tserializedRow := bucket.Get(accountID)\n+\tif serializedRow == nil {\n+\t\treturn nil, errors.E(errors.NotExist, errors.Errorf(\"no account %q\", VotingAddrAccount))\n+\t}\n+\n+\taccountRow, err := deserializeAccountRow(accountID, serializedRow)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\tvar row *dbVotingAccountRow\n+\trow, err = deserializeVotingAccountRow(accountRow)\n+\n+\tif err != nil {\n+\t\treturn nil, errors.E(errors.Invalid, errors.Errorf(\"failed to deserialize voting account row: %v\", err))\n+\t}\n+\n+\tif row == nil {","path":"wallet/udb/addressdb.go","position":142,"original_position":142,"commit_id":"1d1e60df49251d4cf31872ad5156468ccdfc3fe7","original_commit_id":"1d1e60df49251d4cf31872ad5156468ccdfc3fe7","user":{"login":"jrick","id":1420313,"node_id":"MDQ6VXNlcjE0MjAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1420313?v=4","gravatar_id":"","url":"https://api.github.com/users/jrick","html_url":"https://github.com/jrick","followers_url":"https://api.github.com/users/jrick/followers","following_url":"https://api.github.com/users/jrick/following{/other_user}","gists_url":"https://api.github.com/users/jrick/gists{/gist_id}","starred_url":"https://api.github.com/users/jrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrick/subscriptions","organizations_url":"https://api.github.com/users/jrick/orgs","repos_url":"https://api.github.com/users/jrick/repos","events_url":"https://api.github.com/users/jrick/events{/privacy}","received_events_url":"https://api.github.com/users/jrick/received_events","type":"User","site_admin":false},"body":"why would this return nil without error?","created_at":"2018-07-03T15:51:46Z","updated_at":"2018-07-03T16:02:06Z","html_url":"https://github.com/decred/dcrwallet/pull/1137#discussion_r199859477","pull_request_url":"https://api.github.com/repos/decred/dcrwallet/pulls/1137","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/comments/199859477"},"html":{"href":"https://github.com/decred/dcrwallet/pull/1137#discussion_r199859477"},"pull_request":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/1137"}}},"pull_request":{"url":"https://api.github.com/repos/decred/dcrwallet/pulls/1137","id":187306287,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3MzA2Mjg3","html_url":"https://github.com/decred/dcrwallet/pull/1137","diff_url":"https://github.com/decred/dcrwallet/pull/1137.diff","patch_url":"https://github.com/decred/dcrwallet/pull/1137.patch","issue_url":"https://api.github.com/repos/decred/dcrwallet/issues/1137","number":1137,"state":"open","locked":false,"title":"multi: Implement xpub import from other wallet and use for address generation ","user":{"login":"kLkA","id":5596845,"node_id":"MDQ6VXNlcjU1OTY4NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5596845?v=4","gravatar_id":"","url":"https://api.github.com/users/kLkA","html_url":"https://github.com/kLkA","followers_url":"https://api.github.com/users/kLkA/followers","following_url":"https://api.github.com/users/kLkA/following{/other_user}","gists_url":"https://api.github.com/users/kLkA/gists{/gist_id}","starred_url":"https://api.github.com/users/kLkA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kLkA/subscriptions","organizations_url":"https://api.github.com/users/kLkA/orgs","repos_url":"https://api.github.com/users/kLkA/repos","events_url":"https://api.github.com/users/kLkA/events{/privacy}","received_events_url":"https://api.github.com/users/kLkA/received_events","type":"User","site_admin":false},"body":"Add basic helper methods for fetch, put, delete\r\nvotingWalletMasterPubKey and load key on wallet startup\r\n\r\nissue #990","created_at":"2018-05-10T21:01:19Z","updated_at":"2018-07-03T16:02:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e38fbc9399d471004419caabdce79acc43a55c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/decred/dcrwallet/pulls/1137/commits","review_comments_url":"https://api.github.com/repos/decred/dcrwallet/pulls/1137/comments","review_comment_url":"https://api.github.com/repos/decred/dcrwallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decred/dcrwallet/issues/1137/comments","statuses_url":"https://api.github.com/repos/decred/dcrwallet/statuses/1d1e60df49251d4cf31872ad5156468ccdfc3fe7","head":{"label":"kLkA:xpub_for_ticket_purchase","ref":"xpub_for_ticket_purchase","sha":"1d1e60df49251d4cf31872ad5156468ccdfc3fe7","user":{"login":"kLkA","id":5596845,"node_id":"MDQ6VXNlcjU1OTY4NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5596845?v=4","gravatar_id":"","url":"https://api.github.com/users/kLkA","html_url":"https://github.com/kLkA","followers_url":"https://api.github.com/users/kLkA/followers","following_url":"https://api.github.com/users/kLkA/following{/other_user}","gists_url":"https://api.github.com/users/kLkA/gists{/gist_id}","starred_url":"https://api.github.com/users/kLkA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kLkA/subscriptions","organizations_url":"https://api.github.com/users/kLkA/orgs","repos_url":"https://api.github.com/users/kLkA/repos","events_url":"https://api.github.com/users/kLkA/events{/privacy}","received_events_url":"https://api.github.com/users/kLkA/received_events","type":"User","site_admin":false},"repo":{"id":131407852,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE0MDc4NTI=","name":"dcrwallet","full_name":"kLkA/dcrwallet","owner":{"login":"kLkA","id":5596845,"node_id":"MDQ6VXNlcjU1OTY4NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5596845?v=4","gravatar_id":"","url":"https://api.github.com/users/kLkA","html_url":"https://github.com/kLkA","followers_url":"https://api.github.com/users/kLkA/followers","following_url":"https://api.github.com/users/kLkA/following{/other_user}","gists_url":"https://api.github.com/users/kLkA/gists{/gist_id}","starred_url":"https://api.github.com/users/kLkA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kLkA/subscriptions","organizations_url":"https://api.github.com/users/kLkA/orgs","repos_url":"https://api.github.com/users/kLkA/repos","events_url":"https://api.github.com/users/kLkA/events{/privacy}","received_events_url":"https://api.github.com/users/kLkA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kLkA/dcrwallet","description":"A secure Decred wallet daemon written in Go (golang).","fork":true,"url":"https://api.github.com/repos/kLkA/dcrwallet","forks_url":"https://api.github.com/repos/kLkA/dcrwallet/forks","keys_url":"https://api.github.com/repos/kLkA/dcrwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kLkA/dcrwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kLkA/dcrwallet/teams","hooks_url":"https://api.github.com/repos/kLkA/dcrwallet/hooks","issue_events_url":"https://api.github.com/repos/kLkA/dcrwallet/issues/events{/number}","events_url":"https://api.github.com/repos/kLkA/dcrwallet/events","assignees_url":"https://api.github.com/repos/kLkA/dcrwallet/assignees{/user}","branches_url":"https://api.github.com/repos/kLkA/dcrwallet/branches{/branch}","tags_url":"https://api.github.com/repos/kLkA/dcrwallet/tags","blobs_url":"https://api.github.com/repos/kLkA/dcrwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kLkA/dcrwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kLkA/dcrwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/kLkA/dcrwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kLkA/dcrwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/kLkA/dcrwallet/languages","stargazers_url":"https://api.github.com/repos/kLkA/dcrwallet/stargazers","contributors_url":"https://api.github.com/repos/kLkA/dcrwallet/contributors","subscribers_url":"https://api.github.com/repos/kLkA/dcrwallet/subscribers","subscription_url":"https://api.github.com/repos/kLkA/dcrwallet/subscription","commits_url":"https://api.github.com/repos/kLkA/dcrwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/kLkA/dcrwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/kLkA/dcrwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/kLkA/dcrwallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/kLkA/dcrwallet/contents/{+path}","compare_url":"https://api.github.com/repos/kLkA/dcrwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kLkA/dcrwallet/merges","archive_url":"https://api.github.com/repos/kLkA/dcrwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kLkA/dcrwallet/downloads","issues_url":"https://api.github.com/repos/kLkA/dcrwallet/issues{/number}","pulls_url":"https://api.github.com/repos/kLkA/dcrwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/kLkA/dcrwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/kLkA/dcrwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kLkA/dcrwallet/labels{/name}","releases_url":"https://api.github.com/repos/kLkA/dcrwallet/releases{/id}","deployments_url":"https://api.github.com/repos/kLkA/dcrwallet/deployments","created_at":"2018-04-28T12:31:33Z","updated_at":"2018-06-03T20:18:57Z","pushed_at":"2018-06-10T10:20:50Z","git_url":"git://github.com/kLkA/dcrwallet.git","ssh_url":"git@github.com:kLkA/dcrwallet.git","clone_url":"https://github.com/kLkA/dcrwallet.git","svn_url":"https://github.com/kLkA/dcrwallet","homepage":"https://decred.org","size":8198,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"decred:master","ref":"master","sha":"5dc5c18a6b94fe3d0d3390b090a9bdbcf0b52e41","user":{"login":"decred","id":16297194,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3MTk0","avatar_url":"https://avatars3.githubusercontent.com/u/16297194?v=4","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"repo":{"id":50457727,"node_id":"MDEwOlJlcG9zaXRvcnk1MDQ1NzcyNw==","name":"dcrwallet","full_name":"decred/dcrwallet","owner":{"login":"decred","id":16297194,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3MTk0","avatar_url":"https://avatars3.githubusercontent.com/u/16297194?v=4","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decred/dcrwallet","description":"A secure Decred wallet daemon written in Go (golang).","fork":true,"url":"https://api.github.com/repos/decred/dcrwallet","forks_url":"https://api.github.com/repos/decred/dcrwallet/forks","keys_url":"https://api.github.com/repos/decred/dcrwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decred/dcrwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decred/dcrwallet/teams","hooks_url":"https://api.github.com/repos/decred/dcrwallet/hooks","issue_events_url":"https://api.github.com/repos/decred/dcrwallet/issues/events{/number}","events_url":"https://api.github.com/repos/decred/dcrwallet/events","assignees_url":"https://api.github.com/repos/decred/dcrwallet/assignees{/user}","branches_url":"https://api.github.com/repos/decred/dcrwallet/branches{/branch}","tags_url":"https://api.github.com/repos/decred/dcrwallet/tags","blobs_url":"https://api.github.com/repos/decred/dcrwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decred/dcrwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decred/dcrwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/decred/dcrwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decred/dcrwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/decred/dcrwallet/languages","stargazers_url":"https://api.github.com/repos/decred/dcrwallet/stargazers","contributors_url":"https://api.github.com/repos/decred/dcrwallet/contributors","subscribers_url":"https://api.github.com/repos/decred/dcrwallet/subscribers","subscription_url":"https://api.github.com/repos/decred/dcrwallet/subscription","commits_url":"https://api.github.com/repos/decred/dcrwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/decred/dcrwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/decred/dcrwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/decred/dcrwallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/decred/dcrwallet/contents/{+path}","compare_url":"https://api.github.com/repos/decred/dcrwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decred/dcrwallet/merges","archive_url":"https://api.github.com/repos/decred/dcrwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decred/dcrwallet/downloads","issues_url":"https://api.github.com/repos/decred/dcrwallet/issues{/number}","pulls_url":"https://api.github.com/repos/decred/dcrwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/decred/dcrwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/decred/dcrwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decred/dcrwallet/labels{/name}","releases_url":"https://api.github.com/repos/decred/dcrwallet/releases{/id}","deployments_url":"https://api.github.com/repos/decred/dcrwallet/deployments","created_at":"2016-01-26T20:40:34Z","updated_at":"2018-07-03T15:05:31Z","pushed_at":"2018-07-03T15:05:25Z","git_url":"git://github.com/decred/dcrwallet.git","ssh_url":"git@github.com:decred/dcrwallet.git","clone_url":"https://github.com/decred/dcrwallet.git","svn_url":"https://github.com/decred/dcrwallet","homepage":"https://decred.org","size":8217,"stargazers_count":120,"watchers_count":120,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":86,"open_issues":118,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/1137"},"html":{"href":"https://github.com/decred/dcrwallet/pull/1137"},"issue":{"href":"https://api.github.com/repos/decred/dcrwallet/issues/1137"},"comments":{"href":"https://api.github.com/repos/decred/dcrwallet/issues/1137/comments"},"review_comments":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/1137/comments"},"review_comment":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/1137/commits"},"statuses":{"href":"https://api.github.com/repos/decred/dcrwallet/statuses/1d1e60df49251d4cf31872ad5156468ccdfc3fe7"}},"author_association":"NONE"}}
{"actor":{"display_login":"jrick"}}