{"action":"created","comment":{"url":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments/183392724","pull_request_review_id":114380530,"id":183392724,"diff_hunk":"@@ -0,0 +1,64 @@\n+LIGHTNING-CONNECT(7)\n+====================\n+:doctype: manpage\n+\n+NAME\n+----\n+lightning-connect - Protocol for connecting to another \n+lightning node.\n+\n+SYNOPSIS\n+--------\n+*connect* 'node_id'[@('ip_addr'|'hostname')[:'port']]\n+\n+or\n+\n+*connect* 'node_id'[ ('ip_addr'|'hostname')[:'port']]\n+\n+DESCRIPTION\n+-----------\n+The *connect* RPC command establishes a new connection \n+with another node in the Lightning Network.\n+\n+'node_id' represents the target node's public key and \n+'ip_addr' can be either IPv4 or IPv6. \n+\n+If not specified the 'port' is assumed to be 9375 \n+(default lightning port).\n+\n+If neither 'ip_addr' or 'hostname' is specified, \n+connection will be attempted to an IP belonging to \n+'node_id' learned through gossip with other already \n+connected peers\n+\n+Connecting to a node is just the first step in opening \n+a channel with another node, once the peer is connected\n+a channel can be opened with lightning-fundchannel(7)\n+\n+\n+RETURN VALUE\n+------------\n+On success the response will include just the peer id \n+(peer's public key)\n+\n+ERRORS\n+------\n+If 'node_id' or 'ip_addr' are invalid or if 'hostname' \n+can't be resolved to a valid IP address an error message\n+will be returned. An error will also be returned if the \n+simplified version (only 'node_id') is used and there's\n+no published IP for the peer. *connect* will make up to \n+10(?) attempts to connect to the peer before giving up","path":"doc/lightning-connect.7.txt","position":51,"original_position":51,"commit_id":"2e7dbfdd37fd938bc064f073eca96e69af3b7385","original_commit_id":"172d2245b7f6b52df484ad987609a8bf6532b9e1","user":{"login":"ZmnSCPxj","id":28175207,"avatar_url":"https://avatars0.githubusercontent.com/u/28175207?v=4","gravatar_id":"","url":"https://api.github.com/users/ZmnSCPxj","html_url":"https://github.com/ZmnSCPxj","followers_url":"https://api.github.com/users/ZmnSCPxj/followers","following_url":"https://api.github.com/users/ZmnSCPxj/following{/other_user}","gists_url":"https://api.github.com/users/ZmnSCPxj/gists{/gist_id}","starred_url":"https://api.github.com/users/ZmnSCPxj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZmnSCPxj/subscriptions","organizations_url":"https://api.github.com/users/ZmnSCPxj/orgs","repos_url":"https://api.github.com/users/ZmnSCPxj/repos","events_url":"https://api.github.com/users/ZmnSCPxj/events{/privacy}","received_events_url":"https://api.github.com/users/ZmnSCPxj/received_events","type":"User","site_admin":false},"body":"#1322 will change this to a single attempt only.  Instead, persistent reconnecting (with exponential backoff until we do a retry every 5 minutes) will be done if we have a channel to that node (although this particular fact might be better mentioned in `fundchannel` manpage).\r\n\r\nI suggest moving the `connect` manpage to a new pull request, as #1322 will change its behavior, so we can rewrite it separately after #1322 is merged in.","created_at":"2018-04-23T13:24:38Z","updated_at":"2018-04-23T13:24:43Z","html_url":"https://github.com/ElementsProject/lightning/pull/1406#discussion_r183392724","pull_request_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1406","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments/183392724"},"html":{"href":"https://github.com/ElementsProject/lightning/pull/1406#discussion_r183392724"},"pull_request":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1406"}}},"pull_request":{"url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1406","id":183286724,"html_url":"https://github.com/ElementsProject/lightning/pull/1406","diff_url":"https://github.com/ElementsProject/lightning/pull/1406.diff","patch_url":"https://github.com/ElementsProject/lightning/pull/1406.patch","issue_url":"https://api.github.com/repos/ElementsProject/lightning/issues/1406","number":1406,"state":"open","locked":false,"title":"documentation for listfunds, newaddr, connect and withdraw","user":{"login":"fixone","id":196430,"avatar_url":"https://avatars0.githubusercontent.com/u/196430?v=4","gravatar_id":"","url":"https://api.github.com/users/fixone","html_url":"https://github.com/fixone","followers_url":"https://api.github.com/users/fixone/followers","following_url":"https://api.github.com/users/fixone/following{/other_user}","gists_url":"https://api.github.com/users/fixone/gists{/gist_id}","starred_url":"https://api.github.com/users/fixone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fixone/subscriptions","organizations_url":"https://api.github.com/users/fixone/orgs","repos_url":"https://api.github.com/users/fixone/repos","events_url":"https://api.github.com/users/fixone/events{/privacy}","received_events_url":"https://api.github.com/users/fixone/received_events","type":"User","site_admin":false},"body":"some of the opened items in #1360","created_at":"2018-04-22T18:22:57Z","updated_at":"2018-04-23T13:24:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11dbdea0262d6021a2112683d0838748a349d23d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1406/commits","review_comments_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1406/comments","review_comment_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElementsProject/lightning/issues/1406/comments","statuses_url":"https://api.github.com/repos/ElementsProject/lightning/statuses/2e7dbfdd37fd938bc064f073eca96e69af3b7385","head":{"label":"fixone:master","ref":"master","sha":"2e7dbfdd37fd938bc064f073eca96e69af3b7385","user":{"login":"fixone","id":196430,"avatar_url":"https://avatars0.githubusercontent.com/u/196430?v=4","gravatar_id":"","url":"https://api.github.com/users/fixone","html_url":"https://github.com/fixone","followers_url":"https://api.github.com/users/fixone/followers","following_url":"https://api.github.com/users/fixone/following{/other_user}","gists_url":"https://api.github.com/users/fixone/gists{/gist_id}","starred_url":"https://api.github.com/users/fixone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fixone/subscriptions","organizations_url":"https://api.github.com/users/fixone/orgs","repos_url":"https://api.github.com/users/fixone/repos","events_url":"https://api.github.com/users/fixone/events{/privacy}","received_events_url":"https://api.github.com/users/fixone/received_events","type":"User","site_admin":false},"repo":{"id":130548961,"name":"lightning","full_name":"fixone/lightning","owner":{"login":"fixone","id":196430,"avatar_url":"https://avatars0.githubusercontent.com/u/196430?v=4","gravatar_id":"","url":"https://api.github.com/users/fixone","html_url":"https://github.com/fixone","followers_url":"https://api.github.com/users/fixone/followers","following_url":"https://api.github.com/users/fixone/following{/other_user}","gists_url":"https://api.github.com/users/fixone/gists{/gist_id}","starred_url":"https://api.github.com/users/fixone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fixone/subscriptions","organizations_url":"https://api.github.com/users/fixone/orgs","repos_url":"https://api.github.com/users/fixone/repos","events_url":"https://api.github.com/users/fixone/events{/privacy}","received_events_url":"https://api.github.com/users/fixone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fixone/lightning","description":"c-lightning — a Lightning Network implementation in C","fork":true,"url":"https://api.github.com/repos/fixone/lightning","forks_url":"https://api.github.com/repos/fixone/lightning/forks","keys_url":"https://api.github.com/repos/fixone/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fixone/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fixone/lightning/teams","hooks_url":"https://api.github.com/repos/fixone/lightning/hooks","issue_events_url":"https://api.github.com/repos/fixone/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/fixone/lightning/events","assignees_url":"https://api.github.com/repos/fixone/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/fixone/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/fixone/lightning/tags","blobs_url":"https://api.github.com/repos/fixone/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fixone/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fixone/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/fixone/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fixone/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/fixone/lightning/languages","stargazers_url":"https://api.github.com/repos/fixone/lightning/stargazers","contributors_url":"https://api.github.com/repos/fixone/lightning/contributors","subscribers_url":"https://api.github.com/repos/fixone/lightning/subscribers","subscription_url":"https://api.github.com/repos/fixone/lightning/subscription","commits_url":"https://api.github.com/repos/fixone/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/fixone/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/fixone/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/fixone/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/fixone/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/fixone/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fixone/lightning/merges","archive_url":"https://api.github.com/repos/fixone/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fixone/lightning/downloads","issues_url":"https://api.github.com/repos/fixone/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/fixone/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/fixone/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/fixone/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fixone/lightning/labels{/name}","releases_url":"https://api.github.com/repos/fixone/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/fixone/lightning/deployments","created_at":"2018-04-22T08:27:33Z","updated_at":"2018-04-23T13:19:39Z","pushed_at":"2018-04-23T13:19:37Z","git_url":"git://github.com/fixone/lightning.git","ssh_url":"git@github.com:fixone/lightning.git","clone_url":"https://github.com/fixone/lightning.git","svn_url":"https://github.com/fixone/lightning","homepage":"","size":14778,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ElementsProject:master","ref":"master","sha":"78a074af5acfeb60fc5d58ae083ef4bec48801a7","user":{"login":"ElementsProject","id":12729539,"avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":37350472,"name":"lightning","full_name":"ElementsProject/lightning","owner":{"login":"ElementsProject","id":12729539,"avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ElementsProject/lightning","description":"c-lightning — a Lightning Network implementation in C","fork":false,"url":"https://api.github.com/repos/ElementsProject/lightning","forks_url":"https://api.github.com/repos/ElementsProject/lightning/forks","keys_url":"https://api.github.com/repos/ElementsProject/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElementsProject/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElementsProject/lightning/teams","hooks_url":"https://api.github.com/repos/ElementsProject/lightning/hooks","issue_events_url":"https://api.github.com/repos/ElementsProject/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/ElementsProject/lightning/events","assignees_url":"https://api.github.com/repos/ElementsProject/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/ElementsProject/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/ElementsProject/lightning/tags","blobs_url":"https://api.github.com/repos/ElementsProject/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElementsProject/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElementsProject/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElementsProject/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElementsProject/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/ElementsProject/lightning/languages","stargazers_url":"https://api.github.com/repos/ElementsProject/lightning/stargazers","contributors_url":"https://api.github.com/repos/ElementsProject/lightning/contributors","subscribers_url":"https://api.github.com/repos/ElementsProject/lightning/subscribers","subscription_url":"https://api.github.com/repos/ElementsProject/lightning/subscription","commits_url":"https://api.github.com/repos/ElementsProject/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElementsProject/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElementsProject/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElementsProject/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElementsProject/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/ElementsProject/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElementsProject/lightning/merges","archive_url":"https://api.github.com/repos/ElementsProject/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElementsProject/lightning/downloads","issues_url":"https://api.github.com/repos/ElementsProject/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/ElementsProject/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/ElementsProject/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/ElementsProject/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElementsProject/lightning/labels{/name}","releases_url":"https://api.github.com/repos/ElementsProject/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/ElementsProject/lightning/deployments","created_at":"2015-06-13T00:04:22Z","updated_at":"2018-04-23T10:12:23Z","pushed_at":"2018-04-23T13:19:39Z","git_url":"git://github.com/ElementsProject/lightning.git","ssh_url":"git@github.com:ElementsProject/lightning.git","clone_url":"https://github.com/ElementsProject/lightning.git","svn_url":"https://github.com/ElementsProject/lightning","homepage":"","size":14766,"stargazers_count":894,"watchers_count":894,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":247,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":247,"open_issues":118,"watchers":894,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1406"},"html":{"href":"https://github.com/ElementsProject/lightning/pull/1406"},"issue":{"href":"https://api.github.com/repos/ElementsProject/lightning/issues/1406"},"comments":{"href":"https://api.github.com/repos/ElementsProject/lightning/issues/1406/comments"},"review_comments":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1406/comments"},"review_comment":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1406/commits"},"statuses":{"href":"https://api.github.com/repos/ElementsProject/lightning/statuses/2e7dbfdd37fd938bc064f073eca96e69af3b7385"}},"author_association":"NONE"}}
{"actor":{"display_login":"ZmnSCPxj"}}