{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/parity-common/pulls/comments/229467656","pull_request_review_id":169977055,"id":229467656,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQ2NzY1Ng==","diff_hunk":"@@ -506,11 +506,7 @@ macro_rules! construct_hash {\n \t\t\t}\n \t\t}\n \n-\t\t#[cfg(all(\n-\t\t\tfeature = \"heapsize-support\",\n-\t\t\tfeature = \"libc\",\n-\t\t\tnot(target_os = \"unknown\")\n-\t\t))]\n+\t\t#[cfg(feature = \"heapsize-support\")]","path":"fixed-hash/src/hash.rs","position":896,"original_position":9,"commit_id":"1badf67a17f528b071f6c6429385c7b827c7e498","original_commit_id":"93d18df0ad218be3d9002ae04cafee66967e37f5","user":{"login":"dvdplm","id":18515,"node_id":"MDQ6VXNlcjE4NTE1","avatar_url":"https://avatars2.githubusercontent.com/u/18515?v=4","gravatar_id":"","url":"https://api.github.com/users/dvdplm","html_url":"https://github.com/dvdplm","followers_url":"https://api.github.com/users/dvdplm/followers","following_url":"https://api.github.com/users/dvdplm/following{/other_user}","gists_url":"https://api.github.com/users/dvdplm/gists{/gist_id}","starred_url":"https://api.github.com/users/dvdplm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvdplm/subscriptions","organizations_url":"https://api.github.com/users/dvdplm/orgs","repos_url":"https://api.github.com/users/dvdplm/repos","events_url":"https://api.github.com/users/dvdplm/events{/privacy}","received_events_url":"https://api.github.com/users/dvdplm/received_events","type":"User","site_admin":false},"body":"The `target_os` need to be there I'm afraid. WASM can't use the `heapsize` crate.","created_at":"2018-10-30T20:11:52Z","updated_at":"2018-10-30T20:11:52Z","html_url":"https://github.com/paritytech/parity-common/pull/71#discussion_r229467656","pull_request_url":"https://api.github.com/repos/paritytech/parity-common/pulls/71","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity-common/pulls/comments/229467656"},"html":{"href":"https://github.com/paritytech/parity-common/pull/71#discussion_r229467656"},"pull_request":{"href":"https://api.github.com/repos/paritytech/parity-common/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/parity-common/pulls/71","id":224486706,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDg2NzA2","html_url":"https://github.com/paritytech/parity-common/pull/71","diff_url":"https://github.com/paritytech/parity-common/pull/71.diff","patch_url":"https://github.com/paritytech/parity-common/pull/71.patch","issue_url":"https://api.github.com/repos/paritytech/parity-common/issues/71","number":71,"state":"open","locked":false,"title":"[fixed-hash] Major overhaul of `construct_hash!` macro","user":{"login":"Robbepop","id":8193155,"node_id":"MDQ6VXNlcjgxOTMxNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/8193155?v=4","gravatar_id":"","url":"https://api.github.com/users/Robbepop","html_url":"https://github.com/Robbepop","followers_url":"https://api.github.com/users/Robbepop/followers","following_url":"https://api.github.com/users/Robbepop/following{/other_user}","gists_url":"https://api.github.com/users/Robbepop/gists{/gist_id}","starred_url":"https://api.github.com/users/Robbepop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robbepop/subscriptions","organizations_url":"https://api.github.com/users/Robbepop/orgs","repos_url":"https://api.github.com/users/Robbepop/repos","events_url":"https://api.github.com/users/Robbepop/events{/privacy}","received_events_url":"https://api.github.com/users/Robbepop/received_events","type":"User","site_admin":false},"body":"# Overhaul of the entire sub-crate `fixed-hash`\r\n\r\n## Roadmap\r\n\r\n### Pre-merging\r\n\r\n- Sort out the last few nits with new features\r\n    - [x] Finalize documentation\r\n    - [x] Remove deprecated features\r\n    - [x] Test new features\r\n    - [x] Clean up public API\r\n\r\n- Merge this PR after\r\n    - [x] Merge of [PR](https://github.com/paritytech/parity-common/pull/72)\r\n    - [x] After release of [Rust 1.30](https://github.com/rust-lang/rust/blob/stable/RELEASES.md)\r\n\r\n- [x] Bump version to `0.3-beta.0` and publish on crates.io.\r\n\r\n### Post-merging\r\n\r\nTransit all below dependencies to the `0.3.0-beta.X` version of `fixed-hash`. Note that the `pwasm-*` crates currently depend on `parity-hash` instead of `fixed-hash` version `0.2`.\r\n\r\n- `pwasm-std` will provide new `uint` instances and updated `fixed-hash` instances without conversion between `uint` and `fixed-hash` since I cannot see that it has been provided yet\r\n- `pwasm-ethereum` will no longer link to `parity-hash` and instead use `pwasm-std`\r\n- `pwasm-abi` same as `pwasm-ethereum`\r\n- `ethbloom` simply update `fixed-hash`\r\n- `ethereum-types` update `fixed-hash`, but already provides `uint` conversions itself, so no need for providing them by `fixed-hash` either\r\n- `substrate-primitives` update `fixed-hash` but does not need `uint` conversion\r\n\r\n- Make any changes that might come up during the work on step 4 and publish `0.3-beta.X` as needed\r\n- Bump version to `0.3`, create a tag `fixed-hash-0.3` and publish `0.3`\r\n\r\n## Open Questions\r\n\r\n- What to do with `impl_hash_uint_conversions` macro?\r\n    - The problem: Why should it be defined in `fixed-hash` and not in `uint`?\r\n    - Possible solution: Maybe add another crate to combine `fixed-hash` and `uint` and allow for this macro.\r\n\r\n## Summary of changes\r\n\r\n- Major overhaul of the `construct_hash` macro\r\n    - Possibility to declare types with visibility modifier (not only `pub`)\r\n    - Possibility to add custom doc comment\r\n    - Syntactically more conforming to default Rust syntax\r\n    - Updated documentation and added examples\r\n- Major overhaul of the `impl_hash_conversion` macro\r\n    - No longer requires sizes of input types\r\n    - Added proper error handling for some conversions\r\n    - Updated documentation and added examples\r\n- The `std` feature is now a default feature for this crate\r\n- Removed items that have been deprecated in `0.2.5`\r\n- Removed bad usage of `AsRef<Self>` impl\r\n- Removed `serialize` crate feature\r\n","created_at":"2018-10-20T16:53:31Z","updated_at":"2018-10-30T20:11:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"735b026d7d3dc61d1e366e75479e74c2a2c53900","assignee":null,"assignees":[],"requested_reviewers":[{"login":"NikVolf","id":3186518,"node_id":"MDQ6VXNlcjMxODY1MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3186518?v=4","gravatar_id":"","url":"https://api.github.com/users/NikVolf","html_url":"https://github.com/NikVolf","followers_url":"https://api.github.com/users/NikVolf/followers","following_url":"https://api.github.com/users/NikVolf/following{/other_user}","gists_url":"https://api.github.com/users/NikVolf/gists{/gist_id}","starred_url":"https://api.github.com/users/NikVolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikVolf/subscriptions","organizations_url":"https://api.github.com/users/NikVolf/orgs","repos_url":"https://api.github.com/users/NikVolf/repos","events_url":"https://api.github.com/users/NikVolf/events{/privacy}","received_events_url":"https://api.github.com/users/NikVolf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":978995873,"node_id":"MDU6TGFiZWw5Nzg5OTU4NzM=","url":"https://api.github.com/repos/paritytech/parity-common/labels/A1-onice","name":"A1-onice","color":"c7def8","default":false},{"id":978995890,"node_id":"MDU6TGFiZWw5Nzg5OTU4OTA=","url":"https://api.github.com/repos/paritytech/parity-common/labels/A8-looksgood","name":"A8-looksgood","color":"C0E7CC","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/parity-common/pulls/71/commits","review_comments_url":"https://api.github.com/repos/paritytech/parity-common/pulls/71/comments","review_comment_url":"https://api.github.com/repos/paritytech/parity-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/parity-common/issues/71/comments","statuses_url":"https://api.github.com/repos/paritytech/parity-common/statuses/1badf67a17f528b071f6c6429385c7b827c7e498","head":{"label":"paritytech:api-refactorings","ref":"api-refactorings","sha":"1badf67a17f528b071f6c6429385c7b827c7e498","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":139124943,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxMjQ5NDM=","name":"parity-common","full_name":"paritytech/parity-common","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/parity-common","description":"Collection of crates used in Parity projects","fork":false,"url":"https://api.github.com/repos/paritytech/parity-common","forks_url":"https://api.github.com/repos/paritytech/parity-common/forks","keys_url":"https://api.github.com/repos/paritytech/parity-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity-common/teams","hooks_url":"https://api.github.com/repos/paritytech/parity-common/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity-common/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity-common/events","assignees_url":"https://api.github.com/repos/paritytech/parity-common/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity-common/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity-common/tags","blobs_url":"https://api.github.com/repos/paritytech/parity-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity-common/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity-common/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity-common/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity-common/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity-common/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity-common/subscription","commits_url":"https://api.github.com/repos/paritytech/parity-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity-common/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity-common/merges","archive_url":"https://api.github.com/repos/paritytech/parity-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity-common/downloads","issues_url":"https://api.github.com/repos/paritytech/parity-common/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity-common/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity-common/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity-common/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity-common/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity-common/deployments","created_at":"2018-06-29T08:45:55Z","updated_at":"2018-10-30T17:13:21Z","pushed_at":"2018-10-30T17:00:24Z","git_url":"git://github.com/paritytech/parity-common.git","ssh_url":"git@github.com:paritytech/parity-common.git","clone_url":"https://github.com/paritytech/parity-common.git","svn_url":"https://github.com/paritytech/parity-common","homepage":"https://www.paritytech.io/","size":842,"stargazers_count":26,"watchers_count":26,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":14,"open_issues":8,"watchers":26,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"9fdf2f6fbcca5d9225acf761ba65394337aeb6b4","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":139124943,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxMjQ5NDM=","name":"parity-common","full_name":"paritytech/parity-common","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/parity-common","description":"Collection of crates used in Parity projects","fork":false,"url":"https://api.github.com/repos/paritytech/parity-common","forks_url":"https://api.github.com/repos/paritytech/parity-common/forks","keys_url":"https://api.github.com/repos/paritytech/parity-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity-common/teams","hooks_url":"https://api.github.com/repos/paritytech/parity-common/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity-common/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity-common/events","assignees_url":"https://api.github.com/repos/paritytech/parity-common/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity-common/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity-common/tags","blobs_url":"https://api.github.com/repos/paritytech/parity-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity-common/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity-common/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity-common/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity-common/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity-common/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity-common/subscription","commits_url":"https://api.github.com/repos/paritytech/parity-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity-common/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity-common/merges","archive_url":"https://api.github.com/repos/paritytech/parity-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity-common/downloads","issues_url":"https://api.github.com/repos/paritytech/parity-common/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity-common/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity-common/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity-common/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity-common/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity-common/deployments","created_at":"2018-06-29T08:45:55Z","updated_at":"2018-10-30T17:13:21Z","pushed_at":"2018-10-30T17:00:24Z","git_url":"git://github.com/paritytech/parity-common.git","ssh_url":"git@github.com:paritytech/parity-common.git","clone_url":"https://github.com/paritytech/parity-common.git","svn_url":"https://github.com/paritytech/parity-common","homepage":"https://www.paritytech.io/","size":842,"stargazers_count":26,"watchers_count":26,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":14,"open_issues":8,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity-common/pulls/71"},"html":{"href":"https://github.com/paritytech/parity-common/pull/71"},"issue":{"href":"https://api.github.com/repos/paritytech/parity-common/issues/71"},"comments":{"href":"https://api.github.com/repos/paritytech/parity-common/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/parity-common/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/parity-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/parity-common/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/parity-common/statuses/1badf67a17f528b071f6c6429385c7b827c7e498"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dvdplm"}}