{"action":"created","issue":{"url":"https://api.github.com/repos/moira-alert/moira/issues/83","repository_url":"https://api.github.com/repos/moira-alert/moira","labels_url":"https://api.github.com/repos/moira-alert/moira/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/moira-alert/moira/issues/83/comments","events_url":"https://api.github.com/repos/moira-alert/moira/issues/83/events","html_url":"https://github.com/moira-alert/moira/pull/83","id":323566386,"number":83,"title":"Change default trigger state to TTLState","user":{"login":"titusjaka","id":5277948,"avatar_url":"https://avatars0.githubusercontent.com/u/5277948?v=4","gravatar_id":"","url":"https://api.github.com/users/titusjaka","html_url":"https://github.com/titusjaka","followers_url":"https://api.github.com/users/titusjaka/followers","following_url":"https://api.github.com/users/titusjaka/following{/other_user}","gists_url":"https://api.github.com/users/titusjaka/gists{/gist_id}","starred_url":"https://api.github.com/users/titusjaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titusjaka/subscriptions","organizations_url":"https://api.github.com/users/titusjaka/orgs","repos_url":"https://api.github.com/users/titusjaka/repos","events_url":"https://api.github.com/users/titusjaka/events{/privacy}","received_events_url":"https://api.github.com/users/titusjaka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-16T10:44:02Z","updated_at":"2018-05-16T13:50:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/moira-alert/moira/pulls/83","html_url":"https://github.com/moira-alert/moira/pull/83","diff_url":"https://github.com/moira-alert/moira/pull/83.diff","patch_url":"https://github.com/moira-alert/moira/pull/83.patch"},"body":"When you create a new trigger, switch its state as `TTLState` looks like a great idea. `TTLState` is an option which defines which state to set on trigger when no data provided. So, if you want to treat `NODATA` as `OK` its quite obvious to create trigger in `OK` state.\r\n\r\nThe second part is checking trigger without any metric inside. I think, we should set `TTLState` in this case too."},"comment":{"url":"https://api.github.com/repos/moira-alert/moira/issues/comments/389525606","html_url":"https://github.com/moira-alert/moira/pull/83#issuecomment-389525606","issue_url":"https://api.github.com/repos/moira-alert/moira/issues/83","id":389525606,"user":{"login":"titusjaka","id":5277948,"avatar_url":"https://avatars0.githubusercontent.com/u/5277948?v=4","gravatar_id":"","url":"https://api.github.com/users/titusjaka","html_url":"https://github.com/titusjaka","followers_url":"https://api.github.com/users/titusjaka/followers","following_url":"https://api.github.com/users/titusjaka/following{/other_user}","gists_url":"https://api.github.com/users/titusjaka/gists{/gist_id}","starred_url":"https://api.github.com/users/titusjaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titusjaka/subscriptions","organizations_url":"https://api.github.com/users/titusjaka/orgs","repos_url":"https://api.github.com/users/titusjaka/repos","events_url":"https://api.github.com/users/titusjaka/events{/privacy}","received_events_url":"https://api.github.com/users/titusjaka/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T13:50:36Z","updated_at":"2018-05-16T13:50:36Z","author_association":"CONTRIBUTOR","body":"Для старых проверок я тесты починил. Нужно написать тесты на новую логику, пока что они не работают. Точнее работают, а не должны."}}
{"actor":{"display_login":"titusjaka"}}