{"action":"created","issue":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/5118","repository_url":"https://api.github.com/repos/ankidroid/Anki-Android","labels_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/5118/labels{/name}","comments_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/5118/comments","events_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/5118/events","html_url":"https://github.com/ankidroid/Anki-Android/pull/5118","id":381755016,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjUxNjkx","number":5118,"title":"Use divider style attributes for deck item decorator","user":{"login":"mikehardy","id":782704,"node_id":"MDQ6VXNlcjc4MjcwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/782704?v=4","gravatar_id":"","url":"https://api.github.com/users/mikehardy","html_url":"https://github.com/mikehardy","followers_url":"https://api.github.com/users/mikehardy/followers","following_url":"https://api.github.com/users/mikehardy/following{/other_user}","gists_url":"https://api.github.com/users/mikehardy/gists{/gist_id}","starred_url":"https://api.github.com/users/mikehardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikehardy/subscriptions","organizations_url":"https://api.github.com/users/mikehardy/orgs","repos_url":"https://api.github.com/users/mikehardy/repos","events_url":"https://api.github.com/users/mikehardy/events{/privacy}","received_events_url":"https://api.github.com/users/mikehardy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/milestones/11","html_url":"https://github.com/ankidroid/Anki-Android/milestone/11","labels_url":"https://api.github.com/repos/ankidroid/Anki-Android/milestones/11/labels","id":3653591,"node_id":"MDk6TWlsZXN0b25lMzY1MzU5MQ==","number":11,"title":"v2.9 release","description":"","creator":{"login":"timrae","id":2818274,"node_id":"MDQ6VXNlcjI4MTgyNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2818274?v=4","gravatar_id":"","url":"https://api.github.com/users/timrae","html_url":"https://github.com/timrae","followers_url":"https://api.github.com/users/timrae/followers","following_url":"https://api.github.com/users/timrae/following{/other_user}","gists_url":"https://api.github.com/users/timrae/gists{/gist_id}","starred_url":"https://api.github.com/users/timrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timrae/subscriptions","organizations_url":"https://api.github.com/users/timrae/orgs","repos_url":"https://api.github.com/users/timrae/repos","events_url":"https://api.github.com/users/timrae/events{/privacy}","received_events_url":"https://api.github.com/users/timrae/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":23,"state":"open","created_at":"2018-09-14T02:44:57Z","updated_at":"2018-11-23T18:26:23Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-11-16T20:50:26Z","updated_at":"2018-11-24T00:18:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/pulls/5118","html_url":"https://github.com/ankidroid/Anki-Android/pull/5118","diff_url":"https://github.com/ankidroid/Anki-Android/pull/5118.diff","patch_url":"https://github.com/ankidroid/Anki-Android/pull/5118.patch"},"body":"In this commit https://github.com/ankidroid/Anki-Android/commit/9a04d086ee5b9ee83889d03ce9d0cd6bdf69ae8f#diff-f50a1149d9cb92269cbf94c417602c5cL21\r\n...we moved to the \"new\" framework item decorator that wasn't available when\r\nour custom implementation was written\r\n\r\nBut during the conversion I didn't correctly set the drawable style, this sets the style\r\nas it was prior\r\n\r\nShould Fix #4942\r\n\r\n## Pull Request template\r\n\r\n## Purpose / Description\r\n_Describe the problem or feature and motivation_\r\n\r\n## Fixes\r\n_Link to the issues._\r\n\r\n## Approach\r\n_How does this change address the problem?_\r\n\r\n## How Has This Been Tested?\r\n\r\nPlease describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)\r\n\r\n## Learning (optional, can help others)\r\n_Describe the research stage_\r\n\r\n_Links to blog posts, patterns, libraries or addons used to solve this problem_\r\n\r\n## Checklist\r\n_Please, go through these checks before submitting the PR._\r\n\r\n- [ ] You have not changed whitespace unnecessarily (it makes diffs hard to read)\r\n- [ ] You have a descriptive commit message with a short title (first line, max 50 chars).\r\n- [ ] Your code follows the style of the project (e.g. never omit braces in `if` statements) \r\n- [ ] You have commented your code, particularly in hard-to-understand areas\r\n- [ ] You have performed a self-review of your own code\r\n"},"comment":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/comments/441332218","html_url":"https://github.com/ankidroid/Anki-Android/pull/5118#issuecomment-441332218","issue_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/5118","id":441332218,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTMzMjIxOA==","user":{"login":"timrae","id":2818274,"node_id":"MDQ6VXNlcjI4MTgyNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2818274?v=4","gravatar_id":"","url":"https://api.github.com/users/timrae","html_url":"https://github.com/timrae","followers_url":"https://api.github.com/users/timrae/followers","following_url":"https://api.github.com/users/timrae/following{/other_user}","gists_url":"https://api.github.com/users/timrae/gists{/gist_id}","starred_url":"https://api.github.com/users/timrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timrae/subscriptions","organizations_url":"https://api.github.com/users/timrae/orgs","repos_url":"https://api.github.com/users/timrae/repos","events_url":"https://api.github.com/users/timrae/events{/privacy}","received_events_url":"https://api.github.com/users/timrae/received_events","type":"User","site_admin":false},"created_at":"2018-11-24T00:18:07Z","updated_at":"2018-11-24T00:18:07Z","author_association":"MEMBER","body":"Yeah sorry for the vague and blunt comment above, I'm a bit stressed out recently... My knee-jerk reaction was that the main point of the divider item class is to encapsulate the drawable related code, so overriding it in the activity is pretty meh. I guess the framework divider drawable has a small margin in it which we don't have in the one from 38e0931. When I took screenshots and compared them side by side, I can agree that the difference is not all that noticeable, but my eyes did pick up on it right away, and it seems we forgot to pull out the custom divider item drawable anyway so maybe I'll just accept this PR. The better way would be to make a new class overriding the framework and encapsulating this code in there, but I'm sure we all have more important things to do than that lol."}}
{"actor":{"display_login":"timrae"}}