{"action":"created","issue":{"url":"https://api.github.com/repos/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues/315","repository_url":"https://api.github.com/repos/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL","labels_url":"https://api.github.com/repos/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues/315/labels{/name}","comments_url":"https://api.github.com/repos/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues/315/comments","events_url":"https://api.github.com/repos/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues/315/events","html_url":"https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/pull/315","id":300843008,"number":315,"title":"Full text search LINQ support","user":{"login":"rwasef1830","id":4632253,"avatar_url":"https://avatars0.githubusercontent.com/u/4632253?v=4","gravatar_id":"","url":"https://api.github.com/users/rwasef1830","html_url":"https://github.com/rwasef1830","followers_url":"https://api.github.com/users/rwasef1830/followers","following_url":"https://api.github.com/users/rwasef1830/following{/other_user}","gists_url":"https://api.github.com/users/rwasef1830/gists{/gist_id}","starred_url":"https://api.github.com/users/rwasef1830/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwasef1830/subscriptions","organizations_url":"https://api.github.com/users/rwasef1830/orgs","repos_url":"https://api.github.com/users/rwasef1830/repos","events_url":"https://api.github.com/users/rwasef1830/events{/privacy}","received_events_url":"https://api.github.com/users/rwasef1830/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-02-28T00:14:32Z","updated_at":"2018-03-29T07:30:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/pulls/315","html_url":"https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/pull/315","diff_url":"https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/pull/315.diff","patch_url":"https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/pull/315.patch"},"body":"Hello,\r\nThis resolves #1 and implements full text LINQ query support with all methods and operators. It also adds an explicit casting function (EF.Functions.Cast) for edge cases (when needed). This brings it in feature parity with the EF6 provider.\r\n\r\nThanks @roji for the hints along the way. Hoping for a review and merge 👍 "},"comment":{"url":"https://api.github.com/repos/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues/comments/377148321","html_url":"https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/pull/315#issuecomment-377148321","issue_url":"https://api.github.com/repos/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues/315","id":377148321,"user":{"login":"roji","id":1862641,"avatar_url":"https://avatars0.githubusercontent.com/u/1862641?v=4","gravatar_id":"","url":"https://api.github.com/users/roji","html_url":"https://github.com/roji","followers_url":"https://api.github.com/users/roji/followers","following_url":"https://api.github.com/users/roji/following{/other_user}","gists_url":"https://api.github.com/users/roji/gists{/gist_id}","starred_url":"https://api.github.com/users/roji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roji/subscriptions","organizations_url":"https://api.github.com/users/roji/orgs","repos_url":"https://api.github.com/users/roji/repos","events_url":"https://api.github.com/users/roji/events{/privacy}","received_events_url":"https://api.github.com/users/roji/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T07:30:04Z","updated_at":"2018-03-29T07:30:04Z","author_association":"OWNER","body":"Merged to dev via 05cedfdde0e70e0ee80b21488a24eead7d467e25 (and f35bed978f3fc8071c3e31d04dd020916fb6786e), thanks for all this work @rwasef1830! It's great to have PostgreSQL full-text search support!\r\n\r\nOne question: how would you feel about an overload of `Matches()` that accepts a string, an implicitly does `to_tsquery` to convert it to a query? I'm asking because looking at [this test code](https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/blob/05cedfdde0e70e0ee80b21488a24eead7d467e25/test/EFCore.PG.FunctionalTests/Query/FullTextSearchDbFunctionsNpgsqlTest.cs#L696, things seem needlessly verbose with EF.Functions everywhere. There could be other functions where such overloads could make sense.\r\n\r\nAlso, can you please open an issue to track support for `array_to_tsvector`, just so we have it in the backlog somewhere?"}}
{"actor":{"display_login":"roji"}}