{"action":"opened","number":70250,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70250","id":225865711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODY1NzEx","html_url":"https://github.com/kubernetes/kubernetes/pull/70250","diff_url":"https://github.com/kubernetes/kubernetes/pull/70250.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70250.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70250","number":70250,"state":"open","locked":false,"title":"Gcp credentails file token source","user":{"login":"curtisallen","id":270735,"node_id":"MDQ6VXNlcjI3MDczNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/270735?v=4","gravatar_id":"","url":"https://api.github.com/users/curtisallen","html_url":"https://github.com/curtisallen","followers_url":"https://api.github.com/users/curtisallen/followers","following_url":"https://api.github.com/users/curtisallen/following{/other_user}","gists_url":"https://api.github.com/users/curtisallen/gists{/gist_id}","starred_url":"https://api.github.com/users/curtisallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curtisallen/subscriptions","organizations_url":"https://api.github.com/users/curtisallen/orgs","repos_url":"https://api.github.com/users/curtisallen/repos","events_url":"https://api.github.com/users/curtisallen/events{/privacy}","received_events_url":"https://api.github.com/users/curtisallen/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n> Uncomment only one, leave it on its own line:\r\n>\r\n> /kind api-change\r\n> /kind bug\r\n> /kind cleanup\r\n> /kind design\r\n> /kind documentation\r\n> /kind failing-test\r\n\r\n/kind feature\r\n\r\n> /kind flake\r\n\r\n**What this PR does / why we need it**:\r\nUpdates `client-go`'s GCP token source, allowing users to specify `credentials-file` when creating a token source. Currently, if you don't set \"cmd-path\" then client-go will use the Google Application Credentials defined by `google.FindDefaultCredentials`. This works well except if you want to allow a process to connect to multiple clusters there is no way to specify multiple Google Application Credentials sources. This change allows you to set `credentials-file` in the config for gcp auth to make it easier to support connecting to multiple clusters.\r\n\r\n**Special notes for your reviewer**: https://github.com/kubernetes/kubernetes/commit/ed58f37e794053fb9911f154b50bd8e20feaa53c updates golang.org/x/oauth2 as there were some updates to the GCP provider. \r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\nNONE","created_at":"2018-10-25T18:50:47Z","updated_at":"2018-10-25T18:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70250/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70250/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70250/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ad22505a9d98125394b0d5d2453c77631976634a","head":{"label":"curtisallen:gcp-credentails-file-token-source","ref":"gcp-credentails-file-token-source","sha":"ad22505a9d98125394b0d5d2453c77631976634a","user":{"login":"curtisallen","id":270735,"node_id":"MDQ6VXNlcjI3MDczNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/270735?v=4","gravatar_id":"","url":"https://api.github.com/users/curtisallen","html_url":"https://github.com/curtisallen","followers_url":"https://api.github.com/users/curtisallen/followers","following_url":"https://api.github.com/users/curtisallen/following{/other_user}","gists_url":"https://api.github.com/users/curtisallen/gists{/gist_id}","starred_url":"https://api.github.com/users/curtisallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curtisallen/subscriptions","organizations_url":"https://api.github.com/users/curtisallen/orgs","repos_url":"https://api.github.com/users/curtisallen/repos","events_url":"https://api.github.com/users/curtisallen/events{/privacy}","received_events_url":"https://api.github.com/users/curtisallen/received_events","type":"User","site_admin":false},"repo":{"id":84243460,"node_id":"MDEwOlJlcG9zaXRvcnk4NDI0MzQ2MA==","name":"kubernetes","full_name":"curtisallen/kubernetes","private":false,"owner":{"login":"curtisallen","id":270735,"node_id":"MDQ6VXNlcjI3MDczNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/270735?v=4","gravatar_id":"","url":"https://api.github.com/users/curtisallen","html_url":"https://github.com/curtisallen","followers_url":"https://api.github.com/users/curtisallen/followers","following_url":"https://api.github.com/users/curtisallen/following{/other_user}","gists_url":"https://api.github.com/users/curtisallen/gists{/gist_id}","starred_url":"https://api.github.com/users/curtisallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curtisallen/subscriptions","organizations_url":"https://api.github.com/users/curtisallen/orgs","repos_url":"https://api.github.com/users/curtisallen/repos","events_url":"https://api.github.com/users/curtisallen/events{/privacy}","received_events_url":"https://api.github.com/users/curtisallen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/curtisallen/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/curtisallen/kubernetes","forks_url":"https://api.github.com/repos/curtisallen/kubernetes/forks","keys_url":"https://api.github.com/repos/curtisallen/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/curtisallen/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/curtisallen/kubernetes/teams","hooks_url":"https://api.github.com/repos/curtisallen/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/curtisallen/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/curtisallen/kubernetes/events","assignees_url":"https://api.github.com/repos/curtisallen/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/curtisallen/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/curtisallen/kubernetes/tags","blobs_url":"https://api.github.com/repos/curtisallen/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/curtisallen/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/curtisallen/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/curtisallen/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/curtisallen/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/curtisallen/kubernetes/languages","stargazers_url":"https://api.github.com/repos/curtisallen/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/curtisallen/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/curtisallen/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/curtisallen/kubernetes/subscription","commits_url":"https://api.github.com/repos/curtisallen/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/curtisallen/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/curtisallen/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/curtisallen/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/curtisallen/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/curtisallen/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/curtisallen/kubernetes/merges","archive_url":"https://api.github.com/repos/curtisallen/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/curtisallen/kubernetes/downloads","issues_url":"https://api.github.com/repos/curtisallen/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/curtisallen/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/curtisallen/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/curtisallen/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/curtisallen/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/curtisallen/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/curtisallen/kubernetes/deployments","created_at":"2017-03-07T20:34:43Z","updated_at":"2017-03-07T20:35:15Z","pushed_at":"2018-10-25T18:29:43Z","git_url":"git://github.com/curtisallen/kubernetes.git","ssh_url":"git@github.com:curtisallen/kubernetes.git","clone_url":"https://github.com/curtisallen/kubernetes.git","svn_url":"https://github.com/curtisallen/kubernetes","homepage":"http://kubernetes.io","size":409221,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"12cf5451952c8425a47334465f3e03d7ca181956","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-10-25T18:25:31Z","pushed_at":"2018-10-25T18:50:24Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":808521,"stargazers_count":43025,"watchers_count":43025,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14950,"mirror_url":null,"archived":false,"open_issues_count":3187,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14950,"open_issues":3187,"watchers":43025,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70250"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/70250"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/70250"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/70250/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70250/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70250/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ad22505a9d98125394b0d5d2453c77631976634a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":515,"deletions":250,"changed_files":26}}
{"actor":{"display_login":"curtisallen"}}