{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/3711","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3711/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3711/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3711/events","html_url":"https://github.com/trilinos/Trilinos/pull/3711","id":373033727,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MDYzNzUx","number":3711,"title":"Tempus: Improve Observer Names.","user":{"login":"ccober6","id":19675338,"node_id":"MDQ6VXNlcjE5Njc1MzM4","avatar_url":"https://avatars2.githubusercontent.com/u/19675338?v=4","gravatar_id":"","url":"https://api.github.com/users/ccober6","html_url":"https://github.com/ccober6","followers_url":"https://api.github.com/users/ccober6/followers","following_url":"https://api.github.com/users/ccober6/following{/other_user}","gists_url":"https://api.github.com/users/ccober6/gists{/gist_id}","starred_url":"https://api.github.com/users/ccober6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccober6/subscriptions","organizations_url":"https://api.github.com/users/ccober6/orgs","repos_url":"https://api.github.com/users/ccober6/repos","events_url":"https://api.github.com/users/ccober6/events{/privacy}","received_events_url":"https://api.github.com/users/ccober6/received_events","type":"User","site_admin":false},"labels":[{"id":978422145,"node_id":"MDU6TGFiZWw5Nzg0MjIxNDU=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/AT:%20AUTOMERGE","name":"AT: AUTOMERGE","color":"00cd00","default":false},{"id":1085487687,"node_id":"MDU6TGFiZWwxMDg1NDg3Njg3","url":"https://api.github.com/repos/trilinos/Trilinos/labels/SPARC","name":"SPARC","color":"e24da7","default":false},{"id":604664600,"node_id":"MDU6TGFiZWw2MDQ2NjQ2MDA=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/Tempus","name":"Tempus","color":"d93f0b","default":false},{"id":287520105,"node_id":"MDU6TGFiZWwyODc1MjAxMDU=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":318642986,"node_id":"MDU6TGFiZWwzMTg2NDI5ODY=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"ccober6","id":19675338,"node_id":"MDQ6VXNlcjE5Njc1MzM4","avatar_url":"https://avatars2.githubusercontent.com/u/19675338?v=4","gravatar_id":"","url":"https://api.github.com/users/ccober6","html_url":"https://github.com/ccober6","followers_url":"https://api.github.com/users/ccober6/followers","following_url":"https://api.github.com/users/ccober6/following{/other_user}","gists_url":"https://api.github.com/users/ccober6/gists{/gist_id}","starred_url":"https://api.github.com/users/ccober6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccober6/subscriptions","organizations_url":"https://api.github.com/users/ccober6/orgs","repos_url":"https://api.github.com/users/ccober6/repos","events_url":"https://api.github.com/users/ccober6/events{/privacy}","received_events_url":"https://api.github.com/users/ccober6/received_events","type":"User","site_admin":false},"assignees":[{"login":"ccober6","id":19675338,"node_id":"MDQ6VXNlcjE5Njc1MzM4","avatar_url":"https://avatars2.githubusercontent.com/u/19675338?v=4","gravatar_id":"","url":"https://api.github.com/users/ccober6","html_url":"https://github.com/ccober6","followers_url":"https://api.github.com/users/ccober6/followers","following_url":"https://api.github.com/users/ccober6/following{/other_user}","gists_url":"https://api.github.com/users/ccober6/gists{/gist_id}","starred_url":"https://api.github.com/users/ccober6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccober6/subscriptions","organizations_url":"https://api.github.com/users/ccober6/orgs","repos_url":"https://api.github.com/users/ccober6/repos","events_url":"https://api.github.com/users/ccober6/events{/privacy}","received_events_url":"https://api.github.com/users/ccober6/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-10-23T14:32:58Z","updated_at":"2018-10-24T01:54:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/3711","html_url":"https://github.com/trilinos/Trilinos/pull/3711","diff_url":"https://github.com/trilinos/Trilinos/pull/3711.diff","patch_url":"https://github.com/trilinos/Trilinos/pull/3711.patch"},"body":"Made changes to reduce confusion related to\r\nIntegratorObserver::acceptTimeStep().  acceptTimeStep() checked if\r\nthe timestep should be accepted or failed and promoting if passing.\r\n“acceptTimeStep” was being read as a statement, \"accept the timestep\",\r\nwhen it was meant as a question, “accept the timestep?”.  To reduce\r\nthis confusion, acceptTimeStep has been split into the determination\r\nof the time step passing (now checkTimeStep()) and promotion of the\r\ntime step (now promoteWorkingState() is part of the Integrator time\r\nloop).  Also two observers, observeAfterCheckTimeStep() and\r\nobserveEndTimeStep, have replaced the observeAcceptedTimeStep().\r\nWork previously completed in observeAcceptedTimeStep() will likely\r\nmove into observeEndTimeStep(), unless it deals with the acceptance\r\nof a time step as passing which would go into observeAfterCheckTimeStep().\r\n\r\nPassed all tests.\r\n\r\nCloses #3697 \r\n\r\n<!---\r\nBe sure to select `develop` as the `base` branch against which to create this\r\npull request.  Only pull requests against `develop` will undergo Trilinos'\r\nautomated testing.  Pull requests against `master` will be ignored.\r\n\r\nProvide a general summary of your changes in the Title above.  If this pull\r\nrequest pertains to a particular package in Trilinos, it's worthwhile to start\r\nthe title with \"PackageName:  \".\r\n\r\nNote that anything between these delimiters is a comment that will not appear\r\nin the pull request description once created. Most areas in this message are\r\ncommented out and can be easily added by removing the comment delimiters.\r\n\r\nPlease make sure to mark:\r\n* Reviewers\r\n* Assignees\r\n* Labels\r\n\r\nReplace <teamName> below with the appropriate Trilinos package/team name.\r\n-->\r\n@trilinos/tempus \r\n\r\n## Checklist\r\n\r\n- [x] My commit messages mention the appropriate GitHub issue numbers.\r\n- [x] My code follows the code style of the affected package(s).\r\n- [x] All new and existing tests passed.\r\n- [x] No new compiler warnings were introduced.\r\n- [x] These changes break backwards compatibility.\r\n\r\n<!--- \r\n## Additional Information\r\nAnything else we need to know in evaluating this merge request?\r\n -->\r\n"},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/432483614","html_url":"https://github.com/trilinos/Trilinos/pull/3711#issuecomment-432483614","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3711","id":432483614,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjQ4MzYxNA==","user":{"login":"trilinos-autotester","id":26070492,"node_id":"MDQ6VXNlcjI2MDcwNDky","avatar_url":"https://avatars2.githubusercontent.com/u/26070492?v=4","gravatar_id":"","url":"https://api.github.com/users/trilinos-autotester","html_url":"https://github.com/trilinos-autotester","followers_url":"https://api.github.com/users/trilinos-autotester/followers","following_url":"https://api.github.com/users/trilinos-autotester/following{/other_user}","gists_url":"https://api.github.com/users/trilinos-autotester/gists{/gist_id}","starred_url":"https://api.github.com/users/trilinos-autotester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trilinos-autotester/subscriptions","organizations_url":"https://api.github.com/users/trilinos-autotester/orgs","repos_url":"https://api.github.com/users/trilinos-autotester/repos","events_url":"https://api.github.com/users/trilinos-autotester/events{/privacy}","received_events_url":"https://api.github.com/users/trilinos-autotester/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T01:54:54Z","updated_at":"2018-10-24T01:54:54Z","author_association":"CONTRIBUTOR","body":"Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED\n\n<details>\n<summary>\n  <b>Pull Request Auto Testing has PASSED</b> (click to expand)\n</summary>\n\n<h2>Build Information</h2>\n<h3>Test Name: Trilinos_pullrequest_intel_17.0.1</h3>\n<ul>\n  <li>Build Num: 1471</li>\n  <li>Status: PASSED</li>\n</ul>\n\n<h4>Jenkins Parameters</h4>\n<table>\n  <tr>\n    <th>Parameter Name</th>\n    <th>Value</th>\n  </tr>\n\n  <tr>\n    <td>PULLREQUESTNUM</td>\n    <td>3711</td>\n  </tr>\n\n  <tr>\n    <td>TEST_REPO_ALIAS</td>\n    <td>TRILINOS</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_SOURCE_BRANCH</td>\n    <td>tempus-improve-observer-name-3697</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_SOURCE_REPO</td>\n    <td>https://github.com/trilinos/Trilinos</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_SOURCE_SHA</td>\n    <td>39bf8c26ec881adac7c7eb171562a99ef3fe3028</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_TARGET_BRANCH</td>\n    <td>develop</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_TARGET_REPO</td>\n    <td>https://github.com/trilinos/Trilinos</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_TARGET_SHA</td>\n    <td>88a2cdc6e5374aa558da7a0a9d7a25379dcdcb63</td>\n  </tr>\n</table>\n\n<h2>Build Information</h2>\n<h3>Test Name: Trilinos_pullrequest_gcc_4.9.3</h3>\n<ul>\n  <li>Build Num: 2034</li>\n  <li>Status: PASSED</li>\n</ul>\n\n<h4>Jenkins Parameters</h4>\n<table>\n  <tr>\n    <th>Parameter Name</th>\n    <th>Value</th>\n  </tr>\n\n  <tr>\n    <td>COMPILER_MODULE</td>\n    <td>sems-gcc/4.9.3</td>\n  </tr>\n\n  <tr>\n    <td>JENKINS_BUILD_TYPE</td>\n    <td>Release</td>\n  </tr>\n\n  <tr>\n    <td>JENKINS_COMM_TYPE</td>\n    <td>MPI</td>\n  </tr>\n\n  <tr>\n    <td>JENKINS_DO_COMPLEX</td>\n    <td>OFF</td>\n  </tr>\n\n  <tr>\n    <td>JENKINS_JOB_TYPE</td>\n    <td>Experimental</td>\n  </tr>\n\n  <tr>\n    <td>MPI_MODULE</td>\n    <td>sems-openmpi/1.8.7</td>\n  </tr>\n\n  <tr>\n    <td>PULLREQUESTNUM</td>\n    <td>3711</td>\n  </tr>\n\n  <tr>\n    <td>TEST_REPO_ALIAS</td>\n    <td>TRILINOS</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_SOURCE_BRANCH</td>\n    <td>tempus-improve-observer-name-3697</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_SOURCE_REPO</td>\n    <td>https://github.com/trilinos/Trilinos</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_SOURCE_SHA</td>\n    <td>39bf8c26ec881adac7c7eb171562a99ef3fe3028</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_TARGET_BRANCH</td>\n    <td>develop</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_TARGET_REPO</td>\n    <td>https://github.com/trilinos/Trilinos</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_TARGET_SHA</td>\n    <td>88a2cdc6e5374aa558da7a0a9d7a25379dcdcb63</td>\n  </tr>\n</table>\n\n<h2>Build Information</h2>\n<h3>Test Name: Trilinos_pullrequest_gcc_4.8.4</h3>\n<ul>\n  <li>Build Num: 1696</li>\n  <li>Status: PASSED</li>\n</ul>\n\n<h4>Jenkins Parameters</h4>\n<table>\n  <tr>\n    <th>Parameter Name</th>\n    <th>Value</th>\n  </tr>\n\n  <tr>\n    <td>COMPILER_MODULE</td>\n    <td>sems-gcc/4.8.4</td>\n  </tr>\n\n  <tr>\n    <td>JENKINS_BUILD_TYPE</td>\n    <td>Release</td>\n  </tr>\n\n  <tr>\n    <td>JENKINS_COMM_TYPE</td>\n    <td>MPI</td>\n  </tr>\n\n  <tr>\n    <td>JENKINS_DO_COMPLEX</td>\n    <td>OFF</td>\n  </tr>\n\n  <tr>\n    <td>JENKINS_JOB_TYPE</td>\n    <td>Experimental</td>\n  </tr>\n\n  <tr>\n    <td>MPI_MODULE</td>\n    <td>sems-openmpi/1.8.7</td>\n  </tr>\n\n  <tr>\n    <td>PULLREQUESTNUM</td>\n    <td>3711</td>\n  </tr>\n\n  <tr>\n    <td>TEST_REPO_ALIAS</td>\n    <td>TRILINOS</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_SOURCE_BRANCH</td>\n    <td>tempus-improve-observer-name-3697</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_SOURCE_REPO</td>\n    <td>https://github.com/trilinos/Trilinos</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_SOURCE_SHA</td>\n    <td>39bf8c26ec881adac7c7eb171562a99ef3fe3028</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_TARGET_BRANCH</td>\n    <td>develop</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_TARGET_REPO</td>\n    <td>https://github.com/trilinos/Trilinos</td>\n  </tr>\n\n  <tr>\n    <td>TRILINOS_TARGET_SHA</td>\n    <td>88a2cdc6e5374aa558da7a0a9d7a25379dcdcb63</td>\n  </tr>\n</table>\n</details>\n\n\n<br>[CDash Test Results for PR# 3711.](https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=2&showfilters=1&filtercombine=and&field1=buildname&compare1=63&value1=PR-3711-test&field2=buildstarttime&compare2=84&value2=NOW\n)<br>"}}
{"actor":{"display_login":"trilinos-autotester"}}