{"action":"created","comment":{"url":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/comments/230224950","pull_request_review_id":170915739,"id":230224950,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDIyNDk1MA==","diff_hunk":"@@ -0,0 +1,21 @@\n+# Common fields between v2 A and B peripherals\n+\n+CR1:\n+  UESM:\n+    Disabled: [0, \"USART not able to wake up the MCU from Stop mode\"]\n+    Enabled: [1, \"USART able to wake up the MCU from Stop mode\"]\n+CR3:\n+  WUFIE:\n+    Inhibited: [0, \"Interrupt is inhibited\"]\n+    Interrupted: [1, \"An USART interrupt is generated whenever WUF=1 in the ISR register\"]\n+  WUS:\n+    Address: [0, \"WUF active on address match\"]\n+    Start: [2, \"WuF active on Start bit detection\"]","path":"peripherals/usart/_v2_AB_common.yaml","position":13,"original_position":13,"commit_id":"513f96c62a13f3819a56c3b7d568549992f5984c","original_commit_id":"d19f8d8edd4985c580af504f548e029e65e502a5","user":{"login":"adamgreig","id":47219,"node_id":"MDQ6VXNlcjQ3MjE5","avatar_url":"https://avatars2.githubusercontent.com/u/47219?v=4","gravatar_id":"","url":"https://api.github.com/users/adamgreig","html_url":"https://github.com/adamgreig","followers_url":"https://api.github.com/users/adamgreig/followers","following_url":"https://api.github.com/users/adamgreig/following{/other_user}","gists_url":"https://api.github.com/users/adamgreig/gists{/gist_id}","starred_url":"https://api.github.com/users/adamgreig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamgreig/subscriptions","organizations_url":"https://api.github.com/users/adamgreig/orgs","repos_url":"https://api.github.com/users/adamgreig/repos","events_url":"https://api.github.com/users/adamgreig/events{/privacy}","received_events_url":"https://api.github.com/users/adamgreig/received_events","type":"User","site_admin":false},"body":"Sorry, I wasn't clear, I was referring to the lower-case `u` in `WuF`. Though checking the RM more carefully I see it makes the same typo. Still I think we should probably write `WUF` since `WuF` doesn't make sense.","created_at":"2018-11-01T22:50:14Z","updated_at":"2018-11-01T22:50:15Z","html_url":"https://github.com/adamgreig/stm32-rs/pull/75#discussion_r230224950","pull_request_url":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/75","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/comments/230224950"},"html":{"href":"https://github.com/adamgreig/stm32-rs/pull/75#discussion_r230224950"},"pull_request":{"href":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/75"}},"in_reply_to_id":229883958},"pull_request":{"url":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/75","id":224478001,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDc4MDAx","html_url":"https://github.com/adamgreig/stm32-rs/pull/75","diff_url":"https://github.com/adamgreig/stm32-rs/pull/75.diff","patch_url":"https://github.com/adamgreig/stm32-rs/pull/75.patch","issue_url":"https://api.github.com/repos/adamgreig/stm32-rs/issues/75","number":75,"state":"open","locked":false,"title":"Documents some USART and LPUART","user":{"login":"octronics","id":43217372,"node_id":"MDQ6VXNlcjQzMjE3Mzcy","avatar_url":"https://avatars0.githubusercontent.com/u/43217372?v=4","gravatar_id":"","url":"https://api.github.com/users/octronics","html_url":"https://github.com/octronics","followers_url":"https://api.github.com/users/octronics/followers","following_url":"https://api.github.com/users/octronics/following{/other_user}","gists_url":"https://api.github.com/users/octronics/gists{/gist_id}","starred_url":"https://api.github.com/users/octronics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octronics/subscriptions","organizations_url":"https://api.github.com/users/octronics/orgs","repos_url":"https://api.github.com/users/octronics/repos","events_url":"https://api.github.com/users/octronics/events{/privacy}","received_events_url":"https://api.github.com/users/octronics/received_events","type":"User","site_admin":false},"body":"F0, F3, F7, H7, L0 and L4 families are covered.\r\n\r\nI versioned  the peripherals with v2 to differentiate with other family (UART and USART) peripherals. I use arbitrary letter for subdividing the USART v2 peripherals tree.\r\n\r\nThe fields are documented but the svd get not patched, caused by #67 issue. So I can't checks if all fields are documented. I greatly appreciate If you can help me to find how to make include inside peripheral working. ","created_at":"2018-10-20T14:27:32Z","updated_at":"2018-11-01T22:50:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77ab0e7a1f738a1938c663108dc9f2d0b7f150ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/75/commits","review_comments_url":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/75/comments","review_comment_url":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adamgreig/stm32-rs/issues/75/comments","statuses_url":"https://api.github.com/repos/adamgreig/stm32-rs/statuses/513f96c62a13f3819a56c3b7d568549992f5984c","head":{"label":"octronics:serial","ref":"serial","sha":"513f96c62a13f3819a56c3b7d568549992f5984c","user":{"login":"octronics","id":43217372,"node_id":"MDQ6VXNlcjQzMjE3Mzcy","avatar_url":"https://avatars0.githubusercontent.com/u/43217372?v=4","gravatar_id":"","url":"https://api.github.com/users/octronics","html_url":"https://github.com/octronics","followers_url":"https://api.github.com/users/octronics/followers","following_url":"https://api.github.com/users/octronics/following{/other_user}","gists_url":"https://api.github.com/users/octronics/gists{/gist_id}","starred_url":"https://api.github.com/users/octronics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octronics/subscriptions","organizations_url":"https://api.github.com/users/octronics/orgs","repos_url":"https://api.github.com/users/octronics/repos","events_url":"https://api.github.com/users/octronics/events{/privacy}","received_events_url":"https://api.github.com/users/octronics/received_events","type":"User","site_admin":false},"repo":{"id":148522819,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1MjI4MTk=","name":"stm32-rs","full_name":"octronics/stm32-rs","private":false,"owner":{"login":"octronics","id":43217372,"node_id":"MDQ6VXNlcjQzMjE3Mzcy","avatar_url":"https://avatars0.githubusercontent.com/u/43217372?v=4","gravatar_id":"","url":"https://api.github.com/users/octronics","html_url":"https://github.com/octronics","followers_url":"https://api.github.com/users/octronics/followers","following_url":"https://api.github.com/users/octronics/following{/other_user}","gists_url":"https://api.github.com/users/octronics/gists{/gist_id}","starred_url":"https://api.github.com/users/octronics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octronics/subscriptions","organizations_url":"https://api.github.com/users/octronics/orgs","repos_url":"https://api.github.com/users/octronics/repos","events_url":"https://api.github.com/users/octronics/events{/privacy}","received_events_url":"https://api.github.com/users/octronics/received_events","type":"User","site_admin":false},"html_url":"https://github.com/octronics/stm32-rs","description":"Embedded rust device crates for STM32 microcontrollers","fork":true,"url":"https://api.github.com/repos/octronics/stm32-rs","forks_url":"https://api.github.com/repos/octronics/stm32-rs/forks","keys_url":"https://api.github.com/repos/octronics/stm32-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/octronics/stm32-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/octronics/stm32-rs/teams","hooks_url":"https://api.github.com/repos/octronics/stm32-rs/hooks","issue_events_url":"https://api.github.com/repos/octronics/stm32-rs/issues/events{/number}","events_url":"https://api.github.com/repos/octronics/stm32-rs/events","assignees_url":"https://api.github.com/repos/octronics/stm32-rs/assignees{/user}","branches_url":"https://api.github.com/repos/octronics/stm32-rs/branches{/branch}","tags_url":"https://api.github.com/repos/octronics/stm32-rs/tags","blobs_url":"https://api.github.com/repos/octronics/stm32-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/octronics/stm32-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/octronics/stm32-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/octronics/stm32-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/octronics/stm32-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/octronics/stm32-rs/languages","stargazers_url":"https://api.github.com/repos/octronics/stm32-rs/stargazers","contributors_url":"https://api.github.com/repos/octronics/stm32-rs/contributors","subscribers_url":"https://api.github.com/repos/octronics/stm32-rs/subscribers","subscription_url":"https://api.github.com/repos/octronics/stm32-rs/subscription","commits_url":"https://api.github.com/repos/octronics/stm32-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/octronics/stm32-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/octronics/stm32-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/octronics/stm32-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/octronics/stm32-rs/contents/{+path}","compare_url":"https://api.github.com/repos/octronics/stm32-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/octronics/stm32-rs/merges","archive_url":"https://api.github.com/repos/octronics/stm32-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/octronics/stm32-rs/downloads","issues_url":"https://api.github.com/repos/octronics/stm32-rs/issues{/number}","pulls_url":"https://api.github.com/repos/octronics/stm32-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/octronics/stm32-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/octronics/stm32-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/octronics/stm32-rs/labels{/name}","releases_url":"https://api.github.com/repos/octronics/stm32-rs/releases{/id}","deployments_url":"https://api.github.com/repos/octronics/stm32-rs/deployments","created_at":"2018-09-12T18:19:00Z","updated_at":"2018-10-08T19:24:21Z","pushed_at":"2018-11-01T14:28:30Z","git_url":"git://github.com/octronics/stm32-rs.git","ssh_url":"git@github.com:octronics/stm32-rs.git","clone_url":"https://github.com/octronics/stm32-rs.git","svn_url":"https://github.com/octronics/stm32-rs","homepage":"https://stm32.agg.io/rs","size":8001,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adamgreig:master","ref":"master","sha":"89c521b6671e3e81ab7468541b4468bad741139c","user":{"login":"adamgreig","id":47219,"node_id":"MDQ6VXNlcjQ3MjE5","avatar_url":"https://avatars2.githubusercontent.com/u/47219?v=4","gravatar_id":"","url":"https://api.github.com/users/adamgreig","html_url":"https://github.com/adamgreig","followers_url":"https://api.github.com/users/adamgreig/followers","following_url":"https://api.github.com/users/adamgreig/following{/other_user}","gists_url":"https://api.github.com/users/adamgreig/gists{/gist_id}","starred_url":"https://api.github.com/users/adamgreig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamgreig/subscriptions","organizations_url":"https://api.github.com/users/adamgreig/orgs","repos_url":"https://api.github.com/users/adamgreig/repos","events_url":"https://api.github.com/users/adamgreig/events{/privacy}","received_events_url":"https://api.github.com/users/adamgreig/received_events","type":"User","site_admin":false},"repo":{"id":92896971,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjg5Njk3MQ==","name":"stm32-rs","full_name":"adamgreig/stm32-rs","private":false,"owner":{"login":"adamgreig","id":47219,"node_id":"MDQ6VXNlcjQ3MjE5","avatar_url":"https://avatars2.githubusercontent.com/u/47219?v=4","gravatar_id":"","url":"https://api.github.com/users/adamgreig","html_url":"https://github.com/adamgreig","followers_url":"https://api.github.com/users/adamgreig/followers","following_url":"https://api.github.com/users/adamgreig/following{/other_user}","gists_url":"https://api.github.com/users/adamgreig/gists{/gist_id}","starred_url":"https://api.github.com/users/adamgreig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamgreig/subscriptions","organizations_url":"https://api.github.com/users/adamgreig/orgs","repos_url":"https://api.github.com/users/adamgreig/repos","events_url":"https://api.github.com/users/adamgreig/events{/privacy}","received_events_url":"https://api.github.com/users/adamgreig/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adamgreig/stm32-rs","description":"Embedded rust device crates for STM32 microcontrollers","fork":false,"url":"https://api.github.com/repos/adamgreig/stm32-rs","forks_url":"https://api.github.com/repos/adamgreig/stm32-rs/forks","keys_url":"https://api.github.com/repos/adamgreig/stm32-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamgreig/stm32-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamgreig/stm32-rs/teams","hooks_url":"https://api.github.com/repos/adamgreig/stm32-rs/hooks","issue_events_url":"https://api.github.com/repos/adamgreig/stm32-rs/issues/events{/number}","events_url":"https://api.github.com/repos/adamgreig/stm32-rs/events","assignees_url":"https://api.github.com/repos/adamgreig/stm32-rs/assignees{/user}","branches_url":"https://api.github.com/repos/adamgreig/stm32-rs/branches{/branch}","tags_url":"https://api.github.com/repos/adamgreig/stm32-rs/tags","blobs_url":"https://api.github.com/repos/adamgreig/stm32-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamgreig/stm32-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamgreig/stm32-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamgreig/stm32-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamgreig/stm32-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/adamgreig/stm32-rs/languages","stargazers_url":"https://api.github.com/repos/adamgreig/stm32-rs/stargazers","contributors_url":"https://api.github.com/repos/adamgreig/stm32-rs/contributors","subscribers_url":"https://api.github.com/repos/adamgreig/stm32-rs/subscribers","subscription_url":"https://api.github.com/repos/adamgreig/stm32-rs/subscription","commits_url":"https://api.github.com/repos/adamgreig/stm32-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamgreig/stm32-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamgreig/stm32-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamgreig/stm32-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamgreig/stm32-rs/contents/{+path}","compare_url":"https://api.github.com/repos/adamgreig/stm32-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamgreig/stm32-rs/merges","archive_url":"https://api.github.com/repos/adamgreig/stm32-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamgreig/stm32-rs/downloads","issues_url":"https://api.github.com/repos/adamgreig/stm32-rs/issues{/number}","pulls_url":"https://api.github.com/repos/adamgreig/stm32-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/adamgreig/stm32-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/adamgreig/stm32-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamgreig/stm32-rs/labels{/name}","releases_url":"https://api.github.com/repos/adamgreig/stm32-rs/releases{/id}","deployments_url":"https://api.github.com/repos/adamgreig/stm32-rs/deployments","created_at":"2017-05-31T02:43:32Z","updated_at":"2018-11-01T12:06:01Z","pushed_at":"2018-11-01T14:28:32Z","git_url":"git://github.com/adamgreig/stm32-rs.git","ssh_url":"git@github.com:adamgreig/stm32-rs.git","clone_url":"https://github.com/adamgreig/stm32-rs.git","svn_url":"https://github.com/adamgreig/stm32-rs","homepage":"https://stm32.agg.io/rs","size":7948,"stargazers_count":74,"watchers_count":74,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":20,"open_issues":16,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/75"},"html":{"href":"https://github.com/adamgreig/stm32-rs/pull/75"},"issue":{"href":"https://api.github.com/repos/adamgreig/stm32-rs/issues/75"},"comments":{"href":"https://api.github.com/repos/adamgreig/stm32-rs/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adamgreig/stm32-rs/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/adamgreig/stm32-rs/statuses/513f96c62a13f3819a56c3b7d568549992f5984c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adamgreig"}}