{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material2/pulls/comments/179967000","pull_request_review_id":110305999,"id":179967000,"diff_hunk":"@@ -26,21 +26,21 @@ export class CdkTreeNodePadding<T> implements OnDestroy {\n \n   /** The level of depth of the tree node. The padding will be `level * indent` pixels. */\n   @Input('cdkTreeNodePadding')\n+  get level(): number { return this._level; }\n   set level(value: number) {\n     this._level = coerceNumberProperty(value);\n     this._setPadding();\n   }\n-  get level(): number { return this._level; }\n   _level: number;\n \n   /** The indent for each level. Default number 40px from material design menu sub-menu spec. */\n   // TODO(tinayuangao): Make indent working with a string with unit, e.g. 10em","path":"src/cdk/tree/padding.ts","position":13,"original_position":13,"commit_id":"0c6e538b2a4adcd8c28e1590882b10d3c1ddc5e9","original_commit_id":"0c6e538b2a4adcd8c28e1590882b10d3c1ddc5e9","user":{"login":"rafaelss95","id":11965907,"avatar_url":"https://avatars0.githubusercontent.com/u/11965907?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelss95","html_url":"https://github.com/rafaelss95","followers_url":"https://api.github.com/users/rafaelss95/followers","following_url":"https://api.github.com/users/rafaelss95/following{/other_user}","gists_url":"https://api.github.com/users/rafaelss95/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelss95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelss95/subscriptions","organizations_url":"https://api.github.com/users/rafaelss95/orgs","repos_url":"https://api.github.com/users/rafaelss95/repos","events_url":"https://api.github.com/users/rafaelss95/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelss95/received_events","type":"User","site_admin":false},"body":"@tinayuangao Not related to this PR, but can't this be done using `coerceCssPixelValue`?","created_at":"2018-04-09T00:03:31Z","updated_at":"2018-04-09T00:03:31Z","html_url":"https://github.com/angular/material2/pull/10764#discussion_r179967000","pull_request_url":"https://api.github.com/repos/angular/material2/pulls/10764","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/comments/179967000"},"html":{"href":"https://github.com/angular/material2/pull/10764#discussion_r179967000"},"pull_request":{"href":"https://api.github.com/repos/angular/material2/pulls/10764"}}},"pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/10764","id":180174008,"html_url":"https://github.com/angular/material2/pull/10764","diff_url":"https://github.com/angular/material2/pull/10764.diff","patch_url":"https://github.com/angular/material2/pull/10764.patch","issue_url":"https://api.github.com/repos/angular/material2/issues/10764","number":10764,"state":"open","locked":false,"title":"refactor(tree): ensure input is applied to the getter and not the setter","user":{"login":"rafaelss95","id":11965907,"avatar_url":"https://avatars0.githubusercontent.com/u/11965907?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelss95","html_url":"https://github.com/rafaelss95","followers_url":"https://api.github.com/users/rafaelss95/followers","following_url":"https://api.github.com/users/rafaelss95/following{/other_user}","gists_url":"https://api.github.com/users/rafaelss95/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelss95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelss95/subscriptions","organizations_url":"https://api.github.com/users/rafaelss95/orgs","repos_url":"https://api.github.com/users/rafaelss95/repos","events_url":"https://api.github.com/users/rafaelss95/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelss95/received_events","type":"User","site_admin":false},"body":"According to [CODING_STANDARDS.md#getters-and-setters](https://github.com/angular/material2/blob/master/CODING_STANDARDS.md#getters-and-setters):\r\n\r\n- Decorators such as @Input should be applied to the getter and not the setter.","created_at":"2018-04-08T18:50:08Z","updated_at":"2018-04-09T00:03:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d11a6bc2d9addc9029b7209d1687fc928b384d3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tinayuangao","id":20677343,"avatar_url":"https://avatars3.githubusercontent.com/u/20677343?v=4","gravatar_id":"","url":"https://api.github.com/users/tinayuangao","html_url":"https://github.com/tinayuangao","followers_url":"https://api.github.com/users/tinayuangao/followers","following_url":"https://api.github.com/users/tinayuangao/following{/other_user}","gists_url":"https://api.github.com/users/tinayuangao/gists{/gist_id}","starred_url":"https://api.github.com/users/tinayuangao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinayuangao/subscriptions","organizations_url":"https://api.github.com/users/tinayuangao/orgs","repos_url":"https://api.github.com/users/tinayuangao/repos","events_url":"https://api.github.com/users/tinayuangao/events{/privacy}","received_events_url":"https://api.github.com/users/tinayuangao/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":308798701,"url":"https://api.github.com/repos/angular/material2/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/material2/pulls/10764/commits","review_comments_url":"https://api.github.com/repos/angular/material2/pulls/10764/comments","review_comment_url":"https://api.github.com/repos/angular/material2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material2/issues/10764/comments","statuses_url":"https://api.github.com/repos/angular/material2/statuses/0c6e538b2a4adcd8c28e1590882b10d3c1ddc5e9","head":{"label":"rafaelss95:fix-tree-getters-setters","ref":"fix-tree-getters-setters","sha":"0c6e538b2a4adcd8c28e1590882b10d3c1ddc5e9","user":{"login":"rafaelss95","id":11965907,"avatar_url":"https://avatars0.githubusercontent.com/u/11965907?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelss95","html_url":"https://github.com/rafaelss95","followers_url":"https://api.github.com/users/rafaelss95/followers","following_url":"https://api.github.com/users/rafaelss95/following{/other_user}","gists_url":"https://api.github.com/users/rafaelss95/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelss95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelss95/subscriptions","organizations_url":"https://api.github.com/users/rafaelss95/orgs","repos_url":"https://api.github.com/users/rafaelss95/repos","events_url":"https://api.github.com/users/rafaelss95/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelss95/received_events","type":"User","site_admin":false},"repo":{"id":96825556,"name":"material2","full_name":"rafaelss95/material2","owner":{"login":"rafaelss95","id":11965907,"avatar_url":"https://avatars0.githubusercontent.com/u/11965907?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelss95","html_url":"https://github.com/rafaelss95","followers_url":"https://api.github.com/users/rafaelss95/followers","following_url":"https://api.github.com/users/rafaelss95/following{/other_user}","gists_url":"https://api.github.com/users/rafaelss95/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelss95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelss95/subscriptions","organizations_url":"https://api.github.com/users/rafaelss95/orgs","repos_url":"https://api.github.com/users/rafaelss95/repos","events_url":"https://api.github.com/users/rafaelss95/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelss95/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rafaelss95/material2","description":"Material Design components for Angular","fork":true,"url":"https://api.github.com/repos/rafaelss95/material2","forks_url":"https://api.github.com/repos/rafaelss95/material2/forks","keys_url":"https://api.github.com/repos/rafaelss95/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafaelss95/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafaelss95/material2/teams","hooks_url":"https://api.github.com/repos/rafaelss95/material2/hooks","issue_events_url":"https://api.github.com/repos/rafaelss95/material2/issues/events{/number}","events_url":"https://api.github.com/repos/rafaelss95/material2/events","assignees_url":"https://api.github.com/repos/rafaelss95/material2/assignees{/user}","branches_url":"https://api.github.com/repos/rafaelss95/material2/branches{/branch}","tags_url":"https://api.github.com/repos/rafaelss95/material2/tags","blobs_url":"https://api.github.com/repos/rafaelss95/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafaelss95/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafaelss95/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafaelss95/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafaelss95/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/rafaelss95/material2/languages","stargazers_url":"https://api.github.com/repos/rafaelss95/material2/stargazers","contributors_url":"https://api.github.com/repos/rafaelss95/material2/contributors","subscribers_url":"https://api.github.com/repos/rafaelss95/material2/subscribers","subscription_url":"https://api.github.com/repos/rafaelss95/material2/subscription","commits_url":"https://api.github.com/repos/rafaelss95/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafaelss95/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafaelss95/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafaelss95/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/rafaelss95/material2/contents/{+path}","compare_url":"https://api.github.com/repos/rafaelss95/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafaelss95/material2/merges","archive_url":"https://api.github.com/repos/rafaelss95/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafaelss95/material2/downloads","issues_url":"https://api.github.com/repos/rafaelss95/material2/issues{/number}","pulls_url":"https://api.github.com/repos/rafaelss95/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/rafaelss95/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/rafaelss95/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafaelss95/material2/labels{/name}","releases_url":"https://api.github.com/repos/rafaelss95/material2/releases{/id}","deployments_url":"https://api.github.com/repos/rafaelss95/material2/deployments","created_at":"2017-07-10T22:07:33Z","updated_at":"2018-04-08T17:10:17Z","pushed_at":"2018-04-08T18:41:48Z","git_url":"git://github.com/rafaelss95/material2.git","ssh_url":"git@github.com:rafaelss95/material2.git","clone_url":"https://github.com/rafaelss95/material2.git","svn_url":"https://github.com/rafaelss95/material2","homepage":"https://material.angular.io","size":13759,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"edb57f969fc0fc8abf24bc6059b71d0426ebb4ae","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":49016322,"name":"material2","full_name":"angular/material2","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material2","description":"Material Design components for Angular","fork":false,"url":"https://api.github.com/repos/angular/material2","forks_url":"https://api.github.com/repos/angular/material2/forks","keys_url":"https://api.github.com/repos/angular/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material2/teams","hooks_url":"https://api.github.com/repos/angular/material2/hooks","issue_events_url":"https://api.github.com/repos/angular/material2/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material2/events","assignees_url":"https://api.github.com/repos/angular/material2/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material2/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material2/tags","blobs_url":"https://api.github.com/repos/angular/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material2/languages","stargazers_url":"https://api.github.com/repos/angular/material2/stargazers","contributors_url":"https://api.github.com/repos/angular/material2/contributors","subscribers_url":"https://api.github.com/repos/angular/material2/subscribers","subscription_url":"https://api.github.com/repos/angular/material2/subscription","commits_url":"https://api.github.com/repos/angular/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material2/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material2/merges","archive_url":"https://api.github.com/repos/angular/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material2/downloads","issues_url":"https://api.github.com/repos/angular/material2/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material2/labels{/name}","releases_url":"https://api.github.com/repos/angular/material2/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material2/deployments","created_at":"2016-01-04T18:50:02Z","updated_at":"2018-04-08T22:55:21Z","pushed_at":"2018-04-08T18:52:50Z","git_url":"git://github.com/angular/material2.git","ssh_url":"git@github.com:angular/material2.git","clone_url":"https://github.com/angular/material2.git","svn_url":"https://github.com/angular/material2","homepage":"https://material.angular.io","size":14106,"stargazers_count":13761,"watchers_count":13761,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3394,"mirror_url":null,"archived":false,"open_issues_count":965,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3394,"open_issues":965,"watchers":13761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/10764"},"html":{"href":"https://github.com/angular/material2/pull/10764"},"issue":{"href":"https://api.github.com/repos/angular/material2/issues/10764"},"comments":{"href":"https://api.github.com/repos/angular/material2/issues/10764/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material2/pulls/10764/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material2/pulls/10764/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material2/statuses/0c6e538b2a4adcd8c28e1590882b10d3c1ddc5e9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rafaelss95"}}