{"action":"created","comment":{"url":"https://api.github.com/repos/newsuk/times-xnative/pulls/comments/182999163","pull_request_review_id":113913300,"id":182999163,"diff_hunk":"@@ -1,19 +1,23 @@\n-{  \n+{\n   \"name\": \"@thetimes/android-app\",\n   \"version\": \"0.0.1\",\n+  \"private\": true,\n   \"license\": \"BSD-3-Clause\",\n   \"scripts\": {\n-    \"bundle\": \"haul bundle --platform android --dev false --entry-file js/index.android.js --bundle-output assets/js/index.android.bundle --assets-dest assets/res/\",\n+    \"bundle:deps\": \"cd android && ./gradlew generateReactArchives && cd ..\",\n+    \"bundle:js\": \"haul bundle --platform android --dev false --entry-file js/index.android.js --bundle-output assets/js/index.android.bundle --assets-dest assets/res/\",\n+    \"build\": \"yarn bundle:deps && yarn bundle:js\",\n     \"fmt\": \"prettier --write 'src/**/*.*'\",\n     \"start\": \"haul start --platform android\",\n-    \"lint:prettier\": \"prettier --list-different src/**/*.*\",\n-    \"lint\": \"yarn:lint:prettier\"\n+    \"lint:prettier\": \"prettier --lxist-different src/**/*.*\",","path":"packages/android-app/package.json","position":null,"original_position":16,"commit_id":"fc8bfb25072246350a3011de4c5148f43c16a96f","original_commit_id":"f4b459b5cc20738cc6fcce9e3a5397d7c7f20f8c","user":{"login":"tuncaulubilge","id":1849590,"avatar_url":"https://avatars3.githubusercontent.com/u/1849590?v=4","gravatar_id":"","url":"https://api.github.com/users/tuncaulubilge","html_url":"https://github.com/tuncaulubilge","followers_url":"https://api.github.com/users/tuncaulubilge/followers","following_url":"https://api.github.com/users/tuncaulubilge/following{/other_user}","gists_url":"https://api.github.com/users/tuncaulubilge/gists{/gist_id}","starred_url":"https://api.github.com/users/tuncaulubilge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuncaulubilge/subscriptions","organizations_url":"https://api.github.com/users/tuncaulubilge/orgs","repos_url":"https://api.github.com/users/tuncaulubilge/repos","events_url":"https://api.github.com/users/tuncaulubilge/events{/privacy}","received_events_url":"https://api.github.com/users/tuncaulubilge/received_events","type":"User","site_admin":false},"body":"Thanks, fc8bfb2","created_at":"2018-04-20T09:42:22Z","updated_at":"2018-04-20T09:42:22Z","html_url":"https://github.com/newsuk/times-xnative/pull/22#discussion_r182999163","pull_request_url":"https://api.github.com/repos/newsuk/times-xnative/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-xnative/pulls/comments/182999163"},"html":{"href":"https://github.com/newsuk/times-xnative/pull/22#discussion_r182999163"},"pull_request":{"href":"https://api.github.com/repos/newsuk/times-xnative/pulls/22"}},"in_reply_to_id":182942157},"pull_request":{"url":"https://api.github.com/repos/newsuk/times-xnative/pulls/22","id":182440581,"html_url":"https://github.com/newsuk/times-xnative/pull/22","diff_url":"https://github.com/newsuk/times-xnative/pull/22.diff","patch_url":"https://github.com/newsuk/times-xnative/pull/22.patch","issue_url":"https://api.github.com/repos/newsuk/times-xnative/issues/22","number":22,"state":"open","locked":false,"title":"[POC] - Create android-app package for android specific bundling","user":{"login":"tuncaulubilge","id":1849590,"avatar_url":"https://avatars3.githubusercontent.com/u/1849590?v=4","gravatar_id":"","url":"https://api.github.com/users/tuncaulubilge","html_url":"https://github.com/tuncaulubilge","followers_url":"https://api.github.com/users/tuncaulubilge/followers","following_url":"https://api.github.com/users/tuncaulubilge/following{/other_user}","gists_url":"https://api.github.com/users/tuncaulubilge/gists{/gist_id}","starred_url":"https://api.github.com/users/tuncaulubilge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuncaulubilge/subscriptions","organizations_url":"https://api.github.com/users/tuncaulubilge/orgs","repos_url":"https://api.github.com/users/tuncaulubilge/repos","events_url":"https://api.github.com/users/tuncaulubilge/events{/privacy}","received_events_url":"https://api.github.com/users/tuncaulubilge/received_events","type":"User","site_admin":false},"body":"This pr aims to prove the concept of bundling the android specific code inside xnative repo. With this pr, we should be able to remove all js specific logic from the android app and just include the bundled file for releases. For development, we can use the react-native development server by running `yarn start` inside android-app package.\r\n\r\n- Copied android js files including webpack config and babelrc\r\n- Version bumps for dependencies\r\n- Include times-components in workspace configuration to enable much better symlinking - experimental\r\n\r\nWhat's missing?\r\n- Bundling native modules such as react-native-svg and react-native-linear-gradient. For now, it's a manual process of copying these to the native app, but ideally, android-app package should produce aar files, which is ready to use by the android app.","created_at":"2018-04-18T10:53:32Z","updated_at":"2018-04-20T09:42:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3f2acc32ffee9e781f28310c70655a4bb87d5da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/newsuk/times-xnative/pulls/22/commits","review_comments_url":"https://api.github.com/repos/newsuk/times-xnative/pulls/22/comments","review_comment_url":"https://api.github.com/repos/newsuk/times-xnative/pulls/comments{/number}","comments_url":"https://api.github.com/repos/newsuk/times-xnative/issues/22/comments","statuses_url":"https://api.github.com/repos/newsuk/times-xnative/statuses/fc8bfb25072246350a3011de4c5148f43c16a96f","head":{"label":"newsuk:android-package","ref":"android-package","sha":"fc8bfb25072246350a3011de4c5148f43c16a96f","user":{"login":"newsuk","id":736306,"avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":120758304,"name":"times-xnative","full_name":"newsuk/times-xnative","owner":{"login":"newsuk","id":736306,"avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newsuk/times-xnative","description":null,"fork":false,"url":"https://api.github.com/repos/newsuk/times-xnative","forks_url":"https://api.github.com/repos/newsuk/times-xnative/forks","keys_url":"https://api.github.com/repos/newsuk/times-xnative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-xnative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-xnative/teams","hooks_url":"https://api.github.com/repos/newsuk/times-xnative/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-xnative/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-xnative/events","assignees_url":"https://api.github.com/repos/newsuk/times-xnative/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-xnative/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-xnative/tags","blobs_url":"https://api.github.com/repos/newsuk/times-xnative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-xnative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-xnative/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-xnative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-xnative/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-xnative/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-xnative/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-xnative/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-xnative/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-xnative/subscription","commits_url":"https://api.github.com/repos/newsuk/times-xnative/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-xnative/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-xnative/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-xnative/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-xnative/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-xnative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-xnative/merges","archive_url":"https://api.github.com/repos/newsuk/times-xnative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-xnative/downloads","issues_url":"https://api.github.com/repos/newsuk/times-xnative/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-xnative/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-xnative/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-xnative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-xnative/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-xnative/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-xnative/deployments","created_at":"2018-02-08T12:24:55Z","updated_at":"2018-04-16T10:10:28Z","pushed_at":"2018-04-20T09:42:09Z","git_url":"git://github.com/newsuk/times-xnative.git","ssh_url":"git@github.com:newsuk/times-xnative.git","clone_url":"https://github.com/newsuk/times-xnative.git","svn_url":"https://github.com/newsuk/times-xnative","homepage":null,"size":988,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"newsuk:master","ref":"master","sha":"8e7f09f0c956a6cdbb407f20df65ac9ee937f144","user":{"login":"newsuk","id":736306,"avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":120758304,"name":"times-xnative","full_name":"newsuk/times-xnative","owner":{"login":"newsuk","id":736306,"avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newsuk/times-xnative","description":null,"fork":false,"url":"https://api.github.com/repos/newsuk/times-xnative","forks_url":"https://api.github.com/repos/newsuk/times-xnative/forks","keys_url":"https://api.github.com/repos/newsuk/times-xnative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-xnative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-xnative/teams","hooks_url":"https://api.github.com/repos/newsuk/times-xnative/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-xnative/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-xnative/events","assignees_url":"https://api.github.com/repos/newsuk/times-xnative/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-xnative/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-xnative/tags","blobs_url":"https://api.github.com/repos/newsuk/times-xnative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-xnative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-xnative/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-xnative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-xnative/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-xnative/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-xnative/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-xnative/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-xnative/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-xnative/subscription","commits_url":"https://api.github.com/repos/newsuk/times-xnative/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-xnative/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-xnative/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-xnative/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-xnative/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-xnative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-xnative/merges","archive_url":"https://api.github.com/repos/newsuk/times-xnative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-xnative/downloads","issues_url":"https://api.github.com/repos/newsuk/times-xnative/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-xnative/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-xnative/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-xnative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-xnative/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-xnative/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-xnative/deployments","created_at":"2018-02-08T12:24:55Z","updated_at":"2018-04-16T10:10:28Z","pushed_at":"2018-04-20T09:42:09Z","git_url":"git://github.com/newsuk/times-xnative.git","ssh_url":"git@github.com:newsuk/times-xnative.git","clone_url":"https://github.com/newsuk/times-xnative.git","svn_url":"https://github.com/newsuk/times-xnative","homepage":null,"size":988,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-xnative/pulls/22"},"html":{"href":"https://github.com/newsuk/times-xnative/pull/22"},"issue":{"href":"https://api.github.com/repos/newsuk/times-xnative/issues/22"},"comments":{"href":"https://api.github.com/repos/newsuk/times-xnative/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/newsuk/times-xnative/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/newsuk/times-xnative/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/newsuk/times-xnative/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/newsuk/times-xnative/statuses/fc8bfb25072246350a3011de4c5148f43c16a96f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tuncaulubilge"}}