{"action":"closed","number":6838,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6838","id":188555382,"html_url":"https://github.com/puppetlabs/puppet/pull/6838","diff_url":"https://github.com/puppetlabs/puppet/pull/6838.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/6838.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/6838","number":6838,"state":"closed","locked":false,"title":"(PUP-8746) Minor report metric optimization","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"body":" - lak introduced this original code in Feb 2010, using the\r\n   initializer for Resource in 9919b14f262c994a58eb202cda408f1b90d728e\r\n\r\n - At this point in time, the Resource::Status object was not very\r\n   well defined, and did not contain the type of resource in the\r\n   `resource_type` attribute.\r\n\r\n - Later in Dec 2010 the resource_type value was added in\r\n   1f72c31f9e0223e71e2729da96e0e98ebea5417 but not all code was\r\n   refactored to take advantage of this\r\n\r\n - This code simply uses what is already available, rather than\r\n   creating a new Resource instance that is immediately thrown away,\r\n   solely for the sake of retrieving the type","created_at":"2018-05-16T20:47:16Z","updated_at":"2018-05-18T20:51:51Z","closed_at":"2018-05-18T20:51:51Z","merged_at":"2018-05-18T20:51:51Z","merge_commit_sha":"28240e5e300e8548be33142e108cf706a788bd74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6838/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6838/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/6838/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/e7b8f1ca9e58fed7eec630bd23eeda32c35316a4","head":{"label":"Iristyle:PUP-8746-cleanup-report-metrics","ref":"PUP-8746-cleanup-report-metrics","sha":"e7b8f1ca9e58fed7eec630bd23eeda32c35316a4","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"repo":{"id":12253882,"name":"puppet","full_name":"Iristyle/puppet","owner":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Iristyle/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/Iristyle/puppet","forks_url":"https://api.github.com/repos/Iristyle/puppet/forks","keys_url":"https://api.github.com/repos/Iristyle/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Iristyle/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Iristyle/puppet/teams","hooks_url":"https://api.github.com/repos/Iristyle/puppet/hooks","issue_events_url":"https://api.github.com/repos/Iristyle/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/Iristyle/puppet/events","assignees_url":"https://api.github.com/repos/Iristyle/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/Iristyle/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/Iristyle/puppet/tags","blobs_url":"https://api.github.com/repos/Iristyle/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Iristyle/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Iristyle/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Iristyle/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Iristyle/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/Iristyle/puppet/languages","stargazers_url":"https://api.github.com/repos/Iristyle/puppet/stargazers","contributors_url":"https://api.github.com/repos/Iristyle/puppet/contributors","subscribers_url":"https://api.github.com/repos/Iristyle/puppet/subscribers","subscription_url":"https://api.github.com/repos/Iristyle/puppet/subscription","commits_url":"https://api.github.com/repos/Iristyle/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Iristyle/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Iristyle/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Iristyle/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Iristyle/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/Iristyle/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Iristyle/puppet/merges","archive_url":"https://api.github.com/repos/Iristyle/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Iristyle/puppet/downloads","issues_url":"https://api.github.com/repos/Iristyle/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/Iristyle/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/Iristyle/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/Iristyle/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Iristyle/puppet/labels{/name}","releases_url":"https://api.github.com/repos/Iristyle/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/Iristyle/puppet/deployments","created_at":"2013-08-20T20:49:43Z","updated_at":"2015-02-14T00:06:23Z","pushed_at":"2018-05-16T20:52:29Z","git_url":"git://github.com/Iristyle/puppet.git","ssh_url":"git@github.com:Iristyle/puppet.git","clone_url":"https://github.com/Iristyle/puppet.git","svn_url":"https://github.com/Iristyle/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":65476,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:5.5.x","ref":"5.5.x","sha":"045647f2de532ca7cecd7f46d4d6f00e86f81fde","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2018-05-17T04:54:02Z","pushed_at":"2018-05-18T20:51:51Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":65106,"stargazers_count":4998,"watchers_count":4998,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2007,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2007,"open_issues":51,"watchers":4998,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6838"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/6838"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/6838"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/6838/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6838/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6838/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/e7b8f1ca9e58fed7eec630bd23eeda32c35316a4"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars1.githubusercontent.com/u/737664?v=4","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"joshcooper"}}