{"action":"created","comment":{"url":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/comments/185477902","pull_request_review_id":116873389,"id":185477902,"diff_hunk":"@@ -27,9 +27,9 @@ <h4>The friendly App Store for the Internet of Things.</h4>\n                     </div>\n \n                 </div>\n-                <div class=\"col-sm-2\">\n+                <!--<div class=\"col-sm-2\">","path":"rapstore-frontend/src/app/app.component.html","position":14,"original_position":5,"commit_id":"08aa7345b2b551fb5baf6671c7cfc905e8bcc25f","original_commit_id":"fb651f75e0d7df1a58faa07694656aba214b304d","user":{"login":"HendrikVE","id":9884864,"avatar_url":"https://avatars2.githubusercontent.com/u/9884864?v=4","gravatar_id":"","url":"https://api.github.com/users/HendrikVE","html_url":"https://github.com/HendrikVE","followers_url":"https://api.github.com/users/HendrikVE/followers","following_url":"https://api.github.com/users/HendrikVE/following{/other_user}","gists_url":"https://api.github.com/users/HendrikVE/gists{/gist_id}","starred_url":"https://api.github.com/users/HendrikVE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HendrikVE/subscriptions","organizations_url":"https://api.github.com/users/HendrikVE/orgs","repos_url":"https://api.github.com/users/HendrikVE/repos","events_url":"https://api.github.com/users/HendrikVE/events{/privacy}","received_events_url":"https://api.github.com/users/HendrikVE/received_events","type":"User","site_admin":false},"body":"That is ok for me","created_at":"2018-05-02T12:26:09Z","updated_at":"2018-05-02T12:26:10Z","html_url":"https://github.com/riot-appstore/rapstore-django/pull/35#discussion_r185477902","pull_request_url":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/35","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/comments/185477902"},"html":{"href":"https://github.com/riot-appstore/rapstore-django/pull/35#discussion_r185477902"},"pull_request":{"href":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/35"}},"in_reply_to_id":185470219},"pull_request":{"url":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/35","id":184973739,"html_url":"https://github.com/riot-appstore/rapstore-django/pull/35","diff_url":"https://github.com/riot-appstore/rapstore-django/pull/35.diff","patch_url":"https://github.com/riot-appstore/rapstore-django/pull/35.patch","issue_url":"https://api.github.com/repos/riot-appstore/rapstore-django/issues/35","number":35,"state":"open","locked":false,"title":"bugfix: Fix several bugs and hide feature out of scope of demo","user":{"login":"jia200x","id":1260616,"avatar_url":"https://avatars3.githubusercontent.com/u/1260616?v=4","gravatar_id":"","url":"https://api.github.com/users/jia200x","html_url":"https://github.com/jia200x","followers_url":"https://api.github.com/users/jia200x/followers","following_url":"https://api.github.com/users/jia200x/following{/other_user}","gists_url":"https://api.github.com/users/jia200x/gists{/gist_id}","starred_url":"https://api.github.com/users/jia200x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jia200x/subscriptions","organizations_url":"https://api.github.com/users/jia200x/orgs","repos_url":"https://api.github.com/users/jia200x/repos","events_url":"https://api.github.com/users/jia200x/events{/privacy}","received_events_url":"https://api.github.com/users/jia200x/received_events","type":"User","site_admin":false},"body":"This PR fixes several bugs and hides features that are not going to be presented for the demo.\r\n\r\nEDIT: It also fixes the responsive bug!\r\n\r\n- [ ] Remove developer tab, since only shows a dummy message\r\n- [ ] Refactor developer information in App details views (alignment, labels, etc)\r\n- [ ] Remove fake ranking (*****)\r\n- [ ] Fix one line description => Now shows the first line of the description instead of literally \"One line description\"\r\n- [ ] Fix validation in Project site when uploading an app (it accepts blank URLs)\r\n- [ ] Remove version_name and version_code from application upload\r\n- [ ] Remove \"Install on device\" button. Only \"Download binary\" will be available for the demo\r\n- [ ] Remove version tag from upper right corner. #16 introduced a \"missing angular core\" bug that has to be fixed in order to use proper versioning from Angular.\r\n- [ ] Add link to main site in \"RAPstore\" header.\r\n- [ ] Remove `ApplicationInstance` from Django Admin, since it's not meant to be modified by administrators\r\n- [ ] Accept only alphanumeric app for app names (just for the demo)\r\n- [ ] Remove time from Last update (shows only dd/mm/yyyy)\r\n- [ ] Expand number of rows in Description text area (Application Upload)\r\n- [ ] Reset error messages when triggering \"Upload\" mechanism.\r\n- [ ] Responsive feature added","created_at":"2018-04-30T14:37:55Z","updated_at":"2018-05-02T12:26:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e694b4e5a8b02de4414b19dd9b6d66e8824cc11","assignee":{"login":"danpetry","id":11301549,"avatar_url":"https://avatars2.githubusercontent.com/u/11301549?v=4","gravatar_id":"","url":"https://api.github.com/users/danpetry","html_url":"https://github.com/danpetry","followers_url":"https://api.github.com/users/danpetry/followers","following_url":"https://api.github.com/users/danpetry/following{/other_user}","gists_url":"https://api.github.com/users/danpetry/gists{/gist_id}","starred_url":"https://api.github.com/users/danpetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpetry/subscriptions","organizations_url":"https://api.github.com/users/danpetry/orgs","repos_url":"https://api.github.com/users/danpetry/repos","events_url":"https://api.github.com/users/danpetry/events{/privacy}","received_events_url":"https://api.github.com/users/danpetry/received_events","type":"User","site_admin":false},"assignees":[{"login":"danpetry","id":11301549,"avatar_url":"https://avatars2.githubusercontent.com/u/11301549?v=4","gravatar_id":"","url":"https://api.github.com/users/danpetry","html_url":"https://github.com/danpetry","followers_url":"https://api.github.com/users/danpetry/followers","following_url":"https://api.github.com/users/danpetry/following{/other_user}","gists_url":"https://api.github.com/users/danpetry/gists{/gist_id}","starred_url":"https://api.github.com/users/danpetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpetry/subscriptions","organizations_url":"https://api.github.com/users/danpetry/orgs","repos_url":"https://api.github.com/users/danpetry/repos","events_url":"https://api.github.com/users/danpetry/events{/privacy}","received_events_url":"https://api.github.com/users/danpetry/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/35/commits","review_comments_url":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/35/comments","review_comment_url":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riot-appstore/rapstore-django/issues/35/comments","statuses_url":"https://api.github.com/repos/riot-appstore/rapstore-django/statuses/08aa7345b2b551fb5baf6671c7cfc905e8bcc25f","head":{"label":"riot-appstore:pr/fix_ui","ref":"pr/fix_ui","sha":"08aa7345b2b551fb5baf6671c7cfc905e8bcc25f","user":{"login":"riot-appstore","id":33024728,"avatar_url":"https://avatars1.githubusercontent.com/u/33024728?v=4","gravatar_id":"","url":"https://api.github.com/users/riot-appstore","html_url":"https://github.com/riot-appstore","followers_url":"https://api.github.com/users/riot-appstore/followers","following_url":"https://api.github.com/users/riot-appstore/following{/other_user}","gists_url":"https://api.github.com/users/riot-appstore/gists{/gist_id}","starred_url":"https://api.github.com/users/riot-appstore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riot-appstore/subscriptions","organizations_url":"https://api.github.com/users/riot-appstore/orgs","repos_url":"https://api.github.com/users/riot-appstore/repos","events_url":"https://api.github.com/users/riot-appstore/events{/privacy}","received_events_url":"https://api.github.com/users/riot-appstore/received_events","type":"Organization","site_admin":false},"repo":{"id":121289117,"name":"rapstore-django","full_name":"riot-appstore/rapstore-django","owner":{"login":"riot-appstore","id":33024728,"avatar_url":"https://avatars1.githubusercontent.com/u/33024728?v=4","gravatar_id":"","url":"https://api.github.com/users/riot-appstore","html_url":"https://github.com/riot-appstore","followers_url":"https://api.github.com/users/riot-appstore/followers","following_url":"https://api.github.com/users/riot-appstore/following{/other_user}","gists_url":"https://api.github.com/users/riot-appstore/gists{/gist_id}","starred_url":"https://api.github.com/users/riot-appstore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riot-appstore/subscriptions","organizations_url":"https://api.github.com/users/riot-appstore/orgs","repos_url":"https://api.github.com/users/riot-appstore/repos","events_url":"https://api.github.com/users/riot-appstore/events{/privacy}","received_events_url":"https://api.github.com/users/riot-appstore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riot-appstore/rapstore-django","description":null,"fork":false,"url":"https://api.github.com/repos/riot-appstore/rapstore-django","forks_url":"https://api.github.com/repos/riot-appstore/rapstore-django/forks","keys_url":"https://api.github.com/repos/riot-appstore/rapstore-django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riot-appstore/rapstore-django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riot-appstore/rapstore-django/teams","hooks_url":"https://api.github.com/repos/riot-appstore/rapstore-django/hooks","issue_events_url":"https://api.github.com/repos/riot-appstore/rapstore-django/issues/events{/number}","events_url":"https://api.github.com/repos/riot-appstore/rapstore-django/events","assignees_url":"https://api.github.com/repos/riot-appstore/rapstore-django/assignees{/user}","branches_url":"https://api.github.com/repos/riot-appstore/rapstore-django/branches{/branch}","tags_url":"https://api.github.com/repos/riot-appstore/rapstore-django/tags","blobs_url":"https://api.github.com/repos/riot-appstore/rapstore-django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riot-appstore/rapstore-django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riot-appstore/rapstore-django/git/refs{/sha}","trees_url":"https://api.github.com/repos/riot-appstore/rapstore-django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riot-appstore/rapstore-django/statuses/{sha}","languages_url":"https://api.github.com/repos/riot-appstore/rapstore-django/languages","stargazers_url":"https://api.github.com/repos/riot-appstore/rapstore-django/stargazers","contributors_url":"https://api.github.com/repos/riot-appstore/rapstore-django/contributors","subscribers_url":"https://api.github.com/repos/riot-appstore/rapstore-django/subscribers","subscription_url":"https://api.github.com/repos/riot-appstore/rapstore-django/subscription","commits_url":"https://api.github.com/repos/riot-appstore/rapstore-django/commits{/sha}","git_commits_url":"https://api.github.com/repos/riot-appstore/rapstore-django/git/commits{/sha}","comments_url":"https://api.github.com/repos/riot-appstore/rapstore-django/comments{/number}","issue_comment_url":"https://api.github.com/repos/riot-appstore/rapstore-django/issues/comments{/number}","contents_url":"https://api.github.com/repos/riot-appstore/rapstore-django/contents/{+path}","compare_url":"https://api.github.com/repos/riot-appstore/rapstore-django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riot-appstore/rapstore-django/merges","archive_url":"https://api.github.com/repos/riot-appstore/rapstore-django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riot-appstore/rapstore-django/downloads","issues_url":"https://api.github.com/repos/riot-appstore/rapstore-django/issues{/number}","pulls_url":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls{/number}","milestones_url":"https://api.github.com/repos/riot-appstore/rapstore-django/milestones{/number}","notifications_url":"https://api.github.com/repos/riot-appstore/rapstore-django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riot-appstore/rapstore-django/labels{/name}","releases_url":"https://api.github.com/repos/riot-appstore/rapstore-django/releases{/id}","deployments_url":"https://api.github.com/repos/riot-appstore/rapstore-django/deployments","created_at":"2018-02-12T19:06:07Z","updated_at":"2018-04-27T13:20:51Z","pushed_at":"2018-05-02T12:14:39Z","git_url":"git://github.com/riot-appstore/rapstore-django.git","ssh_url":"git@github.com:riot-appstore/rapstore-django.git","clone_url":"https://github.com/riot-appstore/rapstore-django.git","svn_url":"https://github.com/riot-appstore/rapstore-django","homepage":null,"size":1920,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"riot-appstore:master","ref":"master","sha":"e063e5f8e32c26c7f1686b2752c0dec569496efb","user":{"login":"riot-appstore","id":33024728,"avatar_url":"https://avatars1.githubusercontent.com/u/33024728?v=4","gravatar_id":"","url":"https://api.github.com/users/riot-appstore","html_url":"https://github.com/riot-appstore","followers_url":"https://api.github.com/users/riot-appstore/followers","following_url":"https://api.github.com/users/riot-appstore/following{/other_user}","gists_url":"https://api.github.com/users/riot-appstore/gists{/gist_id}","starred_url":"https://api.github.com/users/riot-appstore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riot-appstore/subscriptions","organizations_url":"https://api.github.com/users/riot-appstore/orgs","repos_url":"https://api.github.com/users/riot-appstore/repos","events_url":"https://api.github.com/users/riot-appstore/events{/privacy}","received_events_url":"https://api.github.com/users/riot-appstore/received_events","type":"Organization","site_admin":false},"repo":{"id":121289117,"name":"rapstore-django","full_name":"riot-appstore/rapstore-django","owner":{"login":"riot-appstore","id":33024728,"avatar_url":"https://avatars1.githubusercontent.com/u/33024728?v=4","gravatar_id":"","url":"https://api.github.com/users/riot-appstore","html_url":"https://github.com/riot-appstore","followers_url":"https://api.github.com/users/riot-appstore/followers","following_url":"https://api.github.com/users/riot-appstore/following{/other_user}","gists_url":"https://api.github.com/users/riot-appstore/gists{/gist_id}","starred_url":"https://api.github.com/users/riot-appstore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riot-appstore/subscriptions","organizations_url":"https://api.github.com/users/riot-appstore/orgs","repos_url":"https://api.github.com/users/riot-appstore/repos","events_url":"https://api.github.com/users/riot-appstore/events{/privacy}","received_events_url":"https://api.github.com/users/riot-appstore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riot-appstore/rapstore-django","description":null,"fork":false,"url":"https://api.github.com/repos/riot-appstore/rapstore-django","forks_url":"https://api.github.com/repos/riot-appstore/rapstore-django/forks","keys_url":"https://api.github.com/repos/riot-appstore/rapstore-django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riot-appstore/rapstore-django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riot-appstore/rapstore-django/teams","hooks_url":"https://api.github.com/repos/riot-appstore/rapstore-django/hooks","issue_events_url":"https://api.github.com/repos/riot-appstore/rapstore-django/issues/events{/number}","events_url":"https://api.github.com/repos/riot-appstore/rapstore-django/events","assignees_url":"https://api.github.com/repos/riot-appstore/rapstore-django/assignees{/user}","branches_url":"https://api.github.com/repos/riot-appstore/rapstore-django/branches{/branch}","tags_url":"https://api.github.com/repos/riot-appstore/rapstore-django/tags","blobs_url":"https://api.github.com/repos/riot-appstore/rapstore-django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riot-appstore/rapstore-django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riot-appstore/rapstore-django/git/refs{/sha}","trees_url":"https://api.github.com/repos/riot-appstore/rapstore-django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riot-appstore/rapstore-django/statuses/{sha}","languages_url":"https://api.github.com/repos/riot-appstore/rapstore-django/languages","stargazers_url":"https://api.github.com/repos/riot-appstore/rapstore-django/stargazers","contributors_url":"https://api.github.com/repos/riot-appstore/rapstore-django/contributors","subscribers_url":"https://api.github.com/repos/riot-appstore/rapstore-django/subscribers","subscription_url":"https://api.github.com/repos/riot-appstore/rapstore-django/subscription","commits_url":"https://api.github.com/repos/riot-appstore/rapstore-django/commits{/sha}","git_commits_url":"https://api.github.com/repos/riot-appstore/rapstore-django/git/commits{/sha}","comments_url":"https://api.github.com/repos/riot-appstore/rapstore-django/comments{/number}","issue_comment_url":"https://api.github.com/repos/riot-appstore/rapstore-django/issues/comments{/number}","contents_url":"https://api.github.com/repos/riot-appstore/rapstore-django/contents/{+path}","compare_url":"https://api.github.com/repos/riot-appstore/rapstore-django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riot-appstore/rapstore-django/merges","archive_url":"https://api.github.com/repos/riot-appstore/rapstore-django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riot-appstore/rapstore-django/downloads","issues_url":"https://api.github.com/repos/riot-appstore/rapstore-django/issues{/number}","pulls_url":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls{/number}","milestones_url":"https://api.github.com/repos/riot-appstore/rapstore-django/milestones{/number}","notifications_url":"https://api.github.com/repos/riot-appstore/rapstore-django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riot-appstore/rapstore-django/labels{/name}","releases_url":"https://api.github.com/repos/riot-appstore/rapstore-django/releases{/id}","deployments_url":"https://api.github.com/repos/riot-appstore/rapstore-django/deployments","created_at":"2018-02-12T19:06:07Z","updated_at":"2018-04-27T13:20:51Z","pushed_at":"2018-05-02T12:14:39Z","git_url":"git://github.com/riot-appstore/rapstore-django.git","ssh_url":"git@github.com:riot-appstore/rapstore-django.git","clone_url":"https://github.com/riot-appstore/rapstore-django.git","svn_url":"https://github.com/riot-appstore/rapstore-django","homepage":null,"size":1920,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/35"},"html":{"href":"https://github.com/riot-appstore/rapstore-django/pull/35"},"issue":{"href":"https://api.github.com/repos/riot-appstore/rapstore-django/issues/35"},"comments":{"href":"https://api.github.com/repos/riot-appstore/rapstore-django/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riot-appstore/rapstore-django/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/riot-appstore/rapstore-django/statuses/08aa7345b2b551fb5baf6671c7cfc905e8bcc25f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"HendrikVE"}}