{"action":"created","issue":{"url":"https://api.github.com/repos/SpareBank1/designsystem/issues/415","repository_url":"https://api.github.com/repos/SpareBank1/designsystem","labels_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/415/labels{/name}","comments_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/415/comments","events_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/415/events","html_url":"https://github.com/SpareBank1/designsystem/issues/415","id":362488006,"node_id":"MDU6SXNzdWUzNjI0ODgwMDY=","number":415,"title":"Peer dependencies are not maintained (need update for ffe-core@14)","user":{"login":"henrikhermansen","id":435037,"node_id":"MDQ6VXNlcjQzNTAzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/435037?v=4","gravatar_id":"","url":"https://api.github.com/users/henrikhermansen","html_url":"https://github.com/henrikhermansen","followers_url":"https://api.github.com/users/henrikhermansen/followers","following_url":"https://api.github.com/users/henrikhermansen/following{/other_user}","gists_url":"https://api.github.com/users/henrikhermansen/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikhermansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikhermansen/subscriptions","organizations_url":"https://api.github.com/users/henrikhermansen/orgs","repos_url":"https://api.github.com/users/henrikhermansen/repos","events_url":"https://api.github.com/users/henrikhermansen/events{/privacy}","received_events_url":"https://api.github.com/users/henrikhermansen/received_events","type":"User","site_admin":false},"labels":[{"id":848907443,"node_id":"MDU6TGFiZWw4NDg5MDc0NDM=","url":"https://api.github.com/repos/SpareBank1/designsystem/labels/:computer:%20technical","name":":computer: technical","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-21T07:23:52Z","updated_at":"2018-09-21T12:37:58Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"#### Which package is this issue related to?\r\nMany of our packages\r\n\r\n#### Describe your issue (screenshots welcome!)\r\nI have just now installed all the newest versions of ffe-packages,\r\nbut peer dependencies are not updated for ffe-core@14.\r\nAll of the following warnings are just noise - all packages works fine with ffe-core@14:\r\n\r\n```\r\nnpm WARN @sb1/ffe-buttons@8.0.7 requires a peer of @sb1/ffe-core@^12.0.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-buttons-react@11.1.7 requires a peer of @sb1/ffe-buttons@^7.0.2 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-context-message@3.0.18 requires a peer of @sb1/ffe-core@^12.0.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-core-react@3.2.2 requires a peer of @sb1/ffe-core@^12.0.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-datepicker@5.0.32 requires a peer of @sb1/ffe-core@^12.0.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-form-react@3.2.3 requires a peer of @sb1/ffe-core@^12.0.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-grid@10.0.4 requires a peer of @sb1/ffe-core@^12.0.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-grid-react@9.0.2 requires a peer of @sb1/ffe-grid@^7.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-layout-legacy@1.0.2 requires a peer of @sb1/ffe-core@^12.2.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-lists@5.0.17 requires a peer of @sb1/ffe-core@^12.0.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-message-box@6.0.5 requires a peer of @sb1/ffe-core@^12.0.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-searchable-dropdown-react@6.0.9 requires a peer of @sb1/ffe-core@^12.0.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-spinner@3.0.17 requires a peer of @sb1/ffe-core@^12.0.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\nnpm WARN @sb1/ffe-tables@9.0.16 requires a peer of @sb1/ffe-core@^12.0.0 || ^13.0.0 but none is installed. You must install peer dependencies yourself.\r\n```\r\n\r\n#### What is the expected behavior? \r\nI expect peerDependency warnings to be of significance.\r\n\r\n#### What is the actual behavior?\r\nPeerDependencies are not maintained, and thus their warnings become noise instead of useful information.\r\n\r\n#### Steps to reproduce\r\nUpgrade to ffe-core@14 and run npm install.\r\n\r\n#### Other notes\r\nThis issue is in one way just a simple task to update peerDependencies.\r\nI also hope it will serve as a reminder that if you create a new major version of a package,\r\nplease check and update packages which has your package as a peerDependency."},"comment":{"url":"https://api.github.com/repos/SpareBank1/designsystem/issues/comments/423516736","html_url":"https://github.com/SpareBank1/designsystem/issues/415#issuecomment-423516736","issue_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/415","id":423516736,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzUxNjczNg==","user":{"login":"kwltrs","id":493924,"node_id":"MDQ6VXNlcjQ5MzkyNA==","avatar_url":"https://avatars1.githubusercontent.com/u/493924?v=4","gravatar_id":"","url":"https://api.github.com/users/kwltrs","html_url":"https://github.com/kwltrs","followers_url":"https://api.github.com/users/kwltrs/followers","following_url":"https://api.github.com/users/kwltrs/following{/other_user}","gists_url":"https://api.github.com/users/kwltrs/gists{/gist_id}","starred_url":"https://api.github.com/users/kwltrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwltrs/subscriptions","organizations_url":"https://api.github.com/users/kwltrs/orgs","repos_url":"https://api.github.com/users/kwltrs/repos","events_url":"https://api.github.com/users/kwltrs/events{/privacy}","received_events_url":"https://api.github.com/users/kwltrs/received_events","type":"User","site_admin":false},"created_at":"2018-09-21T12:37:58Z","updated_at":"2018-09-21T12:37:58Z","author_association":"CONTRIBUTOR","body":"Upgrading of dependencies is done by lerna, but it seems lerna 3 does not upgrade peer dependencies anymore (Possibly related issue: https://github.com/lerna/lerna/issues/1575). "}}
{"actor":{"display_login":"kwltrs"}}