{"action":"created","issue":{"url":"https://api.github.com/repos/ccxt/ccxt/issues/2328","repository_url":"https://api.github.com/repos/ccxt/ccxt","labels_url":"https://api.github.com/repos/ccxt/ccxt/issues/2328/labels{/name}","comments_url":"https://api.github.com/repos/ccxt/ccxt/issues/2328/comments","events_url":"https://api.github.com/repos/ccxt/ccxt/issues/2328/events","html_url":"https://github.com/ccxt/ccxt/issues/2328","id":307308586,"number":2328,"title":"Cryptopia supports trade history. Emulation not necessary?","user":{"login":"MarcelBeining","id":1278660,"avatar_url":"https://avatars1.githubusercontent.com/u/1278660?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcelBeining","html_url":"https://github.com/MarcelBeining","followers_url":"https://api.github.com/users/MarcelBeining/followers","following_url":"https://api.github.com/users/MarcelBeining/following{/other_user}","gists_url":"https://api.github.com/users/MarcelBeining/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelBeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelBeining/subscriptions","organizations_url":"https://api.github.com/users/MarcelBeining/orgs","repos_url":"https://api.github.com/users/MarcelBeining/repos","events_url":"https://api.github.com/users/MarcelBeining/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelBeining/received_events","type":"User","site_admin":false},"labels":[{"id":604886965,"url":"https://api.github.com/repos/ccxt/ccxt/labels/duplicate","name":"duplicate","color":"cccccc","default":true},{"id":604886969,"url":"https://api.github.com/repos/ccxt/ccxt/labels/question","name":"question","color":"cc317c","default":true}],"state":"closed","locked":false,"assignee":{"login":"kroitor","id":1294454,"avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false},"assignees":[{"login":"kroitor","id":1294454,"avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-03-21T15:59:03Z","updated_at":"2018-03-21T16:11:30Z","closed_at":"2018-03-21T16:11:29Z","author_association":"NONE","body":"Hi,\r\nI just saw that Cryptopia meanwhile seems to support retrieving the trade history (GetTradeHistory):\r\nhttps://www.cryptopia.co.nz/Forum/Thread/256\r\n\r\nHowever, in ccxt it is still handled in emulated mode for Cryptopia (e.g. fetchClosedOrders).\r\n\r\nWould be great if you'd implement that. Unfortunately, I am not that into python / your code structure to feel confident enough doing it myself. Thanks for this great package!\r\n\r\n- OS: Windows\r\n- Programming Language version: Python 3.5\r\n- CCXT version: 1.11.149\r\n- Exchange: Cryptopia\r\n- Method: fetchClosedOrders\r\n"},"comment":{"url":"https://api.github.com/repos/ccxt/ccxt/issues/comments/374997778","html_url":"https://github.com/ccxt/ccxt/issues/2328#issuecomment-374997778","issue_url":"https://api.github.com/repos/ccxt/ccxt/issues/2328","id":374997778,"user":{"login":"kroitor","id":1294454,"avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T16:11:29Z","updated_at":"2018-03-21T16:11:29Z","author_association":"OWNER","body":"Hi!\r\n\r\nIt's already implemented...\r\n\r\n- https://github.com/ccxt/ccxt/blob/master/js/cryptopia.js#L320\r\n- https://github.com/ccxt/ccxt/blob/master/php/cryptopia.php#L319\r\n- https://github.com/ccxt/ccxt/blob/master/python/ccxt/cryptopia.py#L306\r\n\r\n... however, you seem to be confusing `trades` and `orders`, explained here:\r\n\r\n- https://github.com/ccxt/ccxt/wiki/Manual#how-orders-are-related-to-trades\r\n\r\nAlso, see my post on Cryptopia forum to understand what exactly their API is missing.\r\n\r\n- https://www.cryptopia.co.nz/Forum/Thread/256?postId=12743\r\n\r\n↑ The above should give an extensive answer to your question. Thx!"}}
{"actor":{"display_login":"kroitor"}}