{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/xgboost/pulls/comments/218956281","pull_request_review_id":157012351,"id":218956281,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODk1NjI4MQ==","diff_hunk":"@@ -378,11 +378,13 @@ private object Watches {\n     }\n \n     val (trainIter1, trainIter2) = trainPoints.duplicate\n-    val trainMatrix = new DMatrix(trainIter1, cacheDirName.map(_ + \"/train\").orNull)\n+    val trainMatrix = new DMatrix(trainIter1, cacheDirName.map(_ + \"/train\").orNull,\n+      params.get(\"batchSize\").map(_.toString.toInt).getOrElse(32<<10))","path":"jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala","position":6,"original_position":6,"commit_id":"88a7c85e7b94017786384f9cf08adbfc132ed69a","original_commit_id":"a21601826433daa1ff13e9c38299af7112f2728b","user":{"login":"chenqin","id":1184534,"node_id":"MDQ6VXNlcjExODQ1MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1184534?v=4","gravatar_id":"","url":"https://api.github.com/users/chenqin","html_url":"https://github.com/chenqin","followers_url":"https://api.github.com/users/chenqin/followers","following_url":"https://api.github.com/users/chenqin/following{/other_user}","gists_url":"https://api.github.com/users/chenqin/gists{/gist_id}","starred_url":"https://api.github.com/users/chenqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenqin/subscriptions","organizations_url":"https://api.github.com/users/chenqin/orgs","repos_url":"https://api.github.com/users/chenqin/repos","events_url":"https://api.github.com/users/chenqin/events{/privacy}","received_events_url":"https://api.github.com/users/chenqin/received_events","type":"User","site_admin":false},"body":"sounds good, fixed.","created_at":"2018-09-19T20:40:44Z","updated_at":"2018-09-19T20:40:44Z","html_url":"https://github.com/dmlc/xgboost/pull/3705#discussion_r218956281","pull_request_url":"https://api.github.com/repos/dmlc/xgboost/pulls/3705","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dmlc/xgboost/pulls/comments/218956281"},"html":{"href":"https://github.com/dmlc/xgboost/pull/3705#discussion_r218956281"},"pull_request":{"href":"https://api.github.com/repos/dmlc/xgboost/pulls/3705"}},"in_reply_to_id":218642575},"pull_request":{"url":"https://api.github.com/repos/dmlc/xgboost/pulls/3705","id":215872260,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODcyMjYw","html_url":"https://github.com/dmlc/xgboost/pull/3705","diff_url":"https://github.com/dmlc/xgboost/pull/3705.diff","patch_url":"https://github.com/dmlc/xgboost/pull/3705.patch","issue_url":"https://api.github.com/repos/dmlc/xgboost/issues/3705","number":3705,"state":"open","locked":false,"title":"[jvm-packages] add batchSize to xgboost4j and xgboost-spark","user":{"login":"chenqin","id":1184534,"node_id":"MDQ6VXNlcjExODQ1MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1184534?v=4","gravatar_id":"","url":"https://api.github.com/users/chenqin","html_url":"https://github.com/chenqin","followers_url":"https://api.github.com/users/chenqin/followers","following_url":"https://api.github.com/users/chenqin/following{/other_user}","gists_url":"https://api.github.com/users/chenqin/gists{/gist_id}","starred_url":"https://api.github.com/users/chenqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenqin/subscriptions","organizations_url":"https://api.github.com/users/chenqin/orgs","repos_url":"https://api.github.com/users/chenqin/repos","events_url":"https://api.github.com/users/chenqin/events{/privacy}","received_events_url":"https://api.github.com/users/chenqin/received_events","type":"User","site_admin":false},"body":"per feedback from [#3701](https://github.com/dmlc/xgboost/pull/3701)","created_at":"2018-09-17T04:42:29Z","updated_at":"2018-09-19T20:40:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b350f67e6c715d36c56ca6b661b0b0f8fdaf768","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/xgboost/pulls/3705/commits","review_comments_url":"https://api.github.com/repos/dmlc/xgboost/pulls/3705/comments","review_comment_url":"https://api.github.com/repos/dmlc/xgboost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/xgboost/issues/3705/comments","statuses_url":"https://api.github.com/repos/dmlc/xgboost/statuses/88a7c85e7b94017786384f9cf08adbfc132ed69a","head":{"label":"chenqin:master","ref":"master","sha":"88a7c85e7b94017786384f9cf08adbfc132ed69a","user":{"login":"chenqin","id":1184534,"node_id":"MDQ6VXNlcjExODQ1MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1184534?v=4","gravatar_id":"","url":"https://api.github.com/users/chenqin","html_url":"https://github.com/chenqin","followers_url":"https://api.github.com/users/chenqin/followers","following_url":"https://api.github.com/users/chenqin/following{/other_user}","gists_url":"https://api.github.com/users/chenqin/gists{/gist_id}","starred_url":"https://api.github.com/users/chenqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenqin/subscriptions","organizations_url":"https://api.github.com/users/chenqin/orgs","repos_url":"https://api.github.com/users/chenqin/repos","events_url":"https://api.github.com/users/chenqin/events{/privacy}","received_events_url":"https://api.github.com/users/chenqin/received_events","type":"User","site_admin":false},"repo":{"id":142615172,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2MTUxNzI=","name":"xgboost","full_name":"chenqin/xgboost","private":false,"owner":{"login":"chenqin","id":1184534,"node_id":"MDQ6VXNlcjExODQ1MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1184534?v=4","gravatar_id":"","url":"https://api.github.com/users/chenqin","html_url":"https://github.com/chenqin","followers_url":"https://api.github.com/users/chenqin/followers","following_url":"https://api.github.com/users/chenqin/following{/other_user}","gists_url":"https://api.github.com/users/chenqin/gists{/gist_id}","starred_url":"https://api.github.com/users/chenqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenqin/subscriptions","organizations_url":"https://api.github.com/users/chenqin/orgs","repos_url":"https://api.github.com/users/chenqin/repos","events_url":"https://api.github.com/users/chenqin/events{/privacy}","received_events_url":"https://api.github.com/users/chenqin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chenqin/xgboost","description":"Scalable, Portable and Distributed Gradient Boosting (GBDT, GBRT or GBM) Library,  for Python, R, Java, Scala, C++ and more. Runs on single machine, Hadoop, Spark, Flink and DataFlow","fork":true,"url":"https://api.github.com/repos/chenqin/xgboost","forks_url":"https://api.github.com/repos/chenqin/xgboost/forks","keys_url":"https://api.github.com/repos/chenqin/xgboost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chenqin/xgboost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chenqin/xgboost/teams","hooks_url":"https://api.github.com/repos/chenqin/xgboost/hooks","issue_events_url":"https://api.github.com/repos/chenqin/xgboost/issues/events{/number}","events_url":"https://api.github.com/repos/chenqin/xgboost/events","assignees_url":"https://api.github.com/repos/chenqin/xgboost/assignees{/user}","branches_url":"https://api.github.com/repos/chenqin/xgboost/branches{/branch}","tags_url":"https://api.github.com/repos/chenqin/xgboost/tags","blobs_url":"https://api.github.com/repos/chenqin/xgboost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chenqin/xgboost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chenqin/xgboost/git/refs{/sha}","trees_url":"https://api.github.com/repos/chenqin/xgboost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chenqin/xgboost/statuses/{sha}","languages_url":"https://api.github.com/repos/chenqin/xgboost/languages","stargazers_url":"https://api.github.com/repos/chenqin/xgboost/stargazers","contributors_url":"https://api.github.com/repos/chenqin/xgboost/contributors","subscribers_url":"https://api.github.com/repos/chenqin/xgboost/subscribers","subscription_url":"https://api.github.com/repos/chenqin/xgboost/subscription","commits_url":"https://api.github.com/repos/chenqin/xgboost/commits{/sha}","git_commits_url":"https://api.github.com/repos/chenqin/xgboost/git/commits{/sha}","comments_url":"https://api.github.com/repos/chenqin/xgboost/comments{/number}","issue_comment_url":"https://api.github.com/repos/chenqin/xgboost/issues/comments{/number}","contents_url":"https://api.github.com/repos/chenqin/xgboost/contents/{+path}","compare_url":"https://api.github.com/repos/chenqin/xgboost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chenqin/xgboost/merges","archive_url":"https://api.github.com/repos/chenqin/xgboost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chenqin/xgboost/downloads","issues_url":"https://api.github.com/repos/chenqin/xgboost/issues{/number}","pulls_url":"https://api.github.com/repos/chenqin/xgboost/pulls{/number}","milestones_url":"https://api.github.com/repos/chenqin/xgboost/milestones{/number}","notifications_url":"https://api.github.com/repos/chenqin/xgboost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chenqin/xgboost/labels{/name}","releases_url":"https://api.github.com/repos/chenqin/xgboost/releases{/id}","deployments_url":"https://api.github.com/repos/chenqin/xgboost/deployments","created_at":"2018-07-27T19:16:00Z","updated_at":"2018-09-19T20:36:58Z","pushed_at":"2018-09-19T20:36:53Z","git_url":"git://github.com/chenqin/xgboost.git","ssh_url":"git@github.com:chenqin/xgboost.git","clone_url":"https://github.com/chenqin/xgboost.git","svn_url":"https://github.com/chenqin/xgboost","homepage":"https://xgboost.ai/","size":9617,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"aa53e9fc8d0fbd2e229246212fb40d107985cb83","user":{"login":"dmlc","id":11508361,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA4MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":16587283,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU4NzI4Mw==","name":"xgboost","full_name":"dmlc/xgboost","private":false,"owner":{"login":"dmlc","id":11508361,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA4MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dmlc/xgboost","description":"Scalable, Portable and Distributed Gradient Boosting (GBDT, GBRT or GBM) Library,  for Python, R, Java, Scala, C++ and more. Runs on single machine, Hadoop, Spark, Flink and DataFlow","fork":false,"url":"https://api.github.com/repos/dmlc/xgboost","forks_url":"https://api.github.com/repos/dmlc/xgboost/forks","keys_url":"https://api.github.com/repos/dmlc/xgboost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/xgboost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/xgboost/teams","hooks_url":"https://api.github.com/repos/dmlc/xgboost/hooks","issue_events_url":"https://api.github.com/repos/dmlc/xgboost/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/xgboost/events","assignees_url":"https://api.github.com/repos/dmlc/xgboost/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/xgboost/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/xgboost/tags","blobs_url":"https://api.github.com/repos/dmlc/xgboost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/xgboost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/xgboost/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/xgboost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/xgboost/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/xgboost/languages","stargazers_url":"https://api.github.com/repos/dmlc/xgboost/stargazers","contributors_url":"https://api.github.com/repos/dmlc/xgboost/contributors","subscribers_url":"https://api.github.com/repos/dmlc/xgboost/subscribers","subscription_url":"https://api.github.com/repos/dmlc/xgboost/subscription","commits_url":"https://api.github.com/repos/dmlc/xgboost/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/xgboost/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/xgboost/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/xgboost/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/xgboost/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/xgboost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/xgboost/merges","archive_url":"https://api.github.com/repos/dmlc/xgboost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/xgboost/downloads","issues_url":"https://api.github.com/repos/dmlc/xgboost/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/xgboost/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/xgboost/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/xgboost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/xgboost/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/xgboost/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/xgboost/deployments","created_at":"2014-02-06T17:28:03Z","updated_at":"2018-09-19T18:18:13Z","pushed_at":"2018-09-19T20:36:57Z","git_url":"git://github.com/dmlc/xgboost.git","ssh_url":"git@github.com:dmlc/xgboost.git","clone_url":"https://github.com/dmlc/xgboost.git","svn_url":"https://github.com/dmlc/xgboost","homepage":"https://xgboost.ai/","size":9669,"stargazers_count":13506,"watchers_count":13506,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5927,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5927,"open_issues":56,"watchers":13506,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/xgboost/pulls/3705"},"html":{"href":"https://github.com/dmlc/xgboost/pull/3705"},"issue":{"href":"https://api.github.com/repos/dmlc/xgboost/issues/3705"},"comments":{"href":"https://api.github.com/repos/dmlc/xgboost/issues/3705/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/xgboost/pulls/3705/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/xgboost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/xgboost/pulls/3705/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/xgboost/statuses/88a7c85e7b94017786384f9cf08adbfc132ed69a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chenqin"}}