{"action":"created","issue":{"url":"https://api.github.com/repos/gcp/leela-zero/issues/1741","repository_url":"https://api.github.com/repos/gcp/leela-zero","labels_url":"https://api.github.com/repos/gcp/leela-zero/issues/1741/labels{/name}","comments_url":"https://api.github.com/repos/gcp/leela-zero/issues/1741/comments","events_url":"https://api.github.com/repos/gcp/leela-zero/issues/1741/events","html_url":"https://github.com/gcp/leela-zero/pull/1741","id":351654308,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTk0NTMy","number":1741,"title":"specify MAX_TREE_SIZE as bytes rather than node count","user":{"login":"kuba97531","id":133693,"node_id":"MDQ6VXNlcjEzMzY5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/133693?v=4","gravatar_id":"","url":"https://api.github.com/users/kuba97531","html_url":"https://github.com/kuba97531","followers_url":"https://api.github.com/users/kuba97531/followers","following_url":"https://api.github.com/users/kuba97531/following{/other_user}","gists_url":"https://api.github.com/users/kuba97531/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba97531/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba97531/subscriptions","organizations_url":"https://api.github.com/users/kuba97531/orgs","repos_url":"https://api.github.com/users/kuba97531/repos","events_url":"https://api.github.com/users/kuba97531/events{/privacy}","received_events_url":"https://api.github.com/users/kuba97531/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-08-17T16:14:08Z","updated_at":"2018-09-03T13:05:19Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/gcp/leela-zero/pulls/1741","html_url":"https://github.com/gcp/leela-zero/pull/1741","diff_url":"https://github.com/gcp/leela-zero/pull/1741.diff","patch_url":"https://github.com/gcp/leela-zero/pull/1741.patch"},"body":"I see two good reasons to include this change\r\n\r\n1) Enable longer analysis on stronger computers with more RAM.\r\n\r\nI have been hitting the 100M nodes limit after few minutes of analysis. I think it's unrealistically low given that it's not very uncommon for people to have systems with 16+ Gigabytes of ram. Also it seems that the constant has been chosen when it was believed that memory consumption is roughly node_count * 56 (equal to `sizeof(UCTNode)`) which is no longer the case with the smart `UCTNodePointer`. I have observed as little memory consumption as 18 bytes per node instead of the 56 at 50 millions nodes.\r\n\r\n2) Enable earlier min_psa_ratio optimisation on slower computers with less RAM.\r\n\r\nSome people might want to reduce the number as it affects the search via `get_min_psa_ratio`.  https://github.com/kuba97531/leela-zero/blob/9e903eda6e93fb65375ea03127e4f62268913175/src/UCTSearch.cpp#L148-L149\r\n"},"comment":{"url":"https://api.github.com/repos/gcp/leela-zero/issues/comments/418109806","html_url":"https://github.com/gcp/leela-zero/pull/1741#issuecomment-418109806","issue_url":"https://api.github.com/repos/gcp/leela-zero/issues/1741","id":418109806,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODEwOTgwNg==","user":{"login":"ihavnoid","id":33939814,"node_id":"MDQ6VXNlcjMzOTM5ODE0","avatar_url":"https://avatars3.githubusercontent.com/u/33939814?v=4","gravatar_id":"","url":"https://api.github.com/users/ihavnoid","html_url":"https://github.com/ihavnoid","followers_url":"https://api.github.com/users/ihavnoid/followers","following_url":"https://api.github.com/users/ihavnoid/following{/other_user}","gists_url":"https://api.github.com/users/ihavnoid/gists{/gist_id}","starred_url":"https://api.github.com/users/ihavnoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihavnoid/subscriptions","organizations_url":"https://api.github.com/users/ihavnoid/orgs","repos_url":"https://api.github.com/users/ihavnoid/repos","events_url":"https://api.github.com/users/ihavnoid/events{/privacy}","received_events_url":"https://api.github.com/users/ihavnoid/received_events","type":"User","site_admin":false},"created_at":"2018-09-03T13:05:19Z","updated_at":"2018-09-03T13:05:19Z","author_association":"COLLABORATOR","body":"I will give it a try, but I expect there need to be some fudge factor because of the malloc pointer management overhead.  Will try and see what that overhead might be..."}}
{"actor":{"display_login":"ihavnoid"}}