{"action":"closed","issue":{"url":"https://api.github.com/repos/DAVFoundation/dav-js/issues/79","repository_url":"https://api.github.com/repos/DAVFoundation/dav-js","labels_url":"https://api.github.com/repos/DAVFoundation/dav-js/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/DAVFoundation/dav-js/issues/79/comments","events_url":"https://api.github.com/repos/DAVFoundation/dav-js/issues/79/events","html_url":"https://github.com/DAVFoundation/dav-js/issues/79","id":366873996,"node_id":"MDU6SXNzdWUzNjY4NzM5OTY=","number":79,"title":"Update tests for `src/ride-hailing/MissionParams.test.ts` using Jest","user":{"login":"mariolo1985","id":17772508,"node_id":"MDQ6VXNlcjE3NzcyNTA4","avatar_url":"https://avatars3.githubusercontent.com/u/17772508?v=4","gravatar_id":"","url":"https://api.github.com/users/mariolo1985","html_url":"https://github.com/mariolo1985","followers_url":"https://api.github.com/users/mariolo1985/followers","following_url":"https://api.github.com/users/mariolo1985/following{/other_user}","gists_url":"https://api.github.com/users/mariolo1985/gists{/gist_id}","starred_url":"https://api.github.com/users/mariolo1985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariolo1985/subscriptions","organizations_url":"https://api.github.com/users/mariolo1985/orgs","repos_url":"https://api.github.com/users/mariolo1985/repos","events_url":"https://api.github.com/users/mariolo1985/events{/privacy}","received_events_url":"https://api.github.com/users/mariolo1985/received_events","type":"User","site_admin":false},"labels":[{"id":741905022,"node_id":"MDU6TGFiZWw3NDE5MDUwMjI=","url":"https://api.github.com/repos/DAVFoundation/dav-js/labels/beginner","name":"beginner","color":"5319e7","default":false},{"id":673954642,"node_id":"MDU6TGFiZWw2NzM5NTQ2NDI=","url":"https://api.github.com/repos/DAVFoundation/dav-js/labels/claimed","name":"claimed","color":"b60205","default":false},{"id":673954769,"node_id":"MDU6TGFiZWw2NzM5NTQ3Njk=","url":"https://api.github.com/repos/DAVFoundation/dav-js/labels/first-timers-only","name":"first-timers-only","color":"5319e7","default":false},{"id":741905227,"node_id":"MDU6TGFiZWw3NDE5MDUyMjc=","url":"https://api.github.com/repos/DAVFoundation/dav-js/labels/good%20first%20issue","name":"good first issue","color":"5319e7","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-04T16:33:53Z","updated_at":"2018-10-05T17:55:31Z","closed_at":"2018-10-05T17:55:31Z","author_association":"CONTRIBUTOR","body":"## first-timers-only\r\n\r\nThis issue is tagged 🕺  **first-timers-only**. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.\r\n\r\nConsider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.\r\n\r\nFind more **first-timers-only** issues from DAV Foundation [here](https://github.com/search?q=first-timers-only+org%3ADAVFoundation+label%3A%22up-for-grabs%22&state=open&type=Issues).\r\n\r\nThank you for your help :heart:\r\n\r\n## What is this project? \r\n\r\nDAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.\r\n\r\nAs an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.\r\n\r\n### dav-js\r\n\r\nThis repo contains the DAV JavaScript SDK. This SDK allows developers to build applications and servers that connect to the DAV network. For example, allowing a drone to find charging stations, or an autonomous car to ask for traffic data.\r\n\r\n## How you can help\r\n\r\nIn order to foster a community that is welcoming for open source contributions, it is important for us to have good test coverage. And good tests are simple, readable tests.\r\n\r\nHere is a good opportunity to simplify one of our tests.\r\n\r\n### The Issue\r\n\r\nIn [`src/ride-hailing/MissionParams.test.ts`](../blob/master/src/ride-hailing/MissionParams.test.ts#L25) we defined the following **deserialize** method test. This is currently testing for the object content.\r\n\r\n```javascript\r\n  describe('deserialize method', () => {\r\n    it('should return serialized MissionParams instance with the current parameters', () => {\r\n      const missionParamsObject = new MissionParams();\r\n      missionParamsObject.deserialize(serializedMissionParams);\r\n      expect(missionParamsObject).toEqual(missionParams);\r\n    });\r\n  });\r\n```\r\n\r\nPlease update the **deserialize** tests to check for the instance and the object content similar to the deserialize method test found [here](https://github.com/DAVFoundation/dav-js/blob/master/src/vessel-charging/messages/ChargingCompleteMessageParams.test.ts#L21).\r\n\r\n![deserializetest][deserializetest]\r\n\r\nAfter making your changes, run `npm run jest` to make sure our tests are passing.\r\n\r\n### Contributing to dav-js\r\n\r\n- [ ] Make sure this issue is labeled `up-for-grabs` and not labeled `claimed`, to verify no one else is working on it.\r\n- [ ] Comment on this issue that you would like to do it (if you're the first you can start working on it immediately)\r\n- [ ] Open [dav-js GitHub page](https://github.com/DAVFoundation/dav-js) and click the ★ Star and then ⑂ Fork buttons\r\n- [ ] Clone a copy to your local machine with `$ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git`\r\n- [ ] Install dependencies by running `npm install`\r\n- [ ] Make sure everything is working and all tests pass by running `npm run jest`\r\n- [ ] **Code Code Code**\r\n- [ ] Make sure everything is still working and all tests pass by running `npm run jest` again\r\n- [ ] Commit all your changes\r\n- [ ] Push your local changes back to github with `$ git push -u origin master`\r\n- [ ] Visit your fork on GitHub.com ([https://github.com/YOUR-USER-NAME/dav-js](https://github.com/YOUR-USER-NAME/dav-js)) and create a pull request for your changes.\r\n- [ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: `#7`)\r\n- [ ] Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.\r\n\r\n### Asking for help\r\n\r\nWe appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our [gitter channel](https://gitter.im/DAVFoundation/DAV-Contributors). We are always happy to help 😄\r\n\r\n[deserializetest]: https://raw.githubusercontent.com/mariolo1985/opensource-issue-list/4aec560e39447f68dc22cbe5beda10d72c6ecd4a/issues/davjs/MissionParms/instancetest.png \"deserialize test\"\r\n"}}
{"actor":{"display_login":"mariolo1985"}}