{"action":"closed","issue":{"url":"https://api.github.com/repos/lerna/lerna/issues/1345","repository_url":"https://api.github.com/repos/lerna/lerna","labels_url":"https://api.github.com/repos/lerna/lerna/issues/1345/labels{/name}","comments_url":"https://api.github.com/repos/lerna/lerna/issues/1345/comments","events_url":"https://api.github.com/repos/lerna/lerna/issues/1345/events","html_url":"https://github.com/lerna/lerna/issues/1345","id":307714201,"number":1345,"title":"Using squashed commits for releases results in lerna publish listing all packages","user":{"login":"penx","id":1027024,"avatar_url":"https://avatars3.githubusercontent.com/u/1027024?v=4","gravatar_id":"","url":"https://api.github.com/users/penx","html_url":"https://github.com/penx","followers_url":"https://api.github.com/users/penx/followers","following_url":"https://api.github.com/users/penx/following{/other_user}","gists_url":"https://api.github.com/users/penx/gists{/gist_id}","starred_url":"https://api.github.com/users/penx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penx/subscriptions","organizations_url":"https://api.github.com/users/penx/orgs","repos_url":"https://api.github.com/users/penx/repos","events_url":"https://api.github.com/users/penx/events{/privacy}","received_events_url":"https://api.github.com/users/penx/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-22T16:16:17Z","updated_at":"2018-03-22T17:21:16Z","closed_at":"2018-03-22T17:21:16Z","author_association":"NONE","body":"## Our Workflow\r\n\r\n- Developers that are able to propose a release do not have push access to master, all changes go via a pull request on GitHub.\r\n- Pull requests are set to squash commit to master by default.\r\n- A developer runs `lerna publish --skip-npm` on a branch of master and opens a pull request with the version increment.\r\n- When merged, the default commit message added by GitHub is `v1.0.0 (#101)` which is the Lerna generated version number followed by the GitHub pull request ID.\r\n\r\n## Expected Behavior\r\n\r\nAfter following the workflow above, I would expect `lerna updated` to list no new changes on master immediately after a release.\r\n\r\n## Current Behavior\r\n\r\nAll packages are listed as containing changes, I assume because Lerna is looking for a commit message of `v1.0.0` for a release, and does not match `v1.0.0 (#101)`.\r\n\r\n## Possible Solution\r\n\r\nWhen looking for published versions in commit messages, match an optional pull request ID following the version number (e.g. `v1.0.0 (#101)`) with a regex.\r\n\r\n## Steps to Reproduce (for bugs)\r\n\r\nOur release process is [here](https://github.com/penx/govuk-react/blob/master/CONTRIBUTING.md#releasing).\r\n\r\nThis is partially scripted [here](https://github.com/penx/govuk-react/blob/master/scripts/release.sh).\r\n\r\n| Executable | Version |\r\n| ---: | :--- |\r\n| `lerna --version` | 2.9.0 |\r\n| `npm --version`  | 5.6.0 |\r\n| `yarn --version` | 1.5.1 |\r\n| `node --version` | v8.9.4 |\r\n"}}
{"actor":{"display_login":"penx"}}