{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/pulls/2","id":236808318,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODA4MzE4","html_url":"https://github.com/prateekrastogi/videojs-landscape-fullscreen/pull/2","diff_url":"https://github.com/prateekrastogi/videojs-landscape-fullscreen/pull/2.diff","patch_url":"https://github.com/prateekrastogi/videojs-landscape-fullscreen/pull/2.patch","issue_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/issues/2","number":2,"state":"closed","locked":false,"title":"Make sure screen.orientation exists before register onchange event","user":{"login":"suchy","id":255720,"node_id":"MDQ6VXNlcjI1NTcyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/255720?v=4","gravatar_id":"","url":"https://api.github.com/users/suchy","html_url":"https://github.com/suchy","followers_url":"https://api.github.com/users/suchy/followers","following_url":"https://api.github.com/users/suchy/following{/other_user}","gists_url":"https://api.github.com/users/suchy/gists{/gist_id}","starred_url":"https://api.github.com/users/suchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suchy/subscriptions","organizations_url":"https://api.github.com/users/suchy/orgs","repos_url":"https://api.github.com/users/suchy/repos","events_url":"https://api.github.com/users/suchy/events{/privacy}","received_events_url":"https://api.github.com/users/suchy/received_events","type":"User","site_admin":false},"body":"# Why\r\n\r\nThis fix is checking if `screen.orientation` exists before register `onchange` event.\r\n\r\nThis is some strange edge case. \r\n\r\n## Error log:\r\n\r\n```\r\nTypeError: Cannot set property 'onchange' of undefined\r\n  at Array.forEach (/production_b07cfcf7ebb8414f4246d6c04eb049f00910df2e/vjsfullscreen.d975b8370d43b1717244.es5.js)\r\n  at a (../src/integrations/helpers.ts:77:19)\r\n...\r\n(3 additional frame(s) were not displayed)\r\n```\r\n\r\n## User info:\r\n\r\nbrowser: `Chrome Mobile 33.0.1750`\r\nbrowser.name: `Chrome Mobile`\r\ndevice: `C1904`\r\ndevice.family: `C1904`\r\nlevel `error`\r\nos `Android 4.3`","created_at":"2018-12-07T09:47:17Z","updated_at":"2018-12-10T11:50:33Z","closed_at":"2018-12-10T11:50:33Z","merged_at":"2018-12-10T11:50:33Z","merge_commit_sha":"e82c9615b9322f3f9e5c7a10a144dc13a5ae4329","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/pulls/2/commits","review_comments_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/pulls/2/comments","review_comment_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/issues/2/comments","statuses_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/statuses/da9fdeeb4f02c6eb679142f61602ed62a00e0785","head":{"label":"suchy:fix-scrteen-orientation-change","ref":"fix-scrteen-orientation-change","sha":"da9fdeeb4f02c6eb679142f61602ed62a00e0785","user":{"login":"suchy","id":255720,"node_id":"MDQ6VXNlcjI1NTcyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/255720?v=4","gravatar_id":"","url":"https://api.github.com/users/suchy","html_url":"https://github.com/suchy","followers_url":"https://api.github.com/users/suchy/followers","following_url":"https://api.github.com/users/suchy/following{/other_user}","gists_url":"https://api.github.com/users/suchy/gists{/gist_id}","starred_url":"https://api.github.com/users/suchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suchy/subscriptions","organizations_url":"https://api.github.com/users/suchy/orgs","repos_url":"https://api.github.com/users/suchy/repos","events_url":"https://api.github.com/users/suchy/events{/privacy}","received_events_url":"https://api.github.com/users/suchy/received_events","type":"User","site_admin":false},"repo":{"id":160796753,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA3OTY3NTM=","name":"videojs-landscape-fullscreen","full_name":"suchy/videojs-landscape-fullscreen","private":false,"owner":{"login":"suchy","id":255720,"node_id":"MDQ6VXNlcjI1NTcyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/255720?v=4","gravatar_id":"","url":"https://api.github.com/users/suchy","html_url":"https://github.com/suchy","followers_url":"https://api.github.com/users/suchy/followers","following_url":"https://api.github.com/users/suchy/following{/other_user}","gists_url":"https://api.github.com/users/suchy/gists{/gist_id}","starred_url":"https://api.github.com/users/suchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suchy/subscriptions","organizations_url":"https://api.github.com/users/suchy/orgs","repos_url":"https://api.github.com/users/suchy/repos","events_url":"https://api.github.com/users/suchy/events{/privacy}","received_events_url":"https://api.github.com/users/suchy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/suchy/videojs-landscape-fullscreen","description":"Automatically Switch to Landscape on Fullscreen, and Fullscreen on Landscape","fork":true,"url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen","forks_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/forks","keys_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/teams","hooks_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/hooks","issue_events_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/issues/events{/number}","events_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/events","assignees_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/assignees{/user}","branches_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/branches{/branch}","tags_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/tags","blobs_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/git/refs{/sha}","trees_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/statuses/{sha}","languages_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/languages","stargazers_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/stargazers","contributors_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/contributors","subscribers_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/subscribers","subscription_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/subscription","commits_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/commits{/sha}","git_commits_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/git/commits{/sha}","comments_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/comments{/number}","issue_comment_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/issues/comments{/number}","contents_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/contents/{+path}","compare_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/merges","archive_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/downloads","issues_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/issues{/number}","pulls_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/pulls{/number}","milestones_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/milestones{/number}","notifications_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/labels{/name}","releases_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/releases{/id}","deployments_url":"https://api.github.com/repos/suchy/videojs-landscape-fullscreen/deployments","created_at":"2018-12-07T08:47:12Z","updated_at":"2018-12-07T08:47:14Z","pushed_at":"2018-12-07T09:38:28Z","git_url":"git://github.com/suchy/videojs-landscape-fullscreen.git","ssh_url":"git@github.com:suchy/videojs-landscape-fullscreen.git","clone_url":"https://github.com/suchy/videojs-landscape-fullscreen.git","svn_url":"https://github.com/suchy/videojs-landscape-fullscreen","homepage":"","size":77,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prateekrastogi:master","ref":"master","sha":"70a7a4fbc20e0814a702b5a59fab26cc35a3defe","user":{"login":"prateekrastogi","id":14788991,"node_id":"MDQ6VXNlcjE0Nzg4OTkx","avatar_url":"https://avatars2.githubusercontent.com/u/14788991?v=4","gravatar_id":"","url":"https://api.github.com/users/prateekrastogi","html_url":"https://github.com/prateekrastogi","followers_url":"https://api.github.com/users/prateekrastogi/followers","following_url":"https://api.github.com/users/prateekrastogi/following{/other_user}","gists_url":"https://api.github.com/users/prateekrastogi/gists{/gist_id}","starred_url":"https://api.github.com/users/prateekrastogi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateekrastogi/subscriptions","organizations_url":"https://api.github.com/users/prateekrastogi/orgs","repos_url":"https://api.github.com/users/prateekrastogi/repos","events_url":"https://api.github.com/users/prateekrastogi/events{/privacy}","received_events_url":"https://api.github.com/users/prateekrastogi/received_events","type":"User","site_admin":false},"repo":{"id":134839208,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ4MzkyMDg=","name":"videojs-landscape-fullscreen","full_name":"prateekrastogi/videojs-landscape-fullscreen","private":false,"owner":{"login":"prateekrastogi","id":14788991,"node_id":"MDQ6VXNlcjE0Nzg4OTkx","avatar_url":"https://avatars2.githubusercontent.com/u/14788991?v=4","gravatar_id":"","url":"https://api.github.com/users/prateekrastogi","html_url":"https://github.com/prateekrastogi","followers_url":"https://api.github.com/users/prateekrastogi/followers","following_url":"https://api.github.com/users/prateekrastogi/following{/other_user}","gists_url":"https://api.github.com/users/prateekrastogi/gists{/gist_id}","starred_url":"https://api.github.com/users/prateekrastogi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateekrastogi/subscriptions","organizations_url":"https://api.github.com/users/prateekrastogi/orgs","repos_url":"https://api.github.com/users/prateekrastogi/repos","events_url":"https://api.github.com/users/prateekrastogi/events{/privacy}","received_events_url":"https://api.github.com/users/prateekrastogi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/prateekrastogi/videojs-landscape-fullscreen","description":"Automatically Switch to Landscape on Fullscreen, and Fullscreen on Landscape","fork":false,"url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen","forks_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/forks","keys_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/teams","hooks_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/hooks","issue_events_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/issues/events{/number}","events_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/events","assignees_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/assignees{/user}","branches_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/branches{/branch}","tags_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/tags","blobs_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/git/refs{/sha}","trees_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/statuses/{sha}","languages_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/languages","stargazers_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/stargazers","contributors_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/contributors","subscribers_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/subscribers","subscription_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/subscription","commits_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/commits{/sha}","git_commits_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/git/commits{/sha}","comments_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/comments{/number}","issue_comment_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/issues/comments{/number}","contents_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/contents/{+path}","compare_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/merges","archive_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/downloads","issues_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/issues{/number}","pulls_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/pulls{/number}","milestones_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/milestones{/number}","notifications_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/labels{/name}","releases_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/releases{/id}","deployments_url":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/deployments","created_at":"2018-05-25T10:05:00Z","updated_at":"2018-11-30T02:24:28Z","pushed_at":"2018-12-10T11:50:33Z","git_url":"git://github.com/prateekrastogi/videojs-landscape-fullscreen.git","ssh_url":"git@github.com:prateekrastogi/videojs-landscape-fullscreen.git","clone_url":"https://github.com/prateekrastogi/videojs-landscape-fullscreen.git","svn_url":"https://github.com/prateekrastogi/videojs-landscape-fullscreen","homepage":"","size":76,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":0,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/pulls/2"},"html":{"href":"https://github.com/prateekrastogi/videojs-landscape-fullscreen/pull/2"},"issue":{"href":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/issues/2"},"comments":{"href":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/prateekrastogi/videojs-landscape-fullscreen/statuses/da9fdeeb4f02c6eb679142f61602ed62a00e0785"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"prateekrastogi","id":14788991,"node_id":"MDQ6VXNlcjE0Nzg4OTkx","avatar_url":"https://avatars2.githubusercontent.com/u/14788991?v=4","gravatar_id":"","url":"https://api.github.com/users/prateekrastogi","html_url":"https://github.com/prateekrastogi","followers_url":"https://api.github.com/users/prateekrastogi/followers","following_url":"https://api.github.com/users/prateekrastogi/following{/other_user}","gists_url":"https://api.github.com/users/prateekrastogi/gists{/gist_id}","starred_url":"https://api.github.com/users/prateekrastogi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateekrastogi/subscriptions","organizations_url":"https://api.github.com/users/prateekrastogi/orgs","repos_url":"https://api.github.com/users/prateekrastogi/repos","events_url":"https://api.github.com/users/prateekrastogi/events{/privacy}","received_events_url":"https://api.github.com/users/prateekrastogi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"prateekrastogi"}}