{"action":"created","comment":{"url":"https://api.github.com/repos/FWGS/xash3d/pulls/comments/201995313","pull_request_review_id":136602302,"id":201995313,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTk5NTMxMw==","diff_hunk":"@@ -609,7 +609,7 @@ set EF_BRIGHTFIELD effect\n */\n void GAME_EXPORT CL_EntityParticles( cl_entity_t *ent )\n {\n-\tfloat\t\tangle;\n+\t// float\t\tangle;","path":"engine/client/gl_rpart.c","position":5,"original_position":5,"commit_id":"df38e538ad882a3ea718243d6464450b425989c2","original_commit_id":"df38e538ad882a3ea718243d6464450b425989c2","user":{"login":"mittorn","id":2101109,"node_id":"MDQ6VXNlcjIxMDExMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2101109?v=4","gravatar_id":"","url":"https://api.github.com/users/mittorn","html_url":"https://github.com/mittorn","followers_url":"https://api.github.com/users/mittorn/followers","following_url":"https://api.github.com/users/mittorn/following{/other_user}","gists_url":"https://api.github.com/users/mittorn/gists{/gist_id}","starred_url":"https://api.github.com/users/mittorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mittorn/subscriptions","organizations_url":"https://api.github.com/users/mittorn/orgs","repos_url":"https://api.github.com/users/mittorn/repos","events_url":"https://api.github.com/users/mittorn/events{/privacy}","received_events_url":"https://api.github.com/users/mittorn/received_events","type":"User","site_admin":false},"body":"It makes code difficult to read.\r\nUnused variable warning will not break anything, it is just developer note, so it is better to leave variable as is. It is better to make coverity tests sometimes to search for dead code. Dead code much worse. It may break in future.","created_at":"2018-07-12T11:06:04Z","updated_at":"2018-07-12T11:06:04Z","html_url":"https://github.com/FWGS/xash3d/pull/388#discussion_r201995313","pull_request_url":"https://api.github.com/repos/FWGS/xash3d/pulls/388","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/FWGS/xash3d/pulls/comments/201995313"},"html":{"href":"https://github.com/FWGS/xash3d/pull/388#discussion_r201995313"},"pull_request":{"href":"https://api.github.com/repos/FWGS/xash3d/pulls/388"}},"in_reply_to_id":201927877},"pull_request":{"url":"https://api.github.com/repos/FWGS/xash3d/pulls/388","id":200861349,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODYxMzQ5","html_url":"https://github.com/FWGS/xash3d/pull/388","diff_url":"https://github.com/FWGS/xash3d/pull/388.diff","patch_url":"https://github.com/FWGS/xash3d/pull/388.patch","issue_url":"https://api.github.com/repos/FWGS/xash3d/issues/388","number":388,"state":"open","locked":false,"title":"Better strobe code","user":{"login":"fuzun","id":5276126,"node_id":"MDQ6VXNlcjUyNzYxMjY=","avatar_url":"https://avatars1.githubusercontent.com/u/5276126?v=4","gravatar_id":"","url":"https://api.github.com/users/fuzun","html_url":"https://github.com/fuzun","followers_url":"https://api.github.com/users/fuzun/followers","following_url":"https://api.github.com/users/fuzun/following{/other_user}","gists_url":"https://api.github.com/users/fuzun/gists{/gist_id}","starred_url":"https://api.github.com/users/fuzun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuzun/subscriptions","organizations_url":"https://api.github.com/users/fuzun/orgs","repos_url":"https://api.github.com/users/fuzun/repos","events_url":"https://api.github.com/users/fuzun/events{/privacy}","received_events_url":"https://api.github.com/users/fuzun/received_events","type":"User","site_admin":false},"body":"+ some msvc warning corrections.","created_at":"2018-07-12T00:43:39Z","updated_at":"2018-07-12T11:06:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a19625587e1441b431267726744dc7b6f56d652e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FWGS/xash3d/pulls/388/commits","review_comments_url":"https://api.github.com/repos/FWGS/xash3d/pulls/388/comments","review_comment_url":"https://api.github.com/repos/FWGS/xash3d/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FWGS/xash3d/issues/388/comments","statuses_url":"https://api.github.com/repos/FWGS/xash3d/statuses/df38e538ad882a3ea718243d6464450b425989c2","head":{"label":"fuzun:master","ref":"master","sha":"df38e538ad882a3ea718243d6464450b425989c2","user":{"login":"fuzun","id":5276126,"node_id":"MDQ6VXNlcjUyNzYxMjY=","avatar_url":"https://avatars1.githubusercontent.com/u/5276126?v=4","gravatar_id":"","url":"https://api.github.com/users/fuzun","html_url":"https://github.com/fuzun","followers_url":"https://api.github.com/users/fuzun/followers","following_url":"https://api.github.com/users/fuzun/following{/other_user}","gists_url":"https://api.github.com/users/fuzun/gists{/gist_id}","starred_url":"https://api.github.com/users/fuzun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuzun/subscriptions","organizations_url":"https://api.github.com/users/fuzun/orgs","repos_url":"https://api.github.com/users/fuzun/repos","events_url":"https://api.github.com/users/fuzun/events{/privacy}","received_events_url":"https://api.github.com/users/fuzun/received_events","type":"User","site_admin":false},"repo":{"id":118024586,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgwMjQ1ODY=","name":"xash3d-strobe","full_name":"fuzun/xash3d-strobe","owner":{"login":"fuzun","id":5276126,"node_id":"MDQ6VXNlcjUyNzYxMjY=","avatar_url":"https://avatars1.githubusercontent.com/u/5276126?v=4","gravatar_id":"","url":"https://api.github.com/users/fuzun","html_url":"https://github.com/fuzun","followers_url":"https://api.github.com/users/fuzun/followers","following_url":"https://api.github.com/users/fuzun/following{/other_user}","gists_url":"https://api.github.com/users/fuzun/gists{/gist_id}","starred_url":"https://api.github.com/users/fuzun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuzun/subscriptions","organizations_url":"https://api.github.com/users/fuzun/orgs","repos_url":"https://api.github.com/users/fuzun/repos","events_url":"https://api.github.com/users/fuzun/events{/privacy}","received_events_url":"https://api.github.com/users/fuzun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fuzun/xash3d-strobe","description":"Xash3d fork for software based strobing (StrobeAPI). Check \"strobe-support\" branch.","fork":true,"url":"https://api.github.com/repos/fuzun/xash3d-strobe","forks_url":"https://api.github.com/repos/fuzun/xash3d-strobe/forks","keys_url":"https://api.github.com/repos/fuzun/xash3d-strobe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fuzun/xash3d-strobe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fuzun/xash3d-strobe/teams","hooks_url":"https://api.github.com/repos/fuzun/xash3d-strobe/hooks","issue_events_url":"https://api.github.com/repos/fuzun/xash3d-strobe/issues/events{/number}","events_url":"https://api.github.com/repos/fuzun/xash3d-strobe/events","assignees_url":"https://api.github.com/repos/fuzun/xash3d-strobe/assignees{/user}","branches_url":"https://api.github.com/repos/fuzun/xash3d-strobe/branches{/branch}","tags_url":"https://api.github.com/repos/fuzun/xash3d-strobe/tags","blobs_url":"https://api.github.com/repos/fuzun/xash3d-strobe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fuzun/xash3d-strobe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fuzun/xash3d-strobe/git/refs{/sha}","trees_url":"https://api.github.com/repos/fuzun/xash3d-strobe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fuzun/xash3d-strobe/statuses/{sha}","languages_url":"https://api.github.com/repos/fuzun/xash3d-strobe/languages","stargazers_url":"https://api.github.com/repos/fuzun/xash3d-strobe/stargazers","contributors_url":"https://api.github.com/repos/fuzun/xash3d-strobe/contributors","subscribers_url":"https://api.github.com/repos/fuzun/xash3d-strobe/subscribers","subscription_url":"https://api.github.com/repos/fuzun/xash3d-strobe/subscription","commits_url":"https://api.github.com/repos/fuzun/xash3d-strobe/commits{/sha}","git_commits_url":"https://api.github.com/repos/fuzun/xash3d-strobe/git/commits{/sha}","comments_url":"https://api.github.com/repos/fuzun/xash3d-strobe/comments{/number}","issue_comment_url":"https://api.github.com/repos/fuzun/xash3d-strobe/issues/comments{/number}","contents_url":"https://api.github.com/repos/fuzun/xash3d-strobe/contents/{+path}","compare_url":"https://api.github.com/repos/fuzun/xash3d-strobe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fuzun/xash3d-strobe/merges","archive_url":"https://api.github.com/repos/fuzun/xash3d-strobe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fuzun/xash3d-strobe/downloads","issues_url":"https://api.github.com/repos/fuzun/xash3d-strobe/issues{/number}","pulls_url":"https://api.github.com/repos/fuzun/xash3d-strobe/pulls{/number}","milestones_url":"https://api.github.com/repos/fuzun/xash3d-strobe/milestones{/number}","notifications_url":"https://api.github.com/repos/fuzun/xash3d-strobe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fuzun/xash3d-strobe/labels{/name}","releases_url":"https://api.github.com/repos/fuzun/xash3d-strobe/releases{/id}","deployments_url":"https://api.github.com/repos/fuzun/xash3d-strobe/deployments","created_at":"2018-01-18T18:56:26Z","updated_at":"2018-07-04T20:44:23Z","pushed_at":"2018-07-12T00:41:19Z","git_url":"git://github.com/fuzun/xash3d-strobe.git","ssh_url":"git@github.com:fuzun/xash3d-strobe.git","clone_url":"https://github.com/fuzun/xash3d-strobe.git","svn_url":"https://github.com/fuzun/xash3d-strobe","homepage":"","size":12634,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"strobe-support"}},"base":{"label":"FWGS:master","ref":"master","sha":"c8338e66a91cbeae68f72a9016dd08da100034e6","user":{"login":"FWGS","id":10867064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODY3MDY0","avatar_url":"https://avatars1.githubusercontent.com/u/10867064?v=4","gravatar_id":"","url":"https://api.github.com/users/FWGS","html_url":"https://github.com/FWGS","followers_url":"https://api.github.com/users/FWGS/followers","following_url":"https://api.github.com/users/FWGS/following{/other_user}","gists_url":"https://api.github.com/users/FWGS/gists{/gist_id}","starred_url":"https://api.github.com/users/FWGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FWGS/subscriptions","organizations_url":"https://api.github.com/users/FWGS/orgs","repos_url":"https://api.github.com/users/FWGS/repos","events_url":"https://api.github.com/users/FWGS/events{/privacy}","received_events_url":"https://api.github.com/users/FWGS/received_events","type":"Organization","site_admin":false},"repo":{"id":30359229,"node_id":"MDEwOlJlcG9zaXRvcnkzMDM1OTIyOQ==","name":"xash3d","full_name":"FWGS/xash3d","owner":{"login":"FWGS","id":10867064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODY3MDY0","avatar_url":"https://avatars1.githubusercontent.com/u/10867064?v=4","gravatar_id":"","url":"https://api.github.com/users/FWGS","html_url":"https://github.com/FWGS","followers_url":"https://api.github.com/users/FWGS/followers","following_url":"https://api.github.com/users/FWGS/following{/other_user}","gists_url":"https://api.github.com/users/FWGS/gists{/gist_id}","starred_url":"https://api.github.com/users/FWGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FWGS/subscriptions","organizations_url":"https://api.github.com/users/FWGS/orgs","repos_url":"https://api.github.com/users/FWGS/repos","events_url":"https://api.github.com/users/FWGS/events{/privacy}","received_events_url":"https://api.github.com/users/FWGS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FWGS/xash3d","description":"Xash3D FWGS Engine. Fork of Xash3D. Stable in \"master\" branch.","fork":false,"url":"https://api.github.com/repos/FWGS/xash3d","forks_url":"https://api.github.com/repos/FWGS/xash3d/forks","keys_url":"https://api.github.com/repos/FWGS/xash3d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FWGS/xash3d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FWGS/xash3d/teams","hooks_url":"https://api.github.com/repos/FWGS/xash3d/hooks","issue_events_url":"https://api.github.com/repos/FWGS/xash3d/issues/events{/number}","events_url":"https://api.github.com/repos/FWGS/xash3d/events","assignees_url":"https://api.github.com/repos/FWGS/xash3d/assignees{/user}","branches_url":"https://api.github.com/repos/FWGS/xash3d/branches{/branch}","tags_url":"https://api.github.com/repos/FWGS/xash3d/tags","blobs_url":"https://api.github.com/repos/FWGS/xash3d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FWGS/xash3d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FWGS/xash3d/git/refs{/sha}","trees_url":"https://api.github.com/repos/FWGS/xash3d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FWGS/xash3d/statuses/{sha}","languages_url":"https://api.github.com/repos/FWGS/xash3d/languages","stargazers_url":"https://api.github.com/repos/FWGS/xash3d/stargazers","contributors_url":"https://api.github.com/repos/FWGS/xash3d/contributors","subscribers_url":"https://api.github.com/repos/FWGS/xash3d/subscribers","subscription_url":"https://api.github.com/repos/FWGS/xash3d/subscription","commits_url":"https://api.github.com/repos/FWGS/xash3d/commits{/sha}","git_commits_url":"https://api.github.com/repos/FWGS/xash3d/git/commits{/sha}","comments_url":"https://api.github.com/repos/FWGS/xash3d/comments{/number}","issue_comment_url":"https://api.github.com/repos/FWGS/xash3d/issues/comments{/number}","contents_url":"https://api.github.com/repos/FWGS/xash3d/contents/{+path}","compare_url":"https://api.github.com/repos/FWGS/xash3d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FWGS/xash3d/merges","archive_url":"https://api.github.com/repos/FWGS/xash3d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FWGS/xash3d/downloads","issues_url":"https://api.github.com/repos/FWGS/xash3d/issues{/number}","pulls_url":"https://api.github.com/repos/FWGS/xash3d/pulls{/number}","milestones_url":"https://api.github.com/repos/FWGS/xash3d/milestones{/number}","notifications_url":"https://api.github.com/repos/FWGS/xash3d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FWGS/xash3d/labels{/name}","releases_url":"https://api.github.com/repos/FWGS/xash3d/releases{/id}","deployments_url":"https://api.github.com/repos/FWGS/xash3d/deployments","created_at":"2015-02-05T14:24:30Z","updated_at":"2018-07-10T18:52:48Z","pushed_at":"2018-07-12T00:43:40Z","git_url":"git://github.com/FWGS/xash3d.git","ssh_url":"git@github.com:FWGS/xash3d.git","clone_url":"https://github.com/FWGS/xash3d.git","svn_url":"https://github.com/FWGS/xash3d","homepage":"http://xash.su","size":12961,"stargazers_count":263,"watchers_count":263,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":57,"open_issues":45,"watchers":263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FWGS/xash3d/pulls/388"},"html":{"href":"https://github.com/FWGS/xash3d/pull/388"},"issue":{"href":"https://api.github.com/repos/FWGS/xash3d/issues/388"},"comments":{"href":"https://api.github.com/repos/FWGS/xash3d/issues/388/comments"},"review_comments":{"href":"https://api.github.com/repos/FWGS/xash3d/pulls/388/comments"},"review_comment":{"href":"https://api.github.com/repos/FWGS/xash3d/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FWGS/xash3d/pulls/388/commits"},"statuses":{"href":"https://api.github.com/repos/FWGS/xash3d/statuses/df38e538ad882a3ea718243d6464450b425989c2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mittorn"}}