{"action":"created","comment":{"url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/comments/194343073","pull_request_review_id":127494345,"id":194343073,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDM0MzA3Mw==","diff_hunk":"@@ -41,13 +41,18 @@ export default function fieldsCollision (bottomField, topField) {\n \n   if (bottomField.isOcean) {\n     subduction(bottomField, topField)\n-    if (bottomField.isContinentBuffer && !topField.isContinent) {\n+    if (bottomField.isContinentBuffer && !topField.isContinent && !topField.isContinentBuffer) {\n       // Special case when the continent is \"trying\" to subduct under the ocean. Apply drag force to stop both plates.\n+      // There's one exception - when both fields are continent buffers, it means continents are about to collide soon.\n+      // Don't apply forces in this case, so the orogeny can actually happen.\n       applyDragForces(bottomField, topField)\n     }\n   } else if (bottomField.isContinent) {\n     if (topField.isContinent) {\n       orogeny(bottomField, topField)\n+    } else if (topField.isContinentBuffer) {\n+      // Continents are next to each other. They will collide soon. Remove oceanic field to let that happen.\n+      topField.alive = false","path":"js/plates-model/fields-collision.js","position":16,"original_position":16,"commit_id":"9f23f7fe85479c5df6152f04e44b4e29f2acf2f9","original_commit_id":"9f23f7fe85479c5df6152f04e44b4e29f2acf2f9","user":{"login":"pjanik","id":767857,"node_id":"MDQ6VXNlcjc2Nzg1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/767857?v=4","gravatar_id":"","url":"https://api.github.com/users/pjanik","html_url":"https://github.com/pjanik","followers_url":"https://api.github.com/users/pjanik/followers","following_url":"https://api.github.com/users/pjanik/following{/other_user}","gists_url":"https://api.github.com/users/pjanik/gists{/gist_id}","starred_url":"https://api.github.com/users/pjanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjanik/subscriptions","organizations_url":"https://api.github.com/users/pjanik/orgs","repos_url":"https://api.github.com/users/pjanik/repos","events_url":"https://api.github.com/users/pjanik/events{/privacy}","received_events_url":"https://api.github.com/users/pjanik/received_events","type":"User","site_admin":false},"body":"It does. We remove ocean crust that otherwise would collide with the continent and won't allow orogeny to happen.","created_at":"2018-06-11T09:32:21Z","updated_at":"2018-06-11T09:32:21Z","html_url":"https://github.com/concord-consortium/tectonic-explorer/pull/34#discussion_r194343073","pull_request_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/34","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/comments/194343073"},"html":{"href":"https://github.com/concord-consortium/tectonic-explorer/pull/34#discussion_r194343073"},"pull_request":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/34"}},"in_reply_to_id":194204702},"pull_request":{"url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/34","id":193586548,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTg2NTQ4","html_url":"https://github.com/concord-consortium/tectonic-explorer/pull/34","diff_url":"https://github.com/concord-consortium/tectonic-explorer/pull/34.diff","patch_url":"https://github.com/concord-consortium/tectonic-explorer/pull/34.patch","issue_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/34","number":34,"state":"open","locked":false,"title":"Improve continent buffers handling","user":{"login":"pjanik","id":767857,"node_id":"MDQ6VXNlcjc2Nzg1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/767857?v=4","gravatar_id":"","url":"https://api.github.com/users/pjanik","html_url":"https://github.com/pjanik","followers_url":"https://api.github.com/users/pjanik/followers","following_url":"https://api.github.com/users/pjanik/following{/other_user}","gists_url":"https://api.github.com/users/pjanik/gists{/gist_id}","starred_url":"https://api.github.com/users/pjanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjanik/subscriptions","organizations_url":"https://api.github.com/users/pjanik/orgs","repos_url":"https://api.github.com/users/pjanik/repos","events_url":"https://api.github.com/users/pjanik/events{/privacy}","received_events_url":"https://api.github.com/users/pjanik/received_events","type":"User","site_admin":false},"body":"[#157605459]\r\n\r\nMake continent-continent collisions more likely. When two continent buffers are colliding, we know that it's not continent-ocean collision case (where we want to spot plates), but rather continent-continent (where we want collision to happen).","created_at":"2018-06-08T11:30:55Z","updated_at":"2018-06-11T09:32:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba76010fa20fb3cfb3fbd662ec739592f054da98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/34/commits","review_comments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/34/comments","review_comment_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/34/comments","statuses_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/statuses/9f23f7fe85479c5df6152f04e44b4e29f2acf2f9","head":{"label":"concord-consortium:buffer-changes","ref":"buffer-changes","sha":"9f23f7fe85479c5df6152f04e44b4e29f2acf2f9","user":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":89474068,"node_id":"MDEwOlJlcG9zaXRvcnk4OTQ3NDA2OA==","name":"tectonic-explorer","full_name":"concord-consortium/tectonic-explorer","owner":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concord-consortium/tectonic-explorer","description":null,"fork":false,"url":"https://api.github.com/repos/concord-consortium/tectonic-explorer","forks_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/forks","keys_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/teams","hooks_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/events","assignees_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/tags","blobs_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/subscription","commits_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/merges","archive_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/downloads","issues_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/deployments","created_at":"2017-04-26T11:38:19Z","updated_at":"2018-06-08T21:28:01Z","pushed_at":"2018-06-09T00:52:53Z","git_url":"git://github.com/concord-consortium/tectonic-explorer.git","ssh_url":"git@github.com:concord-consortium/tectonic-explorer.git","clone_url":"https://github.com/concord-consortium/tectonic-explorer.git","svn_url":"https://github.com/concord-consortium/tectonic-explorer","homepage":null,"size":3497,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"concord-consortium:master","ref":"master","sha":"0cd35b0a2c9a16dd3f2cc8c7b6350c03e2b99289","user":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":89474068,"node_id":"MDEwOlJlcG9zaXRvcnk4OTQ3NDA2OA==","name":"tectonic-explorer","full_name":"concord-consortium/tectonic-explorer","owner":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concord-consortium/tectonic-explorer","description":null,"fork":false,"url":"https://api.github.com/repos/concord-consortium/tectonic-explorer","forks_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/forks","keys_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/teams","hooks_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/events","assignees_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/tags","blobs_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/subscription","commits_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/merges","archive_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/downloads","issues_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/deployments","created_at":"2017-04-26T11:38:19Z","updated_at":"2018-06-08T21:28:01Z","pushed_at":"2018-06-09T00:52:53Z","git_url":"git://github.com/concord-consortium/tectonic-explorer.git","ssh_url":"git@github.com:concord-consortium/tectonic-explorer.git","clone_url":"https://github.com/concord-consortium/tectonic-explorer.git","svn_url":"https://github.com/concord-consortium/tectonic-explorer","homepage":null,"size":3497,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/34"},"html":{"href":"https://github.com/concord-consortium/tectonic-explorer/pull/34"},"issue":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/34"},"comments":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/statuses/9f23f7fe85479c5df6152f04e44b4e29f2acf2f9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pjanik"}}