{"action":"created","comment":{"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/comments/196813610","pull_request_review_id":130436608,"id":196813610,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjgxMzYxMA==","diff_hunk":"@@ -0,0 +1,131 @@\n+class Node:\n+    \"\"\"    Class Node: Each object has value and a two pointers - for left and right child.    \"\"\"\n+    def __init__(self, val):\n+        self.val = val\n+        self.left = None\n+        self.right = None\n+\n+\n+class Tree:\n+    \"\"\"    Class Tree: Has a root of type Node    \"\"\"\n+    def __init__(self):\n+        self.root = None\n+\n+    def add(self, val):\n+        if self.root is None:\n+            self.root = Node(val)\n+        else:\n+            self.add_node(val, self.root)\n+\n+    def add_node(self, val, node):\n+        \"\"\" Adds nodes to the tree as they would be added in a BST","path":"avgustinagr/assignment2/Task.py","position":null,"original_position":21,"commit_id":"26239641d61ca0ca373e19a7a53e54ca56bc7330","original_commit_id":"ad824db12ee427956d484f568cbca16abde9e601","user":{"login":"ferreron","id":20680398,"node_id":"MDQ6VXNlcjIwNjgwMzk4","avatar_url":"https://avatars0.githubusercontent.com/u/20680398?v=4","gravatar_id":"","url":"https://api.github.com/users/ferreron","html_url":"https://github.com/ferreron","followers_url":"https://api.github.com/users/ferreron/followers","following_url":"https://api.github.com/users/ferreron/following{/other_user}","gists_url":"https://api.github.com/users/ferreron/gists{/gist_id}","starred_url":"https://api.github.com/users/ferreron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferreron/subscriptions","organizations_url":"https://api.github.com/users/ferreron/orgs","repos_url":"https://api.github.com/users/ferreron/repos","events_url":"https://api.github.com/users/ferreron/events{/privacy}","received_events_url":"https://api.github.com/users/ferreron/received_events","type":"User","site_admin":false},"body":"No need for apologies!\r\nWhat I meant is that you chose one way to insert nodes in the tree, and that is fine. However, someone reading your code may think that you are assuming a BST, when it is not true. So having a comment clarifying that you made decision X for reason Y, helps.","created_at":"2018-06-20T14:52:50Z","updated_at":"2018-06-20T14:52:50Z","html_url":"https://github.com/flerdacodeu/CodeU-2018-Group8/pull/11#discussion_r196813610","pull_request_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/11","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/comments/196813610"},"html":{"href":"https://github.com/flerdacodeu/CodeU-2018-Group8/pull/11#discussion_r196813610"},"pull_request":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/11"}},"in_reply_to_id":193413575},"pull_request":{"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/11","id":192553424,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTUzNDI0","html_url":"https://github.com/flerdacodeu/CodeU-2018-Group8/pull/11","diff_url":"https://github.com/flerdacodeu/CodeU-2018-Group8/pull/11.diff","patch_url":"https://github.com/flerdacodeu/CodeU-2018-Group8/pull/11.patch","issue_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/issues/11","number":11,"state":"open","locked":false,"title":"Avgustinagr 2","user":{"login":"Avgustinagr","id":24685517,"node_id":"MDQ6VXNlcjI0Njg1NTE3","avatar_url":"https://avatars0.githubusercontent.com/u/24685517?v=4","gravatar_id":"","url":"https://api.github.com/users/Avgustinagr","html_url":"https://github.com/Avgustinagr","followers_url":"https://api.github.com/users/Avgustinagr/followers","following_url":"https://api.github.com/users/Avgustinagr/following{/other_user}","gists_url":"https://api.github.com/users/Avgustinagr/gists{/gist_id}","starred_url":"https://api.github.com/users/Avgustinagr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avgustinagr/subscriptions","organizations_url":"https://api.github.com/users/Avgustinagr/orgs","repos_url":"https://api.github.com/users/Avgustinagr/repos","events_url":"https://api.github.com/users/Avgustinagr/events{/privacy}","received_events_url":"https://api.github.com/users/Avgustinagr/received_events","type":"User","site_admin":false},"body":"I`ve assumed that every node value is unique","created_at":"2018-06-04T23:22:00Z","updated_at":"2018-06-20T14:52:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4df568471756b77d4e18061f3898d0d709835fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/11/commits","review_comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/11/comments","review_comment_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/issues/11/comments","statuses_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/statuses/26239641d61ca0ca373e19a7a53e54ca56bc7330","head":{"label":"flerdacodeu:avgustinagr-2","ref":"avgustinagr-2","sha":"26239641d61ca0ca373e19a7a53e54ca56bc7330","user":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"repo":{"id":133326659,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMjY2NTk=","name":"CodeU-2018-Group8","full_name":"flerdacodeu/CodeU-2018-Group8","owner":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flerdacodeu/CodeU-2018-Group8","description":null,"fork":false,"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8","forks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/forks","keys_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/teams","hooks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/hooks","issue_events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/issues/events{/number}","events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/events","assignees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/assignees{/user}","branches_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/branches{/branch}","tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/tags","blobs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/git/refs{/sha}","trees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/statuses/{sha}","languages_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/languages","stargazers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/stargazers","contributors_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/contributors","subscribers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/subscribers","subscription_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/subscription","commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/commits{/sha}","git_commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/git/commits{/sha}","comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/comments{/number}","issue_comment_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/issues/comments{/number}","contents_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/contents/{+path}","compare_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/merges","archive_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/downloads","issues_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/issues{/number}","pulls_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls{/number}","milestones_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/milestones{/number}","notifications_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/labels{/name}","releases_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/releases{/id}","deployments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/deployments","created_at":"2018-05-14T08:07:14Z","updated_at":"2018-06-17T21:28:15Z","pushed_at":"2018-06-19T07:44:39Z","git_url":"git://github.com/flerdacodeu/CodeU-2018-Group8.git","ssh_url":"git@github.com:flerdacodeu/CodeU-2018-Group8.git","clone_url":"https://github.com/flerdacodeu/CodeU-2018-Group8.git","svn_url":"https://github.com/flerdacodeu/CodeU-2018-Group8","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"flerdacodeu:master","ref":"master","sha":"867b2151d708ebd0d3f285c90d69ce6f79ebd008","user":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"repo":{"id":133326659,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMjY2NTk=","name":"CodeU-2018-Group8","full_name":"flerdacodeu/CodeU-2018-Group8","owner":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flerdacodeu/CodeU-2018-Group8","description":null,"fork":false,"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8","forks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/forks","keys_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/teams","hooks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/hooks","issue_events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/issues/events{/number}","events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/events","assignees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/assignees{/user}","branches_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/branches{/branch}","tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/tags","blobs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/git/refs{/sha}","trees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/statuses/{sha}","languages_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/languages","stargazers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/stargazers","contributors_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/contributors","subscribers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/subscribers","subscription_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/subscription","commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/commits{/sha}","git_commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/git/commits{/sha}","comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/comments{/number}","issue_comment_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/issues/comments{/number}","contents_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/contents/{+path}","compare_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/merges","archive_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/downloads","issues_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/issues{/number}","pulls_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls{/number}","milestones_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/milestones{/number}","notifications_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/labels{/name}","releases_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/releases{/id}","deployments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/deployments","created_at":"2018-05-14T08:07:14Z","updated_at":"2018-06-17T21:28:15Z","pushed_at":"2018-06-19T07:44:39Z","git_url":"git://github.com/flerdacodeu/CodeU-2018-Group8.git","ssh_url":"git@github.com:flerdacodeu/CodeU-2018-Group8.git","clone_url":"https://github.com/flerdacodeu/CodeU-2018-Group8.git","svn_url":"https://github.com/flerdacodeu/CodeU-2018-Group8","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/11"},"html":{"href":"https://github.com/flerdacodeu/CodeU-2018-Group8/pull/11"},"issue":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/issues/11"},"comments":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group8/statuses/26239641d61ca0ca373e19a7a53e54ca56bc7330"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ferreron"}}