{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/216059030","pull_request_review_id":153467054,"id":216059030,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjA1OTAzMA==","diff_hunk":"@@ -140,7 +140,8 @@ describe('PerfCategoryRenderer', () => {\n     const diagnosticSection = categoryDOM.querySelectorAll('.lh-category > .lh-audit-group')[2];\n \n     const diagnosticAudits = category.auditRefs.filter(audit => audit.group === 'diagnostics' &&\n-        audit.result.score !== 1 && audit.result.scoreDisplayMode !== 'not-applicable');\n+        audit.result.score < Util.PASS_THRESHOLD &&","path":"lighthouse-core/test/report/html/renderer/performance-category-renderer-test.js","position":5,"original_position":5,"commit_id":"f03931b2bd2fd5bb4fc07becfc85b0e6490b55a1","original_commit_id":"f03931b2bd2fd5bb4fc07becfc85b0e6490b55a1","user":{"login":"paulirish","id":39191,"node_id":"MDQ6VXNlcjM5MTkx","avatar_url":"https://avatars0.githubusercontent.com/u/39191?v=4","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},"body":"nope. that sounds great.","created_at":"2018-09-07T19:04:39Z","updated_at":"2018-09-07T19:04:39Z","html_url":"https://github.com/GoogleChrome/lighthouse/pull/5963#discussion_r216059030","pull_request_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5963","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/216059030"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/5963#discussion_r216059030"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5963"}},"in_reply_to_id":216049677},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5963","id":213158425,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTU4NDI1","html_url":"https://github.com/GoogleChrome/lighthouse/pull/5963","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/5963.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/5963.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5963","number":5963,"state":"open","locked":false,"title":"report(util): ✅ audits should be in Passed Audits","user":{"login":"justinribeiro","id":643503,"node_id":"MDQ6VXNlcjY0MzUwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/643503?v=4","gravatar_id":"","url":"https://api.github.com/users/justinribeiro","html_url":"https://github.com/justinribeiro","followers_url":"https://api.github.com/users/justinribeiro/followers","following_url":"https://api.github.com/users/justinribeiro/following{/other_user}","gists_url":"https://api.github.com/users/justinribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/justinribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinribeiro/subscriptions","organizations_url":"https://api.github.com/users/justinribeiro/orgs","repos_url":"https://api.github.com/users/justinribeiro/repos","events_url":"https://api.github.com/users/justinribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/justinribeiro/received_events","type":"User","site_admin":false},"body":"`Util.showAsPassed()` now default compares to `RATINGS.PASS.minScore`; updated the perf-category render tests to check against the added `PASS_THRESHOLD` const. Resolves #5959 \r\n\r\n*With PR*\r\n![image](https://user-images.githubusercontent.com/643503/45069009-3d43f880-b07f-11e8-9e05-3e60db32b780.png)\r\n\r\n*Without PR*\r\n![image](https://user-images.githubusercontent.com/643503/45069001-374e1780-b07f-11e8-9963-eff17d50ae8a.png)\r\n","created_at":"2018-09-05T03:18:47Z","updated_at":"2018-09-07T19:04:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"962b0deffb09c32a4c5b19b66cf8bbdf117fd753","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5963/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5963/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5963/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/f03931b2bd2fd5bb4fc07becfc85b0e6490b55a1","head":{"label":"justinribeiro:issue-5959","ref":"issue-5959","sha":"f03931b2bd2fd5bb4fc07becfc85b0e6490b55a1","user":{"login":"justinribeiro","id":643503,"node_id":"MDQ6VXNlcjY0MzUwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/643503?v=4","gravatar_id":"","url":"https://api.github.com/users/justinribeiro","html_url":"https://github.com/justinribeiro","followers_url":"https://api.github.com/users/justinribeiro/followers","following_url":"https://api.github.com/users/justinribeiro/following{/other_user}","gists_url":"https://api.github.com/users/justinribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/justinribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinribeiro/subscriptions","organizations_url":"https://api.github.com/users/justinribeiro/orgs","repos_url":"https://api.github.com/users/justinribeiro/repos","events_url":"https://api.github.com/users/justinribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/justinribeiro/received_events","type":"User","site_admin":false},"repo":{"id":142635105,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2MzUxMDU=","name":"lighthouse","full_name":"justinribeiro/lighthouse","owner":{"login":"justinribeiro","id":643503,"node_id":"MDQ6VXNlcjY0MzUwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/643503?v=4","gravatar_id":"","url":"https://api.github.com/users/justinribeiro","html_url":"https://github.com/justinribeiro","followers_url":"https://api.github.com/users/justinribeiro/followers","following_url":"https://api.github.com/users/justinribeiro/following{/other_user}","gists_url":"https://api.github.com/users/justinribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/justinribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinribeiro/subscriptions","organizations_url":"https://api.github.com/users/justinribeiro/orgs","repos_url":"https://api.github.com/users/justinribeiro/repos","events_url":"https://api.github.com/users/justinribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/justinribeiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinribeiro/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":true,"url":"https://api.github.com/repos/justinribeiro/lighthouse","forks_url":"https://api.github.com/repos/justinribeiro/lighthouse/forks","keys_url":"https://api.github.com/repos/justinribeiro/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinribeiro/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinribeiro/lighthouse/teams","hooks_url":"https://api.github.com/repos/justinribeiro/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/justinribeiro/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/justinribeiro/lighthouse/events","assignees_url":"https://api.github.com/repos/justinribeiro/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/justinribeiro/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/justinribeiro/lighthouse/tags","blobs_url":"https://api.github.com/repos/justinribeiro/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinribeiro/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinribeiro/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinribeiro/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinribeiro/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/justinribeiro/lighthouse/languages","stargazers_url":"https://api.github.com/repos/justinribeiro/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/justinribeiro/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/justinribeiro/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/justinribeiro/lighthouse/subscription","commits_url":"https://api.github.com/repos/justinribeiro/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinribeiro/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinribeiro/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinribeiro/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinribeiro/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/justinribeiro/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinribeiro/lighthouse/merges","archive_url":"https://api.github.com/repos/justinribeiro/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinribeiro/lighthouse/downloads","issues_url":"https://api.github.com/repos/justinribeiro/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/justinribeiro/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/justinribeiro/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/justinribeiro/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinribeiro/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/justinribeiro/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/justinribeiro/lighthouse/deployments","created_at":"2018-07-28T00:47:28Z","updated_at":"2018-07-28T00:47:33Z","pushed_at":"2018-09-05T23:25:15Z","git_url":"git://github.com/justinribeiro/lighthouse.git","ssh_url":"git@github.com:justinribeiro/lighthouse.git","clone_url":"https://github.com/justinribeiro/lighthouse.git","svn_url":"https://github.com/justinribeiro/lighthouse","homepage":"https://developers.google.com/web/tools/lighthouse/","size":23494,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"d3af6d0bbc6ae008431f26d001050834162c1f3f","user":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"node_id":"MDEwOlJlcG9zaXRvcnk1MzM3MDk4OA==","name":"lighthouse","full_name":"GoogleChrome/lighthouse","owner":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2018-09-07T18:48:18Z","pushed_at":"2018-09-07T18:48:08Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":"https://developers.google.com/web/tools/lighthouse/","size":23708,"stargazers_count":14508,"watchers_count":14508,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":4402,"mirror_url":null,"archived":false,"open_issues_count":370,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4402,"open_issues":370,"watchers":14508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5963"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/5963"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5963"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5963/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5963/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5963/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/f03931b2bd2fd5bb4fc07becfc85b0e6490b55a1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"paulirish"}}