{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/177459490","pull_request_review_id":107327937,"id":177459490,"diff_hunk":"@@ -372,8 +372,8 @@ class IndexingUtilsTest : public CxxTest::TestSuite {\n                             {2.66668320, 5.29605670, 7.9653444}};\n \n     std::vector<V3D> directions;\n-    for (size_t i = 0; i < 5; i++)\n-      directions.emplace_back(vectors[i][0], vectors[i][1], vectors[i][2]);\n+    for (auto &vector : vectors)","path":"Framework/Geometry/test/IndexingUtilsTest.h","position":28,"original_position":28,"commit_id":"2ce8fe76884a445cb75c11cd9ccce3374d98023b","original_commit_id":"2ce8fe76884a445cb75c11cd9ccce3374d98023b","user":{"login":"josephframsay","id":29916298,"avatar_url":"https://avatars0.githubusercontent.com/u/29916298?v=4","gravatar_id":"","url":"https://api.github.com/users/josephframsay","html_url":"https://github.com/josephframsay","followers_url":"https://api.github.com/users/josephframsay/followers","following_url":"https://api.github.com/users/josephframsay/following{/other_user}","gists_url":"https://api.github.com/users/josephframsay/gists{/gist_id}","starred_url":"https://api.github.com/users/josephframsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephframsay/subscriptions","organizations_url":"https://api.github.com/users/josephframsay/orgs","repos_url":"https://api.github.com/users/josephframsay/repos","events_url":"https://api.github.com/users/josephframsay/events{/privacy}","received_events_url":"https://api.github.com/users/josephframsay/received_events","type":"User","site_admin":false},"body":"`vector` seems like a risky variable name - could this be something like `direction` instead? The same goes for line 413","created_at":"2018-03-27T15:04:30Z","updated_at":"2018-03-27T15:20:05Z","html_url":"https://github.com/mantidproject/mantid/pull/22189#discussion_r177459490","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/177459490"},"html":{"href":"https://github.com/mantidproject/mantid/pull/22189#discussion_r177459490"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22189"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/22189","id":177012484,"html_url":"https://github.com/mantidproject/mantid/pull/22189","diff_url":"https://github.com/mantidproject/mantid/pull/22189.diff","patch_url":"https://github.com/mantidproject/mantid/pull/22189.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/22189","number":22189,"state":"open","locked":false,"title":"Applied clang-tidy modernize-loop-convert fixes for Framework/ ","user":{"login":"edwardb96","id":8405233,"avatar_url":"https://avatars3.githubusercontent.com/u/8405233?v=4","gravatar_id":"","url":"https://api.github.com/users/edwardb96","html_url":"https://github.com/edwardb96","followers_url":"https://api.github.com/users/edwardb96/followers","following_url":"https://api.github.com/users/edwardb96/following{/other_user}","gists_url":"https://api.github.com/users/edwardb96/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardb96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardb96/subscriptions","organizations_url":"https://api.github.com/users/edwardb96/orgs","repos_url":"https://api.github.com/users/edwardb96/repos","events_url":"https://api.github.com/users/edwardb96/events{/privacy}","received_events_url":"https://api.github.com/users/edwardb96/received_events","type":"User","site_admin":false},"body":"1. Applied automatic fixes which convert c and iterator style for loops to range-based for loops where appropriate in Framework/ code.\r\n2. Fixed bad variable names chosen by clang-tidy for non-trivial plurals e.g `boxes` as a singular is not `boxe`.\r\n\r\n**To test:**\r\n1. Ensure builds pass.\r\n2. Quick code inspection.\r\n<!-- Instructions for testing. -->\r\n\r\nRefs #22183. <!-- and fix #xxxx or close #xxxx xor resolves #xxxx -->\r\n\r\n**Release Notes** \r\n*Does not need to be in the release notes.*\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2018-03-23T09:25:33Z","updated_at":"2018-03-27T15:20:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb711cdddbf6a9e56ca5a4ec077f10bb78c28d66","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":177607615,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800","default":false},{"id":177556901,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Maintenance","name":"Misc: Maintenance","color":"d4c5f9","default":false},{"id":372311294,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Quality:%20Clang-Tidy","name":"Quality: Clang-Tidy","color":"c7def8","default":false},{"id":372311590,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Quality:%20Code%20Quality","name":"Quality: Code Quality","color":"c7def8","default":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/67","html_url":"https://github.com/mantidproject/mantid/milestone/67","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/67/labels","id":3113719,"number":67,"title":"Release 3.13","description":"Code Freeze: 29th June\r\nBeta Test: 3rd-17th July","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":283,"closed_issues":65,"state":"open","created_at":"2018-02-13T15:37:12Z","updated_at":"2018-03-27T14:31:06Z","due_on":"2018-07-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22189/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22189/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/22189/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/2ce8fe76884a445cb75c11cd9ccce3374d98023b","head":{"label":"mantidproject:22183_modernize_loop_convert","ref":"22183_modernize_loop_convert","sha":"2ce8fe76884a445cb75c11cd9ccce3374d98023b","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-03-27T14:31:22Z","pushed_at":"2018-03-27T15:11:20Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":476968,"stargazers_count":71,"watchers_count":71,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":1795,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":53,"open_issues":1795,"watchers":71,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"8db2d60f2449e38b7ce1829c4736bc2564f154d8","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-03-27T14:31:22Z","pushed_at":"2018-03-27T15:11:20Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":476968,"stargazers_count":71,"watchers_count":71,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":1795,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":53,"open_issues":1795,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22189"},"html":{"href":"https://github.com/mantidproject/mantid/pull/22189"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/22189"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/22189/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22189/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22189/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/2ce8fe76884a445cb75c11cd9ccce3374d98023b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"josephframsay"}}