{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/h/issues/4962","repository_url":"https://api.github.com/repos/hypothesis/h","labels_url":"https://api.github.com/repos/hypothesis/h/issues/4962/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/4962/comments","events_url":"https://api.github.com/repos/hypothesis/h/issues/4962/events","html_url":"https://github.com/hypothesis/h/pull/4962","id":312888416,"number":4962,"title":"Unicode literals","user":{"login":"seanh","id":22498,"avatar_url":"https://avatars3.githubusercontent.com/u/22498?v=4","gravatar_id":"","url":"https://api.github.com/users/seanh","html_url":"https://github.com/seanh","followers_url":"https://api.github.com/users/seanh/followers","following_url":"https://api.github.com/users/seanh/following{/other_user}","gists_url":"https://api.github.com/users/seanh/gists{/gist_id}","starred_url":"https://api.github.com/users/seanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanh/subscriptions","organizations_url":"https://api.github.com/users/seanh/orgs","repos_url":"https://api.github.com/users/seanh/repos","events_url":"https://api.github.com/users/seanh/events{/privacy}","received_events_url":"https://api.github.com/users/seanh/received_events","type":"User","site_admin":false},"labels":[{"id":895964918,"url":"https://api.github.com/repos/hypothesis/h/labels/Python%203000","name":"Python 3000","color":"043d99","default":false},{"id":546994724,"url":"https://api.github.com/repos/hypothesis/h/labels/WIP","name":"WIP","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"robertknight","id":2458,"avatar_url":"https://avatars1.githubusercontent.com/u/2458?v=4","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"assignees":[{"login":"robertknight","id":2458,"avatar_url":"https://avatars1.githubusercontent.com/u/2458?v=4","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2018-04-10T11:50:44Z","updated_at":"2018-04-12T12:57:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/4962","html_url":"https://github.com/hypothesis/h/pull/4962","diff_url":"https://github.com/hypothesis/h/pull/4962.diff","patch_url":"https://github.com/hypothesis/h/pull/4962.patch"},"body":"* Add `unicode_literals` to all Python files\r\n  \r\n  Add `from __future__ import unicode_literals` to all Python files that don't have it yet.\r\n  \r\n  See: https://www.python.org/dev/peps/pep-3112/\r\n  \r\n  This makes our Python 2.7 environment a little more similar to what a Python 3 one will look like: string literals are unicode by default. By doing this as a separate step now we reduce the size of the change that we'll be applying when we move from Python 2 to 3.\r\n  \r\n  This was done using `futurize --unicode-literals -wn1 h tests`.\r\n  \r\n  I did not add `unicode_literals` to:\r\n  \r\n  - `h/cli/*` and its tests, because the click library complains about `unicode_literals` (see: http://click.pocoo.org/5/python3/)\r\n  \r\n  - `h/migrations/versions/*`, because I don't want to make changes to old migration scripts.\r\n\r\n* Remove now unnecessary `u`-prefixes from string literals\r\n\r\n* Use `make lint` to enforce `unicode_literals`\r\n\r\n  Add an additional flake8 command to `make lint` that complains if `from __future__ import unicode_literals` is missing from any files. To make sure that no new files are added without it."},"comment":{"url":"https://api.github.com/repos/hypothesis/h/issues/comments/380795731","html_url":"https://github.com/hypothesis/h/pull/4962#issuecomment-380795731","issue_url":"https://api.github.com/repos/hypothesis/h/issues/4962","id":380795731,"user":{"login":"robertknight","id":2458,"avatar_url":"https://avatars1.githubusercontent.com/u/2458?v=4","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"created_at":"2018-04-12T12:57:47Z","updated_at":"2018-04-12T12:57:47Z","author_association":"CONTRIBUTOR","body":"> Or is it just a problem with webtest? \r\n\r\nI looked into this a bit for 9edc6fbed062ce64efdf84051293c0a7f6b0f212. [PEP 3333](https://www.python.org/dev/peps/pep-3333/#a-note-on-string-types) is where the requirement comes from."}}
{"actor":{"display_login":"robertknight"}}