{"action":"opened","number":2765,"pull_request":{"url":"https://api.github.com/repos/containerd/containerd/pulls/2765","id":228553549,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTUzNTQ5","html_url":"https://github.com/containerd/containerd/pull/2765","diff_url":"https://github.com/containerd/containerd/pull/2765.diff","patch_url":"https://github.com/containerd/containerd/pull/2765.patch","issue_url":"https://api.github.com/repos/containerd/containerd/issues/2765","number":2765,"state":"open","locked":false,"title":"[release/1.1] cherry-pick: optimize shim lock in runtime v1","user":{"login":"Random-Liu","id":5821883,"node_id":"MDQ6VXNlcjU4MjE4ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"body":"We also need this fix in release 1.1.\r\n\r\nI think this is the last piece for https://github.com/containerd/containerd/issues/2709.\r\n\r\nNote that the lock location for `Create` is not updated in this cherry-pick, because:\r\n1) It is not necessary. `Create` should be called as the first function, and no other functions will be called at the same time.\r\n2) It is matches the behavior of shim v2 https://github.com/containerd/containerd/blob/master/runtime/v2/runc/service.go#L226.\r\n3) In `release/1.1`, all logic is in `proc.New`. There is no way for us to add the lock at the same place with https://github.com/containerd/containerd/pull/2743.\r\n\r\n/cc @Ace-Tang ","created_at":"2018-11-06T02:13:32Z","updated_at":"2018-11-06T02:13:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1029688095,"node_id":"MDU6TGFiZWwxMDI5Njg4MDk1","url":"https://api.github.com/repos/containerd/containerd/labels/cherry-picked/1.1.x","name":"cherry-picked/1.1.x","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/containerd/containerd/pulls/2765/commits","review_comments_url":"https://api.github.com/repos/containerd/containerd/pulls/2765/comments","review_comment_url":"https://api.github.com/repos/containerd/containerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containerd/containerd/issues/2765/comments","statuses_url":"https://api.github.com/repos/containerd/containerd/statuses/345837be5df2769ff457f6f2e4073692aaa59694","head":{"label":"Random-Liu:cherrypick-#2743-release-1.1","ref":"cherrypick-#2743-release-1.1","sha":"345837be5df2769ff457f6f2e4073692aaa59694","user":{"login":"Random-Liu","id":5821883,"node_id":"MDQ6VXNlcjU4MjE4ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"repo":{"id":82423058,"node_id":"MDEwOlJlcG9zaXRvcnk4MjQyMzA1OA==","name":"containerd","full_name":"Random-Liu/containerd","private":false,"owner":{"login":"Random-Liu","id":5821883,"node_id":"MDQ6VXNlcjU4MjE4ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Random-Liu/containerd","description":"An open and reliable container runtime, by Docker","fork":true,"url":"https://api.github.com/repos/Random-Liu/containerd","forks_url":"https://api.github.com/repos/Random-Liu/containerd/forks","keys_url":"https://api.github.com/repos/Random-Liu/containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Random-Liu/containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Random-Liu/containerd/teams","hooks_url":"https://api.github.com/repos/Random-Liu/containerd/hooks","issue_events_url":"https://api.github.com/repos/Random-Liu/containerd/issues/events{/number}","events_url":"https://api.github.com/repos/Random-Liu/containerd/events","assignees_url":"https://api.github.com/repos/Random-Liu/containerd/assignees{/user}","branches_url":"https://api.github.com/repos/Random-Liu/containerd/branches{/branch}","tags_url":"https://api.github.com/repos/Random-Liu/containerd/tags","blobs_url":"https://api.github.com/repos/Random-Liu/containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Random-Liu/containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Random-Liu/containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Random-Liu/containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Random-Liu/containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/Random-Liu/containerd/languages","stargazers_url":"https://api.github.com/repos/Random-Liu/containerd/stargazers","contributors_url":"https://api.github.com/repos/Random-Liu/containerd/contributors","subscribers_url":"https://api.github.com/repos/Random-Liu/containerd/subscribers","subscription_url":"https://api.github.com/repos/Random-Liu/containerd/subscription","commits_url":"https://api.github.com/repos/Random-Liu/containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Random-Liu/containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Random-Liu/containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Random-Liu/containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Random-Liu/containerd/contents/{+path}","compare_url":"https://api.github.com/repos/Random-Liu/containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Random-Liu/containerd/merges","archive_url":"https://api.github.com/repos/Random-Liu/containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Random-Liu/containerd/downloads","issues_url":"https://api.github.com/repos/Random-Liu/containerd/issues{/number}","pulls_url":"https://api.github.com/repos/Random-Liu/containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/Random-Liu/containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/Random-Liu/containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Random-Liu/containerd/labels{/name}","releases_url":"https://api.github.com/repos/Random-Liu/containerd/releases{/id}","deployments_url":"https://api.github.com/repos/Random-Liu/containerd/deployments","created_at":"2017-02-18T23:41:16Z","updated_at":"2017-02-18T23:41:18Z","pushed_at":"2018-11-06T01:58:52Z","git_url":"git://github.com/Random-Liu/containerd.git","ssh_url":"git@github.com:Random-Liu/containerd.git","clone_url":"https://github.com/Random-Liu/containerd.git","svn_url":"https://github.com/Random-Liu/containerd","homepage":"https://containerd.io","size":44922,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containerd:release/1.1","ref":"release/1.1","sha":"68a2cbc50fa949b7279c5b1ecb030f8f838d8450","user":{"login":"containerd","id":14037953,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDM3OTUz","avatar_url":"https://avatars1.githubusercontent.com/u/14037953?v=4","gravatar_id":"","url":"https://api.github.com/users/containerd","html_url":"https://github.com/containerd","followers_url":"https://api.github.com/users/containerd/followers","following_url":"https://api.github.com/users/containerd/following{/other_user}","gists_url":"https://api.github.com/users/containerd/gists{/gist_id}","starred_url":"https://api.github.com/users/containerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containerd/subscriptions","organizations_url":"https://api.github.com/users/containerd/orgs","repos_url":"https://api.github.com/users/containerd/repos","events_url":"https://api.github.com/users/containerd/events{/privacy}","received_events_url":"https://api.github.com/users/containerd/received_events","type":"Organization","site_admin":false},"repo":{"id":46089560,"node_id":"MDEwOlJlcG9zaXRvcnk0NjA4OTU2MA==","name":"containerd","full_name":"containerd/containerd","private":false,"owner":{"login":"containerd","id":14037953,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDM3OTUz","avatar_url":"https://avatars1.githubusercontent.com/u/14037953?v=4","gravatar_id":"","url":"https://api.github.com/users/containerd","html_url":"https://github.com/containerd","followers_url":"https://api.github.com/users/containerd/followers","following_url":"https://api.github.com/users/containerd/following{/other_user}","gists_url":"https://api.github.com/users/containerd/gists{/gist_id}","starred_url":"https://api.github.com/users/containerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containerd/subscriptions","organizations_url":"https://api.github.com/users/containerd/orgs","repos_url":"https://api.github.com/users/containerd/repos","events_url":"https://api.github.com/users/containerd/events{/privacy}","received_events_url":"https://api.github.com/users/containerd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/containerd/containerd","description":"An open and reliable container runtime","fork":false,"url":"https://api.github.com/repos/containerd/containerd","forks_url":"https://api.github.com/repos/containerd/containerd/forks","keys_url":"https://api.github.com/repos/containerd/containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containerd/containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containerd/containerd/teams","hooks_url":"https://api.github.com/repos/containerd/containerd/hooks","issue_events_url":"https://api.github.com/repos/containerd/containerd/issues/events{/number}","events_url":"https://api.github.com/repos/containerd/containerd/events","assignees_url":"https://api.github.com/repos/containerd/containerd/assignees{/user}","branches_url":"https://api.github.com/repos/containerd/containerd/branches{/branch}","tags_url":"https://api.github.com/repos/containerd/containerd/tags","blobs_url":"https://api.github.com/repos/containerd/containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containerd/containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containerd/containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/containerd/containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containerd/containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/containerd/containerd/languages","stargazers_url":"https://api.github.com/repos/containerd/containerd/stargazers","contributors_url":"https://api.github.com/repos/containerd/containerd/contributors","subscribers_url":"https://api.github.com/repos/containerd/containerd/subscribers","subscription_url":"https://api.github.com/repos/containerd/containerd/subscription","commits_url":"https://api.github.com/repos/containerd/containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/containerd/containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/containerd/containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/containerd/containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/containerd/containerd/contents/{+path}","compare_url":"https://api.github.com/repos/containerd/containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containerd/containerd/merges","archive_url":"https://api.github.com/repos/containerd/containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containerd/containerd/downloads","issues_url":"https://api.github.com/repos/containerd/containerd/issues{/number}","pulls_url":"https://api.github.com/repos/containerd/containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/containerd/containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/containerd/containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containerd/containerd/labels{/name}","releases_url":"https://api.github.com/repos/containerd/containerd/releases{/id}","deployments_url":"https://api.github.com/repos/containerd/containerd/deployments","created_at":"2015-11-13T00:27:43Z","updated_at":"2018-11-06T02:02:53Z","pushed_at":"2018-11-05T21:40:02Z","git_url":"git://github.com/containerd/containerd.git","ssh_url":"git@github.com:containerd/containerd.git","clone_url":"https://github.com/containerd/containerd.git","svn_url":"https://github.com/containerd/containerd","homepage":"https://containerd.io","size":45063,"stargazers_count":3045,"watchers_count":3045,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":623,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":623,"open_issues":117,"watchers":3045,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containerd/containerd/pulls/2765"},"html":{"href":"https://github.com/containerd/containerd/pull/2765"},"issue":{"href":"https://api.github.com/repos/containerd/containerd/issues/2765"},"comments":{"href":"https://api.github.com/repos/containerd/containerd/issues/2765/comments"},"review_comments":{"href":"https://api.github.com/repos/containerd/containerd/pulls/2765/comments"},"review_comment":{"href":"https://api.github.com/repos/containerd/containerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containerd/containerd/pulls/2765/commits"},"statuses":{"href":"https://api.github.com/repos/containerd/containerd/statuses/345837be5df2769ff457f6f2e4073692aaa59694"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":71,"deletions":66,"changed_files":1}}
{"actor":{"display_login":"Random-Liu"}}