{"action":"created","comment":{"url":"https://api.github.com/repos/erickok/pastt/pulls/comments/183752503","pull_request_review_id":114809925,"id":183752503,"diff_hunk":"@@ -14,6 +14,7 @@\n \t$frommail = '';\n \t$askforemail = TRUE;\n \t$requireemail = FALSE;\n+\t$indentation = '    '; // four spaces","path":"includes/settings.example.php","position":4,"original_position":4,"commit_id":"ee106f3bbd0267cdd7457d5007e48768deeb62c6","original_commit_id":"ee106f3bbd0267cdd7457d5007e48768deeb62c6","user":{"login":"firebirdberlin","id":2759123,"avatar_url":"https://avatars0.githubusercontent.com/u/2759123?v=4","gravatar_id":"","url":"https://api.github.com/users/firebirdberlin","html_url":"https://github.com/firebirdberlin","followers_url":"https://api.github.com/users/firebirdberlin/followers","following_url":"https://api.github.com/users/firebirdberlin/following{/other_user}","gists_url":"https://api.github.com/users/firebirdberlin/gists{/gist_id}","starred_url":"https://api.github.com/users/firebirdberlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebirdberlin/subscriptions","organizations_url":"https://api.github.com/users/firebirdberlin/orgs","repos_url":"https://api.github.com/users/firebirdberlin/repos","events_url":"https://api.github.com/users/firebirdberlin/events{/privacy}","received_events_url":"https://api.github.com/users/firebirdberlin/received_events","type":"User","site_admin":false},"body":"I would propose to propose a four space indentation. \r\n\r\nIn translation.php we should add this kind of check *\r\n\r\nif ( ! isset($indentation) ) {\r\n    $indentation = '';\r\n}\r\n\r\nSo we would stick to the old setting, if the indentation is not (yet) defined. This would mean that users can update without breaking their instance of pastt. \r\n\r\n* attention: php written by a Python hero","created_at":"2018-04-24T14:29:20Z","updated_at":"2018-04-24T14:29:20Z","html_url":"https://github.com/erickok/pastt/pull/14#discussion_r183752503","pull_request_url":"https://api.github.com/repos/erickok/pastt/pulls/14","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/erickok/pastt/pulls/comments/183752503"},"html":{"href":"https://github.com/erickok/pastt/pull/14#discussion_r183752503"},"pull_request":{"href":"https://api.github.com/repos/erickok/pastt/pulls/14"}},"in_reply_to_id":183072128},"pull_request":{"url":"https://api.github.com/repos/erickok/pastt/pulls/14","id":182938322,"html_url":"https://github.com/erickok/pastt/pull/14","diff_url":"https://github.com/erickok/pastt/pull/14.diff","patch_url":"https://github.com/erickok/pastt/pull/14.patch","issue_url":"https://api.github.com/repos/erickok/pastt/issues/14","number":14,"state":"open","locked":false,"title":"Indentation setting for XML output","user":{"login":"cmengler","id":1858194,"avatar_url":"https://avatars1.githubusercontent.com/u/1858194?v=4","gravatar_id":"","url":"https://api.github.com/users/cmengler","html_url":"https://github.com/cmengler","followers_url":"https://api.github.com/users/cmengler/followers","following_url":"https://api.github.com/users/cmengler/following{/other_user}","gists_url":"https://api.github.com/users/cmengler/gists{/gist_id}","starred_url":"https://api.github.com/users/cmengler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmengler/subscriptions","organizations_url":"https://api.github.com/users/cmengler/orgs","repos_url":"https://api.github.com/users/cmengler/repos","events_url":"https://api.github.com/users/cmengler/events{/privacy}","received_events_url":"https://api.github.com/users/cmengler/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-20T01:28:35Z","updated_at":"2018-04-24T14:29:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39c0af466aada6f22d2a01e92959a8c5fe634087","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/erickok/pastt/pulls/14/commits","review_comments_url":"https://api.github.com/repos/erickok/pastt/pulls/14/comments","review_comment_url":"https://api.github.com/repos/erickok/pastt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erickok/pastt/issues/14/comments","statuses_url":"https://api.github.com/repos/erickok/pastt/statuses/ee106f3bbd0267cdd7457d5007e48768deeb62c6","head":{"label":"cmengler:feature/indentation","ref":"feature/indentation","sha":"ee106f3bbd0267cdd7457d5007e48768deeb62c6","user":{"login":"cmengler","id":1858194,"avatar_url":"https://avatars1.githubusercontent.com/u/1858194?v=4","gravatar_id":"","url":"https://api.github.com/users/cmengler","html_url":"https://github.com/cmengler","followers_url":"https://api.github.com/users/cmengler/followers","following_url":"https://api.github.com/users/cmengler/following{/other_user}","gists_url":"https://api.github.com/users/cmengler/gists{/gist_id}","starred_url":"https://api.github.com/users/cmengler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmengler/subscriptions","organizations_url":"https://api.github.com/users/cmengler/orgs","repos_url":"https://api.github.com/users/cmengler/repos","events_url":"https://api.github.com/users/cmengler/events{/privacy}","received_events_url":"https://api.github.com/users/cmengler/received_events","type":"User","site_admin":false},"repo":{"id":110404818,"name":"pastt","full_name":"cmengler/pastt","owner":{"login":"cmengler","id":1858194,"avatar_url":"https://avatars1.githubusercontent.com/u/1858194?v=4","gravatar_id":"","url":"https://api.github.com/users/cmengler","html_url":"https://github.com/cmengler","followers_url":"https://api.github.com/users/cmengler/followers","following_url":"https://api.github.com/users/cmengler/following{/other_user}","gists_url":"https://api.github.com/users/cmengler/gists{/gist_id}","starred_url":"https://api.github.com/users/cmengler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmengler/subscriptions","organizations_url":"https://api.github.com/users/cmengler/orgs","repos_url":"https://api.github.com/users/cmengler/repos","events_url":"https://api.github.com/users/cmengler/events{/privacy}","received_events_url":"https://api.github.com/users/cmengler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmengler/pastt","description":"PASTT: PHP Android String Translation Tool","fork":true,"url":"https://api.github.com/repos/cmengler/pastt","forks_url":"https://api.github.com/repos/cmengler/pastt/forks","keys_url":"https://api.github.com/repos/cmengler/pastt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmengler/pastt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmengler/pastt/teams","hooks_url":"https://api.github.com/repos/cmengler/pastt/hooks","issue_events_url":"https://api.github.com/repos/cmengler/pastt/issues/events{/number}","events_url":"https://api.github.com/repos/cmengler/pastt/events","assignees_url":"https://api.github.com/repos/cmengler/pastt/assignees{/user}","branches_url":"https://api.github.com/repos/cmengler/pastt/branches{/branch}","tags_url":"https://api.github.com/repos/cmengler/pastt/tags","blobs_url":"https://api.github.com/repos/cmengler/pastt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmengler/pastt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmengler/pastt/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmengler/pastt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmengler/pastt/statuses/{sha}","languages_url":"https://api.github.com/repos/cmengler/pastt/languages","stargazers_url":"https://api.github.com/repos/cmengler/pastt/stargazers","contributors_url":"https://api.github.com/repos/cmengler/pastt/contributors","subscribers_url":"https://api.github.com/repos/cmengler/pastt/subscribers","subscription_url":"https://api.github.com/repos/cmengler/pastt/subscription","commits_url":"https://api.github.com/repos/cmengler/pastt/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmengler/pastt/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmengler/pastt/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmengler/pastt/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmengler/pastt/contents/{+path}","compare_url":"https://api.github.com/repos/cmengler/pastt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmengler/pastt/merges","archive_url":"https://api.github.com/repos/cmengler/pastt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmengler/pastt/downloads","issues_url":"https://api.github.com/repos/cmengler/pastt/issues{/number}","pulls_url":"https://api.github.com/repos/cmengler/pastt/pulls{/number}","milestones_url":"https://api.github.com/repos/cmengler/pastt/milestones{/number}","notifications_url":"https://api.github.com/repos/cmengler/pastt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmengler/pastt/labels{/name}","releases_url":"https://api.github.com/repos/cmengler/pastt/releases{/id}","deployments_url":"https://api.github.com/repos/cmengler/pastt/deployments","created_at":"2017-11-12T04:31:31Z","updated_at":"2018-04-20T09:32:41Z","pushed_at":"2018-04-20T09:33:21Z","git_url":"git://github.com/cmengler/pastt.git","ssh_url":"git@github.com:cmengler/pastt.git","clone_url":"https://github.com/cmengler/pastt.git","svn_url":"https://github.com/cmengler/pastt","homepage":null,"size":52,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"erickok:master","ref":"master","sha":"788cb63557307fd9099dba043f5c8c0ec8bb2713","user":{"login":"erickok","id":196453,"avatar_url":"https://avatars1.githubusercontent.com/u/196453?v=4","gravatar_id":"","url":"https://api.github.com/users/erickok","html_url":"https://github.com/erickok","followers_url":"https://api.github.com/users/erickok/followers","following_url":"https://api.github.com/users/erickok/following{/other_user}","gists_url":"https://api.github.com/users/erickok/gists{/gist_id}","starred_url":"https://api.github.com/users/erickok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickok/subscriptions","organizations_url":"https://api.github.com/users/erickok/orgs","repos_url":"https://api.github.com/users/erickok/repos","events_url":"https://api.github.com/users/erickok/events{/privacy}","received_events_url":"https://api.github.com/users/erickok/received_events","type":"User","site_admin":false},"repo":{"id":12373895,"name":"pastt","full_name":"erickok/pastt","owner":{"login":"erickok","id":196453,"avatar_url":"https://avatars1.githubusercontent.com/u/196453?v=4","gravatar_id":"","url":"https://api.github.com/users/erickok","html_url":"https://github.com/erickok","followers_url":"https://api.github.com/users/erickok/followers","following_url":"https://api.github.com/users/erickok/following{/other_user}","gists_url":"https://api.github.com/users/erickok/gists{/gist_id}","starred_url":"https://api.github.com/users/erickok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickok/subscriptions","organizations_url":"https://api.github.com/users/erickok/orgs","repos_url":"https://api.github.com/users/erickok/repos","events_url":"https://api.github.com/users/erickok/events{/privacy}","received_events_url":"https://api.github.com/users/erickok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erickok/pastt","description":"PASTT: PHP Android String Translation Tool","fork":false,"url":"https://api.github.com/repos/erickok/pastt","forks_url":"https://api.github.com/repos/erickok/pastt/forks","keys_url":"https://api.github.com/repos/erickok/pastt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erickok/pastt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erickok/pastt/teams","hooks_url":"https://api.github.com/repos/erickok/pastt/hooks","issue_events_url":"https://api.github.com/repos/erickok/pastt/issues/events{/number}","events_url":"https://api.github.com/repos/erickok/pastt/events","assignees_url":"https://api.github.com/repos/erickok/pastt/assignees{/user}","branches_url":"https://api.github.com/repos/erickok/pastt/branches{/branch}","tags_url":"https://api.github.com/repos/erickok/pastt/tags","blobs_url":"https://api.github.com/repos/erickok/pastt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erickok/pastt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erickok/pastt/git/refs{/sha}","trees_url":"https://api.github.com/repos/erickok/pastt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erickok/pastt/statuses/{sha}","languages_url":"https://api.github.com/repos/erickok/pastt/languages","stargazers_url":"https://api.github.com/repos/erickok/pastt/stargazers","contributors_url":"https://api.github.com/repos/erickok/pastt/contributors","subscribers_url":"https://api.github.com/repos/erickok/pastt/subscribers","subscription_url":"https://api.github.com/repos/erickok/pastt/subscription","commits_url":"https://api.github.com/repos/erickok/pastt/commits{/sha}","git_commits_url":"https://api.github.com/repos/erickok/pastt/git/commits{/sha}","comments_url":"https://api.github.com/repos/erickok/pastt/comments{/number}","issue_comment_url":"https://api.github.com/repos/erickok/pastt/issues/comments{/number}","contents_url":"https://api.github.com/repos/erickok/pastt/contents/{+path}","compare_url":"https://api.github.com/repos/erickok/pastt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erickok/pastt/merges","archive_url":"https://api.github.com/repos/erickok/pastt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erickok/pastt/downloads","issues_url":"https://api.github.com/repos/erickok/pastt/issues{/number}","pulls_url":"https://api.github.com/repos/erickok/pastt/pulls{/number}","milestones_url":"https://api.github.com/repos/erickok/pastt/milestones{/number}","notifications_url":"https://api.github.com/repos/erickok/pastt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erickok/pastt/labels{/name}","releases_url":"https://api.github.com/repos/erickok/pastt/releases{/id}","deployments_url":"https://api.github.com/repos/erickok/pastt/deployments","created_at":"2013-08-26T07:52:31Z","updated_at":"2018-04-20T06:43:53Z","pushed_at":"2018-04-20T07:02:03Z","git_url":"git://github.com/erickok/pastt.git","ssh_url":"git@github.com:erickok/pastt.git","clone_url":"https://github.com/erickok/pastt.git","svn_url":"https://github.com/erickok/pastt","homepage":null,"size":51,"stargazers_count":27,"watchers_count":27,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":15,"open_issues":8,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erickok/pastt/pulls/14"},"html":{"href":"https://github.com/erickok/pastt/pull/14"},"issue":{"href":"https://api.github.com/repos/erickok/pastt/issues/14"},"comments":{"href":"https://api.github.com/repos/erickok/pastt/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/erickok/pastt/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/erickok/pastt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erickok/pastt/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/erickok/pastt/statuses/ee106f3bbd0267cdd7457d5007e48768deeb62c6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"firebirdberlin"}}