{"action":"created","comment":{"url":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/comments/184650229","pull_request_review_id":115890947,"id":184650229,"diff_hunk":"@@ -41,25 +48,22 @@ class PlayListFragmentViewModel @Inject constructor(\n                 }\n \n         repository.observeNowPlayingVideo()\n+                .takeUntil(onPause.toFlowable(BackpressureStrategy.LATEST))\n                 .subscribe {\n                     nowPlayVideo.set(it)\n                     published.set(resources.getString(R.string.published).format(it.published))\n                     viewCount.set(resources.getString(R.string.view_count).format(it.viewCount))\n                 }\n \n         repository.observeIsPlaying()\n+                .takeUntil(onPause.toFlowable(BackpressureStrategy.LATEST))\n                 .subscribe {\n                     isPlaying.set(it)\n                 }\n     }\n \n-    override fun onStart() {\n-    }\n-\n-    override fun onResume() {\n-    }\n-\n     override fun onPause() {\n+        onPause.onNext(Unit)","path":"app/src/main/kotlin/com/cyder/atsushi/youtubesync/viewmodel/PlayListFragmentViewModel.kt","position":57,"original_position":57,"commit_id":"5ed12f26c5ee02e48cf76c133ab2895f24ace0fa","original_commit_id":"5ed12f26c5ee02e48cf76c133ab2895f24ace0fa","user":{"login":"chigichan24","id":7840108,"avatar_url":"https://avatars1.githubusercontent.com/u/7840108?v=4","gravatar_id":"","url":"https://api.github.com/users/chigichan24","html_url":"https://github.com/chigichan24","followers_url":"https://api.github.com/users/chigichan24/followers","following_url":"https://api.github.com/users/chigichan24/following{/other_user}","gists_url":"https://api.github.com/users/chigichan24/gists{/gist_id}","starred_url":"https://api.github.com/users/chigichan24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chigichan24/subscriptions","organizations_url":"https://api.github.com/users/chigichan24/orgs","repos_url":"https://api.github.com/users/chigichan24/repos","events_url":"https://api.github.com/users/chigichan24/events{/privacy}","received_events_url":"https://api.github.com/users/chigichan24/received_events","type":"User","site_admin":false},"body":"せめてなんか`const val`においてそれを`onNext`しない？","created_at":"2018-04-27T10:29:53Z","updated_at":"2018-04-27T10:29:53Z","html_url":"https://github.com/cyder/SyncPod-Android/pull/225#discussion_r184650229","pull_request_url":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/225","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/comments/184650229"},"html":{"href":"https://github.com/cyder/SyncPod-Android/pull/225#discussion_r184650229"},"pull_request":{"href":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/225"}},"in_reply_to_id":184646449},"pull_request":{"url":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/225","id":183842098,"html_url":"https://github.com/cyder/SyncPod-Android/pull/225","diff_url":"https://github.com/cyder/SyncPod-Android/pull/225.diff","patch_url":"https://github.com/cyder/SyncPod-Android/pull/225.patch","issue_url":"https://api.github.com/repos/cyder/SyncPod-Android/issues/225","number":225,"state":"open","locked":false,"title":"VideoFragmentViewModelでのobserverWithInitPlayerのタイミングを変更","user":{"login":"Mori-Atsushi","id":13435109,"avatar_url":"https://avatars0.githubusercontent.com/u/13435109?v=4","gravatar_id":"","url":"https://api.github.com/users/Mori-Atsushi","html_url":"https://github.com/Mori-Atsushi","followers_url":"https://api.github.com/users/Mori-Atsushi/followers","following_url":"https://api.github.com/users/Mori-Atsushi/following{/other_user}","gists_url":"https://api.github.com/users/Mori-Atsushi/gists{/gist_id}","starred_url":"https://api.github.com/users/Mori-Atsushi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mori-Atsushi/subscriptions","organizations_url":"https://api.github.com/users/Mori-Atsushi/orgs","repos_url":"https://api.github.com/users/Mori-Atsushi/repos","events_url":"https://api.github.com/users/Mori-Atsushi/events{/privacy}","received_events_url":"https://api.github.com/users/Mori-Atsushi/received_events","type":"User","site_admin":false},"body":"じゃないと、永遠にストリームが増え続けてロード時間が無限に増え続けます。\r\nもしかすると #223 が解決するかも？","created_at":"2018-04-24T19:37:56Z","updated_at":"2018-04-27T10:29:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcaf9a3ffefcd1883248d9025ec70fdd8c644656","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":799075486,"url":"https://api.github.com/repos/cyder/SyncPod-Android/labels/new-architecture","name":"new-architecture","color":"98ea6b","default":false},{"id":739111516,"url":"https://api.github.com/repos/cyder/SyncPod-Android/labels/review%20complete","name":"review complete","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/225/commits","review_comments_url":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/225/comments","review_comment_url":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyder/SyncPod-Android/issues/225/comments","statuses_url":"https://api.github.com/repos/cyder/SyncPod-Android/statuses/5ed12f26c5ee02e48cf76c133ab2895f24ace0fa","head":{"label":"cyder:player-load","ref":"player-load","sha":"5ed12f26c5ee02e48cf76c133ab2895f24ace0fa","user":{"login":"cyder","id":25344502,"avatar_url":"https://avatars3.githubusercontent.com/u/25344502?v=4","gravatar_id":"","url":"https://api.github.com/users/cyder","html_url":"https://github.com/cyder","followers_url":"https://api.github.com/users/cyder/followers","following_url":"https://api.github.com/users/cyder/following{/other_user}","gists_url":"https://api.github.com/users/cyder/gists{/gist_id}","starred_url":"https://api.github.com/users/cyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyder/subscriptions","organizations_url":"https://api.github.com/users/cyder/orgs","repos_url":"https://api.github.com/users/cyder/repos","events_url":"https://api.github.com/users/cyder/events{/privacy}","received_events_url":"https://api.github.com/users/cyder/received_events","type":"Organization","site_admin":false},"repo":{"id":105630028,"name":"SyncPod-Android","full_name":"cyder/SyncPod-Android","owner":{"login":"cyder","id":25344502,"avatar_url":"https://avatars3.githubusercontent.com/u/25344502?v=4","gravatar_id":"","url":"https://api.github.com/users/cyder","html_url":"https://github.com/cyder","followers_url":"https://api.github.com/users/cyder/followers","following_url":"https://api.github.com/users/cyder/following{/other_user}","gists_url":"https://api.github.com/users/cyder/gists{/gist_id}","starred_url":"https://api.github.com/users/cyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyder/subscriptions","organizations_url":"https://api.github.com/users/cyder/orgs","repos_url":"https://api.github.com/users/cyder/repos","events_url":"https://api.github.com/users/cyder/events{/privacy}","received_events_url":"https://api.github.com/users/cyder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyder/SyncPod-Android","description":null,"fork":false,"url":"https://api.github.com/repos/cyder/SyncPod-Android","forks_url":"https://api.github.com/repos/cyder/SyncPod-Android/forks","keys_url":"https://api.github.com/repos/cyder/SyncPod-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyder/SyncPod-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyder/SyncPod-Android/teams","hooks_url":"https://api.github.com/repos/cyder/SyncPod-Android/hooks","issue_events_url":"https://api.github.com/repos/cyder/SyncPod-Android/issues/events{/number}","events_url":"https://api.github.com/repos/cyder/SyncPod-Android/events","assignees_url":"https://api.github.com/repos/cyder/SyncPod-Android/assignees{/user}","branches_url":"https://api.github.com/repos/cyder/SyncPod-Android/branches{/branch}","tags_url":"https://api.github.com/repos/cyder/SyncPod-Android/tags","blobs_url":"https://api.github.com/repos/cyder/SyncPod-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyder/SyncPod-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyder/SyncPod-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyder/SyncPod-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyder/SyncPod-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/cyder/SyncPod-Android/languages","stargazers_url":"https://api.github.com/repos/cyder/SyncPod-Android/stargazers","contributors_url":"https://api.github.com/repos/cyder/SyncPod-Android/contributors","subscribers_url":"https://api.github.com/repos/cyder/SyncPod-Android/subscribers","subscription_url":"https://api.github.com/repos/cyder/SyncPod-Android/subscription","commits_url":"https://api.github.com/repos/cyder/SyncPod-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyder/SyncPod-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyder/SyncPod-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyder/SyncPod-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyder/SyncPod-Android/contents/{+path}","compare_url":"https://api.github.com/repos/cyder/SyncPod-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyder/SyncPod-Android/merges","archive_url":"https://api.github.com/repos/cyder/SyncPod-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyder/SyncPod-Android/downloads","issues_url":"https://api.github.com/repos/cyder/SyncPod-Android/issues{/number}","pulls_url":"https://api.github.com/repos/cyder/SyncPod-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/cyder/SyncPod-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/cyder/SyncPod-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyder/SyncPod-Android/labels{/name}","releases_url":"https://api.github.com/repos/cyder/SyncPod-Android/releases{/id}","deployments_url":"https://api.github.com/repos/cyder/SyncPod-Android/deployments","created_at":"2017-10-03T08:34:09Z","updated_at":"2018-04-27T10:06:29Z","pushed_at":"2018-04-27T10:12:44Z","git_url":"git://github.com/cyder/SyncPod-Android.git","ssh_url":"git@github.com:cyder/SyncPod-Android.git","clone_url":"https://github.com/cyder/SyncPod-Android.git","svn_url":"https://github.com/cyder/SyncPod-Android","homepage":"https://play.google.com/store/apps/details?id=com.cyder.atsushi.youtubesync","size":1483,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":2,"open_issues":32,"watchers":0,"default_branch":"new-architecture"}},"base":{"label":"cyder:new-architecture","ref":"new-architecture","sha":"8f572b93e1c01b8dc6a12e8ecdf509a6e33daaf2","user":{"login":"cyder","id":25344502,"avatar_url":"https://avatars3.githubusercontent.com/u/25344502?v=4","gravatar_id":"","url":"https://api.github.com/users/cyder","html_url":"https://github.com/cyder","followers_url":"https://api.github.com/users/cyder/followers","following_url":"https://api.github.com/users/cyder/following{/other_user}","gists_url":"https://api.github.com/users/cyder/gists{/gist_id}","starred_url":"https://api.github.com/users/cyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyder/subscriptions","organizations_url":"https://api.github.com/users/cyder/orgs","repos_url":"https://api.github.com/users/cyder/repos","events_url":"https://api.github.com/users/cyder/events{/privacy}","received_events_url":"https://api.github.com/users/cyder/received_events","type":"Organization","site_admin":false},"repo":{"id":105630028,"name":"SyncPod-Android","full_name":"cyder/SyncPod-Android","owner":{"login":"cyder","id":25344502,"avatar_url":"https://avatars3.githubusercontent.com/u/25344502?v=4","gravatar_id":"","url":"https://api.github.com/users/cyder","html_url":"https://github.com/cyder","followers_url":"https://api.github.com/users/cyder/followers","following_url":"https://api.github.com/users/cyder/following{/other_user}","gists_url":"https://api.github.com/users/cyder/gists{/gist_id}","starred_url":"https://api.github.com/users/cyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyder/subscriptions","organizations_url":"https://api.github.com/users/cyder/orgs","repos_url":"https://api.github.com/users/cyder/repos","events_url":"https://api.github.com/users/cyder/events{/privacy}","received_events_url":"https://api.github.com/users/cyder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyder/SyncPod-Android","description":null,"fork":false,"url":"https://api.github.com/repos/cyder/SyncPod-Android","forks_url":"https://api.github.com/repos/cyder/SyncPod-Android/forks","keys_url":"https://api.github.com/repos/cyder/SyncPod-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyder/SyncPod-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyder/SyncPod-Android/teams","hooks_url":"https://api.github.com/repos/cyder/SyncPod-Android/hooks","issue_events_url":"https://api.github.com/repos/cyder/SyncPod-Android/issues/events{/number}","events_url":"https://api.github.com/repos/cyder/SyncPod-Android/events","assignees_url":"https://api.github.com/repos/cyder/SyncPod-Android/assignees{/user}","branches_url":"https://api.github.com/repos/cyder/SyncPod-Android/branches{/branch}","tags_url":"https://api.github.com/repos/cyder/SyncPod-Android/tags","blobs_url":"https://api.github.com/repos/cyder/SyncPod-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyder/SyncPod-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyder/SyncPod-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyder/SyncPod-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyder/SyncPod-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/cyder/SyncPod-Android/languages","stargazers_url":"https://api.github.com/repos/cyder/SyncPod-Android/stargazers","contributors_url":"https://api.github.com/repos/cyder/SyncPod-Android/contributors","subscribers_url":"https://api.github.com/repos/cyder/SyncPod-Android/subscribers","subscription_url":"https://api.github.com/repos/cyder/SyncPod-Android/subscription","commits_url":"https://api.github.com/repos/cyder/SyncPod-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyder/SyncPod-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyder/SyncPod-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyder/SyncPod-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyder/SyncPod-Android/contents/{+path}","compare_url":"https://api.github.com/repos/cyder/SyncPod-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyder/SyncPod-Android/merges","archive_url":"https://api.github.com/repos/cyder/SyncPod-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyder/SyncPod-Android/downloads","issues_url":"https://api.github.com/repos/cyder/SyncPod-Android/issues{/number}","pulls_url":"https://api.github.com/repos/cyder/SyncPod-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/cyder/SyncPod-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/cyder/SyncPod-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyder/SyncPod-Android/labels{/name}","releases_url":"https://api.github.com/repos/cyder/SyncPod-Android/releases{/id}","deployments_url":"https://api.github.com/repos/cyder/SyncPod-Android/deployments","created_at":"2017-10-03T08:34:09Z","updated_at":"2018-04-27T10:06:29Z","pushed_at":"2018-04-27T10:12:44Z","git_url":"git://github.com/cyder/SyncPod-Android.git","ssh_url":"git@github.com:cyder/SyncPod-Android.git","clone_url":"https://github.com/cyder/SyncPod-Android.git","svn_url":"https://github.com/cyder/SyncPod-Android","homepage":"https://play.google.com/store/apps/details?id=com.cyder.atsushi.youtubesync","size":1483,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":2,"open_issues":32,"watchers":0,"default_branch":"new-architecture"}},"_links":{"self":{"href":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/225"},"html":{"href":"https://github.com/cyder/SyncPod-Android/pull/225"},"issue":{"href":"https://api.github.com/repos/cyder/SyncPod-Android/issues/225"},"comments":{"href":"https://api.github.com/repos/cyder/SyncPod-Android/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyder/SyncPod-Android/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/cyder/SyncPod-Android/statuses/5ed12f26c5ee02e48cf76c133ab2895f24ace0fa"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"chigichan24"}}