{"action":"opened","number":234,"pull_request":{"url":"https://api.github.com/repos/google/protobuf-gradle-plugin/pulls/234","id":192223896,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjIzODk2","html_url":"https://github.com/google/protobuf-gradle-plugin/pull/234","diff_url":"https://github.com/google/protobuf-gradle-plugin/pull/234.diff","patch_url":"https://github.com/google/protobuf-gradle-plugin/pull/234.patch","issue_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/issues/234","number":234,"state":"open","locked":false,"title":"Register generated sources with android studio","user":{"login":"zpencer","id":2819812,"node_id":"MDQ6VXNlcjI4MTk4MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"body":"It turns out, android studio does not use the `idea` plugin and\r\ninstead does its own thing.\r\n\r\nThe android project's non local unit test protos are automatically\r\nregistered when we call `registerJavaGeneratingTask`. But local unit\r\ntests run without the android SDK, and `registerJavaGeneratingTask` is\r\nnot implemented. They must be registered explicitly.\r\n\r\nAlso, an Android sub project can depend on another subproject that has\r\nGenerateProtoTasks. We must scan through each variant and find such\r\nsubproject dependencies, and register their gen outputs.\r\n\r\nAndroid Studio automatically ignores linter warnings for\r\n`registerJavaGeneratingTask` sources, but for these sources it will\r\nwarn. Unfortunately the current version of proto lite generates code\r\nthat fails lint, and this causes warnings. But I think the typical\r\nuser would rather see warnings than have sources not be registered at\r\nall, so turning this on by default makes sense.\r\n\r\nTo disable this behavior, set the project property:\r\nprotobuf.androidstudio.extrasrcs.experimental=false","created_at":"2018-06-03T00:18:50Z","updated_at":"2018-06-03T00:18:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/pulls/234/commits","review_comments_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/pulls/234/comments","review_comment_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/issues/234/comments","statuses_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/statuses/51589a84329b3b1c308533b54d708a6e7d986c3e","head":{"label":"zpencer:register-generated-unit-test-code","ref":"register-generated-unit-test-code","sha":"51589a84329b3b1c308533b54d708a6e7d986c3e","user":{"login":"zpencer","id":2819812,"node_id":"MDQ6VXNlcjI4MTk4MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"repo":{"id":91708480,"node_id":"MDEwOlJlcG9zaXRvcnk5MTcwODQ4MA==","name":"protobuf-gradle-plugin","full_name":"zpencer/protobuf-gradle-plugin","owner":{"login":"zpencer","id":2819812,"node_id":"MDQ6VXNlcjI4MTk4MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zpencer/protobuf-gradle-plugin","description":"Protobuf Plugin for Gradle","fork":true,"url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin","forks_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/forks","keys_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/events","assignees_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/merges","archive_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/zpencer/protobuf-gradle-plugin/deployments","created_at":"2017-05-18T15:18:20Z","updated_at":"2017-05-18T15:18:22Z","pushed_at":"2018-06-03T00:18:32Z","git_url":"git://github.com/zpencer/protobuf-gradle-plugin.git","ssh_url":"git@github.com:zpencer/protobuf-gradle-plugin.git","clone_url":"https://github.com/zpencer/protobuf-gradle-plugin.git","svn_url":"https://github.com/zpencer/protobuf-gradle-plugin","homepage":"","size":921,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"609f8b46f67c364b9cfc200d7f3cd8b4fc92ff36","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":33881870,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg4MTg3MA==","name":"protobuf-gradle-plugin","full_name":"google/protobuf-gradle-plugin","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/protobuf-gradle-plugin","description":"Protobuf Plugin for Gradle","fork":false,"url":"https://api.github.com/repos/google/protobuf-gradle-plugin","forks_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/forks","keys_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/events","assignees_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/merges","archive_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/google/protobuf-gradle-plugin/deployments","created_at":"2015-04-13T17:06:00Z","updated_at":"2018-06-01T11:47:17Z","pushed_at":"2018-06-02T19:09:05Z","git_url":"git://github.com/google/protobuf-gradle-plugin.git","ssh_url":"git@github.com:google/protobuf-gradle-plugin.git","clone_url":"https://github.com/google/protobuf-gradle-plugin.git","svn_url":"https://github.com/google/protobuf-gradle-plugin","homepage":"","size":889,"stargazers_count":505,"watchers_count":505,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":106,"open_issues":33,"watchers":505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/protobuf-gradle-plugin/pulls/234"},"html":{"href":"https://github.com/google/protobuf-gradle-plugin/pull/234"},"issue":{"href":"https://api.github.com/repos/google/protobuf-gradle-plugin/issues/234"},"comments":{"href":"https://api.github.com/repos/google/protobuf-gradle-plugin/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/google/protobuf-gradle-plugin/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/google/protobuf-gradle-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/protobuf-gradle-plugin/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/google/protobuf-gradle-plugin/statuses/51589a84329b3b1c308533b54d708a6e7d986c3e"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":54,"deletions":14,"changed_files":1}}
{"actor":{"display_login":"zpencer"}}