{"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris/pulls/comments/207869899","pull_request_review_id":143565537,"id":207869899,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzg2OTg5OQ==","diff_hunk":"@@ -3,45 +3,55 @@\n We'd love to have you contribute to Loris. The first thing you should do\n before contributing is probably sign up for the [LORIS developers' mailing list](http://www.bic.mni.mcgill.ca/mailman/listinfo/loris-dev).\n \n+Your next step before issuing a pull request is to review our [Coding Standards](./docs/CodingStandards.md). If you are doing front-end development you should also check out our [React guidelines](https://github.com/johnsaigle/Loris/blob/180631-Contributing/LORIS_react.README.md).\n+\n+You can also learn about our code review process by perusing our [Code Review Checklist](https://github.com/aces/Loris/wiki/Code-Review-Checklist) in the [LORIS Wiki](https://github.com/aces/Loris/wiki). These will be some of the factors we'll consider when reviewing your code.\n+\n ## Development branches\n \n-Pull requests should be based on and sent to the VERSIONNUMBER-dev branch of the version that you are targeting. The master branch is reserved for stable releases.\n+You should base your pull requests on one of the following branches depending on the kind of change you are making:\n+\n+#### Bug Fixes\n+   - Branch: `bugfix`\n+   - Label: ![](https://via.placeholder.com/15/cc9966/000000?text=+) **[branch] bugfix**\n+   - Content: Generally these changes do not require SQL scripts and are concise with the sole objective to correct a single problem in the code.\n+\n+#### Minor Changes and Small Features\n+   - Branch: `minor`\n+   - Label: ![](https://via.placeholder.com/15/996633/000000?text=+) **[branch] minor**\n+   - Content: Features affecting self-contained components such as modules. Additions to Libraries, API or modules that do not change and function signatures. ","path":"CONTRIBUTING.md","position":21,"original_position":21,"commit_id":"079d77247e504fb01f8e031b6d4540387e94c87c","original_commit_id":"e25550c27d85d939d499c3eef104a95824ded466","user":{"login":"PapillonMcGill","id":34311645,"node_id":"MDQ6VXNlcjM0MzExNjQ1","avatar_url":"https://avatars0.githubusercontent.com/u/34311645?v=4","gravatar_id":"","url":"https://api.github.com/users/PapillonMcGill","html_url":"https://github.com/PapillonMcGill","followers_url":"https://api.github.com/users/PapillonMcGill/followers","following_url":"https://api.github.com/users/PapillonMcGill/following{/other_user}","gists_url":"https://api.github.com/users/PapillonMcGill/gists{/gist_id}","starred_url":"https://api.github.com/users/PapillonMcGill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PapillonMcGill/subscriptions","organizations_url":"https://api.github.com/users/PapillonMcGill/orgs","repos_url":"https://api.github.com/users/PapillonMcGill/repos","events_url":"https://api.github.com/users/PapillonMcGill/events{/privacy}","received_events_url":"https://api.github.com/users/PapillonMcGill/received_events","type":"User","site_admin":false},"body":"```modules that do not change and function signatures.``` maybe ``` ... do not change functionality or function signatures ...``` ","created_at":"2018-08-06T12:15:47Z","updated_at":"2018-08-06T12:15:47Z","html_url":"https://github.com/aces/Loris/pull/3859#discussion_r207869899","pull_request_url":"https://api.github.com/repos/aces/Loris/pulls/3859","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments/207869899"},"html":{"href":"https://github.com/aces/Loris/pull/3859#discussion_r207869899"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris/pulls/3859"}},"in_reply_to_id":207342778},"pull_request":{"url":"https://api.github.com/repos/aces/Loris/pulls/3859","id":205188727,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTg4NzI3","html_url":"https://github.com/aces/Loris/pull/3859","diff_url":"https://github.com/aces/Loris/pull/3859.diff","patch_url":"https://github.com/aces/Loris/pull/3859.patch","issue_url":"https://api.github.com/repos/aces/Loris/issues/3859","number":3859,"state":"open","locked":false,"title":"[Docs] Update and rework CONTRIBUTING.md","user":{"login":"johnsaigle","id":4022790,"node_id":"MDQ6VXNlcjQwMjI3OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4022790?v=4","gravatar_id":"","url":"https://api.github.com/users/johnsaigle","html_url":"https://github.com/johnsaigle","followers_url":"https://api.github.com/users/johnsaigle/followers","following_url":"https://api.github.com/users/johnsaigle/following{/other_user}","gists_url":"https://api.github.com/users/johnsaigle/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsaigle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsaigle/subscriptions","organizations_url":"https://api.github.com/users/johnsaigle/orgs","repos_url":"https://api.github.com/users/johnsaigle/repos","events_url":"https://api.github.com/users/johnsaigle/events{/privacy}","received_events_url":"https://api.github.com/users/johnsaigle/received_events","type":"User","site_admin":false},"body":"This pull request modifies the CONTRIBUTING document.\r\n\r\nChanges made:\r\n\r\n* Update the base branch practices\r\n* Add code formatting and branch label colours\r\n* Re-organize information flow\r\n* Skew tone toward on-boarding new devs\r\n","created_at":"2018-07-31T17:35:52Z","updated_at":"2018-08-06T12:15:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70c019f43531d5ad9b67113beec29e652d35c2b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":158461173,"node_id":"MDU6TGFiZWwxNTg0NjExNzM=","url":"https://api.github.com/repos/aces/Loris/labels/Documentation","name":"Documentation","color":"ffffcc","default":false}],"milestone":{"url":"https://api.github.com/repos/aces/Loris/milestones/31","html_url":"https://github.com/aces/Loris/milestone/31","labels_url":"https://api.github.com/repos/aces/Loris/milestones/31/labels","id":3439094,"node_id":"MDk6TWlsZXN0b25lMzQzOTA5NA==","number":31,"title":"20.1.0","description":"","creator":{"login":"ridz1208","id":15268287,"node_id":"MDQ6VXNlcjE1MjY4Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/15268287?v=4","gravatar_id":"","url":"https://api.github.com/users/ridz1208","html_url":"https://github.com/ridz1208","followers_url":"https://api.github.com/users/ridz1208/followers","following_url":"https://api.github.com/users/ridz1208/following{/other_user}","gists_url":"https://api.github.com/users/ridz1208/gists{/gist_id}","starred_url":"https://api.github.com/users/ridz1208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridz1208/subscriptions","organizations_url":"https://api.github.com/users/ridz1208/orgs","repos_url":"https://api.github.com/users/ridz1208/repos","events_url":"https://api.github.com/users/ridz1208/events{/privacy}","received_events_url":"https://api.github.com/users/ridz1208/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":3,"state":"open","created_at":"2018-06-20T15:52:15Z","updated_at":"2018-08-01T13:19:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aces/Loris/pulls/3859/commits","review_comments_url":"https://api.github.com/repos/aces/Loris/pulls/3859/comments","review_comment_url":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris/issues/3859/comments","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/079d77247e504fb01f8e031b6d4540387e94c87c","head":{"label":"johnsaigle:180631-Contributing","ref":"180631-Contributing","sha":"079d77247e504fb01f8e031b6d4540387e94c87c","user":{"login":"johnsaigle","id":4022790,"node_id":"MDQ6VXNlcjQwMjI3OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4022790?v=4","gravatar_id":"","url":"https://api.github.com/users/johnsaigle","html_url":"https://github.com/johnsaigle","followers_url":"https://api.github.com/users/johnsaigle/followers","following_url":"https://api.github.com/users/johnsaigle/following{/other_user}","gists_url":"https://api.github.com/users/johnsaigle/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsaigle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsaigle/subscriptions","organizations_url":"https://api.github.com/users/johnsaigle/orgs","repos_url":"https://api.github.com/users/johnsaigle/repos","events_url":"https://api.github.com/users/johnsaigle/events{/privacy}","received_events_url":"https://api.github.com/users/johnsaigle/received_events","type":"User","site_admin":false},"repo":{"id":49739900,"node_id":"MDEwOlJlcG9zaXRvcnk0OTczOTkwMA==","name":"Loris","full_name":"johnsaigle/Loris","owner":{"login":"johnsaigle","id":4022790,"node_id":"MDQ6VXNlcjQwMjI3OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4022790?v=4","gravatar_id":"","url":"https://api.github.com/users/johnsaigle","html_url":"https://github.com/johnsaigle","followers_url":"https://api.github.com/users/johnsaigle/followers","following_url":"https://api.github.com/users/johnsaigle/following{/other_user}","gists_url":"https://api.github.com/users/johnsaigle/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsaigle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsaigle/subscriptions","organizations_url":"https://api.github.com/users/johnsaigle/orgs","repos_url":"https://api.github.com/users/johnsaigle/repos","events_url":"https://api.github.com/users/johnsaigle/events{/privacy}","received_events_url":"https://api.github.com/users/johnsaigle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnsaigle/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":true,"url":"https://api.github.com/repos/johnsaigle/Loris","forks_url":"https://api.github.com/repos/johnsaigle/Loris/forks","keys_url":"https://api.github.com/repos/johnsaigle/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnsaigle/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnsaigle/Loris/teams","hooks_url":"https://api.github.com/repos/johnsaigle/Loris/hooks","issue_events_url":"https://api.github.com/repos/johnsaigle/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/johnsaigle/Loris/events","assignees_url":"https://api.github.com/repos/johnsaigle/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/johnsaigle/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/johnsaigle/Loris/tags","blobs_url":"https://api.github.com/repos/johnsaigle/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnsaigle/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnsaigle/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnsaigle/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnsaigle/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/johnsaigle/Loris/languages","stargazers_url":"https://api.github.com/repos/johnsaigle/Loris/stargazers","contributors_url":"https://api.github.com/repos/johnsaigle/Loris/contributors","subscribers_url":"https://api.github.com/repos/johnsaigle/Loris/subscribers","subscription_url":"https://api.github.com/repos/johnsaigle/Loris/subscription","commits_url":"https://api.github.com/repos/johnsaigle/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnsaigle/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnsaigle/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnsaigle/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnsaigle/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/johnsaigle/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnsaigle/Loris/merges","archive_url":"https://api.github.com/repos/johnsaigle/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnsaigle/Loris/downloads","issues_url":"https://api.github.com/repos/johnsaigle/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/johnsaigle/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/johnsaigle/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/johnsaigle/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnsaigle/Loris/labels{/name}","releases_url":"https://api.github.com/repos/johnsaigle/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/johnsaigle/Loris/deployments","created_at":"2016-01-15T19:21:06Z","updated_at":"2018-07-31T16:35:56Z","pushed_at":"2018-08-02T20:19:39Z","git_url":"git://github.com/johnsaigle/Loris.git","ssh_url":"git@github.com:johnsaigle/Loris.git","clone_url":"https://github.com/johnsaigle/Loris.git","svn_url":"https://github.com/johnsaigle/Loris","homepage":"","size":76144,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"20.0-release"}},"base":{"label":"aces:20.0-release","ref":"20.0-release","sha":"7f9ee2aa87a13e916a01189f3e02486e04ddc205","user":{"login":"aces","id":472868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":1125630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1NjMw","name":"Loris","full_name":"aces/Loris","owner":{"login":"aces","id":472868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aces/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":false,"url":"https://api.github.com/repos/aces/Loris","forks_url":"https://api.github.com/repos/aces/Loris/forks","keys_url":"https://api.github.com/repos/aces/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris/teams","hooks_url":"https://api.github.com/repos/aces/Loris/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris/events","assignees_url":"https://api.github.com/repos/aces/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris/tags","blobs_url":"https://api.github.com/repos/aces/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris/languages","stargazers_url":"https://api.github.com/repos/aces/Loris/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris/subscription","commits_url":"https://api.github.com/repos/aces/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris/merges","archive_url":"https://api.github.com/repos/aces/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris/downloads","issues_url":"https://api.github.com/repos/aces/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/aces/Loris/deployments","created_at":"2010-11-30T14:57:57Z","updated_at":"2018-07-17T17:47:04Z","pushed_at":"2018-08-04T06:39:26Z","git_url":"git://github.com/aces/Loris.git","ssh_url":"git@github.com:aces/Loris.git","clone_url":"https://github.com/aces/Loris.git","svn_url":"https://github.com/aces/Loris","homepage":"","size":76297,"stargazers_count":64,"watchers_count":64,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":93,"open_issues":88,"watchers":64,"default_branch":"minor"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/3859"},"html":{"href":"https://github.com/aces/Loris/pull/3859"},"issue":{"href":"https://api.github.com/repos/aces/Loris/issues/3859"},"comments":{"href":"https://api.github.com/repos/aces/Loris/issues/3859/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris/pulls/3859/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris/pulls/3859/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris/statuses/079d77247e504fb01f8e031b6d4540387e94c87c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PapillonMcGill"}}