{"action":"created","issue":{"url":"https://api.github.com/repos/uport-project/3box-js/issues/65","repository_url":"https://api.github.com/repos/uport-project/3box-js","labels_url":"https://api.github.com/repos/uport-project/3box-js/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/uport-project/3box-js/issues/65/comments","events_url":"https://api.github.com/repos/uport-project/3box-js/issues/65/events","html_url":"https://github.com/uport-project/3box-js/pull/65","id":365931757,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzI5NzI3","number":65,"title":"feat: add internal metadata to sets, timestamp","user":{"login":"zachferland","id":1887967,"node_id":"MDQ6VXNlcjE4ODc5Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/1887967?v=4","gravatar_id":"","url":"https://api.github.com/users/zachferland","html_url":"https://github.com/zachferland","followers_url":"https://api.github.com/users/zachferland/followers","following_url":"https://api.github.com/users/zachferland/following{/other_user}","gists_url":"https://api.github.com/users/zachferland/gists{/gist_id}","starred_url":"https://api.github.com/users/zachferland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachferland/subscriptions","organizations_url":"https://api.github.com/users/zachferland/orgs","repos_url":"https://api.github.com/users/zachferland/repos","events_url":"https://api.github.com/users/zachferland/events{/privacy}","received_events_url":"https://api.github.com/users/zachferland/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-02T14:42:35Z","updated_at":"2018-10-02T14:50:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/uport-project/3box-js/pulls/65","html_url":"https://github.com/uport-project/3box-js/pull/65","diff_url":"https://github.com/uport-project/3box-js/pull/65.diff","patch_url":"https://github.com/uport-project/3box-js/pull/65.patch"},"body":"Adds timestamps to set data. Keeps for internal use for now. We may want to add other additional internal metadata in the future, this starts using it as { value: 'val set by app', timestamp: ..., metadata1: ..., metadata2: ....}. While a get only returns value.  Maybe want to externalize in future."},"comment":{"url":"https://api.github.com/repos/uport-project/3box-js/issues/comments/426303565","html_url":"https://github.com/uport-project/3box-js/pull/65#issuecomment-426303565","issue_url":"https://api.github.com/repos/uport-project/3box-js/issues/65","id":426303565,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjMwMzU2NQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-10-02T14:50:58Z","updated_at":"2018-10-02T14:50:58Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/uport-project/3box-js/pull/65?src=pr&el=h1) Report\n> Merging [#65](https://codecov.io/gh/uport-project/3box-js/pull/65?src=pr&el=desc) into [develop](https://codecov.io/gh/uport-project/3box-js/commit/c93c874e119e8cf1bec73cf946d7600e1b0ae896?src=pr&el=desc) will **increase** coverage by `0.66%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/uport-project/3box-js/pull/65/graphs/tree.svg?width=650&token=57nR93kArk&height=150&src=pr)](https://codecov.io/gh/uport-project/3box-js/pull/65?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff             @@\n##           develop      #65      +/-   ##\n===========================================\n+ Coverage    81.57%   82.23%   +0.66%     \n===========================================\n  Files            6        6              \n  Lines          304      259      -45     \n  Branches        42       38       -4     \n===========================================\n- Hits           248      213      -35     \n+ Misses          48       38      -10     \n  Partials         8        8\n```\n\n\n| [Impacted Files](https://codecov.io/gh/uport-project/3box-js/pull/65?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/keyValueStore.js](https://codecov.io/gh/uport-project/3box-js/pull/65/diff?src=pr&el=tree#diff-c3JjL2tleVZhbHVlU3RvcmUuanM=) | `85.29% <100%> (+1.08%)` | :arrow_up: |\n| [src/utils.js](https://codecov.io/gh/uport-project/3box-js/pull/65/diff?src=pr&el=tree#diff-c3JjL3V0aWxzLmpz) | `14.63% <0%> (-0.26%)` | :arrow_down: |\n| [src/3box.js](https://codecov.io/gh/uport-project/3box-js/pull/65/diff?src=pr&el=tree#diff-c3JjLzNib3guanM=) | `98.46% <0%> (-0.14%)` | :arrow_down: |\n| [src/publicStore.js](https://codecov.io/gh/uport-project/3box-js/pull/65/diff?src=pr&el=tree#diff-c3JjL3B1YmxpY1N0b3JlLmpz) | `100% <0%> (ø)` | :arrow_up: |\n| [src/privateStore.js](https://codecov.io/gh/uport-project/3box-js/pull/65/diff?src=pr&el=tree#diff-c3JjL3ByaXZhdGVTdG9yZS5qcw==) | `100% <0%> (ø)` | :arrow_up: |\n| [src/orbitdbKeyAdapter.js](https://codecov.io/gh/uport-project/3box-js/pull/65/diff?src=pr&el=tree#diff-c3JjL29yYml0ZGJLZXlBZGFwdGVyLmpz) | `75% <0%> (+5.76%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/uport-project/3box-js/pull/65?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/uport-project/3box-js/pull/65?src=pr&el=footer). Last update [c93c874...2ba3e98](https://codecov.io/gh/uport-project/3box-js/pull/65?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}