{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/241224914","pull_request_review_id":184444947,"id":241224914,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTIyNDkxNA==","diff_hunk":"@@ -15,26 +15,38 @@ const isDeepEqual = require('lodash.isequal');\n const Audit = require('./audit');\n const mobileThrottling = require('../config/constants').throttling.mobileSlow4G;\n const Interactive = require('../computed/metrics/interactive.js');\n-\n-const displayValueText = `Interactive at %d\\xa0s`;\n-const displayValueTextWithOverride = `Interactive on simulated mobile network at %d\\xa0s`;\n+const i18n = require('../lib/i18n/i18n.js');\n \n // Maximum TTI to be considered \"fast\" for PWA baseline checklist\n //   https://developers.google.com/web/progressive-web-apps/checklist\n const MAXIMUM_TTI = 10 * 1000;\n \n+const UIStrings = {\n+  /** Imperative title of a Lighthouse audit that tells the user that their page has loaded fast enough to be considered a Progressive Web App. This is displayed in a list of audit titles that Lighthouse generates. */\n+  title: 'Page load is fast enough on mobile networks',\n+  /** Imperative title of a Lighthouse audit that tells the user that their page has loaded fast enough to be considered a Progressive Web App. This imperative title is shown to users when the web page has loaded too slowly to be considered a Progressive Web App. */\n+  failureTitle: 'Page load is not fast enough on mobile networks',\n+  /** Description of a Lighthouse audit that tells the user *why* they need to load fast enough on mobile networks. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */\n+  description: 'A fast page load over a cellular network ensures a good mobile user experience. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/fast-3g).',\n+  /** [ICU Syntax] Label for the audit identifying the time it took for the page to become interactive. */\n+  displayValueText: 'Interactive at {timeInMs, number, seconds}\\xa0s',\n+  /** [ICU Syntax] Label for the audit identifying the time it took for the page to become interactive on a mobile network. */\n+  displayValueTextWithOverride: 'Interactive on simulated mobile network at ' +","path":"lighthouse-core/audits/load-fast-enough-for-pwa.js","position":23,"original_position":23,"commit_id":"6571239c5dad038c882b3f5bf86bf56fa6ac19d0","original_commit_id":"6571239c5dad038c882b3f5bf86bf56fa6ac19d0","user":{"login":"exterkamp","id":6392995,"node_id":"MDQ6VXNlcjYzOTI5OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/6392995?v=4","gravatar_id":"","url":"https://api.github.com/users/exterkamp","html_url":"https://github.com/exterkamp","followers_url":"https://api.github.com/users/exterkamp/followers","following_url":"https://api.github.com/users/exterkamp/following{/other_user}","gists_url":"https://api.github.com/users/exterkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/exterkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exterkamp/subscriptions","organizations_url":"https://api.github.com/users/exterkamp/orgs","repos_url":"https://api.github.com/users/exterkamp/repos","events_url":"https://api.github.com/users/exterkamp/events{/privacy}","received_events_url":"https://api.github.com/users/exterkamp/received_events","type":"User","site_admin":false},"body":"Should this be 1 line @brendankenny?","created_at":"2018-12-12T23:34:45Z","updated_at":"2018-12-12T23:34:46Z","html_url":"https://github.com/GoogleChrome/lighthouse/pull/6767#discussion_r241224914","pull_request_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6767","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/241224914"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/6767#discussion_r241224914"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6767"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6767","id":237483176,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDgzMTc2","html_url":"https://github.com/GoogleChrome/lighthouse/pull/6767","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/6767.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/6767.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6767","number":6767,"state":"open","locked":false,"title":"core(displayvalue): change displayValue to be string only","user":{"login":"exterkamp","id":6392995,"node_id":"MDQ6VXNlcjYzOTI5OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/6392995?v=4","gravatar_id":"","url":"https://api.github.com/users/exterkamp","html_url":"https://github.com/exterkamp","followers_url":"https://api.github.com/users/exterkamp/followers","following_url":"https://api.github.com/users/exterkamp/following{/other_user}","gists_url":"https://api.github.com/users/exterkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/exterkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exterkamp/subscriptions","organizations_url":"https://api.github.com/users/exterkamp/orgs","repos_url":"https://api.github.com/users/exterkamp/repos","events_url":"https://api.github.com/users/exterkamp/events{/privacy}","received_events_url":"https://api.github.com/users/exterkamp/received_events","type":"User","site_admin":false},"body":"<!-- Thank you for submitting a pull request! -->\r\n\r\n**Summary**\r\nConvert displayValue to be a `string` value only instead of `[string, <string | number> ]` for consistency.  Also converted the only 2 audits that still use the old displayValue array format.\r\n- font-size\r\n- load-fast-enough-for-pwa\r\n\r\n**Related Issues/PRs**\r\nfixes: #6200 \r\n","created_at":"2018-12-10T22:09:01Z","updated_at":"2018-12-12T23:34:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e0516a56757bd2de7f20c0518da09047569405d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"paulirish","id":39191,"node_id":"MDQ6VXNlcjM5MTkx","avatar_url":"https://avatars0.githubusercontent.com/u/39191?v=4","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6767/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6767/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6767/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/6571239c5dad038c882b3f5bf86bf56fa6ac19d0","head":{"label":"GoogleChrome:display-value-string","ref":"display-value-string","sha":"6571239c5dad038c882b3f5bf86bf56fa6ac19d0","user":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"node_id":"MDEwOlJlcG9zaXRvcnk1MzM3MDk4OA==","name":"lighthouse","full_name":"GoogleChrome/lighthouse","private":false,"owner":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleChrome/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2018-12-12T22:05:55Z","pushed_at":"2018-12-12T23:33:09Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":"https://developers.google.com/web/tools/lighthouse/","size":28266,"stargazers_count":15474,"watchers_count":15474,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":5069,"mirror_url":null,"archived":false,"open_issues_count":432,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5069,"open_issues":432,"watchers":15474,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"9ebf0692de37bd772c59280dd63071bb9357989e","user":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"node_id":"MDEwOlJlcG9zaXRvcnk1MzM3MDk4OA==","name":"lighthouse","full_name":"GoogleChrome/lighthouse","private":false,"owner":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleChrome/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2018-12-12T22:05:55Z","pushed_at":"2018-12-12T23:33:09Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":"https://developers.google.com/web/tools/lighthouse/","size":28266,"stargazers_count":15474,"watchers_count":15474,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":5069,"mirror_url":null,"archived":false,"open_issues_count":432,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5069,"open_issues":432,"watchers":15474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6767"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/6767"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6767"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6767/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6767/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6767/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/6571239c5dad038c882b3f5bf86bf56fa6ac19d0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"exterkamp"}}