{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4895","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4895/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4895/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4895/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4895","id":378782097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDA0MTc4","number":4895,"title":"Replace cloud tenant form with React component","user":{"login":"Hyperkid123","id":22619452,"node_id":"MDQ6VXNlcjIyNjE5NDUy","avatar_url":"https://avatars1.githubusercontent.com/u/22619452?v=4","gravatar_id":"","url":"https://api.github.com/users/Hyperkid123","html_url":"https://github.com/Hyperkid123","followers_url":"https://api.github.com/users/Hyperkid123/followers","following_url":"https://api.github.com/users/Hyperkid123/following{/other_user}","gists_url":"https://api.github.com/users/Hyperkid123/gists{/gist_id}","starred_url":"https://api.github.com/users/Hyperkid123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hyperkid123/subscriptions","organizations_url":"https://api.github.com/users/Hyperkid123/orgs","repos_url":"https://api.github.com/users/Hyperkid123/repos","events_url":"https://api.github.com/users/Hyperkid123/events{/privacy}","received_events_url":"https://api.github.com/users/Hyperkid123/received_events","type":"User","site_admin":false},"labels":[{"id":873726227,"node_id":"MDU6TGFiZWw4NzM3MjYyMjc=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/react","name":"react","color":"f2afa2","default":false},{"id":512311643,"node_id":"MDU6TGFiZWw1MTIzMTE2NDM=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/refactoring","name":"refactoring","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"martinpovolny","id":51095,"node_id":"MDQ6VXNlcjUxMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/51095?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"assignees":[{"login":"martinpovolny","id":51095,"node_id":"MDQ6VXNlcjUxMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/51095?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2018-11-08T15:26:57Z","updated_at":"2018-11-29T15:12:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4895","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4895","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4895.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4895.patch"},"body":"Replaces angular form with React component.\r\n\r\nform is at: `Compute` -> `Clouds` -> `Tenants` -> `Create/Edit`\r\n\r\n### Changes\r\n- Added required error messages\r\n- Replaced JS maxLength validation with HTML5 (can't write more 128 characters into name input). Before there was some NG validator that did not even show error if there was more than 128 characters.\r\n- Using data-driven-forms\r\n\r\n### Before\r\n![screenshot from 2018-11-26 13-17-08](https://user-images.githubusercontent.com/22619452/49013656-cd28a880-f17d-11e8-8f21-503037650453.png)\r\n\r\n### After\r\n![screenshot from 2018-11-26 13-26-36](https://user-images.githubusercontent.com/22619452/49014014-f8f85e00-f17e-11e8-9e3f-b1ea1dac0b8f.png)\r\n\r\n\r\n### TO DO\r\n- [x] tests\r\n- [x] remove dead code"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/442869004","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4895#issuecomment-442869004","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4895","id":442869004,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mjg2OTAwNA==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T15:12:41Z","updated_at":"2018-11-29T15:12:41Z","author_association":"MEMBER","body":"<rubocop />Checked commit https://github.com/Hyperkid123/manageiq-ui-classic/commit/349ac435de338664f8e100c1e40b55a71353ceee with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n0 files checked, 0 offenses detected\nEverything looks fine. :star:\n"}}
{"actor":{"display_login":"miq-bot"}}