{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/2802","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/2802/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/2802/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/2802/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/issues/2802","id":297192565,"number":2802,"title":"Don't flag potentially static methods in test packages","user":{"login":"elharo","id":1005544,"avatar_url":"https://avatars2.githubusercontent.com/u/1005544?v=4","gravatar_id":"","url":"https://api.github.com/users/elharo","html_url":"https://github.com/elharo","followers_url":"https://api.github.com/users/elharo/followers","following_url":"https://api.github.com/users/elharo/following{/other_user}","gists_url":"https://api.github.com/users/elharo/gists{/gist_id}","starred_url":"https://api.github.com/users/elharo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elharo/subscriptions","organizations_url":"https://api.github.com/users/elharo/orgs","repos_url":"https://api.github.com/users/elharo/repos","events_url":"https://api.github.com/users/elharo/events{/privacy}","received_events_url":"https://api.github.com/users/elharo/received_events","type":"User","site_admin":false},"labels":[{"id":338414096,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/labels/Tech%20Debt","name":"Tech Debt","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"briandealwis","id":202851,"avatar_url":"https://avatars3.githubusercontent.com/u/202851?v=4","gravatar_id":"","url":"https://api.github.com/users/briandealwis","html_url":"https://github.com/briandealwis","followers_url":"https://api.github.com/users/briandealwis/followers","following_url":"https://api.github.com/users/briandealwis/following{/other_user}","gists_url":"https://api.github.com/users/briandealwis/gists{/gist_id}","starred_url":"https://api.github.com/users/briandealwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandealwis/subscriptions","organizations_url":"https://api.github.com/users/briandealwis/orgs","repos_url":"https://api.github.com/users/briandealwis/repos","events_url":"https://api.github.com/users/briandealwis/events{/privacy}","received_events_url":"https://api.github.com/users/briandealwis/received_events","type":"User","site_admin":false},"assignees":[{"login":"briandealwis","id":202851,"avatar_url":"https://avatars3.githubusercontent.com/u/202851?v=4","gravatar_id":"","url":"https://api.github.com/users/briandealwis","html_url":"https://github.com/briandealwis","followers_url":"https://api.github.com/users/briandealwis/followers","following_url":"https://api.github.com/users/briandealwis/following{/other_user}","gists_url":"https://api.github.com/users/briandealwis/gists{/gist_id}","starred_url":"https://api.github.com/users/briandealwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandealwis/subscriptions","organizations_url":"https://api.github.com/users/briandealwis/orgs","repos_url":"https://api.github.com/users/briandealwis/repos","events_url":"https://api.github.com/users/briandealwis/events{/privacy}","received_events_url":"https://api.github.com/users/briandealwis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-02-14T18:06:16Z","updated_at":"2018-02-14T18:26:16Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"We have many info messages of this form:\r\n\r\nThe method testManagedSdkOption_featureForced() from the type CloudSdkManagerTest can potentially be declared as static\tCloudSdkManagerTest.java\t/com.google.cloud.tools.eclipse.sdk.test/src/com/google/cloud/tools/eclipse/sdk\tline 65\tJava Problem\r\n\r\nThis seems to be untrue:\r\n\r\n```\r\njava.lang.Exception: Method testNewAppEngineStandardProject() should not be static\r\n\tat org.junit.runners.model.FrameworkMethod.validatePublicVoid(FrameworkMethod.java:93)\r\n\tat org.junit.runners.model.FrameworkMethod.validatePublicVoidNoArg(FrameworkMethod.java:74)\r\n\tat org.junit.runners.ParentRunner.validatePublicVoidNoArgMethods(ParentRunner.java:155)\r\n\tat org.junit.runners.BlockJUnit4ClassRunner.validateTestMethods(BlockJUnit4ClassRunner.java:208)\r\n\tat org.junit.runners.BlockJUnit4ClassRunner.validateInstanceMethods(BlockJUnit4ClassRunner.java:188)\r\n\tat org.junit.runners.BlockJUnit4ClassRunner.collectInitializationErrors(BlockJUnit4ClassRunner.java:128)\r\n\tat org.junit.runners.ParentRunner.validate(ParentRunner.java:416)\r\n\tat org.junit.runners.ParentRunner.<init>(ParentRunner.java:84)\r\n\tat org.junit.runners.BlockJUnit4ClassRunner.<init>(BlockJUnit4ClassRunner.java:65)\r\n\tat org.junit.internal.builders.JUnit4Builder.runnerForClass(JUnit4Builder.java:10)\r\n\tat org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)\r\n\tat org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:26)\r\n\tat org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)\r\n\tat org.junit.internal.requests.ClassRequest.getRunner(ClassRequest.java:33)\r\n\tat org.eclipse.jdt.internal.junit4.runner.JUnit4TestLoader.createUnfilteredTest(JUnit4TestLoader.java:84)\r\n\tat org.eclipse.jdt.internal.junit4.runner.JUnit4TestLoader.createTest(JUnit4TestLoader.java:70)\r\n\tat org.eclipse.jdt.internal.junit4.runner.JUnit4TestLoader.loadTests(JUnit4TestLoader.java:43)\r\n\tat org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:444)\r\n\tat org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)\r\n\tat org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)\r\n\tat org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:62)\r\n\tat org.eclipse.pde.internal.junit.runtime.PlatformUITestHarness$1.run(PlatformUITestHarness.java:47)\r\n\tat org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)\r\n\tat org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)\r\n\tat org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4024)\r\n\tat org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3700)\r\n\tat org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)\r\n\tat org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)\r\n\tat org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)\r\n\tat org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)\r\n\tat org.eclipse.ui.internal.Workbench$5.run(Workbench.java:694)\r\n\tat org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)\r\n\tat org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:606)\r\n\tat org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)\r\n\tat org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)\r\n\tat org.eclipse.pde.internal.junit.runtime.NonUIThreadTestApplication.runApp(NonUIThreadTestApplication.java:54)\r\n\tat org.eclipse.pde.internal.junit.runtime.UITestApplication.runApp(UITestApplication.java:47)\r\n\tat org.eclipse.pde.internal.junit.runtime.NonUIThreadTestApplication.start(NonUIThreadTestApplication.java:48)\r\n\tat org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)\r\n\tat org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)\r\n\tat org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)\r\n\tat org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)\r\n\tat org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat java.lang.reflect.Method.invoke(Method.java:498)\r\n\tat org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)\r\n\tat org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)\r\n\tat org.eclipse.equinox.launcher.Main.run(Main.java:1515)\r\n\tat org.eclipse.equinox.launcher.Main.main(Main.java:1488)\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/comments/365699712","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/issues/2802#issuecomment-365699712","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/2802","id":365699712,"user":{"login":"briandealwis","id":202851,"avatar_url":"https://avatars3.githubusercontent.com/u/202851?v=4","gravatar_id":"","url":"https://api.github.com/users/briandealwis","html_url":"https://github.com/briandealwis","followers_url":"https://api.github.com/users/briandealwis/followers","following_url":"https://api.github.com/users/briandealwis/following{/other_user}","gists_url":"https://api.github.com/users/briandealwis/gists{/gist_id}","starred_url":"https://api.github.com/users/briandealwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandealwis/subscriptions","organizations_url":"https://api.github.com/users/briandealwis/orgs","repos_url":"https://api.github.com/users/briandealwis/repos","events_url":"https://api.github.com/users/briandealwis/events{/privacy}","received_events_url":"https://api.github.com/users/briandealwis/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T18:26:16Z","updated_at":"2018-02-14T18:26:16Z","author_association":"COLLABORATOR","body":"Doesn't seem useful.  I'll turn it off."}}
{"actor":{"display_login":"briandealwis"}}