{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/machine-config-operator/issues/49","repository_url":"https://api.github.com/repos/openshift/machine-config-operator","labels_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/49/comments","events_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/49/events","html_url":"https://github.com/openshift/machine-config-operator/pull/49","id":357819486,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzQ0MTY1","number":49,"title":"daemon: strengthen user/group handling","user":{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"labels":[{"id":1005850192,"node_id":"MDU6TGFiZWwxMDA1ODUwMTky","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1005849393,"node_id":"MDU6TGFiZWwxMDA1ODQ5Mzkz","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1005849749,"node_id":"MDU6TGFiZWwxMDA1ODQ5NzQ5","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"ashcrow","id":22706,"node_id":"MDQ6VXNlcjIyNzA2","avatar_url":"https://avatars3.githubusercontent.com/u/22706?v=4","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"assignees":[{"login":"ashcrow","id":22706,"node_id":"MDQ6VXNlcjIyNzA2","avatar_url":"https://avatars3.githubusercontent.com/u/22706?v=4","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-09-06T20:42:21Z","updated_at":"2018-09-06T21:38:19Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/49","html_url":"https://github.com/openshift/machine-config-operator/pull/49","diff_url":"https://github.com/openshift/machine-config-operator/pull/49.diff","patch_url":"https://github.com/openshift/machine-config-operator/pull/49.patch"},"body":"We were previously dereferencing `f.User` without checking if it was\r\n`nil` first. Just lift `ResolveNodeUidAndGid()` from Ignition (and make\r\na note that we should dedupe stuff down the line)."},"comment":{"url":"https://api.github.com/repos/openshift/machine-config-operator/issues/comments/419249833","html_url":"https://github.com/openshift/machine-config-operator/pull/49#issuecomment-419249833","issue_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/49","id":419249833,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTI0OTgzMw==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-09-06T21:38:19Z","updated_at":"2018-09-06T21:38:19Z","author_association":"NONE","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/openshift/machine-config-operator/pull/49#issuecomment-419249642\" title=\"LGTM\">ashcrow</a>*, *<a href=\"https://github.com/openshift/machine-config-operator/pull/49#\" title=\"Author self-approved\">jlebon</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/daemon/OWNERS](https://github.com/openshift/machine-config-operator/blob/master/pkg/daemon/OWNERS)~~ [ashcrow,jlebon]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}