{"action":"created","issue":{"url":"https://api.github.com/repos/onnx/tensorflow-onnx/issues/88","repository_url":"https://api.github.com/repos/onnx/tensorflow-onnx","labels_url":"https://api.github.com/repos/onnx/tensorflow-onnx/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/onnx/tensorflow-onnx/issues/88/comments","events_url":"https://api.github.com/repos/onnx/tensorflow-onnx/issues/88/events","html_url":"https://github.com/onnx/tensorflow-onnx/pull/88","id":344669212,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MDEwMTcz","number":88,"title":"fix the graph output node dtype issue","user":{"login":"pengwa","id":10530022,"node_id":"MDQ6VXNlcjEwNTMwMDIy","avatar_url":"https://avatars1.githubusercontent.com/u/10530022?v=4","gravatar_id":"","url":"https://api.github.com/users/pengwa","html_url":"https://github.com/pengwa","followers_url":"https://api.github.com/users/pengwa/followers","following_url":"https://api.github.com/users/pengwa/following{/other_user}","gists_url":"https://api.github.com/users/pengwa/gists{/gist_id}","starred_url":"https://api.github.com/users/pengwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengwa/subscriptions","organizations_url":"https://api.github.com/users/pengwa/orgs","repos_url":"https://api.github.com/users/pengwa/repos","events_url":"https://api.github.com/users/pengwa/events{/privacy}","received_events_url":"https://api.github.com/users/pengwa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-26T02:12:47Z","updated_at":"2018-07-26T03:10:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/onnx/tensorflow-onnx/pulls/88","html_url":"https://github.com/onnx/tensorflow-onnx/pull/88","diff_url":"https://github.com/onnx/tensorflow-onnx/pull/88.diff","patch_url":"https://github.com/onnx/tensorflow-onnx/pull/88.patch"},"body":"send for an early review, need solve the int32 issue before merge. "},"comment":{"url":"https://api.github.com/repos/onnx/tensorflow-onnx/issues/comments/407962266","html_url":"https://github.com/onnx/tensorflow-onnx/pull/88#issuecomment-407962266","issue_url":"https://api.github.com/repos/onnx/tensorflow-onnx/issues/88","id":407962266,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzk2MjI2Ng==","user":{"login":"pengwa","id":10530022,"node_id":"MDQ6VXNlcjEwNTMwMDIy","avatar_url":"https://avatars1.githubusercontent.com/u/10530022?v=4","gravatar_id":"","url":"https://api.github.com/users/pengwa","html_url":"https://github.com/pengwa","followers_url":"https://api.github.com/users/pengwa/followers","following_url":"https://api.github.com/users/pengwa/following{/other_user}","gists_url":"https://api.github.com/users/pengwa/gists{/gist_id}","starred_url":"https://api.github.com/users/pengwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengwa/subscriptions","organizations_url":"https://api.github.com/users/pengwa/orgs","repos_url":"https://api.github.com/users/pengwa/repos","events_url":"https://api.github.com/users/pengwa/events{/privacy}","received_events_url":"https://api.github.com/users/pengwa/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T03:10:04Z","updated_at":"2018-07-26T03:10:04Z","author_association":"CONTRIBUTOR","body":"Thanks @guschmue , I tried another approach. since Graph (e.g. ctx)'s _dtypes are prepared  before func() are executed, while I think limiting the int32->int64 is operator level stuff/workaround. So I update the global ctx's _dtype when TopK operator is being handled, then when make_graph is called, ouput node is generated with the updated topk:1 dtype. \r\n\r\nDo you have any concerns since I am modifying the dtypes of topk:1 in the middle of graph handling?"}}
{"actor":{"display_login":"pengwa"}}