{"action":"created","comment":{"url":"https://api.github.com/repos/ESCOMP/ctsm/pulls/comments/232415058","pull_request_review_id":173618111,"id":232415058,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQxNTA1OA==","diff_hunk":"@@ -2779,7 +2780,7 @@ sub setup_logic_irrigation_parameters {\n      my $var;\n      foreach $var (\"irrig_min_lai\", \"irrig_start_time\", \"irrig_length\",\n                    \"irrig_target_smp\", \"irrig_depth\", \"irrig_threshold_fraction\",\n-                   \"limit_irrigation_if_rof_enabled\") {\n+                   \"limit_irrigation_if_rof_enabled\",\"use_groundwater_irrigation\") {\n         add_default($opts, $nl_flags->{'inputdata_rootdir'}, $definition, $defaults, $nl, $var);\n      }\n ","path":"bld/CLMBuildNamelist.pm","position":18,"original_position":18,"commit_id":"2b33248d3e954c89ce39f7da7e2937708b10dcdd","original_commit_id":"e309a6300200b944b985372a6c2fbe18e9b83755","user":{"login":"billsacks","id":6266741,"node_id":"MDQ6VXNlcjYyNjY3NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6266741?v=4","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false},"body":"Okay, I added this and tested by adding use_groundwater_irrigation to user_nl_clm for both a clm50 case (works) and clm45 case (dies with the error).","created_at":"2018-11-09T22:42:42Z","updated_at":"2018-11-09T22:42:43Z","html_url":"https://github.com/ESCOMP/ctsm/pull/523#discussion_r232415058","pull_request_url":"https://api.github.com/repos/ESCOMP/ctsm/pulls/523","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ESCOMP/ctsm/pulls/comments/232415058"},"html":{"href":"https://github.com/ESCOMP/ctsm/pull/523#discussion_r232415058"},"pull_request":{"href":"https://api.github.com/repos/ESCOMP/ctsm/pulls/523"}},"in_reply_to_id":232384448},"pull_request":{"url":"https://api.github.com/repos/ESCOMP/ctsm/pulls/523","id":218706899,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NzA2ODk5","html_url":"https://github.com/ESCOMP/ctsm/pull/523","diff_url":"https://github.com/ESCOMP/ctsm/pull/523.diff","patch_url":"https://github.com/ESCOMP/ctsm/pull/523.patch","issue_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/523","number":523,"state":"open","locked":false,"title":"Groundwater irrigation","user":{"login":"swensosc","id":27451132,"node_id":"MDQ6VXNlcjI3NDUxMTMy","avatar_url":"https://avatars1.githubusercontent.com/u/27451132?v=4","gravatar_id":"","url":"https://api.github.com/users/swensosc","html_url":"https://github.com/swensosc","followers_url":"https://api.github.com/users/swensosc/followers","following_url":"https://api.github.com/users/swensosc/following{/other_user}","gists_url":"https://api.github.com/users/swensosc/gists{/gist_id}","starred_url":"https://api.github.com/users/swensosc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swensosc/subscriptions","organizations_url":"https://api.github.com/users/swensosc/orgs","repos_url":"https://api.github.com/users/swensosc/repos","events_url":"https://api.github.com/users/swensosc/events{/privacy}","received_events_url":"https://api.github.com/users/swensosc/received_events","type":"User","site_admin":false},"body":"### Description of changes\r\nAdd irrigation from groundwater sources (unconfined [from the soil column] and confined [from wa] aquifers).  Add irrigation application method (sprinkler [above canopy] and drip [below canopy]).  Both of these changes are activated via namelist.  Add option to set saturated fraction to zero for crop columns.\r\n### Specific notes\r\nIrrigation method also requires input data on surface data file, otherwise will default to previous behavior (drip).  \r\n\r\nContributors other than yourself, if any:\r\n\r\nCTSM Issues Fixed (include github issue #):\r\n\r\nAre answers expected to change (and if so in what way)?\r\nmaybe for changes related to irrigation method due to new variables used to \r\napply irrigation in CanopyHydrologyMod\r\n\r\nAny User Interface Changes (namelist or namelist defaults changes)?\r\ntwo new namelist variables: use_groundwater_irrigation and crop_fsat_equals_zero\r\nthe latter name might not be great and could be changed\r\n\r\nTesting performed, if any:\r\n(List what testing you did to show your changes worked as expected)\r\n(This can be manual testing or running of the different test suites)\r\n(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)\r\n(aux_clm on cheyenne for gnu/pgi and hobart for gnu/pgi/nag is the standard for tags on master)\r\n\r\nperformed 1 year simulation with new options activated\r\n\r\n**NOTE: Be sure to check your Coding style against the standard:**\r\nhttps://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines\r\n","created_at":"2018-09-27T16:00:44Z","updated_at":"2018-11-09T22:42:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb9e09c3391b8420f3eb19e875ee5edc3d943298","assignee":{"login":"billsacks","id":6266741,"node_id":"MDQ6VXNlcjYyNjY3NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6266741?v=4","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false},"assignees":[{"login":"billsacks","id":6266741,"node_id":"MDQ6VXNlcjYyNjY3NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6266741?v=4","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1065159210,"node_id":"MDU6TGFiZWwxMDY1MTU5MjEw","url":"https://api.github.com/repos/ESCOMP/ctsm/labels/status:%20work%20in%20progress","name":"status: work in progress","color":"5358e8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ESCOMP/ctsm/pulls/523/commits","review_comments_url":"https://api.github.com/repos/ESCOMP/ctsm/pulls/523/comments","review_comment_url":"https://api.github.com/repos/ESCOMP/ctsm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/523/comments","statuses_url":"https://api.github.com/repos/ESCOMP/ctsm/statuses/2b33248d3e954c89ce39f7da7e2937708b10dcdd","head":{"label":"swensosc:groundwater_irrigation","ref":"groundwater_irrigation","sha":"2b33248d3e954c89ce39f7da7e2937708b10dcdd","user":{"login":"swensosc","id":27451132,"node_id":"MDQ6VXNlcjI3NDUxMTMy","avatar_url":"https://avatars1.githubusercontent.com/u/27451132?v=4","gravatar_id":"","url":"https://api.github.com/users/swensosc","html_url":"https://github.com/swensosc","followers_url":"https://api.github.com/users/swensosc/followers","following_url":"https://api.github.com/users/swensosc/following{/other_user}","gists_url":"https://api.github.com/users/swensosc/gists{/gist_id}","starred_url":"https://api.github.com/users/swensosc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swensosc/subscriptions","organizations_url":"https://api.github.com/users/swensosc/orgs","repos_url":"https://api.github.com/users/swensosc/repos","events_url":"https://api.github.com/users/swensosc/events{/privacy}","received_events_url":"https://api.github.com/users/swensosc/received_events","type":"User","site_admin":false},"repo":{"id":117866476,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4NjY0NzY=","name":"ctsm","full_name":"swensosc/ctsm","private":false,"owner":{"login":"swensosc","id":27451132,"node_id":"MDQ6VXNlcjI3NDUxMTMy","avatar_url":"https://avatars1.githubusercontent.com/u/27451132?v=4","gravatar_id":"","url":"https://api.github.com/users/swensosc","html_url":"https://github.com/swensosc","followers_url":"https://api.github.com/users/swensosc/followers","following_url":"https://api.github.com/users/swensosc/following{/other_user}","gists_url":"https://api.github.com/users/swensosc/gists{/gist_id}","starred_url":"https://api.github.com/users/swensosc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swensosc/subscriptions","organizations_url":"https://api.github.com/users/swensosc/orgs","repos_url":"https://api.github.com/users/swensosc/repos","events_url":"https://api.github.com/users/swensosc/events{/privacy}","received_events_url":"https://api.github.com/users/swensosc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/swensosc/ctsm","description":"EXPERIMENTAL - DO NOT USE!","fork":true,"url":"https://api.github.com/repos/swensosc/ctsm","forks_url":"https://api.github.com/repos/swensosc/ctsm/forks","keys_url":"https://api.github.com/repos/swensosc/ctsm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swensosc/ctsm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swensosc/ctsm/teams","hooks_url":"https://api.github.com/repos/swensosc/ctsm/hooks","issue_events_url":"https://api.github.com/repos/swensosc/ctsm/issues/events{/number}","events_url":"https://api.github.com/repos/swensosc/ctsm/events","assignees_url":"https://api.github.com/repos/swensosc/ctsm/assignees{/user}","branches_url":"https://api.github.com/repos/swensosc/ctsm/branches{/branch}","tags_url":"https://api.github.com/repos/swensosc/ctsm/tags","blobs_url":"https://api.github.com/repos/swensosc/ctsm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swensosc/ctsm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swensosc/ctsm/git/refs{/sha}","trees_url":"https://api.github.com/repos/swensosc/ctsm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swensosc/ctsm/statuses/{sha}","languages_url":"https://api.github.com/repos/swensosc/ctsm/languages","stargazers_url":"https://api.github.com/repos/swensosc/ctsm/stargazers","contributors_url":"https://api.github.com/repos/swensosc/ctsm/contributors","subscribers_url":"https://api.github.com/repos/swensosc/ctsm/subscribers","subscription_url":"https://api.github.com/repos/swensosc/ctsm/subscription","commits_url":"https://api.github.com/repos/swensosc/ctsm/commits{/sha}","git_commits_url":"https://api.github.com/repos/swensosc/ctsm/git/commits{/sha}","comments_url":"https://api.github.com/repos/swensosc/ctsm/comments{/number}","issue_comment_url":"https://api.github.com/repos/swensosc/ctsm/issues/comments{/number}","contents_url":"https://api.github.com/repos/swensosc/ctsm/contents/{+path}","compare_url":"https://api.github.com/repos/swensosc/ctsm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swensosc/ctsm/merges","archive_url":"https://api.github.com/repos/swensosc/ctsm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swensosc/ctsm/downloads","issues_url":"https://api.github.com/repos/swensosc/ctsm/issues{/number}","pulls_url":"https://api.github.com/repos/swensosc/ctsm/pulls{/number}","milestones_url":"https://api.github.com/repos/swensosc/ctsm/milestones{/number}","notifications_url":"https://api.github.com/repos/swensosc/ctsm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swensosc/ctsm/labels{/name}","releases_url":"https://api.github.com/repos/swensosc/ctsm/releases{/id}","deployments_url":"https://api.github.com/repos/swensosc/ctsm/deployments","created_at":"2018-01-17T17:04:45Z","updated_at":"2018-06-21T16:30:51Z","pushed_at":"2018-11-09T22:42:14Z","git_url":"git://github.com/swensosc/ctsm.git","ssh_url":"git@github.com:swensosc/ctsm.git","clone_url":"https://github.com/swensosc/ctsm.git","svn_url":"https://github.com/swensosc/ctsm","homepage":null,"size":16779,"stargazers_count":0,"watchers_count":0,"language":"Fortran","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ESCOMP:master","ref":"master","sha":"527f3262e550c96b28ce78ee307457bf6adb2e46","user":{"login":"ESCOMP","id":33552285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTUyMjg1","avatar_url":"https://avatars3.githubusercontent.com/u/33552285?v=4","gravatar_id":"","url":"https://api.github.com/users/ESCOMP","html_url":"https://github.com/ESCOMP","followers_url":"https://api.github.com/users/ESCOMP/followers","following_url":"https://api.github.com/users/ESCOMP/following{/other_user}","gists_url":"https://api.github.com/users/ESCOMP/gists{/gist_id}","starred_url":"https://api.github.com/users/ESCOMP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESCOMP/subscriptions","organizations_url":"https://api.github.com/users/ESCOMP/orgs","repos_url":"https://api.github.com/users/ESCOMP/repos","events_url":"https://api.github.com/users/ESCOMP/events{/privacy}","received_events_url":"https://api.github.com/users/ESCOMP/received_events","type":"Organization","site_admin":false},"repo":{"id":114487210,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ0ODcyMTA=","name":"ctsm","full_name":"ESCOMP/ctsm","private":false,"owner":{"login":"ESCOMP","id":33552285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTUyMjg1","avatar_url":"https://avatars3.githubusercontent.com/u/33552285?v=4","gravatar_id":"","url":"https://api.github.com/users/ESCOMP","html_url":"https://github.com/ESCOMP","followers_url":"https://api.github.com/users/ESCOMP/followers","following_url":"https://api.github.com/users/ESCOMP/following{/other_user}","gists_url":"https://api.github.com/users/ESCOMP/gists{/gist_id}","starred_url":"https://api.github.com/users/ESCOMP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESCOMP/subscriptions","organizations_url":"https://api.github.com/users/ESCOMP/orgs","repos_url":"https://api.github.com/users/ESCOMP/repos","events_url":"https://api.github.com/users/ESCOMP/events{/privacy}","received_events_url":"https://api.github.com/users/ESCOMP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ESCOMP/ctsm","description":"Community Terrestrial Systems Model (includes the Community Land Model of CESM)","fork":false,"url":"https://api.github.com/repos/ESCOMP/ctsm","forks_url":"https://api.github.com/repos/ESCOMP/ctsm/forks","keys_url":"https://api.github.com/repos/ESCOMP/ctsm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESCOMP/ctsm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESCOMP/ctsm/teams","hooks_url":"https://api.github.com/repos/ESCOMP/ctsm/hooks","issue_events_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/events{/number}","events_url":"https://api.github.com/repos/ESCOMP/ctsm/events","assignees_url":"https://api.github.com/repos/ESCOMP/ctsm/assignees{/user}","branches_url":"https://api.github.com/repos/ESCOMP/ctsm/branches{/branch}","tags_url":"https://api.github.com/repos/ESCOMP/ctsm/tags","blobs_url":"https://api.github.com/repos/ESCOMP/ctsm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESCOMP/ctsm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESCOMP/ctsm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESCOMP/ctsm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESCOMP/ctsm/statuses/{sha}","languages_url":"https://api.github.com/repos/ESCOMP/ctsm/languages","stargazers_url":"https://api.github.com/repos/ESCOMP/ctsm/stargazers","contributors_url":"https://api.github.com/repos/ESCOMP/ctsm/contributors","subscribers_url":"https://api.github.com/repos/ESCOMP/ctsm/subscribers","subscription_url":"https://api.github.com/repos/ESCOMP/ctsm/subscription","commits_url":"https://api.github.com/repos/ESCOMP/ctsm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESCOMP/ctsm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESCOMP/ctsm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ESCOMP/ctsm/contents/{+path}","compare_url":"https://api.github.com/repos/ESCOMP/ctsm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESCOMP/ctsm/merges","archive_url":"https://api.github.com/repos/ESCOMP/ctsm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESCOMP/ctsm/downloads","issues_url":"https://api.github.com/repos/ESCOMP/ctsm/issues{/number}","pulls_url":"https://api.github.com/repos/ESCOMP/ctsm/pulls{/number}","milestones_url":"https://api.github.com/repos/ESCOMP/ctsm/milestones{/number}","notifications_url":"https://api.github.com/repos/ESCOMP/ctsm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESCOMP/ctsm/labels{/name}","releases_url":"https://api.github.com/repos/ESCOMP/ctsm/releases{/id}","deployments_url":"https://api.github.com/repos/ESCOMP/ctsm/deployments","created_at":"2017-12-16T20:05:16Z","updated_at":"2018-11-01T13:30:30Z","pushed_at":"2018-11-09T22:42:16Z","git_url":"git://github.com/ESCOMP/ctsm.git","ssh_url":"git@github.com:ESCOMP/ctsm.git","clone_url":"https://github.com/ESCOMP/ctsm.git","svn_url":"https://github.com/ESCOMP/ctsm","homepage":"http://www.cesm.ucar.edu/models/cesm2.0/land/","size":16496,"stargazers_count":44,"watchers_count":44,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":62,"open_issues":321,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ESCOMP/ctsm/pulls/523"},"html":{"href":"https://github.com/ESCOMP/ctsm/pull/523"},"issue":{"href":"https://api.github.com/repos/ESCOMP/ctsm/issues/523"},"comments":{"href":"https://api.github.com/repos/ESCOMP/ctsm/issues/523/comments"},"review_comments":{"href":"https://api.github.com/repos/ESCOMP/ctsm/pulls/523/comments"},"review_comment":{"href":"https://api.github.com/repos/ESCOMP/ctsm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ESCOMP/ctsm/pulls/523/commits"},"statuses":{"href":"https://api.github.com/repos/ESCOMP/ctsm/statuses/2b33248d3e954c89ce39f7da7e2937708b10dcdd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"billsacks"}}