{"action":"created","comment":{"url":"https://api.github.com/repos/m-labs/artiq/pulls/comments/194484235","pull_request_review_id":127664620,"id":194484235,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDQ4NDIzNQ==","diff_hunk":"@@ -1,15 +1,3 @@\n-/*\n- * HMC830 config:\n- * 100MHz input, 1.2GHz output\n- * fvco = (refclk / r_divider) * n_divider\n- * fout = fvco/2\n- *\n- * HMC7043 config:","path":"artiq/firmware/libboard_artiq/hmc830_7043.rs","position":7,"original_position":7,"commit_id":"2621782f8c6bcf05f0e0ca85df42704922e5945b","original_commit_id":"2621782f8c6bcf05f0e0ca85df42704922e5945b","user":{"login":"jordens","id":1338946,"node_id":"MDQ6VXNlcjEzMzg5NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1338946?v=4","gravatar_id":"","url":"https://api.github.com/users/jordens","html_url":"https://github.com/jordens","followers_url":"https://api.github.com/users/jordens/followers","following_url":"https://api.github.com/users/jordens/following{/other_user}","gists_url":"https://api.github.com/users/jordens/gists{/gist_id}","starred_url":"https://api.github.com/users/jordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordens/subscriptions","organizations_url":"https://api.github.com/users/jordens/orgs","repos_url":"https://api.github.com/users/jordens/repos","events_url":"https://api.github.com/users/jordens/events{/privacy}","received_events_url":"https://api.github.com/users/jordens/received_events","type":"User","site_admin":false},"body":"That part of the comment shouldn't be removed.","created_at":"2018-06-11T17:31:12Z","updated_at":"2018-06-11T17:32:39Z","html_url":"https://github.com/m-labs/artiq/pull/1068#discussion_r194484235","pull_request_url":"https://api.github.com/repos/m-labs/artiq/pulls/1068","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/m-labs/artiq/pulls/comments/194484235"},"html":{"href":"https://github.com/m-labs/artiq/pull/1068#discussion_r194484235"},"pull_request":{"href":"https://api.github.com/repos/m-labs/artiq/pulls/1068"}}},"pull_request":{"url":"https://api.github.com/repos/m-labs/artiq/pulls/1068","id":194028551,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDI4NTUx","html_url":"https://github.com/m-labs/artiq/pull/1068","diff_url":"https://github.com/m-labs/artiq/pull/1068.diff","patch_url":"https://github.com/m-labs/artiq/pull/1068.patch","issue_url":"https://api.github.com/repos/m-labs/artiq/issues/1068","number":1068,"state":"open","locked":false,"title":"Sayma HMC830: update interface and register writes.","user":{"login":"hartytp","id":21218399,"node_id":"MDQ6VXNlcjIxMjE4Mzk5","avatar_url":"https://avatars0.githubusercontent.com/u/21218399?v=4","gravatar_id":"","url":"https://api.github.com/users/hartytp","html_url":"https://github.com/hartytp","followers_url":"https://api.github.com/users/hartytp/followers","following_url":"https://api.github.com/users/hartytp/following{/other_user}","gists_url":"https://api.github.com/users/hartytp/gists{/gist_id}","starred_url":"https://api.github.com/users/hartytp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartytp/subscriptions","organizations_url":"https://api.github.com/users/hartytp/orgs","repos_url":"https://api.github.com/users/hartytp/repos","events_url":"https://api.github.com/users/hartytp/events{/privacy}","received_events_url":"https://api.github.com/users/hartytp/received_events","type":"User","site_admin":false},"body":"- Break the HMC830 init into separate functions for general purpose (but, integer-N) init, setting dividers and checking lock\r\n- Use 1.6mA ICP (which the loop filter was optimized for)\r\n- Go through the data sheet carefully and set all registers to the correct value (e.g. ensure that all settings are correctly optimized for integer-N usage)\r\n- Change divider values (now using 100MHz PFD, which should give lower noise in theory)\r\n- Tested at Oxford and all locked reliably well here, but someone else should check this before merging!","created_at":"2018-06-11T16:01:19Z","updated_at":"2018-06-11T17:32:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e46cb62601447a33159492478413a75ec8deee46","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m-labs/artiq/pulls/1068/commits","review_comments_url":"https://api.github.com/repos/m-labs/artiq/pulls/1068/comments","review_comment_url":"https://api.github.com/repos/m-labs/artiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m-labs/artiq/issues/1068/comments","statuses_url":"https://api.github.com/repos/m-labs/artiq/statuses/2621782f8c6bcf05f0e0ca85df42704922e5945b","head":{"label":"hartytp:hmc830_tidy","ref":"hmc830_tidy","sha":"2621782f8c6bcf05f0e0ca85df42704922e5945b","user":{"login":"hartytp","id":21218399,"node_id":"MDQ6VXNlcjIxMjE4Mzk5","avatar_url":"https://avatars0.githubusercontent.com/u/21218399?v=4","gravatar_id":"","url":"https://api.github.com/users/hartytp","html_url":"https://github.com/hartytp","followers_url":"https://api.github.com/users/hartytp/followers","following_url":"https://api.github.com/users/hartytp/following{/other_user}","gists_url":"https://api.github.com/users/hartytp/gists{/gist_id}","starred_url":"https://api.github.com/users/hartytp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartytp/subscriptions","organizations_url":"https://api.github.com/users/hartytp/orgs","repos_url":"https://api.github.com/users/hartytp/repos","events_url":"https://api.github.com/users/hartytp/events{/privacy}","received_events_url":"https://api.github.com/users/hartytp/received_events","type":"User","site_admin":false},"repo":{"id":115832373,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU4MzIzNzM=","name":"artiq","full_name":"hartytp/artiq","owner":{"login":"hartytp","id":21218399,"node_id":"MDQ6VXNlcjIxMjE4Mzk5","avatar_url":"https://avatars0.githubusercontent.com/u/21218399?v=4","gravatar_id":"","url":"https://api.github.com/users/hartytp","html_url":"https://github.com/hartytp","followers_url":"https://api.github.com/users/hartytp/followers","following_url":"https://api.github.com/users/hartytp/following{/other_user}","gists_url":"https://api.github.com/users/hartytp/gists{/gist_id}","starred_url":"https://api.github.com/users/hartytp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartytp/subscriptions","organizations_url":"https://api.github.com/users/hartytp/orgs","repos_url":"https://api.github.com/users/hartytp/repos","events_url":"https://api.github.com/users/hartytp/events{/privacy}","received_events_url":"https://api.github.com/users/hartytp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hartytp/artiq","description":"Next-generation control system for quantum information experiments","fork":true,"url":"https://api.github.com/repos/hartytp/artiq","forks_url":"https://api.github.com/repos/hartytp/artiq/forks","keys_url":"https://api.github.com/repos/hartytp/artiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hartytp/artiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hartytp/artiq/teams","hooks_url":"https://api.github.com/repos/hartytp/artiq/hooks","issue_events_url":"https://api.github.com/repos/hartytp/artiq/issues/events{/number}","events_url":"https://api.github.com/repos/hartytp/artiq/events","assignees_url":"https://api.github.com/repos/hartytp/artiq/assignees{/user}","branches_url":"https://api.github.com/repos/hartytp/artiq/branches{/branch}","tags_url":"https://api.github.com/repos/hartytp/artiq/tags","blobs_url":"https://api.github.com/repos/hartytp/artiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hartytp/artiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hartytp/artiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/hartytp/artiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hartytp/artiq/statuses/{sha}","languages_url":"https://api.github.com/repos/hartytp/artiq/languages","stargazers_url":"https://api.github.com/repos/hartytp/artiq/stargazers","contributors_url":"https://api.github.com/repos/hartytp/artiq/contributors","subscribers_url":"https://api.github.com/repos/hartytp/artiq/subscribers","subscription_url":"https://api.github.com/repos/hartytp/artiq/subscription","commits_url":"https://api.github.com/repos/hartytp/artiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/hartytp/artiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/hartytp/artiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/hartytp/artiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/hartytp/artiq/contents/{+path}","compare_url":"https://api.github.com/repos/hartytp/artiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hartytp/artiq/merges","archive_url":"https://api.github.com/repos/hartytp/artiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hartytp/artiq/downloads","issues_url":"https://api.github.com/repos/hartytp/artiq/issues{/number}","pulls_url":"https://api.github.com/repos/hartytp/artiq/pulls{/number}","milestones_url":"https://api.github.com/repos/hartytp/artiq/milestones{/number}","notifications_url":"https://api.github.com/repos/hartytp/artiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hartytp/artiq/labels{/name}","releases_url":"https://api.github.com/repos/hartytp/artiq/releases{/id}","deployments_url":"https://api.github.com/repos/hartytp/artiq/deployments","created_at":"2017-12-31T00:04:15Z","updated_at":"2018-03-16T12:18:43Z","pushed_at":"2018-06-11T15:49:25Z","git_url":"git://github.com/hartytp/artiq.git","ssh_url":"git@github.com:hartytp/artiq.git","clone_url":"https://github.com/hartytp/artiq.git","svn_url":"https://github.com/hartytp/artiq","homepage":"https://m-labs.hk/artiq","size":11339,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"m-labs:master","ref":"master","sha":"0b086225a9ede6bd6a9fe8b8efe0056251554336","user":{"login":"m-labs","id":116047,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjA0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/116047?v=4","gravatar_id":"","url":"https://api.github.com/users/m-labs","html_url":"https://github.com/m-labs","followers_url":"https://api.github.com/users/m-labs/followers","following_url":"https://api.github.com/users/m-labs/following{/other_user}","gists_url":"https://api.github.com/users/m-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/m-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-labs/subscriptions","organizations_url":"https://api.github.com/users/m-labs/orgs","repos_url":"https://api.github.com/users/m-labs/repos","events_url":"https://api.github.com/users/m-labs/events{/privacy}","received_events_url":"https://api.github.com/users/m-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":20161671,"node_id":"MDEwOlJlcG9zaXRvcnkyMDE2MTY3MQ==","name":"artiq","full_name":"m-labs/artiq","owner":{"login":"m-labs","id":116047,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjA0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/116047?v=4","gravatar_id":"","url":"https://api.github.com/users/m-labs","html_url":"https://github.com/m-labs","followers_url":"https://api.github.com/users/m-labs/followers","following_url":"https://api.github.com/users/m-labs/following{/other_user}","gists_url":"https://api.github.com/users/m-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/m-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-labs/subscriptions","organizations_url":"https://api.github.com/users/m-labs/orgs","repos_url":"https://api.github.com/users/m-labs/repos","events_url":"https://api.github.com/users/m-labs/events{/privacy}","received_events_url":"https://api.github.com/users/m-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m-labs/artiq","description":"A leading-edge control system for quantum information experiments","fork":false,"url":"https://api.github.com/repos/m-labs/artiq","forks_url":"https://api.github.com/repos/m-labs/artiq/forks","keys_url":"https://api.github.com/repos/m-labs/artiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-labs/artiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-labs/artiq/teams","hooks_url":"https://api.github.com/repos/m-labs/artiq/hooks","issue_events_url":"https://api.github.com/repos/m-labs/artiq/issues/events{/number}","events_url":"https://api.github.com/repos/m-labs/artiq/events","assignees_url":"https://api.github.com/repos/m-labs/artiq/assignees{/user}","branches_url":"https://api.github.com/repos/m-labs/artiq/branches{/branch}","tags_url":"https://api.github.com/repos/m-labs/artiq/tags","blobs_url":"https://api.github.com/repos/m-labs/artiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-labs/artiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-labs/artiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-labs/artiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-labs/artiq/statuses/{sha}","languages_url":"https://api.github.com/repos/m-labs/artiq/languages","stargazers_url":"https://api.github.com/repos/m-labs/artiq/stargazers","contributors_url":"https://api.github.com/repos/m-labs/artiq/contributors","subscribers_url":"https://api.github.com/repos/m-labs/artiq/subscribers","subscription_url":"https://api.github.com/repos/m-labs/artiq/subscription","commits_url":"https://api.github.com/repos/m-labs/artiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-labs/artiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-labs/artiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-labs/artiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-labs/artiq/contents/{+path}","compare_url":"https://api.github.com/repos/m-labs/artiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-labs/artiq/merges","archive_url":"https://api.github.com/repos/m-labs/artiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-labs/artiq/downloads","issues_url":"https://api.github.com/repos/m-labs/artiq/issues{/number}","pulls_url":"https://api.github.com/repos/m-labs/artiq/pulls{/number}","milestones_url":"https://api.github.com/repos/m-labs/artiq/milestones{/number}","notifications_url":"https://api.github.com/repos/m-labs/artiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-labs/artiq/labels{/name}","releases_url":"https://api.github.com/repos/m-labs/artiq/releases{/id}","deployments_url":"https://api.github.com/repos/m-labs/artiq/deployments","created_at":"2014-05-25T18:09:36Z","updated_at":"2018-06-09T09:39:41Z","pushed_at":"2018-06-11T16:01:20Z","git_url":"git://github.com/m-labs/artiq.git","ssh_url":"git@github.com:m-labs/artiq.git","clone_url":"https://github.com/m-labs/artiq.git","svn_url":"https://github.com/m-labs/artiq","homepage":"https://m-labs.hk/artiq","size":11318,"stargazers_count":133,"watchers_count":133,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":46,"open_issues":135,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m-labs/artiq/pulls/1068"},"html":{"href":"https://github.com/m-labs/artiq/pull/1068"},"issue":{"href":"https://api.github.com/repos/m-labs/artiq/issues/1068"},"comments":{"href":"https://api.github.com/repos/m-labs/artiq/issues/1068/comments"},"review_comments":{"href":"https://api.github.com/repos/m-labs/artiq/pulls/1068/comments"},"review_comment":{"href":"https://api.github.com/repos/m-labs/artiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m-labs/artiq/pulls/1068/commits"},"statuses":{"href":"https://api.github.com/repos/m-labs/artiq/statuses/2621782f8c6bcf05f0e0ca85df42704922e5945b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jordens"}}