{"push_id":2845831975,"size":20,"distinct_size":20,"ref":"refs/heads/2018-04-rpc-getaddress","head":"c1316947e8070f666c924151f1c67b2cb6bbca7a","before":"e6a6cea8c8a4428741ff20910ce5eb7b9c118aa3","commits":[{"sha":"545e85eccc2441c6d7745bb90d88dc14718455a2","author":{"name":"Russell Yanofsky","email":"d1818e90f775d1fa111cabb0c1a59ce802530221@yanofsky.org"},"message":"Add AssertLockHeld assertions in CWallet::ListCoins","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/545e85eccc2441c6d7745bb90d88dc14718455a2"},{"sha":"41b88e93375d57db12da923f45f87b9a2db8e730","author":{"name":"Russell Yanofsky","email":"d1818e90f775d1fa111cabb0c1a59ce802530221@yanofsky.org"},"message":"Add unit test for DEBUG_LOCKORDER code","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/41b88e93375d57db12da923f45f87b9a2db8e730"},{"sha":"ba1f095aadf29bddb0bd8176d2e0b908f92a5623","author":{"name":"Russell Yanofsky","email":"d1818e90f775d1fa111cabb0c1a59ce802530221@yanofsky.org"},"message":"MOVEONLY Move AnnotatedMixin declaration\n\nMove AnnotatedMixin closer to where it's used, and after the DEBUG_LOCKORDER\nfunction declarations so it can call them.","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/ba1f095aadf29bddb0bd8176d2e0b908f92a5623"},{"sha":"1382913e61f5db6ba849b1e261e8aefcd5a1ae68","author":{"name":"Russell Yanofsky","email":"d1818e90f775d1fa111cabb0c1a59ce802530221@yanofsky.org"},"message":"Make LOCK, LOCK2, TRY_LOCK work with CWaitableCriticalSection\n\nThey should also work with any other mutex type which std::unique_lock\nsupports.\n\nThere is no change in behavior for current code that calls these macros with\nCCriticalSection mutexes.","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/1382913e61f5db6ba849b1e261e8aefcd5a1ae68"},{"sha":"9c4dc597ddc66acfd58a945a5ab11f833731abba","author":{"name":"Russell Yanofsky","email":"d1818e90f775d1fa111cabb0c1a59ce802530221@yanofsky.org"},"message":"Use LOCK macros for non-recursive locks\n\nInstead of std::unique_lock.","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/9c4dc597ddc66acfd58a945a5ab11f833731abba"},{"sha":"4c3c9c38699360f93d3c52a01a90ff15ee5e1a62","author":{"name":"practicalswift","email":"4a57785b02e7b752fc2eb7d1c97db94302a41bf7@users.noreply.github.com"},"message":"Don't assert(...) with side effects","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/4c3c9c38699360f93d3c52a01a90ff15ee5e1a62"},{"sha":"ca1a093127c11bb2aea10bf96c38dbfb40f8d170","author":{"name":"practicalswift","email":"4a57785b02e7b752fc2eb7d1c97db94302a41bf7@users.noreply.github.com"},"message":"Add regression test: Don't assert(...) with side effects","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/ca1a093127c11bb2aea10bf96c38dbfb40f8d170"},{"sha":"b602c9b3af284995d0f89b4c676f6f6c5316c9a2","author":{"name":"practicalswift","email":"4a57785b02e7b752fc2eb7d1c97db94302a41bf7@users.noreply.github.com"},"message":"tests: Add missing locking annotations and locks","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/b602c9b3af284995d0f89b4c676f6f6c5316c9a2"},{"sha":"62b6f0f21e24ff367d096c80ebdf398de4a98163","author":{"name":"Russell Yanofsky","email":"d1818e90f775d1fa111cabb0c1a59ce802530221@yanofsky.org"},"message":"Add EXCLUSIVE_LOCKS_REQUIRED to CWallet::ListCoins\n\nSuggested by MarcoFalke <falke.marco@gmail.com> in\nhttps://github.com/bitcoin/bitcoin/pull/10605#issuecomment-417643535","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/62b6f0f21e24ff367d096c80ebdf398de4a98163"},{"sha":"bdbd654df8ddf5945256f2ccf85feae620f6f0d5","author":{"name":"MarcoFalke","email":"94662c316543fb349a23cc41ada52e5549f80958@gmail.com"},"message":"Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans)\n\nb602c9b3af tests: Add missing locking annotations and locks (practicalswift)\n\nPull request description:\n\n  Add missing locking annotations and locks.\n\n  `mapOrphanTransactions` is guarded by `g_cs_orphans`.\n\nTree-SHA512: f95104fbef23bd385e754c6bea3c3bdddd8a9c6a68e719d761227c9be1e46ff1316ec050a15a1243218dbab4e8584da6674f4a72f949f54b0a758392f19c83f8","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/bdbd654df8ddf5945256f2ccf85feae620f6f0d5"},{"sha":"709a15b0a6f8ca421b6bb1fcb31c58fd7d7e3b68","author":{"name":"Wladimir J. van der Laan","email":"bbc07dc96bb50bf6868a2ddfc4dae14fbed703d9@gmail.com"},"message":"Merge #14088: tests: Don't assert(...) with side effects\n\nca1a093127c11bb2aea10bf96c38dbfb40f8d170 Add regression test: Don't assert(...) with side effects (practicalswift)\n4c3c9c38699360f93d3c52a01a90ff15ee5e1a62 Don't assert(...) with side effects (practicalswift)\n\nPull request description:\n\n  Don't `assert(...)` with side effects.\n\n  From the developer notes:\n\n  > **Assertions should not have side-effects**\n  >\n  > Rationale: Even though the source code is set to refuse to compile with assertions disabled, having side-effects in assertions is unexpected and makes the code harder to understand\n\n  These assertions were introduced quite recently (in #14069 which was merged two days ago) and since this is a recurring thing (see #13534 – \"Don't assert(foo()) where foo() has side effects\" from May) I added a simple regression test for the most obvious common side effect.\n\nTree-SHA512: be65db9d8d5d0f5752152ba73fe3fbb0531880f156d3cd7dfdf1752709979b63214e46ae64b1adbe1e09fa121278f4087f4ae49bff16cf8f5aec16ea6bde3650","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/709a15b0a6f8ca421b6bb1fcb31c58fd7d7e3b68"},{"sha":"b012bbe358311cc4a73300ccca41b64272250277","author":{"name":"MarcoFalke","email":"94662c316543fb349a23cc41ada52e5549f80958@gmail.com"},"message":"Merge #10605: Add AssertLockHeld assertions in CWallet::ListCoins\n\n62b6f0f21e Add EXCLUSIVE_LOCKS_REQUIRED to CWallet::ListCoins (Russell Yanofsky)\n545e85eccc Add AssertLockHeld assertions in CWallet::ListCoins (Russell Yanofsky)\n\nPull request description:\n\n  Fixes TODO from #10295\n\nTree-SHA512: 2dd03a8217e5e1313aa2119cb530e0c0daf3ae3a751b6fdec611df57b8090201a90b52ff05f8f696e978a1344aaf21989d67a03beb5ef6ef79b77be38d04b451","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/b012bbe358311cc4a73300ccca41b64272250277"},{"sha":"fb97437efa06acfbe75a5e34d8bbf8388d5f6432","author":{"name":"Jordan Baczuk","email":"c65d2ceb40285eaecaefa4530bc6907a64cca4cd@gmail.com"},"message":"added note that control port must be enabled and how to do that in torrc config file","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/fb97437efa06acfbe75a5e34d8bbf8388d5f6432"},{"sha":"190bf62be1214b072513c7fd7e01cc191723967c","author":{"name":"Russell Yanofsky","email":"d1818e90f775d1fa111cabb0c1a59ce802530221@yanofsky.org"},"message":"scripted-diff: Small locking rename\n\nCall sync.h primitives \"locks\" and \"mutexes\" instead of \"blocks\" and \"waitable\ncritical sections\" to match current coding conventions and c++11 standard\nnames.\n\nThis PR does not rename the \"CCriticalSection\" class (though this could be done\nas a followup) because it is used everywhere and would swamp the other changes\nin this PR. Plain mutexes should mostly be preferred instead of recursive\nmutexes in new code anyway.\n\n-BEGIN VERIFY SCRIPT-\nset -x\nset -e\nren() { git grep -l $1 | xargs sed -i s/$1/$2/; }\nren CCriticalBlock           UniqueLock\nren CWaitableCriticalSection Mutex\nren CConditionVariable       std::condition_variable\nren cs_GenesisWait           g_genesis_wait_mutex\nren condvar_GenesisWait      g_genesis_wait_cv\nperl -0777 -pi -e 's/.*typedef.*condition_variable.*\\n\\n?//g' src/sync.h\n-END VERIFY SCRIPT-","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/190bf62be1214b072513c7fd7e01cc191723967c"},{"sha":"385ad110400bc9646dcf2e38b64b7080182a7344","author":{"name":"Wladimir J. van der Laan","email":"bbc07dc96bb50bf6868a2ddfc4dae14fbed703d9@gmail.com"},"message":"Merge #11640: Make LOCK, LOCK2, TRY_LOCK work with CWaitableCriticalSection\n\n9c4dc597ddc66acfd58a945a5ab11f833731abba Use LOCK macros for non-recursive locks (Russell Yanofsky)\n1382913e61f5db6ba849b1e261e8aefcd5a1ae68 Make LOCK, LOCK2, TRY_LOCK work with CWaitableCriticalSection (Russell Yanofsky)\nba1f095aadf29bddb0bd8176d2e0b908f92a5623 MOVEONLY Move AnnotatedMixin declaration (Russell Yanofsky)\n41b88e93375d57db12da923f45f87b9a2db8e730 Add unit test for DEBUG_LOCKORDER code (Russell Yanofsky)\n\nPull request description:\n\n  Make LOCK macros work with non-recursive mutexes, and use wherever possible for better deadlock detection.\n\n  Also add unit test for DEBUG_LOCKORDER code.\n\nTree-SHA512: 64ef209307f28ecd0813a283f15c6406138c6ffe7f6cbbd084161044db60e2c099a7d0d2edcd1c5e7770a115e9b931b486e86c9a777bdc96d2e8a9f4dc192942","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/385ad110400bc9646dcf2e38b64b7080182a7344"},{"sha":"59ecacfc84af13e5a1608e7d970315d07dcb0269","author":{"name":"Wladimir J. van der Laan","email":"bbc07dc96bb50bf6868a2ddfc4dae14fbed703d9@gmail.com"},"message":"Merge #11599: scripted-diff: Small locking rename\n\n190bf62be1214b072513c7fd7e01cc191723967c scripted-diff: Small locking rename (Russell Yanofsky)\n\nPull request description:\n\n  Call sync.h primitives \"locks\" and \"mutexes\" instead of \"blocks\" and \"waitable critical sections\" to match current coding conventions and c++11 standard names.\n\n  This PR does not rename the \"CCriticalSection\" class (though this could be done as a followup) because it's used everywhere and would swamp the other changes in this PR. Plain mutexes should mostly be preferred instead of recursive mutexes in new code anyway.\n\nTree-SHA512: 39b5b2be8f7a98227be8ab0648bdbb1b620944659bdc1eb9a15b0fcc0c930457fa0c03170cfedaeee0007ea716c526b31a8d84a86dd2333ce9d8bfabd773fe45","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/59ecacfc84af13e5a1608e7d970315d07dcb0269"},{"sha":"8dfc2f30dea6bde0f74d23691377f248966011ab","author":{"name":"Kvaciral","email":"b53ae9068c6f7ac595e110bd0213621fdfda04ea@protonmail.com"},"message":"Test rpc_help.py failed: Check whether ZMQ is enabled or not.","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/8dfc2f30dea6bde0f74d23691377f248966011ab"},{"sha":"2070a545e2c4e8c2dff4c0fb40b8fd2f68fc2cad","author":{"name":"Wladimir J. van der Laan","email":"bbc07dc96bb50bf6868a2ddfc4dae14fbed703d9@gmail.com"},"message":"Merge #14122: Test rpc_help.py failed: Check whether ZMQ is enabled or not.\n\n8dfc2f30dea6bde0f74d23691377f248966011ab Test rpc_help.py failed: Check whether ZMQ is enabled or not. (Kvaciral)\n\nPull request description:\n\n  /test/functional/rpc_help.py checks for the zmq-category even while zmq may be disabled (in /test/config.ini) , I have added a check function to test_framework.py that can be used whether to determine to include zmq in a test or not.\n\nTree-SHA512: 6819050277e2dc875f8d9bf49a02291555cb7b301379dfb9d898e6d8e14bfb8eeb6bef8af46d07b5db45b2fe281b35ea7f98af9ffba703768658a69addbc81b1","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/2070a545e2c4e8c2dff4c0fb40b8fd2f68fc2cad"},{"sha":"68f3c7eb080e461cfeac37f8db7034fe507241d0","author":{"name":"Wladimir J. van der Laan","email":"bbc07dc96bb50bf6868a2ddfc4dae14fbed703d9@gmail.com"},"message":"Merge #14120: Notes about control port and read access to cookie\n\nfb97437efa06acfbe75a5e34d8bbf8388d5f6432 added note that control port must be enabled and how to do that in torrc config file (Jordan Baczuk)\n\nPull request description:\n\n  Reopened from #13681 because pushes made it unable to reopen.\n\nTree-SHA512: 34eac14308aef70963b630173cd93916201553d5323ab2de3517d4a78604ae5a7cf8691a314c0af00fe36f0ef19b94a4c371d2e7aa1229d9c603d36c51b115fb","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/68f3c7eb080e461cfeac37f8db7034fe507241d0"},{"sha":"c1316947e8070f666c924151f1c67b2cb6bbca7a","author":{"name":"chris-belcher","email":"0bac86f5ebfcbbe4a8fc0c713530eb679f88941b@users.noreply.github.com"},"message":"[rpc] Add getnodeaddresses RPC command\n\nNew getnodeaddresses call gives access via RPC to the peers known by\nthe node. It may be useful for bitcoin wallets to broadcast their\ntransactions over tor for improved privacy without using the\ncentralized DNS seeds. getnodeaddresses is very similar to the getaddr\np2p method.\n\nTests the new rpc call by feeding IP address to a test node via the p2p\nprotocol, then obtaining someone of those addresses with\ngetnodeaddresses and checking that they are a subset.","distinct":true,"url":"https://api.github.com/repos/chris-belcher/bitcoin/commits/c1316947e8070f666c924151f1c67b2cb6bbca7a"}]}
{"actor":{"display_login":"chris-belcher"}}