{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/comments/227981415","pull_request_review_id":168146488,"id":227981415,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzk4MTQxNQ==","diff_hunk":"@@ -45,7 +45,7 @@ internal MsalAccessTokenCacheItem()\n         internal MsalAccessTokenCacheItem\n             (string environment, string clientId, MsalTokenResponse response, string tenantId) :\n \n-            this(environment, clientId, response.TokenType, ScopeHelper.ConvertStringToLowercaseSortedSet(response.Scope).AsSingleString(),\n+            this(environment, clientId, response.TokenType, response.Scope,","path":"core/src/Cache/Items/MsalAccessTokenCacheItem.cs","position":5,"original_position":5,"commit_id":"cc222beb1099b5f150b5083a1ce40d1a6197603b","original_commit_id":"cc222beb1099b5f150b5083a1ce40d1a6197603b","user":{"login":"SomkaPe","id":21348914,"node_id":"MDQ6VXNlcjIxMzQ4OTE0","avatar_url":"https://avatars3.githubusercontent.com/u/21348914?v=4","gravatar_id":"","url":"https://api.github.com/users/SomkaPe","html_url":"https://github.com/SomkaPe","followers_url":"https://api.github.com/users/SomkaPe/followers","following_url":"https://api.github.com/users/SomkaPe/following{/other_user}","gists_url":"https://api.github.com/users/SomkaPe/gists{/gist_id}","starred_url":"https://api.github.com/users/SomkaPe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SomkaPe/subscriptions","organizations_url":"https://api.github.com/users/SomkaPe/orgs","repos_url":"https://api.github.com/users/SomkaPe/repos","events_url":"https://api.github.com/users/SomkaPe/events{/privacy}","received_events_url":"https://api.github.com/users/SomkaPe/received_events","type":"User","site_admin":false},"body":"according to schema scopes should be stored as returned from sts","created_at":"2018-10-24T22:29:18Z","updated_at":"2018-10-24T22:29:18Z","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1350#discussion_r227981415","pull_request_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1350","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/comments/227981415"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1350#discussion_r227981415"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1350"}},"in_reply_to_id":227930185},"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1350","id":225507684,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTA3Njg0","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1350","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1350.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1350.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1350","number":1350,"state":"open","locked":false,"title":"cache format tests + format  changes ","user":{"login":"SomkaPe","id":21348914,"node_id":"MDQ6VXNlcjIxMzQ4OTE0","avatar_url":"https://avatars3.githubusercontent.com/u/21348914?v=4","gravatar_id":"","url":"https://api.github.com/users/SomkaPe","html_url":"https://github.com/SomkaPe","followers_url":"https://api.github.com/users/SomkaPe/followers","following_url":"https://api.github.com/users/SomkaPe/following{/other_user}","gists_url":"https://api.github.com/users/SomkaPe/gists{/gist_id}","starred_url":"https://api.github.com/users/SomkaPe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SomkaPe/subscriptions","organizations_url":"https://api.github.com/users/SomkaPe/orgs","repos_url":"https://api.github.com/users/SomkaPe/repos","events_url":"https://api.github.com/users/SomkaPe/events{/privacy}","received_events_url":"https://api.github.com/users/SomkaPe/received_events","type":"User","site_admin":false},"body":"Cache format tests\r\n\r\nWhile writing cache format test some cache format inconsistencies with current version of unified schema were found:\r\n1. Timestamps should be stored as strings in Json\r\n2. It was decided to not store client_info(which is optional field) in all cache entities  - just in account\r\n3. Credential Type field should be Case sensitive\r\n4. Keys of cache entities should be in lower case\r\n5. Scopes should not be stored in sorted form, instead should be  stored as is (as returned from STS)\r\n6. Change \"preferred_username not in id_token\" to \"Missing from the token response\"\r\n\r\nOthers:\r\n\r\n1. Persisting given_name and family_name optional claims in account cache entity\r\n2. Fixing issue of client_info misuse:\r\n  2.1. AccounId is derived from ClientInfo (Not opposite way - ClientInfo can not be recreated from accountId, it can contains more fields )\r\n  2.2. Some code was written based on assumption that client info is always persisted with cache entities, which is wrong because it is optional field, so some library can not persist it.\r\n \r\n","created_at":"2018-10-24T18:37:00Z","updated_at":"2018-10-24T22:29:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"228378554d532def9acfb900a8190e40d51db3a1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MarkZuber","id":7103178,"node_id":"MDQ6VXNlcjcxMDMxNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7103178?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkZuber","html_url":"https://github.com/MarkZuber","followers_url":"https://api.github.com/users/MarkZuber/followers","following_url":"https://api.github.com/users/MarkZuber/following{/other_user}","gists_url":"https://api.github.com/users/MarkZuber/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkZuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkZuber/subscriptions","organizations_url":"https://api.github.com/users/MarkZuber/orgs","repos_url":"https://api.github.com/users/MarkZuber/repos","events_url":"https://api.github.com/users/MarkZuber/events{/privacy}","received_events_url":"https://api.github.com/users/MarkZuber/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1350/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1350/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1350/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/cc222beb1099b5f150b5083a1ce40d1a6197603b","head":{"label":"AzureAD:somkape/cacheFormatTest","ref":"somkape/cacheFormatTest","sha":"cc222beb1099b5f150b5083a1ce40d1a6197603b","user":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":19123031,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEyMzAzMQ==","name":"azure-activedirectory-library-for-dotnet","full_name":"AzureAD/azure-activedirectory-library-for-dotnet","private":false,"owner":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","description":"ADAL and MSAL authentication libraries for .net","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/deployments","created_at":"2014-04-24T20:29:51Z","updated_at":"2018-10-24T09:55:51Z","pushed_at":"2018-10-24T22:23:53Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-dotnet.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","homepage":"http://aka.ms/aaddev","size":13657,"stargazers_count":227,"watchers_count":227,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":177,"open_issues":58,"watchers":227,"default_branch":"dev"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"927cd16245650b4b8ff6dfd763f18857d2bb8ab7","user":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":19123031,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEyMzAzMQ==","name":"azure-activedirectory-library-for-dotnet","full_name":"AzureAD/azure-activedirectory-library-for-dotnet","private":false,"owner":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","description":"ADAL and MSAL authentication libraries for .net","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/deployments","created_at":"2014-04-24T20:29:51Z","updated_at":"2018-10-24T09:55:51Z","pushed_at":"2018-10-24T22:23:53Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-dotnet.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","homepage":"http://aka.ms/aaddev","size":13657,"stargazers_count":227,"watchers_count":227,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":177,"open_issues":58,"watchers":227,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1350"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1350"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1350"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1350/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1350/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1350/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/cc222beb1099b5f150b5083a1ce40d1a6197603b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SomkaPe"}}