{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments/199224126","pull_request_review_id":133306535,"id":199224126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTIyNDEyNg==","diff_hunk":"@@ -0,0 +1,61 @@\n+/*\n+ * Copyright 2018 Google\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+#include \"Firestore/core/src/firebase/firestore/core/query.h\"\n+\n+#include \"Firestore/core/src/firebase/firestore/model/document_key.h\"","path":"Firestore/core/src/firebase/firestore/core/query.cc","position":19,"original_position":19,"commit_id":"65d1f943effa537f78dcfa51f20623de03f1bf83","original_commit_id":"65d1f943effa537f78dcfa51f20623de03f1bf83","user":{"login":"wilhuff","id":10249104,"node_id":"MDQ6VXNlcjEwMjQ5MTA0","avatar_url":"https://avatars1.githubusercontent.com/u/10249104?v=4","gravatar_id":"","url":"https://api.github.com/users/wilhuff","html_url":"https://github.com/wilhuff","followers_url":"https://api.github.com/users/wilhuff/followers","following_url":"https://api.github.com/users/wilhuff/following{/other_user}","gists_url":"https://api.github.com/users/wilhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhuff/subscriptions","organizations_url":"https://api.github.com/users/wilhuff/orgs","repos_url":"https://api.github.com/users/wilhuff/repos","events_url":"https://api.github.com/users/wilhuff/events{/privacy}","received_events_url":"https://api.github.com/users/wilhuff/received_events","type":"User","site_admin":false},"body":"I'm fine either way. Note that cpplint includes logic to detect this case, but only handles the first order headers directly included from the class header.\r\n\r\nI'd like to be able to articulate a simple rule and then delegate that to tooling so I don't have to think about it in reviews. Maybe I'll just remove that logic from cpplint and call it a day.","created_at":"2018-06-29T17:09:08Z","updated_at":"2018-06-29T17:15:05Z","html_url":"https://github.com/firebase/firebase-ios-sdk/pull/1471#discussion_r199224126","pull_request_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1471","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments/199224126"},"html":{"href":"https://github.com/firebase/firebase-ios-sdk/pull/1471#discussion_r199224126"},"pull_request":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1471"}},"in_reply_to_id":199208354},"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1471","id":198055447,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDU1NDQ3","html_url":"https://github.com/firebase/firebase-ios-sdk/pull/1471","diff_url":"https://github.com/firebase/firebase-ios-sdk/pull/1471.diff","patch_url":"https://github.com/firebase/firebase-ios-sdk/pull/1471.patch","issue_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1471","number":1471,"state":"open","locked":false,"title":"Initial (incomplete) implementation of f:f::core::Query","user":{"login":"rsgowman","id":11047174,"node_id":"MDQ6VXNlcjExMDQ3MTc0","avatar_url":"https://avatars2.githubusercontent.com/u/11047174?v=4","gravatar_id":"","url":"https://api.github.com/users/rsgowman","html_url":"https://github.com/rsgowman","followers_url":"https://api.github.com/users/rsgowman/followers","following_url":"https://api.github.com/users/rsgowman/following{/other_user}","gists_url":"https://api.github.com/users/rsgowman/gists{/gist_id}","starred_url":"https://api.github.com/users/rsgowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsgowman/subscriptions","organizations_url":"https://api.github.com/users/rsgowman/orgs","repos_url":"https://api.github.com/users/rsgowman/repos","events_url":"https://api.github.com/users/rsgowman/events{/privacy}","received_events_url":"https://api.github.com/users/rsgowman/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-28T14:48:27Z","updated_at":"2018-06-29T17:15:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"208fa6e20d6e1203c7b6e7129989927fa5f95bd0","assignee":{"login":"rsgowman","id":11047174,"node_id":"MDQ6VXNlcjExMDQ3MTc0","avatar_url":"https://avatars2.githubusercontent.com/u/11047174?v=4","gravatar_id":"","url":"https://api.github.com/users/rsgowman","html_url":"https://github.com/rsgowman","followers_url":"https://api.github.com/users/rsgowman/followers","following_url":"https://api.github.com/users/rsgowman/following{/other_user}","gists_url":"https://api.github.com/users/rsgowman/gists{/gist_id}","starred_url":"https://api.github.com/users/rsgowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsgowman/subscriptions","organizations_url":"https://api.github.com/users/rsgowman/orgs","repos_url":"https://api.github.com/users/rsgowman/repos","events_url":"https://api.github.com/users/rsgowman/events{/privacy}","received_events_url":"https://api.github.com/users/rsgowman/received_events","type":"User","site_admin":false},"assignees":[{"login":"rsgowman","id":11047174,"node_id":"MDQ6VXNlcjExMDQ3MTc0","avatar_url":"https://avatars2.githubusercontent.com/u/11047174?v=4","gravatar_id":"","url":"https://api.github.com/users/rsgowman","html_url":"https://github.com/rsgowman","followers_url":"https://api.github.com/users/rsgowman/followers","following_url":"https://api.github.com/users/rsgowman/following{/other_user}","gists_url":"https://api.github.com/users/rsgowman/gists{/gist_id}","starred_url":"https://api.github.com/users/rsgowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsgowman/subscriptions","organizations_url":"https://api.github.com/users/rsgowman/orgs","repos_url":"https://api.github.com/users/rsgowman/repos","events_url":"https://api.github.com/users/rsgowman/events{/privacy}","received_events_url":"https://api.github.com/users/rsgowman/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zxu123","id":26017994,"node_id":"MDQ6VXNlcjI2MDE3OTk0","avatar_url":"https://avatars1.githubusercontent.com/u/26017994?v=4","gravatar_id":"","url":"https://api.github.com/users/zxu123","html_url":"https://github.com/zxu123","followers_url":"https://api.github.com/users/zxu123/followers","following_url":"https://api.github.com/users/zxu123/following{/other_user}","gists_url":"https://api.github.com/users/zxu123/gists{/gist_id}","starred_url":"https://api.github.com/users/zxu123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxu123/subscriptions","organizations_url":"https://api.github.com/users/zxu123/orgs","repos_url":"https://api.github.com/users/zxu123/repos","events_url":"https://api.github.com/users/zxu123/events{/privacy}","received_events_url":"https://api.github.com/users/zxu123/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":713434153,"node_id":"MDU6TGFiZWw3MTM0MzQxNTM=","url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels/Firestore","name":"Firestore","color":"c5def5","default":false},{"id":658858759,"node_id":"MDU6TGFiZWw2NTg4NTg3NTk=","url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1471/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1471/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1471/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/65d1f943effa537f78dcfa51f20623de03f1bf83","head":{"label":"firebase:rsgowman/query1","ref":"rsgowman/query1","sha":"65d1f943effa537f78dcfa51f20623de03f1bf83","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89033556,"node_id":"MDEwOlJlcG9zaXRvcnk4OTAzMzU1Ng==","name":"firebase-ios-sdk","full_name":"firebase/firebase-ios-sdk","owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-ios-sdk","description":"Firebase iOS SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/deployments","created_at":"2017-04-22T00:26:50Z","updated_at":"2018-06-29T15:40:46Z","pushed_at":"2018-06-29T15:40:41Z","git_url":"git://github.com/firebase/firebase-ios-sdk.git","ssh_url":"git@github.com:firebase/firebase-ios-sdk.git","clone_url":"https://github.com/firebase/firebase-ios-sdk.git","svn_url":"https://github.com/firebase/firebase-ios-sdk","homepage":"https://firebase.google.com","size":10965,"stargazers_count":732,"watchers_count":732,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":146,"open_issues":84,"watchers":732,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"8d399c78bda9529832d6ecd70a6c4c564c62da6d","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89033556,"node_id":"MDEwOlJlcG9zaXRvcnk4OTAzMzU1Ng==","name":"firebase-ios-sdk","full_name":"firebase/firebase-ios-sdk","owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-ios-sdk","description":"Firebase iOS SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/deployments","created_at":"2017-04-22T00:26:50Z","updated_at":"2018-06-29T15:40:46Z","pushed_at":"2018-06-29T15:40:41Z","git_url":"git://github.com/firebase/firebase-ios-sdk.git","ssh_url":"git@github.com:firebase/firebase-ios-sdk.git","clone_url":"https://github.com/firebase/firebase-ios-sdk.git","svn_url":"https://github.com/firebase/firebase-ios-sdk","homepage":"https://firebase.google.com","size":10965,"stargazers_count":732,"watchers_count":732,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":146,"open_issues":84,"watchers":732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1471"},"html":{"href":"https://github.com/firebase/firebase-ios-sdk/pull/1471"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1471"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1471/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1471/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1471/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/65d1f943effa537f78dcfa51f20623de03f1bf83"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"wilhuff"}}