{"action":"created","comment":{"url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/comments/189440722","pull_request_review_id":121625367,"id":189440722,"diff_hunk":"@@ -266,13 +266,13 @@ _install_metrics_agent() {\n   local ctxDir=${1:-BUILD_DIR}\n   local curDir=${JVM_COMMON_DIR:-$(cd $(dirname ${BASH_SOURCE[0]}) && cd .. && pwd )}\n   local binDir=\"${ctxDir}/.heroku/bin/\"\n-  local agent_jar=\"${binDir}/heroku-metrics-agent.jar\"\n+  local agent_jar=\"${binDir}/heroku-jvm-metrics-agent.jar\"\n \n   mkdir -p ${binDir}\n   curl --retry 3 -s -o ${agent_jar} \\\n       -L ${HEROKU_METRICS_JAR_URL:-\"https://repo1.maven.org/maven2/com/heroku/agent/heroku-java-metrics-agent/3.7/heroku-java-metrics-agent-3.7.jar\"}\n   [ ! -f ${agent_jar} ] && warning_inline \"failed to install metrics agent!\"\n \n   mkdir -p ${ctxDir}/.profile.d\n-  cp $curDir/opt/heroku-metrics-daemon.sh $ctxDir/.profile.d/","path":"bin/java","position":13,"original_position":13,"commit_id":"d4f8c5ac3a31a8795baa907fd4ef198f18d8ad1e","original_commit_id":"d4f8c5ac3a31a8795baa907fd4ef198f18d8ad1e","user":{"login":"freeformz","id":103,"avatar_url":"https://avatars0.githubusercontent.com/u/103?v=4","gravatar_id":"","url":"https://api.github.com/users/freeformz","html_url":"https://github.com/freeformz","followers_url":"https://api.github.com/users/freeformz/followers","following_url":"https://api.github.com/users/freeformz/following{/other_user}","gists_url":"https://api.github.com/users/freeformz/gists{/gist_id}","starred_url":"https://api.github.com/users/freeformz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeformz/subscriptions","organizations_url":"https://api.github.com/users/freeformz/orgs","repos_url":"https://api.github.com/users/freeformz/repos","events_url":"https://api.github.com/users/freeformz/events{/privacy}","received_events_url":"https://api.github.com/users/freeformz/received_events","type":"User","site_admin":false},"body":"Suggestion: Because this script no longer runs a daemon, drop that from the name. Maybe something like: `heroku-jvm-metrics-options.sh` since it sets options/flags for the jvm?","created_at":"2018-05-19T17:55:00Z","updated_at":"2018-05-19T17:55:01Z","html_url":"https://github.com/heroku/heroku-buildpack-jvm-common/pull/56#discussion_r189440722","pull_request_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/56","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/comments/189440722"},"html":{"href":"https://github.com/heroku/heroku-buildpack-jvm-common/pull/56#discussion_r189440722"},"pull_request":{"href":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/56","id":188870030,"html_url":"https://github.com/heroku/heroku-buildpack-jvm-common/pull/56","diff_url":"https://github.com/heroku/heroku-buildpack-jvm-common/pull/56.diff","patch_url":"https://github.com/heroku/heroku-buildpack-jvm-common/pull/56.patch","issue_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/issues/56","number":56,"state":"closed","locked":false,"title":"Renamed metrics script","user":{"login":"jkutner","id":1589,"avatar_url":"https://avatars0.githubusercontent.com/u/1589?v=4","gravatar_id":"","url":"https://api.github.com/users/jkutner","html_url":"https://github.com/jkutner","followers_url":"https://api.github.com/users/jkutner/followers","following_url":"https://api.github.com/users/jkutner/following{/other_user}","gists_url":"https://api.github.com/users/jkutner/gists{/gist_id}","starred_url":"https://api.github.com/users/jkutner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkutner/subscriptions","organizations_url":"https://api.github.com/users/jkutner/orgs","repos_url":"https://api.github.com/users/jkutner/repos","events_url":"https://api.github.com/users/jkutner/events{/privacy}","received_events_url":"https://api.github.com/users/jkutner/received_events","type":"User","site_admin":false},"body":"Prevents a conflict with the script installed by https://github.com/heroku/heroku-buildpack-metrics","created_at":"2018-05-17T21:45:59Z","updated_at":"2018-05-19T17:55:01Z","closed_at":"2018-05-17T22:28:06Z","merged_at":"2018-05-17T22:28:05Z","merge_commit_sha":"d5a2e0198c483225875afd89a3270adff1a37200","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/56/commits","review_comments_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/56/comments","review_comment_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/issues/56/comments","statuses_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/statuses/d4f8c5ac3a31a8795baa907fd4ef198f18d8ad1e","head":{"label":"heroku:rename-metrics-script","ref":"rename-metrics-script","sha":"d4f8c5ac3a31a8795baa907fd4ef198f18d8ad1e","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":5517201,"name":"heroku-buildpack-jvm-common","full_name":"heroku/heroku-buildpack-jvm-common","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/heroku-buildpack-jvm-common","description":"Common utils for JVM buildpacks","fork":false,"url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common","forks_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/forks","keys_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/teams","hooks_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/hooks","issue_events_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/events","assignees_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/tags","blobs_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/languages","stargazers_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/stargazers","contributors_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/contributors","subscribers_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/subscribers","subscription_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/subscription","commits_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/merges","archive_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/downloads","issues_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/labels{/name}","releases_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/deployments","created_at":"2012-08-23T00:35:24Z","updated_at":"2018-05-17T22:28:07Z","pushed_at":"2018-05-17T22:28:09Z","git_url":"git://github.com/heroku/heroku-buildpack-jvm-common.git","ssh_url":"git@github.com:heroku/heroku-buildpack-jvm-common.git","clone_url":"https://github.com/heroku/heroku-buildpack-jvm-common.git","svn_url":"https://github.com/heroku/heroku-buildpack-jvm-common","homepage":null,"size":251,"stargazers_count":17,"watchers_count":17,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":33,"open_issues":2,"watchers":17,"default_branch":"master"}},"base":{"label":"heroku:master","ref":"master","sha":"6138957b1c4274325076cc11a133e0de14a42e99","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":5517201,"name":"heroku-buildpack-jvm-common","full_name":"heroku/heroku-buildpack-jvm-common","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/heroku-buildpack-jvm-common","description":"Common utils for JVM buildpacks","fork":false,"url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common","forks_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/forks","keys_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/teams","hooks_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/hooks","issue_events_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/events","assignees_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/tags","blobs_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/languages","stargazers_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/stargazers","contributors_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/contributors","subscribers_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/subscribers","subscription_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/subscription","commits_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/merges","archive_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/downloads","issues_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/labels{/name}","releases_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/deployments","created_at":"2012-08-23T00:35:24Z","updated_at":"2018-05-17T22:28:07Z","pushed_at":"2018-05-17T22:28:09Z","git_url":"git://github.com/heroku/heroku-buildpack-jvm-common.git","ssh_url":"git@github.com:heroku/heroku-buildpack-jvm-common.git","clone_url":"https://github.com/heroku/heroku-buildpack-jvm-common.git","svn_url":"https://github.com/heroku/heroku-buildpack-jvm-common","homepage":null,"size":251,"stargazers_count":17,"watchers_count":17,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":33,"open_issues":2,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/56"},"html":{"href":"https://github.com/heroku/heroku-buildpack-jvm-common/pull/56"},"issue":{"href":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/issues/56"},"comments":{"href":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/heroku/heroku-buildpack-jvm-common/statuses/d4f8c5ac3a31a8795baa907fd4ef198f18d8ad1e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"freeformz"}}