{"action":"created","issue":{"url":"https://api.github.com/repos/coveo/react-vapor/issues/831","repository_url":"https://api.github.com/repos/coveo/react-vapor","labels_url":"https://api.github.com/repos/coveo/react-vapor/issues/831/labels{/name}","comments_url":"https://api.github.com/repos/coveo/react-vapor/issues/831/comments","events_url":"https://api.github.com/repos/coveo/react-vapor/issues/831/events","html_url":"https://github.com/coveo/react-vapor/pull/831","id":364128113,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MzkxMDkz","number":831,"title":"Fix INavigationChildrenProps's onPerPageClick","user":{"login":"tommy-tran","id":3431602,"node_id":"MDQ6VXNlcjM0MzE2MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3431602?v=4","gravatar_id":"","url":"https://api.github.com/users/tommy-tran","html_url":"https://github.com/tommy-tran","followers_url":"https://api.github.com/users/tommy-tran/followers","following_url":"https://api.github.com/users/tommy-tran/following{/other_user}","gists_url":"https://api.github.com/users/tommy-tran/gists{/gist_id}","starred_url":"https://api.github.com/users/tommy-tran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommy-tran/subscriptions","organizations_url":"https://api.github.com/users/tommy-tran/orgs","repos_url":"https://api.github.com/users/tommy-tran/repos","events_url":"https://api.github.com/users/tommy-tran/events{/privacy}","received_events_url":"https://api.github.com/users/tommy-tran/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-26T17:09:35Z","updated_at":"2018-09-26T17:16:30Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coveo/react-vapor/pulls/831","html_url":"https://github.com/coveo/react-vapor/pull/831","diff_url":"https://github.com/coveo/react-vapor/pull/831.diff","patch_url":"https://github.com/coveo/react-vapor/pull/831.patch"},"body":"Not sure if currentPerPage and currentPage are necessary here(I was thinking it could possibly be just newPerPage?) but they are used within NavigationPerPage. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/coveo/react-vapor/issues/comments/424798627","html_url":"https://github.com/coveo/react-vapor/pull/831#issuecomment-424798627","issue_url":"https://api.github.com/repos/coveo/react-vapor/issues/831","id":424798627,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDc5ODYyNw==","user":{"login":"GermainBergeron","id":260007,"node_id":"MDQ6VXNlcjI2MDAwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/260007?v=4","gravatar_id":"","url":"https://api.github.com/users/GermainBergeron","html_url":"https://github.com/GermainBergeron","followers_url":"https://api.github.com/users/GermainBergeron/followers","following_url":"https://api.github.com/users/GermainBergeron/following{/other_user}","gists_url":"https://api.github.com/users/GermainBergeron/gists{/gist_id}","starred_url":"https://api.github.com/users/GermainBergeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GermainBergeron/subscriptions","organizations_url":"https://api.github.com/users/GermainBergeron/orgs","repos_url":"https://api.github.com/users/GermainBergeron/repos","events_url":"https://api.github.com/users/GermainBergeron/events{/privacy}","received_events_url":"https://api.github.com/users/GermainBergeron/received_events","type":"User","site_admin":false},"created_at":"2018-09-26T17:16:30Z","updated_at":"2018-09-26T17:16:30Z","author_association":"CONTRIBUTOR","body":"It would be nice to add a test in `src/components/navigation/Navigation.spec.tsx` to validate that the parameters are correctly sent when the user change the \"perPage\""}}
{"actor":{"display_login":"GermainBergeron"}}