{"action":"created","comment":{"url":"https://api.github.com/repos/wikimedia/service-runner/pulls/comments/166805761","pull_request_review_id":94927203,"id":166805761,"diff_hunk":"@@ -175,26 +175,28 @@ class Master extends BaseService {\n                         return;\n                     }\n \n-                    if (!this._firstWorkerStarted) {\n-                        this._logger.log('error/service-runner/master',\n-                            `First worker died on startup with exit code ${code}`);\n-                        if (this._firstWorkerStartupAttempts++ >= STARTUP_ATTEMPTS_LIMIT) {\n-                            // We tried to start the first worker 3 times, but never succeed.\n-                            // Give up.\n-                            this._logger.log('fatal/service-runner/master',\n-                                'startup failed, exiting master');\n-                            return this._exitProcess(1);\n-                        }\n+                    if (!this._firstWorkerStarted\n+                            && this._firstWorkerStartupAttempts++ >= STARTUP_ATTEMPTS_LIMIT) {\n+                        // We tried to start the first worker 3 times, but never succeed.\n+                        // Give up.\n+                        this._logger.log('fatal/service-runner/master',","path":"lib/master.js","position":null,"original_position":27,"commit_id":"d13e9f48742aca361ca48af9872148e6e2ffedd8","original_commit_id":"ae14359323d9a53ee371665071c733edf3b6e32a","user":{"login":"Pchelolo","id":814754,"avatar_url":"https://avatars3.githubusercontent.com/u/814754?v=4","gravatar_id":"","url":"https://api.github.com/users/Pchelolo","html_url":"https://github.com/Pchelolo","followers_url":"https://api.github.com/users/Pchelolo/followers","following_url":"https://api.github.com/users/Pchelolo/following{/other_user}","gists_url":"https://api.github.com/users/Pchelolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pchelolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pchelolo/subscriptions","organizations_url":"https://api.github.com/users/Pchelolo/orgs","repos_url":"https://api.github.com/users/Pchelolo/repos","events_url":"https://api.github.com/users/Pchelolo/events{/privacy}","received_events_url":"https://api.github.com/users/Pchelolo/received_events","type":"User","site_admin":false},"body":"@d00rman done","created_at":"2018-02-08T01:00:38Z","updated_at":"2018-02-08T01:00:38Z","html_url":"https://github.com/wikimedia/service-runner/pull/180#discussion_r166805761","pull_request_url":"https://api.github.com/repos/wikimedia/service-runner/pulls/180","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wikimedia/service-runner/pulls/comments/166805761"},"html":{"href":"https://github.com/wikimedia/service-runner/pull/180#discussion_r166805761"},"pull_request":{"href":"https://api.github.com/repos/wikimedia/service-runner/pulls/180"}},"in_reply_to_id":166804801},"pull_request":{"url":"https://api.github.com/repos/wikimedia/service-runner/pulls/180","id":167847017,"html_url":"https://github.com/wikimedia/service-runner/pull/180","diff_url":"https://github.com/wikimedia/service-runner/pull/180.diff","patch_url":"https://github.com/wikimedia/service-runner/pull/180.patch","issue_url":"https://api.github.com/repos/wikimedia/service-runner/issues/180","number":180,"state":"open","locked":false,"title":"Normalize the logging messages for easier filtering in kibana","user":{"login":"Pchelolo","id":814754,"avatar_url":"https://avatars3.githubusercontent.com/u/814754?v=4","gravatar_id":"","url":"https://api.github.com/users/Pchelolo","html_url":"https://github.com/Pchelolo","followers_url":"https://api.github.com/users/Pchelolo/followers","following_url":"https://api.github.com/users/Pchelolo/following{/other_user}","gists_url":"https://api.github.com/users/Pchelolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pchelolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pchelolo/subscriptions","organizations_url":"https://api.github.com/users/Pchelolo/orgs","repos_url":"https://api.github.com/users/Pchelolo/repos","events_url":"https://api.github.com/users/Pchelolo/events{/privacy}","received_events_url":"https://api.github.com/users/Pchelolo/received_events","type":"User","site_admin":false},"body":"The additional information has been moved to separate fields in logs,\r\nlike this we can easily filter out mesages about worker deaths and\r\nfilter a sequence of events that lead to the death of a particular\r\nworker.\r\n\r\nBug: https://phabricator.wikimedia.org/T186761\r\ncc @wikimedia/services @berndsi @mdholloway ","created_at":"2018-02-08T00:27:04Z","updated_at":"2018-02-08T01:00:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a465e7549e671a8e607e53d44e0561992d5f1b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/service-runner/pulls/180/commits","review_comments_url":"https://api.github.com/repos/wikimedia/service-runner/pulls/180/comments","review_comment_url":"https://api.github.com/repos/wikimedia/service-runner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/service-runner/issues/180/comments","statuses_url":"https://api.github.com/repos/wikimedia/service-runner/statuses/d13e9f48742aca361ca48af9872148e6e2ffedd8","head":{"label":"Pchelolo:normalise_logging","ref":"normalise_logging","sha":"d13e9f48742aca361ca48af9872148e6e2ffedd8","user":{"login":"Pchelolo","id":814754,"avatar_url":"https://avatars3.githubusercontent.com/u/814754?v=4","gravatar_id":"","url":"https://api.github.com/users/Pchelolo","html_url":"https://github.com/Pchelolo","followers_url":"https://api.github.com/users/Pchelolo/followers","following_url":"https://api.github.com/users/Pchelolo/following{/other_user}","gists_url":"https://api.github.com/users/Pchelolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pchelolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pchelolo/subscriptions","organizations_url":"https://api.github.com/users/Pchelolo/orgs","repos_url":"https://api.github.com/users/Pchelolo/repos","events_url":"https://api.github.com/users/Pchelolo/events{/privacy}","received_events_url":"https://api.github.com/users/Pchelolo/received_events","type":"User","site_admin":false},"repo":{"id":40494448,"name":"service-runner","full_name":"Pchelolo/service-runner","owner":{"login":"Pchelolo","id":814754,"avatar_url":"https://avatars3.githubusercontent.com/u/814754?v=4","gravatar_id":"","url":"https://api.github.com/users/Pchelolo","html_url":"https://github.com/Pchelolo","followers_url":"https://api.github.com/users/Pchelolo/followers","following_url":"https://api.github.com/users/Pchelolo/following{/other_user}","gists_url":"https://api.github.com/users/Pchelolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pchelolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pchelolo/subscriptions","organizations_url":"https://api.github.com/users/Pchelolo/orgs","repos_url":"https://api.github.com/users/Pchelolo/repos","events_url":"https://api.github.com/users/Pchelolo/events{/privacy}","received_events_url":"https://api.github.com/users/Pchelolo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pchelolo/service-runner","description":"Generic nodejs service supervisor","fork":true,"url":"https://api.github.com/repos/Pchelolo/service-runner","forks_url":"https://api.github.com/repos/Pchelolo/service-runner/forks","keys_url":"https://api.github.com/repos/Pchelolo/service-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pchelolo/service-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pchelolo/service-runner/teams","hooks_url":"https://api.github.com/repos/Pchelolo/service-runner/hooks","issue_events_url":"https://api.github.com/repos/Pchelolo/service-runner/issues/events{/number}","events_url":"https://api.github.com/repos/Pchelolo/service-runner/events","assignees_url":"https://api.github.com/repos/Pchelolo/service-runner/assignees{/user}","branches_url":"https://api.github.com/repos/Pchelolo/service-runner/branches{/branch}","tags_url":"https://api.github.com/repos/Pchelolo/service-runner/tags","blobs_url":"https://api.github.com/repos/Pchelolo/service-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pchelolo/service-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pchelolo/service-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pchelolo/service-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pchelolo/service-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/Pchelolo/service-runner/languages","stargazers_url":"https://api.github.com/repos/Pchelolo/service-runner/stargazers","contributors_url":"https://api.github.com/repos/Pchelolo/service-runner/contributors","subscribers_url":"https://api.github.com/repos/Pchelolo/service-runner/subscribers","subscription_url":"https://api.github.com/repos/Pchelolo/service-runner/subscription","commits_url":"https://api.github.com/repos/Pchelolo/service-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pchelolo/service-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pchelolo/service-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pchelolo/service-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pchelolo/service-runner/contents/{+path}","compare_url":"https://api.github.com/repos/Pchelolo/service-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pchelolo/service-runner/merges","archive_url":"https://api.github.com/repos/Pchelolo/service-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pchelolo/service-runner/downloads","issues_url":"https://api.github.com/repos/Pchelolo/service-runner/issues{/number}","pulls_url":"https://api.github.com/repos/Pchelolo/service-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/Pchelolo/service-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/Pchelolo/service-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pchelolo/service-runner/labels{/name}","releases_url":"https://api.github.com/repos/Pchelolo/service-runner/releases{/id}","deployments_url":"https://api.github.com/repos/Pchelolo/service-runner/deployments","created_at":"2015-08-10T16:54:28Z","updated_at":"2016-01-14T01:06:01Z","pushed_at":"2018-02-08T01:00:30Z","git_url":"git://github.com/Pchelolo/service-runner.git","ssh_url":"git@github.com:Pchelolo/service-runner.git","clone_url":"https://github.com/Pchelolo/service-runner.git","svn_url":"https://github.com/Pchelolo/service-runner","homepage":null,"size":380,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"86f15c5bc9ad973b30af182ddacbd0f9089b8bd8","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":30805535,"name":"service-runner","full_name":"wikimedia/service-runner","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/service-runner","description":"Generic nodejs service supervisor","fork":false,"url":"https://api.github.com/repos/wikimedia/service-runner","forks_url":"https://api.github.com/repos/wikimedia/service-runner/forks","keys_url":"https://api.github.com/repos/wikimedia/service-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/service-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/service-runner/teams","hooks_url":"https://api.github.com/repos/wikimedia/service-runner/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/service-runner/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/service-runner/events","assignees_url":"https://api.github.com/repos/wikimedia/service-runner/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/service-runner/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/service-runner/tags","blobs_url":"https://api.github.com/repos/wikimedia/service-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/service-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/service-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/service-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/service-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/service-runner/languages","stargazers_url":"https://api.github.com/repos/wikimedia/service-runner/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/service-runner/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/service-runner/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/service-runner/subscription","commits_url":"https://api.github.com/repos/wikimedia/service-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/service-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/service-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/service-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/service-runner/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/service-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/service-runner/merges","archive_url":"https://api.github.com/repos/wikimedia/service-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/service-runner/downloads","issues_url":"https://api.github.com/repos/wikimedia/service-runner/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/service-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/service-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/service-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/service-runner/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/service-runner/releases{/id}","deployments_url":"https://api.github.com/repos/wikimedia/service-runner/deployments","created_at":"2015-02-14T18:58:54Z","updated_at":"2017-08-04T00:57:57Z","pushed_at":"2018-02-08T01:00:31Z","git_url":"git://github.com/wikimedia/service-runner.git","ssh_url":"git@github.com:wikimedia/service-runner.git","clone_url":"https://github.com/wikimedia/service-runner.git","svn_url":"https://github.com/wikimedia/service-runner","homepage":null,"size":359,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":9,"open_issues":7,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/service-runner/pulls/180"},"html":{"href":"https://github.com/wikimedia/service-runner/pull/180"},"issue":{"href":"https://api.github.com/repos/wikimedia/service-runner/issues/180"},"comments":{"href":"https://api.github.com/repos/wikimedia/service-runner/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/service-runner/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/service-runner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/service-runner/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/service-runner/statuses/d13e9f48742aca361ca48af9872148e6e2ffedd8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Pchelolo"}}