{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments/206664416","pull_request_review_id":142121217,"id":206664416,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjY2NDQxNg==","diff_hunk":"@@ -188,4 +188,77 @@ public void completableSourceAsMs() throws Exception {\n     public void observableAsC() throws Exception {\n         findPattern(\"Observable<.*>\\\\s+c\\\\b\");\n     }\n+\n+    @Test\n+    public void subscriberAsObserver() throws Exception {\n+        findPattern(\"Subscriber<.*>\\\\s+observer[0-9]?\\\\b\");\n+    }\n+\n+    @Test\n+    public void subscriberAsO() throws Exception {\n+        findPattern(\"Subscriber<.*>\\\\s+o[0-9]?\\\\b\");\n+    }\n+\n+    @Test\n+    public void singleAsObservable() throws Exception {\n+        findPattern(\"Single<.*>\\\\s+observable\\\\b\");\n+    }\n+\n+    @Test\n+    public void singleAsFlowable() throws Exception {\n+        findPattern(\"Single<.*>\\\\s+flowable\\\\b\");\n+    }\n+\n+    public void observerAsSubscriber() throws Exception {","path":"src/test/java/io/reactivex/CheckLocalVariablesInTests.java","position":25,"original_position":25,"commit_id":"171d74e811eb0bfd9f24ab32c806c28702f4464c","original_commit_id":"171d74e811eb0bfd9f24ab32c806c28702f4464c","user":{"login":"artem-zinnatullin","id":967132,"node_id":"MDQ6VXNlcjk2NzEzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/967132?v=4","gravatar_id":"","url":"https://api.github.com/users/artem-zinnatullin","html_url":"https://github.com/artem-zinnatullin","followers_url":"https://api.github.com/users/artem-zinnatullin/followers","following_url":"https://api.github.com/users/artem-zinnatullin/following{/other_user}","gists_url":"https://api.github.com/users/artem-zinnatullin/gists{/gist_id}","starred_url":"https://api.github.com/users/artem-zinnatullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artem-zinnatullin/subscriptions","organizations_url":"https://api.github.com/users/artem-zinnatullin/orgs","repos_url":"https://api.github.com/users/artem-zinnatullin/repos","events_url":"https://api.github.com/users/artem-zinnatullin/events{/privacy}","received_events_url":"https://api.github.com/users/artem-zinnatullin/received_events","type":"User","site_admin":false},"body":"missing `@Test`","created_at":"2018-07-31T20:01:15Z","updated_at":"2018-07-31T20:01:32Z","html_url":"https://github.com/ReactiveX/RxJava/pull/6119#discussion_r206664416","pull_request_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/6119","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments/206664416"},"html":{"href":"https://github.com/ReactiveX/RxJava/pull/6119#discussion_r206664416"},"pull_request":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/6119"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/6119","id":205206176,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjA2MTc2","html_url":"https://github.com/ReactiveX/RxJava/pull/6119","diff_url":"https://github.com/ReactiveX/RxJava/pull/6119.diff","patch_url":"https://github.com/ReactiveX/RxJava/pull/6119.patch","issue_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/6119","number":6119,"state":"open","locked":false,"title":"2.x: Test cleanup","user":{"login":"akarnokd","id":1269832,"node_id":"MDQ6VXNlcjEyNjk4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1269832?v=4","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"body":"This PR cleans up the tests:\r\n\r\n- Reduce stacktrace printouts due to undeliverable errors and turn them into assertions instead.\r\n- Rename local variables & arguments of `Subscriber`s from `o` and `observer` to the proper `subscriber`\r\n- Rename local variables & arguments of `Flowable`s from `o` and `observable` to the more appropriate `f` and `flowable`\r\n- Add more naming tests to `CheckLocalVariablesInTests` to support the previous two points.","created_at":"2018-07-31T18:44:03Z","updated_at":"2018-07-31T20:01:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89ac87d10c0205854129cc3c45262def8bdb9564","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":480313802,"node_id":"MDU6TGFiZWw0ODAzMTM4MDI=","url":"https://api.github.com/repos/ReactiveX/RxJava/labels/2.x","name":"2.x","color":"af40af","default":false},{"id":278982782,"node_id":"MDU6TGFiZWwyNzg5ODI3ODI=","url":"https://api.github.com/repos/ReactiveX/RxJava/labels/Cleanup","name":"Cleanup","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/ReactiveX/RxJava/milestones/26","html_url":"https://github.com/ReactiveX/RxJava/milestone/26","labels_url":"https://api.github.com/repos/ReactiveX/RxJava/milestones/26/labels","id":3505512,"node_id":"MDk6TWlsZXN0b25lMzUwNTUxMg==","number":26,"title":"2.2 backlog","description":"Issues and tasks deferred beyond the 2.2 release.","creator":{"login":"akarnokd","id":1269832,"node_id":"MDQ6VXNlcjEyNjk4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1269832?v=4","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":3,"state":"open","created_at":"2018-07-18T10:59:08Z","updated_at":"2018-07-31T18:44:03Z","due_on":"2018-12-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/6119/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/6119/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/6119/comments","statuses_url":"https://api.github.com/repos/ReactiveX/RxJava/statuses/171d74e811eb0bfd9f24ab32c806c28702f4464c","head":{"label":"akarnokd:LessErrorPrintout","ref":"LessErrorPrintout","sha":"171d74e811eb0bfd9f24ab32c806c28702f4464c","user":{"login":"akarnokd","id":1269832,"node_id":"MDQ6VXNlcjEyNjk4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1269832?v=4","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"repo":{"id":14518033,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxODAzMw==","name":"RxJava","full_name":"akarnokd/RxJava","owner":{"login":"akarnokd","id":1269832,"node_id":"MDQ6VXNlcjEyNjk4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1269832?v=4","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akarnokd/RxJava","description":"RxJava - a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":true,"url":"https://api.github.com/repos/akarnokd/RxJava","forks_url":"https://api.github.com/repos/akarnokd/RxJava/forks","keys_url":"https://api.github.com/repos/akarnokd/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akarnokd/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akarnokd/RxJava/teams","hooks_url":"https://api.github.com/repos/akarnokd/RxJava/hooks","issue_events_url":"https://api.github.com/repos/akarnokd/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/akarnokd/RxJava/events","assignees_url":"https://api.github.com/repos/akarnokd/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/akarnokd/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/akarnokd/RxJava/tags","blobs_url":"https://api.github.com/repos/akarnokd/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akarnokd/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akarnokd/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/akarnokd/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akarnokd/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/akarnokd/RxJava/languages","stargazers_url":"https://api.github.com/repos/akarnokd/RxJava/stargazers","contributors_url":"https://api.github.com/repos/akarnokd/RxJava/contributors","subscribers_url":"https://api.github.com/repos/akarnokd/RxJava/subscribers","subscription_url":"https://api.github.com/repos/akarnokd/RxJava/subscription","commits_url":"https://api.github.com/repos/akarnokd/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/akarnokd/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/akarnokd/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/akarnokd/RxJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/akarnokd/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/akarnokd/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akarnokd/RxJava/merges","archive_url":"https://api.github.com/repos/akarnokd/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akarnokd/RxJava/downloads","issues_url":"https://api.github.com/repos/akarnokd/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/akarnokd/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/akarnokd/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/akarnokd/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akarnokd/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/akarnokd/RxJava/releases{/id}","deployments_url":"https://api.github.com/repos/akarnokd/RxJava/deployments","created_at":"2013-11-19T08:04:52Z","updated_at":"2018-07-17T03:43:40Z","pushed_at":"2018-07-31T18:39:20Z","git_url":"git://github.com/akarnokd/RxJava.git","ssh_url":"git@github.com:akarnokd/RxJava.git","clone_url":"https://github.com/akarnokd/RxJava.git","svn_url":"https://github.com/akarnokd/RxJava","homepage":"","size":33343,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":4,"default_branch":"2.x"}},"base":{"label":"ReactiveX:2.x","ref":"2.x","sha":"a20f993dfc9f30ee1635f7ced155eee188926f9a","user":{"login":"ReactiveX","id":6407041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MDcwNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":7508411,"node_id":"MDEwOlJlcG9zaXRvcnk3NTA4NDEx","name":"RxJava","full_name":"ReactiveX/RxJava","owner":{"login":"ReactiveX","id":6407041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MDcwNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/RxJava","description":"RxJava – Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":false,"url":"https://api.github.com/repos/ReactiveX/RxJava","forks_url":"https://api.github.com/repos/ReactiveX/RxJava/forks","keys_url":"https://api.github.com/repos/ReactiveX/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/RxJava/teams","hooks_url":"https://api.github.com/repos/ReactiveX/RxJava/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/RxJava/events","assignees_url":"https://api.github.com/repos/ReactiveX/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/RxJava/tags","blobs_url":"https://api.github.com/repos/ReactiveX/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/RxJava/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/RxJava/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/RxJava/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/RxJava/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/RxJava/subscription","commits_url":"https://api.github.com/repos/ReactiveX/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/RxJava/merges","archive_url":"https://api.github.com/repos/ReactiveX/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/RxJava/downloads","issues_url":"https://api.github.com/repos/ReactiveX/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/RxJava/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/RxJava/deployments","created_at":"2013-01-08T20:11:48Z","updated_at":"2018-07-31T13:54:44Z","pushed_at":"2018-07-31T18:44:04Z","git_url":"git://github.com/ReactiveX/RxJava.git","ssh_url":"git@github.com:ReactiveX/RxJava.git","clone_url":"https://github.com/ReactiveX/RxJava.git","svn_url":"https://github.com/ReactiveX/RxJava","homepage":"","size":61255,"stargazers_count":34550,"watchers_count":34550,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5981,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5981,"open_issues":26,"watchers":34550,"default_branch":"2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/6119"},"html":{"href":"https://github.com/ReactiveX/RxJava/pull/6119"},"issue":{"href":"https://api.github.com/repos/ReactiveX/RxJava/issues/6119"},"comments":{"href":"https://api.github.com/repos/ReactiveX/RxJava/issues/6119/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/6119/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/6119/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/RxJava/statuses/171d74e811eb0bfd9f24ab32c806c28702f4464c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"artem-zinnatullin"}}