{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments/187778624","pull_request_review_id":119632195,"id":187778624,"diff_hunk":"@@ -122,13 +122,13 @@\n     \"joi\": \"^13.2.0\",\n     \"joi-browser\": \"^13.0.1\",\n     \"joi-multiaddr\": \"^2.0.0\",\n-    \"libp2p\": \"~0.20.4\",\n+    \"libp2p\": \"libp2p/js-libp2p#feat/pull-mplex\",","path":"package.json","position":5,"original_position":5,"commit_id":"c2baa0a5a9c42645e950730c45333b6c37299bb8","original_commit_id":"c2baa0a5a9c42645e950730c45333b6c37299bb8","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars0.githubusercontent.com/u/1211152?v=4","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"body":"This change should not be necessary.","created_at":"2018-05-12T17:39:13Z","updated_at":"2018-05-12T17:39:13Z","html_url":"https://github.com/ipfs/js-ipfs/pull/1346#discussion_r187778624","pull_request_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1346","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments/187778624"},"html":{"href":"https://github.com/ipfs/js-ipfs/pull/1346#discussion_r187778624"},"pull_request":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1346"}}},"pull_request":{"url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1346","id":186798552,"html_url":"https://github.com/ipfs/js-ipfs/pull/1346","diff_url":"https://github.com/ipfs/js-ipfs/pull/1346.diff","patch_url":"https://github.com/ipfs/js-ipfs/pull/1346.patch","issue_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1346","number":1346,"state":"open","locked":false,"title":"feat: use pull stream based mplex","user":{"login":"dryajov","id":1094341,"avatar_url":"https://avatars1.githubusercontent.com/u/1094341?v=4","gravatar_id":"","url":"https://api.github.com/users/dryajov","html_url":"https://github.com/dryajov","followers_url":"https://api.github.com/users/dryajov/followers","following_url":"https://api.github.com/users/dryajov/following{/other_user}","gists_url":"https://api.github.com/users/dryajov/gists{/gist_id}","starred_url":"https://api.github.com/users/dryajov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryajov/subscriptions","organizations_url":"https://api.github.com/users/dryajov/orgs","repos_url":"https://api.github.com/users/dryajov/repos","events_url":"https://api.github.com/users/dryajov/events{/privacy}","received_events_url":"https://api.github.com/users/dryajov/received_events","type":"User","site_admin":false},"body":"NOTE: Im using libp2p as a git dep, so that we can test it on CI. This is temporary and should be changed once libp2p is released.","created_at":"2018-05-09T01:52:40Z","updated_at":"2018-05-12T17:39:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba0a3d817e57175b6caafb54a5cdde49360433d6","assignee":{"login":"dryajov","id":1094341,"avatar_url":"https://avatars1.githubusercontent.com/u/1094341?v=4","gravatar_id":"","url":"https://api.github.com/users/dryajov","html_url":"https://github.com/dryajov","followers_url":"https://api.github.com/users/dryajov/followers","following_url":"https://api.github.com/users/dryajov/following{/other_user}","gists_url":"https://api.github.com/users/dryajov/gists{/gist_id}","starred_url":"https://api.github.com/users/dryajov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryajov/subscriptions","organizations_url":"https://api.github.com/users/dryajov/orgs","repos_url":"https://api.github.com/users/dryajov/repos","events_url":"https://api.github.com/users/dryajov/events{/privacy}","received_events_url":"https://api.github.com/users/dryajov/received_events","type":"User","site_admin":false},"assignees":[{"login":"dryajov","id":1094341,"avatar_url":"https://avatars1.githubusercontent.com/u/1094341?v=4","gravatar_id":"","url":"https://api.github.com/users/dryajov","html_url":"https://github.com/dryajov","followers_url":"https://api.github.com/users/dryajov/followers","following_url":"https://api.github.com/users/dryajov/following{/other_user}","gists_url":"https://api.github.com/users/dryajov/gists{/gist_id}","starred_url":"https://api.github.com/users/dryajov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryajov/subscriptions","organizations_url":"https://api.github.com/users/dryajov/orgs","repos_url":"https://api.github.com/users/dryajov/repos","events_url":"https://api.github.com/users/dryajov/events{/privacy}","received_events_url":"https://api.github.com/users/dryajov/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":259619775,"url":"https://api.github.com/repos/ipfs/js-ipfs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1346/commits","review_comments_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1346/comments","review_comment_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1346/comments","statuses_url":"https://api.github.com/repos/ipfs/js-ipfs/statuses/c2baa0a5a9c42645e950730c45333b6c37299bb8","head":{"label":"ipfs:feat/pull-mplex","ref":"feat/pull-mplex","sha":"c2baa0a5a9c42645e950730c45333b6c37299bb8","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":20312497,"name":"js-ipfs","full_name":"ipfs/js-ipfs","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/js-ipfs","description":"IPFS implementation in JavaScript","fork":false,"url":"https://api.github.com/repos/ipfs/js-ipfs","forks_url":"https://api.github.com/repos/ipfs/js-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/js-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/js-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/js-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/js-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/js-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/js-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/js-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/js-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/js-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/js-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/js-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/js-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/js-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/js-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/js-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/js-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/js-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/js-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/js-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/js-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/js-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/js-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/js-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/js-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/js-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/js-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/js-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/js-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/js-ipfs/deployments","created_at":"2014-05-30T00:31:06Z","updated_at":"2018-05-12T16:57:50Z","pushed_at":"2018-05-12T16:58:26Z","git_url":"git://github.com/ipfs/js-ipfs.git","ssh_url":"git@github.com:ipfs/js-ipfs.git","clone_url":"https://github.com/ipfs/js-ipfs.git","svn_url":"https://github.com/ipfs/js-ipfs","homepage":"https://ipfs.io","size":9353,"stargazers_count":2291,"watchers_count":2291,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":368,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":368,"open_issues":95,"watchers":2291,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"de95989c3617f5a1c2ea8a376bc6cf525684edc6","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":20312497,"name":"js-ipfs","full_name":"ipfs/js-ipfs","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/js-ipfs","description":"IPFS implementation in JavaScript","fork":false,"url":"https://api.github.com/repos/ipfs/js-ipfs","forks_url":"https://api.github.com/repos/ipfs/js-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/js-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/js-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/js-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/js-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/js-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/js-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/js-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/js-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/js-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/js-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/js-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/js-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/js-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/js-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/js-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/js-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/js-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/js-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/js-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/js-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/js-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/js-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/js-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/js-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/js-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/js-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/js-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/js-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/js-ipfs/deployments","created_at":"2014-05-30T00:31:06Z","updated_at":"2018-05-12T16:57:50Z","pushed_at":"2018-05-12T16:58:26Z","git_url":"git://github.com/ipfs/js-ipfs.git","ssh_url":"git@github.com:ipfs/js-ipfs.git","clone_url":"https://github.com/ipfs/js-ipfs.git","svn_url":"https://github.com/ipfs/js-ipfs","homepage":"https://ipfs.io","size":9353,"stargazers_count":2291,"watchers_count":2291,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":368,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":368,"open_issues":95,"watchers":2291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1346"},"html":{"href":"https://github.com/ipfs/js-ipfs/pull/1346"},"issue":{"href":"https://api.github.com/repos/ipfs/js-ipfs/issues/1346"},"comments":{"href":"https://api.github.com/repos/ipfs/js-ipfs/issues/1346/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1346/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1346/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/js-ipfs/statuses/c2baa0a5a9c42645e950730c45333b6c37299bb8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"diasdavid"}}