{"action":"created","issue":{"url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/49","repository_url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro","labels_url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/49/comments","events_url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/49/events","html_url":"https://github.com/OpenLiberty/draft-guide-security-intro/issues/49","id":367466801,"node_id":"MDU6SXNzdWUzNjc0NjY4MDE=","number":49,"title":"Quick review feedback","user":{"login":"yeekangc","id":4803104,"node_id":"MDQ6VXNlcjQ4MDMxMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4803104?v=4","gravatar_id":"","url":"https://api.github.com/users/yeekangc","html_url":"https://github.com/yeekangc","followers_url":"https://api.github.com/users/yeekangc/followers","following_url":"https://api.github.com/users/yeekangc/following{/other_user}","gists_url":"https://api.github.com/users/yeekangc/gists{/gist_id}","starred_url":"https://api.github.com/users/yeekangc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeekangc/subscriptions","organizations_url":"https://api.github.com/users/yeekangc/orgs","repos_url":"https://api.github.com/users/yeekangc/repos","events_url":"https://api.github.com/users/yeekangc/events{/privacy}","received_events_url":"https://api.github.com/users/yeekangc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"justineechen","id":18709242,"node_id":"MDQ6VXNlcjE4NzA5MjQy","avatar_url":"https://avatars3.githubusercontent.com/u/18709242?v=4","gravatar_id":"","url":"https://api.github.com/users/justineechen","html_url":"https://github.com/justineechen","followers_url":"https://api.github.com/users/justineechen/followers","following_url":"https://api.github.com/users/justineechen/following{/other_user}","gists_url":"https://api.github.com/users/justineechen/gists{/gist_id}","starred_url":"https://api.github.com/users/justineechen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justineechen/subscriptions","organizations_url":"https://api.github.com/users/justineechen/orgs","repos_url":"https://api.github.com/users/justineechen/repos","events_url":"https://api.github.com/users/justineechen/events{/privacy}","received_events_url":"https://api.github.com/users/justineechen/received_events","type":"User","site_admin":false},"assignees":[{"login":"justineechen","id":18709242,"node_id":"MDQ6VXNlcjE4NzA5MjQy","avatar_url":"https://avatars3.githubusercontent.com/u/18709242?v=4","gravatar_id":"","url":"https://api.github.com/users/justineechen","html_url":"https://github.com/justineechen","followers_url":"https://api.github.com/users/justineechen/followers","following_url":"https://api.github.com/users/justineechen/following{/other_user}","gists_url":"https://api.github.com/users/justineechen/gists{/gist_id}","starred_url":"https://api.github.com/users/justineechen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justineechen/subscriptions","organizations_url":"https://api.github.com/users/justineechen/orgs","repos_url":"https://api.github.com/users/justineechen/repos","events_url":"https://api.github.com/users/justineechen/events{/privacy}","received_events_url":"https://api.github.com/users/justineechen/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-10-06T15:21:52Z","updated_at":"2018-10-09T17:44:54Z","closed_at":null,"author_association":"MEMBER","body":"_It also provides a SecurityContext API for programmatic security checks in Java EE containers._\r\nIn Java EE containers?  Should be application or your code.  The API allows you to access security information.\r\n\r\n_Java EE Security provides capability to configure the basic, form or custom form authentication mechanism by using annotations in the servlets. It also provides a SecurityContext API for programmatic security checks in Java EE containers. You’ll learn how to implement form authentication. Form authentication allows you to specify the web application login and error pages, assign the security constraint of a servlet and use the SecurityContext API to determine the role of a logged in user._\r\nWe can break the above into paragraphs for easier read.\r\n\r\n_The identity store is provided with the following user information credentials:_\r\nThe identify store provided is defined with the following user crendentials\r\n\r\n_Now you can sign in to the HomeServlet with one of the credentials from the identity store._\r\nHomeServlet?  I would say the application.\r\n\r\nWhy do we do an inclusion for the server.xml?  If we want to do so, we should explain why and the benefits?\r\n\r\n_Within the <application-bnd> tags, two different authorization roles are assigned to these groups: admin and user._\r\nTags?  Should we say elements?\r\n\r\n_Encrypting passwords using securityUtility_\r\nMake a note that it is not recommended to store passwords in plain text?\r\n\r\n_Open the src/main/webapp/WEB-INF/web.xml file:_\r\nDo we need the user to edit this?  If not, it should not be copyable?\r\n\r\n_// Return if expect the login should fail_\r\nMore like \"Return if the login fail\"?\r\n\r\n_Next, you can try the related MicroProfile-JWT guide._\r\nShouldn't have a dash between MicroProfile and JWT?\r\n"},"comment":{"url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/comments/428285173","html_url":"https://github.com/OpenLiberty/draft-guide-security-intro/issues/49#issuecomment-428285173","issue_url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/49","id":428285173,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODI4NTE3Mw==","user":{"login":"gkwan-ibm","id":29576299,"node_id":"MDQ6VXNlcjI5NTc2Mjk5","avatar_url":"https://avatars0.githubusercontent.com/u/29576299?v=4","gravatar_id":"","url":"https://api.github.com/users/gkwan-ibm","html_url":"https://github.com/gkwan-ibm","followers_url":"https://api.github.com/users/gkwan-ibm/followers","following_url":"https://api.github.com/users/gkwan-ibm/following{/other_user}","gists_url":"https://api.github.com/users/gkwan-ibm/gists{/gist_id}","starred_url":"https://api.github.com/users/gkwan-ibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkwan-ibm/subscriptions","organizations_url":"https://api.github.com/users/gkwan-ibm/orgs","repos_url":"https://api.github.com/users/gkwan-ibm/repos","events_url":"https://api.github.com/users/gkwan-ibm/events{/privacy}","received_events_url":"https://api.github.com/users/gkwan-ibm/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T17:44:54Z","updated_at":"2018-10-09T17:44:54Z","author_association":"MEMBER","body":"Yes the index.html is needed. If directly use servlet  for the welcome page, the web container does not challenge the authorization of the servlet and directly execute it. The role cannot be determined in the servlet."}}
{"actor":{"display_login":"gkwan-ibm"}}