{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3534","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3534/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3534/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3534/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3534","id":303426286,"number":3534,"title":"[WIP] Convert MIQ Request filtering to the client (using Angular)","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars3.githubusercontent.com/u/51095?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"labels":[{"id":535030500,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/angular%20dialogs","name":"angular dialogs","color":"d4c5f9","default":false},{"id":736077188,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/gaprindashvili/no","name":"gaprindashvili/no","color":"000000","default":false},{"id":505531449,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/technical%20debt","name":"technical debt","color":"ff7619","default":false},{"id":505531653,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/wip","name":"wip","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-08T10:16:42Z","updated_at":"2018-03-21T12:54:12Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3534","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3534","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3534.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3534.patch"},"body":"### What is does?\r\n * use the new scopes\r\n * scopes are calculated on the server side, applied to the grid\r\n * \"Default\" button is renamed to \"Reset\" and \"Reset\" is removed (discussed with @terezanovotna @dclarizio)\r\n\r\n### TODO: \r\n  * specs\r\n  * delete more code\r\n  * the generic angular error handling **still** does not properly handle session timeout (ping @AparnaKarve, @himdel, @Hyperkid123)\r\n  * rbac check handling for `filter`\r\n  * remove routes for removed actions\r\n\r\nDepends on https://github.com/ManageIQ/manageiq/pull/17102"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/374926516","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3534#issuecomment-374926516","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3534","id":374926516,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T12:54:12Z","updated_at":"2018-03-21T12:54:12Z","author_association":"MEMBER","body":"<rubocop />Checked commit https://github.com/martinpovolny/manageiq-ui-classic/commit/026f9a8184868d0581dc698a27c764c489489eb7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n3 files checked, 10 offenses detected\n\n**app/controllers/miq_request_controller.rb**\n- [ ] :exclamation: - [Line 340](https://github.com/martinpovolny/manageiq-ui-classic/blob/026f9a8184868d0581dc698a27c764c489489eb7/app/controllers/miq_request_controller.rb#L340), Col 3 - [Layout/LeadingCommentSpace](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/LeadingCommentSpace) - Missing space after `#`.\n- [ ] :exclamation: - [Line 347](https://github.com/martinpovolny/manageiq-ui-classic/blob/026f9a8184868d0581dc698a27c764c489489eb7/app/controllers/miq_request_controller.rb#L347), Col 3 - [Layout/LeadingCommentSpace](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/LeadingCommentSpace) - Missing space after `#`.\n- [ ] :exclamation: - [Line 388](https://github.com/martinpovolny/manageiq-ui-classic/blob/026f9a8184868d0581dc698a27c764c489489eb7/app/controllers/miq_request_controller.rb#L388), Col 3 - [Layout/IndentationWidth](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/IndentationWidth) - Use 2 (not 1) spaces for indentation.\n- [ ] :exclamation: - [Line 440](https://github.com/martinpovolny/manageiq-ui-classic/blob/026f9a8184868d0581dc698a27c764c489489eb7/app/controllers/miq_request_controller.rb#L440), Col 76 - [Layout/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/SpaceAfterComma) - Space missing after comma.\n- [ ] :exclamation: - [Line 540](https://github.com/martinpovolny/manageiq-ui-classic/blob/026f9a8184868d0581dc698a27c764c489489eb7/app/controllers/miq_request_controller.rb#L540), Col 5 - [Layout/LeadingCommentSpace](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/LeadingCommentSpace) - Missing space after `#`.\n- [ ] :exclamation: - [Line 547](https://github.com/martinpovolny/manageiq-ui-classic/blob/026f9a8184868d0581dc698a27c764c489489eb7/app/controllers/miq_request_controller.rb#L547), Col 5 - [Layout/LeadingCommentSpace](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/LeadingCommentSpace) - Missing space after `#`.\n- [ ] :exclamation: - [Line 76](https://github.com/martinpovolny/manageiq-ui-classic/blob/026f9a8184868d0581dc698a27c764c489489eb7/app/controllers/miq_request_controller.rb#L76), Col 5 - [Layout/LeadingCommentSpace](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/LeadingCommentSpace) - Missing space after `#`.\n- [ ] :exclamation: - [Line 79](https://github.com/martinpovolny/manageiq-ui-classic/blob/026f9a8184868d0581dc698a27c764c489489eb7/app/controllers/miq_request_controller.rb#L79), Col 5 - [Layout/LeadingCommentSpace](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/LeadingCommentSpace) - Missing space after `#`.\n- [ ] :exclamation: - [Line 80](https://github.com/martinpovolny/manageiq-ui-classic/blob/026f9a8184868d0581dc698a27c764c489489eb7/app/controllers/miq_request_controller.rb#L80), Col 5 - [Layout/LeadingCommentSpace](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/LeadingCommentSpace) - Missing space after `#`.\n- [ ] :exclamation: - [Line 81](https://github.com/martinpovolny/manageiq-ui-classic/blob/026f9a8184868d0581dc698a27c764c489489eb7/app/controllers/miq_request_controller.rb#L81), Col 5 - [Layout/LeadingCommentSpace](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/LeadingCommentSpace) - Missing space after `#`.\n"}}
{"actor":{"display_login":"miq-bot"}}