{"action":"created","issue":{"url":"https://api.github.com/repos/fernando-mc/serverless-finch/issues/58","repository_url":"https://api.github.com/repos/fernando-mc/serverless-finch","labels_url":"https://api.github.com/repos/fernando-mc/serverless-finch/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/fernando-mc/serverless-finch/issues/58/comments","events_url":"https://api.github.com/repos/fernando-mc/serverless-finch/issues/58/events","html_url":"https://github.com/fernando-mc/serverless-finch/pull/58","id":332908048,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Mjc4MjQy","number":58,"title":"add support for custom bucket policy configs","user":{"login":"jsphweid","id":8868585,"node_id":"MDQ6VXNlcjg4Njg1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/8868585?v=4","gravatar_id":"","url":"https://api.github.com/users/jsphweid","html_url":"https://github.com/jsphweid","followers_url":"https://api.github.com/users/jsphweid/followers","following_url":"https://api.github.com/users/jsphweid/following{/other_user}","gists_url":"https://api.github.com/users/jsphweid/gists{/gist_id}","starred_url":"https://api.github.com/users/jsphweid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsphweid/subscriptions","organizations_url":"https://api.github.com/users/jsphweid/orgs","repos_url":"https://api.github.com/users/jsphweid/repos","events_url":"https://api.github.com/users/jsphweid/events{/privacy}","received_events_url":"https://api.github.com/users/jsphweid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-15T20:42:18Z","updated_at":"2018-06-18T14:30:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/fernando-mc/serverless-finch/pulls/58","html_url":"https://github.com/fernando-mc/serverless-finch/pull/58","diff_url":"https://github.com/fernando-mc/serverless-finch/pull/58.diff","patch_url":"https://github.com/fernando-mc/serverless-finch/pull/58.patch"},"body":"### Background\r\n\r\nReimplement this: #15 \r\n\r\n### Proposed changes\r\n\r\nThe ability to add a custom bucket config.\r\n"},"comment":{"url":"https://api.github.com/repos/fernando-mc/serverless-finch/issues/comments/398074136","html_url":"https://github.com/fernando-mc/serverless-finch/pull/58#issuecomment-398074136","issue_url":"https://api.github.com/repos/fernando-mc/serverless-finch/issues/58","id":398074136,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODA3NDEzNg==","user":{"login":"linusmarco","id":18667084,"node_id":"MDQ6VXNlcjE4NjY3MDg0","avatar_url":"https://avatars3.githubusercontent.com/u/18667084?v=4","gravatar_id":"","url":"https://api.github.com/users/linusmarco","html_url":"https://github.com/linusmarco","followers_url":"https://api.github.com/users/linusmarco/followers","following_url":"https://api.github.com/users/linusmarco/following{/other_user}","gists_url":"https://api.github.com/users/linusmarco/gists{/gist_id}","starred_url":"https://api.github.com/users/linusmarco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linusmarco/subscriptions","organizations_url":"https://api.github.com/users/linusmarco/orgs","repos_url":"https://api.github.com/users/linusmarco/repos","events_url":"https://api.github.com/users/linusmarco/events{/privacy}","received_events_url":"https://api.github.com/users/linusmarco/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T14:30:46Z","updated_at":"2018-06-18T14:30:46Z","author_association":"COLLABORATOR","body":"@jsphweid you should be able to use the `iam.simulateCustomPolicy` method in the AWS SDK to validate the policy:\r\nhttps://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/IAM.html#simulateCustomPolicy-property\r\n\r\nAlso, please make sure that you add this and any other relevant validation checks on the new `bucketPolicyFile` configuration option to `lib/validate.js`. That is where we keep all the validation checks to make sure that all of the validation runs prior to any bucket removal and/or deployment.\r\n\r\nAnd thanks for adding this functionality! "}}
{"actor":{"display_login":"linusmarco"}}