{"action":"created","issue":{"url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-rabbitmq/issues/92","repository_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-rabbitmq","labels_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-rabbitmq/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-rabbitmq/issues/92/comments","events_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-rabbitmq/issues/92/events","html_url":"https://github.com/sensu-plugins/sensu-plugins-rabbitmq/pull/92","id":323322268,"number":92,"title":"remove frozen string literal setting from the plugin","user":{"login":"rstruber","id":3433905,"avatar_url":"https://avatars1.githubusercontent.com/u/3433905?v=4","gravatar_id":"","url":"https://api.github.com/users/rstruber","html_url":"https://github.com/rstruber","followers_url":"https://api.github.com/users/rstruber/followers","following_url":"https://api.github.com/users/rstruber/following{/other_user}","gists_url":"https://api.github.com/users/rstruber/gists{/gist_id}","starred_url":"https://api.github.com/users/rstruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstruber/subscriptions","organizations_url":"https://api.github.com/users/rstruber/orgs","repos_url":"https://api.github.com/users/rstruber/repos","events_url":"https://api.github.com/users/rstruber/events{/privacy}","received_events_url":"https://api.github.com/users/rstruber/received_events","type":"User","site_admin":false},"labels":[{"id":707568610,"url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-rabbitmq/labels/Status:%20Awaiting%20Response","name":"Status: Awaiting Response","color":"fef2c0","default":false},{"id":707568822,"url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-rabbitmq/labels/Status:%20Thinking","name":"Status: Thinking","color":"000000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-15T17:58:03Z","updated_at":"2018-05-29T15:44:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-rabbitmq/pulls/92","html_url":"https://github.com/sensu-plugins/sensu-plugins-rabbitmq/pull/92","diff_url":"https://github.com/sensu-plugins/sensu-plugins-rabbitmq/pull/92.diff","patch_url":"https://github.com/sensu-plugins/sensu-plugins-rabbitmq/pull/92.patch"},"body":"This avoids issues with string modification in scripts that do not create objects from the strings.\r\n\r\nExample:\r\n\r\n```\r\nCheck failed to run: can't modify frozen String, [\"/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/mixlib-cli-1.7.0/lib/mixlib/cli.rb:315:in `build_option_arguments'\", \"/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/mixlib-cli-1.7.0/lib/mixlib/cli.rb:269:in `block (2 levels) in opt_parser'\", \"/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/mixlib-cli-1.7.0/lib/mixlib/cli.rb:268:in `each'\", \"/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/mixlib-cli-1.7.0/lib/mixlib/cli.rb:268:in `block in opt_parser'\", \"/opt/sensu/embedded/lib/ruby/2.4.0/optparse.rb:1062:in `initialize'\", \"/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/mixlib-cli-1.7.0/lib/mixlib/cli.rb:263:in `new'\", \"/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/mixlib-cli-1.7.0/lib/mixlib/cli.rb:263:in `opt_parser'\", \"/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/mixlib-cli-1.7.0/lib/mixlib/cli.rb:230:in `parse_options'\", \"/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/sensu-plugin-2.0.1/lib/sensu-plugin/cli.rb:13:in `initialize'\", \"/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/sensu-plugin-2.0.1/lib/sensu-plugin/cli.rb:57:in `new'\", \"/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/sensu-plugin-2.0.1/lib/sensu-plugin/cli.rb:57:in `block in <class:CLI>'\"]\r\n```\r\n\r\nIn bin/check-rabbitmq-node-usage.rb\r\n\r\n## Pull Request Checklist\r\n\r\n**Is this in reference to an existing issue?**\r\n\r\n#### General\r\n\r\n- [ ] Update Changelog following the conventions laid out [here](https://github.com/sensu-plugins/community/blob/master/HOW_WE_CHANGELOG.md)\r\n\r\n- [ ] Update README with any necessary configuration snippets\r\n\r\n- [ ] Binstubs are created if needed\r\n\r\n- [ ] RuboCop passes\r\n\r\n- [ ] Existing tests pass\r\n\r\n#### New Plugins\r\n\r\n- [ ] Tests\r\n\r\n- [ ] Add the plugin to the README\r\n\r\n- [ ] Does it have a complete header as outlined [here](http://sensu-plugins.io/docs/developer_guidelines.html#coding-style)\r\n\r\n#### Purpose\r\n\r\n#### Known Compatibility Issues\r\n"},"comment":{"url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-rabbitmq/issues/comments/392826587","html_url":"https://github.com/sensu-plugins/sensu-plugins-rabbitmq/pull/92#issuecomment-392826587","issue_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-rabbitmq/issues/92","id":392826587,"user":{"login":"rstruber","id":3433905,"avatar_url":"https://avatars1.githubusercontent.com/u/3433905?v=4","gravatar_id":"","url":"https://api.github.com/users/rstruber","html_url":"https://github.com/rstruber","followers_url":"https://api.github.com/users/rstruber/followers","following_url":"https://api.github.com/users/rstruber/following{/other_user}","gists_url":"https://api.github.com/users/rstruber/gists{/gist_id}","starred_url":"https://api.github.com/users/rstruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstruber/subscriptions","organizations_url":"https://api.github.com/users/rstruber/orgs","repos_url":"https://api.github.com/users/rstruber/repos","events_url":"https://api.github.com/users/rstruber/events{/privacy}","received_events_url":"https://api.github.com/users/rstruber/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T15:44:58Z","updated_at":"2018-05-29T15:44:58Z","author_association":"NONE","body":"I probably got a little over-zealous. Nothing wrong with paring it down. I would lean toward using the `.dup` method as that seems the most obvious way of showing what you're doing and future proof as well."}}
{"actor":{"display_login":"rstruber"}}