{"action":"created","comment":{"url":"https://api.github.com/repos/txtdirect/txtdirect/pulls/comments/200212111","pull_request_review_id":134482684,"id":200212111,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDIxMjExMQ==","diff_hunk":"@@ -8,6 +8,10 @@ import (\n )\n \n func zoneFromPath(host string, path string) (string, int, error) {\n+\tbl := \"/internal\"\n+\tif strings.Contains(path, bl) {\n+\t\treturn \"\", 0, fmt.Errorf(\"path containing 'internal' is disallowed\")\n+\t}","path":"path.go","position":null,"original_position":7,"commit_id":"c44f78ea9eb6104ca6da9b1141ab40b35f96b3f1","original_commit_id":"f1a603e0c6954e24034c7e3e047aa922c101a081","user":{"login":"dbriesz","id":20975751,"node_id":"MDQ6VXNlcjIwOTc1NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/20975751?v=4","gravatar_id":"","url":"https://api.github.com/users/dbriesz","html_url":"https://github.com/dbriesz","followers_url":"https://api.github.com/users/dbriesz/followers","following_url":"https://api.github.com/users/dbriesz/following{/other_user}","gists_url":"https://api.github.com/users/dbriesz/gists{/gist_id}","starred_url":"https://api.github.com/users/dbriesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbriesz/subscriptions","organizations_url":"https://api.github.com/users/dbriesz/orgs","repos_url":"https://api.github.com/users/dbriesz/repos","events_url":"https://api.github.com/users/dbriesz/events{/privacy}","received_events_url":"https://api.github.com/users/dbriesz/received_events","type":"User","site_admin":false},"body":"Thanks - I removed that unnecessary check","created_at":"2018-07-05T00:13:22Z","updated_at":"2018-07-05T00:13:22Z","html_url":"https://github.com/txtdirect/txtdirect/pull/54#discussion_r200212111","pull_request_url":"https://api.github.com/repos/txtdirect/txtdirect/pulls/54","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/txtdirect/txtdirect/pulls/comments/200212111"},"html":{"href":"https://github.com/txtdirect/txtdirect/pull/54#discussion_r200212111"},"pull_request":{"href":"https://api.github.com/repos/txtdirect/txtdirect/pulls/54"}},"in_reply_to_id":199822536},"pull_request":{"url":"https://api.github.com/repos/txtdirect/txtdirect/pulls/54","id":198117066,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTE3MDY2","html_url":"https://github.com/txtdirect/txtdirect/pull/54","diff_url":"https://github.com/txtdirect/txtdirect/pull/54.diff","patch_url":"https://github.com/txtdirect/txtdirect/pull/54.patch","issue_url":"https://api.github.com/repos/txtdirect/txtdirect/issues/54","number":54,"state":"open","locked":false,"title":"Prevent internal folder path","user":{"login":"dbriesz","id":20975751,"node_id":"MDQ6VXNlcjIwOTc1NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/20975751?v=4","gravatar_id":"","url":"https://api.github.com/users/dbriesz","html_url":"https://github.com/dbriesz","followers_url":"https://api.github.com/users/dbriesz/followers","following_url":"https://api.github.com/users/dbriesz/following{/other_user}","gists_url":"https://api.github.com/users/dbriesz/gists{/gist_id}","starred_url":"https://api.github.com/users/dbriesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbriesz/subscriptions","organizations_url":"https://api.github.com/users/dbriesz/orgs","repos_url":"https://api.github.com/users/dbriesz/repos","events_url":"https://api.github.com/users/dbriesz/events{/privacy}","received_events_url":"https://api.github.com/users/dbriesz/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nAdds checks for paths that contain \"internal\" folders and returns an error since importing of internal packages should be prevented.\r\n\r\n**Which issue this PR fixes**:\r\nfixes #27 ","created_at":"2018-06-28T18:37:41Z","updated_at":"2018-07-05T00:13:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ad97ec29a8abf6705a3ad24ed098022a57447c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/txtdirect/txtdirect/pulls/54/commits","review_comments_url":"https://api.github.com/repos/txtdirect/txtdirect/pulls/54/comments","review_comment_url":"https://api.github.com/repos/txtdirect/txtdirect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/txtdirect/txtdirect/issues/54/comments","statuses_url":"https://api.github.com/repos/txtdirect/txtdirect/statuses/c44f78ea9eb6104ca6da9b1141ab40b35f96b3f1","head":{"label":"dbriesz:internal-blacklist","ref":"internal-blacklist","sha":"c44f78ea9eb6104ca6da9b1141ab40b35f96b3f1","user":{"login":"dbriesz","id":20975751,"node_id":"MDQ6VXNlcjIwOTc1NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/20975751?v=4","gravatar_id":"","url":"https://api.github.com/users/dbriesz","html_url":"https://github.com/dbriesz","followers_url":"https://api.github.com/users/dbriesz/followers","following_url":"https://api.github.com/users/dbriesz/following{/other_user}","gists_url":"https://api.github.com/users/dbriesz/gists{/gist_id}","starred_url":"https://api.github.com/users/dbriesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbriesz/subscriptions","organizations_url":"https://api.github.com/users/dbriesz/orgs","repos_url":"https://api.github.com/users/dbriesz/repos","events_url":"https://api.github.com/users/dbriesz/events{/privacy}","received_events_url":"https://api.github.com/users/dbriesz/received_events","type":"User","site_admin":false},"repo":{"id":128266981,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgyNjY5ODE=","name":"txtdirect","full_name":"dbriesz/txtdirect","owner":{"login":"dbriesz","id":20975751,"node_id":"MDQ6VXNlcjIwOTc1NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/20975751?v=4","gravatar_id":"","url":"https://api.github.com/users/dbriesz","html_url":"https://github.com/dbriesz","followers_url":"https://api.github.com/users/dbriesz/followers","following_url":"https://api.github.com/users/dbriesz/following{/other_user}","gists_url":"https://api.github.com/users/dbriesz/gists{/gist_id}","starred_url":"https://api.github.com/users/dbriesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbriesz/subscriptions","organizations_url":"https://api.github.com/users/dbriesz/orgs","repos_url":"https://api.github.com/users/dbriesz/repos","events_url":"https://api.github.com/users/dbriesz/events{/privacy}","received_events_url":"https://api.github.com/users/dbriesz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbriesz/txtdirect","description":"DNS TXT-record based redirects","fork":true,"url":"https://api.github.com/repos/dbriesz/txtdirect","forks_url":"https://api.github.com/repos/dbriesz/txtdirect/forks","keys_url":"https://api.github.com/repos/dbriesz/txtdirect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbriesz/txtdirect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbriesz/txtdirect/teams","hooks_url":"https://api.github.com/repos/dbriesz/txtdirect/hooks","issue_events_url":"https://api.github.com/repos/dbriesz/txtdirect/issues/events{/number}","events_url":"https://api.github.com/repos/dbriesz/txtdirect/events","assignees_url":"https://api.github.com/repos/dbriesz/txtdirect/assignees{/user}","branches_url":"https://api.github.com/repos/dbriesz/txtdirect/branches{/branch}","tags_url":"https://api.github.com/repos/dbriesz/txtdirect/tags","blobs_url":"https://api.github.com/repos/dbriesz/txtdirect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbriesz/txtdirect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbriesz/txtdirect/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbriesz/txtdirect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbriesz/txtdirect/statuses/{sha}","languages_url":"https://api.github.com/repos/dbriesz/txtdirect/languages","stargazers_url":"https://api.github.com/repos/dbriesz/txtdirect/stargazers","contributors_url":"https://api.github.com/repos/dbriesz/txtdirect/contributors","subscribers_url":"https://api.github.com/repos/dbriesz/txtdirect/subscribers","subscription_url":"https://api.github.com/repos/dbriesz/txtdirect/subscription","commits_url":"https://api.github.com/repos/dbriesz/txtdirect/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbriesz/txtdirect/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbriesz/txtdirect/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbriesz/txtdirect/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbriesz/txtdirect/contents/{+path}","compare_url":"https://api.github.com/repos/dbriesz/txtdirect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbriesz/txtdirect/merges","archive_url":"https://api.github.com/repos/dbriesz/txtdirect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbriesz/txtdirect/downloads","issues_url":"https://api.github.com/repos/dbriesz/txtdirect/issues{/number}","pulls_url":"https://api.github.com/repos/dbriesz/txtdirect/pulls{/number}","milestones_url":"https://api.github.com/repos/dbriesz/txtdirect/milestones{/number}","notifications_url":"https://api.github.com/repos/dbriesz/txtdirect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbriesz/txtdirect/labels{/name}","releases_url":"https://api.github.com/repos/dbriesz/txtdirect/releases{/id}","deployments_url":"https://api.github.com/repos/dbriesz/txtdirect/deployments","created_at":"2018-04-05T21:36:19Z","updated_at":"2018-06-04T21:54:21Z","pushed_at":"2018-07-05T00:10:50Z","git_url":"git://github.com/dbriesz/txtdirect.git","ssh_url":"git@github.com:dbriesz/txtdirect.git","clone_url":"https://github.com/dbriesz/txtdirect.git","svn_url":"https://github.com/dbriesz/txtdirect","homepage":"https://about.txtdirect.org","size":120,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"txtdirect:master","ref":"master","sha":"cec6e361cda002563713cdce619cb5e20230721c","user":{"login":"txtdirect","id":29709653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzA5NjUz","avatar_url":"https://avatars1.githubusercontent.com/u/29709653?v=4","gravatar_id":"","url":"https://api.github.com/users/txtdirect","html_url":"https://github.com/txtdirect","followers_url":"https://api.github.com/users/txtdirect/followers","following_url":"https://api.github.com/users/txtdirect/following{/other_user}","gists_url":"https://api.github.com/users/txtdirect/gists{/gist_id}","starred_url":"https://api.github.com/users/txtdirect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txtdirect/subscriptions","organizations_url":"https://api.github.com/users/txtdirect/orgs","repos_url":"https://api.github.com/users/txtdirect/repos","events_url":"https://api.github.com/users/txtdirect/events{/privacy}","received_events_url":"https://api.github.com/users/txtdirect/received_events","type":"Organization","site_admin":false},"repo":{"id":100856271,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA4NTYyNzE=","name":"txtdirect","full_name":"txtdirect/txtdirect","owner":{"login":"txtdirect","id":29709653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzA5NjUz","avatar_url":"https://avatars1.githubusercontent.com/u/29709653?v=4","gravatar_id":"","url":"https://api.github.com/users/txtdirect","html_url":"https://github.com/txtdirect","followers_url":"https://api.github.com/users/txtdirect/followers","following_url":"https://api.github.com/users/txtdirect/following{/other_user}","gists_url":"https://api.github.com/users/txtdirect/gists{/gist_id}","starred_url":"https://api.github.com/users/txtdirect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txtdirect/subscriptions","organizations_url":"https://api.github.com/users/txtdirect/orgs","repos_url":"https://api.github.com/users/txtdirect/repos","events_url":"https://api.github.com/users/txtdirect/events{/privacy}","received_events_url":"https://api.github.com/users/txtdirect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/txtdirect/txtdirect","description":"DNS TXT-record based redirects","fork":false,"url":"https://api.github.com/repos/txtdirect/txtdirect","forks_url":"https://api.github.com/repos/txtdirect/txtdirect/forks","keys_url":"https://api.github.com/repos/txtdirect/txtdirect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/txtdirect/txtdirect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/txtdirect/txtdirect/teams","hooks_url":"https://api.github.com/repos/txtdirect/txtdirect/hooks","issue_events_url":"https://api.github.com/repos/txtdirect/txtdirect/issues/events{/number}","events_url":"https://api.github.com/repos/txtdirect/txtdirect/events","assignees_url":"https://api.github.com/repos/txtdirect/txtdirect/assignees{/user}","branches_url":"https://api.github.com/repos/txtdirect/txtdirect/branches{/branch}","tags_url":"https://api.github.com/repos/txtdirect/txtdirect/tags","blobs_url":"https://api.github.com/repos/txtdirect/txtdirect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/txtdirect/txtdirect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/txtdirect/txtdirect/git/refs{/sha}","trees_url":"https://api.github.com/repos/txtdirect/txtdirect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/txtdirect/txtdirect/statuses/{sha}","languages_url":"https://api.github.com/repos/txtdirect/txtdirect/languages","stargazers_url":"https://api.github.com/repos/txtdirect/txtdirect/stargazers","contributors_url":"https://api.github.com/repos/txtdirect/txtdirect/contributors","subscribers_url":"https://api.github.com/repos/txtdirect/txtdirect/subscribers","subscription_url":"https://api.github.com/repos/txtdirect/txtdirect/subscription","commits_url":"https://api.github.com/repos/txtdirect/txtdirect/commits{/sha}","git_commits_url":"https://api.github.com/repos/txtdirect/txtdirect/git/commits{/sha}","comments_url":"https://api.github.com/repos/txtdirect/txtdirect/comments{/number}","issue_comment_url":"https://api.github.com/repos/txtdirect/txtdirect/issues/comments{/number}","contents_url":"https://api.github.com/repos/txtdirect/txtdirect/contents/{+path}","compare_url":"https://api.github.com/repos/txtdirect/txtdirect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/txtdirect/txtdirect/merges","archive_url":"https://api.github.com/repos/txtdirect/txtdirect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/txtdirect/txtdirect/downloads","issues_url":"https://api.github.com/repos/txtdirect/txtdirect/issues{/number}","pulls_url":"https://api.github.com/repos/txtdirect/txtdirect/pulls{/number}","milestones_url":"https://api.github.com/repos/txtdirect/txtdirect/milestones{/number}","notifications_url":"https://api.github.com/repos/txtdirect/txtdirect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/txtdirect/txtdirect/labels{/name}","releases_url":"https://api.github.com/repos/txtdirect/txtdirect/releases{/id}","deployments_url":"https://api.github.com/repos/txtdirect/txtdirect/deployments","created_at":"2017-08-20T11:13:30Z","updated_at":"2018-06-21T03:23:22Z","pushed_at":"2018-07-05T00:10:51Z","git_url":"git://github.com/txtdirect/txtdirect.git","ssh_url":"git@github.com:txtdirect/txtdirect.git","clone_url":"https://github.com/txtdirect/txtdirect.git","svn_url":"https://github.com/txtdirect/txtdirect","homepage":"https://about.txtdirect.org","size":117,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":20,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/txtdirect/txtdirect/pulls/54"},"html":{"href":"https://github.com/txtdirect/txtdirect/pull/54"},"issue":{"href":"https://api.github.com/repos/txtdirect/txtdirect/issues/54"},"comments":{"href":"https://api.github.com/repos/txtdirect/txtdirect/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/txtdirect/txtdirect/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/txtdirect/txtdirect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/txtdirect/txtdirect/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/txtdirect/txtdirect/statuses/c44f78ea9eb6104ca6da9b1141ab40b35f96b3f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dbriesz"}}