{"action":"closed","number":2231,"pull_request":{"url":"https://api.github.com/repos/studentinsights/studentinsights/pulls/2231","id":227984816,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTg0ODE2","html_url":"https://github.com/studentinsights/studentinsights/pull/2231","diff_url":"https://github.com/studentinsights/studentinsights/pull/2231.diff","patch_url":"https://github.com/studentinsights/studentinsights/pull/2231.patch","issue_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/2231","number":2231,"state":"closed","locked":false,"title":"Profile: Update discipline incidents to use same FeedCard UI, add in time","user":{"login":"kevinrobinson","id":1056957,"node_id":"MDQ6VXNlcjEwNTY5NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1056957?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinrobinson","html_url":"https://github.com/kevinrobinson","followers_url":"https://api.github.com/users/kevinrobinson/followers","following_url":"https://api.github.com/users/kevinrobinson/following{/other_user}","gists_url":"https://api.github.com/users/kevinrobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinrobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinrobinson/subscriptions","organizations_url":"https://api.github.com/users/kevinrobinson/orgs","repos_url":"https://api.github.com/users/kevinrobinson/repos","events_url":"https://api.github.com/users/kevinrobinson/events{/privacy}","received_events_url":"https://api.github.com/users/kevinrobinson/received_events","type":"User","site_admin":false},"body":"# Who is this PR for?\r\ndevelopers, admin educators\r\n\r\n# What problem does this PR fix?\r\nThere's some old duplication between how this is displayed; this part of the UI hasn't been updated in a while despite a newer `<IncidentCard/>` existing.  Separately, admin educators have asked to see time in individual incidents, since this is available in the prototype analysis page.  Time isn't visible now.\r\n\r\n# What does this PR do?\r\nRemoves the older `<IncidentCard/>` and replaces the controller and UI code with the code that does this for the feed.\r\n\r\nUpdates the color of the tag to align with the profile page colors, add a gray background to the card to distinguish this at-a-glance visually from the home page feed.  And add in the time (which will likely reveal data quality issues at the time of data entry).  The card format also emphasizes the narrative over the codes, which can help with questions about coding that folks are looking at.\r\n\r\n# Screenshot (if adding a client-side feature)\r\n### before\r\n<img width=\"1114\" alt=\"screen shot 2018-11-02 at 11 59 45 am\" src=\"https://user-images.githubusercontent.com/1056957/47926572-455dc000-de97-11e8-9cd2-013c2f7ac644.png\">\r\n\r\n### after\r\n<img width=\"1115\" alt=\"screen shot 2018-11-02 at 11 58 00 am\" src=\"https://user-images.githubusercontent.com/1056957/47926576-47278380-de97-11e8-9711-0bb86b8380fd.png\">\r\n\r\n# Checklists\r\n*Which features or pages does this PR touch?*\r\n+ [x] Student Profile\r\n\r\n*Does this PR use tests to help verify we can deploy these changes quickly and confidently?*\r\n+ [x] Included specs for changes\r\n+ [x] Improved specs for existing code in need of better test coverage","created_at":"2018-11-02T16:04:15Z","updated_at":"2018-11-02T16:21:45Z","closed_at":"2018-11-02T16:21:45Z","merged_at":"2018-11-02T16:21:44Z","merge_commit_sha":"66d6b57165f40600ea2f24dd2d5860ec6a211753","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/studentinsights/studentinsights/pulls/2231/commits","review_comments_url":"https://api.github.com/repos/studentinsights/studentinsights/pulls/2231/comments","review_comment_url":"https://api.github.com/repos/studentinsights/studentinsights/pulls/comments{/number}","comments_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/2231/comments","statuses_url":"https://api.github.com/repos/studentinsights/studentinsights/statuses/04312d64c55ca95f7efb97f9924ab6fc5d10b228","head":{"label":"studentinsights:patch/discipline-clean-slate-list","ref":"patch/discipline-clean-slate-list","sha":"04312d64c55ca95f7efb97f9924ab6fc5d10b228","user":{"login":"studentinsights","id":17129837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTI5ODM3","avatar_url":"https://avatars2.githubusercontent.com/u/17129837?v=4","gravatar_id":"","url":"https://api.github.com/users/studentinsights","html_url":"https://github.com/studentinsights","followers_url":"https://api.github.com/users/studentinsights/followers","following_url":"https://api.github.com/users/studentinsights/following{/other_user}","gists_url":"https://api.github.com/users/studentinsights/gists{/gist_id}","starred_url":"https://api.github.com/users/studentinsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studentinsights/subscriptions","organizations_url":"https://api.github.com/users/studentinsights/orgs","repos_url":"https://api.github.com/users/studentinsights/repos","events_url":"https://api.github.com/users/studentinsights/events{/privacy}","received_events_url":"https://api.github.com/users/studentinsights/received_events","type":"Organization","site_admin":false},"repo":{"id":51324046,"node_id":"MDEwOlJlcG9zaXRvcnk1MTMyNDA0Ng==","name":"studentinsights","full_name":"studentinsights/studentinsights","private":false,"owner":{"login":"studentinsights","id":17129837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTI5ODM3","avatar_url":"https://avatars2.githubusercontent.com/u/17129837?v=4","gravatar_id":"","url":"https://api.github.com/users/studentinsights","html_url":"https://github.com/studentinsights","followers_url":"https://api.github.com/users/studentinsights/followers","following_url":"https://api.github.com/users/studentinsights/following{/other_user}","gists_url":"https://api.github.com/users/studentinsights/gists{/gist_id}","starred_url":"https://api.github.com/users/studentinsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studentinsights/subscriptions","organizations_url":"https://api.github.com/users/studentinsights/orgs","repos_url":"https://api.github.com/users/studentinsights/repos","events_url":"https://api.github.com/users/studentinsights/events{/privacy}","received_events_url":"https://api.github.com/users/studentinsights/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/studentinsights/studentinsights","description":"Student Insights for Somerville, New Bedford and Bedford educators","fork":false,"url":"https://api.github.com/repos/studentinsights/studentinsights","forks_url":"https://api.github.com/repos/studentinsights/studentinsights/forks","keys_url":"https://api.github.com/repos/studentinsights/studentinsights/keys{/key_id}","collaborators_url":"https://api.github.com/repos/studentinsights/studentinsights/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/studentinsights/studentinsights/teams","hooks_url":"https://api.github.com/repos/studentinsights/studentinsights/hooks","issue_events_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/events{/number}","events_url":"https://api.github.com/repos/studentinsights/studentinsights/events","assignees_url":"https://api.github.com/repos/studentinsights/studentinsights/assignees{/user}","branches_url":"https://api.github.com/repos/studentinsights/studentinsights/branches{/branch}","tags_url":"https://api.github.com/repos/studentinsights/studentinsights/tags","blobs_url":"https://api.github.com/repos/studentinsights/studentinsights/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/studentinsights/studentinsights/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/studentinsights/studentinsights/git/refs{/sha}","trees_url":"https://api.github.com/repos/studentinsights/studentinsights/git/trees{/sha}","statuses_url":"https://api.github.com/repos/studentinsights/studentinsights/statuses/{sha}","languages_url":"https://api.github.com/repos/studentinsights/studentinsights/languages","stargazers_url":"https://api.github.com/repos/studentinsights/studentinsights/stargazers","contributors_url":"https://api.github.com/repos/studentinsights/studentinsights/contributors","subscribers_url":"https://api.github.com/repos/studentinsights/studentinsights/subscribers","subscription_url":"https://api.github.com/repos/studentinsights/studentinsights/subscription","commits_url":"https://api.github.com/repos/studentinsights/studentinsights/commits{/sha}","git_commits_url":"https://api.github.com/repos/studentinsights/studentinsights/git/commits{/sha}","comments_url":"https://api.github.com/repos/studentinsights/studentinsights/comments{/number}","issue_comment_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/comments{/number}","contents_url":"https://api.github.com/repos/studentinsights/studentinsights/contents/{+path}","compare_url":"https://api.github.com/repos/studentinsights/studentinsights/compare/{base}...{head}","merges_url":"https://api.github.com/repos/studentinsights/studentinsights/merges","archive_url":"https://api.github.com/repos/studentinsights/studentinsights/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/studentinsights/studentinsights/downloads","issues_url":"https://api.github.com/repos/studentinsights/studentinsights/issues{/number}","pulls_url":"https://api.github.com/repos/studentinsights/studentinsights/pulls{/number}","milestones_url":"https://api.github.com/repos/studentinsights/studentinsights/milestones{/number}","notifications_url":"https://api.github.com/repos/studentinsights/studentinsights/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/studentinsights/studentinsights/labels{/name}","releases_url":"https://api.github.com/repos/studentinsights/studentinsights/releases{/id}","deployments_url":"https://api.github.com/repos/studentinsights/studentinsights/deployments","created_at":"2016-02-08T20:15:35Z","updated_at":"2018-11-02T15:16:24Z","pushed_at":"2018-11-02T16:21:44Z","git_url":"git://github.com/studentinsights/studentinsights.git","ssh_url":"git@github.com:studentinsights/studentinsights.git","clone_url":"https://github.com/studentinsights/studentinsights.git","svn_url":"https://github.com/studentinsights/studentinsights","homepage":"https://somerville-teacher-tool-demo.herokuapp.com/","size":21197,"stargazers_count":97,"watchers_count":97,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":46,"open_issues":107,"watchers":97,"default_branch":"master"}},"base":{"label":"studentinsights:master","ref":"master","sha":"05bdf97a1bb29fcd345259b2a42220c881b4f95a","user":{"login":"studentinsights","id":17129837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTI5ODM3","avatar_url":"https://avatars2.githubusercontent.com/u/17129837?v=4","gravatar_id":"","url":"https://api.github.com/users/studentinsights","html_url":"https://github.com/studentinsights","followers_url":"https://api.github.com/users/studentinsights/followers","following_url":"https://api.github.com/users/studentinsights/following{/other_user}","gists_url":"https://api.github.com/users/studentinsights/gists{/gist_id}","starred_url":"https://api.github.com/users/studentinsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studentinsights/subscriptions","organizations_url":"https://api.github.com/users/studentinsights/orgs","repos_url":"https://api.github.com/users/studentinsights/repos","events_url":"https://api.github.com/users/studentinsights/events{/privacy}","received_events_url":"https://api.github.com/users/studentinsights/received_events","type":"Organization","site_admin":false},"repo":{"id":51324046,"node_id":"MDEwOlJlcG9zaXRvcnk1MTMyNDA0Ng==","name":"studentinsights","full_name":"studentinsights/studentinsights","private":false,"owner":{"login":"studentinsights","id":17129837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTI5ODM3","avatar_url":"https://avatars2.githubusercontent.com/u/17129837?v=4","gravatar_id":"","url":"https://api.github.com/users/studentinsights","html_url":"https://github.com/studentinsights","followers_url":"https://api.github.com/users/studentinsights/followers","following_url":"https://api.github.com/users/studentinsights/following{/other_user}","gists_url":"https://api.github.com/users/studentinsights/gists{/gist_id}","starred_url":"https://api.github.com/users/studentinsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studentinsights/subscriptions","organizations_url":"https://api.github.com/users/studentinsights/orgs","repos_url":"https://api.github.com/users/studentinsights/repos","events_url":"https://api.github.com/users/studentinsights/events{/privacy}","received_events_url":"https://api.github.com/users/studentinsights/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/studentinsights/studentinsights","description":"Student Insights for Somerville, New Bedford and Bedford educators","fork":false,"url":"https://api.github.com/repos/studentinsights/studentinsights","forks_url":"https://api.github.com/repos/studentinsights/studentinsights/forks","keys_url":"https://api.github.com/repos/studentinsights/studentinsights/keys{/key_id}","collaborators_url":"https://api.github.com/repos/studentinsights/studentinsights/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/studentinsights/studentinsights/teams","hooks_url":"https://api.github.com/repos/studentinsights/studentinsights/hooks","issue_events_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/events{/number}","events_url":"https://api.github.com/repos/studentinsights/studentinsights/events","assignees_url":"https://api.github.com/repos/studentinsights/studentinsights/assignees{/user}","branches_url":"https://api.github.com/repos/studentinsights/studentinsights/branches{/branch}","tags_url":"https://api.github.com/repos/studentinsights/studentinsights/tags","blobs_url":"https://api.github.com/repos/studentinsights/studentinsights/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/studentinsights/studentinsights/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/studentinsights/studentinsights/git/refs{/sha}","trees_url":"https://api.github.com/repos/studentinsights/studentinsights/git/trees{/sha}","statuses_url":"https://api.github.com/repos/studentinsights/studentinsights/statuses/{sha}","languages_url":"https://api.github.com/repos/studentinsights/studentinsights/languages","stargazers_url":"https://api.github.com/repos/studentinsights/studentinsights/stargazers","contributors_url":"https://api.github.com/repos/studentinsights/studentinsights/contributors","subscribers_url":"https://api.github.com/repos/studentinsights/studentinsights/subscribers","subscription_url":"https://api.github.com/repos/studentinsights/studentinsights/subscription","commits_url":"https://api.github.com/repos/studentinsights/studentinsights/commits{/sha}","git_commits_url":"https://api.github.com/repos/studentinsights/studentinsights/git/commits{/sha}","comments_url":"https://api.github.com/repos/studentinsights/studentinsights/comments{/number}","issue_comment_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/comments{/number}","contents_url":"https://api.github.com/repos/studentinsights/studentinsights/contents/{+path}","compare_url":"https://api.github.com/repos/studentinsights/studentinsights/compare/{base}...{head}","merges_url":"https://api.github.com/repos/studentinsights/studentinsights/merges","archive_url":"https://api.github.com/repos/studentinsights/studentinsights/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/studentinsights/studentinsights/downloads","issues_url":"https://api.github.com/repos/studentinsights/studentinsights/issues{/number}","pulls_url":"https://api.github.com/repos/studentinsights/studentinsights/pulls{/number}","milestones_url":"https://api.github.com/repos/studentinsights/studentinsights/milestones{/number}","notifications_url":"https://api.github.com/repos/studentinsights/studentinsights/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/studentinsights/studentinsights/labels{/name}","releases_url":"https://api.github.com/repos/studentinsights/studentinsights/releases{/id}","deployments_url":"https://api.github.com/repos/studentinsights/studentinsights/deployments","created_at":"2016-02-08T20:15:35Z","updated_at":"2018-11-02T15:16:24Z","pushed_at":"2018-11-02T16:21:44Z","git_url":"git://github.com/studentinsights/studentinsights.git","ssh_url":"git@github.com:studentinsights/studentinsights.git","clone_url":"https://github.com/studentinsights/studentinsights.git","svn_url":"https://github.com/studentinsights/studentinsights","homepage":"https://somerville-teacher-tool-demo.herokuapp.com/","size":21197,"stargazers_count":97,"watchers_count":97,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":46,"open_issues":107,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/studentinsights/studentinsights/pulls/2231"},"html":{"href":"https://github.com/studentinsights/studentinsights/pull/2231"},"issue":{"href":"https://api.github.com/repos/studentinsights/studentinsights/issues/2231"},"comments":{"href":"https://api.github.com/repos/studentinsights/studentinsights/issues/2231/comments"},"review_comments":{"href":"https://api.github.com/repos/studentinsights/studentinsights/pulls/2231/comments"},"review_comment":{"href":"https://api.github.com/repos/studentinsights/studentinsights/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/studentinsights/studentinsights/pulls/2231/commits"},"statuses":{"href":"https://api.github.com/repos/studentinsights/studentinsights/statuses/04312d64c55ca95f7efb97f9924ab6fc5d10b228"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kevinrobinson","id":1056957,"node_id":"MDQ6VXNlcjEwNTY5NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1056957?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinrobinson","html_url":"https://github.com/kevinrobinson","followers_url":"https://api.github.com/users/kevinrobinson/followers","following_url":"https://api.github.com/users/kevinrobinson/following{/other_user}","gists_url":"https://api.github.com/users/kevinrobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinrobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinrobinson/subscriptions","organizations_url":"https://api.github.com/users/kevinrobinson/orgs","repos_url":"https://api.github.com/users/kevinrobinson/repos","events_url":"https://api.github.com/users/kevinrobinson/events{/privacy}","received_events_url":"https://api.github.com/users/kevinrobinson/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":62,"deletions":118,"changed_files":10}}
{"actor":{"display_login":"kevinrobinson"}}