{"action":"created","comment":{"url":"https://api.github.com/repos/buzzfeed/sso/pulls/comments/212342817","pull_request_review_id":148953442,"id":212342817,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjM0MjgxNw==","diff_hunk":"@@ -0,0 +1,143 @@\n+version: '3'\n+\n+services:\n+  # ===========================================================================\n+  # sso services\n+  #\n+  # Here we provide a minimal sso installation for demo purposes that allows\n+  # any valid google account to log in, and hard codes the various secrets\n+  # required to secure communication.\n+  #\n+  # A more realistic deployment will likely require a specific organization's\n+  # email domain and restrict access to upstream services based on Google Group\n+  # membership.\n+  #\n+  # The sso-proxy service is handing requests to any domain under\n+  # *.sso.localtest.me and the sso-auth service is available at sso-\n+  # auth.localtest.me.\n+  #\n+  # There are two upstream services defined below, which can be accessed at\n+  #  - http://hello-world.sso.localtest.me\n+  #  - http://httpbin.sso.localtest.me\n+  # ===========================================================================\n+  sso-proxy:\n+    image: buzzfeed/sso:latest # change this to `build: ..` to try local changes\n+    entrypoint: /bin/sso-proxy","path":"quickstart/docker-compose.yml","position":25,"original_position":25,"commit_id":"f859809ddab148a62510b8ce3ebe7d060de204d5","original_commit_id":"bdff60c58a12427c455959e08ddd817fab1f59c1","user":{"login":"mccutchen","id":57938,"node_id":"MDQ6VXNlcjU3OTM4","avatar_url":"https://avatars0.githubusercontent.com/u/57938?v=4","gravatar_id":"","url":"https://api.github.com/users/mccutchen","html_url":"https://github.com/mccutchen","followers_url":"https://api.github.com/users/mccutchen/followers","following_url":"https://api.github.com/users/mccutchen/following{/other_user}","gists_url":"https://api.github.com/users/mccutchen/gists{/gist_id}","starred_url":"https://api.github.com/users/mccutchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccutchen/subscriptions","organizations_url":"https://api.github.com/users/mccutchen/orgs","repos_url":"https://api.github.com/users/mccutchen/repos","events_url":"https://api.github.com/users/mccutchen/events{/privacy}","received_events_url":"https://api.github.com/users/mccutchen/received_events","type":"User","site_admin":false},"body":"@danbf I'm pretty sure this is an indication that you're not actually running the latest docker image","created_at":"2018-08-23T14:58:04Z","updated_at":"2018-08-23T14:58:04Z","html_url":"https://github.com/buzzfeed/sso/pull/23#discussion_r212342817","pull_request_url":"https://api.github.com/repos/buzzfeed/sso/pulls/23","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/buzzfeed/sso/pulls/comments/212342817"},"html":{"href":"https://github.com/buzzfeed/sso/pull/23#discussion_r212342817"},"pull_request":{"href":"https://api.github.com/repos/buzzfeed/sso/pulls/23"}},"in_reply_to_id":212335522},"pull_request":{"url":"https://api.github.com/repos/buzzfeed/sso/pulls/23","id":210455660,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDU1NjYw","html_url":"https://github.com/buzzfeed/sso/pull/23","diff_url":"https://github.com/buzzfeed/sso/pull/23.diff","patch_url":"https://github.com/buzzfeed/sso/pull/23.patch","issue_url":"https://api.github.com/repos/buzzfeed/sso/issues/23","number":23,"state":"open","locked":false,"title":"docs: add quickstart & document google provider setup","user":{"login":"mccutchen","id":57938,"node_id":"MDQ6VXNlcjU3OTM4","avatar_url":"https://avatars0.githubusercontent.com/u/57938?v=4","gravatar_id":"","url":"https://api.github.com/users/mccutchen","html_url":"https://github.com/mccutchen","followers_url":"https://api.github.com/users/mccutchen/followers","following_url":"https://api.github.com/users/mccutchen/following{/other_user}","gists_url":"https://api.github.com/users/mccutchen/gists{/gist_id}","starred_url":"https://api.github.com/users/mccutchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccutchen/subscriptions","organizations_url":"https://api.github.com/users/mccutchen/orgs","repos_url":"https://api.github.com/users/mccutchen/repos","events_url":"https://api.github.com/users/mccutchen/events{/privacy}","received_events_url":"https://api.github.com/users/mccutchen/received_events","type":"User","site_admin":false},"body":"This builds on @danbf and @katzdm's work in https://github.com/buzzfeed/sso/pull/18 to provide:\r\n - Standalone documentation of the Google provider setup process\r\n - A relatively simple quickstart process that uses `docker-compose` to spin up an example deployment of `sso` and two secured upstream services\r\n\r\nRFR @buzzfeed/infra-security ","created_at":"2018-08-23T13:51:43Z","updated_at":"2018-08-23T14:58:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0280c1c54734582cc785ec00a202db6252bae908","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/buzzfeed/sso/pulls/23/commits","review_comments_url":"https://api.github.com/repos/buzzfeed/sso/pulls/23/comments","review_comment_url":"https://api.github.com/repos/buzzfeed/sso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buzzfeed/sso/issues/23/comments","statuses_url":"https://api.github.com/repos/buzzfeed/sso/statuses/f859809ddab148a62510b8ce3ebe7d060de204d5","head":{"label":"buzzfeed:quickstart-tweaks","ref":"quickstart-tweaks","sha":"f859809ddab148a62510b8ce3ebe7d060de204d5","user":{"login":"buzzfeed","id":1781305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODEzMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1781305?v=4","gravatar_id":"","url":"https://api.github.com/users/buzzfeed","html_url":"https://github.com/buzzfeed","followers_url":"https://api.github.com/users/buzzfeed/followers","following_url":"https://api.github.com/users/buzzfeed/following{/other_user}","gists_url":"https://api.github.com/users/buzzfeed/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzfeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzfeed/subscriptions","organizations_url":"https://api.github.com/users/buzzfeed/orgs","repos_url":"https://api.github.com/users/buzzfeed/repos","events_url":"https://api.github.com/users/buzzfeed/events{/privacy}","received_events_url":"https://api.github.com/users/buzzfeed/received_events","type":"Organization","site_admin":false},"repo":{"id":145011089,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwMTEwODk=","name":"sso","full_name":"buzzfeed/sso","owner":{"login":"buzzfeed","id":1781305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODEzMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1781305?v=4","gravatar_id":"","url":"https://api.github.com/users/buzzfeed","html_url":"https://github.com/buzzfeed","followers_url":"https://api.github.com/users/buzzfeed/followers","following_url":"https://api.github.com/users/buzzfeed/following{/other_user}","gists_url":"https://api.github.com/users/buzzfeed/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzfeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzfeed/subscriptions","organizations_url":"https://api.github.com/users/buzzfeed/orgs","repos_url":"https://api.github.com/users/buzzfeed/repos","events_url":"https://api.github.com/users/buzzfeed/events{/privacy}","received_events_url":"https://api.github.com/users/buzzfeed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buzzfeed/sso","description":"sso, aka S.S.Octopus, aka octoboi, is a single-sign on solution for securing internal services","fork":false,"url":"https://api.github.com/repos/buzzfeed/sso","forks_url":"https://api.github.com/repos/buzzfeed/sso/forks","keys_url":"https://api.github.com/repos/buzzfeed/sso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buzzfeed/sso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buzzfeed/sso/teams","hooks_url":"https://api.github.com/repos/buzzfeed/sso/hooks","issue_events_url":"https://api.github.com/repos/buzzfeed/sso/issues/events{/number}","events_url":"https://api.github.com/repos/buzzfeed/sso/events","assignees_url":"https://api.github.com/repos/buzzfeed/sso/assignees{/user}","branches_url":"https://api.github.com/repos/buzzfeed/sso/branches{/branch}","tags_url":"https://api.github.com/repos/buzzfeed/sso/tags","blobs_url":"https://api.github.com/repos/buzzfeed/sso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buzzfeed/sso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buzzfeed/sso/git/refs{/sha}","trees_url":"https://api.github.com/repos/buzzfeed/sso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buzzfeed/sso/statuses/{sha}","languages_url":"https://api.github.com/repos/buzzfeed/sso/languages","stargazers_url":"https://api.github.com/repos/buzzfeed/sso/stargazers","contributors_url":"https://api.github.com/repos/buzzfeed/sso/contributors","subscribers_url":"https://api.github.com/repos/buzzfeed/sso/subscribers","subscription_url":"https://api.github.com/repos/buzzfeed/sso/subscription","commits_url":"https://api.github.com/repos/buzzfeed/sso/commits{/sha}","git_commits_url":"https://api.github.com/repos/buzzfeed/sso/git/commits{/sha}","comments_url":"https://api.github.com/repos/buzzfeed/sso/comments{/number}","issue_comment_url":"https://api.github.com/repos/buzzfeed/sso/issues/comments{/number}","contents_url":"https://api.github.com/repos/buzzfeed/sso/contents/{+path}","compare_url":"https://api.github.com/repos/buzzfeed/sso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buzzfeed/sso/merges","archive_url":"https://api.github.com/repos/buzzfeed/sso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buzzfeed/sso/downloads","issues_url":"https://api.github.com/repos/buzzfeed/sso/issues{/number}","pulls_url":"https://api.github.com/repos/buzzfeed/sso/pulls{/number}","milestones_url":"https://api.github.com/repos/buzzfeed/sso/milestones{/number}","notifications_url":"https://api.github.com/repos/buzzfeed/sso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buzzfeed/sso/labels{/name}","releases_url":"https://api.github.com/repos/buzzfeed/sso/releases{/id}","deployments_url":"https://api.github.com/repos/buzzfeed/sso/deployments","created_at":"2018-08-16T16:06:36Z","updated_at":"2018-08-23T14:50:45Z","pushed_at":"2018-08-23T14:55:17Z","git_url":"git://github.com/buzzfeed/sso.git","ssh_url":"git@github.com:buzzfeed/sso.git","clone_url":"https://github.com/buzzfeed/sso.git","svn_url":"https://github.com/buzzfeed/sso","homepage":"","size":1246,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":15,"watchers":14,"default_branch":"master"}},"base":{"label":"buzzfeed:master","ref":"master","sha":"f14094053a63fb1f658c8b1ebfb993e1f6a4cfae","user":{"login":"buzzfeed","id":1781305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODEzMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1781305?v=4","gravatar_id":"","url":"https://api.github.com/users/buzzfeed","html_url":"https://github.com/buzzfeed","followers_url":"https://api.github.com/users/buzzfeed/followers","following_url":"https://api.github.com/users/buzzfeed/following{/other_user}","gists_url":"https://api.github.com/users/buzzfeed/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzfeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzfeed/subscriptions","organizations_url":"https://api.github.com/users/buzzfeed/orgs","repos_url":"https://api.github.com/users/buzzfeed/repos","events_url":"https://api.github.com/users/buzzfeed/events{/privacy}","received_events_url":"https://api.github.com/users/buzzfeed/received_events","type":"Organization","site_admin":false},"repo":{"id":145011089,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwMTEwODk=","name":"sso","full_name":"buzzfeed/sso","owner":{"login":"buzzfeed","id":1781305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODEzMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1781305?v=4","gravatar_id":"","url":"https://api.github.com/users/buzzfeed","html_url":"https://github.com/buzzfeed","followers_url":"https://api.github.com/users/buzzfeed/followers","following_url":"https://api.github.com/users/buzzfeed/following{/other_user}","gists_url":"https://api.github.com/users/buzzfeed/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzfeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzfeed/subscriptions","organizations_url":"https://api.github.com/users/buzzfeed/orgs","repos_url":"https://api.github.com/users/buzzfeed/repos","events_url":"https://api.github.com/users/buzzfeed/events{/privacy}","received_events_url":"https://api.github.com/users/buzzfeed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buzzfeed/sso","description":"sso, aka S.S.Octopus, aka octoboi, is a single-sign on solution for securing internal services","fork":false,"url":"https://api.github.com/repos/buzzfeed/sso","forks_url":"https://api.github.com/repos/buzzfeed/sso/forks","keys_url":"https://api.github.com/repos/buzzfeed/sso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buzzfeed/sso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buzzfeed/sso/teams","hooks_url":"https://api.github.com/repos/buzzfeed/sso/hooks","issue_events_url":"https://api.github.com/repos/buzzfeed/sso/issues/events{/number}","events_url":"https://api.github.com/repos/buzzfeed/sso/events","assignees_url":"https://api.github.com/repos/buzzfeed/sso/assignees{/user}","branches_url":"https://api.github.com/repos/buzzfeed/sso/branches{/branch}","tags_url":"https://api.github.com/repos/buzzfeed/sso/tags","blobs_url":"https://api.github.com/repos/buzzfeed/sso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buzzfeed/sso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buzzfeed/sso/git/refs{/sha}","trees_url":"https://api.github.com/repos/buzzfeed/sso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buzzfeed/sso/statuses/{sha}","languages_url":"https://api.github.com/repos/buzzfeed/sso/languages","stargazers_url":"https://api.github.com/repos/buzzfeed/sso/stargazers","contributors_url":"https://api.github.com/repos/buzzfeed/sso/contributors","subscribers_url":"https://api.github.com/repos/buzzfeed/sso/subscribers","subscription_url":"https://api.github.com/repos/buzzfeed/sso/subscription","commits_url":"https://api.github.com/repos/buzzfeed/sso/commits{/sha}","git_commits_url":"https://api.github.com/repos/buzzfeed/sso/git/commits{/sha}","comments_url":"https://api.github.com/repos/buzzfeed/sso/comments{/number}","issue_comment_url":"https://api.github.com/repos/buzzfeed/sso/issues/comments{/number}","contents_url":"https://api.github.com/repos/buzzfeed/sso/contents/{+path}","compare_url":"https://api.github.com/repos/buzzfeed/sso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buzzfeed/sso/merges","archive_url":"https://api.github.com/repos/buzzfeed/sso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buzzfeed/sso/downloads","issues_url":"https://api.github.com/repos/buzzfeed/sso/issues{/number}","pulls_url":"https://api.github.com/repos/buzzfeed/sso/pulls{/number}","milestones_url":"https://api.github.com/repos/buzzfeed/sso/milestones{/number}","notifications_url":"https://api.github.com/repos/buzzfeed/sso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buzzfeed/sso/labels{/name}","releases_url":"https://api.github.com/repos/buzzfeed/sso/releases{/id}","deployments_url":"https://api.github.com/repos/buzzfeed/sso/deployments","created_at":"2018-08-16T16:06:36Z","updated_at":"2018-08-23T14:50:45Z","pushed_at":"2018-08-23T14:55:17Z","git_url":"git://github.com/buzzfeed/sso.git","ssh_url":"git@github.com:buzzfeed/sso.git","clone_url":"https://github.com/buzzfeed/sso.git","svn_url":"https://github.com/buzzfeed/sso","homepage":"","size":1246,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":15,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buzzfeed/sso/pulls/23"},"html":{"href":"https://github.com/buzzfeed/sso/pull/23"},"issue":{"href":"https://api.github.com/repos/buzzfeed/sso/issues/23"},"comments":{"href":"https://api.github.com/repos/buzzfeed/sso/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/buzzfeed/sso/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/buzzfeed/sso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buzzfeed/sso/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/buzzfeed/sso/statuses/f859809ddab148a62510b8ce3ebe7d060de204d5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mccutchen"}}