{"action":"closed","number":295,"pull_request":{"url":"https://api.github.com/repos/18F/cms-hitech-apd/pulls/295","id":174088031,"html_url":"https://github.com/18F/cms-hitech-apd/pull/295","diff_url":"https://github.com/18F/cms-hitech-apd/pull/295.diff","patch_url":"https://github.com/18F/cms-hitech-apd/pull/295.patch","issue_url":"https://api.github.com/repos/18F/cms-hitech-apd/issues/295","number":295,"state":"closed","locked":false,"title":"Don't let users update the role they belong to","user":{"login":"mgwalker","id":1775733,"avatar_url":"https://avatars3.githubusercontent.com/u/1775733?v=4","gravatar_id":"","url":"https://api.github.com/users/mgwalker","html_url":"https://github.com/mgwalker","followers_url":"https://api.github.com/users/mgwalker/followers","following_url":"https://api.github.com/users/mgwalker/following{/other_user}","gists_url":"https://api.github.com/users/mgwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/mgwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgwalker/subscriptions","organizations_url":"https://api.github.com/users/mgwalker/orgs","repos_url":"https://api.github.com/users/mgwalker/repos","events_url":"https://api.github.com/users/mgwalker/events{/privacy}","received_events_url":"https://api.github.com/users/mgwalker/received_events","type":"User","site_admin":false},"body":"It would be very silly to let users update the list of activities that their role can perform, because then everyone could give themselves all permissions, or accidentally remove all their permissions (which they then couldn't fix!).\r\n\r\nThis PR makes it so people can't just decide what they want to be able to do.\r\n\r\nCloses #222\r\n\r\n### This pull request is ready to merge when...\r\n- [x] Tests have been updated (and all tests are passing)\r\n- [ ] This code has been reviewed by someone other than the original author\r\n- ~~The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented~~\r\n- ~~The change has been documented~~\r\n  - ~~Associated OpenAPI documentation has been updated~~\r\n\r\n### This feature is done when...\r\n- ~~Design has approved the experience~~\r\n- ~~Product has approved the experience~~\r\n","created_at":"2018-03-09T19:27:02Z","updated_at":"2018-03-12T14:03:40Z","closed_at":"2018-03-12T14:03:40Z","merged_at":"2018-03-12T14:03:40Z","merge_commit_sha":"fa18ffebe6204e509fc3fb98a5f34c6e006f3202","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/cms-hitech-apd/pulls/295/commits","review_comments_url":"https://api.github.com/repos/18F/cms-hitech-apd/pulls/295/comments","review_comment_url":"https://api.github.com/repos/18F/cms-hitech-apd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/cms-hitech-apd/issues/295/comments","statuses_url":"https://api.github.com/repos/18F/cms-hitech-apd/statuses/35a07d1f574b058853873b523047243ad1682086","head":{"label":"18F:mgwalker/222-do-not-update-own-role","ref":"mgwalker/222-do-not-update-own-role","sha":"35a07d1f574b058853873b523047243ad1682086","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":113234315,"name":"cms-hitech-apd","full_name":"18F/cms-hitech-apd","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/cms-hitech-apd","description":"Centers for Medicare and Medicaid Services (CMS) HITECH funding request app","fork":false,"url":"https://api.github.com/repos/18F/cms-hitech-apd","forks_url":"https://api.github.com/repos/18F/cms-hitech-apd/forks","keys_url":"https://api.github.com/repos/18F/cms-hitech-apd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/cms-hitech-apd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/cms-hitech-apd/teams","hooks_url":"https://api.github.com/repos/18F/cms-hitech-apd/hooks","issue_events_url":"https://api.github.com/repos/18F/cms-hitech-apd/issues/events{/number}","events_url":"https://api.github.com/repos/18F/cms-hitech-apd/events","assignees_url":"https://api.github.com/repos/18F/cms-hitech-apd/assignees{/user}","branches_url":"https://api.github.com/repos/18F/cms-hitech-apd/branches{/branch}","tags_url":"https://api.github.com/repos/18F/cms-hitech-apd/tags","blobs_url":"https://api.github.com/repos/18F/cms-hitech-apd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/cms-hitech-apd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/cms-hitech-apd/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/cms-hitech-apd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/cms-hitech-apd/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/cms-hitech-apd/languages","stargazers_url":"https://api.github.com/repos/18F/cms-hitech-apd/stargazers","contributors_url":"https://api.github.com/repos/18F/cms-hitech-apd/contributors","subscribers_url":"https://api.github.com/repos/18F/cms-hitech-apd/subscribers","subscription_url":"https://api.github.com/repos/18F/cms-hitech-apd/subscription","commits_url":"https://api.github.com/repos/18F/cms-hitech-apd/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/cms-hitech-apd/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/cms-hitech-apd/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/cms-hitech-apd/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/cms-hitech-apd/contents/{+path}","compare_url":"https://api.github.com/repos/18F/cms-hitech-apd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/cms-hitech-apd/merges","archive_url":"https://api.github.com/repos/18F/cms-hitech-apd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/cms-hitech-apd/downloads","issues_url":"https://api.github.com/repos/18F/cms-hitech-apd/issues{/number}","pulls_url":"https://api.github.com/repos/18F/cms-hitech-apd/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/cms-hitech-apd/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/cms-hitech-apd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/cms-hitech-apd/labels{/name}","releases_url":"https://api.github.com/repos/18F/cms-hitech-apd/releases{/id}","deployments_url":"https://api.github.com/repos/18F/cms-hitech-apd/deployments","created_at":"2017-12-05T21:20:35Z","updated_at":"2018-03-02T19:23:34Z","pushed_at":"2018-03-12T14:03:40Z","git_url":"git://github.com/18F/cms-hitech-apd.git","ssh_url":"git@github.com:18F/cms-hitech-apd.git","clone_url":"https://github.com/18F/cms-hitech-apd.git","svn_url":"https://github.com/18F/cms-hitech-apd","homepage":"","size":1452,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":39,"watchers":6,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"18e6bc49a9aad4a10c524d656748247958512017","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":113234315,"name":"cms-hitech-apd","full_name":"18F/cms-hitech-apd","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/cms-hitech-apd","description":"Centers for Medicare and Medicaid Services (CMS) HITECH funding request app","fork":false,"url":"https://api.github.com/repos/18F/cms-hitech-apd","forks_url":"https://api.github.com/repos/18F/cms-hitech-apd/forks","keys_url":"https://api.github.com/repos/18F/cms-hitech-apd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/cms-hitech-apd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/cms-hitech-apd/teams","hooks_url":"https://api.github.com/repos/18F/cms-hitech-apd/hooks","issue_events_url":"https://api.github.com/repos/18F/cms-hitech-apd/issues/events{/number}","events_url":"https://api.github.com/repos/18F/cms-hitech-apd/events","assignees_url":"https://api.github.com/repos/18F/cms-hitech-apd/assignees{/user}","branches_url":"https://api.github.com/repos/18F/cms-hitech-apd/branches{/branch}","tags_url":"https://api.github.com/repos/18F/cms-hitech-apd/tags","blobs_url":"https://api.github.com/repos/18F/cms-hitech-apd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/cms-hitech-apd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/cms-hitech-apd/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/cms-hitech-apd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/cms-hitech-apd/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/cms-hitech-apd/languages","stargazers_url":"https://api.github.com/repos/18F/cms-hitech-apd/stargazers","contributors_url":"https://api.github.com/repos/18F/cms-hitech-apd/contributors","subscribers_url":"https://api.github.com/repos/18F/cms-hitech-apd/subscribers","subscription_url":"https://api.github.com/repos/18F/cms-hitech-apd/subscription","commits_url":"https://api.github.com/repos/18F/cms-hitech-apd/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/cms-hitech-apd/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/cms-hitech-apd/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/cms-hitech-apd/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/cms-hitech-apd/contents/{+path}","compare_url":"https://api.github.com/repos/18F/cms-hitech-apd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/cms-hitech-apd/merges","archive_url":"https://api.github.com/repos/18F/cms-hitech-apd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/cms-hitech-apd/downloads","issues_url":"https://api.github.com/repos/18F/cms-hitech-apd/issues{/number}","pulls_url":"https://api.github.com/repos/18F/cms-hitech-apd/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/cms-hitech-apd/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/cms-hitech-apd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/cms-hitech-apd/labels{/name}","releases_url":"https://api.github.com/repos/18F/cms-hitech-apd/releases{/id}","deployments_url":"https://api.github.com/repos/18F/cms-hitech-apd/deployments","created_at":"2017-12-05T21:20:35Z","updated_at":"2018-03-02T19:23:34Z","pushed_at":"2018-03-12T14:03:40Z","git_url":"git://github.com/18F/cms-hitech-apd.git","ssh_url":"git@github.com:18F/cms-hitech-apd.git","clone_url":"https://github.com/18F/cms-hitech-apd.git","svn_url":"https://github.com/18F/cms-hitech-apd","homepage":"","size":1452,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":39,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/cms-hitech-apd/pulls/295"},"html":{"href":"https://github.com/18F/cms-hitech-apd/pull/295"},"issue":{"href":"https://api.github.com/repos/18F/cms-hitech-apd/issues/295"},"comments":{"href":"https://api.github.com/repos/18F/cms-hitech-apd/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/cms-hitech-apd/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/cms-hitech-apd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/cms-hitech-apd/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/18F/cms-hitech-apd/statuses/35a07d1f574b058853873b523047243ad1682086"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"brendansudol","id":1060893,"avatar_url":"https://avatars2.githubusercontent.com/u/1060893?v=4","gravatar_id":"","url":"https://api.github.com/users/brendansudol","html_url":"https://github.com/brendansudol","followers_url":"https://api.github.com/users/brendansudol/followers","following_url":"https://api.github.com/users/brendansudol/following{/other_user}","gists_url":"https://api.github.com/users/brendansudol/gists{/gist_id}","starred_url":"https://api.github.com/users/brendansudol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendansudol/subscriptions","organizations_url":"https://api.github.com/users/brendansudol/orgs","repos_url":"https://api.github.com/users/brendansudol/repos","events_url":"https://api.github.com/users/brendansudol/events{/privacy}","received_events_url":"https://api.github.com/users/brendansudol/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":104,"deletions":64,"changed_files":3}}
{"actor":{"display_login":"brendansudol"}}