{"action":"created","issue":{"url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/994","repository_url":"https://api.github.com/repos/gaearon/react-hot-loader","labels_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/994/labels{/name}","comments_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/994/comments","events_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/994/events","html_url":"https://github.com/gaearon/react-hot-loader/pull/994","id":327090894,"number":994,"title":"Fixes #913 - Fix/improve guide for Electron","user":{"login":"s-h-a-d-o-w","id":16936908,"avatar_url":"https://avatars2.githubusercontent.com/u/16936908?v=4","gravatar_id":"","url":"https://api.github.com/users/s-h-a-d-o-w","html_url":"https://github.com/s-h-a-d-o-w","followers_url":"https://api.github.com/users/s-h-a-d-o-w/followers","following_url":"https://api.github.com/users/s-h-a-d-o-w/following{/other_user}","gists_url":"https://api.github.com/users/s-h-a-d-o-w/gists{/gist_id}","starred_url":"https://api.github.com/users/s-h-a-d-o-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-h-a-d-o-w/subscriptions","organizations_url":"https://api.github.com/users/s-h-a-d-o-w/orgs","repos_url":"https://api.github.com/users/s-h-a-d-o-w/repos","events_url":"https://api.github.com/users/s-h-a-d-o-w/events{/privacy}","received_events_url":"https://api.github.com/users/s-h-a-d-o-w/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-28T18:10:19Z","updated_at":"2018-05-28T18:54:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/gaearon/react-hot-loader/pulls/994","html_url":"https://github.com/gaearon/react-hot-loader/pull/994","diff_url":"https://github.com/gaearon/react-hot-loader/pull/994.diff","patch_url":"https://github.com/gaearon/react-hot-loader/pull/994.patch"},"body":"Apologies for the delay. I wanted to see how the situation with electron-compile's HMR would develop before committing to a recommendation.\r\n\r\nAnd I had to come up with a good workflow myself. Because it was only after I submitted issue #913 that I had the fairly banal realization that one could simply view an Electron app like any other web app. And that maybe one should. Most people probably choose to use Electron because they are already familiar with JS. So they've probably already used webpack. Why introduce new tools that at least partly don't work as well as webpack does?\r\n\r\nBut I left the reference to electron-compile in there because it is quite popular, it does require less configuration and some people have argued that webpack should not be used with Electron. (Although they possibly overlook the fact that parse time may still play a role even when a big project is loaded directly from one's hard drive...)"},"comment":{"url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/comments/392586632","html_url":"https://github.com/gaearon/react-hot-loader/pull/994#issuecomment-392586632","issue_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/994","id":392586632,"user":{"login":"s-h-a-d-o-w","id":16936908,"avatar_url":"https://avatars2.githubusercontent.com/u/16936908?v=4","gravatar_id":"","url":"https://api.github.com/users/s-h-a-d-o-w","html_url":"https://github.com/s-h-a-d-o-w","followers_url":"https://api.github.com/users/s-h-a-d-o-w/followers","following_url":"https://api.github.com/users/s-h-a-d-o-w/following{/other_user}","gists_url":"https://api.github.com/users/s-h-a-d-o-w/gists{/gist_id}","starred_url":"https://api.github.com/users/s-h-a-d-o-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-h-a-d-o-w/subscriptions","organizations_url":"https://api.github.com/users/s-h-a-d-o-w/orgs","repos_url":"https://api.github.com/users/s-h-a-d-o-w/repos","events_url":"https://api.github.com/users/s-h-a-d-o-w/events{/privacy}","received_events_url":"https://api.github.com/users/s-h-a-d-o-w/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T18:54:33Z","updated_at":"2018-05-28T18:54:33Z","author_association":"NONE","body":"Hm... I didn't see that and you're obviously right for consistency's sake.\r\n\r\nHowever, I would like to point out that the official way of spelling \"webpack\" is indeed with a lower-case w in the beginning: https://webpack.js.org/concepts/\r\nSo it seems to me that instead, all occurrences of \"Webpack\" in the rest of the README should be changed."}}
{"actor":{"display_login":"s-h-a-d-o-w"}}