{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/169288496","pull_request_review_id":97788012,"id":169288496,"diff_hunk":"@@ -243,6 +266,13 @@ int mbedtls_md2_ret( const unsigned char *input,\n     return( ret );\n }\n \n+void mbedtls_md2( const unsigned char *input,","path":"library/md2.c","position":55,"original_position":55,"commit_id":"661cb977709757747be4162e339aa340e846353d","original_commit_id":"661cb977709757747be4162e339aa340e846353d","user":{"login":"hanno-arm","id":26892988,"avatar_url":"https://avatars1.githubusercontent.com/u/26892988?v=4","gravatar_id":"","url":"https://api.github.com/users/hanno-arm","html_url":"https://github.com/hanno-arm","followers_url":"https://api.github.com/users/hanno-arm/followers","following_url":"https://api.github.com/users/hanno-arm/following{/other_user}","gists_url":"https://api.github.com/users/hanno-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/hanno-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanno-arm/subscriptions","organizations_url":"https://api.github.com/users/hanno-arm/orgs","repos_url":"https://api.github.com/users/hanno-arm/repos","events_url":"https://api.github.com/users/hanno-arm/events{/privacy}","received_events_url":"https://api.github.com/users/hanno-arm/received_events","type":"User","site_admin":false},"body":"Blocker: These wrappers must be guarded by `! MBEDTLS_DEPRECATED_REMOVED`.","created_at":"2018-02-20T11:20:31Z","updated_at":"2018-02-20T11:20:31Z","html_url":"https://github.com/ARMmbed/mbedtls/pull/1382#discussion_r169288496","pull_request_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1382","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/169288496"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1382#discussion_r169288496"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1382"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1382","id":170016529,"html_url":"https://github.com/ARMmbed/mbedtls/pull/1382","diff_url":"https://github.com/ARMmbed/mbedtls/pull/1382.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/1382.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1382","number":1382,"state":"open","locked":false,"title":"MD: Make deprecated functions not inline","user":{"login":"Patater","id":410816,"avatar_url":"https://avatars0.githubusercontent.com/u/410816?v=4","gravatar_id":"","url":"https://api.github.com/users/Patater","html_url":"https://github.com/Patater","followers_url":"https://api.github.com/users/Patater/followers","following_url":"https://api.github.com/users/Patater/following{/other_user}","gists_url":"https://api.github.com/users/Patater/gists{/gist_id}","starred_url":"https://api.github.com/users/Patater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patater/subscriptions","organizations_url":"https://api.github.com/users/Patater/orgs","repos_url":"https://api.github.com/users/Patater/repos","events_url":"https://api.github.com/users/Patater/events{/privacy}","received_events_url":"https://api.github.com/users/Patater/received_events","type":"User","site_admin":false},"body":"In 2.7.0, we replaced a number of MD functions with deprecated inline\r\nversions. This causes ABI compatibility issues, as the functions are no\r\nlonger guaranteed to be callable when built into a shared library.\r\nInstead, deprecate the functions without also inlining them, to help\r\nmaintain ABI backwards compatibility.\r\n\r\nTesting done:\r\n- Passed all.sh\r\n- Passed Buildbot","created_at":"2018-02-19T17:21:51Z","updated_at":"2018-02-20T11:20:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3ca9ca517c611c3c043f74e939f177a19e3dd23","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1382/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1382/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1382/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/661cb977709757747be4162e339aa340e846353d","head":{"label":"Patater:dev/jaeden/md-no-inline","ref":"dev/jaeden/md-no-inline","sha":"661cb977709757747be4162e339aa340e846353d","user":{"login":"Patater","id":410816,"avatar_url":"https://avatars0.githubusercontent.com/u/410816?v=4","gravatar_id":"","url":"https://api.github.com/users/Patater","html_url":"https://github.com/Patater","followers_url":"https://api.github.com/users/Patater/followers","following_url":"https://api.github.com/users/Patater/following{/other_user}","gists_url":"https://api.github.com/users/Patater/gists{/gist_id}","starred_url":"https://api.github.com/users/Patater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patater/subscriptions","organizations_url":"https://api.github.com/users/Patater/orgs","repos_url":"https://api.github.com/users/Patater/repos","events_url":"https://api.github.com/users/Patater/events{/privacy}","received_events_url":"https://api.github.com/users/Patater/received_events","type":"User","site_admin":false},"repo":{"id":104342405,"name":"mbedtls","full_name":"Patater/mbedtls","owner":{"login":"Patater","id":410816,"avatar_url":"https://avatars0.githubusercontent.com/u/410816?v=4","gravatar_id":"","url":"https://api.github.com/users/Patater","html_url":"https://github.com/Patater","followers_url":"https://api.github.com/users/Patater/followers","following_url":"https://api.github.com/users/Patater/following{/other_user}","gists_url":"https://api.github.com/users/Patater/gists{/gist_id}","starred_url":"https://api.github.com/users/Patater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patater/subscriptions","organizations_url":"https://api.github.com/users/Patater/orgs","repos_url":"https://api.github.com/users/Patater/repos","events_url":"https://api.github.com/users/Patater/events{/privacy}","received_events_url":"https://api.github.com/users/Patater/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Patater/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":true,"url":"https://api.github.com/repos/Patater/mbedtls","forks_url":"https://api.github.com/repos/Patater/mbedtls/forks","keys_url":"https://api.github.com/repos/Patater/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Patater/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Patater/mbedtls/teams","hooks_url":"https://api.github.com/repos/Patater/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/Patater/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/Patater/mbedtls/events","assignees_url":"https://api.github.com/repos/Patater/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/Patater/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/Patater/mbedtls/tags","blobs_url":"https://api.github.com/repos/Patater/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Patater/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Patater/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/Patater/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Patater/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/Patater/mbedtls/languages","stargazers_url":"https://api.github.com/repos/Patater/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/Patater/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/Patater/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/Patater/mbedtls/subscription","commits_url":"https://api.github.com/repos/Patater/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/Patater/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/Patater/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/Patater/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/Patater/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/Patater/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Patater/mbedtls/merges","archive_url":"https://api.github.com/repos/Patater/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Patater/mbedtls/downloads","issues_url":"https://api.github.com/repos/Patater/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/Patater/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/Patater/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/Patater/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Patater/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/Patater/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/Patater/mbedtls/deployments","created_at":"2017-09-21T11:58:06Z","updated_at":"2017-09-21T11:58:11Z","pushed_at":"2018-02-19T17:32:28Z","git_url":"git://github.com/Patater/mbedtls.git","ssh_url":"git@github.com:Patater/mbedtls.git","clone_url":"https://github.com/Patater/mbedtls.git","svn_url":"https://github.com/Patater/mbedtls","homepage":"https://tls.mbed.org","size":24396,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ARMmbed:development","ref":"development","sha":"e6844ccf2b83d26ba89d05a9f3a1493efb720e61","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":6687936,"name":"mbedtls","full_name":"ARMmbed/mbedtls","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbedtls","forks_url":"https://api.github.com/repos/ARMmbed/mbedtls/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbedtls/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbedtls/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbedtls/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbedtls/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbedtls/deployments","created_at":"2012-11-14T13:13:13Z","updated_at":"2018-02-19T20:07:10Z","pushed_at":"2018-02-20T09:28:21Z","git_url":"git://github.com/ARMmbed/mbedtls.git","ssh_url":"git@github.com:ARMmbed/mbedtls.git","clone_url":"https://github.com/ARMmbed/mbedtls.git","svn_url":"https://github.com/ARMmbed/mbedtls","homepage":"https://tls.mbed.org","size":24493,"stargazers_count":1264,"watchers_count":1264,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":778,"mirror_url":null,"archived":false,"open_issues_count":430,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":778,"open_issues":430,"watchers":1264,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1382"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1382"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1382"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1382/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1382/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1382/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/661cb977709757747be4162e339aa340e846353d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hanno-arm"}}