{"action":"created","comment":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/comments/171303915","pull_request_review_id":100132778,"id":171303915,"diff_hunk":"@@ -90,6 +91,45 @@ def _validate_supported_distros():\n         )\n \n \n+def _validate_private_ip():\n+    logger.info('Validating private IP address...')\n+    private_ip = config[MANAGER][PRIVATE_IP]\n+    all_addresses = set()\n+    found = False\n+    all_interfaces = netifaces.interfaces()\n+    for interface in all_interfaces:\n+        int_addresses = netifaces.ifaddresses(interface)\n+        if not int_addresses:\n+            logger.debug('Could not find any addresses for interface {}'.\n+                format(interface))\n+            continue\n+        inet_addresses = int_addresses.get(netifaces.AF_INET)\n+        if not inet_addresses:\n+            logger.debug('No AF_INET addresses found for interface {}'.format(\n+                interface))\n+            continue","path":"cfy_manager/components/validations.py","position":34,"original_position":34,"commit_id":"5e0d80caba6f2aca3621bd6b1afec87dd7221549","original_commit_id":"5e0d80caba6f2aca3621bd6b1afec87dd7221549","user":{"login":"isaac-s","id":6048541,"avatar_url":"https://avatars0.githubusercontent.com/u/6048541?v=4","gravatar_id":"","url":"https://api.github.com/users/isaac-s","html_url":"https://github.com/isaac-s","followers_url":"https://api.github.com/users/isaac-s/followers","following_url":"https://api.github.com/users/isaac-s/following{/other_user}","gists_url":"https://api.github.com/users/isaac-s/gists{/gist_id}","starred_url":"https://api.github.com/users/isaac-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaac-s/subscriptions","organizations_url":"https://api.github.com/users/isaac-s/orgs","repos_url":"https://api.github.com/users/isaac-s/repos","events_url":"https://api.github.com/users/isaac-s/events{/privacy}","received_events_url":"https://api.github.com/users/isaac-s/received_events","type":"User","site_admin":false},"body":"`int_addresses` is a `dict`, so `None` will be returned. Keeping it as is.","created_at":"2018-02-28T16:30:41Z","updated_at":"2018-02-28T16:30:41Z","html_url":"https://github.com/cloudify-cosmo/cloudify-manager-install/pull/161#discussion_r171303915","pull_request_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/161","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/comments/171303915"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-manager-install/pull/161#discussion_r171303915"},"pull_request":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/161"}},"in_reply_to_id":171231936},"pull_request":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/161","id":170702006,"html_url":"https://github.com/cloudify-cosmo/cloudify-manager-install/pull/161","diff_url":"https://github.com/cloudify-cosmo/cloudify-manager-install/pull/161.diff","patch_url":"https://github.com/cloudify-cosmo/cloudify-manager-install/pull/161.patch","issue_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/issues/161","number":161,"state":"open","locked":false,"title":"CFY-7923: private IP validation","user":{"login":"isaac-s","id":6048541,"avatar_url":"https://avatars0.githubusercontent.com/u/6048541?v=4","gravatar_id":"","url":"https://api.github.com/users/isaac-s","html_url":"https://github.com/isaac-s","followers_url":"https://api.github.com/users/isaac-s/followers","following_url":"https://api.github.com/users/isaac-s/following{/other_user}","gists_url":"https://api.github.com/users/isaac-s/gists{/gist_id}","starred_url":"https://api.github.com/users/isaac-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaac-s/subscriptions","organizations_url":"https://api.github.com/users/isaac-s/orgs","repos_url":"https://api.github.com/users/isaac-s/repos","events_url":"https://api.github.com/users/isaac-s/events{/privacy}","received_events_url":"https://api.github.com/users/isaac-s/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-22T09:53:47Z","updated_at":"2018-02-28T16:30:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"551abd35b38417a049fce5454ecfcec0677619c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/161/commits","review_comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/161/comments","review_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/issues/161/comments","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/statuses/5e0d80caba6f2aca3621bd6b1afec87dd7221549","head":{"label":"cloudify-cosmo:CFY-7923","ref":"CFY-7923","sha":"5e0d80caba6f2aca3621bd6b1afec87dd7221549","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":109827462,"name":"cloudify-manager-install","full_name":"cloudify-cosmo/cloudify-manager-install","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/cloudify-manager-install","description":"A new, simpler, way to install a Cloudify manager","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/releases{/id}","deployments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/deployments","created_at":"2017-11-07T11:36:54Z","updated_at":"2018-02-21T22:36:47Z","pushed_at":"2018-02-28T12:32:27Z","git_url":"git://github.com/cloudify-cosmo/cloudify-manager-install.git","ssh_url":"git@github.com:cloudify-cosmo/cloudify-manager-install.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-manager-install.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-manager-install","homepage":"","size":586,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":0,"open_issues":22,"watchers":1,"default_branch":"master"}},"base":{"label":"cloudify-cosmo:master","ref":"master","sha":"64121b69aa9766b15d71731891fe9af8b9471bb8","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":109827462,"name":"cloudify-manager-install","full_name":"cloudify-cosmo/cloudify-manager-install","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/cloudify-manager-install","description":"A new, simpler, way to install a Cloudify manager","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/releases{/id}","deployments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/deployments","created_at":"2017-11-07T11:36:54Z","updated_at":"2018-02-21T22:36:47Z","pushed_at":"2018-02-28T12:32:27Z","git_url":"git://github.com/cloudify-cosmo/cloudify-manager-install.git","ssh_url":"git@github.com:cloudify-cosmo/cloudify-manager-install.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-manager-install.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-manager-install","homepage":"","size":586,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":0,"open_issues":22,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/161"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-manager-install/pull/161"},"issue":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/issues/161"},"comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-install/statuses/5e0d80caba6f2aca3621bd6b1afec87dd7221549"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"isaac-s"}}