{"action":"created","issue":{"url":"https://api.github.com/repos/arduino-libraries/Ethernet/issues/68","repository_url":"https://api.github.com/repos/arduino-libraries/Ethernet","labels_url":"https://api.github.com/repos/arduino-libraries/Ethernet/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/arduino-libraries/Ethernet/issues/68/comments","events_url":"https://api.github.com/repos/arduino-libraries/Ethernet/issues/68/events","html_url":"https://github.com/arduino-libraries/Ethernet/pull/68","id":357228956,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjkzNTU1","number":68,"title":"Avoid conflicts with similar declaration of MAX_SOCK_NUM","user":{"login":"agdl","id":2743774,"node_id":"MDQ6VXNlcjI3NDM3NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2743774?v=4","gravatar_id":"","url":"https://api.github.com/users/agdl","html_url":"https://github.com/agdl","followers_url":"https://api.github.com/users/agdl/followers","following_url":"https://api.github.com/users/agdl/following{/other_user}","gists_url":"https://api.github.com/users/agdl/gists{/gist_id}","starred_url":"https://api.github.com/users/agdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agdl/subscriptions","organizations_url":"https://api.github.com/users/agdl/orgs","repos_url":"https://api.github.com/users/agdl/repos","events_url":"https://api.github.com/users/agdl/events{/privacy}","received_events_url":"https://api.github.com/users/agdl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-05T13:26:44Z","updated_at":"2018-09-06T13:10:28Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/arduino-libraries/Ethernet/pulls/68","html_url":"https://github.com/arduino-libraries/Ethernet/pull/68","diff_url":"https://github.com/arduino-libraries/Ethernet/pull/68.diff","patch_url":"https://github.com/arduino-libraries/Ethernet/pull/68.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/arduino-libraries/Ethernet/issues/comments/419087164","html_url":"https://github.com/arduino-libraries/Ethernet/pull/68#issuecomment-419087164","issue_url":"https://api.github.com/repos/arduino-libraries/Ethernet/issues/68","id":419087164,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTA4NzE2NA==","user":{"login":"PaulStoffregen","id":965463,"node_id":"MDQ6VXNlcjk2NTQ2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/965463?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulStoffregen","html_url":"https://github.com/PaulStoffregen","followers_url":"https://api.github.com/users/PaulStoffregen/followers","following_url":"https://api.github.com/users/PaulStoffregen/following{/other_user}","gists_url":"https://api.github.com/users/PaulStoffregen/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulStoffregen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulStoffregen/subscriptions","organizations_url":"https://api.github.com/users/PaulStoffregen/orgs","repos_url":"https://api.github.com/users/PaulStoffregen/repos","events_url":"https://api.github.com/users/PaulStoffregen/events{/privacy}","received_events_url":"https://api.github.com/users/PaulStoffregen/received_events","type":"User","site_admin":false},"created_at":"2018-09-06T13:10:28Z","updated_at":"2018-09-06T13:10:28Z","author_association":"COLLABORATOR","body":"If this is changed, I believe the proper approach would be the bring it inside EthernetClass, rather than keeping it as a preprocessor macro.  I had considered doing this for version 2.0.0, but left things the way they were...\r\n\r\nThe main question I have is whether we should keep MAX_SOCK_NUM defined for backwards compatibility?  Removing this from newer libs is much easier.  Ethernet has exposed this define to Arduino sketches and libraries for at least 10 years."}}
{"actor":{"display_login":"PaulStoffregen"}}