{"action":"created","comment":{"url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/comments/236646942","pull_request_review_id":178759748,"id":236646942,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjY0Njk0Mg==","diff_hunk":"@@ -173,7 +183,12 @@ MediaKeySession::MediaKeySession(const uint8_t *f_pbInitData, uint32_t f_cbInitD\n     , m_piCallback(nullptr) {\n   DRM_RESULT dr = DRM_SUCCESS;\n   DRM_ID oSessionID;\n+\n+#ifdef PR_3_3\n+  DRM_DWORD cchEncodedSessionID = sizeof(m_rgchSessionID);\n+#else\n   DRM_DWORD cchEncodedSessionID = SIZEOF(m_rgchSessionID);","path":"MediaSession.cpp","position":31,"original_position":31,"commit_id":"ed0d9d8b9b3dcd494e9626b4efe7911627a3ae45","original_commit_id":"94577cb2fc23c34c54e1971c8131db97ea2663a9","user":{"login":"petegriffin","id":10936277,"node_id":"MDQ6VXNlcjEwOTM2Mjc3","avatar_url":"https://avatars2.githubusercontent.com/u/10936277?v=4","gravatar_id":"","url":"https://api.github.com/users/petegriffin","html_url":"https://github.com/petegriffin","followers_url":"https://api.github.com/users/petegriffin/followers","following_url":"https://api.github.com/users/petegriffin/following{/other_user}","gists_url":"https://api.github.com/users/petegriffin/gists{/gist_id}","starred_url":"https://api.github.com/users/petegriffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petegriffin/subscriptions","organizations_url":"https://api.github.com/users/petegriffin/orgs","repos_url":"https://api.github.com/users/petegriffin/repos","events_url":"https://api.github.com/users/petegriffin/events{/privacy}","received_events_url":"https://api.github.com/users/petegriffin/received_events","type":"User","site_admin":false},"body":"@wouterlucas SIZEOF, ZEROMEM and MEMCPY aren't present in our porting kit release. Is there a reason we can't update the code to just use memset, memcpy and sizeof?","created_at":"2018-11-27T12:46:08Z","updated_at":"2018-11-27T12:46:25Z","html_url":"https://github.com/WebPlatformForEmbedded/OCDM-Playready/pull/2#discussion_r236646942","pull_request_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/comments/236646942"},"html":{"href":"https://github.com/WebPlatformForEmbedded/OCDM-Playready/pull/2#discussion_r236646942"},"pull_request":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/2","id":226523635,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NTIzNjM1","html_url":"https://github.com/WebPlatformForEmbedded/OCDM-Playready/pull/2","diff_url":"https://github.com/WebPlatformForEmbedded/OCDM-Playready/pull/2.diff","patch_url":"https://github.com/WebPlatformForEmbedded/OCDM-Playready/pull/2.patch","issue_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/issues/2","number":2,"state":"open","locked":false,"title":"Playready v3.3 support changes","user":{"login":"psivasubramanian","id":18259550,"node_id":"MDQ6VXNlcjE4MjU5NTUw","avatar_url":"https://avatars3.githubusercontent.com/u/18259550?v=4","gravatar_id":"","url":"https://api.github.com/users/psivasubramanian","html_url":"https://github.com/psivasubramanian","followers_url":"https://api.github.com/users/psivasubramanian/followers","following_url":"https://api.github.com/users/psivasubramanian/following{/other_user}","gists_url":"https://api.github.com/users/psivasubramanian/gists{/gist_id}","starred_url":"https://api.github.com/users/psivasubramanian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psivasubramanian/subscriptions","organizations_url":"https://api.github.com/users/psivasubramanian/orgs","repos_url":"https://api.github.com/users/psivasubramanian/repos","events_url":"https://api.github.com/users/psivasubramanian/events{/privacy}","received_events_url":"https://api.github.com/users/psivasubramanian/received_events","type":"User","site_admin":false},"body":"1. Replacing v3.3 deprecated Drm_Reader_InitDecrypt() and Drm_Reader_Decrypt() with\r\nDrm_Reader_InitDecrypt and Drm_Reader_DecryptOpaque()\r\n2. Drm_LicenseAcq_ProcessResponse() number of arguments change\r\n3. Drm_LicenseAcq_GenerateChallenge() arguments list should end with NULL\r\n4. invoke Drm_Reader_Bind() before Drm_LicenseAcq_GenerateChallenge\r\n5. Make Playready dependency mandatory properly","created_at":"2018-10-29T11:23:38Z","updated_at":"2018-11-27T12:46:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8152c37432c1a518804ac1f7c636120558d1b3a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wouterlucas","id":1534440,"node_id":"MDQ6VXNlcjE1MzQ0NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1534440?v=4","gravatar_id":"","url":"https://api.github.com/users/wouterlucas","html_url":"https://github.com/wouterlucas","followers_url":"https://api.github.com/users/wouterlucas/followers","following_url":"https://api.github.com/users/wouterlucas/following{/other_user}","gists_url":"https://api.github.com/users/wouterlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/wouterlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wouterlucas/subscriptions","organizations_url":"https://api.github.com/users/wouterlucas/orgs","repos_url":"https://api.github.com/users/wouterlucas/repos","events_url":"https://api.github.com/users/wouterlucas/events{/privacy}","received_events_url":"https://api.github.com/users/wouterlucas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/2/commits","review_comments_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/2/comments","review_comment_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/issues/2/comments","statuses_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/statuses/ed0d9d8b9b3dcd494e9626b4efe7911627a3ae45","head":{"label":"psivasubramanian:master","ref":"master","sha":"ed0d9d8b9b3dcd494e9626b4efe7911627a3ae45","user":{"login":"psivasubramanian","id":18259550,"node_id":"MDQ6VXNlcjE4MjU5NTUw","avatar_url":"https://avatars3.githubusercontent.com/u/18259550?v=4","gravatar_id":"","url":"https://api.github.com/users/psivasubramanian","html_url":"https://github.com/psivasubramanian","followers_url":"https://api.github.com/users/psivasubramanian/followers","following_url":"https://api.github.com/users/psivasubramanian/following{/other_user}","gists_url":"https://api.github.com/users/psivasubramanian/gists{/gist_id}","starred_url":"https://api.github.com/users/psivasubramanian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psivasubramanian/subscriptions","organizations_url":"https://api.github.com/users/psivasubramanian/orgs","repos_url":"https://api.github.com/users/psivasubramanian/repos","events_url":"https://api.github.com/users/psivasubramanian/events{/privacy}","received_events_url":"https://api.github.com/users/psivasubramanian/received_events","type":"User","site_admin":false},"repo":{"id":155159337,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUxNTkzMzc=","name":"OCDM-Playready","full_name":"psivasubramanian/OCDM-Playready","private":false,"owner":{"login":"psivasubramanian","id":18259550,"node_id":"MDQ6VXNlcjE4MjU5NTUw","avatar_url":"https://avatars3.githubusercontent.com/u/18259550?v=4","gravatar_id":"","url":"https://api.github.com/users/psivasubramanian","html_url":"https://github.com/psivasubramanian","followers_url":"https://api.github.com/users/psivasubramanian/followers","following_url":"https://api.github.com/users/psivasubramanian/following{/other_user}","gists_url":"https://api.github.com/users/psivasubramanian/gists{/gist_id}","starred_url":"https://api.github.com/users/psivasubramanian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psivasubramanian/subscriptions","organizations_url":"https://api.github.com/users/psivasubramanian/orgs","repos_url":"https://api.github.com/users/psivasubramanian/repos","events_url":"https://api.github.com/users/psivasubramanian/events{/privacy}","received_events_url":"https://api.github.com/users/psivasubramanian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/psivasubramanian/OCDM-Playready","description":"PlayReady OpenCDM(i) plugin","fork":true,"url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready","forks_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/forks","keys_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/teams","hooks_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/hooks","issue_events_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/issues/events{/number}","events_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/events","assignees_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/assignees{/user}","branches_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/branches{/branch}","tags_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/tags","blobs_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/git/refs{/sha}","trees_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/statuses/{sha}","languages_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/languages","stargazers_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/stargazers","contributors_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/contributors","subscribers_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/subscribers","subscription_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/subscription","commits_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/commits{/sha}","git_commits_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/git/commits{/sha}","comments_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/comments{/number}","issue_comment_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/issues/comments{/number}","contents_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/contents/{+path}","compare_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/merges","archive_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/downloads","issues_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/issues{/number}","pulls_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/pulls{/number}","milestones_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/milestones{/number}","notifications_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/labels{/name}","releases_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/releases{/id}","deployments_url":"https://api.github.com/repos/psivasubramanian/OCDM-Playready/deployments","created_at":"2018-10-29T05:59:10Z","updated_at":"2018-11-23T12:57:59Z","pushed_at":"2018-11-23T12:57:58Z","git_url":"git://github.com/psivasubramanian/OCDM-Playready.git","ssh_url":"git@github.com:psivasubramanian/OCDM-Playready.git","clone_url":"https://github.com/psivasubramanian/OCDM-Playready.git","svn_url":"https://github.com/psivasubramanian/OCDM-Playready","homepage":null,"size":33,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WebPlatformForEmbedded:master","ref":"master","sha":"0e564fd772f47877364264413d057df80e1c8aeb","user":{"login":"WebPlatformForEmbedded","id":26092996,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDkyOTk2","avatar_url":"https://avatars1.githubusercontent.com/u/26092996?v=4","gravatar_id":"","url":"https://api.github.com/users/WebPlatformForEmbedded","html_url":"https://github.com/WebPlatformForEmbedded","followers_url":"https://api.github.com/users/WebPlatformForEmbedded/followers","following_url":"https://api.github.com/users/WebPlatformForEmbedded/following{/other_user}","gists_url":"https://api.github.com/users/WebPlatformForEmbedded/gists{/gist_id}","starred_url":"https://api.github.com/users/WebPlatformForEmbedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebPlatformForEmbedded/subscriptions","organizations_url":"https://api.github.com/users/WebPlatformForEmbedded/orgs","repos_url":"https://api.github.com/users/WebPlatformForEmbedded/repos","events_url":"https://api.github.com/users/WebPlatformForEmbedded/events{/privacy}","received_events_url":"https://api.github.com/users/WebPlatformForEmbedded/received_events","type":"Organization","site_admin":false},"repo":{"id":122600668,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2MDA2Njg=","name":"OCDM-Playready","full_name":"WebPlatformForEmbedded/OCDM-Playready","private":false,"owner":{"login":"WebPlatformForEmbedded","id":26092996,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDkyOTk2","avatar_url":"https://avatars1.githubusercontent.com/u/26092996?v=4","gravatar_id":"","url":"https://api.github.com/users/WebPlatformForEmbedded","html_url":"https://github.com/WebPlatformForEmbedded","followers_url":"https://api.github.com/users/WebPlatformForEmbedded/followers","following_url":"https://api.github.com/users/WebPlatformForEmbedded/following{/other_user}","gists_url":"https://api.github.com/users/WebPlatformForEmbedded/gists{/gist_id}","starred_url":"https://api.github.com/users/WebPlatformForEmbedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebPlatformForEmbedded/subscriptions","organizations_url":"https://api.github.com/users/WebPlatformForEmbedded/orgs","repos_url":"https://api.github.com/users/WebPlatformForEmbedded/repos","events_url":"https://api.github.com/users/WebPlatformForEmbedded/events{/privacy}","received_events_url":"https://api.github.com/users/WebPlatformForEmbedded/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WebPlatformForEmbedded/OCDM-Playready","description":"PlayReady OpenCDM(i) plugin","fork":false,"url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready","forks_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/forks","keys_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/teams","hooks_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/hooks","issue_events_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/issues/events{/number}","events_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/events","assignees_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/assignees{/user}","branches_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/branches{/branch}","tags_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/tags","blobs_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/statuses/{sha}","languages_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/languages","stargazers_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/stargazers","contributors_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/contributors","subscribers_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/subscribers","subscription_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/subscription","commits_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/contents/{+path}","compare_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/merges","archive_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/downloads","issues_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/issues{/number}","pulls_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls{/number}","milestones_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/milestones{/number}","notifications_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/labels{/name}","releases_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/releases{/id}","deployments_url":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/deployments","created_at":"2018-02-23T09:29:46Z","updated_at":"2018-09-19T18:38:18Z","pushed_at":"2018-11-23T12:57:59Z","git_url":"git://github.com/WebPlatformForEmbedded/OCDM-Playready.git","ssh_url":"git@github.com:WebPlatformForEmbedded/OCDM-Playready.git","clone_url":"https://github.com/WebPlatformForEmbedded/OCDM-Playready.git","svn_url":"https://github.com/WebPlatformForEmbedded/OCDM-Playready","homepage":null,"size":29,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/2"},"html":{"href":"https://github.com/WebPlatformForEmbedded/OCDM-Playready/pull/2"},"issue":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/issues/2"},"comments":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/OCDM-Playready/statuses/ed0d9d8b9b3dcd494e9626b4efe7911627a3ae45"}},"author_association":"NONE"}}
{"actor":{"display_login":"petegriffin"}}