{"action":"created","comment":{"url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/comments/239952590","pull_request_review_id":182882083,"id":239952590,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk1MjU5MA==","diff_hunk":"@@ -15,6 +15,10 @@\n from .util import PrintError, ThreadJob\n \n \n+DEFAULT_ENABLED = False\n+DEFAULT_CURRENCY = \"EUR\"\n+DEFAULT_EXCHANGE = \"Kraken\"","path":"lib/exchange_rate.py","position":6,"original_position":6,"commit_id":"94f0ad5cc3588179a13f063d34dd950e1bc050b2","original_commit_id":"94f0ad5cc3588179a13f063d34dd950e1bc050b2","user":{"login":"cculianu","id":266627,"node_id":"MDQ6VXNlcjI2NjYyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/266627?v=4","gravatar_id":"","url":"https://api.github.com/users/cculianu","html_url":"https://github.com/cculianu","followers_url":"https://api.github.com/users/cculianu/followers","following_url":"https://api.github.com/users/cculianu/following{/other_user}","gists_url":"https://api.github.com/users/cculianu/gists{/gist_id}","starred_url":"https://api.github.com/users/cculianu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cculianu/subscriptions","organizations_url":"https://api.github.com/users/cculianu/orgs","repos_url":"https://api.github.com/users/cculianu/repos","events_url":"https://api.github.com/users/cculianu/events{/privacy}","received_events_url":"https://api.github.com/users/cculianu/received_events","type":"User","site_admin":false},"body":"Yes. Good. :)","created_at":"2018-12-07T21:34:10Z","updated_at":"2018-12-07T21:52:40Z","html_url":"https://github.com/Electron-Cash/Electron-Cash/pull/1022#discussion_r239952590","pull_request_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/1022","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/comments/239952590"},"html":{"href":"https://github.com/Electron-Cash/Electron-Cash/pull/1022#discussion_r239952590"},"pull_request":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/1022"}}},"pull_request":{"url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/1022","id":236999235,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTk5MjM1","html_url":"https://github.com/Electron-Cash/Electron-Cash/pull/1022","diff_url":"https://github.com/Electron-Cash/Electron-Cash/pull/1022.diff","patch_url":"https://github.com/Electron-Cash/Electron-Cash/pull/1022.patch","issue_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/1022","number":1022,"state":"open","locked":false,"title":"Android phase 2 (second try)","user":{"login":"mhsmith","id":166954,"node_id":"MDQ6VXNlcjE2Njk1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/166954?v=4","gravatar_id":"","url":"https://api.github.com/users/mhsmith","html_url":"https://github.com/mhsmith","followers_url":"https://api.github.com/users/mhsmith/followers","following_url":"https://api.github.com/users/mhsmith/following{/other_user}","gists_url":"https://api.github.com/users/mhsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/mhsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhsmith/subscriptions","organizations_url":"https://api.github.com/users/mhsmith/orgs","repos_url":"https://api.github.com/users/mhsmith/repos","events_url":"https://api.github.com/users/mhsmith/events{/privacy}","received_events_url":"https://api.github.com/users/mhsmith/received_events","type":"User","site_admin":false},"body":"Before merging, please review my changes to the back-end code in `lib`. I think they should all be self-explanatory except for `Network.set_parameters`. I've split that into two parts: one to save to the config, and the other to apply the config. That way each part can be called separately by the UI.\r\n\r\nInstructions for building the app are in `android/README.md`. Jonald has a copy of the release key.","created_at":"2018-12-07T21:31:18Z","updated_at":"2018-12-07T21:52:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e4419c1a319b6ef7220f5038b0df1a6e1f1199d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/1022/commits","review_comments_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/1022/comments","review_comment_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/1022/comments","statuses_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/statuses/94f0ad5cc3588179a13f063d34dd950e1bc050b2","head":{"label":"mhsmith:android2","ref":"android2","sha":"94f0ad5cc3588179a13f063d34dd950e1bc050b2","user":{"login":"mhsmith","id":166954,"node_id":"MDQ6VXNlcjE2Njk1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/166954?v=4","gravatar_id":"","url":"https://api.github.com/users/mhsmith","html_url":"https://github.com/mhsmith","followers_url":"https://api.github.com/users/mhsmith/followers","following_url":"https://api.github.com/users/mhsmith/following{/other_user}","gists_url":"https://api.github.com/users/mhsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/mhsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhsmith/subscriptions","organizations_url":"https://api.github.com/users/mhsmith/orgs","repos_url":"https://api.github.com/users/mhsmith/repos","events_url":"https://api.github.com/users/mhsmith/events{/privacy}","received_events_url":"https://api.github.com/users/mhsmith/received_events","type":"User","site_admin":false},"repo":{"id":136178415,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxNzg0MTU=","name":"electrum","full_name":"mhsmith/electrum","private":false,"owner":{"login":"mhsmith","id":166954,"node_id":"MDQ6VXNlcjE2Njk1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/166954?v=4","gravatar_id":"","url":"https://api.github.com/users/mhsmith","html_url":"https://github.com/mhsmith","followers_url":"https://api.github.com/users/mhsmith/followers","following_url":"https://api.github.com/users/mhsmith/following{/other_user}","gists_url":"https://api.github.com/users/mhsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/mhsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhsmith/subscriptions","organizations_url":"https://api.github.com/users/mhsmith/orgs","repos_url":"https://api.github.com/users/mhsmith/repos","events_url":"https://api.github.com/users/mhsmith/events{/privacy}","received_events_url":"https://api.github.com/users/mhsmith/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mhsmith/electrum","description":"Electrum; Bitcoin thin client","fork":true,"url":"https://api.github.com/repos/mhsmith/electrum","forks_url":"https://api.github.com/repos/mhsmith/electrum/forks","keys_url":"https://api.github.com/repos/mhsmith/electrum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhsmith/electrum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhsmith/electrum/teams","hooks_url":"https://api.github.com/repos/mhsmith/electrum/hooks","issue_events_url":"https://api.github.com/repos/mhsmith/electrum/issues/events{/number}","events_url":"https://api.github.com/repos/mhsmith/electrum/events","assignees_url":"https://api.github.com/repos/mhsmith/electrum/assignees{/user}","branches_url":"https://api.github.com/repos/mhsmith/electrum/branches{/branch}","tags_url":"https://api.github.com/repos/mhsmith/electrum/tags","blobs_url":"https://api.github.com/repos/mhsmith/electrum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhsmith/electrum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhsmith/electrum/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhsmith/electrum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhsmith/electrum/statuses/{sha}","languages_url":"https://api.github.com/repos/mhsmith/electrum/languages","stargazers_url":"https://api.github.com/repos/mhsmith/electrum/stargazers","contributors_url":"https://api.github.com/repos/mhsmith/electrum/contributors","subscribers_url":"https://api.github.com/repos/mhsmith/electrum/subscribers","subscription_url":"https://api.github.com/repos/mhsmith/electrum/subscription","commits_url":"https://api.github.com/repos/mhsmith/electrum/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhsmith/electrum/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhsmith/electrum/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhsmith/electrum/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhsmith/electrum/contents/{+path}","compare_url":"https://api.github.com/repos/mhsmith/electrum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhsmith/electrum/merges","archive_url":"https://api.github.com/repos/mhsmith/electrum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhsmith/electrum/downloads","issues_url":"https://api.github.com/repos/mhsmith/electrum/issues{/number}","pulls_url":"https://api.github.com/repos/mhsmith/electrum/pulls{/number}","milestones_url":"https://api.github.com/repos/mhsmith/electrum/milestones{/number}","notifications_url":"https://api.github.com/repos/mhsmith/electrum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhsmith/electrum/labels{/name}","releases_url":"https://api.github.com/repos/mhsmith/electrum/releases{/id}","deployments_url":"https://api.github.com/repos/mhsmith/electrum/deployments","created_at":"2018-06-05T13:03:42Z","updated_at":"2018-11-30T20:53:40Z","pushed_at":"2018-12-07T19:02:16Z","git_url":"git://github.com/mhsmith/electrum.git","ssh_url":"git@github.com:mhsmith/electrum.git","clone_url":"https://github.com/mhsmith/electrum.git","svn_url":"https://github.com/mhsmith/electrum","homepage":null,"size":29010,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Electron-Cash:master","ref":"master","sha":"baa2d69f47e4136600fb73e231107f7449dd8759","user":{"login":"Electron-Cash","id":43519373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTE5Mzcz","avatar_url":"https://avatars3.githubusercontent.com/u/43519373?v=4","gravatar_id":"","url":"https://api.github.com/users/Electron-Cash","html_url":"https://github.com/Electron-Cash","followers_url":"https://api.github.com/users/Electron-Cash/followers","following_url":"https://api.github.com/users/Electron-Cash/following{/other_user}","gists_url":"https://api.github.com/users/Electron-Cash/gists{/gist_id}","starred_url":"https://api.github.com/users/Electron-Cash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Electron-Cash/subscriptions","organizations_url":"https://api.github.com/users/Electron-Cash/orgs","repos_url":"https://api.github.com/users/Electron-Cash/repos","events_url":"https://api.github.com/users/Electron-Cash/events{/privacy}","received_events_url":"https://api.github.com/users/Electron-Cash/received_events","type":"Organization","site_admin":false},"repo":{"id":98333687,"node_id":"MDEwOlJlcG9zaXRvcnk5ODMzMzY4Nw==","name":"Electron-Cash","full_name":"Electron-Cash/Electron-Cash","private":false,"owner":{"login":"Electron-Cash","id":43519373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTE5Mzcz","avatar_url":"https://avatars3.githubusercontent.com/u/43519373?v=4","gravatar_id":"","url":"https://api.github.com/users/Electron-Cash","html_url":"https://github.com/Electron-Cash","followers_url":"https://api.github.com/users/Electron-Cash/followers","following_url":"https://api.github.com/users/Electron-Cash/following{/other_user}","gists_url":"https://api.github.com/users/Electron-Cash/gists{/gist_id}","starred_url":"https://api.github.com/users/Electron-Cash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Electron-Cash/subscriptions","organizations_url":"https://api.github.com/users/Electron-Cash/orgs","repos_url":"https://api.github.com/users/Electron-Cash/repos","events_url":"https://api.github.com/users/Electron-Cash/events{/privacy}","received_events_url":"https://api.github.com/users/Electron-Cash/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Electron-Cash/Electron-Cash","description":"Electrum; Bitcoin thin client","fork":true,"url":"https://api.github.com/repos/Electron-Cash/Electron-Cash","forks_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/forks","keys_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/teams","hooks_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/hooks","issue_events_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/events{/number}","events_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/events","assignees_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/assignees{/user}","branches_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/branches{/branch}","tags_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/tags","blobs_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/git/refs{/sha}","trees_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/statuses/{sha}","languages_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/languages","stargazers_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/stargazers","contributors_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/contributors","subscribers_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/subscribers","subscription_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/subscription","commits_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/commits{/sha}","git_commits_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/git/commits{/sha}","comments_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/comments{/number}","issue_comment_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/comments{/number}","contents_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/contents/{+path}","compare_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/merges","archive_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/downloads","issues_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues{/number}","pulls_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls{/number}","milestones_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/milestones{/number}","notifications_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/labels{/name}","releases_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/releases{/id}","deployments_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/deployments","created_at":"2017-07-25T17:40:55Z","updated_at":"2018-12-07T21:27:53Z","pushed_at":"2018-12-07T21:31:18Z","git_url":"git://github.com/Electron-Cash/Electron-Cash.git","ssh_url":"git@github.com:Electron-Cash/Electron-Cash.git","clone_url":"https://github.com/Electron-Cash/Electron-Cash.git","svn_url":"https://github.com/Electron-Cash/Electron-Cash","homepage":null,"size":33177,"stargazers_count":202,"watchers_count":202,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":123,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":90,"open_issues":123,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/1022"},"html":{"href":"https://github.com/Electron-Cash/Electron-Cash/pull/1022"},"issue":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/1022"},"comments":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/1022/comments"},"review_comments":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/1022/comments"},"review_comment":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/1022/commits"},"statuses":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/statuses/94f0ad5cc3588179a13f063d34dd950e1bc050b2"}},"author_association":"NONE"}}
{"actor":{"display_login":"cculianu"}}