{"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/brave/pulls/comments/204198332","pull_request_review_id":139244692,"id":204198332,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE5ODMzMg==","diff_hunk":"@@ -3,90 +3,100 @@\n import brave.internal.Nullable;\n \n //@Immutable\n-public abstract class SamplingFlags {\n-  public static final SamplingFlags EMPTY = new SamplingFlagsImpl(null, false);\n-  public static final SamplingFlags SAMPLED = new SamplingFlagsImpl(true, false);\n-  public static final SamplingFlags NOT_SAMPLED = new SamplingFlagsImpl(false, false);\n-  public static final SamplingFlags DEBUG = new SamplingFlagsImpl(true, true);","path":"brave/src/main/java/brave/propagation/SamplingFlags.java","position":8,"original_position":8,"commit_id":"5733475b961d3f7c8a3e0d717d2153dacf6b717f","original_commit_id":"5733475b961d3f7c8a3e0d717d2153dacf6b717f","user":{"login":"adriancole","id":64215,"node_id":"MDQ6VXNlcjY0MjE1","avatar_url":"https://avatars2.githubusercontent.com/u/64215?v=4","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"intellij showed warnings about classloader deadlock by referencing a subclass ctor in a super. the changes here not only make things smaller, but also remove that possibility.","created_at":"2018-07-21T01:45:01Z","updated_at":"2018-07-21T01:45:01Z","html_url":"https://github.com/openzipkin/brave/pull/730#discussion_r204198332","pull_request_url":"https://api.github.com/repos/openzipkin/brave/pulls/730","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/comments/204198332"},"html":{"href":"https://github.com/openzipkin/brave/pull/730#discussion_r204198332"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/730"}}},"pull_request":{"url":"https://api.github.com/repos/openzipkin/brave/pulls/730","id":202985218,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTg1MjE4","html_url":"https://github.com/openzipkin/brave/pull/730","diff_url":"https://github.com/openzipkin/brave/pull/730.diff","patch_url":"https://github.com/openzipkin/brave/pull/730.patch","issue_url":"https://api.github.com/repos/openzipkin/brave/issues/730","number":730,"state":"open","locked":false,"title":"Removes bytecode so we can add more","user":{"login":"adriancole","id":64215,"node_id":"MDQ6VXNlcjY0MjE1","avatar_url":"https://avatars2.githubusercontent.com/u/64215?v=4","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"This removes the auto-value dependency and related for inlining the few\r\ncases where it was used. It also trims the class hierarchy of sampling\r\nflags. Finally, it moves out the in-flight localEndpoint as it is\r\nconstant.\r\n\r\nBesides fixing a few bugs, these changes reduced the size of the jar by\r\n12KiB and scraps 2 dependencies.\r\n\r\n```bash\r\ndu -k /Users/acole/.m2/repository/io/zipkin/brave/brave/5.1.2/brave-5.1.2.jar /Users/acole/.m2/repository/io/zipkin/brave/brave/5.1.3-SNAPSHOT/brave-5.1.3-SNAPSHOT.jar\r\n116\t/Users/acole/.m2/repository/io/zipkin/brave/brave/5.1.2/brave-5.1.2.jar\r\n128\t/Users/acole/.m2/repository/io/zipkin/brave/brave/5.1.3-SNAPSHOT/brave-5.1.3-SNAPSHOT.jar\r\n```","created_at":"2018-07-21T01:31:16Z","updated_at":"2018-07-21T01:45:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"587bc07dc8ebe2eca76bc09d7babd4d7f40ebee4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/brave/pulls/730/commits","review_comments_url":"https://api.github.com/repos/openzipkin/brave/pulls/730/comments","review_comment_url":"https://api.github.com/repos/openzipkin/brave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/brave/issues/730/comments","statuses_url":"https://api.github.com/repos/openzipkin/brave/statuses/5733475b961d3f7c8a3e0d717d2153dacf6b717f","head":{"label":"openzipkin:bytecode-smaller","ref":"bytecode-smaller","sha":"5733475b961d3f7c8a3e0d717d2153dacf6b717f","user":{"login":"openzipkin","id":11860887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODYwODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":9278888,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjc4ODg4","name":"brave","full_name":"openzipkin/brave","owner":{"login":"openzipkin","id":11860887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODYwODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/brave","description":"Java distributed tracing implementation compatible with Zipkin backend services.","fork":false,"url":"https://api.github.com/repos/openzipkin/brave","forks_url":"https://api.github.com/repos/openzipkin/brave/forks","keys_url":"https://api.github.com/repos/openzipkin/brave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/brave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/brave/teams","hooks_url":"https://api.github.com/repos/openzipkin/brave/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/brave/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/brave/events","assignees_url":"https://api.github.com/repos/openzipkin/brave/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/brave/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/brave/tags","blobs_url":"https://api.github.com/repos/openzipkin/brave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/brave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/brave/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/brave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/brave/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/brave/languages","stargazers_url":"https://api.github.com/repos/openzipkin/brave/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/brave/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/brave/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/brave/subscription","commits_url":"https://api.github.com/repos/openzipkin/brave/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/brave/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/brave/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/brave/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/brave/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/brave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/brave/merges","archive_url":"https://api.github.com/repos/openzipkin/brave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/brave/downloads","issues_url":"https://api.github.com/repos/openzipkin/brave/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/brave/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/brave/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/brave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/brave/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/brave/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/brave/deployments","created_at":"2013-04-07T15:48:18Z","updated_at":"2018-07-20T06:42:05Z","pushed_at":"2018-07-21T01:39:58Z","git_url":"git://github.com/openzipkin/brave.git","ssh_url":"git@github.com:openzipkin/brave.git","clone_url":"https://github.com/openzipkin/brave.git","svn_url":"https://github.com/openzipkin/brave","homepage":"","size":5533,"stargazers_count":1132,"watchers_count":1132,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":364,"open_issues":60,"watchers":1132,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"af055a61330a10afa9b6fa4f05f7d33a3b3a7296","user":{"login":"openzipkin","id":11860887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODYwODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":9278888,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjc4ODg4","name":"brave","full_name":"openzipkin/brave","owner":{"login":"openzipkin","id":11860887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODYwODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/brave","description":"Java distributed tracing implementation compatible with Zipkin backend services.","fork":false,"url":"https://api.github.com/repos/openzipkin/brave","forks_url":"https://api.github.com/repos/openzipkin/brave/forks","keys_url":"https://api.github.com/repos/openzipkin/brave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/brave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/brave/teams","hooks_url":"https://api.github.com/repos/openzipkin/brave/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/brave/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/brave/events","assignees_url":"https://api.github.com/repos/openzipkin/brave/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/brave/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/brave/tags","blobs_url":"https://api.github.com/repos/openzipkin/brave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/brave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/brave/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/brave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/brave/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/brave/languages","stargazers_url":"https://api.github.com/repos/openzipkin/brave/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/brave/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/brave/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/brave/subscription","commits_url":"https://api.github.com/repos/openzipkin/brave/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/brave/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/brave/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/brave/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/brave/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/brave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/brave/merges","archive_url":"https://api.github.com/repos/openzipkin/brave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/brave/downloads","issues_url":"https://api.github.com/repos/openzipkin/brave/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/brave/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/brave/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/brave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/brave/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/brave/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/brave/deployments","created_at":"2013-04-07T15:48:18Z","updated_at":"2018-07-20T06:42:05Z","pushed_at":"2018-07-21T01:39:58Z","git_url":"git://github.com/openzipkin/brave.git","ssh_url":"git@github.com:openzipkin/brave.git","clone_url":"https://github.com/openzipkin/brave.git","svn_url":"https://github.com/openzipkin/brave","homepage":"","size":5533,"stargazers_count":1132,"watchers_count":1132,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":364,"open_issues":60,"watchers":1132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/730"},"html":{"href":"https://github.com/openzipkin/brave/pull/730"},"issue":{"href":"https://api.github.com/repos/openzipkin/brave/issues/730"},"comments":{"href":"https://api.github.com/repos/openzipkin/brave/issues/730/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/730/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/730/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/brave/statuses/5733475b961d3f7c8a3e0d717d2153dacf6b717f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adriancole"}}