{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/3682","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3682/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3682/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3682/events","html_url":"https://github.com/apache/incubator-airflow/pull/3682","id":346939699,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Njc4MjUw","number":3682,"title":" [AIRFLOW-2841] HttpsHook support for airflow","user":{"login":"q2w","id":12875634,"node_id":"MDQ6VXNlcjEyODc1NjM0","avatar_url":"https://avatars3.githubusercontent.com/u/12875634?v=4","gravatar_id":"","url":"https://api.github.com/users/q2w","html_url":"https://github.com/q2w","followers_url":"https://api.github.com/users/q2w/followers","following_url":"https://api.github.com/users/q2w/following{/other_user}","gists_url":"https://api.github.com/users/q2w/gists{/gist_id}","starred_url":"https://api.github.com/users/q2w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/q2w/subscriptions","organizations_url":"https://api.github.com/users/q2w/orgs","repos_url":"https://api.github.com/users/q2w/repos","events_url":"https://api.github.com/users/q2w/events{/privacy}","received_events_url":"https://api.github.com/users/q2w/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-02T09:51:05Z","updated_at":"2018-08-02T10:01:57Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3682","html_url":"https://github.com/apache/incubator-airflow/pull/3682","diff_url":"https://github.com/apache/incubator-airflow/pull/3682.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/3682.patch"},"body":"Make sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. \r\n  - https://issues.apache.org/jira/browse/AIRFLOW-2841\r\n\r\n### Description\r\n\r\n- [ ] Here are some details about my PR, including screenshots of any UI changes:\r\nThis adds a simple HttpsHook .\r\n\r\n### Tests\r\n\r\n- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\nSimple functionality\r\n\r\n### Commits\r\n\r\n- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n  1. Subject is separated from body by a blank line\r\n  1. Subject is limited to 50 characters (not including Jira issue reference)\r\n  1. Subject does not end with a period\r\n  1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n  1. Body wraps at 72 characters\r\n  1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [ ] In case of new functionality, my PR adds documentation that describes how to use it.\r\n  - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n\r\n### Code Quality\r\n\r\n- [ ] Passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/409874986","html_url":"https://github.com/apache/incubator-airflow/pull/3682#issuecomment-409874986","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3682","id":409874986,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTg3NDk4Ng==","user":{"login":"ashb","id":34150,"node_id":"MDQ6VXNlcjM0MTUw","avatar_url":"https://avatars2.githubusercontent.com/u/34150?v=4","gravatar_id":"","url":"https://api.github.com/users/ashb","html_url":"https://github.com/ashb","followers_url":"https://api.github.com/users/ashb/followers","following_url":"https://api.github.com/users/ashb/following{/other_user}","gists_url":"https://api.github.com/users/ashb/gists{/gist_id}","starred_url":"https://api.github.com/users/ashb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashb/subscriptions","organizations_url":"https://api.github.com/users/ashb/orgs","repos_url":"https://api.github.com/users/ashb/repos","events_url":"https://api.github.com/users/ashb/events{/privacy}","received_events_url":"https://api.github.com/users/ashb/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T10:01:57Z","updated_at":"2018-08-02T10:01:57Z","author_association":"MEMBER","body":"The existing HttpHook already supports https if you provide it a schema in the connection. Is there something stopping you using that?\r\n\r\nI do not think a whole extra class is useful, especially not a class that duplicates the entirety of HttpHook with only minor changes and no tests."}}
{"actor":{"display_login":"ashb"}}