{"action":"created","comment":{"url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/comments/173883076","pull_request_review_id":103145658,"id":173883076,"diff_hunk":"@@ -1,23 +1,34 @@\n locals {\n   etcd_test_command = \"/opt/etcd/bin/etcdctl --ca-file /opt/etcd/certs/ca.pem --cert-file /opt/etcd/certs/cert.pem --key-file /opt/etcd/certs/cert-key.pem --endpoints https://${module.k8s.public_ipv4_addrs[0]}:2379 member list\"\n-  k8s_test_command = \"sudo /opt/k8s/bin/kubectl --kubeconfig /etc/kubernetes/admin.conf get nodes\"\n+  k8s_admin_config = \"/etc/kubernetes/admin.conf\"\n+  k8s_test_command = \"sudo /opt/k8s/bin/kubectl --kubeconfig ${local.k8s_admin_config} get nodes\"\n+  k8s_config_path = \"~/.kube/config\"\n }\n \n-output \"tf_test_etcd\" {\n-  description = \"This output can be used to check if the cluster is up & running by typing `terraform output tf_test | sh`\"\n+output \"etcd_status\" {\n+  description = \"This output can be used to check if the etcd cluster is up & running by typing\"\n   value = <<TEST\n ssh -o UserKnownHostsFile=/dev/null \\\n     -o StrictHostKeyChecking=no \\\n-    core@${module.k8s.public_ipv4_addrs[0]} sh -c '\"[ \\$(${local.etcd_test_command} | wc -l) == ${var.count} ] && ${local.etcd_test_command} | grep -q isLeader=true\"'\n+    core@${module.k8s.public_ipv4_addrs[0]} -- sh -c '\"[ \\$(${local.etcd_test_command} | wc -l) == ${var.count} ] && ${local.etcd_test_command} | grep -q isLeader=true\"'\n TEST\n }\n \n-output \"tf_test\" {\n-  description = \"This output can be used to check if the cluster is up & running by typing `terraform output tf_test | sh`\"\n+output \"k8s_status\" {","path":"examples/public-cluster-cl/output.tf","position":23,"original_position":23,"commit_id":"d48e47967f669d743053622ee4ebbc53007bf556","original_commit_id":"d48e47967f669d743053622ee4ebbc53007bf556","user":{"login":"yanndegat","id":17246629,"avatar_url":"https://avatars2.githubusercontent.com/u/17246629?v=4","gravatar_id":"","url":"https://api.github.com/users/yanndegat","html_url":"https://github.com/yanndegat","followers_url":"https://api.github.com/users/yanndegat/followers","following_url":"https://api.github.com/users/yanndegat/following{/other_user}","gists_url":"https://api.github.com/users/yanndegat/gists{/gist_id}","starred_url":"https://api.github.com/users/yanndegat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanndegat/subscriptions","organizations_url":"https://api.github.com/users/yanndegat/orgs","repos_url":"https://api.github.com/users/yanndegat/repos","events_url":"https://api.github.com/users/yanndegat/events{/privacy}","received_events_url":"https://api.github.com/users/yanndegat/received_events","type":"User","site_admin":false},"body":"you cant change the name of this output, it's used as a convention to run an acceptance test","created_at":"2018-03-12T17:34:26Z","updated_at":"2018-03-12T17:34:26Z","html_url":"https://github.com/ovh/terraform-ovh-publiccloud-k8s/pull/51#discussion_r173883076","pull_request_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/51","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/comments/173883076"},"html":{"href":"https://github.com/ovh/terraform-ovh-publiccloud-k8s/pull/51#discussion_r173883076"},"pull_request":{"href":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/51","id":174438336,"html_url":"https://github.com/ovh/terraform-ovh-publiccloud-k8s/pull/51","diff_url":"https://github.com/ovh/terraform-ovh-publiccloud-k8s/pull/51.diff","patch_url":"https://github.com/ovh/terraform-ovh-publiccloud-k8s/pull/51.patch","issue_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/issues/51","number":51,"state":"open","locked":false,"title":"Dev/minor documentation","user":{"login":"pierre-peronnet-ovh","id":26902307,"avatar_url":"https://avatars2.githubusercontent.com/u/26902307?v=4","gravatar_id":"","url":"https://api.github.com/users/pierre-peronnet-ovh","html_url":"https://github.com/pierre-peronnet-ovh","followers_url":"https://api.github.com/users/pierre-peronnet-ovh/followers","following_url":"https://api.github.com/users/pierre-peronnet-ovh/following{/other_user}","gists_url":"https://api.github.com/users/pierre-peronnet-ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre-peronnet-ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre-peronnet-ovh/subscriptions","organizations_url":"https://api.github.com/users/pierre-peronnet-ovh/orgs","repos_url":"https://api.github.com/users/pierre-peronnet-ovh/repos","events_url":"https://api.github.com/users/pierre-peronnet-ovh/events{/privacy}","received_events_url":"https://api.github.com/users/pierre-peronnet-ovh/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-12T17:20:27Z","updated_at":"2018-03-12T17:34:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5971e2f595447aee78d0ee4d112e7bd33a175d61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/51/commits","review_comments_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/51/comments","review_comment_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/issues/51/comments","statuses_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/statuses/d48e47967f669d743053622ee4ebbc53007bf556","head":{"label":"pierre-peronnet-ovh:dev/MINOR-documentation","ref":"dev/MINOR-documentation","sha":"d48e47967f669d743053622ee4ebbc53007bf556","user":{"login":"pierre-peronnet-ovh","id":26902307,"avatar_url":"https://avatars2.githubusercontent.com/u/26902307?v=4","gravatar_id":"","url":"https://api.github.com/users/pierre-peronnet-ovh","html_url":"https://github.com/pierre-peronnet-ovh","followers_url":"https://api.github.com/users/pierre-peronnet-ovh/followers","following_url":"https://api.github.com/users/pierre-peronnet-ovh/following{/other_user}","gists_url":"https://api.github.com/users/pierre-peronnet-ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre-peronnet-ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre-peronnet-ovh/subscriptions","organizations_url":"https://api.github.com/users/pierre-peronnet-ovh/orgs","repos_url":"https://api.github.com/users/pierre-peronnet-ovh/repos","events_url":"https://api.github.com/users/pierre-peronnet-ovh/events{/privacy}","received_events_url":"https://api.github.com/users/pierre-peronnet-ovh/received_events","type":"User","site_admin":false},"repo":{"id":124875326,"name":"terraform-ovh-publiccloud-k8s","full_name":"pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s","owner":{"login":"pierre-peronnet-ovh","id":26902307,"avatar_url":"https://avatars2.githubusercontent.com/u/26902307?v=4","gravatar_id":"","url":"https://api.github.com/users/pierre-peronnet-ovh","html_url":"https://github.com/pierre-peronnet-ovh","followers_url":"https://api.github.com/users/pierre-peronnet-ovh/followers","following_url":"https://api.github.com/users/pierre-peronnet-ovh/following{/other_user}","gists_url":"https://api.github.com/users/pierre-peronnet-ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre-peronnet-ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre-peronnet-ovh/subscriptions","organizations_url":"https://api.github.com/users/pierre-peronnet-ovh/orgs","repos_url":"https://api.github.com/users/pierre-peronnet-ovh/repos","events_url":"https://api.github.com/users/pierre-peronnet-ovh/events{/privacy}","received_events_url":"https://api.github.com/users/pierre-peronnet-ovh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s","description":null,"fork":true,"url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s","forks_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/forks","keys_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/teams","hooks_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/hooks","issue_events_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/issues/events{/number}","events_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/events","assignees_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/assignees{/user}","branches_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/branches{/branch}","tags_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/tags","blobs_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/statuses/{sha}","languages_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/languages","stargazers_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/stargazers","contributors_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/contributors","subscribers_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/subscribers","subscription_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/subscription","commits_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/contents/{+path}","compare_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/merges","archive_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/downloads","issues_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/issues{/number}","pulls_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/pulls{/number}","milestones_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/milestones{/number}","notifications_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/labels{/name}","releases_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/releases{/id}","deployments_url":"https://api.github.com/repos/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s/deployments","created_at":"2018-03-12T10:56:08Z","updated_at":"2018-03-12T10:56:09Z","pushed_at":"2018-03-12T17:18:47Z","git_url":"git://github.com/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s.git","ssh_url":"git@github.com:pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s.git","clone_url":"https://github.com/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s.git","svn_url":"https://github.com/pierre-peronnet-ovh/terraform-ovh-publiccloud-k8s","homepage":null,"size":86,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ovh:master","ref":"master","sha":"506de65be40d1496a99bdeb5b88e72c075d3753a","user":{"login":"ovh","id":1698434,"avatar_url":"https://avatars3.githubusercontent.com/u/1698434?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"repo":{"id":121735547,"name":"terraform-ovh-publiccloud-k8s","full_name":"ovh/terraform-ovh-publiccloud-k8s","owner":{"login":"ovh","id":1698434,"avatar_url":"https://avatars3.githubusercontent.com/u/1698434?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ovh/terraform-ovh-publiccloud-k8s","description":null,"fork":false,"url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s","forks_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/forks","keys_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/teams","hooks_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/hooks","issue_events_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/issues/events{/number}","events_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/events","assignees_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/assignees{/user}","branches_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/branches{/branch}","tags_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/tags","blobs_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/languages","stargazers_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/stargazers","contributors_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/contributors","subscribers_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/subscribers","subscription_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/subscription","commits_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/contents/{+path}","compare_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/merges","archive_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/downloads","issues_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/issues{/number}","pulls_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/labels{/name}","releases_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/releases{/id}","deployments_url":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/deployments","created_at":"2018-02-16T09:51:23Z","updated_at":"2018-03-12T17:22:04Z","pushed_at":"2018-03-12T17:20:27Z","git_url":"git://github.com/ovh/terraform-ovh-publiccloud-k8s.git","ssh_url":"git@github.com:ovh/terraform-ovh-publiccloud-k8s.git","clone_url":"https://github.com/ovh/terraform-ovh-publiccloud-k8s.git","svn_url":"https://github.com/ovh/terraform-ovh-publiccloud-k8s","homepage":null,"size":86,"stargazers_count":3,"watchers_count":3,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7,"open_issues":12,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/51"},"html":{"href":"https://github.com/ovh/terraform-ovh-publiccloud-k8s/pull/51"},"issue":{"href":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/issues/51"},"comments":{"href":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/ovh/terraform-ovh-publiccloud-k8s/statuses/d48e47967f669d743053622ee4ebbc53007bf556"}},"author_association":"NONE"}}
{"actor":{"display_login":"yanndegat"}}