{"action":"created","comment":{"url":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments/188053841","pull_request_review_id":119955973,"id":188053841,"diff_hunk":"@@ -184,17 +184,21 @@ def testSegmentSubset( self ) :\n \t\tself.assertEqual( segments[0][\"s\"].data, IECore.StringVectorData( [\"b\"] ) )\n \n \n-\tdef testSegmentUsingIndexedPrimitiveVariable( self ) :\n+\t# def testSegmentUsingIndexedPrimitiveVariable( self ) :","path":"test/IECoreScene/MeshAlgoSegmentTest.py","position":null,"original_position":5,"commit_id":"a818e454333bed3b60a4ff2abe7579e527f725c8","original_commit_id":"91932a0dcf5fba618769620f847cacf84b7f2833","user":{"login":"donboie","id":25311256,"avatar_url":"https://avatars1.githubusercontent.com/u/25311256?v=4","gravatar_id":"","url":"https://api.github.com/users/donboie","html_url":"https://github.com/donboie","followers_url":"https://api.github.com/users/donboie/followers","following_url":"https://api.github.com/users/donboie/following{/other_user}","gists_url":"https://api.github.com/users/donboie/gists{/gist_id}","starred_url":"https://api.github.com/users/donboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donboie/subscriptions","organizations_url":"https://api.github.com/users/donboie/orgs","repos_url":"https://api.github.com/users/donboie/repos","events_url":"https://api.github.com/users/donboie/events{/privacy}","received_events_url":"https://api.github.com/users/donboie/received_events","type":"User","site_admin":false},"body":"This test is reinstated in a later commit. \r\n\r\nPerhaps  I need to add more segment tests for indexed primvars for Points & Curves? There is already some test coverage in the DeleteFaces / Curves / Points already though.","created_at":"2018-05-14T18:31:30Z","updated_at":"2018-05-14T18:36:08Z","html_url":"https://github.com/ImageEngine/cortex/pull/789#discussion_r188053841","pull_request_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/789","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments/188053841"},"html":{"href":"https://github.com/ImageEngine/cortex/pull/789#discussion_r188053841"},"pull_request":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/789"}}},"pull_request":{"url":"https://api.github.com/repos/ImageEngine/cortex/pulls/789","id":187912650,"html_url":"https://github.com/ImageEngine/cortex/pull/789","diff_url":"https://github.com/ImageEngine/cortex/pull/789.diff","patch_url":"https://github.com/ImageEngine/cortex/pull/789.patch","issue_url":"https://api.github.com/repos/ImageEngine/cortex/issues/789","number":789,"state":"open","locked":false,"title":"Segment Primitive performance improvements","user":{"login":"donboie","id":25311256,"avatar_url":"https://avatars1.githubusercontent.com/u/25311256?v=4","gravatar_id":"","url":"https://api.github.com/users/donboie","html_url":"https://github.com/donboie","followers_url":"https://api.github.com/users/donboie/followers","following_url":"https://api.github.com/users/donboie/following{/other_user}","gists_url":"https://api.github.com/users/donboie/gists{/gist_id}","starred_url":"https://api.github.com/users/donboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donboie/subscriptions","organizations_url":"https://api.github.com/users/donboie/orgs","repos_url":"https://api.github.com/users/donboie/repos","events_url":"https://api.github.com/users/donboie/events{/privacy}","received_events_url":"https://api.github.com/users/donboie/received_events","type":"User","site_admin":false},"body":"The cortex segment algo is used by the houdini LiveScene (and therefore exporter), it was implemented by deleting all primitives apart from the part being segmented out, which has horrendous performance as the number of segments increases. \r\n\r\nWe now recursively split the primitive into two parts and dispatch these sub partitions as TBB tasks. \r\n\r\nPerformance could be improved further by \r\n\r\n- not building a set on each split level and using iterators into a sorted vector\r\n- rewriting the segment completely inserting each segment into a primitive directly perhaps.\r\n- multithreading the deleteCurves / Faces / Points algos, perhaps dispatching a primvar as a task? As the first split is single threaded the thread utilization increases after the first couple of rounds.\r\n\r\n**Export timing scene split into 11500 meshes**\r\nbefore: > 30 minutes\r\nafter: 45 seconds\r\n\r\n\r\n\r\n\r\n","created_at":"2018-05-14T18:29:43Z","updated_at":"2018-05-14T18:36:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baadcafe0a50f867ac4508e1fcc20333a90f02c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/789/commits","review_comments_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/789/comments","review_comment_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ImageEngine/cortex/issues/789/comments","statuses_url":"https://api.github.com/repos/ImageEngine/cortex/statuses/a818e454333bed3b60a4ff2abe7579e527f725c8","head":{"label":"donboie:FasterSegment","ref":"FasterSegment","sha":"a818e454333bed3b60a4ff2abe7579e527f725c8","user":{"login":"donboie","id":25311256,"avatar_url":"https://avatars1.githubusercontent.com/u/25311256?v=4","gravatar_id":"","url":"https://api.github.com/users/donboie","html_url":"https://github.com/donboie","followers_url":"https://api.github.com/users/donboie/followers","following_url":"https://api.github.com/users/donboie/following{/other_user}","gists_url":"https://api.github.com/users/donboie/gists{/gist_id}","starred_url":"https://api.github.com/users/donboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donboie/subscriptions","organizations_url":"https://api.github.com/users/donboie/orgs","repos_url":"https://api.github.com/users/donboie/repos","events_url":"https://api.github.com/users/donboie/events{/privacy}","received_events_url":"https://api.github.com/users/donboie/received_events","type":"User","site_admin":false},"repo":{"id":80573606,"name":"cortex","full_name":"donboie/cortex","owner":{"login":"donboie","id":25311256,"avatar_url":"https://avatars1.githubusercontent.com/u/25311256?v=4","gravatar_id":"","url":"https://api.github.com/users/donboie","html_url":"https://github.com/donboie","followers_url":"https://api.github.com/users/donboie/followers","following_url":"https://api.github.com/users/donboie/following{/other_user}","gists_url":"https://api.github.com/users/donboie/gists{/gist_id}","starred_url":"https://api.github.com/users/donboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donboie/subscriptions","organizations_url":"https://api.github.com/users/donboie/orgs","repos_url":"https://api.github.com/users/donboie/repos","events_url":"https://api.github.com/users/donboie/events{/privacy}","received_events_url":"https://api.github.com/users/donboie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/donboie/cortex","description":"Libraries for visual effects software development","fork":true,"url":"https://api.github.com/repos/donboie/cortex","forks_url":"https://api.github.com/repos/donboie/cortex/forks","keys_url":"https://api.github.com/repos/donboie/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donboie/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donboie/cortex/teams","hooks_url":"https://api.github.com/repos/donboie/cortex/hooks","issue_events_url":"https://api.github.com/repos/donboie/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/donboie/cortex/events","assignees_url":"https://api.github.com/repos/donboie/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/donboie/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/donboie/cortex/tags","blobs_url":"https://api.github.com/repos/donboie/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donboie/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donboie/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/donboie/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donboie/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/donboie/cortex/languages","stargazers_url":"https://api.github.com/repos/donboie/cortex/stargazers","contributors_url":"https://api.github.com/repos/donboie/cortex/contributors","subscribers_url":"https://api.github.com/repos/donboie/cortex/subscribers","subscription_url":"https://api.github.com/repos/donboie/cortex/subscription","commits_url":"https://api.github.com/repos/donboie/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/donboie/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/donboie/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/donboie/cortex/issues/comments{/number}","contents_url":"https://api.github.com/repos/donboie/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/donboie/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donboie/cortex/merges","archive_url":"https://api.github.com/repos/donboie/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donboie/cortex/downloads","issues_url":"https://api.github.com/repos/donboie/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/donboie/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/donboie/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/donboie/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donboie/cortex/labels{/name}","releases_url":"https://api.github.com/repos/donboie/cortex/releases{/id}","deployments_url":"https://api.github.com/repos/donboie/cortex/deployments","created_at":"2017-01-31T23:39:09Z","updated_at":"2018-04-20T03:14:07Z","pushed_at":"2018-05-14T18:01:40Z","git_url":"git://github.com/donboie/cortex.git","ssh_url":"git@github.com:donboie/cortex.git","clone_url":"https://github.com/donboie/cortex.git","svn_url":"https://github.com/donboie/cortex","homepage":null,"size":105229,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ImageEngine:master","ref":"master","sha":"e65ae9f4deb771193b2b862ccd5ff033158dbbff","user":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars1.githubusercontent.com/u/3976662?v=4","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":10654465,"name":"cortex","full_name":"ImageEngine/cortex","owner":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars1.githubusercontent.com/u/3976662?v=4","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ImageEngine/cortex","description":"Libraries for visual effects software development","fork":false,"url":"https://api.github.com/repos/ImageEngine/cortex","forks_url":"https://api.github.com/repos/ImageEngine/cortex/forks","keys_url":"https://api.github.com/repos/ImageEngine/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImageEngine/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImageEngine/cortex/teams","hooks_url":"https://api.github.com/repos/ImageEngine/cortex/hooks","issue_events_url":"https://api.github.com/repos/ImageEngine/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/ImageEngine/cortex/events","assignees_url":"https://api.github.com/repos/ImageEngine/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/ImageEngine/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/ImageEngine/cortex/tags","blobs_url":"https://api.github.com/repos/ImageEngine/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImageEngine/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImageEngine/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImageEngine/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImageEngine/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/ImageEngine/cortex/languages","stargazers_url":"https://api.github.com/repos/ImageEngine/cortex/stargazers","contributors_url":"https://api.github.com/repos/ImageEngine/cortex/contributors","subscribers_url":"https://api.github.com/repos/ImageEngine/cortex/subscribers","subscription_url":"https://api.github.com/repos/ImageEngine/cortex/subscription","commits_url":"https://api.github.com/repos/ImageEngine/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImageEngine/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImageEngine/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImageEngine/cortex/issues/comments{/number}","contents_url":"https://api.github.com/repos/ImageEngine/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/ImageEngine/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImageEngine/cortex/merges","archive_url":"https://api.github.com/repos/ImageEngine/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImageEngine/cortex/downloads","issues_url":"https://api.github.com/repos/ImageEngine/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/ImageEngine/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/ImageEngine/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/ImageEngine/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImageEngine/cortex/labels{/name}","releases_url":"https://api.github.com/repos/ImageEngine/cortex/releases{/id}","deployments_url":"https://api.github.com/repos/ImageEngine/cortex/deployments","created_at":"2013-06-12T23:12:28Z","updated_at":"2018-05-11T19:21:07Z","pushed_at":"2018-05-14T18:29:43Z","git_url":"git://github.com/ImageEngine/cortex.git","ssh_url":"git@github.com:ImageEngine/cortex.git","clone_url":"https://github.com/ImageEngine/cortex.git","svn_url":"https://github.com/ImageEngine/cortex","homepage":null,"size":105026,"stargazers_count":259,"watchers_count":259,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":80,"open_issues":45,"watchers":259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/789"},"html":{"href":"https://github.com/ImageEngine/cortex/pull/789"},"issue":{"href":"https://api.github.com/repos/ImageEngine/cortex/issues/789"},"comments":{"href":"https://api.github.com/repos/ImageEngine/cortex/issues/789/comments"},"review_comments":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/789/comments"},"review_comment":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/789/commits"},"statuses":{"href":"https://api.github.com/repos/ImageEngine/cortex/statuses/a818e454333bed3b60a4ff2abe7579e527f725c8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"donboie"}}