{"action":"created","comment":{"url":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/comments/168907815","pull_request_review_id":97236292,"id":168907815,"diff_hunk":"@@ -359,6 +374,25 @@ public ExistentialVariableSlot createExistentialVariableSlot(VariableSlot potent\n         return existentialVariableSlot;\n     }\n \n+    @Override\n+    public ArithmeticVariableSlot createArithmeticVariableSlot(ArithmeticOperationKind operation,\n+            VariableSlot leftOperand, VariableSlot rightOperand) {\n+        ArithmeticVariableSlot arithmeticVariableSlot;\n+        Pair<Slot, Slot> pair = new Pair<>(leftOperand, rightOperand);\n+\n+        Map<Pair<Slot, Slot>, Integer> slotsForOp = arithmeticSlotCache.get(operation);\n+        if (slotsForOp.containsKey(pair)) {\n+            int id = slotsForOp.get(pair);\n+            arithmeticVariableSlot = (ArithmeticVariableSlot) getVariable(id);\n+        } else {\n+            arithmeticVariableSlot = new ArithmeticVariableSlot(\n+                    null, nextId(), operation, leftOperand, rightOperand);","path":"src/checkers/inference/DefaultSlotManager.java","position":52,"original_position":52,"commit_id":"e0b997f8029f6332132cdf7763be8930d0d49ddc","original_commit_id":"e0b997f8029f6332132cdf7763be8930d0d49ddc","user":{"login":"jyluo","id":13159245,"avatar_url":"https://avatars3.githubusercontent.com/u/13159245?v=4","gravatar_id":"","url":"https://api.github.com/users/jyluo","html_url":"https://github.com/jyluo","followers_url":"https://api.github.com/users/jyluo/followers","following_url":"https://api.github.com/users/jyluo/following{/other_user}","gists_url":"https://api.github.com/users/jyluo/gists{/gist_id}","starred_url":"https://api.github.com/users/jyluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyluo/subscriptions","organizations_url":"https://api.github.com/users/jyluo/orgs","repos_url":"https://api.github.com/users/jyluo/repos","events_url":"https://api.github.com/users/jyluo/events{/privacy}","received_events_url":"https://api.github.com/users/jyluo/received_events","type":"User","site_admin":false},"body":"I started this method based on combine constraint, will add it as a parameter and pass it in.","created_at":"2018-02-17T01:47:42Z","updated_at":"2018-02-17T01:48:06Z","html_url":"https://github.com/opprop/checker-framework-inference/pull/149#discussion_r168907815","pull_request_url":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/149","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/comments/168907815"},"html":{"href":"https://github.com/opprop/checker-framework-inference/pull/149#discussion_r168907815"},"pull_request":{"href":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/149"}},"in_reply_to_id":168838715},"pull_request":{"url":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/149","id":168089763,"html_url":"https://github.com/opprop/checker-framework-inference/pull/149","diff_url":"https://github.com/opprop/checker-framework-inference/pull/149.diff","patch_url":"https://github.com/opprop/checker-framework-inference/pull/149.patch","issue_url":"https://api.github.com/repos/opprop/checker-framework-inference/issues/149","number":149,"state":"open","locked":false,"title":"Add arithmetic constraint","user":{"login":"jyluo","id":13159245,"avatar_url":"https://avatars3.githubusercontent.com/u/13159245?v=4","gravatar_id":"","url":"https://api.github.com/users/jyluo","html_url":"https://github.com/jyluo","followers_url":"https://api.github.com/users/jyluo/followers","following_url":"https://api.github.com/users/jyluo/following{/other_user}","gists_url":"https://api.github.com/users/jyluo/gists{/gist_id}","starred_url":"https://api.github.com/users/jyluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyluo/subscriptions","organizations_url":"https://api.github.com/users/jyluo/orgs","repos_url":"https://api.github.com/users/jyluo/repos","events_url":"https://api.github.com/users/jyluo/events{/privacy}","received_events_url":"https://api.github.com/users/jyluo/received_events","type":"User","site_admin":false},"body":"This PR adds the arithmetic constraint which is used by the units inference checker.","created_at":"2018-02-08T21:19:00Z","updated_at":"2018-02-17T01:48:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4476e34990bc01daf410b9beb141cdbb58ba16a0","assignee":{"login":"jyluo","id":13159245,"avatar_url":"https://avatars3.githubusercontent.com/u/13159245?v=4","gravatar_id":"","url":"https://api.github.com/users/jyluo","html_url":"https://github.com/jyluo","followers_url":"https://api.github.com/users/jyluo/followers","following_url":"https://api.github.com/users/jyluo/following{/other_user}","gists_url":"https://api.github.com/users/jyluo/gists{/gist_id}","starred_url":"https://api.github.com/users/jyluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyluo/subscriptions","organizations_url":"https://api.github.com/users/jyluo/orgs","repos_url":"https://api.github.com/users/jyluo/repos","events_url":"https://api.github.com/users/jyluo/events{/privacy}","received_events_url":"https://api.github.com/users/jyluo/received_events","type":"User","site_admin":false},"assignees":[{"login":"jyluo","id":13159245,"avatar_url":"https://avatars3.githubusercontent.com/u/13159245?v=4","gravatar_id":"","url":"https://api.github.com/users/jyluo","html_url":"https://github.com/jyluo","followers_url":"https://api.github.com/users/jyluo/followers","following_url":"https://api.github.com/users/jyluo/following{/other_user}","gists_url":"https://api.github.com/users/jyluo/gists{/gist_id}","starred_url":"https://api.github.com/users/jyluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyluo/subscriptions","organizations_url":"https://api.github.com/users/jyluo/orgs","repos_url":"https://api.github.com/users/jyluo/repos","events_url":"https://api.github.com/users/jyluo/events{/privacy}","received_events_url":"https://api.github.com/users/jyluo/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"wmdietl","id":6699136,"avatar_url":"https://avatars1.githubusercontent.com/u/6699136?v=4","gravatar_id":"","url":"https://api.github.com/users/wmdietl","html_url":"https://github.com/wmdietl","followers_url":"https://api.github.com/users/wmdietl/followers","following_url":"https://api.github.com/users/wmdietl/following{/other_user}","gists_url":"https://api.github.com/users/wmdietl/gists{/gist_id}","starred_url":"https://api.github.com/users/wmdietl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmdietl/subscriptions","organizations_url":"https://api.github.com/users/wmdietl/orgs","repos_url":"https://api.github.com/users/wmdietl/repos","events_url":"https://api.github.com/users/wmdietl/events{/privacy}","received_events_url":"https://api.github.com/users/wmdietl/received_events","type":"User","site_admin":false},{"login":"topnessman","id":15336177,"avatar_url":"https://avatars0.githubusercontent.com/u/15336177?v=4","gravatar_id":"","url":"https://api.github.com/users/topnessman","html_url":"https://github.com/topnessman","followers_url":"https://api.github.com/users/topnessman/followers","following_url":"https://api.github.com/users/topnessman/following{/other_user}","gists_url":"https://api.github.com/users/topnessman/gists{/gist_id}","starred_url":"https://api.github.com/users/topnessman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topnessman/subscriptions","organizations_url":"https://api.github.com/users/topnessman/orgs","repos_url":"https://api.github.com/users/topnessman/repos","events_url":"https://api.github.com/users/topnessman/events{/privacy}","received_events_url":"https://api.github.com/users/topnessman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/149/commits","review_comments_url":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/149/comments","review_comment_url":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opprop/checker-framework-inference/issues/149/comments","statuses_url":"https://api.github.com/repos/opprop/checker-framework-inference/statuses/e0b997f8029f6332132cdf7763be8930d0d49ddc","head":{"label":"jyluo:AddArithmeticConstraint","ref":"AddArithmeticConstraint","sha":"e0b997f8029f6332132cdf7763be8930d0d49ddc","user":{"login":"jyluo","id":13159245,"avatar_url":"https://avatars3.githubusercontent.com/u/13159245?v=4","gravatar_id":"","url":"https://api.github.com/users/jyluo","html_url":"https://github.com/jyluo","followers_url":"https://api.github.com/users/jyluo/followers","following_url":"https://api.github.com/users/jyluo/following{/other_user}","gists_url":"https://api.github.com/users/jyluo/gists{/gist_id}","starred_url":"https://api.github.com/users/jyluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyluo/subscriptions","organizations_url":"https://api.github.com/users/jyluo/orgs","repos_url":"https://api.github.com/users/jyluo/repos","events_url":"https://api.github.com/users/jyluo/events{/privacy}","received_events_url":"https://api.github.com/users/jyluo/received_events","type":"User","site_admin":false},"repo":{"id":68767428,"name":"checker-framework-inference","full_name":"jyluo/checker-framework-inference","owner":{"login":"jyluo","id":13159245,"avatar_url":"https://avatars3.githubusercontent.com/u/13159245?v=4","gravatar_id":"","url":"https://api.github.com/users/jyluo","html_url":"https://github.com/jyluo","followers_url":"https://api.github.com/users/jyluo/followers","following_url":"https://api.github.com/users/jyluo/following{/other_user}","gists_url":"https://api.github.com/users/jyluo/gists{/gist_id}","starred_url":"https://api.github.com/users/jyluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyluo/subscriptions","organizations_url":"https://api.github.com/users/jyluo/orgs","repos_url":"https://api.github.com/users/jyluo/repos","events_url":"https://api.github.com/users/jyluo/events{/privacy}","received_events_url":"https://api.github.com/users/jyluo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jyluo/checker-framework-inference","description":"Inference of pluggable types for Java","fork":true,"url":"https://api.github.com/repos/jyluo/checker-framework-inference","forks_url":"https://api.github.com/repos/jyluo/checker-framework-inference/forks","keys_url":"https://api.github.com/repos/jyluo/checker-framework-inference/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jyluo/checker-framework-inference/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jyluo/checker-framework-inference/teams","hooks_url":"https://api.github.com/repos/jyluo/checker-framework-inference/hooks","issue_events_url":"https://api.github.com/repos/jyluo/checker-framework-inference/issues/events{/number}","events_url":"https://api.github.com/repos/jyluo/checker-framework-inference/events","assignees_url":"https://api.github.com/repos/jyluo/checker-framework-inference/assignees{/user}","branches_url":"https://api.github.com/repos/jyluo/checker-framework-inference/branches{/branch}","tags_url":"https://api.github.com/repos/jyluo/checker-framework-inference/tags","blobs_url":"https://api.github.com/repos/jyluo/checker-framework-inference/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jyluo/checker-framework-inference/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jyluo/checker-framework-inference/git/refs{/sha}","trees_url":"https://api.github.com/repos/jyluo/checker-framework-inference/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jyluo/checker-framework-inference/statuses/{sha}","languages_url":"https://api.github.com/repos/jyluo/checker-framework-inference/languages","stargazers_url":"https://api.github.com/repos/jyluo/checker-framework-inference/stargazers","contributors_url":"https://api.github.com/repos/jyluo/checker-framework-inference/contributors","subscribers_url":"https://api.github.com/repos/jyluo/checker-framework-inference/subscribers","subscription_url":"https://api.github.com/repos/jyluo/checker-framework-inference/subscription","commits_url":"https://api.github.com/repos/jyluo/checker-framework-inference/commits{/sha}","git_commits_url":"https://api.github.com/repos/jyluo/checker-framework-inference/git/commits{/sha}","comments_url":"https://api.github.com/repos/jyluo/checker-framework-inference/comments{/number}","issue_comment_url":"https://api.github.com/repos/jyluo/checker-framework-inference/issues/comments{/number}","contents_url":"https://api.github.com/repos/jyluo/checker-framework-inference/contents/{+path}","compare_url":"https://api.github.com/repos/jyluo/checker-framework-inference/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jyluo/checker-framework-inference/merges","archive_url":"https://api.github.com/repos/jyluo/checker-framework-inference/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jyluo/checker-framework-inference/downloads","issues_url":"https://api.github.com/repos/jyluo/checker-framework-inference/issues{/number}","pulls_url":"https://api.github.com/repos/jyluo/checker-framework-inference/pulls{/number}","milestones_url":"https://api.github.com/repos/jyluo/checker-framework-inference/milestones{/number}","notifications_url":"https://api.github.com/repos/jyluo/checker-framework-inference/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jyluo/checker-framework-inference/labels{/name}","releases_url":"https://api.github.com/repos/jyluo/checker-framework-inference/releases{/id}","deployments_url":"https://api.github.com/repos/jyluo/checker-framework-inference/deployments","created_at":"2016-09-21T01:25:51Z","updated_at":"2016-09-21T01:25:52Z","pushed_at":"2018-02-16T03:55:40Z","git_url":"git://github.com/jyluo/checker-framework-inference.git","ssh_url":"git@github.com:jyluo/checker-framework-inference.git","clone_url":"https://github.com/jyluo/checker-framework-inference.git","svn_url":"https://github.com/jyluo/checker-framework-inference","homepage":"","size":2930,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opprop:master","ref":"master","sha":"d307fc6ac893b2a48254579b03ee75a644d5bd55","user":{"login":"opprop","id":20308424,"avatar_url":"https://avatars1.githubusercontent.com/u/20308424?v=4","gravatar_id":"","url":"https://api.github.com/users/opprop","html_url":"https://github.com/opprop","followers_url":"https://api.github.com/users/opprop/followers","following_url":"https://api.github.com/users/opprop/following{/other_user}","gists_url":"https://api.github.com/users/opprop/gists{/gist_id}","starred_url":"https://api.github.com/users/opprop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opprop/subscriptions","organizations_url":"https://api.github.com/users/opprop/orgs","repos_url":"https://api.github.com/users/opprop/repos","events_url":"https://api.github.com/users/opprop/events{/privacy}","received_events_url":"https://api.github.com/users/opprop/received_events","type":"Organization","site_admin":false},"repo":{"id":62672562,"name":"checker-framework-inference","full_name":"opprop/checker-framework-inference","owner":{"login":"opprop","id":20308424,"avatar_url":"https://avatars1.githubusercontent.com/u/20308424?v=4","gravatar_id":"","url":"https://api.github.com/users/opprop","html_url":"https://github.com/opprop","followers_url":"https://api.github.com/users/opprop/followers","following_url":"https://api.github.com/users/opprop/following{/other_user}","gists_url":"https://api.github.com/users/opprop/gists{/gist_id}","starred_url":"https://api.github.com/users/opprop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opprop/subscriptions","organizations_url":"https://api.github.com/users/opprop/orgs","repos_url":"https://api.github.com/users/opprop/repos","events_url":"https://api.github.com/users/opprop/events{/privacy}","received_events_url":"https://api.github.com/users/opprop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opprop/checker-framework-inference","description":"Inference of pluggable types for Java","fork":true,"url":"https://api.github.com/repos/opprop/checker-framework-inference","forks_url":"https://api.github.com/repos/opprop/checker-framework-inference/forks","keys_url":"https://api.github.com/repos/opprop/checker-framework-inference/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opprop/checker-framework-inference/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opprop/checker-framework-inference/teams","hooks_url":"https://api.github.com/repos/opprop/checker-framework-inference/hooks","issue_events_url":"https://api.github.com/repos/opprop/checker-framework-inference/issues/events{/number}","events_url":"https://api.github.com/repos/opprop/checker-framework-inference/events","assignees_url":"https://api.github.com/repos/opprop/checker-framework-inference/assignees{/user}","branches_url":"https://api.github.com/repos/opprop/checker-framework-inference/branches{/branch}","tags_url":"https://api.github.com/repos/opprop/checker-framework-inference/tags","blobs_url":"https://api.github.com/repos/opprop/checker-framework-inference/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opprop/checker-framework-inference/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opprop/checker-framework-inference/git/refs{/sha}","trees_url":"https://api.github.com/repos/opprop/checker-framework-inference/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opprop/checker-framework-inference/statuses/{sha}","languages_url":"https://api.github.com/repos/opprop/checker-framework-inference/languages","stargazers_url":"https://api.github.com/repos/opprop/checker-framework-inference/stargazers","contributors_url":"https://api.github.com/repos/opprop/checker-framework-inference/contributors","subscribers_url":"https://api.github.com/repos/opprop/checker-framework-inference/subscribers","subscription_url":"https://api.github.com/repos/opprop/checker-framework-inference/subscription","commits_url":"https://api.github.com/repos/opprop/checker-framework-inference/commits{/sha}","git_commits_url":"https://api.github.com/repos/opprop/checker-framework-inference/git/commits{/sha}","comments_url":"https://api.github.com/repos/opprop/checker-framework-inference/comments{/number}","issue_comment_url":"https://api.github.com/repos/opprop/checker-framework-inference/issues/comments{/number}","contents_url":"https://api.github.com/repos/opprop/checker-framework-inference/contents/{+path}","compare_url":"https://api.github.com/repos/opprop/checker-framework-inference/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opprop/checker-framework-inference/merges","archive_url":"https://api.github.com/repos/opprop/checker-framework-inference/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opprop/checker-framework-inference/downloads","issues_url":"https://api.github.com/repos/opprop/checker-framework-inference/issues{/number}","pulls_url":"https://api.github.com/repos/opprop/checker-framework-inference/pulls{/number}","milestones_url":"https://api.github.com/repos/opprop/checker-framework-inference/milestones{/number}","notifications_url":"https://api.github.com/repos/opprop/checker-framework-inference/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opprop/checker-framework-inference/labels{/name}","releases_url":"https://api.github.com/repos/opprop/checker-framework-inference/releases{/id}","deployments_url":"https://api.github.com/repos/opprop/checker-framework-inference/deployments","created_at":"2016-07-05T22:01:58Z","updated_at":"2016-10-28T03:22:54Z","pushed_at":"2018-02-16T23:23:57Z","git_url":"git://github.com/opprop/checker-framework-inference.git","ssh_url":"git@github.com:opprop/checker-framework-inference.git","clone_url":"https://github.com/opprop/checker-framework-inference.git","svn_url":"https://github.com/opprop/checker-framework-inference","homepage":"","size":3129,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":41,"license":null,"forks":3,"open_issues":41,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/149"},"html":{"href":"https://github.com/opprop/checker-framework-inference/pull/149"},"issue":{"href":"https://api.github.com/repos/opprop/checker-framework-inference/issues/149"},"comments":{"href":"https://api.github.com/repos/opprop/checker-framework-inference/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opprop/checker-framework-inference/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/opprop/checker-framework-inference/statuses/e0b997f8029f6332132cdf7763be8930d0d49ddc"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jyluo"}}