{"action":"created","issue":{"url":"https://api.github.com/repos/hackingmaterials/matminer/issues/124","repository_url":"https://api.github.com/repos/hackingmaterials/matminer","labels_url":"https://api.github.com/repos/hackingmaterials/matminer/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/hackingmaterials/matminer/issues/124/comments","events_url":"https://api.github.com/repos/hackingmaterials/matminer/issues/124/events","html_url":"https://github.com/hackingmaterials/matminer/pull/124","id":294560766,"number":124,"title":"MDF interface","user":{"login":"montoyjh","id":6494516,"avatar_url":"https://avatars1.githubusercontent.com/u/6494516?v=4","gravatar_id":"","url":"https://api.github.com/users/montoyjh","html_url":"https://github.com/montoyjh","followers_url":"https://api.github.com/users/montoyjh/followers","following_url":"https://api.github.com/users/montoyjh/following{/other_user}","gists_url":"https://api.github.com/users/montoyjh/gists{/gist_id}","starred_url":"https://api.github.com/users/montoyjh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montoyjh/subscriptions","organizations_url":"https://api.github.com/users/montoyjh/orgs","repos_url":"https://api.github.com/users/montoyjh/repos","events_url":"https://api.github.com/users/montoyjh/events{/privacy}","received_events_url":"https://api.github.com/users/montoyjh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-05T22:11:58Z","updated_at":"2018-02-06T18:12:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hackingmaterials/matminer/pulls/124","html_url":"https://github.com/hackingmaterials/matminer/pull/124","diff_url":"https://github.com/hackingmaterials/matminer/pull/124.diff","patch_url":"https://github.com/hackingmaterials/matminer/pull/124.patch"},"body":"Sorry for the delay on this, I got tied up with a bug related to the anonymous invocation of the forge (this functionality is nice, because you can write unittests without an API key or logging in through globus).  Intended to address #94.\r\n\r\n* Adds an MDF data retrieval tool, data_retrieval.retrieve_MDF.MDFDataRetrieval, which invokes a Forge object from mdf_forge (added as a dependency) and accepts any kwargs used to construct Forge.\r\n* MDFDataRetrieval has two methods `search` and `search_by_query` which allow a user to search either by a set of keyword arguments (documented in the docstring for `search`) or a direct MDF query.\r\n* I also accidentally wrote my own flatten_dict method, which I thought was a bit more readable (although no more or less functional) than the one already in MatMiner, so I replaced the old one and added a unittest in utils.\r\n\r\nUsage:\r\n```\r\nmdf_dr = MDFDataRetrieval(anonymous=True) # or no anonymous, will be prompted for auth\r\nresults = mdf_dr.search(sources=['oqmd'], elements=['Be', 'Ag', 'V'])\r\n```\r\n\r\nWorking through codacy."},"comment":{"url":"https://api.github.com/repos/hackingmaterials/matminer/issues/comments/363513887","html_url":"https://github.com/hackingmaterials/matminer/pull/124#issuecomment-363513887","issue_url":"https://api.github.com/repos/hackingmaterials/matminer/issues/124","id":363513887,"user":{"login":"computron","id":986759,"avatar_url":"https://avatars2.githubusercontent.com/u/986759?v=4","gravatar_id":"","url":"https://api.github.com/users/computron","html_url":"https://github.com/computron","followers_url":"https://api.github.com/users/computron/followers","following_url":"https://api.github.com/users/computron/following{/other_user}","gists_url":"https://api.github.com/users/computron/gists{/gist_id}","starred_url":"https://api.github.com/users/computron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/computron/subscriptions","organizations_url":"https://api.github.com/users/computron/orgs","repos_url":"https://api.github.com/users/computron/repos","events_url":"https://api.github.com/users/computron/events{/privacy}","received_events_url":"https://api.github.com/users/computron/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T18:12:54Z","updated_at":"2018-02-06T18:12:54Z","author_association":"CONTRIBUTOR","body":"I think it's some kind of Codacy bug, don't worry about it. Codacy is just there as a guideline anyway, sometimes if you try to make all its suggestions go away the code gets worse. So humans > Codacy.\r\n\r\nWill take a look at this PR and merge hopefully soon, if I ever escape from meetings ..."}}
{"actor":{"display_login":"computron"}}