{"action":"created","comment":{"url":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/comments/185539361","pull_request_review_id":116903941,"id":185539361,"diff_hunk":"@@ -3,14 +3,14 @@\n import argparse\n import os\n import sys\n-","path":"upload/docker_images/checksummer/checksummer.py","position":4,"original_position":4,"commit_id":"4630610100ec7bdeddb9fa131b07d5cef3617901","original_commit_id":"3628134f81cb0de777a295438b6a2b95090e458f","user":{"login":"sampierson","id":441066,"avatar_url":"https://avatars2.githubusercontent.com/u/441066?v=4","gravatar_id":"","url":"https://api.github.com/users/sampierson","html_url":"https://github.com/sampierson","followers_url":"https://api.github.com/users/sampierson/followers","following_url":"https://api.github.com/users/sampierson/following{/other_user}","gists_url":"https://api.github.com/users/sampierson/gists{/gist_id}","starred_url":"https://api.github.com/users/sampierson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sampierson/subscriptions","organizations_url":"https://api.github.com/users/sampierson/orgs","repos_url":"https://api.github.com/users/sampierson/repos","events_url":"https://api.github.com/users/sampierson/events{/privacy}","received_events_url":"https://api.github.com/users/sampierson/received_events","type":"User","site_admin":false},"body":"Please follow the conventions of the codebase you're working in, or ask.  I believe the data store also uses this convention.  That's where I got it, and it makes sense.","created_at":"2018-05-02T15:31:14Z","updated_at":"2018-05-02T15:41:49Z","html_url":"https://github.com/HumanCellAtlas/upload-service/pull/53#discussion_r185539361","pull_request_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/53","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/comments/185539361"},"html":{"href":"https://github.com/HumanCellAtlas/upload-service/pull/53#discussion_r185539361"},"pull_request":{"href":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/53","id":184212219,"html_url":"https://github.com/HumanCellAtlas/upload-service/pull/53","diff_url":"https://github.com/HumanCellAtlas/upload-service/pull/53.diff","patch_url":"https://github.com/HumanCellAtlas/upload-service/pull/53.patch","issue_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/issues/53","number":53,"state":"open","locked":false,"title":"Aurora database integration","user":{"login":"parthshahva","id":6373241,"avatar_url":"https://avatars2.githubusercontent.com/u/6373241?v=4","gravatar_id":"","url":"https://api.github.com/users/parthshahva","html_url":"https://github.com/parthshahva","followers_url":"https://api.github.com/users/parthshahva/followers","following_url":"https://api.github.com/users/parthshahva/following{/other_user}","gists_url":"https://api.github.com/users/parthshahva/gists{/gist_id}","starred_url":"https://api.github.com/users/parthshahva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parthshahva/subscriptions","organizations_url":"https://api.github.com/users/parthshahva/orgs","repos_url":"https://api.github.com/users/parthshahva/repos","events_url":"https://api.github.com/users/parthshahva/events{/privacy}","received_events_url":"https://api.github.com/users/parthshahva/received_events","type":"User","site_admin":false},"body":"Things left\r\n1) Manual testing of validation and checksummer images\r\n2) Review code climate\r\n3) get tests to pass in travis\r\n4) Edgcase and exception handling + logging\r\n5) update readme with new dev and deployment instructions\r\n\r\nStory of commits:\r\n1) Terraform setup of database module \r\n2) Alembic integration for management of schema and migrations\r\n3) Database.py module and tests using sqlalchemy library (library that alembic is built upon as well)\r\n4) DB interface for upload area, uploaded file, and ingest notifier\r\n5) changes/additions to upload api (2 new endpoints) and inclusion of ingest notifier from upload api with tests\r\n6) client method for updating validation and checksum events called from docker images with tests\r\n7) changes to checksumming flow to use new data flow and classes, no more immediate checksumming\r\n8) changes to validation flow to use new data flow and classes","created_at":"2018-04-26T02:46:00Z","updated_at":"2018-05-02T15:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85f66ee4c5c7769c97ee7e89d3bbc3c4b3d6ea52","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mweiden","id":538456,"avatar_url":"https://avatars3.githubusercontent.com/u/538456?v=4","gravatar_id":"","url":"https://api.github.com/users/mweiden","html_url":"https://github.com/mweiden","followers_url":"https://api.github.com/users/mweiden/followers","following_url":"https://api.github.com/users/mweiden/following{/other_user}","gists_url":"https://api.github.com/users/mweiden/gists{/gist_id}","starred_url":"https://api.github.com/users/mweiden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mweiden/subscriptions","organizations_url":"https://api.github.com/users/mweiden/orgs","repos_url":"https://api.github.com/users/mweiden/repos","events_url":"https://api.github.com/users/mweiden/events{/privacy}","received_events_url":"https://api.github.com/users/mweiden/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/53/commits","review_comments_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/53/comments","review_comment_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/issues/53/comments","statuses_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/statuses/4630610100ec7bdeddb9fa131b07d5cef3617901","head":{"label":"HumanCellAtlas:database","ref":"database","sha":"4630610100ec7bdeddb9fa131b07d5cef3617901","user":{"login":"HumanCellAtlas","id":26391798,"avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"repo":{"id":96461745,"name":"upload-service","full_name":"HumanCellAtlas/upload-service","owner":{"login":"HumanCellAtlas","id":26391798,"avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HumanCellAtlas/upload-service","description":"DCP Ingestion File Upload Service","fork":false,"url":"https://api.github.com/repos/HumanCellAtlas/upload-service","forks_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/forks","keys_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/teams","hooks_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/hooks","issue_events_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/issues/events{/number}","events_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/events","assignees_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/assignees{/user}","branches_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/branches{/branch}","tags_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/tags","blobs_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/statuses/{sha}","languages_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/languages","stargazers_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/stargazers","contributors_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/contributors","subscribers_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/subscribers","subscription_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/subscription","commits_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/contents/{+path}","compare_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/merges","archive_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/downloads","issues_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/issues{/number}","pulls_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls{/number}","milestones_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/milestones{/number}","notifications_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/labels{/name}","releases_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/releases{/id}","deployments_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/deployments","created_at":"2017-07-06T18:45:36Z","updated_at":"2018-04-28T00:17:26Z","pushed_at":"2018-05-02T01:49:55Z","git_url":"git://github.com/HumanCellAtlas/upload-service.git","ssh_url":"git@github.com:HumanCellAtlas/upload-service.git","clone_url":"https://github.com/HumanCellAtlas/upload-service.git","svn_url":"https://github.com/HumanCellAtlas/upload-service","homepage":"","size":2491,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":47,"watchers":3,"default_branch":"master"}},"base":{"label":"HumanCellAtlas:master","ref":"master","sha":"67b972a841286ac49568935d2a0c741defa4cf4c","user":{"login":"HumanCellAtlas","id":26391798,"avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"repo":{"id":96461745,"name":"upload-service","full_name":"HumanCellAtlas/upload-service","owner":{"login":"HumanCellAtlas","id":26391798,"avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HumanCellAtlas/upload-service","description":"DCP Ingestion File Upload Service","fork":false,"url":"https://api.github.com/repos/HumanCellAtlas/upload-service","forks_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/forks","keys_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/teams","hooks_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/hooks","issue_events_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/issues/events{/number}","events_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/events","assignees_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/assignees{/user}","branches_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/branches{/branch}","tags_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/tags","blobs_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/statuses/{sha}","languages_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/languages","stargazers_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/stargazers","contributors_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/contributors","subscribers_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/subscribers","subscription_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/subscription","commits_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/contents/{+path}","compare_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/merges","archive_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/downloads","issues_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/issues{/number}","pulls_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls{/number}","milestones_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/milestones{/number}","notifications_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/labels{/name}","releases_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/releases{/id}","deployments_url":"https://api.github.com/repos/HumanCellAtlas/upload-service/deployments","created_at":"2017-07-06T18:45:36Z","updated_at":"2018-04-28T00:17:26Z","pushed_at":"2018-05-02T01:49:55Z","git_url":"git://github.com/HumanCellAtlas/upload-service.git","ssh_url":"git@github.com:HumanCellAtlas/upload-service.git","clone_url":"https://github.com/HumanCellAtlas/upload-service.git","svn_url":"https://github.com/HumanCellAtlas/upload-service","homepage":"","size":2491,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":47,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/53"},"html":{"href":"https://github.com/HumanCellAtlas/upload-service/pull/53"},"issue":{"href":"https://api.github.com/repos/HumanCellAtlas/upload-service/issues/53"},"comments":{"href":"https://api.github.com/repos/HumanCellAtlas/upload-service/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HumanCellAtlas/upload-service/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/HumanCellAtlas/upload-service/statuses/4630610100ec7bdeddb9fa131b07d5cef3617901"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sampierson"}}