{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/232547041","pull_request_review_id":173765929,"id":232547041,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjU0NzA0MQ==","diff_hunk":"@@ -50,6 +53,13 @@ in {\n       default = false;\n       description = \"Enable if there is a TLS terminating proxy in front of nextcloud.\";\n     };\n+    openFirewall = mkOption {\n+      type = types.bool;\n+      default = true;","path":"nixos/modules/services/web-apps/nextcloud.nix","position":18,"original_position":18,"commit_id":"bc11a5dc24317df37d55b779d49145a82303743a","original_commit_id":"bc11a5dc24317df37d55b779d49145a82303743a","user":{"login":"teto","id":886074,"node_id":"MDQ6VXNlcjg4NjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"body":"Oh my bad I definitely wanted to set it to false but forgot.","created_at":"2018-11-12T06:40:38Z","updated_at":"2018-11-12T06:40:38Z","html_url":"https://github.com/NixOS/nixpkgs/pull/50256#discussion_r232547041","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50256","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/232547041"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/50256#discussion_r232547041"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50256"}},"in_reply_to_id":232544352},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50256","id":230025097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDI1MDk3","html_url":"https://github.com/NixOS/nixpkgs/pull/50256","diff_url":"https://github.com/NixOS/nixpkgs/pull/50256.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/50256.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50256","number":50256,"state":"open","locked":false,"title":"Nextcloud: add openFirewall setting","user":{"login":"teto","id":886074,"node_id":"MDQ6VXNlcjg4NjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nadding openFirewall setting as is done for sshd so that the firewall ports get coupled with nextcloud (they get removed along with nextcloud => more secure).\r\nhttps://github.com/NixOS/nixpkgs/issues/48881\r\n\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-11-12T05:53:31Z","updated_at":"2018-11-12T06:40:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41bcdc3c25d4fab15a5da73edcb9ec547e9df6bf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Infinisil","id":20525370,"node_id":"MDQ6VXNlcjIwNTI1Mzcw","avatar_url":"https://avatars0.githubusercontent.com/u/20525370?v=4","gravatar_id":"","url":"https://api.github.com/users/Infinisil","html_url":"https://github.com/Infinisil","followers_url":"https://api.github.com/users/Infinisil/followers","following_url":"https://api.github.com/users/Infinisil/following{/other_user}","gists_url":"https://api.github.com/users/Infinisil/gists{/gist_id}","starred_url":"https://api.github.com/users/Infinisil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Infinisil/subscriptions","organizations_url":"https://api.github.com/users/Infinisil/orgs","repos_url":"https://api.github.com/users/Infinisil/repos","events_url":"https://api.github.com/users/Infinisil/events{/privacy}","received_events_url":"https://api.github.com/users/Infinisil/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50256/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50256/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50256/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/bc11a5dc24317df37d55b779d49145a82303743a","head":{"label":"teto:nextcloud","ref":"nextcloud","sha":"bc11a5dc24317df37d55b779d49145a82303743a","user":{"login":"teto","id":886074,"node_id":"MDQ6VXNlcjg4NjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"repo":{"id":61347607,"node_id":"MDEwOlJlcG9zaXRvcnk2MTM0NzYwNw==","name":"nixpkgs","full_name":"teto/nixpkgs","private":false,"owner":{"login":"teto","id":886074,"node_id":"MDQ6VXNlcjg4NjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/teto/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/teto/nixpkgs","forks_url":"https://api.github.com/repos/teto/nixpkgs/forks","keys_url":"https://api.github.com/repos/teto/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teto/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teto/nixpkgs/teams","hooks_url":"https://api.github.com/repos/teto/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/teto/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/teto/nixpkgs/events","assignees_url":"https://api.github.com/repos/teto/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/teto/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/teto/nixpkgs/tags","blobs_url":"https://api.github.com/repos/teto/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teto/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teto/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/teto/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teto/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/teto/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/teto/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/teto/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/teto/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/teto/nixpkgs/subscription","commits_url":"https://api.github.com/repos/teto/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/teto/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/teto/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/teto/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/teto/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/teto/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teto/nixpkgs/merges","archive_url":"https://api.github.com/repos/teto/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teto/nixpkgs/downloads","issues_url":"https://api.github.com/repos/teto/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/teto/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/teto/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/teto/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teto/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/teto/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/teto/nixpkgs/deployments","created_at":"2016-06-17T05:22:26Z","updated_at":"2018-11-01T15:24:32Z","pushed_at":"2018-11-12T05:56:44Z","git_url":"git://github.com/teto/nixpkgs.git","ssh_url":"git@github.com:teto/nixpkgs.git","clone_url":"https://github.com/teto/nixpkgs.git","svn_url":"https://github.com/teto/nixpkgs","homepage":null,"size":765785,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"49df3150c71aee580c9a04c3482ad4b7d0552516","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-11-12T05:45:25Z","pushed_at":"2018-11-12T05:56:48Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":881904,"stargazers_count":2989,"watchers_count":2989,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3181,"mirror_url":null,"archived":false,"open_issues_count":3379,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3181,"open_issues":3379,"watchers":2989,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50256"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/50256"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/50256"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/50256/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50256/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50256/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/bc11a5dc24317df37d55b779d49145a82303743a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"teto"}}