{"action":"created","issue":{"url":"https://api.github.com/repos/scour-project/scour/issues/167","repository_url":"https://api.github.com/repos/scour-project/scour","labels_url":"https://api.github.com/repos/scour-project/scour/issues/167/labels{/name}","comments_url":"https://api.github.com/repos/scour-project/scour/issues/167/comments","events_url":"https://api.github.com/repos/scour-project/scour/issues/167/events","html_url":"https://github.com/scour-project/scour/pull/167","id":297997759,"number":167,"title":"Optimize find referenced elements","user":{"login":"nthykier","id":429402,"avatar_url":"https://avatars3.githubusercontent.com/u/429402?v=4","gravatar_id":"","url":"https://api.github.com/users/nthykier","html_url":"https://github.com/nthykier","followers_url":"https://api.github.com/users/nthykier/followers","following_url":"https://api.github.com/users/nthykier/following{/other_user}","gists_url":"https://api.github.com/users/nthykier/gists{/gist_id}","starred_url":"https://api.github.com/users/nthykier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nthykier/subscriptions","organizations_url":"https://api.github.com/users/nthykier/orgs","repos_url":"https://api.github.com/users/nthykier/repos","events_url":"https://api.github.com/users/nthykier/events{/privacy}","received_events_url":"https://api.github.com/users/nthykier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-17T11:22:42Z","updated_at":"2018-02-17T13:11:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scour-project/scour/pulls/167","html_url":"https://github.com/scour-project/scour/pull/167","diff_url":"https://github.com/scour-project/scour/pull/167.diff","patch_url":"https://github.com/scour-project/scour/pull/167.patch"},"body":"The biggest win (at least in my test case) is the \"findReferencedElements: Handle referencingProps separately\", which avoids a large number of unnecessary string operations.\r\n\r\nBut there is also a large potential in \"Avoid recomputing findReferencedElements in removeUnusedDefs\" for any SVG that need a number of calls to \"removeUnreferencedElements\" or where \"removeUnusedDefs\" recurses a lot of times.  My particular test case does not seem to trigger any of that though (with a total of one call to removeUnreferencedElements)"},"comment":{"url":"https://api.github.com/repos/scour-project/scour/issues/comments/366440585","html_url":"https://github.com/scour-project/scour/pull/167#issuecomment-366440585","issue_url":"https://api.github.com/repos/scour-project/scour/issues/167","id":366440585,"user":{"login":"Ede123","id":904570,"avatar_url":"https://avatars0.githubusercontent.com/u/904570?v=4","gravatar_id":"","url":"https://api.github.com/users/Ede123","html_url":"https://github.com/Ede123","followers_url":"https://api.github.com/users/Ede123/followers","following_url":"https://api.github.com/users/Ede123/following{/other_user}","gists_url":"https://api.github.com/users/Ede123/gists{/gist_id}","starred_url":"https://api.github.com/users/Ede123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ede123/subscriptions","organizations_url":"https://api.github.com/users/Ede123/orgs","repos_url":"https://api.github.com/users/Ede123/repos","events_url":"https://api.github.com/users/Ede123/events{/privacy}","received_events_url":"https://api.github.com/users/Ede123/received_events","type":"User","site_admin":false},"created_at":"2018-02-17T13:11:40Z","updated_at":"2018-02-17T13:11:40Z","author_association":"OWNER","body":"Perfect! 6% speedup also confirmed in a class of files I'm currently working with."}}
{"actor":{"display_login":"Ede123"}}