{"action":"created","comment":{"url":"https://api.github.com/repos/CanonicalLtd/candid/pulls/comments/185761458","pull_request_review_id":117214348,"id":185761458,"diff_hunk":"@@ -96,7 +84,6 @@ func (c *thirdPartyCaveatChecker) checkThirdPartyCaveat(ctx context.Context, p h\n \tdefault:\n \t\treturn nil, checkers.ErrCaveatNotRecognized\n \t}\n-\tinteractionRequiredParams.domain = domain\n \t// TODO add discharge id to context","path":"internal/discharger/discharge.go","position":33,"original_position":33,"commit_id":"4f09e944a084f486fe3bdcfbf4d341d2a89a0c9f","original_commit_id":"4f09e944a084f486fe3bdcfbf4d341d2a89a0c9f","user":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars3.githubusercontent.com/u/1136018?v=4","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"body":"Is this TODO still relevant?","created_at":"2018-05-03T10:58:04Z","updated_at":"2018-05-03T11:03:31Z","html_url":"https://github.com/CanonicalLtd/candid/pull/25#discussion_r185761458","pull_request_url":"https://api.github.com/repos/CanonicalLtd/candid/pulls/25","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/CanonicalLtd/candid/pulls/comments/185761458"},"html":{"href":"https://github.com/CanonicalLtd/candid/pull/25#discussion_r185761458"},"pull_request":{"href":"https://api.github.com/repos/CanonicalLtd/candid/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/CanonicalLtd/candid/pulls/25","id":185680238,"html_url":"https://github.com/CanonicalLtd/candid/pull/25","diff_url":"https://github.com/CanonicalLtd/candid/pull/25.diff","patch_url":"https://github.com/CanonicalLtd/candid/pull/25.patch","issue_url":"https://api.github.com/repos/CanonicalLtd/candid/issues/25","number":25,"state":"open","locked":false,"title":"internal/discharger: use random discharge ids","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars0.githubusercontent.com/u/66491?v=4","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"body":"Previously, if two clients attempted to discharge\r\na macaroon with the same third party caveat id at the\r\nsame time, one of the attempts would fail because\r\ndischarge ids were deterministically determined from\r\nthe caveat id.\r\n\r\nSince we no longer tie discharge tokens to a particular\r\ndischarge, we no longer need to know the discharge id\r\nin advance, so we remove the for-discharge caveat and\r\nmake the discharge id random for every new discharge\r\nrequest.","created_at":"2018-05-03T10:56:43Z","updated_at":"2018-05-03T11:03:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0492d2e19790e5be05e0686d9fe3c6226c32a06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanonicalLtd/candid/pulls/25/commits","review_comments_url":"https://api.github.com/repos/CanonicalLtd/candid/pulls/25/comments","review_comment_url":"https://api.github.com/repos/CanonicalLtd/candid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanonicalLtd/candid/issues/25/comments","statuses_url":"https://api.github.com/repos/CanonicalLtd/candid/statuses/4f09e944a084f486fe3bdcfbf4d341d2a89a0c9f","head":{"label":"rogpeppe:142-random-discharge-ids","ref":"142-random-discharge-ids","sha":"4f09e944a084f486fe3bdcfbf4d341d2a89a0c9f","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars0.githubusercontent.com/u/66491?v=4","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"repo":{"id":128244714,"name":"candid","full_name":"rogpeppe/candid","owner":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars0.githubusercontent.com/u/66491?v=4","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rogpeppe/candid","description":"Identity manager service","fork":true,"url":"https://api.github.com/repos/rogpeppe/candid","forks_url":"https://api.github.com/repos/rogpeppe/candid/forks","keys_url":"https://api.github.com/repos/rogpeppe/candid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rogpeppe/candid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rogpeppe/candid/teams","hooks_url":"https://api.github.com/repos/rogpeppe/candid/hooks","issue_events_url":"https://api.github.com/repos/rogpeppe/candid/issues/events{/number}","events_url":"https://api.github.com/repos/rogpeppe/candid/events","assignees_url":"https://api.github.com/repos/rogpeppe/candid/assignees{/user}","branches_url":"https://api.github.com/repos/rogpeppe/candid/branches{/branch}","tags_url":"https://api.github.com/repos/rogpeppe/candid/tags","blobs_url":"https://api.github.com/repos/rogpeppe/candid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rogpeppe/candid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rogpeppe/candid/git/refs{/sha}","trees_url":"https://api.github.com/repos/rogpeppe/candid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rogpeppe/candid/statuses/{sha}","languages_url":"https://api.github.com/repos/rogpeppe/candid/languages","stargazers_url":"https://api.github.com/repos/rogpeppe/candid/stargazers","contributors_url":"https://api.github.com/repos/rogpeppe/candid/contributors","subscribers_url":"https://api.github.com/repos/rogpeppe/candid/subscribers","subscription_url":"https://api.github.com/repos/rogpeppe/candid/subscription","commits_url":"https://api.github.com/repos/rogpeppe/candid/commits{/sha}","git_commits_url":"https://api.github.com/repos/rogpeppe/candid/git/commits{/sha}","comments_url":"https://api.github.com/repos/rogpeppe/candid/comments{/number}","issue_comment_url":"https://api.github.com/repos/rogpeppe/candid/issues/comments{/number}","contents_url":"https://api.github.com/repos/rogpeppe/candid/contents/{+path}","compare_url":"https://api.github.com/repos/rogpeppe/candid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rogpeppe/candid/merges","archive_url":"https://api.github.com/repos/rogpeppe/candid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rogpeppe/candid/downloads","issues_url":"https://api.github.com/repos/rogpeppe/candid/issues{/number}","pulls_url":"https://api.github.com/repos/rogpeppe/candid/pulls{/number}","milestones_url":"https://api.github.com/repos/rogpeppe/candid/milestones{/number}","notifications_url":"https://api.github.com/repos/rogpeppe/candid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rogpeppe/candid/labels{/name}","releases_url":"https://api.github.com/repos/rogpeppe/candid/releases{/id}","deployments_url":"https://api.github.com/repos/rogpeppe/candid/deployments","created_at":"2018-04-05T18:02:44Z","updated_at":"2018-04-05T18:02:47Z","pushed_at":"2018-05-03T10:56:02Z","git_url":"git://github.com/rogpeppe/candid.git","ssh_url":"git@github.com:rogpeppe/candid.git","clone_url":"https://github.com/rogpeppe/candid.git","svn_url":"https://github.com/rogpeppe/candid","homepage":null,"size":1050,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CanonicalLtd:master","ref":"master","sha":"266a2bf973d245f535404e0e05bd6f121ea45a44","user":{"login":"CanonicalLtd","id":7490288,"avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":128048586,"name":"candid","full_name":"CanonicalLtd/candid","owner":{"login":"CanonicalLtd","id":7490288,"avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanonicalLtd/candid","description":"Identity manager service","fork":false,"url":"https://api.github.com/repos/CanonicalLtd/candid","forks_url":"https://api.github.com/repos/CanonicalLtd/candid/forks","keys_url":"https://api.github.com/repos/CanonicalLtd/candid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanonicalLtd/candid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanonicalLtd/candid/teams","hooks_url":"https://api.github.com/repos/CanonicalLtd/candid/hooks","issue_events_url":"https://api.github.com/repos/CanonicalLtd/candid/issues/events{/number}","events_url":"https://api.github.com/repos/CanonicalLtd/candid/events","assignees_url":"https://api.github.com/repos/CanonicalLtd/candid/assignees{/user}","branches_url":"https://api.github.com/repos/CanonicalLtd/candid/branches{/branch}","tags_url":"https://api.github.com/repos/CanonicalLtd/candid/tags","blobs_url":"https://api.github.com/repos/CanonicalLtd/candid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanonicalLtd/candid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanonicalLtd/candid/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanonicalLtd/candid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanonicalLtd/candid/statuses/{sha}","languages_url":"https://api.github.com/repos/CanonicalLtd/candid/languages","stargazers_url":"https://api.github.com/repos/CanonicalLtd/candid/stargazers","contributors_url":"https://api.github.com/repos/CanonicalLtd/candid/contributors","subscribers_url":"https://api.github.com/repos/CanonicalLtd/candid/subscribers","subscription_url":"https://api.github.com/repos/CanonicalLtd/candid/subscription","commits_url":"https://api.github.com/repos/CanonicalLtd/candid/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanonicalLtd/candid/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanonicalLtd/candid/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanonicalLtd/candid/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanonicalLtd/candid/contents/{+path}","compare_url":"https://api.github.com/repos/CanonicalLtd/candid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanonicalLtd/candid/merges","archive_url":"https://api.github.com/repos/CanonicalLtd/candid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanonicalLtd/candid/downloads","issues_url":"https://api.github.com/repos/CanonicalLtd/candid/issues{/number}","pulls_url":"https://api.github.com/repos/CanonicalLtd/candid/pulls{/number}","milestones_url":"https://api.github.com/repos/CanonicalLtd/candid/milestones{/number}","notifications_url":"https://api.github.com/repos/CanonicalLtd/candid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanonicalLtd/candid/labels{/name}","releases_url":"https://api.github.com/repos/CanonicalLtd/candid/releases{/id}","deployments_url":"https://api.github.com/repos/CanonicalLtd/candid/deployments","created_at":"2018-04-04T10:47:41Z","updated_at":"2018-05-01T09:41:46Z","pushed_at":"2018-05-03T11:00:53Z","git_url":"git://github.com/CanonicalLtd/candid.git","ssh_url":"git@github.com:CanonicalLtd/candid.git","clone_url":"https://github.com/CanonicalLtd/candid.git","svn_url":"https://github.com/CanonicalLtd/candid","homepage":null,"size":1064,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":4,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CanonicalLtd/candid/pulls/25"},"html":{"href":"https://github.com/CanonicalLtd/candid/pull/25"},"issue":{"href":"https://api.github.com/repos/CanonicalLtd/candid/issues/25"},"comments":{"href":"https://api.github.com/repos/CanonicalLtd/candid/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/CanonicalLtd/candid/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/CanonicalLtd/candid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanonicalLtd/candid/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/CanonicalLtd/candid/statuses/4f09e944a084f486fe3bdcfbf4d341d2a89a0c9f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mhilton"}}