{"action":"created","comment":{"url":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/comments/175108476","pull_request_review_id":104588407,"id":175108476,"diff_hunk":"@@ -1,2 +1,65 @@\n-# ti.admob\n-Admob implementation with Axway Hyperloop \n+# Ti.Admob\n+Right now this module is Android only, and only supports Interstitial Ads\n+\n+## Run the Sample\n+\n+1. Copy the `ti-admob` folder to your `lib/` (Alloy) or your Resources (Classic) directory.\n+2. Copy the example code to your Titanium app (in case of a Classic app adjust the code to fit your needs).\n+3. Include `hyperloop` and `ti.playservices` modules in your tiapp.xml.\n+4. Adjust `tiapp.xml` to support the ad type as explained below.\n+5. Make sure you have `<transpile>true</transpile>` added in tiapp to support ES6.\n+5. Go for it!\n+\n+## tiapp.xml adjustments required\n+You need to add a manifest to your app with an extra activity to support Interstitial ads. It should look like this:\n+```xml\n+<android xmlns:android=\"http://schemas.android.com/apk/res/android\">\n+    <manifest android:installLocation=\"auto\" android:versionCode=\"1\"\n+        android:versionName=\"1.0\" xmlns:android=\"http://schemas.android.com/apk/res/android\">\n+        <application>\n+            <meta-data android:name=\"com.google.android.gms.version\" android:value=\"@integer/google_play_services_version\"/>\n+            <activity\n+            android:configChanges=\"keyboard|keyboardHidden|orientation|screenLayout|uiMode|screenSize|smallestScreenSize\" android:name=\"com.google.android.gms.ads.AdActivity\"/>\n+        </application>\n+        <uses-permission android:name=\"android.permission.INTERNET\"/>\n+        <uses-permission android:name=\"android.permission.ACCESS_NETWORK_STATE\"/>\n+        <uses-permission android:name=\"android.permission.WRITE_EXTERNAL_STORAGE\"/>\n+    </manifest>\n+</android>\n+```\n+\n+## Example\n+Right here we're creating a new ad using the Google Default app/add id's. As soon as the onAdLoaded event is fired you can show the ad using `ad.show();`\n+Check the sample how it's implemented.\n+\n+```javascript\n+import {ADTYPES, AdView} from 'ti-admob';\n+\n+let appAd = new AdView({\n+    adType: ADTYPES.AD_TYPE_INTERSTITIAL,\n+    appId: 'ca-app-pub-3940256099942544~3347511713',\n+    adId: 'ca-app-pub-3940256099942544/1033173712',\n+    onAdLoaded : () => {\n+        alert('ad loaded!');\n+    },\n+    onAdClosed: () => {\n+        setTimeout(() => {\n+            appAd.load();\n+        },2500);\n+    }\n+});\n+\n+let ad = appAd.ad;","path":"README.md","position":54,"original_position":54,"commit_id":"91571a2858eb83b2ecb60e75c420c887a5c76762","original_commit_id":"91571a2858eb83b2ecb60e75c420c887a5c76762","user":{"login":"hansemannn","id":10667698,"avatar_url":"https://avatars0.githubusercontent.com/u/10667698?v=4","gravatar_id":"","url":"https://api.github.com/users/hansemannn","html_url":"https://github.com/hansemannn","followers_url":"https://api.github.com/users/hansemannn/followers","following_url":"https://api.github.com/users/hansemannn/following{/other_user}","gists_url":"https://api.github.com/users/hansemannn/gists{/gist_id}","starred_url":"https://api.github.com/users/hansemannn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansemannn/subscriptions","organizations_url":"https://api.github.com/users/hansemannn/orgs","repos_url":"https://api.github.com/users/hansemannn/repos","events_url":"https://api.github.com/users/hansemannn/events{/privacy}","received_events_url":"https://api.github.com/users/hansemannn/received_events","type":"User","site_admin":false},"body":"const const const","created_at":"2018-03-16T14:34:16Z","updated_at":"2018-03-16T14:36:55Z","html_url":"https://github.com/hyperloop-modules/ti.admob/pull/1#discussion_r175108476","pull_request_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/comments/175108476"},"html":{"href":"https://github.com/hyperloop-modules/ti.admob/pull/1#discussion_r175108476"},"pull_request":{"href":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/1","id":174959778,"html_url":"https://github.com/hyperloop-modules/ti.admob/pull/1","diff_url":"https://github.com/hyperloop-modules/ti.admob/pull/1.diff","patch_url":"https://github.com/hyperloop-modules/ti.admob/pull/1.patch","issue_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/issues/1","number":1,"state":"open","locked":false,"title":"Android: Support Interstitial ads","user":{"login":"Topener","id":1898949,"avatar_url":"https://avatars1.githubusercontent.com/u/1898949?v=4","gravatar_id":"","url":"https://api.github.com/users/Topener","html_url":"https://github.com/Topener","followers_url":"https://api.github.com/users/Topener/followers","following_url":"https://api.github.com/users/Topener/following{/other_user}","gists_url":"https://api.github.com/users/Topener/gists{/gist_id}","starred_url":"https://api.github.com/users/Topener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Topener/subscriptions","organizations_url":"https://api.github.com/users/Topener/orgs","repos_url":"https://api.github.com/users/Topener/repos","events_url":"https://api.github.com/users/Topener/events{/privacy}","received_events_url":"https://api.github.com/users/Topener/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-14T13:46:33Z","updated_at":"2018-03-16T14:36:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"202f5fa4fab0d839c9116ebb29617c8da2d4bc5f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/1/commits","review_comments_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/1/comments","review_comment_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/issues/1/comments","statuses_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/statuses/91571a2858eb83b2ecb60e75c420c887a5c76762","head":{"label":"hyperloop-modules:develop","ref":"develop","sha":"91571a2858eb83b2ecb60e75c420c887a5c76762","user":{"login":"hyperloop-modules","id":22434687,"avatar_url":"https://avatars0.githubusercontent.com/u/22434687?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperloop-modules","html_url":"https://github.com/hyperloop-modules","followers_url":"https://api.github.com/users/hyperloop-modules/followers","following_url":"https://api.github.com/users/hyperloop-modules/following{/other_user}","gists_url":"https://api.github.com/users/hyperloop-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperloop-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperloop-modules/subscriptions","organizations_url":"https://api.github.com/users/hyperloop-modules/orgs","repos_url":"https://api.github.com/users/hyperloop-modules/repos","events_url":"https://api.github.com/users/hyperloop-modules/events{/privacy}","received_events_url":"https://api.github.com/users/hyperloop-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":125124018,"name":"ti.admob","full_name":"hyperloop-modules/ti.admob","owner":{"login":"hyperloop-modules","id":22434687,"avatar_url":"https://avatars0.githubusercontent.com/u/22434687?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperloop-modules","html_url":"https://github.com/hyperloop-modules","followers_url":"https://api.github.com/users/hyperloop-modules/followers","following_url":"https://api.github.com/users/hyperloop-modules/following{/other_user}","gists_url":"https://api.github.com/users/hyperloop-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperloop-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperloop-modules/subscriptions","organizations_url":"https://api.github.com/users/hyperloop-modules/orgs","repos_url":"https://api.github.com/users/hyperloop-modules/repos","events_url":"https://api.github.com/users/hyperloop-modules/events{/privacy}","received_events_url":"https://api.github.com/users/hyperloop-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperloop-modules/ti.admob","description":"Admob implementation with Axway Hyperloop ","fork":false,"url":"https://api.github.com/repos/hyperloop-modules/ti.admob","forks_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/forks","keys_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/teams","hooks_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/hooks","issue_events_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/issues/events{/number}","events_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/events","assignees_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/assignees{/user}","branches_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/branches{/branch}","tags_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/tags","blobs_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/languages","stargazers_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/stargazers","contributors_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/contributors","subscribers_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/subscribers","subscription_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/subscription","commits_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/contents/{+path}","compare_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/merges","archive_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/downloads","issues_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/issues{/number}","pulls_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/labels{/name}","releases_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/releases{/id}","deployments_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/deployments","created_at":"2018-03-13T22:43:47Z","updated_at":"2018-03-15T09:26:59Z","pushed_at":"2018-03-16T14:26:28Z","git_url":"git://github.com/hyperloop-modules/ti.admob.git","ssh_url":"git@github.com:hyperloop-modules/ti.admob.git","clone_url":"https://github.com/hyperloop-modules/ti.admob.git","svn_url":"https://github.com/hyperloop-modules/ti.admob","homepage":null,"size":6,"stargazers_count":4,"watchers_count":4,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"hyperloop-modules:master","ref":"master","sha":"42d21e5fc3a9c8e5a46e8a3e8857d0084d58ded1","user":{"login":"hyperloop-modules","id":22434687,"avatar_url":"https://avatars0.githubusercontent.com/u/22434687?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperloop-modules","html_url":"https://github.com/hyperloop-modules","followers_url":"https://api.github.com/users/hyperloop-modules/followers","following_url":"https://api.github.com/users/hyperloop-modules/following{/other_user}","gists_url":"https://api.github.com/users/hyperloop-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperloop-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperloop-modules/subscriptions","organizations_url":"https://api.github.com/users/hyperloop-modules/orgs","repos_url":"https://api.github.com/users/hyperloop-modules/repos","events_url":"https://api.github.com/users/hyperloop-modules/events{/privacy}","received_events_url":"https://api.github.com/users/hyperloop-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":125124018,"name":"ti.admob","full_name":"hyperloop-modules/ti.admob","owner":{"login":"hyperloop-modules","id":22434687,"avatar_url":"https://avatars0.githubusercontent.com/u/22434687?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperloop-modules","html_url":"https://github.com/hyperloop-modules","followers_url":"https://api.github.com/users/hyperloop-modules/followers","following_url":"https://api.github.com/users/hyperloop-modules/following{/other_user}","gists_url":"https://api.github.com/users/hyperloop-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperloop-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperloop-modules/subscriptions","organizations_url":"https://api.github.com/users/hyperloop-modules/orgs","repos_url":"https://api.github.com/users/hyperloop-modules/repos","events_url":"https://api.github.com/users/hyperloop-modules/events{/privacy}","received_events_url":"https://api.github.com/users/hyperloop-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperloop-modules/ti.admob","description":"Admob implementation with Axway Hyperloop ","fork":false,"url":"https://api.github.com/repos/hyperloop-modules/ti.admob","forks_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/forks","keys_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/teams","hooks_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/hooks","issue_events_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/issues/events{/number}","events_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/events","assignees_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/assignees{/user}","branches_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/branches{/branch}","tags_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/tags","blobs_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/languages","stargazers_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/stargazers","contributors_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/contributors","subscribers_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/subscribers","subscription_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/subscription","commits_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/contents/{+path}","compare_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/merges","archive_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/downloads","issues_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/issues{/number}","pulls_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/labels{/name}","releases_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/releases{/id}","deployments_url":"https://api.github.com/repos/hyperloop-modules/ti.admob/deployments","created_at":"2018-03-13T22:43:47Z","updated_at":"2018-03-15T09:26:59Z","pushed_at":"2018-03-16T14:26:28Z","git_url":"git://github.com/hyperloop-modules/ti.admob.git","ssh_url":"git@github.com:hyperloop-modules/ti.admob.git","clone_url":"https://github.com/hyperloop-modules/ti.admob.git","svn_url":"https://github.com/hyperloop-modules/ti.admob","homepage":null,"size":6,"stargazers_count":4,"watchers_count":4,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/1"},"html":{"href":"https://github.com/hyperloop-modules/ti.admob/pull/1"},"issue":{"href":"https://api.github.com/repos/hyperloop-modules/ti.admob/issues/1"},"comments":{"href":"https://api.github.com/repos/hyperloop-modules/ti.admob/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperloop-modules/ti.admob/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/hyperloop-modules/ti.admob/statuses/91571a2858eb83b2ecb60e75c420c887a5c76762"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"hansemannn"}}