{"action":"created","issue":{"url":"https://api.github.com/repos/dotansimha/graphql-code-generator/issues/561","repository_url":"https://api.github.com/repos/dotansimha/graphql-code-generator","labels_url":"https://api.github.com/repos/dotansimha/graphql-code-generator/issues/561/labels{/name}","comments_url":"https://api.github.com/repos/dotansimha/graphql-code-generator/issues/561/comments","events_url":"https://api.github.com/repos/dotansimha/graphql-code-generator/issues/561/events","html_url":"https://github.com/dotansimha/graphql-code-generator/pull/561","id":356267787,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTg0MTEw","number":561,"title":"Client Schema","user":{"login":"kamilkisiela","id":8167190,"node_id":"MDQ6VXNlcjgxNjcxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/8167190?v=4","gravatar_id":"","url":"https://api.github.com/users/kamilkisiela","html_url":"https://github.com/kamilkisiela","followers_url":"https://api.github.com/users/kamilkisiela/followers","following_url":"https://api.github.com/users/kamilkisiela/following{/other_user}","gists_url":"https://api.github.com/users/kamilkisiela/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilkisiela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilkisiela/subscriptions","organizations_url":"https://api.github.com/users/kamilkisiela/orgs","repos_url":"https://api.github.com/users/kamilkisiela/repos","events_url":"https://api.github.com/users/kamilkisiela/events{/privacy}","received_events_url":"https://api.github.com/users/kamilkisiela/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-02T09:30:28Z","updated_at":"2018-09-03T19:29:49Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/dotansimha/graphql-code-generator/pulls/561","html_url":"https://github.com/dotansimha/graphql-code-generator/pull/561","diff_url":"https://github.com/dotansimha/graphql-code-generator/pull/561.diff","patch_url":"https://github.com/dotansimha/graphql-code-generator/pull/561.patch"},"body":"Three cases:\r\n\r\n1. user provides `--schema` - nothing changes\r\n1. user provides `--schema` `--clientSchema` - we merge both\r\n1. user provides  `--clientSchema` only - now we throw an error that there's no `--schema` (maybe we shouldn't?)\r\n\r\n@dotansimha @ardatan what do you think?"},"comment":{"url":"https://api.github.com/repos/dotansimha/graphql-code-generator/issues/comments/418181478","html_url":"https://github.com/dotansimha/graphql-code-generator/pull/561#issuecomment-418181478","issue_url":"https://api.github.com/repos/dotansimha/graphql-code-generator/issues/561","id":418181478,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODE4MTQ3OA==","user":{"login":"emmanuelbuah","id":432664,"node_id":"MDQ6VXNlcjQzMjY2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/432664?v=4","gravatar_id":"","url":"https://api.github.com/users/emmanuelbuah","html_url":"https://github.com/emmanuelbuah","followers_url":"https://api.github.com/users/emmanuelbuah/followers","following_url":"https://api.github.com/users/emmanuelbuah/following{/other_user}","gists_url":"https://api.github.com/users/emmanuelbuah/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanuelbuah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanuelbuah/subscriptions","organizations_url":"https://api.github.com/users/emmanuelbuah/orgs","repos_url":"https://api.github.com/users/emmanuelbuah/repos","events_url":"https://api.github.com/users/emmanuelbuah/events{/privacy}","received_events_url":"https://api.github.com/users/emmanuelbuah/received_events","type":"User","site_admin":false},"created_at":"2018-09-03T19:29:49Z","updated_at":"2018-09-03T19:29:49Z","author_association":"NONE","body":"@kamilkisiela Per my earlier comment, it think its missing the case where `--schema` is provided,  `--clientSchema` is not provided but they exact a query with `@client`. Currently, the type generator throughs an error. It should skip the generation of queries with `@client` directive if a graph query schema isn't present. "}}
{"actor":{"display_login":"emmanuelbuah"}}