{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1246","repository_url":"https://api.github.com/repos/ipfs/js-ipfs","labels_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1246/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1246/comments","events_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1246/events","html_url":"https://github.com/ipfs/js-ipfs/pull/1246","id":302160929,"number":1246,"title":"fix: init script sed in non existent file","user":{"login":"JGAntunes","id":5799039,"avatar_url":"https://avatars3.githubusercontent.com/u/5799039?v=4","gravatar_id":"","url":"https://api.github.com/users/JGAntunes","html_url":"https://github.com/JGAntunes","followers_url":"https://api.github.com/users/JGAntunes/followers","following_url":"https://api.github.com/users/JGAntunes/following{/other_user}","gists_url":"https://api.github.com/users/JGAntunes/gists{/gist_id}","starred_url":"https://api.github.com/users/JGAntunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGAntunes/subscriptions","organizations_url":"https://api.github.com/users/JGAntunes/orgs","repos_url":"https://api.github.com/users/JGAntunes/repos","events_url":"https://api.github.com/users/JGAntunes/events{/privacy}","received_events_url":"https://api.github.com/users/JGAntunes/received_events","type":"User","site_admin":false},"labels":[{"id":259619775,"url":"https://api.github.com/repos/ipfs/js-ipfs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"JGAntunes","id":5799039,"avatar_url":"https://avatars3.githubusercontent.com/u/5799039?v=4","gravatar_id":"","url":"https://api.github.com/users/JGAntunes","html_url":"https://github.com/JGAntunes","followers_url":"https://api.github.com/users/JGAntunes/followers","following_url":"https://api.github.com/users/JGAntunes/following{/other_user}","gists_url":"https://api.github.com/users/JGAntunes/gists{/gist_id}","starred_url":"https://api.github.com/users/JGAntunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGAntunes/subscriptions","organizations_url":"https://api.github.com/users/JGAntunes/orgs","repos_url":"https://api.github.com/users/JGAntunes/repos","events_url":"https://api.github.com/users/JGAntunes/events{/privacy}","received_events_url":"https://api.github.com/users/JGAntunes/received_events","type":"User","site_admin":false},"assignees":[{"login":"JGAntunes","id":5799039,"avatar_url":"https://avatars3.githubusercontent.com/u/5799039?v=4","gravatar_id":"","url":"https://api.github.com/users/JGAntunes","html_url":"https://github.com/JGAntunes","followers_url":"https://api.github.com/users/JGAntunes/followers","following_url":"https://api.github.com/users/JGAntunes/following{/other_user}","gists_url":"https://api.github.com/users/JGAntunes/gists{/gist_id}","starred_url":"https://api.github.com/users/JGAntunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGAntunes/subscriptions","organizations_url":"https://api.github.com/users/JGAntunes/orgs","repos_url":"https://api.github.com/users/JGAntunes/repos","events_url":"https://api.github.com/users/JGAntunes/events{/privacy}","received_events_url":"https://api.github.com/users/JGAntunes/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-03-05T03:30:09Z","updated_at":"2018-03-06T14:39:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1246","html_url":"https://github.com/ipfs/js-ipfs/pull/1246","diff_url":"https://github.com/ipfs/js-ipfs/pull/1246.diff","patch_url":"https://github.com/ipfs/js-ipfs/pull/1246.patch"},"body":"Running:\r\n```\r\n$ docker run -it -p 4002:4002 -p 4003:4003 -p 5002:5002 -p 9090:9090 ipfs/js-ipfs:latest\r\n```\r\n\r\nIs returning:\r\n```\r\nUsing /root/.jsipfs as IPFS repository\r\nsed: can't read /root/.jsipfs/config: No such file or directory\r\n```\r\n\r\nSeems like the `sed` command in the `init-and-daemon.sh` script is performed against a non existing file since the repo might not exist (which is the case in a brand new container without any volume attached).\r\n\r\nI went ahead and changed the order of the commands (it works like this). I assume that this was the intended behaviour, but might be missing some reason as to why this should be arranged in a different form. If anyone wants to test it out - https://hub.docker.com/r/jgantunes/js-ipfs/\r\n"},"comment":{"url":"https://api.github.com/repos/ipfs/js-ipfs/issues/comments/370802161","html_url":"https://github.com/ipfs/js-ipfs/pull/1246#issuecomment-370802161","issue_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1246","id":370802161,"user":{"login":"JGAntunes","id":5799039,"avatar_url":"https://avatars3.githubusercontent.com/u/5799039?v=4","gravatar_id":"","url":"https://api.github.com/users/JGAntunes","html_url":"https://github.com/JGAntunes","followers_url":"https://api.github.com/users/JGAntunes/followers","following_url":"https://api.github.com/users/JGAntunes/following{/other_user}","gists_url":"https://api.github.com/users/JGAntunes/gists{/gist_id}","starred_url":"https://api.github.com/users/JGAntunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGAntunes/subscriptions","organizations_url":"https://api.github.com/users/JGAntunes/orgs","repos_url":"https://api.github.com/users/JGAntunes/repos","events_url":"https://api.github.com/users/JGAntunes/events{/privacy}","received_events_url":"https://api.github.com/users/JGAntunes/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T14:39:56Z","updated_at":"2018-03-06T14:39:56Z","author_association":"MEMBER","body":"Hey @VictorBjelkholm @diasdavid !\r\n\r\nI don't mind changing this to use env vars honestly. Would the expected behaviour be the same as the ipfs-cluster example? When the env var exists we use it else we keep the config as it is and bind to the loopback interface? And the docker image sets a value by default to `0.0.0.0`?"}}
{"actor":{"display_login":"JGAntunes"}}