{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/168875828","pull_request_review_id":97323288,"id":168875828,"diff_hunk":"@@ -0,0 +1,217 @@\n+package aws\n+\n+import (\n+\t\"fmt\"\n+\t\"log\"\n+\t\"strings\"\n+\t\"time\"\n+\n+\t\"github.com/hashicorp/terraform/helper/resource\"\n+\t\"github.com/hashicorp/terraform/helper/schema\"\n+","path":"aws/resource_aws_s3_bucket_metric.go","position":11,"original_position":11,"commit_id":"1d9468a5b89d0080c4b784bc12071e1dc353183d","original_commit_id":"1d9468a5b89d0080c4b784bc12071e1dc353183d","user":{"login":"bflad","id":189114,"avatar_url":"https://avatars3.githubusercontent.com/u/189114?v=4","gravatar_id":"","url":"https://api.github.com/users/bflad","html_url":"https://github.com/bflad","followers_url":"https://api.github.com/users/bflad/followers","following_url":"https://api.github.com/users/bflad/following{/other_user}","gists_url":"https://api.github.com/users/bflad/gists{/gist_id}","starred_url":"https://api.github.com/users/bflad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bflad/subscriptions","organizations_url":"https://api.github.com/users/bflad/orgs","repos_url":"https://api.github.com/users/bflad/repos","events_url":"https://api.github.com/users/bflad/events{/privacy}","received_events_url":"https://api.github.com/users/bflad/received_events","type":"User","site_admin":false},"body":"👍  absolutely, thanks!","created_at":"2018-02-16T21:34:40Z","updated_at":"2018-02-16T21:34:40Z","html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/916#discussion_r168875828","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/916","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/168875828"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/916#discussion_r168875828"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/916"}},"in_reply_to_id":168789589},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/916","id":126446878,"html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/916","diff_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/916.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/916.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/916","number":916,"state":"open","locked":false,"title":"New Resource: aws_s3_bucket_metric","user":{"login":"bflad","id":189114,"avatar_url":"https://avatars3.githubusercontent.com/u/189114?v=4","gravatar_id":"","url":"https://api.github.com/users/bflad","html_url":"https://github.com/bflad","followers_url":"https://api.github.com/users/bflad/followers","following_url":"https://api.github.com/users/bflad/following{/other_user}","gists_url":"https://api.github.com/users/bflad/gists{/gist_id}","starred_url":"https://api.github.com/users/bflad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bflad/subscriptions","organizations_url":"https://api.github.com/users/bflad/orgs","repos_url":"https://api.github.com/users/bflad/repos","events_url":"https://api.github.com/users/bflad/events{/privacy}","received_events_url":"https://api.github.com/users/bflad/received_events","type":"User","site_admin":false},"body":"Ref: #6 \r\n\r\n```\r\nmake testacc TESTARGS='-run=TestAccAWSS3BucketMetric'\r\n==> Checking that code complies with gofmt requirements...\r\nTF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAWSS3BucketMetric -timeout 120m\r\n?       github.com/terraform-providers/terraform-provider-aws   [no test files]\r\n=== RUN   TestAccAWSS3BucketMetric_importBasic\r\n--- PASS: TestAccAWSS3BucketMetric_importBasic (70.02s)\r\n=== RUN   TestAccAWSS3BucketMetric_WithoutFilter\r\n--- PASS: TestAccAWSS3BucketMetric_WithoutFilter (33.98s)\r\n=== RUN   TestAccAWSS3BucketMetric_WithFilterPrefix\r\n--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefix (69.32s)\r\n=== RUN   TestAccAWSS3BucketMetric_WithFilterPrefixAndTag\r\n--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndTag (48.61s)\r\n=== RUN   TestAccAWSS3BucketMetric_WithFilterTagMultiple\r\n--- PASS: TestAccAWSS3BucketMetric_WithFilterTagMultiple (47.89s)\r\n=== RUN   TestAccAWSS3BucketMetric_WithFilterTagSingle\r\n--- PASS: TestAccAWSS3BucketMetric_WithFilterTagSingle (46.32s)\r\nPASS\r\nok      github.com/terraform-providers/terraform-provider-aws/aws   316.168s\r\n```","created_at":"2017-06-20T04:52:28Z","updated_at":"2018-02-16T21:34:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47381729681186cdc2169206368819b876a32934","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":625892945,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/new-resource","name":"new-resource","color":"d4c5f9","default":false},{"id":794044082,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/service/s3","name":"service/s3","color":"bfd4f2","default":false},{"id":737832191,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/size/XL","name":"size/XL","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/916/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/916/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/916/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/1d9468a5b89d0080c4b784bc12071e1dc353183d","head":{"label":"bflad:aws_s3_bucket_metrics","ref":"aws_s3_bucket_metrics","sha":"1d9468a5b89d0080c4b784bc12071e1dc353183d","user":{"login":"bflad","id":189114,"avatar_url":"https://avatars3.githubusercontent.com/u/189114?v=4","gravatar_id":"","url":"https://api.github.com/users/bflad","html_url":"https://github.com/bflad","followers_url":"https://api.github.com/users/bflad/followers","following_url":"https://api.github.com/users/bflad/following{/other_user}","gists_url":"https://api.github.com/users/bflad/gists{/gist_id}","starred_url":"https://api.github.com/users/bflad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bflad/subscriptions","organizations_url":"https://api.github.com/users/bflad/orgs","repos_url":"https://api.github.com/users/bflad/repos","events_url":"https://api.github.com/users/bflad/events{/privacy}","received_events_url":"https://api.github.com/users/bflad/received_events","type":"User","site_admin":false},"repo":{"id":93969205,"name":"terraform-provider-aws","full_name":"bflad/terraform-provider-aws","owner":{"login":"bflad","id":189114,"avatar_url":"https://avatars3.githubusercontent.com/u/189114?v=4","gravatar_id":"","url":"https://api.github.com/users/bflad","html_url":"https://github.com/bflad","followers_url":"https://api.github.com/users/bflad/followers","following_url":"https://api.github.com/users/bflad/following{/other_user}","gists_url":"https://api.github.com/users/bflad/gists{/gist_id}","starred_url":"https://api.github.com/users/bflad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bflad/subscriptions","organizations_url":"https://api.github.com/users/bflad/orgs","repos_url":"https://api.github.com/users/bflad/repos","events_url":"https://api.github.com/users/bflad/events{/privacy}","received_events_url":"https://api.github.com/users/bflad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bflad/terraform-provider-aws","description":"Terraform aws provider","fork":true,"url":"https://api.github.com/repos/bflad/terraform-provider-aws","forks_url":"https://api.github.com/repos/bflad/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/bflad/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bflad/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bflad/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/bflad/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/bflad/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/bflad/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/bflad/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/bflad/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/bflad/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/bflad/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bflad/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bflad/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/bflad/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bflad/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/bflad/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/bflad/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/bflad/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/bflad/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/bflad/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/bflad/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/bflad/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/bflad/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/bflad/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/bflad/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/bflad/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bflad/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/bflad/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bflad/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/bflad/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/bflad/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/bflad/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/bflad/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bflad/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/bflad/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/bflad/terraform-provider-aws/deployments","created_at":"2017-06-10T22:40:39Z","updated_at":"2017-06-10T22:40:44Z","pushed_at":"2018-01-27T04:55:20Z","git_url":"git://github.com/bflad/terraform-provider-aws.git","ssh_url":"git@github.com:bflad/terraform-provider-aws.git","clone_url":"https://github.com/bflad/terraform-provider-aws.git","svn_url":"https://github.com/bflad/terraform-provider-aws","homepage":"","size":25145,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"1507f6c0315a5b5c3090b3d30863edefc3236f39","user":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93444615,"name":"terraform-provider-aws","full_name":"terraform-providers/terraform-provider-aws","owner":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-aws","description":"Terraform AWS provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/deployments","created_at":"2017-06-05T20:37:52Z","updated_at":"2018-02-16T19:00:18Z","pushed_at":"2018-02-16T18:28:32Z","git_url":"git://github.com/terraform-providers/terraform-provider-aws.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-aws.git","clone_url":"https://github.com/terraform-providers/terraform-provider-aws.git","svn_url":"https://github.com/terraform-providers/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":29669,"stargazers_count":813,"watchers_count":813,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":737,"mirror_url":null,"archived":false,"open_issues_count":1664,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":737,"open_issues":1664,"watchers":813,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/916"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/916"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/916"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/916/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/916/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/916/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/1d9468a5b89d0080c4b784bc12071e1dc353183d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bflad"}}