{"action":"created","comment":{"url":"https://api.github.com/repos/bbc/simorgh/pulls/comments/209616504","pull_request_review_id":145662316,"id":209616504,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTYxNjUwNA==","diff_hunk":"@@ -1,3 +1,4 @@\n import fetch from 'jest-fetch-mock'; // eslint-disable-line import/no-extraneous-dependencies\n \n global.fetch = fetch;\n+process.env.RAZZLE_ASSETS_MANIFEST = 'manifest.json';","path":"src/app/helpers/tests/jest-setup.js","position":4,"original_position":4,"commit_id":"253058a55f5db4fbbef84d84db2bda9eeab77736","original_commit_id":"253058a55f5db4fbbef84d84db2bda9eeab77736","user":{"login":"sareh","id":3028997,"node_id":"MDQ6VXNlcjMwMjg5OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3028997?v=4","gravatar_id":"","url":"https://api.github.com/users/sareh","html_url":"https://github.com/sareh","followers_url":"https://api.github.com/users/sareh/followers","following_url":"https://api.github.com/users/sareh/following{/other_user}","gists_url":"https://api.github.com/users/sareh/gists{/gist_id}","starred_url":"https://api.github.com/users/sareh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sareh/subscriptions","organizations_url":"https://api.github.com/users/sareh/orgs","repos_url":"https://api.github.com/users/sareh/repos","events_url":"https://api.github.com/users/sareh/events{/privacy}","received_events_url":"https://api.github.com/users/sareh/received_events","type":"User","site_admin":false},"body":"OK, since we're using an arbitrary value here, I'd suggest calling it `'mockBundleAssets.json'` just to clarify that the tests aren't actually using the contents of `'manifest.json'`. ","created_at":"2018-08-13T13:52:25Z","updated_at":"2018-08-13T13:52:25Z","html_url":"https://github.com/bbc/simorgh/pull/470#discussion_r209616504","pull_request_url":"https://api.github.com/repos/bbc/simorgh/pulls/470","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/comments/209616504"},"html":{"href":"https://github.com/bbc/simorgh/pull/470#discussion_r209616504"},"pull_request":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/470"}},"in_reply_to_id":209576456},"pull_request":{"url":"https://api.github.com/repos/bbc/simorgh/pulls/470","id":207062072,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDYyMDcy","html_url":"https://github.com/bbc/simorgh/pull/470","diff_url":"https://github.com/bbc/simorgh/pull/470.diff","patch_url":"https://github.com/bbc/simorgh/pull/470.patch","issue_url":"https://api.github.com/repos/bbc/simorgh/issues/470","number":470,"state":"open","locked":false,"title":"Bundle splitting","user":{"login":"jtart","id":16549467,"node_id":"MDQ6VXNlcjE2NTQ5NDY3","avatar_url":"https://avatars1.githubusercontent.com/u/16549467?v=4","gravatar_id":"","url":"https://api.github.com/users/jtart","html_url":"https://github.com/jtart","followers_url":"https://api.github.com/users/jtart/followers","following_url":"https://api.github.com/users/jtart/following{/other_user}","gists_url":"https://api.github.com/users/jtart/gists{/gist_id}","starred_url":"https://api.github.com/users/jtart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtart/subscriptions","organizations_url":"https://api.github.com/users/jtart/orgs","repos_url":"https://api.github.com/users/jtart/repos","events_url":"https://api.github.com/users/jtart/events{/privacy}","received_events_url":"https://api.github.com/users/jtart/received_events","type":"User","site_admin":false},"body":"Resolves #466 \r\n\r\n_Adds Webpack config to split the client bundle by vendor and size. Also adds logic to map through the assets manifest and create a script for each script asset, not just a single client asset._\r\n\r\n* [x] Tests added for new features\r\n* [ ] Test engineer approval\r\n","created_at":"2018-08-08T16:14:35Z","updated_at":"2018-08-13T13:52:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97744656174bbe5e0e487f2191cdadc24447a437","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bbc/simorgh/pulls/470/commits","review_comments_url":"https://api.github.com/repos/bbc/simorgh/pulls/470/comments","review_comment_url":"https://api.github.com/repos/bbc/simorgh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbc/simorgh/issues/470/comments","statuses_url":"https://api.github.com/repos/bbc/simorgh/statuses/253058a55f5db4fbbef84d84db2bda9eeab77736","head":{"label":"bbc:bundle-splitting","ref":"bundle-splitting","sha":"253058a55f5db4fbbef84d84db2bda9eeab77736","user":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":133968906,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Njg5MDY=","name":"simorgh","full_name":"bbc/simorgh","owner":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bbc/simorgh","description":"The BBC's new article (soon... we hope)","fork":false,"url":"https://api.github.com/repos/bbc/simorgh","forks_url":"https://api.github.com/repos/bbc/simorgh/forks","keys_url":"https://api.github.com/repos/bbc/simorgh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/simorgh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/simorgh/teams","hooks_url":"https://api.github.com/repos/bbc/simorgh/hooks","issue_events_url":"https://api.github.com/repos/bbc/simorgh/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/simorgh/events","assignees_url":"https://api.github.com/repos/bbc/simorgh/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/simorgh/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/simorgh/tags","blobs_url":"https://api.github.com/repos/bbc/simorgh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/simorgh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/simorgh/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/simorgh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/simorgh/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/simorgh/languages","stargazers_url":"https://api.github.com/repos/bbc/simorgh/stargazers","contributors_url":"https://api.github.com/repos/bbc/simorgh/contributors","subscribers_url":"https://api.github.com/repos/bbc/simorgh/subscribers","subscription_url":"https://api.github.com/repos/bbc/simorgh/subscription","commits_url":"https://api.github.com/repos/bbc/simorgh/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/simorgh/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/simorgh/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/simorgh/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/simorgh/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/simorgh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/simorgh/merges","archive_url":"https://api.github.com/repos/bbc/simorgh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/simorgh/downloads","issues_url":"https://api.github.com/repos/bbc/simorgh/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/simorgh/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/simorgh/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/simorgh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/simorgh/labels{/name}","releases_url":"https://api.github.com/repos/bbc/simorgh/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/simorgh/deployments","created_at":"2018-05-18T14:59:42Z","updated_at":"2018-08-13T12:39:16Z","pushed_at":"2018-08-13T13:34:49Z","git_url":"git://github.com/bbc/simorgh.git","ssh_url":"git@github.com:bbc/simorgh.git","clone_url":"https://github.com/bbc/simorgh.git","svn_url":"https://github.com/bbc/simorgh","homepage":"https://www.bbc.com","size":37336,"stargazers_count":15,"watchers_count":15,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":85,"watchers":15,"default_branch":"latest"}},"base":{"label":"bbc:latest","ref":"latest","sha":"a8d65a32e1c50b73eba0b6e545b0cfd61f8db10d","user":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":133968906,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Njg5MDY=","name":"simorgh","full_name":"bbc/simorgh","owner":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bbc/simorgh","description":"The BBC's new article (soon... we hope)","fork":false,"url":"https://api.github.com/repos/bbc/simorgh","forks_url":"https://api.github.com/repos/bbc/simorgh/forks","keys_url":"https://api.github.com/repos/bbc/simorgh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/simorgh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/simorgh/teams","hooks_url":"https://api.github.com/repos/bbc/simorgh/hooks","issue_events_url":"https://api.github.com/repos/bbc/simorgh/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/simorgh/events","assignees_url":"https://api.github.com/repos/bbc/simorgh/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/simorgh/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/simorgh/tags","blobs_url":"https://api.github.com/repos/bbc/simorgh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/simorgh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/simorgh/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/simorgh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/simorgh/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/simorgh/languages","stargazers_url":"https://api.github.com/repos/bbc/simorgh/stargazers","contributors_url":"https://api.github.com/repos/bbc/simorgh/contributors","subscribers_url":"https://api.github.com/repos/bbc/simorgh/subscribers","subscription_url":"https://api.github.com/repos/bbc/simorgh/subscription","commits_url":"https://api.github.com/repos/bbc/simorgh/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/simorgh/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/simorgh/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/simorgh/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/simorgh/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/simorgh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/simorgh/merges","archive_url":"https://api.github.com/repos/bbc/simorgh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/simorgh/downloads","issues_url":"https://api.github.com/repos/bbc/simorgh/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/simorgh/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/simorgh/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/simorgh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/simorgh/labels{/name}","releases_url":"https://api.github.com/repos/bbc/simorgh/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/simorgh/deployments","created_at":"2018-05-18T14:59:42Z","updated_at":"2018-08-13T12:39:16Z","pushed_at":"2018-08-13T13:34:49Z","git_url":"git://github.com/bbc/simorgh.git","ssh_url":"git@github.com:bbc/simorgh.git","clone_url":"https://github.com/bbc/simorgh.git","svn_url":"https://github.com/bbc/simorgh","homepage":"https://www.bbc.com","size":37336,"stargazers_count":15,"watchers_count":15,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":85,"watchers":15,"default_branch":"latest"}},"_links":{"self":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/470"},"html":{"href":"https://github.com/bbc/simorgh/pull/470"},"issue":{"href":"https://api.github.com/repos/bbc/simorgh/issues/470"},"comments":{"href":"https://api.github.com/repos/bbc/simorgh/issues/470/comments"},"review_comments":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/470/comments"},"review_comment":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/470/commits"},"statuses":{"href":"https://api.github.com/repos/bbc/simorgh/statuses/253058a55f5db4fbbef84d84db2bda9eeab77736"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sareh"}}