{"action":"created","comment":{"url":"https://api.github.com/repos/SixTrack/SixTrack/pulls/comments/237470089","pull_request_review_id":179774010,"id":237470089,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzQ3MDA4OQ==","diff_hunk":"@@ -383,35 +381,41 @@ end subroutine elens_postInput\n !  - total beam energy [MeV]\n !  - outer radius [mm]\n ! ================================================================================================ !\n-real(kind=fPrec) function eLensTheta( len, Int, Ekin, Etot, r2 )\n+subroutine eLensTheta( j, Etot )\n \n   use floatPrecision\n   use mathlib_bouncer\n   use numerical_constants\n   use physical_constants\n   use crcoall\n   use mod_common\n+  use mod_hions, only : nucm0, zz0\n \n   implicit none\n \n-  real(kind=fPrec) gamma, beta_e, beta_b, brho, len, Int, Ekin, Etot, r2\n+  integer j\n+  real(kind=fPrec) gamma, beta_e, beta_b, brho, Etot\n \n-  gamma  = Ekin*c1m3/pmae+1 ! from kinetic energy\n+  gamma  = elens_Ek(j)*c1m3/pmae+one ! from kinetic energy\n   beta_e = sqrt((gamma+one)*(gamma-one))/(gamma)\n-  gamma  = Etot/pma ! from total energy\n+  gamma  = Etot/nucm0                ! from total energy\n   beta_b = sqrt((gamma+one)*(gamma-one))/(gamma)\n-  brho   = Etot/(clight*c1m6)\n+  brho   = Etot/(clight*c1m6)/zz0\n \n-  ! r2: from mm to m\n-  ! theta: from rad to mrad\n-  eLensTheta = len*abs(Int)/(2*pi*eps0*brho*clight**2*r2*c1m3)*c1e3\n-  if(Int < zero) then\n-    eLensTheta = eLensTheta*(one/(beta_e*beta_b)+one)\n+  ! r2: from mm to m (c1m3)\n+  ! theta: from rad to mrad (c1e3)\n+  elens_theta_r2(j) = elens_len(j)*abs(elens_I(j))/(two*pi*eps0*brho*clight**2*elens_r2(j)*c1m3)*c1e3","path":"source/elens.f90","position":174,"original_position":174,"commit_id":"2d39c9ee44ff0cbc21aabb83d9865ac4099cd860","original_commit_id":"2d39c9ee44ff0cbc21aabb83d9865ac4099cd860","user":{"login":"amereghe","id":14805184,"node_id":"MDQ6VXNlcjE0ODA1MTg0","avatar_url":"https://avatars0.githubusercontent.com/u/14805184?v=4","gravatar_id":"","url":"https://api.github.com/users/amereghe","html_url":"https://github.com/amereghe","followers_url":"https://api.github.com/users/amereghe/followers","following_url":"https://api.github.com/users/amereghe/following{/other_user}","gists_url":"https://api.github.com/users/amereghe/gists{/gist_id}","starred_url":"https://api.github.com/users/amereghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amereghe/subscriptions","organizations_url":"https://api.github.com/users/amereghe/orgs","repos_url":"https://api.github.com/users/amereghe/repos","events_url":"https://api.github.com/users/amereghe/events{/privacy}","received_events_url":"https://api.github.com/users/amereghe/received_events","type":"User","site_admin":false},"body":"done - I will anyway review the entire code of elenses to make sure that there are no other left-overs of this type","created_at":"2018-11-29T12:39:01Z","updated_at":"2018-11-29T12:39:01Z","html_url":"https://github.com/SixTrack/SixTrack/pull/702#discussion_r237470089","pull_request_url":"https://api.github.com/repos/SixTrack/SixTrack/pulls/702","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SixTrack/SixTrack/pulls/comments/237470089"},"html":{"href":"https://github.com/SixTrack/SixTrack/pull/702#discussion_r237470089"},"pull_request":{"href":"https://api.github.com/repos/SixTrack/SixTrack/pulls/702"}},"in_reply_to_id":235303127},"pull_request":{"url":"https://api.github.com/repos/SixTrack/SixTrack/pulls/702","id":231283181,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjgzMTgx","html_url":"https://github.com/SixTrack/SixTrack/pull/702","diff_url":"https://github.com/SixTrack/SixTrack/pull/702.diff","patch_url":"https://github.com/SixTrack/SixTrack/pull/702.patch","issue_url":"https://api.github.com/repos/SixTrack/SixTrack/issues/702","number":702,"state":"open","locked":false,"title":"E lenses with Gaussian electron beams","user":{"login":"amereghe","id":14805184,"node_id":"MDQ6VXNlcjE0ODA1MTg0","avatar_url":"https://avatars0.githubusercontent.com/u/14805184?v=4","gravatar_id":"","url":"https://api.github.com/users/amereghe","html_url":"https://github.com/amereghe","followers_url":"https://api.github.com/users/amereghe/followers","following_url":"https://api.github.com/users/amereghe/following{/other_user}","gists_url":"https://api.github.com/users/amereghe/gists{/gist_id}","starred_url":"https://api.github.com/users/amereghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amereghe/subscriptions","organizations_url":"https://api.github.com/users/amereghe/orgs","repos_url":"https://api.github.com/users/amereghe/repos","events_url":"https://api.github.com/users/amereghe/events{/privacy}","received_events_url":"https://api.github.com/users/amereghe/received_events","type":"User","site_admin":false},"body":"This PR re-enables Gaussian beams in e-lenses - still `R1=0` not permitted as we would need to change also the `FOX` part. Manuals (physics and user) updated consequently.\r\n\r\nelens tests updated, removing the turn by turn dumps from the canonicals; only the dump at one element at the last turn is actually checked.","created_at":"2018-11-15T17:54:41Z","updated_at":"2018-11-29T12:39:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ae70ac7aead4339a57f3a698f3f149e2bed6e2e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SixTrack/SixTrack/pulls/702/commits","review_comments_url":"https://api.github.com/repos/SixTrack/SixTrack/pulls/702/comments","review_comment_url":"https://api.github.com/repos/SixTrack/SixTrack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SixTrack/SixTrack/issues/702/comments","statuses_url":"https://api.github.com/repos/SixTrack/SixTrack/statuses/2d39c9ee44ff0cbc21aabb83d9865ac4099cd860","head":{"label":"amereghe:eLenses","ref":"eLenses","sha":"2d39c9ee44ff0cbc21aabb83d9865ac4099cd860","user":{"login":"amereghe","id":14805184,"node_id":"MDQ6VXNlcjE0ODA1MTg0","avatar_url":"https://avatars0.githubusercontent.com/u/14805184?v=4","gravatar_id":"","url":"https://api.github.com/users/amereghe","html_url":"https://github.com/amereghe","followers_url":"https://api.github.com/users/amereghe/followers","following_url":"https://api.github.com/users/amereghe/following{/other_user}","gists_url":"https://api.github.com/users/amereghe/gists{/gist_id}","starred_url":"https://api.github.com/users/amereghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amereghe/subscriptions","organizations_url":"https://api.github.com/users/amereghe/orgs","repos_url":"https://api.github.com/users/amereghe/repos","events_url":"https://api.github.com/users/amereghe/events{/privacy}","received_events_url":"https://api.github.com/users/amereghe/received_events","type":"User","site_admin":false},"repo":{"id":49884092,"node_id":"MDEwOlJlcG9zaXRvcnk0OTg4NDA5Mg==","name":"SixTrack","full_name":"amereghe/SixTrack","private":false,"owner":{"login":"amereghe","id":14805184,"node_id":"MDQ6VXNlcjE0ODA1MTg0","avatar_url":"https://avatars0.githubusercontent.com/u/14805184?v=4","gravatar_id":"","url":"https://api.github.com/users/amereghe","html_url":"https://github.com/amereghe","followers_url":"https://api.github.com/users/amereghe/followers","following_url":"https://api.github.com/users/amereghe/following{/other_user}","gists_url":"https://api.github.com/users/amereghe/gists{/gist_id}","starred_url":"https://api.github.com/users/amereghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amereghe/subscriptions","organizations_url":"https://api.github.com/users/amereghe/orgs","repos_url":"https://api.github.com/users/amereghe/repos","events_url":"https://api.github.com/users/amereghe/events{/privacy}","received_events_url":"https://api.github.com/users/amereghe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/amereghe/SixTrack","description":null,"fork":true,"url":"https://api.github.com/repos/amereghe/SixTrack","forks_url":"https://api.github.com/repos/amereghe/SixTrack/forks","keys_url":"https://api.github.com/repos/amereghe/SixTrack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amereghe/SixTrack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amereghe/SixTrack/teams","hooks_url":"https://api.github.com/repos/amereghe/SixTrack/hooks","issue_events_url":"https://api.github.com/repos/amereghe/SixTrack/issues/events{/number}","events_url":"https://api.github.com/repos/amereghe/SixTrack/events","assignees_url":"https://api.github.com/repos/amereghe/SixTrack/assignees{/user}","branches_url":"https://api.github.com/repos/amereghe/SixTrack/branches{/branch}","tags_url":"https://api.github.com/repos/amereghe/SixTrack/tags","blobs_url":"https://api.github.com/repos/amereghe/SixTrack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amereghe/SixTrack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amereghe/SixTrack/git/refs{/sha}","trees_url":"https://api.github.com/repos/amereghe/SixTrack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amereghe/SixTrack/statuses/{sha}","languages_url":"https://api.github.com/repos/amereghe/SixTrack/languages","stargazers_url":"https://api.github.com/repos/amereghe/SixTrack/stargazers","contributors_url":"https://api.github.com/repos/amereghe/SixTrack/contributors","subscribers_url":"https://api.github.com/repos/amereghe/SixTrack/subscribers","subscription_url":"https://api.github.com/repos/amereghe/SixTrack/subscription","commits_url":"https://api.github.com/repos/amereghe/SixTrack/commits{/sha}","git_commits_url":"https://api.github.com/repos/amereghe/SixTrack/git/commits{/sha}","comments_url":"https://api.github.com/repos/amereghe/SixTrack/comments{/number}","issue_comment_url":"https://api.github.com/repos/amereghe/SixTrack/issues/comments{/number}","contents_url":"https://api.github.com/repos/amereghe/SixTrack/contents/{+path}","compare_url":"https://api.github.com/repos/amereghe/SixTrack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amereghe/SixTrack/merges","archive_url":"https://api.github.com/repos/amereghe/SixTrack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amereghe/SixTrack/downloads","issues_url":"https://api.github.com/repos/amereghe/SixTrack/issues{/number}","pulls_url":"https://api.github.com/repos/amereghe/SixTrack/pulls{/number}","milestones_url":"https://api.github.com/repos/amereghe/SixTrack/milestones{/number}","notifications_url":"https://api.github.com/repos/amereghe/SixTrack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amereghe/SixTrack/labels{/name}","releases_url":"https://api.github.com/repos/amereghe/SixTrack/releases{/id}","deployments_url":"https://api.github.com/repos/amereghe/SixTrack/deployments","created_at":"2016-01-18T15:01:23Z","updated_at":"2018-11-29T12:26:23Z","pushed_at":"2018-11-29T12:26:13Z","git_url":"git://github.com/amereghe/SixTrack.git","ssh_url":"git@github.com:amereghe/SixTrack.git","clone_url":"https://github.com/amereghe/SixTrack.git","svn_url":"https://github.com/amereghe/SixTrack","homepage":null,"size":601359,"stargazers_count":0,"watchers_count":0,"language":"Fortran","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SixTrack:master","ref":"master","sha":"6fefb8129c0c2f0d511cb47371e2ad4f4eb72c2c","user":{"login":"SixTrack","id":7603461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDM0NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7603461?v=4","gravatar_id":"","url":"https://api.github.com/users/SixTrack","html_url":"https://github.com/SixTrack","followers_url":"https://api.github.com/users/SixTrack/followers","following_url":"https://api.github.com/users/SixTrack/following{/other_user}","gists_url":"https://api.github.com/users/SixTrack/gists{/gist_id}","starred_url":"https://api.github.com/users/SixTrack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SixTrack/subscriptions","organizations_url":"https://api.github.com/users/SixTrack/orgs","repos_url":"https://api.github.com/users/SixTrack/repos","events_url":"https://api.github.com/users/SixTrack/events{/privacy}","received_events_url":"https://api.github.com/users/SixTrack/received_events","type":"Organization","site_admin":false},"repo":{"id":41029431,"node_id":"MDEwOlJlcG9zaXRvcnk0MTAyOTQzMQ==","name":"SixTrack","full_name":"SixTrack/SixTrack","private":false,"owner":{"login":"SixTrack","id":7603461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDM0NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7603461?v=4","gravatar_id":"","url":"https://api.github.com/users/SixTrack","html_url":"https://github.com/SixTrack","followers_url":"https://api.github.com/users/SixTrack/followers","following_url":"https://api.github.com/users/SixTrack/following{/other_user}","gists_url":"https://api.github.com/users/SixTrack/gists{/gist_id}","starred_url":"https://api.github.com/users/SixTrack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SixTrack/subscriptions","organizations_url":"https://api.github.com/users/SixTrack/orgs","repos_url":"https://api.github.com/users/SixTrack/repos","events_url":"https://api.github.com/users/SixTrack/events{/privacy}","received_events_url":"https://api.github.com/users/SixTrack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SixTrack/SixTrack","description":null,"fork":false,"url":"https://api.github.com/repos/SixTrack/SixTrack","forks_url":"https://api.github.com/repos/SixTrack/SixTrack/forks","keys_url":"https://api.github.com/repos/SixTrack/SixTrack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SixTrack/SixTrack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SixTrack/SixTrack/teams","hooks_url":"https://api.github.com/repos/SixTrack/SixTrack/hooks","issue_events_url":"https://api.github.com/repos/SixTrack/SixTrack/issues/events{/number}","events_url":"https://api.github.com/repos/SixTrack/SixTrack/events","assignees_url":"https://api.github.com/repos/SixTrack/SixTrack/assignees{/user}","branches_url":"https://api.github.com/repos/SixTrack/SixTrack/branches{/branch}","tags_url":"https://api.github.com/repos/SixTrack/SixTrack/tags","blobs_url":"https://api.github.com/repos/SixTrack/SixTrack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SixTrack/SixTrack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SixTrack/SixTrack/git/refs{/sha}","trees_url":"https://api.github.com/repos/SixTrack/SixTrack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SixTrack/SixTrack/statuses/{sha}","languages_url":"https://api.github.com/repos/SixTrack/SixTrack/languages","stargazers_url":"https://api.github.com/repos/SixTrack/SixTrack/stargazers","contributors_url":"https://api.github.com/repos/SixTrack/SixTrack/contributors","subscribers_url":"https://api.github.com/repos/SixTrack/SixTrack/subscribers","subscription_url":"https://api.github.com/repos/SixTrack/SixTrack/subscription","commits_url":"https://api.github.com/repos/SixTrack/SixTrack/commits{/sha}","git_commits_url":"https://api.github.com/repos/SixTrack/SixTrack/git/commits{/sha}","comments_url":"https://api.github.com/repos/SixTrack/SixTrack/comments{/number}","issue_comment_url":"https://api.github.com/repos/SixTrack/SixTrack/issues/comments{/number}","contents_url":"https://api.github.com/repos/SixTrack/SixTrack/contents/{+path}","compare_url":"https://api.github.com/repos/SixTrack/SixTrack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SixTrack/SixTrack/merges","archive_url":"https://api.github.com/repos/SixTrack/SixTrack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SixTrack/SixTrack/downloads","issues_url":"https://api.github.com/repos/SixTrack/SixTrack/issues{/number}","pulls_url":"https://api.github.com/repos/SixTrack/SixTrack/pulls{/number}","milestones_url":"https://api.github.com/repos/SixTrack/SixTrack/milestones{/number}","notifications_url":"https://api.github.com/repos/SixTrack/SixTrack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SixTrack/SixTrack/labels{/name}","releases_url":"https://api.github.com/repos/SixTrack/SixTrack/releases{/id}","deployments_url":"https://api.github.com/repos/SixTrack/SixTrack/deployments","created_at":"2015-08-19T11:10:12Z","updated_at":"2018-11-27T12:51:13Z","pushed_at":"2018-11-28T19:22:05Z","git_url":"git://github.com/SixTrack/SixTrack.git","ssh_url":"git@github.com:SixTrack/SixTrack.git","clone_url":"https://github.com/SixTrack/SixTrack.git","svn_url":"https://github.com/SixTrack/SixTrack","homepage":"http://sixtrack.web.cern.ch/SixTrack/","size":594202,"stargazers_count":20,"watchers_count":20,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":98,"license":null,"forks":36,"open_issues":98,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SixTrack/SixTrack/pulls/702"},"html":{"href":"https://github.com/SixTrack/SixTrack/pull/702"},"issue":{"href":"https://api.github.com/repos/SixTrack/SixTrack/issues/702"},"comments":{"href":"https://api.github.com/repos/SixTrack/SixTrack/issues/702/comments"},"review_comments":{"href":"https://api.github.com/repos/SixTrack/SixTrack/pulls/702/comments"},"review_comment":{"href":"https://api.github.com/repos/SixTrack/SixTrack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SixTrack/SixTrack/pulls/702/commits"},"statuses":{"href":"https://api.github.com/repos/SixTrack/SixTrack/statuses/2d39c9ee44ff0cbc21aabb83d9865ac4099cd860"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amereghe"}}