{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/E-NOISE/opensrs/pulls/3","id":238780704,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NzgwNzA0","html_url":"https://github.com/E-NOISE/opensrs/pull/3","diff_url":"https://github.com/E-NOISE/opensrs/pull/3.diff","patch_url":"https://github.com/E-NOISE/opensrs/pull/3.patch","issue_url":"https://api.github.com/repos/E-NOISE/opensrs/issues/3","number":3,"state":"open","locked":false,"title":"fix bug: strings (chars) get split on &quot;","user":{"login":"YavorK","id":4265225,"node_id":"MDQ6VXNlcjQyNjUyMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/4265225?v=4","gravatar_id":"","url":"https://api.github.com/users/YavorK","html_url":"https://github.com/YavorK","followers_url":"https://api.github.com/users/YavorK/followers","following_url":"https://api.github.com/users/YavorK/following{/other_user}","gists_url":"https://api.github.com/users/YavorK/gists{/gist_id}","starred_url":"https://api.github.com/users/YavorK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YavorK/subscriptions","organizations_url":"https://api.github.com/users/YavorK/orgs","repos_url":"https://api.github.com/users/YavorK/repos","events_url":"https://api.github.com/users/YavorK/events{/privacy}","received_events_url":"https://api.github.com/users/YavorK/received_events","type":"User","site_admin":false},"body":"When there is &quot; in the string the xml parser splits the string into different parts. This makes the opensrs package bug as well when returning \"response_text\" property. For example when the \"response_text\" is 'DNS Zone could not be set for qpwoeip18301.com. (Record type \"\" is not valid or supported.)' it returns only ' is not valid or supported.)' which is a problem for me since I'd like to show errors from the OpenSRS API directly to clients. (Too lazy to think of proper errors messages myself). On the other hand I was not too lazy to fix the code (which only took like 2 hours to figure out.. so here you go. Hope it gets into the repo. Or if you know of a cleverer way to do it - please tell me so I fix my code.","created_at":"2018-12-14T16:48:17Z","updated_at":"2018-12-14T16:48:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/E-NOISE/opensrs/pulls/3/commits","review_comments_url":"https://api.github.com/repos/E-NOISE/opensrs/pulls/3/comments","review_comment_url":"https://api.github.com/repos/E-NOISE/opensrs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/E-NOISE/opensrs/issues/3/comments","statuses_url":"https://api.github.com/repos/E-NOISE/opensrs/statuses/0536687d5a90f0d0e6a906d576fa0ab6bc33c757","head":{"label":"YavorK:patch-2","ref":"patch-2","sha":"0536687d5a90f0d0e6a906d576fa0ab6bc33c757","user":{"login":"YavorK","id":4265225,"node_id":"MDQ6VXNlcjQyNjUyMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/4265225?v=4","gravatar_id":"","url":"https://api.github.com/users/YavorK","html_url":"https://github.com/YavorK","followers_url":"https://api.github.com/users/YavorK/followers","following_url":"https://api.github.com/users/YavorK/following{/other_user}","gists_url":"https://api.github.com/users/YavorK/gists{/gist_id}","starred_url":"https://api.github.com/users/YavorK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YavorK/subscriptions","organizations_url":"https://api.github.com/users/YavorK/orgs","repos_url":"https://api.github.com/users/YavorK/repos","events_url":"https://api.github.com/users/YavorK/events{/privacy}","received_events_url":"https://api.github.com/users/YavorK/received_events","type":"User","site_admin":false},"repo":{"id":160795129,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA3OTUxMjk=","name":"opensrs","full_name":"YavorK/opensrs","private":false,"owner":{"login":"YavorK","id":4265225,"node_id":"MDQ6VXNlcjQyNjUyMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/4265225?v=4","gravatar_id":"","url":"https://api.github.com/users/YavorK","html_url":"https://github.com/YavorK","followers_url":"https://api.github.com/users/YavorK/followers","following_url":"https://api.github.com/users/YavorK/following{/other_user}","gists_url":"https://api.github.com/users/YavorK/gists{/gist_id}","starred_url":"https://api.github.com/users/YavorK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YavorK/subscriptions","organizations_url":"https://api.github.com/users/YavorK/orgs","repos_url":"https://api.github.com/users/YavorK/repos","events_url":"https://api.github.com/users/YavorK/events{/privacy}","received_events_url":"https://api.github.com/users/YavorK/received_events","type":"User","site_admin":false},"html_url":"https://github.com/YavorK/opensrs","description":"Node.js client for the OpenSRS Reseller XML API","fork":true,"url":"https://api.github.com/repos/YavorK/opensrs","forks_url":"https://api.github.com/repos/YavorK/opensrs/forks","keys_url":"https://api.github.com/repos/YavorK/opensrs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YavorK/opensrs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YavorK/opensrs/teams","hooks_url":"https://api.github.com/repos/YavorK/opensrs/hooks","issue_events_url":"https://api.github.com/repos/YavorK/opensrs/issues/events{/number}","events_url":"https://api.github.com/repos/YavorK/opensrs/events","assignees_url":"https://api.github.com/repos/YavorK/opensrs/assignees{/user}","branches_url":"https://api.github.com/repos/YavorK/opensrs/branches{/branch}","tags_url":"https://api.github.com/repos/YavorK/opensrs/tags","blobs_url":"https://api.github.com/repos/YavorK/opensrs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YavorK/opensrs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YavorK/opensrs/git/refs{/sha}","trees_url":"https://api.github.com/repos/YavorK/opensrs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YavorK/opensrs/statuses/{sha}","languages_url":"https://api.github.com/repos/YavorK/opensrs/languages","stargazers_url":"https://api.github.com/repos/YavorK/opensrs/stargazers","contributors_url":"https://api.github.com/repos/YavorK/opensrs/contributors","subscribers_url":"https://api.github.com/repos/YavorK/opensrs/subscribers","subscription_url":"https://api.github.com/repos/YavorK/opensrs/subscription","commits_url":"https://api.github.com/repos/YavorK/opensrs/commits{/sha}","git_commits_url":"https://api.github.com/repos/YavorK/opensrs/git/commits{/sha}","comments_url":"https://api.github.com/repos/YavorK/opensrs/comments{/number}","issue_comment_url":"https://api.github.com/repos/YavorK/opensrs/issues/comments{/number}","contents_url":"https://api.github.com/repos/YavorK/opensrs/contents/{+path}","compare_url":"https://api.github.com/repos/YavorK/opensrs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YavorK/opensrs/merges","archive_url":"https://api.github.com/repos/YavorK/opensrs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YavorK/opensrs/downloads","issues_url":"https://api.github.com/repos/YavorK/opensrs/issues{/number}","pulls_url":"https://api.github.com/repos/YavorK/opensrs/pulls{/number}","milestones_url":"https://api.github.com/repos/YavorK/opensrs/milestones{/number}","notifications_url":"https://api.github.com/repos/YavorK/opensrs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YavorK/opensrs/labels{/name}","releases_url":"https://api.github.com/repos/YavorK/opensrs/releases{/id}","deployments_url":"https://api.github.com/repos/YavorK/opensrs/deployments","created_at":"2018-12-07T08:33:12Z","updated_at":"2018-12-07T08:33:14Z","pushed_at":"2018-12-14T16:47:40Z","git_url":"git://github.com/YavorK/opensrs.git","ssh_url":"git@github.com:YavorK/opensrs.git","clone_url":"https://github.com/YavorK/opensrs.git","svn_url":"https://github.com/YavorK/opensrs","homepage":"","size":37,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"E-NOISE:master","ref":"master","sha":"9c55a85f37985df784163365ff03a7fc764915eb","user":{"login":"E-NOISE","id":342354,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjM1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/342354?v=4","gravatar_id":"","url":"https://api.github.com/users/E-NOISE","html_url":"https://github.com/E-NOISE","followers_url":"https://api.github.com/users/E-NOISE/followers","following_url":"https://api.github.com/users/E-NOISE/following{/other_user}","gists_url":"https://api.github.com/users/E-NOISE/gists{/gist_id}","starred_url":"https://api.github.com/users/E-NOISE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/E-NOISE/subscriptions","organizations_url":"https://api.github.com/users/E-NOISE/orgs","repos_url":"https://api.github.com/users/E-NOISE/repos","events_url":"https://api.github.com/users/E-NOISE/events{/privacy}","received_events_url":"https://api.github.com/users/E-NOISE/received_events","type":"Organization","site_admin":false},"repo":{"id":2949728,"node_id":"MDEwOlJlcG9zaXRvcnkyOTQ5NzI4","name":"opensrs","full_name":"E-NOISE/opensrs","private":false,"owner":{"login":"E-NOISE","id":342354,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjM1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/342354?v=4","gravatar_id":"","url":"https://api.github.com/users/E-NOISE","html_url":"https://github.com/E-NOISE","followers_url":"https://api.github.com/users/E-NOISE/followers","following_url":"https://api.github.com/users/E-NOISE/following{/other_user}","gists_url":"https://api.github.com/users/E-NOISE/gists{/gist_id}","starred_url":"https://api.github.com/users/E-NOISE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/E-NOISE/subscriptions","organizations_url":"https://api.github.com/users/E-NOISE/orgs","repos_url":"https://api.github.com/users/E-NOISE/repos","events_url":"https://api.github.com/users/E-NOISE/events{/privacy}","received_events_url":"https://api.github.com/users/E-NOISE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/E-NOISE/opensrs","description":"Node.js client for the OpenSRS Reseller XML API","fork":false,"url":"https://api.github.com/repos/E-NOISE/opensrs","forks_url":"https://api.github.com/repos/E-NOISE/opensrs/forks","keys_url":"https://api.github.com/repos/E-NOISE/opensrs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/E-NOISE/opensrs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/E-NOISE/opensrs/teams","hooks_url":"https://api.github.com/repos/E-NOISE/opensrs/hooks","issue_events_url":"https://api.github.com/repos/E-NOISE/opensrs/issues/events{/number}","events_url":"https://api.github.com/repos/E-NOISE/opensrs/events","assignees_url":"https://api.github.com/repos/E-NOISE/opensrs/assignees{/user}","branches_url":"https://api.github.com/repos/E-NOISE/opensrs/branches{/branch}","tags_url":"https://api.github.com/repos/E-NOISE/opensrs/tags","blobs_url":"https://api.github.com/repos/E-NOISE/opensrs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/E-NOISE/opensrs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/E-NOISE/opensrs/git/refs{/sha}","trees_url":"https://api.github.com/repos/E-NOISE/opensrs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/E-NOISE/opensrs/statuses/{sha}","languages_url":"https://api.github.com/repos/E-NOISE/opensrs/languages","stargazers_url":"https://api.github.com/repos/E-NOISE/opensrs/stargazers","contributors_url":"https://api.github.com/repos/E-NOISE/opensrs/contributors","subscribers_url":"https://api.github.com/repos/E-NOISE/opensrs/subscribers","subscription_url":"https://api.github.com/repos/E-NOISE/opensrs/subscription","commits_url":"https://api.github.com/repos/E-NOISE/opensrs/commits{/sha}","git_commits_url":"https://api.github.com/repos/E-NOISE/opensrs/git/commits{/sha}","comments_url":"https://api.github.com/repos/E-NOISE/opensrs/comments{/number}","issue_comment_url":"https://api.github.com/repos/E-NOISE/opensrs/issues/comments{/number}","contents_url":"https://api.github.com/repos/E-NOISE/opensrs/contents/{+path}","compare_url":"https://api.github.com/repos/E-NOISE/opensrs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/E-NOISE/opensrs/merges","archive_url":"https://api.github.com/repos/E-NOISE/opensrs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/E-NOISE/opensrs/downloads","issues_url":"https://api.github.com/repos/E-NOISE/opensrs/issues{/number}","pulls_url":"https://api.github.com/repos/E-NOISE/opensrs/pulls{/number}","milestones_url":"https://api.github.com/repos/E-NOISE/opensrs/milestones{/number}","notifications_url":"https://api.github.com/repos/E-NOISE/opensrs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/E-NOISE/opensrs/labels{/name}","releases_url":"https://api.github.com/repos/E-NOISE/opensrs/releases{/id}","deployments_url":"https://api.github.com/repos/E-NOISE/opensrs/deployments","created_at":"2011-12-09T20:00:18Z","updated_at":"2018-12-07T08:32:40Z","pushed_at":"2017-12-11T16:20:24Z","git_url":"git://github.com/E-NOISE/opensrs.git","ssh_url":"git@github.com:E-NOISE/opensrs.git","clone_url":"https://github.com/E-NOISE/opensrs.git","svn_url":"https://github.com/E-NOISE/opensrs","homepage":"","size":37,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/E-NOISE/opensrs/pulls/3"},"html":{"href":"https://github.com/E-NOISE/opensrs/pull/3"},"issue":{"href":"https://api.github.com/repos/E-NOISE/opensrs/issues/3"},"comments":{"href":"https://api.github.com/repos/E-NOISE/opensrs/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/E-NOISE/opensrs/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/E-NOISE/opensrs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/E-NOISE/opensrs/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/E-NOISE/opensrs/statuses/0536687d5a90f0d0e6a906d576fa0ab6bc33c757"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":13,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"YavorK"}}