{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/24804","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/24804/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/24804/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/24804/events","html_url":"https://github.com/elastic/kibana/pull/24804","id":375277975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzYxMjgw","number":24804,"title":"[GIS] plugin","user":{"login":"thomasneirynck","id":1833023,"node_id":"MDQ6VXNlcjE4MzMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1833023?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasneirynck","html_url":"https://github.com/thomasneirynck","followers_url":"https://api.github.com/users/thomasneirynck/followers","following_url":"https://api.github.com/users/thomasneirynck/following{/other_user}","gists_url":"https://api.github.com/users/thomasneirynck/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasneirynck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasneirynck/subscriptions","organizations_url":"https://api.github.com/users/thomasneirynck/orgs","repos_url":"https://api.github.com/users/thomasneirynck/repos","events_url":"https://api.github.com/users/thomasneirynck/events{/privacy}","received_events_url":"https://api.github.com/users/thomasneirynck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":47,"created_at":"2018-10-30T01:09:07Z","updated_at":"2018-11-15T20:05:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/24804","html_url":"https://github.com/elastic/kibana/pull/24804","diff_url":"https://github.com/elastic/kibana/pull/24804.diff","patch_url":"https://github.com/elastic/kibana/pull/24804.patch"},"body":"DO NOT MERGE\r\n\r\nFor discussion purposes only.\r\n\r\n---------------------------\r\n\r\nHi:\r\n- [x] :building_construction: mapbox syncing\r\n    - [x] :building_construction: @thomasneirynck ~~cannot map a single layer to a single source in mapbox. Mapbox will apply point-styles to all vertices of all geometries. We don't want polygons/strings to be styled as circles~~ solution is much more simple. just use mapbox `geometry-type` filter\r\n- [x] :purse: line thickness should be styleable\r\n- [ ] :purse: should be able to select metric (count, avg, ...)\r\n- [ ] :purse: time-aware layers seem to refresh twice on time-change. once after the time-change, and once on the first extent change\r\n- [x] :bug: @nreese workspace at startup doesnt seem to apply current time-selection\r\n- [x] :bug: should be able to delete joins\r\n- [ ] :bug: @thomasneirynck data-refresh seems to be buggy (likely all related)\r\n    - [ ] :bug: for es search sources, the fitlered-by-map bound flag seems to be always false.(Source#getGeoJson should not have time and extent filters if they shouldn't be applied to begin with)\r\n    - [ ] :bug: time-aware sources are always refreshed, even when no time-changes and map is just being panned\r\n- [ ] :bug: @aaronjcaldwell styling/legend loose ends\r\n    - [ ] :bug: color ramp previewer in TOC should work for all vector-layers (including points)\r\n    - [ ] :bug: small icon needs to default to regular vector-type icon (grey one) when a color-ramp is showing in the TOC\r\n    - [ ] :bug: for small legend icon of non-point uses, use icon from keynote demo (so not the one with the vertices, but the rectangular one with rounded corners).\r\n    - [ ] :bug: error when swithcing from dynamic to static color. (e.g. `Error: layers.ric9r_fill.paint.fill-color: color expected, \"Green to Red\" found)`. The seeding of the control seems wrong. \r\n\r\n\r\nMid:\r\n- [ ] ~~:building_construction: evaluate writing style-files for style-syncing (iso setting individual paintproperties on the map instance), so that mapbox does the style-diffing on application (https://www.mapbox.com/mapbox-gl-js/api/#map#setstyle)~~ retain current approach with `setPaintProperty` for now\r\n- [ ] :purse: @thomasneirynck basic point and line styling (otherwise we're limited to just visualizing polygons from ES)\r\n- [x] :bug: @nreese should pad the extent a little before applying bbox-filter on es_search_sources (similar to geohash-grid)\r\n- [x] :bug: @nreese for es_search_source, should not requery data when next extent is contained within old extent (ie. when zooming in). (similar to geohash-grid). (do this optimization ONLY if we received all documents)\r\n- [x] :bug: should not be able to add geohash-grid layer for indices without geo_point field\r\n- [x] :bug: layer-details for index-pattern sources should not show the index-pattern id, but rather the name of the index pattern (note that this requires async rendering, since the name needs to be retrieved dynamically).\r\n- [ ] :bug: extent-aware filtering does not seem to work on map pan/zoom\r\n- [ ] :bug: cancel button should work for ALL layer properties (e.g. label, zoom-settigs, ...), not just style-settings\r\n\r\n\r\nLow:\r\n- [x] :purse: be able to minimize/collapse layer TOC so it doesn't cover the map\r\n- [x] :purse: Heatmap styling in layer-details panel\r\n- [x] :purse: visibilty toggle should be automagical (icon turns into a checkbox to toggle visibility)\r\n- [ ] :purse: when previewing a layer in the add-layer panel, the map should fit to the data, and then, after adding snap back to the previous extent\r\n- [ ] :purse: @aaronjcaldwell small legend icon next to layer in TOC (needs to take into account layer-type and style) (layer-type maps to `heatmap`, `grid`, and `vector` icons in EUI. legend-icon must degrade to those when we cannot provide a small preview. small preview is only for static styling of fill and outline.)\r\n- [ ] :purse: @aaronjcaldwell WMS data source\r\n- [ ] ~~:bug: flyout hides timepicker~~ this is everywhere in Kibana\r\n- [x] :bug: @thomasneirynck reset button on style is not working (reconsider if we actually need this, we can cancel out the layer-details panel and style gets reverted)\r\n- [ ] :bug: currently can enable tooltip without fields, which actually results in no tooltip. should be a warning to the user that no fields have been specified for tooltip\r\n\r\n\r\nFunctional test cases:\r\n- [ ] Can save a workspace\r\n- [ ] Can load a saved workspace\r\n    - [ ] Applies workspace time to Kibana global time\r\n    - [ ] Applies workspace map center and zoom\r\n    - [ ] Applies workspace layers\r\n- [ ] es_search_source\r\n     - [ ] should add request to inspector\r\n    - [ ] should not requery data when next extent is contained within old extent (ie. when zooming in) and we received all documents\r\n    - [ ] should requery data when next extent is contained within old extent (ie. when zooming in)\r\n- [ ] es_geohashgrid_source\r\n     - [ ] should add request to inspector\r\n    - [ ] should not requery data when next extent is contained within old extent (ie. when zooming in)\r\n    - [ ] should requery data when next extent is contained within old extent (ie. when zooming in) and precision changes"},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/439172442","html_url":"https://github.com/elastic/kibana/pull/24804#issuecomment-439172442","issue_url":"https://api.github.com/repos/elastic/kibana/issues/24804","id":439172442,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTE3MjQ0Mg==","user":{"login":"elasticmachine","id":15837671,"node_id":"MDQ6VXNlcjE1ODM3Njcx","avatar_url":"https://avatars3.githubusercontent.com/u/15837671?v=4","gravatar_id":"","url":"https://api.github.com/users/elasticmachine","html_url":"https://github.com/elasticmachine","followers_url":"https://api.github.com/users/elasticmachine/followers","following_url":"https://api.github.com/users/elasticmachine/following{/other_user}","gists_url":"https://api.github.com/users/elasticmachine/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticmachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticmachine/subscriptions","organizations_url":"https://api.github.com/users/elasticmachine/orgs","repos_url":"https://api.github.com/users/elasticmachine/repos","events_url":"https://api.github.com/users/elasticmachine/events{/privacy}","received_events_url":"https://api.github.com/users/elasticmachine/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T20:05:02Z","updated_at":"2018-11-15T20:05:02Z","author_association":"NONE","body":"## :broken_heart: Build Failed\n* [continuous-integration/kibana-ci/pull-request](https://kibana-ci.elastic.co/job/elastic+kibana+pull-request/230/)\n\n"}}
{"actor":{"display_login":"elasticmachine"}}