{"action":"created","issue":{"url":"https://api.github.com/repos/react-native-community/react-native-video/issues/1273","repository_url":"https://api.github.com/repos/react-native-community/react-native-video","labels_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/1273/labels{/name}","comments_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/1273/comments","events_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/1273/events","html_url":"https://github.com/react-native-community/react-native-video/issues/1273","id":368262406,"node_id":"MDU6SXNzdWUzNjgyNjI0MDY=","number":1273,"title":"Cookie handling changes between React Native 0.55 & 0.57","user":{"login":"gtebbutt","id":5956226,"node_id":"MDQ6VXNlcjU5NTYyMjY=","avatar_url":"https://avatars1.githubusercontent.com/u/5956226?v=4","gravatar_id":"","url":"https://api.github.com/users/gtebbutt","html_url":"https://github.com/gtebbutt","followers_url":"https://api.github.com/users/gtebbutt/followers","following_url":"https://api.github.com/users/gtebbutt/following{/other_user}","gists_url":"https://api.github.com/users/gtebbutt/gists{/gist_id}","starred_url":"https://api.github.com/users/gtebbutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtebbutt/subscriptions","organizations_url":"https://api.github.com/users/gtebbutt/orgs","repos_url":"https://api.github.com/users/gtebbutt/repos","events_url":"https://api.github.com/users/gtebbutt/events{/privacy}","received_events_url":"https://api.github.com/users/gtebbutt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-09T15:14:09Z","updated_at":"2018-10-15T12:33:19Z","closed_at":null,"author_association":"NONE","body":"### Current behavior\r\nAfter upgrading from 0.55 to 0.57, the cookies sent by `react-native-video` are not the same as those sent by `fetch` requests. The video request does send *some* cookies, which suggests to me that there's a synchronisation/update issue rather than a total change of behaviour.\r\n\r\nThe cookies are set from the root domain and the video request is to a subdomain, which may or may not be relevant (the cookie domain is set correctly, and working fine across the subdomains on web and on RN 0.55).\r\n\r\nIt's also worth noting that there definitely has been some change in RN's cookie handling in the last couple of versions (see https://github.com/facebook/react-native/issues/19376 and https://github.com/facebook/react-native/issues/19958), but nobody seems to be sure what precisely has changed. I've chased a few dead-ends myself with no luck. \r\n\r\n### Reproduction steps\r\n- Make a `fetch` request that sets a cookie\r\n- Open a video on the same domain (but different subdomain)\r\n- The new cookie will not be sent with the video request\r\n\r\n### Expected behavior\r\nAs per 0.55, the cookies sent by `react-native-video` remain in sync with those sent by the `react-native` default `fetch` implementation.\r\n\r\n### Platform\r\n* iOS\r\n\r\n### Video sample\r\nN/A"},"comment":{"url":"https://api.github.com/repos/react-native-community/react-native-video/issues/comments/429835553","html_url":"https://github.com/react-native-community/react-native-video/issues/1273#issuecomment-429835553","issue_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/1273","id":429835553,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTgzNTU1Mw==","user":{"login":"gtebbutt","id":5956226,"node_id":"MDQ6VXNlcjU5NTYyMjY=","avatar_url":"https://avatars1.githubusercontent.com/u/5956226?v=4","gravatar_id":"","url":"https://api.github.com/users/gtebbutt","html_url":"https://github.com/gtebbutt","followers_url":"https://api.github.com/users/gtebbutt/followers","following_url":"https://api.github.com/users/gtebbutt/following{/other_user}","gists_url":"https://api.github.com/users/gtebbutt/gists{/gist_id}","starred_url":"https://api.github.com/users/gtebbutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtebbutt/subscriptions","organizations_url":"https://api.github.com/users/gtebbutt/orgs","repos_url":"https://api.github.com/users/gtebbutt/repos","events_url":"https://api.github.com/users/gtebbutt/events{/privacy}","received_events_url":"https://api.github.com/users/gtebbutt/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T12:33:19Z","updated_at":"2018-10-15T12:33:19Z","author_association":"NONE","body":"Understood, that all makes sense. I'll definitely keep looking into it as I get time, but I also wanted to flag it here in case anyone has input or suggestions that might be helpful! "}}
{"actor":{"display_login":"gtebbutt"}}