{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pulls/3","id":232872105,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODcyMTA1","html_url":"https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pull/3","diff_url":"https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pull/3.diff","patch_url":"https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pull/3.patch","issue_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/issues/3","number":3,"state":"open","locked":false,"title":"Rewrite to make package scope traversing clearer","user":{"login":"GeoffreyBooth","id":456802,"node_id":"MDQ6VXNlcjQ1NjgwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/456802?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"body":"So I started rewriting the proposal to make clear that the searching up the path for the nearest `package.json` applied to not just absolute URL specifiers but also to relative specifiers and deep imports, and it was getting very repetitive so I ditched the previous structure. The proposal got a lot shorter as a result, which I assume must be a good thing. I don’t think I actually _changed_ anything that was being proposed, just that the text is now much better organized (I hope); @jkrems and @guybedford please let me know if any of my rewriting screwed anything up.\r\n\r\n@bmeck and @robpalme I added some language about exceptions being thrown for “double import” of files, please feel free to expand or rewrite as you see fit.\r\n\r\nFormatted version for each reading: https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal/blob/rewrite/README.md (basically just reread the entire “Proposal” section).","created_at":"2018-11-22T06:30:42Z","updated_at":"2018-11-22T06:30:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pulls/3/commits","review_comments_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pulls/3/comments","review_comment_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/issues/3/comments","statuses_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/statuses/114ce969ac294e55f822c645ad36b47cd2021dd5","head":{"label":"GeoffreyBooth:rewrite","ref":"rewrite","sha":"114ce969ac294e55f822c645ad36b47cd2021dd5","user":{"login":"GeoffreyBooth","id":456802,"node_id":"MDQ6VXNlcjQ1NjgwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/456802?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"repo":{"id":157161479,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcxNjE0Nzk=","name":"node-import-file-specifier-resolution-proposal","full_name":"GeoffreyBooth/node-import-file-specifier-resolution-proposal","private":false,"owner":{"login":"GeoffreyBooth","id":456802,"node_id":"MDQ6VXNlcjQ1NjgwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/456802?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal","description":"A proposal for import statements of files for the new Node.js modules implementation","fork":false,"url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal","forks_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/forks","keys_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/teams","hooks_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/hooks","issue_events_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/issues/events{/number}","events_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/events","assignees_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/assignees{/user}","branches_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/branches{/branch}","tags_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/tags","blobs_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/statuses/{sha}","languages_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/languages","stargazers_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/stargazers","contributors_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/contributors","subscribers_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/subscribers","subscription_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/subscription","commits_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/contents/{+path}","compare_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/merges","archive_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/downloads","issues_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/issues{/number}","pulls_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pulls{/number}","milestones_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/milestones{/number}","notifications_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/labels{/name}","releases_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/releases{/id}","deployments_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/deployments","created_at":"2018-11-12T05:35:16Z","updated_at":"2018-11-21T22:29:02Z","pushed_at":"2018-11-22T06:30:20Z","git_url":"git://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal.git","ssh_url":"git@github.com:GeoffreyBooth/node-import-file-specifier-resolution-proposal.git","clone_url":"https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal.git","svn_url":"https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal","homepage":null,"size":6513,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"GeoffreyBooth:master","ref":"master","sha":"825cc7ab1b63f81871a14f832fb8906a7b319aea","user":{"login":"GeoffreyBooth","id":456802,"node_id":"MDQ6VXNlcjQ1NjgwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/456802?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"repo":{"id":157161479,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcxNjE0Nzk=","name":"node-import-file-specifier-resolution-proposal","full_name":"GeoffreyBooth/node-import-file-specifier-resolution-proposal","private":false,"owner":{"login":"GeoffreyBooth","id":456802,"node_id":"MDQ6VXNlcjQ1NjgwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/456802?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal","description":"A proposal for import statements of files for the new Node.js modules implementation","fork":false,"url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal","forks_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/forks","keys_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/teams","hooks_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/hooks","issue_events_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/issues/events{/number}","events_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/events","assignees_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/assignees{/user}","branches_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/branches{/branch}","tags_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/tags","blobs_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/statuses/{sha}","languages_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/languages","stargazers_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/stargazers","contributors_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/contributors","subscribers_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/subscribers","subscription_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/subscription","commits_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/contents/{+path}","compare_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/merges","archive_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/downloads","issues_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/issues{/number}","pulls_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pulls{/number}","milestones_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/milestones{/number}","notifications_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/labels{/name}","releases_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/releases{/id}","deployments_url":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/deployments","created_at":"2018-11-12T05:35:16Z","updated_at":"2018-11-21T22:29:02Z","pushed_at":"2018-11-22T06:30:20Z","git_url":"git://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal.git","ssh_url":"git@github.com:GeoffreyBooth/node-import-file-specifier-resolution-proposal.git","clone_url":"https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal.git","svn_url":"https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal","homepage":null,"size":6513,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pulls/3"},"html":{"href":"https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pull/3"},"issue":{"href":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/issues/3"},"comments":{"href":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/GeoffreyBooth/node-import-file-specifier-resolution-proposal/statuses/114ce969ac294e55f822c645ad36b47cd2021dd5"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":91,"deletions":65,"changed_files":1}}
{"actor":{"display_login":"GeoffreyBooth"}}