{"action":"created","comment":{"url":"https://api.github.com/repos/atom/github/pulls/comments/239204621","pull_request_review_id":181922702,"id":239204621,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTIwNDYyMQ==","diff_hunk":"@@ -317,7 +270,7 @@ export class BareIssueishDetailView extends React.Component {\n   }\n \n   recordOpenInBrowserEvent() {\n-    addEvent('open-issueish-in-browser', {package: 'github', from: 'issueish-header'});\n+    addEvent('open-pull-request-in-browser', {package: 'github', component: this.constructor.name});","path":"lib/views/pr-detail-view.js","position":253,"original_position":253,"commit_id":"f9c687858b1d19a709120a5ca37dfe93b655cfbe","original_commit_id":"f9c687858b1d19a709120a5ca37dfe93b655cfbe","user":{"login":"smashwilson","id":17565,"node_id":"MDQ6VXNlcjE3NTY1","avatar_url":"https://avatars2.githubusercontent.com/u/17565?v=4","gravatar_id":"","url":"https://api.github.com/users/smashwilson","html_url":"https://github.com/smashwilson","followers_url":"https://api.github.com/users/smashwilson/followers","following_url":"https://api.github.com/users/smashwilson/following{/other_user}","gists_url":"https://api.github.com/users/smashwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/smashwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smashwilson/subscriptions","organizations_url":"https://api.github.com/users/smashwilson/orgs","repos_url":"https://api.github.com/users/smashwilson/repos","events_url":"https://api.github.com/users/smashwilson/events{/privacy}","received_events_url":"https://api.github.com/users/smashwilson/received_events","type":"User","site_admin":true},"body":"Oh, cool, we get better granularity on these telemetry events, too.\r\n\r\nDo we need to update anything or let @telliott27 know that this event name is changing?","created_at":"2018-12-05T19:26:39Z","updated_at":"2018-12-05T19:37:26Z","html_url":"https://github.com/atom/github/pull/1804#discussion_r239204621","pull_request_url":"https://api.github.com/repos/atom/github/pulls/1804","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/atom/github/pulls/comments/239204621"},"html":{"href":"https://github.com/atom/github/pull/1804#discussion_r239204621"},"pull_request":{"href":"https://api.github.com/repos/atom/github/pulls/1804"}}},"pull_request":{"url":"https://api.github.com/repos/atom/github/pulls/1804","id":232470736,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDcwNzM2","html_url":"https://github.com/atom/github/pull/1804","diff_url":"https://github.com/atom/github/pull/1804.diff","patch_url":"https://github.com/atom/github/pull/1804.patch","issue_url":"https://api.github.com/repos/atom/github/issues/1804","number":1804,"state":"open","locked":false,"title":"split IssueishDetailView into IssueDetailView and PullRequestDetailView","user":{"login":"annthurium","id":3781742,"node_id":"MDQ6VXNlcjM3ODE3NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3781742?v=4","gravatar_id":"","url":"https://api.github.com/users/annthurium","html_url":"https://github.com/annthurium","followers_url":"https://api.github.com/users/annthurium/followers","following_url":"https://api.github.com/users/annthurium/following{/other_user}","gists_url":"https://api.github.com/users/annthurium/gists{/gist_id}","starred_url":"https://api.github.com/users/annthurium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annthurium/subscriptions","organizations_url":"https://api.github.com/users/annthurium/orgs","repos_url":"https://api.github.com/users/annthurium/repos","events_url":"https://api.github.com/users/annthurium/events{/privacy}","received_events_url":"https://api.github.com/users/annthurium/received_events","type":"User","site_admin":true},"body":"addresses https://github.com/atom/github/issues/1715. \r\n\r\nThese components have enough separate functionality that we should move them into their own files.  There should be no user facing changes as a result of this refactor - it just makes it easier for us to maintain things in the future. \r\n\r\n## Todo\r\n- [x] make new files for the new components\r\n- [x] extract pr functionality from `IssueishDetailView` into `PullRequestDetailView`\r\n- [x] extract issue functionality from `IssueishDetailView` into `IssueDetailView`\r\n- [x] fix the graphql problems that will undoubtedly arise\r\n- [x] extract emoji rendering functionality since it's shared by both components\r\n- [x] do a pass on variables that could maybe be renamed?\r\n- [x] nuke `IssueishDetailContainer` and any other dead code\r\n- [x] fix missing prop warning in pr view when commits tab is clicked\r\n- [ ] all unit tests are green\r\n- [ ]  Coveralls reports no new uncovered lines\r\n- [ ] Coveralls reports no uncovered existing lines\r\n\r\n## Manual test plan:\r\n- [x] open issue in Atom\r\n    - [x] header links to issue on dotcom\r\n    - [x] refresh button pulls down new data\r\n    - [x] issue body text and comments are styled as expected\r\n    - [x] link to dotcom in issue footer exists\r\n    - [x] emoji reactions are rendered\r\n    - [x] switching from an issue to a pull request (by clicking link to a pull request referenced in an issue)\r\n- [x] open pull request in Atom\r\n  - [x] header links to pull request on dotcom\r\n  - [x] refresh button pulls down new data\r\n  - [x] pull request meta view is styled as expected\r\n  - [x] checkout pull request functionality works.\r\n  - [x] overview tab contains pull request timeline\r\n  - [x] emoji reactions are rendered\r\n  - [x] build status contains the build status\r\n  - [x] commits tab contains commits \r\n  - [x] test a pull request with more than 50 commits to make sure pagination and refetching work correctly\r\n   - [x] switching from an pull request to an issue (by clicking link to an issue referenced in a pull request body)","created_at":"2018-11-20T21:52:10Z","updated_at":"2018-12-05T19:37:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8ee4209668568be7194631520d6b57bf8755994","assignee":{"login":"smashwilson","id":17565,"node_id":"MDQ6VXNlcjE3NTY1","avatar_url":"https://avatars2.githubusercontent.com/u/17565?v=4","gravatar_id":"","url":"https://api.github.com/users/smashwilson","html_url":"https://github.com/smashwilson","followers_url":"https://api.github.com/users/smashwilson/followers","following_url":"https://api.github.com/users/smashwilson/following{/other_user}","gists_url":"https://api.github.com/users/smashwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/smashwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smashwilson/subscriptions","organizations_url":"https://api.github.com/users/smashwilson/orgs","repos_url":"https://api.github.com/users/smashwilson/repos","events_url":"https://api.github.com/users/smashwilson/events{/privacy}","received_events_url":"https://api.github.com/users/smashwilson/received_events","type":"User","site_admin":true},"assignees":[{"login":"smashwilson","id":17565,"node_id":"MDQ6VXNlcjE3NTY1","avatar_url":"https://avatars2.githubusercontent.com/u/17565?v=4","gravatar_id":"","url":"https://api.github.com/users/smashwilson","html_url":"https://github.com/smashwilson","followers_url":"https://api.github.com/users/smashwilson/followers","following_url":"https://api.github.com/users/smashwilson/following{/other_user}","gists_url":"https://api.github.com/users/smashwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/smashwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smashwilson/subscriptions","organizations_url":"https://api.github.com/users/smashwilson/orgs","repos_url":"https://api.github.com/users/smashwilson/repos","events_url":"https://api.github.com/users/smashwilson/events{/privacy}","received_events_url":"https://api.github.com/users/smashwilson/received_events","type":"User","site_admin":true},{"login":"annthurium","id":3781742,"node_id":"MDQ6VXNlcjM3ODE3NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3781742?v=4","gravatar_id":"","url":"https://api.github.com/users/annthurium","html_url":"https://github.com/annthurium","followers_url":"https://api.github.com/users/annthurium/followers","following_url":"https://api.github.com/users/annthurium/following{/other_user}","gists_url":"https://api.github.com/users/annthurium/gists{/gist_id}","starred_url":"https://api.github.com/users/annthurium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annthurium/subscriptions","organizations_url":"https://api.github.com/users/annthurium/orgs","repos_url":"https://api.github.com/users/annthurium/repos","events_url":"https://api.github.com/users/annthurium/events{/privacy}","received_events_url":"https://api.github.com/users/annthurium/received_events","type":"User","site_admin":true},{"login":"vanessayuenn","id":6842965,"node_id":"MDQ6VXNlcjY4NDI5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/6842965?v=4","gravatar_id":"","url":"https://api.github.com/users/vanessayuenn","html_url":"https://github.com/vanessayuenn","followers_url":"https://api.github.com/users/vanessayuenn/followers","following_url":"https://api.github.com/users/vanessayuenn/following{/other_user}","gists_url":"https://api.github.com/users/vanessayuenn/gists{/gist_id}","starred_url":"https://api.github.com/users/vanessayuenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanessayuenn/subscriptions","organizations_url":"https://api.github.com/users/vanessayuenn/orgs","repos_url":"https://api.github.com/users/vanessayuenn/repos","events_url":"https://api.github.com/users/vanessayuenn/events{/privacy}","received_events_url":"https://api.github.com/users/vanessayuenn/received_events","type":"User","site_admin":true},{"login":"kuychaco","id":7910250,"node_id":"MDQ6VXNlcjc5MTAyNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/7910250?v=4","gravatar_id":"","url":"https://api.github.com/users/kuychaco","html_url":"https://github.com/kuychaco","followers_url":"https://api.github.com/users/kuychaco/followers","following_url":"https://api.github.com/users/kuychaco/following{/other_user}","gists_url":"https://api.github.com/users/kuychaco/gists{/gist_id}","starred_url":"https://api.github.com/users/kuychaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuychaco/subscriptions","organizations_url":"https://api.github.com/users/kuychaco/orgs","repos_url":"https://api.github.com/users/kuychaco/repos","events_url":"https://api.github.com/users/kuychaco/events{/privacy}","received_events_url":"https://api.github.com/users/kuychaco/received_events","type":"User","site_admin":true}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/atom/github/pulls/1804/commits","review_comments_url":"https://api.github.com/repos/atom/github/pulls/1804/comments","review_comment_url":"https://api.github.com/repos/atom/github/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/github/issues/1804/comments","statuses_url":"https://api.github.com/repos/atom/github/statuses/f9c687858b1d19a709120a5ca37dfe93b655cfbe","head":{"label":"atom:tt-18-nov-split-component","ref":"tt-18-nov-split-component","sha":"f9c687858b1d19a709120a5ca37dfe93b655cfbe","user":{"login":"atom","id":1089146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODkxNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":46155786,"node_id":"MDEwOlJlcG9zaXRvcnk0NjE1NTc4Ng==","name":"github","full_name":"atom/github","private":false,"owner":{"login":"atom","id":1089146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODkxNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atom/github","description":":octocat: Git and GitHub integration for Atom","fork":false,"url":"https://api.github.com/repos/atom/github","forks_url":"https://api.github.com/repos/atom/github/forks","keys_url":"https://api.github.com/repos/atom/github/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/github/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/github/teams","hooks_url":"https://api.github.com/repos/atom/github/hooks","issue_events_url":"https://api.github.com/repos/atom/github/issues/events{/number}","events_url":"https://api.github.com/repos/atom/github/events","assignees_url":"https://api.github.com/repos/atom/github/assignees{/user}","branches_url":"https://api.github.com/repos/atom/github/branches{/branch}","tags_url":"https://api.github.com/repos/atom/github/tags","blobs_url":"https://api.github.com/repos/atom/github/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/github/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/github/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/github/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/github/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/github/languages","stargazers_url":"https://api.github.com/repos/atom/github/stargazers","contributors_url":"https://api.github.com/repos/atom/github/contributors","subscribers_url":"https://api.github.com/repos/atom/github/subscribers","subscription_url":"https://api.github.com/repos/atom/github/subscription","commits_url":"https://api.github.com/repos/atom/github/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/github/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/github/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/github/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/github/contents/{+path}","compare_url":"https://api.github.com/repos/atom/github/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/github/merges","archive_url":"https://api.github.com/repos/atom/github/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/github/downloads","issues_url":"https://api.github.com/repos/atom/github/issues{/number}","pulls_url":"https://api.github.com/repos/atom/github/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/github/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/github/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/github/labels{/name}","releases_url":"https://api.github.com/repos/atom/github/releases{/id}","deployments_url":"https://api.github.com/repos/atom/github/deployments","created_at":"2015-11-14T01:17:58Z","updated_at":"2018-12-05T02:13:24Z","pushed_at":"2018-12-05T16:42:13Z","git_url":"git://github.com/atom/github.git","ssh_url":"git@github.com:atom/github.git","clone_url":"https://github.com/atom/github.git","svn_url":"https://github.com/atom/github","homepage":"https://github.atom.io","size":14418,"stargazers_count":596,"watchers_count":596,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":357,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":141,"open_issues":357,"watchers":596,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"d403789432de85e38c5801570f6b06f9f9a7cd59","user":{"login":"atom","id":1089146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODkxNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":46155786,"node_id":"MDEwOlJlcG9zaXRvcnk0NjE1NTc4Ng==","name":"github","full_name":"atom/github","private":false,"owner":{"login":"atom","id":1089146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODkxNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atom/github","description":":octocat: Git and GitHub integration for Atom","fork":false,"url":"https://api.github.com/repos/atom/github","forks_url":"https://api.github.com/repos/atom/github/forks","keys_url":"https://api.github.com/repos/atom/github/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/github/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/github/teams","hooks_url":"https://api.github.com/repos/atom/github/hooks","issue_events_url":"https://api.github.com/repos/atom/github/issues/events{/number}","events_url":"https://api.github.com/repos/atom/github/events","assignees_url":"https://api.github.com/repos/atom/github/assignees{/user}","branches_url":"https://api.github.com/repos/atom/github/branches{/branch}","tags_url":"https://api.github.com/repos/atom/github/tags","blobs_url":"https://api.github.com/repos/atom/github/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/github/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/github/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/github/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/github/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/github/languages","stargazers_url":"https://api.github.com/repos/atom/github/stargazers","contributors_url":"https://api.github.com/repos/atom/github/contributors","subscribers_url":"https://api.github.com/repos/atom/github/subscribers","subscription_url":"https://api.github.com/repos/atom/github/subscription","commits_url":"https://api.github.com/repos/atom/github/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/github/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/github/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/github/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/github/contents/{+path}","compare_url":"https://api.github.com/repos/atom/github/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/github/merges","archive_url":"https://api.github.com/repos/atom/github/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/github/downloads","issues_url":"https://api.github.com/repos/atom/github/issues{/number}","pulls_url":"https://api.github.com/repos/atom/github/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/github/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/github/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/github/labels{/name}","releases_url":"https://api.github.com/repos/atom/github/releases{/id}","deployments_url":"https://api.github.com/repos/atom/github/deployments","created_at":"2015-11-14T01:17:58Z","updated_at":"2018-12-05T02:13:24Z","pushed_at":"2018-12-05T16:42:13Z","git_url":"git://github.com/atom/github.git","ssh_url":"git@github.com:atom/github.git","clone_url":"https://github.com/atom/github.git","svn_url":"https://github.com/atom/github","homepage":"https://github.atom.io","size":14418,"stargazers_count":596,"watchers_count":596,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":357,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":141,"open_issues":357,"watchers":596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/github/pulls/1804"},"html":{"href":"https://github.com/atom/github/pull/1804"},"issue":{"href":"https://api.github.com/repos/atom/github/issues/1804"},"comments":{"href":"https://api.github.com/repos/atom/github/issues/1804/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/github/pulls/1804/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/github/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/github/pulls/1804/commits"},"statuses":{"href":"https://api.github.com/repos/atom/github/statuses/f9c687858b1d19a709120a5ca37dfe93b655cfbe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"smashwilson"}}