{"action":"closed","issue":{"url":"https://api.github.com/repos/kirinrastogi/proxysql-go/issues/2","repository_url":"https://api.github.com/repos/kirinrastogi/proxysql-go","labels_url":"https://api.github.com/repos/kirinrastogi/proxysql-go/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/kirinrastogi/proxysql-go/issues/2/comments","events_url":"https://api.github.com/repos/kirinrastogi/proxysql-go/issues/2/events","html_url":"https://github.com/kirinrastogi/proxysql-go/issues/2","id":362945109,"node_id":"MDU6SXNzdWUzNjI5NDUxMDk=","number":2,"title":"RFC: Specify max_connections dynamically, and provide API functions for it","user":{"login":"kirinrastogi","id":14277509,"node_id":"MDQ6VXNlcjE0Mjc3NTA5","avatar_url":"https://avatars2.githubusercontent.com/u/14277509?v=4","gravatar_id":"","url":"https://api.github.com/users/kirinrastogi","html_url":"https://github.com/kirinrastogi","followers_url":"https://api.github.com/users/kirinrastogi/followers","following_url":"https://api.github.com/users/kirinrastogi/following{/other_user}","gists_url":"https://api.github.com/users/kirinrastogi/gists{/gist_id}","starred_url":"https://api.github.com/users/kirinrastogi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirinrastogi/subscriptions","organizations_url":"https://api.github.com/users/kirinrastogi/orgs","repos_url":"https://api.github.com/users/kirinrastogi/repos","events_url":"https://api.github.com/users/kirinrastogi/events{/privacy}","received_events_url":"https://api.github.com/users/kirinrastogi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-23T14:03:09Z","updated_at":"2018-10-04T02:35:05Z","closed_at":"2018-10-04T02:35:04Z","author_association":"OWNER","body":"We might want to provide a way to modify the max_connections for all entries, for some entries that match a certain regex, for some in a certain hostgroup.\r\n\r\nWe also may want to reconsider how we specify it. Should it be once on lib creation? In the `New` func? Or should it be on each call?\r\n\r\nShould there be helper funcs to call say `SetWriter, AddHost` with max_connections as a default value? I don't know that much about if anyone changes this dynamically, I have only worked with it being fixed for the whole fleet."}}
{"actor":{"display_login":"kirinrastogi"}}