{"action":"created","comment":{"url":"https://api.github.com/repos/pypa/virtualenv/pulls/comments/228715621","pull_request_review_id":169058390,"id":228715621,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODcxNTYyMQ==","diff_hunk":"@@ -305,20 +303,17 @@ def end_progress(self, msg=\"done.\"):\n         if self.stdout_level_matches(self.NOTIFY):\n             if not self.in_progress_hanging:\n                 # Some message has been printed out since start_progress\n-                sys.stdout.write(\"...\" + self.in_progress + msg + \"\\n\")\n-                sys.stdout.flush()\n+                print(\"...\" + self.in_progress + msg, flush=True)","path":"src/virtualenv.py","position":26,"original_position":26,"commit_id":"152de475b38c853a1cd8e0240010ee1c1cc4469b","original_commit_id":"152de475b38c853a1cd8e0240010ee1c1cc4469b","user":{"login":"gaborbernat","id":690238,"node_id":"MDQ6VXNlcjY5MDIzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/690238?v=4","gravatar_id":"","url":"https://api.github.com/users/gaborbernat","html_url":"https://github.com/gaborbernat","followers_url":"https://api.github.com/users/gaborbernat/followers","following_url":"https://api.github.com/users/gaborbernat/following{/other_user}","gists_url":"https://api.github.com/users/gaborbernat/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborbernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborbernat/subscriptions","organizations_url":"https://api.github.com/users/gaborbernat/orgs","repos_url":"https://api.github.com/users/gaborbernat/repos","events_url":"https://api.github.com/users/gaborbernat/events{/privacy}","received_events_url":"https://api.github.com/users/gaborbernat/received_events","type":"User","site_admin":false},"body":"please make this a format, instead of the pluses :+1: thanks","created_at":"2018-10-27T14:57:55Z","updated_at":"2018-10-27T14:57:55Z","html_url":"https://github.com/pypa/virtualenv/pull/1231#discussion_r228715621","pull_request_url":"https://api.github.com/repos/pypa/virtualenv/pulls/1231","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/comments/228715621"},"html":{"href":"https://github.com/pypa/virtualenv/pull/1231#discussion_r228715621"},"pull_request":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/1231"}}},"pull_request":{"url":"https://api.github.com/repos/pypa/virtualenv/pulls/1231","id":226297244,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2Mjk3MjQ0","html_url":"https://github.com/pypa/virtualenv/pull/1231","diff_url":"https://github.com/pypa/virtualenv/pull/1231.diff","patch_url":"https://github.com/pypa/virtualenv/pull/1231.patch","issue_url":"https://api.github.com/repos/pypa/virtualenv/issues/1231","number":1231,"state":"open","locked":false,"title":"Refactor print statements","user":{"login":"minggli","id":14131823,"node_id":"MDQ6VXNlcjE0MTMxODIz","avatar_url":"https://avatars0.githubusercontent.com/u/14131823?v=4","gravatar_id":"","url":"https://api.github.com/users/minggli","html_url":"https://github.com/minggli","followers_url":"https://api.github.com/users/minggli/followers","following_url":"https://api.github.com/users/minggli/following{/other_user}","gists_url":"https://api.github.com/users/minggli/gists{/gist_id}","starred_url":"https://api.github.com/users/minggli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggli/subscriptions","organizations_url":"https://api.github.com/users/minggli/orgs","repos_url":"https://api.github.com/users/minggli/repos","events_url":"https://api.github.com/users/minggli/events{/privacy}","received_events_url":"https://api.github.com/users/minggli/received_events","type":"User","site_admin":false},"body":"This PR refactors all sys.stdout.write to print for brevity and readability.","created_at":"2018-10-27T14:14:55Z","updated_at":"2018-10-27T14:57:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05bc3c45fd7b268f6882d6b2cc1a991b926824b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pypa/virtualenv/pulls/1231/commits","review_comments_url":"https://api.github.com/repos/pypa/virtualenv/pulls/1231/comments","review_comment_url":"https://api.github.com/repos/pypa/virtualenv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypa/virtualenv/issues/1231/comments","statuses_url":"https://api.github.com/repos/pypa/virtualenv/statuses/152de475b38c853a1cd8e0240010ee1c1cc4469b","head":{"label":"minggli:refactor/print_statements","ref":"refactor/print_statements","sha":"152de475b38c853a1cd8e0240010ee1c1cc4469b","user":{"login":"minggli","id":14131823,"node_id":"MDQ6VXNlcjE0MTMxODIz","avatar_url":"https://avatars0.githubusercontent.com/u/14131823?v=4","gravatar_id":"","url":"https://api.github.com/users/minggli","html_url":"https://github.com/minggli","followers_url":"https://api.github.com/users/minggli/followers","following_url":"https://api.github.com/users/minggli/following{/other_user}","gists_url":"https://api.github.com/users/minggli/gists{/gist_id}","starred_url":"https://api.github.com/users/minggli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggli/subscriptions","organizations_url":"https://api.github.com/users/minggli/orgs","repos_url":"https://api.github.com/users/minggli/repos","events_url":"https://api.github.com/users/minggli/events{/privacy}","received_events_url":"https://api.github.com/users/minggli/received_events","type":"User","site_admin":false},"repo":{"id":154968706,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ5Njg3MDY=","name":"virtualenv","full_name":"minggli/virtualenv","private":false,"owner":{"login":"minggli","id":14131823,"node_id":"MDQ6VXNlcjE0MTMxODIz","avatar_url":"https://avatars0.githubusercontent.com/u/14131823?v=4","gravatar_id":"","url":"https://api.github.com/users/minggli","html_url":"https://github.com/minggli","followers_url":"https://api.github.com/users/minggli/followers","following_url":"https://api.github.com/users/minggli/following{/other_user}","gists_url":"https://api.github.com/users/minggli/gists{/gist_id}","starred_url":"https://api.github.com/users/minggli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggli/subscriptions","organizations_url":"https://api.github.com/users/minggli/orgs","repos_url":"https://api.github.com/users/minggli/repos","events_url":"https://api.github.com/users/minggli/events{/privacy}","received_events_url":"https://api.github.com/users/minggli/received_events","type":"User","site_admin":false},"html_url":"https://github.com/minggli/virtualenv","description":"Virtual Python Environment builder","fork":true,"url":"https://api.github.com/repos/minggli/virtualenv","forks_url":"https://api.github.com/repos/minggli/virtualenv/forks","keys_url":"https://api.github.com/repos/minggli/virtualenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minggli/virtualenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minggli/virtualenv/teams","hooks_url":"https://api.github.com/repos/minggli/virtualenv/hooks","issue_events_url":"https://api.github.com/repos/minggli/virtualenv/issues/events{/number}","events_url":"https://api.github.com/repos/minggli/virtualenv/events","assignees_url":"https://api.github.com/repos/minggli/virtualenv/assignees{/user}","branches_url":"https://api.github.com/repos/minggli/virtualenv/branches{/branch}","tags_url":"https://api.github.com/repos/minggli/virtualenv/tags","blobs_url":"https://api.github.com/repos/minggli/virtualenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minggli/virtualenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minggli/virtualenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/minggli/virtualenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minggli/virtualenv/statuses/{sha}","languages_url":"https://api.github.com/repos/minggli/virtualenv/languages","stargazers_url":"https://api.github.com/repos/minggli/virtualenv/stargazers","contributors_url":"https://api.github.com/repos/minggli/virtualenv/contributors","subscribers_url":"https://api.github.com/repos/minggli/virtualenv/subscribers","subscription_url":"https://api.github.com/repos/minggli/virtualenv/subscription","commits_url":"https://api.github.com/repos/minggli/virtualenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/minggli/virtualenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/minggli/virtualenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/minggli/virtualenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/minggli/virtualenv/contents/{+path}","compare_url":"https://api.github.com/repos/minggli/virtualenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minggli/virtualenv/merges","archive_url":"https://api.github.com/repos/minggli/virtualenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minggli/virtualenv/downloads","issues_url":"https://api.github.com/repos/minggli/virtualenv/issues{/number}","pulls_url":"https://api.github.com/repos/minggli/virtualenv/pulls{/number}","milestones_url":"https://api.github.com/repos/minggli/virtualenv/milestones{/number}","notifications_url":"https://api.github.com/repos/minggli/virtualenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minggli/virtualenv/labels{/name}","releases_url":"https://api.github.com/repos/minggli/virtualenv/releases{/id}","deployments_url":"https://api.github.com/repos/minggli/virtualenv/deployments","created_at":"2018-10-27T13:40:27Z","updated_at":"2018-10-27T13:40:30Z","pushed_at":"2018-10-27T14:49:01Z","git_url":"git://github.com/minggli/virtualenv.git","ssh_url":"git@github.com:minggli/virtualenv.git","clone_url":"https://github.com/minggli/virtualenv.git","svn_url":"https://github.com/minggli/virtualenv","homepage":"virtualenv.pypa.io","size":64373,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pypa:master","ref":"master","sha":"bc13441adc3349cda0e925f1a935076827df3d64","user":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":1446474,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2NDc0","name":"virtualenv","full_name":"pypa/virtualenv","private":false,"owner":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pypa/virtualenv","description":"Virtual Python Environment builder","fork":false,"url":"https://api.github.com/repos/pypa/virtualenv","forks_url":"https://api.github.com/repos/pypa/virtualenv/forks","keys_url":"https://api.github.com/repos/pypa/virtualenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/virtualenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/virtualenv/teams","hooks_url":"https://api.github.com/repos/pypa/virtualenv/hooks","issue_events_url":"https://api.github.com/repos/pypa/virtualenv/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/virtualenv/events","assignees_url":"https://api.github.com/repos/pypa/virtualenv/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/virtualenv/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/virtualenv/tags","blobs_url":"https://api.github.com/repos/pypa/virtualenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/virtualenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/virtualenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/virtualenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/virtualenv/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/virtualenv/languages","stargazers_url":"https://api.github.com/repos/pypa/virtualenv/stargazers","contributors_url":"https://api.github.com/repos/pypa/virtualenv/contributors","subscribers_url":"https://api.github.com/repos/pypa/virtualenv/subscribers","subscription_url":"https://api.github.com/repos/pypa/virtualenv/subscription","commits_url":"https://api.github.com/repos/pypa/virtualenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/virtualenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/virtualenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/virtualenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/virtualenv/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/virtualenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/virtualenv/merges","archive_url":"https://api.github.com/repos/pypa/virtualenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/virtualenv/downloads","issues_url":"https://api.github.com/repos/pypa/virtualenv/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/virtualenv/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/virtualenv/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/virtualenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/virtualenv/labels{/name}","releases_url":"https://api.github.com/repos/pypa/virtualenv/releases{/id}","deployments_url":"https://api.github.com/repos/pypa/virtualenv/deployments","created_at":"2011-03-06T14:33:27Z","updated_at":"2018-10-27T12:31:30Z","pushed_at":"2018-10-27T14:49:02Z","git_url":"git://github.com/pypa/virtualenv.git","ssh_url":"git@github.com:pypa/virtualenv.git","clone_url":"https://github.com/pypa/virtualenv.git","svn_url":"https://github.com/pypa/virtualenv","homepage":"virtualenv.pypa.io","size":64397,"stargazers_count":2821,"watchers_count":2821,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":681,"mirror_url":null,"archived":false,"open_issues_count":452,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":681,"open_issues":452,"watchers":2821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/1231"},"html":{"href":"https://github.com/pypa/virtualenv/pull/1231"},"issue":{"href":"https://api.github.com/repos/pypa/virtualenv/issues/1231"},"comments":{"href":"https://api.github.com/repos/pypa/virtualenv/issues/1231/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/1231/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/1231/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/virtualenv/statuses/152de475b38c853a1cd8e0240010ee1c1cc4469b"}},"author_association":"NONE"}}
{"actor":{"display_login":"gaborbernat"}}