{"action":"created","comment":{"url":"https://api.github.com/repos/fog/fog-azure-rm/pulls/comments/229018631","pull_request_review_id":169418370,"id":229018631,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTAxODYzMQ==","diff_hunk":"@@ -0,0 +1,66 @@\n+module Fog\n+  module Compute\n+    class AzureRM\n+      # Real class for Compute Request\n+      class Real\n+        def list_virtual_machine_sizes(location, async = false)\n+          msg = 'Listing all VirtualMachineSize'\n+          Fog::Logger.debug msg\n+          begin\n+            if async\n+              response = @compute_mgmt_client.virtual_machine_sizes.list_async(location)\n+            else\n+              virtual_machine_sizes = @compute_mgmt_client.virtual_machine_sizes.list(location)\n+            end\n+          rescue MsRestAzure::AzureOperationError => e\n+            raise_azure_exception(e, msg)\n+          end\n+          if async\n+            response\n+          else\n+            Fog::Logger.debug 'VirtualMachineSizes listed successfully.'\n+            virtual_machine_sizes.value\n+          end\n+        end\n+      end\n+       # Mock class for Compute Request\n+      class Mock\n+        def list_virtual_machine_sizes(*)\n+          virtual_machine_sizes = [\n+            {\n+              'max_data_disk_count' => 1,\n+              'memory_in_mb' => 768,\n+              'name' => 'Standard_A0',\n+              'number_of_cores' => 1,\n+              'os_disk_size_in_mb' => 1047552,\n+              'resource_disk_size_in_mb' => 20480,\n+            }, {\n+              'max_data_disk_count' => 2,\n+              'memory_in_mb' => 1792,\n+              'name' => 'Standard_A1',\n+              'number_of_cores' => 1,\n+              'os_disk_size_in_mb'=> 1047552,\n+              'resource_disk_size_in_mb' => 71680,\n+            }, {\n+              'max_data_disk_count' => 4,\n+              'memory_in_mb' => 3584,\n+              'name' => 'Standard_A2',\n+              'number_of_cores' => 2,\n+              'os_disk_size_in_mb' => 1047552,","path":"lib/fog/azurerm/requests/compute/list_virtual_machine_sizes.rb","position":49,"original_position":49,"commit_id":"f52c14bdda4c2d2b0d71ed807ec687e4a2cc087b","original_commit_id":"f52c14bdda4c2d2b0d71ed807ec687e4a2cc087b","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.","created_at":"2018-10-29T17:12:36Z","updated_at":"2018-10-29T17:12:38Z","html_url":"https://github.com/fog/fog-azure-rm/pull/405#discussion_r229018631","pull_request_url":"https://api.github.com/repos/fog/fog-azure-rm/pulls/405","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/fog/fog-azure-rm/pulls/comments/229018631"},"html":{"href":"https://github.com/fog/fog-azure-rm/pull/405#discussion_r229018631"},"pull_request":{"href":"https://api.github.com/repos/fog/fog-azure-rm/pulls/405"}}},"pull_request":{"url":"https://api.github.com/repos/fog/fog-azure-rm/pulls/405","id":226642848,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjQyODQ4","html_url":"https://github.com/fog/fog-azure-rm/pull/405","diff_url":"https://github.com/fog/fog-azure-rm/pull/405.diff","patch_url":"https://github.com/fog/fog-azure-rm/pull/405.patch","issue_url":"https://api.github.com/repos/fog/fog-azure-rm/issues/405","number":405,"state":"open","locked":false,"title":"Feature/add list virtual machine sizes functionalitie","user":{"login":"KevinLoiseau","id":12276507,"node_id":"MDQ6VXNlcjEyMjc2NTA3","avatar_url":"https://avatars2.githubusercontent.com/u/12276507?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinLoiseau","html_url":"https://github.com/KevinLoiseau","followers_url":"https://api.github.com/users/KevinLoiseau/followers","following_url":"https://api.github.com/users/KevinLoiseau/following{/other_user}","gists_url":"https://api.github.com/users/KevinLoiseau/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinLoiseau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinLoiseau/subscriptions","organizations_url":"https://api.github.com/users/KevinLoiseau/orgs","repos_url":"https://api.github.com/users/KevinLoiseau/repos","events_url":"https://api.github.com/users/KevinLoiseau/events{/privacy}","received_events_url":"https://api.github.com/users/KevinLoiseau/received_events","type":"User","site_admin":false},"body":"Hi !\r\n\r\nThis PR implement the virtual machine size's listing, through request and model.\r\n\r\nThanks in advance for your time","created_at":"2018-10-29T17:11:27Z","updated_at":"2018-10-29T17:12:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15f656fd0d986f33b514e91fe657d61cddf386c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fog/fog-azure-rm/pulls/405/commits","review_comments_url":"https://api.github.com/repos/fog/fog-azure-rm/pulls/405/comments","review_comment_url":"https://api.github.com/repos/fog/fog-azure-rm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fog/fog-azure-rm/issues/405/comments","statuses_url":"https://api.github.com/repos/fog/fog-azure-rm/statuses/f52c14bdda4c2d2b0d71ed807ec687e4a2cc087b","head":{"label":"KevinLoiseau:feature/add_list_virtual_machine_sizes_functionalitie","ref":"feature/add_list_virtual_machine_sizes_functionalitie","sha":"f52c14bdda4c2d2b0d71ed807ec687e4a2cc087b","user":{"login":"KevinLoiseau","id":12276507,"node_id":"MDQ6VXNlcjEyMjc2NTA3","avatar_url":"https://avatars2.githubusercontent.com/u/12276507?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinLoiseau","html_url":"https://github.com/KevinLoiseau","followers_url":"https://api.github.com/users/KevinLoiseau/followers","following_url":"https://api.github.com/users/KevinLoiseau/following{/other_user}","gists_url":"https://api.github.com/users/KevinLoiseau/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinLoiseau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinLoiseau/subscriptions","organizations_url":"https://api.github.com/users/KevinLoiseau/orgs","repos_url":"https://api.github.com/users/KevinLoiseau/repos","events_url":"https://api.github.com/users/KevinLoiseau/events{/privacy}","received_events_url":"https://api.github.com/users/KevinLoiseau/received_events","type":"User","site_admin":false},"repo":{"id":60863087,"node_id":"MDEwOlJlcG9zaXRvcnk2MDg2MzA4Nw==","name":"fog-azure-rm","full_name":"KevinLoiseau/fog-azure-rm","private":false,"owner":{"login":"KevinLoiseau","id":12276507,"node_id":"MDQ6VXNlcjEyMjc2NTA3","avatar_url":"https://avatars2.githubusercontent.com/u/12276507?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinLoiseau","html_url":"https://github.com/KevinLoiseau","followers_url":"https://api.github.com/users/KevinLoiseau/followers","following_url":"https://api.github.com/users/KevinLoiseau/following{/other_user}","gists_url":"https://api.github.com/users/KevinLoiseau/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinLoiseau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinLoiseau/subscriptions","organizations_url":"https://api.github.com/users/KevinLoiseau/orgs","repos_url":"https://api.github.com/users/KevinLoiseau/repos","events_url":"https://api.github.com/users/KevinLoiseau/events{/privacy}","received_events_url":"https://api.github.com/users/KevinLoiseau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KevinLoiseau/fog-azure-rm","description":null,"fork":true,"url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm","forks_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/forks","keys_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/teams","hooks_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/hooks","issue_events_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/issues/events{/number}","events_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/events","assignees_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/assignees{/user}","branches_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/branches{/branch}","tags_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/tags","blobs_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/languages","stargazers_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/stargazers","contributors_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/contributors","subscribers_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/subscribers","subscription_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/subscription","commits_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/contents/{+path}","compare_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/merges","archive_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/downloads","issues_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/issues{/number}","pulls_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/labels{/name}","releases_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/releases{/id}","deployments_url":"https://api.github.com/repos/KevinLoiseau/fog-azure-rm/deployments","created_at":"2016-06-10T16:48:35Z","updated_at":"2018-10-01T12:14:46Z","pushed_at":"2018-10-29T17:09:22Z","git_url":"git://github.com/KevinLoiseau/fog-azure-rm.git","ssh_url":"git@github.com:KevinLoiseau/fog-azure-rm.git","clone_url":"https://github.com/KevinLoiseau/fog-azure-rm.git","svn_url":"https://github.com/KevinLoiseau/fog-azure-rm","homepage":null,"size":2445,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fog:master","ref":"master","sha":"1fde7d8227932461e5d9f4c79dd03215a58753a2","user":{"login":"fog","id":991149,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTE0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/991149?v=4","gravatar_id":"","url":"https://api.github.com/users/fog","html_url":"https://github.com/fog","followers_url":"https://api.github.com/users/fog/followers","following_url":"https://api.github.com/users/fog/following{/other_user}","gists_url":"https://api.github.com/users/fog/gists{/gist_id}","starred_url":"https://api.github.com/users/fog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fog/subscriptions","organizations_url":"https://api.github.com/users/fog/orgs","repos_url":"https://api.github.com/users/fog/repos","events_url":"https://api.github.com/users/fog/events{/privacy}","received_events_url":"https://api.github.com/users/fog/received_events","type":"Organization","site_admin":false},"repo":{"id":54466250,"node_id":"MDEwOlJlcG9zaXRvcnk1NDQ2NjI1MA==","name":"fog-azure-rm","full_name":"fog/fog-azure-rm","private":false,"owner":{"login":"fog","id":991149,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTE0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/991149?v=4","gravatar_id":"","url":"https://api.github.com/users/fog","html_url":"https://github.com/fog","followers_url":"https://api.github.com/users/fog/followers","following_url":"https://api.github.com/users/fog/following{/other_user}","gists_url":"https://api.github.com/users/fog/gists{/gist_id}","starred_url":"https://api.github.com/users/fog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fog/subscriptions","organizations_url":"https://api.github.com/users/fog/orgs","repos_url":"https://api.github.com/users/fog/repos","events_url":"https://api.github.com/users/fog/events{/privacy}","received_events_url":"https://api.github.com/users/fog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fog/fog-azure-rm","description":"Fog for Azure Resource Manager","fork":false,"url":"https://api.github.com/repos/fog/fog-azure-rm","forks_url":"https://api.github.com/repos/fog/fog-azure-rm/forks","keys_url":"https://api.github.com/repos/fog/fog-azure-rm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fog/fog-azure-rm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fog/fog-azure-rm/teams","hooks_url":"https://api.github.com/repos/fog/fog-azure-rm/hooks","issue_events_url":"https://api.github.com/repos/fog/fog-azure-rm/issues/events{/number}","events_url":"https://api.github.com/repos/fog/fog-azure-rm/events","assignees_url":"https://api.github.com/repos/fog/fog-azure-rm/assignees{/user}","branches_url":"https://api.github.com/repos/fog/fog-azure-rm/branches{/branch}","tags_url":"https://api.github.com/repos/fog/fog-azure-rm/tags","blobs_url":"https://api.github.com/repos/fog/fog-azure-rm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fog/fog-azure-rm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fog/fog-azure-rm/git/refs{/sha}","trees_url":"https://api.github.com/repos/fog/fog-azure-rm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fog/fog-azure-rm/statuses/{sha}","languages_url":"https://api.github.com/repos/fog/fog-azure-rm/languages","stargazers_url":"https://api.github.com/repos/fog/fog-azure-rm/stargazers","contributors_url":"https://api.github.com/repos/fog/fog-azure-rm/contributors","subscribers_url":"https://api.github.com/repos/fog/fog-azure-rm/subscribers","subscription_url":"https://api.github.com/repos/fog/fog-azure-rm/subscription","commits_url":"https://api.github.com/repos/fog/fog-azure-rm/commits{/sha}","git_commits_url":"https://api.github.com/repos/fog/fog-azure-rm/git/commits{/sha}","comments_url":"https://api.github.com/repos/fog/fog-azure-rm/comments{/number}","issue_comment_url":"https://api.github.com/repos/fog/fog-azure-rm/issues/comments{/number}","contents_url":"https://api.github.com/repos/fog/fog-azure-rm/contents/{+path}","compare_url":"https://api.github.com/repos/fog/fog-azure-rm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fog/fog-azure-rm/merges","archive_url":"https://api.github.com/repos/fog/fog-azure-rm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fog/fog-azure-rm/downloads","issues_url":"https://api.github.com/repos/fog/fog-azure-rm/issues{/number}","pulls_url":"https://api.github.com/repos/fog/fog-azure-rm/pulls{/number}","milestones_url":"https://api.github.com/repos/fog/fog-azure-rm/milestones{/number}","notifications_url":"https://api.github.com/repos/fog/fog-azure-rm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fog/fog-azure-rm/labels{/name}","releases_url":"https://api.github.com/repos/fog/fog-azure-rm/releases{/id}","deployments_url":"https://api.github.com/repos/fog/fog-azure-rm/deployments","created_at":"2016-03-22T10:26:42Z","updated_at":"2018-08-08T14:45:17Z","pushed_at":"2018-10-29T17:11:27Z","git_url":"git://github.com/fog/fog-azure-rm.git","ssh_url":"git@github.com:fog/fog-azure-rm.git","clone_url":"https://github.com/fog/fog-azure-rm.git","svn_url":"https://github.com/fog/fog-azure-rm","homepage":"","size":2362,"stargazers_count":20,"watchers_count":20,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":47,"open_issues":25,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fog/fog-azure-rm/pulls/405"},"html":{"href":"https://github.com/fog/fog-azure-rm/pull/405"},"issue":{"href":"https://api.github.com/repos/fog/fog-azure-rm/issues/405"},"comments":{"href":"https://api.github.com/repos/fog/fog-azure-rm/issues/405/comments"},"review_comments":{"href":"https://api.github.com/repos/fog/fog-azure-rm/pulls/405/comments"},"review_comment":{"href":"https://api.github.com/repos/fog/fog-azure-rm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fog/fog-azure-rm/pulls/405/commits"},"statuses":{"href":"https://api.github.com/repos/fog/fog-azure-rm/statuses/f52c14bdda4c2d2b0d71ed807ec687e4a2cc087b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}