{"action":"created","comment":{"url":"https://api.github.com/repos/gonum/gonum/pulls/comments/182646169","pull_request_review_id":113481707,"id":182646169,"diff_hunk":"@@ -0,0 +1,95 @@\n+// Copyright ©2018 The Gonum Authors. All rights reserved.","path":"internal/imports/import.go","position":1,"original_position":1,"commit_id":"80b5004a6d64f702e7680679bc6bee323aef54f1","original_commit_id":"2ec86da8dae6da36152d3bd271fe406907fcf5f2","user":{"login":"sbinet","id":1070920,"avatar_url":"https://avatars2.githubusercontent.com/u/1070920?v=4","gravatar_id":"","url":"https://api.github.com/users/sbinet","html_url":"https://github.com/sbinet","followers_url":"https://api.github.com/users/sbinet/followers","following_url":"https://api.github.com/users/sbinet/following{/other_user}","gists_url":"https://api.github.com/users/sbinet/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinet/subscriptions","organizations_url":"https://api.github.com/users/sbinet/orgs","repos_url":"https://api.github.com/users/sbinet/repos","events_url":"https://api.github.com/users/sbinet/events{/privacy}","received_events_url":"https://api.github.com/users/sbinet/received_events","type":"User","site_admin":false},"body":"My issue with putting that inside '.travis' is twofold:\r\n\r\n- it's only run during CI,\r\n- it's run very late, duplicated over all the various 'TAGS=xyz' variants we test against, essentially wasting a lot of resources.\r\n\r\nWhereas if it were to be run as part of regular 'go test', it could be caught much earlier, even *before* sending the PR.\r\n\r\nI agree, putting that test inside 'internal/imports' isn't ideal and that's why I initially put it at the 'gonum' top-level :)","created_at":"2018-04-19T06:40:46Z","updated_at":"2018-04-19T06:40:46Z","html_url":"https://github.com/gonum/gonum/pull/469#discussion_r182646169","pull_request_url":"https://api.github.com/repos/gonum/gonum/pulls/469","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gonum/gonum/pulls/comments/182646169"},"html":{"href":"https://github.com/gonum/gonum/pull/469#discussion_r182646169"},"pull_request":{"href":"https://api.github.com/repos/gonum/gonum/pulls/469"}},"in_reply_to_id":181683500},"pull_request":{"url":"https://api.github.com/repos/gonum/gonum/pulls/469","id":181803265,"html_url":"https://github.com/gonum/gonum/pull/469","diff_url":"https://github.com/gonum/gonum/pull/469.diff","patch_url":"https://github.com/gonum/gonum/pull/469.patch","issue_url":"https://api.github.com/repos/gonum/gonum/issues/469","number":469,"state":"open","locked":false,"title":"gonum,internal/imports: add check against imports of deprecated packages","user":{"login":"sbinet","id":1070920,"avatar_url":"https://avatars2.githubusercontent.com/u/1070920?v=4","gravatar_id":"","url":"https://api.github.com/users/sbinet","html_url":"https://github.com/sbinet","followers_url":"https://api.github.com/users/sbinet/followers","following_url":"https://api.github.com/users/sbinet/following{/other_user}","gists_url":"https://api.github.com/users/sbinet/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinet/subscriptions","organizations_url":"https://api.github.com/users/sbinet/orgs","repos_url":"https://api.github.com/users/sbinet/repos","events_url":"https://api.github.com/users/sbinet/events{/privacy}","received_events_url":"https://api.github.com/users/sbinet/received_events","type":"User","site_admin":false},"body":"This CL adds a check against Gonum packages importing deprecated or\r\nblacklisted packages.\r\n\r\nFixes gonum/gonum#467.\r\n\r\nPlease take a look.\r\n\r\n<!--\r\nChecklist:\r\n\r\n- API changes have been discussed\r\n- code is goformated correctly (goimports)\r\n- packages with generated code have had code generation run\r\n- tests pass locally\r\n- linked to relevant issues\r\n\r\nPlease make sure your commit message summary line and pull request\r\ntitle match the Go convention; a one-line summary of the change,\r\nprefixed by the primary affected package that should complete the\r\nsentence, \"This change modifies Gonum to _____.\"\r\n-->\r\n","created_at":"2018-04-16T09:36:38Z","updated_at":"2018-04-19T06:40:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67afdf5c1519e98a16d717a879473bbb040c86c1","assignee":{"login":"sbinet","id":1070920,"avatar_url":"https://avatars2.githubusercontent.com/u/1070920?v=4","gravatar_id":"","url":"https://api.github.com/users/sbinet","html_url":"https://github.com/sbinet","followers_url":"https://api.github.com/users/sbinet/followers","following_url":"https://api.github.com/users/sbinet/following{/other_user}","gists_url":"https://api.github.com/users/sbinet/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinet/subscriptions","organizations_url":"https://api.github.com/users/sbinet/orgs","repos_url":"https://api.github.com/users/sbinet/repos","events_url":"https://api.github.com/users/sbinet/events{/privacy}","received_events_url":"https://api.github.com/users/sbinet/received_events","type":"User","site_admin":false},"assignees":[{"login":"sbinet","id":1070920,"avatar_url":"https://avatars2.githubusercontent.com/u/1070920?v=4","gravatar_id":"","url":"https://api.github.com/users/sbinet","html_url":"https://github.com/sbinet","followers_url":"https://api.github.com/users/sbinet/followers","following_url":"https://api.github.com/users/sbinet/following{/other_user}","gists_url":"https://api.github.com/users/sbinet/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinet/subscriptions","organizations_url":"https://api.github.com/users/sbinet/orgs","repos_url":"https://api.github.com/users/sbinet/repos","events_url":"https://api.github.com/users/sbinet/events{/privacy}","received_events_url":"https://api.github.com/users/sbinet/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gonum/gonum/pulls/469/commits","review_comments_url":"https://api.github.com/repos/gonum/gonum/pulls/469/comments","review_comment_url":"https://api.github.com/repos/gonum/gonum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gonum/gonum/issues/469/comments","statuses_url":"https://api.github.com/repos/gonum/gonum/statuses/80b5004a6d64f702e7680679bc6bee323aef54f1","head":{"label":"sbinet-gonum:issue-467","ref":"issue-467","sha":"80b5004a6d64f702e7680679bc6bee323aef54f1","user":{"login":"sbinet-gonum","id":24896421,"avatar_url":"https://avatars1.githubusercontent.com/u/24896421?v=4","gravatar_id":"","url":"https://api.github.com/users/sbinet-gonum","html_url":"https://github.com/sbinet-gonum","followers_url":"https://api.github.com/users/sbinet-gonum/followers","following_url":"https://api.github.com/users/sbinet-gonum/following{/other_user}","gists_url":"https://api.github.com/users/sbinet-gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinet-gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinet-gonum/subscriptions","organizations_url":"https://api.github.com/users/sbinet-gonum/orgs","repos_url":"https://api.github.com/users/sbinet-gonum/repos","events_url":"https://api.github.com/users/sbinet-gonum/events{/privacy}","received_events_url":"https://api.github.com/users/sbinet-gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":92497590,"name":"gonum","full_name":"sbinet-gonum/gonum","owner":{"login":"sbinet-gonum","id":24896421,"avatar_url":"https://avatars1.githubusercontent.com/u/24896421?v=4","gravatar_id":"","url":"https://api.github.com/users/sbinet-gonum","html_url":"https://github.com/sbinet-gonum","followers_url":"https://api.github.com/users/sbinet-gonum/followers","following_url":"https://api.github.com/users/sbinet-gonum/following{/other_user}","gists_url":"https://api.github.com/users/sbinet-gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinet-gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinet-gonum/subscriptions","organizations_url":"https://api.github.com/users/sbinet-gonum/orgs","repos_url":"https://api.github.com/users/sbinet-gonum/repos","events_url":"https://api.github.com/users/sbinet-gonum/events{/privacy}","received_events_url":"https://api.github.com/users/sbinet-gonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbinet-gonum/gonum","description":"Gonum is a set of numeric libraries for the Go programming language. It contains libraries for matrices, statistics, optimization, and more","fork":true,"url":"https://api.github.com/repos/sbinet-gonum/gonum","forks_url":"https://api.github.com/repos/sbinet-gonum/gonum/forks","keys_url":"https://api.github.com/repos/sbinet-gonum/gonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbinet-gonum/gonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbinet-gonum/gonum/teams","hooks_url":"https://api.github.com/repos/sbinet-gonum/gonum/hooks","issue_events_url":"https://api.github.com/repos/sbinet-gonum/gonum/issues/events{/number}","events_url":"https://api.github.com/repos/sbinet-gonum/gonum/events","assignees_url":"https://api.github.com/repos/sbinet-gonum/gonum/assignees{/user}","branches_url":"https://api.github.com/repos/sbinet-gonum/gonum/branches{/branch}","tags_url":"https://api.github.com/repos/sbinet-gonum/gonum/tags","blobs_url":"https://api.github.com/repos/sbinet-gonum/gonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbinet-gonum/gonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbinet-gonum/gonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbinet-gonum/gonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbinet-gonum/gonum/statuses/{sha}","languages_url":"https://api.github.com/repos/sbinet-gonum/gonum/languages","stargazers_url":"https://api.github.com/repos/sbinet-gonum/gonum/stargazers","contributors_url":"https://api.github.com/repos/sbinet-gonum/gonum/contributors","subscribers_url":"https://api.github.com/repos/sbinet-gonum/gonum/subscribers","subscription_url":"https://api.github.com/repos/sbinet-gonum/gonum/subscription","commits_url":"https://api.github.com/repos/sbinet-gonum/gonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbinet-gonum/gonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbinet-gonum/gonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbinet-gonum/gonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbinet-gonum/gonum/contents/{+path}","compare_url":"https://api.github.com/repos/sbinet-gonum/gonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbinet-gonum/gonum/merges","archive_url":"https://api.github.com/repos/sbinet-gonum/gonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbinet-gonum/gonum/downloads","issues_url":"https://api.github.com/repos/sbinet-gonum/gonum/issues{/number}","pulls_url":"https://api.github.com/repos/sbinet-gonum/gonum/pulls{/number}","milestones_url":"https://api.github.com/repos/sbinet-gonum/gonum/milestones{/number}","notifications_url":"https://api.github.com/repos/sbinet-gonum/gonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbinet-gonum/gonum/labels{/name}","releases_url":"https://api.github.com/repos/sbinet-gonum/gonum/releases{/id}","deployments_url":"https://api.github.com/repos/sbinet-gonum/gonum/deployments","created_at":"2017-05-26T09:58:40Z","updated_at":"2017-05-26T09:58:44Z","pushed_at":"2018-04-16T11:34:09Z","git_url":"git://github.com/sbinet-gonum/gonum.git","ssh_url":"git@github.com:sbinet-gonum/gonum.git","clone_url":"https://github.com/sbinet-gonum/gonum.git","svn_url":"https://github.com/sbinet-gonum/gonum","homepage":null,"size":10752,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gonum:master","ref":"master","sha":"cb2511e4c8995b79a7be1a6a8c7dc8ae7a9bb2e0","user":{"login":"gonum","id":3771091,"avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":86164982,"name":"gonum","full_name":"gonum/gonum","owner":{"login":"gonum","id":3771091,"avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gonum/gonum","description":"Gonum is a set of numeric libraries for the Go programming language. It contains libraries for matrices, statistics, optimization, and more","fork":false,"url":"https://api.github.com/repos/gonum/gonum","forks_url":"https://api.github.com/repos/gonum/gonum/forks","keys_url":"https://api.github.com/repos/gonum/gonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonum/gonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonum/gonum/teams","hooks_url":"https://api.github.com/repos/gonum/gonum/hooks","issue_events_url":"https://api.github.com/repos/gonum/gonum/issues/events{/number}","events_url":"https://api.github.com/repos/gonum/gonum/events","assignees_url":"https://api.github.com/repos/gonum/gonum/assignees{/user}","branches_url":"https://api.github.com/repos/gonum/gonum/branches{/branch}","tags_url":"https://api.github.com/repos/gonum/gonum/tags","blobs_url":"https://api.github.com/repos/gonum/gonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonum/gonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonum/gonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonum/gonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonum/gonum/statuses/{sha}","languages_url":"https://api.github.com/repos/gonum/gonum/languages","stargazers_url":"https://api.github.com/repos/gonum/gonum/stargazers","contributors_url":"https://api.github.com/repos/gonum/gonum/contributors","subscribers_url":"https://api.github.com/repos/gonum/gonum/subscribers","subscription_url":"https://api.github.com/repos/gonum/gonum/subscription","commits_url":"https://api.github.com/repos/gonum/gonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonum/gonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonum/gonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonum/gonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonum/gonum/contents/{+path}","compare_url":"https://api.github.com/repos/gonum/gonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonum/gonum/merges","archive_url":"https://api.github.com/repos/gonum/gonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonum/gonum/downloads","issues_url":"https://api.github.com/repos/gonum/gonum/issues{/number}","pulls_url":"https://api.github.com/repos/gonum/gonum/pulls{/number}","milestones_url":"https://api.github.com/repos/gonum/gonum/milestones{/number}","notifications_url":"https://api.github.com/repos/gonum/gonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonum/gonum/labels{/name}","releases_url":"https://api.github.com/repos/gonum/gonum/releases{/id}","deployments_url":"https://api.github.com/repos/gonum/gonum/deployments","created_at":"2017-03-25T14:54:38Z","updated_at":"2018-04-19T02:16:39Z","pushed_at":"2018-04-18T20:40:49Z","git_url":"git://github.com/gonum/gonum.git","ssh_url":"git@github.com:gonum/gonum.git","clone_url":"https://github.com/gonum/gonum.git","svn_url":"https://github.com/gonum/gonum","homepage":"https://www.gonum.org/","size":10926,"stargazers_count":1592,"watchers_count":1592,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":95,"open_issues":101,"watchers":1592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gonum/gonum/pulls/469"},"html":{"href":"https://github.com/gonum/gonum/pull/469"},"issue":{"href":"https://api.github.com/repos/gonum/gonum/issues/469"},"comments":{"href":"https://api.github.com/repos/gonum/gonum/issues/469/comments"},"review_comments":{"href":"https://api.github.com/repos/gonum/gonum/pulls/469/comments"},"review_comment":{"href":"https://api.github.com/repos/gonum/gonum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gonum/gonum/pulls/469/commits"},"statuses":{"href":"https://api.github.com/repos/gonum/gonum/statuses/80b5004a6d64f702e7680679bc6bee323aef54f1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sbinet"}}