{"action":"closed","number":14427,"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14427","id":187647521,"html_url":"https://github.com/home-assistant/home-assistant/pull/14427","diff_url":"https://github.com/home-assistant/home-assistant/pull/14427.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/14427.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/14427","number":14427,"state":"closed","locked":false,"title":"Add generic thermostat AC entity config","user":{"login":"akking","id":10442067,"avatar_url":"https://avatars1.githubusercontent.com/u/10442067?v=4","gravatar_id":"","url":"https://api.github.com/users/akking","html_url":"https://github.com/akking","followers_url":"https://api.github.com/users/akking/followers","following_url":"https://api.github.com/users/akking/following{/other_user}","gists_url":"https://api.github.com/users/akking/gists{/gist_id}","starred_url":"https://api.github.com/users/akking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akking/subscriptions","organizations_url":"https://api.github.com/users/akking/orgs","repos_url":"https://api.github.com/users/akking/repos","events_url":"https://api.github.com/users/akking/events{/privacy}","received_events_url":"https://api.github.com/users/akking/received_events","type":"User","site_admin":false},"body":"## Description:\r\nAdd a separate configuration for AC entity so that 'heater' entity is always 'heater'.\r\nThe config for 'ac_mode' is used for initial operation mode.\r\n\r\n**Related issue (if applicable):** None\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#5360\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\n\r\n```\r\n\r\n## Checklist:\r\n  - [ ] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [x] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-05-13T01:18:02Z","updated_at":"2018-05-22T21:56:41Z","closed_at":"2018-05-22T21:56:41Z","merged_at":null,"merge_commit_sha":"a443f06ef54a1fe8d0538aba12d17212874115ff","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Danielhiversen","id":650502,"avatar_url":"https://avatars0.githubusercontent.com/u/650502?v=4","gravatar_id":"","url":"https://api.github.com/users/Danielhiversen","html_url":"https://github.com/Danielhiversen","followers_url":"https://api.github.com/users/Danielhiversen/followers","following_url":"https://api.github.com/users/Danielhiversen/following{/other_user}","gists_url":"https://api.github.com/users/Danielhiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/Danielhiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danielhiversen/subscriptions","organizations_url":"https://api.github.com/users/Danielhiversen/orgs","repos_url":"https://api.github.com/users/Danielhiversen/repos","events_url":"https://api.github.com/users/Danielhiversen/events{/privacy}","received_events_url":"https://api.github.com/users/Danielhiversen/received_events","type":"User","site_admin":false},{"login":"syssi","id":2735933,"avatar_url":"https://avatars3.githubusercontent.com/u/2735933?v=4","gravatar_id":"","url":"https://api.github.com/users/syssi","html_url":"https://github.com/syssi","followers_url":"https://api.github.com/users/syssi/followers","following_url":"https://api.github.com/users/syssi/following{/other_user}","gists_url":"https://api.github.com/users/syssi/gists{/gist_id}","starred_url":"https://api.github.com/users/syssi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syssi/subscriptions","organizations_url":"https://api.github.com/users/syssi/orgs","repos_url":"https://api.github.com/users/syssi/repos","events_url":"https://api.github.com/users/syssi/events{/privacy}","received_events_url":"https://api.github.com/users/syssi/received_events","type":"User","site_admin":false},{"login":"kellerza","id":6756881,"avatar_url":"https://avatars3.githubusercontent.com/u/6756881?v=4","gravatar_id":"","url":"https://api.github.com/users/kellerza","html_url":"https://github.com/kellerza","followers_url":"https://api.github.com/users/kellerza/followers","following_url":"https://api.github.com/users/kellerza/following{/other_user}","gists_url":"https://api.github.com/users/kellerza/gists{/gist_id}","starred_url":"https://api.github.com/users/kellerza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellerza/subscriptions","organizations_url":"https://api.github.com/users/kellerza/orgs","repos_url":"https://api.github.com/users/kellerza/repos","events_url":"https://api.github.com/users/kellerza/events{/privacy}","received_events_url":"https://api.github.com/users/kellerza/received_events","type":"User","site_admin":false},{"login":"amelchio","id":26174915,"avatar_url":"https://avatars3.githubusercontent.com/u/26174915?v=4","gravatar_id":"","url":"https://api.github.com/users/amelchio","html_url":"https://github.com/amelchio","followers_url":"https://api.github.com/users/amelchio/followers","following_url":"https://api.github.com/users/amelchio/following{/other_user}","gists_url":"https://api.github.com/users/amelchio/gists{/gist_id}","starred_url":"https://api.github.com/users/amelchio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amelchio/subscriptions","organizations_url":"https://api.github.com/users/amelchio/orgs","repos_url":"https://api.github.com/users/amelchio/repos","events_url":"https://api.github.com/users/amelchio/events{/privacy}","received_events_url":"https://api.github.com/users/amelchio/received_events","type":"User","site_admin":false},{"login":"cdce8p","id":30130371,"avatar_url":"https://avatars2.githubusercontent.com/u/30130371?v=4","gravatar_id":"","url":"https://api.github.com/users/cdce8p","html_url":"https://github.com/cdce8p","followers_url":"https://api.github.com/users/cdce8p/followers","following_url":"https://api.github.com/users/cdce8p/following{/other_user}","gists_url":"https://api.github.com/users/cdce8p/gists{/gist_id}","starred_url":"https://api.github.com/users/cdce8p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdce8p/subscriptions","organizations_url":"https://api.github.com/users/cdce8p/orgs","repos_url":"https://api.github.com/users/cdce8p/repos","events_url":"https://api.github.com/users/cdce8p/events{/privacy}","received_events_url":"https://api.github.com/users/cdce8p/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"Core","id":2410391,"slug":"core","description":"Developers with knowledge of the Home Assistant core","privacy":"closed","url":"https://api.github.com/teams/2410391","members_url":"https://api.github.com/teams/2410391/members{/member}","repositories_url":"https://api.github.com/teams/2410391/repos","permission":"pull"}],"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":529619247,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20climate.generic_thermostat","name":"platform: climate.generic_thermostat","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14427/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14427/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/14427/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/9cce921feabc79c80db6ffb8154bf7e8d4f1e98a","head":{"label":"akking:dev","ref":"dev","sha":"9cce921feabc79c80db6ffb8154bf7e8d4f1e98a","user":{"login":"akking","id":10442067,"avatar_url":"https://avatars1.githubusercontent.com/u/10442067?v=4","gravatar_id":"","url":"https://api.github.com/users/akking","html_url":"https://github.com/akking","followers_url":"https://api.github.com/users/akking/followers","following_url":"https://api.github.com/users/akking/following{/other_user}","gists_url":"https://api.github.com/users/akking/gists{/gist_id}","starred_url":"https://api.github.com/users/akking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akking/subscriptions","organizations_url":"https://api.github.com/users/akking/orgs","repos_url":"https://api.github.com/users/akking/repos","events_url":"https://api.github.com/users/akking/events{/privacy}","received_events_url":"https://api.github.com/users/akking/received_events","type":"User","site_admin":false},"repo":{"id":133190865,"name":"home-assistant","full_name":"akking/home-assistant","owner":{"login":"akking","id":10442067,"avatar_url":"https://avatars1.githubusercontent.com/u/10442067?v=4","gravatar_id":"","url":"https://api.github.com/users/akking","html_url":"https://github.com/akking","followers_url":"https://api.github.com/users/akking/followers","following_url":"https://api.github.com/users/akking/following{/other_user}","gists_url":"https://api.github.com/users/akking/gists{/gist_id}","starred_url":"https://api.github.com/users/akking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akking/subscriptions","organizations_url":"https://api.github.com/users/akking/orgs","repos_url":"https://api.github.com/users/akking/repos","events_url":"https://api.github.com/users/akking/events{/privacy}","received_events_url":"https://api.github.com/users/akking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akking/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/akking/home-assistant","forks_url":"https://api.github.com/repos/akking/home-assistant/forks","keys_url":"https://api.github.com/repos/akking/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akking/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akking/home-assistant/teams","hooks_url":"https://api.github.com/repos/akking/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/akking/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/akking/home-assistant/events","assignees_url":"https://api.github.com/repos/akking/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/akking/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/akking/home-assistant/tags","blobs_url":"https://api.github.com/repos/akking/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akking/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akking/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/akking/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akking/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/akking/home-assistant/languages","stargazers_url":"https://api.github.com/repos/akking/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/akking/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/akking/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/akking/home-assistant/subscription","commits_url":"https://api.github.com/repos/akking/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/akking/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/akking/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/akking/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/akking/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/akking/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akking/home-assistant/merges","archive_url":"https://api.github.com/repos/akking/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akking/home-assistant/downloads","issues_url":"https://api.github.com/repos/akking/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/akking/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/akking/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/akking/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akking/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/akking/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/akking/home-assistant/deployments","created_at":"2018-05-12T23:32:03Z","updated_at":"2018-05-22T21:29:08Z","pushed_at":"2018-05-22T21:28:57Z","git_url":"git://github.com/akking/home-assistant.git","ssh_url":"git@github.com:akking/home-assistant.git","clone_url":"https://github.com/akking/home-assistant.git","svn_url":"https://github.com/akking/home-assistant","homepage":"https://home-assistant.io","size":82102,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"ea2c0736123f3445c7183cf7f0a097da6374d302","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-05-22T20:50:00Z","pushed_at":"2018-05-22T21:29:03Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":82391,"stargazers_count":14384,"watchers_count":14384,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4276,"mirror_url":null,"archived":false,"open_issues_count":832,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4276,"open_issues":832,"watchers":14384,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14427"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/14427"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/14427"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/14427/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14427/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14427/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/9cce921feabc79c80db6ffb8154bf7e8d4f1e98a"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":19,"maintainer_can_modify":false,"commits":112,"additions":3877,"deletions":1231,"changed_files":178}}
{"actor":{"display_login":"akking"}}