{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/211769412","pull_request_review_id":148262553,"id":211769412,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTc2OTQxMg==","diff_hunk":"@@ -105,11 +110,24 @@ class _CombiningGestureArenaMember extends GestureArenaMember {\n /// the horizontal nor vertical drag recognizers can claim victory) the tap\n /// recognizer still actually wins, despite being in the team.\n ///\n+/// [AndroidView] is using a team with a captain to decide which gestures are\n+/// forwarded to the native view. For example if we want to forward taps and\n+/// vertical scrolls to a native Android view, [TapGestureRecognizers] and\n+/// [VerticalDragGestureRecognizer] are added to a team with a captain, once the\n+/// captain wins then gesture is forwarded to the Android view.","path":"packages/flutter/lib/src/gestures/team.dart","position":52,"original_position":52,"commit_id":"d9ecfef4f2ece13067af8ed0cbd25c5a577bc94f","original_commit_id":"d9ecfef4f2ece13067af8ed0cbd25c5a577bc94f","user":{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"this is good as far as it goes but it doesn't answer the question of why it uses a captain.","created_at":"2018-08-21T21:41:14Z","updated_at":"2018-08-21T21:41:15Z","html_url":"https://github.com/flutter/flutter/pull/20883#discussion_r211769412","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/20883","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/211769412"},"html":{"href":"https://github.com/flutter/flutter/pull/20883#discussion_r211769412"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/20883"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/20883","id":209955032,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTU1MDMy","html_url":"https://github.com/flutter/flutter/pull/20883","diff_url":"https://github.com/flutter/flutter/pull/20883.diff","patch_url":"https://github.com/flutter/flutter/pull/20883.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/20883","number":20883,"state":"open","locked":false,"title":"Add support for GestureArenaTeam captains.","user":{"login":"amirh","id":1024117,"node_id":"MDQ6VXNlcjEwMjQxMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1024117?v=4","gravatar_id":"","url":"https://api.github.com/users/amirh","html_url":"https://github.com/amirh","followers_url":"https://api.github.com/users/amirh/followers","following_url":"https://api.github.com/users/amirh/following{/other_user}","gists_url":"https://api.github.com/users/amirh/gists{/gist_id}","starred_url":"https://api.github.com/users/amirh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirh/subscriptions","organizations_url":"https://api.github.com/users/amirh/orgs","repos_url":"https://api.github.com/users/amirh/repos","events_url":"https://api.github.com/users/amirh/events{/privacy}","received_events_url":"https://api.github.com/users/amirh/received_events","type":"User","site_admin":false},"body":"*I apologize for adding more metaphors here, please do let me know if you have a better way to express this than as a captain.*\r\n\r\nThe team captain wins the arena on behalf of the team.\r\nWhen any of the team members claims victory for the arena the captain\r\naccepts the gesture.\r\n\r\nThis is used when embeddeding platform views - we allow configuring a\r\nset of gestures that should be forwarded to the platform view.\r\nWe add the set of gesture recognizers to a GestureArenaTeam with a\r\ncaptain, and if the captain accepts the gesture we forward it to the\r\nplatform view.","created_at":"2018-08-21T21:02:45Z","updated_at":"2018-08-21T21:41:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b15881715ca57d83f3a32e1dbfe919c3eddb0b23","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/20883/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/20883/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/20883/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/d9ecfef4f2ece13067af8ed0cbd25c5a577bc94f","head":{"label":"amirh:gesture_team_captains","ref":"gesture_team_captains","sha":"d9ecfef4f2ece13067af8ed0cbd25c5a577bc94f","user":{"login":"amirh","id":1024117,"node_id":"MDQ6VXNlcjEwMjQxMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1024117?v=4","gravatar_id":"","url":"https://api.github.com/users/amirh","html_url":"https://github.com/amirh","followers_url":"https://api.github.com/users/amirh/followers","following_url":"https://api.github.com/users/amirh/following{/other_user}","gists_url":"https://api.github.com/users/amirh/gists{/gist_id}","starred_url":"https://api.github.com/users/amirh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirh/subscriptions","organizations_url":"https://api.github.com/users/amirh/orgs","repos_url":"https://api.github.com/users/amirh/repos","events_url":"https://api.github.com/users/amirh/events{/privacy}","received_events_url":"https://api.github.com/users/amirh/received_events","type":"User","site_admin":false},"repo":{"id":78148410,"node_id":"MDEwOlJlcG9zaXRvcnk3ODE0ODQxMA==","name":"flutter","full_name":"amirh/flutter","owner":{"login":"amirh","id":1024117,"node_id":"MDQ6VXNlcjEwMjQxMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1024117?v=4","gravatar_id":"","url":"https://api.github.com/users/amirh","html_url":"https://github.com/amirh","followers_url":"https://api.github.com/users/amirh/followers","following_url":"https://api.github.com/users/amirh/following{/other_user}","gists_url":"https://api.github.com/users/amirh/gists{/gist_id}","starred_url":"https://api.github.com/users/amirh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirh/subscriptions","organizations_url":"https://api.github.com/users/amirh/orgs","repos_url":"https://api.github.com/users/amirh/repos","events_url":"https://api.github.com/users/amirh/events{/privacy}","received_events_url":"https://api.github.com/users/amirh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amirh/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/amirh/flutter","forks_url":"https://api.github.com/repos/amirh/flutter/forks","keys_url":"https://api.github.com/repos/amirh/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amirh/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amirh/flutter/teams","hooks_url":"https://api.github.com/repos/amirh/flutter/hooks","issue_events_url":"https://api.github.com/repos/amirh/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/amirh/flutter/events","assignees_url":"https://api.github.com/repos/amirh/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/amirh/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/amirh/flutter/tags","blobs_url":"https://api.github.com/repos/amirh/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amirh/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amirh/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/amirh/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amirh/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/amirh/flutter/languages","stargazers_url":"https://api.github.com/repos/amirh/flutter/stargazers","contributors_url":"https://api.github.com/repos/amirh/flutter/contributors","subscribers_url":"https://api.github.com/repos/amirh/flutter/subscribers","subscription_url":"https://api.github.com/repos/amirh/flutter/subscription","commits_url":"https://api.github.com/repos/amirh/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/amirh/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/amirh/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/amirh/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/amirh/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/amirh/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amirh/flutter/merges","archive_url":"https://api.github.com/repos/amirh/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amirh/flutter/downloads","issues_url":"https://api.github.com/repos/amirh/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/amirh/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/amirh/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/amirh/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amirh/flutter/labels{/name}","releases_url":"https://api.github.com/repos/amirh/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/amirh/flutter/deployments","created_at":"2017-01-05T21:08:15Z","updated_at":"2017-10-31T16:35:14Z","pushed_at":"2018-08-21T21:03:23Z","git_url":"git://github.com/amirh/flutter.git","ssh_url":"git@github.com:amirh/flutter.git","clone_url":"https://github.com/amirh/flutter.git","svn_url":"https://github.com/amirh/flutter","homepage":"https://flutter.io","size":44598,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"94f9604a969d6343de76543599d5fd21978f3de8","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-08-21T21:39:15Z","pushed_at":"2018-08-21T21:23:25Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":44547,"stargazers_count":35622,"watchers_count":35622,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3320,"mirror_url":null,"archived":false,"open_issues_count":3727,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3320,"open_issues":3727,"watchers":35622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/20883"},"html":{"href":"https://github.com/flutter/flutter/pull/20883"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/20883"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/20883/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/20883/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/20883/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/d9ecfef4f2ece13067af8ed0cbd25c5a577bc94f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Hixie"}}