{"action":"created","issue":{"url":"https://api.github.com/repos/jruby/jruby/issues/4150","repository_url":"https://api.github.com/repos/jruby/jruby","labels_url":"https://api.github.com/repos/jruby/jruby/issues/4150/labels{/name}","comments_url":"https://api.github.com/repos/jruby/jruby/issues/4150/comments","events_url":"https://api.github.com/repos/jruby/jruby/issues/4150/events","html_url":"https://github.com/jruby/jruby/issues/4150","id":176446886,"number":4150,"title":"Web Scraping with 9.1.5.0 much much slower than 9.0.4.0","user":{"login":"asdf1337","id":7471865,"avatar_url":"https://avatars3.githubusercontent.com/u/7471865?v=4","gravatar_id":"","url":"https://api.github.com/users/asdf1337","html_url":"https://github.com/asdf1337","followers_url":"https://api.github.com/users/asdf1337/followers","following_url":"https://api.github.com/users/asdf1337/following{/other_user}","gists_url":"https://api.github.com/users/asdf1337/gists{/gist_id}","starred_url":"https://api.github.com/users/asdf1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asdf1337/subscriptions","organizations_url":"https://api.github.com/users/asdf1337/orgs","repos_url":"https://api.github.com/users/asdf1337/repos","events_url":"https://api.github.com/users/asdf1337/events{/privacy}","received_events_url":"https://api.github.com/users/asdf1337/received_events","type":"User","site_admin":false},"labels":[{"id":156307290,"url":"https://api.github.com/repos/jruby/jruby/labels/JRuby%209000","name":"JRuby 9000","color":"bfe5bf","default":false},{"id":21197924,"url":"https://api.github.com/repos/jruby/jruby/labels/performance","name":"performance","color":"009800","default":false},{"id":302705246,"url":"https://api.github.com/repos/jruby/jruby/labels/regression","name":"regression","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jruby/jruby/milestones/72","html_url":"https://github.com/jruby/jruby/milestone/72","labels_url":"https://api.github.com/repos/jruby/jruby/milestones/72/labels","id":3346806,"number":72,"title":"JRuby 9.2.1.0","description":"","creator":{"login":"headius","id":10135,"avatar_url":"https://avatars3.githubusercontent.com/u/10135?v=4","gravatar_id":"","url":"https://api.github.com/users/headius","html_url":"https://github.com/headius","followers_url":"https://api.github.com/users/headius/followers","following_url":"https://api.github.com/users/headius/following{/other_user}","gists_url":"https://api.github.com/users/headius/gists{/gist_id}","starred_url":"https://api.github.com/users/headius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/headius/subscriptions","organizations_url":"https://api.github.com/users/headius/orgs","repos_url":"https://api.github.com/users/headius/repos","events_url":"https://api.github.com/users/headius/events{/privacy}","received_events_url":"https://api.github.com/users/headius/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":1,"state":"open","created_at":"2018-05-14T21:04:50Z","updated_at":"2018-05-15T21:24:19Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-09-12T18:21:31Z","updated_at":"2018-05-15T21:45:48Z","closed_at":null,"author_association":"NONE","body":"### Environment\n- JRuby-9.0.4.0 & JRuby-9.1.5.0\n- Ubuntu 16\n\nTried using both OpenURI as well as Manticore for HTTP get requests. Same results.\n### Expected Behavior\n\nScraping around 200,000 pages with many threads.\nUsing 9.0.40 it is very fast.\n![Image of 9.0.4.0](http://i.imgur.com/90xT6LU.png)\n### Actual Behavior\n\nWhen I switch to any newer version of JRuby the performance hit is huge.\nThe code I am running is exactly the same.\n![Image of 9.0.4.0](http://i.imgur.com/UvX701b.png)\n\n---\n\nI'd love to start using a more up to date version of this amazing project,\nbut this huge issue is preventing me from upgrading.\n\nI know I'm probably not sharing enough information to help much but I'm not sure what would be useful.\nPlease let me know what else I should provide and I will do my best.\n\nThank you.\n"},"comment":{"url":"https://api.github.com/repos/jruby/jruby/issues/comments/389323753","html_url":"https://github.com/jruby/jruby/issues/4150#issuecomment-389323753","issue_url":"https://api.github.com/repos/jruby/jruby/issues/4150","id":389323753,"user":{"login":"JasonLunn","id":778854,"avatar_url":"https://avatars2.githubusercontent.com/u/778854?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonLunn","html_url":"https://github.com/JasonLunn","followers_url":"https://api.github.com/users/JasonLunn/followers","following_url":"https://api.github.com/users/JasonLunn/following{/other_user}","gists_url":"https://api.github.com/users/JasonLunn/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonLunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonLunn/subscriptions","organizations_url":"https://api.github.com/users/JasonLunn/orgs","repos_url":"https://api.github.com/users/JasonLunn/repos","events_url":"https://api.github.com/users/JasonLunn/events{/privacy}","received_events_url":"https://api.github.com/users/JasonLunn/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T21:45:48Z","updated_at":"2018-05-15T21:45:48Z","author_association":"NONE","body":"I don't know if it there is still a performance degradation because we implemented a workaround (described above) in our application some time ago and it remains in place today. It consists of an initializer in our rails app that defines a constant:\r\n\r\n```ruby\r\nCERTIFICATE_STORE = OpenSSL::X509::Store.new.freeze\r\nCERTIFICATE_STORE.set_default_paths\r\n```\r\n\r\nIn every place where we use `HTTParty` to make outbound connections, we pass in the parameter constant as the value of the `cert_store` parameter like so:\r\n\r\n```ruby\r\nHTTParty.get url, cert_store: CERTIFICATE_STORE\r\n```\r\n\r\nIn every place where we use `RestClient`, we use a similar strategy:\r\n\r\n```ruby\r\nRestClient::Request.execute method: :get, url: url, ssl_cert_store: CERTIFICATE_STORE\r\n```\r\n\r\nI still believe this issue is related to jruby/jruby-openssl/issues/111 - I haven't tried dropping the workarounds since that issue remains open."}}
{"actor":{"display_login":"JasonLunn"}}