{"action":"created","comment":{"url":"https://api.github.com/repos/tikv/tikv/pulls/comments/211225931","pull_request_review_id":147600280,"id":211225931,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTIyNTkzMQ==","diff_hunk":"@@ -140,7 +152,11 @@ impl Progress {\n     }\n }\n \n-pub enum Task {\n+pub struct Task {","path":"src/raftstore/store/worker/read.rs","position":45,"original_position":45,"commit_id":"8d06815ac7f28eda7b8f6e91beb1cc1789714203","original_commit_id":"8d06815ac7f28eda7b8f6e91beb1cc1789714203","user":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"body":"To hide its detail.","created_at":"2018-08-20T11:18:18Z","updated_at":"2018-08-20T11:18:18Z","html_url":"https://github.com/tikv/tikv/pull/3443#discussion_r211225931","pull_request_url":"https://api.github.com/repos/tikv/tikv/pulls/3443","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tikv/tikv/pulls/comments/211225931"},"html":{"href":"https://github.com/tikv/tikv/pull/3443#discussion_r211225931"},"pull_request":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3443"}},"in_reply_to_id":211211559},"pull_request":{"url":"https://api.github.com/repos/tikv/tikv/pulls/3443","id":207949397,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTQ5Mzk3","html_url":"https://github.com/tikv/tikv/pull/3443","diff_url":"https://github.com/tikv/tikv/pull/3443.diff","patch_url":"https://github.com/tikv/tikv/pull/3443.patch","issue_url":"https://api.github.com/repos/tikv/tikv/issues/3443","number":3443,"state":"open","locked":false,"title":"raftstore: an efficient workflow for localreader","user":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"body":"## What have you changed? (mandatory)\r\n\r\nThis PR optimizes local reader's workflow that saves unnecessary lease check(makes a syscall), and reuse snapshots for requests in the same batch.\r\n\r\n## What are the type of the changes? (mandatory)\r\n\r\n- Improvement (non-breaking change which is an improvement to an existing feature)\r\n\r\n## How has this PR been tested? (mandatory)\r\n\r\nunit tests and integration tests.\r\n\r\n## Does this PR affect documentation (docs/docs-cn) update? (mandatory)\r\n\r\nNo.\r\n\r\n## Does this PR affect tidb-ansible update? (mandatory)\r\n\r\nNo.\r\n\r\n## Refer to a related PR or issue link (optional)\r\n\r\n#2639 \r\n\r\n## Benchmark result if necessary (optional)\r\n\r\nQPS improved about 16.5%, from 207211 to 241526.9.\r\n\r\n## Add a few positive/negative examples (optional)\r\n\r\nNo.","created_at":"2018-08-13T11:36:54Z","updated_at":"2018-08-20T11:18:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"121e612f453801f6364762eefd6e06aae959406e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tikv/tikv/pulls/3443/commits","review_comments_url":"https://api.github.com/repos/tikv/tikv/pulls/3443/comments","review_comment_url":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tikv/tikv/issues/3443/comments","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/8d06815ac7f28eda7b8f6e91beb1cc1789714203","head":{"label":"overvenus:efficient-reader","ref":"efficient-reader","sha":"8d06815ac7f28eda7b8f6e91beb1cc1789714203","user":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"repo":{"id":58031891,"node_id":"MDEwOlJlcG9zaXRvcnk1ODAzMTg5MQ==","name":"tikv","full_name":"overvenus/tikv","owner":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/overvenus/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":true,"url":"https://api.github.com/repos/overvenus/tikv","forks_url":"https://api.github.com/repos/overvenus/tikv/forks","keys_url":"https://api.github.com/repos/overvenus/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/overvenus/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/overvenus/tikv/teams","hooks_url":"https://api.github.com/repos/overvenus/tikv/hooks","issue_events_url":"https://api.github.com/repos/overvenus/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/overvenus/tikv/events","assignees_url":"https://api.github.com/repos/overvenus/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/overvenus/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/overvenus/tikv/tags","blobs_url":"https://api.github.com/repos/overvenus/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/overvenus/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/overvenus/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/overvenus/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/overvenus/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/overvenus/tikv/languages","stargazers_url":"https://api.github.com/repos/overvenus/tikv/stargazers","contributors_url":"https://api.github.com/repos/overvenus/tikv/contributors","subscribers_url":"https://api.github.com/repos/overvenus/tikv/subscribers","subscription_url":"https://api.github.com/repos/overvenus/tikv/subscription","commits_url":"https://api.github.com/repos/overvenus/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/overvenus/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/overvenus/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/overvenus/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/overvenus/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/overvenus/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/overvenus/tikv/merges","archive_url":"https://api.github.com/repos/overvenus/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/overvenus/tikv/downloads","issues_url":"https://api.github.com/repos/overvenus/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/overvenus/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/overvenus/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/overvenus/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/overvenus/tikv/labels{/name}","releases_url":"https://api.github.com/repos/overvenus/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/overvenus/tikv/deployments","created_at":"2016-05-04T07:29:33Z","updated_at":"2018-08-09T17:18:43Z","pushed_at":"2018-08-20T10:09:39Z","git_url":"git://github.com/overvenus/tikv.git","ssh_url":"git@github.com:overvenus/tikv.git","clone_url":"https://github.com/overvenus/tikv.git","svn_url":"https://github.com/overvenus/tikv","homepage":"","size":14955,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tikv:master","ref":"master","sha":"c75bb85cfc79833f7aa60fc45209bbcde0842ef6","user":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgzMzkxMA==","name":"tikv","full_name":"tikv/tikv","owner":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tikv/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/tikv/tikv","forks_url":"https://api.github.com/repos/tikv/tikv/forks","keys_url":"https://api.github.com/repos/tikv/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tikv/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tikv/tikv/teams","hooks_url":"https://api.github.com/repos/tikv/tikv/hooks","issue_events_url":"https://api.github.com/repos/tikv/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/tikv/tikv/events","assignees_url":"https://api.github.com/repos/tikv/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/tikv/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/tikv/tikv/tags","blobs_url":"https://api.github.com/repos/tikv/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tikv/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tikv/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/tikv/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/tikv/tikv/languages","stargazers_url":"https://api.github.com/repos/tikv/tikv/stargazers","contributors_url":"https://api.github.com/repos/tikv/tikv/contributors","subscribers_url":"https://api.github.com/repos/tikv/tikv/subscribers","subscription_url":"https://api.github.com/repos/tikv/tikv/subscription","commits_url":"https://api.github.com/repos/tikv/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/tikv/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/tikv/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/tikv/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/tikv/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/tikv/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tikv/tikv/merges","archive_url":"https://api.github.com/repos/tikv/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tikv/tikv/downloads","issues_url":"https://api.github.com/repos/tikv/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/tikv/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/tikv/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/tikv/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tikv/tikv/labels{/name}","releases_url":"https://api.github.com/repos/tikv/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/tikv/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-08-20T10:43:02Z","pushed_at":"2018-08-20T10:42:55Z","git_url":"git://github.com/tikv/tikv.git","ssh_url":"git@github.com:tikv/tikv.git","clone_url":"https://github.com/tikv/tikv.git","svn_url":"https://github.com/tikv/tikv","homepage":"https://pingcap.com","size":15509,"stargazers_count":3511,"watchers_count":3511,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":470,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":470,"open_issues":246,"watchers":3511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3443"},"html":{"href":"https://github.com/tikv/tikv/pull/3443"},"issue":{"href":"https://api.github.com/repos/tikv/tikv/issues/3443"},"comments":{"href":"https://api.github.com/repos/tikv/tikv/issues/3443/comments"},"review_comments":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3443/comments"},"review_comment":{"href":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3443/commits"},"statuses":{"href":"https://api.github.com/repos/tikv/tikv/statuses/8d06815ac7f28eda7b8f6e91beb1cc1789714203"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"overvenus"}}