{"action":"created","issue":{"url":"https://api.github.com/repos/hyperledger/iroha/issues/1833","repository_url":"https://api.github.com/repos/hyperledger/iroha","labels_url":"https://api.github.com/repos/hyperledger/iroha/issues/1833/labels{/name}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/1833/comments","events_url":"https://api.github.com/repos/hyperledger/iroha/issues/1833/events","html_url":"https://github.com/hyperledger/iroha/pull/1833","id":377502934,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDMwNjUx","number":1833,"title":"Remove client_test","user":{"login":"l4l","id":5658339,"node_id":"MDQ6VXNlcjU2NTgzMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/5658339?v=4","gravatar_id":"","url":"https://api.github.com/users/l4l","html_url":"https://github.com/l4l","followers_url":"https://api.github.com/users/l4l/followers","following_url":"https://api.github.com/users/l4l/following{/other_user}","gists_url":"https://api.github.com/users/l4l/gists{/gist_id}","starred_url":"https://api.github.com/users/l4l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l4l/subscriptions","organizations_url":"https://api.github.com/users/l4l/orgs","repos_url":"https://api.github.com/users/l4l/repos","events_url":"https://api.github.com/users/l4l/events{/privacy}","received_events_url":"https://api.github.com/users/l4l/received_events","type":"User","site_admin":false},"labels":[{"id":886022613,"node_id":"MDU6TGFiZWw4ODYwMjI2MTM=","url":"https://api.github.com/repos/hyperledger/iroha/labels/cli","name":"cli","color":"fbca04","default":false},{"id":684699993,"node_id":"MDU6TGFiZWw2ODQ2OTk5OTM=","url":"https://api.github.com/repos/hyperledger/iroha/labels/needs-review","name":"needs-review","color":"f9d0c4","default":false},{"id":878215203,"node_id":"MDU6TGFiZWw4NzgyMTUyMDM=","url":"https://api.github.com/repos/hyperledger/iroha/labels/tests","name":"tests","color":"69e075","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-05T17:25:33Z","updated_at":"2018-12-25T08:34:06Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/1833","html_url":"https://github.com/hyperledger/iroha/pull/1833","diff_url":"https://github.com/hyperledger/iroha/pull/1833.diff","patch_url":"https://github.com/hyperledger/iroha/pull/1833.patch"},"body":"### Description of the Change\r\n\r\nFinally it comes.\r\nIt seems that client_test doesn't really check behavior of CliClient as intended, but instead duplicate the integration tests that already present in unit test folder (😢). Since it's painful for the support we discussed with @muratovv that it should be removed from the project.\r\n\r\n### Benefits\r\n\r\nLesser stuff to support\r\n\r\n### Possible Drawbacks\r\n\r\nNo tests for CliClient, cli is even less maintained\r\n"},"comment":{"url":"https://api.github.com/repos/hyperledger/iroha/issues/comments/449824139","html_url":"https://github.com/hyperledger/iroha/pull/1833#issuecomment-449824139","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/1833","id":449824139,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTgyNDEzOQ==","user":{"login":"lebdron","id":14347159,"node_id":"MDQ6VXNlcjE0MzQ3MTU5","avatar_url":"https://avatars1.githubusercontent.com/u/14347159?v=4","gravatar_id":"","url":"https://api.github.com/users/lebdron","html_url":"https://github.com/lebdron","followers_url":"https://api.github.com/users/lebdron/followers","following_url":"https://api.github.com/users/lebdron/following{/other_user}","gists_url":"https://api.github.com/users/lebdron/gists{/gist_id}","starred_url":"https://api.github.com/users/lebdron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lebdron/subscriptions","organizations_url":"https://api.github.com/users/lebdron/orgs","repos_url":"https://api.github.com/users/lebdron/repos","events_url":"https://api.github.com/users/lebdron/events{/privacy}","received_events_url":"https://api.github.com/users/lebdron/received_events","type":"User","site_admin":false},"created_at":"2018-12-25T08:34:06Z","updated_at":"2018-12-25T08:34:06Z","author_association":"MEMBER","body":"@l4l @luckychess @muratovv can we make a decision on this test?"}}
{"actor":{"display_login":"lebdron"}}