{"action":"created","issue":{"url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/153","repository_url":"https://api.github.com/repos/Netflix/fast_jsonapi","labels_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/153/labels{/name}","comments_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/153/comments","events_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/153/events","html_url":"https://github.com/Netflix/fast_jsonapi/pull/153","id":311379901,"number":153,"title":"Add in options[:scope] and receiving scope in attribute blocks","user":{"login":"bbuck","id":1244900,"avatar_url":"https://avatars3.githubusercontent.com/u/1244900?v=4","gravatar_id":"","url":"https://api.github.com/users/bbuck","html_url":"https://github.com/bbuck","followers_url":"https://api.github.com/users/bbuck/followers","following_url":"https://api.github.com/users/bbuck/following{/other_user}","gists_url":"https://api.github.com/users/bbuck/gists{/gist_id}","starred_url":"https://api.github.com/users/bbuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbuck/subscriptions","organizations_url":"https://api.github.com/users/bbuck/orgs","repos_url":"https://api.github.com/users/bbuck/repos","events_url":"https://api.github.com/users/bbuck/events{/privacy}","received_events_url":"https://api.github.com/users/bbuck/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2018-04-04T20:30:24Z","updated_at":"2018-05-09T12:03:05Z","closed_at":"2018-05-01T16:58:02Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/153","html_url":"https://github.com/Netflix/fast_jsonapi/pull/153","diff_url":"https://github.com/Netflix/fast_jsonapi/pull/153.diff","patch_url":"https://github.com/Netflix/fast_jsonapi/pull/153.patch"},"body":"This feature is an alternative implementation to #150 that also should provide a solution for #139 and #145 and, potentially, #148.\r\n\r\nWhy I chose a different path: #150 opts to use a class-level `attr_accessor` for setting the scope, this approach feels open to potential race conditions or overlap as the scope may persist to other serializer instances or having more instances of one kind of serializer may unintentionally remove a scope -- basically the class-level approach feels open to unnecessary errors.\r\n\r\nThis solution instead opts for a local instance variable to the serializer instance and pass it upward to the class-level methods as necessary like it does for `@resource`.\r\n\r\n**NOTE** There are some failing performance specs but they appear to be failing (at least for me) without my change. I wasn't able to notice any significant amount of decrease when my changes were present by if you do see any speed-ups please point them out!"},"comment":{"url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/comments/387716408","html_url":"https://github.com/Netflix/fast_jsonapi/pull/153#issuecomment-387716408","issue_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/153","id":387716408,"user":{"login":"albertusnicholas","id":29484555,"avatar_url":"https://avatars2.githubusercontent.com/u/29484555?v=4","gravatar_id":"","url":"https://api.github.com/users/albertusnicholas","html_url":"https://github.com/albertusnicholas","followers_url":"https://api.github.com/users/albertusnicholas/followers","following_url":"https://api.github.com/users/albertusnicholas/following{/other_user}","gists_url":"https://api.github.com/users/albertusnicholas/gists{/gist_id}","starred_url":"https://api.github.com/users/albertusnicholas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertusnicholas/subscriptions","organizations_url":"https://api.github.com/users/albertusnicholas/orgs","repos_url":"https://api.github.com/users/albertusnicholas/repos","events_url":"https://api.github.com/users/albertusnicholas/events{/privacy}","received_events_url":"https://api.github.com/users/albertusnicholas/received_events","type":"User","site_admin":false},"created_at":"2018-05-09T12:03:05Z","updated_at":"2018-05-09T12:03:05Z","author_association":"NONE","body":"Thank you so much we are currently use FastJson api for our project but we stuck with this feature that we need hope can use. Pleaseeeeeeeee :100: "}}
{"actor":{"display_login":"albertusnicholas"}}