{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17498","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17498/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17498/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17498/events","html_url":"https://github.com/home-assistant/home-assistant/pull/17498","id":370338346,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDM4ODYx","number":17498,"title":"Adding id to lovelace cards in ui-lovelace.yaml","user":{"login":"bramkragten","id":5662298,"node_id":"MDQ6VXNlcjU2NjIyOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5662298?v=4","gravatar_id":"","url":"https://api.github.com/users/bramkragten","html_url":"https://github.com/bramkragten","followers_url":"https://api.github.com/users/bramkragten/followers","following_url":"https://api.github.com/users/bramkragten/following{/other_user}","gists_url":"https://api.github.com/users/bramkragten/gists{/gist_id}","starred_url":"https://api.github.com/users/bramkragten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bramkragten/subscriptions","organizations_url":"https://api.github.com/users/bramkragten/orgs","repos_url":"https://api.github.com/users/bramkragten/repos","events_url":"https://api.github.com/users/bramkragten/events{/privacy}","received_events_url":"https://api.github.com/users/bramkragten/received_events","type":"User","site_admin":false},"labels":[{"id":450787042,"node_id":"MDU6TGFiZWw0NTA3ODcwNDI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/Hacktoberfest","name":"Hacktoberfest","color":"fbca04","default":false},{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":1067333201,"node_id":"MDU6TGFiZWwxMDY3MzMzMjAx","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20lovelace","name":"component: lovelace","color":"ededed","default":false},{"id":805697812,"node_id":"MDU6TGFiZWw4MDU2OTc4MTI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/docs-missing","name":"docs-missing","color":"83f26f","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-10-15T20:50:33Z","updated_at":"2018-10-27T17:54:12Z","closed_at":"2018-10-17T14:31:06Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17498","html_url":"https://github.com/home-assistant/home-assistant/pull/17498","diff_url":"https://github.com/home-assistant/home-assistant/pull/17498.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/17498.patch"},"body":"## Description:\r\nFirst step to configurate lovelace from the ui, adding ID's to cards in ui-lovelace.yaml\r\n\r\n**Related issue (if applicable):** fixes #<home-assistant issue number goes here>\r\n\r\n**Pull request in [home-assistant.io](https://github.com/home-assistant/home-assistant.io) with documentation (if applicable):** home-assistant/home-assistant.io#<home-assistant.io PR number goes here>\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\n\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [x] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [x] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [x] New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/433641676","html_url":"https://github.com/home-assistant/home-assistant/pull/17498#issuecomment-433641676","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17498","id":433641676,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzY0MTY3Ng==","user":{"login":"dshokouhi","id":1634145,"node_id":"MDQ6VXNlcjE2MzQxNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1634145?v=4","gravatar_id":"","url":"https://api.github.com/users/dshokouhi","html_url":"https://github.com/dshokouhi","followers_url":"https://api.github.com/users/dshokouhi/followers","following_url":"https://api.github.com/users/dshokouhi/following{/other_user}","gists_url":"https://api.github.com/users/dshokouhi/gists{/gist_id}","starred_url":"https://api.github.com/users/dshokouhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshokouhi/subscriptions","organizations_url":"https://api.github.com/users/dshokouhi/orgs","repos_url":"https://api.github.com/users/dshokouhi/repos","events_url":"https://api.github.com/users/dshokouhi/events{/privacy}","received_events_url":"https://api.github.com/users/dshokouhi/received_events","type":"User","site_admin":false},"created_at":"2018-10-27T17:54:12Z","updated_at":"2018-10-27T17:54:12Z","author_association":"CONTRIBUTOR","body":"I think maybe we should treat this upcoming UI editor more like the existing Automation and Script editors.  Power users simply don't use these tools for the reasons stated by @bramkragten. We should only touch the lovelace file IF a user decides to SAVE from the UI editor.  This way power users can just avoid it (like we do today) and users who like the editors can use it.  In fact in order to use the automation editor the user needs to meet certain requirements so we should do the same requirements here. "}}
{"actor":{"display_login":"dshokouhi"}}