{"action":"opened","number":40604,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/40604","id":189962696,"html_url":"https://github.com/ansible/ansible/pull/40604","diff_url":"https://github.com/ansible/ansible/pull/40604.diff","patch_url":"https://github.com/ansible/ansible/pull/40604.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/40604","number":40604,"state":"open","locked":false,"title":"Fixes eos_logging idempotence issue #31862","user":{"login":"NilashishC","id":15523883,"avatar_url":"https://avatars2.githubusercontent.com/u/15523883?v=4","gravatar_id":"","url":"https://api.github.com/users/NilashishC","html_url":"https://github.com/NilashishC","followers_url":"https://api.github.com/users/NilashishC/followers","following_url":"https://api.github.com/users/NilashishC/following{/other_user}","gists_url":"https://api.github.com/users/NilashishC/gists{/gist_id}","starred_url":"https://api.github.com/users/NilashishC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilashishC/subscriptions","organizations_url":"https://api.github.com/users/NilashishC/orgs","repos_url":"https://api.github.com/users/NilashishC/repos","events_url":"https://api.github.com/users/NilashishC/events{/privacy}","received_events_url":"https://api.github.com/users/NilashishC/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\n\r\nFixes eos_logging idempotence issue while setting logging destination as buffered & facility.\r\n\r\nThe change iterates over all the entries in the 'have' list to decide whether a new command needs to appended/executed or not.\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bugfix Pull Request\r\n\r\n\r\n##### COMPONENT NAME\r\neos_logging.py\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\ndevel\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\nIssue reported at https://github.com/ansible/ansible/issues/31862\r\n\r\n<!--- Paste verbatim command output below, e.g. before and after your change -->\r\n```\r\n\r\nBefore change:\r\nPlaybook:\r\ntasks:\r\n    - name: Set Buffered Logging & Facility \r\n      eos_logging:\r\n        dest: buffered\r\n        size: 300\r\n        facility: local7\r\n        level: informational\r\n        state: present\r\n\r\nThe above playbook would result in 'Changed: True' for every run.\r\nAfter fixing it, this idempotence issue does not occur.\r\n```\r\n","created_at":"2018-05-23T12:46:46Z","updated_at":"2018-05-23T12:46:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/40604/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/40604/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/40604/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/c1b67a0a170b8d515209ff5f439e934e40ab0929","head":{"label":"NilashishC:fix_eos_logging_31862","ref":"fix_eos_logging_31862","sha":"c1b67a0a170b8d515209ff5f439e934e40ab0929","user":{"login":"NilashishC","id":15523883,"avatar_url":"https://avatars2.githubusercontent.com/u/15523883?v=4","gravatar_id":"","url":"https://api.github.com/users/NilashishC","html_url":"https://github.com/NilashishC","followers_url":"https://api.github.com/users/NilashishC/followers","following_url":"https://api.github.com/users/NilashishC/following{/other_user}","gists_url":"https://api.github.com/users/NilashishC/gists{/gist_id}","starred_url":"https://api.github.com/users/NilashishC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilashishC/subscriptions","organizations_url":"https://api.github.com/users/NilashishC/orgs","repos_url":"https://api.github.com/users/NilashishC/repos","events_url":"https://api.github.com/users/NilashishC/events{/privacy}","received_events_url":"https://api.github.com/users/NilashishC/received_events","type":"User","site_admin":false},"repo":{"id":133320768,"name":"ansible","full_name":"NilashishC/ansible","owner":{"login":"NilashishC","id":15523883,"avatar_url":"https://avatars2.githubusercontent.com/u/15523883?v=4","gravatar_id":"","url":"https://api.github.com/users/NilashishC","html_url":"https://github.com/NilashishC","followers_url":"https://api.github.com/users/NilashishC/followers","following_url":"https://api.github.com/users/NilashishC/following{/other_user}","gists_url":"https://api.github.com/users/NilashishC/gists{/gist_id}","starred_url":"https://api.github.com/users/NilashishC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilashishC/subscriptions","organizations_url":"https://api.github.com/users/NilashishC/orgs","repos_url":"https://api.github.com/users/NilashishC/repos","events_url":"https://api.github.com/users/NilashishC/events{/privacy}","received_events_url":"https://api.github.com/users/NilashishC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NilashishC/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":true,"url":"https://api.github.com/repos/NilashishC/ansible","forks_url":"https://api.github.com/repos/NilashishC/ansible/forks","keys_url":"https://api.github.com/repos/NilashishC/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NilashishC/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NilashishC/ansible/teams","hooks_url":"https://api.github.com/repos/NilashishC/ansible/hooks","issue_events_url":"https://api.github.com/repos/NilashishC/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/NilashishC/ansible/events","assignees_url":"https://api.github.com/repos/NilashishC/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/NilashishC/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/NilashishC/ansible/tags","blobs_url":"https://api.github.com/repos/NilashishC/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NilashishC/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NilashishC/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/NilashishC/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NilashishC/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/NilashishC/ansible/languages","stargazers_url":"https://api.github.com/repos/NilashishC/ansible/stargazers","contributors_url":"https://api.github.com/repos/NilashishC/ansible/contributors","subscribers_url":"https://api.github.com/repos/NilashishC/ansible/subscribers","subscription_url":"https://api.github.com/repos/NilashishC/ansible/subscription","commits_url":"https://api.github.com/repos/NilashishC/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/NilashishC/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/NilashishC/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/NilashishC/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/NilashishC/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/NilashishC/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NilashishC/ansible/merges","archive_url":"https://api.github.com/repos/NilashishC/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NilashishC/ansible/downloads","issues_url":"https://api.github.com/repos/NilashishC/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/NilashishC/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/NilashishC/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/NilashishC/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NilashishC/ansible/labels{/name}","releases_url":"https://api.github.com/repos/NilashishC/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/NilashishC/ansible/deployments","created_at":"2018-05-14T07:20:06Z","updated_at":"2018-05-14T07:20:34Z","pushed_at":"2018-05-23T12:28:03Z","git_url":"git://github.com/NilashishC/ansible.git","ssh_url":"git@github.com:NilashishC/ansible.git","clone_url":"https://github.com/NilashishC/ansible.git","svn_url":"https://github.com/NilashishC/ansible","homepage":"https://www.ansible.com/","size":121497,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"a3cfe0d72f1d206aed9895be322625c7595ef71d","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-05-23T11:58:01Z","pushed_at":"2018-05-23T12:43:20Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":123665,"stargazers_count":30374,"watchers_count":30374,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11371,"mirror_url":null,"archived":false,"open_issues_count":5116,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":11371,"open_issues":5116,"watchers":30374,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/40604"},"html":{"href":"https://github.com/ansible/ansible/pull/40604"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/40604"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/40604/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/40604/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/40604/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/c1b67a0a170b8d515209ff5f439e934e40ab0929"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":53,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"NilashishC"}}