{"action":"created","comment":{"url":"https://api.github.com/repos/Pivotal/postfacto/pulls/comments/204364349","pull_request_review_id":139429463,"id":204364349,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDM2NDM0OQ==","diff_hunk":"@@ -6,7 +6,7 @@ window.Retro = {\n     \"stylesheets\": [\"application.css\"],\n     \"useRevManifest\": true,\n     \"api_base_url\": \"https://{{api-app-name}}.{{pcf-url}}\",\n-    \"websocket_url\": \"wss://{{api-app-name}}.{{pcf-url}}:443/cable\",\n+    \"websocket_url\": \"wss://{{api-app-name}}.{{pcf-url}}:4443/cable\",","path":"deployment/pcf/config/config.js","position":5,"original_position":5,"commit_id":"0c8dd8ef96c7c22258a67e29cc6126f698cf8c10","original_commit_id":"0c8dd8ef96c7c22258a67e29cc6126f698cf8c10","user":{"login":"seadowg","id":556280,"node_id":"MDQ6VXNlcjU1NjI4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/556280?v=4","gravatar_id":"","url":"https://api.github.com/users/seadowg","html_url":"https://github.com/seadowg","followers_url":"https://api.github.com/users/seadowg/followers","following_url":"https://api.github.com/users/seadowg/following{/other_user}","gists_url":"https://api.github.com/users/seadowg/gists{/gist_id}","starred_url":"https://api.github.com/users/seadowg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seadowg/subscriptions","organizations_url":"https://api.github.com/users/seadowg/orgs","repos_url":"https://api.github.com/users/seadowg/repos","events_url":"https://api.github.com/users/seadowg/events{/privacy}","received_events_url":"https://api.github.com/users/seadowg/received_events","type":"User","site_admin":false},"body":"This actually isn't a mistake. PWS runs (secure) websockets on 4443 but most PCF installations will run it on the standard 443. Could you revert this please?","created_at":"2018-07-23T11:17:57Z","updated_at":"2018-07-23T11:17:58Z","html_url":"https://github.com/Pivotal/postfacto/pull/74#discussion_r204364349","pull_request_url":"https://api.github.com/repos/Pivotal/postfacto/pulls/74","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Pivotal/postfacto/pulls/comments/204364349"},"html":{"href":"https://github.com/Pivotal/postfacto/pull/74#discussion_r204364349"},"pull_request":{"href":"https://api.github.com/repos/Pivotal/postfacto/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/Pivotal/postfacto/pulls/74","id":203153778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMTUzNzc4","html_url":"https://github.com/Pivotal/postfacto/pull/74","diff_url":"https://github.com/Pivotal/postfacto/pull/74.diff","patch_url":"https://github.com/Pivotal/postfacto/pull/74.patch","issue_url":"https://api.github.com/repos/Pivotal/postfacto/issues/74","number":74,"state":"open","locked":false,"title":"Rework deploy script for PCF, trim static site memory to 64MB, fix minor issues","user":{"login":"Kehrlann","id":5676779,"node_id":"MDQ6VXNlcjU2NzY3Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/5676779?v=4","gravatar_id":"","url":"https://api.github.com/users/Kehrlann","html_url":"https://github.com/Kehrlann","followers_url":"https://api.github.com/users/Kehrlann/followers","following_url":"https://api.github.com/users/Kehrlann/following{/other_user}","gists_url":"https://api.github.com/users/Kehrlann/gists{/gist_id}","starred_url":"https://api.github.com/users/Kehrlann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kehrlann/subscriptions","organizations_url":"https://api.github.com/users/Kehrlann/orgs","repos_url":"https://api.github.com/users/Kehrlann/repos","events_url":"https://api.github.com/users/Kehrlann/events{/privacy}","received_events_url":"https://api.github.com/users/Kehrlann/received_events","type":"User","site_admin":false},"body":"Quite a \"big\" PR, tackling :\r\n1. Add react-hot-loader dependency to package.json - the front-end wouldn't build otherwise.\r\n2. Rework the CF deploy script, as discussed in #69. We now use one `deploy.sh` script for both PCF and PWS, as the script itself is the same for both environments. Tested it using the PCF folder, and fixed a minor issue in `config.js`\r\n3. Fix #70 : the static site is now served with 64MB of memory. 32MB should be enough, but, in doubt, 64MB is a good start.","created_at":"2018-07-23T09:08:19Z","updated_at":"2018-07-23T11:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f7901a2217823d46d8dd7f7e2cdca2bb71d4eb3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Pivotal/postfacto/pulls/74/commits","review_comments_url":"https://api.github.com/repos/Pivotal/postfacto/pulls/74/comments","review_comment_url":"https://api.github.com/repos/Pivotal/postfacto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pivotal/postfacto/issues/74/comments","statuses_url":"https://api.github.com/repos/Pivotal/postfacto/statuses/0c8dd8ef96c7c22258a67e29cc6126f698cf8c10","head":{"label":"Kehrlann:master","ref":"master","sha":"0c8dd8ef96c7c22258a67e29cc6126f698cf8c10","user":{"login":"Kehrlann","id":5676779,"node_id":"MDQ6VXNlcjU2NzY3Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/5676779?v=4","gravatar_id":"","url":"https://api.github.com/users/Kehrlann","html_url":"https://github.com/Kehrlann","followers_url":"https://api.github.com/users/Kehrlann/followers","following_url":"https://api.github.com/users/Kehrlann/following{/other_user}","gists_url":"https://api.github.com/users/Kehrlann/gists{/gist_id}","starred_url":"https://api.github.com/users/Kehrlann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kehrlann/subscriptions","organizations_url":"https://api.github.com/users/Kehrlann/orgs","repos_url":"https://api.github.com/users/Kehrlann/repos","events_url":"https://api.github.com/users/Kehrlann/events{/privacy}","received_events_url":"https://api.github.com/users/Kehrlann/received_events","type":"User","site_admin":false},"repo":{"id":141438960,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0Mzg5NjA=","name":"postfacto","full_name":"Kehrlann/postfacto","owner":{"login":"Kehrlann","id":5676779,"node_id":"MDQ6VXNlcjU2NzY3Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/5676779?v=4","gravatar_id":"","url":"https://api.github.com/users/Kehrlann","html_url":"https://github.com/Kehrlann","followers_url":"https://api.github.com/users/Kehrlann/followers","following_url":"https://api.github.com/users/Kehrlann/following{/other_user}","gists_url":"https://api.github.com/users/Kehrlann/gists{/gist_id}","starred_url":"https://api.github.com/users/Kehrlann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kehrlann/subscriptions","organizations_url":"https://api.github.com/users/Kehrlann/orgs","repos_url":"https://api.github.com/users/Kehrlann/repos","events_url":"https://api.github.com/users/Kehrlann/events{/privacy}","received_events_url":"https://api.github.com/users/Kehrlann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kehrlann/postfacto","description":"Self-hosted retro tool aimed at helping remote teams","fork":true,"url":"https://api.github.com/repos/Kehrlann/postfacto","forks_url":"https://api.github.com/repos/Kehrlann/postfacto/forks","keys_url":"https://api.github.com/repos/Kehrlann/postfacto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kehrlann/postfacto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kehrlann/postfacto/teams","hooks_url":"https://api.github.com/repos/Kehrlann/postfacto/hooks","issue_events_url":"https://api.github.com/repos/Kehrlann/postfacto/issues/events{/number}","events_url":"https://api.github.com/repos/Kehrlann/postfacto/events","assignees_url":"https://api.github.com/repos/Kehrlann/postfacto/assignees{/user}","branches_url":"https://api.github.com/repos/Kehrlann/postfacto/branches{/branch}","tags_url":"https://api.github.com/repos/Kehrlann/postfacto/tags","blobs_url":"https://api.github.com/repos/Kehrlann/postfacto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kehrlann/postfacto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kehrlann/postfacto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kehrlann/postfacto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kehrlann/postfacto/statuses/{sha}","languages_url":"https://api.github.com/repos/Kehrlann/postfacto/languages","stargazers_url":"https://api.github.com/repos/Kehrlann/postfacto/stargazers","contributors_url":"https://api.github.com/repos/Kehrlann/postfacto/contributors","subscribers_url":"https://api.github.com/repos/Kehrlann/postfacto/subscribers","subscription_url":"https://api.github.com/repos/Kehrlann/postfacto/subscription","commits_url":"https://api.github.com/repos/Kehrlann/postfacto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kehrlann/postfacto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kehrlann/postfacto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kehrlann/postfacto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kehrlann/postfacto/contents/{+path}","compare_url":"https://api.github.com/repos/Kehrlann/postfacto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kehrlann/postfacto/merges","archive_url":"https://api.github.com/repos/Kehrlann/postfacto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kehrlann/postfacto/downloads","issues_url":"https://api.github.com/repos/Kehrlann/postfacto/issues{/number}","pulls_url":"https://api.github.com/repos/Kehrlann/postfacto/pulls{/number}","milestones_url":"https://api.github.com/repos/Kehrlann/postfacto/milestones{/number}","notifications_url":"https://api.github.com/repos/Kehrlann/postfacto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kehrlann/postfacto/labels{/name}","releases_url":"https://api.github.com/repos/Kehrlann/postfacto/releases{/id}","deployments_url":"https://api.github.com/repos/Kehrlann/postfacto/deployments","created_at":"2018-07-18T13:31:04Z","updated_at":"2018-07-22T18:55:02Z","pushed_at":"2018-07-22T18:55:01Z","git_url":"git://github.com/Kehrlann/postfacto.git","ssh_url":"git@github.com:Kehrlann/postfacto.git","clone_url":"https://github.com/Kehrlann/postfacto.git","svn_url":"https://github.com/Kehrlann/postfacto","homepage":"","size":4395,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Pivotal:master","ref":"master","sha":"d7126011a62d8e82aa6bd6db99595786d5df35ee","user":{"login":"Pivotal","id":33104318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTA0MzE4","avatar_url":"https://avatars0.githubusercontent.com/u/33104318?v=4","gravatar_id":"","url":"https://api.github.com/users/Pivotal","html_url":"https://github.com/Pivotal","followers_url":"https://api.github.com/users/Pivotal/followers","following_url":"https://api.github.com/users/Pivotal/following{/other_user}","gists_url":"https://api.github.com/users/Pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/Pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pivotal/subscriptions","organizations_url":"https://api.github.com/users/Pivotal/orgs","repos_url":"https://api.github.com/users/Pivotal/repos","events_url":"https://api.github.com/users/Pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/Pivotal/received_events","type":"Organization","site_admin":false},"repo":{"id":99138977,"node_id":"MDEwOlJlcG9zaXRvcnk5OTEzODk3Nw==","name":"postfacto","full_name":"Pivotal/postfacto","owner":{"login":"Pivotal","id":33104318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTA0MzE4","avatar_url":"https://avatars0.githubusercontent.com/u/33104318?v=4","gravatar_id":"","url":"https://api.github.com/users/Pivotal","html_url":"https://github.com/Pivotal","followers_url":"https://api.github.com/users/Pivotal/followers","following_url":"https://api.github.com/users/Pivotal/following{/other_user}","gists_url":"https://api.github.com/users/Pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/Pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pivotal/subscriptions","organizations_url":"https://api.github.com/users/Pivotal/orgs","repos_url":"https://api.github.com/users/Pivotal/repos","events_url":"https://api.github.com/users/Pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/Pivotal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pivotal/postfacto","description":"Self-hosted retro tool aimed at helping remote teams","fork":false,"url":"https://api.github.com/repos/Pivotal/postfacto","forks_url":"https://api.github.com/repos/Pivotal/postfacto/forks","keys_url":"https://api.github.com/repos/Pivotal/postfacto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pivotal/postfacto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pivotal/postfacto/teams","hooks_url":"https://api.github.com/repos/Pivotal/postfacto/hooks","issue_events_url":"https://api.github.com/repos/Pivotal/postfacto/issues/events{/number}","events_url":"https://api.github.com/repos/Pivotal/postfacto/events","assignees_url":"https://api.github.com/repos/Pivotal/postfacto/assignees{/user}","branches_url":"https://api.github.com/repos/Pivotal/postfacto/branches{/branch}","tags_url":"https://api.github.com/repos/Pivotal/postfacto/tags","blobs_url":"https://api.github.com/repos/Pivotal/postfacto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pivotal/postfacto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pivotal/postfacto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pivotal/postfacto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pivotal/postfacto/statuses/{sha}","languages_url":"https://api.github.com/repos/Pivotal/postfacto/languages","stargazers_url":"https://api.github.com/repos/Pivotal/postfacto/stargazers","contributors_url":"https://api.github.com/repos/Pivotal/postfacto/contributors","subscribers_url":"https://api.github.com/repos/Pivotal/postfacto/subscribers","subscription_url":"https://api.github.com/repos/Pivotal/postfacto/subscription","commits_url":"https://api.github.com/repos/Pivotal/postfacto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pivotal/postfacto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pivotal/postfacto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pivotal/postfacto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pivotal/postfacto/contents/{+path}","compare_url":"https://api.github.com/repos/Pivotal/postfacto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pivotal/postfacto/merges","archive_url":"https://api.github.com/repos/Pivotal/postfacto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pivotal/postfacto/downloads","issues_url":"https://api.github.com/repos/Pivotal/postfacto/issues{/number}","pulls_url":"https://api.github.com/repos/Pivotal/postfacto/pulls{/number}","milestones_url":"https://api.github.com/repos/Pivotal/postfacto/milestones{/number}","notifications_url":"https://api.github.com/repos/Pivotal/postfacto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pivotal/postfacto/labels{/name}","releases_url":"https://api.github.com/repos/Pivotal/postfacto/releases{/id}","deployments_url":"https://api.github.com/repos/Pivotal/postfacto/deployments","created_at":"2017-08-02T16:33:00Z","updated_at":"2018-07-22T10:44:44Z","pushed_at":"2018-07-23T09:08:20Z","git_url":"git://github.com/Pivotal/postfacto.git","ssh_url":"git@github.com:Pivotal/postfacto.git","clone_url":"https://github.com/Pivotal/postfacto.git","svn_url":"https://github.com/Pivotal/postfacto","homepage":"","size":4441,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":17,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pivotal/postfacto/pulls/74"},"html":{"href":"https://github.com/Pivotal/postfacto/pull/74"},"issue":{"href":"https://api.github.com/repos/Pivotal/postfacto/issues/74"},"comments":{"href":"https://api.github.com/repos/Pivotal/postfacto/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/Pivotal/postfacto/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/Pivotal/postfacto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pivotal/postfacto/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/Pivotal/postfacto/statuses/0c8dd8ef96c7c22258a67e29cc6126f698cf8c10"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"seadowg"}}