{"action":"created","issue":{"url":"https://api.github.com/repos/line/armeria/issues/1368","repository_url":"https://api.github.com/repos/line/armeria","labels_url":"https://api.github.com/repos/line/armeria/issues/1368/labels{/name}","comments_url":"https://api.github.com/repos/line/armeria/issues/1368/comments","events_url":"https://api.github.com/repos/line/armeria/issues/1368/events","html_url":"https://github.com/line/armeria/issues/1368","id":360521594,"node_id":"MDU6SXNzdWUzNjA1MjE1OTQ=","number":1368,"title":"Thrift oneway sync call need to wait server handle complete???","user":{"login":"yanfeipeng","id":12102322,"node_id":"MDQ6VXNlcjEyMTAyMzIy","avatar_url":"https://avatars3.githubusercontent.com/u/12102322?v=4","gravatar_id":"","url":"https://api.github.com/users/yanfeipeng","html_url":"https://github.com/yanfeipeng","followers_url":"https://api.github.com/users/yanfeipeng/followers","following_url":"https://api.github.com/users/yanfeipeng/following{/other_user}","gists_url":"https://api.github.com/users/yanfeipeng/gists{/gist_id}","starred_url":"https://api.github.com/users/yanfeipeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanfeipeng/subscriptions","organizations_url":"https://api.github.com/users/yanfeipeng/orgs","repos_url":"https://api.github.com/users/yanfeipeng/repos","events_url":"https://api.github.com/users/yanfeipeng/events{/privacy}","received_events_url":"https://api.github.com/users/yanfeipeng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-15T08:48:48Z","updated_at":"2018-09-17T02:27:11Z","closed_at":null,"author_association":"NONE","body":"```java\r\n    private static void invokeSynchronously(\r\n            ServiceRequestContext ctx, Object impl,\r\n            ThriftFunction func, TBase<?, ?> args, DefaultRpcResponse reply) {\r\n\r\n        final ProcessFunction<Object, TBase<?, ?>> f = func.syncFunc();\r\n        ctx.blockingTaskExecutor().execute(() -> {\r\n            if (reply.isDone()) {\r\n                // Closed already most likely due to timeout.\r\n                return;\r\n            }\r\n\r\n            try {\r\n                final TBase<?, ?> result = f.getResult(impl, args);\r\n                if (func.isOneWay()) {\r\n                    reply.complete(null);\r\n                } else {\r\n                    reply.complete(func.getResult(result));\r\n                }\r\n            } catch (Throwable t) {\r\n                reply.completeExceptionally(t);\r\n            }\r\n        });\r\n    }\r\n````\r\n\r\nsomething wrong with \r\n\r\n```java\r\n                final TBase<?, ?> result = f.getResult(impl, args);\r\n                if (func.isOneWay()) {\r\n                    reply.complete(null);\r\n                } else {\r\n                    reply.complete(func.getResult(result));\r\n                }\r\n```"},"comment":{"url":"https://api.github.com/repos/line/armeria/issues/comments/421876316","html_url":"https://github.com/line/armeria/issues/1368#issuecomment-421876316","issue_url":"https://api.github.com/repos/line/armeria/issues/1368","id":421876316,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTg3NjMxNg==","user":{"login":"trustin","id":173918,"node_id":"MDQ6VXNlcjE3MzkxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T02:27:11Z","updated_at":"2018-09-17T02:27:11Z","author_association":"MEMBER","body":"@yanfeipeng What would be the expected behavior then? Sending an HTTP response immediately after the service started to handle the request?"}}
{"actor":{"display_login":"trustin"}}