{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10855","repository_url":"https://api.github.com/repos/rapid7/metasploit-framework","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10855/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10855/comments","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10855/events","html_url":"https://github.com/rapid7/metasploit-framework/pull/10855","id":373012039,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MDQ4MDAy","number":10855,"title":"Enable non-session command output for SSH modules","user":{"login":"wvu-r7","id":4551878,"node_id":"MDQ6VXNlcjQ1NTE4Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/4551878?v=4","gravatar_id":"","url":"https://api.github.com/users/wvu-r7","html_url":"https://github.com/wvu-r7","followers_url":"https://api.github.com/users/wvu-r7/followers","following_url":"https://api.github.com/users/wvu-r7/following{/other_user}","gists_url":"https://api.github.com/users/wvu-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wvu-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvu-r7/subscriptions","organizations_url":"https://api.github.com/users/wvu-r7/orgs","repos_url":"https://api.github.com/users/wvu-r7/repos","events_url":"https://api.github.com/users/wvu-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wvu-r7/received_events","type":"User","site_admin":false},"labels":[{"id":124421898,"node_id":"MDU6TGFiZWwxMjQ0MjE4OTg=","url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/bug","name":"bug","color":"e11d21","default":true},{"id":213102939,"node_id":"MDU6TGFiZWwyMTMxMDI5Mzk=","url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/enhancement","name":"enhancement","color":"5319e7","default":true},{"id":103436071,"node_id":"MDU6TGFiZWwxMDM0MzYwNzE=","url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/library","name":"library","color":"fad8c7","default":false},{"id":103436014,"node_id":"MDU6TGFiZWwxMDM0MzYwMTQ=","url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/module","name":"module","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-23T13:52:56Z","updated_at":"2018-10-23T16:57:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/10855","html_url":"https://github.com/rapid7/metasploit-framework/pull/10855","diff_url":"https://github.com/rapid7/metasploit-framework/pull/10855.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/10855.patch"},"body":"Looks like `channel[:data]` was initialized but never used.\r\n\r\nThe socket pair is closed on EOF from the command, which is why we couldn't read output outside a shell session.\r\n\r\n```\r\nmsf5 auxiliary(scanner/ssh/libssh_auth_bypass) > set action Execute\r\naction => Execute\r\nmsf5 auxiliary(scanner/ssh/libssh_auth_bypass) > set cmd id; uname -a\r\ncmd => id; uname -a\r\nmsf5 auxiliary(scanner/ssh/libssh_auth_bypass) > run\r\n\r\n[*] 172.28.128.3:2222 - Attempting authentication bypass\r\n[+] 172.28.128.3:2222 - SSH-2.0-libssh_0.8.3 appears to be unpatched\r\n[*] 172.28.128.3:2222 - Executed: id; uname -a\r\nuid=0(root) gid=0(root) groups=0(root)\r\nLinux ubuntu-xenial 4.4.0-134-generic #160-Ubuntu SMP Wed Aug 15 14:58:00 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux\r\n[*] Scanned 1 of 1 hosts (100% complete)\r\n[*] Auxiliary module execution completed\r\nmsf5 auxiliary(scanner/ssh/libssh_auth_bypass) >\r\n```\r\n\r\n#10820"},"comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments/432331542","html_url":"https://github.com/rapid7/metasploit-framework/pull/10855#issuecomment-432331542","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10855","id":432331542,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjMzMTU0Mg==","user":{"login":"busterb","id":4108654,"node_id":"MDQ6VXNlcjQxMDg2NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4108654?v=4","gravatar_id":"","url":"https://api.github.com/users/busterb","html_url":"https://github.com/busterb","followers_url":"https://api.github.com/users/busterb/followers","following_url":"https://api.github.com/users/busterb/following{/other_user}","gists_url":"https://api.github.com/users/busterb/gists{/gist_id}","starred_url":"https://api.github.com/users/busterb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busterb/subscriptions","organizations_url":"https://api.github.com/users/busterb/orgs","repos_url":"https://api.github.com/users/busterb/repos","events_url":"https://api.github.com/users/busterb/events{/privacy}","received_events_url":"https://api.github.com/users/busterb/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T16:57:57Z","updated_at":"2018-10-23T16:57:57Z","author_association":"CONTRIBUTOR","body":"Very nice, now `sessions -K` doesn't throw a nasty stracktrace either.\r\n\r\nBefore:\r\n```\r\nmsf5 auxiliary(scanner/ssh/libssh_auth_bypass) > sessions -K\r\n[*] Killing all sessions...\r\n#<Thread:0x000055ec29db7890@/home/bcook/projects/metasploit-framework/lib/net/ssh/command_stream.rb:69 run> terminated with exception (report_on_exception is true):\r\nTraceback (most recent call last):\r\n\t3: from /home/bcook/projects/metasploit-framework/lib/net/ssh/command_stream.rb:72:in `block (2 levels) in initialize'\r\n\t2: from /home/bcook/.rvm/gems/ruby-2.5.3@metasploit-framework/gems/rex-core-0.1.13/lib/rex/io/stream.rb:72:in `read'\r\n\t1: from /home/bcook/.rvm/rubies/ruby-2.5.3/lib/ruby/2.5.0/socket.rb:452:in `read_nonblock'\r\n/home/bcook/.rvm/rubies/ruby-2.5.3/lib/ruby/2.5.0/socket.rb:452:in `__read_nonblock': Connection reset by peer (Errno::ECONNRESET)\r\n[*] 127.0.0.1 - Command shell session 1 closed.\r\n\r\n```\r\n\r\nAfter:\r\n```\r\nmsf5 auxiliary(scanner/ssh/libssh_auth_bypass) > sessions -K\r\n[*] Killing all sessions...\r\n[*] 127.0.0.1 - Command shell session 1 closed.\r\n```"}}
{"actor":{"display_login":"busterb"}}