{"action":"closed","number":337,"pull_request":{"url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/337","id":225211073,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjExMDcz","html_url":"https://github.com/aws/aws-toolkit-jetbrains/pull/337","diff_url":"https://github.com/aws/aws-toolkit-jetbrains/pull/337.diff","patch_url":"https://github.com/aws/aws-toolkit-jetbrains/pull/337.patch","issue_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/337","number":337,"state":"closed","locked":false,"title":"Add exception handling logic for blank credentials file","user":{"login":"kiiadi","id":4661536,"node_id":"MDQ6VXNlcjQ2NjE1MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4661536?v=4","gravatar_id":"","url":"https://api.github.com/users/kiiadi","html_url":"https://github.com/kiiadi","followers_url":"https://api.github.com/users/kiiadi/followers","following_url":"https://api.github.com/users/kiiadi/following{/other_user}","gists_url":"https://api.github.com/users/kiiadi/gists{/gist_id}","starred_url":"https://api.github.com/users/kiiadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiiadi/subscriptions","organizations_url":"https://api.github.com/users/kiiadi/orgs","repos_url":"https://api.github.com/users/kiiadi/repos","events_url":"https://api.github.com/users/kiiadi/events{/privacy}","received_events_url":"https://api.github.com/users/kiiadi/received_events","type":"User","site_admin":false},"body":"Fixes #336\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nThrow exception when attempting to open a blank credentials file (rather than current behaviour of \"no action\").\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nIntelliJ can't detect the file type when the file is blank (and has no extension).\r\n\r\n## Related Issue(s)\r\n<!--- What is the related issue you are trying to fix? -->\r\n\r\n## Testing\r\n<!--- Please describe in detail how you tested your changes -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nAdded additional unit tests.\r\n\r\n## Screenshots (if appropriate)\r\n\r\n## Checklist\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the **README** document\r\n- [x] I have read the **CONTRIBUTING** document\r\n- [x] Local run of `gradlew check` succeeds\r\n- [x] My code follows the code style of this project\r\n- [x] I have added tests to cover my changes\r\n- [x] All new and existing tests passed\r\n- [ ] A short description of the change has been added to the **CHANGELOG**\r\n\r\n## License\r\nI confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-10-23T22:45:55Z","updated_at":"2018-10-23T23:20:45Z","closed_at":"2018-10-23T23:20:45Z","merged_at":"2018-10-23T23:20:44Z","merge_commit_sha":"741227d028a0242a3bc36a894f642c33b46c00a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/337/commits","review_comments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/337/comments","review_comment_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/337/comments","statuses_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/statuses/b52deb50cc369ab9f4bdfbab16da9576d5045214","head":{"label":"aws:kiiadi/fixing-blank-credential-files","ref":"kiiadi/fixing-blank-credential-files","sha":"b52deb50cc369ab9f4bdfbab16da9576d5045214","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":91485909,"node_id":"MDEwOlJlcG9zaXRvcnk5MTQ4NTkwOQ==","name":"aws-toolkit-jetbrains","full_name":"aws/aws-toolkit-jetbrains","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/aws-toolkit-jetbrains","description":"AWS Toolkit for JetBrains - a plugin for interacting with AWS from JetBrains IDEs","fork":false,"url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains","forks_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/forks","keys_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/teams","hooks_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/events","assignees_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/tags","blobs_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/languages","stargazers_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/subscription","commits_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/merges","archive_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/downloads","issues_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/deployments","created_at":"2017-05-16T17:28:34Z","updated_at":"2018-10-23T19:36:02Z","pushed_at":"2018-10-23T23:20:44Z","git_url":"git://github.com/aws/aws-toolkit-jetbrains.git","ssh_url":"git@github.com:aws/aws-toolkit-jetbrains.git","clone_url":"https://github.com/aws/aws-toolkit-jetbrains.git","svn_url":"https://github.com/aws/aws-toolkit-jetbrains","homepage":"","size":936,"stargazers_count":24,"watchers_count":24,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":56,"watchers":24,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"261ea2f710928e566b7407f4f6d03a25749436d0","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":91485909,"node_id":"MDEwOlJlcG9zaXRvcnk5MTQ4NTkwOQ==","name":"aws-toolkit-jetbrains","full_name":"aws/aws-toolkit-jetbrains","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/aws-toolkit-jetbrains","description":"AWS Toolkit for JetBrains - a plugin for interacting with AWS from JetBrains IDEs","fork":false,"url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains","forks_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/forks","keys_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/teams","hooks_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/events","assignees_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/tags","blobs_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/languages","stargazers_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/subscription","commits_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/merges","archive_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/downloads","issues_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/deployments","created_at":"2017-05-16T17:28:34Z","updated_at":"2018-10-23T19:36:02Z","pushed_at":"2018-10-23T23:20:44Z","git_url":"git://github.com/aws/aws-toolkit-jetbrains.git","ssh_url":"git@github.com:aws/aws-toolkit-jetbrains.git","clone_url":"https://github.com/aws/aws-toolkit-jetbrains.git","svn_url":"https://github.com/aws/aws-toolkit-jetbrains","homepage":"","size":936,"stargazers_count":24,"watchers_count":24,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":56,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/337"},"html":{"href":"https://github.com/aws/aws-toolkit-jetbrains/pull/337"},"issue":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/337"},"comments":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/statuses/b52deb50cc369ab9f4bdfbab16da9576d5045214"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kiiadi","id":4661536,"node_id":"MDQ6VXNlcjQ2NjE1MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4661536?v=4","gravatar_id":"","url":"https://api.github.com/users/kiiadi","html_url":"https://github.com/kiiadi","followers_url":"https://api.github.com/users/kiiadi/followers","following_url":"https://api.github.com/users/kiiadi/following{/other_user}","gists_url":"https://api.github.com/users/kiiadi/gists{/gist_id}","starred_url":"https://api.github.com/users/kiiadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiiadi/subscriptions","organizations_url":"https://api.github.com/users/kiiadi/orgs","repos_url":"https://api.github.com/users/kiiadi/repos","events_url":"https://api.github.com/users/kiiadi/events{/privacy}","received_events_url":"https://api.github.com/users/kiiadi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":22,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"kiiadi"}}