{"action":"created","comment":{"url":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/comments/241269279","pull_request_review_id":184498387,"id":241269279,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTI2OTI3OQ==","diff_hunk":"@@ -300,20 +300,21 @@ export async function runTask(\n   // Runs the provided source in our fantasy gulp context\n   const run = async (src: string) => {\n     const project = appStore.getProject().getModel();\n-    await runGulpTask(src, name, optional, project, logLn, externals);\n+    return await runGulpTask(src, name, optional, project, logLn, externals);","path":"src/actions/AppActions.ts","position":5,"original_position":5,"commit_id":"4b1102f5602ec6a09112fec5a69dc054a5bf118e","original_commit_id":"5efeb34aba8cd7b785bd83ae3a8d24a217eb4dd5","user":{"login":"vgrichina","id":126710,"node_id":"MDQ6VXNlcjEyNjcxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/126710?v=4","gravatar_id":"","url":"https://api.github.com/users/vgrichina","html_url":"https://github.com/vgrichina","followers_url":"https://api.github.com/users/vgrichina/followers","following_url":"https://api.github.com/users/vgrichina/following{/other_user}","gists_url":"https://api.github.com/users/vgrichina/gists{/gist_id}","starred_url":"https://api.github.com/users/vgrichina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgrichina/subscriptions","organizations_url":"https://api.github.com/users/vgrichina/orgs","repos_url":"https://api.github.com/users/vgrichina/repos","events_url":"https://api.github.com/users/vgrichina/events{/privacy}","received_events_url":"https://api.github.com/users/vgrichina/received_events","type":"User","site_admin":false},"body":"It is normal practice to use exceptions in code using `async`/`await` to indicate any type of error in JavaScript. Build failure doesn't somehow dramatically different from e.g. failed network request.\r\n\r\nAFAIK the only mainstream language (with exception support) where it is common practice to consider exceptions heavyweight is C++.","created_at":"2018-12-13T04:32:52Z","updated_at":"2018-12-13T04:32:53Z","html_url":"https://github.com/nearprotocol/NEARStudio/pull/40#discussion_r241269279","pull_request_url":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/40","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/comments/241269279"},"html":{"href":"https://github.com/nearprotocol/NEARStudio/pull/40#discussion_r241269279"},"pull_request":{"href":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/40"}},"in_reply_to_id":240871481},"pull_request":{"url":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/40","id":237898149,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODk4MTQ5","html_url":"https://github.com/nearprotocol/NEARStudio/pull/40","diff_url":"https://github.com/nearprotocol/NEARStudio/pull/40.diff","patch_url":"https://github.com/nearprotocol/NEARStudio/pull/40.patch","issue_url":"https://api.github.com/repos/nearprotocol/NEARStudio/issues/40","number":40,"state":"closed","locked":false,"title":"[near studio] do not run if build has failed.","user":{"login":"janedegtiareva","id":1320689,"node_id":"MDQ6VXNlcjEzMjA2ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1320689?v=4","gravatar_id":"","url":"https://api.github.com/users/janedegtiareva","html_url":"https://github.com/janedegtiareva","followers_url":"https://api.github.com/users/janedegtiareva/followers","following_url":"https://api.github.com/users/janedegtiareva/following{/other_user}","gists_url":"https://api.github.com/users/janedegtiareva/gists{/gist_id}","starred_url":"https://api.github.com/users/janedegtiareva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janedegtiareva/subscriptions","organizations_url":"https://api.github.com/users/janedegtiareva/orgs","repos_url":"https://api.github.com/users/janedegtiareva/repos","events_url":"https://api.github.com/users/janedegtiareva/events{/privacy}","received_events_url":"https://api.github.com/users/janedegtiareva/received_events","type":"User","site_admin":false},"body":"Associated Issue: https://github.com/nearprotocol/NEARStudio/issues/21\r\n\r\n","created_at":"2018-12-12T03:06:07Z","updated_at":"2018-12-13T04:32:53Z","closed_at":"2018-12-12T19:15:00Z","merged_at":"2018-12-12T19:15:00Z","merge_commit_sha":"7fc15631a04868cb1e8a96e665017b56576168e8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/40/commits","review_comments_url":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/40/comments","review_comment_url":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nearprotocol/NEARStudio/issues/40/comments","statuses_url":"https://api.github.com/repos/nearprotocol/NEARStudio/statuses/4b1102f5602ec6a09112fec5a69dc054a5bf118e","head":{"label":"nearprotocol:build-run","ref":"build-run","sha":"4b1102f5602ec6a09112fec5a69dc054a5bf118e","user":{"login":"nearprotocol","id":42587064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNTg3MDY0","avatar_url":"https://avatars2.githubusercontent.com/u/42587064?v=4","gravatar_id":"","url":"https://api.github.com/users/nearprotocol","html_url":"https://github.com/nearprotocol","followers_url":"https://api.github.com/users/nearprotocol/followers","following_url":"https://api.github.com/users/nearprotocol/following{/other_user}","gists_url":"https://api.github.com/users/nearprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/nearprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearprotocol/subscriptions","organizations_url":"https://api.github.com/users/nearprotocol/orgs","repos_url":"https://api.github.com/users/nearprotocol/repos","events_url":"https://api.github.com/users/nearprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/nearprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":156448884,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY0NDg4ODQ=","name":"NEARStudio","full_name":"nearprotocol/NEARStudio","private":false,"owner":{"login":"nearprotocol","id":42587064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNTg3MDY0","avatar_url":"https://avatars2.githubusercontent.com/u/42587064?v=4","gravatar_id":"","url":"https://api.github.com/users/nearprotocol","html_url":"https://github.com/nearprotocol","followers_url":"https://api.github.com/users/nearprotocol/followers","following_url":"https://api.github.com/users/nearprotocol/following{/other_user}","gists_url":"https://api.github.com/users/nearprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/nearprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearprotocol/subscriptions","organizations_url":"https://api.github.com/users/nearprotocol/orgs","repos_url":"https://api.github.com/users/nearprotocol/repos","events_url":"https://api.github.com/users/nearprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/nearprotocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nearprotocol/NEARStudio","description":"IDE for building smart contract on NEAR platform","fork":false,"url":"https://api.github.com/repos/nearprotocol/NEARStudio","forks_url":"https://api.github.com/repos/nearprotocol/NEARStudio/forks","keys_url":"https://api.github.com/repos/nearprotocol/NEARStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nearprotocol/NEARStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nearprotocol/NEARStudio/teams","hooks_url":"https://api.github.com/repos/nearprotocol/NEARStudio/hooks","issue_events_url":"https://api.github.com/repos/nearprotocol/NEARStudio/issues/events{/number}","events_url":"https://api.github.com/repos/nearprotocol/NEARStudio/events","assignees_url":"https://api.github.com/repos/nearprotocol/NEARStudio/assignees{/user}","branches_url":"https://api.github.com/repos/nearprotocol/NEARStudio/branches{/branch}","tags_url":"https://api.github.com/repos/nearprotocol/NEARStudio/tags","blobs_url":"https://api.github.com/repos/nearprotocol/NEARStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nearprotocol/NEARStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nearprotocol/NEARStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/nearprotocol/NEARStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nearprotocol/NEARStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/nearprotocol/NEARStudio/languages","stargazers_url":"https://api.github.com/repos/nearprotocol/NEARStudio/stargazers","contributors_url":"https://api.github.com/repos/nearprotocol/NEARStudio/contributors","subscribers_url":"https://api.github.com/repos/nearprotocol/NEARStudio/subscribers","subscription_url":"https://api.github.com/repos/nearprotocol/NEARStudio/subscription","commits_url":"https://api.github.com/repos/nearprotocol/NEARStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/nearprotocol/NEARStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/nearprotocol/NEARStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/nearprotocol/NEARStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/nearprotocol/NEARStudio/contents/{+path}","compare_url":"https://api.github.com/repos/nearprotocol/NEARStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nearprotocol/NEARStudio/merges","archive_url":"https://api.github.com/repos/nearprotocol/NEARStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nearprotocol/NEARStudio/downloads","issues_url":"https://api.github.com/repos/nearprotocol/NEARStudio/issues{/number}","pulls_url":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/nearprotocol/NEARStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/nearprotocol/NEARStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nearprotocol/NEARStudio/labels{/name}","releases_url":"https://api.github.com/repos/nearprotocol/NEARStudio/releases{/id}","deployments_url":"https://api.github.com/repos/nearprotocol/NEARStudio/deployments","created_at":"2018-11-06T21:16:12Z","updated_at":"2018-12-13T00:10:09Z","pushed_at":"2018-12-13T00:10:07Z","git_url":"git://github.com/nearprotocol/NEARStudio.git","ssh_url":"git@github.com:nearprotocol/NEARStudio.git","clone_url":"https://github.com/nearprotocol/NEARStudio.git","svn_url":"https://github.com/nearprotocol/NEARStudio","homepage":"https://studio.nearprotocol.com","size":14087,"stargazers_count":13,"watchers_count":13,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":28,"watchers":13,"default_branch":"master"}},"base":{"label":"nearprotocol:master","ref":"master","sha":"ef9e331f1a02a577c29fdd20ebb72b4decdae5fe","user":{"login":"nearprotocol","id":42587064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNTg3MDY0","avatar_url":"https://avatars2.githubusercontent.com/u/42587064?v=4","gravatar_id":"","url":"https://api.github.com/users/nearprotocol","html_url":"https://github.com/nearprotocol","followers_url":"https://api.github.com/users/nearprotocol/followers","following_url":"https://api.github.com/users/nearprotocol/following{/other_user}","gists_url":"https://api.github.com/users/nearprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/nearprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearprotocol/subscriptions","organizations_url":"https://api.github.com/users/nearprotocol/orgs","repos_url":"https://api.github.com/users/nearprotocol/repos","events_url":"https://api.github.com/users/nearprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/nearprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":156448884,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY0NDg4ODQ=","name":"NEARStudio","full_name":"nearprotocol/NEARStudio","private":false,"owner":{"login":"nearprotocol","id":42587064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNTg3MDY0","avatar_url":"https://avatars2.githubusercontent.com/u/42587064?v=4","gravatar_id":"","url":"https://api.github.com/users/nearprotocol","html_url":"https://github.com/nearprotocol","followers_url":"https://api.github.com/users/nearprotocol/followers","following_url":"https://api.github.com/users/nearprotocol/following{/other_user}","gists_url":"https://api.github.com/users/nearprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/nearprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearprotocol/subscriptions","organizations_url":"https://api.github.com/users/nearprotocol/orgs","repos_url":"https://api.github.com/users/nearprotocol/repos","events_url":"https://api.github.com/users/nearprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/nearprotocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nearprotocol/NEARStudio","description":"IDE for building smart contract on NEAR platform","fork":false,"url":"https://api.github.com/repos/nearprotocol/NEARStudio","forks_url":"https://api.github.com/repos/nearprotocol/NEARStudio/forks","keys_url":"https://api.github.com/repos/nearprotocol/NEARStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nearprotocol/NEARStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nearprotocol/NEARStudio/teams","hooks_url":"https://api.github.com/repos/nearprotocol/NEARStudio/hooks","issue_events_url":"https://api.github.com/repos/nearprotocol/NEARStudio/issues/events{/number}","events_url":"https://api.github.com/repos/nearprotocol/NEARStudio/events","assignees_url":"https://api.github.com/repos/nearprotocol/NEARStudio/assignees{/user}","branches_url":"https://api.github.com/repos/nearprotocol/NEARStudio/branches{/branch}","tags_url":"https://api.github.com/repos/nearprotocol/NEARStudio/tags","blobs_url":"https://api.github.com/repos/nearprotocol/NEARStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nearprotocol/NEARStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nearprotocol/NEARStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/nearprotocol/NEARStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nearprotocol/NEARStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/nearprotocol/NEARStudio/languages","stargazers_url":"https://api.github.com/repos/nearprotocol/NEARStudio/stargazers","contributors_url":"https://api.github.com/repos/nearprotocol/NEARStudio/contributors","subscribers_url":"https://api.github.com/repos/nearprotocol/NEARStudio/subscribers","subscription_url":"https://api.github.com/repos/nearprotocol/NEARStudio/subscription","commits_url":"https://api.github.com/repos/nearprotocol/NEARStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/nearprotocol/NEARStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/nearprotocol/NEARStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/nearprotocol/NEARStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/nearprotocol/NEARStudio/contents/{+path}","compare_url":"https://api.github.com/repos/nearprotocol/NEARStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nearprotocol/NEARStudio/merges","archive_url":"https://api.github.com/repos/nearprotocol/NEARStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nearprotocol/NEARStudio/downloads","issues_url":"https://api.github.com/repos/nearprotocol/NEARStudio/issues{/number}","pulls_url":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/nearprotocol/NEARStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/nearprotocol/NEARStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nearprotocol/NEARStudio/labels{/name}","releases_url":"https://api.github.com/repos/nearprotocol/NEARStudio/releases{/id}","deployments_url":"https://api.github.com/repos/nearprotocol/NEARStudio/deployments","created_at":"2018-11-06T21:16:12Z","updated_at":"2018-12-13T00:10:09Z","pushed_at":"2018-12-13T00:10:07Z","git_url":"git://github.com/nearprotocol/NEARStudio.git","ssh_url":"git@github.com:nearprotocol/NEARStudio.git","clone_url":"https://github.com/nearprotocol/NEARStudio.git","svn_url":"https://github.com/nearprotocol/NEARStudio","homepage":"https://studio.nearprotocol.com","size":14087,"stargazers_count":13,"watchers_count":13,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":28,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/40"},"html":{"href":"https://github.com/nearprotocol/NEARStudio/pull/40"},"issue":{"href":"https://api.github.com/repos/nearprotocol/NEARStudio/issues/40"},"comments":{"href":"https://api.github.com/repos/nearprotocol/NEARStudio/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nearprotocol/NEARStudio/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/nearprotocol/NEARStudio/statuses/4b1102f5602ec6a09112fec5a69dc054a5bf118e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vgrichina"}}