{"action":"created","issue":{"url":"https://api.github.com/repos/woocart/localizations/issues/61","repository_url":"https://api.github.com/repos/woocart/localizations","labels_url":"https://api.github.com/repos/woocart/localizations/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/woocart/localizations/issues/61/comments","events_url":"https://api.github.com/repos/woocart/localizations/issues/61/events","html_url":"https://github.com/woocart/localizations/issues/61","id":369922343,"node_id":"MDU6SXNzdWUzNjk5MjIzNDM=","number":61,"title":"Prevent line breaks in localization files","user":{"login":"zupo","id":311580,"node_id":"MDQ6VXNlcjMxMTU4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/311580?v=4","gravatar_id":"","url":"https://api.github.com/users/zupo","html_url":"https://github.com/zupo","followers_url":"https://api.github.com/users/zupo/followers","following_url":"https://api.github.com/users/zupo/following{/other_user}","gists_url":"https://api.github.com/users/zupo/gists{/gist_id}","starred_url":"https://api.github.com/users/zupo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zupo/subscriptions","organizations_url":"https://api.github.com/users/zupo/orgs","repos_url":"https://api.github.com/users/zupo/repos","events_url":"https://api.github.com/users/zupo/events{/privacy}","received_events_url":"https://api.github.com/users/zupo/received_events","type":"User","site_admin":false},"labels":[{"id":992815030,"node_id":"MDU6TGFiZWw5OTI4MTUwMzA=","url":"https://api.github.com/repos/woocart/localizations/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-14T17:08:29Z","updated_at":"2019-01-05T17:45:27Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"TL;RD: we want to prevent bugs such as https://github.com/niteoweb/woocart/issues/336 cropping up.\r\n\r\nLong story: if the localization file has line breaks, the resulting store's page is rendered like so:\r\n\r\n<img width=\"514\" alt=\"46670842-93064600-cbd3-11e8-849b-058fba08ae82\" src=\"https://user-images.githubusercontent.com/311580/46919765-e3e1ba00-cf98-11e8-86cf-001f57a64e33.png\">\r\n\r\nThis exact bug was fixed with the following PR: https://github.com/woocart/localizations/pull/49/files\r\n\r\nWhat we need now is a way to prevent such bugs re-appearing. One idea: we could say that every line that starts with a `<p>` must end with `</p>`. Same for `<li>` and `</li>`. But I'm sure there will be exceptions so we need a way to skip an arbitrary line, possibly with a comment `<!-- noqa -->`."},"comment":{"url":"https://api.github.com/repos/woocart/localizations/issues/comments/451675776","html_url":"https://github.com/woocart/localizations/issues/61#issuecomment-451675776","issue_url":"https://api.github.com/repos/woocart/localizations/issues/61","id":451675776,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTY3NTc3Ng==","user":{"login":"ikolar","id":11309,"node_id":"MDQ6VXNlcjExMzA5","avatar_url":"https://avatars3.githubusercontent.com/u/11309?v=4","gravatar_id":"","url":"https://api.github.com/users/ikolar","html_url":"https://github.com/ikolar","followers_url":"https://api.github.com/users/ikolar/followers","following_url":"https://api.github.com/users/ikolar/following{/other_user}","gists_url":"https://api.github.com/users/ikolar/gists{/gist_id}","starred_url":"https://api.github.com/users/ikolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikolar/subscriptions","organizations_url":"https://api.github.com/users/ikolar/orgs","repos_url":"https://api.github.com/users/ikolar/repos","events_url":"https://api.github.com/users/ikolar/events{/privacy}","received_events_url":"https://api.github.com/users/ikolar/received_events","type":"User","site_admin":false},"created_at":"2019-01-05T17:45:27Z","updated_at":"2019-01-05T17:45:27Z","author_association":"COLLABORATOR","body":"Did a manual check with a simple sed script. Found only one problem, and fixed that.\r\n\r\nFor something more thorough, we could use a html linter maybe?"}}
{"actor":{"display_login":"ikolar"}}