{"action":"created","issue":{"url":"https://api.github.com/repos/runconduit/conduit/issues/412","repository_url":"https://api.github.com/repos/runconduit/conduit","labels_url":"https://api.github.com/repos/runconduit/conduit/issues/412/labels{/name}","comments_url":"https://api.github.com/repos/runconduit/conduit/issues/412/comments","events_url":"https://api.github.com/repos/runconduit/conduit/issues/412/events","html_url":"https://github.com/runconduit/conduit/issues/412","id":299179906,"number":412,"title":"Replace timeout.rs with tower-timeout","user":{"login":"hawkw","id":2796466,"avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"labels":[{"id":773709989,"url":"https://api.github.com/repos/runconduit/conduit/labels/proxy","name":"proxy","color":"dea584","default":false}],"state":"open","locked":false,"assignee":{"login":"hawkw","id":2796466,"avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"assignees":[{"login":"hawkw","id":2796466,"avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-02-22T00:27:46Z","updated_at":"2018-02-22T00:29:14Z","closed_at":null,"author_association":"MEMBER","body":"[`proxy/timeout.rs`](https://github.com/runconduit/conduit/blob/master/proxy/src/timeout.rs) contains an implementation of a timeout Tower middleware. `tower` also contains a [`tower-timeout`](https://github.com/tower-rs/tower/tree/master/tower-timeout) crate that does pretty much the same thing. We may want to replace our hand-rolled timeout implementation with the middleware in `tower-timeout`."},"comment":{"url":"https://api.github.com/repos/runconduit/conduit/issues/comments/367525712","html_url":"https://github.com/runconduit/conduit/issues/412#issuecomment-367525712","issue_url":"https://api.github.com/repos/runconduit/conduit/issues/412","id":367525712,"user":{"login":"hawkw","id":2796466,"avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T00:29:14Z","updated_at":"2018-02-22T00:29:14Z","author_association":"MEMBER","body":"One potential sticking point is that our `Timeout` and its associated response future also have  `tokio_connect::Connect`/`Connected` impls, respectively, that `tower-timeout` lacks. We can't add these impls due to the orphan rules, so we'd need to introduce a newtype or something."}}
{"actor":{"display_login":"hawkw"}}