{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/183017167","pull_request_review_id":113935692,"id":183017167,"diff_hunk":"@@ -6,7 +6,7 @@ buildscript {\n         mavenLocal()\n     }\n     dependencies {\n-        classpath 'com.android.tools.build:gradle:2.2.2'\n+        classpath 'com.android.tools.build:gradle:2.3.3'","path":"build.gradle","position":5,"original_position":5,"commit_id":"9664bc742379c7ff86a29280388fed7a1a09aa56","original_commit_id":"9664bc742379c7ff86a29280388fed7a1a09aa56","user":{"login":"DimitrisJim","id":8123587,"avatar_url":"https://avatars3.githubusercontent.com/u/8123587?v=4","gravatar_id":"","url":"https://api.github.com/users/DimitrisJim","html_url":"https://github.com/DimitrisJim","followers_url":"https://api.github.com/users/DimitrisJim/followers","following_url":"https://api.github.com/users/DimitrisJim/following{/other_user}","gists_url":"https://api.github.com/users/DimitrisJim/gists{/gist_id}","starred_url":"https://api.github.com/users/DimitrisJim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DimitrisJim/subscriptions","organizations_url":"https://api.github.com/users/DimitrisJim/orgs","repos_url":"https://api.github.com/users/DimitrisJim/repos","events_url":"https://api.github.com/users/DimitrisJim/events{/privacy}","received_events_url":"https://api.github.com/users/DimitrisJim/received_events","type":"User","site_admin":false},"body":"Also, shouldn't the `gradle-wrapper.properties` `distributionUrl` be bumped?","created_at":"2018-04-20T11:04:59Z","updated_at":"2018-04-20T11:04:59Z","html_url":"https://github.com/facebook/react-native/pull/17741#discussion_r183017167","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/17741","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/183017167"},"html":{"href":"https://github.com/facebook/react-native/pull/17741#discussion_r183017167"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/17741"}},"in_reply_to_id":183016997},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/17741","id":165151608,"html_url":"https://github.com/facebook/react-native/pull/17741","diff_url":"https://github.com/facebook/react-native/pull/17741.diff","patch_url":"https://github.com/facebook/react-native/pull/17741.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/17741","number":17741,"state":"open","locked":false,"title":"Update all the android related projects to target API level 27","user":{"login":"SandroMachado","id":631739,"avatar_url":"https://avatars2.githubusercontent.com/u/631739?v=4","gravatar_id":"","url":"https://api.github.com/users/SandroMachado","html_url":"https://github.com/SandroMachado","followers_url":"https://api.github.com/users/SandroMachado/followers","following_url":"https://api.github.com/users/SandroMachado/following{/other_user}","gists_url":"https://api.github.com/users/SandroMachado/gists{/gist_id}","starred_url":"https://api.github.com/users/SandroMachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SandroMachado/subscriptions","organizations_url":"https://api.github.com/users/SandroMachado/orgs","repos_url":"https://api.github.com/users/SandroMachado/repos","events_url":"https://api.github.com/users/SandroMachado/events{/privacy}","received_events_url":"https://api.github.com/users/SandroMachado/received_events","type":"User","site_admin":false},"body":"## Motivation\r\n\r\nGoogle recently announced in a blog post called [Improving app security and performance on Google Play for years to come](https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html) that all the new apps submitted to the play store, after August 2018,  will require to be targeting at least Android API level 26:\r\n\r\n>August 2018: New apps required to target API level 26 (Android 8.0) or higher.\r\n\r\n>November 2018: Updates to existing apps required to target API level 26 or higher.\r\n\r\n> 2019 onwards: Each year the targetSdkVersion requirement will advance. Within one year following each Android dessert release, new apps and app updates will need to target the corresponding API level or higher.\r\n\r\nThis PR updates all the Android related projects (ReactAndroid, RNTester and the HelloWorld template) to target the API level 27.\r\n\r\nI did not find any issue doing this upgrade but since RN was targeting version API level 22, the developers need to be aware that targeting any **API level greater that 22 will introduce the [run time permissions feature](https://developer.android.com/training/permissions/requesting.html)**. Since this is a breaking change it should be described in the `changelog`.\r\n\r\nThis PR also closes https://github.com/facebook/react-native/issues/17287.\r\n\r\n## Test Plan\r\n\r\nI tested the project and LGTM. I compiled and executed the RNTester and everything looks good.\r\n\r\n![screenshot_20180125-153317](https://user-images.githubusercontent.com/631739/35396707-551dcd94-01e5-11e8-96bd-b1c56688edc9.jpg) \r\n\r\n## Related PRs\r\n\r\n(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)\r\n\r\n## Release Notes\r\n\r\n [CLI] [FEATURE] [local-cli/generator/templates] - Generate the android app template targeting API level 27.\r\n [ANDROID] [FEATURE] [BuildTools] - Updates the Android project to target  API level 27.\r\n","created_at":"2018-01-25T15:39:29Z","updated_at":"2018-04-20T11:04:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bde7d9a083c2acde0fce3d5a78c8a2be32fc2c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":869759799,"url":"https://api.github.com/repos/facebook/react-native/labels/:clipboard:Release%20Notes","name":":clipboard:Release Notes","color":"0e8a16","default":false},{"id":857091288,"url":"https://api.github.com/repos/facebook/react-native/labels/:computer:CLI","name":":computer:CLI","color":"fef2c0","default":false},{"id":870851515,"url":"https://api.github.com/repos/facebook/react-native/labels/:large_blue_diamond:Android","name":":large_blue_diamond:Android","color":"bfd4f2","default":false},{"id":872547321,"url":"https://api.github.com/repos/facebook/react-native/labels/:star2:Enhancement%20PR","name":":star2:Enhancement PR","color":"0e8a16","default":false},{"id":468774151,"url":"https://api.github.com/repos/facebook/react-native/labels/Core%20Team","name":"Core Team","color":"0052cc","default":false},{"id":337217254,"url":"https://api.github.com/repos/facebook/react-native/labels/Ran%20Commands","name":"Ran Commands","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/17741/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/17741/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/17741/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/9664bc742379c7ff86a29280388fed7a1a09aa56","head":{"label":"uphold-forks:support/bump-target-api-level-27","ref":"support/bump-target-api-level-27","sha":"9664bc742379c7ff86a29280388fed7a1a09aa56","user":{"login":"uphold-forks","id":17198022,"avatar_url":"https://avatars3.githubusercontent.com/u/17198022?v=4","gravatar_id":"","url":"https://api.github.com/users/uphold-forks","html_url":"https://github.com/uphold-forks","followers_url":"https://api.github.com/users/uphold-forks/followers","following_url":"https://api.github.com/users/uphold-forks/following{/other_user}","gists_url":"https://api.github.com/users/uphold-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/uphold-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uphold-forks/subscriptions","organizations_url":"https://api.github.com/users/uphold-forks/orgs","repos_url":"https://api.github.com/users/uphold-forks/repos","events_url":"https://api.github.com/users/uphold-forks/events{/privacy}","received_events_url":"https://api.github.com/users/uphold-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":73433380,"name":"react-native","full_name":"uphold-forks/react-native","owner":{"login":"uphold-forks","id":17198022,"avatar_url":"https://avatars3.githubusercontent.com/u/17198022?v=4","gravatar_id":"","url":"https://api.github.com/users/uphold-forks","html_url":"https://github.com/uphold-forks","followers_url":"https://api.github.com/users/uphold-forks/followers","following_url":"https://api.github.com/users/uphold-forks/following{/other_user}","gists_url":"https://api.github.com/users/uphold-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/uphold-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uphold-forks/subscriptions","organizations_url":"https://api.github.com/users/uphold-forks/orgs","repos_url":"https://api.github.com/users/uphold-forks/repos","events_url":"https://api.github.com/users/uphold-forks/events{/privacy}","received_events_url":"https://api.github.com/users/uphold-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uphold-forks/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/uphold-forks/react-native","forks_url":"https://api.github.com/repos/uphold-forks/react-native/forks","keys_url":"https://api.github.com/repos/uphold-forks/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uphold-forks/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uphold-forks/react-native/teams","hooks_url":"https://api.github.com/repos/uphold-forks/react-native/hooks","issue_events_url":"https://api.github.com/repos/uphold-forks/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/uphold-forks/react-native/events","assignees_url":"https://api.github.com/repos/uphold-forks/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/uphold-forks/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/uphold-forks/react-native/tags","blobs_url":"https://api.github.com/repos/uphold-forks/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uphold-forks/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uphold-forks/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/uphold-forks/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uphold-forks/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/uphold-forks/react-native/languages","stargazers_url":"https://api.github.com/repos/uphold-forks/react-native/stargazers","contributors_url":"https://api.github.com/repos/uphold-forks/react-native/contributors","subscribers_url":"https://api.github.com/repos/uphold-forks/react-native/subscribers","subscription_url":"https://api.github.com/repos/uphold-forks/react-native/subscription","commits_url":"https://api.github.com/repos/uphold-forks/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/uphold-forks/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/uphold-forks/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/uphold-forks/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/uphold-forks/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/uphold-forks/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uphold-forks/react-native/merges","archive_url":"https://api.github.com/repos/uphold-forks/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uphold-forks/react-native/downloads","issues_url":"https://api.github.com/repos/uphold-forks/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/uphold-forks/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/uphold-forks/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/uphold-forks/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uphold-forks/react-native/labels{/name}","releases_url":"https://api.github.com/repos/uphold-forks/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/uphold-forks/react-native/deployments","created_at":"2016-11-11T00:49:46Z","updated_at":"2016-11-11T00:49:57Z","pushed_at":"2018-03-13T21:15:15Z","git_url":"git://github.com/uphold-forks/react-native.git","ssh_url":"git@github.com:uphold-forks/react-native.git","clone_url":"https://github.com/uphold-forks/react-native.git","svn_url":"https://github.com/uphold-forks/react-native","homepage":"http://facebook.github.io/react-native/","size":140864,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"c136c54ff0211e2bf149fab600cd6e295f9d19dd","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2018-04-20T10:45:47Z","pushed_at":"2018-04-19T22:51:12Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":219308,"stargazers_count":62847,"watchers_count":62847,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14276,"mirror_url":null,"archived":false,"open_issues_count":728,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":14276,"open_issues":728,"watchers":62847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/17741"},"html":{"href":"https://github.com/facebook/react-native/pull/17741"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/17741"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/17741/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/17741/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/17741/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/9664bc742379c7ff86a29280388fed7a1a09aa56"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DimitrisJim"}}