{"action":"closed","issue":{"url":"https://api.github.com/repos/nightwatchjs/nightwatch/issues/1891","repository_url":"https://api.github.com/repos/nightwatchjs/nightwatch","labels_url":"https://api.github.com/repos/nightwatchjs/nightwatch/issues/1891/labels{/name}","comments_url":"https://api.github.com/repos/nightwatchjs/nightwatch/issues/1891/comments","events_url":"https://api.github.com/repos/nightwatchjs/nightwatch/issues/1891/events","html_url":"https://github.com/nightwatchjs/nightwatch/issues/1891","id":363738871,"node_id":"MDU6SXNzdWUzNjM3Mzg4NzE=","number":1891,"title":"Documentation on waitFor commands: time parameter should be optional","user":{"login":"barelyfitz","id":185461,"node_id":"MDQ6VXNlcjE4NTQ2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/185461?v=4","gravatar_id":"","url":"https://api.github.com/users/barelyfitz","html_url":"https://github.com/barelyfitz","followers_url":"https://api.github.com/users/barelyfitz/followers","following_url":"https://api.github.com/users/barelyfitz/following{/other_user}","gists_url":"https://api.github.com/users/barelyfitz/gists{/gist_id}","starred_url":"https://api.github.com/users/barelyfitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barelyfitz/subscriptions","organizations_url":"https://api.github.com/users/barelyfitz/orgs","repos_url":"https://api.github.com/users/barelyfitz/repos","events_url":"https://api.github.com/users/barelyfitz/events{/privacy}","received_events_url":"https://api.github.com/users/barelyfitz/received_events","type":"User","site_admin":false},"labels":[{"id":200845125,"node_id":"MDU6TGFiZWwyMDA4NDUxMjU=","url":"https://api.github.com/repos/nightwatchjs/nightwatch/labels/api%20docs","name":"api docs","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-25T19:48:07Z","updated_at":"2018-12-17T19:52:53Z","closed_at":"2018-12-17T19:52:53Z","author_association":"CONTRIBUTOR","body":"On the documentation pages for `waitFor` commands, there is a note that specifies:\r\n\r\n> A default timeout can be specified as a global waitForConditionTimeout property (in milliseconds).\r\n\r\nHowever, in the `Parameters` table, the `time` parameter is listed as a required parameter. Please change it to an optional parameter, and perhaps add more examples to the usage section:\r\n\r\n```\r\n// Wait until the element is visible (using the global timeout)\r\nbrowser.waitForElementVisible('body')\r\n\r\n// Wait until the element is visible (using the global timeout) then call a function\r\nbrowser.waitForElementVisible('body', function() {\r\n  // do something while we're here\r\n});\r\n```\r\n\r\nThe following commands are affected:\r\n- http://nightwatchjs.org/api#waitForElementNotPresent\r\n- http://nightwatchjs.org/api#waitForElementNotVisible\r\n- http://nightwatchjs.org/api#waitForElementPresent\r\n- http://nightwatchjs.org/api#waitForElementVisible\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"beatfactor"}}