{"action":"created","comment":{"url":"https://api.github.com/repos/tyfkda/xv6/pulls/comments/211470157","pull_request_review_id":147895254,"id":211470157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTQ3MDE1Nw==","diff_hunk":"@@ -2,6 +2,8 @@\n #include \"sys/stat.h\"\n #include \"unistd.h\"\n \n+extern char **environ;","path":"ulib/ulib.c","position":null,"original_position":4,"commit_id":"71c33331813f80a438eeafa1f91ea08b4ad29d9a","original_commit_id":"666f064e7e5730b486f426b0e2aea9b72d9afefd","user":{"login":"takeharukato","id":15859044,"node_id":"MDQ6VXNlcjE1ODU5MDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/15859044?v=4","gravatar_id":"","url":"https://api.github.com/users/takeharukato","html_url":"https://github.com/takeharukato","followers_url":"https://api.github.com/users/takeharukato/followers","following_url":"https://api.github.com/users/takeharukato/following{/other_user}","gists_url":"https://api.github.com/users/takeharukato/gists{/gist_id}","starred_url":"https://api.github.com/users/takeharukato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takeharukato/subscriptions","organizations_url":"https://api.github.com/users/takeharukato/orgs","repos_url":"https://api.github.com/users/takeharukato/repos","events_url":"https://api.github.com/users/takeharukato/events{/privacy}","received_events_url":"https://api.github.com/users/takeharukato/received_events","type":"User","site_admin":false},"body":"Right.\r\nI've removed it.\r\n","created_at":"2018-08-21T03:40:16Z","updated_at":"2018-08-21T03:40:16Z","html_url":"https://github.com/tyfkda/xv6/pull/25#discussion_r211470157","pull_request_url":"https://api.github.com/repos/tyfkda/xv6/pulls/25","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tyfkda/xv6/pulls/comments/211470157"},"html":{"href":"https://github.com/tyfkda/xv6/pull/25#discussion_r211470157"},"pull_request":{"href":"https://api.github.com/repos/tyfkda/xv6/pulls/25"}},"in_reply_to_id":211279282},"pull_request":{"url":"https://api.github.com/repos/tyfkda/xv6/pulls/25","id":208853288,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4ODUzMjg4","html_url":"https://github.com/tyfkda/xv6/pull/25","diff_url":"https://github.com/tyfkda/xv6/pull/25.diff","patch_url":"https://github.com/tyfkda/xv6/pull/25.patch","issue_url":"https://api.github.com/repos/tyfkda/xv6/issues/25","number":25,"state":"open","locked":false,"title":"Add the execve system call version 1.","user":{"login":"takeharukato","id":15859044,"node_id":"MDQ6VXNlcjE1ODU5MDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/15859044?v=4","gravatar_id":"","url":"https://api.github.com/users/takeharukato","html_url":"https://github.com/takeharukato","followers_url":"https://api.github.com/users/takeharukato/followers","following_url":"https://api.github.com/users/takeharukato/following{/other_user}","gists_url":"https://api.github.com/users/takeharukato/gists{/gist_id}","starred_url":"https://api.github.com/users/takeharukato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takeharukato/subscriptions","organizations_url":"https://api.github.com/users/takeharukato/orgs","repos_url":"https://api.github.com/users/takeharukato/repos","events_url":"https://api.github.com/users/takeharukato/events{/privacy}","received_events_url":"https://api.github.com/users/takeharukato/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nAs you said in Environment variable #15 , xv6 cannot handle environment variable properly.\r\nOne of the reasons of this, it does not have execve(2) system call.\r\nI wrote a patch to implement execve(2) for xv6 as a trial.\r\n\r\nWould you please look into it and give it a try if you can?\r\n\r\nP.S. Implementing exec(2) system call in a user land library might be more preferable way.\r\nIn addition to this, I did not modify the shell application. Some modification might be needed for the shell. \r\n\r\nThanks,\r\nRegards,\r\n\r\n","created_at":"2018-08-16T13:08:02Z","updated_at":"2018-08-21T03:40:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d51fa39b1d533be064681f47da92e4302cb2566","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tyfkda/xv6/pulls/25/commits","review_comments_url":"https://api.github.com/repos/tyfkda/xv6/pulls/25/comments","review_comment_url":"https://api.github.com/repos/tyfkda/xv6/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tyfkda/xv6/issues/25/comments","statuses_url":"https://api.github.com/repos/tyfkda/xv6/statuses/71c33331813f80a438eeafa1f91ea08b4ad29d9a","head":{"label":"takeharukato:devel-tkato-execfix","ref":"devel-tkato-execfix","sha":"71c33331813f80a438eeafa1f91ea08b4ad29d9a","user":{"login":"takeharukato","id":15859044,"node_id":"MDQ6VXNlcjE1ODU5MDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/15859044?v=4","gravatar_id":"","url":"https://api.github.com/users/takeharukato","html_url":"https://github.com/takeharukato","followers_url":"https://api.github.com/users/takeharukato/followers","following_url":"https://api.github.com/users/takeharukato/following{/other_user}","gists_url":"https://api.github.com/users/takeharukato/gists{/gist_id}","starred_url":"https://api.github.com/users/takeharukato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takeharukato/subscriptions","organizations_url":"https://api.github.com/users/takeharukato/orgs","repos_url":"https://api.github.com/users/takeharukato/repos","events_url":"https://api.github.com/users/takeharukato/events{/privacy}","received_events_url":"https://api.github.com/users/takeharukato/received_events","type":"User","site_admin":false},"repo":{"id":144420150,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ0MjAxNTA=","name":"xv6","full_name":"takeharukato/xv6","owner":{"login":"takeharukato","id":15859044,"node_id":"MDQ6VXNlcjE1ODU5MDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/15859044?v=4","gravatar_id":"","url":"https://api.github.com/users/takeharukato","html_url":"https://github.com/takeharukato","followers_url":"https://api.github.com/users/takeharukato/followers","following_url":"https://api.github.com/users/takeharukato/following{/other_user}","gists_url":"https://api.github.com/users/takeharukato/gists{/gist_id}","starred_url":"https://api.github.com/users/takeharukato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takeharukato/subscriptions","organizations_url":"https://api.github.com/users/takeharukato/orgs","repos_url":"https://api.github.com/users/takeharukato/repos","events_url":"https://api.github.com/users/takeharukato/events{/privacy}","received_events_url":"https://api.github.com/users/takeharukato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/takeharukato/xv6","description":"64bit port of xv6","fork":true,"url":"https://api.github.com/repos/takeharukato/xv6","forks_url":"https://api.github.com/repos/takeharukato/xv6/forks","keys_url":"https://api.github.com/repos/takeharukato/xv6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takeharukato/xv6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takeharukato/xv6/teams","hooks_url":"https://api.github.com/repos/takeharukato/xv6/hooks","issue_events_url":"https://api.github.com/repos/takeharukato/xv6/issues/events{/number}","events_url":"https://api.github.com/repos/takeharukato/xv6/events","assignees_url":"https://api.github.com/repos/takeharukato/xv6/assignees{/user}","branches_url":"https://api.github.com/repos/takeharukato/xv6/branches{/branch}","tags_url":"https://api.github.com/repos/takeharukato/xv6/tags","blobs_url":"https://api.github.com/repos/takeharukato/xv6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takeharukato/xv6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takeharukato/xv6/git/refs{/sha}","trees_url":"https://api.github.com/repos/takeharukato/xv6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takeharukato/xv6/statuses/{sha}","languages_url":"https://api.github.com/repos/takeharukato/xv6/languages","stargazers_url":"https://api.github.com/repos/takeharukato/xv6/stargazers","contributors_url":"https://api.github.com/repos/takeharukato/xv6/contributors","subscribers_url":"https://api.github.com/repos/takeharukato/xv6/subscribers","subscription_url":"https://api.github.com/repos/takeharukato/xv6/subscription","commits_url":"https://api.github.com/repos/takeharukato/xv6/commits{/sha}","git_commits_url":"https://api.github.com/repos/takeharukato/xv6/git/commits{/sha}","comments_url":"https://api.github.com/repos/takeharukato/xv6/comments{/number}","issue_comment_url":"https://api.github.com/repos/takeharukato/xv6/issues/comments{/number}","contents_url":"https://api.github.com/repos/takeharukato/xv6/contents/{+path}","compare_url":"https://api.github.com/repos/takeharukato/xv6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takeharukato/xv6/merges","archive_url":"https://api.github.com/repos/takeharukato/xv6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takeharukato/xv6/downloads","issues_url":"https://api.github.com/repos/takeharukato/xv6/issues{/number}","pulls_url":"https://api.github.com/repos/takeharukato/xv6/pulls{/number}","milestones_url":"https://api.github.com/repos/takeharukato/xv6/milestones{/number}","notifications_url":"https://api.github.com/repos/takeharukato/xv6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takeharukato/xv6/labels{/name}","releases_url":"https://api.github.com/repos/takeharukato/xv6/releases{/id}","deployments_url":"https://api.github.com/repos/takeharukato/xv6/deployments","created_at":"2018-08-11T21:47:11Z","updated_at":"2018-08-16T14:18:32Z","pushed_at":"2018-08-21T03:39:39Z","git_url":"git://github.com/takeharukato/xv6.git","ssh_url":"git@github.com:takeharukato/xv6.git","clone_url":"https://github.com/takeharukato/xv6.git","svn_url":"https://github.com/takeharukato/xv6","homepage":"","size":13419,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tyfkda:master","ref":"master","sha":"3a0f66dfa992d6d1eef5637d8c639af5d025e97e","user":{"login":"tyfkda","id":7347125,"node_id":"MDQ6VXNlcjczNDcxMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7347125?v=4","gravatar_id":"","url":"https://api.github.com/users/tyfkda","html_url":"https://github.com/tyfkda","followers_url":"https://api.github.com/users/tyfkda/followers","following_url":"https://api.github.com/users/tyfkda/following{/other_user}","gists_url":"https://api.github.com/users/tyfkda/gists{/gist_id}","starred_url":"https://api.github.com/users/tyfkda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyfkda/subscriptions","organizations_url":"https://api.github.com/users/tyfkda/orgs","repos_url":"https://api.github.com/users/tyfkda/repos","events_url":"https://api.github.com/users/tyfkda/events{/privacy}","received_events_url":"https://api.github.com/users/tyfkda/received_events","type":"User","site_admin":false},"repo":{"id":136849162,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY4NDkxNjI=","name":"xv6","full_name":"tyfkda/xv6","owner":{"login":"tyfkda","id":7347125,"node_id":"MDQ6VXNlcjczNDcxMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7347125?v=4","gravatar_id":"","url":"https://api.github.com/users/tyfkda","html_url":"https://github.com/tyfkda","followers_url":"https://api.github.com/users/tyfkda/followers","following_url":"https://api.github.com/users/tyfkda/following{/other_user}","gists_url":"https://api.github.com/users/tyfkda/gists{/gist_id}","starred_url":"https://api.github.com/users/tyfkda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyfkda/subscriptions","organizations_url":"https://api.github.com/users/tyfkda/orgs","repos_url":"https://api.github.com/users/tyfkda/repos","events_url":"https://api.github.com/users/tyfkda/events{/privacy}","received_events_url":"https://api.github.com/users/tyfkda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tyfkda/xv6","description":"64bit port of xv6","fork":true,"url":"https://api.github.com/repos/tyfkda/xv6","forks_url":"https://api.github.com/repos/tyfkda/xv6/forks","keys_url":"https://api.github.com/repos/tyfkda/xv6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tyfkda/xv6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tyfkda/xv6/teams","hooks_url":"https://api.github.com/repos/tyfkda/xv6/hooks","issue_events_url":"https://api.github.com/repos/tyfkda/xv6/issues/events{/number}","events_url":"https://api.github.com/repos/tyfkda/xv6/events","assignees_url":"https://api.github.com/repos/tyfkda/xv6/assignees{/user}","branches_url":"https://api.github.com/repos/tyfkda/xv6/branches{/branch}","tags_url":"https://api.github.com/repos/tyfkda/xv6/tags","blobs_url":"https://api.github.com/repos/tyfkda/xv6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tyfkda/xv6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tyfkda/xv6/git/refs{/sha}","trees_url":"https://api.github.com/repos/tyfkda/xv6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tyfkda/xv6/statuses/{sha}","languages_url":"https://api.github.com/repos/tyfkda/xv6/languages","stargazers_url":"https://api.github.com/repos/tyfkda/xv6/stargazers","contributors_url":"https://api.github.com/repos/tyfkda/xv6/contributors","subscribers_url":"https://api.github.com/repos/tyfkda/xv6/subscribers","subscription_url":"https://api.github.com/repos/tyfkda/xv6/subscription","commits_url":"https://api.github.com/repos/tyfkda/xv6/commits{/sha}","git_commits_url":"https://api.github.com/repos/tyfkda/xv6/git/commits{/sha}","comments_url":"https://api.github.com/repos/tyfkda/xv6/comments{/number}","issue_comment_url":"https://api.github.com/repos/tyfkda/xv6/issues/comments{/number}","contents_url":"https://api.github.com/repos/tyfkda/xv6/contents/{+path}","compare_url":"https://api.github.com/repos/tyfkda/xv6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tyfkda/xv6/merges","archive_url":"https://api.github.com/repos/tyfkda/xv6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tyfkda/xv6/downloads","issues_url":"https://api.github.com/repos/tyfkda/xv6/issues{/number}","pulls_url":"https://api.github.com/repos/tyfkda/xv6/pulls{/number}","milestones_url":"https://api.github.com/repos/tyfkda/xv6/milestones{/number}","notifications_url":"https://api.github.com/repos/tyfkda/xv6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tyfkda/xv6/labels{/name}","releases_url":"https://api.github.com/repos/tyfkda/xv6/releases{/id}","deployments_url":"https://api.github.com/repos/tyfkda/xv6/deployments","created_at":"2018-06-10T22:20:26Z","updated_at":"2018-08-18T13:52:56Z","pushed_at":"2018-08-21T03:39:40Z","git_url":"git://github.com/tyfkda/xv6.git","ssh_url":"git@github.com:tyfkda/xv6.git","clone_url":"https://github.com/tyfkda/xv6.git","svn_url":"https://github.com/tyfkda/xv6","homepage":"","size":13361,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":15,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tyfkda/xv6/pulls/25"},"html":{"href":"https://github.com/tyfkda/xv6/pull/25"},"issue":{"href":"https://api.github.com/repos/tyfkda/xv6/issues/25"},"comments":{"href":"https://api.github.com/repos/tyfkda/xv6/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/tyfkda/xv6/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/tyfkda/xv6/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tyfkda/xv6/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/tyfkda/xv6/statuses/71c33331813f80a438eeafa1f91ea08b4ad29d9a"}},"author_association":"NONE"}}
{"actor":{"display_login":"takeharukato"}}