{"action":"created","issue":{"url":"https://api.github.com/repos/square/p2/issues/1061","repository_url":"https://api.github.com/repos/square/p2","labels_url":"https://api.github.com/repos/square/p2/issues/1061/labels{/name}","comments_url":"https://api.github.com/repos/square/p2/issues/1061/comments","events_url":"https://api.github.com/repos/square/p2/issues/1061/events","html_url":"https://github.com/square/p2/pull/1061","id":334524462,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NDc1MDAz","number":1061,"title":"Modify p2-preparer to read pod whitelist from p2-may-run(require file)","user":{"login":"akun1012","id":3346348,"node_id":"MDQ6VXNlcjMzNDYzNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3346348?v=4","gravatar_id":"","url":"https://api.github.com/users/akun1012","html_url":"https://github.com/akun1012","followers_url":"https://api.github.com/users/akun1012/followers","following_url":"https://api.github.com/users/akun1012/following{/other_user}","gists_url":"https://api.github.com/users/akun1012/gists{/gist_id}","starred_url":"https://api.github.com/users/akun1012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akun1012/subscriptions","organizations_url":"https://api.github.com/users/akun1012/orgs","repos_url":"https://api.github.com/users/akun1012/repos","events_url":"https://api.github.com/users/akun1012/events{/privacy}","received_events_url":"https://api.github.com/users/akun1012/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-21T14:38:16Z","updated_at":"2018-06-21T17:30:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/1061","html_url":"https://github.com/square/p2/pull/1061","diff_url":"https://github.com/square/p2/pull/1061.diff","patch_url":"https://github.com/square/p2/pull/1061.patch"},"body":"Previously p2-may-run is an empty file, services as a signal that the hose is set up, and p2-prepare can start work. The new requirement is when p2-prepare restarted, and intent store is not empty, p2-prepare need to install some of the specific important pods first(mostly daemon sets ), then start normally working to watch other and new intents. We store the white list in p2-may-run file, splitting the podIDs with spaces, and let p2-prepare prepare them first."},"comment":{"url":"https://api.github.com/repos/square/p2/issues/comments/399183023","html_url":"https://github.com/square/p2/pull/1061#issuecomment-399183023","issue_url":"https://api.github.com/repos/square/p2/issues/1061","id":399183023,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTE4MzAyMw==","user":{"login":"akun1012","id":3346348,"node_id":"MDQ6VXNlcjMzNDYzNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3346348?v=4","gravatar_id":"","url":"https://api.github.com/users/akun1012","html_url":"https://github.com/akun1012","followers_url":"https://api.github.com/users/akun1012/followers","following_url":"https://api.github.com/users/akun1012/following{/other_user}","gists_url":"https://api.github.com/users/akun1012/gists{/gist_id}","starred_url":"https://api.github.com/users/akun1012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akun1012/subscriptions","organizations_url":"https://api.github.com/users/akun1012/orgs","repos_url":"https://api.github.com/users/akun1012/repos","events_url":"https://api.github.com/users/akun1012/events{/privacy}","received_events_url":"https://api.github.com/users/akun1012/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T17:30:27Z","updated_at":"2018-06-21T17:30:27Z","author_association":"CONTRIBUTOR","body":"@spenceral \r\n\"If the require file is a non zero byte file, will the preparer's WatchForPodManifestsForNode loop still install any and all pods in intent?\"\r\nThe answer is no, although watchPods() will signal all pods from intent for the first time, but p2-prepare will compare the intent and reality menifests SHAs, if same, no installation will happen for the pods."}}
{"actor":{"display_login":"akun1012"}}