{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments/230233484","pull_request_review_id":170925749,"id":230233484,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDIzMzQ4NA==","diff_hunk":"@@ -0,0 +1,129 @@\n+// +build k8srequired\n+\n+package deletionerror\n+\n+import (\n+\t\"context\"\n+\t\"testing\"\n+\t\"time\"\n+)\n+\n+func Test_Informer_Integration_DeletionError(t *testing.T) {\n+\tmustSetup()\n+\tdefer mustTeardown()\n+\n+\tidOne := \"al7qy\"\n+\tidTwo := \"al8qy\"\n+\tctx, cancelFunc := context.WithCancel(context.Background())\n+\tdefer cancelFunc()\n+\n+\toperatorkitInformer, filterWatcher, err := newOperatorkitInformerAndWatcher(time.Second*2, time.Second*10)\n+\tif err != nil {\n+\t\tt.Fatal(\"expected\", nil, \"got\", err)\n+\t}\n+\n+\t// We create two config maps before starting the informer watch. This causes\n+\t// the informer to fill the cache and to initially sent cached events to the\n+\t// delete and update channels provided by the watch.\n+\terr = createConfigMap(idOne)\n+\tif err != nil {\n+\t\tt.Fatal(\"expected\", nil, \"got\", err)\n+\t}\n+\terr = createConfigMap(idTwo)\n+\tif err != nil {\n+\t\tt.Fatal(\"expected\", nil, \"got\", err)\n+\t}\n+\n+\t// When there are the config maps in the Kubernetes API we start the watch.\n+\tdeleteChan, updateChan, errChan := operatorkitInformer.Watch(ctx)\n+\n+\t// We define a general control goroutine to stop test execution on errors or\n+\t// after timeouts. The timeout is 25 seconds because of two resync periods,\n+\t// one rate limit wait period, plus some time buffer for all the test magic\n+\t// happening here: (2 * 10) + 2 + buffer.\n+\tgo func() {\n+\t\tfor {\n+\t\t\tselect {\n+\t\t\tcase <-time.After(25 * time.Second):\n+\t\t\t\tt.Fatalf(\"expected proper test execution got timeout\")\n+\t\t\tcase err := <-errChan:\n+\t\t\t\tif err != nil {\n+\t\t\t\t\tt.Fatalf(\"expected %#v got %#v\", nil, err)\n+\t\t\t\t}\n+\t\t\tcase <-ctx.Done():\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t}\n+\t}()\n+\n+\t// Due to the two created config maps we get two events in the informer which\n+\t// we simply drain here because they stand in our way of testing the actual\n+\t// matter of delete events. When anything else is weird with the informer and\n+\t// the channels hang on this stage then the test will time out due to the\n+\t// safety goroutine above.","path":"informer/integration/test/deletionerror/deletion_error_test.go","position":63,"original_position":63,"commit_id":"34bcdcd5c6fcce4812364c956376abb12fd339f6","original_commit_id":"95b5e86bbf1ac33ba60acbd912818f341e6724b0","user":{"login":"xh3b4sd","id":552769,"node_id":"MDQ6VXNlcjU1Mjc2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/552769?v=4","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false},"body":"I am not sure what you mean or how this should look like. ","created_at":"2018-11-01T23:36:12Z","updated_at":"2018-11-01T23:36:13Z","html_url":"https://github.com/giantswarm/operatorkit/pull/245#discussion_r230233484","pull_request_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/245","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments/230233484"},"html":{"href":"https://github.com/giantswarm/operatorkit/pull/245#discussion_r230233484"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/245"}},"in_reply_to_id":229957923},"pull_request":{"url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/245","id":227453027,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDUzMDI3","html_url":"https://github.com/giantswarm/operatorkit/pull/245","diff_url":"https://github.com/giantswarm/operatorkit/pull/245.diff","patch_url":"https://github.com/giantswarm/operatorkit/pull/245.patch","issue_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/245","number":245,"state":"open","locked":false,"title":"adds e2e test for informer deletion error","user":{"login":"xh3b4sd","id":552769,"node_id":"MDQ6VXNlcjU1Mjc2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/552769?v=4","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false},"body":"Towards https://github.com/giantswarm/giantswarm/issues/4433. Here I added a new e2e test for the informer. This test fails now and shows where the issue results into. I want to provide another PR based on this one and make the test green. ","created_at":"2018-10-31T21:49:47Z","updated_at":"2018-11-01T23:36:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"077629d64fe069d5f57dddd20b9606801db3e94d","assignee":{"login":"xh3b4sd","id":552769,"node_id":"MDQ6VXNlcjU1Mjc2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/552769?v=4","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false},"assignees":[{"login":"xh3b4sd","id":552769,"node_id":"MDQ6VXNlcjU1Mjc2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/552769?v=4","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/245/commits","review_comments_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/245/comments","review_comment_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/245/comments","statuses_url":"https://api.github.com/repos/giantswarm/operatorkit/statuses/34bcdcd5c6fcce4812364c956376abb12fd339f6","head":{"label":"giantswarm:deletion-error","ref":"deletion-error","sha":"34bcdcd5c6fcce4812364c956376abb12fd339f6","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":87818870,"node_id":"MDEwOlJlcG9zaXRvcnk4NzgxODg3MA==","name":"operatorkit","full_name":"giantswarm/operatorkit","private":false,"owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/giantswarm/operatorkit","description":"Package operatorkit implements an opinionated framework for developing Kubernetes operators.","fork":false,"url":"https://api.github.com/repos/giantswarm/operatorkit","forks_url":"https://api.github.com/repos/giantswarm/operatorkit/forks","keys_url":"https://api.github.com/repos/giantswarm/operatorkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/operatorkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/operatorkit/teams","hooks_url":"https://api.github.com/repos/giantswarm/operatorkit/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/operatorkit/events","assignees_url":"https://api.github.com/repos/giantswarm/operatorkit/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/operatorkit/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/operatorkit/tags","blobs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/operatorkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/operatorkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/operatorkit/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/operatorkit/languages","stargazers_url":"https://api.github.com/repos/giantswarm/operatorkit/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/operatorkit/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/operatorkit/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/operatorkit/subscription","commits_url":"https://api.github.com/repos/giantswarm/operatorkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/operatorkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/operatorkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/operatorkit/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/operatorkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/operatorkit/merges","archive_url":"https://api.github.com/repos/giantswarm/operatorkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/operatorkit/downloads","issues_url":"https://api.github.com/repos/giantswarm/operatorkit/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/operatorkit/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/operatorkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/operatorkit/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/operatorkit/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/operatorkit/deployments","created_at":"2017-04-10T14:12:58Z","updated_at":"2018-10-30T08:59:30Z","pushed_at":"2018-11-01T23:32:48Z","git_url":"git://github.com/giantswarm/operatorkit.git","ssh_url":"git@github.com:giantswarm/operatorkit.git","clone_url":"https://github.com/giantswarm/operatorkit.git","svn_url":"https://github.com/giantswarm/operatorkit","homepage":"https://godoc.org/github.com/giantswarm/operatorkit","size":33783,"stargazers_count":99,"watchers_count":99,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":7,"watchers":99,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"4409402cf31da7437585c0e0d40e4d35c70e3988","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":87818870,"node_id":"MDEwOlJlcG9zaXRvcnk4NzgxODg3MA==","name":"operatorkit","full_name":"giantswarm/operatorkit","private":false,"owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/giantswarm/operatorkit","description":"Package operatorkit implements an opinionated framework for developing Kubernetes operators.","fork":false,"url":"https://api.github.com/repos/giantswarm/operatorkit","forks_url":"https://api.github.com/repos/giantswarm/operatorkit/forks","keys_url":"https://api.github.com/repos/giantswarm/operatorkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/operatorkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/operatorkit/teams","hooks_url":"https://api.github.com/repos/giantswarm/operatorkit/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/operatorkit/events","assignees_url":"https://api.github.com/repos/giantswarm/operatorkit/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/operatorkit/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/operatorkit/tags","blobs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/operatorkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/operatorkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/operatorkit/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/operatorkit/languages","stargazers_url":"https://api.github.com/repos/giantswarm/operatorkit/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/operatorkit/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/operatorkit/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/operatorkit/subscription","commits_url":"https://api.github.com/repos/giantswarm/operatorkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/operatorkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/operatorkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/operatorkit/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/operatorkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/operatorkit/merges","archive_url":"https://api.github.com/repos/giantswarm/operatorkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/operatorkit/downloads","issues_url":"https://api.github.com/repos/giantswarm/operatorkit/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/operatorkit/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/operatorkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/operatorkit/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/operatorkit/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/operatorkit/deployments","created_at":"2017-04-10T14:12:58Z","updated_at":"2018-10-30T08:59:30Z","pushed_at":"2018-11-01T23:32:48Z","git_url":"git://github.com/giantswarm/operatorkit.git","ssh_url":"git@github.com:giantswarm/operatorkit.git","clone_url":"https://github.com/giantswarm/operatorkit.git","svn_url":"https://github.com/giantswarm/operatorkit","homepage":"https://godoc.org/github.com/giantswarm/operatorkit","size":33783,"stargazers_count":99,"watchers_count":99,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":7,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/245"},"html":{"href":"https://github.com/giantswarm/operatorkit/pull/245"},"issue":{"href":"https://api.github.com/repos/giantswarm/operatorkit/issues/245"},"comments":{"href":"https://api.github.com/repos/giantswarm/operatorkit/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/operatorkit/statuses/34bcdcd5c6fcce4812364c956376abb12fd339f6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"xh3b4sd"}}