{"action":"created","issue":{"url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2703","repository_url":"https://api.github.com/repos/OP-TEE/optee_os","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2703/labels{/name}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2703/comments","events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2703/events","html_url":"https://github.com/OP-TEE/optee_os/pull/2703","id":391208075,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4Nzk3NDQ4","number":2703,"title":"Introduce CFG_USER_TA_TARGETS to select user mode architecture(s)","user":{"login":"jforissier","id":8288195,"node_id":"MDQ6VXNlcjgyODgxOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/8288195?v=4","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-12-14T17:54:48Z","updated_at":"2018-12-18T09:01:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2703","html_url":"https://github.com/OP-TEE/optee_os/pull/2703","diff_url":"https://github.com/OP-TEE/optee_os/pull/2703.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/2703.patch"},"body":"```\r\nThis change introduces CFG_USER_TA_TARGETS to allow the configuration\r\ndirectives to select the architectures for which userspace TA and TA\r\nlibraries shall be built. The only use case for the moment is to be able\r\nto build only 32 or 64-bit libraries and TAs when the platform would\r\notherwise support both 32 and 64-bit. See the example below.\r\n\r\nIf CFG_USER_TA_TARGETS is undefined or empty, all the architectures\r\nsupported by the platform are built.\r\n\r\nIf CFG_USER_TA_TARGETS contains an unsupported value, the build will\r\nreport an error.\r\n\r\nExamples:\r\n\r\n $ make PLATFORM=hikey CFG_ARM64_core=y\r\n   # Builds both 32 and 64-bit userspace\r\n $ make PLATFORM=hikey CFG_ARM64_core=y \\\r\n        CFG_USER_TA_TARGETS=\"ta_arm32 ta_arm64\"\r\n   # Same as above\r\n $ make PLATFORM=hikey CFG_ARM64_core=y CFG_USER_TA_TARGETS=ta_arm32\r\n   # Builds only 32-bit userspace\r\n\r\nSigned-off-by: Jerome Forissier <jerome.forissier@linaro.org>\r\nSuggested-by: Etienne Carriere <etienne.carriere@linaro.org>\r\n```\r\n\r\n<!--\r\n    If you are new to submitting pull requests to OP-TEE, then please have a\r\n    look at the list below and tick them off before submitting the pull request.\r\n\r\n    1. Read our contribution guidelines:\r\n         documentation/github.md.\r\n\r\n    2. Read the contribution section in Notice.md and pay extra attention to the\r\n       \"Developer Certificate of Origin\" part:\r\n         https://github.com/OP-TEE/optee_os/blob/master/Notice.md#contributions.\r\n\r\n    3. You should run checkpatch preferably before submitting the pull request.\r\n\r\n    4. When everything has been reviewed, you will need to squash, rebase and\r\n       add tags like `Reviewed-by`, `Acked-by`, `Tested-by` etc.\r\n\r\n    NOTE: This comment will not be shown in the pull request, so no harm keeping\r\n    it, but feel free to remove it if you like.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments/448146518","html_url":"https://github.com/OP-TEE/optee_os/pull/2703#issuecomment-448146518","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2703","id":448146518,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODE0NjUxOA==","user":{"login":"jbech-linaro","id":6168937,"node_id":"MDQ6VXNlcjYxNjg5Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6168937?v=4","gravatar_id":"","url":"https://api.github.com/users/jbech-linaro","html_url":"https://github.com/jbech-linaro","followers_url":"https://api.github.com/users/jbech-linaro/followers","following_url":"https://api.github.com/users/jbech-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jbech-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jbech-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbech-linaro/subscriptions","organizations_url":"https://api.github.com/users/jbech-linaro/orgs","repos_url":"https://api.github.com/users/jbech-linaro/repos","events_url":"https://api.github.com/users/jbech-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jbech-linaro/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T09:01:41Z","updated_at":"2018-12-18T09:01:41Z","author_association":"CONTRIBUTOR","body":"This in TF-A seems to fix the issue. I'll send a patch to arm-trusted-firmware.git\r\n```patch\r\n$ git diff\r\ndiff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c\r\nindex 4160003c8..6d5ba9d73 100644\r\n--- a/drivers/mmc/mmc.c\r\n+++ b/drivers/mmc/mmc.c\r\n@@ -404,7 +404,7 @@ static int mmc_send_op_cond(void)\r\n                        return 0;\r\n                }\r\n \r\n-               mdelay(1);\r\n+               mdelay(10);\r\n        }\r\n \r\n        ERROR(\"CMD1 failed after %d retries\\n\", SEND_OP_COND_MAX_RETRIES);\r\n```"}}
{"actor":{"display_login":"jbech-linaro"}}