{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60692","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60692/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60692/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60692/events","html_url":"https://github.com/kubernetes/kubernetes/pull/60692","id":301674171,"number":60692,"title":"Cleanup the use of ExternalID as it is deprecated","user":{"login":"adnavare","id":18075544,"avatar_url":"https://avatars2.githubusercontent.com/u/18075544?v=4","gravatar_id":"","url":"https://api.github.com/users/adnavare","html_url":"https://github.com/adnavare","followers_url":"https://api.github.com/users/adnavare/followers","following_url":"https://api.github.com/users/adnavare/following{/other_user}","gists_url":"https://api.github.com/users/adnavare/gists{/gist_id}","starred_url":"https://api.github.com/users/adnavare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnavare/subscriptions","organizations_url":"https://api.github.com/users/adnavare/orgs","repos_url":"https://api.github.com/users/adnavare/repos","events_url":"https://api.github.com/users/adnavare/events{/privacy}","received_events_url":"https://api.github.com/users/adnavare/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680152113,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":573014062,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-02T07:13:24Z","updated_at":"2018-03-02T07:16:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60692","html_url":"https://github.com/kubernetes/kubernetes/pull/60692","diff_url":"https://github.com/kubernetes/kubernetes/pull/60692.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/60692.patch"},"body":"The patch removes ExternalID usage from node_controller\r\nand node_lifecycle_oontroller. The code instead uses InstanceID\r\nwhich returns the cloud provider ID as well.\r\n\r\nfixes #60466 \r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/369842244","html_url":"https://github.com/kubernetes/kubernetes/pull/60692#issuecomment-369842244","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60692","id":369842244,"user":{"login":"adnavare","id":18075544,"avatar_url":"https://avatars2.githubusercontent.com/u/18075544?v=4","gravatar_id":"","url":"https://api.github.com/users/adnavare","html_url":"https://github.com/adnavare","followers_url":"https://api.github.com/users/adnavare/followers","following_url":"https://api.github.com/users/adnavare/following{/other_user}","gists_url":"https://api.github.com/users/adnavare/gists{/gist_id}","starred_url":"https://api.github.com/users/adnavare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnavare/subscriptions","organizations_url":"https://api.github.com/users/adnavare/orgs","repos_url":"https://api.github.com/users/adnavare/repos","events_url":"https://api.github.com/users/adnavare/events{/privacy}","received_events_url":"https://api.github.com/users/adnavare/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T07:16:01Z","updated_at":"2018-03-02T07:16:01Z","author_association":"CONTRIBUTOR","body":"Hi Folks, I have changed the code to remove ExternalID from node_controller and node_lifecycle_controller. But as ExternalID is deprecated and if not needed, I can go ahead  to remove the implementation of ExternalID() from each provider and also delete the field from instances type defined in cloud.go. I wanted to know the feedback from you guys, thanks."}}
{"actor":{"display_login":"adnavare"}}