{"action":"closed","issue":{"url":"https://api.github.com/repos/xwp/pwa-wp/issues/46","repository_url":"https://api.github.com/repos/xwp/pwa-wp","labels_url":"https://api.github.com/repos/xwp/pwa-wp/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/xwp/pwa-wp/issues/46/comments","events_url":"https://api.github.com/repos/xwp/pwa-wp/issues/46/events","html_url":"https://github.com/xwp/pwa-wp/issues/46","id":347407697,"node_id":"MDU6SXNzdWUzNDc0MDc2OTc=","number":46,"title":"Handle when default offline page is in a menu","user":{"login":"hellofromtonya","id":7284611,"node_id":"MDQ6VXNlcjcyODQ2MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/7284611?v=4","gravatar_id":"","url":"https://api.github.com/users/hellofromtonya","html_url":"https://github.com/hellofromtonya","followers_url":"https://api.github.com/users/hellofromtonya/followers","following_url":"https://api.github.com/users/hellofromtonya/following{/other_user}","gists_url":"https://api.github.com/users/hellofromtonya/gists{/gist_id}","starred_url":"https://api.github.com/users/hellofromtonya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellofromtonya/subscriptions","organizations_url":"https://api.github.com/users/hellofromtonya/orgs","repos_url":"https://api.github.com/users/hellofromtonya/repos","events_url":"https://api.github.com/users/hellofromtonya/events{/privacy}","received_events_url":"https://api.github.com/users/hellofromtonya/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"postphotos","id":963672,"node_id":"MDQ6VXNlcjk2MzY3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/963672?v=4","gravatar_id":"","url":"https://api.github.com/users/postphotos","html_url":"https://github.com/postphotos","followers_url":"https://api.github.com/users/postphotos/followers","following_url":"https://api.github.com/users/postphotos/following{/other_user}","gists_url":"https://api.github.com/users/postphotos/gists{/gist_id}","starred_url":"https://api.github.com/users/postphotos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postphotos/subscriptions","organizations_url":"https://api.github.com/users/postphotos/orgs","repos_url":"https://api.github.com/users/postphotos/repos","events_url":"https://api.github.com/users/postphotos/events{/privacy}","received_events_url":"https://api.github.com/users/postphotos/received_events","type":"User","site_admin":false},"assignees":[{"login":"postphotos","id":963672,"node_id":"MDQ6VXNlcjk2MzY3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/963672?v=4","gravatar_id":"","url":"https://api.github.com/users/postphotos","html_url":"https://github.com/postphotos","followers_url":"https://api.github.com/users/postphotos/followers","following_url":"https://api.github.com/users/postphotos/following{/other_user}","gists_url":"https://api.github.com/users/postphotos/gists{/gist_id}","starred_url":"https://api.github.com/users/postphotos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postphotos/subscriptions","organizations_url":"https://api.github.com/users/postphotos/orgs","repos_url":"https://api.github.com/users/postphotos/repos","events_url":"https://api.github.com/users/postphotos/events{/privacy}","received_events_url":"https://api.github.com/users/postphotos/received_events","type":"User","site_admin":false},{"login":"jwold","id":3411173,"node_id":"MDQ6VXNlcjM0MTExNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/3411173?v=4","gravatar_id":"","url":"https://api.github.com/users/jwold","html_url":"https://github.com/jwold","followers_url":"https://api.github.com/users/jwold/followers","following_url":"https://api.github.com/users/jwold/following{/other_user}","gists_url":"https://api.github.com/users/jwold/gists{/gist_id}","starred_url":"https://api.github.com/users/jwold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwold/subscriptions","organizations_url":"https://api.github.com/users/jwold/orgs","repos_url":"https://api.github.com/users/jwold/repos","events_url":"https://api.github.com/users/jwold/events{/privacy}","received_events_url":"https://api.github.com/users/jwold/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-08-03T13:58:26Z","updated_at":"2018-08-15T20:06:56Z","closed_at":"2018-08-15T20:06:56Z","author_association":"CONTRIBUTOR","body":"*The Problem* :   The default offline page should not be in a menu.  But it is possible that when selecting an existing page as the default offline page, that existing page might be included as a menu item or parent menu item within one or more existing menus.\r\n\r\nFor example:\r\n\r\n![pwa-existing-page-in-nav](https://user-images.githubusercontent.com/7284611/42894263-045e5c5a-8a7c-11e8-97b2-6a0160be83ec.png)\r\n\r\nCurrently, no error messaging appears.\r\n\r\nIn this issue, we are exploring how best to handle this edge case.  The [discussion began here](https://github.com/xwp/pwa-wp/issues/23#issuecomment-405996763) in #23.\r\n\r\nWe need to determine whether to:\r\n\r\n- [ ] Prevent it from happening by disallowing an existing page to be selected as the default offline page.\r\n- [ ] Alert - notify the admin and direct him/her to each of the menus in `Appearance > Menus`\r\n- [ ] Automatically resolve and Alert for action when needed (e.g. when the page is a parent menu item).\r\n\r\n\r\n"}}
{"actor":{"display_login":"westonruter"}}