{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/22852","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/22852/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/22852/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/22852/events","html_url":"https://github.com/mantidproject/mantid/pull/22852","id":339815018,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMzc0OTky","number":22852,"title":"Add C++ version of SortXAxis #22515","user":{"login":"Pasarus","id":24723609,"node_id":"MDQ6VXNlcjI0NzIzNjA5","avatar_url":"https://avatars2.githubusercontent.com/u/24723609?v=4","gravatar_id":"","url":"https://api.github.com/users/Pasarus","html_url":"https://github.com/Pasarus","followers_url":"https://api.github.com/users/Pasarus/followers","following_url":"https://api.github.com/users/Pasarus/following{/other_user}","gists_url":"https://api.github.com/users/Pasarus/gists{/gist_id}","starred_url":"https://api.github.com/users/Pasarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pasarus/subscriptions","organizations_url":"https://api.github.com/users/Pasarus/orgs","repos_url":"https://api.github.com/users/Pasarus/repos","events_url":"https://api.github.com/users/Pasarus/events{/privacy}","received_events_url":"https://api.github.com/users/Pasarus/received_events","type":"User","site_admin":false},"labels":[{"id":636712977,"node_id":"MDU6TGFiZWw2MzY3MTI5Nzc=","url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Induction%201","name":"Misc: Induction 1","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"edwardb96","id":8405233,"node_id":"MDQ6VXNlcjg0MDUyMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/8405233?v=4","gravatar_id":"","url":"https://api.github.com/users/edwardb96","html_url":"https://github.com/edwardb96","followers_url":"https://api.github.com/users/edwardb96/followers","following_url":"https://api.github.com/users/edwardb96/following{/other_user}","gists_url":"https://api.github.com/users/edwardb96/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardb96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardb96/subscriptions","organizations_url":"https://api.github.com/users/edwardb96/orgs","repos_url":"https://api.github.com/users/edwardb96/repos","events_url":"https://api.github.com/users/edwardb96/events{/privacy}","received_events_url":"https://api.github.com/users/edwardb96/received_events","type":"User","site_admin":false},"assignees":[{"login":"edwardb96","id":8405233,"node_id":"MDQ6VXNlcjg0MDUyMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/8405233?v=4","gravatar_id":"","url":"https://api.github.com/users/edwardb96","html_url":"https://github.com/edwardb96","followers_url":"https://api.github.com/users/edwardb96/followers","following_url":"https://api.github.com/users/edwardb96/following{/other_user}","gists_url":"https://api.github.com/users/edwardb96/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardb96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardb96/subscriptions","organizations_url":"https://api.github.com/users/edwardb96/orgs","repos_url":"https://api.github.com/users/edwardb96/repos","events_url":"https://api.github.com/users/edwardb96/events{/privacy}","received_events_url":"https://api.github.com/users/edwardb96/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/68","html_url":"https://github.com/mantidproject/mantid/milestone/68","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/68/labels","id":3113735,"node_id":"MDk6TWlsZXN0b25lMzExMzczNQ==","number":68,"title":"Release 3.14 (4.0?)","description":"Code freeze: 23rd Nov\r\nBeta test: 27th Nov - 11th Dec","creator":{"login":"NickDraper","id":1017173,"node_id":"MDQ6VXNlcjEwMTcxNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":154,"closed_issues":8,"state":"open","created_at":"2018-02-13T15:42:17Z","updated_at":"2018-07-12T10:19:32Z","due_on":"2018-12-17T08:00:00Z","closed_at":null},"comments":2,"created_at":"2018-07-10T12:12:19Z","updated_at":"2018-07-12T12:29:00Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/22852","html_url":"https://github.com/mantidproject/mantid/pull/22852","diff_url":"https://github.com/mantidproject/mantid/pull/22852.diff","patch_url":"https://github.com/mantidproject/mantid/pull/22852.patch"},"body":"**Description of work.**\r\nIt was requested that for C++ users the algorithm SortXAxis was rewritten in C++ so it is more easily used, in a C++ context instead of writing it individually across. This also replaces the Python as the C++ is V2 and the Python is V1.\r\n\r\n**Report to:** nobody  <!--If the original issue was raised by a user they should be named here.-->\r\n\r\n**To test:**\r\n\r\n- Either Load some data can be anything but ` TestSampleData->D33041421_tof.nxs ` is a good one to use and run the algorithm like you would any other Algorithm. It should use the C++ variant, which should be inherently faster than Python anyway, which with test data sets as large as this is noticeable.\r\nor\r\n- Run the ctest 'SortXAxisTest.py' \r\n\r\n<!-- Instructions for testing. -->\r\n\r\nFixes #22515 <!-- and fix #xxxx or close #xxxx xor resolves #xxxx -->\r\n\r\nDoes this update require release notes?\r\n- [ ] Yes\r\n- [x] No\r\n<!--\r\nIf yes, edit the file docs/source/release/... \r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/404495295","html_url":"https://github.com/mantidproject/mantid/pull/22852#issuecomment-404495295","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/22852","id":404495295,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDQ5NTI5NQ==","user":{"login":"Pasarus","id":24723609,"node_id":"MDQ6VXNlcjI0NzIzNjA5","avatar_url":"https://avatars2.githubusercontent.com/u/24723609?v=4","gravatar_id":"","url":"https://api.github.com/users/Pasarus","html_url":"https://github.com/Pasarus","followers_url":"https://api.github.com/users/Pasarus/followers","following_url":"https://api.github.com/users/Pasarus/following{/other_user}","gists_url":"https://api.github.com/users/Pasarus/gists{/gist_id}","starred_url":"https://api.github.com/users/Pasarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pasarus/subscriptions","organizations_url":"https://api.github.com/users/Pasarus/orgs","repos_url":"https://api.github.com/users/Pasarus/repos","events_url":"https://api.github.com/users/Pasarus/events{/privacy}","received_events_url":"https://api.github.com/users/Pasarus/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T12:29:00Z","updated_at":"2018-07-12T12:29:00Z","author_association":"NONE","body":"`Sorry for my intervention!\r\n- Will the Python test run this algorithm? It should test this algorithm next to its version 1 by default.\r\n- I wonder about the performance. XAxis sorting is used in `Stitch1D`, can you compare performances? I could not use the openmp for loops after moving the code to an anonymous namespace. At the moment we do not have an amazing performance running Mantid C++/Python code compared to IDL code of same reduction steps. `Stitch1D` may not make the difference but we should start somewhere looking for better performances.\r\n- Can you only open an issue for replacing the c++ sorting in `Stitch1D` by calling this algorithm?`\r\n\r\nWith regards to the test running, it currently runs just the new C++ version and not the older python one, is this what you mean or do you want both to run on both of the versions of the algorithm.\r\n\r\nWill sort a benchmark and post results here.\r\n\r\nI can indeed."}}
{"actor":{"display_login":"Pasarus"}}