{"action":"created","issue":{"url":"https://api.github.com/repos/iiasa/message_ix/issues/93","repository_url":"https://api.github.com/repos/iiasa/message_ix","labels_url":"https://api.github.com/repos/iiasa/message_ix/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/iiasa/message_ix/issues/93/comments","events_url":"https://api.github.com/repos/iiasa/message_ix/issues/93/events","html_url":"https://github.com/iiasa/message_ix/pull/93","id":347062036,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzczOTQy","number":93,"title":"WIP - initial thoughts on generic share constraint","user":{"login":"gidden","id":1392657,"node_id":"MDQ6VXNlcjEzOTI2NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1392657?v=4","gravatar_id":"","url":"https://api.github.com/users/gidden","html_url":"https://github.com/gidden","followers_url":"https://api.github.com/users/gidden/followers","following_url":"https://api.github.com/users/gidden/following{/other_user}","gists_url":"https://api.github.com/users/gidden/gists{/gist_id}","starred_url":"https://api.github.com/users/gidden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gidden/subscriptions","organizations_url":"https://api.github.com/users/gidden/orgs","repos_url":"https://api.github.com/users/gidden/repos","events_url":"https://api.github.com/users/gidden/events{/privacy}","received_events_url":"https://api.github.com/users/gidden/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-02T15:26:04Z","updated_at":"2018-08-03T11:58:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/iiasa/message_ix/pulls/93","html_url":"https://github.com/iiasa/message_ix/pull/93","diff_url":"https://github.com/iiasa/message_ix/pull/93.diff","patch_url":"https://github.com/iiasa/message_ix/pull/93.patch"},"body":"# Please confirm that this PR has done the following:\r\n\r\n- [ ] Tests Added\r\n- [ ] Documentation Added\r\n- [ ] Description in RELEASE_NOTES.md Added\r\n\r\n# Adding to RELEASE_NOTES.md\r\n\r\nPlease add a single line in the release notes similar to the following:\r\n\r\n```\r\n- (#XX)[http://link-to-pr.com] Added feature which does something\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/iiasa/message_ix/issues/comments/410232149","html_url":"https://github.com/iiasa/message_ix/pull/93#issuecomment-410232149","issue_url":"https://api.github.com/repos/iiasa/message_ix/issues/93","id":410232149,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDIzMjE0OQ==","user":{"login":"danielhuppmann","id":16931589,"node_id":"MDQ6VXNlcjE2OTMxNTg5","avatar_url":"https://avatars2.githubusercontent.com/u/16931589?v=4","gravatar_id":"","url":"https://api.github.com/users/danielhuppmann","html_url":"https://github.com/danielhuppmann","followers_url":"https://api.github.com/users/danielhuppmann/followers","following_url":"https://api.github.com/users/danielhuppmann/following{/other_user}","gists_url":"https://api.github.com/users/danielhuppmann/gists{/gist_id}","starred_url":"https://api.github.com/users/danielhuppmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielhuppmann/subscriptions","organizations_url":"https://api.github.com/users/danielhuppmann/orgs","repos_url":"https://api.github.com/users/danielhuppmann/repos","events_url":"https://api.github.com/users/danielhuppmann/events{/privacy}","received_events_url":"https://api.github.com/users/danielhuppmann/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T11:58:35Z","updated_at":"2018-08-03T11:58:35Z","author_association":"MEMBER","body":"Not sure how this is supposed to work and whether the mapping to `input` and `output` is necessary... But it seems to me like if this would want to implement a constraint for each region, the region info would have to be hardcoded into the name `shares`, like `['renewables_share_AFR', 'renewables_share_EUR', ...]`. This is probably not a good solution, because one would need to parse and decode the elements of the `shares` set. \r\n\r\nSuggestion for an alternative approach, building off the approach in #80:\r\n\r\nadd explicit mapping sets that state which type_tecs, nodes, etc. belong to the numerator and which belong to the denominator, like\r\n```\r\nshare_factor_up('shares', 'node', 'year', 'time')\r\nmap_shares_commodity_level_share('shares', 'commodity', 'level', 'type_tec_share')\r\nmap_shares_commodity_level_total('shares', 'commodity', 'level', 'type_tec_share')\r\n``` \r\nThis would allow to have multiple entries into the mapping `map_shares_commodity_level_share` and it breaks the direct connection between commodity and level in the numerator and denominator. So that we could have constraints like \"all electricity generated by renewables compared to all methane used by cars\".\r\n\r\nThis formulation could be extended to include nodes and modes - but I'm not sure we really want to go that far?"}}
{"actor":{"display_login":"danielhuppmann"}}