{"action":"created","comment":{"url":"https://api.github.com/repos/ament/ament_package/pulls/comments/195306405","pull_request_review_id":128646406,"id":195306405,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTMwNjQwNQ==","diff_hunk":"@@ -11,13 +11,19 @@\n # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n # See the License for the specific language governing permissions and\n # limitations under the License.\n+from flake8.api.legacy import get_style_guide\n \n-from ament_flake8.main import main\n import pytest\n \n \n @pytest.mark.flake8\n @pytest.mark.linter\n def test_flake8():\n-    rc = main(argv=[])\n-    assert rc == 0, 'Found code style errors / warnings'\n+    style = get_style_guide(\n+        ignore='I202',\n+        import_order_style='google',","path":"test/test_flake8.py","position":null,"original_position":17,"commit_id":"bd3510699152976cfb8728f68a5cbad7b63fe3db","original_commit_id":"e18de6cf35c436d1ed8466983844cf95f83715f5","user":{"login":"dirk-thomas","id":1335366,"node_id":"MDQ6VXNlcjEzMzUzNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1335366?v=4","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"Well, currently the code fails the test (at least for me). And changing the argument for the import order style in the test doesn't make any difference.\r\n\r\nOnly with a `.flake8` file with the following content it does pass for me:\r\n\r\n```\r\n[flake8]\r\nimport-order-style = google\r\n```","created_at":"2018-06-14T05:35:53Z","updated_at":"2018-06-14T05:35:53Z","html_url":"https://github.com/ament/ament_package/pull/77#discussion_r195306405","pull_request_url":"https://api.github.com/repos/ament/ament_package/pulls/77","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ament/ament_package/pulls/comments/195306405"},"html":{"href":"https://github.com/ament/ament_package/pull/77#discussion_r195306405"},"pull_request":{"href":"https://api.github.com/repos/ament/ament_package/pulls/77"}},"in_reply_to_id":195304482},"pull_request":{"url":"https://api.github.com/repos/ament/ament_package/pulls/77","id":194700643,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzAwNjQz","html_url":"https://github.com/ament/ament_package/pull/77","diff_url":"https://github.com/ament/ament_package/pull/77.diff","patch_url":"https://github.com/ament/ament_package/pull/77.patch","issue_url":"https://api.github.com/repos/ament/ament_package/issues/77","number":77,"state":"open","locked":false,"title":"Use flake8 directly","user":{"login":"nuclearsandwich","id":358882,"node_id":"MDQ6VXNlcjM1ODg4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/358882?v=4","gravatar_id":"","url":"https://api.github.com/users/nuclearsandwich","html_url":"https://github.com/nuclearsandwich","followers_url":"https://api.github.com/users/nuclearsandwich/followers","following_url":"https://api.github.com/users/nuclearsandwich/following{/other_user}","gists_url":"https://api.github.com/users/nuclearsandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearsandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearsandwich/subscriptions","organizations_url":"https://api.github.com/users/nuclearsandwich/orgs","repos_url":"https://api.github.com/users/nuclearsandwich/repos","events_url":"https://api.github.com/users/nuclearsandwich/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearsandwich/received_events","type":"User","site_admin":false},"body":"This PR breaks the repository level dependency cycle of `ament_package` --test-depend--> `ament_lint` --buildtool_depend--> `ament_cmake_core` --buildtool_depend--> `ament_package` by removing the pep257 and copyright checks and using flake8 directly for the flake8 checks.\r\n\r\nThis also means losing the JUnit xml output from ament_flake8 for this package.\r\n\r\nOn this initial review pass I'd like to know if there's any additional functionality we should add before CI and final review.\r\n\r\nA complete alternative would be skipping pytest entirely and running flake8 directly as the test command, but I'm not completely certain of the details or implications of doing so.","created_at":"2018-06-13T20:08:26Z","updated_at":"2018-06-14T05:35:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ad0375096043408ae9d4a0d0173f47371443b39","assignee":{"login":"nuclearsandwich","id":358882,"node_id":"MDQ6VXNlcjM1ODg4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/358882?v=4","gravatar_id":"","url":"https://api.github.com/users/nuclearsandwich","html_url":"https://github.com/nuclearsandwich","followers_url":"https://api.github.com/users/nuclearsandwich/followers","following_url":"https://api.github.com/users/nuclearsandwich/following{/other_user}","gists_url":"https://api.github.com/users/nuclearsandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearsandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearsandwich/subscriptions","organizations_url":"https://api.github.com/users/nuclearsandwich/orgs","repos_url":"https://api.github.com/users/nuclearsandwich/repos","events_url":"https://api.github.com/users/nuclearsandwich/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearsandwich/received_events","type":"User","site_admin":false},"assignees":[{"login":"nuclearsandwich","id":358882,"node_id":"MDQ6VXNlcjM1ODg4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/358882?v=4","gravatar_id":"","url":"https://api.github.com/users/nuclearsandwich","html_url":"https://github.com/nuclearsandwich","followers_url":"https://api.github.com/users/nuclearsandwich/followers","following_url":"https://api.github.com/users/nuclearsandwich/following{/other_user}","gists_url":"https://api.github.com/users/nuclearsandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearsandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearsandwich/subscriptions","organizations_url":"https://api.github.com/users/nuclearsandwich/orgs","repos_url":"https://api.github.com/users/nuclearsandwich/repos","events_url":"https://api.github.com/users/nuclearsandwich/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearsandwich/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":185220673,"node_id":"MDU6TGFiZWwxODUyMjA2NzM=","url":"https://api.github.com/repos/ament/ament_package/labels/in%20progress","name":"in progress","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ament/ament_package/pulls/77/commits","review_comments_url":"https://api.github.com/repos/ament/ament_package/pulls/77/comments","review_comment_url":"https://api.github.com/repos/ament/ament_package/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ament/ament_package/issues/77/comments","statuses_url":"https://api.github.com/repos/ament/ament_package/statuses/bd3510699152976cfb8728f68a5cbad7b63fe3db","head":{"label":"nuclearsandwich:use-flake8-direct","ref":"use-flake8-direct","sha":"bd3510699152976cfb8728f68a5cbad7b63fe3db","user":{"login":"nuclearsandwich","id":358882,"node_id":"MDQ6VXNlcjM1ODg4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/358882?v=4","gravatar_id":"","url":"https://api.github.com/users/nuclearsandwich","html_url":"https://github.com/nuclearsandwich","followers_url":"https://api.github.com/users/nuclearsandwich/followers","following_url":"https://api.github.com/users/nuclearsandwich/following{/other_user}","gists_url":"https://api.github.com/users/nuclearsandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearsandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearsandwich/subscriptions","organizations_url":"https://api.github.com/users/nuclearsandwich/orgs","repos_url":"https://api.github.com/users/nuclearsandwich/repos","events_url":"https://api.github.com/users/nuclearsandwich/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearsandwich/received_events","type":"User","site_admin":false},"repo":{"id":91826641,"node_id":"MDEwOlJlcG9zaXRvcnk5MTgyNjY0MQ==","name":"ament_package","full_name":"nuclearsandwich/ament_package","owner":{"login":"nuclearsandwich","id":358882,"node_id":"MDQ6VXNlcjM1ODg4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/358882?v=4","gravatar_id":"","url":"https://api.github.com/users/nuclearsandwich","html_url":"https://github.com/nuclearsandwich","followers_url":"https://api.github.com/users/nuclearsandwich/followers","following_url":"https://api.github.com/users/nuclearsandwich/following{/other_user}","gists_url":"https://api.github.com/users/nuclearsandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearsandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearsandwich/subscriptions","organizations_url":"https://api.github.com/users/nuclearsandwich/orgs","repos_url":"https://api.github.com/users/nuclearsandwich/repos","events_url":"https://api.github.com/users/nuclearsandwich/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearsandwich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nuclearsandwich/ament_package","description":"Python package for parsing package manifest files (package.xml).","fork":true,"url":"https://api.github.com/repos/nuclearsandwich/ament_package","forks_url":"https://api.github.com/repos/nuclearsandwich/ament_package/forks","keys_url":"https://api.github.com/repos/nuclearsandwich/ament_package/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuclearsandwich/ament_package/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuclearsandwich/ament_package/teams","hooks_url":"https://api.github.com/repos/nuclearsandwich/ament_package/hooks","issue_events_url":"https://api.github.com/repos/nuclearsandwich/ament_package/issues/events{/number}","events_url":"https://api.github.com/repos/nuclearsandwich/ament_package/events","assignees_url":"https://api.github.com/repos/nuclearsandwich/ament_package/assignees{/user}","branches_url":"https://api.github.com/repos/nuclearsandwich/ament_package/branches{/branch}","tags_url":"https://api.github.com/repos/nuclearsandwich/ament_package/tags","blobs_url":"https://api.github.com/repos/nuclearsandwich/ament_package/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuclearsandwich/ament_package/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuclearsandwich/ament_package/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuclearsandwich/ament_package/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuclearsandwich/ament_package/statuses/{sha}","languages_url":"https://api.github.com/repos/nuclearsandwich/ament_package/languages","stargazers_url":"https://api.github.com/repos/nuclearsandwich/ament_package/stargazers","contributors_url":"https://api.github.com/repos/nuclearsandwich/ament_package/contributors","subscribers_url":"https://api.github.com/repos/nuclearsandwich/ament_package/subscribers","subscription_url":"https://api.github.com/repos/nuclearsandwich/ament_package/subscription","commits_url":"https://api.github.com/repos/nuclearsandwich/ament_package/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuclearsandwich/ament_package/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuclearsandwich/ament_package/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuclearsandwich/ament_package/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuclearsandwich/ament_package/contents/{+path}","compare_url":"https://api.github.com/repos/nuclearsandwich/ament_package/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuclearsandwich/ament_package/merges","archive_url":"https://api.github.com/repos/nuclearsandwich/ament_package/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuclearsandwich/ament_package/downloads","issues_url":"https://api.github.com/repos/nuclearsandwich/ament_package/issues{/number}","pulls_url":"https://api.github.com/repos/nuclearsandwich/ament_package/pulls{/number}","milestones_url":"https://api.github.com/repos/nuclearsandwich/ament_package/milestones{/number}","notifications_url":"https://api.github.com/repos/nuclearsandwich/ament_package/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuclearsandwich/ament_package/labels{/name}","releases_url":"https://api.github.com/repos/nuclearsandwich/ament_package/releases{/id}","deployments_url":"https://api.github.com/repos/nuclearsandwich/ament_package/deployments","created_at":"2017-05-19T16:47:07Z","updated_at":"2018-06-13T18:11:42Z","pushed_at":"2018-06-14T05:32:44Z","git_url":"git://github.com/nuclearsandwich/ament_package.git","ssh_url":"git@github.com:nuclearsandwich/ament_package.git","clone_url":"https://github.com/nuclearsandwich/ament_package.git","svn_url":"https://github.com/nuclearsandwich/ament_package","homepage":"","size":129,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ament:master","ref":"master","sha":"dd4ed2b81f2d799092b4d96179c50e722239ed20","user":{"login":"ament","id":7365061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjUwNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7365061?v=4","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"repo":{"id":19928304,"node_id":"MDEwOlJlcG9zaXRvcnkxOTkyODMwNA==","name":"ament_package","full_name":"ament/ament_package","owner":{"login":"ament","id":7365061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjUwNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7365061?v=4","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ament/ament_package","description":"Python package for parsing package manifest files (package.xml).","fork":false,"url":"https://api.github.com/repos/ament/ament_package","forks_url":"https://api.github.com/repos/ament/ament_package/forks","keys_url":"https://api.github.com/repos/ament/ament_package/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ament/ament_package/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ament/ament_package/teams","hooks_url":"https://api.github.com/repos/ament/ament_package/hooks","issue_events_url":"https://api.github.com/repos/ament/ament_package/issues/events{/number}","events_url":"https://api.github.com/repos/ament/ament_package/events","assignees_url":"https://api.github.com/repos/ament/ament_package/assignees{/user}","branches_url":"https://api.github.com/repos/ament/ament_package/branches{/branch}","tags_url":"https://api.github.com/repos/ament/ament_package/tags","blobs_url":"https://api.github.com/repos/ament/ament_package/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ament/ament_package/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ament/ament_package/git/refs{/sha}","trees_url":"https://api.github.com/repos/ament/ament_package/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ament/ament_package/statuses/{sha}","languages_url":"https://api.github.com/repos/ament/ament_package/languages","stargazers_url":"https://api.github.com/repos/ament/ament_package/stargazers","contributors_url":"https://api.github.com/repos/ament/ament_package/contributors","subscribers_url":"https://api.github.com/repos/ament/ament_package/subscribers","subscription_url":"https://api.github.com/repos/ament/ament_package/subscription","commits_url":"https://api.github.com/repos/ament/ament_package/commits{/sha}","git_commits_url":"https://api.github.com/repos/ament/ament_package/git/commits{/sha}","comments_url":"https://api.github.com/repos/ament/ament_package/comments{/number}","issue_comment_url":"https://api.github.com/repos/ament/ament_package/issues/comments{/number}","contents_url":"https://api.github.com/repos/ament/ament_package/contents/{+path}","compare_url":"https://api.github.com/repos/ament/ament_package/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ament/ament_package/merges","archive_url":"https://api.github.com/repos/ament/ament_package/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ament/ament_package/downloads","issues_url":"https://api.github.com/repos/ament/ament_package/issues{/number}","pulls_url":"https://api.github.com/repos/ament/ament_package/pulls{/number}","milestones_url":"https://api.github.com/repos/ament/ament_package/milestones{/number}","notifications_url":"https://api.github.com/repos/ament/ament_package/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ament/ament_package/labels{/name}","releases_url":"https://api.github.com/repos/ament/ament_package/releases{/id}","deployments_url":"https://api.github.com/repos/ament/ament_package/deployments","created_at":"2014-05-19T03:37:21Z","updated_at":"2018-06-13T21:52:47Z","pushed_at":"2018-06-14T05:32:45Z","git_url":"git://github.com/ament/ament_package.git","ssh_url":"git@github.com:ament/ament_package.git","clone_url":"https://github.com/ament/ament_package.git","svn_url":"https://github.com/ament/ament_package","homepage":"","size":125,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ament/ament_package/pulls/77"},"html":{"href":"https://github.com/ament/ament_package/pull/77"},"issue":{"href":"https://api.github.com/repos/ament/ament_package/issues/77"},"comments":{"href":"https://api.github.com/repos/ament/ament_package/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/ament/ament_package/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/ament/ament_package/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ament/ament_package/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/ament/ament_package/statuses/bd3510699152976cfb8728f68a5cbad7b63fe3db"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dirk-thomas"}}