{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70839","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70839/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70839/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70839/events","html_url":"https://github.com/kubernetes/kubernetes/pull/70839","id":379000302,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTcxNzM1","number":70839,"title":"[WIP] runtime/serializer: use DisallowUnknownFields for the json-iter config","user":{"login":"neolit123","id":331852,"node_id":"MDQ6VXNlcjMzMTg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680152113,"node_id":"MDU6TGFiZWw2ODAxNTIxMTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":1047217136,"node_id":"MDU6TGFiZWwxMDQ3MjE3MTM2","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-kind","name":"needs-kind","color":"ededed","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-09T02:41:56Z","updated_at":"2018-11-09T03:04:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70839","html_url":"https://github.com/kubernetes/kubernetes/pull/70839","diff_url":"https://github.com/kubernetes/kubernetes/pull/70839.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70839.patch"},"body":"**TEST PR - DO NOT MERGE**\r\n\r\n@dims \r\nwe are now using the k-sigs/yaml repo, but a number of locations call yaml.Unmarshal instead of yaml.UnmarshalStrict.\r\nwe can potentially enumerate those locations and see what can be changed?\r\n\r\nkubeadm on the other hand is using codecs for unmarshaling, which goes deep into apimachinery where instead of k-sigs/yaml it's using the json-iter library instead of k-sigs/yaml 's yaml.Unmarshal() or encoding/json.\r\n\r\n@timothysc if we want to support checks for unknown fields we either have to try to pre-process a configuration file using k-sigs/yaml or a change like the one in this PR has to go into apimachinery.\r\n...the change in this PR seems quite hazardous.\r\n\r\ni'm just sending this PR to see how many tests would break.\r\ncc @kubernetes/sig-api-machinery-pr-reviews \r\ncc @kubernetes/sig-cluster-lifecycle-pr-reviews \r\ncc @thockin @ash2k \r\n\r\nxref https://github.com/kubernetes/kubeadm/issues/1066\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/437234632","html_url":"https://github.com/kubernetes/kubernetes/pull/70839#issuecomment-437234632","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70839","id":437234632,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzIzNDYzMg==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T03:04:12Z","updated_at":"2018-11-09T03:04:12Z","author_association":"CONTRIBUTOR","body":"@neolit123: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-node-e2e | feabe3954acafe4caa3ad923e75d07c1d844c580 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70839/pull-kubernetes-node-e2e/110699/) | `/test pull-kubernetes-node-e2e`\npull-kubernetes-bazel-test | feabe3954acafe4caa3ad923e75d07c1d844c580 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70839/pull-kubernetes-bazel-test/66842/) | `/test pull-kubernetes-bazel-test`\n\n[Full PR test history](https://gubernator.k8s.io/pr/70839). [Your PR dashboard](https://gubernator.k8s.io/pr/neolit123). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}