{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/comments/228165542","pull_request_review_id":168371771,"id":228165542,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODE2NTU0Mg==","diff_hunk":"@@ -25,7 +25,7 @@\n     'cassandra': True,\n     'celery': True,\n     'elasticsearch': True,\n-    'futures': False,  # experimental propagation\n+    'futures': True,","path":"ddtrace/monkey.py","position":5,"original_position":5,"commit_id":"fbf70c6c171bba409f7f2e099ef6aeba8bda6869","original_commit_id":"fbf70c6c171bba409f7f2e099ef6aeba8bda6869","user":{"login":"palazzem","id":1560405,"node_id":"MDQ6VXNlcjE1NjA0MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1560405?v=4","gravatar_id":"","url":"https://api.github.com/users/palazzem","html_url":"https://github.com/palazzem","followers_url":"https://api.github.com/users/palazzem/followers","following_url":"https://api.github.com/users/palazzem/following{/other_user}","gists_url":"https://api.github.com/users/palazzem/gists{/gist_id}","starred_url":"https://api.github.com/users/palazzem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palazzem/subscriptions","organizations_url":"https://api.github.com/users/palazzem/orgs","repos_url":"https://api.github.com/users/palazzem/repos","events_url":"https://api.github.com/users/palazzem/events{/privacy}","received_events_url":"https://api.github.com/users/palazzem/received_events","type":"User","site_admin":false},"body":"This integration is actually well tested only on Tornado environments (and Tornado enables it by default). For other scenarios, I think it must be disabled until we have more feedbacks from users.\r\n\r\nFor now it's better to keep it disabled, while everything else is enabled.","created_at":"2018-10-25T13:09:59Z","updated_at":"2018-10-25T13:10:02Z","html_url":"https://github.com/DataDog/dd-trace-py/pull/674#discussion_r228165542","pull_request_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/674","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/comments/228165542"},"html":{"href":"https://github.com/DataDog/dd-trace-py/pull/674#discussion_r228165542"},"pull_request":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/674"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/674","id":225744238,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NzQ0MjM4","html_url":"https://github.com/DataDog/dd-trace-py/pull/674","diff_url":"https://github.com/DataDog/dd-trace-py/pull/674.diff","patch_url":"https://github.com/DataDog/dd-trace-py/pull/674.patch","issue_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/674","number":674,"state":"open","locked":false,"title":"[futures] Enabled by default","user":{"login":"Kyle-Verhoog","id":6321485,"node_id":"MDQ6VXNlcjYzMjE0ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/6321485?v=4","gravatar_id":"","url":"https://api.github.com/users/Kyle-Verhoog","html_url":"https://github.com/Kyle-Verhoog","followers_url":"https://api.github.com/users/Kyle-Verhoog/followers","following_url":"https://api.github.com/users/Kyle-Verhoog/following{/other_user}","gists_url":"https://api.github.com/users/Kyle-Verhoog/gists{/gist_id}","starred_url":"https://api.github.com/users/Kyle-Verhoog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kyle-Verhoog/subscriptions","organizations_url":"https://api.github.com/users/Kyle-Verhoog/orgs","repos_url":"https://api.github.com/users/Kyle-Verhoog/repos","events_url":"https://api.github.com/users/Kyle-Verhoog/events{/privacy}","received_events_url":"https://api.github.com/users/Kyle-Verhoog/received_events","type":"User","site_admin":false},"body":"This PR continues on from #658, enabling the futures integration by default.\r\n\r\nThe futures integration was previously marked as experimental.\r\n\r\n@palazzem can you look over the futures integration and give the 👍 / 👎  for if this change is safe to make?","created_at":"2018-10-25T12:44:25Z","updated_at":"2018-10-25T13:10:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3cea1f98de73938642cf9712c0906c5e0bc6bc0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":395724892,"node_id":"MDU6TGFiZWwzOTU3MjQ4OTI=","url":"https://api.github.com/repos/DataDog/dd-trace-py/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":443002993,"node_id":"MDU6TGFiZWw0NDMwMDI5OTM=","url":"https://api.github.com/repos/DataDog/dd-trace-py/labels/integrations","name":"integrations","color":"c2e0c6","default":false}],"milestone":{"url":"https://api.github.com/repos/DataDog/dd-trace-py/milestones/28","html_url":"https://github.com/DataDog/dd-trace-py/milestone/28","labels_url":"https://api.github.com/repos/DataDog/dd-trace-py/milestones/28/labels","id":3730311,"node_id":"MDk6TWlsZXN0b25lMzczMDMxMQ==","number":28,"title":"0.16.0","description":"","creator":{"login":"labbati","id":2952352,"node_id":"MDQ6VXNlcjI5NTIzNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2952352?v=4","gravatar_id":"","url":"https://api.github.com/users/labbati","html_url":"https://github.com/labbati","followers_url":"https://api.github.com/users/labbati/followers","following_url":"https://api.github.com/users/labbati/following{/other_user}","gists_url":"https://api.github.com/users/labbati/gists{/gist_id}","starred_url":"https://api.github.com/users/labbati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labbati/subscriptions","organizations_url":"https://api.github.com/users/labbati/orgs","repos_url":"https://api.github.com/users/labbati/repos","events_url":"https://api.github.com/users/labbati/events{/privacy}","received_events_url":"https://api.github.com/users/labbati/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":15,"state":"open","created_at":"2018-10-11T13:08:37Z","updated_at":"2018-10-25T12:46:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/674/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/674/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/674/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-py/statuses/fbf70c6c171bba409f7f2e099ef6aeba8bda6869","head":{"label":"DataDog:kyle-verhoog/enabled-by-default-futures","ref":"kyle-verhoog/enabled-by-default-futures","sha":"fbf70c6c171bba409f7f2e099ef6aeba8bda6869","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":61572326,"node_id":"MDEwOlJlcG9zaXRvcnk2MTU3MjMyNg==","name":"dd-trace-py","full_name":"DataDog/dd-trace-py","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/dd-trace-py","description":"Datadog Tracing Python Client","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-py","forks_url":"https://api.github.com/repos/DataDog/dd-trace-py/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-py/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-py/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-py/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-py/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-py/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-py/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-py/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-py/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-py/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-py/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-py/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-py/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-py/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-py/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-py/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-py/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-py/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-py/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-py/deployments","created_at":"2016-06-20T18:52:23Z","updated_at":"2018-10-24T22:28:28Z","pushed_at":"2018-10-25T12:59:34Z","git_url":"git://github.com/DataDog/dd-trace-py.git","ssh_url":"git@github.com:DataDog/dd-trace-py.git","clone_url":"https://github.com/DataDog/dd-trace-py.git","svn_url":"https://github.com/DataDog/dd-trace-py","homepage":"http://pypi.datadoghq.com/trace/docs/","size":2434,"stargazers_count":83,"watchers_count":83,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":90,"open_issues":66,"watchers":83,"default_branch":"master"}},"base":{"label":"DataDog:0.16-dev","ref":"0.16-dev","sha":"61997cf852aff97c34e157fe43b7c1bcdcc08243","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":61572326,"node_id":"MDEwOlJlcG9zaXRvcnk2MTU3MjMyNg==","name":"dd-trace-py","full_name":"DataDog/dd-trace-py","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/dd-trace-py","description":"Datadog Tracing Python Client","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-py","forks_url":"https://api.github.com/repos/DataDog/dd-trace-py/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-py/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-py/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-py/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-py/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-py/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-py/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-py/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-py/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-py/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-py/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-py/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-py/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-py/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-py/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-py/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-py/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-py/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-py/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-py/deployments","created_at":"2016-06-20T18:52:23Z","updated_at":"2018-10-24T22:28:28Z","pushed_at":"2018-10-25T12:59:34Z","git_url":"git://github.com/DataDog/dd-trace-py.git","ssh_url":"git@github.com:DataDog/dd-trace-py.git","clone_url":"https://github.com/DataDog/dd-trace-py.git","svn_url":"https://github.com/DataDog/dd-trace-py","homepage":"http://pypi.datadoghq.com/trace/docs/","size":2434,"stargazers_count":83,"watchers_count":83,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":90,"open_issues":66,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/674"},"html":{"href":"https://github.com/DataDog/dd-trace-py/pull/674"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/issues/674"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/statuses/fbf70c6c171bba409f7f2e099ef6aeba8bda6869"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"palazzem"}}