{"action":"created","issue":{"url":"https://api.github.com/repos/kenwheeler/cash/issues/215","repository_url":"https://api.github.com/repos/kenwheeler/cash","labels_url":"https://api.github.com/repos/kenwheeler/cash/issues/215/labels{/name}","comments_url":"https://api.github.com/repos/kenwheeler/cash/issues/215/comments","events_url":"https://api.github.com/repos/kenwheeler/cash/issues/215/events","html_url":"https://github.com/kenwheeler/cash/pull/215","id":369902417,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzE1NzU5","number":215,"title":"Fix .append(undefined) error, refs #213","user":{"login":"fervero","id":20402984,"node_id":"MDQ6VXNlcjIwNDAyOTg0","avatar_url":"https://avatars2.githubusercontent.com/u/20402984?v=4","gravatar_id":"","url":"https://api.github.com/users/fervero","html_url":"https://github.com/fervero","followers_url":"https://api.github.com/users/fervero/followers","following_url":"https://api.github.com/users/fervero/following{/other_user}","gists_url":"https://api.github.com/users/fervero/gists{/gist_id}","starred_url":"https://api.github.com/users/fervero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fervero/subscriptions","organizations_url":"https://api.github.com/users/fervero/orgs","repos_url":"https://api.github.com/users/fervero/repos","events_url":"https://api.github.com/users/fervero/events{/privacy}","received_events_url":"https://api.github.com/users/fervero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-14T13:29:13Z","updated_at":"2018-10-14T17:57:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kenwheeler/cash/pulls/215","html_url":"https://github.com/kenwheeler/cash/pull/215","diff_url":"https://github.com/kenwheeler/cash/pull/215.diff","patch_url":"https://github.com/kenwheeler/cash/pull/215.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/kenwheeler/cash/issues/comments/429647427","html_url":"https://github.com/kenwheeler/cash/pull/215#issuecomment-429647427","issue_url":"https://api.github.com/repos/kenwheeler/cash/issues/215","id":429647427,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTY0NzQyNw==","user":{"login":"fervero","id":20402984,"node_id":"MDQ6VXNlcjIwNDAyOTg0","avatar_url":"https://avatars2.githubusercontent.com/u/20402984?v=4","gravatar_id":"","url":"https://api.github.com/users/fervero","html_url":"https://github.com/fervero","followers_url":"https://api.github.com/users/fervero/followers","following_url":"https://api.github.com/users/fervero/following{/other_user}","gists_url":"https://api.github.com/users/fervero/gists{/gist_id}","starred_url":"https://api.github.com/users/fervero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fervero/subscriptions","organizations_url":"https://api.github.com/users/fervero/orgs","repos_url":"https://api.github.com/users/fervero/repos","events_url":"https://api.github.com/users/fervero/events{/privacy}","received_events_url":"https://api.github.com/users/fervero/received_events","type":"User","site_admin":false},"created_at":"2018-10-14T17:57:06Z","updated_at":"2018-10-14T17:57:06Z","author_association":"NONE","body":"Huh.\n\nSorry about that, I assumed that `each` was a run-of-the-mill `forEach`, which would accept an empty array, do absolutely nothing, and not throw. (And if brevity of code is what you’re after, then a 3-character fix `|[]` would be hard to beat).\n\nAh well, it was worth a shot.\n\n \n\nFrom: Fabio Spampinato [mailto:notifications@github.com] \nSent: Sunday, October 14, 2018 4:23 PM\nTo: kenwheeler/cash\nCc: Maciej Bójko; Author\nSubject: Re: [kenwheeler/cash] Fix .append(undefined) error, refs #213 (#215)\n\n \n\nThanks for the PR!\n\nI've just tested this and it's not working though, insertContent can't accept an empty array as the value of child.\n\nThis should be fixed by updating insertContent <https://github.com/kenwheeler/cash/blob/master/src/manipulation/helpers/insert_content.js>  instead, so that both prepend and append work with this.\n\nAlso it would be helpful if you added an additional test for this use case.\n\n—\nYou are receiving this because you authored the thread.\nReply to this email directly, view it on GitHub <https://github.com/kenwheeler/cash/pull/215#issuecomment-429630486> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ATdTKH-1chds5Kph-DpBjtJXZ2i9gMe_ks5uk0i8gaJpZM4XbIMI> .Obraz usunięty przez nadawcę.\n\n\n\n---\nTa wiadomość została sprawdzona na obecność wirusów przez oprogramowanie antywirusowe Avast.\nhttps://www.avast.com/antivirus\n"}}
{"actor":{"display_login":"fervero"}}