{"action":"created","issue":{"url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/49","repository_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto","labels_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/49/comments","events_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/49/events","html_url":"https://github.com/SemanticMediaWiki/SemanticScribunto/pull/49","id":307671051,"number":49,"title":"fix #48 (mw.set drops property names with numbers in key-value mode)","user":{"login":"oetterer","id":9444462,"avatar_url":"https://avatars0.githubusercontent.com/u/9444462?v=4","gravatar_id":"","url":"https://api.github.com/users/oetterer","html_url":"https://github.com/oetterer","followers_url":"https://api.github.com/users/oetterer/followers","following_url":"https://api.github.com/users/oetterer/following{/other_user}","gists_url":"https://api.github.com/users/oetterer/gists{/gist_id}","starred_url":"https://api.github.com/users/oetterer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oetterer/subscriptions","organizations_url":"https://api.github.com/users/oetterer/orgs","repos_url":"https://api.github.com/users/oetterer/repos","events_url":"https://api.github.com/users/oetterer/events{/privacy}","received_events_url":"https://api.github.com/users/oetterer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-22T14:37:38Z","updated_at":"2018-03-22T14:53:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/49","html_url":"https://github.com/SemanticMediaWiki/SemanticScribunto/pull/49","diff_url":"https://github.com/SemanticMediaWiki/SemanticScribunto/pull/49.diff","patch_url":"https://github.com/SemanticMediaWiki/SemanticScribunto/pull/49.patch"},"body":"adds:\r\n- a test, including fixture, to reproduce the problem\r\n- a fix for the problem (regular expressions and I are still at odds, it seems)\r\n\r\ncloses #48"},"comment":{"url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/comments/375334757","html_url":"https://github.com/SemanticMediaWiki/SemanticScribunto/pull/49#issuecomment-375334757","issue_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/49","id":375334757,"user":{"login":"mwjames","id":1245473,"avatar_url":"https://avatars1.githubusercontent.com/u/1245473?v=4","gravatar_id":"","url":"https://api.github.com/users/mwjames","html_url":"https://github.com/mwjames","followers_url":"https://api.github.com/users/mwjames/followers","following_url":"https://api.github.com/users/mwjames/following{/other_user}","gists_url":"https://api.github.com/users/mwjames/gists{/gist_id}","starred_url":"https://api.github.com/users/mwjames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwjames/subscriptions","organizations_url":"https://api.github.com/users/mwjames/orgs","repos_url":"https://api.github.com/users/mwjames/repos","events_url":"https://api.github.com/users/mwjames/events{/privacy}","received_events_url":"https://api.github.com/users/mwjames/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T14:53:13Z","updated_at":"2018-03-22T14:53:13Z","author_association":"CONTRIBUTOR","body":"> hm. Can I be so bold and assume, that the failing master test is not caused\n> by my fix..\n\nYes, and most likely caused by [0].\n\nPS: [1] shows how to deal with different MW releases where the output changed.\n\n[0] https://github.com/wikimedia/mediawiki/commit/3bae295aef6f6495dc37802f1f4f6956c9a5648c\n[1] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/24ef304aa31a2cd20123bf5e40b1a178dd7d5f31/tests/phpunit/Integration/JSONScript/TestCases/s-0014.json#L70-L112\n\nCheers\n\nOn 3/22/18, Tobias Oetterer <notifications@github.com> wrote:\n> hm. Can I be so bold and assume, that the failing master test is not caused\n> by my fix...\n>\n> --\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly or view it on GitHub:\n> https://github.com/SemanticMediaWiki/SemanticScribunto/pull/49#issuecomment-375333692\n"}}
{"actor":{"display_login":"mwjames"}}