{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61878","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61878/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61878/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61878/events","html_url":"https://github.com/kubernetes/kubernetes/pull/61878","id":309621969,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc4MjI4NTMz","number":61878,"title":"Adding Alternative Node Naming Convention","user":{"login":"nathanjsweet","id":447792,"node_id":"MDQ6VXNlcjQ0Nzc5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/447792?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanjsweet","html_url":"https://github.com/nathanjsweet","followers_url":"https://api.github.com/users/nathanjsweet/followers","following_url":"https://api.github.com/users/nathanjsweet/following{/other_user}","gists_url":"https://api.github.com/users/nathanjsweet/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanjsweet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanjsweet/subscriptions","organizations_url":"https://api.github.com/users/nathanjsweet/orgs","repos_url":"https://api.github.com/users/nathanjsweet/repos","events_url":"https://api.github.com/users/nathanjsweet/events{/privacy}","received_events_url":"https://api.github.com/users/nathanjsweet/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":328487998,"node_id":"MDU6TGFiZWwzMjg0ODc5OTg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/aws","name":"sig/aws","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-03-29T05:11:33Z","updated_at":"2018-06-14T15:57:56Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61878","html_url":"https://github.com/kubernetes/kubernetes/pull/61878","diff_url":"https://github.com/kubernetes/kubernetes/pull/61878.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/61878.patch"},"body":"**What this PR does / why we need it**:\r\nCurrently node names in aws are derived from the private-dns entry of the ec2 instance.\r\nThis PR offers administrators, who might have differing dns toplogies in their VPCs,\r\nthe option to manually configure their node names. This PR also directly addresses a\r\nbug in K8s that prevents the Node Admission Controller from working properly when the AWS cloud provider is selected.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #11543\r\nFixes #47695\r\nFixes #52241\r\n\r\nAddresses #48929\r\n\r\nIs there someone where I need to document this?\r\n```release-note\r\nAllow node names in AWS to be configured explicitly with a tag\r\n```\r\n/sig aws"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/397346918","html_url":"https://github.com/kubernetes/kubernetes/pull/61878#issuecomment-397346918","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61878","id":397346918,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzM0NjkxOA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T15:57:56Z","updated_at":"2018-06-14T15:57:56Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/61878#\" title=\"Author self-approved\">nathanjsweet</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **brendandburns**\n\nAssign the PR to them by writing `/assign @brendandburns` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubernetes/kubernetes/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"brendandburns\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}