{"action":"created","comment":{"url":"https://api.github.com/repos/aleklisi/sparrow/pulls/comments/207500992","pull_request_review_id":143106066,"id":207500992,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzUwMDk5Mg==","diff_hunk":"@@ -0,0 +1,158 @@\n+defmodule ApnsMock.ConnTest do\n+  use ExUnit.Case\n+\n+  alias H2Integration.Helpers.SetupHelper, as: Setup\n+  alias Sparrow.APNS.Notification, as: Notification\n+  @apns_mock_address \"localhost\"\n+\n+  setup do\n+    {:ok, _cowboy_pid, cowboys_name} =\n+      :cowboy_router.compile([\n+        {\":_\",\n+         [\n+           {\"/3/device/OkResponseHandler\", ApnsMock.CowboyHandlers.OkResponseHandler, []},","path":"test/apns_mock/conn_test.exs","position":13,"original_position":13,"commit_id":"04f8c55044e5218ccd231c3396b2f547c0ff1cb1","original_commit_id":"d63205f921d03433202794798175fc5e8604a769","user":{"login":"arkgil","id":11610769,"node_id":"MDQ6VXNlcjExNjEwNzY5","avatar_url":"https://avatars1.githubusercontent.com/u/11610769?v=4","gravatar_id":"","url":"https://api.github.com/users/arkgil","html_url":"https://github.com/arkgil","followers_url":"https://api.github.com/users/arkgil/followers","following_url":"https://api.github.com/users/arkgil/following{/other_user}","gists_url":"https://api.github.com/users/arkgil/gists{/gist_id}","starred_url":"https://api.github.com/users/arkgil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkgil/subscriptions","organizations_url":"https://api.github.com/users/arkgil/orgs","repos_url":"https://api.github.com/users/arkgil/repos","events_url":"https://api.github.com/users/arkgil/events{/privacy}","received_events_url":"https://api.github.com/users/arkgil/received_events","type":"User","site_admin":false},"body":"You're hardcoding the device token in these paths and then again in tests. It would be good to extract them as module attributes, e.g.\r\n\r\n```elixir\r\n@ok_device_token \"ok_device_token\"\r\n@echo_device_token \"echo_device_token\"\r\n...\r\n```\r\n\r\nand then use them in tests and to construct handlers paths. Right now it's hard to figure out that these values are actually tokens.","created_at":"2018-08-03T10:10:15Z","updated_at":"2018-08-03T10:16:40Z","html_url":"https://github.com/aleklisi/sparrow/pull/8#discussion_r207500992","pull_request_url":"https://api.github.com/repos/aleklisi/sparrow/pulls/8","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/aleklisi/sparrow/pulls/comments/207500992"},"html":{"href":"https://github.com/aleklisi/sparrow/pull/8#discussion_r207500992"},"pull_request":{"href":"https://api.github.com/repos/aleklisi/sparrow/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/aleklisi/sparrow/pulls/8","id":205152395,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTUyMzk1","html_url":"https://github.com/aleklisi/sparrow/pull/8","diff_url":"https://github.com/aleklisi/sparrow/pull/8.diff","patch_url":"https://github.com/aleklisi/sparrow/pull/8.patch","issue_url":"https://api.github.com/repos/aleklisi/sparrow/issues/8","number":8,"state":"open","locked":false,"title":"WiP - Implementing apns prototype","user":{"login":"aleklisi","id":16130626,"node_id":"MDQ6VXNlcjE2MTMwNjI2","avatar_url":"https://avatars2.githubusercontent.com/u/16130626?v=4","gravatar_id":"","url":"https://api.github.com/users/aleklisi","html_url":"https://github.com/aleklisi","followers_url":"https://api.github.com/users/aleklisi/followers","following_url":"https://api.github.com/users/aleklisi/following{/other_user}","gists_url":"https://api.github.com/users/aleklisi/gists{/gist_id}","starred_url":"https://api.github.com/users/aleklisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleklisi/subscriptions","organizations_url":"https://api.github.com/users/aleklisi/orgs","repos_url":"https://api.github.com/users/aleklisi/repos","events_url":"https://api.github.com/users/aleklisi/events{/privacy}","received_events_url":"https://api.github.com/users/aleklisi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-31T15:27:43Z","updated_at":"2018-08-03T10:16:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e7f9187055dacb806fbf8337168515be79fbfd4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aleklisi/sparrow/pulls/8/commits","review_comments_url":"https://api.github.com/repos/aleklisi/sparrow/pulls/8/comments","review_comment_url":"https://api.github.com/repos/aleklisi/sparrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aleklisi/sparrow/issues/8/comments","statuses_url":"https://api.github.com/repos/aleklisi/sparrow/statuses/04f8c55044e5218ccd231c3396b2f547c0ff1cb1","head":{"label":"aleklisi:implementing-apns-prototype","ref":"implementing-apns-prototype","sha":"04f8c55044e5218ccd231c3396b2f547c0ff1cb1","user":{"login":"aleklisi","id":16130626,"node_id":"MDQ6VXNlcjE2MTMwNjI2","avatar_url":"https://avatars2.githubusercontent.com/u/16130626?v=4","gravatar_id":"","url":"https://api.github.com/users/aleklisi","html_url":"https://github.com/aleklisi","followers_url":"https://api.github.com/users/aleklisi/followers","following_url":"https://api.github.com/users/aleklisi/following{/other_user}","gists_url":"https://api.github.com/users/aleklisi/gists{/gist_id}","starred_url":"https://api.github.com/users/aleklisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleklisi/subscriptions","organizations_url":"https://api.github.com/users/aleklisi/orgs","repos_url":"https://api.github.com/users/aleklisi/repos","events_url":"https://api.github.com/users/aleklisi/events{/privacy}","received_events_url":"https://api.github.com/users/aleklisi/received_events","type":"User","site_admin":false},"repo":{"id":139951896,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5NTE4OTY=","name":"sparrow","full_name":"aleklisi/sparrow","owner":{"login":"aleklisi","id":16130626,"node_id":"MDQ6VXNlcjE2MTMwNjI2","avatar_url":"https://avatars2.githubusercontent.com/u/16130626?v=4","gravatar_id":"","url":"https://api.github.com/users/aleklisi","html_url":"https://github.com/aleklisi","followers_url":"https://api.github.com/users/aleklisi/followers","following_url":"https://api.github.com/users/aleklisi/following{/other_user}","gists_url":"https://api.github.com/users/aleklisi/gists{/gist_id}","starred_url":"https://api.github.com/users/aleklisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleklisi/subscriptions","organizations_url":"https://api.github.com/users/aleklisi/orgs","repos_url":"https://api.github.com/users/aleklisi/repos","events_url":"https://api.github.com/users/aleklisi/events{/privacy}","received_events_url":"https://api.github.com/users/aleklisi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aleklisi/sparrow","description":"HTTP2-compliant library for sending iOS and Android push notifications.","fork":false,"url":"https://api.github.com/repos/aleklisi/sparrow","forks_url":"https://api.github.com/repos/aleklisi/sparrow/forks","keys_url":"https://api.github.com/repos/aleklisi/sparrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aleklisi/sparrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aleklisi/sparrow/teams","hooks_url":"https://api.github.com/repos/aleklisi/sparrow/hooks","issue_events_url":"https://api.github.com/repos/aleklisi/sparrow/issues/events{/number}","events_url":"https://api.github.com/repos/aleklisi/sparrow/events","assignees_url":"https://api.github.com/repos/aleklisi/sparrow/assignees{/user}","branches_url":"https://api.github.com/repos/aleklisi/sparrow/branches{/branch}","tags_url":"https://api.github.com/repos/aleklisi/sparrow/tags","blobs_url":"https://api.github.com/repos/aleklisi/sparrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aleklisi/sparrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aleklisi/sparrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/aleklisi/sparrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aleklisi/sparrow/statuses/{sha}","languages_url":"https://api.github.com/repos/aleklisi/sparrow/languages","stargazers_url":"https://api.github.com/repos/aleklisi/sparrow/stargazers","contributors_url":"https://api.github.com/repos/aleklisi/sparrow/contributors","subscribers_url":"https://api.github.com/repos/aleklisi/sparrow/subscribers","subscription_url":"https://api.github.com/repos/aleklisi/sparrow/subscription","commits_url":"https://api.github.com/repos/aleklisi/sparrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/aleklisi/sparrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/aleklisi/sparrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/aleklisi/sparrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/aleklisi/sparrow/contents/{+path}","compare_url":"https://api.github.com/repos/aleklisi/sparrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aleklisi/sparrow/merges","archive_url":"https://api.github.com/repos/aleklisi/sparrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aleklisi/sparrow/downloads","issues_url":"https://api.github.com/repos/aleklisi/sparrow/issues{/number}","pulls_url":"https://api.github.com/repos/aleklisi/sparrow/pulls{/number}","milestones_url":"https://api.github.com/repos/aleklisi/sparrow/milestones{/number}","notifications_url":"https://api.github.com/repos/aleklisi/sparrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aleklisi/sparrow/labels{/name}","releases_url":"https://api.github.com/repos/aleklisi/sparrow/releases{/id}","deployments_url":"https://api.github.com/repos/aleklisi/sparrow/deployments","created_at":"2018-07-06T07:53:29Z","updated_at":"2018-07-30T11:37:14Z","pushed_at":"2018-08-03T09:36:54Z","git_url":"git://github.com/aleklisi/sparrow.git","ssh_url":"git@github.com:aleklisi/sparrow.git","clone_url":"https://github.com/aleklisi/sparrow.git","svn_url":"https://github.com/aleklisi/sparrow","homepage":null,"size":115,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"aleklisi:master","ref":"master","sha":"cbdea121f103c9dc008d6a8310daad93ab729999","user":{"login":"aleklisi","id":16130626,"node_id":"MDQ6VXNlcjE2MTMwNjI2","avatar_url":"https://avatars2.githubusercontent.com/u/16130626?v=4","gravatar_id":"","url":"https://api.github.com/users/aleklisi","html_url":"https://github.com/aleklisi","followers_url":"https://api.github.com/users/aleklisi/followers","following_url":"https://api.github.com/users/aleklisi/following{/other_user}","gists_url":"https://api.github.com/users/aleklisi/gists{/gist_id}","starred_url":"https://api.github.com/users/aleklisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleklisi/subscriptions","organizations_url":"https://api.github.com/users/aleklisi/orgs","repos_url":"https://api.github.com/users/aleklisi/repos","events_url":"https://api.github.com/users/aleklisi/events{/privacy}","received_events_url":"https://api.github.com/users/aleklisi/received_events","type":"User","site_admin":false},"repo":{"id":139951896,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5NTE4OTY=","name":"sparrow","full_name":"aleklisi/sparrow","owner":{"login":"aleklisi","id":16130626,"node_id":"MDQ6VXNlcjE2MTMwNjI2","avatar_url":"https://avatars2.githubusercontent.com/u/16130626?v=4","gravatar_id":"","url":"https://api.github.com/users/aleklisi","html_url":"https://github.com/aleklisi","followers_url":"https://api.github.com/users/aleklisi/followers","following_url":"https://api.github.com/users/aleklisi/following{/other_user}","gists_url":"https://api.github.com/users/aleklisi/gists{/gist_id}","starred_url":"https://api.github.com/users/aleklisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleklisi/subscriptions","organizations_url":"https://api.github.com/users/aleklisi/orgs","repos_url":"https://api.github.com/users/aleklisi/repos","events_url":"https://api.github.com/users/aleklisi/events{/privacy}","received_events_url":"https://api.github.com/users/aleklisi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aleklisi/sparrow","description":"HTTP2-compliant library for sending iOS and Android push notifications.","fork":false,"url":"https://api.github.com/repos/aleklisi/sparrow","forks_url":"https://api.github.com/repos/aleklisi/sparrow/forks","keys_url":"https://api.github.com/repos/aleklisi/sparrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aleklisi/sparrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aleklisi/sparrow/teams","hooks_url":"https://api.github.com/repos/aleklisi/sparrow/hooks","issue_events_url":"https://api.github.com/repos/aleklisi/sparrow/issues/events{/number}","events_url":"https://api.github.com/repos/aleklisi/sparrow/events","assignees_url":"https://api.github.com/repos/aleklisi/sparrow/assignees{/user}","branches_url":"https://api.github.com/repos/aleklisi/sparrow/branches{/branch}","tags_url":"https://api.github.com/repos/aleklisi/sparrow/tags","blobs_url":"https://api.github.com/repos/aleklisi/sparrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aleklisi/sparrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aleklisi/sparrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/aleklisi/sparrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aleklisi/sparrow/statuses/{sha}","languages_url":"https://api.github.com/repos/aleklisi/sparrow/languages","stargazers_url":"https://api.github.com/repos/aleklisi/sparrow/stargazers","contributors_url":"https://api.github.com/repos/aleklisi/sparrow/contributors","subscribers_url":"https://api.github.com/repos/aleklisi/sparrow/subscribers","subscription_url":"https://api.github.com/repos/aleklisi/sparrow/subscription","commits_url":"https://api.github.com/repos/aleklisi/sparrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/aleklisi/sparrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/aleklisi/sparrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/aleklisi/sparrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/aleklisi/sparrow/contents/{+path}","compare_url":"https://api.github.com/repos/aleklisi/sparrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aleklisi/sparrow/merges","archive_url":"https://api.github.com/repos/aleklisi/sparrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aleklisi/sparrow/downloads","issues_url":"https://api.github.com/repos/aleklisi/sparrow/issues{/number}","pulls_url":"https://api.github.com/repos/aleklisi/sparrow/pulls{/number}","milestones_url":"https://api.github.com/repos/aleklisi/sparrow/milestones{/number}","notifications_url":"https://api.github.com/repos/aleklisi/sparrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aleklisi/sparrow/labels{/name}","releases_url":"https://api.github.com/repos/aleklisi/sparrow/releases{/id}","deployments_url":"https://api.github.com/repos/aleklisi/sparrow/deployments","created_at":"2018-07-06T07:53:29Z","updated_at":"2018-07-30T11:37:14Z","pushed_at":"2018-08-03T09:36:54Z","git_url":"git://github.com/aleklisi/sparrow.git","ssh_url":"git@github.com:aleklisi/sparrow.git","clone_url":"https://github.com/aleklisi/sparrow.git","svn_url":"https://github.com/aleklisi/sparrow","homepage":null,"size":115,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aleklisi/sparrow/pulls/8"},"html":{"href":"https://github.com/aleklisi/sparrow/pull/8"},"issue":{"href":"https://api.github.com/repos/aleklisi/sparrow/issues/8"},"comments":{"href":"https://api.github.com/repos/aleklisi/sparrow/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/aleklisi/sparrow/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/aleklisi/sparrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aleklisi/sparrow/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/aleklisi/sparrow/statuses/04f8c55044e5218ccd231c3396b2f547c0ff1cb1"}},"author_association":"OWNER"}}
{"actor":{"display_login":"arkgil"}}