{"action":"created","issue":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/21402","repository_url":"https://api.github.com/repos/pandas-dev/pandas","labels_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21402/labels{/name}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21402/comments","events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21402/events","html_url":"https://github.com/pandas-dev/pandas/pull/21402","id":330900892,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzg1NzI5","number":21402,"title":"CI: Enable Spellcheck in dockbuild","user":{"login":"FabioRosado","id":3131401,"node_id":"MDQ6VXNlcjMxMzE0MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/3131401?v=4","gravatar_id":"","url":"https://api.github.com/users/FabioRosado","html_url":"https://github.com/FabioRosado","followers_url":"https://api.github.com/users/FabioRosado/followers","following_url":"https://api.github.com/users/FabioRosado/following{/other_user}","gists_url":"https://api.github.com/users/FabioRosado/gists{/gist_id}","starred_url":"https://api.github.com/users/FabioRosado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabioRosado/subscriptions","organizations_url":"https://api.github.com/users/FabioRosado/orgs","repos_url":"https://api.github.com/users/FabioRosado/repos","events_url":"https://api.github.com/users/FabioRosado/events{/privacy}","received_events_url":"https://api.github.com/users/FabioRosado/received_events","type":"User","site_admin":false},"labels":[{"id":134699,"node_id":"MDU6TGFiZWwxMzQ2OTk=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Docs","name":"Docs","color":"3465A4","default":false},{"id":127685,"node_id":"MDU6TGFiZWwxMjc2ODU=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Testing","name":"Testing","color":"C4A000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-06-09T16:31:45Z","updated_at":"2018-06-19T12:16:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21402","html_url":"https://github.com/pandas-dev/pandas/pull/21402","diff_url":"https://github.com/pandas-dev/pandas/pull/21402.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/21402.patch"},"body":"This is the initial PR to try and fix the issue #21354 the sphinx spelling extension needs every name to be divided and added to each line in order to get the name marked as spelt correctly. The file `names_wordlist.txt` is updated on every run of the function `get_authors()` located inside`scripts/announce.py`.\r\n\r\nSince the issue #21396 is related to my previous PR I attempted to resolve this issue here as well, I followed the suggestion of @jorisvandenbossche and added a try/except to the `conf.py` if the dependency doesn't exist then nothing will happen.\r\n\r\n@datapythonista since you submitted a PR(#21397) to try and fix the issue, perhaps you have an opinion about this bit of code. Also, if you would like to do the changes on your own PR I will just delete this bit and use your solution 😄 👍 \r\n\r\nI would like some feedback on this first attempt, the generator `[names.extend(re.sub('\\W+', ' ', x).split()) for x in cur.union(pre)]` seems a bit smelly but does the trick, should this be refactored to use a long form and make it more readable? I extended the list to names because split() was creating a list inside the main list and this makes every name to be split and added to the same list (this is probably very memory inefficient though)\r\n\r\nI tried to run the script from my machine but I got an issue with it, probably I'm doing something wrong but when I run `./scripts/announce.py $GITHUB v0.15.1..v0.23.0` I get the error message:\r\n\r\n```\r\nusage: announce.py [-h] [--repo REPO] revision_range \r\nannounce.py: error: unrecognized arguments: v0.15.1..v0.23.0\r\n```\r\n\r\nNot sure what I'm doing wrong, to be honest. If I run just the `get_authors()` function everything seems to be fine (including the v0.15.1..v0.23.0 format) and the names_wordlist is updated successfully.\r\n\r\nI will look forward to read your opinions about this PR 👍 \r\n----\r\n- [ ] closes #21396 #21354\r\n- [ ] tests added / passed\r\n- [ ] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry"},"comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments/398377929","html_url":"https://github.com/pandas-dev/pandas/pull/21402#issuecomment-398377929","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21402","id":398377929,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODM3NzkyOQ==","user":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T12:16:04Z","updated_at":"2018-06-19T12:16:04Z","author_association":"MEMBER","body":"> BTW, I think a very valuable contribution would be to add a feature to sphinxcontrib-spelling to skip a file ... (that would solve many problems here!)\r\n\r\nAnd it might be as simple as skipping based on the `docname` in https://github.com/sphinx-contrib/spelling/blob/fa8c4b6140d7be0dcaa2aefbf690b84090bb0884/sphinxcontrib/spelling/builder.py#L144"}}
{"actor":{"display_login":"jorisvandenbossche"}}