{"action":"closed","number":24769,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/24769","id":226692235,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjkyMjM1","html_url":"https://github.com/elastic/kibana/pull/24769","diff_url":"https://github.com/elastic/kibana/pull/24769.diff","patch_url":"https://github.com/elastic/kibana/pull/24769.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/24769","number":24769,"state":"closed","locked":false,"title":"Return promise in reporting jobs API","user":{"login":"joshdover","id":1813008,"node_id":"MDQ6VXNlcjE4MTMwMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1813008?v=4","gravatar_id":"","url":"https://api.github.com/users/joshdover","html_url":"https://github.com/joshdover","followers_url":"https://api.github.com/users/joshdover/followers","following_url":"https://api.github.com/users/joshdover/following{/other_user}","gists_url":"https://api.github.com/users/joshdover/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdover/subscriptions","organizations_url":"https://api.github.com/users/joshdover/orgs","repos_url":"https://api.github.com/users/joshdover/repos","events_url":"https://api.github.com/users/joshdover/events{/privacy}","received_events_url":"https://api.github.com/users/joshdover/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nFixes a route handler that was not converted correctly in #21707 and was making this 500 error happen:\r\n```\r\nserver  respons [17:09:18.579]  GET /api/reporting/jobs/output/jnujv2r0036l9d006216i2e9 500 32ms - 9.0B\r\nDebug: internal, implementation, error \r\n    Error: handler method did not return a value, a promise, or throw an error\r\n    at module.exports.internals.Manager.execute (/Users/stacey/Elastic/kibana/node_modules/hapi/lib/toolkit.js:52:29)\r\n    at <anonymous>\r\n```\r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)\r\n- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)\r\n- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials\r\n- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios\r\n- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n\r\n","created_at":"2018-10-29T19:53:19Z","updated_at":"2018-10-29T22:14:28Z","closed_at":"2018-10-29T22:14:28Z","merged_at":"2018-10-29T22:14:28Z","merge_commit_sha":"69d25d8e5046686e43180503aecc4bed0efdcfd9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":912940527,"node_id":"MDU6TGFiZWw5MTI5NDA1Mjc=","url":"https://api.github.com/repos/elastic/kibana/labels/:Reporting","name":":Reporting","color":"0e8a16","default":false},{"id":1062169267,"node_id":"MDU6TGFiZWwxMDYyMTY5MjY3","url":"https://api.github.com/repos/elastic/kibana/labels/v6.6.0","name":"v6.6.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/24769/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/24769/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/24769/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/b1e322af239db13a82db2b70def170c3ac63d0bf","head":{"label":"joshdover:fx-reporting-jobs","ref":"fx-reporting-jobs","sha":"b1e322af239db13a82db2b70def170c3ac63d0bf","user":{"login":"joshdover","id":1813008,"node_id":"MDQ6VXNlcjE4MTMwMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1813008?v=4","gravatar_id":"","url":"https://api.github.com/users/joshdover","html_url":"https://github.com/joshdover","followers_url":"https://api.github.com/users/joshdover/followers","following_url":"https://api.github.com/users/joshdover/following{/other_user}","gists_url":"https://api.github.com/users/joshdover/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdover/subscriptions","organizations_url":"https://api.github.com/users/joshdover/orgs","repos_url":"https://api.github.com/users/joshdover/repos","events_url":"https://api.github.com/users/joshdover/events{/privacy}","received_events_url":"https://api.github.com/users/joshdover/received_events","type":"User","site_admin":false},"repo":{"id":139932255,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5MzIyNTU=","name":"kibana","full_name":"joshdover/kibana","private":false,"owner":{"login":"joshdover","id":1813008,"node_id":"MDQ6VXNlcjE4MTMwMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1813008?v=4","gravatar_id":"","url":"https://api.github.com/users/joshdover","html_url":"https://github.com/joshdover","followers_url":"https://api.github.com/users/joshdover/followers","following_url":"https://api.github.com/users/joshdover/following{/other_user}","gists_url":"https://api.github.com/users/joshdover/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdover/subscriptions","organizations_url":"https://api.github.com/users/joshdover/orgs","repos_url":"https://api.github.com/users/joshdover/repos","events_url":"https://api.github.com/users/joshdover/events{/privacy}","received_events_url":"https://api.github.com/users/joshdover/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joshdover/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/joshdover/kibana","forks_url":"https://api.github.com/repos/joshdover/kibana/forks","keys_url":"https://api.github.com/repos/joshdover/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshdover/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshdover/kibana/teams","hooks_url":"https://api.github.com/repos/joshdover/kibana/hooks","issue_events_url":"https://api.github.com/repos/joshdover/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/joshdover/kibana/events","assignees_url":"https://api.github.com/repos/joshdover/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/joshdover/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/joshdover/kibana/tags","blobs_url":"https://api.github.com/repos/joshdover/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshdover/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshdover/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshdover/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshdover/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/joshdover/kibana/languages","stargazers_url":"https://api.github.com/repos/joshdover/kibana/stargazers","contributors_url":"https://api.github.com/repos/joshdover/kibana/contributors","subscribers_url":"https://api.github.com/repos/joshdover/kibana/subscribers","subscription_url":"https://api.github.com/repos/joshdover/kibana/subscription","commits_url":"https://api.github.com/repos/joshdover/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshdover/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshdover/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshdover/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshdover/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/joshdover/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshdover/kibana/merges","archive_url":"https://api.github.com/repos/joshdover/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshdover/kibana/downloads","issues_url":"https://api.github.com/repos/joshdover/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/joshdover/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/joshdover/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/joshdover/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshdover/kibana/labels{/name}","releases_url":"https://api.github.com/repos/joshdover/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/joshdover/kibana/deployments","created_at":"2018-07-06T04:15:01Z","updated_at":"2018-10-19T19:50:07Z","pushed_at":"2018-10-29T21:38:55Z","git_url":"git://github.com/joshdover/kibana.git","ssh_url":"git@github.com:joshdover/kibana.git","clone_url":"https://github.com/joshdover/kibana.git","svn_url":"https://github.com/joshdover/kibana","homepage":"https://www.elastic.co/products/kibana","size":525360,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"460a297bc9b688ad50cadc50ede99795a980acfd","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-10-29T21:31:58Z","pushed_at":"2018-10-29T22:14:28Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":556822,"stargazers_count":10332,"watchers_count":10332,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4023,"mirror_url":null,"archived":false,"open_issues_count":3625,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4023,"open_issues":3625,"watchers":10332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/24769"},"html":{"href":"https://github.com/elastic/kibana/pull/24769"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/24769"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/24769/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/24769/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/24769/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/b1e322af239db13a82db2b70def170c3ac63d0bf"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"joshdover","id":1813008,"node_id":"MDQ6VXNlcjE4MTMwMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1813008?v=4","gravatar_id":"","url":"https://api.github.com/users/joshdover","html_url":"https://github.com/joshdover","followers_url":"https://api.github.com/users/joshdover/followers","following_url":"https://api.github.com/users/joshdover/following{/other_user}","gists_url":"https://api.github.com/users/joshdover/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdover/subscriptions","organizations_url":"https://api.github.com/users/joshdover/orgs","repos_url":"https://api.github.com/users/joshdover/repos","events_url":"https://api.github.com/users/joshdover/events{/privacy}","received_events_url":"https://api.github.com/users/joshdover/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"joshdover"}}