{"action":"created","comment":{"url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/comments/204687417","pull_request_review_id":139808469,"id":204687417,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDY4NzQxNw==","diff_hunk":"@@ -1,52 +1,93 @@\n import { addBooleanParameter } from \"@oui-angular/common/component-utils\";\n+import get from \"lodash/get\";\n \n export default class {\n-    constructor ($attrs, $document, $element, $timeout, ouiNavbarConfiguration, NavbarService, KEYBOARD_KEYS) {\n+    constructor ($attrs, $document, $element, $timeout, ouiNavbarConfiguration, KEYBOARD_KEYS) {\n         \"ngInject\";\n \n         this.$attrs = $attrs;\n         this.$document = $document;\n         this.$element = $element;\n         this.$timeout = $timeout;\n         this.config = ouiNavbarConfiguration;\n-        this.navbarService = NavbarService;\n+\n+        this.keyboardNav = {};\n         this.KEYBOARD_KEYS = KEYBOARD_KEYS;\n     }\n \n+    addItemToGroup (item, groupName) {\n+        // Create the group if it doesn't exist\n+        if (angular.isUndefined(this.keyboardNav[groupName])) {\n+            this.keyboardNav[groupName] = [];\n+        }\n+\n+        // Add item to the group\n+        this.keyboardNav[groupName].push(item);\n+    }\n+\n+    getGroup (groupName) {\n+        return this.keyboardNav[groupName];\n+    }\n+\n+    // Set focus to an item of a group\n+    setFocusTo (groupName, index) {\n+        // Add a delay to force focus\n+        const delay = 50;","path":"packages/oui-navbar/src/navbar.controller.js","position":37,"original_position":37,"commit_id":"018a8b4db7361f7bba3912891a132703cadb4a70","original_commit_id":"018a8b4db7361f7bba3912891a132703cadb4a70","user":{"login":"AxelPeter","id":15101925,"node_id":"MDQ6VXNlcjE1MTAxOTI1","avatar_url":"https://avatars1.githubusercontent.com/u/15101925?v=4","gravatar_id":"","url":"https://api.github.com/users/AxelPeter","html_url":"https://github.com/AxelPeter","followers_url":"https://api.github.com/users/AxelPeter/followers","following_url":"https://api.github.com/users/AxelPeter/following{/other_user}","gists_url":"https://api.github.com/users/AxelPeter/gists{/gist_id}","starred_url":"https://api.github.com/users/AxelPeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AxelPeter/subscriptions","organizations_url":"https://api.github.com/users/AxelPeter/orgs","repos_url":"https://api.github.com/users/AxelPeter/repos","events_url":"https://api.github.com/users/AxelPeter/events{/privacy}","received_events_url":"https://api.github.com/users/AxelPeter/received_events","type":"User","site_admin":false},"body":"Not the same, we don't want to autofocus on the page load","created_at":"2018-07-24T09:35:22Z","updated_at":"2018-07-24T09:35:22Z","html_url":"https://github.com/ovh-ux/ovh-ui-angular/pull/235#discussion_r204687417","pull_request_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/235","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/comments/204687417"},"html":{"href":"https://github.com/ovh-ux/ovh-ui-angular/pull/235#discussion_r204687417"},"pull_request":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/235"}},"in_reply_to_id":204682277},"pull_request":{"url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/235","id":202832012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODMyMDEy","html_url":"https://github.com/ovh-ux/ovh-ui-angular/pull/235","diff_url":"https://github.com/ovh-ux/ovh-ui-angular/pull/235.diff","patch_url":"https://github.com/ovh-ux/ovh-ui-angular/pull/235.patch","issue_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/235","number":235,"state":"open","locked":false,"title":"feat(oui-navbar): add new components","user":{"login":"AxelPeter","id":15101925,"node_id":"MDQ6VXNlcjE1MTAxOTI1","avatar_url":"https://avatars1.githubusercontent.com/u/15101925?v=4","gravatar_id":"","url":"https://api.github.com/users/AxelPeter","html_url":"https://github.com/AxelPeter","followers_url":"https://api.github.com/users/AxelPeter/followers","following_url":"https://api.github.com/users/AxelPeter/following{/other_user}","gists_url":"https://api.github.com/users/AxelPeter/gists{/gist_id}","starred_url":"https://api.github.com/users/AxelPeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AxelPeter/subscriptions","organizations_url":"https://api.github.com/users/AxelPeter/orgs","repos_url":"https://api.github.com/users/AxelPeter/repos","events_url":"https://api.github.com/users/AxelPeter/events{/privacy}","received_events_url":"https://api.github.com/users/AxelPeter/received_events","type":"User","site_admin":false},"body":"- Add oui-navbar-brand\r\n- Add oui-navbar-dropdown\r\n- Add oui-navbar-link\r\n- Add oui-navbar-toggler\r\n- Add oui-navbar-notification\r\n- Review documentation\r\n- Fix tab navigation of notifications\r\n- Add more unit tests\r\n\r\nLinked to https://github.com/ovh-ux/ovh-ui-kit/pull/246","created_at":"2018-07-20T12:15:08Z","updated_at":"2018-07-24T09:35:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48cdf01c8a57268777d0e82052c1b83a94bab066","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":837298853,"node_id":"MDU6TGFiZWw4MzcyOTg4NTM=","url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/labels/feature","name":"feature","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/235/commits","review_comments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/235/comments","review_comment_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/235/comments","statuses_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/statuses/018a8b4db7361f7bba3912891a132703cadb4a70","head":{"label":"ovh-ux:feature/upgrade-navbar","ref":"feature/upgrade-navbar","sha":"018a8b4db7361f7bba3912891a132703cadb4a70","user":{"login":"ovh-ux","id":26575234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTc1MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"repo":{"id":97920934,"node_id":"MDEwOlJlcG9zaXRvcnk5NzkyMDkzNA==","name":"ovh-ui-angular","full_name":"ovh-ux/ovh-ui-angular","owner":{"login":"ovh-ux","id":26575234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTc1MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ovh-ux/ovh-ui-angular","description":"A set of maintainable components for the OVH ecosystem (Angular).","fork":false,"url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular","forks_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/forks","keys_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/teams","hooks_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/hooks","issue_events_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/events{/number}","events_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/events","assignees_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/assignees{/user}","branches_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/branches{/branch}","tags_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/tags","blobs_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/languages","stargazers_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/stargazers","contributors_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/contributors","subscribers_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/subscribers","subscription_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/subscription","commits_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/contents/{+path}","compare_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/merges","archive_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/downloads","issues_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues{/number}","pulls_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/labels{/name}","releases_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/releases{/id}","deployments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/deployments","created_at":"2017-07-21T07:46:15Z","updated_at":"2018-07-17T15:11:03Z","pushed_at":"2018-07-24T08:58:18Z","git_url":"git://github.com/ovh-ux/ovh-ui-angular.git","ssh_url":"git@github.com:ovh-ux/ovh-ui-angular.git","clone_url":"https://github.com/ovh-ux/ovh-ui-angular.git","svn_url":"https://github.com/ovh-ux/ovh-ui-angular","homepage":"http://ui-kit.ovh","size":5764,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6,"open_issues":3,"watchers":10,"default_branch":"master"}},"base":{"label":"ovh-ux:develop","ref":"develop","sha":"8fd418b674efc4d6703d8f99909e4e9e51600316","user":{"login":"ovh-ux","id":26575234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTc1MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"repo":{"id":97920934,"node_id":"MDEwOlJlcG9zaXRvcnk5NzkyMDkzNA==","name":"ovh-ui-angular","full_name":"ovh-ux/ovh-ui-angular","owner":{"login":"ovh-ux","id":26575234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTc1MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ovh-ux/ovh-ui-angular","description":"A set of maintainable components for the OVH ecosystem (Angular).","fork":false,"url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular","forks_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/forks","keys_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/teams","hooks_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/hooks","issue_events_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/events{/number}","events_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/events","assignees_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/assignees{/user}","branches_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/branches{/branch}","tags_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/tags","blobs_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/languages","stargazers_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/stargazers","contributors_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/contributors","subscribers_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/subscribers","subscription_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/subscription","commits_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/contents/{+path}","compare_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/merges","archive_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/downloads","issues_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues{/number}","pulls_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/labels{/name}","releases_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/releases{/id}","deployments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/deployments","created_at":"2017-07-21T07:46:15Z","updated_at":"2018-07-17T15:11:03Z","pushed_at":"2018-07-24T08:58:18Z","git_url":"git://github.com/ovh-ux/ovh-ui-angular.git","ssh_url":"git@github.com:ovh-ux/ovh-ui-angular.git","clone_url":"https://github.com/ovh-ux/ovh-ui-angular.git","svn_url":"https://github.com/ovh-ux/ovh-ui-angular","homepage":"http://ui-kit.ovh","size":5764,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/235"},"html":{"href":"https://github.com/ovh-ux/ovh-ui-angular/pull/235"},"issue":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/235"},"comments":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/statuses/018a8b4db7361f7bba3912891a132703cadb4a70"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"AxelPeter"}}