{"action":"created","comment":{"url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/comments/191413194","pull_request_review_id":123979320,"id":191413194,"diff_hunk":"@@ -64,4 +75,16 @@ export class App {\n       },\n     ]);\n   }\n+\n+  public showSolutionExplorerChanged(showSolutionExplorer: boolean): void {\n+    if (this._eventAggregator === undefined) {","path":"src/app.ts","position":35,"original_position":35,"commit_id":"723117abd61516f09836d718af2b61b27335ac3d","original_commit_id":"723117abd61516f09836d718af2b61b27335ac3d","user":{"login":"LeoTT","id":21304781,"avatar_url":"https://avatars1.githubusercontent.com/u/21304781?v=4","gravatar_id":"","url":"https://api.github.com/users/LeoTT","html_url":"https://github.com/LeoTT","followers_url":"https://api.github.com/users/LeoTT/followers","following_url":"https://api.github.com/users/LeoTT/following{/other_user}","gists_url":"https://api.github.com/users/LeoTT/gists{/gist_id}","starred_url":"https://api.github.com/users/LeoTT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeoTT/subscriptions","organizations_url":"https://api.github.com/users/LeoTT/orgs","repos_url":"https://api.github.com/users/LeoTT/repos","events_url":"https://api.github.com/users/LeoTT/events{/privacy}","received_events_url":"https://api.github.com/users/LeoTT/received_events","type":"User","site_admin":false},"body":"resolved in person, to clarify: `showSolutionExplorerChanged` was called before constructor because of `public showSolutionExplorer: boolean = false; `.","created_at":"2018-05-29T12:59:50Z","updated_at":"2018-05-29T12:59:51Z","html_url":"https://github.com/process-engine/bpmn-studio/pull/434#discussion_r191413194","pull_request_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/434","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/comments/191413194"},"html":{"href":"https://github.com/process-engine/bpmn-studio/pull/434#discussion_r191413194"},"pull_request":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/434"}},"in_reply_to_id":191331990},"pull_request":{"url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/434","id":190542466,"html_url":"https://github.com/process-engine/bpmn-studio/pull/434","diff_url":"https://github.com/process-engine/bpmn-studio/pull/434.diff","patch_url":"https://github.com/process-engine/bpmn-studio/pull/434.patch","issue_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/434","number":434,"state":"open","locked":false,"title":"✨Include Process Solution Explorer Width in Property Panel MaxWidth Calculation","user":{"login":"SteffenKn","id":20394992,"avatar_url":"https://avatars2.githubusercontent.com/u/20394992?v=4","gravatar_id":"","url":"https://api.github.com/users/SteffenKn","html_url":"https://github.com/SteffenKn","followers_url":"https://api.github.com/users/SteffenKn/followers","following_url":"https://api.github.com/users/SteffenKn/following{/other_user}","gists_url":"https://api.github.com/users/SteffenKn/gists{/gist_id}","starred_url":"https://api.github.com/users/SteffenKn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteffenKn/subscriptions","organizations_url":"https://api.github.com/users/SteffenKn/orgs","repos_url":"https://api.github.com/users/SteffenKn/repos","events_url":"https://api.github.com/users/SteffenKn/events{/privacy}","received_events_url":"https://api.github.com/users/SteffenKn/received_events","type":"User","site_admin":false},"body":"## What did you change?\r\n\r\nThis PR adds the width of the process solution explorer to the calculation of the maxWidth of the property panel.\r\n\r\nAlso when hiding/showing the process solution explorer the property panel should be hidden/showed when there is/was not enough space.\r\n\r\nTODOs: \r\n\r\n- Refactor `_HideAndShowPropertyPanelForPlaceReasons`\r\n- Test everything again very carefully\r\n\r\nFixes #416 \r\n\r\n## How can others test the changes?\r\n\r\n- Open the Bpmn-Studio\r\n- Go to the Detail View of any ProcessDefinition\r\n- Resize the Property Panel and Hide/Show the Process Solution Explorer\r\n- See that the Process Solution Explorer can not break the Property Panel anymore\r\n\r\n## PR-Checklist\r\n\r\nPlease check the boxes in this list after submitting your PR:\r\n\r\n- [ ] You can merge this PR **right now** (if not, please prefix the title with \"WIP: \")\r\n- [ ] I've tested **all** changes included in this PR.\r\n- [ ] I've also reviewed this PR myself before submitting (e.g. for scrambled letters, typos, etc.)\r\n- [ ] I've merged the `develop` branch into my branch before finishing this PR.\r\n- [ ] I've **not added any other changes** than the ones described above.\r\n- [ ] I've mentioned all **PRs, which relate to this one**\r\n","created_at":"2018-05-25T10:13:23Z","updated_at":"2018-05-29T12:59:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2475a90b9bac09ebe4ee1d16d324546d9c562e3b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cmg-dev","id":4034128,"avatar_url":"https://avatars0.githubusercontent.com/u/4034128?v=4","gravatar_id":"","url":"https://api.github.com/users/cmg-dev","html_url":"https://github.com/cmg-dev","followers_url":"https://api.github.com/users/cmg-dev/followers","following_url":"https://api.github.com/users/cmg-dev/following{/other_user}","gists_url":"https://api.github.com/users/cmg-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/cmg-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmg-dev/subscriptions","organizations_url":"https://api.github.com/users/cmg-dev/orgs","repos_url":"https://api.github.com/users/cmg-dev/repos","events_url":"https://api.github.com/users/cmg-dev/events{/privacy}","received_events_url":"https://api.github.com/users/cmg-dev/received_events","type":"User","site_admin":false},{"login":"5ebastianMeier","id":16539774,"avatar_url":"https://avatars0.githubusercontent.com/u/16539774?v=4","gravatar_id":"","url":"https://api.github.com/users/5ebastianMeier","html_url":"https://github.com/5ebastianMeier","followers_url":"https://api.github.com/users/5ebastianMeier/followers","following_url":"https://api.github.com/users/5ebastianMeier/following{/other_user}","gists_url":"https://api.github.com/users/5ebastianMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/5ebastianMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5ebastianMeier/subscriptions","organizations_url":"https://api.github.com/users/5ebastianMeier/orgs","repos_url":"https://api.github.com/users/5ebastianMeier/repos","events_url":"https://api.github.com/users/5ebastianMeier/events{/privacy}","received_events_url":"https://api.github.com/users/5ebastianMeier/received_events","type":"User","site_admin":false},{"login":"roblen45","id":36449148,"avatar_url":"https://avatars1.githubusercontent.com/u/36449148?v=4","gravatar_id":"","url":"https://api.github.com/users/roblen45","html_url":"https://github.com/roblen45","followers_url":"https://api.github.com/users/roblen45/followers","following_url":"https://api.github.com/users/roblen45/following{/other_user}","gists_url":"https://api.github.com/users/roblen45/gists{/gist_id}","starred_url":"https://api.github.com/users/roblen45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblen45/subscriptions","organizations_url":"https://api.github.com/users/roblen45/orgs","repos_url":"https://api.github.com/users/roblen45/repos","events_url":"https://api.github.com/users/roblen45/events{/privacy}","received_events_url":"https://api.github.com/users/roblen45/received_events","type":"User","site_admin":false},{"login":"robpal94","id":38498731,"avatar_url":"https://avatars1.githubusercontent.com/u/38498731?v=4","gravatar_id":"","url":"https://api.github.com/users/robpal94","html_url":"https://github.com/robpal94","followers_url":"https://api.github.com/users/robpal94/followers","following_url":"https://api.github.com/users/robpal94/following{/other_user}","gists_url":"https://api.github.com/users/robpal94/gists{/gist_id}","starred_url":"https://api.github.com/users/robpal94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robpal94/subscriptions","organizations_url":"https://api.github.com/users/robpal94/orgs","repos_url":"https://api.github.com/users/robpal94/repos","events_url":"https://api.github.com/users/robpal94/events{/privacy}","received_events_url":"https://api.github.com/users/robpal94/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/434/commits","review_comments_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/434/comments","review_comment_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/434/comments","statuses_url":"https://api.github.com/repos/process-engine/bpmn-studio/statuses/723117abd61516f09836d718af2b61b27335ac3d","head":{"label":"process-engine:feature/fix_pp-size_with_acitvated_pse","ref":"feature/fix_pp-size_with_acitvated_pse","sha":"723117abd61516f09836d718af2b61b27335ac3d","user":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106867605,"name":"bpmn-studio","full_name":"process-engine/bpmn-studio","owner":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/process-engine/bpmn-studio","description":"The Front-End for Designing Runnable BPMN-Diagrams","fork":false,"url":"https://api.github.com/repos/process-engine/bpmn-studio","forks_url":"https://api.github.com/repos/process-engine/bpmn-studio/forks","keys_url":"https://api.github.com/repos/process-engine/bpmn-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/bpmn-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/bpmn-studio/teams","hooks_url":"https://api.github.com/repos/process-engine/bpmn-studio/hooks","issue_events_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/bpmn-studio/events","assignees_url":"https://api.github.com/repos/process-engine/bpmn-studio/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/bpmn-studio/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/bpmn-studio/tags","blobs_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/bpmn-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/bpmn-studio/languages","stargazers_url":"https://api.github.com/repos/process-engine/bpmn-studio/stargazers","contributors_url":"https://api.github.com/repos/process-engine/bpmn-studio/contributors","subscribers_url":"https://api.github.com/repos/process-engine/bpmn-studio/subscribers","subscription_url":"https://api.github.com/repos/process-engine/bpmn-studio/subscription","commits_url":"https://api.github.com/repos/process-engine/bpmn-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/bpmn-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/bpmn-studio/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/bpmn-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/bpmn-studio/merges","archive_url":"https://api.github.com/repos/process-engine/bpmn-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/bpmn-studio/downloads","issues_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/bpmn-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/bpmn-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/bpmn-studio/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/bpmn-studio/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/bpmn-studio/deployments","created_at":"2017-10-13T19:54:48Z","updated_at":"2018-05-28T10:39:48Z","pushed_at":"2018-05-29T07:46:58Z","git_url":"git://github.com/process-engine/bpmn-studio.git","ssh_url":"git@github.com:process-engine/bpmn-studio.git","clone_url":"https://github.com/process-engine/bpmn-studio.git","svn_url":"https://github.com/process-engine/bpmn-studio","homepage":"","size":2964,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":128,"watchers":8,"default_branch":"develop"}},"base":{"label":"process-engine:develop","ref":"develop","sha":"245ebaa957cfd12d4574dc287ee8d9f5d6adbaa1","user":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106867605,"name":"bpmn-studio","full_name":"process-engine/bpmn-studio","owner":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/process-engine/bpmn-studio","description":"The Front-End for Designing Runnable BPMN-Diagrams","fork":false,"url":"https://api.github.com/repos/process-engine/bpmn-studio","forks_url":"https://api.github.com/repos/process-engine/bpmn-studio/forks","keys_url":"https://api.github.com/repos/process-engine/bpmn-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/bpmn-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/bpmn-studio/teams","hooks_url":"https://api.github.com/repos/process-engine/bpmn-studio/hooks","issue_events_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/bpmn-studio/events","assignees_url":"https://api.github.com/repos/process-engine/bpmn-studio/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/bpmn-studio/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/bpmn-studio/tags","blobs_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/bpmn-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/bpmn-studio/languages","stargazers_url":"https://api.github.com/repos/process-engine/bpmn-studio/stargazers","contributors_url":"https://api.github.com/repos/process-engine/bpmn-studio/contributors","subscribers_url":"https://api.github.com/repos/process-engine/bpmn-studio/subscribers","subscription_url":"https://api.github.com/repos/process-engine/bpmn-studio/subscription","commits_url":"https://api.github.com/repos/process-engine/bpmn-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/bpmn-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/bpmn-studio/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/bpmn-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/bpmn-studio/merges","archive_url":"https://api.github.com/repos/process-engine/bpmn-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/bpmn-studio/downloads","issues_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/bpmn-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/bpmn-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/bpmn-studio/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/bpmn-studio/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/bpmn-studio/deployments","created_at":"2017-10-13T19:54:48Z","updated_at":"2018-05-28T10:39:48Z","pushed_at":"2018-05-29T07:46:58Z","git_url":"git://github.com/process-engine/bpmn-studio.git","ssh_url":"git@github.com:process-engine/bpmn-studio.git","clone_url":"https://github.com/process-engine/bpmn-studio.git","svn_url":"https://github.com/process-engine/bpmn-studio","homepage":"","size":2964,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":128,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/434"},"html":{"href":"https://github.com/process-engine/bpmn-studio/pull/434"},"issue":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/issues/434"},"comments":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/statuses/723117abd61516f09836d718af2b61b27335ac3d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LeoTT"}}