{"action":"created","issue":{"url":"https://api.github.com/repos/antirez/redis/issues/5686","repository_url":"https://api.github.com/repos/antirez/redis","labels_url":"https://api.github.com/repos/antirez/redis/issues/5686/labels{/name}","comments_url":"https://api.github.com/repos/antirez/redis/issues/5686/comments","events_url":"https://api.github.com/repos/antirez/redis/issues/5686/events","html_url":"https://github.com/antirez/redis/issues/5686","id":389811143,"node_id":"MDU6SXNzdWUzODk4MTExNDM=","number":5686,"title":"Eviction during AOF loading","user":{"login":"guybe7","id":19590683,"node_id":"MDQ6VXNlcjE5NTkwNjgz","avatar_url":"https://avatars2.githubusercontent.com/u/19590683?v=4","gravatar_id":"","url":"https://api.github.com/users/guybe7","html_url":"https://github.com/guybe7","followers_url":"https://api.github.com/users/guybe7/followers","following_url":"https://api.github.com/users/guybe7/following{/other_user}","gists_url":"https://api.github.com/users/guybe7/gists{/gist_id}","starred_url":"https://api.github.com/users/guybe7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybe7/subscriptions","organizations_url":"https://api.github.com/users/guybe7/orgs","repos_url":"https://api.github.com/users/guybe7/repos","events_url":"https://api.github.com/users/guybe7/events{/privacy}","received_events_url":"https://api.github.com/users/guybe7/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-12-11T15:13:52Z","updated_at":"2018-12-12T10:38:11Z","closed_at":"2018-12-12T10:38:11Z","author_association":"CONTRIBUTOR","body":"Not sure if it's an actual issue (didn't write a test to reproduce it)\r\nWhile loading AOF, `processEventsWhileBlocked` is called every 1000 commands, which in turn calls `processCommand` which calls `freeMemoryIfNeeded` (regardless of server.loading)\r\nThis could result in evicting keys that the AOF playback may rely on their value (INCR, GETSET, etc.) which could result in inconsistent dataset.\r\n\r\nEven a PING or a command that rejected with -LOADING, can cause the following AOF playback:\r\n```\r\nSET X 1000\r\nINCR X 1\r\n```\r\nto end up with X being 1"},"comment":{"url":"https://api.github.com/repos/antirez/redis/issues/comments/446541441","html_url":"https://github.com/antirez/redis/issues/5686#issuecomment-446541441","issue_url":"https://api.github.com/repos/antirez/redis/issues/5686","id":446541441,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjU0MTQ0MQ==","user":{"login":"antirez","id":65632,"node_id":"MDQ6VXNlcjY1NjMy","avatar_url":"https://avatars0.githubusercontent.com/u/65632?v=4","gravatar_id":"","url":"https://api.github.com/users/antirez","html_url":"https://github.com/antirez","followers_url":"https://api.github.com/users/antirez/followers","following_url":"https://api.github.com/users/antirez/following{/other_user}","gists_url":"https://api.github.com/users/antirez/gists{/gist_id}","starred_url":"https://api.github.com/users/antirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antirez/subscriptions","organizations_url":"https://api.github.com/users/antirez/orgs","repos_url":"https://api.github.com/users/antirez/repos","events_url":"https://api.github.com/users/antirez/events{/privacy}","received_events_url":"https://api.github.com/users/antirez/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T10:38:11Z","updated_at":"2018-12-12T10:38:11Z","author_association":"OWNER","body":"Refactored in 129f2d27"}}
{"actor":{"display_login":"antirez"}}