{"action":"created","comment":{"url":"https://api.github.com/repos/cosmos/voyager/pulls/comments/187630431","pull_request_review_id":119453700,"id":187630431,"diff_hunk":"@@ -232,6 +239,8 @@ async function startLCD(home, nodeIP) {\n       reject()\n       afterBooted(() => {\n         if (mainWindow) {\n+          // TODO unify/refactor logError and webContents.send\n+          logError(`The ${SERVER_BINARY} rest-server (LCD) exited unplanned`)","path":"app/src/main/index.js","position":32,"original_position":32,"commit_id":"34637b19d01b59c94cac9596564d2e73c77bd626","original_commit_id":"34637b19d01b59c94cac9596564d2e73c77bd626","user":{"login":"jolesbi","id":6021933,"avatar_url":"https://avatars1.githubusercontent.com/u/6021933?v=4","gravatar_id":"","url":"https://api.github.com/users/jolesbi","html_url":"https://github.com/jolesbi","followers_url":"https://api.github.com/users/jolesbi/followers","following_url":"https://api.github.com/users/jolesbi/following{/other_user}","gists_url":"https://api.github.com/users/jolesbi/gists{/gist_id}","starred_url":"https://api.github.com/users/jolesbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolesbi/subscriptions","organizations_url":"https://api.github.com/users/jolesbi/orgs","repos_url":"https://api.github.com/users/jolesbi/repos","events_url":"https://api.github.com/users/jolesbi/events{/privacy}","received_events_url":"https://api.github.com/users/jolesbi/received_events","type":"User","site_admin":false},"body":"i know this is not a change from this PR - but why do we call this `SERVER_BINARY`?","created_at":"2018-05-11T14:25:54Z","updated_at":"2018-05-11T14:25:54Z","html_url":"https://github.com/cosmos/voyager/pull/684#discussion_r187630431","pull_request_url":"https://api.github.com/repos/cosmos/voyager/pulls/684","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/comments/187630431"},"html":{"href":"https://github.com/cosmos/voyager/pull/684#discussion_r187630431"},"pull_request":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/684"}}},"pull_request":{"url":"https://api.github.com/repos/cosmos/voyager/pulls/684","id":187373274,"html_url":"https://github.com/cosmos/voyager/pull/684","diff_url":"https://github.com/cosmos/voyager/pull/684.diff","patch_url":"https://github.com/cosmos/voyager/pull/684.patch","issue_url":"https://api.github.com/repos/cosmos/voyager/issues/684","number":684,"state":"open","locked":false,"title":"enable and fix e2e tests for new SDK","user":{"login":"nylira","id":172531,"avatar_url":"https://avatars0.githubusercontent.com/u/172531?v=4","gravatar_id":"","url":"https://api.github.com/users/nylira","html_url":"https://github.com/nylira","followers_url":"https://api.github.com/users/nylira/followers","following_url":"https://api.github.com/users/nylira/following{/other_user}","gists_url":"https://api.github.com/users/nylira/gists{/gist_id}","starred_url":"https://api.github.com/users/nylira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylira/subscriptions","organizations_url":"https://api.github.com/users/nylira/orgs","repos_url":"https://api.github.com/users/nylira/repos","events_url":"https://api.github.com/users/nylira/events{/privacy}","received_events_url":"https://api.github.com/users/nylira/received_events","type":"User","site_admin":false},"body":"Let's work together to fix the E2E tests for the new SDK!\r\n\r\n> Jordan:\r\n> TLDR: i’m pretty sure the e2e tests are failing because “sign in” is hidden from the welcome modal - because our `createAccount` function in our e2e tests doesn’t actually create accounts - it recovers them - and recover may have changed a bit in `gaiacli` - or at least is not working as expected ATM\r\n\r\n- [x] passing e2e tests","created_at":"2018-05-11T05:52:38Z","updated_at":"2018-05-11T14:25:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f3765b6f12912f4becc9b4a97aa9c80867c7f0b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"NodeGuy","id":2148537,"avatar_url":"https://avatars0.githubusercontent.com/u/2148537?v=4","gravatar_id":"","url":"https://api.github.com/users/NodeGuy","html_url":"https://github.com/NodeGuy","followers_url":"https://api.github.com/users/NodeGuy/followers","following_url":"https://api.github.com/users/NodeGuy/following{/other_user}","gists_url":"https://api.github.com/users/NodeGuy/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeGuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeGuy/subscriptions","organizations_url":"https://api.github.com/users/NodeGuy/orgs","repos_url":"https://api.github.com/users/NodeGuy/repos","events_url":"https://api.github.com/users/NodeGuy/events{/privacy}","received_events_url":"https://api.github.com/users/NodeGuy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cosmos/voyager/pulls/684/commits","review_comments_url":"https://api.github.com/repos/cosmos/voyager/pulls/684/comments","review_comment_url":"https://api.github.com/repos/cosmos/voyager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cosmos/voyager/issues/684/comments","statuses_url":"https://api.github.com/repos/cosmos/voyager/statuses/34637b19d01b59c94cac9596564d2e73c77bd626","head":{"label":"cosmos:peng/enable-and-fix-e2e","ref":"peng/enable-and-fix-e2e","sha":"34637b19d01b59c94cac9596564d2e73c77bd626","user":{"login":"cosmos","id":228843,"avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"repo":{"id":99653950,"name":"voyager","full_name":"cosmos/voyager","owner":{"login":"cosmos","id":228843,"avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cosmos/voyager","description":"Cosmos Voyager — the user interface for the Cosmos Network. ✨","fork":false,"url":"https://api.github.com/repos/cosmos/voyager","forks_url":"https://api.github.com/repos/cosmos/voyager/forks","keys_url":"https://api.github.com/repos/cosmos/voyager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmos/voyager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmos/voyager/teams","hooks_url":"https://api.github.com/repos/cosmos/voyager/hooks","issue_events_url":"https://api.github.com/repos/cosmos/voyager/issues/events{/number}","events_url":"https://api.github.com/repos/cosmos/voyager/events","assignees_url":"https://api.github.com/repos/cosmos/voyager/assignees{/user}","branches_url":"https://api.github.com/repos/cosmos/voyager/branches{/branch}","tags_url":"https://api.github.com/repos/cosmos/voyager/tags","blobs_url":"https://api.github.com/repos/cosmos/voyager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmos/voyager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmos/voyager/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmos/voyager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmos/voyager/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmos/voyager/languages","stargazers_url":"https://api.github.com/repos/cosmos/voyager/stargazers","contributors_url":"https://api.github.com/repos/cosmos/voyager/contributors","subscribers_url":"https://api.github.com/repos/cosmos/voyager/subscribers","subscription_url":"https://api.github.com/repos/cosmos/voyager/subscription","commits_url":"https://api.github.com/repos/cosmos/voyager/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmos/voyager/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmos/voyager/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmos/voyager/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmos/voyager/contents/{+path}","compare_url":"https://api.github.com/repos/cosmos/voyager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmos/voyager/merges","archive_url":"https://api.github.com/repos/cosmos/voyager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmos/voyager/downloads","issues_url":"https://api.github.com/repos/cosmos/voyager/issues{/number}","pulls_url":"https://api.github.com/repos/cosmos/voyager/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmos/voyager/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmos/voyager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmos/voyager/labels{/name}","releases_url":"https://api.github.com/repos/cosmos/voyager/releases{/id}","deployments_url":"https://api.github.com/repos/cosmos/voyager/deployments","created_at":"2017-08-08T05:34:48Z","updated_at":"2018-05-11T12:56:43Z","pushed_at":"2018-05-11T14:18:39Z","git_url":"git://github.com/cosmos/voyager.git","ssh_url":"git@github.com:cosmos/voyager.git","clone_url":"https://github.com/cosmos/voyager.git","svn_url":"https://github.com/cosmos/voyager","homepage":"https://cosmos.network/voyager","size":17621,"stargazers_count":76,"watchers_count":76,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":91,"watchers":76,"default_branch":"develop"}},"base":{"label":"cosmos:develop","ref":"develop","sha":"f940086d376413065bf4f956f621121a29189c71","user":{"login":"cosmos","id":228843,"avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"repo":{"id":99653950,"name":"voyager","full_name":"cosmos/voyager","owner":{"login":"cosmos","id":228843,"avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cosmos/voyager","description":"Cosmos Voyager — the user interface for the Cosmos Network. ✨","fork":false,"url":"https://api.github.com/repos/cosmos/voyager","forks_url":"https://api.github.com/repos/cosmos/voyager/forks","keys_url":"https://api.github.com/repos/cosmos/voyager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmos/voyager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmos/voyager/teams","hooks_url":"https://api.github.com/repos/cosmos/voyager/hooks","issue_events_url":"https://api.github.com/repos/cosmos/voyager/issues/events{/number}","events_url":"https://api.github.com/repos/cosmos/voyager/events","assignees_url":"https://api.github.com/repos/cosmos/voyager/assignees{/user}","branches_url":"https://api.github.com/repos/cosmos/voyager/branches{/branch}","tags_url":"https://api.github.com/repos/cosmos/voyager/tags","blobs_url":"https://api.github.com/repos/cosmos/voyager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmos/voyager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmos/voyager/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmos/voyager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmos/voyager/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmos/voyager/languages","stargazers_url":"https://api.github.com/repos/cosmos/voyager/stargazers","contributors_url":"https://api.github.com/repos/cosmos/voyager/contributors","subscribers_url":"https://api.github.com/repos/cosmos/voyager/subscribers","subscription_url":"https://api.github.com/repos/cosmos/voyager/subscription","commits_url":"https://api.github.com/repos/cosmos/voyager/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmos/voyager/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmos/voyager/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmos/voyager/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmos/voyager/contents/{+path}","compare_url":"https://api.github.com/repos/cosmos/voyager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmos/voyager/merges","archive_url":"https://api.github.com/repos/cosmos/voyager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmos/voyager/downloads","issues_url":"https://api.github.com/repos/cosmos/voyager/issues{/number}","pulls_url":"https://api.github.com/repos/cosmos/voyager/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmos/voyager/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmos/voyager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmos/voyager/labels{/name}","releases_url":"https://api.github.com/repos/cosmos/voyager/releases{/id}","deployments_url":"https://api.github.com/repos/cosmos/voyager/deployments","created_at":"2017-08-08T05:34:48Z","updated_at":"2018-05-11T12:56:43Z","pushed_at":"2018-05-11T14:18:39Z","git_url":"git://github.com/cosmos/voyager.git","ssh_url":"git@github.com:cosmos/voyager.git","clone_url":"https://github.com/cosmos/voyager.git","svn_url":"https://github.com/cosmos/voyager","homepage":"https://cosmos.network/voyager","size":17621,"stargazers_count":76,"watchers_count":76,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":91,"watchers":76,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/684"},"html":{"href":"https://github.com/cosmos/voyager/pull/684"},"issue":{"href":"https://api.github.com/repos/cosmos/voyager/issues/684"},"comments":{"href":"https://api.github.com/repos/cosmos/voyager/issues/684/comments"},"review_comments":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/684/comments"},"review_comment":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/684/commits"},"statuses":{"href":"https://api.github.com/repos/cosmos/voyager/statuses/34637b19d01b59c94cac9596564d2e73c77bd626"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jolesbi"}}