{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/pai/pulls/comments/224304668","pull_request_review_id":163637640,"id":224304668,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDMwNDY2OA==","diff_hunk":"@@ -36,6 +36,13 @@ data:\n     scrape_configs:\n     - job_name: 'node_exporter'\n       scrape_interval: {{ prom_info['scrape_interval']|default(30) }}s\n+      {% if clusterinfo['prometheusinfo']['use_tls'] -%}\n+      tls_config:\n+        ca_file: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt","path":"src/prometheus/deploy/prometheus-configmap.yaml.template","position":6,"original_position":6,"commit_id":"2cfefb83113596021dd044ab462b3257c388b1ec","original_commit_id":"2cfefb83113596021dd044ab462b3257c388b1ec","user":{"login":"xudifsd","id":665253,"node_id":"MDQ6VXNlcjY2NTI1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/665253?v=4","gravatar_id":"","url":"https://api.github.com/users/xudifsd","html_url":"https://github.com/xudifsd","followers_url":"https://api.github.com/users/xudifsd/followers","following_url":"https://api.github.com/users/xudifsd/following{/other_user}","gists_url":"https://api.github.com/users/xudifsd/gists{/gist_id}","starred_url":"https://api.github.com/users/xudifsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xudifsd/subscriptions","organizations_url":"https://api.github.com/users/xudifsd/orgs","repos_url":"https://api.github.com/users/xudifsd/repos","events_url":"https://api.github.com/users/xudifsd/events{/privacy}","received_events_url":"https://api.github.com/users/xudifsd/received_events","type":"User","site_admin":false},"body":"Ok, then, I think it's inappropriate to config under `prometheus`.","created_at":"2018-10-11T03:28:18Z","updated_at":"2018-10-11T03:28:18Z","html_url":"https://github.com/Microsoft/pai/pull/1458#discussion_r224304668","pull_request_url":"https://api.github.com/repos/Microsoft/pai/pulls/1458","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/comments/224304668"},"html":{"href":"https://github.com/Microsoft/pai/pull/1458#discussion_r224304668"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1458"}},"in_reply_to_id":224301379},"pull_request":{"url":"https://api.github.com/repos/Microsoft/pai/pulls/1458","id":220996049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTk2MDQ5","html_url":"https://github.com/Microsoft/pai/pull/1458","diff_url":"https://github.com/Microsoft/pai/pull/1458.diff","patch_url":"https://github.com/Microsoft/pai/pull/1458.patch","issue_url":"https://api.github.com/repos/Microsoft/pai/issues/1458","number":1458,"state":"open","locked":false,"title":"[AKS] prometheus config leverage service account access api-server","user":{"login":"YanjieGao","id":5576848,"node_id":"MDQ6VXNlcjU1NzY4NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/5576848?v=4","gravatar_id":"","url":"https://api.github.com/users/YanjieGao","html_url":"https://github.com/YanjieGao","followers_url":"https://api.github.com/users/YanjieGao/followers","following_url":"https://api.github.com/users/YanjieGao/following{/other_user}","gists_url":"https://api.github.com/users/YanjieGao/gists{/gist_id}","starred_url":"https://api.github.com/users/YanjieGao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanjieGao/subscriptions","organizations_url":"https://api.github.com/users/YanjieGao/orgs","repos_url":"https://api.github.com/users/YanjieGao/repos","events_url":"https://api.github.com/users/YanjieGao/events{/privacy}","received_events_url":"https://api.github.com/users/YanjieGao/received_events","type":"User","site_admin":false},"body":"prometheus deployment leverage service account. this is maybe useful for deploy pai on existing k8s which api-server access need auth.\r\n\r\nwhen use this on aks:\r\n\r\n- user config use_tls\r\n- config api-server url. \r\nnote: this has the dependency with pr (https://github.com/Microsoft/pai/pull/1428)  for api-server url configuration.\r\n","created_at":"2018-10-08T03:25:21Z","updated_at":"2018-10-11T03:28:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de8669ad48e65b934567d2ea965aaea07837fdc6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/pai/pulls/1458/commits","review_comments_url":"https://api.github.com/repos/Microsoft/pai/pulls/1458/comments","review_comment_url":"https://api.github.com/repos/Microsoft/pai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/pai/issues/1458/comments","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/2cfefb83113596021dd044ab462b3257c388b1ec","head":{"label":"Microsoft:yanjga/aks-prometheus","ref":"yanjga/aks-prometheus","sha":"2cfefb83113596021dd044ab462b3257c388b1ec","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104741169,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ3NDExNjk=","name":"pai","full_name":"Microsoft/pai","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/pai","description":"Resource scheduling and cluster management for AI","fork":false,"url":"https://api.github.com/repos/Microsoft/pai","forks_url":"https://api.github.com/repos/Microsoft/pai/forks","keys_url":"https://api.github.com/repos/Microsoft/pai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pai/teams","hooks_url":"https://api.github.com/repos/Microsoft/pai/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pai/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pai/events","assignees_url":"https://api.github.com/repos/Microsoft/pai/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pai/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pai/tags","blobs_url":"https://api.github.com/repos/Microsoft/pai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pai/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pai/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pai/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pai/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pai/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pai/subscription","commits_url":"https://api.github.com/repos/Microsoft/pai/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pai/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pai/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pai/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pai/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pai/merges","archive_url":"https://api.github.com/repos/Microsoft/pai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pai/downloads","issues_url":"https://api.github.com/repos/Microsoft/pai/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pai/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pai/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pai/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pai/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pai/deployments","created_at":"2017-09-25T11:24:51Z","updated_at":"2018-10-11T02:53:15Z","pushed_at":"2018-10-11T03:14:52Z","git_url":"git://github.com/Microsoft/pai.git","ssh_url":"git@github.com:Microsoft/pai.git","clone_url":"https://github.com/Microsoft/pai.git","svn_url":"https://github.com/Microsoft/pai","homepage":"","size":10948,"stargazers_count":499,"watchers_count":499,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":128,"open_issues":104,"watchers":499,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"b8ec5687887b25bdcfb4a66f56676cdfe2458ad2","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104741169,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ3NDExNjk=","name":"pai","full_name":"Microsoft/pai","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/pai","description":"Resource scheduling and cluster management for AI","fork":false,"url":"https://api.github.com/repos/Microsoft/pai","forks_url":"https://api.github.com/repos/Microsoft/pai/forks","keys_url":"https://api.github.com/repos/Microsoft/pai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pai/teams","hooks_url":"https://api.github.com/repos/Microsoft/pai/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pai/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pai/events","assignees_url":"https://api.github.com/repos/Microsoft/pai/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pai/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pai/tags","blobs_url":"https://api.github.com/repos/Microsoft/pai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pai/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pai/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pai/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pai/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pai/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pai/subscription","commits_url":"https://api.github.com/repos/Microsoft/pai/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pai/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pai/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pai/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pai/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pai/merges","archive_url":"https://api.github.com/repos/Microsoft/pai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pai/downloads","issues_url":"https://api.github.com/repos/Microsoft/pai/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pai/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pai/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pai/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pai/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pai/deployments","created_at":"2017-09-25T11:24:51Z","updated_at":"2018-10-11T02:53:15Z","pushed_at":"2018-10-11T03:14:52Z","git_url":"git://github.com/Microsoft/pai.git","ssh_url":"git@github.com:Microsoft/pai.git","clone_url":"https://github.com/Microsoft/pai.git","svn_url":"https://github.com/Microsoft/pai","homepage":"","size":10948,"stargazers_count":499,"watchers_count":499,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":128,"open_issues":104,"watchers":499,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1458"},"html":{"href":"https://github.com/Microsoft/pai/pull/1458"},"issue":{"href":"https://api.github.com/repos/Microsoft/pai/issues/1458"},"comments":{"href":"https://api.github.com/repos/Microsoft/pai/issues/1458/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1458/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1458/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/pai/statuses/2cfefb83113596021dd044ab462b3257c388b1ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xudifsd"}}