{"action":"created","issue":{"url":"https://api.github.com/repos/dev-sec/puppet-os-hardening/issues/120","repository_url":"https://api.github.com/repos/dev-sec/puppet-os-hardening","labels_url":"https://api.github.com/repos/dev-sec/puppet-os-hardening/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/dev-sec/puppet-os-hardening/issues/120/comments","events_url":"https://api.github.com/repos/dev-sec/puppet-os-hardening/issues/120/events","html_url":"https://github.com/dev-sec/puppet-os-hardening/pull/120","id":296030794,"number":120,"title":"converted module to pdk #107","user":{"login":"enemarke","id":4777514,"avatar_url":"https://avatars2.githubusercontent.com/u/4777514?v=4","gravatar_id":"","url":"https://api.github.com/users/enemarke","html_url":"https://github.com/enemarke","followers_url":"https://api.github.com/users/enemarke/followers","following_url":"https://api.github.com/users/enemarke/following{/other_user}","gists_url":"https://api.github.com/users/enemarke/gists{/gist_id}","starred_url":"https://api.github.com/users/enemarke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enemarke/subscriptions","organizations_url":"https://api.github.com/users/enemarke/orgs","repos_url":"https://api.github.com/users/enemarke/repos","events_url":"https://api.github.com/users/enemarke/events{/privacy}","received_events_url":"https://api.github.com/users/enemarke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-09T22:23:08Z","updated_at":"2018-02-12T08:32:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dev-sec/puppet-os-hardening/pulls/120","html_url":"https://github.com/dev-sec/puppet-os-hardening/pull/120","diff_url":"https://github.com/dev-sec/puppet-os-hardening/pull/120.diff","patch_url":"https://github.com/dev-sec/puppet-os-hardening/pull/120.patch"},"body":"Hi\r\n\r\nI have converted the module to be pdk compliant and made a few minor refactors.\r\n\r\nSome notes on what I have brooken and what is missing:\r\n\r\n- The kitchen setup was removed in the pdk convertion scripts and Im not familiar with kitchen and have not added kitchen config.\r\n- Readme has not been updated, since I would like some feedback on my work before updating it.\r\n\r\nCheers\r\n"},"comment":{"url":"https://api.github.com/repos/dev-sec/puppet-os-hardening/issues/comments/364855980","html_url":"https://github.com/dev-sec/puppet-os-hardening/pull/120#issuecomment-364855980","issue_url":"https://api.github.com/repos/dev-sec/puppet-os-hardening/issues/120","id":364855980,"user":{"login":"mcgege","id":6241510,"avatar_url":"https://avatars1.githubusercontent.com/u/6241510?v=4","gravatar_id":"","url":"https://api.github.com/users/mcgege","html_url":"https://github.com/mcgege","followers_url":"https://api.github.com/users/mcgege/followers","following_url":"https://api.github.com/users/mcgege/following{/other_user}","gists_url":"https://api.github.com/users/mcgege/gists{/gist_id}","starred_url":"https://api.github.com/users/mcgege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcgege/subscriptions","organizations_url":"https://api.github.com/users/mcgege/orgs","repos_url":"https://api.github.com/users/mcgege/repos","events_url":"https://api.github.com/users/mcgege/events{/privacy}","received_events_url":"https://api.github.com/users/mcgege/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T08:32:14Z","updated_at":"2018-02-12T08:32:14Z","author_association":"MEMBER","body":"Hi @enemarke , thanks a lot for working on this topic ... as I'm not the kitchen guru, maybe @artem-sidorenko can help us here?\r\n\r\nI also would suggest to separate the functional optimization (`/lib/*`, `/manifests/*`) from the pdk / testing changes. Can you put the first block in a separate pr? I could test & merge it prior to this ...\r\n"}}
{"actor":{"display_login":"mcgege"}}