{"action":"created","issue":{"url":"https://api.github.com/repos/eggheads/eggdrop/issues/741","repository_url":"https://api.github.com/repos/eggheads/eggdrop","labels_url":"https://api.github.com/repos/eggheads/eggdrop/issues/741/labels{/name}","comments_url":"https://api.github.com/repos/eggheads/eggdrop/issues/741/comments","events_url":"https://api.github.com/repos/eggheads/eggdrop/issues/741/events","html_url":"https://github.com/eggheads/eggdrop/pull/741","id":374770263,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2Mzc4MjE3","number":741,"title":"Fix 354 whox with workaround until 005 support","user":{"login":"michaelortmann","id":41313082,"node_id":"MDQ6VXNlcjQxMzEzMDgy","avatar_url":"https://avatars1.githubusercontent.com/u/41313082?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelortmann","html_url":"https://github.com/michaelortmann","followers_url":"https://api.github.com/users/michaelortmann/followers","following_url":"https://api.github.com/users/michaelortmann/following{/other_user}","gists_url":"https://api.github.com/users/michaelortmann/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelortmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelortmann/subscriptions","organizations_url":"https://api.github.com/users/michaelortmann/orgs","repos_url":"https://api.github.com/users/michaelortmann/repos","events_url":"https://api.github.com/users/michaelortmann/events{/privacy}","received_events_url":"https://api.github.com/users/michaelortmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-28T16:12:55Z","updated_at":"2018-10-28T23:39:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eggheads/eggdrop/pulls/741","html_url":"https://github.com/eggheads/eggdrop/pull/741","diff_url":"https://github.com/eggheads/eggdrop/pull/741.diff","patch_url":"https://github.com/eggheads/eggdrop/pull/741.patch"},"body":"Found by: key2peace\r\nPatch by: michaelortmann\r\nFixes: #739\r\n\r\nOne-line summary:\r\nFix 354 whox with workaround until 005 support\r\n\r\nAdditional description (if needed):\r\n\r\n\r\nTest cases demonstrating functionality (if applicable):\r\n```\r\n.console +drv\r\n[...]\r\n.set use-354\r\n[20:28:14] tcl: builtin dcc call: *dcc:set -HQ 1 use-354\r\n[20:28:14] #-HQ# set use-354\r\nCurrently: 1\r\n.set net-type\r\n[20:28:20] tcl: builtin dcc call: *dcc:set -HQ 1 net-type\r\n[20:28:20] #-HQ# set net-type\r\nCurrently: 2\r\n.server\r\n[20:28:28] tcl: builtin dcc call: *dcc:servers -HQ 1 \r\n[20:28:28] #-HQ# servers\r\nServer list:\r\n  [Ashburn.Va.Us.UnderNet.org]:6667 (Chicago.IL.US.Undernet.Org) <- I am here\r\nEnd of server list.\r\n```\r\nBefore:\r\n```\r\n.channel\r\n[15:09:27] tcl: builtin dcc call: *dcc:channel -HQ 1 \r\n[15:09:27] #-HQ# (#chan739) channel\r\nChannel #chan739, 1 member, mode +tn:\r\n(n = owner, m = master, o = op, d = deop, b = bot)\r\n NICKNAME  HANDLE     JOIN  IDLE  USER@HOST\r\n@bot739    *          ---        <- it's me!\r\nEnd of channel info.\r\n.tcl putserv \"WHO #chan739 %xcnihurf\"\r\n[15:09:39] tcl: builtin dcc call: *dcc:tcl -HQ 1 putserv \"WHO #chan739 %xcnihurf\"\r\n[15:09:39] tcl: evaluate (.tcl): putserv \"WHO #chan739 %xcnihurf\"\r\n[15:09:39] [!s] WHO #chan739 %xcnihurf\r\nTcl: \r\n[15:09:40] [s->] WHO #chan739 %xcnihurf\r\n[15:09:40] [@] Chicago.IL.US.Undernet.Org 354 bot739 #chan739 ~bot739 93.194.1.1 foo.dip0.t-ipconnect.de bot739 H@ :/msg bot739 hello\r\n[15:09:40] [@] Chicago.IL.US.Undernet.Org 315 bot739 #chan739 :End of /WHO list.\r\n.channel\r\n[15:09:44] tcl: builtin dcc call: *dcc:channel -HQ 1 \r\n[15:09:44] #-HQ# (#chan739) channel\r\nChannel #chan739, 2 members, mode +tn:\r\n(n = owner, m = master, o = op, d = deop, b = bot)\r\n NICKNAME                      HANDLE     JOIN  IDLE  USER@HOST\r\n@bot739                        *          ---        <- it's me!\r\n foo.dip0.t-ipconnect.de *          ---         ~bot739@93.194.1.1\r\nEnd of channel info.\r\n```\r\nAfter (this test with a second user in the channel):\r\n```\r\n.channel\r\n[17:05:56] tcl: builtin dcc call: *dcc:channel -HQ 1 \r\n[17:05:56] #-HQ# (#chan739) channel\r\nChannel #chan739, 2 members, mode +tn:\r\n(n = owner, m = master, o = op, d = deop, b = bot)\r\n NICKNAME  HANDLE     JOIN  IDLE  USER@HOST\r\n bot739    *          ---        <- it's me!\r\n user739   *          ---         ~michael@foo.dip0.t-ipconnect.de\r\nEnd of channel info.\r\n.tcl putserv \"WHO #chan739 %xcnihurf\"\r\n[17:06:00] tcl: builtin dcc call: *dcc:tcl -HQ 1 putserv \"WHO #chan739 %xcnihurf\"\r\n[17:06:00] tcl: evaluate (.tcl): putserv \"WHO #chan739 %xcnihurf\"\r\n[17:06:00] [!s] WHO #chan739 %xcnihurf\r\nTcl: \r\n[17:06:00] [s->] WHO #chan739 %xcnihurf\r\n[17:06:00] [@] tulip.eu.ix.undernet.org 354 bot739 #chan739 ~bot739 93.194.1.1 foo.dip0.t-ipconnect.de bot739 H :/msg bot739 hello\r\n[17:06:00] [@] tulip.eu.ix.undernet.org 354 bot739 #chan739 ~michael 93.194.1.1 foo.dip0.t-ipconnect.de user739 H :*Unknown*\r\n[17:06:00] [@] tulip.eu.ix.undernet.org 315 bot739 #chan739 :End of /WHO list.\r\n.channel\r\n[17:06:02] tcl: builtin dcc call: *dcc:channel -HQ 1 \r\n[17:06:02] #-HQ# (#chan739) channel\r\nChannel #chan739, 2 members, mode +tn:\r\n(n = owner, m = master, o = op, d = deop, b = bot)\r\n NICKNAME  HANDLE     JOIN  IDLE  USER@HOST\r\n bot739    *          ---        <- it's me!\r\n user739   *          ---         ~michael@foo.dip0.t-ipconnect.de\r\nEnd of channel info.\r\n```"},"comment":{"url":"https://api.github.com/repos/eggheads/eggdrop/issues/comments/433753379","html_url":"https://github.com/eggheads/eggdrop/pull/741#issuecomment-433753379","issue_url":"https://api.github.com/repos/eggheads/eggdrop/issues/741","id":433753379,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzc1MzM3OQ==","user":{"login":"michaelortmann","id":41313082,"node_id":"MDQ6VXNlcjQxMzEzMDgy","avatar_url":"https://avatars1.githubusercontent.com/u/41313082?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelortmann","html_url":"https://github.com/michaelortmann","followers_url":"https://api.github.com/users/michaelortmann/followers","following_url":"https://api.github.com/users/michaelortmann/following{/other_user}","gists_url":"https://api.github.com/users/michaelortmann/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelortmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelortmann/subscriptions","organizations_url":"https://api.github.com/users/michaelortmann/orgs","repos_url":"https://api.github.com/users/michaelortmann/repos","events_url":"https://api.github.com/users/michaelortmann/events{/privacy}","received_events_url":"https://api.github.com/users/michaelortmann/received_events","type":"User","site_admin":false},"created_at":"2018-10-28T23:39:49Z","updated_at":"2018-10-28T23:39:49Z","author_association":"CONTRIBUTOR","body":"maybe the whole idea of using that 354 reply for updating eggdrops channel stats is wrong? again, i don't see any irc client out there is capable of parsing variable results here. the best they currently do is they may count and handle a very specific case. and they dont look that broken. though there are issues opened for them every now and then."}}
{"actor":{"display_login":"michaelortmann"}}