{"action":"created","issue":{"url":"https://api.github.com/repos/aerokube/ggr/issues/185","repository_url":"https://api.github.com/repos/aerokube/ggr","labels_url":"https://api.github.com/repos/aerokube/ggr/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/aerokube/ggr/issues/185/comments","events_url":"https://api.github.com/repos/aerokube/ggr/issues/185/events","html_url":"https://github.com/aerokube/ggr/pull/185","id":309298180,"number":185,"title":"Added support of a custom request id for logging","user":{"login":"gsx95","id":15109418,"avatar_url":"https://avatars3.githubusercontent.com/u/15109418?v=4","gravatar_id":"","url":"https://api.github.com/users/gsx95","html_url":"https://github.com/gsx95","followers_url":"https://api.github.com/users/gsx95/followers","following_url":"https://api.github.com/users/gsx95/following{/other_user}","gists_url":"https://api.github.com/users/gsx95/gists{/gist_id}","starred_url":"https://api.github.com/users/gsx95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsx95/subscriptions","organizations_url":"https://api.github.com/users/gsx95/orgs","repos_url":"https://api.github.com/users/gsx95/repos","events_url":"https://api.github.com/users/gsx95/events{/privacy}","received_events_url":"https://api.github.com/users/gsx95/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-03-28T09:57:55Z","updated_at":"2018-03-29T10:50:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aerokube/ggr/pulls/185","html_url":"https://github.com/aerokube/ggr/pull/185","diff_url":"https://github.com/aerokube/ggr/pull/185.diff","patch_url":"https://github.com/aerokube/ggr/pull/185.patch"},"body":"Adds ability to associate a specific ggr log message with the original WebDriver request.\r\n\r\nUse: User puts a custom request id into the Desired Capabilities of his WebDriver, ggr logs the id and lets the user associate the log message with his original request."},"comment":{"url":"https://api.github.com/repos/aerokube/ggr/issues/comments/377197978","html_url":"https://github.com/aerokube/ggr/pull/185#issuecomment-377197978","issue_url":"https://api.github.com/repos/aerokube/ggr/issues/185","id":377197978,"user":{"login":"mdrobek","id":10487645,"avatar_url":"https://avatars0.githubusercontent.com/u/10487645?v=4","gravatar_id":"","url":"https://api.github.com/users/mdrobek","html_url":"https://github.com/mdrobek","followers_url":"https://api.github.com/users/mdrobek/followers","following_url":"https://api.github.com/users/mdrobek/following{/other_user}","gists_url":"https://api.github.com/users/mdrobek/gists{/gist_id}","starred_url":"https://api.github.com/users/mdrobek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdrobek/subscriptions","organizations_url":"https://api.github.com/users/mdrobek/orgs","repos_url":"https://api.github.com/users/mdrobek/repos","events_url":"https://api.github.com/users/mdrobek/events{/privacy}","received_events_url":"https://api.github.com/users/mdrobek/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T10:50:20Z","updated_at":"2018-03-29T10:50:20Z","author_association":"NONE","body":"@vania-pooh This SessionID is fine to track logs only from GridRouter or Selenoid. However, you cannot match GridRouter logs (that have a self-generated incrementing SessionCounterID) with external client side logs.\r\n\r\nSuppose you want to match all GridRouter logs with the outside client logs?\r\nHow would you do that, if on the client-side, which generates the request to GridRouter, you are not able to see the GridRouter SessionID in case of a failed session.\r\nIts not about debugging GridRouter, its about matching GridRouter log messages with outside client requests.\r\n\r\nWe see 2 options to tackle this issue:\r\n1) From a GridRouter protocol side, we use the capabilities options and sent a client-side generated requestID, which will then be logged in a GridRouter log event.\r\n2) GridRouter/Selenoid generates a unique sessionID (which does not increment, since this would be non-unique with multiple paralllel running GridRouter instances) AND forwards this unique session ID to the client-side as a response in ANY case (also FAILED session attempts).\r\n\r\nCan u please elaborate on your thoughts of this problem?\r\nThank you very much for your support/help."}}
{"actor":{"display_login":"mdrobek"}}