{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/232348735","pull_request_review_id":173534431,"id":232348735,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjM0ODczNQ==","diff_hunk":"@@ -116,8 +116,35 @@ def test_update(self):\n         df = DataFrame([{\"a\": 1}, {\"a\": 3, \"b\": 2}])\n         df['c'] = np.nan\n \n-        # this will fail as long as series is a sub-class of ndarray\n-        # df['c'].update(Series(['foo'],index=[0])) #####","path":"pandas/tests/series/test_combine_concat.py","position":14,"original_position":14,"commit_id":"925237a87a25b5d4af94b4429608d37465d6d51f","original_commit_id":"925237a87a25b5d4af94b4429608d37465d6d51f","user":{"login":"h-vetinari","id":33685575,"node_id":"MDQ6VXNlcjMzNjg1NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"body":"Series ceased being a subclass of ndarray in 0.13, so this test has been uncommented for quite some time. Now it's finally time for it to shine. ;-)","created_at":"2018-11-09T18:28:38Z","updated_at":"2018-11-09T18:28:49Z","html_url":"https://github.com/pandas-dev/pandas/pull/23604#discussion_r232348735","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23604","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/232348735"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23604#discussion_r232348735"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23604"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23604","id":229779772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5Nzc5Nzcy","html_url":"https://github.com/pandas-dev/pandas/pull/23604","diff_url":"https://github.com/pandas-dev/pandas/pull/23604.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/23604.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23604","number":23604,"state":"open","locked":false,"title":"TST: add tests for keeping dtype in Series.update","user":{"login":"h-vetinari","id":33685575,"node_id":"MDQ6VXNlcjMzNjg1NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"body":"- [x] precursor to #23192\r\n- [x] tests added / passed\r\n- [x] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n","created_at":"2018-11-09T18:27:32Z","updated_at":"2018-11-09T18:28:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bea132f8f22b1a145e790942c35aa99891bd8ce4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23604/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23604/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23604/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/925237a87a25b5d4af94b4429608d37465d6d51f","head":{"label":"h-vetinari:tst_series_update_dtype","ref":"tst_series_update_dtype","sha":"925237a87a25b5d4af94b4429608d37465d6d51f","user":{"login":"h-vetinari","id":33685575,"node_id":"MDQ6VXNlcjMzNjg1NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"repo":{"id":125207159,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyMDcxNTk=","name":"pandas","full_name":"h-vetinari/pandas","private":false,"owner":{"login":"h-vetinari","id":33685575,"node_id":"MDQ6VXNlcjMzNjg1NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"html_url":"https://github.com/h-vetinari/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/h-vetinari/pandas","forks_url":"https://api.github.com/repos/h-vetinari/pandas/forks","keys_url":"https://api.github.com/repos/h-vetinari/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h-vetinari/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h-vetinari/pandas/teams","hooks_url":"https://api.github.com/repos/h-vetinari/pandas/hooks","issue_events_url":"https://api.github.com/repos/h-vetinari/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/h-vetinari/pandas/events","assignees_url":"https://api.github.com/repos/h-vetinari/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/h-vetinari/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/h-vetinari/pandas/tags","blobs_url":"https://api.github.com/repos/h-vetinari/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h-vetinari/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h-vetinari/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/h-vetinari/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h-vetinari/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/h-vetinari/pandas/languages","stargazers_url":"https://api.github.com/repos/h-vetinari/pandas/stargazers","contributors_url":"https://api.github.com/repos/h-vetinari/pandas/contributors","subscribers_url":"https://api.github.com/repos/h-vetinari/pandas/subscribers","subscription_url":"https://api.github.com/repos/h-vetinari/pandas/subscription","commits_url":"https://api.github.com/repos/h-vetinari/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/h-vetinari/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/h-vetinari/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/h-vetinari/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/h-vetinari/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/h-vetinari/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h-vetinari/pandas/merges","archive_url":"https://api.github.com/repos/h-vetinari/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h-vetinari/pandas/downloads","issues_url":"https://api.github.com/repos/h-vetinari/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/h-vetinari/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/h-vetinari/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/h-vetinari/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h-vetinari/pandas/labels{/name}","releases_url":"https://api.github.com/repos/h-vetinari/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/h-vetinari/pandas/deployments","created_at":"2018-03-14T12:12:19Z","updated_at":"2018-11-07T21:46:35Z","pushed_at":"2018-11-09T18:26:48Z","git_url":"git://github.com/h-vetinari/pandas.git","ssh_url":"git@github.com:h-vetinari/pandas.git","clone_url":"https://github.com/h-vetinari/pandas.git","svn_url":"https://github.com/h-vetinari/pandas","homepage":"http://pandas.pydata.org","size":134346,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"efd1844daaadee29a57943597431611d554b6c4a","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-11-09T18:23:30Z","pushed_at":"2018-11-09T18:27:33Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":134404,"stargazers_count":16812,"watchers_count":16812,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6777,"mirror_url":null,"archived":false,"open_issues_count":2874,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6777,"open_issues":2874,"watchers":16812,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23604"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23604"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23604"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23604/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23604/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23604/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/925237a87a25b5d4af94b4429608d37465d6d51f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"h-vetinari"}}