{"action":"created","issue":{"url":"https://api.github.com/repos/pypa/pipenv/issues/2568","repository_url":"https://api.github.com/repos/pypa/pipenv","labels_url":"https://api.github.com/repos/pypa/pipenv/issues/2568/labels{/name}","comments_url":"https://api.github.com/repos/pypa/pipenv/issues/2568/comments","events_url":"https://api.github.com/repos/pypa/pipenv/issues/2568/events","html_url":"https://github.com/pypa/pipenv/pull/2568","id":340344633,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzc5MzA2","number":2568,"title":"Simplify testing for new contributors","user":{"login":"JacobHayes","id":2555532,"node_id":"MDQ6VXNlcjI1NTU1MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/2555532?v=4","gravatar_id":"","url":"https://api.github.com/users/JacobHayes","html_url":"https://github.com/JacobHayes","followers_url":"https://api.github.com/users/JacobHayes/followers","following_url":"https://api.github.com/users/JacobHayes/following{/other_user}","gists_url":"https://api.github.com/users/JacobHayes/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobHayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobHayes/subscriptions","organizations_url":"https://api.github.com/users/JacobHayes/orgs","repos_url":"https://api.github.com/users/JacobHayes/repos","events_url":"https://api.github.com/users/JacobHayes/events{/privacy}","received_events_url":"https://api.github.com/users/JacobHayes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-07-11T17:53:01Z","updated_at":"2018-07-12T18:48:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pypa/pipenv/pulls/2568","html_url":"https://github.com/pypa/pipenv/pull/2568","diff_url":"https://github.com/pypa/pipenv/pull/2568.diff","patch_url":"https://github.com/pypa/pipenv/pull/2568.patch"},"body":"Addresses some difficulties encountered when trying to get up to speed contributing to the project.\r\n\r\n- Fixes pytest.ini to ignore things like `build` dirs when looking for tests\r\n- Fixes resolving vendored test packages when running tests outside the repo root\r\n- Add some docs on development setup and testing\r\n\r\nThere are a few more structural decisions that this doesn't address:\r\n- repo `pipenv` shadowing global package when bootstrapping (pypa/pipenv#2557)\r\n- The docker-compose image doesn't have python 3.7, so `make test` doesn't work\r\n- The test Dockerfile is outside this repo, so ^ can't be fixed as easily"},"comment":{"url":"https://api.github.com/repos/pypa/pipenv/issues/comments/404612751","html_url":"https://github.com/pypa/pipenv/pull/2568#issuecomment-404612751","issue_url":"https://api.github.com/repos/pypa/pipenv/issues/2568","id":404612751,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDYxMjc1MQ==","user":{"login":"uranusjr","id":605277,"node_id":"MDQ6VXNlcjYwNTI3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/605277?v=4","gravatar_id":"","url":"https://api.github.com/users/uranusjr","html_url":"https://github.com/uranusjr","followers_url":"https://api.github.com/users/uranusjr/followers","following_url":"https://api.github.com/users/uranusjr/following{/other_user}","gists_url":"https://api.github.com/users/uranusjr/gists{/gist_id}","starred_url":"https://api.github.com/users/uranusjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uranusjr/subscriptions","organizations_url":"https://api.github.com/users/uranusjr/orgs","repos_url":"https://api.github.com/users/uranusjr/repos","events_url":"https://api.github.com/users/uranusjr/events{/privacy}","received_events_url":"https://api.github.com/users/uranusjr/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T18:48:30Z","updated_at":"2018-07-12T18:48:30Z","author_association":"COLLABORATOR","body":"I run the tests on my local Windows machine. One failure:\r\n\r\n```\r\n_____________________ test_install_venv_project_directory _____________________\r\n[gw5] win32 -- Python 3.7.0 c:\\users\\uranusjr\\documents\\programming\\pipenv\\.venv\\scripts\\python.exe\r\n\r\nPipenvInstance = <class 'tests.integration.conftest._PipenvInstance'>\r\npypi = <pytest_pypi.serve.Server object at 0x0000027CF2455F28>\r\n\r\n    @pytest.mark.install\r\n    @pytest.mark.virtualenv\r\n    def test_install_venv_project_directory(PipenvInstance, pypi):\r\n        \"\"\"Test the project functionality during virtualenv creation.\r\n        \"\"\"\r\n        with PipenvInstance(pypi=pypi, chdir=True) as p:\r\n            with temp_environ(), TemporaryDirectory(\r\n                prefix=\"pipenv-\", suffix=\"temp_workon_home\"\r\n            ) as workon_home:\r\n                os.environ[\"WORKON_HOME\"] = workon_home.name\r\n                if \"PIPENV_VENV_IN_PROJECT\" in os.environ:\r\n                    del os.environ[\"PIPENV_VENV_IN_PROJECT\"]\r\n                c = p.pipenv(\"install six\")\r\n                assert c.return_code == 0\r\n                project = Project()\r\n>               assert Path(project.virtualenv_location).joinpath(\".project\").exists()\r\nE               AssertionError: assert False\r\nE                +  where False = <bound method Path.exists of WindowsPath('C:/Users/uranusjr/Documents/programming/pipenv/.venv/.project')>()\r\nE                +    where <bound method Path.exists of WindowsPath('C:/Users/uranusjr/Documents/programming/pipenv/.venv/.project')> = WindowsPath('C:/Users/uranusjr/Documents/programming/pipenv/.venv/.project').exists\r\nE                +      where WindowsPath('C:/Users/uranusjr/Documents/programming/pipenv/.venv/.project') = <bound method PurePath.joinpath of WindowsPath('C:/Users/uranusjr/Documents/programming/pipenv/.venv')>('.project')\r\nE                +        where <bound method PurePath.joinpath of WindowsPath('C:/Users/uranusjr/Documents/programming/pipenv/.venv')> = WindowsPath('C:/Users/uranusjr/Documents/programming/pipenv/.venv').joinpath\r\nE                +          where WindowsPath('C:/Users/uranusjr/Documents/programming/pipenv/.venv') = Path('C:\\\\Users\\\\uranusjr\\\\Documents\\\\programming\\\\pipenv\\\\.venv')\r\nE                +            where 'C:\\\\Users\\\\uranusjr\\\\Documents\\\\programming\\\\pipenv\\\\.venv' = <pipenv.project.Project object at 0x0000027CF2483BE0>.virtualenv_location\r\n\r\ntests\\integration\\test_install_basic.py:365: AssertionError\r\n---------------------------- Captured stdout call -----------------------------\r\n$ pipenv install six\r\nInstalling six…\r\nLooking in indexes: http://127.0.0.1:3348/simple\r\nCollecting six\r\n  Downloading http://127.0.0.1:3348/six/six-1.11.0-py2.py3-none-any.whl\r\nInstalling collected packages: six\r\nSuccessfully installed six-1.11.0\r\n\r\nAdding six to Pipfile's [packages]…\r\nInstalling dependencies from Pipfile.lock (2a6c8a)…\r\nTo activate this project's virtualenv, run pipenv shell.\r\nAlternatively, run a command inside the virtualenv with pipenv run.\r\n\r\nCreating a virtualenv for this project…\r\nPipfile: R:\\9893bf199154429c87a8c5cb903351c0\\Pipfile\r\nUsing c:\\users\\uranusjr\\documents\\programming\\pipenv\\.venv\\scripts\\python.exe (3.7.0) to create virtualenv…\r\nAlready using interpreter c:\\users\\uranusjr\\documents\\programming\\pipenv\\.venv\\scripts\\python.exe\r\n\r\nUsing base prefix 'C:\\\\Users\\\\uranusjr\\\\AppData\\\\Local\\\\Programs\\\\Python\\\\Python37'\r\n\r\nc:\\users\\uranusjr\\documents\\programming\\pipenv\\.venv\\lib\\site-packages\\virtualenv.py:1041: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses\r\n\r\n  import imp\r\n\r\nNew python executable in R:\\1bf6f8b890de4da391d12c1747a1b67e\\9893bf199154429c87a8c5cb903351c0-fG1u2CNc\\Scripts\\python.exe\r\n\r\nInstalling setuptools, pip, wheel...done.\r\n\r\n\r\nVirtualenv location: R:\\1bf6f8b890de4da391d12c1747a1b67e\\9893bf199154429c87a8c5cb903351c0-fG1u2CNc\r\nCreating a Pipfile for this project…\r\nPipfile.lock not found, creating…\r\nLocking [dev-packages] dependencies…\r\nLocking [packages] dependencies…\r\nUpdated Pipfile.lock (2a6c8a)!\r\n\r\n---------------------------- Captured stderr call -----------------------------\r\n127.0.0.1 - - [13/Jul/2018 02:32:20] \"GET /simple/six/ HTTP/1.1\" 200 310\r\n127.0.0.1 - - [13/Jul/2018 02:32:20] \"GET /six/six-1.11.0-py2.py3-none-any.whl HTTP/1.1\" 200 10702\r\n127.0.0.1 - - [13/Jul/2018 02:32:29] \"GET /simple/six/ HTTP/1.1\" 200 310\r\n127.0.0.1 - - [13/Jul/2018 02:32:29] \"GET /simple/six/ HTTP/1.1\" 200 310\r\n127.0.0.1 - - [13/Jul/2018 02:32:29] \"GET /six/six-1.11.0-py2.py3-none-any.whl HTTP/1.1\" 200 10702\r\n127.0.0.1 - - [13/Jul/2018 02:32:29] \"GET /simple/six/ HTTP/1.1\" 200 310\r\n127.0.0.1 - - [13/Jul/2018 02:32:29] \"GET /six/six-1.11.0-py2.py3-none-any.whl HTTP/1.1\" 200 10702\r\n127.0.0.1 - - [13/Jul/2018 02:32:29] \"GET /six/six-1.11.0.tar.gz HTTP/1.1\" 200 29860\r\n```"}}
{"actor":{"display_login":"uranusjr"}}