{"action":"created","issue":{"url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/111","repository_url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll","labels_url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/111/comments","events_url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/111/events","html_url":"https://github.com/dollarshaveclub/ember-router-scroll/issues/111","id":311473278,"number":111,"title":"[Update] add more tests","user":{"login":"yowainwright","id":1074042,"avatar_url":"https://avatars2.githubusercontent.com/u/1074042?v=4","gravatar_id":"","url":"https://api.github.com/users/yowainwright","html_url":"https://github.com/yowainwright","followers_url":"https://api.github.com/users/yowainwright/followers","following_url":"https://api.github.com/users/yowainwright/following{/other_user}","gists_url":"https://api.github.com/users/yowainwright/gists{/gist_id}","starred_url":"https://api.github.com/users/yowainwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yowainwright/subscriptions","organizations_url":"https://api.github.com/users/yowainwright/orgs","repos_url":"https://api.github.com/users/yowainwright/repos","events_url":"https://api.github.com/users/yowainwright/events{/privacy}","received_events_url":"https://api.github.com/users/yowainwright/received_events","type":"User","site_admin":false},"labels":[{"id":890703020,"url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/labels/ci/cd","name":"ci/cd","color":"3598d6","default":false},{"id":411613749,"url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/labels/enhancement","name":"enhancement","color":"0e8a16","default":true}],"state":"open","locked":false,"assignee":{"login":"yowainwright","id":1074042,"avatar_url":"https://avatars2.githubusercontent.com/u/1074042?v=4","gravatar_id":"","url":"https://api.github.com/users/yowainwright","html_url":"https://github.com/yowainwright","followers_url":"https://api.github.com/users/yowainwright/followers","following_url":"https://api.github.com/users/yowainwright/following{/other_user}","gists_url":"https://api.github.com/users/yowainwright/gists{/gist_id}","starred_url":"https://api.github.com/users/yowainwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yowainwright/subscriptions","organizations_url":"https://api.github.com/users/yowainwright/orgs","repos_url":"https://api.github.com/users/yowainwright/repos","events_url":"https://api.github.com/users/yowainwright/events{/privacy}","received_events_url":"https://api.github.com/users/yowainwright/received_events","type":"User","site_admin":false},"assignees":[{"login":"yowainwright","id":1074042,"avatar_url":"https://avatars2.githubusercontent.com/u/1074042?v=4","gravatar_id":"","url":"https://api.github.com/users/yowainwright","html_url":"https://github.com/yowainwright","followers_url":"https://api.github.com/users/yowainwright/followers","following_url":"https://api.github.com/users/yowainwright/following{/other_user}","gists_url":"https://api.github.com/users/yowainwright/gists{/gist_id}","starred_url":"https://api.github.com/users/yowainwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yowainwright/subscriptions","organizations_url":"https://api.github.com/users/yowainwright/orgs","repos_url":"https://api.github.com/users/yowainwright/repos","events_url":"https://api.github.com/users/yowainwright/events{/privacy}","received_events_url":"https://api.github.com/users/yowainwright/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/milestones/1","html_url":"https://github.com/dollarshaveclub/ember-router-scroll/milestone/1","labels_url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/milestones/1/labels","id":3243680,"number":1,"title":"CI/CD configuration","description":"This milestone will allow the DollarShaveClub org to better support the community of this addon.\r\n \r\nIt will tentatively involve:\r\n\r\n- harmless changes: https://github.com/dollarshaveclub/harmless-changes\r\n  -  to make for faster builds if changes are harmless\r\n- es-check: https://github.com/dollarshaveclub/es-check  \r\n   - to ensure that dist files match the ES version expected\r\n- a switch to CircleCi: faster builds, DSC's ability to add post-merge jobs\r\n- more tests: in order to more easily/safely be able to merge/publish updates\r\n- post-merge jobs: auto npm publish, changelog updates","creator":{"login":"yowainwright","id":1074042,"avatar_url":"https://avatars2.githubusercontent.com/u/1074042?v=4","gravatar_id":"","url":"https://api.github.com/users/yowainwright","html_url":"https://github.com/yowainwright","followers_url":"https://api.github.com/users/yowainwright/followers","following_url":"https://api.github.com/users/yowainwright/following{/other_user}","gists_url":"https://api.github.com/users/yowainwright/gists{/gist_id}","starred_url":"https://api.github.com/users/yowainwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yowainwright/subscriptions","organizations_url":"https://api.github.com/users/yowainwright/orgs","repos_url":"https://api.github.com/users/yowainwright/repos","events_url":"https://api.github.com/users/yowainwright/events{/privacy}","received_events_url":"https://api.github.com/users/yowainwright/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":1,"state":"open","created_at":"2018-04-04T23:23:07Z","updated_at":"2018-04-05T18:38:53Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-04-05T05:00:46Z","updated_at":"2018-04-11T21:40:53Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Add more tests\r\n\r\n For this issue more testing will be implemented. \r\n\r\n### Reasons 🤔\r\n\r\n- easier code review\r\n- tests need to be added for future features like:\r\n  - post-merge publishing and changelog updates, \r\n  - [automerge](https://github.com/jonathanong/gh-automerge)\r\n\r\n----\r\n\r\n### Steps 📊\r\n\r\nThe checklist key items will be in separate PRs for readability. \r\nVersioning for these PRs will try to best support the community.\r\n\r\n-----\r\n\r\n#### Key Items ✅\r\n\r\n- [ ] Add unit tests specific to [location/router-scroll.js](https://github.com/dollarshaveclub/ember-router-scroll/blob/master/addon/locations/router-scroll.js)\r\n- [ ] Add unit tests  specific to [services/router-scroll.js](https://github.com/dollarshaveclub/ember-router-scroll/blob/master/addon/services/router-scroll.js)\r\n- [ ] Add [acceptance tests](https://github.com/dollarshaveclub/ember-router-scroll/blob/master/tests/acceptance/basic-functionality-test.js)\r\n- [ ] **Spike:** Other test opportunities?"},"comment":{"url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/comments/380604568","html_url":"https://github.com/dollarshaveclub/ember-router-scroll/issues/111#issuecomment-380604568","issue_url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/111","id":380604568,"user":{"login":"yowainwright","id":1074042,"avatar_url":"https://avatars2.githubusercontent.com/u/1074042?v=4","gravatar_id":"","url":"https://api.github.com/users/yowainwright","html_url":"https://github.com/yowainwright","followers_url":"https://api.github.com/users/yowainwright/followers","following_url":"https://api.github.com/users/yowainwright/following{/other_user}","gists_url":"https://api.github.com/users/yowainwright/gists{/gist_id}","starred_url":"https://api.github.com/users/yowainwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yowainwright/subscriptions","organizations_url":"https://api.github.com/users/yowainwright/orgs","repos_url":"https://api.github.com/users/yowainwright/repos","events_url":"https://api.github.com/users/yowainwright/events{/privacy}","received_events_url":"https://api.github.com/users/yowainwright/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T21:40:53Z","updated_at":"2018-04-11T21:40:53Z","author_association":"CONTRIBUTOR","body":"@rwwagner90 will manage open issues. I am closing this pr. This issue will not be done. "}}
{"actor":{"display_login":"yowainwright"}}