{"action":"created","issue":{"url":"https://api.github.com/repos/marrink-lab/vermouth-martinize/issues/156","repository_url":"https://api.github.com/repos/marrink-lab/vermouth-martinize","labels_url":"https://api.github.com/repos/marrink-lab/vermouth-martinize/issues/156/labels{/name}","comments_url":"https://api.github.com/repos/marrink-lab/vermouth-martinize/issues/156/comments","events_url":"https://api.github.com/repos/marrink-lab/vermouth-martinize/issues/156/events","html_url":"https://github.com/marrink-lab/vermouth-martinize/pull/156","id":375561406,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTc4MTkw","number":156,"title":"Make the logging tests Python 3.8 compatible","user":{"login":"pckroon","id":12967865,"node_id":"MDQ6VXNlcjEyOTY3ODY1","avatar_url":"https://avatars1.githubusercontent.com/u/12967865?v=4","gravatar_id":"","url":"https://api.github.com/users/pckroon","html_url":"https://github.com/pckroon","followers_url":"https://api.github.com/users/pckroon/followers","following_url":"https://api.github.com/users/pckroon/following{/other_user}","gists_url":"https://api.github.com/users/pckroon/gists{/gist_id}","starred_url":"https://api.github.com/users/pckroon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pckroon/subscriptions","organizations_url":"https://api.github.com/users/pckroon/orgs","repos_url":"https://api.github.com/users/pckroon/repos","events_url":"https://api.github.com/users/pckroon/events{/privacy}","received_events_url":"https://api.github.com/users/pckroon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-30T15:50:00Z","updated_at":"2018-11-01T11:50:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/marrink-lab/vermouth-martinize/pulls/156","html_url":"https://github.com/marrink-lab/vermouth-martinize/pull/156","diff_url":"https://github.com/marrink-lab/vermouth-martinize/pull/156.diff","patch_url":"https://github.com/marrink-lab/vermouth-martinize/pull/156.patch"},"body":"In Python 3.8 logging.Formatter suddenly starts to try and validate it's format string using regexes. Since our `FormatCounter` was in fact not a string this broke. This PR fixes that. \r\nNote that it *must* have a formatstring passed (instead of `''`), otherwise it'll get replaced by a default formatting string, which is just a plain string."},"comment":{"url":"https://api.github.com/repos/marrink-lab/vermouth-martinize/issues/comments/435017082","html_url":"https://github.com/marrink-lab/vermouth-martinize/pull/156#issuecomment-435017082","issue_url":"https://api.github.com/repos/marrink-lab/vermouth-martinize/issues/156","id":435017082,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTAxNzA4Mg==","user":{"login":"jbarnoud","id":1382074,"node_id":"MDQ6VXNlcjEzODIwNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1382074?v=4","gravatar_id":"","url":"https://api.github.com/users/jbarnoud","html_url":"https://github.com/jbarnoud","followers_url":"https://api.github.com/users/jbarnoud/followers","following_url":"https://api.github.com/users/jbarnoud/following{/other_user}","gists_url":"https://api.github.com/users/jbarnoud/gists{/gist_id}","starred_url":"https://api.github.com/users/jbarnoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbarnoud/subscriptions","organizations_url":"https://api.github.com/users/jbarnoud/orgs","repos_url":"https://api.github.com/users/jbarnoud/repos","events_url":"https://api.github.com/users/jbarnoud/events{/privacy}","received_events_url":"https://api.github.com/users/jbarnoud/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T11:50:13Z","updated_at":"2018-11-01T11:50:13Z","author_association":"COLLABORATOR","body":"Out of curiosity, did you comment on the python mailing list about this? Python 3.8 is not out yet, the change may still be reversible."}}
{"actor":{"display_login":"jbarnoud"}}