{"action":"created","issue":{"url":"https://api.github.com/repos/apache/geode/issues/2330","repository_url":"https://api.github.com/repos/apache/geode","labels_url":"https://api.github.com/repos/apache/geode/issues/2330/labels{/name}","comments_url":"https://api.github.com/repos/apache/geode/issues/2330/comments","events_url":"https://api.github.com/repos/apache/geode/issues/2330/events","html_url":"https://github.com/apache/geode/pull/2330","id":350902869,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjMyOTIw","number":2330,"title":"GEODE-5583: Use the ConcurrencyRule to run threads","user":{"login":"balesh2","id":7718000,"node_id":"MDQ6VXNlcjc3MTgwMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7718000?v=4","gravatar_id":"","url":"https://api.github.com/users/balesh2","html_url":"https://github.com/balesh2","followers_url":"https://api.github.com/users/balesh2/followers","following_url":"https://api.github.com/users/balesh2/following{/other_user}","gists_url":"https://api.github.com/users/balesh2/gists{/gist_id}","starred_url":"https://api.github.com/users/balesh2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balesh2/subscriptions","organizations_url":"https://api.github.com/users/balesh2/orgs","repos_url":"https://api.github.com/users/balesh2/repos","events_url":"https://api.github.com/users/balesh2/events{/privacy}","received_events_url":"https://api.github.com/users/balesh2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-15T17:50:49Z","updated_at":"2018-08-15T19:49:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/2330","html_url":"https://github.com/apache/geode/pull/2330","diff_url":"https://github.com/apache/geode/pull/2330.diff","patch_url":"https://github.com/apache/geode/pull/2330.patch"},"body":"Use the concurrency rule to run threads instead of providing a custom\r\nimplementation that may or may not be correct.\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [x] Is your initial contribution a single, squashed commit?\r\n\r\n- [x] Does `gradlew build` run cleanly?\r\n\r\n- [x] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/geode/issues/comments/413314267","html_url":"https://github.com/apache/geode/pull/2330#issuecomment-413314267","issue_url":"https://api.github.com/repos/apache/geode/issues/2330","id":413314267,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzMxNDI2Nw==","user":{"login":"pivotal-amurmann","id":19393329,"node_id":"MDQ6VXNlcjE5MzkzMzI5","avatar_url":"https://avatars2.githubusercontent.com/u/19393329?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-amurmann","html_url":"https://github.com/pivotal-amurmann","followers_url":"https://api.github.com/users/pivotal-amurmann/followers","following_url":"https://api.github.com/users/pivotal-amurmann/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-amurmann/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-amurmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-amurmann/subscriptions","organizations_url":"https://api.github.com/users/pivotal-amurmann/orgs","repos_url":"https://api.github.com/users/pivotal-amurmann/repos","events_url":"https://api.github.com/users/pivotal-amurmann/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-amurmann/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T19:49:52Z","updated_at":"2018-08-15T19:49:52Z","author_association":"CONTRIBUTOR","body":"I love how much more readable this is! \r\n\r\nPart of me wishes that the concurrency rule was exposing a fluent interface, but I guess that would make the `add()` method clunkier. "}}
{"actor":{"display_login":"pivotal-amurmann"}}