{"action":"created","issue":{"url":"https://api.github.com/repos/Lexikos/AutoHotkey_L-Docs/issues/249","repository_url":"https://api.github.com/repos/Lexikos/AutoHotkey_L-Docs","labels_url":"https://api.github.com/repos/Lexikos/AutoHotkey_L-Docs/issues/249/labels{/name}","comments_url":"https://api.github.com/repos/Lexikos/AutoHotkey_L-Docs/issues/249/comments","events_url":"https://api.github.com/repos/Lexikos/AutoHotkey_L-Docs/issues/249/events","html_url":"https://github.com/Lexikos/AutoHotkey_L-Docs/issues/249","id":309364848,"number":249,"title":"ISO-8859-1 vs UTF-8","user":{"login":"joedf","id":3848219,"avatar_url":"https://avatars2.githubusercontent.com/u/3848219?v=4","gravatar_id":"","url":"https://api.github.com/users/joedf","html_url":"https://github.com/joedf","followers_url":"https://api.github.com/users/joedf/followers","following_url":"https://api.github.com/users/joedf/following{/other_user}","gists_url":"https://api.github.com/users/joedf/gists{/gist_id}","starred_url":"https://api.github.com/users/joedf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joedf/subscriptions","organizations_url":"https://api.github.com/users/joedf/orgs","repos_url":"https://api.github.com/users/joedf/repos","events_url":"https://api.github.com/users/joedf/events{/privacy}","received_events_url":"https://api.github.com/users/joedf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-28T13:22:52Z","updated_at":"2018-03-29T13:28:36Z","closed_at":"2018-03-29T13:28:36Z","author_association":"CONTRIBUTOR","body":"The docs is currently using \"ISO-8859-1\" instead of \"UTF-8\". Is there a particular reason for this?\r\nCurrently the docs' search box does not work because the key name `mört` within var `SearchIndex` (near \"mywindowtitle\") is being loaded as `mÃ¶rt` instead in [this file ](https://github.com/Lexikos/AutoHotkey_L-Docs/blob/v2/docs/static/source/data_search.js). This flags an invalid character error, and so on:\r\n```js\r\nSyntaxError: illegal character @ data_search.js:1:157034\r\nReferenceError: SearchIndex is not defined @ content.js:111:7\r\n```\r\nI have double checked that the files on the server are encoded as UTF-8 without BOM (content.js is ASCII since there are no unicode chars used)."},"comment":{"url":"https://api.github.com/repos/Lexikos/AutoHotkey_L-Docs/issues/comments/377234882","html_url":"https://github.com/Lexikos/AutoHotkey_L-Docs/issues/249#issuecomment-377234882","issue_url":"https://api.github.com/repos/Lexikos/AutoHotkey_L-Docs/issues/249","id":377234882,"user":{"login":"joedf","id":3848219,"avatar_url":"https://avatars2.githubusercontent.com/u/3848219?v=4","gravatar_id":"","url":"https://api.github.com/users/joedf","html_url":"https://github.com/joedf","followers_url":"https://api.github.com/users/joedf/followers","following_url":"https://api.github.com/users/joedf/following{/other_user}","gists_url":"https://api.github.com/users/joedf/gists{/gist_id}","starred_url":"https://api.github.com/users/joedf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joedf/subscriptions","organizations_url":"https://api.github.com/users/joedf/orgs","repos_url":"https://api.github.com/users/joedf/repos","events_url":"https://api.github.com/users/joedf/events{/privacy}","received_events_url":"https://api.github.com/users/joedf/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T13:28:36Z","updated_at":"2018-03-29T13:28:36Z","author_association":"CONTRIBUTOR","body":"I have added the BOM manually to `data_search.js`. Now the search works just fine after a hard-refresh.\r\n`sed -i '1s/^/\\xef\\xbb\\xbf/' data_search.js`\r\n\r\nInterestingly, I've read that one should not include the UTF-8 BOM in unicode files as per specs and recommendations. Another source says it is optional... No matter, the new change #250 should fix this either way. 👍 \r\n\r\nFor further reading:\r\nhttps://stackoverflow.com/a/15691902/883015\r\nhttps://stackoverflow.com/a/30349775/883015"}}
{"actor":{"display_login":"joedf"}}