{"action":"created","comment":{"url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/comments/174571798","pull_request_review_id":103952950,"id":174571798,"diff_hunk":"@@ -257,4 +255,10 @@ def remove_tokens_after_password_reset\n     end\n   end\n \n+  def clean_old_tokens","path":"app/models/devise_token_auth/concerns/user.rb","position":40,"original_position":26,"commit_id":"8a4688f302c1996c6300816dcc8ff473ed2bf760","original_commit_id":"7800929f0ae794979b077a49f4aa1222b25f727a","user":{"login":"MaicolBen","id":3474627,"avatar_url":"https://avatars2.githubusercontent.com/u/3474627?v=4","gravatar_id":"","url":"https://api.github.com/users/MaicolBen","html_url":"https://github.com/MaicolBen","followers_url":"https://api.github.com/users/MaicolBen/followers","following_url":"https://api.github.com/users/MaicolBen/following{/other_user}","gists_url":"https://api.github.com/users/MaicolBen/gists{/gist_id}","starred_url":"https://api.github.com/users/MaicolBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaicolBen/subscriptions","organizations_url":"https://api.github.com/users/MaicolBen/orgs","repos_url":"https://api.github.com/users/MaicolBen/repos","events_url":"https://api.github.com/users/MaicolBen/events{/privacy}","received_events_url":"https://api.github.com/users/MaicolBen/received_events","type":"User","site_admin":false},"body":"This change breaks randomically the test that you mentioned: `test/controllers/demo_user_controller_test.rb#L506`. I tried for a day fixing it but it's quite weird (and hard to debug with minitest). If we merge the PR without this change, can you create a new one and try to fix it with your comment?","created_at":"2018-03-14T18:47:48Z","updated_at":"2018-03-14T18:47:49Z","html_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/1109#discussion_r174571798","pull_request_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/1109","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/comments/174571798"},"html":{"href":"https://github.com/lynndylanhurley/devise_token_auth/pull/1109#discussion_r174571798"},"pull_request":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/1109"}},"in_reply_to_id":173952496},"pull_request":{"url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/1109","id":174459128,"html_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/1109","diff_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/1109.diff","patch_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/1109.patch","issue_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/1109","number":1109,"state":"open","locked":false,"title":"max_number_of_devices should be used in a new session as well","user":{"login":"MaicolBen","id":3474627,"avatar_url":"https://avatars2.githubusercontent.com/u/3474627?v=4","gravatar_id":"","url":"https://api.github.com/users/MaicolBen","html_url":"https://github.com/MaicolBen","followers_url":"https://api.github.com/users/MaicolBen/followers","following_url":"https://api.github.com/users/MaicolBen/following{/other_user}","gists_url":"https://api.github.com/users/MaicolBen/gists{/gist_id}","starred_url":"https://api.github.com/users/MaicolBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaicolBen/subscriptions","organizations_url":"https://api.github.com/users/MaicolBen/orgs","repos_url":"https://api.github.com/users/MaicolBen/repos","events_url":"https://api.github.com/users/MaicolBen/events{/privacy}","received_events_url":"https://api.github.com/users/MaicolBen/received_events","type":"User","site_admin":false},"body":"Resolves #1107\r\nResolves #637","created_at":"2018-03-12T18:39:50Z","updated_at":"2018-03-14T18:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c874aaaf2ed49c48026cbc87753132a317b6939","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lynndylanhurley","id":468037,"avatar_url":"https://avatars0.githubusercontent.com/u/468037?v=4","gravatar_id":"","url":"https://api.github.com/users/lynndylanhurley","html_url":"https://github.com/lynndylanhurley","followers_url":"https://api.github.com/users/lynndylanhurley/followers","following_url":"https://api.github.com/users/lynndylanhurley/following{/other_user}","gists_url":"https://api.github.com/users/lynndylanhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/lynndylanhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynndylanhurley/subscriptions","organizations_url":"https://api.github.com/users/lynndylanhurley/orgs","repos_url":"https://api.github.com/users/lynndylanhurley/repos","events_url":"https://api.github.com/users/lynndylanhurley/events{/privacy}","received_events_url":"https://api.github.com/users/lynndylanhurley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/1109/commits","review_comments_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/1109/comments","review_comment_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/1109/comments","statuses_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/statuses/8a4688f302c1996c6300816dcc8ff473ed2bf760","head":{"label":"MaicolBen:max_number_of_devices_in_new_session","ref":"max_number_of_devices_in_new_session","sha":"8a4688f302c1996c6300816dcc8ff473ed2bf760","user":{"login":"MaicolBen","id":3474627,"avatar_url":"https://avatars2.githubusercontent.com/u/3474627?v=4","gravatar_id":"","url":"https://api.github.com/users/MaicolBen","html_url":"https://github.com/MaicolBen","followers_url":"https://api.github.com/users/MaicolBen/followers","following_url":"https://api.github.com/users/MaicolBen/following{/other_user}","gists_url":"https://api.github.com/users/MaicolBen/gists{/gist_id}","starred_url":"https://api.github.com/users/MaicolBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaicolBen/subscriptions","organizations_url":"https://api.github.com/users/MaicolBen/orgs","repos_url":"https://api.github.com/users/MaicolBen/repos","events_url":"https://api.github.com/users/MaicolBen/events{/privacy}","received_events_url":"https://api.github.com/users/MaicolBen/received_events","type":"User","site_admin":false},"repo":{"id":72008384,"name":"devise_token_auth","full_name":"MaicolBen/devise_token_auth","owner":{"login":"MaicolBen","id":3474627,"avatar_url":"https://avatars2.githubusercontent.com/u/3474627?v=4","gravatar_id":"","url":"https://api.github.com/users/MaicolBen","html_url":"https://github.com/MaicolBen","followers_url":"https://api.github.com/users/MaicolBen/followers","following_url":"https://api.github.com/users/MaicolBen/following{/other_user}","gists_url":"https://api.github.com/users/MaicolBen/gists{/gist_id}","starred_url":"https://api.github.com/users/MaicolBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaicolBen/subscriptions","organizations_url":"https://api.github.com/users/MaicolBen/orgs","repos_url":"https://api.github.com/users/MaicolBen/repos","events_url":"https://api.github.com/users/MaicolBen/events{/privacy}","received_events_url":"https://api.github.com/users/MaicolBen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaicolBen/devise_token_auth","description":"Token based authentication for Rails JSON APIs. Designed to work with jToker and ng-token-auth.","fork":true,"url":"https://api.github.com/repos/MaicolBen/devise_token_auth","forks_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/forks","keys_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/teams","hooks_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/hooks","issue_events_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/issues/events{/number}","events_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/events","assignees_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/assignees{/user}","branches_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/branches{/branch}","tags_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/tags","blobs_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/statuses/{sha}","languages_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/languages","stargazers_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/stargazers","contributors_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/contributors","subscribers_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/subscribers","subscription_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/subscription","commits_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/contents/{+path}","compare_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/merges","archive_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/downloads","issues_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/issues{/number}","pulls_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/pulls{/number}","milestones_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/milestones{/number}","notifications_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/labels{/name}","releases_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/releases{/id}","deployments_url":"https://api.github.com/repos/MaicolBen/devise_token_auth/deployments","created_at":"2016-10-26T13:55:39Z","updated_at":"2016-10-26T13:55:40Z","pushed_at":"2018-03-12T22:01:14Z","git_url":"git://github.com/MaicolBen/devise_token_auth.git","ssh_url":"git@github.com:MaicolBen/devise_token_auth.git","clone_url":"https://github.com/MaicolBen/devise_token_auth.git","svn_url":"https://github.com/MaicolBen/devise_token_auth","homepage":"","size":8150,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lynndylanhurley:master","ref":"master","sha":"7a83ada953ca0adaa311118725edca501e49974d","user":{"login":"lynndylanhurley","id":468037,"avatar_url":"https://avatars0.githubusercontent.com/u/468037?v=4","gravatar_id":"","url":"https://api.github.com/users/lynndylanhurley","html_url":"https://github.com/lynndylanhurley","followers_url":"https://api.github.com/users/lynndylanhurley/followers","following_url":"https://api.github.com/users/lynndylanhurley/following{/other_user}","gists_url":"https://api.github.com/users/lynndylanhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/lynndylanhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynndylanhurley/subscriptions","organizations_url":"https://api.github.com/users/lynndylanhurley/orgs","repos_url":"https://api.github.com/users/lynndylanhurley/repos","events_url":"https://api.github.com/users/lynndylanhurley/events{/privacy}","received_events_url":"https://api.github.com/users/lynndylanhurley/received_events","type":"User","site_admin":false},"repo":{"id":21333814,"name":"devise_token_auth","full_name":"lynndylanhurley/devise_token_auth","owner":{"login":"lynndylanhurley","id":468037,"avatar_url":"https://avatars0.githubusercontent.com/u/468037?v=4","gravatar_id":"","url":"https://api.github.com/users/lynndylanhurley","html_url":"https://github.com/lynndylanhurley","followers_url":"https://api.github.com/users/lynndylanhurley/followers","following_url":"https://api.github.com/users/lynndylanhurley/following{/other_user}","gists_url":"https://api.github.com/users/lynndylanhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/lynndylanhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynndylanhurley/subscriptions","organizations_url":"https://api.github.com/users/lynndylanhurley/orgs","repos_url":"https://api.github.com/users/lynndylanhurley/repos","events_url":"https://api.github.com/users/lynndylanhurley/events{/privacy}","received_events_url":"https://api.github.com/users/lynndylanhurley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lynndylanhurley/devise_token_auth","description":"Token based authentication for Rails JSON APIs. Designed to work with jToker and ng-token-auth.","fork":false,"url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth","forks_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/forks","keys_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/teams","hooks_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/hooks","issue_events_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/events{/number}","events_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/events","assignees_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/assignees{/user}","branches_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/branches{/branch}","tags_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/tags","blobs_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/statuses/{sha}","languages_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/languages","stargazers_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/stargazers","contributors_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/contributors","subscribers_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/subscribers","subscription_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/subscription","commits_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/contents/{+path}","compare_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/merges","archive_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/downloads","issues_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues{/number}","pulls_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls{/number}","milestones_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/milestones{/number}","notifications_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/labels{/name}","releases_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/releases{/id}","deployments_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/deployments","created_at":"2014-06-29T22:43:58Z","updated_at":"2018-03-14T12:03:59Z","pushed_at":"2018-03-12T22:01:16Z","git_url":"git://github.com/lynndylanhurley/devise_token_auth.git","ssh_url":"git@github.com:lynndylanhurley/devise_token_auth.git","clone_url":"https://github.com/lynndylanhurley/devise_token_auth.git","svn_url":"https://github.com/lynndylanhurley/devise_token_auth","homepage":"","size":8163,"stargazers_count":2321,"watchers_count":2321,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":730,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"wtfpl","name":"Do What The F*ck You Want To Public License","spdx_id":"WTFPL","url":"https://api.github.com/licenses/wtfpl"},"forks":730,"open_issues":111,"watchers":2321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/1109"},"html":{"href":"https://github.com/lynndylanhurley/devise_token_auth/pull/1109"},"issue":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/1109"},"comments":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/1109/comments"},"review_comments":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/1109/comments"},"review_comment":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/1109/commits"},"statuses":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/statuses/8a4688f302c1996c6300816dcc8ff473ed2bf760"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"MaicolBen"}}