{"action":"closed","number":402,"pull_request":{"url":"https://api.github.com/repos/featurecat/lizzie/pulls/402","id":222742261,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzQyMjYx","html_url":"https://github.com/featurecat/lizzie/pull/402","diff_url":"https://github.com/featurecat/lizzie/pull/402.diff","patch_url":"https://github.com/featurecat/lizzie/pull/402.patch","issue_url":"https://api.github.com/repos/featurecat/lizzie/issues/402","number":402,"state":"closed","locked":false,"title":"Remove all nulls","user":{"login":"OlivierBlanvillain","id":1085297,"node_id":"MDQ6VXNlcjEwODUyOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1085297?v=4","gravatar_id":"","url":"https://api.github.com/users/OlivierBlanvillain","html_url":"https://github.com/OlivierBlanvillain","followers_url":"https://api.github.com/users/OlivierBlanvillain/followers","following_url":"https://api.github.com/users/OlivierBlanvillain/following{/other_user}","gists_url":"https://api.github.com/users/OlivierBlanvillain/gists{/gist_id}","starred_url":"https://api.github.com/users/OlivierBlanvillain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlivierBlanvillain/subscriptions","organizations_url":"https://api.github.com/users/OlivierBlanvillain/orgs","repos_url":"https://api.github.com/users/OlivierBlanvillain/repos","events_url":"https://api.github.com/users/OlivierBlanvillain/events{/privacy}","received_events_url":"https://api.github.com/users/OlivierBlanvillain/received_events","type":"User","site_admin":false},"body":"This PR refactors the entire code base to remove all usages for null as a values, and all null checks. When needed, data structures are updated to use `java.util.Optional`, but in a lot of cases null are removed without replacement.\r\n\r\nThe second commit re-implements `nextBranch` and `previousBranch` in functional style (best reviewed commit by commit).\r\n\r\nWe should probably branch off for v0.6 before merging this in case I missed something, but if possible I would like to avoid rebasing this for too long ^^'","created_at":"2018-10-14T20:52:12Z","updated_at":"2018-10-30T06:56:23Z","closed_at":"2018-10-30T06:56:23Z","merged_at":"2018-10-30T06:56:23Z","merge_commit_sha":"a51050210f248ffaba73ace3c6f32283e3b36641","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/featurecat/lizzie/pulls/402/commits","review_comments_url":"https://api.github.com/repos/featurecat/lizzie/pulls/402/comments","review_comment_url":"https://api.github.com/repos/featurecat/lizzie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/featurecat/lizzie/issues/402/comments","statuses_url":"https://api.github.com/repos/featurecat/lizzie/statuses/f928209a310532f6383dae4ad46f4cec28154a14","head":{"label":"OlivierBlanvillain:no-null","ref":"no-null","sha":"f928209a310532f6383dae4ad46f4cec28154a14","user":{"login":"OlivierBlanvillain","id":1085297,"node_id":"MDQ6VXNlcjEwODUyOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1085297?v=4","gravatar_id":"","url":"https://api.github.com/users/OlivierBlanvillain","html_url":"https://github.com/OlivierBlanvillain","followers_url":"https://api.github.com/users/OlivierBlanvillain/followers","following_url":"https://api.github.com/users/OlivierBlanvillain/following{/other_user}","gists_url":"https://api.github.com/users/OlivierBlanvillain/gists{/gist_id}","starred_url":"https://api.github.com/users/OlivierBlanvillain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlivierBlanvillain/subscriptions","organizations_url":"https://api.github.com/users/OlivierBlanvillain/orgs","repos_url":"https://api.github.com/users/OlivierBlanvillain/repos","events_url":"https://api.github.com/users/OlivierBlanvillain/events{/privacy}","received_events_url":"https://api.github.com/users/OlivierBlanvillain/received_events","type":"User","site_admin":false},"repo":{"id":140929328,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA5MjkzMjg=","name":"lizzie","full_name":"OlivierBlanvillain/lizzie","private":false,"owner":{"login":"OlivierBlanvillain","id":1085297,"node_id":"MDQ6VXNlcjEwODUyOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1085297?v=4","gravatar_id":"","url":"https://api.github.com/users/OlivierBlanvillain","html_url":"https://github.com/OlivierBlanvillain","followers_url":"https://api.github.com/users/OlivierBlanvillain/followers","following_url":"https://api.github.com/users/OlivierBlanvillain/following{/other_user}","gists_url":"https://api.github.com/users/OlivierBlanvillain/gists{/gist_id}","starred_url":"https://api.github.com/users/OlivierBlanvillain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlivierBlanvillain/subscriptions","organizations_url":"https://api.github.com/users/OlivierBlanvillain/orgs","repos_url":"https://api.github.com/users/OlivierBlanvillain/repos","events_url":"https://api.github.com/users/OlivierBlanvillain/events{/privacy}","received_events_url":"https://api.github.com/users/OlivierBlanvillain/received_events","type":"User","site_admin":false},"html_url":"https://github.com/OlivierBlanvillain/lizzie","description":"Lizzie - Leela Zero Interface","fork":true,"url":"https://api.github.com/repos/OlivierBlanvillain/lizzie","forks_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/forks","keys_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/teams","hooks_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/hooks","issue_events_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/issues/events{/number}","events_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/events","assignees_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/assignees{/user}","branches_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/branches{/branch}","tags_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/tags","blobs_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/git/refs{/sha}","trees_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/statuses/{sha}","languages_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/languages","stargazers_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/stargazers","contributors_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/contributors","subscribers_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/subscribers","subscription_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/subscription","commits_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/commits{/sha}","git_commits_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/git/commits{/sha}","comments_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/comments{/number}","issue_comment_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/issues/comments{/number}","contents_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/contents/{+path}","compare_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/merges","archive_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/downloads","issues_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/issues{/number}","pulls_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/pulls{/number}","milestones_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/milestones{/number}","notifications_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/labels{/name}","releases_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/releases{/id}","deployments_url":"https://api.github.com/repos/OlivierBlanvillain/lizzie/deployments","created_at":"2018-07-14T08:20:51Z","updated_at":"2018-07-14T08:20:53Z","pushed_at":"2018-10-30T06:53:43Z","git_url":"git://github.com/OlivierBlanvillain/lizzie.git","ssh_url":"git@github.com:OlivierBlanvillain/lizzie.git","clone_url":"https://github.com/OlivierBlanvillain/lizzie.git","svn_url":"https://github.com/OlivierBlanvillain/lizzie","homepage":null,"size":41875,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"featurecat:next","ref":"next","sha":"adf7cac6f8df0e920b3959ca06e80669cf0e8b1a","user":{"login":"featurecat","id":10515890,"node_id":"MDQ6VXNlcjEwNTE1ODkw","avatar_url":"https://avatars3.githubusercontent.com/u/10515890?v=4","gravatar_id":"","url":"https://api.github.com/users/featurecat","html_url":"https://github.com/featurecat","followers_url":"https://api.github.com/users/featurecat/followers","following_url":"https://api.github.com/users/featurecat/following{/other_user}","gists_url":"https://api.github.com/users/featurecat/gists{/gist_id}","starred_url":"https://api.github.com/users/featurecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/featurecat/subscriptions","organizations_url":"https://api.github.com/users/featurecat/orgs","repos_url":"https://api.github.com/users/featurecat/repos","events_url":"https://api.github.com/users/featurecat/events{/privacy}","received_events_url":"https://api.github.com/users/featurecat/received_events","type":"User","site_admin":false},"repo":{"id":122782059,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI3ODIwNTk=","name":"lizzie","full_name":"featurecat/lizzie","private":false,"owner":{"login":"featurecat","id":10515890,"node_id":"MDQ6VXNlcjEwNTE1ODkw","avatar_url":"https://avatars3.githubusercontent.com/u/10515890?v=4","gravatar_id":"","url":"https://api.github.com/users/featurecat","html_url":"https://github.com/featurecat","followers_url":"https://api.github.com/users/featurecat/followers","following_url":"https://api.github.com/users/featurecat/following{/other_user}","gists_url":"https://api.github.com/users/featurecat/gists{/gist_id}","starred_url":"https://api.github.com/users/featurecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/featurecat/subscriptions","organizations_url":"https://api.github.com/users/featurecat/orgs","repos_url":"https://api.github.com/users/featurecat/repos","events_url":"https://api.github.com/users/featurecat/events{/privacy}","received_events_url":"https://api.github.com/users/featurecat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/featurecat/lizzie","description":"Lizzie - Leela Zero Interface","fork":false,"url":"https://api.github.com/repos/featurecat/lizzie","forks_url":"https://api.github.com/repos/featurecat/lizzie/forks","keys_url":"https://api.github.com/repos/featurecat/lizzie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/featurecat/lizzie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/featurecat/lizzie/teams","hooks_url":"https://api.github.com/repos/featurecat/lizzie/hooks","issue_events_url":"https://api.github.com/repos/featurecat/lizzie/issues/events{/number}","events_url":"https://api.github.com/repos/featurecat/lizzie/events","assignees_url":"https://api.github.com/repos/featurecat/lizzie/assignees{/user}","branches_url":"https://api.github.com/repos/featurecat/lizzie/branches{/branch}","tags_url":"https://api.github.com/repos/featurecat/lizzie/tags","blobs_url":"https://api.github.com/repos/featurecat/lizzie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/featurecat/lizzie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/featurecat/lizzie/git/refs{/sha}","trees_url":"https://api.github.com/repos/featurecat/lizzie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/featurecat/lizzie/statuses/{sha}","languages_url":"https://api.github.com/repos/featurecat/lizzie/languages","stargazers_url":"https://api.github.com/repos/featurecat/lizzie/stargazers","contributors_url":"https://api.github.com/repos/featurecat/lizzie/contributors","subscribers_url":"https://api.github.com/repos/featurecat/lizzie/subscribers","subscription_url":"https://api.github.com/repos/featurecat/lizzie/subscription","commits_url":"https://api.github.com/repos/featurecat/lizzie/commits{/sha}","git_commits_url":"https://api.github.com/repos/featurecat/lizzie/git/commits{/sha}","comments_url":"https://api.github.com/repos/featurecat/lizzie/comments{/number}","issue_comment_url":"https://api.github.com/repos/featurecat/lizzie/issues/comments{/number}","contents_url":"https://api.github.com/repos/featurecat/lizzie/contents/{+path}","compare_url":"https://api.github.com/repos/featurecat/lizzie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/featurecat/lizzie/merges","archive_url":"https://api.github.com/repos/featurecat/lizzie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/featurecat/lizzie/downloads","issues_url":"https://api.github.com/repos/featurecat/lizzie/issues{/number}","pulls_url":"https://api.github.com/repos/featurecat/lizzie/pulls{/number}","milestones_url":"https://api.github.com/repos/featurecat/lizzie/milestones{/number}","notifications_url":"https://api.github.com/repos/featurecat/lizzie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/featurecat/lizzie/labels{/name}","releases_url":"https://api.github.com/repos/featurecat/lizzie/releases{/id}","deployments_url":"https://api.github.com/repos/featurecat/lizzie/deployments","created_at":"2018-02-24T21:39:00Z","updated_at":"2018-10-27T14:57:20Z","pushed_at":"2018-10-30T06:56:23Z","git_url":"git://github.com/featurecat/lizzie.git","ssh_url":"git@github.com:featurecat/lizzie.git","clone_url":"https://github.com/featurecat/lizzie.git","svn_url":"https://github.com/featurecat/lizzie","homepage":null,"size":42516,"stargazers_count":229,"watchers_count":229,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":63,"open_issues":44,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/featurecat/lizzie/pulls/402"},"html":{"href":"https://github.com/featurecat/lizzie/pull/402"},"issue":{"href":"https://api.github.com/repos/featurecat/lizzie/issues/402"},"comments":{"href":"https://api.github.com/repos/featurecat/lizzie/issues/402/comments"},"review_comments":{"href":"https://api.github.com/repos/featurecat/lizzie/pulls/402/comments"},"review_comment":{"href":"https://api.github.com/repos/featurecat/lizzie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/featurecat/lizzie/pulls/402/commits"},"statuses":{"href":"https://api.github.com/repos/featurecat/lizzie/statuses/f928209a310532f6383dae4ad46f4cec28154a14"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zsalch","id":42595514,"node_id":"MDQ6VXNlcjQyNTk1NTE0","avatar_url":"https://avatars3.githubusercontent.com/u/42595514?v=4","gravatar_id":"","url":"https://api.github.com/users/zsalch","html_url":"https://github.com/zsalch","followers_url":"https://api.github.com/users/zsalch/followers","following_url":"https://api.github.com/users/zsalch/following{/other_user}","gists_url":"https://api.github.com/users/zsalch/gists{/gist_id}","starred_url":"https://api.github.com/users/zsalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsalch/subscriptions","organizations_url":"https://api.github.com/users/zsalch/orgs","repos_url":"https://api.github.com/users/zsalch/repos","events_url":"https://api.github.com/users/zsalch/events{/privacy}","received_events_url":"https://api.github.com/users/zsalch/received_events","type":"User","site_admin":false},"comments":7,"review_comments":4,"maintainer_can_modify":false,"commits":4,"additions":845,"deletions":919,"changed_files":16}}
{"actor":{"display_login":"zsalch"}}