{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/224638110","pull_request_review_id":164057396,"id":224638110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDYzODExMA==","diff_hunk":"@@ -172,15 +171,15 @@ public ModelNode execute(ExpressionResolver expressionResolver, ModelNode operat\n         public ModelNode execute(ExpressionResolver expressionResolver, ModelNode operation, ModClusterServiceMBean service) {\n             boolean enabled = service.enable();\n \n-            return new ModelNode().get(ModelDescriptionConstants.RESULT).set(enabled);\n+            return new ModelNode(enabled);","path":"mod_cluster/extension/src/main/java/org/wildfly/extension/mod_cluster/ProxyOperation.java","position":40,"original_position":40,"commit_id":"9965e3a9c88ac5d0fcd90e0fefc400febda5fb6f","original_commit_id":"9965e3a9c88ac5d0fcd90e0fefc400febda5fb6f","user":{"login":"bstansberry","id":299242,"node_id":"MDQ6VXNlcjI5OTI0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/299242?v=4","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"Most of these enums don't override 'apply' and thus don't configure an OperationDescription that describe any reply at all. OTOH that maybe gives you freedom to change the undocumented reply type. OTOH, it's not a correct description.","created_at":"2018-10-11T23:56:43Z","updated_at":"2018-10-11T23:57:05Z","html_url":"https://github.com/wildfly/wildfly/pull/11726#discussion_r224638110","pull_request_url":"https://api.github.com/repos/wildfly/wildfly/pulls/11726","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/224638110"},"html":{"href":"https://github.com/wildfly/wildfly/pull/11726#discussion_r224638110"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11726"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/11726","id":221471383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNDcxMzgz","html_url":"https://github.com/wildfly/wildfly/pull/11726","diff_url":"https://github.com/wildfly/wildfly/pull/11726.diff","patch_url":"https://github.com/wildfly/wildfly/pull/11726.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly/issues/11726","number":11726,"state":"open","locked":false,"title":"WFLY-11117 Executing legacy operations in mod_cluster subsystem","user":{"login":"rhusar","id":765506,"node_id":"MDQ6VXNlcjc2NTUwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/765506?v=4","gravatar_id":"","url":"https://api.github.com/users/rhusar","html_url":"https://github.com/rhusar","followers_url":"https://api.github.com/users/rhusar/followers","following_url":"https://api.github.com/users/rhusar/following{/other_user}","gists_url":"https://api.github.com/users/rhusar/gists{/gist_id}","starred_url":"https://api.github.com/users/rhusar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhusar/subscriptions","organizations_url":"https://api.github.com/users/rhusar/orgs","repos_url":"https://api.github.com/users/rhusar/repos","events_url":"https://api.github.com/users/rhusar/events{/privacy}","received_events_url":"https://api.github.com/users/rhusar/received_events","type":"User","site_admin":false},"body":"Jira\r\nhttps://issues.jboss.org/browse/WFLY-11117","created_at":"2018-10-09T14:51:59Z","updated_at":"2018-10-11T23:57:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e744872552de99709c08347029e5597df66ab63","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly/pulls/11726/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly/pulls/11726/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly/issues/11726/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/9965e3a9c88ac5d0fcd90e0fefc400febda5fb6f","head":{"label":"rhusar:WFLY-11117","ref":"WFLY-11117","sha":"9965e3a9c88ac5d0fcd90e0fefc400febda5fb6f","user":{"login":"rhusar","id":765506,"node_id":"MDQ6VXNlcjc2NTUwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/765506?v=4","gravatar_id":"","url":"https://api.github.com/users/rhusar","html_url":"https://github.com/rhusar","followers_url":"https://api.github.com/users/rhusar/followers","following_url":"https://api.github.com/users/rhusar/following{/other_user}","gists_url":"https://api.github.com/users/rhusar/gists{/gist_id}","starred_url":"https://api.github.com/users/rhusar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhusar/subscriptions","organizations_url":"https://api.github.com/users/rhusar/orgs","repos_url":"https://api.github.com/users/rhusar/repos","events_url":"https://api.github.com/users/rhusar/events{/privacy}","received_events_url":"https://api.github.com/users/rhusar/received_events","type":"User","site_admin":false},"repo":{"id":1850393,"node_id":"MDEwOlJlcG9zaXRvcnkxODUwMzkz","name":"wildfly","full_name":"rhusar/wildfly","private":false,"owner":{"login":"rhusar","id":765506,"node_id":"MDQ6VXNlcjc2NTUwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/765506?v=4","gravatar_id":"","url":"https://api.github.com/users/rhusar","html_url":"https://github.com/rhusar","followers_url":"https://api.github.com/users/rhusar/followers","following_url":"https://api.github.com/users/rhusar/following{/other_user}","gists_url":"https://api.github.com/users/rhusar/gists{/gist_id}","starred_url":"https://api.github.com/users/rhusar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhusar/subscriptions","organizations_url":"https://api.github.com/users/rhusar/orgs","repos_url":"https://api.github.com/users/rhusar/repos","events_url":"https://api.github.com/users/rhusar/events{/privacy}","received_events_url":"https://api.github.com/users/rhusar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rhusar/wildfly","description":"WildFly Application Server","fork":true,"url":"https://api.github.com/repos/rhusar/wildfly","forks_url":"https://api.github.com/repos/rhusar/wildfly/forks","keys_url":"https://api.github.com/repos/rhusar/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhusar/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhusar/wildfly/teams","hooks_url":"https://api.github.com/repos/rhusar/wildfly/hooks","issue_events_url":"https://api.github.com/repos/rhusar/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/rhusar/wildfly/events","assignees_url":"https://api.github.com/repos/rhusar/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/rhusar/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/rhusar/wildfly/tags","blobs_url":"https://api.github.com/repos/rhusar/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhusar/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhusar/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhusar/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhusar/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/rhusar/wildfly/languages","stargazers_url":"https://api.github.com/repos/rhusar/wildfly/stargazers","contributors_url":"https://api.github.com/repos/rhusar/wildfly/contributors","subscribers_url":"https://api.github.com/repos/rhusar/wildfly/subscribers","subscription_url":"https://api.github.com/repos/rhusar/wildfly/subscription","commits_url":"https://api.github.com/repos/rhusar/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhusar/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhusar/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhusar/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhusar/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/rhusar/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhusar/wildfly/merges","archive_url":"https://api.github.com/repos/rhusar/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhusar/wildfly/downloads","issues_url":"https://api.github.com/repos/rhusar/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/rhusar/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/rhusar/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/rhusar/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhusar/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/rhusar/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/rhusar/wildfly/deployments","created_at":"2011-06-05T13:58:11Z","updated_at":"2018-10-10T08:52:21Z","pushed_at":"2018-10-11T18:13:04Z","git_url":"git://github.com/rhusar/wildfly.git","ssh_url":"git@github.com:rhusar/wildfly.git","clone_url":"https://github.com/rhusar/wildfly.git","svn_url":"https://github.com/rhusar/wildfly","homepage":"http://wildfly.org/","size":189918,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"47b1db08fadb745706df7ba411db4f7252d5dd04","user":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":764708,"node_id":"MDEwOlJlcG9zaXRvcnk3NjQ3MDg=","name":"wildfly","full_name":"wildfly/wildfly","private":false,"owner":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wildfly/wildfly","description":"WildFly Application Server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly","forks_url":"https://api.github.com/repos/wildfly/wildfly/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly/deployments","created_at":"2010-07-08T20:46:07Z","updated_at":"2018-10-11T23:27:51Z","pushed_at":"2018-10-11T23:27:42Z","git_url":"git://github.com/wildfly/wildfly.git","ssh_url":"git@github.com:wildfly/wildfly.git","clone_url":"https://github.com/wildfly/wildfly.git","svn_url":"https://github.com/wildfly/wildfly","homepage":"http://wildfly.org","size":188648,"stargazers_count":2060,"watchers_count":2060,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1826,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1826,"open_issues":53,"watchers":2060,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11726"},"html":{"href":"https://github.com/wildfly/wildfly/pull/11726"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/11726"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/11726/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11726/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11726/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly/statuses/9965e3a9c88ac5d0fcd90e0fefc400febda5fb6f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bstansberry"}}