{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/AztecEditor-iOS/issues/643","repository_url":"https://api.github.com/repos/wordpress-mobile/AztecEditor-iOS","labels_url":"https://api.github.com/repos/wordpress-mobile/AztecEditor-iOS/issues/643/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/AztecEditor-iOS/issues/643/comments","events_url":"https://api.github.com/repos/wordpress-mobile/AztecEditor-iOS/issues/643/events","html_url":"https://github.com/wordpress-mobile/AztecEditor-iOS/issues/643","id":244720065,"number":643,"title":"Enable toolbar in HTML mode","user":{"login":"diegoreymendez","id":1836005,"avatar_url":"https://avatars1.githubusercontent.com/u/1836005?v=4","gravatar_id":"","url":"https://api.github.com/users/diegoreymendez","html_url":"https://github.com/diegoreymendez","followers_url":"https://api.github.com/users/diegoreymendez/followers","following_url":"https://api.github.com/users/diegoreymendez/following{/other_user}","gists_url":"https://api.github.com/users/diegoreymendez/gists{/gist_id}","starred_url":"https://api.github.com/users/diegoreymendez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegoreymendez/subscriptions","organizations_url":"https://api.github.com/users/diegoreymendez/orgs","repos_url":"https://api.github.com/users/diegoreymendez/repos","events_url":"https://api.github.com/users/diegoreymendez/events{/privacy}","received_events_url":"https://api.github.com/users/diegoreymendez/received_events","type":"User","site_admin":false},"labels":[{"id":398111818,"url":"https://api.github.com/repos/wordpress-mobile/AztecEditor-iOS/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-21T16:27:13Z","updated_at":"2018-03-12T14:14:57Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### Description:\r\n\r\nUser's should be able to use the toolbar in HTML mode.\r\n\r\n### Details:\r\n\r\nApplying styles in HTML mode can be non trivial if our intent is to also generate valid HTML.\r\n\r\nWe'll just enable buttons that will wrap a selected range inside a specified tag.  Our default model to implement this will be based on WordPress's Calypso Post Editor.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/AztecEditor-iOS/issues/comments/372324029","html_url":"https://github.com/wordpress-mobile/AztecEditor-iOS/issues/643#issuecomment-372324029","issue_url":"https://api.github.com/repos/wordpress-mobile/AztecEditor-iOS/issues/643","id":372324029,"user":{"login":"diegoreymendez","id":1836005,"avatar_url":"https://avatars1.githubusercontent.com/u/1836005?v=4","gravatar_id":"","url":"https://api.github.com/users/diegoreymendez","html_url":"https://github.com/diegoreymendez","followers_url":"https://api.github.com/users/diegoreymendez/followers","following_url":"https://api.github.com/users/diegoreymendez/following{/other_user}","gists_url":"https://api.github.com/users/diegoreymendez/gists{/gist_id}","starred_url":"https://api.github.com/users/diegoreymendez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegoreymendez/subscriptions","organizations_url":"https://api.github.com/users/diegoreymendez/orgs","repos_url":"https://api.github.com/users/diegoreymendez/repos","events_url":"https://api.github.com/users/diegoreymendez/events{/privacy}","received_events_url":"https://api.github.com/users/diegoreymendez/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T14:14:57Z","updated_at":"2018-03-12T14:14:57Z","author_association":"CONTRIBUTOR","body":"> I agree with the problem @iamthomasbishop raises - a toolbar button is not a good place for a \"mode toggle\".\r\n\r\nThe toggle in the toolbar is indeed a really bad idea because it requires a field to have focus for you to switch mode.  This was initially not in there for Aztec but was added due to a design request.\r\n\r\n> I was under the impression the visual editor already handles HTML it doesn't like (sometimes by deleting it). I don't think it affects the implementation of this feature.\r\n\r\nDepends on the expectations (which was the point of my comment).  I personally consider it a bit of a poor experience for our style buttons to generate something like:\r\n\r\n```html\r\n<em>Hello <strong>there</em>, World!</strong>\r\n```\r\n\r\nThat said, this is not enough reason not to have those buttons working.\r\n\r\n> Are these the only blockers to implementing this?\r\n\r\nThere are no blockers to implementing this feature.\r\n\r\n> If the toolbar becomes slightly more confusing, I suggested another approach in the Wordpress-iOS bug:\r\n\r\nWe need a static indicator that you're in HTML mode.  An alert is not good at that, especially if we ever switch to remembering your preferred mode."}}
{"actor":{"display_login":"diegoreymendez"}}