{"action":"created","issue":{"url":"https://api.github.com/repos/abo-abo/swiper/issues/1634","repository_url":"https://api.github.com/repos/abo-abo/swiper","labels_url":"https://api.github.com/repos/abo-abo/swiper/issues/1634/labels{/name}","comments_url":"https://api.github.com/repos/abo-abo/swiper/issues/1634/comments","events_url":"https://api.github.com/repos/abo-abo/swiper/issues/1634/events","html_url":"https://github.com/abo-abo/swiper/issues/1634","id":333322344,"node_id":"MDU6SXNzdWUzMzMzMjIzNDQ=","number":1634,"title":"add-face-text-property requires emacs 24.4","user":{"login":"JohnLunzer","id":8135795,"node_id":"MDQ6VXNlcjgxMzU3OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/8135795?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnLunzer","html_url":"https://github.com/JohnLunzer","followers_url":"https://api.github.com/users/JohnLunzer/followers","following_url":"https://api.github.com/users/JohnLunzer/following{/other_user}","gists_url":"https://api.github.com/users/JohnLunzer/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLunzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLunzer/subscriptions","organizations_url":"https://api.github.com/users/JohnLunzer/orgs","repos_url":"https://api.github.com/users/JohnLunzer/repos","events_url":"https://api.github.com/users/JohnLunzer/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLunzer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-06-18T15:35:10Z","updated_at":"2018-06-19T08:00:44Z","closed_at":"2018-06-18T17:01:11Z","author_association":"NONE","body":"Similarly to previously reported issue, ivy.el uses `add-face-text-property` which was introduced in 24.4, but ivy.el currently states that it requires 24.1. \r\n\r\nI ran into an error when using ivy-rich's version of ivy-switch-buffer, when I type in a search pattern that doesn't exist. ivy-rich doesn't call `add-face-text-property`, so I believe ivy is the culprit. \r\n\r\nIt looks like in a couple places in ivy.el that there is a check for `add-face-text-property` and using an alternative when appropriate but in`ivy--insert-prompt` it looks like it is being used without an alternative option. Though, I'm not entirely sure this is where I'm seeing my error.\r\n\r\nAny advice on how I can eliminate all calls to `add-face-text-property`? the one in `ivy--insert-prompt` looks tricky because it says it's actually _removing_ some property so I'm not sure I can just drop in `font-lock-append-text-property` as is being done elsewhere.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/abo-abo/swiper/issues/comments/398310561","html_url":"https://github.com/abo-abo/swiper/issues/1634#issuecomment-398310561","issue_url":"https://api.github.com/repos/abo-abo/swiper/issues/1634","id":398310561,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODMxMDU2MQ==","user":{"login":"abo-abo","id":2937359,"node_id":"MDQ6VXNlcjI5MzczNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/2937359?v=4","gravatar_id":"","url":"https://api.github.com/users/abo-abo","html_url":"https://github.com/abo-abo","followers_url":"https://api.github.com/users/abo-abo/followers","following_url":"https://api.github.com/users/abo-abo/following{/other_user}","gists_url":"https://api.github.com/users/abo-abo/gists{/gist_id}","starred_url":"https://api.github.com/users/abo-abo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abo-abo/subscriptions","organizations_url":"https://api.github.com/users/abo-abo/orgs","repos_url":"https://api.github.com/users/abo-abo/repos","events_url":"https://api.github.com/users/abo-abo/events{/privacy}","received_events_url":"https://api.github.com/users/abo-abo/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T08:00:44Z","updated_at":"2018-06-19T08:00:44Z","author_association":"OWNER","body":"> The docstring says nothing about falling back on font-lock-append-text-property, but rather suggests that font-lock-append-text-property is the preferred function for propertising STR with FACE, for some reason.\r\n\r\nI think the reason is the historical deterioration of the docstring. Initially, no color blending was available and `font-lock-append-text-property` was the whole body.\r\n"}}
{"actor":{"display_login":"abo-abo"}}