{"push_id":2396707340,"size":125,"distinct_size":125,"ref":"refs/heads/master","head":"33c6eb9689eb51dfe31dd05b24b3b6b1c948c267","before":"ef71caeaa81ab75daf441fe702d267c9b722bafb","commits":[{"sha":"ed11e9cd95bd9cae6cdfab14ae0936930bbb63e6","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuMigrationSrcIsSafe: Check local storage more thoroughly\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1494454\n\nIf a domain disk is stored on local filesystem (e.g. ext4) but is\nnot being migrated it is very likely that domain is not able to\nrun on destination. Regardless of share/cache mode.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/ed11e9cd95bd9cae6cdfab14ae0936930bbb63e6"},{"sha":"61b49e387a92fa1cec9e17d2b1fdce684596ad2a","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuProcessLaunch: Print all arguments to debug\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/61b49e387a92fa1cec9e17d2b1fdce684596ad2a"},{"sha":"9ea69808f50d93c1d9737041e051c51ca9c6b07b","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemu: Add virConnectPtr back to some migration methods\n\nThis partially reverts 82592551cb8c4112cfa2264d50b8dce5349533d5.\n\nWhen migrating a domain, qemuMigrationDstPrepareAny() is called\nwhich eventually calls qemuProcessLaunch(conn = NULL, flags =\nVIR_QEMU_PROCESS_START_AUTODESTROY); But the very first thing\nthat qemuProcessLaunch does is check if AUTODESTROY flag is set\nand @conn is not NULL. Well, it is.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/9ea69808f50d93c1d9737041e051c51ca9c6b07b"},{"sha":"4393bc02109c13cd7fdba1d608c3fc13feeaeb84","author":{"name":"Nikolay Shirokovskiy","email":"04631ef0ee7d55d1ced6f402d646c6b5f91011f3@virtuozzo.com"},"message":"vz: build fix after excluding cross driver headers\n\nBuild is broken by 5529b057 [1].\n\n[1] cfg: forbid includes of headers in network and storage drivers again\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/4393bc02109c13cd7fdba1d608c3fc13feeaeb84"},{"sha":"68684c532a160536dc99f88b320d641db7926b92","author":{"name":"Nikolay Shirokovskiy","email":"04631ef0ee7d55d1ced6f402d646c6b5f91011f3@virtuozzo.com"},"message":"vz: build fix: handle missing switch enum cases\n\nEnsure all enum cases are listed in switch statements, or cast away\nenum type in places where we don't wish to cover all cases.\n\nBuild is broken after 67966ad51 [1].\n\n[1] m4: enforce that all enum cases are listed in switch statements\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/68684c532a160536dc99f88b320d641db7926b92"},{"sha":"8fafbf630fb366f54ed7478af46574be21a0e37c","author":{"name":"Nikolay Shirokovskiy","email":"04631ef0ee7d55d1ced6f402d646c6b5f91011f3@virtuozzo.com"},"message":"daemon: fix rpc event leak on error path in remoteDispatchObjectEventSend\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/8fafbf630fb366f54ed7478af46574be21a0e37c"},{"sha":"666dcb1aa25fa8d7e061fc7493226c345bafc66e","author":{"name":"Nikolay Shirokovskiy","email":"04631ef0ee7d55d1ced6f402d646c6b5f91011f3@virtuozzo.com"},"message":"lxc: fix rpc event leak on error path in virLXCControllerEventSend\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/666dcb1aa25fa8d7e061fc7493226c345bafc66e"},{"sha":"1f7b198ab4ff9202bf450ceebf16d5d06ad592ae","author":{"name":"Daniel P. Berrangé","email":"5d1320ff3c85681bb6d7ea4b0b2f371698325ec8@redhat.com"},"message":"po: refresh translations from zanata\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/1f7b198ab4ff9202bf450ceebf16d5d06ad592ae"},{"sha":"19d3d2633c848abf3ab1488be365d6ccc688f67e","author":{"name":"Daniel P. Berrangé","email":"5d1320ff3c85681bb6d7ea4b0b2f371698325ec8@redhat.com"},"message":"make: fix uninstall of subdirectory data\n\nA typo in the uninstall-data-extra rule expansion meant we just called\nthe install rule again, instead of the uninstall rule. While fixing\nthis, just inline the dependancy, since the intermediate\ninstall-data-extra rule adds no value.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/19d3d2633c848abf3ab1488be365d6ccc688f67e"},{"sha":"e1ab81b339c4d631b704290c26caa0af6882527c","author":{"name":"Daniel P. Berrangé","email":"5d1320ff3c85681bb6d7ea4b0b2f371698325ec8@redhat.com"},"message":"storage: fix sheepdog driver / test linking to avoid duplicating source\n\nThe libvirt_storage_backend_sheepdog_priv.la library depends on symbols\nprovided in the libvirt_driver_storage_impl.la library. As such the\nlatter must be listed 2nd when passed to the linker to avoid symbol\nresolution problems. This mistake is being masked by the sheepdog\ndriver linking in a second copy of the storage driver code. Remove\nthis duplicate linkage of backend source and fix the test link order.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/e1ab81b339c4d631b704290c26caa0af6882527c"},{"sha":"1297db741434b9e6f8096c5a5481594cfdedf12a","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"nwfilter: save error from DHCP snoop thread to report in main thread\n\nA problem encountered due to a bug in libpcap was reported to the\ncaller as:\n\n   An error occurred, but the cause is unknown\n\nThis was because the error had been logged in the DHCPSnoop\nthread. The worker thread handling the API call to start a domain\nspins up the DHCPSnoop thread which watches for dhcp packets with\nlibpcap, then uses virCondSignal() to notify the worker thread (which\nhas been waiting with virCondWait()). The worker thread knows that\nthere was an error (because threadStatus != THREAD_STATUS_OK), but the\nerror info had been stored in thread-specific storage for the other\nthread, so the worker thread can only report that there was a failure,\nbut it doesn't know why.\n\nThe solution is to save the error that was logged (with\nvirErrorPreserveLast() into the object the is used to share info\nbetween the threads, then we can set the error in the worker thread\nusing virErrorRestore().\n\nIn the case of the error I was looking at, this changed the \"unknown\"\nmessage into:\n\n    internal error: pcap_setfilter: can't remove kernel filter:\n    Bad file descriptor\n\nSigned-off-by: Laine Stump <laine@laine.org>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/1297db741434b9e6f8096c5a5481594cfdedf12a"},{"sha":"f7399de11b9d92aa8e3a4c47c8cccd8de21db11a","author":{"name":"Zhangzijian","email":"abf52cc1ded9ad29668cb055e7c4b2f8b83b7a4f@h3c.com"},"message":"qemu: fix memory leak of @vporttype during migration.\n\n12 bytes in 1 blocks are definitely lost in loss record 188 of 1,145\nat 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)\nby 0x5D2CD77: xmlStrndup (in /lib/x86_64-linux-gnu/libxml2.so.2.7.8)\nby 0x514E137: virXMLPropString (virxml.c:506)\nby 0x234F51: qemuMigrationCookieNetworkXMLParse qemu_migration.c:1001)\nby 0x235FF8: qemuMigrationCookieXMLParse (qemu_migration.c:1333)\nby 0x236214: qemuMigrationCookieXMLParseStr (qemu_migration.c:1372)\nby 0x2365D2: qemuMigrationEatCookie (qemu_migration.c:1456)\nby 0x243DBA: qemuMigrationFinish (qemu_migration.c:6381)\nby 0x204032: qemuDomainMigrateFinish3 (qemu_driver.c:13228)\nby 0x521CCBB: virDomainMigrateFinish3 (libvirt-domain.c:4788)\nby 0x1936DE: remoteDispatchDomainMigrateFinish3 (remote.c:4580)\nby 0x16DBB1: remoteDispatchDomainMigrateFinish3Helper(remote_dispatch.h:7582)\n\nSigned-off-by: ZhangZijian <zhang.zijian@h3c.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/f7399de11b9d92aa8e3a4c47c8cccd8de21db11a"},{"sha":"8fe09a53170a96962d6f795ff9b6034ff9d0fb7f","author":{"name":"Julio Faracco","email":"e44ea82424ac9334b6a706dc2e3a28b88d3b418f@gmail.com"},"message":"virsh: fixing segfault by pool autocompleter function.\n\nThe commands which requires a pool to perform any action for a volume is\nthrowing a segfault when you pass the volume name before a pool name or\nwithout the argument '--pool'.\n\nAn example that works:\nvirsh # vol-list loops-pool\n Name                 Path\n-------------------------------------------------------------------\n loop0                /mnt/loop0\n\nvirsh # vol-info --pool loops-pool lo<TAB>\n\nAn example that does not work:\nvirsh # vol-list loops-pool\n Name                 Path\n-------------------------------------------------------------------\n loop0                /mnt/loop0\n\nvirsh # vol-info lo<TAB>\nSegmentation Fault\n\nThe example 'vol-info' can be executed as 'vol-info loop0 --pool\nloops-pool'. So, this commit fixes this problem when the arguments are\ninverted and avoids the segfault.\n\nSigned-off-by: Julio Faracco <jcfaracco@gmail.com>\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/8fe09a53170a96962d6f795ff9b6034ff9d0fb7f"},{"sha":"98c9c3048d88acd81748466f7970e897ccbe81f1","author":{"name":"Nikolay Shirokovskiy","email":"04631ef0ee7d55d1ced6f402d646c6b5f91011f3@virtuozzo.com"},"message":"vz: fix ref/unref of domain obj in vzDomainRevertToSnapshot\n\nSigned-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/98c9c3048d88acd81748466f7970e897ccbe81f1"},{"sha":"846d3b5874be9f5b808f8bf5ce2e1f07fe1293f0","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"vshCommandOpt: Do more checking if skipChecks is set\n\nCurrently if cmd->skipChecks is set (done only from completers)\nsome basic checks are skipped because we're working over\npartially parsed command. See a26ff63ae4 for more detailed\nexplanation. Anyway, the referenced commit was too aggressive in\ndisabling checks and effectively returned success even in clear\ncase of failure. For instance:\n\n  # domif-getlink --interface <TAB><TAB>\n\ncauses virshDomainInterfaceCompleter() to be called, which calls\nvirshDomainGetXML() which eventually calls\nvshCommandOptStringReq(.., name = \"domain\"); The --domain\nargument is required for the command and if not present -1 should\nbe returned to tell the caller the argument was not found. Well,\nzero is returned meaning the argument was not found but it's not\nrequired either.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/846d3b5874be9f5b808f8bf5ce2e1f07fe1293f0"},{"sha":"6090a816acd984e1aeff235eab0f43f95690a551","author":{"name":"Daniel P. Berrangé","email":"5d1320ff3c85681bb6d7ea4b0b2f371698325ec8@redhat.com"},"message":"docs: remove legacy XHTML <!DOCTYPE> declaration\n\nWe have switched the docs to using the HTML5 doctype declaration in\n\n  commit b1c81567c7172bc9dcd701cf46ea3f87725d62c7\n  Author: Daniel P. Berrange <berrange@redhat.com>\n  Date:   Wed Jul 26 18:01:25 2017 +0100\n\n    docs: switch to using HTML5 doctype declaration\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/6090a816acd984e1aeff235eab0f43f95690a551"},{"sha":"900383f5b83c1574e93b1ba75edd5c94f4d8c190","author":{"name":"Daniel P. Berrangé","email":"5d1320ff3c85681bb6d7ea4b0b2f371698325ec8@redhat.com"},"message":"make: skip pdwtags when building with CLang\n\nWhen building with CLang the structs that are emitted by pdwtags appear\nin a completely different order than with GCC, which causes the\ncomparison against expected data to fail.\n\nIdeally the test would not be sensitive to the ordering, because even\nfuture GCC could cause changes, but that's not easy to fix. So for now\njust skip the test when using clang.\n\nReviewed-by: Andrea Bolognani <abologna@redhat.com>\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/900383f5b83c1574e93b1ba75edd5c94f4d8c190"},{"sha":"d4ea32e85f9e206784d9c559b66947c47fac21ee","author":{"name":"Daniel P. Berrangé","email":"5d1320ff3c85681bb6d7ea4b0b2f371698325ec8@redhat.com"},"message":"travis: drop precise distro jobs\n\nThe precise distro is marked deprecated in travis and will be dropped\nentirely in 2 months time.\n\nReviewed-by: Andrea Bolognani <abologna@redhat.com>\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/d4ea32e85f9e206784d9c559b66947c47fac21ee"},{"sha":"60ae63c230e32801fe34c3999ba288070ec8daa2","author":{"name":"Daniel P. Berrangé","email":"5d1320ff3c85681bb6d7ea4b0b2f371698325ec8@redhat.com"},"message":"travis: run \"make distcheck\" instead of just \"make check\"\n\nRunning \"make distcheck\" includes the \"make check\", and \"make dist\"\ntargets. It ensures that we have CLEANFILES and uninstall rules setup\ncorrectly, as well as validating VPATH builds succeed.\n\nReviewed-by: Andrea Bolognani <abologna@redhat.com>\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/60ae63c230e32801fe34c3999ba288070ec8daa2"},{"sha":"268ab759d98d90e0f458697e1f210e64fc03ebd9","author":{"name":"Daniel P. Berrangé","email":"5d1320ff3c85681bb6d7ea4b0b2f371698325ec8@redhat.com"},"message":"travis: test \"make install\" and \"make dist\" on macOS\n\nWe can't use \"make distcheck\" on macOS because many unit tests fail. We\ncan still get coverage of some of the things \"distcheck\" validates, by\nrunning the \"install\" and \"dist\" targets. This is particularly useful\nbecause many conditional features are disabled on macOS, and this helps\nmake sure we can still successfully install & dist when these bits are\ndisabled.\n\nThe default script is getting unreadable since it is all on one long\nline. Rather than adding further conditional clauses to it, we make\nuse of the travis matrix config override for the script.\n\nReviewed-by: Andrea Bolognani <abologna@redhat.com>\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":true,"url":"https://api.github.com/repos/rst0git/libvirt/commits/268ab759d98d90e0f458697e1f210e64fc03ebd9"}]}
{"actor":{"display_login":"rst0git"}}