{"action":"closed","number":44,"pull_request":{"url":"https://api.github.com/repos/chef/kitchen-vcenter/pulls/44","id":242318175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMzE4MTc1","html_url":"https://github.com/chef/kitchen-vcenter/pull/44","diff_url":"https://github.com/chef/kitchen-vcenter/pull/44.diff","patch_url":"https://github.com/chef/kitchen-vcenter/pull/44.patch","issue_url":"https://api.github.com/repos/chef/kitchen-vcenter/issues/44","number":44,"state":"closed","locked":false,"title":"Fix for Issues #26 and #30","user":{"login":"tecracer-theinen","id":33926466,"node_id":"MDQ6VXNlcjMzOTI2NDY2","avatar_url":"https://avatars0.githubusercontent.com/u/33926466?v=4","gravatar_id":"","url":"https://api.github.com/users/tecracer-theinen","html_url":"https://github.com/tecracer-theinen","followers_url":"https://api.github.com/users/tecracer-theinen/followers","following_url":"https://api.github.com/users/tecracer-theinen/following{/other_user}","gists_url":"https://api.github.com/users/tecracer-theinen/gists{/gist_id}","starred_url":"https://api.github.com/users/tecracer-theinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tecracer-theinen/subscriptions","organizations_url":"https://api.github.com/users/tecracer-theinen/orgs","repos_url":"https://api.github.com/users/tecracer-theinen/repos","events_url":"https://api.github.com/users/tecracer-theinen/events{/privacy}","received_events_url":"https://api.github.com/users/tecracer-theinen/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nImplement support for vSphere setups where vCenter and Platform Services Controller are not located on the same machine (\"external PSC\") in addition to the previous support for setups where they are (\"embedded PSC\").\r\n\r\n### Issues Resolved\r\n\r\nPreviously, trying to use kitchen-vcenter with external PSC setups would fail with 'HTTP error (404)' when trying to access the lookup service on the wrong host. This was e.g. referenced in issues #26 and #30 \r\n\r\nThis new solution queries vCenter for the SSO URL (which is always co-located with the Lookup Service on the PSC). Via Lookup Service, an enumeration of vAPI and VIM endpoints is retrieved and the correct API endpoint for the configured vCenter will be determined.\r\n\r\nIf autodetection of the Lookup Service is not desired, this can be overridded with the new/optional \"lookup_service_host\" configuration parameter.\r\n\r\n### Check List\r\n\r\n- [X] All style checks pass.\r\n- [X] Functionality has been documented in the README if applicable\r\n- [X] All commits have been signed-off for the Developer Certificate of Origin. See <https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco>","created_at":"2019-01-04T16:59:57Z","updated_at":"2019-01-04T17:06:52Z","closed_at":"2019-01-04T17:06:52Z","merged_at":"2019-01-04T17:06:52Z","merge_commit_sha":"5aade3066a90d80ae7b066d9deddb2249805ee1a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"Docs Team","id":2638109,"node_id":"MDQ6VGVhbTI2MzgxMDk=","slug":"docs-team","description":"","privacy":"closed","url":"https://api.github.com/teams/2638109","members_url":"https://api.github.com/teams/2638109/members{/member}","repositories_url":"https://api.github.com/teams/2638109/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/kitchen-vcenter/pulls/44/commits","review_comments_url":"https://api.github.com/repos/chef/kitchen-vcenter/pulls/44/comments","review_comment_url":"https://api.github.com/repos/chef/kitchen-vcenter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/kitchen-vcenter/issues/44/comments","statuses_url":"https://api.github.com/repos/chef/kitchen-vcenter/statuses/c25fee6e6a485c0e4abf03038631aa5a83e49f10","head":{"label":"tecracer-theinen:fix-30","ref":"fix-30","sha":"c25fee6e6a485c0e4abf03038631aa5a83e49f10","user":{"login":"tecracer-theinen","id":33926466,"node_id":"MDQ6VXNlcjMzOTI2NDY2","avatar_url":"https://avatars0.githubusercontent.com/u/33926466?v=4","gravatar_id":"","url":"https://api.github.com/users/tecracer-theinen","html_url":"https://github.com/tecracer-theinen","followers_url":"https://api.github.com/users/tecracer-theinen/followers","following_url":"https://api.github.com/users/tecracer-theinen/following{/other_user}","gists_url":"https://api.github.com/users/tecracer-theinen/gists{/gist_id}","starred_url":"https://api.github.com/users/tecracer-theinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tecracer-theinen/subscriptions","organizations_url":"https://api.github.com/users/tecracer-theinen/orgs","repos_url":"https://api.github.com/users/tecracer-theinen/repos","events_url":"https://api.github.com/users/tecracer-theinen/events{/privacy}","received_events_url":"https://api.github.com/users/tecracer-theinen/received_events","type":"User","site_admin":false},"repo":{"id":157886488,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4ODY0ODg=","name":"kitchen-vcenter","full_name":"tecracer-theinen/kitchen-vcenter","private":false,"owner":{"login":"tecracer-theinen","id":33926466,"node_id":"MDQ6VXNlcjMzOTI2NDY2","avatar_url":"https://avatars0.githubusercontent.com/u/33926466?v=4","gravatar_id":"","url":"https://api.github.com/users/tecracer-theinen","html_url":"https://github.com/tecracer-theinen","followers_url":"https://api.github.com/users/tecracer-theinen/followers","following_url":"https://api.github.com/users/tecracer-theinen/following{/other_user}","gists_url":"https://api.github.com/users/tecracer-theinen/gists{/gist_id}","starred_url":"https://api.github.com/users/tecracer-theinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tecracer-theinen/subscriptions","organizations_url":"https://api.github.com/users/tecracer-theinen/orgs","repos_url":"https://api.github.com/users/tecracer-theinen/repos","events_url":"https://api.github.com/users/tecracer-theinen/events{/privacy}","received_events_url":"https://api.github.com/users/tecracer-theinen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tecracer-theinen/kitchen-vcenter","description":"A test-kitchen driver for vCenter REST API","fork":true,"url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter","forks_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/forks","keys_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/teams","hooks_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/hooks","issue_events_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/issues/events{/number}","events_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/events","assignees_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/assignees{/user}","branches_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/branches{/branch}","tags_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/tags","blobs_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/git/refs{/sha}","trees_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/statuses/{sha}","languages_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/languages","stargazers_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/stargazers","contributors_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/contributors","subscribers_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/subscribers","subscription_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/subscription","commits_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/commits{/sha}","git_commits_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/git/commits{/sha}","comments_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/comments{/number}","issue_comment_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/issues/comments{/number}","contents_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/contents/{+path}","compare_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/merges","archive_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/downloads","issues_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/issues{/number}","pulls_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/pulls{/number}","milestones_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/milestones{/number}","notifications_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/labels{/name}","releases_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/releases{/id}","deployments_url":"https://api.github.com/repos/tecracer-theinen/kitchen-vcenter/deployments","created_at":"2018-11-16T15:32:41Z","updated_at":"2018-12-14T22:45:45Z","pushed_at":"2019-01-04T16:58:07Z","git_url":"git://github.com/tecracer-theinen/kitchen-vcenter.git","ssh_url":"git@github.com:tecracer-theinen/kitchen-vcenter.git","clone_url":"https://github.com/tecracer-theinen/kitchen-vcenter.git","svn_url":"https://github.com/tecracer-theinen/kitchen-vcenter","homepage":"https://www.chef.io/implementations/vmware","size":70,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"c5442f81f5cdd015c1748b25feb009d9956d90c8","user":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":98209826,"node_id":"MDEwOlJlcG9zaXRvcnk5ODIwOTgyNg==","name":"kitchen-vcenter","full_name":"chef/kitchen-vcenter","private":false,"owner":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chef/kitchen-vcenter","description":"A test-kitchen driver for vCenter REST API","fork":false,"url":"https://api.github.com/repos/chef/kitchen-vcenter","forks_url":"https://api.github.com/repos/chef/kitchen-vcenter/forks","keys_url":"https://api.github.com/repos/chef/kitchen-vcenter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/kitchen-vcenter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/kitchen-vcenter/teams","hooks_url":"https://api.github.com/repos/chef/kitchen-vcenter/hooks","issue_events_url":"https://api.github.com/repos/chef/kitchen-vcenter/issues/events{/number}","events_url":"https://api.github.com/repos/chef/kitchen-vcenter/events","assignees_url":"https://api.github.com/repos/chef/kitchen-vcenter/assignees{/user}","branches_url":"https://api.github.com/repos/chef/kitchen-vcenter/branches{/branch}","tags_url":"https://api.github.com/repos/chef/kitchen-vcenter/tags","blobs_url":"https://api.github.com/repos/chef/kitchen-vcenter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/kitchen-vcenter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/kitchen-vcenter/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/kitchen-vcenter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/kitchen-vcenter/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/kitchen-vcenter/languages","stargazers_url":"https://api.github.com/repos/chef/kitchen-vcenter/stargazers","contributors_url":"https://api.github.com/repos/chef/kitchen-vcenter/contributors","subscribers_url":"https://api.github.com/repos/chef/kitchen-vcenter/subscribers","subscription_url":"https://api.github.com/repos/chef/kitchen-vcenter/subscription","commits_url":"https://api.github.com/repos/chef/kitchen-vcenter/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/kitchen-vcenter/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/kitchen-vcenter/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/kitchen-vcenter/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/kitchen-vcenter/contents/{+path}","compare_url":"https://api.github.com/repos/chef/kitchen-vcenter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/kitchen-vcenter/merges","archive_url":"https://api.github.com/repos/chef/kitchen-vcenter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/kitchen-vcenter/downloads","issues_url":"https://api.github.com/repos/chef/kitchen-vcenter/issues{/number}","pulls_url":"https://api.github.com/repos/chef/kitchen-vcenter/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/kitchen-vcenter/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/kitchen-vcenter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/kitchen-vcenter/labels{/name}","releases_url":"https://api.github.com/repos/chef/kitchen-vcenter/releases{/id}","deployments_url":"https://api.github.com/repos/chef/kitchen-vcenter/deployments","created_at":"2017-07-24T16:09:24Z","updated_at":"2018-12-22T06:58:12Z","pushed_at":"2019-01-04T17:06:52Z","git_url":"git://github.com/chef/kitchen-vcenter.git","ssh_url":"git@github.com:chef/kitchen-vcenter.git","clone_url":"https://github.com/chef/kitchen-vcenter.git","svn_url":"https://github.com/chef/kitchen-vcenter","homepage":"https://www.chef.io/implementations/vmware","size":74,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":10,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/kitchen-vcenter/pulls/44"},"html":{"href":"https://github.com/chef/kitchen-vcenter/pull/44"},"issue":{"href":"https://api.github.com/repos/chef/kitchen-vcenter/issues/44"},"comments":{"href":"https://api.github.com/repos/chef/kitchen-vcenter/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/kitchen-vcenter/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/kitchen-vcenter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/kitchen-vcenter/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/chef/kitchen-vcenter/statuses/c25fee6e6a485c0e4abf03038631aa5a83e49f10"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tas50","id":1015200,"node_id":"MDQ6VXNlcjEwMTUyMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1015200?v=4","gravatar_id":"","url":"https://api.github.com/users/tas50","html_url":"https://github.com/tas50","followers_url":"https://api.github.com/users/tas50/followers","following_url":"https://api.github.com/users/tas50/following{/other_user}","gists_url":"https://api.github.com/users/tas50/gists{/gist_id}","starred_url":"https://api.github.com/users/tas50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tas50/subscriptions","organizations_url":"https://api.github.com/users/tas50/orgs","repos_url":"https://api.github.com/users/tas50/repos","events_url":"https://api.github.com/users/tas50/events{/privacy}","received_events_url":"https://api.github.com/users/tas50/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":48,"deletions":10,"changed_files":2}}
{"actor":{"display_login":"tas50"}}