{"action":"closed","number":158,"pull_request":{"url":"https://api.github.com/repos/bugsnag/bugsnag-python/pulls/158","id":205466554,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDY2NTU0","html_url":"https://github.com/bugsnag/bugsnag-python/pull/158","diff_url":"https://github.com/bugsnag/bugsnag-python/pull/158.diff","patch_url":"https://github.com/bugsnag/bugsnag-python/pull/158.patch","issue_url":"https://api.github.com/repos/bugsnag/bugsnag-python/issues/158","number":158,"state":"closed","locked":false,"title":"Add Django 1.11, 2.0 and 2.1 to the build matrix","user":{"login":"browniebroke","id":861044,"node_id":"MDQ6VXNlcjg2MTA0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/861044?v=4","gravatar_id":"","url":"https://api.github.com/users/browniebroke","html_url":"https://github.com/browniebroke","followers_url":"https://api.github.com/users/browniebroke/followers","following_url":"https://api.github.com/users/browniebroke/following{/other_user}","gists_url":"https://api.github.com/users/browniebroke/gists{/gist_id}","starred_url":"https://api.github.com/users/browniebroke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/browniebroke/subscriptions","organizations_url":"https://api.github.com/users/browniebroke/orgs","repos_url":"https://api.github.com/users/browniebroke/repos","events_url":"https://api.github.com/users/browniebroke/events{/privacy}","received_events_url":"https://api.github.com/users/browniebroke/received_events","type":"User","site_admin":false},"body":"## Goal\r\n\r\nDjango 2.1 [was released today](https://www.djangoproject.com/weblog/2018/aug/01/django-21-released/), which means all versions of Django in the build matrix are currently no longer supported by the Django core team. This adds newer versions of Django to the build matrix. \r\n\r\nYou might want to drop support for older versions <1.11 and bump the version of the library. Let me know if you want me to do so as part of this PR, I don't mind it.\r\n\r\n## Design\r\n\r\nn/a\r\n\r\n## Tests\r\n\r\nRunning Python 2.7 tests under Django 1.11 but only Python 3.6 on Django 2.0 and above, as the project dropped support for Python 2.\r\n\r\n## Discussion\r\n\r\n### Alternative Approaches\r\n\r\n<!-- What other approaches were considered or discussed? -->\r\n\r\n### Outstanding Questions\r\n\r\n<!-- Are there any parts of the design or the implementation which seem\r\n     less than ideal and that could require additional discussion?\r\n     List here: -->\r\n\r\n### Linked issues\r\n\r\n<!--\r\n\r\nFixes #\r\nRelated to #\r\n\r\n-->\r\n\r\n## Review\r\n\r\n<!-- When submitting for review, consider the points for self-review and the\r\n     criteria which will be used for secondary review -->\r\n\r\nFor the submitter, initial self-review:\r\n\r\n- [ ] Commented on code changes inline explain the reasoning behind the approach\r\n- [ ] Reviewed the test cases added for completeness and possible points for discussion\r\n- [ ] A changelog entry was added for the goal of this pull request\r\n- [ ] Check the scope of the changeset - is everything in the diff required for the pull request?\r\n- This pull request is ready for:\r\n  - [ ] Initial review of the intended approach, not yet feature complete\r\n  - [ ] Structural review of the classes, functions, and properties modified\r\n  - [ ] Final review\r\n\r\nFor the pull request reviewer(s), this changeset has been reviewed for:\r\n\r\n- [ ] Consistency across platforms for structures or concepts added or modified\r\n- [ ] Consistency between the changeset and the goal stated above\r\n- [ ] Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?\r\n- [ ] Usage friction - is the proposed change in usage cumbersome or complicated?\r\n- [ ] Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?\r\n- [ ] Concurrency concerns - if components are accessed asynchronously, what issues will arise\r\n- [ ] Thoroughness of added tests and any missing edge cases\r\n- [ ] Idiomatic use of the language\r\n","created_at":"2018-08-01T15:34:44Z","updated_at":"2018-08-03T09:05:47Z","closed_at":"2018-08-03T09:05:47Z","merged_at":"2018-08-03T09:05:47Z","merge_commit_sha":"fcc615dc79126094f78dcb963e4a75275679c4cd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bugsnag/bugsnag-python/pulls/158/commits","review_comments_url":"https://api.github.com/repos/bugsnag/bugsnag-python/pulls/158/comments","review_comment_url":"https://api.github.com/repos/bugsnag/bugsnag-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bugsnag/bugsnag-python/issues/158/comments","statuses_url":"https://api.github.com/repos/bugsnag/bugsnag-python/statuses/64f6103018f35daf0ec821c6ef1cee0bc760c833","head":{"label":"founders4schools:build-matrix","ref":"build-matrix","sha":"64f6103018f35daf0ec821c6ef1cee0bc760c833","user":{"login":"founders4schools","id":6940582,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDA1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/6940582?v=4","gravatar_id":"","url":"https://api.github.com/users/founders4schools","html_url":"https://github.com/founders4schools","followers_url":"https://api.github.com/users/founders4schools/followers","following_url":"https://api.github.com/users/founders4schools/following{/other_user}","gists_url":"https://api.github.com/users/founders4schools/gists{/gist_id}","starred_url":"https://api.github.com/users/founders4schools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/founders4schools/subscriptions","organizations_url":"https://api.github.com/users/founders4schools/orgs","repos_url":"https://api.github.com/users/founders4schools/repos","events_url":"https://api.github.com/users/founders4schools/events{/privacy}","received_events_url":"https://api.github.com/users/founders4schools/received_events","type":"Organization","site_admin":false},"repo":{"id":143158928,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxNTg5Mjg=","name":"bugsnag-python","full_name":"founders4schools/bugsnag-python","owner":{"login":"founders4schools","id":6940582,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDA1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/6940582?v=4","gravatar_id":"","url":"https://api.github.com/users/founders4schools","html_url":"https://github.com/founders4schools","followers_url":"https://api.github.com/users/founders4schools/followers","following_url":"https://api.github.com/users/founders4schools/following{/other_user}","gists_url":"https://api.github.com/users/founders4schools/gists{/gist_id}","starred_url":"https://api.github.com/users/founders4schools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/founders4schools/subscriptions","organizations_url":"https://api.github.com/users/founders4schools/orgs","repos_url":"https://api.github.com/users/founders4schools/repos","events_url":"https://api.github.com/users/founders4schools/events{/privacy}","received_events_url":"https://api.github.com/users/founders4schools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/founders4schools/bugsnag-python","description":"Official bugsnag error monitoring and error reporting for django, flask, tornado and other python apps.","fork":true,"url":"https://api.github.com/repos/founders4schools/bugsnag-python","forks_url":"https://api.github.com/repos/founders4schools/bugsnag-python/forks","keys_url":"https://api.github.com/repos/founders4schools/bugsnag-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/founders4schools/bugsnag-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/founders4schools/bugsnag-python/teams","hooks_url":"https://api.github.com/repos/founders4schools/bugsnag-python/hooks","issue_events_url":"https://api.github.com/repos/founders4schools/bugsnag-python/issues/events{/number}","events_url":"https://api.github.com/repos/founders4schools/bugsnag-python/events","assignees_url":"https://api.github.com/repos/founders4schools/bugsnag-python/assignees{/user}","branches_url":"https://api.github.com/repos/founders4schools/bugsnag-python/branches{/branch}","tags_url":"https://api.github.com/repos/founders4schools/bugsnag-python/tags","blobs_url":"https://api.github.com/repos/founders4schools/bugsnag-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/founders4schools/bugsnag-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/founders4schools/bugsnag-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/founders4schools/bugsnag-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/founders4schools/bugsnag-python/statuses/{sha}","languages_url":"https://api.github.com/repos/founders4schools/bugsnag-python/languages","stargazers_url":"https://api.github.com/repos/founders4schools/bugsnag-python/stargazers","contributors_url":"https://api.github.com/repos/founders4schools/bugsnag-python/contributors","subscribers_url":"https://api.github.com/repos/founders4schools/bugsnag-python/subscribers","subscription_url":"https://api.github.com/repos/founders4schools/bugsnag-python/subscription","commits_url":"https://api.github.com/repos/founders4schools/bugsnag-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/founders4schools/bugsnag-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/founders4schools/bugsnag-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/founders4schools/bugsnag-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/founders4schools/bugsnag-python/contents/{+path}","compare_url":"https://api.github.com/repos/founders4schools/bugsnag-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/founders4schools/bugsnag-python/merges","archive_url":"https://api.github.com/repos/founders4schools/bugsnag-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/founders4schools/bugsnag-python/downloads","issues_url":"https://api.github.com/repos/founders4schools/bugsnag-python/issues{/number}","pulls_url":"https://api.github.com/repos/founders4schools/bugsnag-python/pulls{/number}","milestones_url":"https://api.github.com/repos/founders4schools/bugsnag-python/milestones{/number}","notifications_url":"https://api.github.com/repos/founders4schools/bugsnag-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/founders4schools/bugsnag-python/labels{/name}","releases_url":"https://api.github.com/repos/founders4schools/bugsnag-python/releases{/id}","deployments_url":"https://api.github.com/repos/founders4schools/bugsnag-python/deployments","created_at":"2018-08-01T13:20:34Z","updated_at":"2018-08-01T13:20:37Z","pushed_at":"2018-08-01T16:59:17Z","git_url":"git://github.com/founders4schools/bugsnag-python.git","ssh_url":"git@github.com:founders4schools/bugsnag-python.git","clone_url":"https://github.com/founders4schools/bugsnag-python.git","svn_url":"https://github.com/founders4schools/bugsnag-python","homepage":"https://www.bugsnag.com/platforms/python-error-reporting/","size":443,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bugsnag:next","ref":"next","sha":"a961c4ed16985d9bd9f43957ca5887ab351067cb","user":{"login":"bugsnag","id":1058895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTg4OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1058895?v=4","gravatar_id":"","url":"https://api.github.com/users/bugsnag","html_url":"https://github.com/bugsnag","followers_url":"https://api.github.com/users/bugsnag/followers","following_url":"https://api.github.com/users/bugsnag/following{/other_user}","gists_url":"https://api.github.com/users/bugsnag/gists{/gist_id}","starred_url":"https://api.github.com/users/bugsnag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugsnag/subscriptions","organizations_url":"https://api.github.com/users/bugsnag/orgs","repos_url":"https://api.github.com/users/bugsnag/repos","events_url":"https://api.github.com/users/bugsnag/events{/privacy}","received_events_url":"https://api.github.com/users/bugsnag/received_events","type":"Organization","site_admin":false},"repo":{"id":5201854,"node_id":"MDEwOlJlcG9zaXRvcnk1MjAxODU0","name":"bugsnag-python","full_name":"bugsnag/bugsnag-python","owner":{"login":"bugsnag","id":1058895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTg4OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1058895?v=4","gravatar_id":"","url":"https://api.github.com/users/bugsnag","html_url":"https://github.com/bugsnag","followers_url":"https://api.github.com/users/bugsnag/followers","following_url":"https://api.github.com/users/bugsnag/following{/other_user}","gists_url":"https://api.github.com/users/bugsnag/gists{/gist_id}","starred_url":"https://api.github.com/users/bugsnag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugsnag/subscriptions","organizations_url":"https://api.github.com/users/bugsnag/orgs","repos_url":"https://api.github.com/users/bugsnag/repos","events_url":"https://api.github.com/users/bugsnag/events{/privacy}","received_events_url":"https://api.github.com/users/bugsnag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bugsnag/bugsnag-python","description":"Official bugsnag error monitoring and error reporting for django, flask, tornado and other python apps.","fork":false,"url":"https://api.github.com/repos/bugsnag/bugsnag-python","forks_url":"https://api.github.com/repos/bugsnag/bugsnag-python/forks","keys_url":"https://api.github.com/repos/bugsnag/bugsnag-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bugsnag/bugsnag-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bugsnag/bugsnag-python/teams","hooks_url":"https://api.github.com/repos/bugsnag/bugsnag-python/hooks","issue_events_url":"https://api.github.com/repos/bugsnag/bugsnag-python/issues/events{/number}","events_url":"https://api.github.com/repos/bugsnag/bugsnag-python/events","assignees_url":"https://api.github.com/repos/bugsnag/bugsnag-python/assignees{/user}","branches_url":"https://api.github.com/repos/bugsnag/bugsnag-python/branches{/branch}","tags_url":"https://api.github.com/repos/bugsnag/bugsnag-python/tags","blobs_url":"https://api.github.com/repos/bugsnag/bugsnag-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bugsnag/bugsnag-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bugsnag/bugsnag-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/bugsnag/bugsnag-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bugsnag/bugsnag-python/statuses/{sha}","languages_url":"https://api.github.com/repos/bugsnag/bugsnag-python/languages","stargazers_url":"https://api.github.com/repos/bugsnag/bugsnag-python/stargazers","contributors_url":"https://api.github.com/repos/bugsnag/bugsnag-python/contributors","subscribers_url":"https://api.github.com/repos/bugsnag/bugsnag-python/subscribers","subscription_url":"https://api.github.com/repos/bugsnag/bugsnag-python/subscription","commits_url":"https://api.github.com/repos/bugsnag/bugsnag-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/bugsnag/bugsnag-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/bugsnag/bugsnag-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/bugsnag/bugsnag-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/bugsnag/bugsnag-python/contents/{+path}","compare_url":"https://api.github.com/repos/bugsnag/bugsnag-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bugsnag/bugsnag-python/merges","archive_url":"https://api.github.com/repos/bugsnag/bugsnag-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bugsnag/bugsnag-python/downloads","issues_url":"https://api.github.com/repos/bugsnag/bugsnag-python/issues{/number}","pulls_url":"https://api.github.com/repos/bugsnag/bugsnag-python/pulls{/number}","milestones_url":"https://api.github.com/repos/bugsnag/bugsnag-python/milestones{/number}","notifications_url":"https://api.github.com/repos/bugsnag/bugsnag-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bugsnag/bugsnag-python/labels{/name}","releases_url":"https://api.github.com/repos/bugsnag/bugsnag-python/releases{/id}","deployments_url":"https://api.github.com/repos/bugsnag/bugsnag-python/deployments","created_at":"2012-07-27T07:34:23Z","updated_at":"2018-07-11T16:51:10Z","pushed_at":"2018-08-03T09:05:47Z","git_url":"git://github.com/bugsnag/bugsnag-python.git","ssh_url":"git@github.com:bugsnag/bugsnag-python.git","clone_url":"https://github.com/bugsnag/bugsnag-python.git","svn_url":"https://github.com/bugsnag/bugsnag-python","homepage":"https://www.bugsnag.com/platforms/python-error-reporting/","size":442,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":5,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bugsnag/bugsnag-python/pulls/158"},"html":{"href":"https://github.com/bugsnag/bugsnag-python/pull/158"},"issue":{"href":"https://api.github.com/repos/bugsnag/bugsnag-python/issues/158"},"comments":{"href":"https://api.github.com/repos/bugsnag/bugsnag-python/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/bugsnag/bugsnag-python/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/bugsnag/bugsnag-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bugsnag/bugsnag-python/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/bugsnag/bugsnag-python/statuses/64f6103018f35daf0ec821c6ef1cee0bc760c833"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fractalwrench","id":11800640,"node_id":"MDQ6VXNlcjExODAwNjQw","avatar_url":"https://avatars3.githubusercontent.com/u/11800640?v=4","gravatar_id":"","url":"https://api.github.com/users/fractalwrench","html_url":"https://github.com/fractalwrench","followers_url":"https://api.github.com/users/fractalwrench/followers","following_url":"https://api.github.com/users/fractalwrench/following{/other_user}","gists_url":"https://api.github.com/users/fractalwrench/gists{/gist_id}","starred_url":"https://api.github.com/users/fractalwrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fractalwrench/subscriptions","organizations_url":"https://api.github.com/users/fractalwrench/orgs","repos_url":"https://api.github.com/users/fractalwrench/repos","events_url":"https://api.github.com/users/fractalwrench/events{/privacy}","received_events_url":"https://api.github.com/users/fractalwrench/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":21,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"fractalwrench"}}