{"action":"created","comment":{"url":"https://api.github.com/repos/leoluk/configmaster/pulls/comments/179712218","pull_request_review_id":110008320,"id":179712218,"diff_hunk":"@@ -0,0 +1,9 @@\n+#!/bin/bash","path":"openshift/rsh.sh","position":1,"original_position":1,"commit_id":"100a0492a8b1625e97f49075dceef40bd862e456","original_commit_id":"100a0492a8b1625e97f49075dceef40bd862e456","user":{"login":"Alexander-N","id":957095,"avatar_url":"https://avatars3.githubusercontent.com/u/957095?v=4","gravatar_id":"","url":"https://api.github.com/users/Alexander-N","html_url":"https://github.com/Alexander-N","followers_url":"https://api.github.com/users/Alexander-N/followers","following_url":"https://api.github.com/users/Alexander-N/following{/other_user}","gists_url":"https://api.github.com/users/Alexander-N/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexander-N/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexander-N/subscriptions","organizations_url":"https://api.github.com/users/Alexander-N/orgs","repos_url":"https://api.github.com/users/Alexander-N/repos","events_url":"https://api.github.com/users/Alexander-N/events{/privacy}","received_events_url":"https://api.github.com/users/Alexander-N/received_events","type":"User","site_admin":false},"body":"Ok. Couldn't you replace it here directly?","created_at":"2018-04-06T09:59:48Z","updated_at":"2018-04-06T09:59:49Z","html_url":"https://github.com/leoluk/configmaster/pull/34#discussion_r179712218","pull_request_url":"https://api.github.com/repos/leoluk/configmaster/pulls/34","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/leoluk/configmaster/pulls/comments/179712218"},"html":{"href":"https://github.com/leoluk/configmaster/pull/34#discussion_r179712218"},"pull_request":{"href":"https://api.github.com/repos/leoluk/configmaster/pulls/34"}},"in_reply_to_id":179519920},"pull_request":{"url":"https://api.github.com/repos/leoluk/configmaster/pulls/34","id":178720194,"html_url":"https://github.com/leoluk/configmaster/pull/34","diff_url":"https://github.com/leoluk/configmaster/pull/34.diff","patch_url":"https://github.com/leoluk/configmaster/pull/34.patch","issue_url":"https://api.github.com/repos/leoluk/configmaster/issues/34","number":34,"state":"open","locked":false,"title":"OpenShift development environment","user":{"login":"leoluk","id":859697,"avatar_url":"https://avatars1.githubusercontent.com/u/859697?v=4","gravatar_id":"","url":"https://api.github.com/users/leoluk","html_url":"https://github.com/leoluk","followers_url":"https://api.github.com/users/leoluk/followers","following_url":"https://api.github.com/users/leoluk/following{/other_user}","gists_url":"https://api.github.com/users/leoluk/gists{/gist_id}","starred_url":"https://api.github.com/users/leoluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoluk/subscriptions","organizations_url":"https://api.github.com/users/leoluk/orgs","repos_url":"https://api.github.com/users/leoluk/repos","events_url":"https://api.github.com/users/leoluk/events{/privacy}","received_events_url":"https://api.github.com/users/leoluk/received_events","type":"User","site_admin":false},"body":"Note: This pulls in mysqlclient, a python-mysqldb fork. It does not interfere with existing production setups, but the build dependencies for mysqlclient will have to be installed.\r\n\r\nAs discussed earlier, we don't want to depend on any distribution packages except for the interpreter (portability). This leaves us with only python-ldap.\r\n\r\nDebian 8 build dependencies for mysqlclient:\r\n\r\n - libmysqlclient-dev\r\n - python-dev\r\n\r\nWe'll need to fully migrate to mysqlclient for Python 3.","created_at":"2018-04-01T08:54:42Z","updated_at":"2018-04-06T09:59:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e07406e0e9a6551ebfd31dc41c17a7063077be2e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/leoluk/configmaster/pulls/34/commits","review_comments_url":"https://api.github.com/repos/leoluk/configmaster/pulls/34/comments","review_comment_url":"https://api.github.com/repos/leoluk/configmaster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leoluk/configmaster/issues/34/comments","statuses_url":"https://api.github.com/repos/leoluk/configmaster/statuses/100a0492a8b1625e97f49075dceef40bd862e456","head":{"label":"leoluk:openshift","ref":"openshift","sha":"100a0492a8b1625e97f49075dceef40bd862e456","user":{"login":"leoluk","id":859697,"avatar_url":"https://avatars1.githubusercontent.com/u/859697?v=4","gravatar_id":"","url":"https://api.github.com/users/leoluk","html_url":"https://github.com/leoluk","followers_url":"https://api.github.com/users/leoluk/followers","following_url":"https://api.github.com/users/leoluk/following{/other_user}","gists_url":"https://api.github.com/users/leoluk/gists{/gist_id}","starred_url":"https://api.github.com/users/leoluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoluk/subscriptions","organizations_url":"https://api.github.com/users/leoluk/orgs","repos_url":"https://api.github.com/users/leoluk/repos","events_url":"https://api.github.com/users/leoluk/events{/privacy}","received_events_url":"https://api.github.com/users/leoluk/received_events","type":"User","site_admin":false},"repo":{"id":96615252,"name":"configmaster","full_name":"leoluk/configmaster","owner":{"login":"leoluk","id":859697,"avatar_url":"https://avatars1.githubusercontent.com/u/859697?v=4","gravatar_id":"","url":"https://api.github.com/users/leoluk","html_url":"https://github.com/leoluk","followers_url":"https://api.github.com/users/leoluk/followers","following_url":"https://api.github.com/users/leoluk/following{/other_user}","gists_url":"https://api.github.com/users/leoluk/gists{/gist_id}","starred_url":"https://api.github.com/users/leoluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoluk/subscriptions","organizations_url":"https://api.github.com/users/leoluk/orgs","repos_url":"https://api.github.com/users/leoluk/repos","events_url":"https://api.github.com/users/leoluk/events{/privacy}","received_events_url":"https://api.github.com/users/leoluk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leoluk/configmaster","description":"Enterprise-grade network device config management.","fork":false,"url":"https://api.github.com/repos/leoluk/configmaster","forks_url":"https://api.github.com/repos/leoluk/configmaster/forks","keys_url":"https://api.github.com/repos/leoluk/configmaster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leoluk/configmaster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leoluk/configmaster/teams","hooks_url":"https://api.github.com/repos/leoluk/configmaster/hooks","issue_events_url":"https://api.github.com/repos/leoluk/configmaster/issues/events{/number}","events_url":"https://api.github.com/repos/leoluk/configmaster/events","assignees_url":"https://api.github.com/repos/leoluk/configmaster/assignees{/user}","branches_url":"https://api.github.com/repos/leoluk/configmaster/branches{/branch}","tags_url":"https://api.github.com/repos/leoluk/configmaster/tags","blobs_url":"https://api.github.com/repos/leoluk/configmaster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leoluk/configmaster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leoluk/configmaster/git/refs{/sha}","trees_url":"https://api.github.com/repos/leoluk/configmaster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leoluk/configmaster/statuses/{sha}","languages_url":"https://api.github.com/repos/leoluk/configmaster/languages","stargazers_url":"https://api.github.com/repos/leoluk/configmaster/stargazers","contributors_url":"https://api.github.com/repos/leoluk/configmaster/contributors","subscribers_url":"https://api.github.com/repos/leoluk/configmaster/subscribers","subscription_url":"https://api.github.com/repos/leoluk/configmaster/subscription","commits_url":"https://api.github.com/repos/leoluk/configmaster/commits{/sha}","git_commits_url":"https://api.github.com/repos/leoluk/configmaster/git/commits{/sha}","comments_url":"https://api.github.com/repos/leoluk/configmaster/comments{/number}","issue_comment_url":"https://api.github.com/repos/leoluk/configmaster/issues/comments{/number}","contents_url":"https://api.github.com/repos/leoluk/configmaster/contents/{+path}","compare_url":"https://api.github.com/repos/leoluk/configmaster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leoluk/configmaster/merges","archive_url":"https://api.github.com/repos/leoluk/configmaster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leoluk/configmaster/downloads","issues_url":"https://api.github.com/repos/leoluk/configmaster/issues{/number}","pulls_url":"https://api.github.com/repos/leoluk/configmaster/pulls{/number}","milestones_url":"https://api.github.com/repos/leoluk/configmaster/milestones{/number}","notifications_url":"https://api.github.com/repos/leoluk/configmaster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leoluk/configmaster/labels{/name}","releases_url":"https://api.github.com/repos/leoluk/configmaster/releases{/id}","deployments_url":"https://api.github.com/repos/leoluk/configmaster/deployments","created_at":"2017-07-08T11:37:58Z","updated_at":"2018-04-05T11:55:21Z","pushed_at":"2018-04-05T20:26:00Z","git_url":"git://github.com/leoluk/configmaster.git","ssh_url":"git@github.com:leoluk/configmaster.git","clone_url":"https://github.com/leoluk/configmaster.git","svn_url":"https://github.com/leoluk/configmaster","homepage":"","size":579,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":1,"open_issues":22,"watchers":1,"default_branch":"master"}},"base":{"label":"leoluk:master","ref":"master","sha":"f4a54caf02efb551c51ccbcaa71386d86e8c21db","user":{"login":"leoluk","id":859697,"avatar_url":"https://avatars1.githubusercontent.com/u/859697?v=4","gravatar_id":"","url":"https://api.github.com/users/leoluk","html_url":"https://github.com/leoluk","followers_url":"https://api.github.com/users/leoluk/followers","following_url":"https://api.github.com/users/leoluk/following{/other_user}","gists_url":"https://api.github.com/users/leoluk/gists{/gist_id}","starred_url":"https://api.github.com/users/leoluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoluk/subscriptions","organizations_url":"https://api.github.com/users/leoluk/orgs","repos_url":"https://api.github.com/users/leoluk/repos","events_url":"https://api.github.com/users/leoluk/events{/privacy}","received_events_url":"https://api.github.com/users/leoluk/received_events","type":"User","site_admin":false},"repo":{"id":96615252,"name":"configmaster","full_name":"leoluk/configmaster","owner":{"login":"leoluk","id":859697,"avatar_url":"https://avatars1.githubusercontent.com/u/859697?v=4","gravatar_id":"","url":"https://api.github.com/users/leoluk","html_url":"https://github.com/leoluk","followers_url":"https://api.github.com/users/leoluk/followers","following_url":"https://api.github.com/users/leoluk/following{/other_user}","gists_url":"https://api.github.com/users/leoluk/gists{/gist_id}","starred_url":"https://api.github.com/users/leoluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoluk/subscriptions","organizations_url":"https://api.github.com/users/leoluk/orgs","repos_url":"https://api.github.com/users/leoluk/repos","events_url":"https://api.github.com/users/leoluk/events{/privacy}","received_events_url":"https://api.github.com/users/leoluk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leoluk/configmaster","description":"Enterprise-grade network device config management.","fork":false,"url":"https://api.github.com/repos/leoluk/configmaster","forks_url":"https://api.github.com/repos/leoluk/configmaster/forks","keys_url":"https://api.github.com/repos/leoluk/configmaster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leoluk/configmaster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leoluk/configmaster/teams","hooks_url":"https://api.github.com/repos/leoluk/configmaster/hooks","issue_events_url":"https://api.github.com/repos/leoluk/configmaster/issues/events{/number}","events_url":"https://api.github.com/repos/leoluk/configmaster/events","assignees_url":"https://api.github.com/repos/leoluk/configmaster/assignees{/user}","branches_url":"https://api.github.com/repos/leoluk/configmaster/branches{/branch}","tags_url":"https://api.github.com/repos/leoluk/configmaster/tags","blobs_url":"https://api.github.com/repos/leoluk/configmaster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leoluk/configmaster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leoluk/configmaster/git/refs{/sha}","trees_url":"https://api.github.com/repos/leoluk/configmaster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leoluk/configmaster/statuses/{sha}","languages_url":"https://api.github.com/repos/leoluk/configmaster/languages","stargazers_url":"https://api.github.com/repos/leoluk/configmaster/stargazers","contributors_url":"https://api.github.com/repos/leoluk/configmaster/contributors","subscribers_url":"https://api.github.com/repos/leoluk/configmaster/subscribers","subscription_url":"https://api.github.com/repos/leoluk/configmaster/subscription","commits_url":"https://api.github.com/repos/leoluk/configmaster/commits{/sha}","git_commits_url":"https://api.github.com/repos/leoluk/configmaster/git/commits{/sha}","comments_url":"https://api.github.com/repos/leoluk/configmaster/comments{/number}","issue_comment_url":"https://api.github.com/repos/leoluk/configmaster/issues/comments{/number}","contents_url":"https://api.github.com/repos/leoluk/configmaster/contents/{+path}","compare_url":"https://api.github.com/repos/leoluk/configmaster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leoluk/configmaster/merges","archive_url":"https://api.github.com/repos/leoluk/configmaster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leoluk/configmaster/downloads","issues_url":"https://api.github.com/repos/leoluk/configmaster/issues{/number}","pulls_url":"https://api.github.com/repos/leoluk/configmaster/pulls{/number}","milestones_url":"https://api.github.com/repos/leoluk/configmaster/milestones{/number}","notifications_url":"https://api.github.com/repos/leoluk/configmaster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leoluk/configmaster/labels{/name}","releases_url":"https://api.github.com/repos/leoluk/configmaster/releases{/id}","deployments_url":"https://api.github.com/repos/leoluk/configmaster/deployments","created_at":"2017-07-08T11:37:58Z","updated_at":"2018-04-05T11:55:21Z","pushed_at":"2018-04-05T20:26:00Z","git_url":"git://github.com/leoluk/configmaster.git","ssh_url":"git@github.com:leoluk/configmaster.git","clone_url":"https://github.com/leoluk/configmaster.git","svn_url":"https://github.com/leoluk/configmaster","homepage":"","size":579,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":1,"open_issues":22,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leoluk/configmaster/pulls/34"},"html":{"href":"https://github.com/leoluk/configmaster/pull/34"},"issue":{"href":"https://api.github.com/repos/leoluk/configmaster/issues/34"},"comments":{"href":"https://api.github.com/repos/leoluk/configmaster/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/leoluk/configmaster/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/leoluk/configmaster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leoluk/configmaster/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/leoluk/configmaster/statuses/100a0492a8b1625e97f49075dceef40bd862e456"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Alexander-N"}}