{"action":"created","comment":{"url":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/comments/214896708","pull_request_review_id":152044180,"id":214896708,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDg5NjcwOA==","diff_hunk":"@@ -0,0 +1,40 @@\n+/**\n+ * @file\n+ * Bootstrap dropdown on search and inline search.\n+ */\n+\n+(function ($, Drupal) {\n+  Drupal.behaviors.cdSearchInline = {\n+    attach: function (context, settings) {\n+      $(document).ready(function(){\n+\n+        // Apply focus to input when dropdown is shown.\n+        $('.cd-search--inline').on('shown.bs.dropdown', function () {\n+          $(this).find('#edit-search-api-views-fulltext').focus();\n+        });\n+\n+        $('.cd-search--inline').on('hidden.bs.dropdown', function () {\n+          $(this).find('#edit-search-api-views-fulltext').blur();\n+        });\n+\n+        // Add class on submit button when input has focus.\n+        $('.cd-search--inline .cd-search--inline__input').on('focus', function(e) {\n+          $(this).parents().find('.cd-search--inline__submit').addClass('js-has-focus');\n+        });\n+\n+        $('.cd-search--inline .cd-search--inline__input').on('blur', function(e) {\n+          $(this).parents().find('.cd-search--inline__submit').removeClass('js-has-focus');\n+        });\n+\n+        $('.cd-search--inline .cd-search--inline__input').on('focus', function(e){\n+          $(this).parents().addClass('js-has-focus');\n+        });\n+\n+        $('.cd-search--inline .cd-search--inline__input').on('blur', function(e){\n+          $(this).parents().removeClass('js-has-focus');\n+        });","path":"js/custom-search--inline.js","position":35,"original_position":35,"commit_id":"d3d92f81e7162ad4e2eaec31466724dfd59216d7","original_commit_id":"bb9b79fbc34b7264bb21a79467b75a5e2982b257","user":{"login":"left23","id":1835923,"node_id":"MDQ6VXNlcjE4MzU5MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1835923?v=4","gravatar_id":"","url":"https://api.github.com/users/left23","html_url":"https://github.com/left23","followers_url":"https://api.github.com/users/left23/followers","following_url":"https://api.github.com/users/left23/following{/other_user}","gists_url":"https://api.github.com/users/left23/gists{/gist_id}","starred_url":"https://api.github.com/users/left23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/left23/subscriptions","organizations_url":"https://api.github.com/users/left23/orgs","repos_url":"https://api.github.com/users/left23/repos","events_url":"https://api.github.com/users/left23/events{/privacy}","received_events_url":"https://api.github.com/users/left23/received_events","type":"User","site_admin":false},"body":"Yes, thanks!","created_at":"2018-09-04T12:38:08Z","updated_at":"2018-09-04T12:38:08Z","html_url":"https://github.com/UN-OCHA/ocha_basic/pull/48#discussion_r214896708","pull_request_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/48","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/comments/214896708"},"html":{"href":"https://github.com/UN-OCHA/ocha_basic/pull/48#discussion_r214896708"},"pull_request":{"href":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/48"}},"in_reply_to_id":214689953},"pull_request":{"url":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/48","id":212033584,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDMzNTg0","html_url":"https://github.com/UN-OCHA/ocha_basic/pull/48","diff_url":"https://github.com/UN-OCHA/ocha_basic/pull/48.diff","patch_url":"https://github.com/UN-OCHA/ocha_basic/pull/48.patch","issue_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/issues/48","number":48,"state":"closed","locked":false,"title":"CD-61 inline search","user":{"login":"left23","id":1835923,"node_id":"MDQ6VXNlcjE4MzU5MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1835923?v=4","gravatar_id":"","url":"https://api.github.com/users/left23","html_url":"https://github.com/left23","followers_url":"https://api.github.com/users/left23/followers","following_url":"https://api.github.com/users/left23/following{/other_user}","gists_url":"https://api.github.com/users/left23/gists{/gist_id}","starred_url":"https://api.github.com/users/left23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/left23/subscriptions","organizations_url":"https://api.github.com/users/left23/orgs","repos_url":"https://api.github.com/users/left23/repos","events_url":"https://api.github.com/users/left23/events{/privacy}","received_events_url":"https://api.github.com/users/left23/received_events","type":"User","site_admin":false},"body":"Start here: https://github.com/UN-OCHA/ocha-basic-site/pull/7  **necessary config**\r\n\r\nInline search variant as displayed here:\r\nhttps://ochabasic.dev.ahconu.org/inline-search\r\nThis is a views exposed form. I've created a variable based on the path alias which I use to print the correct template include  ~(and I am already noticing a PHP warning about it being undefined)~\r\n\r\nI'm open to suggestion how best to create the search variant. As I mentioned before, the 3 implementations  I've done to date used a Views exposed form so I think it's helpful to have something to this effect prepared in code.\r\n\r\nI also added the soft footer variant as a region. The context associated with it is in the ocha-basic-site PR and it needs content on dev to work.\r\n\r\nI've enabled some of the \"component\" partials and commented out the typography rules that mess with what we have already defined for the header/footer. This should mean the content area has CD styles now.\r\n\r\nI've tweaked the menu JS so child menu items are now clickable.\r\n\r\nI uncommented the :first-child user menu item rule to demo the +Add content menu item\r\n\r\nI added text color to hover for ocha service menu links because the global anchor styles made them dark blue on dark blue background.\r\n\r\nI've added a few subdirectories in tpl folder for blocks and views because the amount of Drupal template overrides is increasing.\r\n\r\n### To test\r\nAfter pulling, clear cache due to template override rearranging","created_at":"2018-08-30T10:40:10Z","updated_at":"2018-09-04T12:38:08Z","closed_at":"2018-09-03T15:45:54Z","merged_at":"2018-09-03T15:45:54Z","merge_commit_sha":"348047931094f75950c02bbdf39b45f08d40cf35","assignee":{"login":"left23","id":1835923,"node_id":"MDQ6VXNlcjE4MzU5MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1835923?v=4","gravatar_id":"","url":"https://api.github.com/users/left23","html_url":"https://github.com/left23","followers_url":"https://api.github.com/users/left23/followers","following_url":"https://api.github.com/users/left23/following{/other_user}","gists_url":"https://api.github.com/users/left23/gists{/gist_id}","starred_url":"https://api.github.com/users/left23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/left23/subscriptions","organizations_url":"https://api.github.com/users/left23/orgs","repos_url":"https://api.github.com/users/left23/repos","events_url":"https://api.github.com/users/left23/events{/privacy}","received_events_url":"https://api.github.com/users/left23/received_events","type":"User","site_admin":false},"assignees":[{"login":"left23","id":1835923,"node_id":"MDQ6VXNlcjE4MzU5MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1835923?v=4","gravatar_id":"","url":"https://api.github.com/users/left23","html_url":"https://github.com/left23","followers_url":"https://api.github.com/users/left23/followers","following_url":"https://api.github.com/users/left23/following{/other_user}","gists_url":"https://api.github.com/users/left23/gists{/gist_id}","starred_url":"https://api.github.com/users/left23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/left23/subscriptions","organizations_url":"https://api.github.com/users/left23/orgs","repos_url":"https://api.github.com/users/left23/repos","events_url":"https://api.github.com/users/left23/events{/privacy}","received_events_url":"https://api.github.com/users/left23/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/48/commits","review_comments_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/48/comments","review_comment_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/issues/48/comments","statuses_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/statuses/d3d92f81e7162ad4e2eaec31466724dfd59216d7","head":{"label":"UN-OCHA:cd-61-inline-search","ref":"cd-61-inline-search","sha":"d3d92f81e7162ad4e2eaec31466724dfd59216d7","user":{"login":"UN-OCHA","id":7985843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5ODU4NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7985843?v=4","gravatar_id":"","url":"https://api.github.com/users/UN-OCHA","html_url":"https://github.com/UN-OCHA","followers_url":"https://api.github.com/users/UN-OCHA/followers","following_url":"https://api.github.com/users/UN-OCHA/following{/other_user}","gists_url":"https://api.github.com/users/UN-OCHA/gists{/gist_id}","starred_url":"https://api.github.com/users/UN-OCHA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UN-OCHA/subscriptions","organizations_url":"https://api.github.com/users/UN-OCHA/orgs","repos_url":"https://api.github.com/users/UN-OCHA/repos","events_url":"https://api.github.com/users/UN-OCHA/events{/privacy}","received_events_url":"https://api.github.com/users/UN-OCHA/received_events","type":"Organization","site_admin":false},"repo":{"id":100573804,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1NzM4MDQ=","name":"ocha_basic","full_name":"UN-OCHA/ocha_basic","owner":{"login":"UN-OCHA","id":7985843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5ODU4NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7985843?v=4","gravatar_id":"","url":"https://api.github.com/users/UN-OCHA","html_url":"https://github.com/UN-OCHA","followers_url":"https://api.github.com/users/UN-OCHA/followers","following_url":"https://api.github.com/users/UN-OCHA/following{/other_user}","gists_url":"https://api.github.com/users/UN-OCHA/gists{/gist_id}","starred_url":"https://api.github.com/users/UN-OCHA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UN-OCHA/subscriptions","organizations_url":"https://api.github.com/users/UN-OCHA/orgs","repos_url":"https://api.github.com/users/UN-OCHA/repos","events_url":"https://api.github.com/users/UN-OCHA/events{/privacy}","received_events_url":"https://api.github.com/users/UN-OCHA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UN-OCHA/ocha_basic","description":"OCHA Basic Drupal theme starterkit","fork":false,"url":"https://api.github.com/repos/UN-OCHA/ocha_basic","forks_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/forks","keys_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/teams","hooks_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/hooks","issue_events_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/issues/events{/number}","events_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/events","assignees_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/assignees{/user}","branches_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/branches{/branch}","tags_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/tags","blobs_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/git/refs{/sha}","trees_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/statuses/{sha}","languages_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/languages","stargazers_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/stargazers","contributors_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/contributors","subscribers_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/subscribers","subscription_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/subscription","commits_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/commits{/sha}","git_commits_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/git/commits{/sha}","comments_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/comments{/number}","issue_comment_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/issues/comments{/number}","contents_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/contents/{+path}","compare_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/merges","archive_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/downloads","issues_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/issues{/number}","pulls_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls{/number}","milestones_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/milestones{/number}","notifications_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/labels{/name}","releases_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/releases{/id}","deployments_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/deployments","created_at":"2017-08-17T07:19:20Z","updated_at":"2018-09-04T12:16:13Z","pushed_at":"2018-09-04T12:37:27Z","git_url":"git://github.com/UN-OCHA/ocha_basic.git","ssh_url":"git@github.com:UN-OCHA/ocha_basic.git","clone_url":"https://github.com/UN-OCHA/ocha_basic.git","svn_url":"https://github.com/UN-OCHA/ocha_basic","homepage":"","size":1447,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"UN-OCHA:master","ref":"master","sha":"85b44dae33e94548bb5c6009809821ccd4d30c28","user":{"login":"UN-OCHA","id":7985843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5ODU4NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7985843?v=4","gravatar_id":"","url":"https://api.github.com/users/UN-OCHA","html_url":"https://github.com/UN-OCHA","followers_url":"https://api.github.com/users/UN-OCHA/followers","following_url":"https://api.github.com/users/UN-OCHA/following{/other_user}","gists_url":"https://api.github.com/users/UN-OCHA/gists{/gist_id}","starred_url":"https://api.github.com/users/UN-OCHA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UN-OCHA/subscriptions","organizations_url":"https://api.github.com/users/UN-OCHA/orgs","repos_url":"https://api.github.com/users/UN-OCHA/repos","events_url":"https://api.github.com/users/UN-OCHA/events{/privacy}","received_events_url":"https://api.github.com/users/UN-OCHA/received_events","type":"Organization","site_admin":false},"repo":{"id":100573804,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1NzM4MDQ=","name":"ocha_basic","full_name":"UN-OCHA/ocha_basic","owner":{"login":"UN-OCHA","id":7985843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5ODU4NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7985843?v=4","gravatar_id":"","url":"https://api.github.com/users/UN-OCHA","html_url":"https://github.com/UN-OCHA","followers_url":"https://api.github.com/users/UN-OCHA/followers","following_url":"https://api.github.com/users/UN-OCHA/following{/other_user}","gists_url":"https://api.github.com/users/UN-OCHA/gists{/gist_id}","starred_url":"https://api.github.com/users/UN-OCHA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UN-OCHA/subscriptions","organizations_url":"https://api.github.com/users/UN-OCHA/orgs","repos_url":"https://api.github.com/users/UN-OCHA/repos","events_url":"https://api.github.com/users/UN-OCHA/events{/privacy}","received_events_url":"https://api.github.com/users/UN-OCHA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UN-OCHA/ocha_basic","description":"OCHA Basic Drupal theme starterkit","fork":false,"url":"https://api.github.com/repos/UN-OCHA/ocha_basic","forks_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/forks","keys_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/teams","hooks_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/hooks","issue_events_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/issues/events{/number}","events_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/events","assignees_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/assignees{/user}","branches_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/branches{/branch}","tags_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/tags","blobs_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/git/refs{/sha}","trees_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/statuses/{sha}","languages_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/languages","stargazers_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/stargazers","contributors_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/contributors","subscribers_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/subscribers","subscription_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/subscription","commits_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/commits{/sha}","git_commits_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/git/commits{/sha}","comments_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/comments{/number}","issue_comment_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/issues/comments{/number}","contents_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/contents/{+path}","compare_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/merges","archive_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/downloads","issues_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/issues{/number}","pulls_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls{/number}","milestones_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/milestones{/number}","notifications_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/labels{/name}","releases_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/releases{/id}","deployments_url":"https://api.github.com/repos/UN-OCHA/ocha_basic/deployments","created_at":"2017-08-17T07:19:20Z","updated_at":"2018-09-04T12:16:13Z","pushed_at":"2018-09-04T12:37:27Z","git_url":"git://github.com/UN-OCHA/ocha_basic.git","ssh_url":"git@github.com:UN-OCHA/ocha_basic.git","clone_url":"https://github.com/UN-OCHA/ocha_basic.git","svn_url":"https://github.com/UN-OCHA/ocha_basic","homepage":"","size":1447,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/48"},"html":{"href":"https://github.com/UN-OCHA/ocha_basic/pull/48"},"issue":{"href":"https://api.github.com/repos/UN-OCHA/ocha_basic/issues/48"},"comments":{"href":"https://api.github.com/repos/UN-OCHA/ocha_basic/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UN-OCHA/ocha_basic/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/UN-OCHA/ocha_basic/statuses/d3d92f81e7162ad4e2eaec31466724dfd59216d7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"left23"}}