{"action":"created","issue":{"url":"https://api.github.com/repos/sardana-org/sardana/issues/592","repository_url":"https://api.github.com/repos/sardana-org/sardana","labels_url":"https://api.github.com/repos/sardana-org/sardana/issues/592/labels{/name}","comments_url":"https://api.github.com/repos/sardana-org/sardana/issues/592/comments","events_url":"https://api.github.com/repos/sardana-org/sardana/issues/592/events","html_url":"https://github.com/sardana-org/sardana/pull/592","id":256228221,"number":592,"title":"New Stop and Abort algorithms (issue 157)","user":{"login":"guifrecuni","id":1969955,"avatar_url":"https://avatars0.githubusercontent.com/u/1969955?v=4","gravatar_id":"","url":"https://api.github.com/users/guifrecuni","html_url":"https://github.com/guifrecuni","followers_url":"https://api.github.com/users/guifrecuni/followers","following_url":"https://api.github.com/users/guifrecuni/following{/other_user}","gists_url":"https://api.github.com/users/guifrecuni/gists{/gist_id}","starred_url":"https://api.github.com/users/guifrecuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guifrecuni/subscriptions","organizations_url":"https://api.github.com/users/guifrecuni/orgs","repos_url":"https://api.github.com/users/guifrecuni/repos","events_url":"https://api.github.com/users/guifrecuni/events{/privacy}","received_events_url":"https://api.github.com/users/guifrecuni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/sardana-org/sardana/milestones/3","html_url":"https://github.com/sardana-org/sardana/milestone/3","labels_url":"https://api.github.com/repos/sardana-org/sardana/milestones/3/labels","id":2627593,"number":3,"title":"Jan18","description":"","creator":{"login":"reszelaz","id":6735649,"avatar_url":"https://avatars1.githubusercontent.com/u/6735649?v=4","gravatar_id":"","url":"https://api.github.com/users/reszelaz","html_url":"https://github.com/reszelaz","followers_url":"https://api.github.com/users/reszelaz/followers","following_url":"https://api.github.com/users/reszelaz/following{/other_user}","gists_url":"https://api.github.com/users/reszelaz/gists{/gist_id}","starred_url":"https://api.github.com/users/reszelaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reszelaz/subscriptions","organizations_url":"https://api.github.com/users/reszelaz/orgs","repos_url":"https://api.github.com/users/reszelaz/repos","events_url":"https://api.github.com/users/reszelaz/events{/privacy}","received_events_url":"https://api.github.com/users/reszelaz/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":62,"state":"open","created_at":"2017-07-07T13:23:28Z","updated_at":"2018-02-07T11:26:41Z","due_on":"2018-01-31T08:00:00Z","closed_at":null},"comments":3,"created_at":"2017-09-08T11:44:12Z","updated_at":"2018-02-08T16:39:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sardana-org/sardana/pulls/592","html_url":"https://github.com/sardana-org/sardana/pull/592","diff_url":"https://github.com/sardana-org/sardana/pull/592.diff","patch_url":"https://github.com/sardana-org/sardana/pull/592.patch"},"body":"Hi, this PR should fix issue #157 \r\n"},"comment":{"url":"https://api.github.com/repos/sardana-org/sardana/issues/comments/364171051","html_url":"https://github.com/sardana-org/sardana/pull/592#issuecomment-364171051","issue_url":"https://api.github.com/repos/sardana-org/sardana/issues/592","id":364171051,"user":{"login":"reszelaz","id":6735649,"avatar_url":"https://avatars1.githubusercontent.com/u/6735649?v=4","gravatar_id":"","url":"https://api.github.com/users/reszelaz","html_url":"https://github.com/reszelaz","followers_url":"https://api.github.com/users/reszelaz/followers","following_url":"https://api.github.com/users/reszelaz/following{/other_user}","gists_url":"https://api.github.com/users/reszelaz/gists{/gist_id}","starred_url":"https://api.github.com/users/reszelaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reszelaz/subscriptions","organizations_url":"https://api.github.com/users/reszelaz/orgs","repos_url":"https://api.github.com/users/reszelaz/repos","events_url":"https://api.github.com/users/reszelaz/events{/privacy}","received_events_url":"https://api.github.com/users/reszelaz/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T16:39:53Z","updated_at":"2018-02-08T16:39:53Z","author_association":"COLLABORATOR","body":"> we think that the stop_elements method should handle possible errors in the controller's code.\r\n\r\nYes, I've checked that and in the develop branch it behaves correctly. If, for example, the `StopOne` method fails on one axis, the rest of the axes are tried to be stopped.\r\n\r\nWhat is currently not optimal is that this failures are not notified to the user. So for example, if the user issued `Ctrl+C` in spock and one axis could not be stopped due to an exception in the `StopOne` method the user does not know about it. He just sees:\r\n\r\n```\r\nDoor_zreszela_1 [9]: mv mot01 1000 mot02 1000\r\n^C\r\nCtrl-C received: Stopping... Done!\r\n```\r\nbut the motor continuous to move. But I think we could treat it in another feature. "}}
{"actor":{"display_login":"reszelaz"}}