{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/223359987","pull_request_review_id":162465828,"id":223359987,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzM1OTk4Nw==","diff_hunk":"@@ -2867,49 +2868,69 @@ def power_transform(X, method='box-cox', standardize=True, copy=True):\n     X : array-like, shape (n_samples, n_features)\n         The data to be transformed using a power transformation.\n \n-    method : str, (default='box-cox')\n-        The power transform method. Currently, 'box-cox' (Box-Cox transform)\n-        is the only option available.\n+    method : str, (default='warn')\n+        The power transform method. Available methods are:\n+\n+        - 'yeo-johnson' [1]_, works with positive and negative values\n+        - 'box-cox' [2]_, only works with strictly positive values\n \n     standardize : boolean, default=True\n         Set to True to apply zero-mean, unit-variance normalization to the\n         transformed output.\n \n     copy : boolean, optional, default=True\n-        Set to False to perform inplace computation.\n+        Set to False to perform inplace computation during transformation.\n+\n+    Returns\n+    -------\n+        X_trans : array-like, shape (n_samples, n_features)","path":"sklearn/preprocessing/data.py","position":70,"original_position":70,"commit_id":"4ac4b07f81a939e3be02ca757097241041767b4d","original_commit_id":"4ac4b07f81a939e3be02ca757097241041767b4d","user":{"login":"jnothman","id":78827,"node_id":"MDQ6VXNlcjc4ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/78827?v=4","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"body":"dedent","created_at":"2018-10-08T13:19:50Z","updated_at":"2018-10-08T13:20:15Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12317#discussion_r223359987","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12317","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/223359987"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12317#discussion_r223359987"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12317"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12317","id":220938877,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTM4ODc3","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12317","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/12317.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/12317.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12317","number":12317,"state":"open","locked":false,"title":"[MRG] FIX Update power_transform docstring and add FutureWarning","user":{"login":"chang","id":16146623,"node_id":"MDQ6VXNlcjE2MTQ2NjIz","avatar_url":"https://avatars0.githubusercontent.com/u/16146623?v=4","gravatar_id":"","url":"https://api.github.com/users/chang","html_url":"https://github.com/chang","followers_url":"https://api.github.com/users/chang/followers","following_url":"https://api.github.com/users/chang/following{/other_user}","gists_url":"https://api.github.com/users/chang/gists{/gist_id}","starred_url":"https://api.github.com/users/chang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chang/subscriptions","organizations_url":"https://api.github.com/users/chang/orgs","repos_url":"https://api.github.com/users/chang/repos","events_url":"https://api.github.com/users/chang/events{/privacy}","received_events_url":"https://api.github.com/users/chang/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist\r\n-->\r\n\r\n#### Reference Issues/PRs\r\n<!--\r\nExample: Fixes #1234. See also #3456.\r\nPlease use keywords (e.g., Fixes) to create link to the issues or pull requests\r\nyou resolved, so that they will automatically be closed when your pull request\r\nis merged. See https://github.com/blog/1506-closing-issues-via-pull-requests\r\n-->\r\n\r\nhttps://github.com/scikit-learn/scikit-learn/pull/11520\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n\r\nLooks like the function version of `PowerTransformer` wasn't updated when Yeo-Johnson was added. Just matching the defaults and updating the docstring with this PR. Congrats on the 0.20 release!!\r\n\r\n#### Any other comments?\r\n\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n","created_at":"2018-10-07T10:13:33Z","updated_at":"2018-10-08T13:20:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5966d8e75d906bcd400a8a279a9141c07c0fb2ba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12317/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12317/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12317/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/4ac4b07f81a939e3be02ca757097241041767b4d","head":{"label":"chang:power-transform-default","ref":"power-transform-default","sha":"4ac4b07f81a939e3be02ca757097241041767b4d","user":{"login":"chang","id":16146623,"node_id":"MDQ6VXNlcjE2MTQ2NjIz","avatar_url":"https://avatars0.githubusercontent.com/u/16146623?v=4","gravatar_id":"","url":"https://api.github.com/users/chang","html_url":"https://github.com/chang","followers_url":"https://api.github.com/users/chang/followers","following_url":"https://api.github.com/users/chang/following{/other_user}","gists_url":"https://api.github.com/users/chang/gists{/gist_id}","starred_url":"https://api.github.com/users/chang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chang/subscriptions","organizations_url":"https://api.github.com/users/chang/orgs","repos_url":"https://api.github.com/users/chang/repos","events_url":"https://api.github.com/users/chang/events{/privacy}","received_events_url":"https://api.github.com/users/chang/received_events","type":"User","site_admin":false},"repo":{"id":111502246,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE1MDIyNDY=","name":"scikit-learn","full_name":"chang/scikit-learn","private":false,"owner":{"login":"chang","id":16146623,"node_id":"MDQ6VXNlcjE2MTQ2NjIz","avatar_url":"https://avatars0.githubusercontent.com/u/16146623?v=4","gravatar_id":"","url":"https://api.github.com/users/chang","html_url":"https://github.com/chang","followers_url":"https://api.github.com/users/chang/followers","following_url":"https://api.github.com/users/chang/following{/other_user}","gists_url":"https://api.github.com/users/chang/gists{/gist_id}","starred_url":"https://api.github.com/users/chang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chang/subscriptions","organizations_url":"https://api.github.com/users/chang/orgs","repos_url":"https://api.github.com/users/chang/repos","events_url":"https://api.github.com/users/chang/events{/privacy}","received_events_url":"https://api.github.com/users/chang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chang/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/chang/scikit-learn","forks_url":"https://api.github.com/repos/chang/scikit-learn/forks","keys_url":"https://api.github.com/repos/chang/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chang/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chang/scikit-learn/teams","hooks_url":"https://api.github.com/repos/chang/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/chang/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/chang/scikit-learn/events","assignees_url":"https://api.github.com/repos/chang/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/chang/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/chang/scikit-learn/tags","blobs_url":"https://api.github.com/repos/chang/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chang/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chang/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/chang/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chang/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/chang/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/chang/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/chang/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/chang/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/chang/scikit-learn/subscription","commits_url":"https://api.github.com/repos/chang/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/chang/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/chang/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/chang/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/chang/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/chang/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chang/scikit-learn/merges","archive_url":"https://api.github.com/repos/chang/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chang/scikit-learn/downloads","issues_url":"https://api.github.com/repos/chang/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/chang/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/chang/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/chang/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chang/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/chang/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/chang/scikit-learn/deployments","created_at":"2017-11-21T05:09:04Z","updated_at":"2017-11-21T05:09:14Z","pushed_at":"2018-10-08T08:53:12Z","git_url":"git://github.com/chang/scikit-learn.git","ssh_url":"git@github.com:chang/scikit-learn.git","clone_url":"https://github.com/chang/scikit-learn.git","svn_url":"https://github.com/chang/scikit-learn","homepage":"http://scikit-learn.org","size":94688,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"63e5ae6319285c44b1a9519aa6acd9006c82a10a","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","private":false,"owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-10-08T13:11:48Z","pushed_at":"2018-10-08T13:14:36Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":95419,"stargazers_count":30949,"watchers_count":30949,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15306,"mirror_url":null,"archived":false,"open_issues_count":1762,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15306,"open_issues":1762,"watchers":30949,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12317"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12317"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12317"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12317/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12317/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12317/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/4ac4b07f81a939e3be02ca757097241041767b4d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jnothman"}}