{"action":"created","comment":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/195071680","pull_request_review_id":128364075,"id":195071680,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTA3MTY4MA==","diff_hunk":"@@ -73,6 +73,7 @@\n         'fmt_console': log_config['formatters']['console']['format'],\n         'fmt_logfile': log_config['formatters']['file']['format'],\n         'granular_levels': {},\n+        'benchmark': False","path":"bigchaindb/__init__.py","position":4,"original_position":4,"commit_id":"327ff9111082f2056fecdb6db5dd962b9fd419cf","original_commit_id":"327ff9111082f2056fecdb6db5dd962b9fd419cf","user":{"login":"kansi","id":4709940,"node_id":"MDQ6VXNlcjQ3MDk5NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4709940?v=4","gravatar_id":"","url":"https://api.github.com/users/kansi","html_url":"https://github.com/kansi","followers_url":"https://api.github.com/users/kansi/followers","following_url":"https://api.github.com/users/kansi/following{/other_user}","gists_url":"https://api.github.com/users/kansi/gists{/gist_id}","starred_url":"https://api.github.com/users/kansi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kansi/subscriptions","organizations_url":"https://api.github.com/users/kansi/orgs","repos_url":"https://api.github.com/users/kansi/repos","events_url":"https://api.github.com/users/kansi/events{/privacy}","received_events_url":"https://api.github.com/users/kansi/received_events","type":"User","site_admin":false},"body":"Instead of having a flag to enable benchmark it would be better to enable it via log level instead i.e. something as following\r\n\r\n```\r\n    \"level_logfile\": \"benchmark\",\r\n```\r\n","created_at":"2018-06-13T13:02:01Z","updated_at":"2018-06-13T13:02:01Z","html_url":"https://github.com/bigchaindb/bigchaindb/pull/2349#discussion_r195071680","pull_request_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2349","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/195071680"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/2349#discussion_r195071680"},"pull_request":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2349"}}},"pull_request":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2349","id":194559733,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTU5NzMz","html_url":"https://github.com/bigchaindb/bigchaindb/pull/2349","diff_url":"https://github.com/bigchaindb/bigchaindb/pull/2349.diff","patch_url":"https://github.com/bigchaindb/bigchaindb/pull/2349.patch","issue_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/2349","number":2349,"state":"open","locked":false,"title":"Problem: There is no logging for benchmark stats","user":{"login":"shahbazn","id":4792791,"node_id":"MDQ6VXNlcjQ3OTI3OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4792791?v=4","gravatar_id":"","url":"https://api.github.com/users/shahbazn","html_url":"https://github.com/shahbazn","followers_url":"https://api.github.com/users/shahbazn/followers","following_url":"https://api.github.com/users/shahbazn/following{/other_user}","gists_url":"https://api.github.com/users/shahbazn/gists{/gist_id}","starred_url":"https://api.github.com/users/shahbazn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahbazn/subscriptions","organizations_url":"https://api.github.com/users/shahbazn/orgs","repos_url":"https://api.github.com/users/shahbazn/repos","events_url":"https://api.github.com/users/shahbazn/events{/privacy}","received_events_url":"https://api.github.com/users/shahbazn/received_events","type":"User","site_admin":false},"body":"Solution: Add a new log handler to capture benchmark stats to a separate file.","created_at":"2018-06-13T11:49:30Z","updated_at":"2018-06-13T13:02:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12029048ad2d582b6fd1746f30418b5c85e1d8c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2349/commits","review_comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2349/comments","review_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/2349/comments","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/327ff9111082f2056fecdb6db5dd962b9fd419cf","head":{"label":"shahbazn:benchmark_logger","ref":"benchmark_logger","sha":"327ff9111082f2056fecdb6db5dd962b9fd419cf","user":{"login":"shahbazn","id":4792791,"node_id":"MDQ6VXNlcjQ3OTI3OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4792791?v=4","gravatar_id":"","url":"https://api.github.com/users/shahbazn","html_url":"https://github.com/shahbazn","followers_url":"https://api.github.com/users/shahbazn/followers","following_url":"https://api.github.com/users/shahbazn/following{/other_user}","gists_url":"https://api.github.com/users/shahbazn/gists{/gist_id}","starred_url":"https://api.github.com/users/shahbazn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahbazn/subscriptions","organizations_url":"https://api.github.com/users/shahbazn/orgs","repos_url":"https://api.github.com/users/shahbazn/repos","events_url":"https://api.github.com/users/shahbazn/events{/privacy}","received_events_url":"https://api.github.com/users/shahbazn/received_events","type":"User","site_admin":false},"repo":{"id":122178616,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIxNzg2MTY=","name":"bigchaindb","full_name":"shahbazn/bigchaindb","owner":{"login":"shahbazn","id":4792791,"node_id":"MDQ6VXNlcjQ3OTI3OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4792791?v=4","gravatar_id":"","url":"https://api.github.com/users/shahbazn","html_url":"https://github.com/shahbazn","followers_url":"https://api.github.com/users/shahbazn/followers","following_url":"https://api.github.com/users/shahbazn/following{/other_user}","gists_url":"https://api.github.com/users/shahbazn/gists{/gist_id}","starred_url":"https://api.github.com/users/shahbazn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahbazn/subscriptions","organizations_url":"https://api.github.com/users/shahbazn/orgs","repos_url":"https://api.github.com/users/shahbazn/repos","events_url":"https://api.github.com/users/shahbazn/events{/privacy}","received_events_url":"https://api.github.com/users/shahbazn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shahbazn/bigchaindb","description":"Meet BigchainDB. The blockchain database.","fork":true,"url":"https://api.github.com/repos/shahbazn/bigchaindb","forks_url":"https://api.github.com/repos/shahbazn/bigchaindb/forks","keys_url":"https://api.github.com/repos/shahbazn/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shahbazn/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shahbazn/bigchaindb/teams","hooks_url":"https://api.github.com/repos/shahbazn/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/shahbazn/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/shahbazn/bigchaindb/events","assignees_url":"https://api.github.com/repos/shahbazn/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/shahbazn/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/shahbazn/bigchaindb/tags","blobs_url":"https://api.github.com/repos/shahbazn/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shahbazn/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shahbazn/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/shahbazn/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shahbazn/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/shahbazn/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/shahbazn/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/shahbazn/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/shahbazn/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/shahbazn/bigchaindb/subscription","commits_url":"https://api.github.com/repos/shahbazn/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/shahbazn/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/shahbazn/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/shahbazn/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/shahbazn/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/shahbazn/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shahbazn/bigchaindb/merges","archive_url":"https://api.github.com/repos/shahbazn/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shahbazn/bigchaindb/downloads","issues_url":"https://api.github.com/repos/shahbazn/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/shahbazn/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/shahbazn/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/shahbazn/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shahbazn/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/shahbazn/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/shahbazn/bigchaindb/deployments","created_at":"2018-02-20T09:35:29Z","updated_at":"2018-04-23T11:56:24Z","pushed_at":"2018-06-13T11:52:44Z","git_url":"git://github.com/shahbazn/bigchaindb.git","ssh_url":"git@github.com:shahbazn/bigchaindb.git","clone_url":"https://github.com/shahbazn/bigchaindb.git","svn_url":"https://github.com/shahbazn/bigchaindb","homepage":"https://www.bigchaindb.com/","size":9952,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigchaindb:master","ref":"master","sha":"6b5fe1903689bae3bf9aacfd86d3af712995fefd","user":{"login":"bigchaindb","id":17097586,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDk3NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/17097586?v=4","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":51290852,"node_id":"MDEwOlJlcG9zaXRvcnk1MTI5MDg1Mg==","name":"bigchaindb","full_name":"bigchaindb/bigchaindb","owner":{"login":"bigchaindb","id":17097586,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDk3NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/17097586?v=4","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/bigchaindb","description":"Meet BigchainDB. The blockchain database.","fork":false,"url":"https://api.github.com/repos/bigchaindb/bigchaindb","forks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/forks","keys_url":"https://api.github.com/repos/bigchaindb/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/bigchaindb/teams","hooks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/events","assignees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/tags","blobs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscription","commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/bigchaindb/merges","archive_url":"https://api.github.com/repos/bigchaindb/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/bigchaindb/downloads","issues_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/deployments","created_at":"2016-02-08T10:12:58Z","updated_at":"2018-06-12T09:40:18Z","pushed_at":"2018-06-13T11:52:45Z","git_url":"git://github.com/bigchaindb/bigchaindb.git","ssh_url":"git@github.com:bigchaindb/bigchaindb.git","clone_url":"https://github.com/bigchaindb/bigchaindb.git","svn_url":"https://github.com/bigchaindb/bigchaindb","homepage":"https://www.bigchaindb.com/","size":9094,"stargazers_count":2616,"watchers_count":2616,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":505,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":505,"open_issues":154,"watchers":2616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2349"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/2349"},"issue":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/2349"},"comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/2349/comments"},"review_comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2349/comments"},"review_comment":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/2349/commits"},"statuses":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/327ff9111082f2056fecdb6db5dd962b9fd419cf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kansi"}}