{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/187804084","pull_request_review_id":119657566,"id":187804084,"diff_hunk":"@@ -123,20 +123,23 @@ pub fn value_to_const_value<'a, 'tcx>(\n             }\n         }\n         _ => {\n-            if let Value::ByRef(ptr, align) = val {\n+            if let Value::ByRef(ptr, _) = val {\n                 let ptr = ptr.primval.to_ptr().unwrap();\n                 assert_eq!(ptr.offset, 0);\n-                let alloc = tcx.interpret_interner\n-                               .get_alloc(ptr.alloc_id)\n-                               .expect(\"miri allocation never successfully created\");\n-                assert_eq!(align, alloc.align);\n+                let alloc = ecx.memory.get(ptr.alloc_id)?;","path":"src/librustc_mir/interpret/const_eval.rs","position":38,"original_position":38,"commit_id":"0e80f473a806cbb55d21a063118d43999735371d","original_commit_id":"0e80f473a806cbb55d21a063118d43999735371d","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"body":"doesn't this change simply turn a panic into an error? How does that fix the regression?","created_at":"2018-05-13T15:09:54Z","updated_at":"2018-05-13T15:09:57Z","html_url":"https://github.com/rust-lang/rust/pull/50710#discussion_r187804084","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/50710","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/187804084"},"html":{"href":"https://github.com/rust-lang/rust/pull/50710#discussion_r187804084"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/50710"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/50710","id":187674590,"html_url":"https://github.com/rust-lang/rust/pull/50710","diff_url":"https://github.com/rust-lang/rust/pull/50710.diff","patch_url":"https://github.com/rust-lang/rust/pull/50710.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/50710","number":50710,"state":"open","locked":false,"title":"Fix conversion from Miri Value to ConstValue","user":{"login":"Zoxc","id":25784,"avatar_url":"https://avatars3.githubusercontent.com/u/25784?v=4","gravatar_id":"","url":"https://api.github.com/users/Zoxc","html_url":"https://github.com/Zoxc","followers_url":"https://api.github.com/users/Zoxc/followers","following_url":"https://api.github.com/users/Zoxc/following{/other_user}","gists_url":"https://api.github.com/users/Zoxc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zoxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zoxc/subscriptions","organizations_url":"https://api.github.com/users/Zoxc/orgs","repos_url":"https://api.github.com/users/Zoxc/repos","events_url":"https://api.github.com/users/Zoxc/events{/privacy}","received_events_url":"https://api.github.com/users/Zoxc/received_events","type":"User","site_admin":false},"body":"This fixes an error compiling the `immeta` 0.3.6 crate. https://github.com/rust-lang/rust/issues/50707 may be fixed too.\r\n\r\nr? @oli-obk ","created_at":"2018-05-13T15:03:29Z","updated_at":"2018-05-13T15:09:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d79c79c364f6fea7d5382fa2c9a2dc2914ef902","assignee":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"assignees":[{"login":"oli-obk","id":332036,"avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/50710/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/50710/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/50710/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/0e80f473a806cbb55d21a063118d43999735371d","head":{"label":"Zoxc:value_to_constvalue","ref":"value_to_constvalue","sha":"0e80f473a806cbb55d21a063118d43999735371d","user":{"login":"Zoxc","id":25784,"avatar_url":"https://avatars3.githubusercontent.com/u/25784?v=4","gravatar_id":"","url":"https://api.github.com/users/Zoxc","html_url":"https://github.com/Zoxc","followers_url":"https://api.github.com/users/Zoxc/followers","following_url":"https://api.github.com/users/Zoxc/following{/other_user}","gists_url":"https://api.github.com/users/Zoxc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zoxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zoxc/subscriptions","organizations_url":"https://api.github.com/users/Zoxc/orgs","repos_url":"https://api.github.com/users/Zoxc/repos","events_url":"https://api.github.com/users/Zoxc/events{/privacy}","received_events_url":"https://api.github.com/users/Zoxc/received_events","type":"User","site_admin":false},"repo":{"id":21868454,"name":"rust","full_name":"Zoxc/rust","owner":{"login":"Zoxc","id":25784,"avatar_url":"https://avatars3.githubusercontent.com/u/25784?v=4","gravatar_id":"","url":"https://api.github.com/users/Zoxc","html_url":"https://github.com/Zoxc","followers_url":"https://api.github.com/users/Zoxc/followers","following_url":"https://api.github.com/users/Zoxc/following{/other_user}","gists_url":"https://api.github.com/users/Zoxc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zoxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zoxc/subscriptions","organizations_url":"https://api.github.com/users/Zoxc/orgs","repos_url":"https://api.github.com/users/Zoxc/repos","events_url":"https://api.github.com/users/Zoxc/events{/privacy}","received_events_url":"https://api.github.com/users/Zoxc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zoxc/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/Zoxc/rust","forks_url":"https://api.github.com/repos/Zoxc/rust/forks","keys_url":"https://api.github.com/repos/Zoxc/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zoxc/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zoxc/rust/teams","hooks_url":"https://api.github.com/repos/Zoxc/rust/hooks","issue_events_url":"https://api.github.com/repos/Zoxc/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Zoxc/rust/events","assignees_url":"https://api.github.com/repos/Zoxc/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Zoxc/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Zoxc/rust/tags","blobs_url":"https://api.github.com/repos/Zoxc/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zoxc/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zoxc/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zoxc/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zoxc/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Zoxc/rust/languages","stargazers_url":"https://api.github.com/repos/Zoxc/rust/stargazers","contributors_url":"https://api.github.com/repos/Zoxc/rust/contributors","subscribers_url":"https://api.github.com/repos/Zoxc/rust/subscribers","subscription_url":"https://api.github.com/repos/Zoxc/rust/subscription","commits_url":"https://api.github.com/repos/Zoxc/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zoxc/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zoxc/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zoxc/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zoxc/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Zoxc/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zoxc/rust/merges","archive_url":"https://api.github.com/repos/Zoxc/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zoxc/rust/downloads","issues_url":"https://api.github.com/repos/Zoxc/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Zoxc/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Zoxc/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Zoxc/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zoxc/rust/labels{/name}","releases_url":"https://api.github.com/repos/Zoxc/rust/releases{/id}","deployments_url":"https://api.github.com/repos/Zoxc/rust/deployments","created_at":"2014-07-15T17:08:44Z","updated_at":"2018-03-16T16:02:33Z","pushed_at":"2018-05-13T15:01:17Z","git_url":"git://github.com/Zoxc/rust.git","ssh_url":"git@github.com:Zoxc/rust.git","clone_url":"https://github.com/Zoxc/rust.git","svn_url":"https://github.com/Zoxc/rust","homepage":"http://www.rust-lang.org","size":370508,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"3e955a058108fcadf0a8222de5868b0c905534d5","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-05-13T15:02:41Z","pushed_at":"2018-05-13T15:03:30Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":373373,"stargazers_count":28202,"watchers_count":28202,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4909,"mirror_url":null,"archived":false,"open_issues_count":3777,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4909,"open_issues":3777,"watchers":28202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/50710"},"html":{"href":"https://github.com/rust-lang/rust/pull/50710"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/50710"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/50710/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/50710/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/50710/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/0e80f473a806cbb55d21a063118d43999735371d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"oli-obk"}}