{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaPackaging/BinaryProvider.jl/issues/89","repository_url":"https://api.github.com/repos/JuliaPackaging/BinaryProvider.jl","labels_url":"https://api.github.com/repos/JuliaPackaging/BinaryProvider.jl/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/JuliaPackaging/BinaryProvider.jl/issues/89/comments","events_url":"https://api.github.com/repos/JuliaPackaging/BinaryProvider.jl/issues/89/events","html_url":"https://github.com/JuliaPackaging/BinaryProvider.jl/issues/89","id":342742022,"node_id":"MDU6SXNzdWUzNDI3NDIwMjI=","number":89,"title":"need import Compat.Libdl on 0.7","user":{"login":"stevengj","id":2913679,"node_id":"MDQ6VXNlcjI5MTM2Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2913679?v=4","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-19T14:03:20Z","updated_at":"2018-07-19T17:17:19Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"There seem to be several places that use `Libdl.foo` without first importing the Libdl module, which is required on 0.7.   (For 0.6 compatibility, `import Compat.Libdl`).  For example\r\n\r\n* [here](https://github.com/JuliaPackaging/BinaryProvider.jl/blob/865e9ce4e041ea2ef9c841cac5fbc9c1f4eac055/src/Products.jl#L168)\r\n* [here](https://github.com/JuliaPackaging/BinaryProvider.jl/blob/865e9ce4e041ea2ef9c841cac5fbc9c1f4eac055/src/Products.jl#L440)\r\n\r\nThe latter case is in generated code for `deps.jl` so it triggers deprecation warnings in packages (see e.g. stevengj/Blosc.jl#56)."},"comment":{"url":"https://api.github.com/repos/JuliaPackaging/BinaryProvider.jl/issues/comments/406351259","html_url":"https://github.com/JuliaPackaging/BinaryProvider.jl/issues/89#issuecomment-406351259","issue_url":"https://api.github.com/repos/JuliaPackaging/BinaryProvider.jl/issues/89","id":406351259,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjM1MTI1OQ==","user":{"login":"ararslan","id":6396159,"node_id":"MDQ6VXNlcjYzOTYxNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6396159?v=4","gravatar_id":"","url":"https://api.github.com/users/ararslan","html_url":"https://github.com/ararslan","followers_url":"https://api.github.com/users/ararslan/followers","following_url":"https://api.github.com/users/ararslan/following{/other_user}","gists_url":"https://api.github.com/users/ararslan/gists{/gist_id}","starred_url":"https://api.github.com/users/ararslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ararslan/subscriptions","organizations_url":"https://api.github.com/users/ararslan/orgs","repos_url":"https://api.github.com/users/ararslan/repos","events_url":"https://api.github.com/users/ararslan/events{/privacy}","received_events_url":"https://api.github.com/users/ararslan/received_events","type":"User","site_admin":false},"created_at":"2018-07-19T17:17:19Z","updated_at":"2018-07-19T17:17:19Z","author_association":"MEMBER","body":"To avoid introducing a dependency on Compat everywhere, we could change the latter case to\r\n```diff\r\n--- a/src/Products.jl\r\n+++ b/src/Products.jl\r\n@@ -437,6 +437,9 @@ function write_deps_file(depsjl_path::AbstractString, products::Vector{P};\r\n             # For Library products, check that we can dlopen it:\r\n             if typeof(product) <: LibraryProduct\r\n                 println(depsjl_file, \"\"\"\r\n+                    if VERSION >= v\"0.7.0-DEV.3382\"\r\n+                        import Libdl\r\n+                    end\r\n                     if Libdl.dlopen_e($(varname)) == C_NULL\r\n                         error(\"\\$($(varname)) cannot be opened, $(rebuild)\")\r\n                     end\r\n```"}}
{"actor":{"display_login":"ararslan"}}