{"action":"created","comment":{"url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/comments/177138790","pull_request_review_id":106960258,"id":177138790,"diff_hunk":"@@ -2,17 +2,32 @@\n \r\n import com.states.GameState;\r\n import de.adesso.anki.battle.mqtt.MqttService;\r\n+import de.adesso.anki.battle.util.Position;\r\n+import de.adesso.anki.battle.world.Body;\r\n import de.adesso.anki.battle.world.DynamicBody;\r\n+import de.adesso.anki.battle.world.World;\r\n+\r\n import org.eclipse.paho.client.mqttv3.MqttException;\r\n \r\n import java.util.List;\r\n \r\n public class Mine extends DynamicBody {\r\n-\r\n+\tprivate long timer ; \r\n+\tprivate boolean active;\r","path":"src/main/java/de/adesso/anki/battle/world/bodies/Mine.java","position":16,"original_position":16,"commit_id":"2a572eb45a68dd59247d1bb5fc1fd561089811e6","original_commit_id":"2a572eb45a68dd59247d1bb5fc1fd561089811e6","user":{"login":"adesso-anki-sonar","id":37698870,"avatar_url":"https://avatars1.githubusercontent.com/u/37698870?v=4","gravatar_id":"","url":"https://api.github.com/users/adesso-anki-sonar","html_url":"https://github.com/adesso-anki-sonar","followers_url":"https://api.github.com/users/adesso-anki-sonar/followers","following_url":"https://api.github.com/users/adesso-anki-sonar/following{/other_user}","gists_url":"https://api.github.com/users/adesso-anki-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/adesso-anki-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adesso-anki-sonar/subscriptions","organizations_url":"https://api.github.com/users/adesso-anki-sonar/orgs","repos_url":"https://api.github.com/users/adesso-anki-sonar/repos","events_url":"https://api.github.com/users/adesso-anki-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/adesso-anki-sonar/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Remove this unused \"active\" private field. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1068)\n","created_at":"2018-03-26T15:43:15Z","updated_at":"2018-03-26T15:43:15Z","html_url":"https://github.com/adessoAG/anki-battle-showcase/pull/18#discussion_r177138790","pull_request_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/18","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/comments/177138790"},"html":{"href":"https://github.com/adessoAG/anki-battle-showcase/pull/18#discussion_r177138790"},"pull_request":{"href":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/18","id":177486878,"html_url":"https://github.com/adessoAG/anki-battle-showcase/pull/18","diff_url":"https://github.com/adessoAG/anki-battle-showcase/pull/18.diff","patch_url":"https://github.com/adessoAG/anki-battle-showcase/pull/18.patch","issue_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/issues/18","number":18,"state":"open","locked":false,"title":"implement basic weapon behaviour in backend","user":{"login":"Kengstar","id":23086982,"avatar_url":"https://avatars3.githubusercontent.com/u/23086982?v=4","gravatar_id":"","url":"https://api.github.com/users/Kengstar","html_url":"https://github.com/Kengstar","followers_url":"https://api.github.com/users/Kengstar/followers","following_url":"https://api.github.com/users/Kengstar/following{/other_user}","gists_url":"https://api.github.com/users/Kengstar/gists{/gist_id}","starred_url":"https://api.github.com/users/Kengstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kengstar/subscriptions","organizations_url":"https://api.github.com/users/Kengstar/orgs","repos_url":"https://api.github.com/users/Kengstar/repos","events_url":"https://api.github.com/users/Kengstar/events{/privacy}","received_events_url":"https://api.github.com/users/Kengstar/received_events","type":"User","site_admin":false},"body":"weapon vehicle collision works in the simulation. \r\n","created_at":"2018-03-26T15:40:24Z","updated_at":"2018-03-26T15:43:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d96a4f04f83cb35520ae8a59e9511478de0c6189","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/18/commits","review_comments_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/18/comments","review_comment_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/issues/18/comments","statuses_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/statuses/2a572eb45a68dd59247d1bb5fc1fd561089811e6","head":{"label":"adessoAG:feature/weapons","ref":"feature/weapons","sha":"2a572eb45a68dd59247d1bb5fc1fd561089811e6","user":{"login":"adessoAG","id":1710422,"avatar_url":"https://avatars1.githubusercontent.com/u/1710422?v=4","gravatar_id":"","url":"https://api.github.com/users/adessoAG","html_url":"https://github.com/adessoAG","followers_url":"https://api.github.com/users/adessoAG/followers","following_url":"https://api.github.com/users/adessoAG/following{/other_user}","gists_url":"https://api.github.com/users/adessoAG/gists{/gist_id}","starred_url":"https://api.github.com/users/adessoAG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adessoAG/subscriptions","organizations_url":"https://api.github.com/users/adessoAG/orgs","repos_url":"https://api.github.com/users/adessoAG/repos","events_url":"https://api.github.com/users/adessoAG/events{/privacy}","received_events_url":"https://api.github.com/users/adessoAG/received_events","type":"Organization","site_admin":false},"repo":{"id":110960000,"name":"anki-battle-showcase","full_name":"adessoAG/anki-battle-showcase","owner":{"login":"adessoAG","id":1710422,"avatar_url":"https://avatars1.githubusercontent.com/u/1710422?v=4","gravatar_id":"","url":"https://api.github.com/users/adessoAG","html_url":"https://github.com/adessoAG","followers_url":"https://api.github.com/users/adessoAG/followers","following_url":"https://api.github.com/users/adessoAG/following{/other_user}","gists_url":"https://api.github.com/users/adessoAG/gists{/gist_id}","starred_url":"https://api.github.com/users/adessoAG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adessoAG/subscriptions","organizations_url":"https://api.github.com/users/adessoAG/orgs","repos_url":"https://api.github.com/users/adessoAG/repos","events_url":"https://api.github.com/users/adessoAG/events{/privacy}","received_events_url":"https://api.github.com/users/adessoAG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adessoAG/anki-battle-showcase","description":null,"fork":false,"url":"https://api.github.com/repos/adessoAG/anki-battle-showcase","forks_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/forks","keys_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/teams","hooks_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/hooks","issue_events_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/issues/events{/number}","events_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/events","assignees_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/assignees{/user}","branches_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/branches{/branch}","tags_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/tags","blobs_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/git/refs{/sha}","trees_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/statuses/{sha}","languages_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/languages","stargazers_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/stargazers","contributors_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/contributors","subscribers_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/subscribers","subscription_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/subscription","commits_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/commits{/sha}","git_commits_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/git/commits{/sha}","comments_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/comments{/number}","issue_comment_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/issues/comments{/number}","contents_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/contents/{+path}","compare_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/merges","archive_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/downloads","issues_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/issues{/number}","pulls_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls{/number}","milestones_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/milestones{/number}","notifications_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/labels{/name}","releases_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/releases{/id}","deployments_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/deployments","created_at":"2017-11-16T10:52:28Z","updated_at":"2018-03-23T15:02:30Z","pushed_at":"2018-03-26T15:40:25Z","git_url":"git://github.com/adessoAG/anki-battle-showcase.git","ssh_url":"git@github.com:adessoAG/anki-battle-showcase.git","clone_url":"https://github.com/adessoAG/anki-battle-showcase.git","svn_url":"https://github.com/adessoAG/anki-battle-showcase","homepage":null,"size":2215,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":0,"open_issues":15,"watchers":3,"default_branch":"develop"}},"base":{"label":"adessoAG:develop","ref":"develop","sha":"6cd119f56e498b529250ee1a20e29e99027f85bf","user":{"login":"adessoAG","id":1710422,"avatar_url":"https://avatars1.githubusercontent.com/u/1710422?v=4","gravatar_id":"","url":"https://api.github.com/users/adessoAG","html_url":"https://github.com/adessoAG","followers_url":"https://api.github.com/users/adessoAG/followers","following_url":"https://api.github.com/users/adessoAG/following{/other_user}","gists_url":"https://api.github.com/users/adessoAG/gists{/gist_id}","starred_url":"https://api.github.com/users/adessoAG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adessoAG/subscriptions","organizations_url":"https://api.github.com/users/adessoAG/orgs","repos_url":"https://api.github.com/users/adessoAG/repos","events_url":"https://api.github.com/users/adessoAG/events{/privacy}","received_events_url":"https://api.github.com/users/adessoAG/received_events","type":"Organization","site_admin":false},"repo":{"id":110960000,"name":"anki-battle-showcase","full_name":"adessoAG/anki-battle-showcase","owner":{"login":"adessoAG","id":1710422,"avatar_url":"https://avatars1.githubusercontent.com/u/1710422?v=4","gravatar_id":"","url":"https://api.github.com/users/adessoAG","html_url":"https://github.com/adessoAG","followers_url":"https://api.github.com/users/adessoAG/followers","following_url":"https://api.github.com/users/adessoAG/following{/other_user}","gists_url":"https://api.github.com/users/adessoAG/gists{/gist_id}","starred_url":"https://api.github.com/users/adessoAG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adessoAG/subscriptions","organizations_url":"https://api.github.com/users/adessoAG/orgs","repos_url":"https://api.github.com/users/adessoAG/repos","events_url":"https://api.github.com/users/adessoAG/events{/privacy}","received_events_url":"https://api.github.com/users/adessoAG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adessoAG/anki-battle-showcase","description":null,"fork":false,"url":"https://api.github.com/repos/adessoAG/anki-battle-showcase","forks_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/forks","keys_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/teams","hooks_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/hooks","issue_events_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/issues/events{/number}","events_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/events","assignees_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/assignees{/user}","branches_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/branches{/branch}","tags_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/tags","blobs_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/git/refs{/sha}","trees_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/statuses/{sha}","languages_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/languages","stargazers_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/stargazers","contributors_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/contributors","subscribers_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/subscribers","subscription_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/subscription","commits_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/commits{/sha}","git_commits_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/git/commits{/sha}","comments_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/comments{/number}","issue_comment_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/issues/comments{/number}","contents_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/contents/{+path}","compare_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/merges","archive_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/downloads","issues_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/issues{/number}","pulls_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls{/number}","milestones_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/milestones{/number}","notifications_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/labels{/name}","releases_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/releases{/id}","deployments_url":"https://api.github.com/repos/adessoAG/anki-battle-showcase/deployments","created_at":"2017-11-16T10:52:28Z","updated_at":"2018-03-23T15:02:30Z","pushed_at":"2018-03-26T15:40:25Z","git_url":"git://github.com/adessoAG/anki-battle-showcase.git","ssh_url":"git@github.com:adessoAG/anki-battle-showcase.git","clone_url":"https://github.com/adessoAG/anki-battle-showcase.git","svn_url":"https://github.com/adessoAG/anki-battle-showcase","homepage":null,"size":2215,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":0,"open_issues":15,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/18"},"html":{"href":"https://github.com/adessoAG/anki-battle-showcase/pull/18"},"issue":{"href":"https://api.github.com/repos/adessoAG/anki-battle-showcase/issues/18"},"comments":{"href":"https://api.github.com/repos/adessoAG/anki-battle-showcase/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adessoAG/anki-battle-showcase/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/adessoAG/anki-battle-showcase/statuses/2a572eb45a68dd59247d1bb5fc1fd561089811e6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adesso-anki-sonar"}}