{"action":"created","issue":{"url":"https://api.github.com/repos/bitwarden/browser/issues/637","repository_url":"https://api.github.com/repos/bitwarden/browser","labels_url":"https://api.github.com/repos/bitwarden/browser/issues/637/labels{/name}","comments_url":"https://api.github.com/repos/bitwarden/browser/issues/637/comments","events_url":"https://api.github.com/repos/bitwarden/browser/issues/637/events","html_url":"https://github.com/bitwarden/browser/pull/637","id":329492006,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzM0NTg2","number":637,"title":"Precaution against iframe creating blank space on the page","user":{"login":"nomaed","id":9551921,"node_id":"MDQ6VXNlcjk1NTE5MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/9551921?v=4","gravatar_id":"","url":"https://api.github.com/users/nomaed","html_url":"https://github.com/nomaed","followers_url":"https://api.github.com/users/nomaed/followers","following_url":"https://api.github.com/users/nomaed/following{/other_user}","gists_url":"https://api.github.com/users/nomaed/gists{/gist_id}","starred_url":"https://api.github.com/users/nomaed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nomaed/subscriptions","organizations_url":"https://api.github.com/users/nomaed/orgs","repos_url":"https://api.github.com/users/nomaed/repos","events_url":"https://api.github.com/users/nomaed/events{/privacy}","received_events_url":"https://api.github.com/users/nomaed/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-05T14:48:47Z","updated_at":"2018-06-05T14:52:57Z","closed_at":"2018-06-05T14:52:48Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bitwarden/browser/pulls/637","html_url":"https://github.com/bitwarden/browser/pull/637","diff_url":"https://github.com/bitwarden/browser/pull/637.diff","patch_url":"https://github.com/bitwarden/browser/pull/637.patch"},"body":"Since the notification bar is added inside of the active page, page specific styles may override how the iframe is rendered in an undesirable way.\r\n\r\nI came across this when logging in an internal corporate web-app we're using which for some reason has a global css setting of `iframe { min-height: 349px }` because nobody anticipated that 3rd party DOM elements would be injected to the page.\r\n\r\nThis modification should have no impact other than negating these global styles.\r\n\r\n![screen shot 2018-06-05 at 17 44 54](https://user-images.githubusercontent.com/9551921/40983551-9b88740e-68e8-11e8-8a37-386a09374fc1.png)\r\n"},"comment":{"url":"https://api.github.com/repos/bitwarden/browser/issues/comments/394739874","html_url":"https://github.com/bitwarden/browser/pull/637#issuecomment-394739874","issue_url":"https://api.github.com/repos/bitwarden/browser/issues/637","id":394739874,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDczOTg3NA==","user":{"login":"kspearrin","id":1190944,"node_id":"MDQ6VXNlcjExOTA5NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1190944?v=4","gravatar_id":"","url":"https://api.github.com/users/kspearrin","html_url":"https://github.com/kspearrin","followers_url":"https://api.github.com/users/kspearrin/followers","following_url":"https://api.github.com/users/kspearrin/following{/other_user}","gists_url":"https://api.github.com/users/kspearrin/gists{/gist_id}","starred_url":"https://api.github.com/users/kspearrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kspearrin/subscriptions","organizations_url":"https://api.github.com/users/kspearrin/orgs","repos_url":"https://api.github.com/users/kspearrin/repos","events_url":"https://api.github.com/users/kspearrin/events{/privacy}","received_events_url":"https://api.github.com/users/kspearrin/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T14:52:57Z","updated_at":"2018-06-05T14:52:57Z","author_association":"MEMBER","body":"Thanks."}}
{"actor":{"display_login":"kspearrin"}}