{"action":"created","issue":{"url":"https://api.github.com/repos/AdamsLair/duality/issues/662","repository_url":"https://api.github.com/repos/AdamsLair/duality","labels_url":"https://api.github.com/repos/AdamsLair/duality/issues/662/labels{/name}","comments_url":"https://api.github.com/repos/AdamsLair/duality/issues/662/comments","events_url":"https://api.github.com/repos/AdamsLair/duality/issues/662/events","html_url":"https://github.com/AdamsLair/duality/pull/662","id":325268499,"number":662,"title":"#658 Fix for exception during OnShutdown causing other OnShutdowns to be skipped","user":{"login":"Barsonax","id":19387223,"avatar_url":"https://avatars2.githubusercontent.com/u/19387223?v=4","gravatar_id":"","url":"https://api.github.com/users/Barsonax","html_url":"https://github.com/Barsonax","followers_url":"https://api.github.com/users/Barsonax/followers","following_url":"https://api.github.com/users/Barsonax/following{/other_user}","gists_url":"https://api.github.com/users/Barsonax/gists{/gist_id}","starred_url":"https://api.github.com/users/Barsonax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Barsonax/subscriptions","organizations_url":"https://api.github.com/users/Barsonax/orgs","repos_url":"https://api.github.com/users/Barsonax/repos","events_url":"https://api.github.com/users/Barsonax/events{/privacy}","received_events_url":"https://api.github.com/users/Barsonax/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-22T12:19:33Z","updated_at":"2018-05-22T17:15:41Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/AdamsLair/duality/pulls/662","html_url":"https://github.com/AdamsLair/duality/pull/662","diff_url":"https://github.com/AdamsLair/duality/pull/662.diff","patch_url":"https://github.com/AdamsLair/duality/pull/662.patch"},"body":"Not yet finished and this PR is mostly for discussion of issue #658  currently.\r\n\r\n**Possible improvements:**\r\n- [ ] Log the individual errors in a AggregrateException as the log currently wont show the original exceptions\r\n- [ ] Generalize and reduce the code duplication of the current implementation\r\n- [ ] Extend this behaviour to other events"},"comment":{"url":"https://api.github.com/repos/AdamsLair/duality/issues/comments/391070530","html_url":"https://github.com/AdamsLair/duality/pull/662#issuecomment-391070530","issue_url":"https://api.github.com/repos/AdamsLair/duality/issues/662","id":391070530,"user":{"login":"Barsonax","id":19387223,"avatar_url":"https://avatars2.githubusercontent.com/u/19387223?v=4","gravatar_id":"","url":"https://api.github.com/users/Barsonax","html_url":"https://github.com/Barsonax","followers_url":"https://api.github.com/users/Barsonax/followers","following_url":"https://api.github.com/users/Barsonax/following{/other_user}","gists_url":"https://api.github.com/users/Barsonax/gists{/gist_id}","starred_url":"https://api.github.com/users/Barsonax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Barsonax/subscriptions","organizations_url":"https://api.github.com/users/Barsonax/orgs","repos_url":"https://api.github.com/users/Barsonax/repos","events_url":"https://api.github.com/users/Barsonax/events{/privacy}","received_events_url":"https://api.github.com/users/Barsonax/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T17:15:41Z","updated_at":"2018-05-22T17:15:41Z","author_association":"MEMBER","body":"Good point I also think there might be a good possibility that this will be used for more than just shutdown (also for init, update etc?). So eventually I want to generalize the code alot more. The current implementation is more like a proof of concept to play with.\r\n\r\nBefore making the current implementation better Iam interested in what @ilexp opinion is about this topic. Maybe he had very good reasons for not doing it like this."}}
{"actor":{"display_login":"Barsonax"}}