{"action":"created","issue":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/114","repository_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/114/comments","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/114/events","html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/114","id":386169288,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0OTczMDQ5","number":114,"title":"BASW-338: Allow users to view membership periods in membership tab","user":{"login":"omarabuhussein","id":6275540,"node_id":"MDQ6VXNlcjYyNzU1NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6275540?v=4","gravatar_id":"","url":"https://api.github.com/users/omarabuhussein","html_url":"https://github.com/omarabuhussein","followers_url":"https://api.github.com/users/omarabuhussein/followers","following_url":"https://api.github.com/users/omarabuhussein/following{/other_user}","gists_url":"https://api.github.com/users/omarabuhussein/gists{/gist_id}","starred_url":"https://api.github.com/users/omarabuhussein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarabuhussein/subscriptions","organizations_url":"https://api.github.com/users/omarabuhussein/orgs","repos_url":"https://api.github.com/users/omarabuhussein/repos","events_url":"https://api.github.com/users/omarabuhussein/events{/privacy}","received_events_url":"https://api.github.com/users/omarabuhussein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-30T12:32:54Z","updated_at":"2018-12-03T13:07:21Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/114","html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/114","diff_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/114.diff","patch_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/114.patch"},"body":"## User Story\r\n\r\nAs a staff member, I want to see the period of each membership signup and renewal so that I can know the complete membership history of this contact. \r\n Membership periods should be nested under each membership type where active periods are in black color, past periods are in gray color and inactive periods are in red, the periods should also be ordered by start date in Ascending order.\r\n\r\n## Before\r\n\r\nThere is no place to view the current membership periods.\r\n\r\n## After\r\n\r\nMembership periods can be viewed by expanding the membership type field : \r\n\r\n+ On Legacy screen\r\n![cccaaaa](https://user-images.githubusercontent.com/6275540/49288832-bd6cd500-f499-11e8-9a71-6c3bcff52bbc.gif)\r\n\r\n+ On Shoreditch screen\r\n![ddadasads](https://user-images.githubusercontent.com/6275540/49308044-fd01e400-f4ce-11e8-9a79-cd3ab11a291d.gif)\r\n\r\n\r\n## Technical Notes \r\n\r\n- hook_civicrm_pageRun is used to add js and css files that created the nested view on membership tab.\r\n-  The JS file listen to datatables (since most civicrm tables are created using [datatables plugin](https://datatables.net)) [init event](https://datatables.net/reference/event/init) all loops through all visible tables (which are active and inactive membership tables) and add click listener that shows/hides the membership periods nested view.\r\n- The nested periods view is appended to the table using datatables child() method, more info can be found here  : https://datatables.net/examples/api/row_details.html"},"comment":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/comments/443703837","html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/114#issuecomment-443703837","issue_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/114","id":443703837,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzcwMzgzNw==","user":{"login":"jamienovick","id":2102899,"node_id":"MDQ6VXNlcjIxMDI4OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/2102899?v=4","gravatar_id":"","url":"https://api.github.com/users/jamienovick","html_url":"https://github.com/jamienovick","followers_url":"https://api.github.com/users/jamienovick/followers","following_url":"https://api.github.com/users/jamienovick/following{/other_user}","gists_url":"https://api.github.com/users/jamienovick/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienovick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienovick/subscriptions","organizations_url":"https://api.github.com/users/jamienovick/orgs","repos_url":"https://api.github.com/users/jamienovick/repos","events_url":"https://api.github.com/users/jamienovick/events{/privacy}","received_events_url":"https://api.github.com/users/jamienovick/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T13:07:21Z","updated_at":"2018-12-03T13:07:21Z","author_association":"NONE","body":"Whatever you can do would be great. Not a huge deal. You can see an example of the CSS in the gift aid extension of that helps @guanhuan may be able to send you a screenshot"}}
{"actor":{"display_login":"jamienovick"}}