{"action":"created","comment":{"url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/comments/195940852","pull_request_review_id":129400489,"id":195940852,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTk0MDg1Mg==","diff_hunk":"@@ -0,0 +1,33 @@\n+#invoke npm in jenkinsfile: sh \"scl enable rh-nodejs6 'npm run build'\"\n+FROM registry.access.redhat.com/openshift3/jenkins-slave-base-rhel7\n+USER root","path":"jenkins-slaves/jenkins-slave-npm/Dockerfile","position":3,"original_position":3,"commit_id":"06165bad60812878052b3bfe22bb5240c27c723b","original_commit_id":"06165bad60812878052b3bfe22bb5240c27c723b","user":{"login":"pabrahamsson","id":5749047,"node_id":"MDQ6VXNlcjU3NDkwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/5749047?v=4","gravatar_id":"","url":"https://api.github.com/users/pabrahamsson","html_url":"https://github.com/pabrahamsson","followers_url":"https://api.github.com/users/pabrahamsson/followers","following_url":"https://api.github.com/users/pabrahamsson/following{/other_user}","gists_url":"https://api.github.com/users/pabrahamsson/gists{/gist_id}","starred_url":"https://api.github.com/users/pabrahamsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabrahamsson/subscriptions","organizations_url":"https://api.github.com/users/pabrahamsson/orgs","repos_url":"https://api.github.com/users/pabrahamsson/repos","events_url":"https://api.github.com/users/pabrahamsson/events{/privacy}","received_events_url":"https://api.github.com/users/pabrahamsson/received_events","type":"User","site_admin":false},"body":"Please remove, `openshift3/jenkins-slave-base-rhel7` is already running as root.","created_at":"2018-06-17T20:46:47Z","updated_at":"2018-06-17T20:58:44Z","html_url":"https://github.com/redhat-cop/containers-quickstarts/pull/98#discussion_r195940852","pull_request_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/98","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/comments/195940852"},"html":{"href":"https://github.com/redhat-cop/containers-quickstarts/pull/98#discussion_r195940852"},"pull_request":{"href":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/98","id":187187842,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3MTg3ODQy","html_url":"https://github.com/redhat-cop/containers-quickstarts/pull/98","diff_url":"https://github.com/redhat-cop/containers-quickstarts/pull/98.diff","patch_url":"https://github.com/redhat-cop/containers-quickstarts/pull/98.patch","issue_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/issues/98","number":98,"state":"open","locked":false,"title":"Feature/jenkins slave npm","user":{"login":"springdo","id":6122439,"node_id":"MDQ6VXNlcjYxMjI0Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/6122439?v=4","gravatar_id":"","url":"https://api.github.com/users/springdo","html_url":"https://github.com/springdo","followers_url":"https://api.github.com/users/springdo/followers","following_url":"https://api.github.com/users/springdo/following{/other_user}","gists_url":"https://api.github.com/users/springdo/gists{/gist_id}","starred_url":"https://api.github.com/users/springdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springdo/subscriptions","organizations_url":"https://api.github.com/users/springdo/orgs","repos_url":"https://api.github.com/users/springdo/repos","events_url":"https://api.github.com/users/springdo/events{/privacy}","received_events_url":"https://api.github.com/users/springdo/received_events","type":"User","site_admin":false},"body":"#### What is this PR About?\r\nDescribe the contents of the PR\r\nadding an npm slave with some extra juice that we use on residencies. Contains latest LTS version of node (v8x), google chrome for headless browser testing as part of CI and some basic git config for Jenkins when pushing repo tags.\r\n\r\n#### How do we test this?\r\nProvide commands/steps to test this PR.\r\nAs with the other PRs, build and run the image locally. $CHROME_BIN, npm and node all avail via env vars and path.\r\n\r\ncc: @redhat-cop/containerize-it\r\n","created_at":"2018-05-10T13:08:23Z","updated_at":"2018-06-17T20:58:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96ebb2bc7d4e97e6dafc116a1aea5e64d98b324a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":433921600,"node_id":"MDU6TGFiZWw0MzM5MjE2MDA=","url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/98/commits","review_comments_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/98/comments","review_comment_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/issues/98/comments","statuses_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/statuses/06165bad60812878052b3bfe22bb5240c27c723b","head":{"label":"springdo:feature/jenkins-slave-npm","ref":"feature/jenkins-slave-npm","sha":"06165bad60812878052b3bfe22bb5240c27c723b","user":{"login":"springdo","id":6122439,"node_id":"MDQ6VXNlcjYxMjI0Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/6122439?v=4","gravatar_id":"","url":"https://api.github.com/users/springdo","html_url":"https://github.com/springdo","followers_url":"https://api.github.com/users/springdo/followers","following_url":"https://api.github.com/users/springdo/following{/other_user}","gists_url":"https://api.github.com/users/springdo/gists{/gist_id}","starred_url":"https://api.github.com/users/springdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springdo/subscriptions","organizations_url":"https://api.github.com/users/springdo/orgs","repos_url":"https://api.github.com/users/springdo/repos","events_url":"https://api.github.com/users/springdo/events{/privacy}","received_events_url":"https://api.github.com/users/springdo/received_events","type":"User","site_admin":false},"repo":{"id":125079654,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwNzk2NTQ=","name":"containers-quickstarts","full_name":"springdo/containers-quickstarts","owner":{"login":"springdo","id":6122439,"node_id":"MDQ6VXNlcjYxMjI0Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/6122439?v=4","gravatar_id":"","url":"https://api.github.com/users/springdo","html_url":"https://github.com/springdo","followers_url":"https://api.github.com/users/springdo/followers","following_url":"https://api.github.com/users/springdo/following{/other_user}","gists_url":"https://api.github.com/users/springdo/gists{/gist_id}","starred_url":"https://api.github.com/users/springdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springdo/subscriptions","organizations_url":"https://api.github.com/users/springdo/orgs","repos_url":"https://api.github.com/users/springdo/repos","events_url":"https://api.github.com/users/springdo/events{/privacy}","received_events_url":"https://api.github.com/users/springdo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/springdo/containers-quickstarts","description":"Images & templates for deploying software to OpenShift","fork":true,"url":"https://api.github.com/repos/springdo/containers-quickstarts","forks_url":"https://api.github.com/repos/springdo/containers-quickstarts/forks","keys_url":"https://api.github.com/repos/springdo/containers-quickstarts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/springdo/containers-quickstarts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/springdo/containers-quickstarts/teams","hooks_url":"https://api.github.com/repos/springdo/containers-quickstarts/hooks","issue_events_url":"https://api.github.com/repos/springdo/containers-quickstarts/issues/events{/number}","events_url":"https://api.github.com/repos/springdo/containers-quickstarts/events","assignees_url":"https://api.github.com/repos/springdo/containers-quickstarts/assignees{/user}","branches_url":"https://api.github.com/repos/springdo/containers-quickstarts/branches{/branch}","tags_url":"https://api.github.com/repos/springdo/containers-quickstarts/tags","blobs_url":"https://api.github.com/repos/springdo/containers-quickstarts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/springdo/containers-quickstarts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/springdo/containers-quickstarts/git/refs{/sha}","trees_url":"https://api.github.com/repos/springdo/containers-quickstarts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/springdo/containers-quickstarts/statuses/{sha}","languages_url":"https://api.github.com/repos/springdo/containers-quickstarts/languages","stargazers_url":"https://api.github.com/repos/springdo/containers-quickstarts/stargazers","contributors_url":"https://api.github.com/repos/springdo/containers-quickstarts/contributors","subscribers_url":"https://api.github.com/repos/springdo/containers-quickstarts/subscribers","subscription_url":"https://api.github.com/repos/springdo/containers-quickstarts/subscription","commits_url":"https://api.github.com/repos/springdo/containers-quickstarts/commits{/sha}","git_commits_url":"https://api.github.com/repos/springdo/containers-quickstarts/git/commits{/sha}","comments_url":"https://api.github.com/repos/springdo/containers-quickstarts/comments{/number}","issue_comment_url":"https://api.github.com/repos/springdo/containers-quickstarts/issues/comments{/number}","contents_url":"https://api.github.com/repos/springdo/containers-quickstarts/contents/{+path}","compare_url":"https://api.github.com/repos/springdo/containers-quickstarts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/springdo/containers-quickstarts/merges","archive_url":"https://api.github.com/repos/springdo/containers-quickstarts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/springdo/containers-quickstarts/downloads","issues_url":"https://api.github.com/repos/springdo/containers-quickstarts/issues{/number}","pulls_url":"https://api.github.com/repos/springdo/containers-quickstarts/pulls{/number}","milestones_url":"https://api.github.com/repos/springdo/containers-quickstarts/milestones{/number}","notifications_url":"https://api.github.com/repos/springdo/containers-quickstarts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/springdo/containers-quickstarts/labels{/name}","releases_url":"https://api.github.com/repos/springdo/containers-quickstarts/releases{/id}","deployments_url":"https://api.github.com/repos/springdo/containers-quickstarts/deployments","created_at":"2018-03-13T16:13:25Z","updated_at":"2018-05-31T09:35:36Z","pushed_at":"2018-06-13T15:07:34Z","git_url":"git://github.com/springdo/containers-quickstarts.git","ssh_url":"git@github.com:springdo/containers-quickstarts.git","clone_url":"https://github.com/springdo/containers-quickstarts.git","svn_url":"https://github.com/springdo/containers-quickstarts","homepage":"","size":2228,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redhat-cop:master","ref":"master","sha":"38276a081e2f72486b84f811472b3770a7258694","user":{"login":"redhat-cop","id":21339385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzM5Mzg1","avatar_url":"https://avatars2.githubusercontent.com/u/21339385?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-cop","html_url":"https://github.com/redhat-cop","followers_url":"https://api.github.com/users/redhat-cop/followers","following_url":"https://api.github.com/users/redhat-cop/following{/other_user}","gists_url":"https://api.github.com/users/redhat-cop/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-cop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-cop/subscriptions","organizations_url":"https://api.github.com/users/redhat-cop/orgs","repos_url":"https://api.github.com/users/redhat-cop/repos","events_url":"https://api.github.com/users/redhat-cop/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-cop/received_events","type":"Organization","site_admin":false},"repo":{"id":66989249,"node_id":"MDEwOlJlcG9zaXRvcnk2Njk4OTI0OQ==","name":"containers-quickstarts","full_name":"redhat-cop/containers-quickstarts","owner":{"login":"redhat-cop","id":21339385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzM5Mzg1","avatar_url":"https://avatars2.githubusercontent.com/u/21339385?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-cop","html_url":"https://github.com/redhat-cop","followers_url":"https://api.github.com/users/redhat-cop/followers","following_url":"https://api.github.com/users/redhat-cop/following{/other_user}","gists_url":"https://api.github.com/users/redhat-cop/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-cop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-cop/subscriptions","organizations_url":"https://api.github.com/users/redhat-cop/orgs","repos_url":"https://api.github.com/users/redhat-cop/repos","events_url":"https://api.github.com/users/redhat-cop/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-cop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhat-cop/containers-quickstarts","description":"Images & templates for deploying software to OpenShift","fork":false,"url":"https://api.github.com/repos/redhat-cop/containers-quickstarts","forks_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/forks","keys_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/teams","hooks_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/hooks","issue_events_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/events","assignees_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/tags","blobs_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/languages","stargazers_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/stargazers","contributors_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/contributors","subscribers_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/subscribers","subscription_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/subscription","commits_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/merges","archive_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/downloads","issues_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/labels{/name}","releases_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-cop/containers-quickstarts/deployments","created_at":"2016-08-31T00:56:55Z","updated_at":"2018-06-15T22:18:33Z","pushed_at":"2018-06-15T20:56:39Z","git_url":"git://github.com/redhat-cop/containers-quickstarts.git","ssh_url":"git@github.com:redhat-cop/containers-quickstarts.git","clone_url":"https://github.com/redhat-cop/containers-quickstarts.git","svn_url":"https://github.com/redhat-cop/containers-quickstarts","homepage":"","size":283,"stargazers_count":62,"watchers_count":62,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":76,"open_issues":21,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/98"},"html":{"href":"https://github.com/redhat-cop/containers-quickstarts/pull/98"},"issue":{"href":"https://api.github.com/repos/redhat-cop/containers-quickstarts/issues/98"},"comments":{"href":"https://api.github.com/repos/redhat-cop/containers-quickstarts/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-cop/containers-quickstarts/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-cop/containers-quickstarts/statuses/06165bad60812878052b3bfe22bb5240c27c723b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pabrahamsson"}}