{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/203669146","pull_request_review_id":138602393,"id":203669146,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzY2OTE0Ng==","diff_hunk":"@@ -0,0 +1,115 @@\n+# Diagnostic Tooling Support Tiers\n+\n+Diagnostic tooling is important to the consumers of Node.js. It is used both\n+in development and in production in order to investigate problems.  The failure\n+of one of these tools may be as big a problem for an end user as a bug within\n+the runtime itself.\n+\n+The Node.js project has assessed the tools and the APIs which support those\n+tools. Each of the tools and APIs has been put them into one of\n+the following tiers.  \n+\n+* Tier 1 - Mmust always be working for all\n+  Current and LTS Node.js releases. A release will not be shipped if the test\n+  suite for the tool/API is not green. To be considered for inclusion\n+  in this tier it must have a good test suite and that test suite and a job\n+  must exist in the Node.js CI so that it can be run as part of the release\n+  process.  No commit to master should break this tool/API if the next\n+  release is within 1 month.","path":"doc/guides/diagnostic-tooling-support-tiers.md","position":18,"original_position":18,"commit_id":"4ca9894c392300bb8def9a6990c9b190fe16c7cd","original_commit_id":"4ca9894c392300bb8def9a6990c9b190fe16c7cd","user":{"login":"targos","id":2352663,"node_id":"MDQ6VXNlcjIzNTI2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"body":"I think you can remove the condition. Current releases usually happen at least once a month.","created_at":"2018-07-19T10:01:29Z","updated_at":"2018-07-19T10:01:29Z","html_url":"https://github.com/nodejs/node/pull/21870#discussion_r203669146","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/21870","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/203669146"},"html":{"href":"https://github.com/nodejs/node/pull/21870#discussion_r203669146"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/21870"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21870","id":202301803,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzAxODAz","html_url":"https://github.com/nodejs/node/pull/21870","diff_url":"https://github.com/nodejs/node/pull/21870.diff","patch_url":"https://github.com/nodejs/node/pull/21870.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/21870","number":21870,"state":"open","locked":false,"title":"doc: initial cut at support tiers for diag tools","user":{"login":"mhdawson","id":9373002,"node_id":"MDQ6VXNlcjkzNzMwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/9373002?v=4","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [X] documentation is changed or added\r\n- [X] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\nDiscussion on support tiers for diagnostic tools started at the Diagnostic summit earlier in the year.  This specific text was discussed in the latest Diagnostics WG meeting and then tweaked based on the discussion. The goal would be to move tools to the target tier overtime as we manage to add the required testing.\r\n\r\n@nodejs/diagnostics, @nodejs/release, @nodejs/tsc as this requires broad agreement on the approach/direction.","created_at":"2018-07-18T15:56:17Z","updated_at":"2018-07-19T10:01:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dea3dec92b225d85d746e0c6e7d574d454636a8a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267517,"node_id":"MDU6TGFiZWwxNTUyNjc1MTc=","url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/21870/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/21870/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21870/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/4ca9894c392300bb8def9a6990c9b190fe16c7cd","head":{"label":"mhdawson:diag-tiers","ref":"diag-tiers","sha":"4ca9894c392300bb8def9a6990c9b190fe16c7cd","user":{"login":"mhdawson","id":9373002,"node_id":"MDQ6VXNlcjkzNzMwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/9373002?v=4","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"repo":{"id":38691521,"node_id":"MDEwOlJlcG9zaXRvcnkzODY5MTUyMQ==","name":"io.js","full_name":"mhdawson/io.js","owner":{"login":"mhdawson","id":9373002,"node_id":"MDQ6VXNlcjkzNzMwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/9373002?v=4","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhdawson/io.js","description":"Future Node.js releases will be based on io.js","fork":true,"url":"https://api.github.com/repos/mhdawson/io.js","forks_url":"https://api.github.com/repos/mhdawson/io.js/forks","keys_url":"https://api.github.com/repos/mhdawson/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhdawson/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhdawson/io.js/teams","hooks_url":"https://api.github.com/repos/mhdawson/io.js/hooks","issue_events_url":"https://api.github.com/repos/mhdawson/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/mhdawson/io.js/events","assignees_url":"https://api.github.com/repos/mhdawson/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/mhdawson/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/mhdawson/io.js/tags","blobs_url":"https://api.github.com/repos/mhdawson/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhdawson/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhdawson/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhdawson/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhdawson/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mhdawson/io.js/languages","stargazers_url":"https://api.github.com/repos/mhdawson/io.js/stargazers","contributors_url":"https://api.github.com/repos/mhdawson/io.js/contributors","subscribers_url":"https://api.github.com/repos/mhdawson/io.js/subscribers","subscription_url":"https://api.github.com/repos/mhdawson/io.js/subscription","commits_url":"https://api.github.com/repos/mhdawson/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhdawson/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhdawson/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhdawson/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhdawson/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/mhdawson/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhdawson/io.js/merges","archive_url":"https://api.github.com/repos/mhdawson/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhdawson/io.js/downloads","issues_url":"https://api.github.com/repos/mhdawson/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/mhdawson/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mhdawson/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mhdawson/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhdawson/io.js/labels{/name}","releases_url":"https://api.github.com/repos/mhdawson/io.js/releases{/id}","deployments_url":"https://api.github.com/repos/mhdawson/io.js/deployments","created_at":"2015-07-07T14:04:11Z","updated_at":"2017-07-31T07:04:26Z","pushed_at":"2018-07-18T15:36:30Z","git_url":"git://github.com/mhdawson/io.js.git","ssh_url":"git@github.com:mhdawson/io.js.git","clone_url":"https://github.com/mhdawson/io.js.git","svn_url":"https://github.com/mhdawson/io.js","homepage":"https://iojs.org","size":347518,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"e406cca5c3eb768dd66301fcac5429223e200955","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-07-19T09:59:12Z","pushed_at":"2018-07-19T09:53:00Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":392358,"stargazers_count":51402,"watchers_count":51402,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10799,"mirror_url":null,"archived":false,"open_issues_count":784,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10799,"open_issues":784,"watchers":51402,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/21870"},"html":{"href":"https://github.com/nodejs/node/pull/21870"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/21870"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/21870/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/21870/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/21870/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/4ca9894c392300bb8def9a6990c9b190fe16c7cd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"targos"}}