{"action":"created","comment":{"url":"https://api.github.com/repos/fluencelabs/fluence/pulls/comments/167860590","pull_request_review_id":96135787,"id":167860590,"diff_hunk":"@@ -134,7 +125,8 @@ object Ecdsa {\n   /**\n    * size of key is 256 bit\n    * `secp256k1` refers to the parameters of the ECDSA curve\n-   * `SHA256withECDSA` Preferably the size of the key is greater than or equal to the digest algorithm\n+   * `NONEwithECDSA with sha-256 hasher` Preferably the size of the key is greater than or equal to the digest algorithm\n+   * don't use `SHA256WithECDSA` because of non-compatibility with javascript libraries\n    */\n-  lazy val ecdsa_secp256k1_sha256 = new Ecdsa(\"secp256k1\", \"SHA256withECDSA\")\n+  def ecdsa_secp256k1_sha256[F[_]] = new Ecdsa(\"secp256k1\", \"NONEwithECDSA\", Some(JdkCryptoHasher.Sha256))","path":"crypto/jvm/src/main/scala/fluence/crypto/algorithm/Ecdsa.scala","position":143,"original_position":143,"commit_id":"8d099821bdca79ceb86eb0c803e374d1844437b8","original_commit_id":"8d099821bdca79ceb86eb0c803e374d1844437b8","user":{"login":"alari","id":683668,"avatar_url":"https://avatars1.githubusercontent.com/u/683668?v=4","gravatar_id":"","url":"https://api.github.com/users/alari","html_url":"https://github.com/alari","followers_url":"https://api.github.com/users/alari/followers","following_url":"https://api.github.com/users/alari/following{/other_user}","gists_url":"https://api.github.com/users/alari/gists{/gist_id}","starred_url":"https://api.github.com/users/alari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alari/subscriptions","organizations_url":"https://api.github.com/users/alari/orgs","repos_url":"https://api.github.com/users/alari/repos","events_url":"https://api.github.com/users/alari/events{/privacy}","received_events_url":"https://api.github.com/users/alari/received_events","type":"User","site_admin":false},"body":"Why do you need `F[_]` here?","created_at":"2018-02-13T13:18:17Z","updated_at":"2018-02-13T13:19:55Z","html_url":"https://github.com/fluencelabs/fluence/pull/37#discussion_r167860590","pull_request_url":"https://api.github.com/repos/fluencelabs/fluence/pulls/37","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fluencelabs/fluence/pulls/comments/167860590"},"html":{"href":"https://github.com/fluencelabs/fluence/pull/37#discussion_r167860590"},"pull_request":{"href":"https://api.github.com/repos/fluencelabs/fluence/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/fluencelabs/fluence/pulls/37","id":168627948,"html_url":"https://github.com/fluencelabs/fluence/pull/37","diff_url":"https://github.com/fluencelabs/fluence/pull/37.diff","patch_url":"https://github.com/fluencelabs/fluence/pull/37.patch","issue_url":"https://api.github.com/repos/fluencelabs/fluence/issues/37","number":37,"state":"open","locked":false,"title":"Ecdsa for scalajs","user":{"login":"DieMyst","id":4075572,"avatar_url":"https://avatars3.githubusercontent.com/u/4075572?v=4","gravatar_id":"","url":"https://api.github.com/users/DieMyst","html_url":"https://github.com/DieMyst","followers_url":"https://api.github.com/users/DieMyst/followers","following_url":"https://api.github.com/users/DieMyst/following{/other_user}","gists_url":"https://api.github.com/users/DieMyst/gists{/gist_id}","starred_url":"https://api.github.com/users/DieMyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DieMyst/subscriptions","organizations_url":"https://api.github.com/users/DieMyst/orgs","repos_url":"https://api.github.com/users/DieMyst/repos","events_url":"https://api.github.com/users/DieMyst/events{/privacy}","received_events_url":"https://api.github.com/users/DieMyst/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-12T16:37:24Z","updated_at":"2018-02-13T13:19:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"416533a090f605f7d51873bf13f4f32d71c6ce63","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fluencelabs/fluence/pulls/37/commits","review_comments_url":"https://api.github.com/repos/fluencelabs/fluence/pulls/37/comments","review_comment_url":"https://api.github.com/repos/fluencelabs/fluence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluencelabs/fluence/issues/37/comments","statuses_url":"https://api.github.com/repos/fluencelabs/fluence/statuses/8d099821bdca79ceb86eb0c803e374d1844437b8","head":{"label":"fluencelabs:ecdsa-for-scalajs","ref":"ecdsa-for-scalajs","sha":"8d099821bdca79ceb86eb0c803e374d1844437b8","user":{"login":"fluencelabs","id":30414417,"avatar_url":"https://avatars1.githubusercontent.com/u/30414417?v=4","gravatar_id":"","url":"https://api.github.com/users/fluencelabs","html_url":"https://github.com/fluencelabs","followers_url":"https://api.github.com/users/fluencelabs/followers","following_url":"https://api.github.com/users/fluencelabs/following{/other_user}","gists_url":"https://api.github.com/users/fluencelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/fluencelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluencelabs/subscriptions","organizations_url":"https://api.github.com/users/fluencelabs/orgs","repos_url":"https://api.github.com/users/fluencelabs/repos","events_url":"https://api.github.com/users/fluencelabs/events{/privacy}","received_events_url":"https://api.github.com/users/fluencelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":114768657,"name":"fluence","full_name":"fluencelabs/fluence","owner":{"login":"fluencelabs","id":30414417,"avatar_url":"https://avatars1.githubusercontent.com/u/30414417?v=4","gravatar_id":"","url":"https://api.github.com/users/fluencelabs","html_url":"https://github.com/fluencelabs","followers_url":"https://api.github.com/users/fluencelabs/followers","following_url":"https://api.github.com/users/fluencelabs/following{/other_user}","gists_url":"https://api.github.com/users/fluencelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/fluencelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluencelabs/subscriptions","organizations_url":"https://api.github.com/users/fluencelabs/orgs","repos_url":"https://api.github.com/users/fluencelabs/repos","events_url":"https://api.github.com/users/fluencelabs/events{/privacy}","received_events_url":"https://api.github.com/users/fluencelabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluencelabs/fluence","description":"Fluence is the decentralized database which securely stores structured data","fork":false,"url":"https://api.github.com/repos/fluencelabs/fluence","forks_url":"https://api.github.com/repos/fluencelabs/fluence/forks","keys_url":"https://api.github.com/repos/fluencelabs/fluence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluencelabs/fluence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluencelabs/fluence/teams","hooks_url":"https://api.github.com/repos/fluencelabs/fluence/hooks","issue_events_url":"https://api.github.com/repos/fluencelabs/fluence/issues/events{/number}","events_url":"https://api.github.com/repos/fluencelabs/fluence/events","assignees_url":"https://api.github.com/repos/fluencelabs/fluence/assignees{/user}","branches_url":"https://api.github.com/repos/fluencelabs/fluence/branches{/branch}","tags_url":"https://api.github.com/repos/fluencelabs/fluence/tags","blobs_url":"https://api.github.com/repos/fluencelabs/fluence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluencelabs/fluence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluencelabs/fluence/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluencelabs/fluence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluencelabs/fluence/statuses/{sha}","languages_url":"https://api.github.com/repos/fluencelabs/fluence/languages","stargazers_url":"https://api.github.com/repos/fluencelabs/fluence/stargazers","contributors_url":"https://api.github.com/repos/fluencelabs/fluence/contributors","subscribers_url":"https://api.github.com/repos/fluencelabs/fluence/subscribers","subscription_url":"https://api.github.com/repos/fluencelabs/fluence/subscription","commits_url":"https://api.github.com/repos/fluencelabs/fluence/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluencelabs/fluence/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluencelabs/fluence/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluencelabs/fluence/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluencelabs/fluence/contents/{+path}","compare_url":"https://api.github.com/repos/fluencelabs/fluence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluencelabs/fluence/merges","archive_url":"https://api.github.com/repos/fluencelabs/fluence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluencelabs/fluence/downloads","issues_url":"https://api.github.com/repos/fluencelabs/fluence/issues{/number}","pulls_url":"https://api.github.com/repos/fluencelabs/fluence/pulls{/number}","milestones_url":"https://api.github.com/repos/fluencelabs/fluence/milestones{/number}","notifications_url":"https://api.github.com/repos/fluencelabs/fluence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluencelabs/fluence/labels{/name}","releases_url":"https://api.github.com/repos/fluencelabs/fluence/releases{/id}","deployments_url":"https://api.github.com/repos/fluencelabs/fluence/deployments","created_at":"2017-12-19T13:31:11Z","updated_at":"2018-02-08T14:17:26Z","pushed_at":"2018-02-12T22:16:02Z","git_url":"git://github.com/fluencelabs/fluence.git","ssh_url":"git@github.com:fluencelabs/fluence.git","clone_url":"https://github.com/fluencelabs/fluence.git","svn_url":"https://github.com/fluencelabs/fluence","homepage":null,"size":716,"stargazers_count":14,"watchers_count":14,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":1,"watchers":14,"default_branch":"master"}},"base":{"label":"fluencelabs:master","ref":"master","sha":"a1d8ddc7aeb88b5389bda3d1659bce46bb269171","user":{"login":"fluencelabs","id":30414417,"avatar_url":"https://avatars1.githubusercontent.com/u/30414417?v=4","gravatar_id":"","url":"https://api.github.com/users/fluencelabs","html_url":"https://github.com/fluencelabs","followers_url":"https://api.github.com/users/fluencelabs/followers","following_url":"https://api.github.com/users/fluencelabs/following{/other_user}","gists_url":"https://api.github.com/users/fluencelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/fluencelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluencelabs/subscriptions","organizations_url":"https://api.github.com/users/fluencelabs/orgs","repos_url":"https://api.github.com/users/fluencelabs/repos","events_url":"https://api.github.com/users/fluencelabs/events{/privacy}","received_events_url":"https://api.github.com/users/fluencelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":114768657,"name":"fluence","full_name":"fluencelabs/fluence","owner":{"login":"fluencelabs","id":30414417,"avatar_url":"https://avatars1.githubusercontent.com/u/30414417?v=4","gravatar_id":"","url":"https://api.github.com/users/fluencelabs","html_url":"https://github.com/fluencelabs","followers_url":"https://api.github.com/users/fluencelabs/followers","following_url":"https://api.github.com/users/fluencelabs/following{/other_user}","gists_url":"https://api.github.com/users/fluencelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/fluencelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluencelabs/subscriptions","organizations_url":"https://api.github.com/users/fluencelabs/orgs","repos_url":"https://api.github.com/users/fluencelabs/repos","events_url":"https://api.github.com/users/fluencelabs/events{/privacy}","received_events_url":"https://api.github.com/users/fluencelabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluencelabs/fluence","description":"Fluence is the decentralized database which securely stores structured data","fork":false,"url":"https://api.github.com/repos/fluencelabs/fluence","forks_url":"https://api.github.com/repos/fluencelabs/fluence/forks","keys_url":"https://api.github.com/repos/fluencelabs/fluence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluencelabs/fluence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluencelabs/fluence/teams","hooks_url":"https://api.github.com/repos/fluencelabs/fluence/hooks","issue_events_url":"https://api.github.com/repos/fluencelabs/fluence/issues/events{/number}","events_url":"https://api.github.com/repos/fluencelabs/fluence/events","assignees_url":"https://api.github.com/repos/fluencelabs/fluence/assignees{/user}","branches_url":"https://api.github.com/repos/fluencelabs/fluence/branches{/branch}","tags_url":"https://api.github.com/repos/fluencelabs/fluence/tags","blobs_url":"https://api.github.com/repos/fluencelabs/fluence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluencelabs/fluence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluencelabs/fluence/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluencelabs/fluence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluencelabs/fluence/statuses/{sha}","languages_url":"https://api.github.com/repos/fluencelabs/fluence/languages","stargazers_url":"https://api.github.com/repos/fluencelabs/fluence/stargazers","contributors_url":"https://api.github.com/repos/fluencelabs/fluence/contributors","subscribers_url":"https://api.github.com/repos/fluencelabs/fluence/subscribers","subscription_url":"https://api.github.com/repos/fluencelabs/fluence/subscription","commits_url":"https://api.github.com/repos/fluencelabs/fluence/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluencelabs/fluence/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluencelabs/fluence/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluencelabs/fluence/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluencelabs/fluence/contents/{+path}","compare_url":"https://api.github.com/repos/fluencelabs/fluence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluencelabs/fluence/merges","archive_url":"https://api.github.com/repos/fluencelabs/fluence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluencelabs/fluence/downloads","issues_url":"https://api.github.com/repos/fluencelabs/fluence/issues{/number}","pulls_url":"https://api.github.com/repos/fluencelabs/fluence/pulls{/number}","milestones_url":"https://api.github.com/repos/fluencelabs/fluence/milestones{/number}","notifications_url":"https://api.github.com/repos/fluencelabs/fluence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluencelabs/fluence/labels{/name}","releases_url":"https://api.github.com/repos/fluencelabs/fluence/releases{/id}","deployments_url":"https://api.github.com/repos/fluencelabs/fluence/deployments","created_at":"2017-12-19T13:31:11Z","updated_at":"2018-02-08T14:17:26Z","pushed_at":"2018-02-12T22:16:02Z","git_url":"git://github.com/fluencelabs/fluence.git","ssh_url":"git@github.com:fluencelabs/fluence.git","clone_url":"https://github.com/fluencelabs/fluence.git","svn_url":"https://github.com/fluencelabs/fluence","homepage":null,"size":716,"stargazers_count":14,"watchers_count":14,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluencelabs/fluence/pulls/37"},"html":{"href":"https://github.com/fluencelabs/fluence/pull/37"},"issue":{"href":"https://api.github.com/repos/fluencelabs/fluence/issues/37"},"comments":{"href":"https://api.github.com/repos/fluencelabs/fluence/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/fluencelabs/fluence/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/fluencelabs/fluence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluencelabs/fluence/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/fluencelabs/fluence/statuses/8d099821bdca79ceb86eb0c803e374d1844437b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alari"}}