{"action":"created","issue":{"url":"https://api.github.com/repos/artefactual/automation-tools/issues/54","repository_url":"https://api.github.com/repos/artefactual/automation-tools","labels_url":"https://api.github.com/repos/artefactual/automation-tools/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/artefactual/automation-tools/issues/54/comments","events_url":"https://api.github.com/repos/artefactual/automation-tools/issues/54/events","html_url":"https://github.com/artefactual/automation-tools/pull/54","id":306715013,"number":54,"title":"Allow a logger to be passed to utils as an arg","user":{"login":"ross-spencer","id":1880412,"avatar_url":"https://avatars1.githubusercontent.com/u/1880412?v=4","gravatar_id":"","url":"https://api.github.com/users/ross-spencer","html_url":"https://github.com/ross-spencer","followers_url":"https://api.github.com/users/ross-spencer/followers","following_url":"https://api.github.com/users/ross-spencer/following{/other_user}","gists_url":"https://api.github.com/users/ross-spencer/gists{/gist_id}","starred_url":"https://api.github.com/users/ross-spencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ross-spencer/subscriptions","organizations_url":"https://api.github.com/users/ross-spencer/orgs","repos_url":"https://api.github.com/users/ross-spencer/repos","events_url":"https://api.github.com/users/ross-spencer/events{/privacy}","received_events_url":"https://api.github.com/users/ross-spencer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-20T03:20:23Z","updated_at":"2018-03-21T00:51:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/artefactual/automation-tools/pulls/54","html_url":"https://github.com/artefactual/automation-tools/pull/54","diff_url":"https://github.com/artefactual/automation-tools/pull/54.diff","patch_url":"https://github.com/artefactual/automation-tools/pull/54.patch"},"body":"The refactor in 699b018 didn't fully take into account the how logging\r\nmight work across the module. Python provides module level thread safe\r\nlogging at the module level through the logging module with appropriate\r\nconfiguration.\r\n\r\nThis fix provides that functionality and additionaly sets a delay write\r\nflag to ensure that no logs are created when there is no logging information\r\noutput.\r\n\r\nFixes #51\r\nResolves #52\r\n\r\nShebangs have been removed from non-executable scripts to resolve #55\r\n\r\nMinor pylint changes added. Importantly, the incorrect check against a\r\nnon-existent ERR_AMCLIENT_UNKNOWN has been replaced with ERR_CLIENT_UNKNOWN.\r\n\r\n--\r\n\r\nThanks to @sevein for his guidance on how to use the logging module effectively. "},"comment":{"url":"https://api.github.com/repos/artefactual/automation-tools/issues/comments/374806068","html_url":"https://github.com/artefactual/automation-tools/pull/54#issuecomment-374806068","issue_url":"https://api.github.com/repos/artefactual/automation-tools/issues/54","id":374806068,"user":{"login":"ross-spencer","id":1880412,"avatar_url":"https://avatars1.githubusercontent.com/u/1880412?v=4","gravatar_id":"","url":"https://api.github.com/users/ross-spencer","html_url":"https://github.com/ross-spencer","followers_url":"https://api.github.com/users/ross-spencer/followers","following_url":"https://api.github.com/users/ross-spencer/following{/other_user}","gists_url":"https://api.github.com/users/ross-spencer/gists{/gist_id}","starred_url":"https://api.github.com/users/ross-spencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ross-spencer/subscriptions","organizations_url":"https://api.github.com/users/ross-spencer/orgs","repos_url":"https://api.github.com/users/ross-spencer/repos","events_url":"https://api.github.com/users/ross-spencer/events{/privacy}","received_events_url":"https://api.github.com/users/ross-spencer/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T00:51:43Z","updated_at":"2018-03-21T00:51:43Z","author_association":"CONTRIBUTOR","body":"@sevein I've made the changes based on your branch. \r\n\r\n@hakamine I am pretty sure this does resolve the issue you were seeing now, because of my previous refactor the logger was still trying to write an empty log file to the default location. It won't happen with this new configuration. It wouldn't have happened previously either i believe because each script had been responsible for its own logging config and wasn't using a shared set of functions.  "}}
{"actor":{"display_login":"ross-spencer"}}