{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3208","repository_url":"https://api.github.com/repos/input-output-hk/cardano-sl","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3208/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3208/comments","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3208/events","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3208","id":339258708,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTYxMTcz","number":3208,"title":"[CDEC-416] Sinbin a few more modules","user":{"login":"mhuesch","id":1151946,"node_id":"MDQ6VXNlcjExNTE5NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1151946?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuesch","html_url":"https://github.com/mhuesch","followers_url":"https://api.github.com/users/mhuesch/followers","following_url":"https://api.github.com/users/mhuesch/following{/other_user}","gists_url":"https://api.github.com/users/mhuesch/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuesch/subscriptions","organizations_url":"https://api.github.com/users/mhuesch/orgs","repos_url":"https://api.github.com/users/mhuesch/repos","events_url":"https://api.github.com/users/mhuesch/events{/privacy}","received_events_url":"https://api.github.com/users/mhuesch/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-08T21:18:35Z","updated_at":"2018-07-20T02:38:09Z","closed_at":"2018-07-20T02:38:09Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3208","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3208","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/3208.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/3208.patch"},"body":"## Description\r\n\r\nMove `Pos.Infra.Communication.Protocol` and it's dependencies to sinbin.\r\n\r\nAlso remove unneeded imports of `Pos.Infra.Binary`.\r\n\r\n## Linked issue\r\n\r\nhttps://iohk.myjetbrains.com/youtrack/issue/CDEC-416\r\n\r\n## Type of change\r\n- [~] 🐞 Bug fix (non-breaking change which fixes an issue)\r\n- [~] 🛠 New feature (non-breaking change which adds functionality)\r\n- [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)\r\n- [x] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc\r\n- [~] 🔨 New or improved tests for existing code\r\n- [~] ⛑ git-flow chore (backport, hotfix, etc)\r\n\r\n## Developer checklist\r\n- [~] I have read the [style guide](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/style-guide.md) document, and my code follows the code style of this project.\r\n- [~] If my code deals with exceptions, it follows the [guidelines](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/exceptions.md).\r\n- [~] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on [cardanodocs.com](https://github.com/input-output-hk/cardanodocs.com), amending the inline [Haddock](https://www.haskell.org/haddock/) comments, any relevant README file or one of the document listed in the [docs](https://github.com/input-output-hk/cardano-sl/tree/develop/docs) directory.\r\n\r\n## Testing checklist\r\n- [~] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments/406471738","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3208#issuecomment-406471738","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3208","id":406471738,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjQ3MTczOA==","user":{"login":"erikd","id":307277,"node_id":"MDQ6VXNlcjMwNzI3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/307277?v=4","gravatar_id":"","url":"https://api.github.com/users/erikd","html_url":"https://github.com/erikd","followers_url":"https://api.github.com/users/erikd/followers","following_url":"https://api.github.com/users/erikd/following{/other_user}","gists_url":"https://api.github.com/users/erikd/gists{/gist_id}","starred_url":"https://api.github.com/users/erikd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikd/subscriptions","organizations_url":"https://api.github.com/users/erikd/orgs","repos_url":"https://api.github.com/users/erikd/repos","events_url":"https://api.github.com/users/erikd/events{/privacy}","received_events_url":"https://api.github.com/users/erikd/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T02:38:09Z","updated_at":"2018-07-20T02:38:09Z","author_association":"MEMBER","body":"This is no longer needed. Problem was solved another way and `Sinbin` is now gone."}}
{"actor":{"display_login":"erikd"}}