{"action":"created","comment":{"url":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/comments/216498056","pull_request_review_id":153993521,"id":216498056,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQ5ODA1Ng==","diff_hunk":"@@ -57,18 +59,19 @@\n @mixin searchInput() {\r\n   padding: 5px 10px;\r\n   border: none;\r\n-  height: 30px;\r\n+  height: $searchHeight;\r\n   // Fixes issues on Safari with type=search\r\n   -webkit-appearance: none;\r\n   border-radius: 0;\r\n   margin: 0;\r\n   // END: Safari fixes\r\n   box-sizing: border-box;\r\n-  font-family: \"Gotham A\", \"Gotham B\", Helvetica, sans-serif !important;\r\n-  font-size: 13px !important;\r\n+  font-family: 'HCo Ringside Narrow SSm', sans-serif !important;\r\n+  font-size: 12px !important;\r\n   font-weight: 500 !important;\r\n   color: $navy !important;\r\n   width: 100%;\r\n+  letter-spacing: 0.3px;\r\n }\r\n \r\n @mixin searchMobile() {\r","path":"components/byu-search/byu-search-common.scss","position":51,"original_position":51,"commit_id":"6a9ac50f8cea7cf4c19e723e9c0a886681d6a5cb","original_commit_id":"1fc2a7669500f50c03e9fe7fa82b7c4538ea8920","user":{"login":"kebowdog","id":19493582,"node_id":"MDQ6VXNlcjE5NDkzNTgy","avatar_url":"https://avatars2.githubusercontent.com/u/19493582?v=4","gravatar_id":"","url":"https://api.github.com/users/kebowdog","html_url":"https://github.com/kebowdog","followers_url":"https://api.github.com/users/kebowdog/followers","following_url":"https://api.github.com/users/kebowdog/following{/other_user}","gists_url":"https://api.github.com/users/kebowdog/gists{/gist_id}","starred_url":"https://api.github.com/users/kebowdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kebowdog/subscriptions","organizations_url":"https://api.github.com/users/kebowdog/orgs","repos_url":"https://api.github.com/users/kebowdog/repos","events_url":"https://api.github.com/users/kebowdog/events{/privacy}","received_events_url":"https://api.github.com/users/kebowdog/received_events","type":"User","site_admin":false},"body":"This has been addressed. There's now 10px of margin between the action buttons, they now have a min width (since \"Action 1\" and \"Action 2\" was creating a little different width and it looked weird on the demos. We can remove that if needed). There's also 23px of space between the bottom of the last action button and the bottom of the menu (which is what the XD document has).\r\n\r\nThe search disappearing is keeping the behavior of the current components. In conversations with Aleni and Rebecca it sounds like the search bar's behavior hasn't been finalized so I've left it alone for now.","created_at":"2018-09-10T22:44:51Z","updated_at":"2018-09-10T22:44:52Z","html_url":"https://github.com/byuweb/byu-theme-components/pull/364#discussion_r216498056","pull_request_url":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/364","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/comments/216498056"},"html":{"href":"https://github.com/byuweb/byu-theme-components/pull/364#discussion_r216498056"},"pull_request":{"href":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/364"}},"in_reply_to_id":216377017},"pull_request":{"url":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/364","id":197211172,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjExMTcy","html_url":"https://github.com/byuweb/byu-theme-components/pull/364","diff_url":"https://github.com/byuweb/byu-theme-components/pull/364.diff","patch_url":"https://github.com/byuweb/byu-theme-components/pull/364.patch","issue_url":"https://api.github.com/repos/byuweb/byu-theme-components/issues/364","number":364,"state":"open","locked":false,"title":"Ringside Update","user":{"login":"kebowdog","id":19493582,"node_id":"MDQ6VXNlcjE5NDkzNTgy","avatar_url":"https://avatars2.githubusercontent.com/u/19493582?v=4","gravatar_id":"","url":"https://api.github.com/users/kebowdog","html_url":"https://github.com/kebowdog","followers_url":"https://api.github.com/users/kebowdog/followers","following_url":"https://api.github.com/users/kebowdog/following{/other_user}","gists_url":"https://api.github.com/users/kebowdog/gists{/gist_id}","starred_url":"https://api.github.com/users/kebowdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kebowdog/subscriptions","organizations_url":"https://api.github.com/users/kebowdog/orgs","repos_url":"https://api.github.com/users/kebowdog/repos","events_url":"https://api.github.com/users/kebowdog/events{/privacy}","received_events_url":"https://api.github.com/users/kebowdog/received_events","type":"User","site_admin":false},"body":"# Summary of Changes\r\n\r\n**Fixes Issue #(Add issue number here)**\r\n\r\n*What did you change? If this is a bug fix, how did you fix it?*\r\nUpdated font references to ringside, fixed sizing and weights to match latest specs\r\n\r\n**If this fixes styling, please include before and after screenshots!**\r\n\r\nBefore:\r\n![image](https://user-images.githubusercontent.com/19493582/41870941-b65fd410-787a-11e8-9569-1f6dd33a3bf2.png)\r\n\r\n![image](https://user-images.githubusercontent.com/19493582/41870955-c080feba-787a-11e8-8f46-9000c2d1ff48.png)\r\n\r\n\r\nAfter:\r\n\r\n![image](https://user-images.githubusercontent.com/19493582/41870915-a1b8c846-787a-11e8-8904-77cffc7dbc7b.png)\r\n\r\n![image](https://user-images.githubusercontent.com/19493582/41870928-aac26726-787a-11e8-9700-5a22c35603b3.png)\r\n\r\n\r\n# Browser Testing\r\n\r\n**I have tested these changes in:**\r\n\r\n*Add an x in all the boxes that apply. Please mark desktop and mobile\r\nbrowsers separately.*\r\n\r\n## Desktop Browsers\r\n\r\n- [x] Google Chrome\r\n- [x] Mozilla Firefox\r\n- [ ] Apple Safari\r\n- [x] Microsoft Edge\r\n- [x] Microsoft Internet Explorer 11\r\n- [ ] Other (please specify)\r\n\r\n## Mobile Browsers\r\n\r\n- [ ] Any browser on iOS\r\n- [ ] Chrome for Android\r\n- [ ] Firefox Mobile for Android\r\n- [ ] Other (please specify)\r\n\r\n**We support the last two versions of Chrome, Firefox, Safari, and Edge,\r\nplus Internet Explorer 11.**\r\n\r\n\r\n\r\n","created_at":"2018-06-25T19:23:23Z","updated_at":"2018-09-10T22:44:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5259edb1b130e578c3ab641df6594c29c5565158","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Gi60s","id":714117,"node_id":"MDQ6VXNlcjcxNDExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/714117?v=4","gravatar_id":"","url":"https://api.github.com/users/Gi60s","html_url":"https://github.com/Gi60s","followers_url":"https://api.github.com/users/Gi60s/followers","following_url":"https://api.github.com/users/Gi60s/following{/other_user}","gists_url":"https://api.github.com/users/Gi60s/gists{/gist_id}","starred_url":"https://api.github.com/users/Gi60s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gi60s/subscriptions","organizations_url":"https://api.github.com/users/Gi60s/orgs","repos_url":"https://api.github.com/users/Gi60s/repos","events_url":"https://api.github.com/users/Gi60s/events{/privacy}","received_events_url":"https://api.github.com/users/Gi60s/received_events","type":"User","site_admin":false},{"login":"rburkey87","id":25965299,"node_id":"MDQ6VXNlcjI1OTY1Mjk5","avatar_url":"https://avatars1.githubusercontent.com/u/25965299?v=4","gravatar_id":"","url":"https://api.github.com/users/rburkey87","html_url":"https://github.com/rburkey87","followers_url":"https://api.github.com/users/rburkey87/followers","following_url":"https://api.github.com/users/rburkey87/following{/other_user}","gists_url":"https://api.github.com/users/rburkey87/gists{/gist_id}","starred_url":"https://api.github.com/users/rburkey87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rburkey87/subscriptions","organizations_url":"https://api.github.com/users/rburkey87/orgs","repos_url":"https://api.github.com/users/rburkey87/repos","events_url":"https://api.github.com/users/rburkey87/events{/privacy}","received_events_url":"https://api.github.com/users/rburkey87/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":588388389,"node_id":"MDU6TGFiZWw1ODgzODgzODk=","url":"https://api.github.com/repos/byuweb/byu-theme-components/labels/spec-change","name":"spec-change","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/364/commits","review_comments_url":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/364/comments","review_comment_url":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/byuweb/byu-theme-components/issues/364/comments","statuses_url":"https://api.github.com/repos/byuweb/byu-theme-components/statuses/6a9ac50f8cea7cf4c19e723e9c0a886681d6a5cb","head":{"label":"byuweb:ringside-switch","ref":"ringside-switch","sha":"6a9ac50f8cea7cf4c19e723e9c0a886681d6a5cb","user":{"login":"byuweb","id":2080063,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODAwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2080063?v=4","gravatar_id":"","url":"https://api.github.com/users/byuweb","html_url":"https://github.com/byuweb","followers_url":"https://api.github.com/users/byuweb/followers","following_url":"https://api.github.com/users/byuweb/following{/other_user}","gists_url":"https://api.github.com/users/byuweb/gists{/gist_id}","starred_url":"https://api.github.com/users/byuweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byuweb/subscriptions","organizations_url":"https://api.github.com/users/byuweb/orgs","repos_url":"https://api.github.com/users/byuweb/repos","events_url":"https://api.github.com/users/byuweb/events{/privacy}","received_events_url":"https://api.github.com/users/byuweb/received_events","type":"Organization","site_admin":false},"repo":{"id":73127259,"node_id":"MDEwOlJlcG9zaXRvcnk3MzEyNzI1OQ==","name":"byu-theme-components","full_name":"byuweb/byu-theme-components","owner":{"login":"byuweb","id":2080063,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODAwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2080063?v=4","gravatar_id":"","url":"https://api.github.com/users/byuweb","html_url":"https://github.com/byuweb","followers_url":"https://api.github.com/users/byuweb/followers","following_url":"https://api.github.com/users/byuweb/following{/other_user}","gists_url":"https://api.github.com/users/byuweb/gists{/gist_id}","starred_url":"https://api.github.com/users/byuweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byuweb/subscriptions","organizations_url":"https://api.github.com/users/byuweb/orgs","repos_url":"https://api.github.com/users/byuweb/repos","events_url":"https://api.github.com/users/byuweb/events{/privacy}","received_events_url":"https://api.github.com/users/byuweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/byuweb/byu-theme-components","description":"Web Components implementing the 2017 theme.","fork":false,"url":"https://api.github.com/repos/byuweb/byu-theme-components","forks_url":"https://api.github.com/repos/byuweb/byu-theme-components/forks","keys_url":"https://api.github.com/repos/byuweb/byu-theme-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/byuweb/byu-theme-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/byuweb/byu-theme-components/teams","hooks_url":"https://api.github.com/repos/byuweb/byu-theme-components/hooks","issue_events_url":"https://api.github.com/repos/byuweb/byu-theme-components/issues/events{/number}","events_url":"https://api.github.com/repos/byuweb/byu-theme-components/events","assignees_url":"https://api.github.com/repos/byuweb/byu-theme-components/assignees{/user}","branches_url":"https://api.github.com/repos/byuweb/byu-theme-components/branches{/branch}","tags_url":"https://api.github.com/repos/byuweb/byu-theme-components/tags","blobs_url":"https://api.github.com/repos/byuweb/byu-theme-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/byuweb/byu-theme-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/byuweb/byu-theme-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/byuweb/byu-theme-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/byuweb/byu-theme-components/statuses/{sha}","languages_url":"https://api.github.com/repos/byuweb/byu-theme-components/languages","stargazers_url":"https://api.github.com/repos/byuweb/byu-theme-components/stargazers","contributors_url":"https://api.github.com/repos/byuweb/byu-theme-components/contributors","subscribers_url":"https://api.github.com/repos/byuweb/byu-theme-components/subscribers","subscription_url":"https://api.github.com/repos/byuweb/byu-theme-components/subscription","commits_url":"https://api.github.com/repos/byuweb/byu-theme-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/byuweb/byu-theme-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/byuweb/byu-theme-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/byuweb/byu-theme-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/byuweb/byu-theme-components/contents/{+path}","compare_url":"https://api.github.com/repos/byuweb/byu-theme-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/byuweb/byu-theme-components/merges","archive_url":"https://api.github.com/repos/byuweb/byu-theme-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/byuweb/byu-theme-components/downloads","issues_url":"https://api.github.com/repos/byuweb/byu-theme-components/issues{/number}","pulls_url":"https://api.github.com/repos/byuweb/byu-theme-components/pulls{/number}","milestones_url":"https://api.github.com/repos/byuweb/byu-theme-components/milestones{/number}","notifications_url":"https://api.github.com/repos/byuweb/byu-theme-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/byuweb/byu-theme-components/labels{/name}","releases_url":"https://api.github.com/repos/byuweb/byu-theme-components/releases{/id}","deployments_url":"https://api.github.com/repos/byuweb/byu-theme-components/deployments","created_at":"2016-11-07T22:36:39Z","updated_at":"2018-07-13T17:29:41Z","pushed_at":"2018-09-10T22:42:04Z","git_url":"git://github.com/byuweb/byu-theme-components.git","ssh_url":"git@github.com:byuweb/byu-theme-components.git","clone_url":"https://github.com/byuweb/byu-theme-components.git","svn_url":"https://github.com/byuweb/byu-theme-components","homepage":"http://2017-components-demo.cdn.byu.edu/","size":10176,"stargazers_count":10,"watchers_count":10,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":7,"open_issues":13,"watchers":10,"default_branch":"master"}},"base":{"label":"byuweb:master","ref":"master","sha":"a2a6801e588b9f45c74fadad34b851c076c0baf5","user":{"login":"byuweb","id":2080063,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODAwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2080063?v=4","gravatar_id":"","url":"https://api.github.com/users/byuweb","html_url":"https://github.com/byuweb","followers_url":"https://api.github.com/users/byuweb/followers","following_url":"https://api.github.com/users/byuweb/following{/other_user}","gists_url":"https://api.github.com/users/byuweb/gists{/gist_id}","starred_url":"https://api.github.com/users/byuweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byuweb/subscriptions","organizations_url":"https://api.github.com/users/byuweb/orgs","repos_url":"https://api.github.com/users/byuweb/repos","events_url":"https://api.github.com/users/byuweb/events{/privacy}","received_events_url":"https://api.github.com/users/byuweb/received_events","type":"Organization","site_admin":false},"repo":{"id":73127259,"node_id":"MDEwOlJlcG9zaXRvcnk3MzEyNzI1OQ==","name":"byu-theme-components","full_name":"byuweb/byu-theme-components","owner":{"login":"byuweb","id":2080063,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODAwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2080063?v=4","gravatar_id":"","url":"https://api.github.com/users/byuweb","html_url":"https://github.com/byuweb","followers_url":"https://api.github.com/users/byuweb/followers","following_url":"https://api.github.com/users/byuweb/following{/other_user}","gists_url":"https://api.github.com/users/byuweb/gists{/gist_id}","starred_url":"https://api.github.com/users/byuweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byuweb/subscriptions","organizations_url":"https://api.github.com/users/byuweb/orgs","repos_url":"https://api.github.com/users/byuweb/repos","events_url":"https://api.github.com/users/byuweb/events{/privacy}","received_events_url":"https://api.github.com/users/byuweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/byuweb/byu-theme-components","description":"Web Components implementing the 2017 theme.","fork":false,"url":"https://api.github.com/repos/byuweb/byu-theme-components","forks_url":"https://api.github.com/repos/byuweb/byu-theme-components/forks","keys_url":"https://api.github.com/repos/byuweb/byu-theme-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/byuweb/byu-theme-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/byuweb/byu-theme-components/teams","hooks_url":"https://api.github.com/repos/byuweb/byu-theme-components/hooks","issue_events_url":"https://api.github.com/repos/byuweb/byu-theme-components/issues/events{/number}","events_url":"https://api.github.com/repos/byuweb/byu-theme-components/events","assignees_url":"https://api.github.com/repos/byuweb/byu-theme-components/assignees{/user}","branches_url":"https://api.github.com/repos/byuweb/byu-theme-components/branches{/branch}","tags_url":"https://api.github.com/repos/byuweb/byu-theme-components/tags","blobs_url":"https://api.github.com/repos/byuweb/byu-theme-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/byuweb/byu-theme-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/byuweb/byu-theme-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/byuweb/byu-theme-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/byuweb/byu-theme-components/statuses/{sha}","languages_url":"https://api.github.com/repos/byuweb/byu-theme-components/languages","stargazers_url":"https://api.github.com/repos/byuweb/byu-theme-components/stargazers","contributors_url":"https://api.github.com/repos/byuweb/byu-theme-components/contributors","subscribers_url":"https://api.github.com/repos/byuweb/byu-theme-components/subscribers","subscription_url":"https://api.github.com/repos/byuweb/byu-theme-components/subscription","commits_url":"https://api.github.com/repos/byuweb/byu-theme-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/byuweb/byu-theme-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/byuweb/byu-theme-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/byuweb/byu-theme-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/byuweb/byu-theme-components/contents/{+path}","compare_url":"https://api.github.com/repos/byuweb/byu-theme-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/byuweb/byu-theme-components/merges","archive_url":"https://api.github.com/repos/byuweb/byu-theme-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/byuweb/byu-theme-components/downloads","issues_url":"https://api.github.com/repos/byuweb/byu-theme-components/issues{/number}","pulls_url":"https://api.github.com/repos/byuweb/byu-theme-components/pulls{/number}","milestones_url":"https://api.github.com/repos/byuweb/byu-theme-components/milestones{/number}","notifications_url":"https://api.github.com/repos/byuweb/byu-theme-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/byuweb/byu-theme-components/labels{/name}","releases_url":"https://api.github.com/repos/byuweb/byu-theme-components/releases{/id}","deployments_url":"https://api.github.com/repos/byuweb/byu-theme-components/deployments","created_at":"2016-11-07T22:36:39Z","updated_at":"2018-07-13T17:29:41Z","pushed_at":"2018-09-10T22:42:04Z","git_url":"git://github.com/byuweb/byu-theme-components.git","ssh_url":"git@github.com:byuweb/byu-theme-components.git","clone_url":"https://github.com/byuweb/byu-theme-components.git","svn_url":"https://github.com/byuweb/byu-theme-components","homepage":"http://2017-components-demo.cdn.byu.edu/","size":10176,"stargazers_count":10,"watchers_count":10,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":7,"open_issues":13,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/364"},"html":{"href":"https://github.com/byuweb/byu-theme-components/pull/364"},"issue":{"href":"https://api.github.com/repos/byuweb/byu-theme-components/issues/364"},"comments":{"href":"https://api.github.com/repos/byuweb/byu-theme-components/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/byuweb/byu-theme-components/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/byuweb/byu-theme-components/statuses/6a9ac50f8cea7cf4c19e723e9c0a886681d6a5cb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kebowdog"}}