{"action":"created","comment":{"url":"https://api.github.com/repos/eciis/web/pulls/comments/229684870","pull_request_review_id":170233744,"id":229684870,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTY4NDg3MA==","diff_hunk":"@@ -0,0 +1,90 @@\n+\"use strict\";\n+\n+(function() {\n+\n+    var app = angular.module(\"app\");\n+\n+    var notificationComponentController = function(NotificationService, $state,\n+        RequestDialogService, NOTIFICATION_TYPE){\n+\n+        const ctrl = this;\n+\n+        const callback = {\n+            \"showRequestDialog\": showRequestDialog\n+        }\n+\n+        ctrl.getIcon = function(type) {\n+            return NOTIFICATION_TYPE[type].icon;\n+        };\n+\n+        /**\n+         * In case that notification had action, e.g. INVITE_USER, call showRequestDialog,\n+         *  otherwise if the notification didn't has action will go to notification page.\n+         * This function mark notification like read.\n+         * @param {object} notification - The notification that has or not action and will be mark as read.\n+         * @param {object} event\n+         */\n+        ctrl.action = function action(notification, event) {\n+            const properties = NOTIFICATION_TYPE[notification.entity_type].properties;\n+            const actionNotification = NOTIFICATION_TYPE[notification.entity_type].action;\n+            if (actionNotification){\n+                showRequestDialog(notification, event, properties, callback);","path":"frontend/notification/notificationList.component.js","position":31,"original_position":31,"commit_id":"68550e5c97e8f223f1440c09bea1d0ac84f144fb","original_commit_id":"68550e5c97e8f223f1440c09bea1d0ac84f144fb","user":{"login":"JuliePessoa","id":7011394,"node_id":"MDQ6VXNlcjcwMTEzOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7011394?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliePessoa","html_url":"https://github.com/JuliePessoa","followers_url":"https://api.github.com/users/JuliePessoa/followers","following_url":"https://api.github.com/users/JuliePessoa/following{/other_user}","gists_url":"https://api.github.com/users/JuliePessoa/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliePessoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliePessoa/subscriptions","organizations_url":"https://api.github.com/users/JuliePessoa/orgs","repos_url":"https://api.github.com/users/JuliePessoa/repos","events_url":"https://api.github.com/users/JuliePessoa/events{/privacy}","received_events_url":"https://api.github.com/users/JuliePessoa/received_events","type":"User","site_admin":false},"body":"theres no callback parameter anymore.","created_at":"2018-10-31T13:09:07Z","updated_at":"2018-10-31T13:17:55Z","html_url":"https://github.com/eciis/web/pull/1293#discussion_r229684870","pull_request_url":"https://api.github.com/repos/eciis/web/pulls/1293","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/eciis/web/pulls/comments/229684870"},"html":{"href":"https://github.com/eciis/web/pull/1293#discussion_r229684870"},"pull_request":{"href":"https://api.github.com/repos/eciis/web/pulls/1293"}}},"pull_request":{"url":"https://api.github.com/repos/eciis/web/pulls/1293","id":226965818,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTY1ODE4","html_url":"https://github.com/eciis/web/pull/1293","diff_url":"https://github.com/eciis/web/pull/1293.diff","patch_url":"https://github.com/eciis/web/pull/1293.patch","issue_url":"https://api.github.com/repos/eciis/web/issues/1293","number":1293,"state":"open","locked":false,"title":"Create notifications list component","user":{"login":"MaianaB","id":18709274,"node_id":"MDQ6VXNlcjE4NzA5Mjc0","avatar_url":"https://avatars1.githubusercontent.com/u/18709274?v=4","gravatar_id":"","url":"https://api.github.com/users/MaianaB","html_url":"https://github.com/MaianaB","followers_url":"https://api.github.com/users/MaianaB/followers","following_url":"https://api.github.com/users/MaianaB/following{/other_user}","gists_url":"https://api.github.com/users/MaianaB/gists{/gist_id}","starred_url":"https://api.github.com/users/MaianaB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaianaB/subscriptions","organizations_url":"https://api.github.com/users/MaianaB/orgs","repos_url":"https://api.github.com/users/MaianaB/repos","events_url":"https://api.github.com/users/MaianaB/events{/privacy}","received_events_url":"https://api.github.com/users/MaianaB/received_events","type":"User","site_admin":false},"body":"**Feature/Bug description:** The directive was pretty confusing with many behaviors.\r\n\r\n**Solution:** Separate in directive and component, this PR handles the component that has the array of notification\r\n\r\n**TODO/FIXME:** n/a","created_at":"2018-10-30T15:19:21Z","updated_at":"2018-10-31T13:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f847ce61abf394d043c69c5525de8b23a21e8661","assignee":{"login":"MaianaB","id":18709274,"node_id":"MDQ6VXNlcjE4NzA5Mjc0","avatar_url":"https://avatars1.githubusercontent.com/u/18709274?v=4","gravatar_id":"","url":"https://api.github.com/users/MaianaB","html_url":"https://github.com/MaianaB","followers_url":"https://api.github.com/users/MaianaB/followers","following_url":"https://api.github.com/users/MaianaB/following{/other_user}","gists_url":"https://api.github.com/users/MaianaB/gists{/gist_id}","starred_url":"https://api.github.com/users/MaianaB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaianaB/subscriptions","organizations_url":"https://api.github.com/users/MaianaB/orgs","repos_url":"https://api.github.com/users/MaianaB/repos","events_url":"https://api.github.com/users/MaianaB/events{/privacy}","received_events_url":"https://api.github.com/users/MaianaB/received_events","type":"User","site_admin":false},"assignees":[{"login":"MaianaB","id":18709274,"node_id":"MDQ6VXNlcjE4NzA5Mjc0","avatar_url":"https://avatars1.githubusercontent.com/u/18709274?v=4","gravatar_id":"","url":"https://api.github.com/users/MaianaB","html_url":"https://github.com/MaianaB","followers_url":"https://api.github.com/users/MaianaB/followers","following_url":"https://api.github.com/users/MaianaB/following{/other_user}","gists_url":"https://api.github.com/users/MaianaB/gists{/gist_id}","starred_url":"https://api.github.com/users/MaianaB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaianaB/subscriptions","organizations_url":"https://api.github.com/users/MaianaB/orgs","repos_url":"https://api.github.com/users/MaianaB/repos","events_url":"https://api.github.com/users/MaianaB/events{/privacy}","received_events_url":"https://api.github.com/users/MaianaB/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":858264818,"node_id":"MDU6TGFiZWw4NTgyNjQ4MTg=","url":"https://api.github.com/repos/eciis/web/labels/enhancement","name":"enhancement","color":"e2c88e","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/eciis/web/pulls/1293/commits","review_comments_url":"https://api.github.com/repos/eciis/web/pulls/1293/comments","review_comment_url":"https://api.github.com/repos/eciis/web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eciis/web/issues/1293/comments","statuses_url":"https://api.github.com/repos/eciis/web/statuses/68550e5c97e8f223f1440c09bea1d0ac84f144fb","head":{"label":"eciis:create-notifications-list-comp","ref":"create-notifications-list-comp","sha":"68550e5c97e8f223f1440c09bea1d0ac84f144fb","user":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"repo":{"id":91336041,"node_id":"MDEwOlJlcG9zaXRvcnk5MTMzNjA0MQ==","name":"web","full_name":"eciis/web","private":false,"owner":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eciis/web","description":"AngularJS Frontend with Appengine Python Backend","fork":false,"url":"https://api.github.com/repos/eciis/web","forks_url":"https://api.github.com/repos/eciis/web/forks","keys_url":"https://api.github.com/repos/eciis/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eciis/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eciis/web/teams","hooks_url":"https://api.github.com/repos/eciis/web/hooks","issue_events_url":"https://api.github.com/repos/eciis/web/issues/events{/number}","events_url":"https://api.github.com/repos/eciis/web/events","assignees_url":"https://api.github.com/repos/eciis/web/assignees{/user}","branches_url":"https://api.github.com/repos/eciis/web/branches{/branch}","tags_url":"https://api.github.com/repos/eciis/web/tags","blobs_url":"https://api.github.com/repos/eciis/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eciis/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eciis/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/eciis/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eciis/web/statuses/{sha}","languages_url":"https://api.github.com/repos/eciis/web/languages","stargazers_url":"https://api.github.com/repos/eciis/web/stargazers","contributors_url":"https://api.github.com/repos/eciis/web/contributors","subscribers_url":"https://api.github.com/repos/eciis/web/subscribers","subscription_url":"https://api.github.com/repos/eciis/web/subscription","commits_url":"https://api.github.com/repos/eciis/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/eciis/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/eciis/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/eciis/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/eciis/web/contents/{+path}","compare_url":"https://api.github.com/repos/eciis/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eciis/web/merges","archive_url":"https://api.github.com/repos/eciis/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eciis/web/downloads","issues_url":"https://api.github.com/repos/eciis/web/issues{/number}","pulls_url":"https://api.github.com/repos/eciis/web/pulls{/number}","milestones_url":"https://api.github.com/repos/eciis/web/milestones{/number}","notifications_url":"https://api.github.com/repos/eciis/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eciis/web/labels{/name}","releases_url":"https://api.github.com/repos/eciis/web/releases{/id}","deployments_url":"https://api.github.com/repos/eciis/web/deployments","created_at":"2017-05-15T12:37:06Z","updated_at":"2018-10-30T11:42:04Z","pushed_at":"2018-10-31T12:44:57Z","git_url":"git://github.com/eciis/web.git","ssh_url":"git@github.com:eciis/web.git","clone_url":"https://github.com/eciis/web.git","svn_url":"https://github.com/eciis/web","homepage":"","size":10446,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":3,"watchers":9,"default_branch":"dev"}},"base":{"label":"eciis:refact-notifications-directive","ref":"refact-notifications-directive","sha":"c14235804febf3adc8ee3529e2453fac4c3ec2a8","user":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"repo":{"id":91336041,"node_id":"MDEwOlJlcG9zaXRvcnk5MTMzNjA0MQ==","name":"web","full_name":"eciis/web","private":false,"owner":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eciis/web","description":"AngularJS Frontend with Appengine Python Backend","fork":false,"url":"https://api.github.com/repos/eciis/web","forks_url":"https://api.github.com/repos/eciis/web/forks","keys_url":"https://api.github.com/repos/eciis/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eciis/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eciis/web/teams","hooks_url":"https://api.github.com/repos/eciis/web/hooks","issue_events_url":"https://api.github.com/repos/eciis/web/issues/events{/number}","events_url":"https://api.github.com/repos/eciis/web/events","assignees_url":"https://api.github.com/repos/eciis/web/assignees{/user}","branches_url":"https://api.github.com/repos/eciis/web/branches{/branch}","tags_url":"https://api.github.com/repos/eciis/web/tags","blobs_url":"https://api.github.com/repos/eciis/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eciis/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eciis/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/eciis/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eciis/web/statuses/{sha}","languages_url":"https://api.github.com/repos/eciis/web/languages","stargazers_url":"https://api.github.com/repos/eciis/web/stargazers","contributors_url":"https://api.github.com/repos/eciis/web/contributors","subscribers_url":"https://api.github.com/repos/eciis/web/subscribers","subscription_url":"https://api.github.com/repos/eciis/web/subscription","commits_url":"https://api.github.com/repos/eciis/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/eciis/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/eciis/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/eciis/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/eciis/web/contents/{+path}","compare_url":"https://api.github.com/repos/eciis/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eciis/web/merges","archive_url":"https://api.github.com/repos/eciis/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eciis/web/downloads","issues_url":"https://api.github.com/repos/eciis/web/issues{/number}","pulls_url":"https://api.github.com/repos/eciis/web/pulls{/number}","milestones_url":"https://api.github.com/repos/eciis/web/milestones{/number}","notifications_url":"https://api.github.com/repos/eciis/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eciis/web/labels{/name}","releases_url":"https://api.github.com/repos/eciis/web/releases{/id}","deployments_url":"https://api.github.com/repos/eciis/web/deployments","created_at":"2017-05-15T12:37:06Z","updated_at":"2018-10-30T11:42:04Z","pushed_at":"2018-10-31T12:44:57Z","git_url":"git://github.com/eciis/web.git","ssh_url":"git@github.com:eciis/web.git","clone_url":"https://github.com/eciis/web.git","svn_url":"https://github.com/eciis/web","homepage":"","size":10446,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":3,"watchers":9,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/eciis/web/pulls/1293"},"html":{"href":"https://github.com/eciis/web/pull/1293"},"issue":{"href":"https://api.github.com/repos/eciis/web/issues/1293"},"comments":{"href":"https://api.github.com/repos/eciis/web/issues/1293/comments"},"review_comments":{"href":"https://api.github.com/repos/eciis/web/pulls/1293/comments"},"review_comment":{"href":"https://api.github.com/repos/eciis/web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eciis/web/pulls/1293/commits"},"statuses":{"href":"https://api.github.com/repos/eciis/web/statuses/68550e5c97e8f223f1440c09bea1d0ac84f144fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JuliePessoa"}}