{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments/195968868","pull_request_review_id":129432154,"id":195968868,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTk2ODg2OA==","diff_hunk":"@@ -228,6 +230,35 @@ public Throwable fillInStackTrace() {\n \t\t\t}\n \t\t};\n \t}\n+\t\n+\tprivate static final boolean IS_CASE_SENSITIVE = isCaseSensitive();\n+\t\n+\tprivate static boolean isCaseSensitive() {\n+\t\tString result = System.getProperty(\"org.eclipse.xtext.common.types.access.binary.BinaryClass.ASSUME_CASE_SENSITIVE\", Boolean.toString(inferIsCaseSensitive()));\n+\t\treturn Boolean.parseBoolean(result);\n+\t}\n+\t\n+\tprivate static boolean inferIsCaseSensitive() {","path":"org.eclipse.xtext.common.types/src/org/eclipse/xtext/common/types/access/binary/BinaryClass.java","position":32,"original_position":32,"commit_id":"58946a1f28454130e0d3bb6526b100bd96c61cae","original_commit_id":"58946a1f28454130e0d3bb6526b100bd96c61cae","user":{"login":"szarnekow","id":375492,"node_id":"MDQ6VXNlcjM3NTQ5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/375492?v=4","gravatar_id":"","url":"https://api.github.com/users/szarnekow","html_url":"https://github.com/szarnekow","followers_url":"https://api.github.com/users/szarnekow/followers","following_url":"https://api.github.com/users/szarnekow/following{/other_user}","gists_url":"https://api.github.com/users/szarnekow/gists{/gist_id}","starred_url":"https://api.github.com/users/szarnekow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szarnekow/subscriptions","organizations_url":"https://api.github.com/users/szarnekow/orgs","repos_url":"https://api.github.com/users/szarnekow/repos","events_url":"https://api.github.com/users/szarnekow/events{/privacy}","received_events_url":"https://api.github.com/users/szarnekow/received_events","type":"User","site_admin":false},"body":"I did not find a helper in any of our current 3rd party libs. I did not want to introduce a new dependency thus this approach.","created_at":"2018-06-18T05:42:54Z","updated_at":"2018-06-18T05:42:54Z","html_url":"https://github.com/eclipse/xtext-extras/pull/263#discussion_r195968868","pull_request_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/263","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments/195968868"},"html":{"href":"https://github.com/eclipse/xtext-extras/pull/263#discussion_r195968868"},"pull_request":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/263"}},"in_reply_to_id":195967047},"pull_request":{"url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/263","id":195224364,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjI0MzY0","html_url":"https://github.com/eclipse/xtext-extras/pull/263","diff_url":"https://github.com/eclipse/xtext-extras/pull/263.diff","patch_url":"https://github.com/eclipse/xtext-extras/pull/263.patch","issue_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/263","number":263,"state":"open","locked":false,"title":"[#262] Made type lookup case sensitive even on windows","user":{"login":"szarnekow","id":375492,"node_id":"MDQ6VXNlcjM3NTQ5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/375492?v=4","gravatar_id":"","url":"https://api.github.com/users/szarnekow","html_url":"https://github.com/szarnekow","followers_url":"https://api.github.com/users/szarnekow/followers","following_url":"https://api.github.com/users/szarnekow/following{/other_user}","gists_url":"https://api.github.com/users/szarnekow/gists{/gist_id}","starred_url":"https://api.github.com/users/szarnekow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szarnekow/subscriptions","organizations_url":"https://api.github.com/users/szarnekow/orgs","repos_url":"https://api.github.com/users/szarnekow/repos","events_url":"https://api.github.com/users/szarnekow/events{/privacy}","received_events_url":"https://api.github.com/users/szarnekow/received_events","type":"User","site_admin":false},"body":"This appears to be a rather expensive solution for a rare corner case but I'm not sure how to solve this in another way. The file / resource lookup is completely transparent to Java and handled natively by the OS. That's why we need to convert the found name to the canonical name to check if it's the real thing. ","created_at":"2018-06-15T16:22:34Z","updated_at":"2018-06-18T05:42:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6727b3e856eab9215397b30519015259c563e54d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/eclipse/xtext-extras/milestones/7","html_url":"https://github.com/eclipse/xtext-extras/milestone/7","labels_url":"https://api.github.com/repos/eclipse/xtext-extras/milestones/7/labels","id":3123888,"node_id":"MDk6TWlsZXN0b25lMzEyMzg4OA==","number":7,"title":"Release_2.15","description":"","creator":{"login":"cdietrich","id":238736,"node_id":"MDQ6VXNlcjIzODczNg==","avatar_url":"https://avatars2.githubusercontent.com/u/238736?v=4","gravatar_id":"","url":"https://api.github.com/users/cdietrich","html_url":"https://github.com/cdietrich","followers_url":"https://api.github.com/users/cdietrich/followers","following_url":"https://api.github.com/users/cdietrich/following{/other_user}","gists_url":"https://api.github.com/users/cdietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/cdietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdietrich/subscriptions","organizations_url":"https://api.github.com/users/cdietrich/orgs","repos_url":"https://api.github.com/users/cdietrich/repos","events_url":"https://api.github.com/users/cdietrich/events{/privacy}","received_events_url":"https://api.github.com/users/cdietrich/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":6,"state":"open","created_at":"2018-02-17T12:06:21Z","updated_at":"2018-06-15T16:46:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/263/commits","review_comments_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/263/comments","review_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/263/comments","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/58946a1f28454130e0d3bb6526b100bd96c61cae","head":{"label":"eclipse:sz_issue262","ref":"sz_issue262","sha":"58946a1f28454130e0d3bb6526b100bd96c61cae","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":60115647,"node_id":"MDEwOlJlcG9zaXRvcnk2MDExNTY0Nw==","name":"xtext-extras","full_name":"eclipse/xtext-extras","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/xtext-extras","description":"xtext-extras","fork":false,"url":"https://api.github.com/repos/eclipse/xtext-extras","forks_url":"https://api.github.com/repos/eclipse/xtext-extras/forks","keys_url":"https://api.github.com/repos/eclipse/xtext-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/xtext-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/xtext-extras/teams","hooks_url":"https://api.github.com/repos/eclipse/xtext-extras/hooks","issue_events_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/xtext-extras/events","assignees_url":"https://api.github.com/repos/eclipse/xtext-extras/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/xtext-extras/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/xtext-extras/tags","blobs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/xtext-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/xtext-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/xtext-extras/languages","stargazers_url":"https://api.github.com/repos/eclipse/xtext-extras/stargazers","contributors_url":"https://api.github.com/repos/eclipse/xtext-extras/contributors","subscribers_url":"https://api.github.com/repos/eclipse/xtext-extras/subscribers","subscription_url":"https://api.github.com/repos/eclipse/xtext-extras/subscription","commits_url":"https://api.github.com/repos/eclipse/xtext-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/xtext-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/xtext-extras/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/xtext-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/xtext-extras/merges","archive_url":"https://api.github.com/repos/eclipse/xtext-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/xtext-extras/downloads","issues_url":"https://api.github.com/repos/eclipse/xtext-extras/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/xtext-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/xtext-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/xtext-extras/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/xtext-extras/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/xtext-extras/deployments","created_at":"2016-05-31T19:00:27Z","updated_at":"2018-06-11T05:55:52Z","pushed_at":"2018-06-15T16:33:13Z","git_url":"git://github.com/eclipse/xtext-extras.git","ssh_url":"git@github.com:eclipse/xtext-extras.git","clone_url":"https://github.com/eclipse/xtext-extras.git","svn_url":"https://github.com/eclipse/xtext-extras","homepage":null,"size":22401,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":19,"open_issues":27,"watchers":8,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"6ef60a65010ddadfc8e0e839d4d67183384d7c78","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":60115647,"node_id":"MDEwOlJlcG9zaXRvcnk2MDExNTY0Nw==","name":"xtext-extras","full_name":"eclipse/xtext-extras","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/xtext-extras","description":"xtext-extras","fork":false,"url":"https://api.github.com/repos/eclipse/xtext-extras","forks_url":"https://api.github.com/repos/eclipse/xtext-extras/forks","keys_url":"https://api.github.com/repos/eclipse/xtext-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/xtext-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/xtext-extras/teams","hooks_url":"https://api.github.com/repos/eclipse/xtext-extras/hooks","issue_events_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/xtext-extras/events","assignees_url":"https://api.github.com/repos/eclipse/xtext-extras/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/xtext-extras/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/xtext-extras/tags","blobs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/xtext-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/xtext-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/xtext-extras/languages","stargazers_url":"https://api.github.com/repos/eclipse/xtext-extras/stargazers","contributors_url":"https://api.github.com/repos/eclipse/xtext-extras/contributors","subscribers_url":"https://api.github.com/repos/eclipse/xtext-extras/subscribers","subscription_url":"https://api.github.com/repos/eclipse/xtext-extras/subscription","commits_url":"https://api.github.com/repos/eclipse/xtext-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/xtext-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/xtext-extras/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/xtext-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/xtext-extras/merges","archive_url":"https://api.github.com/repos/eclipse/xtext-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/xtext-extras/downloads","issues_url":"https://api.github.com/repos/eclipse/xtext-extras/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/xtext-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/xtext-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/xtext-extras/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/xtext-extras/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/xtext-extras/deployments","created_at":"2016-05-31T19:00:27Z","updated_at":"2018-06-11T05:55:52Z","pushed_at":"2018-06-15T16:33:13Z","git_url":"git://github.com/eclipse/xtext-extras.git","ssh_url":"git@github.com:eclipse/xtext-extras.git","clone_url":"https://github.com/eclipse/xtext-extras.git","svn_url":"https://github.com/eclipse/xtext-extras","homepage":null,"size":22401,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":19,"open_issues":27,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/263"},"html":{"href":"https://github.com/eclipse/xtext-extras/pull/263"},"issue":{"href":"https://api.github.com/repos/eclipse/xtext-extras/issues/263"},"comments":{"href":"https://api.github.com/repos/eclipse/xtext-extras/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/xtext-extras/statuses/58946a1f28454130e0d3bb6526b100bd96c61cae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"szarnekow"}}