{"action":"created","comment":{"url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments/170644182","pull_request_review_id":99361085,"id":170644182,"diff_hunk":"@@ -67,8 +67,12 @@ func init() {\n \t\tdefaultArch = \"aarch64\"\n \tcase \"amd64\":\n \t\tdefaultArch = \"x86_64\"\n+\tcase \"s390x\":\n+\t\tdefaultArch = \"s390x\"\n \t}\n \tswitch {\n+\tcase runtime.GOARCH == \"s390x\":\n+\t\tdefaultAccel = \"kvm\"","path":"src/cmd/linuxkit/run_qemu.go","position":9,"original_position":9,"commit_id":"81ea4c8ee9be4da0342ef198cb0765fe4dcf0d62","original_commit_id":"09a576775389f969d4450f65722e51fa7d90f3c6","user":{"login":"rn","id":3338098,"avatar_url":"https://avatars0.githubusercontent.com/u/3338098?v=4","gravatar_id":"","url":"https://api.github.com/users/rn","html_url":"https://github.com/rn","followers_url":"https://api.github.com/users/rn/followers","following_url":"https://api.github.com/users/rn/following{/other_user}","gists_url":"https://api.github.com/users/rn/gists{/gist_id}","starred_url":"https://api.github.com/users/rn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rn/subscriptions","organizations_url":"https://api.github.com/users/rn/orgs","repos_url":"https://api.github.com/users/rn/repos","events_url":"https://api.github.com/users/rn/events{/privacy}","received_events_url":"https://api.github.com/users/rn/received_events","type":"User","site_admin":false},"body":"@alicefr yes, i think that would be fine.","created_at":"2018-02-26T16:11:29Z","updated_at":"2018-02-26T16:11:29Z","html_url":"https://github.com/linuxkit/linuxkit/pull/2927#discussion_r170644182","pull_request_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2927","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments/170644182"},"html":{"href":"https://github.com/linuxkit/linuxkit/pull/2927#discussion_r170644182"},"pull_request":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2927"}},"in_reply_to_id":170593990},"pull_request":{"url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2927","id":171371874,"html_url":"https://github.com/linuxkit/linuxkit/pull/2927","diff_url":"https://github.com/linuxkit/linuxkit/pull/2927.diff","patch_url":"https://github.com/linuxkit/linuxkit/pull/2927.patch","issue_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2927","number":2927,"state":"open","locked":false,"title":"Add s390x support for Linuxkit binary and tools","user":{"login":"alicefr","id":25296267,"avatar_url":"https://avatars0.githubusercontent.com/u/25296267?v=4","gravatar_id":"","url":"https://api.github.com/users/alicefr","html_url":"https://github.com/alicefr","followers_url":"https://api.github.com/users/alicefr/followers","following_url":"https://api.github.com/users/alicefr/following{/other_user}","gists_url":"https://api.github.com/users/alicefr/gists{/gist_id}","starred_url":"https://api.github.com/users/alicefr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicefr/subscriptions","organizations_url":"https://api.github.com/users/alicefr/orgs","repos_url":"https://api.github.com/users/alicefr/repos","events_url":"https://api.github.com/users/alicefr/events{/privacy}","received_events_url":"https://api.github.com/users/alicefr/received_events","type":"User","site_admin":false},"body":"This PR adds the basic support for s390 architecture on linuxkit\r\ncommand.\r\n\r\nSigned-off-by: Alice Frosi <alice@linux.vnet.ibm.com>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/linuxkit/linuxkit/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\nAdd basic support for s390 systems:\r\n- s390-specific flags to run qemu on s390 architecture\r\n\r\n**- How I did it**\r\nUpdate qemu flag in `src/cmd/linuxkit/`.\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n","created_at":"2018-02-26T13:18:11Z","updated_at":"2018-02-26T16:11:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1de3c4830831b6d2d55b38c918c9c4db89452687","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":572728714,"url":"https://api.github.com/repos/linuxkit/linuxkit/labels/status/0-triage","name":"status/0-triage","color":"eeeeee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2927/commits","review_comments_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2927/comments","review_comment_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2927/comments","statuses_url":"https://api.github.com/repos/linuxkit/linuxkit/statuses/81ea4c8ee9be4da0342ef198cb0765fe4dcf0d62","head":{"label":"alicefr:support_s390","ref":"support_s390","sha":"81ea4c8ee9be4da0342ef198cb0765fe4dcf0d62","user":{"login":"alicefr","id":25296267,"avatar_url":"https://avatars0.githubusercontent.com/u/25296267?v=4","gravatar_id":"","url":"https://api.github.com/users/alicefr","html_url":"https://github.com/alicefr","followers_url":"https://api.github.com/users/alicefr/followers","following_url":"https://api.github.com/users/alicefr/following{/other_user}","gists_url":"https://api.github.com/users/alicefr/gists{/gist_id}","starred_url":"https://api.github.com/users/alicefr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicefr/subscriptions","organizations_url":"https://api.github.com/users/alicefr/orgs","repos_url":"https://api.github.com/users/alicefr/repos","events_url":"https://api.github.com/users/alicefr/events{/privacy}","received_events_url":"https://api.github.com/users/alicefr/received_events","type":"User","site_admin":false},"repo":{"id":122449976,"name":"linuxkit","full_name":"alicefr/linuxkit","owner":{"login":"alicefr","id":25296267,"avatar_url":"https://avatars0.githubusercontent.com/u/25296267?v=4","gravatar_id":"","url":"https://api.github.com/users/alicefr","html_url":"https://github.com/alicefr","followers_url":"https://api.github.com/users/alicefr/followers","following_url":"https://api.github.com/users/alicefr/following{/other_user}","gists_url":"https://api.github.com/users/alicefr/gists{/gist_id}","starred_url":"https://api.github.com/users/alicefr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicefr/subscriptions","organizations_url":"https://api.github.com/users/alicefr/orgs","repos_url":"https://api.github.com/users/alicefr/repos","events_url":"https://api.github.com/users/alicefr/events{/privacy}","received_events_url":"https://api.github.com/users/alicefr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alicefr/linuxkit","description":"A toolkit for building secure, portable and lean operating systems for containers","fork":true,"url":"https://api.github.com/repos/alicefr/linuxkit","forks_url":"https://api.github.com/repos/alicefr/linuxkit/forks","keys_url":"https://api.github.com/repos/alicefr/linuxkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alicefr/linuxkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alicefr/linuxkit/teams","hooks_url":"https://api.github.com/repos/alicefr/linuxkit/hooks","issue_events_url":"https://api.github.com/repos/alicefr/linuxkit/issues/events{/number}","events_url":"https://api.github.com/repos/alicefr/linuxkit/events","assignees_url":"https://api.github.com/repos/alicefr/linuxkit/assignees{/user}","branches_url":"https://api.github.com/repos/alicefr/linuxkit/branches{/branch}","tags_url":"https://api.github.com/repos/alicefr/linuxkit/tags","blobs_url":"https://api.github.com/repos/alicefr/linuxkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alicefr/linuxkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alicefr/linuxkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/alicefr/linuxkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alicefr/linuxkit/statuses/{sha}","languages_url":"https://api.github.com/repos/alicefr/linuxkit/languages","stargazers_url":"https://api.github.com/repos/alicefr/linuxkit/stargazers","contributors_url":"https://api.github.com/repos/alicefr/linuxkit/contributors","subscribers_url":"https://api.github.com/repos/alicefr/linuxkit/subscribers","subscription_url":"https://api.github.com/repos/alicefr/linuxkit/subscription","commits_url":"https://api.github.com/repos/alicefr/linuxkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/alicefr/linuxkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/alicefr/linuxkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/alicefr/linuxkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/alicefr/linuxkit/contents/{+path}","compare_url":"https://api.github.com/repos/alicefr/linuxkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alicefr/linuxkit/merges","archive_url":"https://api.github.com/repos/alicefr/linuxkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alicefr/linuxkit/downloads","issues_url":"https://api.github.com/repos/alicefr/linuxkit/issues{/number}","pulls_url":"https://api.github.com/repos/alicefr/linuxkit/pulls{/number}","milestones_url":"https://api.github.com/repos/alicefr/linuxkit/milestones{/number}","notifications_url":"https://api.github.com/repos/alicefr/linuxkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alicefr/linuxkit/labels{/name}","releases_url":"https://api.github.com/repos/alicefr/linuxkit/releases{/id}","deployments_url":"https://api.github.com/repos/alicefr/linuxkit/deployments","created_at":"2018-02-22T08:20:59Z","updated_at":"2018-02-22T08:21:03Z","pushed_at":"2018-02-26T15:44:11Z","git_url":"git://github.com/alicefr/linuxkit.git","ssh_url":"git@github.com:alicefr/linuxkit.git","clone_url":"https://github.com/alicefr/linuxkit.git","svn_url":"https://github.com/alicefr/linuxkit","homepage":"","size":26796,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linuxkit:master","ref":"master","sha":"c1e464f0f8455e1095ac377eed6c66a1d1cfe2d3","user":{"login":"linuxkit","id":27256246,"avatar_url":"https://avatars2.githubusercontent.com/u/27256246?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxkit","html_url":"https://github.com/linuxkit","followers_url":"https://api.github.com/users/linuxkit/followers","following_url":"https://api.github.com/users/linuxkit/following{/other_user}","gists_url":"https://api.github.com/users/linuxkit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxkit/subscriptions","organizations_url":"https://api.github.com/users/linuxkit/orgs","repos_url":"https://api.github.com/users/linuxkit/repos","events_url":"https://api.github.com/users/linuxkit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxkit/received_events","type":"Organization","site_admin":false},"repo":{"id":46932243,"name":"linuxkit","full_name":"linuxkit/linuxkit","owner":{"login":"linuxkit","id":27256246,"avatar_url":"https://avatars2.githubusercontent.com/u/27256246?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxkit","html_url":"https://github.com/linuxkit","followers_url":"https://api.github.com/users/linuxkit/followers","following_url":"https://api.github.com/users/linuxkit/following{/other_user}","gists_url":"https://api.github.com/users/linuxkit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxkit/subscriptions","organizations_url":"https://api.github.com/users/linuxkit/orgs","repos_url":"https://api.github.com/users/linuxkit/repos","events_url":"https://api.github.com/users/linuxkit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linuxkit/linuxkit","description":"A toolkit for building secure, portable and lean operating systems for containers","fork":false,"url":"https://api.github.com/repos/linuxkit/linuxkit","forks_url":"https://api.github.com/repos/linuxkit/linuxkit/forks","keys_url":"https://api.github.com/repos/linuxkit/linuxkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linuxkit/linuxkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linuxkit/linuxkit/teams","hooks_url":"https://api.github.com/repos/linuxkit/linuxkit/hooks","issue_events_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/events{/number}","events_url":"https://api.github.com/repos/linuxkit/linuxkit/events","assignees_url":"https://api.github.com/repos/linuxkit/linuxkit/assignees{/user}","branches_url":"https://api.github.com/repos/linuxkit/linuxkit/branches{/branch}","tags_url":"https://api.github.com/repos/linuxkit/linuxkit/tags","blobs_url":"https://api.github.com/repos/linuxkit/linuxkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linuxkit/linuxkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linuxkit/linuxkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/linuxkit/linuxkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linuxkit/linuxkit/statuses/{sha}","languages_url":"https://api.github.com/repos/linuxkit/linuxkit/languages","stargazers_url":"https://api.github.com/repos/linuxkit/linuxkit/stargazers","contributors_url":"https://api.github.com/repos/linuxkit/linuxkit/contributors","subscribers_url":"https://api.github.com/repos/linuxkit/linuxkit/subscribers","subscription_url":"https://api.github.com/repos/linuxkit/linuxkit/subscription","commits_url":"https://api.github.com/repos/linuxkit/linuxkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/linuxkit/linuxkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/linuxkit/linuxkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/linuxkit/linuxkit/contents/{+path}","compare_url":"https://api.github.com/repos/linuxkit/linuxkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linuxkit/linuxkit/merges","archive_url":"https://api.github.com/repos/linuxkit/linuxkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linuxkit/linuxkit/downloads","issues_url":"https://api.github.com/repos/linuxkit/linuxkit/issues{/number}","pulls_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls{/number}","milestones_url":"https://api.github.com/repos/linuxkit/linuxkit/milestones{/number}","notifications_url":"https://api.github.com/repos/linuxkit/linuxkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linuxkit/linuxkit/labels{/name}","releases_url":"https://api.github.com/repos/linuxkit/linuxkit/releases{/id}","deployments_url":"https://api.github.com/repos/linuxkit/linuxkit/deployments","created_at":"2015-11-26T14:48:52Z","updated_at":"2018-02-26T15:20:18Z","pushed_at":"2018-02-26T15:36:10Z","git_url":"git://github.com/linuxkit/linuxkit.git","ssh_url":"git@github.com:linuxkit/linuxkit.git","clone_url":"https://github.com/linuxkit/linuxkit.git","svn_url":"https://github.com/linuxkit/linuxkit","homepage":"","size":26751,"stargazers_count":4037,"watchers_count":4037,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":482,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":482,"open_issues":167,"watchers":4037,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2927"},"html":{"href":"https://github.com/linuxkit/linuxkit/pull/2927"},"issue":{"href":"https://api.github.com/repos/linuxkit/linuxkit/issues/2927"},"comments":{"href":"https://api.github.com/repos/linuxkit/linuxkit/issues/2927/comments"},"review_comments":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2927/comments"},"review_comment":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2927/commits"},"statuses":{"href":"https://api.github.com/repos/linuxkit/linuxkit/statuses/81ea4c8ee9be4da0342ef198cb0765fe4dcf0d62"}},"author_association":"NONE"}}
{"actor":{"display_login":"rn"}}