{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/196262921","pull_request_review_id":129781981,"id":196262921,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjI2MjkyMQ==","diff_hunk":"@@ -119,30 +174,37 @@ func (a *Agent) stopService() error {\n \n func (a *Agent) startEnvoy() (err error) {\n \t// Create the configuration object\n-\ta.proxyConfig, err = (&proxyConfigBuilder{\n-\t\tServiceName: a.Config.ServiceName,\n-\t\tAdminPort:   a.proxyAdminPort,\n-\t\tPorts:       a.ports,\n-\t\ttmpDir:      a.Config.TmpDir,\n+\tnodeID := a.generateServiceNode()\n+\ta.envoyConfig, err = (&envoyConfigBuilder{\n+\t\tServiceName:   a.Config.ServiceName,\n+\t\tNodeID:        nodeID,\n+\t\tCluster:       serviceCluster,\n+\t\tAdminPort:     a.proxyAdminPort,\n+\t\tPorts:         a.ports,\n+\t\tDiscoveryHost: \"127.0.0.1\",","path":"pkg/test/local/proxy/envoy/agent/agent.go","position":147,"original_position":147,"commit_id":"d33fdcd2fc42dca011025711f958bbdb8150cfce","original_commit_id":"d33fdcd2fc42dca011025711f958bbdb8150cfce","user":{"login":"nmittler","id":6493296,"node_id":"MDQ6VXNlcjY0OTMyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-06-19T00:16:44Z","updated_at":"2018-06-19T00:36:03Z","html_url":"https://github.com/istio/istio/pull/6332#discussion_r196262921","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/6332","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/196262921"},"html":{"href":"https://github.com/istio/istio/pull/6332#discussion_r196262921"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/6332"}},"in_reply_to_id":196259912},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/6332","id":195250143,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjUwMTQz","html_url":"https://github.com/istio/istio/pull/6332","diff_url":"https://github.com/istio/istio/pull/6332.diff","patch_url":"https://github.com/istio/istio/pull/6332.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/6332","number":6332,"state":"open","locked":false,"title":"[test-framework] Integrating local Pilot and Envoy","user":{"login":"nmittler","id":6493296,"node_id":"MDQ6VXNlcjY0OTMyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"body":"- Updated configuration of Envoy to use discovery v2 API on Pilot\r\n\r\n- Adding a discovery proxy to allow interception of responses from\r\nPilot. This will provide the ability to modify the Envoy configs to\r\nsupport local testing.\r\n\r\n- Updated the agent test to incorporate a local pilot. Also starting\r\nto hash out how to determine whether or not an Envoy has received\r\na configuration update.","created_at":"2018-06-15T18:22:15Z","updated_at":"2018-06-19T00:36:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"375e71696bf9feb876139ad360de9678bfc41951","assignee":null,"assignees":[],"requested_reviewers":[{"login":"PiotrSikora","id":190297,"node_id":"MDQ6VXNlcjE5MDI5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/190297?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrSikora","html_url":"https://github.com/PiotrSikora","followers_url":"https://api.github.com/users/PiotrSikora/followers","following_url":"https://api.github.com/users/PiotrSikora/following{/other_user}","gists_url":"https://api.github.com/users/PiotrSikora/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrSikora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrSikora/subscriptions","organizations_url":"https://api.github.com/users/PiotrSikora/orgs","repos_url":"https://api.github.com/users/PiotrSikora/repos","events_url":"https://api.github.com/users/PiotrSikora/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrSikora/received_events","type":"User","site_admin":false},{"login":"kimikowang","id":25443800,"node_id":"MDQ6VXNlcjI1NDQzODAw","avatar_url":"https://avatars3.githubusercontent.com/u/25443800?v=4","gravatar_id":"","url":"https://api.github.com/users/kimikowang","html_url":"https://github.com/kimikowang","followers_url":"https://api.github.com/users/kimikowang/followers","following_url":"https://api.github.com/users/kimikowang/following{/other_user}","gists_url":"https://api.github.com/users/kimikowang/gists{/gist_id}","starred_url":"https://api.github.com/users/kimikowang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimikowang/subscriptions","organizations_url":"https://api.github.com/users/kimikowang/orgs","repos_url":"https://api.github.com/users/kimikowang/repos","events_url":"https://api.github.com/users/kimikowang/events{/privacy}","received_events_url":"https://api.github.com/users/kimikowang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/6332/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/6332/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/6332/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/d33fdcd2fc42dca011025711f958bbdb8150cfce","head":{"label":"nmittler:local_pilot","ref":"local_pilot","sha":"d33fdcd2fc42dca011025711f958bbdb8150cfce","user":{"login":"nmittler","id":6493296,"node_id":"MDQ6VXNlcjY0OTMyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"repo":{"id":105299964,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyOTk5NjQ=","name":"istio","full_name":"nmittler/istio","owner":{"login":"nmittler","id":6493296,"node_id":"MDQ6VXNlcjY0OTMyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmittler/istio","description":"Sample code, build and tests and governance material for the Istio project.","fork":true,"url":"https://api.github.com/repos/nmittler/istio","forks_url":"https://api.github.com/repos/nmittler/istio/forks","keys_url":"https://api.github.com/repos/nmittler/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmittler/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmittler/istio/teams","hooks_url":"https://api.github.com/repos/nmittler/istio/hooks","issue_events_url":"https://api.github.com/repos/nmittler/istio/issues/events{/number}","events_url":"https://api.github.com/repos/nmittler/istio/events","assignees_url":"https://api.github.com/repos/nmittler/istio/assignees{/user}","branches_url":"https://api.github.com/repos/nmittler/istio/branches{/branch}","tags_url":"https://api.github.com/repos/nmittler/istio/tags","blobs_url":"https://api.github.com/repos/nmittler/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmittler/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmittler/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmittler/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmittler/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/nmittler/istio/languages","stargazers_url":"https://api.github.com/repos/nmittler/istio/stargazers","contributors_url":"https://api.github.com/repos/nmittler/istio/contributors","subscribers_url":"https://api.github.com/repos/nmittler/istio/subscribers","subscription_url":"https://api.github.com/repos/nmittler/istio/subscription","commits_url":"https://api.github.com/repos/nmittler/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmittler/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmittler/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmittler/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmittler/istio/contents/{+path}","compare_url":"https://api.github.com/repos/nmittler/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmittler/istio/merges","archive_url":"https://api.github.com/repos/nmittler/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmittler/istio/downloads","issues_url":"https://api.github.com/repos/nmittler/istio/issues{/number}","pulls_url":"https://api.github.com/repos/nmittler/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/nmittler/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/nmittler/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmittler/istio/labels{/name}","releases_url":"https://api.github.com/repos/nmittler/istio/releases{/id}","deployments_url":"https://api.github.com/repos/nmittler/istio/deployments","created_at":"2017-09-29T17:33:39Z","updated_at":"2017-09-29T17:33:41Z","pushed_at":"2018-06-18T17:12:52Z","git_url":"git://github.com/nmittler/istio.git","ssh_url":"git@github.com:nmittler/istio.git","clone_url":"https://github.com/nmittler/istio.git","svn_url":"https://github.com/nmittler/istio","homepage":"https://istio.io","size":119145,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:collab-test-framework","ref":"collab-test-framework","sha":"472d834bad2795a3f53835a4d323d7a7a6eebb53","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-06-19T00:26:14Z","pushed_at":"2018-06-19T00:25:56Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":39133,"stargazers_count":8754,"watchers_count":8754,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1192,"mirror_url":null,"archived":false,"open_issues_count":796,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1192,"open_issues":796,"watchers":8754,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/6332"},"html":{"href":"https://github.com/istio/istio/pull/6332"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/6332"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/6332/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/6332/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/6332/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/d33fdcd2fc42dca011025711f958bbdb8150cfce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nmittler"}}