{"action":"created","issue":{"url":"https://api.github.com/repos/olifolkerd/tabulator/issues/869","repository_url":"https://api.github.com/repos/olifolkerd/tabulator","labels_url":"https://api.github.com/repos/olifolkerd/tabulator/issues/869/labels{/name}","comments_url":"https://api.github.com/repos/olifolkerd/tabulator/issues/869/comments","events_url":"https://api.github.com/repos/olifolkerd/tabulator/issues/869/events","html_url":"https://github.com/olifolkerd/tabulator/issues/869","id":295755047,"number":869,"title":"setHeight + redraw Seem to Break Virtual Dom Rendering","user":{"login":"xXmrotsXx","id":36215684,"avatar_url":"https://avatars2.githubusercontent.com/u/36215684?v=4","gravatar_id":"","url":"https://api.github.com/users/xXmrotsXx","html_url":"https://github.com/xXmrotsXx","followers_url":"https://api.github.com/users/xXmrotsXx/followers","following_url":"https://api.github.com/users/xXmrotsXx/following{/other_user}","gists_url":"https://api.github.com/users/xXmrotsXx/gists{/gist_id}","starred_url":"https://api.github.com/users/xXmrotsXx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xXmrotsXx/subscriptions","organizations_url":"https://api.github.com/users/xXmrotsXx/orgs","repos_url":"https://api.github.com/users/xXmrotsXx/repos","events_url":"https://api.github.com/users/xXmrotsXx/events{/privacy}","received_events_url":"https://api.github.com/users/xXmrotsXx/received_events","type":"User","site_admin":false},"labels":[{"id":277350038,"url":"https://api.github.com/repos/olifolkerd/tabulator/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":{"login":"olifolkerd","id":6840524,"avatar_url":"https://avatars0.githubusercontent.com/u/6840524?v=4","gravatar_id":"","url":"https://api.github.com/users/olifolkerd","html_url":"https://github.com/olifolkerd","followers_url":"https://api.github.com/users/olifolkerd/followers","following_url":"https://api.github.com/users/olifolkerd/following{/other_user}","gists_url":"https://api.github.com/users/olifolkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/olifolkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olifolkerd/subscriptions","organizations_url":"https://api.github.com/users/olifolkerd/orgs","repos_url":"https://api.github.com/users/olifolkerd/repos","events_url":"https://api.github.com/users/olifolkerd/events{/privacy}","received_events_url":"https://api.github.com/users/olifolkerd/received_events","type":"User","site_admin":false},"assignees":[{"login":"olifolkerd","id":6840524,"avatar_url":"https://avatars0.githubusercontent.com/u/6840524?v=4","gravatar_id":"","url":"https://api.github.com/users/olifolkerd","html_url":"https://github.com/olifolkerd","followers_url":"https://api.github.com/users/olifolkerd/followers","following_url":"https://api.github.com/users/olifolkerd/following{/other_user}","gists_url":"https://api.github.com/users/olifolkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/olifolkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olifolkerd/subscriptions","organizations_url":"https://api.github.com/users/olifolkerd/orgs","repos_url":"https://api.github.com/users/olifolkerd/repos","events_url":"https://api.github.com/users/olifolkerd/events{/privacy}","received_events_url":"https://api.github.com/users/olifolkerd/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2018-02-09T04:57:04Z","updated_at":"2018-02-18T19:57:08Z","closed_at":null,"author_association":"NONE","body":"Hi again @olifolkerd,\r\n\r\n_TL;DR: I have actually solved (worked around?) my issue, but would appreciate your feedback on what I have documented below. Thanks again for all the support you provide._\r\n\r\nBeing new to tabulator I'm still getting my head around the inner workings of the code. I'm loving what I've been able to learn in just a couple of days using the product so thanks for it and the awesome support you provide! \r\n\r\nI'm now running into issues when dynamically setting the table height which I realise needs to be set for the Virtual DOM to function. \r\n\r\n1. The docs state _\"...it can be set to any valid height css value.\"_ EG:\r\n```\r\n$(\"#example-table\").tabulator({\r\n    height:\"100%\", //set the table height option\r\n});\r\n```\r\nHowever, this appears to render the table height to 100% of the DATA, not the available screen height like it would in CSS. Is this the correct functionality or is something going wrong? Also, only the first 20 rows have been populated...\r\n\r\n2. To get around the problems I was having with 1 above, I used the following:\r\n```\r\n$(\"#example-table\").tabulator(\"setHeight\", $(window).height() - 250);\r\n$(\"#example-table\").tabulator(\"redraw\", true); \r\n```\r\nI tried using it in place of the height assignment above, but cannot use _setHeight_ until the table has been constructed. So I moved it outside of the table constructor and thought my issues had been resolved... BUT, the Virtual DOM still did not update and my table only populated 50 rows this time.\r\n\r\n3. Leaving 2 in place I can set height: to anything >0 (1px, 800px, 100%) and all my problems go away... Why? :-)\r\n\r\nThanks again"},"comment":{"url":"https://api.github.com/repos/olifolkerd/tabulator/issues/comments/366542667","html_url":"https://github.com/olifolkerd/tabulator/issues/869#issuecomment-366542667","issue_url":"https://api.github.com/repos/olifolkerd/tabulator/issues/869","id":366542667,"user":{"login":"xXmrotsXx","id":36215684,"avatar_url":"https://avatars2.githubusercontent.com/u/36215684?v=4","gravatar_id":"","url":"https://api.github.com/users/xXmrotsXx","html_url":"https://github.com/xXmrotsXx","followers_url":"https://api.github.com/users/xXmrotsXx/followers","following_url":"https://api.github.com/users/xXmrotsXx/following{/other_user}","gists_url":"https://api.github.com/users/xXmrotsXx/gists{/gist_id}","starred_url":"https://api.github.com/users/xXmrotsXx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xXmrotsXx/subscriptions","organizations_url":"https://api.github.com/users/xXmrotsXx/orgs","repos_url":"https://api.github.com/users/xXmrotsXx/repos","events_url":"https://api.github.com/users/xXmrotsXx/events{/privacy}","received_events_url":"https://api.github.com/users/xXmrotsXx/received_events","type":"User","site_admin":false},"created_at":"2018-02-18T19:57:08Z","updated_at":"2018-02-18T19:57:08Z","author_association":"NONE","body":"This table is just that... The html is above. I've just removed the middle 200 rows of manually entered data in my pasted version. I used the tabulator site CSS with the height in .tabulator at the bottom..."}}
{"actor":{"display_login":"xXmrotsXx"}}