{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/elasticsearch-operator/issues/31","repository_url":"https://api.github.com/repos/openshift/elasticsearch-operator","labels_url":"https://api.github.com/repos/openshift/elasticsearch-operator/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/openshift/elasticsearch-operator/issues/31/comments","events_url":"https://api.github.com/repos/openshift/elasticsearch-operator/issues/31/events","html_url":"https://github.com/openshift/elasticsearch-operator/issues/31","id":380326721,"node_id":"MDU6SXNzdWUzODAzMjY3MjE=","number":31,"title":"Should we continue to reconcile in spite of failures?","user":{"login":"jcantrill","id":4548408,"node_id":"MDQ6VXNlcjQ1NDg0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/4548408?v=4","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"labels":[{"id":1039645936,"node_id":"MDU6TGFiZWwxMDM5NjQ1OTM2","url":"https://api.github.com/repos/openshift/elasticsearch-operator/labels/question","name":"question","color":"d876e3","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-13T16:59:00Z","updated_at":"2018-11-20T15:30:26Z","closed_at":null,"author_association":"NONE","body":"Posing the question if in spite of some failed reconciliations if we should continue to with others[1].  Elasticsearch will never deploy even though if these [1] bits are not available on the cluster, the ES cluster could still function.  IMO, we should consider specifying some error condition in the status but this should not block the ES cluster from  starting.  It is still functional but just doesn't have the appropriate objects in place to be scraped.  Maybe a warning message is more appropriate here.\r\n\r\n[1] https://github.com/openshift/elasticsearch-operator/blob/master/pkg/stub/handler.go#L57-L65"},"comment":{"url":"https://api.github.com/repos/openshift/elasticsearch-operator/issues/comments/440314370","html_url":"https://github.com/openshift/elasticsearch-operator/issues/31#issuecomment-440314370","issue_url":"https://api.github.com/repos/openshift/elasticsearch-operator/issues/31","id":440314370,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDMxNDM3MA==","user":{"login":"ewolinetz","id":1427473,"node_id":"MDQ6VXNlcjE0Mjc0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1427473?v=4","gravatar_id":"","url":"https://api.github.com/users/ewolinetz","html_url":"https://github.com/ewolinetz","followers_url":"https://api.github.com/users/ewolinetz/followers","following_url":"https://api.github.com/users/ewolinetz/following{/other_user}","gists_url":"https://api.github.com/users/ewolinetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ewolinetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewolinetz/subscriptions","organizations_url":"https://api.github.com/users/ewolinetz/orgs","repos_url":"https://api.github.com/users/ewolinetz/repos","events_url":"https://api.github.com/users/ewolinetz/events{/privacy}","received_events_url":"https://api.github.com/users/ewolinetz/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T15:30:26Z","updated_at":"2018-11-20T15:30:26Z","author_association":"NONE","body":"I think, in general, if it is not completely required for the operator to provide its functionality we should not fail out in our handling and continue processing as you suggest. But I would also think that if its not critical to running, should there be a way to enable that feature instead of having it on by default?"}}
{"actor":{"display_login":"ewolinetz"}}