{"action":"closed","number":12680,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12680","id":174766948,"html_url":"https://github.com/bitcoin/bitcoin/pull/12680","diff_url":"https://github.com/bitcoin/bitcoin/pull/12680.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/12680.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12680","number":12680,"state":"closed","locked":false,"title":"Add missing virtual destructor in PeerLogicValidation","user":{"login":"vasild","id":266751,"avatar_url":"https://avatars2.githubusercontent.com/u/266751?v=4","gravatar_id":"","url":"https://api.github.com/users/vasild","html_url":"https://github.com/vasild","followers_url":"https://api.github.com/users/vasild/followers","following_url":"https://api.github.com/users/vasild/following{/other_user}","gists_url":"https://api.github.com/users/vasild/gists{/gist_id}","starred_url":"https://api.github.com/users/vasild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasild/subscriptions","organizations_url":"https://api.github.com/users/vasild/orgs","repos_url":"https://api.github.com/users/vasild/repos","events_url":"https://api.github.com/users/vasild/events{/privacy}","received_events_url":"https://api.github.com/users/vasild/received_events","type":"User","site_admin":false},"body":"Silence the following compiler warning:\r\n\r\n/usr/include/c++/v1/memory:2285:5: error: delete called on non-final 'PeerLogicValidation' that has\r\n      virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]\r\n    delete __ptr;\r\n    ^\r\n/usr/include/c++/v1/memory:2598:7: note: in instantiation of member function\r\n      'std::__1::default_delete<PeerLogicValidation>::operator()' requested here\r\n      __ptr_.second()(__tmp);\r\n      ^\r\ninit.cpp:201:15: note: in instantiation of member function 'std::__1::unique_ptr<PeerLogicValidation,\r\n      std::__1::default_delete<PeerLogicValidation> >::reset' requested here\r\n    peerLogic.reset();\r\n              ^","created_at":"2018-03-13T19:33:06Z","updated_at":"2018-03-14T09:48:21Z","closed_at":"2018-03-14T09:48:21Z","merged_at":"2018-03-14T09:48:21Z","merge_commit_sha":"2b3ea39de40bc7754cab558245e4ddac1b261750","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135961,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12680/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12680/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12680/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2b3ea39de40bc7754cab558245e4ddac1b261750","head":{"label":"vasild:master-add-missing-vdtor-in-PeerLogicValidation","ref":"master-add-missing-vdtor-in-PeerLogicValidation","sha":"2b3ea39de40bc7754cab558245e4ddac1b261750","user":{"login":"vasild","id":266751,"avatar_url":"https://avatars2.githubusercontent.com/u/266751?v=4","gravatar_id":"","url":"https://api.github.com/users/vasild","html_url":"https://github.com/vasild","followers_url":"https://api.github.com/users/vasild/followers","following_url":"https://api.github.com/users/vasild/following{/other_user}","gists_url":"https://api.github.com/users/vasild/gists{/gist_id}","starred_url":"https://api.github.com/users/vasild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasild/subscriptions","organizations_url":"https://api.github.com/users/vasild/orgs","repos_url":"https://api.github.com/users/vasild/repos","events_url":"https://api.github.com/users/vasild/events{/privacy}","received_events_url":"https://api.github.com/users/vasild/received_events","type":"User","site_admin":false},"repo":{"id":120608826,"name":"bitcoin","full_name":"vasild/bitcoin","owner":{"login":"vasild","id":266751,"avatar_url":"https://avatars2.githubusercontent.com/u/266751?v=4","gravatar_id":"","url":"https://api.github.com/users/vasild","html_url":"https://github.com/vasild","followers_url":"https://api.github.com/users/vasild/followers","following_url":"https://api.github.com/users/vasild/following{/other_user}","gists_url":"https://api.github.com/users/vasild/gists{/gist_id}","starred_url":"https://api.github.com/users/vasild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasild/subscriptions","organizations_url":"https://api.github.com/users/vasild/orgs","repos_url":"https://api.github.com/users/vasild/repos","events_url":"https://api.github.com/users/vasild/events{/privacy}","received_events_url":"https://api.github.com/users/vasild/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vasild/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/vasild/bitcoin","forks_url":"https://api.github.com/repos/vasild/bitcoin/forks","keys_url":"https://api.github.com/repos/vasild/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vasild/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vasild/bitcoin/teams","hooks_url":"https://api.github.com/repos/vasild/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/vasild/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/vasild/bitcoin/events","assignees_url":"https://api.github.com/repos/vasild/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/vasild/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/vasild/bitcoin/tags","blobs_url":"https://api.github.com/repos/vasild/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vasild/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vasild/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/vasild/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vasild/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/vasild/bitcoin/languages","stargazers_url":"https://api.github.com/repos/vasild/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/vasild/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/vasild/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/vasild/bitcoin/subscription","commits_url":"https://api.github.com/repos/vasild/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/vasild/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/vasild/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/vasild/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/vasild/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/vasild/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vasild/bitcoin/merges","archive_url":"https://api.github.com/repos/vasild/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vasild/bitcoin/downloads","issues_url":"https://api.github.com/repos/vasild/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/vasild/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/vasild/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/vasild/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vasild/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/vasild/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/vasild/bitcoin/deployments","created_at":"2018-02-07T11:52:47Z","updated_at":"2018-02-07T11:53:04Z","pushed_at":"2018-03-14T09:11:30Z","git_url":"git://github.com/vasild/bitcoin.git","ssh_url":"git@github.com:vasild/bitcoin.git","clone_url":"https://github.com/vasild/bitcoin.git","svn_url":"https://github.com/vasild/bitcoin","homepage":"https://bitcoin.org/en/download","size":97776,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"6acd8700bc0ee1d10207a362c1e07372ba274041","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-03-14T09:44:36Z","pushed_at":"2018-03-14T09:48:06Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":98521,"stargazers_count":29292,"watchers_count":29292,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":17437,"mirror_url":null,"archived":false,"open_issues_count":817,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":17437,"open_issues":817,"watchers":29292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12680"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/12680"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12680"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12680/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12680/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12680/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2b3ea39de40bc7754cab558245e4ddac1b261750"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"laanwj","id":126646,"avatar_url":"https://avatars0.githubusercontent.com/u/126646?v=4","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"laanwj"}}