{"action":"created","comment":{"url":"https://api.github.com/repos/knative/docs/pulls/comments/238225919","pull_request_review_id":180712192,"id":238225919,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODIyNTkxOQ==","diff_hunk":"@@ -0,0 +1,139 @@\n+# Knative Install on IBM Cloud Private\n+\n+This guide walks you through the installation of the latest version of\n+[Knative Serving](https://github.com/knative/serving) using pre-built images and\n+demonstrates creating and deploying an image of a sample `hello world` app onto\n+the newly created Knative cluster.\n+\n+You can find [guides for other platforms here](README.md).\n+\n+## Before you begin\n+\n+Knative requires a [IBM Cloud Private](https://www.ibm.com/cloud/private) cluster v2.1.0.3 or newer. The install step you can find on the IBM Knowledge Center, [Installing IBM Cloud Private Cloud Native, Enterprise, and Community editions](https://www.ibm.com/support/knowledgecenter/SSBS6K_3.1.1/installing/install_containers.html)\n+\n+\n+## Installing Istio\n+\n+Follow the [instructions](https://istio.io/docs/setup/kubernetes/quick-start-ibm/#ibm-cloud-private) to install and run Istio in [IBM Cloud Private](https://www.ibm.com/cloud/private).\n+\n+## Installing Knative Serving\n+\n+Next, install [Knative Serving](https://github.com/knative/serving):\n+\n+```\n+curl -L https://github.com/knative/serving/releases/download/v0.2.2/release-lite.yaml \\\n+  | sed 's/LoadBalancer/NodePort/' \\\n+  | kubectl apply --filename -\n+```\n+> Note: If the `image-security-enforcement` enabled when you install [IBM Cloud Private](https://www.ibm.com/cloud/private). You need to update the [image security policy](https://www.ibm.com/support/knowledgecenter/SSBS6K_3.1.1/manage_images/image_security.html).\n+\n+Put the namespaces `knative-serving`, `knative-build`, `knative-monitoring` and `knative-eventing` into pod security policy `ibm-privileged-psp` as follows.\n+\n+The pod security policy in [IBM Cloud Private](https://www.ibm.com/cloud/private) as follows:\n+```\n+# kubectl get psp\n+NAME                        PRIV      CAPS                                                                                                                  SELINUX    RUNASUSER          FSGROUP     SUPGROUP    READONLYROOTFS   VOLUMES\n+ibm-anyuid-hostaccess-psp   false     SETPCAP,AUDIT_WRITE,CHOWN,NET_RAW,DAC_OVERRIDE,FOWNER,FSETID,KILL,SETUID,SETGID,NET_BIND_SERVICE,SYS_CHROOT,SETFCAP   RunAsAny   RunAsAny           RunAsAny    RunAsAny    false            *\n+ibm-anyuid-hostpath-psp     false     SETPCAP,AUDIT_WRITE,CHOWN,NET_RAW,DAC_OVERRIDE,FOWNER,FSETID,KILL,SETUID,SETGID,NET_BIND_SERVICE,SYS_CHROOT,SETFCAP   RunAsAny   RunAsAny           RunAsAny    RunAsAny    false            *\n+ibm-anyuid-psp              false     SETPCAP,AUDIT_WRITE,CHOWN,NET_RAW,DAC_OVERRIDE,FOWNER,FSETID,KILL,SETUID,SETGID,NET_BIND_SERVICE,SYS_CHROOT,SETFCAP   RunAsAny   RunAsAny           RunAsAny    RunAsAny    false            configMap,emptyDir,projected,secret,downwardAPI,persistentVolumeClaim\n+ibm-privileged-psp          true      *                                                                                                                     RunAsAny   RunAsAny           RunAsAny    RunAsAny    false            *\n+ibm-restricted-psp          false                                                                                                                           RunAsAny   MustRunAsNonRoot   MustRunAs   MustRunAs   false            configMap,emptyDir,projected,secret,downwardAPI,persistentVolumeClaim\n+```\n+\n+Create a cluster role for the pod security policy resource. The resourceNames for this role must be the name of the pod security policy that was created previous. Here we use ``ibm-privileged-psp``.\n+Create a YAML file for the cluster role.\n+```shell\n+ cat <<EOF | kubectl apply -f -","path":"install/Knative-with-ICP.md","position":46,"original_position":46,"commit_id":"a0b6797c21f8ff7f9b48203e49cde43edbaee0fa","original_commit_id":"a0b6797c21f8ff7f9b48203e49cde43edbaee0fa","user":{"login":"gyliu513","id":4461983,"node_id":"MDQ6VXNlcjQ0NjE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4461983?v=4","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false},"body":"Kill the blank space in front of this.","created_at":"2018-12-03T11:05:36Z","updated_at":"2018-12-03T11:06:10Z","html_url":"https://github.com/knative/docs/pull/618#discussion_r238225919","pull_request_url":"https://api.github.com/repos/knative/docs/pulls/618","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/knative/docs/pulls/comments/238225919"},"html":{"href":"https://github.com/knative/docs/pull/618#discussion_r238225919"},"pull_request":{"href":"https://api.github.com/repos/knative/docs/pulls/618"}}},"pull_request":{"url":"https://api.github.com/repos/knative/docs/pulls/618","id":235341480,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MzQxNDgw","html_url":"https://github.com/knative/docs/pull/618","diff_url":"https://github.com/knative/docs/pull/618.diff","patch_url":"https://github.com/knative/docs/pull/618.patch","issue_url":"https://api.github.com/repos/knative/docs/issues/618","number":618,"state":"open","locked":false,"title":"Add the doc for install knative on IBMCloudPrivate","user":{"login":"zxDiscovery","id":40016978,"node_id":"MDQ6VXNlcjQwMDE2OTc4","avatar_url":"https://avatars1.githubusercontent.com/u/40016978?v=4","gravatar_id":"","url":"https://api.github.com/users/zxDiscovery","html_url":"https://github.com/zxDiscovery","followers_url":"https://api.github.com/users/zxDiscovery/followers","following_url":"https://api.github.com/users/zxDiscovery/following{/other_user}","gists_url":"https://api.github.com/users/zxDiscovery/gists{/gist_id}","starred_url":"https://api.github.com/users/zxDiscovery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxDiscovery/subscriptions","organizations_url":"https://api.github.com/users/zxDiscovery/orgs","repos_url":"https://api.github.com/users/zxDiscovery/repos","events_url":"https://api.github.com/users/zxDiscovery/events{/privacy}","received_events_url":"https://api.github.com/users/zxDiscovery/received_events","type":"User","site_admin":false},"body":"Fixes #557\r\n\r\n## Proposed Changes\r\n\r\n*  Add the a new file install/Knative-with-ICP.md\r\n*  Update the install/README.md\r\n","created_at":"2018-12-03T06:42:06Z","updated_at":"2018-12-03T11:06:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb9c31f743fe5c1040badbf4b5625fda2d00de06","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mchmarny","id":175854,"node_id":"MDQ6VXNlcjE3NTg1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/175854?v=4","gravatar_id":"","url":"https://api.github.com/users/mchmarny","html_url":"https://github.com/mchmarny","followers_url":"https://api.github.com/users/mchmarny/followers","following_url":"https://api.github.com/users/mchmarny/following{/other_user}","gists_url":"https://api.github.com/users/mchmarny/gists{/gist_id}","starred_url":"https://api.github.com/users/mchmarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchmarny/subscriptions","organizations_url":"https://api.github.com/users/mchmarny/orgs","repos_url":"https://api.github.com/users/mchmarny/repos","events_url":"https://api.github.com/users/mchmarny/events{/privacy}","received_events_url":"https://api.github.com/users/mchmarny/received_events","type":"User","site_admin":false},{"login":"evankanderson","id":7959095,"node_id":"MDQ6VXNlcjc5NTkwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/7959095?v=4","gravatar_id":"","url":"https://api.github.com/users/evankanderson","html_url":"https://github.com/evankanderson","followers_url":"https://api.github.com/users/evankanderson/followers","following_url":"https://api.github.com/users/evankanderson/following{/other_user}","gists_url":"https://api.github.com/users/evankanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/evankanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evankanderson/subscriptions","organizations_url":"https://api.github.com/users/evankanderson/orgs","repos_url":"https://api.github.com/users/evankanderson/repos","events_url":"https://api.github.com/users/evankanderson/events{/privacy}","received_events_url":"https://api.github.com/users/evankanderson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1002977332,"node_id":"MDU6TGFiZWwxMDAyOTc3MzMy","url":"https://api.github.com/repos/knative/docs/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"ededed","default":false},{"id":983045103,"node_id":"MDU6TGFiZWw5ODMwNDUxMDM=","url":"https://api.github.com/repos/knative/docs/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/docs/pulls/618/commits","review_comments_url":"https://api.github.com/repos/knative/docs/pulls/618/comments","review_comment_url":"https://api.github.com/repos/knative/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/docs/issues/618/comments","statuses_url":"https://api.github.com/repos/knative/docs/statuses/a0b6797c21f8ff7f9b48203e49cde43edbaee0fa","head":{"label":"zxDiscovery:Add-ICP-doc","ref":"Add-ICP-doc","sha":"a0b6797c21f8ff7f9b48203e49cde43edbaee0fa","user":{"login":"zxDiscovery","id":40016978,"node_id":"MDQ6VXNlcjQwMDE2OTc4","avatar_url":"https://avatars1.githubusercontent.com/u/40016978?v=4","gravatar_id":"","url":"https://api.github.com/users/zxDiscovery","html_url":"https://github.com/zxDiscovery","followers_url":"https://api.github.com/users/zxDiscovery/followers","following_url":"https://api.github.com/users/zxDiscovery/following{/other_user}","gists_url":"https://api.github.com/users/zxDiscovery/gists{/gist_id}","starred_url":"https://api.github.com/users/zxDiscovery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxDiscovery/subscriptions","organizations_url":"https://api.github.com/users/zxDiscovery/orgs","repos_url":"https://api.github.com/users/zxDiscovery/repos","events_url":"https://api.github.com/users/zxDiscovery/events{/privacy}","received_events_url":"https://api.github.com/users/zxDiscovery/received_events","type":"User","site_admin":false},"repo":{"id":159151947,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkxNTE5NDc=","name":"docs","full_name":"zxDiscovery/docs","private":false,"owner":{"login":"zxDiscovery","id":40016978,"node_id":"MDQ6VXNlcjQwMDE2OTc4","avatar_url":"https://avatars1.githubusercontent.com/u/40016978?v=4","gravatar_id":"","url":"https://api.github.com/users/zxDiscovery","html_url":"https://github.com/zxDiscovery","followers_url":"https://api.github.com/users/zxDiscovery/followers","following_url":"https://api.github.com/users/zxDiscovery/following{/other_user}","gists_url":"https://api.github.com/users/zxDiscovery/gists{/gist_id}","starred_url":"https://api.github.com/users/zxDiscovery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxDiscovery/subscriptions","organizations_url":"https://api.github.com/users/zxDiscovery/orgs","repos_url":"https://api.github.com/users/zxDiscovery/repos","events_url":"https://api.github.com/users/zxDiscovery/events{/privacy}","received_events_url":"https://api.github.com/users/zxDiscovery/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zxDiscovery/docs","description":"User documentation for Knative components","fork":true,"url":"https://api.github.com/repos/zxDiscovery/docs","forks_url":"https://api.github.com/repos/zxDiscovery/docs/forks","keys_url":"https://api.github.com/repos/zxDiscovery/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zxDiscovery/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zxDiscovery/docs/teams","hooks_url":"https://api.github.com/repos/zxDiscovery/docs/hooks","issue_events_url":"https://api.github.com/repos/zxDiscovery/docs/issues/events{/number}","events_url":"https://api.github.com/repos/zxDiscovery/docs/events","assignees_url":"https://api.github.com/repos/zxDiscovery/docs/assignees{/user}","branches_url":"https://api.github.com/repos/zxDiscovery/docs/branches{/branch}","tags_url":"https://api.github.com/repos/zxDiscovery/docs/tags","blobs_url":"https://api.github.com/repos/zxDiscovery/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zxDiscovery/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zxDiscovery/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zxDiscovery/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zxDiscovery/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/zxDiscovery/docs/languages","stargazers_url":"https://api.github.com/repos/zxDiscovery/docs/stargazers","contributors_url":"https://api.github.com/repos/zxDiscovery/docs/contributors","subscribers_url":"https://api.github.com/repos/zxDiscovery/docs/subscribers","subscription_url":"https://api.github.com/repos/zxDiscovery/docs/subscription","commits_url":"https://api.github.com/repos/zxDiscovery/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zxDiscovery/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zxDiscovery/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zxDiscovery/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zxDiscovery/docs/contents/{+path}","compare_url":"https://api.github.com/repos/zxDiscovery/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zxDiscovery/docs/merges","archive_url":"https://api.github.com/repos/zxDiscovery/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zxDiscovery/docs/downloads","issues_url":"https://api.github.com/repos/zxDiscovery/docs/issues{/number}","pulls_url":"https://api.github.com/repos/zxDiscovery/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/zxDiscovery/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/zxDiscovery/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zxDiscovery/docs/labels{/name}","releases_url":"https://api.github.com/repos/zxDiscovery/docs/releases{/id}","deployments_url":"https://api.github.com/repos/zxDiscovery/docs/deployments","created_at":"2018-11-26T10:31:56Z","updated_at":"2018-12-03T05:26:46Z","pushed_at":"2018-12-03T10:04:20Z","git_url":"git://github.com/zxDiscovery/docs.git","ssh_url":"git@github.com:zxDiscovery/docs.git","clone_url":"https://github.com/zxDiscovery/docs.git","svn_url":"https://github.com/zxDiscovery/docs","homepage":"","size":13672,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"f92e52857cfe7c39cc4e3261e2e8054331a51b0f","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":138207223,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyMDcyMjM=","name":"docs","full_name":"knative/docs","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/docs","description":"User documentation for Knative components","fork":false,"url":"https://api.github.com/repos/knative/docs","forks_url":"https://api.github.com/repos/knative/docs/forks","keys_url":"https://api.github.com/repos/knative/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/docs/teams","hooks_url":"https://api.github.com/repos/knative/docs/hooks","issue_events_url":"https://api.github.com/repos/knative/docs/issues/events{/number}","events_url":"https://api.github.com/repos/knative/docs/events","assignees_url":"https://api.github.com/repos/knative/docs/assignees{/user}","branches_url":"https://api.github.com/repos/knative/docs/branches{/branch}","tags_url":"https://api.github.com/repos/knative/docs/tags","blobs_url":"https://api.github.com/repos/knative/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/docs/languages","stargazers_url":"https://api.github.com/repos/knative/docs/stargazers","contributors_url":"https://api.github.com/repos/knative/docs/contributors","subscribers_url":"https://api.github.com/repos/knative/docs/subscribers","subscription_url":"https://api.github.com/repos/knative/docs/subscription","commits_url":"https://api.github.com/repos/knative/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/docs/contents/{+path}","compare_url":"https://api.github.com/repos/knative/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/docs/merges","archive_url":"https://api.github.com/repos/knative/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/docs/downloads","issues_url":"https://api.github.com/repos/knative/docs/issues{/number}","pulls_url":"https://api.github.com/repos/knative/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/docs/labels{/name}","releases_url":"https://api.github.com/repos/knative/docs/releases{/id}","deployments_url":"https://api.github.com/repos/knative/docs/deployments","created_at":"2018-06-21T18:21:09Z","updated_at":"2018-12-03T07:53:56Z","pushed_at":"2018-12-03T10:04:21Z","git_url":"git://github.com/knative/docs.git","ssh_url":"git@github.com:knative/docs.git","clone_url":"https://github.com/knative/docs.git","svn_url":"https://github.com/knative/docs","homepage":"","size":13670,"stargazers_count":1242,"watchers_count":1242,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":236,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":236,"open_issues":101,"watchers":1242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/docs/pulls/618"},"html":{"href":"https://github.com/knative/docs/pull/618"},"issue":{"href":"https://api.github.com/repos/knative/docs/issues/618"},"comments":{"href":"https://api.github.com/repos/knative/docs/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/docs/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/docs/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/knative/docs/statuses/a0b6797c21f8ff7f9b48203e49cde43edbaee0fa"}},"author_association":"NONE"}}
{"actor":{"display_login":"gyliu513"}}