{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments/245155065","pull_request_review_id":189210155,"id":245155065,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTE1NTA2NQ==","diff_hunk":"@@ -99,7 +99,11 @@ func NewDefaultOptionsLCOW(id, owner string) *OptionsLCOW {\n \t\topts.Owner = filepath.Base(os.Args[0])\n \t}\n \n-\t// TODO: If > RS5 use KernelDirect. If rootfs.vhd exists use it.\n+\tif _, err := os.Stat(filepath.Join(opts.BootFilesPath, \"rootfs.vhd\")); err != nil {","path":"internal/uvm/create_lcow.go","position":14,"original_position":14,"commit_id":"e4b5959c70779097f7da59d9fcf92270b4c95ab4","original_commit_id":"e4b5959c70779097f7da59d9fcf92270b4c95ab4","user":{"login":"kevpar","id":315397,"node_id":"MDQ6VXNlcjMxNTM5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/315397?v=4","gravatar_id":"","url":"https://api.github.com/users/kevpar","html_url":"https://github.com/kevpar","followers_url":"https://api.github.com/users/kevpar/followers","following_url":"https://api.github.com/users/kevpar/following{/other_user}","gists_url":"https://api.github.com/users/kevpar/gists{/gist_id}","starred_url":"https://api.github.com/users/kevpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevpar/subscriptions","organizations_url":"https://api.github.com/users/kevpar/orgs","repos_url":"https://api.github.com/users/kevpar/repos","events_url":"https://api.github.com/users/kevpar/events{/privacy}","received_events_url":"https://api.github.com/users/kevpar/received_events","type":"User","site_admin":false},"body":"It looks like if there is a rootfs.vhd in C:\\Program Files\\Linux Containers, but the caller changes opts.BootFilesPath to some other path that only has an InitRD, the code will still try to use a rootfs.vhd that isn't there.\r\n\r\nNot sure what we can realistically do about this issue, but may be worth calling out.","created_at":"2019-01-03T22:32:35Z","updated_at":"2019-01-03T22:32:35Z","html_url":"https://github.com/Microsoft/hcsshim/pull/438#discussion_r245155065","pull_request_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/438","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments/245155065"},"html":{"href":"https://github.com/Microsoft/hcsshim/pull/438#discussion_r245155065"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/438","id":242128411,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMTI4NDEx","html_url":"https://github.com/Microsoft/hcsshim/pull/438","diff_url":"https://github.com/Microsoft/hcsshim/pull/438.diff","patch_url":"https://github.com/Microsoft/hcsshim/pull/438.patch","issue_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/438","number":438,"state":"open","locked":false,"title":"Enable KernelDirect and VHD boot by default","user":{"login":"jterry75","id":5858142,"node_id":"MDQ6VXNlcjU4NTgxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/5858142?v=4","gravatar_id":"","url":"https://api.github.com/users/jterry75","html_url":"https://github.com/jterry75","followers_url":"https://api.github.com/users/jterry75/followers","following_url":"https://api.github.com/users/jterry75/following{/other_user}","gists_url":"https://api.github.com/users/jterry75/gists{/gist_id}","starred_url":"https://api.github.com/users/jterry75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jterry75/subscriptions","organizations_url":"https://api.github.com/users/jterry75/orgs","repos_url":"https://api.github.com/users/jterry75/repos","events_url":"https://api.github.com/users/jterry75/events{/privacy}","received_events_url":"https://api.github.com/users/jterry75/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>","created_at":"2019-01-03T22:26:34Z","updated_at":"2019-01-03T22:32:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a77fcc45e4d4319d6c515417f962d3f9d4f095dd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jhowardmsft","id":10522484,"node_id":"MDQ6VXNlcjEwNTIyNDg0","avatar_url":"https://avatars2.githubusercontent.com/u/10522484?v=4","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/438/commits","review_comments_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/438/comments","review_comment_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/438/comments","statuses_url":"https://api.github.com/repos/Microsoft/hcsshim/statuses/e4b5959c70779097f7da59d9fcf92270b4c95ab4","head":{"label":"Microsoft:change_lcow_boot_default","ref":"change_lcow_boot_default","sha":"e4b5959c70779097f7da59d9fcf92270b4c95ab4","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38258831,"node_id":"MDEwOlJlcG9zaXRvcnkzODI1ODgzMQ==","name":"hcsshim","full_name":"Microsoft/hcsshim","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/hcsshim","description":"Windows - Host Compute Service Shim","fork":false,"url":"https://api.github.com/repos/Microsoft/hcsshim","forks_url":"https://api.github.com/repos/Microsoft/hcsshim/forks","keys_url":"https://api.github.com/repos/Microsoft/hcsshim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/hcsshim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/hcsshim/teams","hooks_url":"https://api.github.com/repos/Microsoft/hcsshim/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/hcsshim/events","assignees_url":"https://api.github.com/repos/Microsoft/hcsshim/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/hcsshim/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/hcsshim/tags","blobs_url":"https://api.github.com/repos/Microsoft/hcsshim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/hcsshim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/hcsshim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/hcsshim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/hcsshim/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/hcsshim/languages","stargazers_url":"https://api.github.com/repos/Microsoft/hcsshim/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/hcsshim/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/hcsshim/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/hcsshim/subscription","commits_url":"https://api.github.com/repos/Microsoft/hcsshim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/hcsshim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/hcsshim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/hcsshim/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/hcsshim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/hcsshim/merges","archive_url":"https://api.github.com/repos/Microsoft/hcsshim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/hcsshim/downloads","issues_url":"https://api.github.com/repos/Microsoft/hcsshim/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/hcsshim/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/hcsshim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/hcsshim/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/hcsshim/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/hcsshim/deployments","created_at":"2015-06-29T16:44:26Z","updated_at":"2019-01-01T09:29:11Z","pushed_at":"2019-01-03T22:26:34Z","git_url":"git://github.com/Microsoft/hcsshim.git","ssh_url":"git@github.com:Microsoft/hcsshim.git","clone_url":"https://github.com/Microsoft/hcsshim.git","svn_url":"https://github.com/Microsoft/hcsshim","homepage":null,"size":1417,"stargazers_count":161,"watchers_count":161,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":58,"open_issues":24,"watchers":161,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"3cbb09db6e047cf6284ab0bbd20618743492273a","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38258831,"node_id":"MDEwOlJlcG9zaXRvcnkzODI1ODgzMQ==","name":"hcsshim","full_name":"Microsoft/hcsshim","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/hcsshim","description":"Windows - Host Compute Service Shim","fork":false,"url":"https://api.github.com/repos/Microsoft/hcsshim","forks_url":"https://api.github.com/repos/Microsoft/hcsshim/forks","keys_url":"https://api.github.com/repos/Microsoft/hcsshim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/hcsshim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/hcsshim/teams","hooks_url":"https://api.github.com/repos/Microsoft/hcsshim/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/hcsshim/events","assignees_url":"https://api.github.com/repos/Microsoft/hcsshim/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/hcsshim/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/hcsshim/tags","blobs_url":"https://api.github.com/repos/Microsoft/hcsshim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/hcsshim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/hcsshim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/hcsshim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/hcsshim/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/hcsshim/languages","stargazers_url":"https://api.github.com/repos/Microsoft/hcsshim/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/hcsshim/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/hcsshim/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/hcsshim/subscription","commits_url":"https://api.github.com/repos/Microsoft/hcsshim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/hcsshim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/hcsshim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/hcsshim/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/hcsshim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/hcsshim/merges","archive_url":"https://api.github.com/repos/Microsoft/hcsshim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/hcsshim/downloads","issues_url":"https://api.github.com/repos/Microsoft/hcsshim/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/hcsshim/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/hcsshim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/hcsshim/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/hcsshim/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/hcsshim/deployments","created_at":"2015-06-29T16:44:26Z","updated_at":"2019-01-01T09:29:11Z","pushed_at":"2019-01-03T22:26:34Z","git_url":"git://github.com/Microsoft/hcsshim.git","ssh_url":"git@github.com:Microsoft/hcsshim.git","clone_url":"https://github.com/Microsoft/hcsshim.git","svn_url":"https://github.com/Microsoft/hcsshim","homepage":null,"size":1417,"stargazers_count":161,"watchers_count":161,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":58,"open_issues":24,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/438"},"html":{"href":"https://github.com/Microsoft/hcsshim/pull/438"},"issue":{"href":"https://api.github.com/repos/Microsoft/hcsshim/issues/438"},"comments":{"href":"https://api.github.com/repos/Microsoft/hcsshim/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/hcsshim/statuses/e4b5959c70779097f7da59d9fcf92270b4c95ab4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kevpar"}}