{"action":"created","issue":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/278","repository_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver","labels_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/278/labels{/name}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/278/comments","events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/278/events","html_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/278","id":395569507,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxOTkyMTky","number":278,"title":"add help menu to install.sh","user":{"login":"qubenix","id":15707061,"node_id":"MDQ6VXNlcjE1NzA3MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/15707061?v=4","gravatar_id":"","url":"https://api.github.com/users/qubenix","html_url":"https://github.com/qubenix","followers_url":"https://api.github.com/users/qubenix/followers","following_url":"https://api.github.com/users/qubenix/following{/other_user}","gists_url":"https://api.github.com/users/qubenix/gists{/gist_id}","starred_url":"https://api.github.com/users/qubenix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qubenix/subscriptions","organizations_url":"https://api.github.com/users/qubenix/orgs","repos_url":"https://api.github.com/users/qubenix/repos","events_url":"https://api.github.com/users/qubenix/events{/privacy}","received_events_url":"https://api.github.com/users/qubenix/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-01-03T13:17:21Z","updated_at":"2019-01-03T17:42:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/278","html_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/278","diff_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/278.diff","patch_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/278.patch"},"body":"I tried to run the install script yesterday without first checking the readme, and I ended up having to look into the code to find out what options I could add. This PR adds a help menu to the install script which will be presented to the user any time they add any flag which is not supported (including `-h` or `--help`).\r\n\r\nI removed the error message about \"unknown flag\" and replaced it with this menu. IMO this is more helpful. ~~I added an `exit`  after the help menu which some may prefer as `exit 1`.~~\r\n\r\nWhoops, looks like I left it `exit 1`. Happy to change it to whichever is preferred."},"comment":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/comments/451220285","html_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/278#issuecomment-451220285","issue_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/278","id":451220285,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTIyMDI4NQ==","user":{"login":"qubenix","id":15707061,"node_id":"MDQ6VXNlcjE1NzA3MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/15707061?v=4","gravatar_id":"","url":"https://api.github.com/users/qubenix","html_url":"https://github.com/qubenix","followers_url":"https://api.github.com/users/qubenix/followers","following_url":"https://api.github.com/users/qubenix/following{/other_user}","gists_url":"https://api.github.com/users/qubenix/gists{/gist_id}","starred_url":"https://api.github.com/users/qubenix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qubenix/subscriptions","organizations_url":"https://api.github.com/users/qubenix/orgs","repos_url":"https://api.github.com/users/qubenix/repos","events_url":"https://api.github.com/users/qubenix/events{/privacy}","received_events_url":"https://api.github.com/users/qubenix/received_events","type":"User","site_admin":false},"created_at":"2019-01-03T17:42:03Z","updated_at":"2019-01-03T17:42:03Z","author_association":"NONE","body":"@fivepiece Thanks for reviewing and your suggestions. I think I've addressed all those concerns.\r\n\r\nI also like to preformatted the menu, I just wasn't sure if breaking indentation was frowned on or not."}}
{"actor":{"display_login":"qubenix"}}