{"action":"created","comment":{"url":"https://api.github.com/repos/samsarahq/api-docs/pulls/comments/233730808","pull_request_review_id":175213125,"id":233730808,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzczMDgwOA==","diff_hunk":"@@ -6374,6 +6683,31 @@\n             \"in\": \"query\",\n             \"type\": \"integer\",\n             \"format\": \"int64\"\n+        },\n+        \"createUserParam\": {\n+            \"name\": \"user\",\n+            \"description\": \"User properties. Only one of organizationRole or tagRoles is required.\",\n+            \"required\": true,\n+            \"in\": \"body\",\n+            \"schema\": {\n+                \"type\": \"object\",\n+                \"required\": [\n+                    \"name\",\n+                    \"email\",\n+                    \"authType\"\n+                ],\n+                \"$ref\": \"#/definitions/UpsertUserBase\"","path":"swagger.json","position":343,"original_position":343,"commit_id":"c55b39a3d4da0271d50c4277b51000ca62947e5e","original_commit_id":"c55b39a3d4da0271d50c4277b51000ca62947e5e","user":{"login":"silverspace","id":15318933,"node_id":"MDQ6VXNlcjE1MzE4OTMz","avatar_url":"https://avatars1.githubusercontent.com/u/15318933?v=4","gravatar_id":"","url":"https://api.github.com/users/silverspace","html_url":"https://github.com/silverspace","followers_url":"https://api.github.com/users/silverspace/followers","following_url":"https://api.github.com/users/silverspace/following{/other_user}","gists_url":"https://api.github.com/users/silverspace/gists{/gist_id}","starred_url":"https://api.github.com/users/silverspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverspace/subscriptions","organizations_url":"https://api.github.com/users/silverspace/orgs","repos_url":"https://api.github.com/users/silverspace/repos","events_url":"https://api.github.com/users/silverspace/events{/privacy}","received_events_url":"https://api.github.com/users/silverspace/received_events","type":"User","site_admin":false},"body":"I think the issue is that JSON schema treats the `allOf` as a literal concatenation of the values in the array, and the required attributes are not applied to the result. If you update the required attributes in the `#/definitions` section, they should show up as required. For example:\r\n\r\n```\r\n        \"UserBase\": {\r\n            \"type\": \"object\",\r\n            \"required\": [ \"name\", \"email\", \"authType\" ],\r\n```","created_at":"2018-11-15T07:06:48Z","updated_at":"2018-11-15T07:06:48Z","html_url":"https://github.com/samsarahq/api-docs/pull/77#discussion_r233730808","pull_request_url":"https://api.github.com/repos/samsarahq/api-docs/pulls/77","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/comments/233730808"},"html":{"href":"https://github.com/samsarahq/api-docs/pull/77#discussion_r233730808"},"pull_request":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/77"}},"in_reply_to_id":233726869},"pull_request":{"url":"https://api.github.com/repos/samsarahq/api-docs/pulls/77","id":229899656,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODk5NjU2","html_url":"https://github.com/samsarahq/api-docs/pull/77","diff_url":"https://github.com/samsarahq/api-docs/pull/77.diff","patch_url":"https://github.com/samsarahq/api-docs/pull/77.patch","issue_url":"https://api.github.com/repos/samsarahq/api-docs/issues/77","number":77,"state":"open","locked":false,"title":"Dsharrison/users crud api","user":{"login":"dsharrison","id":9137905,"node_id":"MDQ6VXNlcjkxMzc5MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/9137905?v=4","gravatar_id":"","url":"https://api.github.com/users/dsharrison","html_url":"https://github.com/dsharrison","followers_url":"https://api.github.com/users/dsharrison/followers","following_url":"https://api.github.com/users/dsharrison/following{/other_user}","gists_url":"https://api.github.com/users/dsharrison/gists{/gist_id}","starred_url":"https://api.github.com/users/dsharrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsharrison/subscriptions","organizations_url":"https://api.github.com/users/dsharrison/orgs","repos_url":"https://api.github.com/users/dsharrison/repos","events_url":"https://api.github.com/users/dsharrison/events{/privacy}","received_events_url":"https://api.github.com/users/dsharrison/received_events","type":"User","site_admin":false},"body":"Add documentation for the future user CRUD API. This is heavily modeled on the user csv upload functionality available today.\r\n\r\nhttps://rebilly.github.io/ReDoc/?url=https://raw.githubusercontent.com/samsarahq/api-docs/dsharrison/users-crud-api/swagger.json#operation/get_users\r\n\r\n","created_at":"2018-11-10T16:47:59Z","updated_at":"2018-11-15T07:06:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08c650080f3e7e5b9a86d59a8d521c2ce3be1f2d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ehzhang","id":3484848,"node_id":"MDQ6VXNlcjM0ODQ4NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3484848?v=4","gravatar_id":"","url":"https://api.github.com/users/ehzhang","html_url":"https://github.com/ehzhang","followers_url":"https://api.github.com/users/ehzhang/followers","following_url":"https://api.github.com/users/ehzhang/following{/other_user}","gists_url":"https://api.github.com/users/ehzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/ehzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehzhang/subscriptions","organizations_url":"https://api.github.com/users/ehzhang/orgs","repos_url":"https://api.github.com/users/ehzhang/repos","events_url":"https://api.github.com/users/ehzhang/events{/privacy}","received_events_url":"https://api.github.com/users/ehzhang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/samsarahq/api-docs/pulls/77/commits","review_comments_url":"https://api.github.com/repos/samsarahq/api-docs/pulls/77/comments","review_comment_url":"https://api.github.com/repos/samsarahq/api-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samsarahq/api-docs/issues/77/comments","statuses_url":"https://api.github.com/repos/samsarahq/api-docs/statuses/c55b39a3d4da0271d50c4277b51000ca62947e5e","head":{"label":"samsarahq:dsharrison/users-crud-api","ref":"dsharrison/users-crud-api","sha":"c55b39a3d4da0271d50c4277b51000ca62947e5e","user":{"login":"samsarahq","id":14863620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODYzNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/14863620?v=4","gravatar_id":"","url":"https://api.github.com/users/samsarahq","html_url":"https://github.com/samsarahq","followers_url":"https://api.github.com/users/samsarahq/followers","following_url":"https://api.github.com/users/samsarahq/following{/other_user}","gists_url":"https://api.github.com/users/samsarahq/gists{/gist_id}","starred_url":"https://api.github.com/users/samsarahq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsarahq/subscriptions","organizations_url":"https://api.github.com/users/samsarahq/orgs","repos_url":"https://api.github.com/users/samsarahq/repos","events_url":"https://api.github.com/users/samsarahq/events{/privacy}","received_events_url":"https://api.github.com/users/samsarahq/received_events","type":"Organization","site_admin":false},"repo":{"id":67077150,"node_id":"MDEwOlJlcG9zaXRvcnk2NzA3NzE1MA==","name":"api-docs","full_name":"samsarahq/api-docs","private":false,"owner":{"login":"samsarahq","id":14863620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODYzNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/14863620?v=4","gravatar_id":"","url":"https://api.github.com/users/samsarahq","html_url":"https://github.com/samsarahq","followers_url":"https://api.github.com/users/samsarahq/followers","following_url":"https://api.github.com/users/samsarahq/following{/other_user}","gists_url":"https://api.github.com/users/samsarahq/gists{/gist_id}","starred_url":"https://api.github.com/users/samsarahq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsarahq/subscriptions","organizations_url":"https://api.github.com/users/samsarahq/orgs","repos_url":"https://api.github.com/users/samsarahq/repos","events_url":"https://api.github.com/users/samsarahq/events{/privacy}","received_events_url":"https://api.github.com/users/samsarahq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/samsarahq/api-docs","description":null,"fork":false,"url":"https://api.github.com/repos/samsarahq/api-docs","forks_url":"https://api.github.com/repos/samsarahq/api-docs/forks","keys_url":"https://api.github.com/repos/samsarahq/api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsarahq/api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsarahq/api-docs/teams","hooks_url":"https://api.github.com/repos/samsarahq/api-docs/hooks","issue_events_url":"https://api.github.com/repos/samsarahq/api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/samsarahq/api-docs/events","assignees_url":"https://api.github.com/repos/samsarahq/api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/samsarahq/api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/samsarahq/api-docs/tags","blobs_url":"https://api.github.com/repos/samsarahq/api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsarahq/api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsarahq/api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsarahq/api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsarahq/api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/samsarahq/api-docs/languages","stargazers_url":"https://api.github.com/repos/samsarahq/api-docs/stargazers","contributors_url":"https://api.github.com/repos/samsarahq/api-docs/contributors","subscribers_url":"https://api.github.com/repos/samsarahq/api-docs/subscribers","subscription_url":"https://api.github.com/repos/samsarahq/api-docs/subscription","commits_url":"https://api.github.com/repos/samsarahq/api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsarahq/api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsarahq/api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsarahq/api-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsarahq/api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/samsarahq/api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsarahq/api-docs/merges","archive_url":"https://api.github.com/repos/samsarahq/api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsarahq/api-docs/downloads","issues_url":"https://api.github.com/repos/samsarahq/api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/samsarahq/api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/samsarahq/api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/samsarahq/api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsarahq/api-docs/labels{/name}","releases_url":"https://api.github.com/repos/samsarahq/api-docs/releases{/id}","deployments_url":"https://api.github.com/repos/samsarahq/api-docs/deployments","created_at":"2016-08-31T22:11:01Z","updated_at":"2018-11-07T17:48:37Z","pushed_at":"2018-11-15T06:36:38Z","git_url":"git://github.com/samsarahq/api-docs.git","ssh_url":"git@github.com:samsarahq/api-docs.git","clone_url":"https://github.com/samsarahq/api-docs.git","svn_url":"https://github.com/samsarahq/api-docs","homepage":null,"size":283,"stargazers_count":5,"watchers_count":5,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":2,"open_issues":11,"watchers":5,"default_branch":"master"}},"base":{"label":"samsarahq:arcbest-preview","ref":"arcbest-preview","sha":"d0f9d133ae9d308ee9684979f6101e5b0ab7027e","user":{"login":"samsarahq","id":14863620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODYzNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/14863620?v=4","gravatar_id":"","url":"https://api.github.com/users/samsarahq","html_url":"https://github.com/samsarahq","followers_url":"https://api.github.com/users/samsarahq/followers","following_url":"https://api.github.com/users/samsarahq/following{/other_user}","gists_url":"https://api.github.com/users/samsarahq/gists{/gist_id}","starred_url":"https://api.github.com/users/samsarahq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsarahq/subscriptions","organizations_url":"https://api.github.com/users/samsarahq/orgs","repos_url":"https://api.github.com/users/samsarahq/repos","events_url":"https://api.github.com/users/samsarahq/events{/privacy}","received_events_url":"https://api.github.com/users/samsarahq/received_events","type":"Organization","site_admin":false},"repo":{"id":67077150,"node_id":"MDEwOlJlcG9zaXRvcnk2NzA3NzE1MA==","name":"api-docs","full_name":"samsarahq/api-docs","private":false,"owner":{"login":"samsarahq","id":14863620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODYzNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/14863620?v=4","gravatar_id":"","url":"https://api.github.com/users/samsarahq","html_url":"https://github.com/samsarahq","followers_url":"https://api.github.com/users/samsarahq/followers","following_url":"https://api.github.com/users/samsarahq/following{/other_user}","gists_url":"https://api.github.com/users/samsarahq/gists{/gist_id}","starred_url":"https://api.github.com/users/samsarahq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsarahq/subscriptions","organizations_url":"https://api.github.com/users/samsarahq/orgs","repos_url":"https://api.github.com/users/samsarahq/repos","events_url":"https://api.github.com/users/samsarahq/events{/privacy}","received_events_url":"https://api.github.com/users/samsarahq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/samsarahq/api-docs","description":null,"fork":false,"url":"https://api.github.com/repos/samsarahq/api-docs","forks_url":"https://api.github.com/repos/samsarahq/api-docs/forks","keys_url":"https://api.github.com/repos/samsarahq/api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsarahq/api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsarahq/api-docs/teams","hooks_url":"https://api.github.com/repos/samsarahq/api-docs/hooks","issue_events_url":"https://api.github.com/repos/samsarahq/api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/samsarahq/api-docs/events","assignees_url":"https://api.github.com/repos/samsarahq/api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/samsarahq/api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/samsarahq/api-docs/tags","blobs_url":"https://api.github.com/repos/samsarahq/api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsarahq/api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsarahq/api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsarahq/api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsarahq/api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/samsarahq/api-docs/languages","stargazers_url":"https://api.github.com/repos/samsarahq/api-docs/stargazers","contributors_url":"https://api.github.com/repos/samsarahq/api-docs/contributors","subscribers_url":"https://api.github.com/repos/samsarahq/api-docs/subscribers","subscription_url":"https://api.github.com/repos/samsarahq/api-docs/subscription","commits_url":"https://api.github.com/repos/samsarahq/api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsarahq/api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsarahq/api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsarahq/api-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsarahq/api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/samsarahq/api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsarahq/api-docs/merges","archive_url":"https://api.github.com/repos/samsarahq/api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsarahq/api-docs/downloads","issues_url":"https://api.github.com/repos/samsarahq/api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/samsarahq/api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/samsarahq/api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/samsarahq/api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsarahq/api-docs/labels{/name}","releases_url":"https://api.github.com/repos/samsarahq/api-docs/releases{/id}","deployments_url":"https://api.github.com/repos/samsarahq/api-docs/deployments","created_at":"2016-08-31T22:11:01Z","updated_at":"2018-11-07T17:48:37Z","pushed_at":"2018-11-15T06:36:38Z","git_url":"git://github.com/samsarahq/api-docs.git","ssh_url":"git@github.com:samsarahq/api-docs.git","clone_url":"https://github.com/samsarahq/api-docs.git","svn_url":"https://github.com/samsarahq/api-docs","homepage":null,"size":283,"stargazers_count":5,"watchers_count":5,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":2,"open_issues":11,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/77"},"html":{"href":"https://github.com/samsarahq/api-docs/pull/77"},"issue":{"href":"https://api.github.com/repos/samsarahq/api-docs/issues/77"},"comments":{"href":"https://api.github.com/repos/samsarahq/api-docs/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/samsarahq/api-docs/statuses/c55b39a3d4da0271d50c4277b51000ca62947e5e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"silverspace"}}