{"action":"closed","number":256,"pull_request":{"url":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/256","id":171194374,"html_url":"https://github.com/smarthomeNG/smarthome/pull/256","diff_url":"https://github.com/smarthomeNG/smarthome/pull/256.diff","patch_url":"https://github.com/smarthomeNG/smarthome/pull/256.patch","issue_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/256","number":256,"state":"closed","locked":false,"title":"persistent variables are prefixed with logics","user":{"login":"shaas","id":597033,"avatar_url":"https://avatars3.githubusercontent.com/u/597033?v=4","gravatar_id":"","url":"https://api.github.com/users/shaas","html_url":"https://github.com/shaas","followers_url":"https://api.github.com/users/shaas/followers","following_url":"https://api.github.com/users/shaas/following{/other_user}","gists_url":"https://api.github.com/users/shaas/gists{/gist_id}","starred_url":"https://api.github.com/users/shaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaas/subscriptions","organizations_url":"https://api.github.com/users/shaas/orgs","repos_url":"https://api.github.com/users/shaas/repos","events_url":"https://api.github.com/users/shaas/events{/privacy}","received_events_url":"https://api.github.com/users/shaas/received_events","type":"User","site_admin":false},"body":"In the documentation about persistent variables it says it needs to be prefixed with logic instead of logics.","created_at":"2018-02-24T19:48:21Z","updated_at":"2018-02-25T11:32:07Z","closed_at":"2018-02-25T11:32:07Z","merged_at":null,"merge_commit_sha":"83b53a5f4041b50792409c27dc9216e320c1a88c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/256/commits","review_comments_url":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/256/comments","review_comment_url":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/256/comments","statuses_url":"https://api.github.com/repos/smarthomeNG/smarthome/statuses/c3352a288d6160f9841abfaa2fd952a079c6b389","head":{"label":"shaas:bugfix-logic-doc","ref":"bugfix-logic-doc","sha":"c3352a288d6160f9841abfaa2fd952a079c6b389","user":{"login":"shaas","id":597033,"avatar_url":"https://avatars3.githubusercontent.com/u/597033?v=4","gravatar_id":"","url":"https://api.github.com/users/shaas","html_url":"https://github.com/shaas","followers_url":"https://api.github.com/users/shaas/followers","following_url":"https://api.github.com/users/shaas/following{/other_user}","gists_url":"https://api.github.com/users/shaas/gists{/gist_id}","starred_url":"https://api.github.com/users/shaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaas/subscriptions","organizations_url":"https://api.github.com/users/shaas/orgs","repos_url":"https://api.github.com/users/shaas/repos","events_url":"https://api.github.com/users/shaas/events{/privacy}","received_events_url":"https://api.github.com/users/shaas/received_events","type":"User","site_admin":false},"repo":{"id":122773390,"name":"smarthome","full_name":"shaas/smarthome","owner":{"login":"shaas","id":597033,"avatar_url":"https://avatars3.githubusercontent.com/u/597033?v=4","gravatar_id":"","url":"https://api.github.com/users/shaas","html_url":"https://github.com/shaas","followers_url":"https://api.github.com/users/shaas/followers","following_url":"https://api.github.com/users/shaas/following{/other_user}","gists_url":"https://api.github.com/users/shaas/gists{/gist_id}","starred_url":"https://api.github.com/users/shaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaas/subscriptions","organizations_url":"https://api.github.com/users/shaas/orgs","repos_url":"https://api.github.com/users/shaas/repos","events_url":"https://api.github.com/users/shaas/events{/privacy}","received_events_url":"https://api.github.com/users/shaas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shaas/smarthome","description":"Device integration platform for your smart home","fork":true,"url":"https://api.github.com/repos/shaas/smarthome","forks_url":"https://api.github.com/repos/shaas/smarthome/forks","keys_url":"https://api.github.com/repos/shaas/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shaas/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shaas/smarthome/teams","hooks_url":"https://api.github.com/repos/shaas/smarthome/hooks","issue_events_url":"https://api.github.com/repos/shaas/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/shaas/smarthome/events","assignees_url":"https://api.github.com/repos/shaas/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/shaas/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/shaas/smarthome/tags","blobs_url":"https://api.github.com/repos/shaas/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shaas/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shaas/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/shaas/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shaas/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/shaas/smarthome/languages","stargazers_url":"https://api.github.com/repos/shaas/smarthome/stargazers","contributors_url":"https://api.github.com/repos/shaas/smarthome/contributors","subscribers_url":"https://api.github.com/repos/shaas/smarthome/subscribers","subscription_url":"https://api.github.com/repos/shaas/smarthome/subscription","commits_url":"https://api.github.com/repos/shaas/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/shaas/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/shaas/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/shaas/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/shaas/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/shaas/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shaas/smarthome/merges","archive_url":"https://api.github.com/repos/shaas/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shaas/smarthome/downloads","issues_url":"https://api.github.com/repos/shaas/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/shaas/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/shaas/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/shaas/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shaas/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/shaas/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/shaas/smarthome/deployments","created_at":"2018-02-24T19:40:48Z","updated_at":"2018-02-24T19:40:50Z","pushed_at":"2018-02-24T19:46:26Z","git_url":"git://github.com/shaas/smarthome.git","ssh_url":"git@github.com:shaas/smarthome.git","clone_url":"https://github.com/shaas/smarthome.git","svn_url":"https://github.com/shaas/smarthome","homepage":"https://www.smarthomeNG.de","size":22464,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smarthomeNG:master","ref":"master","sha":"0dff02446c57faaccda79d5e2e5e2ff1d6069826","user":{"login":"smarthomeNG","id":17847102,"avatar_url":"https://avatars1.githubusercontent.com/u/17847102?v=4","gravatar_id":"","url":"https://api.github.com/users/smarthomeNG","html_url":"https://github.com/smarthomeNG","followers_url":"https://api.github.com/users/smarthomeNG/followers","following_url":"https://api.github.com/users/smarthomeNG/following{/other_user}","gists_url":"https://api.github.com/users/smarthomeNG/gists{/gist_id}","starred_url":"https://api.github.com/users/smarthomeNG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarthomeNG/subscriptions","organizations_url":"https://api.github.com/users/smarthomeNG/orgs","repos_url":"https://api.github.com/users/smarthomeNG/repos","events_url":"https://api.github.com/users/smarthomeNG/events{/privacy}","received_events_url":"https://api.github.com/users/smarthomeNG/received_events","type":"Organization","site_admin":false},"repo":{"id":53928710,"name":"smarthome","full_name":"smarthomeNG/smarthome","owner":{"login":"smarthomeNG","id":17847102,"avatar_url":"https://avatars1.githubusercontent.com/u/17847102?v=4","gravatar_id":"","url":"https://api.github.com/users/smarthomeNG","html_url":"https://github.com/smarthomeNG","followers_url":"https://api.github.com/users/smarthomeNG/followers","following_url":"https://api.github.com/users/smarthomeNG/following{/other_user}","gists_url":"https://api.github.com/users/smarthomeNG/gists{/gist_id}","starred_url":"https://api.github.com/users/smarthomeNG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarthomeNG/subscriptions","organizations_url":"https://api.github.com/users/smarthomeNG/orgs","repos_url":"https://api.github.com/users/smarthomeNG/repos","events_url":"https://api.github.com/users/smarthomeNG/events{/privacy}","received_events_url":"https://api.github.com/users/smarthomeNG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smarthomeNG/smarthome","description":"Device integration platform for your smart home","fork":false,"url":"https://api.github.com/repos/smarthomeNG/smarthome","forks_url":"https://api.github.com/repos/smarthomeNG/smarthome/forks","keys_url":"https://api.github.com/repos/smarthomeNG/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smarthomeNG/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smarthomeNG/smarthome/teams","hooks_url":"https://api.github.com/repos/smarthomeNG/smarthome/hooks","issue_events_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/smarthomeNG/smarthome/events","assignees_url":"https://api.github.com/repos/smarthomeNG/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/smarthomeNG/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/smarthomeNG/smarthome/tags","blobs_url":"https://api.github.com/repos/smarthomeNG/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smarthomeNG/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smarthomeNG/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/smarthomeNG/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smarthomeNG/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/smarthomeNG/smarthome/languages","stargazers_url":"https://api.github.com/repos/smarthomeNG/smarthome/stargazers","contributors_url":"https://api.github.com/repos/smarthomeNG/smarthome/contributors","subscribers_url":"https://api.github.com/repos/smarthomeNG/smarthome/subscribers","subscription_url":"https://api.github.com/repos/smarthomeNG/smarthome/subscription","commits_url":"https://api.github.com/repos/smarthomeNG/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/smarthomeNG/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/smarthomeNG/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/smarthomeNG/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/smarthomeNG/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smarthomeNG/smarthome/merges","archive_url":"https://api.github.com/repos/smarthomeNG/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smarthomeNG/smarthome/downloads","issues_url":"https://api.github.com/repos/smarthomeNG/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/smarthomeNG/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/smarthomeNG/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/smarthomeNG/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smarthomeNG/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/smarthomeNG/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/smarthomeNG/smarthome/deployments","created_at":"2016-03-15T08:49:44Z","updated_at":"2018-02-08T16:18:27Z","pushed_at":"2018-02-24T19:48:22Z","git_url":"git://github.com/smarthomeNG/smarthome.git","ssh_url":"git@github.com:smarthomeNG/smarthome.git","clone_url":"https://github.com/smarthomeNG/smarthome.git","svn_url":"https://github.com/smarthomeNG/smarthome","homepage":"https://www.smarthomeNG.de","size":22463,"stargazers_count":60,"watchers_count":60,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":62,"open_issues":24,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/256"},"html":{"href":"https://github.com/smarthomeNG/smarthome/pull/256"},"issue":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/issues/256"},"comments":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/smarthomeNG/smarthome/statuses/c3352a288d6160f9841abfaa2fd952a079c6b389"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"shaas"}}