{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/16540","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/16540/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/16540/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/16540/events","html_url":"https://github.com/ampproject/amphtml/pull/16540","id":337915196,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4OTc1NTI4","number":16540,"title":"Ensure divertExperiments() is called last in buildCallback().","user":{"login":"glevitzky","id":20518281,"node_id":"MDQ6VXNlcjIwNTE4Mjgx","avatar_url":"https://avatars1.githubusercontent.com/u/20518281?v=4","gravatar_id":"","url":"https://api.github.com/users/glevitzky","html_url":"https://github.com/glevitzky","followers_url":"https://api.github.com/users/glevitzky/followers","following_url":"https://api.github.com/users/glevitzky/following{/other_user}","gists_url":"https://api.github.com/users/glevitzky/gists{/gist_id}","starred_url":"https://api.github.com/users/glevitzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevitzky/subscriptions","organizations_url":"https://api.github.com/users/glevitzky/orgs","repos_url":"https://api.github.com/users/glevitzky/repos","events_url":"https://api.github.com/users/glevitzky/events{/privacy}","received_events_url":"https://api.github.com/users/glevitzky/received_events","type":"User","site_admin":false},"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-03T14:06:32Z","updated_at":"2018-07-06T20:07:47Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/16540","html_url":"https://github.com/ampproject/amphtml/pull/16540","diff_url":"https://github.com/ampproject/amphtml/pull/16540.diff","patch_url":"https://github.com/ampproject/amphtml/pull/16540.patch"},"body":"Prior to this change, `divertExperiments()` was called before the necessary information to determine whether `isResponsive()` returns true or false is set. This is a problem, since one of the experiments uses `isResponsive()` as part of its eligible traffic check."},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/403133905","html_url":"https://github.com/ampproject/amphtml/pull/16540#issuecomment-403133905","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/16540","id":403133905,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzEzMzkwNQ==","user":{"login":"choumx","id":20525523,"node_id":"MDQ6VXNlcjIwNTI1NTIz","avatar_url":"https://avatars1.githubusercontent.com/u/20525523?v=4","gravatar_id":"","url":"https://api.github.com/users/choumx","html_url":"https://github.com/choumx","followers_url":"https://api.github.com/users/choumx/followers","following_url":"https://api.github.com/users/choumx/following{/other_user}","gists_url":"https://api.github.com/users/choumx/gists{/gist_id}","starred_url":"https://api.github.com/users/choumx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choumx/subscriptions","organizations_url":"https://api.github.com/users/choumx/orgs","repos_url":"https://api.github.com/users/choumx/repos","events_url":"https://api.github.com/users/choumx/events{/privacy}","received_events_url":"https://api.github.com/users/choumx/received_events","type":"User","site_admin":false},"created_at":"2018-07-06T20:07:47Z","updated_at":"2018-07-06T20:07:47Z","author_association":"COLLABORATOR","body":"Fixed the problematic tests in #16592."}}
{"actor":{"display_login":"choumx"}}