{"action":"created","comment":{"url":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/comments/224177828","pull_request_review_id":163482117,"id":224177828,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDE3NzgyOA==","diff_hunk":"@@ -22,6 +22,9 @@ const Sidebar = ({ path, dispatch }) => (\n     >\n       Redux\n     </Link>\n+    <NavLink to=\"/test\" activeClassName={styles.active}>","path":"packages/boilerplate/src/components/Sidebar.js","position":4,"original_position":4,"commit_id":"e42afa5ea1b9fc930db2399c153ce85242739083","original_commit_id":"e42afa5ea1b9fc930db2399c153ce85242739083","user":{"login":"ScriptedAlchemy","id":25274700,"node_id":"MDQ6VXNlcjI1Mjc0NzAw","avatar_url":"https://avatars1.githubusercontent.com/u/25274700?v=4","gravatar_id":"","url":"https://api.github.com/users/ScriptedAlchemy","html_url":"https://github.com/ScriptedAlchemy","followers_url":"https://api.github.com/users/ScriptedAlchemy/followers","following_url":"https://api.github.com/users/ScriptedAlchemy/following{/other_user}","gists_url":"https://api.github.com/users/ScriptedAlchemy/gists{/gist_id}","starred_url":"https://api.github.com/users/ScriptedAlchemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScriptedAlchemy/subscriptions","organizations_url":"https://api.github.com/users/ScriptedAlchemy/orgs","repos_url":"https://api.github.com/users/ScriptedAlchemy/repos","events_url":"https://api.github.com/users/ScriptedAlchemy/events{/privacy}","received_events_url":"https://api.github.com/users/ScriptedAlchemy/received_events","type":"User","site_admin":false},"body":"seems to work fine, but SSR doesnt work (yet) because im adding routes during a render cycle ","created_at":"2018-10-10T17:48:32Z","updated_at":"2018-10-10T17:48:32Z","html_url":"https://github.com/faceyspacey/redux-first-router/pull/296#discussion_r224177828","pull_request_url":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/296","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/comments/224177828"},"html":{"href":"https://github.com/faceyspacey/redux-first-router/pull/296#discussion_r224177828"},"pull_request":{"href":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/296"}},"in_reply_to_id":223231275},"pull_request":{"url":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/296","id":219830007,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODMwMDA3","html_url":"https://github.com/faceyspacey/redux-first-router/pull/296","diff_url":"https://github.com/faceyspacey/redux-first-router/pull/296.diff","patch_url":"https://github.com/faceyspacey/redux-first-router/pull/296.patch","issue_url":"https://api.github.com/repos/faceyspacey/redux-first-router/issues/296","number":296,"state":"open","locked":false,"title":"[WIP] <Router> functionality","user":{"login":"ScriptedAlchemy","id":25274700,"node_id":"MDQ6VXNlcjI1Mjc0NzAw","avatar_url":"https://avatars1.githubusercontent.com/u/25274700?v=4","gravatar_id":"","url":"https://api.github.com/users/ScriptedAlchemy","html_url":"https://github.com/ScriptedAlchemy","followers_url":"https://api.github.com/users/ScriptedAlchemy/followers","following_url":"https://api.github.com/users/ScriptedAlchemy/following{/other_user}","gists_url":"https://api.github.com/users/ScriptedAlchemy/gists{/gist_id}","starred_url":"https://api.github.com/users/ScriptedAlchemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScriptedAlchemy/subscriptions","organizations_url":"https://api.github.com/users/ScriptedAlchemy/orgs","repos_url":"https://api.github.com/users/ScriptedAlchemy/repos","events_url":"https://api.github.com/users/ScriptedAlchemy/events{/privacy}","received_events_url":"https://api.github.com/users/ScriptedAlchemy/received_events","type":"User","site_admin":false},"body":"Last feature,\r\n\r\nThis branch is a WIP and will change. \r\n\r\nMy initial thoughts were to keep it simple, this basically just uses addRoutes to append more to the object. \r\n\r\nThe issue is because im using react children, the first render is a 404 as the route doesn't exist. \r\n\r\nGranted this is in between the old object and the new JSX functionality \r\n\r\nThis also needs to be moved into Rudy and not live in the boilerplate","created_at":"2018-10-02T20:11:40Z","updated_at":"2018-10-10T17:48:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6345a907c6e305df48d8bb846a53d9f99e36c11b","assignee":{"login":"ScriptedAlchemy","id":25274700,"node_id":"MDQ6VXNlcjI1Mjc0NzAw","avatar_url":"https://avatars1.githubusercontent.com/u/25274700?v=4","gravatar_id":"","url":"https://api.github.com/users/ScriptedAlchemy","html_url":"https://github.com/ScriptedAlchemy","followers_url":"https://api.github.com/users/ScriptedAlchemy/followers","following_url":"https://api.github.com/users/ScriptedAlchemy/following{/other_user}","gists_url":"https://api.github.com/users/ScriptedAlchemy/gists{/gist_id}","starred_url":"https://api.github.com/users/ScriptedAlchemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScriptedAlchemy/subscriptions","organizations_url":"https://api.github.com/users/ScriptedAlchemy/orgs","repos_url":"https://api.github.com/users/ScriptedAlchemy/repos","events_url":"https://api.github.com/users/ScriptedAlchemy/events{/privacy}","received_events_url":"https://api.github.com/users/ScriptedAlchemy/received_events","type":"User","site_admin":false},"assignees":[{"login":"ScriptedAlchemy","id":25274700,"node_id":"MDQ6VXNlcjI1Mjc0NzAw","avatar_url":"https://avatars1.githubusercontent.com/u/25274700?v=4","gravatar_id":"","url":"https://api.github.com/users/ScriptedAlchemy","html_url":"https://github.com/ScriptedAlchemy","followers_url":"https://api.github.com/users/ScriptedAlchemy/followers","following_url":"https://api.github.com/users/ScriptedAlchemy/following{/other_user}","gists_url":"https://api.github.com/users/ScriptedAlchemy/gists{/gist_id}","starred_url":"https://api.github.com/users/ScriptedAlchemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScriptedAlchemy/subscriptions","organizations_url":"https://api.github.com/users/ScriptedAlchemy/orgs","repos_url":"https://api.github.com/users/ScriptedAlchemy/repos","events_url":"https://api.github.com/users/ScriptedAlchemy/events{/privacy}","received_events_url":"https://api.github.com/users/ScriptedAlchemy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596019173,"node_id":"MDU6TGFiZWw1OTYwMTkxNzM=","url":"https://api.github.com/repos/faceyspacey/redux-first-router/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/296/commits","review_comments_url":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/296/comments","review_comment_url":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/faceyspacey/redux-first-router/issues/296/comments","statuses_url":"https://api.github.com/repos/faceyspacey/redux-first-router/statuses/e42afa5ea1b9fc930db2399c153ce85242739083","head":{"label":"faceyspacey:jsx-router","ref":"jsx-router","sha":"e42afa5ea1b9fc930db2399c153ce85242739083","user":{"login":"faceyspacey","id":154732,"node_id":"MDQ6VXNlcjE1NDczMg==","avatar_url":"https://avatars0.githubusercontent.com/u/154732?v=4","gravatar_id":"","url":"https://api.github.com/users/faceyspacey","html_url":"https://github.com/faceyspacey","followers_url":"https://api.github.com/users/faceyspacey/followers","following_url":"https://api.github.com/users/faceyspacey/following{/other_user}","gists_url":"https://api.github.com/users/faceyspacey/gists{/gist_id}","starred_url":"https://api.github.com/users/faceyspacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faceyspacey/subscriptions","organizations_url":"https://api.github.com/users/faceyspacey/orgs","repos_url":"https://api.github.com/users/faceyspacey/repos","events_url":"https://api.github.com/users/faceyspacey/events{/privacy}","received_events_url":"https://api.github.com/users/faceyspacey/received_events","type":"User","site_admin":false},"repo":{"id":89994993,"node_id":"MDEwOlJlcG9zaXRvcnk4OTk5NDk5Mw==","name":"redux-first-router","full_name":"faceyspacey/redux-first-router","private":false,"owner":{"login":"faceyspacey","id":154732,"node_id":"MDQ6VXNlcjE1NDczMg==","avatar_url":"https://avatars0.githubusercontent.com/u/154732?v=4","gravatar_id":"","url":"https://api.github.com/users/faceyspacey","html_url":"https://github.com/faceyspacey","followers_url":"https://api.github.com/users/faceyspacey/followers","following_url":"https://api.github.com/users/faceyspacey/following{/other_user}","gists_url":"https://api.github.com/users/faceyspacey/gists{/gist_id}","starred_url":"https://api.github.com/users/faceyspacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faceyspacey/subscriptions","organizations_url":"https://api.github.com/users/faceyspacey/orgs","repos_url":"https://api.github.com/users/faceyspacey/repos","events_url":"https://api.github.com/users/faceyspacey/events{/privacy}","received_events_url":"https://api.github.com/users/faceyspacey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/faceyspacey/redux-first-router","description":"🎖 seamless redux-first routing -- just dispatch actions","fork":false,"url":"https://api.github.com/repos/faceyspacey/redux-first-router","forks_url":"https://api.github.com/repos/faceyspacey/redux-first-router/forks","keys_url":"https://api.github.com/repos/faceyspacey/redux-first-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faceyspacey/redux-first-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faceyspacey/redux-first-router/teams","hooks_url":"https://api.github.com/repos/faceyspacey/redux-first-router/hooks","issue_events_url":"https://api.github.com/repos/faceyspacey/redux-first-router/issues/events{/number}","events_url":"https://api.github.com/repos/faceyspacey/redux-first-router/events","assignees_url":"https://api.github.com/repos/faceyspacey/redux-first-router/assignees{/user}","branches_url":"https://api.github.com/repos/faceyspacey/redux-first-router/branches{/branch}","tags_url":"https://api.github.com/repos/faceyspacey/redux-first-router/tags","blobs_url":"https://api.github.com/repos/faceyspacey/redux-first-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faceyspacey/redux-first-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faceyspacey/redux-first-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/faceyspacey/redux-first-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faceyspacey/redux-first-router/statuses/{sha}","languages_url":"https://api.github.com/repos/faceyspacey/redux-first-router/languages","stargazers_url":"https://api.github.com/repos/faceyspacey/redux-first-router/stargazers","contributors_url":"https://api.github.com/repos/faceyspacey/redux-first-router/contributors","subscribers_url":"https://api.github.com/repos/faceyspacey/redux-first-router/subscribers","subscription_url":"https://api.github.com/repos/faceyspacey/redux-first-router/subscription","commits_url":"https://api.github.com/repos/faceyspacey/redux-first-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/faceyspacey/redux-first-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/faceyspacey/redux-first-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/faceyspacey/redux-first-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/faceyspacey/redux-first-router/contents/{+path}","compare_url":"https://api.github.com/repos/faceyspacey/redux-first-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faceyspacey/redux-first-router/merges","archive_url":"https://api.github.com/repos/faceyspacey/redux-first-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faceyspacey/redux-first-router/downloads","issues_url":"https://api.github.com/repos/faceyspacey/redux-first-router/issues{/number}","pulls_url":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls{/number}","milestones_url":"https://api.github.com/repos/faceyspacey/redux-first-router/milestones{/number}","notifications_url":"https://api.github.com/repos/faceyspacey/redux-first-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faceyspacey/redux-first-router/labels{/name}","releases_url":"https://api.github.com/repos/faceyspacey/redux-first-router/releases{/id}","deployments_url":"https://api.github.com/repos/faceyspacey/redux-first-router/deployments","created_at":"2017-05-02T05:30:22Z","updated_at":"2018-10-09T15:14:00Z","pushed_at":"2018-10-09T20:31:10Z","git_url":"git://github.com/faceyspacey/redux-first-router.git","ssh_url":"git@github.com:faceyspacey/redux-first-router.git","clone_url":"https://github.com/faceyspacey/redux-first-router.git","svn_url":"https://github.com/faceyspacey/redux-first-router","homepage":"","size":4790,"stargazers_count":1337,"watchers_count":1337,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":130,"open_issues":12,"watchers":1337,"default_branch":"master"}},"base":{"label":"faceyspacey:rudy-respond","ref":"rudy-respond","sha":"6f9f540213226e3a25434aba362a182361db607d","user":{"login":"faceyspacey","id":154732,"node_id":"MDQ6VXNlcjE1NDczMg==","avatar_url":"https://avatars0.githubusercontent.com/u/154732?v=4","gravatar_id":"","url":"https://api.github.com/users/faceyspacey","html_url":"https://github.com/faceyspacey","followers_url":"https://api.github.com/users/faceyspacey/followers","following_url":"https://api.github.com/users/faceyspacey/following{/other_user}","gists_url":"https://api.github.com/users/faceyspacey/gists{/gist_id}","starred_url":"https://api.github.com/users/faceyspacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faceyspacey/subscriptions","organizations_url":"https://api.github.com/users/faceyspacey/orgs","repos_url":"https://api.github.com/users/faceyspacey/repos","events_url":"https://api.github.com/users/faceyspacey/events{/privacy}","received_events_url":"https://api.github.com/users/faceyspacey/received_events","type":"User","site_admin":false},"repo":{"id":89994993,"node_id":"MDEwOlJlcG9zaXRvcnk4OTk5NDk5Mw==","name":"redux-first-router","full_name":"faceyspacey/redux-first-router","private":false,"owner":{"login":"faceyspacey","id":154732,"node_id":"MDQ6VXNlcjE1NDczMg==","avatar_url":"https://avatars0.githubusercontent.com/u/154732?v=4","gravatar_id":"","url":"https://api.github.com/users/faceyspacey","html_url":"https://github.com/faceyspacey","followers_url":"https://api.github.com/users/faceyspacey/followers","following_url":"https://api.github.com/users/faceyspacey/following{/other_user}","gists_url":"https://api.github.com/users/faceyspacey/gists{/gist_id}","starred_url":"https://api.github.com/users/faceyspacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faceyspacey/subscriptions","organizations_url":"https://api.github.com/users/faceyspacey/orgs","repos_url":"https://api.github.com/users/faceyspacey/repos","events_url":"https://api.github.com/users/faceyspacey/events{/privacy}","received_events_url":"https://api.github.com/users/faceyspacey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/faceyspacey/redux-first-router","description":"🎖 seamless redux-first routing -- just dispatch actions","fork":false,"url":"https://api.github.com/repos/faceyspacey/redux-first-router","forks_url":"https://api.github.com/repos/faceyspacey/redux-first-router/forks","keys_url":"https://api.github.com/repos/faceyspacey/redux-first-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faceyspacey/redux-first-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faceyspacey/redux-first-router/teams","hooks_url":"https://api.github.com/repos/faceyspacey/redux-first-router/hooks","issue_events_url":"https://api.github.com/repos/faceyspacey/redux-first-router/issues/events{/number}","events_url":"https://api.github.com/repos/faceyspacey/redux-first-router/events","assignees_url":"https://api.github.com/repos/faceyspacey/redux-first-router/assignees{/user}","branches_url":"https://api.github.com/repos/faceyspacey/redux-first-router/branches{/branch}","tags_url":"https://api.github.com/repos/faceyspacey/redux-first-router/tags","blobs_url":"https://api.github.com/repos/faceyspacey/redux-first-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faceyspacey/redux-first-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faceyspacey/redux-first-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/faceyspacey/redux-first-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faceyspacey/redux-first-router/statuses/{sha}","languages_url":"https://api.github.com/repos/faceyspacey/redux-first-router/languages","stargazers_url":"https://api.github.com/repos/faceyspacey/redux-first-router/stargazers","contributors_url":"https://api.github.com/repos/faceyspacey/redux-first-router/contributors","subscribers_url":"https://api.github.com/repos/faceyspacey/redux-first-router/subscribers","subscription_url":"https://api.github.com/repos/faceyspacey/redux-first-router/subscription","commits_url":"https://api.github.com/repos/faceyspacey/redux-first-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/faceyspacey/redux-first-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/faceyspacey/redux-first-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/faceyspacey/redux-first-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/faceyspacey/redux-first-router/contents/{+path}","compare_url":"https://api.github.com/repos/faceyspacey/redux-first-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faceyspacey/redux-first-router/merges","archive_url":"https://api.github.com/repos/faceyspacey/redux-first-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faceyspacey/redux-first-router/downloads","issues_url":"https://api.github.com/repos/faceyspacey/redux-first-router/issues{/number}","pulls_url":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls{/number}","milestones_url":"https://api.github.com/repos/faceyspacey/redux-first-router/milestones{/number}","notifications_url":"https://api.github.com/repos/faceyspacey/redux-first-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faceyspacey/redux-first-router/labels{/name}","releases_url":"https://api.github.com/repos/faceyspacey/redux-first-router/releases{/id}","deployments_url":"https://api.github.com/repos/faceyspacey/redux-first-router/deployments","created_at":"2017-05-02T05:30:22Z","updated_at":"2018-10-09T15:14:00Z","pushed_at":"2018-10-09T20:31:10Z","git_url":"git://github.com/faceyspacey/redux-first-router.git","ssh_url":"git@github.com:faceyspacey/redux-first-router.git","clone_url":"https://github.com/faceyspacey/redux-first-router.git","svn_url":"https://github.com/faceyspacey/redux-first-router","homepage":"","size":4790,"stargazers_count":1337,"watchers_count":1337,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":130,"open_issues":12,"watchers":1337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/296"},"html":{"href":"https://github.com/faceyspacey/redux-first-router/pull/296"},"issue":{"href":"https://api.github.com/repos/faceyspacey/redux-first-router/issues/296"},"comments":{"href":"https://api.github.com/repos/faceyspacey/redux-first-router/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/faceyspacey/redux-first-router/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/faceyspacey/redux-first-router/statuses/e42afa5ea1b9fc930db2399c153ce85242739083"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ScriptedAlchemy"}}