{"action":"created","comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments/238139893","pull_request_review_id":180608487,"id":238139893,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODEzOTg5Mw==","diff_hunk":"@@ -49,18 +50,27 @@\n import java.util.Set;\n \n import org.junit.Test;\n+import org.junit.runner.RunWith;\n+import org.powermock.core.classloader.annotations.PowerMockIgnore;\n+import org.powermock.core.classloader.annotations.PrepareForTest;\n+import org.powermock.modules.junit4.PowerMockRunner;\n \n import com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck;\n import com.puppycrawl.tools.checkstyle.api.CheckstyleException;\n import com.puppycrawl.tools.checkstyle.api.FileText;\n import com.puppycrawl.tools.checkstyle.api.LocalizedMessage;\n import com.puppycrawl.tools.checkstyle.checks.annotation.AnnotationLocationCheck;\n import com.puppycrawl.tools.checkstyle.internal.utils.CheckUtil;\n+import com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtil;\n \n /**\n- * Enter a description of class PackageObjectFactoryTest.java.\n+ * This test uses the Powermock framework to simulate an exception\n+ * in the methid {@link ModuleReflectionUtil#getCheckstyleModules(Collection, ClassLoader)}.","path":"src/test/java/com/puppycrawl/tools/checkstyle/PackageObjectFactoryTest.java","position":null,"original_position":30,"commit_id":"ec6e290ae387f0ea916e746b012828a893390555","original_commit_id":"4d92b5a4c878199be2067681c8b45150f1e77fb4","user":{"login":"pbludov","id":900805,"node_id":"MDQ6VXNlcjkwMDgwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/900805?v=4","gravatar_id":"","url":"https://api.github.com/users/pbludov","html_url":"https://github.com/pbludov","followers_url":"https://api.github.com/users/pbludov/followers","following_url":"https://api.github.com/users/pbludov/following{/other_user}","gists_url":"https://api.github.com/users/pbludov/gists{/gist_id}","starred_url":"https://api.github.com/users/pbludov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbludov/subscriptions","organizations_url":"https://api.github.com/users/pbludov/orgs","repos_url":"https://api.github.com/users/pbludov/repos","events_url":"https://api.github.com/users/pbludov/events{/privacy}","received_events_url":"https://api.github.com/users/pbludov/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-12-03T04:02:10Z","updated_at":"2018-12-03T04:02:11Z","html_url":"https://github.com/checkstyle/checkstyle/pull/6239#discussion_r238139893","pull_request_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/6239","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments/238139893"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/6239#discussion_r238139893"},"pull_request":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/6239"}},"in_reply_to_id":238132122},"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/6239","id":235254709,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjU0NzA5","html_url":"https://github.com/checkstyle/checkstyle/pull/6239","diff_url":"https://github.com/checkstyle/checkstyle/pull/6239.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/6239.patch","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/6239","number":6239,"state":"open","locked":false,"title":"Issue #6238: Upgrade Powermock2 to RC4","user":{"login":"pbludov","id":900805,"node_id":"MDQ6VXNlcjkwMDgwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/900805?v=4","gravatar_id":"","url":"https://api.github.com/users/pbludov","html_url":"https://github.com/pbludov","followers_url":"https://api.github.com/users/pbludov/followers","following_url":"https://api.github.com/users/pbludov/following{/other_user}","gists_url":"https://api.github.com/users/pbludov/gists{/gist_id}","starred_url":"https://api.github.com/users/pbludov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbludov/subscriptions","organizations_url":"https://api.github.com/users/pbludov/orgs","repos_url":"https://api.github.com/users/pbludov/repos","events_url":"https://api.github.com/users/pbludov/events{/privacy}","received_events_url":"https://api.github.com/users/pbludov/received_events","type":"User","site_admin":false},"body":"Issue #6238\r\n\r\nPart of #6238 It simply fixed one test:\r\n```\r\nwhen(classLoader.getURLs()).thenThrow(IOException.class);\r\n```\r\nis not a legal code, since `URLClassLoader.getURLs()` throws nothing.","created_at":"2018-12-02T12:03:50Z","updated_at":"2018-12-03T04:02:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d72e35de128a01f00d6b91d926b4d31f70bc90b7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"romani","id":812984,"node_id":"MDQ6VXNlcjgxMjk4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/812984?v=4","gravatar_id":"","url":"https://api.github.com/users/romani","html_url":"https://github.com/romani","followers_url":"https://api.github.com/users/romani/followers","following_url":"https://api.github.com/users/romani/following{/other_user}","gists_url":"https://api.github.com/users/romani/gists{/gist_id}","starred_url":"https://api.github.com/users/romani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romani/subscriptions","organizations_url":"https://api.github.com/users/romani/orgs","repos_url":"https://api.github.com/users/romani/repos","events_url":"https://api.github.com/users/romani/events{/privacy}","received_events_url":"https://api.github.com/users/romani/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/6239/commits","review_comments_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/6239/comments","review_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/6239/comments","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/ec6e290ae387f0ea916e746b012828a893390555","head":{"label":"pbludov:issue-6238","ref":"issue-6238","sha":"ec6e290ae387f0ea916e746b012828a893390555","user":{"login":"pbludov","id":900805,"node_id":"MDQ6VXNlcjkwMDgwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/900805?v=4","gravatar_id":"","url":"https://api.github.com/users/pbludov","html_url":"https://github.com/pbludov","followers_url":"https://api.github.com/users/pbludov/followers","following_url":"https://api.github.com/users/pbludov/following{/other_user}","gists_url":"https://api.github.com/users/pbludov/gists{/gist_id}","starred_url":"https://api.github.com/users/pbludov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbludov/subscriptions","organizations_url":"https://api.github.com/users/pbludov/orgs","repos_url":"https://api.github.com/users/pbludov/repos","events_url":"https://api.github.com/users/pbludov/events{/privacy}","received_events_url":"https://api.github.com/users/pbludov/received_events","type":"User","site_admin":false},"repo":{"id":153001169,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMwMDExNjk=","name":"checkstyle","full_name":"pbludov/checkstyle","private":false,"owner":{"login":"pbludov","id":900805,"node_id":"MDQ6VXNlcjkwMDgwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/900805?v=4","gravatar_id":"","url":"https://api.github.com/users/pbludov","html_url":"https://github.com/pbludov","followers_url":"https://api.github.com/users/pbludov/followers","following_url":"https://api.github.com/users/pbludov/following{/other_user}","gists_url":"https://api.github.com/users/pbludov/gists{/gist_id}","starred_url":"https://api.github.com/users/pbludov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbludov/subscriptions","organizations_url":"https://api.github.com/users/pbludov/orgs","repos_url":"https://api.github.com/users/pbludov/repos","events_url":"https://api.github.com/users/pbludov/events{/privacy}","received_events_url":"https://api.github.com/users/pbludov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pbludov/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":true,"url":"https://api.github.com/repos/pbludov/checkstyle","forks_url":"https://api.github.com/repos/pbludov/checkstyle/forks","keys_url":"https://api.github.com/repos/pbludov/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbludov/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbludov/checkstyle/teams","hooks_url":"https://api.github.com/repos/pbludov/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/pbludov/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/pbludov/checkstyle/events","assignees_url":"https://api.github.com/repos/pbludov/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/pbludov/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/pbludov/checkstyle/tags","blobs_url":"https://api.github.com/repos/pbludov/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbludov/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbludov/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbludov/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbludov/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/pbludov/checkstyle/languages","stargazers_url":"https://api.github.com/repos/pbludov/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/pbludov/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/pbludov/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/pbludov/checkstyle/subscription","commits_url":"https://api.github.com/repos/pbludov/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbludov/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbludov/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbludov/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbludov/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/pbludov/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbludov/checkstyle/merges","archive_url":"https://api.github.com/repos/pbludov/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbludov/checkstyle/downloads","issues_url":"https://api.github.com/repos/pbludov/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/pbludov/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/pbludov/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/pbludov/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbludov/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/pbludov/checkstyle/releases{/id}","deployments_url":"https://api.github.com/repos/pbludov/checkstyle/deployments","created_at":"2018-10-14T17:39:36Z","updated_at":"2018-12-02T11:19:08Z","pushed_at":"2018-12-03T03:55:27Z","git_url":"git://github.com/pbludov/checkstyle.git","ssh_url":"git@github.com:pbludov/checkstyle.git","clone_url":"https://github.com/pbludov/checkstyle.git","svn_url":"https://github.com/pbludov/checkstyle","homepage":"https://checkstyle.org/","size":59784,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"checkstyle:master","ref":"master","sha":"6f1af651141fa5f6cfc416d8c0fb2c43d0a85036","user":{"login":"checkstyle","id":5179750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5179750?v=4","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"repo":{"id":12499251,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5OTI1MQ==","name":"checkstyle","full_name":"checkstyle/checkstyle","private":false,"owner":{"login":"checkstyle","id":5179750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5179750?v=4","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/checkstyle/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":false,"url":"https://api.github.com/repos/checkstyle/checkstyle","forks_url":"https://api.github.com/repos/checkstyle/checkstyle/forks","keys_url":"https://api.github.com/repos/checkstyle/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/checkstyle/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/checkstyle/checkstyle/teams","hooks_url":"https://api.github.com/repos/checkstyle/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/checkstyle/checkstyle/events","assignees_url":"https://api.github.com/repos/checkstyle/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/checkstyle/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/checkstyle/checkstyle/tags","blobs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/checkstyle/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/checkstyle/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/checkstyle/checkstyle/languages","stargazers_url":"https://api.github.com/repos/checkstyle/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/checkstyle/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/checkstyle/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/checkstyle/checkstyle/subscription","commits_url":"https://api.github.com/repos/checkstyle/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/checkstyle/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/checkstyle/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/checkstyle/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/checkstyle/checkstyle/merges","archive_url":"https://api.github.com/repos/checkstyle/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/checkstyle/checkstyle/downloads","issues_url":"https://api.github.com/repos/checkstyle/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/checkstyle/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/checkstyle/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/checkstyle/checkstyle/releases{/id}","deployments_url":"https://api.github.com/repos/checkstyle/checkstyle/deployments","created_at":"2013-08-31T02:05:05Z","updated_at":"2018-12-03T00:16:47Z","pushed_at":"2018-12-03T03:55:31Z","git_url":"git://github.com/checkstyle/checkstyle.git","ssh_url":"git@github.com:checkstyle/checkstyle.git","clone_url":"https://github.com/checkstyle/checkstyle.git","svn_url":"https://github.com/checkstyle/checkstyle","homepage":"https://checkstyle.org/","size":59845,"stargazers_count":4066,"watchers_count":4066,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6677,"mirror_url":null,"archived":false,"open_issues_count":492,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6677,"open_issues":492,"watchers":4066,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/6239"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/6239"},"issue":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/6239"},"comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/6239/comments"},"review_comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/6239/comments"},"review_comment":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/6239/commits"},"statuses":{"href":"https://api.github.com/repos/checkstyle/checkstyle/statuses/ec6e290ae387f0ea916e746b012828a893390555"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pbludov"}}