{"action":"created","issue":{"url":"https://api.github.com/repos/woook/moka-fe/issues/482","repository_url":"https://api.github.com/repos/woook/moka-fe","labels_url":"https://api.github.com/repos/woook/moka-fe/issues/482/labels{/name}","comments_url":"https://api.github.com/repos/woook/moka-fe/issues/482/comments","events_url":"https://api.github.com/repos/woook/moka-fe/issues/482/events","html_url":"https://github.com/woook/moka-fe/pull/482","id":307325731,"number":482,"title":"100 k tracking","user":{"login":"aledj2","id":5880128,"avatar_url":"https://avatars3.githubusercontent.com/u/5880128?v=4","gravatar_id":"","url":"https://api.github.com/users/aledj2","html_url":"https://github.com/aledj2","followers_url":"https://api.github.com/users/aledj2/followers","following_url":"https://api.github.com/users/aledj2/following{/other_user}","gists_url":"https://api.github.com/users/aledj2/gists{/gist_id}","starred_url":"https://api.github.com/users/aledj2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledj2/subscriptions","organizations_url":"https://api.github.com/users/aledj2/orgs","repos_url":"https://api.github.com/users/aledj2/repos","events_url":"https://api.github.com/users/aledj2/events{/privacy}","received_events_url":"https://api.github.com/users/aledj2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"andyb3","id":20341309,"avatar_url":"https://avatars2.githubusercontent.com/u/20341309?v=4","gravatar_id":"","url":"https://api.github.com/users/andyb3","html_url":"https://github.com/andyb3","followers_url":"https://api.github.com/users/andyb3/followers","following_url":"https://api.github.com/users/andyb3/following{/other_user}","gists_url":"https://api.github.com/users/andyb3/gists{/gist_id}","starred_url":"https://api.github.com/users/andyb3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyb3/subscriptions","organizations_url":"https://api.github.com/users/andyb3/orgs","repos_url":"https://api.github.com/users/andyb3/repos","events_url":"https://api.github.com/users/andyb3/events{/privacy}","received_events_url":"https://api.github.com/users/andyb3/received_events","type":"User","site_admin":false},"assignees":[{"login":"andyb3","id":20341309,"avatar_url":"https://avatars2.githubusercontent.com/u/20341309?v=4","gravatar_id":"","url":"https://api.github.com/users/andyb3","html_url":"https://github.com/andyb3","followers_url":"https://api.github.com/users/andyb3/followers","following_url":"https://api.github.com/users/andyb3/following{/other_user}","gists_url":"https://api.github.com/users/andyb3/gists{/gist_id}","starred_url":"https://api.github.com/users/andyb3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyb3/subscriptions","organizations_url":"https://api.github.com/users/andyb3/orgs","repos_url":"https://api.github.com/users/andyb3/repos","events_url":"https://api.github.com/users/andyb3/events{/privacy}","received_events_url":"https://api.github.com/users/andyb3/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2018-03-21T16:39:18Z","updated_at":"2018-03-28T09:54:07Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/woook/moka-fe/pulls/482","html_url":"https://github.com/woook/moka-fe/pull/482","diff_url":"https://github.com/woook/moka-fe/pull/482.diff","patch_url":"https://github.com/woook/moka-fe/pull/482.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/woook/moka-fe/482)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/woook/moka-fe/issues/comments/376829377","html_url":"https://github.com/woook/moka-fe/pull/482#issuecomment-376829377","issue_url":"https://api.github.com/repos/woook/moka-fe/issues/482","id":376829377,"user":{"login":"aledj2","id":5880128,"avatar_url":"https://avatars3.githubusercontent.com/u/5880128?v=4","gravatar_id":"","url":"https://api.github.com/users/aledj2","html_url":"https://github.com/aledj2","followers_url":"https://api.github.com/users/aledj2/followers","following_url":"https://api.github.com/users/aledj2/following{/other_user}","gists_url":"https://api.github.com/users/aledj2/gists{/gist_id}","starred_url":"https://api.github.com/users/aledj2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledj2/subscriptions","organizations_url":"https://api.github.com/users/aledj2/orgs","repos_url":"https://api.github.com/users/aledj2/repos","events_url":"https://api.github.com/users/aledj2/events{/privacy}","received_events_url":"https://api.github.com/users/aledj2/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T09:54:07Z","updated_at":"2018-03-28T09:54:07Z","author_association":"COLLABORATOR","body":"\n\n\n\nReview status: 4 of 6 files reviewed at latest revision, 17 unresolved discussions.\n\n---\n\n*[forms/88005_GEL_InsertPatient, line 113 at r1](https://beta.reviewable.io/reviews/woook/moka-fe/482#-L8fKBdZ67jvTuoRTauv:-L8g-0Ww8KHUF2vtVpa9:b-896fix) ([raw file](https://github.com/woook/moka-fe/blob/78ba9408ef2c7f99360304d62410a24ed6bcb563/forms/88005_GEL_InsertPatient#L113)):*\n<details><summary><i>Previously, andyb3 wrote…</i></summary><blockquote>\n\n>         ' capture the strInternalPatientID ready to insert to NGSTest\n>         strInternalPatientID = rsMokaPatients!InternalPatientID\n>         'Update patient status to 100K\n>         strPatStatus = \"UPDATE Patients SET s_StatusOverall = 1202218839 WHERE InternalPatientID = \" & strInternalPatientID\n>         'Record status update in log\n>         strPatLogStatus = \"INSERT INTO PatientLog(InternalPatientID, LogEntry, [Date], Login, PCName) VALUES(\" & strInternalPatientID & \", 'Patients: Status changed to 100K ',#\" + dt + \"#,'\" + usr + \"','\" + cmp + \"')\"\n>         DoCmd.SetWarnings False\n>         DoCmd.RunSQL strPatLogStatus\n>         DoCmd.SetWarnings True\n\nCould you indent this else block?\n</blockquote></details>\n\nDone.\n\n---\n\n*[forms/88006_GEL_tracking, line 20 at r1](https://beta.reviewable.io/reviews/woook/moka-fe/482#-L8fLxhM5qEPRADqtDCI:-L8g-FFNATnv7hrRoxLE:b-896fix) ([raw file](https://github.com/woook/moka-fe/blob/78ba9408ef2c7f99360304d62410a24ed6bcb563/forms/88006_GEL_tracking#L20)):*\n<details><summary><i>Previously, andyb3 wrote…</i></summary><blockquote>\n\n> 'Private Sub auth_button_Click()\n> 'On Error GoTo Err_auth_button_Click\n> '    ' define the form to be opened and the link criteria\n> '    Dim stDocName As String\n> '    Dim stLinkCriteria As String\n> '    stDocName = \"88004_100K_auth\"\n> '    ' open the subform as a datasheet\n> '    DoCmd.OpenForm stDocName, acFormDS, , stLinkCriteria\n> '\n> 'Exit_auth_button_Click:\n> '    Exit Sub\n> '\n> 'Err_auth_button_Click:\n> '    MsgBox Err.Description\n> '    Resume Exit_auth_button_Click\n> '\n> 'End Sub\n\nIs this not in use anymore? Should it be deleted?\n</blockquote></details>\n\nDone.\n\n---\n\n*[forms/88006_GEL_tracking, line 39 at r1](https://beta.reviewable.io/reviews/woook/moka-fe/482#-L8fNyXk48pALmjbhYCh:-L8g04Gd0dN1ISdcKB5x:b-896fix) ([raw file](https://github.com/woook/moka-fe/blob/78ba9408ef2c7f99360304d62410a24ed6bcb563/forms/88006_GEL_tracking#L39)):*\n<details><summary><i>Previously, andyb3 wrote…</i></summary><blockquote>\n\n(Same goes for other filter fields below)\n</blockquote></details>\n\nDone.\n\n---\n\n*[forms/88006_GEL_tracking, line 62 at r1](https://beta.reviewable.io/reviews/woook/moka-fe/482#-L8fPG_s-dUbTBpptUDp:-L8g03zN95pJIJIusK9n:b-896fix) ([raw file](https://github.com/woook/moka-fe/blob/78ba9408ef2c7f99360304d62410a24ed6bcb563/forms/88006_GEL_tracking#L62)):*\n<details><summary><i>Previously, andyb3 wrote…</i></summary><blockquote>\n\nThis End If is over-indented. Same goes for check3 below\n</blockquote></details>\n\nDone.\n\n---\n\n*[forms/88006_GEL_tracking, line 64 at r1](https://beta.reviewable.io/reviews/woook/moka-fe/482#-L8fQNOe4-taB6bC3l8I:-L8g03oR-CsI-zi51yQZ:b-896fix) ([raw file](https://github.com/woook/moka-fe/blob/78ba9408ef2c7f99360304d62410a24ed6bcb563/forms/88006_GEL_tracking#L64)):*\n<details><summary><i>Previously, andyb3 wrote…</i></summary><blockquote>\n\ncheck4?\n</blockquote></details>\n\nDone.\n\n---\n\n*[forms/88006_GEL_tracking, line 82 at r1](https://beta.reviewable.io/reviews/woook/moka-fe/482#-L8fPzmHCiibxUucdCoi:-L8g0TbNB47w4utBiCyU:b-896fix) ([raw file](https://github.com/woook/moka-fe/blob/78ba9408ef2c7f99360304d62410a24ed6bcb563/forms/88006_GEL_tracking#L82)):*\n<details><summary><i>Previously, andyb3 wrote…</i></summary><blockquote>\n\nCouldn't this just be:\n`filter_msg = \"[StatusID]=\" & status_filter.Column(0)`\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/woook/moka-fe/482)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"aledj2"}}