{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments/182434236","pull_request_review_id":113227428,"id":182434236,"diff_hunk":"@@ -380,6 +397,8 @@ class TwoStepCaretHandler {\n \t\t\tif ( position.isAtStart ) {\n \t\t\t\tif ( this._hasSelectionAttribute ) {\n \t\t\t\t\tthis._removeSelectionAttribute();","path":"src/utils/bindtwostepcarettoattribute.js","position":null,"original_position":116,"commit_id":"24f8e2f890ba264b7ab0b786a4ca3215f962d1de","original_commit_id":"4f6d9d94f98d50d3645f47c43b9743be4ca758f4","user":{"login":"scofalik","id":1502228,"avatar_url":"https://avatars1.githubusercontent.com/u/1502228?v=4","gravatar_id":"","url":"https://api.github.com/users/scofalik","html_url":"https://github.com/scofalik","followers_url":"https://api.github.com/users/scofalik/followers","following_url":"https://api.github.com/users/scofalik/following{/other_user}","gists_url":"https://api.github.com/users/scofalik/gists{/gist_id}","starred_url":"https://api.github.com/users/scofalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scofalik/subscriptions","organizations_url":"https://api.github.com/users/scofalik/orgs","repos_url":"https://api.github.com/users/scofalik/repos","events_url":"https://api.github.com/users/scofalik/events{/privacy}","received_events_url":"https://api.github.com/users/scofalik/received_events","type":"User","site_admin":false},"body":"lol :)\r\n\r\n![apr-18-2018 16-01-40](https://user-images.githubusercontent.com/1502228/38936233-a41d451a-4320-11e8-8eb1-3db3fd5f8eef.gif)\r\n","created_at":"2018-04-18T13:53:37Z","updated_at":"2018-04-18T13:53:38Z","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1406#discussion_r182434236","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1406","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments/182434236"},"html":{"href":"https://github.com/ckeditor/ckeditor5-engine/pull/1406#discussion_r182434236"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1406"}},"in_reply_to_id":182418023},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1406","id":181841820,"html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1406","diff_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1406.diff","patch_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1406.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1406","number":1406,"state":"open","locked":false,"title":"t/1301: The bindTwoStepCaretToAttribute should not fail in more complex cases","user":{"login":"oleq","id":1099479,"avatar_url":"https://avatars1.githubusercontent.com/u/1099479?v=4","gravatar_id":"","url":"https://api.github.com/users/oleq","html_url":"https://github.com/oleq","followers_url":"https://api.github.com/users/oleq/followers","following_url":"https://api.github.com/users/oleq/following{/other_user}","gists_url":"https://api.github.com/users/oleq/gists{/gist_id}","starred_url":"https://api.github.com/users/oleq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleq/subscriptions","organizations_url":"https://api.github.com/users/oleq/orgs","repos_url":"https://api.github.com/users/oleq/repos","events_url":"https://api.github.com/users/oleq/events{/privacy}","received_events_url":"https://api.github.com/users/oleq/received_events","type":"User","site_admin":false},"body":"### Suggested merge commit message ([convention](https://github.com/ckeditor/ckeditor5-design/wiki/Git-commit-message-convention))\r\n\r\nFix: The `bindTwoStepCaretToAttribute` behavioral helper should not fail in more complex cases. Closes #1301. Closes #1346. Closes ckeditor/ckeditor5#937.  Closes ckeditor/ckeditor5#922.  Closes ckeditor/ckeditor5#946.\r\n\r\n---\r\n\r\n### Additional information\r\n\r\n**Note**: A thorough testing required before merging. @Mgsy?\r\n","created_at":"2018-04-16T12:17:55Z","updated_at":"2018-04-18T13:53:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddad92db0a9d143cc2316d97fcf79f5418c83eb5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Mgsy","id":20988892,"avatar_url":"https://avatars3.githubusercontent.com/u/20988892?v=4","gravatar_id":"","url":"https://api.github.com/users/Mgsy","html_url":"https://github.com/Mgsy","followers_url":"https://api.github.com/users/Mgsy/followers","following_url":"https://api.github.com/users/Mgsy/following{/other_user}","gists_url":"https://api.github.com/users/Mgsy/gists{/gist_id}","starred_url":"https://api.github.com/users/Mgsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mgsy/subscriptions","organizations_url":"https://api.github.com/users/Mgsy/orgs","repos_url":"https://api.github.com/users/Mgsy/repos","events_url":"https://api.github.com/users/Mgsy/events{/privacy}","received_events_url":"https://api.github.com/users/Mgsy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":167749141,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels/status:review-","name":"status:review-","color":"ee6622","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1406/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1406/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1406/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/24f8e2f890ba264b7ab0b786a4ca3215f962d1de","head":{"label":"ckeditor:t/1301","ref":"t/1301","sha":"24f8e2f890ba264b7ab0b786a4ca3215f962d1de","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28972890,"name":"ckeditor5-engine","full_name":"ckeditor/ckeditor5-engine","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-engine","description":"CKEditor 5 editing engine.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/deployments","created_at":"2015-01-08T15:47:45Z","updated_at":"2018-04-17T15:47:22Z","pushed_at":"2018-04-18T13:36:32Z","git_url":"git://github.com/ckeditor/ckeditor5-engine.git","ssh_url":"git@github.com:ckeditor/ckeditor5-engine.git","clone_url":"https://github.com/ckeditor/ckeditor5-engine.git","svn_url":"https://github.com/ckeditor/ckeditor5-engine","homepage":"https://ckeditor.com","size":9336,"stargazers_count":52,"watchers_count":52,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":19,"open_issues":197,"watchers":52,"default_branch":"master"}},"base":{"label":"ckeditor:master","ref":"master","sha":"b6a29629d7959ef956bd1d48456927d0910a23cd","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28972890,"name":"ckeditor5-engine","full_name":"ckeditor/ckeditor5-engine","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-engine","description":"CKEditor 5 editing engine.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/deployments","created_at":"2015-01-08T15:47:45Z","updated_at":"2018-04-17T15:47:22Z","pushed_at":"2018-04-18T13:36:32Z","git_url":"git://github.com/ckeditor/ckeditor5-engine.git","ssh_url":"git@github.com:ckeditor/ckeditor5-engine.git","clone_url":"https://github.com/ckeditor/ckeditor5-engine.git","svn_url":"https://github.com/ckeditor/ckeditor5-engine","homepage":"https://ckeditor.com","size":9336,"stargazers_count":52,"watchers_count":52,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":19,"open_issues":197,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1406"},"html":{"href":"https://github.com/ckeditor/ckeditor5-engine/pull/1406"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1406"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1406/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1406/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1406/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/24f8e2f890ba264b7ab0b786a4ca3215f962d1de"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"scofalik"}}