{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/220567636","pull_request_review_id":159003067,"id":220567636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDU2NzYzNg==","diff_hunk":"@@ -126,92 +125,83 @@ class CAFFE2_API Registerer {\n \n   template <class DerivedType>\n   static ObjectPtrType DefaultCreator(Args... args) {\n-    // TODO(jiayq): old versions of NVCC does not handle make_unique well\n-    // so we are forced to use a unique_ptr constructor here. Check if it is\n-    // fine to use make_unique in the future.\n-    // return make_unique<DerivedType>(args...);","path":"c10/util/Registry.h","position":83,"original_position":83,"commit_id":"e393dc538498133938629877101c1a4814b67a32","original_commit_id":"e393dc538498133938629877101c1a4814b67a32","user":{"login":"ezyang","id":13564,"node_id":"MDQ6VXNlcjEzNTY0","avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"So, it's not fine to use `make_unique`?","created_at":"2018-09-26T13:44:22Z","updated_at":"2018-09-26T13:44:22Z","html_url":"https://github.com/pytorch/pytorch/pull/12077#discussion_r220567636","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/12077","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/220567636"},"html":{"href":"https://github.com/pytorch/pytorch/pull/12077#discussion_r220567636"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/12077"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/12077","id":218201197,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MjAxMTk3","html_url":"https://github.com/pytorch/pytorch/pull/12077","diff_url":"https://github.com/pytorch/pytorch/pull/12077.diff","patch_url":"https://github.com/pytorch/pytorch/pull/12077.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/12077","number":12077,"state":"open","locked":false,"title":"Move registry fully to c10","user":{"login":"Yangqing","id":551151,"node_id":"MDQ6VXNlcjU1MTE1MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/551151?v=4","gravatar_id":"","url":"https://api.github.com/users/Yangqing","html_url":"https://github.com/Yangqing","followers_url":"https://api.github.com/users/Yangqing/followers","following_url":"https://api.github.com/users/Yangqing/following{/other_user}","gists_url":"https://api.github.com/users/Yangqing/gists{/gist_id}","starred_url":"https://api.github.com/users/Yangqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yangqing/subscriptions","organizations_url":"https://api.github.com/users/Yangqing/orgs","repos_url":"https://api.github.com/users/Yangqing/repos","events_url":"https://api.github.com/users/Yangqing/events{/privacy}","received_events_url":"https://api.github.com/users/Yangqing/received_events","type":"User","site_admin":false},"body":"This does 6 things:\r\n\r\n- add c10/util/Registry.h as the unified registry util\r\n  - cleaned up some APIs such as export condition\r\n- fully remove aten/core/registry.h\r\n- fully remove caffe2/core/registry.h\r\n- remove a bogus aten/registry.h\r\n- unifying all macros\r\n- set up registry testing in c10\r\n\r\nAlso, an important note that we used to mark the templated Registry class as EXPORT - this should not happen, because one should almost never export a template class. This PR fixes that.","created_at":"2018-09-26T06:23:46Z","updated_at":"2018-09-26T13:44:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c025327bffdef2797d1a92314569656a17a3aa3d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zdevito","id":370202,"node_id":"MDQ6VXNlcjM3MDIwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/370202?v=4","gravatar_id":"","url":"https://api.github.com/users/zdevito","html_url":"https://github.com/zdevito","followers_url":"https://api.github.com/users/zdevito/followers","following_url":"https://api.github.com/users/zdevito/following{/other_user}","gists_url":"https://api.github.com/users/zdevito/gists{/gist_id}","starred_url":"https://api.github.com/users/zdevito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdevito/subscriptions","organizations_url":"https://api.github.com/users/zdevito/orgs","repos_url":"https://api.github.com/users/zdevito/repos","events_url":"https://api.github.com/users/zdevito/events{/privacy}","received_events_url":"https://api.github.com/users/zdevito/received_events","type":"User","site_admin":false},{"login":"colesbury","id":655866,"node_id":"MDQ6VXNlcjY1NTg2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/655866?v=4","gravatar_id":"","url":"https://api.github.com/users/colesbury","html_url":"https://github.com/colesbury","followers_url":"https://api.github.com/users/colesbury/followers","following_url":"https://api.github.com/users/colesbury/following{/other_user}","gists_url":"https://api.github.com/users/colesbury/gists{/gist_id}","starred_url":"https://api.github.com/users/colesbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colesbury/subscriptions","organizations_url":"https://api.github.com/users/colesbury/orgs","repos_url":"https://api.github.com/users/colesbury/repos","events_url":"https://api.github.com/users/colesbury/events{/privacy}","received_events_url":"https://api.github.com/users/colesbury/received_events","type":"User","site_admin":false},{"login":"soumith","id":1310570,"node_id":"MDQ6VXNlcjEzMTA1NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1310570?v=4","gravatar_id":"","url":"https://api.github.com/users/soumith","html_url":"https://github.com/soumith","followers_url":"https://api.github.com/users/soumith/followers","following_url":"https://api.github.com/users/soumith/following{/other_user}","gists_url":"https://api.github.com/users/soumith/gists{/gist_id}","starred_url":"https://api.github.com/users/soumith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumith/subscriptions","organizations_url":"https://api.github.com/users/soumith/orgs","repos_url":"https://api.github.com/users/soumith/repos","events_url":"https://api.github.com/users/soumith/events{/privacy}","received_events_url":"https://api.github.com/users/soumith/received_events","type":"User","site_admin":false},{"login":"gchanan","id":3768583,"node_id":"MDQ6VXNlcjM3Njg1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/3768583?v=4","gravatar_id":"","url":"https://api.github.com/users/gchanan","html_url":"https://github.com/gchanan","followers_url":"https://api.github.com/users/gchanan/followers","following_url":"https://api.github.com/users/gchanan/following{/other_user}","gists_url":"https://api.github.com/users/gchanan/gists{/gist_id}","starred_url":"https://api.github.com/users/gchanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchanan/subscriptions","organizations_url":"https://api.github.com/users/gchanan/orgs","repos_url":"https://api.github.com/users/gchanan/repos","events_url":"https://api.github.com/users/gchanan/events{/privacy}","received_events_url":"https://api.github.com/users/gchanan/received_events","type":"User","site_admin":false},{"login":"apaszke","id":4583066,"node_id":"MDQ6VXNlcjQ1ODMwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/4583066?v=4","gravatar_id":"","url":"https://api.github.com/users/apaszke","html_url":"https://github.com/apaszke","followers_url":"https://api.github.com/users/apaszke/followers","following_url":"https://api.github.com/users/apaszke/following{/other_user}","gists_url":"https://api.github.com/users/apaszke/gists{/gist_id}","starred_url":"https://api.github.com/users/apaszke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apaszke/subscriptions","organizations_url":"https://api.github.com/users/apaszke/orgs","repos_url":"https://api.github.com/users/apaszke/repos","events_url":"https://api.github.com/users/apaszke/events{/privacy}","received_events_url":"https://api.github.com/users/apaszke/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/12077/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/12077/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/12077/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/e393dc538498133938629877101c1a4814b67a32","head":{"label":"Yangqing:c10_registry","ref":"c10_registry","sha":"e393dc538498133938629877101c1a4814b67a32","user":{"login":"Yangqing","id":551151,"node_id":"MDQ6VXNlcjU1MTE1MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/551151?v=4","gravatar_id":"","url":"https://api.github.com/users/Yangqing","html_url":"https://github.com/Yangqing","followers_url":"https://api.github.com/users/Yangqing/followers","following_url":"https://api.github.com/users/Yangqing/following{/other_user}","gists_url":"https://api.github.com/users/Yangqing/gists{/gist_id}","starred_url":"https://api.github.com/users/Yangqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yangqing/subscriptions","organizations_url":"https://api.github.com/users/Yangqing/orgs","repos_url":"https://api.github.com/users/Yangqing/repos","events_url":"https://api.github.com/users/Yangqing/events{/privacy}","received_events_url":"https://api.github.com/users/Yangqing/received_events","type":"User","site_admin":false},"repo":{"id":91034345,"node_id":"MDEwOlJlcG9zaXRvcnk5MTAzNDM0NQ==","name":"pytorch","full_name":"Yangqing/pytorch","private":false,"owner":{"login":"Yangqing","id":551151,"node_id":"MDQ6VXNlcjU1MTE1MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/551151?v=4","gravatar_id":"","url":"https://api.github.com/users/Yangqing","html_url":"https://github.com/Yangqing","followers_url":"https://api.github.com/users/Yangqing/followers","following_url":"https://api.github.com/users/Yangqing/following{/other_user}","gists_url":"https://api.github.com/users/Yangqing/gists{/gist_id}","starred_url":"https://api.github.com/users/Yangqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yangqing/subscriptions","organizations_url":"https://api.github.com/users/Yangqing/orgs","repos_url":"https://api.github.com/users/Yangqing/repos","events_url":"https://api.github.com/users/Yangqing/events{/privacy}","received_events_url":"https://api.github.com/users/Yangqing/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Yangqing/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/Yangqing/pytorch","forks_url":"https://api.github.com/repos/Yangqing/pytorch/forks","keys_url":"https://api.github.com/repos/Yangqing/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yangqing/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yangqing/pytorch/teams","hooks_url":"https://api.github.com/repos/Yangqing/pytorch/hooks","issue_events_url":"https://api.github.com/repos/Yangqing/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/Yangqing/pytorch/events","assignees_url":"https://api.github.com/repos/Yangqing/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/Yangqing/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/Yangqing/pytorch/tags","blobs_url":"https://api.github.com/repos/Yangqing/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yangqing/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yangqing/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yangqing/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yangqing/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/Yangqing/pytorch/languages","stargazers_url":"https://api.github.com/repos/Yangqing/pytorch/stargazers","contributors_url":"https://api.github.com/repos/Yangqing/pytorch/contributors","subscribers_url":"https://api.github.com/repos/Yangqing/pytorch/subscribers","subscription_url":"https://api.github.com/repos/Yangqing/pytorch/subscription","commits_url":"https://api.github.com/repos/Yangqing/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yangqing/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yangqing/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yangqing/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yangqing/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/Yangqing/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yangqing/pytorch/merges","archive_url":"https://api.github.com/repos/Yangqing/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yangqing/pytorch/downloads","issues_url":"https://api.github.com/repos/Yangqing/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/Yangqing/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/Yangqing/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/Yangqing/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yangqing/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/Yangqing/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/Yangqing/pytorch/deployments","created_at":"2017-05-12T00:21:14Z","updated_at":"2018-09-25T17:33:35Z","pushed_at":"2018-09-26T08:40:44Z","git_url":"git://github.com/Yangqing/pytorch.git","ssh_url":"git@github.com:Yangqing/pytorch.git","clone_url":"https://github.com/Yangqing/pytorch.git","svn_url":"https://github.com/Yangqing/pytorch","homepage":"http://pytorch.org","size":75154,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"8ff435c8f60033d6f7795202d145e738a551ee84","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-09-26T13:33:31Z","pushed_at":"2018-09-26T11:08:54Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":76775,"stargazers_count":18995,"watchers_count":18995,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4560,"mirror_url":null,"archived":false,"open_issues_count":1780,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4560,"open_issues":1780,"watchers":18995,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/12077"},"html":{"href":"https://github.com/pytorch/pytorch/pull/12077"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/12077"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/12077/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/12077/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/12077/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/e393dc538498133938629877101c1a4814b67a32"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ezyang"}}