{"action":"closed","number":5276,"pull_request":{"url":"https://api.github.com/repos/gohugoio/hugo/pulls/5276","id":219821650,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODIxNjUw","html_url":"https://github.com/gohugoio/hugo/pull/5276","diff_url":"https://github.com/gohugoio/hugo/pull/5276.diff","patch_url":"https://github.com/gohugoio/hugo/pull/5276.patch","issue_url":"https://api.github.com/repos/gohugoio/hugo/issues/5276","number":5276,"state":"closed","locked":false,"title":"Render markup in figure sc caption and attr","user":{"login":"kaushalmodi","id":3578197,"node_id":"MDQ6VXNlcjM1NzgxOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3578197?v=4","gravatar_id":"","url":"https://api.github.com/users/kaushalmodi","html_url":"https://github.com/kaushalmodi","followers_url":"https://api.github.com/users/kaushalmodi/followers","following_url":"https://api.github.com/users/kaushalmodi/following{/other_user}","gists_url":"https://api.github.com/users/kaushalmodi/gists{/gist_id}","starred_url":"https://api.github.com/users/kaushalmodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaushalmodi/subscriptions","organizations_url":"https://api.github.com/users/kaushalmodi/orgs","repos_url":"https://api.github.com/users/kaushalmodi/repos","events_url":"https://api.github.com/users/kaushalmodi/events{/privacy}","received_events_url":"https://api.github.com/users/kaushalmodi/received_events","type":"User","site_admin":false},"body":"1. First commit cleans up the shortcode to make it more readable, and ready it for the second commit. This commit also updates the tests to pass for the white-space changes made in this commit.\r\n2. Second commit renders the Markdown in `caption` and `attr` parameters of the `figure` shortcode. 2 test cases are added for this change too. None of the existing tests (after the prior whitespace fix commit) needed to be modified for this second commit.\r\n\r\nFixes https://github.com/gohugoio/hugo/issues/4406.\r\n\r\n---\r\n\r\nI found these 13 tests to fail locally before/after building with this PR:\r\n\r\n```\r\n--- FAIL: TestPageWithMoreTagOnlySummary (0.43s)\r\n--- FAIL: TestSummaryWithHTMLTagsOnNextLine (0.34s)\r\n--- FAIL: TestWordCountWithIsCJKLanguageFalse (0.48s)\r\n--- FAIL: TestWordCount (0.53s)\r\n--- FAIL: TestWordCountWithMainEnglishWithCJKRunes (0.53s)\r\n--- FAIL: TestWordCountWithAllCJKRunesWithoutHasCJKLanguage (0.62s)\r\n--- FAIL: TestWordCountWithAllCJKRunesHasCJKLanguage (0.67s)\r\n--- FAIL: TestPageWithMoreTag (0.54s)\r\n--- FAIL: TestPageWithEmbeddedScriptTag (0.65s)\r\n--- FAIL: TestPageWithShortCodeInSummary (0.66s)\r\n--- FAIL: TestPageWithDateFields (0.62s)\r\n--- FAIL: TestPageWithDelimiter (0.59s)\r\n--- FAIL: TestCreateNewPage (0.48s)\r\n--- FAIL: TestGetJSON (4.00s)\r\n````","created_at":"2018-10-02T19:41:02Z","updated_at":"2018-10-03T06:55:55Z","closed_at":"2018-10-03T06:55:55Z","merged_at":"2018-10-03T06:55:54Z","merge_commit_sha":"6818170308994b5f01dec7a559f92d6c7c5ca100","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gohugoio/hugo/pulls/5276/commits","review_comments_url":"https://api.github.com/repos/gohugoio/hugo/pulls/5276/comments","review_comment_url":"https://api.github.com/repos/gohugoio/hugo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gohugoio/hugo/issues/5276/comments","statuses_url":"https://api.github.com/repos/gohugoio/hugo/statuses/17ab19619aee3297df3394a0283e843c126f1150","head":{"label":"kaushalmodi:render-markup-in-figure-sc-captions","ref":"render-markup-in-figure-sc-captions","sha":"17ab19619aee3297df3394a0283e843c126f1150","user":{"login":"kaushalmodi","id":3578197,"node_id":"MDQ6VXNlcjM1NzgxOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3578197?v=4","gravatar_id":"","url":"https://api.github.com/users/kaushalmodi","html_url":"https://github.com/kaushalmodi","followers_url":"https://api.github.com/users/kaushalmodi/followers","following_url":"https://api.github.com/users/kaushalmodi/following{/other_user}","gists_url":"https://api.github.com/users/kaushalmodi/gists{/gist_id}","starred_url":"https://api.github.com/users/kaushalmodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaushalmodi/subscriptions","organizations_url":"https://api.github.com/users/kaushalmodi/orgs","repos_url":"https://api.github.com/users/kaushalmodi/repos","events_url":"https://api.github.com/users/kaushalmodi/events{/privacy}","received_events_url":"https://api.github.com/users/kaushalmodi/received_events","type":"User","site_admin":false},"repo":{"id":70920218,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkyMDIxOA==","name":"hugo","full_name":"kaushalmodi/hugo","private":false,"owner":{"login":"kaushalmodi","id":3578197,"node_id":"MDQ6VXNlcjM1NzgxOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3578197?v=4","gravatar_id":"","url":"https://api.github.com/users/kaushalmodi","html_url":"https://github.com/kaushalmodi","followers_url":"https://api.github.com/users/kaushalmodi/followers","following_url":"https://api.github.com/users/kaushalmodi/following{/other_user}","gists_url":"https://api.github.com/users/kaushalmodi/gists{/gist_id}","starred_url":"https://api.github.com/users/kaushalmodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaushalmodi/subscriptions","organizations_url":"https://api.github.com/users/kaushalmodi/orgs","repos_url":"https://api.github.com/users/kaushalmodi/repos","events_url":"https://api.github.com/users/kaushalmodi/events{/privacy}","received_events_url":"https://api.github.com/users/kaushalmodi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kaushalmodi/hugo","description":"A Fast and Flexible Static Site Generator built with love in GoLang","fork":true,"url":"https://api.github.com/repos/kaushalmodi/hugo","forks_url":"https://api.github.com/repos/kaushalmodi/hugo/forks","keys_url":"https://api.github.com/repos/kaushalmodi/hugo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaushalmodi/hugo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaushalmodi/hugo/teams","hooks_url":"https://api.github.com/repos/kaushalmodi/hugo/hooks","issue_events_url":"https://api.github.com/repos/kaushalmodi/hugo/issues/events{/number}","events_url":"https://api.github.com/repos/kaushalmodi/hugo/events","assignees_url":"https://api.github.com/repos/kaushalmodi/hugo/assignees{/user}","branches_url":"https://api.github.com/repos/kaushalmodi/hugo/branches{/branch}","tags_url":"https://api.github.com/repos/kaushalmodi/hugo/tags","blobs_url":"https://api.github.com/repos/kaushalmodi/hugo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaushalmodi/hugo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaushalmodi/hugo/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaushalmodi/hugo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaushalmodi/hugo/statuses/{sha}","languages_url":"https://api.github.com/repos/kaushalmodi/hugo/languages","stargazers_url":"https://api.github.com/repos/kaushalmodi/hugo/stargazers","contributors_url":"https://api.github.com/repos/kaushalmodi/hugo/contributors","subscribers_url":"https://api.github.com/repos/kaushalmodi/hugo/subscribers","subscription_url":"https://api.github.com/repos/kaushalmodi/hugo/subscription","commits_url":"https://api.github.com/repos/kaushalmodi/hugo/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaushalmodi/hugo/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaushalmodi/hugo/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaushalmodi/hugo/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaushalmodi/hugo/contents/{+path}","compare_url":"https://api.github.com/repos/kaushalmodi/hugo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaushalmodi/hugo/merges","archive_url":"https://api.github.com/repos/kaushalmodi/hugo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaushalmodi/hugo/downloads","issues_url":"https://api.github.com/repos/kaushalmodi/hugo/issues{/number}","pulls_url":"https://api.github.com/repos/kaushalmodi/hugo/pulls{/number}","milestones_url":"https://api.github.com/repos/kaushalmodi/hugo/milestones{/number}","notifications_url":"https://api.github.com/repos/kaushalmodi/hugo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaushalmodi/hugo/labels{/name}","releases_url":"https://api.github.com/repos/kaushalmodi/hugo/releases{/id}","deployments_url":"https://api.github.com/repos/kaushalmodi/hugo/deployments","created_at":"2016-10-14T14:57:10Z","updated_at":"2018-10-02T19:33:24Z","pushed_at":"2018-10-02T19:33:22Z","git_url":"git://github.com/kaushalmodi/hugo.git","ssh_url":"git@github.com:kaushalmodi/hugo.git","clone_url":"https://github.com/kaushalmodi/hugo.git","svn_url":"https://github.com/kaushalmodi/hugo","homepage":"http://gohugo.io","size":61656,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gohugoio:master","ref":"master","sha":"ce264b936ce9f589bd889e18762881cff8bc9cd0","user":{"login":"gohugoio","id":29385237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mzg1MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/29385237?v=4","gravatar_id":"","url":"https://api.github.com/users/gohugoio","html_url":"https://github.com/gohugoio","followers_url":"https://api.github.com/users/gohugoio/followers","following_url":"https://api.github.com/users/gohugoio/following{/other_user}","gists_url":"https://api.github.com/users/gohugoio/gists{/gist_id}","starred_url":"https://api.github.com/users/gohugoio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gohugoio/subscriptions","organizations_url":"https://api.github.com/users/gohugoio/orgs","repos_url":"https://api.github.com/users/gohugoio/repos","events_url":"https://api.github.com/users/gohugoio/events{/privacy}","received_events_url":"https://api.github.com/users/gohugoio/received_events","type":"Organization","site_admin":false},"repo":{"id":11180687,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4MDY4Nw==","name":"hugo","full_name":"gohugoio/hugo","private":false,"owner":{"login":"gohugoio","id":29385237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mzg1MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/29385237?v=4","gravatar_id":"","url":"https://api.github.com/users/gohugoio","html_url":"https://github.com/gohugoio","followers_url":"https://api.github.com/users/gohugoio/followers","following_url":"https://api.github.com/users/gohugoio/following{/other_user}","gists_url":"https://api.github.com/users/gohugoio/gists{/gist_id}","starred_url":"https://api.github.com/users/gohugoio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gohugoio/subscriptions","organizations_url":"https://api.github.com/users/gohugoio/orgs","repos_url":"https://api.github.com/users/gohugoio/repos","events_url":"https://api.github.com/users/gohugoio/events{/privacy}","received_events_url":"https://api.github.com/users/gohugoio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gohugoio/hugo","description":"The world’s fastest framework for building websites.","fork":false,"url":"https://api.github.com/repos/gohugoio/hugo","forks_url":"https://api.github.com/repos/gohugoio/hugo/forks","keys_url":"https://api.github.com/repos/gohugoio/hugo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gohugoio/hugo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gohugoio/hugo/teams","hooks_url":"https://api.github.com/repos/gohugoio/hugo/hooks","issue_events_url":"https://api.github.com/repos/gohugoio/hugo/issues/events{/number}","events_url":"https://api.github.com/repos/gohugoio/hugo/events","assignees_url":"https://api.github.com/repos/gohugoio/hugo/assignees{/user}","branches_url":"https://api.github.com/repos/gohugoio/hugo/branches{/branch}","tags_url":"https://api.github.com/repos/gohugoio/hugo/tags","blobs_url":"https://api.github.com/repos/gohugoio/hugo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gohugoio/hugo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gohugoio/hugo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gohugoio/hugo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gohugoio/hugo/statuses/{sha}","languages_url":"https://api.github.com/repos/gohugoio/hugo/languages","stargazers_url":"https://api.github.com/repos/gohugoio/hugo/stargazers","contributors_url":"https://api.github.com/repos/gohugoio/hugo/contributors","subscribers_url":"https://api.github.com/repos/gohugoio/hugo/subscribers","subscription_url":"https://api.github.com/repos/gohugoio/hugo/subscription","commits_url":"https://api.github.com/repos/gohugoio/hugo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gohugoio/hugo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gohugoio/hugo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gohugoio/hugo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gohugoio/hugo/contents/{+path}","compare_url":"https://api.github.com/repos/gohugoio/hugo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gohugoio/hugo/merges","archive_url":"https://api.github.com/repos/gohugoio/hugo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gohugoio/hugo/downloads","issues_url":"https://api.github.com/repos/gohugoio/hugo/issues{/number}","pulls_url":"https://api.github.com/repos/gohugoio/hugo/pulls{/number}","milestones_url":"https://api.github.com/repos/gohugoio/hugo/milestones{/number}","notifications_url":"https://api.github.com/repos/gohugoio/hugo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gohugoio/hugo/labels{/name}","releases_url":"https://api.github.com/repos/gohugoio/hugo/releases{/id}","deployments_url":"https://api.github.com/repos/gohugoio/hugo/deployments","created_at":"2013-07-04T15:26:26Z","updated_at":"2018-10-03T06:50:11Z","pushed_at":"2018-10-03T06:55:54Z","git_url":"git://github.com/gohugoio/hugo.git","ssh_url":"git@github.com:gohugoio/hugo.git","clone_url":"https://github.com/gohugoio/hugo.git","svn_url":"https://github.com/gohugoio/hugo","homepage":"https://gohugo.io","size":61278,"stargazers_count":29218,"watchers_count":29218,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3419,"mirror_url":null,"archived":false,"open_issues_count":307,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3419,"open_issues":307,"watchers":29218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/5276"},"html":{"href":"https://github.com/gohugoio/hugo/pull/5276"},"issue":{"href":"https://api.github.com/repos/gohugoio/hugo/issues/5276"},"comments":{"href":"https://api.github.com/repos/gohugoio/hugo/issues/5276/comments"},"review_comments":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/5276/comments"},"review_comment":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/5276/commits"},"statuses":{"href":"https://api.github.com/repos/gohugoio/hugo/statuses/17ab19619aee3297df3394a0283e843c126f1150"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bep","id":394382,"node_id":"MDQ6VXNlcjM5NDM4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/394382?v=4","gravatar_id":"","url":"https://api.github.com/users/bep","html_url":"https://github.com/bep","followers_url":"https://api.github.com/users/bep/followers","following_url":"https://api.github.com/users/bep/following{/other_user}","gists_url":"https://api.github.com/users/bep/gists{/gist_id}","starred_url":"https://api.github.com/users/bep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bep/subscriptions","organizations_url":"https://api.github.com/users/bep/orgs","repos_url":"https://api.github.com/users/bep/repos","events_url":"https://api.github.com/users/bep/events{/privacy}","received_events_url":"https://api.github.com/users/bep/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":75,"deletions":48,"changed_files":5}}
{"actor":{"display_login":"bep"}}