{"action":"created","comment":{"url":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/comments/233347603","pull_request_review_id":174737768,"id":233347603,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzM0NzYwMw==","diff_hunk":"@@ -55,34 +56,40 @@\n     \"conditions\": [\n       {\n         \"name\": \"lockPayment\",\n-        \"timeout\": 0,\n+        \"timeout\": 86400,\n+        \"dependencies\": [],\n+        \"isTerminalCondition\": false,\n+        \"canBeFulfilledBeforeTimeout\": true,\n         \"conditionKey\": {\n           \"contractAddress\": \"0x...\",\n           \"fingerprint\": \"0x...\"\n         },\n         \"parameters\": {","path":"11/ddo.example.json","position":null,"original_position":21,"commit_id":"00ffc5e0decd4f0d2ad6918ef03c9aa6ada4054a","original_commit_id":"5a328492941c7874c1992dfed35dd98b730939be","user":{"login":"aaitor","id":1726644,"node_id":"MDQ6VXNlcjE3MjY2NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1726644?v=4","gravatar_id":"","url":"https://api.github.com/users/aaitor","html_url":"https://github.com/aaitor","followers_url":"https://api.github.com/users/aaitor/followers","following_url":"https://api.github.com/users/aaitor/following{/other_user}","gists_url":"https://api.github.com/users/aaitor/gists{/gist_id}","starred_url":"https://api.github.com/users/aaitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaitor/subscriptions","organizations_url":"https://api.github.com/users/aaitor/orgs","repos_url":"https://api.github.com/users/aaitor/repos","events_url":"https://api.github.com/users/aaitor/events{/privacy}","received_events_url":"https://api.github.com/users/aaitor/received_events","type":"User","site_admin":false},"body":"Related with this comment sent by @ssallam I modified lightly this:\r\n\r\n1. Parameters are an object with name, type and value\r\n1. Parameters are part of an array. It makes easier to preserve the parameters order for a remote function invocation using those parameters\r\n\r\nThe DDO json example is validated and is okay\r\n\r\n@ldmberman , @ssallam , @aabdulwahed , @ldmberman , please confirm this is okay for you to merge and adapt the integration.","created_at":"2018-11-14T08:18:15Z","updated_at":"2018-11-14T08:18:15Z","html_url":"https://github.com/oceanprotocol/OEPs/pull/94#discussion_r233347603","pull_request_url":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/94","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/comments/233347603"},"html":{"href":"https://github.com/oceanprotocol/OEPs/pull/94#discussion_r233347603"},"pull_request":{"href":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/94"}},"in_reply_to_id":233131545},"pull_request":{"url":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/94","id":230547562,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTQ3NTYy","html_url":"https://github.com/oceanprotocol/OEPs/pull/94","diff_url":"https://github.com/oceanprotocol/OEPs/pull/94.diff","patch_url":"https://github.com/oceanprotocol/OEPs/pull/94.patch","issue_url":"https://api.github.com/repos/oceanprotocol/OEPs/issues/94","number":94,"state":"open","locked":false,"title":"Condition dependencies oep 11","user":{"login":"ldmberman","id":4797754,"node_id":"MDQ6VXNlcjQ3OTc3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4797754?v=4","gravatar_id":"","url":"https://api.github.com/users/ldmberman","html_url":"https://github.com/ldmberman","followers_url":"https://api.github.com/users/ldmberman/followers","following_url":"https://api.github.com/users/ldmberman/following{/other_user}","gists_url":"https://api.github.com/users/ldmberman/gists{/gist_id}","starred_url":"https://api.github.com/users/ldmberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldmberman/subscriptions","organizations_url":"https://api.github.com/users/ldmberman/orgs","repos_url":"https://api.github.com/users/ldmberman/repos","events_url":"https://api.github.com/users/ldmberman/events{/privacy}","received_events_url":"https://api.github.com/users/ldmberman/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-13T16:45:36Z","updated_at":"2018-11-14T08:18:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cb6a71eca0e30ce93fcb075edae807cf033c29a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"Maintainers","id":2702044,"node_id":"MDQ6VGVhbTI3MDIwNDQ=","slug":"maintainers","description":"","privacy":"closed","url":"https://api.github.com/teams/2702044","members_url":"https://api.github.com/teams/2702044/members{/member}","repositories_url":"https://api.github.com/teams/2702044/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/94/commits","review_comments_url":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/94/comments","review_comment_url":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oceanprotocol/OEPs/issues/94/comments","statuses_url":"https://api.github.com/repos/oceanprotocol/OEPs/statuses/00ffc5e0decd4f0d2ad6918ef03c9aa6ada4054a","head":{"label":"oceanprotocol:condition-dependencies-oep-11","ref":"condition-dependencies-oep-11","sha":"00ffc5e0decd4f0d2ad6918ef03c9aa6ada4054a","user":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":126798642,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY3OTg2NDI=","name":"OEPs","full_name":"oceanprotocol/OEPs","private":false,"owner":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oceanprotocol/OEPs","description":"🐙 Ocean Protocol Enhancement Proposals","fork":false,"url":"https://api.github.com/repos/oceanprotocol/OEPs","forks_url":"https://api.github.com/repos/oceanprotocol/OEPs/forks","keys_url":"https://api.github.com/repos/oceanprotocol/OEPs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oceanprotocol/OEPs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oceanprotocol/OEPs/teams","hooks_url":"https://api.github.com/repos/oceanprotocol/OEPs/hooks","issue_events_url":"https://api.github.com/repos/oceanprotocol/OEPs/issues/events{/number}","events_url":"https://api.github.com/repos/oceanprotocol/OEPs/events","assignees_url":"https://api.github.com/repos/oceanprotocol/OEPs/assignees{/user}","branches_url":"https://api.github.com/repos/oceanprotocol/OEPs/branches{/branch}","tags_url":"https://api.github.com/repos/oceanprotocol/OEPs/tags","blobs_url":"https://api.github.com/repos/oceanprotocol/OEPs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oceanprotocol/OEPs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oceanprotocol/OEPs/git/refs{/sha}","trees_url":"https://api.github.com/repos/oceanprotocol/OEPs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oceanprotocol/OEPs/statuses/{sha}","languages_url":"https://api.github.com/repos/oceanprotocol/OEPs/languages","stargazers_url":"https://api.github.com/repos/oceanprotocol/OEPs/stargazers","contributors_url":"https://api.github.com/repos/oceanprotocol/OEPs/contributors","subscribers_url":"https://api.github.com/repos/oceanprotocol/OEPs/subscribers","subscription_url":"https://api.github.com/repos/oceanprotocol/OEPs/subscription","commits_url":"https://api.github.com/repos/oceanprotocol/OEPs/commits{/sha}","git_commits_url":"https://api.github.com/repos/oceanprotocol/OEPs/git/commits{/sha}","comments_url":"https://api.github.com/repos/oceanprotocol/OEPs/comments{/number}","issue_comment_url":"https://api.github.com/repos/oceanprotocol/OEPs/issues/comments{/number}","contents_url":"https://api.github.com/repos/oceanprotocol/OEPs/contents/{+path}","compare_url":"https://api.github.com/repos/oceanprotocol/OEPs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oceanprotocol/OEPs/merges","archive_url":"https://api.github.com/repos/oceanprotocol/OEPs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oceanprotocol/OEPs/downloads","issues_url":"https://api.github.com/repos/oceanprotocol/OEPs/issues{/number}","pulls_url":"https://api.github.com/repos/oceanprotocol/OEPs/pulls{/number}","milestones_url":"https://api.github.com/repos/oceanprotocol/OEPs/milestones{/number}","notifications_url":"https://api.github.com/repos/oceanprotocol/OEPs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oceanprotocol/OEPs/labels{/name}","releases_url":"https://api.github.com/repos/oceanprotocol/OEPs/releases{/id}","deployments_url":"https://api.github.com/repos/oceanprotocol/OEPs/deployments","created_at":"2018-03-26T08:36:58Z","updated_at":"2018-11-13T07:50:00Z","pushed_at":"2018-11-14T08:15:33Z","git_url":"git://github.com/oceanprotocol/OEPs.git","ssh_url":"git@github.com:oceanprotocol/OEPs.git","clone_url":"https://github.com/oceanprotocol/OEPs.git","svn_url":"https://github.com/oceanprotocol/OEPs","homepage":"https://oceanprotocol.com","size":12664,"stargazers_count":14,"watchers_count":14,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":33,"license":null,"forks":1,"open_issues":33,"watchers":14,"default_branch":"master"}},"base":{"label":"oceanprotocol:master","ref":"master","sha":"7ed18ea1159792a3fb8e1e2fbc66afb0667ccdcd","user":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":126798642,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY3OTg2NDI=","name":"OEPs","full_name":"oceanprotocol/OEPs","private":false,"owner":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oceanprotocol/OEPs","description":"🐙 Ocean Protocol Enhancement Proposals","fork":false,"url":"https://api.github.com/repos/oceanprotocol/OEPs","forks_url":"https://api.github.com/repos/oceanprotocol/OEPs/forks","keys_url":"https://api.github.com/repos/oceanprotocol/OEPs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oceanprotocol/OEPs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oceanprotocol/OEPs/teams","hooks_url":"https://api.github.com/repos/oceanprotocol/OEPs/hooks","issue_events_url":"https://api.github.com/repos/oceanprotocol/OEPs/issues/events{/number}","events_url":"https://api.github.com/repos/oceanprotocol/OEPs/events","assignees_url":"https://api.github.com/repos/oceanprotocol/OEPs/assignees{/user}","branches_url":"https://api.github.com/repos/oceanprotocol/OEPs/branches{/branch}","tags_url":"https://api.github.com/repos/oceanprotocol/OEPs/tags","blobs_url":"https://api.github.com/repos/oceanprotocol/OEPs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oceanprotocol/OEPs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oceanprotocol/OEPs/git/refs{/sha}","trees_url":"https://api.github.com/repos/oceanprotocol/OEPs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oceanprotocol/OEPs/statuses/{sha}","languages_url":"https://api.github.com/repos/oceanprotocol/OEPs/languages","stargazers_url":"https://api.github.com/repos/oceanprotocol/OEPs/stargazers","contributors_url":"https://api.github.com/repos/oceanprotocol/OEPs/contributors","subscribers_url":"https://api.github.com/repos/oceanprotocol/OEPs/subscribers","subscription_url":"https://api.github.com/repos/oceanprotocol/OEPs/subscription","commits_url":"https://api.github.com/repos/oceanprotocol/OEPs/commits{/sha}","git_commits_url":"https://api.github.com/repos/oceanprotocol/OEPs/git/commits{/sha}","comments_url":"https://api.github.com/repos/oceanprotocol/OEPs/comments{/number}","issue_comment_url":"https://api.github.com/repos/oceanprotocol/OEPs/issues/comments{/number}","contents_url":"https://api.github.com/repos/oceanprotocol/OEPs/contents/{+path}","compare_url":"https://api.github.com/repos/oceanprotocol/OEPs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oceanprotocol/OEPs/merges","archive_url":"https://api.github.com/repos/oceanprotocol/OEPs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oceanprotocol/OEPs/downloads","issues_url":"https://api.github.com/repos/oceanprotocol/OEPs/issues{/number}","pulls_url":"https://api.github.com/repos/oceanprotocol/OEPs/pulls{/number}","milestones_url":"https://api.github.com/repos/oceanprotocol/OEPs/milestones{/number}","notifications_url":"https://api.github.com/repos/oceanprotocol/OEPs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oceanprotocol/OEPs/labels{/name}","releases_url":"https://api.github.com/repos/oceanprotocol/OEPs/releases{/id}","deployments_url":"https://api.github.com/repos/oceanprotocol/OEPs/deployments","created_at":"2018-03-26T08:36:58Z","updated_at":"2018-11-13T07:50:00Z","pushed_at":"2018-11-14T08:15:33Z","git_url":"git://github.com/oceanprotocol/OEPs.git","ssh_url":"git@github.com:oceanprotocol/OEPs.git","clone_url":"https://github.com/oceanprotocol/OEPs.git","svn_url":"https://github.com/oceanprotocol/OEPs","homepage":"https://oceanprotocol.com","size":12664,"stargazers_count":14,"watchers_count":14,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":33,"license":null,"forks":1,"open_issues":33,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/94"},"html":{"href":"https://github.com/oceanprotocol/OEPs/pull/94"},"issue":{"href":"https://api.github.com/repos/oceanprotocol/OEPs/issues/94"},"comments":{"href":"https://api.github.com/repos/oceanprotocol/OEPs/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oceanprotocol/OEPs/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/oceanprotocol/OEPs/statuses/00ffc5e0decd4f0d2ad6918ef03c9aa6ada4054a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aaitor"}}