{"action":"created","comment":{"url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/comments/236246860","pull_request_review_id":178279134,"id":236246860,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjI0Njg2MA==","diff_hunk":"@@ -0,0 +1,65 @@\n+package main\n+\n+import (\n+\t\"k8s.io/client-go/kubernetes\"\n+\t\"k8s.io/client-go/tools/cache\"\n+\t\"k8s.io/client-go/tools/record\"\n+\t\"k8s.io/client-go/util/workqueue\"\n+\t\"k8s.io/klog\"\n+\n+\tclientset \"github.com/nmstate/k8s-node-net-conf/pkg/client/clientset/versioned\"\n+\tinformers \"github.com/nmstate/k8s-node-net-conf/pkg/client/informers/externalversions/nmstate.io/v1\"\n+\tlisters \"github.com/nmstate/k8s-node-net-conf/pkg/client/listers/nmstate.io/v1\"\n+)\n+\n+// Controller is the controller implementation for NodeNetConfPolicy resources\n+type Controller struct {\n+\t// kubeclientset is a standard kubernetes clientset\n+\tkubeclientset kubernetes.Interface\n+\t// nmstateclientset is a clientset for our own API group\n+\tnmstateclientset clientset.Interface\n+\n+\tpolicyLister listers.NodeNetConfPolicyLister\n+\tpolicySynced cache.InformerSynced\n+\n+\t// workqueue is a rate limited work queue. This is used to queue work to be\n+\t// processed instead of performing it as soon as a change happens. This\n+\t// means we can ensure we only process a fixed amount of resources at a\n+\t// time, and makes it easy to ensure we are never processing the same item\n+\t// simultaneously in two different workers.\n+\tworkqueue workqueue.RateLimitingInterface\n+\t// recorder is an event recorder for recording Event resources to the\n+\t// Kubernetes API.\n+\trecorder record.EventRecorder\n+}\n+\n+// NewController returns a new state controller\n+func NewController(\n+\tkubeclientset kubernetes.Interface,\n+\tnmstateclientset clientset.Interface,\n+\tpolicyInformer informers.NodeNetConfPolicyInformer) *Controller {\n+\treturn nil","path":"cmd/policy-controller/controller.go","position":41,"original_position":41,"commit_id":"04207d2e02c5ec549f8a3e49696dbea6449dff4b","original_commit_id":"04207d2e02c5ec549f8a3e49696dbea6449dff4b","user":{"login":"yuvalif","id":1798418,"node_id":"MDQ6VXNlcjE3OTg0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1798418?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalif","html_url":"https://github.com/yuvalif","followers_url":"https://api.github.com/users/yuvalif/followers","following_url":"https://api.github.com/users/yuvalif/following{/other_user}","gists_url":"https://api.github.com/users/yuvalif/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalif/subscriptions","organizations_url":"https://api.github.com/users/yuvalif/orgs","repos_url":"https://api.github.com/users/yuvalif/repos","events_url":"https://api.github.com/users/yuvalif/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalif/received_events","type":"User","site_admin":false},"body":"this is not implemented yet. only state controller implemented","created_at":"2018-11-26T13:09:36Z","updated_at":"2018-11-26T13:09:37Z","html_url":"https://github.com/yuvalif/kubernetes-nmstate/pull/1#discussion_r236246860","pull_request_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/comments/236246860"},"html":{"href":"https://github.com/yuvalif/kubernetes-nmstate/pull/1#discussion_r236246860"},"pull_request":{"href":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/1"}},"in_reply_to_id":236187237},"pull_request":{"url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/1","id":233481890,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDgxODkw","html_url":"https://github.com/yuvalif/kubernetes-nmstate/pull/1","diff_url":"https://github.com/yuvalif/kubernetes-nmstate/pull/1.diff","patch_url":"https://github.com/yuvalif/kubernetes-nmstate/pull/1.patch","issue_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/issues/1","number":1,"state":"open","locked":false,"title":"this is a fake PR just for the sake of initial code review","user":{"login":"yuvalif","id":1798418,"node_id":"MDQ6VXNlcjE3OTg0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1798418?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalif","html_url":"https://github.com/yuvalif","followers_url":"https://api.github.com/users/yuvalif/followers","following_url":"https://api.github.com/users/yuvalif/following{/other_user}","gists_url":"https://api.github.com/users/yuvalif/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalif/subscriptions","organizations_url":"https://api.github.com/users/yuvalif/orgs","repos_url":"https://api.github.com/users/yuvalif/repos","events_url":"https://api.github.com/users/yuvalif/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalif/received_events","type":"User","site_admin":false},"body":"please consider that the opened issues try to cover some of the problems with the code\r\nplease look into documentation added here: https://github.com/nmstate/kubernetes-nmstate/pull/15\r\nfor info on how the product SHOULD behave","created_at":"2018-11-26T09:05:15Z","updated_at":"2018-11-26T13:09:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6d112e82838779f562dc00fd8a33f0e374d3dda","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/1/commits","review_comments_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/1/comments","review_comment_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/issues/1/comments","statuses_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/statuses/04207d2e02c5ec549f8a3e49696dbea6449dff4b","head":{"label":"yuvalif:master","ref":"master","sha":"04207d2e02c5ec549f8a3e49696dbea6449dff4b","user":{"login":"yuvalif","id":1798418,"node_id":"MDQ6VXNlcjE3OTg0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1798418?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalif","html_url":"https://github.com/yuvalif","followers_url":"https://api.github.com/users/yuvalif/followers","following_url":"https://api.github.com/users/yuvalif/following{/other_user}","gists_url":"https://api.github.com/users/yuvalif/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalif/subscriptions","organizations_url":"https://api.github.com/users/yuvalif/orgs","repos_url":"https://api.github.com/users/yuvalif/repos","events_url":"https://api.github.com/users/yuvalif/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalif/received_events","type":"User","site_admin":false},"repo":{"id":158676368,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg2NzYzNjg=","name":"kubernetes-nmstate","full_name":"yuvalif/kubernetes-nmstate","private":false,"owner":{"login":"yuvalif","id":1798418,"node_id":"MDQ6VXNlcjE3OTg0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1798418?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalif","html_url":"https://github.com/yuvalif","followers_url":"https://api.github.com/users/yuvalif/followers","following_url":"https://api.github.com/users/yuvalif/following{/other_user}","gists_url":"https://api.github.com/users/yuvalif/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalif/subscriptions","organizations_url":"https://api.github.com/users/yuvalif/orgs","repos_url":"https://api.github.com/users/yuvalif/repos","events_url":"https://api.github.com/users/yuvalif/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalif/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yuvalif/kubernetes-nmstate","description":"system to configure host networking on Kubernetes using nmstate","fork":true,"url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate","forks_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/forks","keys_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/teams","hooks_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/hooks","issue_events_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/issues/events{/number}","events_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/events","assignees_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/assignees{/user}","branches_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/branches{/branch}","tags_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/tags","blobs_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/statuses/{sha}","languages_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/languages","stargazers_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/stargazers","contributors_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/contributors","subscribers_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/subscribers","subscription_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/subscription","commits_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/contents/{+path}","compare_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/merges","archive_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/downloads","issues_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/issues{/number}","pulls_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls{/number}","milestones_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/milestones{/number}","notifications_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/labels{/name}","releases_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/releases{/id}","deployments_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/deployments","created_at":"2018-11-22T09:44:21Z","updated_at":"2018-11-22T09:44:24Z","pushed_at":"2018-11-26T09:05:16Z","git_url":"git://github.com/yuvalif/kubernetes-nmstate.git","ssh_url":"git@github.com:yuvalif/kubernetes-nmstate.git","clone_url":"https://github.com/yuvalif/kubernetes-nmstate.git","svn_url":"https://github.com/yuvalif/kubernetes-nmstate","homepage":null,"size":28314,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"yuvalif:empty","ref":"empty","sha":"940b10ae10f7257de8a213f7146ab9f3b2da5b02","user":{"login":"yuvalif","id":1798418,"node_id":"MDQ6VXNlcjE3OTg0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1798418?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalif","html_url":"https://github.com/yuvalif","followers_url":"https://api.github.com/users/yuvalif/followers","following_url":"https://api.github.com/users/yuvalif/following{/other_user}","gists_url":"https://api.github.com/users/yuvalif/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalif/subscriptions","organizations_url":"https://api.github.com/users/yuvalif/orgs","repos_url":"https://api.github.com/users/yuvalif/repos","events_url":"https://api.github.com/users/yuvalif/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalif/received_events","type":"User","site_admin":false},"repo":{"id":158676368,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg2NzYzNjg=","name":"kubernetes-nmstate","full_name":"yuvalif/kubernetes-nmstate","private":false,"owner":{"login":"yuvalif","id":1798418,"node_id":"MDQ6VXNlcjE3OTg0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1798418?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalif","html_url":"https://github.com/yuvalif","followers_url":"https://api.github.com/users/yuvalif/followers","following_url":"https://api.github.com/users/yuvalif/following{/other_user}","gists_url":"https://api.github.com/users/yuvalif/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalif/subscriptions","organizations_url":"https://api.github.com/users/yuvalif/orgs","repos_url":"https://api.github.com/users/yuvalif/repos","events_url":"https://api.github.com/users/yuvalif/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalif/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yuvalif/kubernetes-nmstate","description":"system to configure host networking on Kubernetes using nmstate","fork":true,"url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate","forks_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/forks","keys_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/teams","hooks_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/hooks","issue_events_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/issues/events{/number}","events_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/events","assignees_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/assignees{/user}","branches_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/branches{/branch}","tags_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/tags","blobs_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/statuses/{sha}","languages_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/languages","stargazers_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/stargazers","contributors_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/contributors","subscribers_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/subscribers","subscription_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/subscription","commits_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/contents/{+path}","compare_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/merges","archive_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/downloads","issues_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/issues{/number}","pulls_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls{/number}","milestones_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/milestones{/number}","notifications_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/labels{/name}","releases_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/releases{/id}","deployments_url":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/deployments","created_at":"2018-11-22T09:44:21Z","updated_at":"2018-11-22T09:44:24Z","pushed_at":"2018-11-26T09:05:16Z","git_url":"git://github.com/yuvalif/kubernetes-nmstate.git","ssh_url":"git@github.com:yuvalif/kubernetes-nmstate.git","clone_url":"https://github.com/yuvalif/kubernetes-nmstate.git","svn_url":"https://github.com/yuvalif/kubernetes-nmstate","homepage":null,"size":28314,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/1"},"html":{"href":"https://github.com/yuvalif/kubernetes-nmstate/pull/1"},"issue":{"href":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/issues/1"},"comments":{"href":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/yuvalif/kubernetes-nmstate/statuses/04207d2e02c5ec549f8a3e49696dbea6449dff4b"}},"author_association":"OWNER"}}
{"actor":{"display_login":"yuvalif"}}