{"action":"created","comment":{"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/171200581","pull_request_review_id":100010149,"id":171200581,"diff_hunk":"@@ -33,6 +47,8 @@ def before_successful_response\n       end\n \n       def validate_attributes\n+        return false if grant && grant.uses_pkce? && code_verifier.blank?","path":"lib/doorkeeper/oauth/authorization_code_request.rb","position":38,"original_position":38,"commit_id":"6a695d79b5ce9143043ff60f51ace3ac4ec71f9e","original_commit_id":"6a695d79b5ce9143043ff60f51ace3ac4ec71f9e","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Use safe navigation (&.) instead of checking if an object exists before calling the method.","created_at":"2018-02-28T10:28:36Z","updated_at":"2018-02-28T10:28:36Z","html_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/1037#discussion_r171200581","pull_request_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1037","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/171200581"},"html":{"href":"https://github.com/doorkeeper-gem/doorkeeper/pull/1037#discussion_r171200581"},"pull_request":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1037"}}},"pull_request":{"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1037","id":169789535,"html_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/1037","diff_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/1037.diff","patch_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/1037.patch","issue_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/1037","number":1037,"state":"open","locked":false,"title":"PKCE","user":{"login":"bpieck","id":1452390,"avatar_url":"https://avatars2.githubusercontent.com/u/1452390?v=4","gravatar_id":"","url":"https://api.github.com/users/bpieck","html_url":"https://github.com/bpieck","followers_url":"https://api.github.com/users/bpieck/followers","following_url":"https://api.github.com/users/bpieck/following{/other_user}","gists_url":"https://api.github.com/users/bpieck/gists{/gist_id}","starred_url":"https://api.github.com/users/bpieck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpieck/subscriptions","organizations_url":"https://api.github.com/users/bpieck/orgs","repos_url":"https://api.github.com/users/bpieck/repos","events_url":"https://api.github.com/users/bpieck/events{/privacy}","received_events_url":"https://api.github.com/users/bpieck/received_events","type":"User","site_admin":false},"body":"I tried to do, as Nikita asked to do, but refactored a little. Hope it is now as expected - else: Please tell me, what to change.\r\n\r\n### Summary\r\n\r\n- merged work of Ross Sharrott into one commit\r\n- fixed issue about code_challenge in redirect_uri\r\n- ensured, doorkeeper is still working, although PCKE migrations are not generated and migrated\r\n- addition to NEWS.md\r\n- addition to README.md","created_at":"2018-02-17T16:11:49Z","updated_at":"2018-02-28T10:28:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f24f6b4759195d1f2e6f1249bbd10804619046bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1037/commits","review_comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1037/comments","review_comment_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/1037/comments","statuses_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/6a695d79b5ce9143043ff60f51ace3ac4ec71f9e","head":{"label":"x-ion-de:pkce","ref":"pkce","sha":"6a695d79b5ce9143043ff60f51ace3ac4ec71f9e","user":{"login":"x-ion-de","id":8902743,"avatar_url":"https://avatars1.githubusercontent.com/u/8902743?v=4","gravatar_id":"","url":"https://api.github.com/users/x-ion-de","html_url":"https://github.com/x-ion-de","followers_url":"https://api.github.com/users/x-ion-de/followers","following_url":"https://api.github.com/users/x-ion-de/following{/other_user}","gists_url":"https://api.github.com/users/x-ion-de/gists{/gist_id}","starred_url":"https://api.github.com/users/x-ion-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x-ion-de/subscriptions","organizations_url":"https://api.github.com/users/x-ion-de/orgs","repos_url":"https://api.github.com/users/x-ion-de/repos","events_url":"https://api.github.com/users/x-ion-de/events{/privacy}","received_events_url":"https://api.github.com/users/x-ion-de/received_events","type":"Organization","site_admin":false},"repo":{"id":121766083,"name":"doorkeeper","full_name":"x-ion-de/doorkeeper","owner":{"login":"x-ion-de","id":8902743,"avatar_url":"https://avatars1.githubusercontent.com/u/8902743?v=4","gravatar_id":"","url":"https://api.github.com/users/x-ion-de","html_url":"https://github.com/x-ion-de","followers_url":"https://api.github.com/users/x-ion-de/followers","following_url":"https://api.github.com/users/x-ion-de/following{/other_user}","gists_url":"https://api.github.com/users/x-ion-de/gists{/gist_id}","starred_url":"https://api.github.com/users/x-ion-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x-ion-de/subscriptions","organizations_url":"https://api.github.com/users/x-ion-de/orgs","repos_url":"https://api.github.com/users/x-ion-de/repos","events_url":"https://api.github.com/users/x-ion-de/events{/privacy}","received_events_url":"https://api.github.com/users/x-ion-de/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/x-ion-de/doorkeeper","description":"Doorkeeper is an OAuth 2 provider for Rails.","fork":true,"url":"https://api.github.com/repos/x-ion-de/doorkeeper","forks_url":"https://api.github.com/repos/x-ion-de/doorkeeper/forks","keys_url":"https://api.github.com/repos/x-ion-de/doorkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/x-ion-de/doorkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/x-ion-de/doorkeeper/teams","hooks_url":"https://api.github.com/repos/x-ion-de/doorkeeper/hooks","issue_events_url":"https://api.github.com/repos/x-ion-de/doorkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/x-ion-de/doorkeeper/events","assignees_url":"https://api.github.com/repos/x-ion-de/doorkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/x-ion-de/doorkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/x-ion-de/doorkeeper/tags","blobs_url":"https://api.github.com/repos/x-ion-de/doorkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/x-ion-de/doorkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/x-ion-de/doorkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/x-ion-de/doorkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/x-ion-de/doorkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/x-ion-de/doorkeeper/languages","stargazers_url":"https://api.github.com/repos/x-ion-de/doorkeeper/stargazers","contributors_url":"https://api.github.com/repos/x-ion-de/doorkeeper/contributors","subscribers_url":"https://api.github.com/repos/x-ion-de/doorkeeper/subscribers","subscription_url":"https://api.github.com/repos/x-ion-de/doorkeeper/subscription","commits_url":"https://api.github.com/repos/x-ion-de/doorkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/x-ion-de/doorkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/x-ion-de/doorkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/x-ion-de/doorkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/x-ion-de/doorkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/x-ion-de/doorkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/x-ion-de/doorkeeper/merges","archive_url":"https://api.github.com/repos/x-ion-de/doorkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/x-ion-de/doorkeeper/downloads","issues_url":"https://api.github.com/repos/x-ion-de/doorkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/x-ion-de/doorkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/x-ion-de/doorkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/x-ion-de/doorkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/x-ion-de/doorkeeper/labels{/name}","releases_url":"https://api.github.com/repos/x-ion-de/doorkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/x-ion-de/doorkeeper/deployments","created_at":"2018-02-16T15:26:14Z","updated_at":"2018-02-16T15:26:16Z","pushed_at":"2018-02-28T10:28:17Z","git_url":"git://github.com/x-ion-de/doorkeeper.git","ssh_url":"git@github.com:x-ion-de/doorkeeper.git","clone_url":"https://github.com/x-ion-de/doorkeeper.git","svn_url":"https://github.com/x-ion-de/doorkeeper","homepage":"","size":2186,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doorkeeper-gem:master","ref":"master","sha":"0be34a2cca08ce757295cbffef788b564a8bafc4","user":{"login":"doorkeeper-gem","id":7275750,"avatar_url":"https://avatars1.githubusercontent.com/u/7275750?v=4","gravatar_id":"","url":"https://api.github.com/users/doorkeeper-gem","html_url":"https://github.com/doorkeeper-gem","followers_url":"https://api.github.com/users/doorkeeper-gem/followers","following_url":"https://api.github.com/users/doorkeeper-gem/following{/other_user}","gists_url":"https://api.github.com/users/doorkeeper-gem/gists{/gist_id}","starred_url":"https://api.github.com/users/doorkeeper-gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doorkeeper-gem/subscriptions","organizations_url":"https://api.github.com/users/doorkeeper-gem/orgs","repos_url":"https://api.github.com/users/doorkeeper-gem/repos","events_url":"https://api.github.com/users/doorkeeper-gem/events{/privacy}","received_events_url":"https://api.github.com/users/doorkeeper-gem/received_events","type":"Organization","site_admin":false},"repo":{"id":2802565,"name":"doorkeeper","full_name":"doorkeeper-gem/doorkeeper","owner":{"login":"doorkeeper-gem","id":7275750,"avatar_url":"https://avatars1.githubusercontent.com/u/7275750?v=4","gravatar_id":"","url":"https://api.github.com/users/doorkeeper-gem","html_url":"https://github.com/doorkeeper-gem","followers_url":"https://api.github.com/users/doorkeeper-gem/followers","following_url":"https://api.github.com/users/doorkeeper-gem/following{/other_user}","gists_url":"https://api.github.com/users/doorkeeper-gem/gists{/gist_id}","starred_url":"https://api.github.com/users/doorkeeper-gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doorkeeper-gem/subscriptions","organizations_url":"https://api.github.com/users/doorkeeper-gem/orgs","repos_url":"https://api.github.com/users/doorkeeper-gem/repos","events_url":"https://api.github.com/users/doorkeeper-gem/events{/privacy}","received_events_url":"https://api.github.com/users/doorkeeper-gem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doorkeeper-gem/doorkeeper","description":"Doorkeeper is an OAuth 2 provider for Rails.","fork":false,"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper","forks_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/forks","keys_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/teams","hooks_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/hooks","issue_events_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/events","assignees_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/tags","blobs_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/languages","stargazers_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/stargazers","contributors_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/contributors","subscribers_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/subscribers","subscription_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/subscription","commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/merges","archive_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/downloads","issues_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/labels{/name}","releases_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/deployments","created_at":"2011-11-18T13:02:01Z","updated_at":"2018-02-28T07:23:10Z","pushed_at":"2018-02-28T10:28:20Z","git_url":"git://github.com/doorkeeper-gem/doorkeeper.git","ssh_url":"git@github.com:doorkeeper-gem/doorkeeper.git","clone_url":"https://github.com/doorkeeper-gem/doorkeeper.git","svn_url":"https://github.com/doorkeeper-gem/doorkeeper","homepage":"","size":2199,"stargazers_count":3779,"watchers_count":3779,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":761,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":761,"open_issues":36,"watchers":3779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1037"},"html":{"href":"https://github.com/doorkeeper-gem/doorkeeper/pull/1037"},"issue":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/1037"},"comments":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/1037/comments"},"review_comments":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1037/comments"},"review_comment":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1037/commits"},"statuses":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/6a695d79b5ce9143043ff60f51ace3ac4ec71f9e"}},"author_association":"NONE"}}
{"actor":{"display_login":"houndci-bot"}}