{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/194950570","pull_request_review_id":128220604,"id":194950570,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDk1MDU3MA==","diff_hunk":"@@ -90,15 +86,11 @@ class WorkerPool {\n   uint32_t Size() const;\n \n  protected:\n-  /// Add started worker PID to the internal list of started workers (for testing).\n-  ///\n-  /// \\param pid A process identifier for the worker being started.\n-  void AddStartedWorker(pid_t pid);\n-\n-  /// Return a number of workers currently starting but not registered.\n-  ///\n-  /// \\return The number of worker PIDs stored for started workers.\n-  int NumWorkersStarting() const;","path":"src/ray/raylet/worker_pool.h","position":59,"original_position":59,"commit_id":"9f3866cada25145c7a93a0f37027794b19c181e7","original_commit_id":"9f3866cada25145c7a93a0f37027794b19c181e7","user":{"login":"raulchen","id":2883335,"node_id":"MDQ6VXNlcjI4ODMzMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/2883335?v=4","gravatar_id":"","url":"https://api.github.com/users/raulchen","html_url":"https://github.com/raulchen","followers_url":"https://api.github.com/users/raulchen/followers","following_url":"https://api.github.com/users/raulchen/following{/other_user}","gists_url":"https://api.github.com/users/raulchen/gists{/gist_id}","starred_url":"https://api.github.com/users/raulchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raulchen/subscriptions","organizations_url":"https://api.github.com/users/raulchen/orgs","repos_url":"https://api.github.com/users/raulchen/repos","events_url":"https://api.github.com/users/raulchen/events{/privacy}","received_events_url":"https://api.github.com/users/raulchen/received_events","type":"User","site_admin":false},"body":"The reason why the Mock class needs `NumWorkerProcessesStarting` is because the tests need to access it.\r\nI'm going to replace `NumWorkerProcessesStarting()` with `starting_worker_processes_.size()` in `WorkerPoolMock.StartWorkerProcess`, and keep `WorkerPoolMock.NumWorkerProcessesStarting` for the tests.","created_at":"2018-06-13T04:00:31Z","updated_at":"2018-06-13T04:00:31Z","html_url":"https://github.com/ray-project/ray/pull/2244#discussion_r194950570","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/2244","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/194950570"},"html":{"href":"https://github.com/ray-project/ray/pull/2244#discussion_r194950570"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2244"}},"in_reply_to_id":194902431},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/2244","id":194263302,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MjYzMzAy","html_url":"https://github.com/ray-project/ray/pull/2244","diff_url":"https://github.com/ray-project/ray/pull/2244.diff","patch_url":"https://github.com/ray-project/ray/pull/2244.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/2244","number":2244,"state":"open","locked":false,"title":"[xray] support multi-workers per process","user":{"login":"raulchen","id":2883335,"node_id":"MDQ6VXNlcjI4ODMzMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/2883335?v=4","gravatar_id":"","url":"https://api.github.com/users/raulchen","html_url":"https://github.com/raulchen","followers_url":"https://api.github.com/users/raulchen/followers","following_url":"https://api.github.com/users/raulchen/following{/other_user}","gists_url":"https://api.github.com/users/raulchen/gists{/gist_id}","starred_url":"https://api.github.com/users/raulchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raulchen/subscriptions","organizations_url":"https://api.github.com/users/raulchen/orgs","repos_url":"https://api.github.com/users/raulchen/repos","events_url":"https://api.github.com/users/raulchen/events{/privacy}","received_events_url":"https://api.github.com/users/raulchen/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your contribution!\r\n\r\nPlease review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request.\r\n-->\r\n\r\n## What do these changes do?\r\n\r\nThis is the first RP to enable multi-workers per thread. This RP only include the changes on raylet backend side. Subsequent RPs will include the changes on Java worker (it depends on Java worker's integration with Raylet), and potentially Python worker (if needed).\r\n\r\nImplementation details:\r\n1. To minimize code changes and simplify implementation, right now, we only support FIXED number of workers per process. \r\n2. The worker process can implement concurrent workers using multi-threads or any other approaches. This is transparent to the node manager.\r\n3. Each worker has its own connection to the node manager. Node manager looks up a worker by the connection, not by pid.\r\n\r\n## Related issue number\r\n#2215 \r\n<!-- Are there any issues opened that will be resolved by merging this change? -->\r\n","created_at":"2018-06-12T12:29:02Z","updated_at":"2018-06-13T04:00:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08fb3915243efba35ff522f1e6aac73acc211e2b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/2244/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/2244/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/2244/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/9f3866cada25145c7a93a0f37027794b19c181e7","head":{"label":"ant-tech-alliance:multi-thread-worker","ref":"multi-thread-worker","sha":"9f3866cada25145c7a93a0f37027794b19c181e7","user":{"login":"ant-tech-alliance","id":29560905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTYwOTA1","avatar_url":"https://avatars3.githubusercontent.com/u/29560905?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-tech-alliance","html_url":"https://github.com/ant-tech-alliance","followers_url":"https://api.github.com/users/ant-tech-alliance/followers","following_url":"https://api.github.com/users/ant-tech-alliance/following{/other_user}","gists_url":"https://api.github.com/users/ant-tech-alliance/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-tech-alliance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-tech-alliance/subscriptions","organizations_url":"https://api.github.com/users/ant-tech-alliance/orgs","repos_url":"https://api.github.com/users/ant-tech-alliance/repos","events_url":"https://api.github.com/users/ant-tech-alliance/events{/privacy}","received_events_url":"https://api.github.com/users/ant-tech-alliance/received_events","type":"Organization","site_admin":false},"repo":{"id":125461261,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU0NjEyNjE=","name":"ray","full_name":"ant-tech-alliance/ray","owner":{"login":"ant-tech-alliance","id":29560905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTYwOTA1","avatar_url":"https://avatars3.githubusercontent.com/u/29560905?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-tech-alliance","html_url":"https://github.com/ant-tech-alliance","followers_url":"https://api.github.com/users/ant-tech-alliance/followers","following_url":"https://api.github.com/users/ant-tech-alliance/following{/other_user}","gists_url":"https://api.github.com/users/ant-tech-alliance/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-tech-alliance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-tech-alliance/subscriptions","organizations_url":"https://api.github.com/users/ant-tech-alliance/orgs","repos_url":"https://api.github.com/users/ant-tech-alliance/repos","events_url":"https://api.github.com/users/ant-tech-alliance/events{/privacy}","received_events_url":"https://api.github.com/users/ant-tech-alliance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ant-tech-alliance/ray","description":"A high-performance distributed execution engine","fork":true,"url":"https://api.github.com/repos/ant-tech-alliance/ray","forks_url":"https://api.github.com/repos/ant-tech-alliance/ray/forks","keys_url":"https://api.github.com/repos/ant-tech-alliance/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ant-tech-alliance/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ant-tech-alliance/ray/teams","hooks_url":"https://api.github.com/repos/ant-tech-alliance/ray/hooks","issue_events_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ant-tech-alliance/ray/events","assignees_url":"https://api.github.com/repos/ant-tech-alliance/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ant-tech-alliance/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ant-tech-alliance/ray/tags","blobs_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ant-tech-alliance/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ant-tech-alliance/ray/languages","stargazers_url":"https://api.github.com/repos/ant-tech-alliance/ray/stargazers","contributors_url":"https://api.github.com/repos/ant-tech-alliance/ray/contributors","subscribers_url":"https://api.github.com/repos/ant-tech-alliance/ray/subscribers","subscription_url":"https://api.github.com/repos/ant-tech-alliance/ray/subscription","commits_url":"https://api.github.com/repos/ant-tech-alliance/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ant-tech-alliance/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ant-tech-alliance/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ant-tech-alliance/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ant-tech-alliance/ray/merges","archive_url":"https://api.github.com/repos/ant-tech-alliance/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ant-tech-alliance/ray/downloads","issues_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ant-tech-alliance/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ant-tech-alliance/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ant-tech-alliance/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ant-tech-alliance/ray/labels{/name}","releases_url":"https://api.github.com/repos/ant-tech-alliance/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ant-tech-alliance/ray/deployments","created_at":"2018-03-16T03:58:55Z","updated_at":"2018-06-12T09:03:57Z","pushed_at":"2018-06-12T13:57:41Z","git_url":"git://github.com/ant-tech-alliance/ray.git","ssh_url":"git@github.com:ant-tech-alliance/ray.git","clone_url":"https://github.com/ant-tech-alliance/ray.git","svn_url":"https://github.com/ant-tech-alliance/ray","homepage":"","size":12528,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":4,"watchers":7,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"7fcaad264a32f7be6e70ab636d68c9f5ee78c09b","user":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzMjM0OQ==","name":"ray","full_name":"ray-project/ray","owner":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray","description":"A high-performance distributed execution engine","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2018-06-13T03:22:21Z","pushed_at":"2018-06-13T03:49:54Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"","size":12114,"stargazers_count":3438,"watchers_count":3438,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":463,"mirror_url":null,"archived":false,"open_issues_count":333,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":463,"open_issues":333,"watchers":3438,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2244"},"html":{"href":"https://github.com/ray-project/ray/pull/2244"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/2244"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/2244/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2244/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2244/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/9f3866cada25145c7a93a0f37027794b19c181e7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"raulchen"}}