{"action":"created","issue":{"url":"https://api.github.com/repos/haskell/hackage-server/issues/731","repository_url":"https://api.github.com/repos/haskell/hackage-server","labels_url":"https://api.github.com/repos/haskell/hackage-server/issues/731/labels{/name}","comments_url":"https://api.github.com/repos/haskell/hackage-server/issues/731/comments","events_url":"https://api.github.com/repos/haskell/hackage-server/issues/731/events","html_url":"https://github.com/haskell/hackage-server/pull/731","id":308275744,"number":731,"title":"Tune styling details","user":{"login":"NunoAlexandre","id":7075260,"avatar_url":"https://avatars1.githubusercontent.com/u/7075260?v=4","gravatar_id":"","url":"https://api.github.com/users/NunoAlexandre","html_url":"https://github.com/NunoAlexandre","followers_url":"https://api.github.com/users/NunoAlexandre/followers","following_url":"https://api.github.com/users/NunoAlexandre/following{/other_user}","gists_url":"https://api.github.com/users/NunoAlexandre/gists{/gist_id}","starred_url":"https://api.github.com/users/NunoAlexandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NunoAlexandre/subscriptions","organizations_url":"https://api.github.com/users/NunoAlexandre/orgs","repos_url":"https://api.github.com/users/NunoAlexandre/repos","events_url":"https://api.github.com/users/NunoAlexandre/events{/privacy}","received_events_url":"https://api.github.com/users/NunoAlexandre/received_events","type":"User","site_admin":false},"labels":[{"id":818778733,"url":"https://api.github.com/repos/haskell/hackage-server/labels/component:%20ux","name":"component: ux","color":"d4c5f9","default":false},{"id":52837187,"url":"https://api.github.com/repos/haskell/hackage-server/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"NunoAlexandre","id":7075260,"avatar_url":"https://avatars1.githubusercontent.com/u/7075260?v=4","gravatar_id":"","url":"https://api.github.com/users/NunoAlexandre","html_url":"https://github.com/NunoAlexandre","followers_url":"https://api.github.com/users/NunoAlexandre/followers","following_url":"https://api.github.com/users/NunoAlexandre/following{/other_user}","gists_url":"https://api.github.com/users/NunoAlexandre/gists{/gist_id}","starred_url":"https://api.github.com/users/NunoAlexandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NunoAlexandre/subscriptions","organizations_url":"https://api.github.com/users/NunoAlexandre/orgs","repos_url":"https://api.github.com/users/NunoAlexandre/repos","events_url":"https://api.github.com/users/NunoAlexandre/events{/privacy}","received_events_url":"https://api.github.com/users/NunoAlexandre/received_events","type":"User","site_admin":false},"assignees":[{"login":"NunoAlexandre","id":7075260,"avatar_url":"https://avatars1.githubusercontent.com/u/7075260?v=4","gravatar_id":"","url":"https://api.github.com/users/NunoAlexandre","html_url":"https://github.com/NunoAlexandre","followers_url":"https://api.github.com/users/NunoAlexandre/followers","following_url":"https://api.github.com/users/NunoAlexandre/following{/other_user}","gists_url":"https://api.github.com/users/NunoAlexandre/gists{/gist_id}","starred_url":"https://api.github.com/users/NunoAlexandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NunoAlexandre/subscriptions","organizations_url":"https://api.github.com/users/NunoAlexandre/orgs","repos_url":"https://api.github.com/users/NunoAlexandre/repos","events_url":"https://api.github.com/users/NunoAlexandre/events{/privacy}","received_events_url":"https://api.github.com/users/NunoAlexandre/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2018-03-24T16:11:02Z","updated_at":"2018-03-29T20:43:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/haskell/hackage-server/pulls/731","html_url":"https://github.com/haskell/hackage-server/pull/731","diff_url":"https://github.com/haskell/hackage-server/pull/731.diff","patch_url":"https://github.com/haskell/hackage-server/pull/731.patch"},"body":"Fixes https://github.com/haskell/hackage-server/issues/707\r\nFixes https://github.com/haskell/hackage-server/issues/715\r\n\r\n## Preview\r\n\r\nThese pages are static html hosted on my blog. If you notice some difference in their html structure compared to what is now live on hackage please let me know.\r\n\r\n- [Hackage homepage](https://nunoalexandre.com/pets/hackage/home.html)\r\n- [Browse page](https://nunoalexandre.com/pets/hackage/browse.html)\r\n- [Monoid Extras package](https://nunoalexandre.com/pets/hackage/monoid-extras.html)\r\n\r\n\r\n## Changelog\r\n\r\n1. **Move header .caption above the ul.links (revert of https://github.com/haskell/hackage-server/commit/7c94de40910def6bf36cb287c0d6721c0c84c7b4)**\r\n@hvr, I have also cleaned up if-else code around the page title since it seems unnecessary after your these changes of yours: https://github.com/haskell/hackage-server/commit/1cf05f432d9643b62a473e884e1838dee6a1b5d9. Also, since we now will always have `Hackage :: [Package]` on the left as a link to Hackage's homepage, I removed the \"home\" link from the right. \r\n\r\n2.  **Tune spacing, typography, and style**\r\n    - Move from Open Sans to PT Sans to improve thickness complaints\r\n    - Adjust several elements' font-size to look good with new font\r\n    - Refactor and improve page-header elements positioning\r\n    - Fix @media queries overlap issue\r\n    - Increase body font size as it was too small\r\n    - Reduce #content width for screens larger than 1280px\r\n    - Add new @media query for screens larger than 1920px\r\n    - Improve headings and overall spacing between elements\r\n    - Enrich fallback fonts stack\r\n    - Style search input element\r\n\r\n3. **Add a new favicon to match the new theme** (https://github.com/haskell/hackage-server/issues/707)\r\n<div style=\"margin: 0 auto;\"><img width=\"75\" height=\"75\" src=\"https://user-images.githubusercontent.com/7075260/37822537-0a602ddc-2e87-11e8-9f16-344b4ec44009.png\"/></div>\r\n\r\n4. **Make the menu a single and scrollable row (on small screens)**\r\nInstead of breaking the menu links into different lines or forcing the whole header - and therefore page - \r\nto grow with the overflow of links, the menu is now a single and scrollable row, a la 9gag mobile. \r\n\r\n5. **Refactor and restyle properties table**\r\n    - Improve way of claiming space, which fixes a reported issue when zooming.\r\n    - Opt for a vertical table style to make efficient use of space\r\n    - Improve mobile experience\r\n\r\n## TODO\r\n\r\n- [x] Fix two-column layout issues\r\n\r\nThere is already [a PR addressing this here](https://github.com/haskell/hackage-server/pull/719) but, although I don't want to redo or discard someone else's work, maybe it could be solved here together with the rest of the tuning being made.\r\n\r\n@gbaz I wonder if we shouldn't, instead, reconsider the 2-col layout. I get where it comes from but it seems it creates more problems than it solves. What do you think?\r\n\r\n- [x] Adopt an approach similar to 9gag to deal with the menu links on small screens\r\n\r\nInstead of break the links into new lines, we could do something like 9gag does on mobile, by having the list of links in a single line and scrollable (without scrollbar). \r\n**Edit:** I have implemented it already. Please have a look and see how you like it. \r\n\r\n- [ ] Reconsider use of webfonts\r\n\r\n- [x] Add fallback fonts for Windows and Linux users\r\n\r\n- [x]  ~~Consider adjusting the properties column table (see https://github.com/haskell/hackage-server/pull/731#issuecomment-376417011)~~\r\n\r\n- [x] Change the `:visited` links color to `#7231AB` (see https://github.com/haskell/hackage-server/pull/731#issuecomment-376399312)"},"comment":{"url":"https://api.github.com/repos/haskell/hackage-server/issues/comments/377363122","html_url":"https://github.com/haskell/hackage-server/pull/731#issuecomment-377363122","issue_url":"https://api.github.com/repos/haskell/hackage-server/issues/731","id":377363122,"user":{"login":"NunoAlexandre","id":7075260,"avatar_url":"https://avatars1.githubusercontent.com/u/7075260?v=4","gravatar_id":"","url":"https://api.github.com/users/NunoAlexandre","html_url":"https://github.com/NunoAlexandre","followers_url":"https://api.github.com/users/NunoAlexandre/followers","following_url":"https://api.github.com/users/NunoAlexandre/following{/other_user}","gists_url":"https://api.github.com/users/NunoAlexandre/gists{/gist_id}","starred_url":"https://api.github.com/users/NunoAlexandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NunoAlexandre/subscriptions","organizations_url":"https://api.github.com/users/NunoAlexandre/orgs","repos_url":"https://api.github.com/users/NunoAlexandre/repos","events_url":"https://api.github.com/users/NunoAlexandre/events{/privacy}","received_events_url":"https://api.github.com/users/NunoAlexandre/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T20:31:41Z","updated_at":"2018-03-29T20:43:39Z","author_association":"CONTRIBUTOR","body":"Hi @jirassimok!\r\n\r\nThank you very much for your great feedback.\r\n\r\n> Right now, the visited links have a higher contrast with the background than other links, which is not usually the case. Reversing the two colors works better, I think.\r\n\r\nThis is a good point. I tried reversing the colors but the visited color is too strong - or so I find, it's not a good choice after all. If one tries to do that and see that color used for all links in the page will understand. \r\nEdit: I have change it now, and IMO it looks sensible and better too, also when all links are visited and have this new color. \r\n\r\n> The new font is all right, but I agree that it is very dense. In particular, the version number list is difficult to read, apparently because spaces following commas are narrower than normal spaces.\r\n\r\nI have fixed this, thanks!\r\n\r\n> My overall impression is that the new font looks nicer at a glance (except for the strange kerning around some punctuation), but is harder to read. This isn't too bad, but it makes it a little harder to find information quickly, or if you are dyslexic. \r\n\r\nI have made it less dense and I have worked on the kerning. Could you have another look? \r\n\r\n> (Also, the tiny, asymmetrical apostrophes and quotation marks bug me.)\r\n\r\nCan you point me an example, please?\r\n\r\n<hr>\r\n\r\n>  It doesn't matter for general use, but if someone wanted to look at a Hackage page with a screen reader, for example, the description should be the first information shown.\r\n\r\nThis is a very good point. I worked on a project thought for blind people and this sort of details for the general user makes a whole difference for them. "}}
{"actor":{"display_login":"NunoAlexandre"}}