{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/19996","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19996/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19996/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19996/events","html_url":"https://github.com/joomla/joomla-cms/pull/19996","id":308571830,"number":19996,"title":"Custom field view level","user":{"login":"Ruud68","id":2733197,"avatar_url":"https://avatars1.githubusercontent.com/u/2733197?v=4","gravatar_id":"","url":"https://api.github.com/users/Ruud68","html_url":"https://github.com/Ruud68","followers_url":"https://api.github.com/users/Ruud68/followers","following_url":"https://api.github.com/users/Ruud68/following{/other_user}","gists_url":"https://api.github.com/users/Ruud68/gists{/gist_id}","starred_url":"https://api.github.com/users/Ruud68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ruud68/subscriptions","organizations_url":"https://api.github.com/users/Ruud68/orgs","repos_url":"https://api.github.com/users/Ruud68/repos","events_url":"https://api.github.com/users/Ruud68/events{/privacy}","received_events_url":"https://api.github.com/users/Ruud68/received_events","type":"User","site_admin":false},"labels":[{"id":198658453,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420","default":false},{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-03-26T13:27:54Z","updated_at":"2018-03-26T17:34:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/19996","html_url":"https://github.com/joomla/joomla-cms/pull/19996","diff_url":"https://github.com/joomla/joomla-cms/pull/19996.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/19996.patch"},"body":"Pull Request for New Feature.\r\n\r\nprevious discussion of several approaches that led to this solution: https://issues.joomla.org/tracker/joomla-cms/19473\r\n\r\n### Summary of Changes\r\nThis RFC proposes to extend the configuration of com_fields to better control the displaying of Fields on (component edit / create) Forms. This functionality will greatly extend the use cases for com_fields (and therefore for Joomla!) in ‘real-life’ implementations.\r\nRead-More: https://github.com/joomla/joomla-cms/pull/19996#issuecomment-376171364\r\n\r\nIn this PR, #19884 is 'cherry picked' (currently in staging) as this is a required bug fix for com_fields.\r\n\r\n### Testing Instructions\r\nNote: this PR requires dabase changes.\r\n\r\nDescribed here: https://onlinecommunityhub.nl/community-tools/rfc-joomla-com-fields-access-form-view-level#testing-instructions\r\n\r\n### Expected / Actual result\r\nDescribed here: https://onlinecommunityhub.nl/community-tools/rfc-joomla-com-fields-access-form-view-level#testing-instructions\r\n\r\n### Documentation Changes Required\r\nyes, com_fields gets new configuration field as you can see here: https://onlinecommunityhub.nl/community-tools/rfc-joomla-com-fields-access-form-view-level#ux-back-end-changes\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/376248360","html_url":"https://github.com/joomla/joomla-cms/pull/19996#issuecomment-376248360","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19996","id":376248360,"user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars2.githubusercontent.com/u/368545?v=4","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"created_at":"2018-03-26T17:34:38Z","updated_at":"2018-03-26T17:34:38Z","author_association":"OWNER","body":"Which comes back around full circle.  You have ACL granting edit permissions and you're using a display oriented permission check to effectively revoke the granted edit permission.\r\n\r\nIf that's really how CCKs and these type of usage scenarios have to work (again, no idea, I avoid that type of stuff), then so be it I guess.  I don't like it, everything about the implementation raises a red flag to me, but such is life.  But, that still means there has to be a check in the save actions exactly as I pointed out before because in this usage scenario it is no longer good enough to check whether the user has the `core.edit.value` permission; the edit permission checks used in save actions must also account for this permission being revoked through the viewing access level filter."}}
{"actor":{"display_login":"mbabker"}}