{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/cruise-control/pulls/comments/170370759","pull_request_review_id":99048513,"id":170370759,"diff_hunk":"@@ -52,7 +53,8 @@ public Samples getSamples(Cluster cluster,\n                             Set<TopicPartition> assignedPartitions,\n                             long startTimeMs,\n                             long endTimeMs,\n-                            SamplingMode mode) throws MetricSamplingException {\n+                            SamplingMode mode,\n+                            MetricDef metricDef) throws MetricSamplingException {","path":"cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/monitor/sampling/CruiseControlMetricsReporterSampler.java","position":14,"original_position":14,"commit_id":"bd597bb9419e25bdb0d46aa9b5168cc5ff23a666","original_commit_id":"bd597bb9419e25bdb0d46aa9b5168cc5ff23a666","user":{"login":"efeg","id":1877110,"avatar_url":"https://avatars2.githubusercontent.com/u/1877110?v=4","gravatar_id":"","url":"https://api.github.com/users/efeg","html_url":"https://github.com/efeg","followers_url":"https://api.github.com/users/efeg/followers","following_url":"https://api.github.com/users/efeg/following{/other_user}","gists_url":"https://api.github.com/users/efeg/gists{/gist_id}","starred_url":"https://api.github.com/users/efeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efeg/subscriptions","organizations_url":"https://api.github.com/users/efeg/orgs","repos_url":"https://api.github.com/users/efeg/repos","events_url":"https://api.github.com/users/efeg/events{/privacy}","received_events_url":"https://api.github.com/users/efeg/received_events","type":"User","site_admin":false},"body":"Does the exception `MetricSamplingException` ever thrown? Can we remove it and the corresponding import?","created_at":"2018-02-23T21:19:43Z","updated_at":"2018-02-23T21:28:10Z","html_url":"https://github.com/linkedin/cruise-control/pull/139#discussion_r170370759","pull_request_url":"https://api.github.com/repos/linkedin/cruise-control/pulls/139","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkedin/cruise-control/pulls/comments/170370759"},"html":{"href":"https://github.com/linkedin/cruise-control/pull/139#discussion_r170370759"},"pull_request":{"href":"https://api.github.com/repos/linkedin/cruise-control/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/cruise-control/pulls/139","id":170546709,"html_url":"https://github.com/linkedin/cruise-control/pull/139","diff_url":"https://github.com/linkedin/cruise-control/pull/139.diff","patch_url":"https://github.com/linkedin/cruise-control/pull/139.patch","issue_url":"https://api.github.com/repos/linkedin/cruise-control/issues/139","number":139,"state":"open","locked":false,"title":"Move KafkaCruiseControl to depend on cruise-control-core","user":{"login":"becketqin","id":5778611,"avatar_url":"https://avatars3.githubusercontent.com/u/5778611?v=4","gravatar_id":"","url":"https://api.github.com/users/becketqin","html_url":"https://github.com/becketqin","followers_url":"https://api.github.com/users/becketqin/followers","following_url":"https://api.github.com/users/becketqin/following{/other_user}","gists_url":"https://api.github.com/users/becketqin/gists{/gist_id}","starred_url":"https://api.github.com/users/becketqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becketqin/subscriptions","organizations_url":"https://api.github.com/users/becketqin/orgs","repos_url":"https://api.github.com/users/becketqin/repos","events_url":"https://api.github.com/users/becketqin/events{/privacy}","received_events_url":"https://api.github.com/users/becketqin/received_events","type":"User","site_admin":false},"body":"This patch changes KafkaCruiseControl to depend on cruise-control-core. ","created_at":"2018-02-21T18:07:23Z","updated_at":"2018-02-23T21:28:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4588b83bfca80a37f91aba5448b25af90098963","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/cruise-control/pulls/139/commits","review_comments_url":"https://api.github.com/repos/linkedin/cruise-control/pulls/139/comments","review_comment_url":"https://api.github.com/repos/linkedin/cruise-control/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/cruise-control/issues/139/comments","statuses_url":"https://api.github.com/repos/linkedin/cruise-control/statuses/bd597bb9419e25bdb0d46aa9b5168cc5ff23a666","head":{"label":"becketqin:refactor_MetricSampleAggregator_2","ref":"refactor_MetricSampleAggregator_2","sha":"bd597bb9419e25bdb0d46aa9b5168cc5ff23a666","user":{"login":"becketqin","id":5778611,"avatar_url":"https://avatars3.githubusercontent.com/u/5778611?v=4","gravatar_id":"","url":"https://api.github.com/users/becketqin","html_url":"https://github.com/becketqin","followers_url":"https://api.github.com/users/becketqin/followers","following_url":"https://api.github.com/users/becketqin/following{/other_user}","gists_url":"https://api.github.com/users/becketqin/gists{/gist_id}","starred_url":"https://api.github.com/users/becketqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becketqin/subscriptions","organizations_url":"https://api.github.com/users/becketqin/orgs","repos_url":"https://api.github.com/users/becketqin/repos","events_url":"https://api.github.com/users/becketqin/events{/privacy}","received_events_url":"https://api.github.com/users/becketqin/received_events","type":"User","site_admin":false},"repo":{"id":101806820,"name":"cruise-control","full_name":"becketqin/cruise-control","owner":{"login":"becketqin","id":5778611,"avatar_url":"https://avatars3.githubusercontent.com/u/5778611?v=4","gravatar_id":"","url":"https://api.github.com/users/becketqin","html_url":"https://github.com/becketqin","followers_url":"https://api.github.com/users/becketqin/followers","following_url":"https://api.github.com/users/becketqin/following{/other_user}","gists_url":"https://api.github.com/users/becketqin/gists{/gist_id}","starred_url":"https://api.github.com/users/becketqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becketqin/subscriptions","organizations_url":"https://api.github.com/users/becketqin/orgs","repos_url":"https://api.github.com/users/becketqin/repos","events_url":"https://api.github.com/users/becketqin/events{/privacy}","received_events_url":"https://api.github.com/users/becketqin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/becketqin/cruise-control","description":"Cruise-control is the first of its kind to fully automate the dynamic workload rebalance and self-healing of a kafka cluster. It provides great value to Kafka users by simplifying the operation of Kafka clusters.","fork":true,"url":"https://api.github.com/repos/becketqin/cruise-control","forks_url":"https://api.github.com/repos/becketqin/cruise-control/forks","keys_url":"https://api.github.com/repos/becketqin/cruise-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/becketqin/cruise-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/becketqin/cruise-control/teams","hooks_url":"https://api.github.com/repos/becketqin/cruise-control/hooks","issue_events_url":"https://api.github.com/repos/becketqin/cruise-control/issues/events{/number}","events_url":"https://api.github.com/repos/becketqin/cruise-control/events","assignees_url":"https://api.github.com/repos/becketqin/cruise-control/assignees{/user}","branches_url":"https://api.github.com/repos/becketqin/cruise-control/branches{/branch}","tags_url":"https://api.github.com/repos/becketqin/cruise-control/tags","blobs_url":"https://api.github.com/repos/becketqin/cruise-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/becketqin/cruise-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/becketqin/cruise-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/becketqin/cruise-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/becketqin/cruise-control/statuses/{sha}","languages_url":"https://api.github.com/repos/becketqin/cruise-control/languages","stargazers_url":"https://api.github.com/repos/becketqin/cruise-control/stargazers","contributors_url":"https://api.github.com/repos/becketqin/cruise-control/contributors","subscribers_url":"https://api.github.com/repos/becketqin/cruise-control/subscribers","subscription_url":"https://api.github.com/repos/becketqin/cruise-control/subscription","commits_url":"https://api.github.com/repos/becketqin/cruise-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/becketqin/cruise-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/becketqin/cruise-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/becketqin/cruise-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/becketqin/cruise-control/contents/{+path}","compare_url":"https://api.github.com/repos/becketqin/cruise-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/becketqin/cruise-control/merges","archive_url":"https://api.github.com/repos/becketqin/cruise-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/becketqin/cruise-control/downloads","issues_url":"https://api.github.com/repos/becketqin/cruise-control/issues{/number}","pulls_url":"https://api.github.com/repos/becketqin/cruise-control/pulls{/number}","milestones_url":"https://api.github.com/repos/becketqin/cruise-control/milestones{/number}","notifications_url":"https://api.github.com/repos/becketqin/cruise-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/becketqin/cruise-control/labels{/name}","releases_url":"https://api.github.com/repos/becketqin/cruise-control/releases{/id}","deployments_url":"https://api.github.com/repos/becketqin/cruise-control/deployments","created_at":"2017-08-29T21:05:26Z","updated_at":"2017-08-29T21:05:28Z","pushed_at":"2018-02-22T07:09:35Z","git_url":"git://github.com/becketqin/cruise-control.git","ssh_url":"git@github.com:becketqin/cruise-control.git","clone_url":"https://github.com/becketqin/cruise-control.git","svn_url":"https://github.com/becketqin/cruise-control","homepage":"","size":1344,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"63812a7d0e9433d912e7521b456958ceb907dd4a","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":100402355,"name":"cruise-control","full_name":"linkedin/cruise-control","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/cruise-control","description":"Cruise-control is the first of its kind to fully automate the dynamic workload rebalance and self-healing of a kafka cluster. It provides great value to Kafka users by simplifying the operation of Kafka clusters.","fork":false,"url":"https://api.github.com/repos/linkedin/cruise-control","forks_url":"https://api.github.com/repos/linkedin/cruise-control/forks","keys_url":"https://api.github.com/repos/linkedin/cruise-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/cruise-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/cruise-control/teams","hooks_url":"https://api.github.com/repos/linkedin/cruise-control/hooks","issue_events_url":"https://api.github.com/repos/linkedin/cruise-control/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/cruise-control/events","assignees_url":"https://api.github.com/repos/linkedin/cruise-control/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/cruise-control/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/cruise-control/tags","blobs_url":"https://api.github.com/repos/linkedin/cruise-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/cruise-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/cruise-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/cruise-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/cruise-control/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/cruise-control/languages","stargazers_url":"https://api.github.com/repos/linkedin/cruise-control/stargazers","contributors_url":"https://api.github.com/repos/linkedin/cruise-control/contributors","subscribers_url":"https://api.github.com/repos/linkedin/cruise-control/subscribers","subscription_url":"https://api.github.com/repos/linkedin/cruise-control/subscription","commits_url":"https://api.github.com/repos/linkedin/cruise-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/cruise-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/cruise-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/cruise-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/cruise-control/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/cruise-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/cruise-control/merges","archive_url":"https://api.github.com/repos/linkedin/cruise-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/cruise-control/downloads","issues_url":"https://api.github.com/repos/linkedin/cruise-control/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/cruise-control/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/cruise-control/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/cruise-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/cruise-control/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/cruise-control/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/cruise-control/deployments","created_at":"2017-08-15T17:32:10Z","updated_at":"2018-02-22T07:57:28Z","pushed_at":"2018-02-23T19:28:15Z","git_url":"git://github.com/linkedin/cruise-control.git","ssh_url":"git@github.com:linkedin/cruise-control.git","clone_url":"https://github.com/linkedin/cruise-control.git","svn_url":"https://github.com/linkedin/cruise-control","homepage":"","size":1054,"stargazers_count":658,"watchers_count":658,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":129,"open_issues":25,"watchers":658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/cruise-control/pulls/139"},"html":{"href":"https://github.com/linkedin/cruise-control/pull/139"},"issue":{"href":"https://api.github.com/repos/linkedin/cruise-control/issues/139"},"comments":{"href":"https://api.github.com/repos/linkedin/cruise-control/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/cruise-control/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/cruise-control/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/cruise-control/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/cruise-control/statuses/bd597bb9419e25bdb0d46aa9b5168cc5ff23a666"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"efeg"}}