{"action":"created","comment":{"url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/comments/218075551","pull_request_review_id":155932451,"id":218075551,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODA3NTU1MQ==","diff_hunk":"@@ -144,6 +323,7 @@ def update_specifications(self, revision, raise_errors=True):\n         self._validate_parameter_values(revision_parameters)\n         if self.parameter_errors and raise_errors:\n             raise ValueError('\\n' + self.parameter_errors)\n+        self.compute_default_params()","path":"ogusa/pb_api.py","position":300,"original_position":299,"commit_id":"b67379b2e980983bac8b2085c005b47d29ea562e","original_commit_id":"16a9fd05c94b545bf0aff20e710926ea007c5c30","user":{"login":"jdebacker","id":10715924,"node_id":"MDQ6VXNlcjEwNzE1OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/10715924?v=4","gravatar_id":"","url":"https://api.github.com/users/jdebacker","html_url":"https://github.com/jdebacker","followers_url":"https://api.github.com/users/jdebacker/followers","following_url":"https://api.github.com/users/jdebacker/following{/other_user}","gists_url":"https://api.github.com/users/jdebacker/gists{/gist_id}","starred_url":"https://api.github.com/users/jdebacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdebacker/subscriptions","organizations_url":"https://api.github.com/users/jdebacker/orgs","repos_url":"https://api.github.com/users/jdebacker/repos","events_url":"https://api.github.com/users/jdebacker/events{/privacy}","received_events_url":"https://api.github.com/users/jdebacker/received_events","type":"User","site_admin":false},"body":"No problem.","created_at":"2018-09-17T13:49:47Z","updated_at":"2018-09-17T13:49:48Z","html_url":"https://github.com/open-source-economics/OG-USA/pull/392#discussion_r218075551","pull_request_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/392","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/comments/218075551"},"html":{"href":"https://github.com/open-source-economics/OG-USA/pull/392#discussion_r218075551"},"pull_request":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/392"}},"in_reply_to_id":217928296},"pull_request":{"url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/392","id":190678511,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNjc4NTEx","html_url":"https://github.com/open-source-economics/OG-USA/pull/392","diff_url":"https://github.com/open-source-economics/OG-USA/pull/392.diff","patch_url":"https://github.com/open-source-economics/OG-USA/pull/392.patch","issue_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/392","number":392,"state":"open","locked":false,"title":"[WIP] OG-USA API","user":{"login":"jdebacker","id":10715924,"node_id":"MDQ6VXNlcjEwNzE1OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/10715924?v=4","gravatar_id":"","url":"https://api.github.com/users/jdebacker","html_url":"https://github.com/jdebacker","followers_url":"https://api.github.com/users/jdebacker/followers","following_url":"https://api.github.com/users/jdebacker/following{/other_user}","gists_url":"https://api.github.com/users/jdebacker/gists{/gist_id}","starred_url":"https://api.github.com/users/jdebacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdebacker/subscriptions","organizations_url":"https://api.github.com/users/jdebacker/orgs","repos_url":"https://api.github.com/users/jdebacker/repos","events_url":"https://api.github.com/users/jdebacker/events{/privacy}","received_events_url":"https://api.github.com/users/jdebacker/received_events","type":"User","site_admin":false},"body":"This PR begins a significant overhaul of OG-USA.  It will:\r\n1) Introduce an OG-USA API that initializes a class of parameters.\r\n2) The API will validate the parameterization\r\n3) Modify the OG-USA code base to use a newly created class of parameters in calculations.\r\n\r\nThis is the first step in the process of making an OG-USA class that will allow for more efficient running and modification of OG-USA.","created_at":"2018-05-25T19:42:20Z","updated_at":"2018-09-17T13:49:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"548a384c924ab730d1da40b3001f330363572870","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/392/commits","review_comments_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/392/comments","review_comment_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/392/comments","statuses_url":"https://api.github.com/repos/open-source-economics/OG-USA/statuses/b67379b2e980983bac8b2085c005b47d29ea562e","head":{"label":"jdebacker:dev","ref":"dev","sha":"b67379b2e980983bac8b2085c005b47d29ea562e","user":{"login":"jdebacker","id":10715924,"node_id":"MDQ6VXNlcjEwNzE1OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/10715924?v=4","gravatar_id":"","url":"https://api.github.com/users/jdebacker","html_url":"https://github.com/jdebacker","followers_url":"https://api.github.com/users/jdebacker/followers","following_url":"https://api.github.com/users/jdebacker/following{/other_user}","gists_url":"https://api.github.com/users/jdebacker/gists{/gist_id}","starred_url":"https://api.github.com/users/jdebacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdebacker/subscriptions","organizations_url":"https://api.github.com/users/jdebacker/orgs","repos_url":"https://api.github.com/users/jdebacker/repos","events_url":"https://api.github.com/users/jdebacker/events{/privacy}","received_events_url":"https://api.github.com/users/jdebacker/received_events","type":"User","site_admin":false},"repo":{"id":37939574,"node_id":"MDEwOlJlcG9zaXRvcnkzNzkzOTU3NA==","name":"dynamic","full_name":"jdebacker/dynamic","private":false,"owner":{"login":"jdebacker","id":10715924,"node_id":"MDQ6VXNlcjEwNzE1OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/10715924?v=4","gravatar_id":"","url":"https://api.github.com/users/jdebacker","html_url":"https://github.com/jdebacker","followers_url":"https://api.github.com/users/jdebacker/followers","following_url":"https://api.github.com/users/jdebacker/following{/other_user}","gists_url":"https://api.github.com/users/jdebacker/gists{/gist_id}","starred_url":"https://api.github.com/users/jdebacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdebacker/subscriptions","organizations_url":"https://api.github.com/users/jdebacker/orgs","repos_url":"https://api.github.com/users/jdebacker/repos","events_url":"https://api.github.com/users/jdebacker/events{/privacy}","received_events_url":"https://api.github.com/users/jdebacker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jdebacker/dynamic","description":"Dynamic Tax Scoring Model","fork":true,"url":"https://api.github.com/repos/jdebacker/dynamic","forks_url":"https://api.github.com/repos/jdebacker/dynamic/forks","keys_url":"https://api.github.com/repos/jdebacker/dynamic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdebacker/dynamic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdebacker/dynamic/teams","hooks_url":"https://api.github.com/repos/jdebacker/dynamic/hooks","issue_events_url":"https://api.github.com/repos/jdebacker/dynamic/issues/events{/number}","events_url":"https://api.github.com/repos/jdebacker/dynamic/events","assignees_url":"https://api.github.com/repos/jdebacker/dynamic/assignees{/user}","branches_url":"https://api.github.com/repos/jdebacker/dynamic/branches{/branch}","tags_url":"https://api.github.com/repos/jdebacker/dynamic/tags","blobs_url":"https://api.github.com/repos/jdebacker/dynamic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdebacker/dynamic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdebacker/dynamic/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdebacker/dynamic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdebacker/dynamic/statuses/{sha}","languages_url":"https://api.github.com/repos/jdebacker/dynamic/languages","stargazers_url":"https://api.github.com/repos/jdebacker/dynamic/stargazers","contributors_url":"https://api.github.com/repos/jdebacker/dynamic/contributors","subscribers_url":"https://api.github.com/repos/jdebacker/dynamic/subscribers","subscription_url":"https://api.github.com/repos/jdebacker/dynamic/subscription","commits_url":"https://api.github.com/repos/jdebacker/dynamic/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdebacker/dynamic/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdebacker/dynamic/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdebacker/dynamic/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdebacker/dynamic/contents/{+path}","compare_url":"https://api.github.com/repos/jdebacker/dynamic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdebacker/dynamic/merges","archive_url":"https://api.github.com/repos/jdebacker/dynamic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdebacker/dynamic/downloads","issues_url":"https://api.github.com/repos/jdebacker/dynamic/issues{/number}","pulls_url":"https://api.github.com/repos/jdebacker/dynamic/pulls{/number}","milestones_url":"https://api.github.com/repos/jdebacker/dynamic/milestones{/number}","notifications_url":"https://api.github.com/repos/jdebacker/dynamic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdebacker/dynamic/labels{/name}","releases_url":"https://api.github.com/repos/jdebacker/dynamic/releases{/id}","deployments_url":"https://api.github.com/repos/jdebacker/dynamic/deployments","created_at":"2015-06-23T19:16:54Z","updated_at":"2018-05-24T12:23:49Z","pushed_at":"2018-09-17T13:43:08Z","git_url":"git://github.com/jdebacker/dynamic.git","ssh_url":"git@github.com:jdebacker/dynamic.git","clone_url":"https://github.com/jdebacker/dynamic.git","svn_url":"https://github.com/jdebacker/dynamic","homepage":"","size":729430,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"open-source-economics:dev","ref":"dev","sha":"a676a0a42b469cdd8aa121650dc6b987dc34ec7b","user":{"login":"open-source-economics","id":15148101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTQ4MTAx","avatar_url":"https://avatars2.githubusercontent.com/u/15148101?v=4","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"repo":{"id":30023836,"node_id":"MDEwOlJlcG9zaXRvcnkzMDAyMzgzNg==","name":"OG-USA","full_name":"open-source-economics/OG-USA","private":false,"owner":{"login":"open-source-economics","id":15148101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTQ4MTAx","avatar_url":"https://avatars2.githubusercontent.com/u/15148101?v=4","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-source-economics/OG-USA","description":"Dynamic Tax Scoring Model","fork":false,"url":"https://api.github.com/repos/open-source-economics/OG-USA","forks_url":"https://api.github.com/repos/open-source-economics/OG-USA/forks","keys_url":"https://api.github.com/repos/open-source-economics/OG-USA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-source-economics/OG-USA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-source-economics/OG-USA/teams","hooks_url":"https://api.github.com/repos/open-source-economics/OG-USA/hooks","issue_events_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/events{/number}","events_url":"https://api.github.com/repos/open-source-economics/OG-USA/events","assignees_url":"https://api.github.com/repos/open-source-economics/OG-USA/assignees{/user}","branches_url":"https://api.github.com/repos/open-source-economics/OG-USA/branches{/branch}","tags_url":"https://api.github.com/repos/open-source-economics/OG-USA/tags","blobs_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-source-economics/OG-USA/statuses/{sha}","languages_url":"https://api.github.com/repos/open-source-economics/OG-USA/languages","stargazers_url":"https://api.github.com/repos/open-source-economics/OG-USA/stargazers","contributors_url":"https://api.github.com/repos/open-source-economics/OG-USA/contributors","subscribers_url":"https://api.github.com/repos/open-source-economics/OG-USA/subscribers","subscription_url":"https://api.github.com/repos/open-source-economics/OG-USA/subscription","commits_url":"https://api.github.com/repos/open-source-economics/OG-USA/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-source-economics/OG-USA/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-source-economics/OG-USA/contents/{+path}","compare_url":"https://api.github.com/repos/open-source-economics/OG-USA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-source-economics/OG-USA/merges","archive_url":"https://api.github.com/repos/open-source-economics/OG-USA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-source-economics/OG-USA/downloads","issues_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues{/number}","pulls_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls{/number}","milestones_url":"https://api.github.com/repos/open-source-economics/OG-USA/milestones{/number}","notifications_url":"https://api.github.com/repos/open-source-economics/OG-USA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-source-economics/OG-USA/labels{/name}","releases_url":"https://api.github.com/repos/open-source-economics/OG-USA/releases{/id}","deployments_url":"https://api.github.com/repos/open-source-economics/OG-USA/deployments","created_at":"2015-01-29T14:33:14Z","updated_at":"2018-09-04T19:10:30Z","pushed_at":"2018-09-17T13:43:09Z","git_url":"git://github.com/open-source-economics/OG-USA.git","ssh_url":"git@github.com:open-source-economics/OG-USA.git","clone_url":"https://github.com/open-source-economics/OG-USA.git","svn_url":"https://github.com/open-source-economics/OG-USA","homepage":"","size":729037,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":54,"open_issues":27,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/392"},"html":{"href":"https://github.com/open-source-economics/OG-USA/pull/392"},"issue":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/issues/392"},"comments":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/statuses/b67379b2e980983bac8b2085c005b47d29ea562e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jdebacker"}}