{"action":"created","issue":{"url":"https://api.github.com/repos/knative/eventing/issues/416","repository_url":"https://api.github.com/repos/knative/eventing","labels_url":"https://api.github.com/repos/knative/eventing/issues/416/labels{/name}","comments_url":"https://api.github.com/repos/knative/eventing/issues/416/comments","events_url":"https://api.github.com/repos/knative/eventing/issues/416/events","html_url":"https://github.com/knative/eventing/pull/416","id":357570448,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNTUxNzQz","number":416,"title":"E2E Go testsuite","user":{"login":"mgencur","id":336823,"node_id":"MDQ6VXNlcjMzNjgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/336823?v=4","gravatar_id":"","url":"https://api.github.com/users/mgencur","html_url":"https://github.com/mgencur","followers_url":"https://api.github.com/users/mgencur/followers","following_url":"https://api.github.com/users/mgencur/following{/other_user}","gists_url":"https://api.github.com/users/mgencur/gists{/gist_id}","starred_url":"https://api.github.com/users/mgencur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgencur/subscriptions","organizations_url":"https://api.github.com/users/mgencur/orgs","repos_url":"https://api.github.com/users/mgencur/repos","events_url":"https://api.github.com/users/mgencur/events{/privacy}","received_events_url":"https://api.github.com/users/mgencur/received_events","type":"User","site_admin":false},"labels":[{"id":904029784,"node_id":"MDU6TGFiZWw5MDQwMjk3ODQ=","url":"https://api.github.com/repos/knative/eventing/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-09-06T09:28:02Z","updated_at":"2018-09-14T17:07:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/knative/eventing/pulls/416","html_url":"https://github.com/knative/eventing/pull/416","diff_url":"https://github.com/knative/eventing/pull/416.diff","patch_url":"https://github.com/knative/eventing/pull/416.patch"},"body":"Fixes #411 \r\n\r\n* A lot of the code comes from updated dependencies or from copying files over from knative/serving. You'll see those in separate commits.\r\n* I've tested this against GKE, uploading images to GCR. I'm in trouble running this on Minikube as I'm still waiting on a new laptop with more RAM and the current laptop doesn't manage running knative/eventing with Minikube:). There might be some changes required for Minikube.\r\n* The file called adding_tests.md is not copied over from knative/serving. Let me know if we need it here as well or if we need more documentation.\r\n* Some source code that was copied from knative/serving is not used right now but it might be good to keep it in this repo for future use (but there's not much of it)\r\n* The TestKubernetesEvents test configures various component in the test body. We might move it to utility classes later when we have the need to re-use some of the code. Please let me know what is preferred here.\r\n* The original test included creation of Channel, Subscription and also Flow. I did not include the first two in the new test because the Flow will create them automatically (there were some redundant resources deployed with the original test which were unused)\r\n\r\n## Proposed Changes\r\n\r\n  * re-implement the bash-like tests in Go\r\n  * implement various helper functions\r\n  * implement proper cleanup which removes resources in reverse order of their creation\r\n  * the test images are published before the test (similar to knative/serving's approach) and the test only references them\r\n  * the original test yaml files are now removed\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/knative/eventing/issues/comments/421423409","html_url":"https://github.com/knative/eventing/pull/416#issuecomment-421423409","issue_url":"https://api.github.com/repos/knative/eventing/issues/416","id":421423409,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTQyMzQwOQ==","user":{"login":"adrcunha","id":35786489,"node_id":"MDQ6VXNlcjM1Nzg2NDg5","avatar_url":"https://avatars3.githubusercontent.com/u/35786489?v=4","gravatar_id":"","url":"https://api.github.com/users/adrcunha","html_url":"https://github.com/adrcunha","followers_url":"https://api.github.com/users/adrcunha/followers","following_url":"https://api.github.com/users/adrcunha/following{/other_user}","gists_url":"https://api.github.com/users/adrcunha/gists{/gist_id}","starred_url":"https://api.github.com/users/adrcunha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrcunha/subscriptions","organizations_url":"https://api.github.com/users/adrcunha/orgs","repos_url":"https://api.github.com/users/adrcunha/repos","events_url":"https://api.github.com/users/adrcunha/events{/privacy}","received_events_url":"https://api.github.com/users/adrcunha/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T17:07:38Z","updated_at":"2018-09-14T17:07:38Z","author_association":"CONTRIBUTOR","body":"/approve\r\n\r\nMartin, you have to resolve the merge conflict, so an LGTM now will be discarded by the next commit. Once you fix the merge I'll LGTM the PR."}}
{"actor":{"display_login":"adrcunha"}}