{"action":"created","comment":{"url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/comments/184955477","pull_request_review_id":116249280,"id":184955477,"diff_hunk":"@@ -1,7 +1,7 @@\n {\n-  \"id\": \"{{ CLIENT_ID }}\",\n-  \"clientId\": \"{{ CLIENT_NAME }}-{{ CLIENT_TYPE }}\",\n-  \"name\": \"{{ CLIENT_NAME }}\",\n+  \"id\": \"{{ GENERATED_CLIENT_ID }}\",\n+  \"clientId\": \"{{ CLIENT_ID }}-{{ CLIENT_TYPE }}\",","path":"roles/bind-keycloak-apb/templates/client_bearer.json.j2","position":6,"original_position":6,"commit_id":"5700c0f21262c3849b7425787507c704c127bad7","original_commit_id":"5700c0f21262c3849b7425787507c704c127bad7","user":{"login":"dimitraz","id":8274693,"avatar_url":"https://avatars2.githubusercontent.com/u/8274693?v=4","gravatar_id":"","url":"https://api.github.com/users/dimitraz","html_url":"https://github.com/dimitraz","followers_url":"https://api.github.com/users/dimitraz/followers","following_url":"https://api.github.com/users/dimitraz/following{/other_user}","gists_url":"https://api.github.com/users/dimitraz/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitraz/subscriptions","organizations_url":"https://api.github.com/users/dimitraz/orgs","repos_url":"https://api.github.com/users/dimitraz/repos","events_url":"https://api.github.com/users/dimitraz/events{/privacy}","received_events_url":"https://api.github.com/users/dimitraz/received_events","type":"User","site_admin":false},"body":"Oh yeah sorry! I thought client-type was the mobile client type","created_at":"2018-04-30T10:40:04Z","updated_at":"2018-04-30T10:40:05Z","html_url":"https://github.com/aerogearcatalog/keycloak-apb/pull/80#discussion_r184955477","pull_request_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/80","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/comments/184955477"},"html":{"href":"https://github.com/aerogearcatalog/keycloak-apb/pull/80#discussion_r184955477"},"pull_request":{"href":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/80"}},"in_reply_to_id":184952695},"pull_request":{"url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/80","id":184628093,"html_url":"https://github.com/aerogearcatalog/keycloak-apb/pull/80","diff_url":"https://github.com/aerogearcatalog/keycloak-apb/pull/80.diff","patch_url":"https://github.com/aerogearcatalog/keycloak-apb/pull/80.patch","issue_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/issues/80","number":80,"state":"open","locked":false,"title":"[AEROGEAR-2636] Change bind params to comply with standard bind params schema","user":{"login":"JameelB","id":9078522,"avatar_url":"https://avatars2.githubusercontent.com/u/9078522?v=4","gravatar_id":"","url":"https://api.github.com/users/JameelB","html_url":"https://github.com/JameelB","followers_url":"https://api.github.com/users/JameelB/followers","following_url":"https://api.github.com/users/JameelB/following{/other_user}","gists_url":"https://api.github.com/users/JameelB/gists{/gist_id}","starred_url":"https://api.github.com/users/JameelB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JameelB/subscriptions","organizations_url":"https://api.github.com/users/JameelB/orgs","repos_url":"https://api.github.com/users/JameelB/repos","events_url":"https://api.github.com/users/JameelB/events{/privacy}","received_events_url":"https://api.github.com/users/JameelB/received_events","type":"User","site_admin":false},"body":"## Description\r\nThe bind parameters for client id and type needs to be consistent across all APBs. We need to change the bind parameters in the `apb.yml` to comply with this standard bind params schema.\r\n\r\n## Progress\r\n- [x] Change the bind params to comply with the standard bind params schema for client id and type.\r\n\r\n## Screenshots\r\n![image](https://user-images.githubusercontent.com/9078522/39366756-be6b97ce-4a2c-11e8-87a2-3a7b7328df66.png)\r\n\r\n## Additional Notes\r\nRelated JIRA Ticket - https://issues.jboss.org/browse/AEROGEAR-2636\r\n","created_at":"2018-04-27T13:50:52Z","updated_at":"2018-04-30T10:40:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1e3cbef9921c99395d247d3204dfb0af53255b3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"maleck13","id":304628,"avatar_url":"https://avatars2.githubusercontent.com/u/304628?v=4","gravatar_id":"","url":"https://api.github.com/users/maleck13","html_url":"https://github.com/maleck13","followers_url":"https://api.github.com/users/maleck13/followers","following_url":"https://api.github.com/users/maleck13/following{/other_user}","gists_url":"https://api.github.com/users/maleck13/gists{/gist_id}","starred_url":"https://api.github.com/users/maleck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maleck13/subscriptions","organizations_url":"https://api.github.com/users/maleck13/orgs","repos_url":"https://api.github.com/users/maleck13/repos","events_url":"https://api.github.com/users/maleck13/events{/privacy}","received_events_url":"https://api.github.com/users/maleck13/received_events","type":"User","site_admin":false},{"login":"philbrookes","id":1033452,"avatar_url":"https://avatars1.githubusercontent.com/u/1033452?v=4","gravatar_id":"","url":"https://api.github.com/users/philbrookes","html_url":"https://github.com/philbrookes","followers_url":"https://api.github.com/users/philbrookes/followers","following_url":"https://api.github.com/users/philbrookes/following{/other_user}","gists_url":"https://api.github.com/users/philbrookes/gists{/gist_id}","starred_url":"https://api.github.com/users/philbrookes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbrookes/subscriptions","organizations_url":"https://api.github.com/users/philbrookes/orgs","repos_url":"https://api.github.com/users/philbrookes/repos","events_url":"https://api.github.com/users/philbrookes/events{/privacy}","received_events_url":"https://api.github.com/users/philbrookes/received_events","type":"User","site_admin":false},{"login":"vchepeli","id":1727278,"avatar_url":"https://avatars1.githubusercontent.com/u/1727278?v=4","gravatar_id":"","url":"https://api.github.com/users/vchepeli","html_url":"https://github.com/vchepeli","followers_url":"https://api.github.com/users/vchepeli/followers","following_url":"https://api.github.com/users/vchepeli/following{/other_user}","gists_url":"https://api.github.com/users/vchepeli/gists{/gist_id}","starred_url":"https://api.github.com/users/vchepeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchepeli/subscriptions","organizations_url":"https://api.github.com/users/vchepeli/orgs","repos_url":"https://api.github.com/users/vchepeli/repos","events_url":"https://api.github.com/users/vchepeli/events{/privacy}","received_events_url":"https://api.github.com/users/vchepeli/received_events","type":"User","site_admin":false},{"login":"sedroche","id":22113654,"avatar_url":"https://avatars1.githubusercontent.com/u/22113654?v=4","gravatar_id":"","url":"https://api.github.com/users/sedroche","html_url":"https://github.com/sedroche","followers_url":"https://api.github.com/users/sedroche/followers","following_url":"https://api.github.com/users/sedroche/following{/other_user}","gists_url":"https://api.github.com/users/sedroche/gists{/gist_id}","starred_url":"https://api.github.com/users/sedroche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sedroche/subscriptions","organizations_url":"https://api.github.com/users/sedroche/orgs","repos_url":"https://api.github.com/users/sedroche/repos","events_url":"https://api.github.com/users/sedroche/events{/privacy}","received_events_url":"https://api.github.com/users/sedroche/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/80/commits","review_comments_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/80/comments","review_comment_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/issues/80/comments","statuses_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/statuses/5700c0f21262c3849b7425787507c704c127bad7","head":{"label":"JameelB:AEROGEAR-2636-change-bind-params","ref":"AEROGEAR-2636-change-bind-params","sha":"5700c0f21262c3849b7425787507c704c127bad7","user":{"login":"JameelB","id":9078522,"avatar_url":"https://avatars2.githubusercontent.com/u/9078522?v=4","gravatar_id":"","url":"https://api.github.com/users/JameelB","html_url":"https://github.com/JameelB","followers_url":"https://api.github.com/users/JameelB/followers","following_url":"https://api.github.com/users/JameelB/following{/other_user}","gists_url":"https://api.github.com/users/JameelB/gists{/gist_id}","starred_url":"https://api.github.com/users/JameelB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JameelB/subscriptions","organizations_url":"https://api.github.com/users/JameelB/orgs","repos_url":"https://api.github.com/users/JameelB/repos","events_url":"https://api.github.com/users/JameelB/events{/privacy}","received_events_url":"https://api.github.com/users/JameelB/received_events","type":"User","site_admin":false},"repo":{"id":122084889,"name":"keycloak-apb","full_name":"JameelB/keycloak-apb","owner":{"login":"JameelB","id":9078522,"avatar_url":"https://avatars2.githubusercontent.com/u/9078522?v=4","gravatar_id":"","url":"https://api.github.com/users/JameelB","html_url":"https://github.com/JameelB","followers_url":"https://api.github.com/users/JameelB/followers","following_url":"https://api.github.com/users/JameelB/following{/other_user}","gists_url":"https://api.github.com/users/JameelB/gists{/gist_id}","starred_url":"https://api.github.com/users/JameelB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JameelB/subscriptions","organizations_url":"https://api.github.com/users/JameelB/orgs","repos_url":"https://api.github.com/users/JameelB/repos","events_url":"https://api.github.com/users/JameelB/events{/privacy}","received_events_url":"https://api.github.com/users/JameelB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JameelB/keycloak-apb","description":null,"fork":true,"url":"https://api.github.com/repos/JameelB/keycloak-apb","forks_url":"https://api.github.com/repos/JameelB/keycloak-apb/forks","keys_url":"https://api.github.com/repos/JameelB/keycloak-apb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JameelB/keycloak-apb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JameelB/keycloak-apb/teams","hooks_url":"https://api.github.com/repos/JameelB/keycloak-apb/hooks","issue_events_url":"https://api.github.com/repos/JameelB/keycloak-apb/issues/events{/number}","events_url":"https://api.github.com/repos/JameelB/keycloak-apb/events","assignees_url":"https://api.github.com/repos/JameelB/keycloak-apb/assignees{/user}","branches_url":"https://api.github.com/repos/JameelB/keycloak-apb/branches{/branch}","tags_url":"https://api.github.com/repos/JameelB/keycloak-apb/tags","blobs_url":"https://api.github.com/repos/JameelB/keycloak-apb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JameelB/keycloak-apb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JameelB/keycloak-apb/git/refs{/sha}","trees_url":"https://api.github.com/repos/JameelB/keycloak-apb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JameelB/keycloak-apb/statuses/{sha}","languages_url":"https://api.github.com/repos/JameelB/keycloak-apb/languages","stargazers_url":"https://api.github.com/repos/JameelB/keycloak-apb/stargazers","contributors_url":"https://api.github.com/repos/JameelB/keycloak-apb/contributors","subscribers_url":"https://api.github.com/repos/JameelB/keycloak-apb/subscribers","subscription_url":"https://api.github.com/repos/JameelB/keycloak-apb/subscription","commits_url":"https://api.github.com/repos/JameelB/keycloak-apb/commits{/sha}","git_commits_url":"https://api.github.com/repos/JameelB/keycloak-apb/git/commits{/sha}","comments_url":"https://api.github.com/repos/JameelB/keycloak-apb/comments{/number}","issue_comment_url":"https://api.github.com/repos/JameelB/keycloak-apb/issues/comments{/number}","contents_url":"https://api.github.com/repos/JameelB/keycloak-apb/contents/{+path}","compare_url":"https://api.github.com/repos/JameelB/keycloak-apb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JameelB/keycloak-apb/merges","archive_url":"https://api.github.com/repos/JameelB/keycloak-apb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JameelB/keycloak-apb/downloads","issues_url":"https://api.github.com/repos/JameelB/keycloak-apb/issues{/number}","pulls_url":"https://api.github.com/repos/JameelB/keycloak-apb/pulls{/number}","milestones_url":"https://api.github.com/repos/JameelB/keycloak-apb/milestones{/number}","notifications_url":"https://api.github.com/repos/JameelB/keycloak-apb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JameelB/keycloak-apb/labels{/name}","releases_url":"https://api.github.com/repos/JameelB/keycloak-apb/releases{/id}","deployments_url":"https://api.github.com/repos/JameelB/keycloak-apb/deployments","created_at":"2018-02-19T15:52:36Z","updated_at":"2018-02-19T15:52:37Z","pushed_at":"2018-04-30T10:14:36Z","git_url":"git://github.com/JameelB/keycloak-apb.git","ssh_url":"git@github.com:JameelB/keycloak-apb.git","clone_url":"https://github.com/JameelB/keycloak-apb.git","svn_url":"https://github.com/JameelB/keycloak-apb","homepage":null,"size":312,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogearcatalog:master","ref":"master","sha":"9f7c1a73c4e589e66c33a43609915073c811a02d","user":{"login":"aerogearcatalog","id":34546838,"avatar_url":"https://avatars1.githubusercontent.com/u/34546838?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogearcatalog","html_url":"https://github.com/aerogearcatalog","followers_url":"https://api.github.com/users/aerogearcatalog/followers","following_url":"https://api.github.com/users/aerogearcatalog/following{/other_user}","gists_url":"https://api.github.com/users/aerogearcatalog/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogearcatalog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogearcatalog/subscriptions","organizations_url":"https://api.github.com/users/aerogearcatalog/orgs","repos_url":"https://api.github.com/users/aerogearcatalog/repos","events_url":"https://api.github.com/users/aerogearcatalog/events{/privacy}","received_events_url":"https://api.github.com/users/aerogearcatalog/received_events","type":"Organization","site_admin":false},"repo":{"id":114350045,"name":"keycloak-apb","full_name":"aerogearcatalog/keycloak-apb","owner":{"login":"aerogearcatalog","id":34546838,"avatar_url":"https://avatars1.githubusercontent.com/u/34546838?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogearcatalog","html_url":"https://github.com/aerogearcatalog","followers_url":"https://api.github.com/users/aerogearcatalog/followers","following_url":"https://api.github.com/users/aerogearcatalog/following{/other_user}","gists_url":"https://api.github.com/users/aerogearcatalog/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogearcatalog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogearcatalog/subscriptions","organizations_url":"https://api.github.com/users/aerogearcatalog/orgs","repos_url":"https://api.github.com/users/aerogearcatalog/repos","events_url":"https://api.github.com/users/aerogearcatalog/events{/privacy}","received_events_url":"https://api.github.com/users/aerogearcatalog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogearcatalog/keycloak-apb","description":null,"fork":false,"url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb","forks_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/forks","keys_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/teams","hooks_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/hooks","issue_events_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/issues/events{/number}","events_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/events","assignees_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/assignees{/user}","branches_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/branches{/branch}","tags_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/tags","blobs_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/languages","stargazers_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/stargazers","contributors_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/contributors","subscribers_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/subscribers","subscription_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/subscription","commits_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/contents/{+path}","compare_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/merges","archive_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/downloads","issues_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/issues{/number}","pulls_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/labels{/name}","releases_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/releases{/id}","deployments_url":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/deployments","created_at":"2017-12-15T09:04:08Z","updated_at":"2018-04-25T10:52:42Z","pushed_at":"2018-04-30T10:14:38Z","git_url":"git://github.com/aerogearcatalog/keycloak-apb.git","ssh_url":"git@github.com:aerogearcatalog/keycloak-apb.git","clone_url":"https://github.com/aerogearcatalog/keycloak-apb.git","svn_url":"https://github.com/aerogearcatalog/keycloak-apb","homepage":null,"size":314,"stargazers_count":2,"watchers_count":2,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":19,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/80"},"html":{"href":"https://github.com/aerogearcatalog/keycloak-apb/pull/80"},"issue":{"href":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/issues/80"},"comments":{"href":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/aerogearcatalog/keycloak-apb/statuses/5700c0f21262c3849b7425787507c704c127bad7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dimitraz"}}