{"action":"created","comment":{"url":"https://api.github.com/repos/bookshelf/bookshelf/pulls/comments/169662840","pull_request_review_id":98224834,"id":169662840,"diff_hunk":"@@ -517,6 +517,33 @@ module.exports = function(bookshelf) {\n         });\n       });\n \n+      it('ensure events are async', function(ok) {","path":"test/integration/model.js","position":4,"original_position":4,"commit_id":"1a5e5cfce08ad7a84fb2d60dd8418e3d2c8f67ca","original_commit_id":"1a5e5cfce08ad7a84fb2d60dd8418e3d2c8f67ca","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"body":"will update 👍 ","created_at":"2018-02-21T14:58:03Z","updated_at":"2018-02-21T14:58:04Z","html_url":"https://github.com/bookshelf/bookshelf/pull/1768#discussion_r169662840","pull_request_url":"https://api.github.com/repos/bookshelf/bookshelf/pulls/1768","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bookshelf/bookshelf/pulls/comments/169662840"},"html":{"href":"https://github.com/bookshelf/bookshelf/pull/1768#discussion_r169662840"},"pull_request":{"href":"https://api.github.com/repos/bookshelf/bookshelf/pulls/1768"}},"in_reply_to_id":169657858},"pull_request":{"url":"https://api.github.com/repos/bookshelf/bookshelf/pulls/1768","id":170468684,"html_url":"https://github.com/bookshelf/bookshelf/pull/1768","diff_url":"https://github.com/bookshelf/bookshelf/pull/1768.diff","patch_url":"https://github.com/bookshelf/bookshelf/pull/1768.patch","issue_url":"https://api.github.com/repos/bookshelf/bookshelf/issues/1768","number":1768,"state":"open","locked":false,"title":"Fixed events being async","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"body":"closes #1765\r\n\r\n- tests pass locally for all clients\r\n- added a test which proofs that the fix works","created_at":"2018-02-21T13:25:10Z","updated_at":"2018-02-21T14:58:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6063ea7b52c6900c514dd4480aa445394496bbc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":35193628,"url":"https://api.github.com/repos/bookshelf/bookshelf/labels/change","name":"change","color":"009800","default":false},{"id":57924743,"url":"https://api.github.com/repos/bookshelf/bookshelf/labels/events","name":"events","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bookshelf/bookshelf/pulls/1768/commits","review_comments_url":"https://api.github.com/repos/bookshelf/bookshelf/pulls/1768/comments","review_comment_url":"https://api.github.com/repos/bookshelf/bookshelf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bookshelf/bookshelf/issues/1768/comments","statuses_url":"https://api.github.com/repos/bookshelf/bookshelf/statuses/1a5e5cfce08ad7a84fb2d60dd8418e3d2c8f67ca","head":{"label":"kirrg001:fix-events-async","ref":"fix-events-async","sha":"1a5e5cfce08ad7a84fb2d60dd8418e3d2c8f67ca","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"repo":{"id":72649493,"name":"bookshelf","full_name":"kirrg001/bookshelf","owner":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kirrg001/bookshelf","description":"A simple Node.js ORM for PostgreSQL, MySQL and SQLite3 built on top of Knex.js","fork":true,"url":"https://api.github.com/repos/kirrg001/bookshelf","forks_url":"https://api.github.com/repos/kirrg001/bookshelf/forks","keys_url":"https://api.github.com/repos/kirrg001/bookshelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirrg001/bookshelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirrg001/bookshelf/teams","hooks_url":"https://api.github.com/repos/kirrg001/bookshelf/hooks","issue_events_url":"https://api.github.com/repos/kirrg001/bookshelf/issues/events{/number}","events_url":"https://api.github.com/repos/kirrg001/bookshelf/events","assignees_url":"https://api.github.com/repos/kirrg001/bookshelf/assignees{/user}","branches_url":"https://api.github.com/repos/kirrg001/bookshelf/branches{/branch}","tags_url":"https://api.github.com/repos/kirrg001/bookshelf/tags","blobs_url":"https://api.github.com/repos/kirrg001/bookshelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirrg001/bookshelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirrg001/bookshelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirrg001/bookshelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirrg001/bookshelf/statuses/{sha}","languages_url":"https://api.github.com/repos/kirrg001/bookshelf/languages","stargazers_url":"https://api.github.com/repos/kirrg001/bookshelf/stargazers","contributors_url":"https://api.github.com/repos/kirrg001/bookshelf/contributors","subscribers_url":"https://api.github.com/repos/kirrg001/bookshelf/subscribers","subscription_url":"https://api.github.com/repos/kirrg001/bookshelf/subscription","commits_url":"https://api.github.com/repos/kirrg001/bookshelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirrg001/bookshelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirrg001/bookshelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirrg001/bookshelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirrg001/bookshelf/contents/{+path}","compare_url":"https://api.github.com/repos/kirrg001/bookshelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirrg001/bookshelf/merges","archive_url":"https://api.github.com/repos/kirrg001/bookshelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirrg001/bookshelf/downloads","issues_url":"https://api.github.com/repos/kirrg001/bookshelf/issues{/number}","pulls_url":"https://api.github.com/repos/kirrg001/bookshelf/pulls{/number}","milestones_url":"https://api.github.com/repos/kirrg001/bookshelf/milestones{/number}","notifications_url":"https://api.github.com/repos/kirrg001/bookshelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirrg001/bookshelf/labels{/name}","releases_url":"https://api.github.com/repos/kirrg001/bookshelf/releases{/id}","deployments_url":"https://api.github.com/repos/kirrg001/bookshelf/deployments","created_at":"2016-11-02T14:46:40Z","updated_at":"2016-11-02T14:46:42Z","pushed_at":"2018-02-21T13:29:44Z","git_url":"git://github.com/kirrg001/bookshelf.git","ssh_url":"git@github.com:kirrg001/bookshelf.git","clone_url":"https://github.com/kirrg001/bookshelf.git","svn_url":"https://github.com/kirrg001/bookshelf","homepage":"http://bookshelfjs.org","size":6007,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bookshelf:master","ref":"master","sha":"b04ef8d2aab60287ce4253cb97a96d909a3153b1","user":{"login":"bookshelf","id":4448260,"avatar_url":"https://avatars2.githubusercontent.com/u/4448260?v=4","gravatar_id":"","url":"https://api.github.com/users/bookshelf","html_url":"https://github.com/bookshelf","followers_url":"https://api.github.com/users/bookshelf/followers","following_url":"https://api.github.com/users/bookshelf/following{/other_user}","gists_url":"https://api.github.com/users/bookshelf/gists{/gist_id}","starred_url":"https://api.github.com/users/bookshelf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bookshelf/subscriptions","organizations_url":"https://api.github.com/users/bookshelf/orgs","repos_url":"https://api.github.com/users/bookshelf/repos","events_url":"https://api.github.com/users/bookshelf/events{/privacy}","received_events_url":"https://api.github.com/users/bookshelf/received_events","type":"Organization","site_admin":false},"repo":{"id":8594752,"name":"bookshelf","full_name":"bookshelf/bookshelf","owner":{"login":"bookshelf","id":4448260,"avatar_url":"https://avatars2.githubusercontent.com/u/4448260?v=4","gravatar_id":"","url":"https://api.github.com/users/bookshelf","html_url":"https://github.com/bookshelf","followers_url":"https://api.github.com/users/bookshelf/followers","following_url":"https://api.github.com/users/bookshelf/following{/other_user}","gists_url":"https://api.github.com/users/bookshelf/gists{/gist_id}","starred_url":"https://api.github.com/users/bookshelf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bookshelf/subscriptions","organizations_url":"https://api.github.com/users/bookshelf/orgs","repos_url":"https://api.github.com/users/bookshelf/repos","events_url":"https://api.github.com/users/bookshelf/events{/privacy}","received_events_url":"https://api.github.com/users/bookshelf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bookshelf/bookshelf","description":"A simple Node.js ORM for PostgreSQL, MySQL and SQLite3 built on top of Knex.js","fork":false,"url":"https://api.github.com/repos/bookshelf/bookshelf","forks_url":"https://api.github.com/repos/bookshelf/bookshelf/forks","keys_url":"https://api.github.com/repos/bookshelf/bookshelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bookshelf/bookshelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bookshelf/bookshelf/teams","hooks_url":"https://api.github.com/repos/bookshelf/bookshelf/hooks","issue_events_url":"https://api.github.com/repos/bookshelf/bookshelf/issues/events{/number}","events_url":"https://api.github.com/repos/bookshelf/bookshelf/events","assignees_url":"https://api.github.com/repos/bookshelf/bookshelf/assignees{/user}","branches_url":"https://api.github.com/repos/bookshelf/bookshelf/branches{/branch}","tags_url":"https://api.github.com/repos/bookshelf/bookshelf/tags","blobs_url":"https://api.github.com/repos/bookshelf/bookshelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bookshelf/bookshelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bookshelf/bookshelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/bookshelf/bookshelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bookshelf/bookshelf/statuses/{sha}","languages_url":"https://api.github.com/repos/bookshelf/bookshelf/languages","stargazers_url":"https://api.github.com/repos/bookshelf/bookshelf/stargazers","contributors_url":"https://api.github.com/repos/bookshelf/bookshelf/contributors","subscribers_url":"https://api.github.com/repos/bookshelf/bookshelf/subscribers","subscription_url":"https://api.github.com/repos/bookshelf/bookshelf/subscription","commits_url":"https://api.github.com/repos/bookshelf/bookshelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/bookshelf/bookshelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/bookshelf/bookshelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/bookshelf/bookshelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/bookshelf/bookshelf/contents/{+path}","compare_url":"https://api.github.com/repos/bookshelf/bookshelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bookshelf/bookshelf/merges","archive_url":"https://api.github.com/repos/bookshelf/bookshelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bookshelf/bookshelf/downloads","issues_url":"https://api.github.com/repos/bookshelf/bookshelf/issues{/number}","pulls_url":"https://api.github.com/repos/bookshelf/bookshelf/pulls{/number}","milestones_url":"https://api.github.com/repos/bookshelf/bookshelf/milestones{/number}","notifications_url":"https://api.github.com/repos/bookshelf/bookshelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bookshelf/bookshelf/labels{/name}","releases_url":"https://api.github.com/repos/bookshelf/bookshelf/releases{/id}","deployments_url":"https://api.github.com/repos/bookshelf/bookshelf/deployments","created_at":"2013-03-06T03:07:32Z","updated_at":"2018-02-21T01:03:10Z","pushed_at":"2018-02-21T13:26:59Z","git_url":"git://github.com/bookshelf/bookshelf.git","ssh_url":"git@github.com:bookshelf/bookshelf.git","clone_url":"https://github.com/bookshelf/bookshelf.git","svn_url":"https://github.com/bookshelf/bookshelf","homepage":"http://bookshelfjs.org","size":6046,"stargazers_count":4702,"watchers_count":4702,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":420,"mirror_url":null,"archived":false,"open_issues_count":233,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":420,"open_issues":233,"watchers":4702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bookshelf/bookshelf/pulls/1768"},"html":{"href":"https://github.com/bookshelf/bookshelf/pull/1768"},"issue":{"href":"https://api.github.com/repos/bookshelf/bookshelf/issues/1768"},"comments":{"href":"https://api.github.com/repos/bookshelf/bookshelf/issues/1768/comments"},"review_comments":{"href":"https://api.github.com/repos/bookshelf/bookshelf/pulls/1768/comments"},"review_comment":{"href":"https://api.github.com/repos/bookshelf/bookshelf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bookshelf/bookshelf/pulls/1768/commits"},"statuses":{"href":"https://api.github.com/repos/bookshelf/bookshelf/statuses/1a5e5cfce08ad7a84fb2d60dd8418e3d2c8f67ca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kirrg001"}}