{"action":"created","issue":{"url":"https://api.github.com/repos/sahat/hackathon-starter/issues/600","repository_url":"https://api.github.com/repos/sahat/hackathon-starter","labels_url":"https://api.github.com/repos/sahat/hackathon-starter/issues/600/labels{/name}","comments_url":"https://api.github.com/repos/sahat/hackathon-starter/issues/600/comments","events_url":"https://api.github.com/repos/sahat/hackathon-starter/issues/600/events","html_url":"https://github.com/sahat/hackathon-starter/issues/600","id":183258188,"number":600,"title":"Steam OAuth","user":{"login":"YasharF","id":6448697,"avatar_url":"https://avatars1.githubusercontent.com/u/6448697?v=4","gravatar_id":"","url":"https://api.github.com/users/YasharF","html_url":"https://github.com/YasharF","followers_url":"https://api.github.com/users/YasharF/followers","following_url":"https://api.github.com/users/YasharF/following{/other_user}","gists_url":"https://api.github.com/users/YasharF/gists{/gist_id}","starred_url":"https://api.github.com/users/YasharF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YasharF/subscriptions","organizations_url":"https://api.github.com/users/YasharF/orgs","repos_url":"https://api.github.com/users/YasharF/repos","events_url":"https://api.github.com/users/YasharF/events{/privacy}","received_events_url":"https://api.github.com/users/YasharF/received_events","type":"User","site_admin":false},"labels":[{"id":65703288,"url":"https://api.github.com/repos/sahat/hackathon-starter/labels/bug","name":"bug","color":"e11d21","default":true},{"id":371166943,"url":"https://api.github.com/repos/sahat/hackathon-starter/labels/in%20progress","name":"in progress","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-16T09:42:11Z","updated_at":"2018-03-23T21:52:57Z","closed_at":"2018-03-23T21:52:57Z","author_association":"COLLABORATOR","body":"I am getting failed logins with Steam, and I suspect there is a potential bug in the passportjs config https://github.com/sahat/hackathon-starter/blob/master/config/passport.js#L457 :\r\nIt looks like that localhost is hardcoded as the returnURL for Steam OpenIDStrategy is set to localhost.  I think the mismatch between this and the domain for the API key are part of the problem, and the requests not coming from the localhost (aka when deployed to Heroku, etc) is probably the other part of the problem.\r\n\r\nIf my suspicion is correct, then probably  the two lines in passportjs config need to be modified so they are using some environment variable config that is the deployment domain/steam app registration domain, instead of the hardcoded `localhost:3000`\r\n"},"comment":{"url":"https://api.github.com/repos/sahat/hackathon-starter/issues/comments/375808307","html_url":"https://github.com/sahat/hackathon-starter/issues/600#issuecomment-375808307","issue_url":"https://api.github.com/repos/sahat/hackathon-starter/issues/600","id":375808307,"user":{"login":"YasharF","id":6448697,"avatar_url":"https://avatars1.githubusercontent.com/u/6448697?v=4","gravatar_id":"","url":"https://api.github.com/users/YasharF","html_url":"https://github.com/YasharF","followers_url":"https://api.github.com/users/YasharF/followers","following_url":"https://api.github.com/users/YasharF/following{/other_user}","gists_url":"https://api.github.com/users/YasharF/gists{/gist_id}","starred_url":"https://api.github.com/users/YasharF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YasharF/subscriptions","organizations_url":"https://api.github.com/users/YasharF/orgs","repos_url":"https://api.github.com/users/YasharF/repos","events_url":"https://api.github.com/users/YasharF/events{/privacy}","received_events_url":"https://api.github.com/users/YasharF/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T21:52:57Z","updated_at":"2018-03-23T21:52:57Z","author_association":"COLLABORATOR","body":"Fixed with the release of v4.4.0"}}
{"actor":{"display_login":"YasharF"}}