{"push_id":2598720097,"size":46,"distinct_size":46,"ref":"refs/heads/mac68k-queue","head":"a23a7b48bc8dd84e0c975035448bc88e11b3d3cc","before":"381741db62604f2bb5e8a4c4e3d2ac65ba6bf566","commits":[{"sha":"15ac4ebd7832c1da8ee57de5484d29ade20dbade","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/8390: Remove redundant make dependencies\n\nThe hydra, zorro8390 and mcf8390 drivers all #include \"lib8390.c\" and\nhave no need for 8390.o. modinfo confirms no dependency on 8390.ko.\nDrop the redundant dependency from the Makefile. objdump confirms\nthat this patch has no effect on the module binaries.\n\nThe superfluous additions of 8390.o were introduced in\ncommit 644570b83026 (\"8390: Move the 8390 related drivers\").\n\nCc: Greg Ungerer <gerg@linux-m68k.org>\nCc: Geert Uytterhoeven <geert@linux-m68k.org>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\nAcked-by: Geert Uytterhoeven <geert@linux-m68k.org>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/15ac4ebd7832c1da8ee57de5484d29ade20dbade"},{"sha":"23fb45ced1d157a313a7084893861245ac23c549","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/8390: Fix msg_enable patch snafu\n\nThe lib8390 module parameter 'msg_enable' doesn't do anything useful:\nit causes an ancient version string to be logged.\n\nRemove redundant code that logs the same string.\n\nIn ne.c and wd.c, the value of ei_local->msg_enable is used before\nbeing assigned. Use ne_msg_enable and wd_msg_enable, respectively.\n\nMost of the other 8390 drivers never assign ei_local->msg_enable.\nUse the 'msg_enable' module parameter from lib8390 as the default\nvalue.\n\nEliminate the pointless static and local variables.\n\nClean up an indentation mistake.\n\nAll of these issues originated from the same patch.\n\nCc: Russell King <linux@armlinux.org.uk>\nFixes: c45f812f0280 (\"8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature\")\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\n---\nOnly the mac8390.c and lib8390.c changes have been tested. The other\nchanges are similar but untested.","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/23fb45ced1d157a313a7084893861245ac23c549"},{"sha":"03531ff062f8008a1b05d40171c167c0a688efb1","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/mac8390: Convert to nubus_driver\n\nThis resolves an old bug that constrained this driver to no more than\none card.\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/03531ff062f8008a1b05d40171c167c0a688efb1"},{"sha":"e3077fce1a56c2580b6882e89cee13aba8e940d1","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/mac8390: Fix log messages\n\nUse dev_foo() to log the slot number instead of the unexpanded \"eth%d\"\nformat string.\nDisambiguate the two identical \"Card type %s is unsupported\" messages.\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/e3077fce1a56c2580b6882e89cee13aba8e940d1"},{"sha":"76be8ca0e9896132d4943721c794bd138b477e1e","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/mac89x0: Remove redundant code\n\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/76be8ca0e9896132d4943721c794bd138b477e1e"},{"sha":"57f540e7559ea128417e6a38c2141e20704f385e","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/mac89x0: Convert to platform_driver\n\nApparently these Dayna cards don't have a pseudoslot declaration ROM\nwhich means they can't be probed like NuBus cards.\n\nCc: Geert Uytterhoeven <geert@linux-m68k.org>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\nAcked-by: Geert Uytterhoeven <geert@linux-m68k.org>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/57f540e7559ea128417e6a38c2141e20704f385e"},{"sha":"a9e496e3b279feb84dc83a4f7250e5185c572bf4","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/mac89x0: Fix and modernize log messages\n\nFix log message fragments that no longer produce the desired output\nsince the behaviour of printk() was changed.\nAdd missing printk severity levels.\nDrop deprecated \"out of memory\" message as per checkpatch advice.\n\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/a9e496e3b279feb84dc83a4f7250e5185c572bf4"},{"sha":"46e7b3617927ae02f3b056f64300a786786fd2f6","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/mac89x0: Replace custom debug logging with netif_* calls\n\nAdopt the conventional style of debug logging because it is both\nshorter and more flexible.\nRemove the 'version_printed' flag as the version will be printed\nonly once anyway (when the module loads).\n\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/46e7b3617927ae02f3b056f64300a786786fd2f6"},{"sha":"aebb086c8e608d57a44c09f73b0fca796d466ed7","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/macsonic: Convert to nubus_driver\n\nThis resolves an old issue preventing any NuBus SONIC NICs from\nworking in a Mac with an on-board SONIC device.\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/aebb086c8e608d57a44c09f73b0fca796d466ed7"},{"sha":"5be9ddbc1abbcd2134244d0d57ea91d30ed93431","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/macsonic: Drop redundant MACH_IS_MAC test\n\nThe MACH_IS_MAC test is redundant here because the platform device\nwon't get registered unless MACH_IS_MAC.\n\nCc: Geert Uytterhoeven <geert@linux-m68k.org>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/5be9ddbc1abbcd2134244d0d57ea91d30ed93431"},{"sha":"7dd71da677ce5bb56e4b7a9ac994631298ed05e7","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/sonic: Clean up and modernize log messages\n\nAdd missing printk severity levels by adopting pr_foo() calls for the\nplatform_driver and dev_foo() calls for the nubus_driver.\nAvoid KERN_CONT usage as per advice from checkpatch.\nAvoid #ifdef around printk calls.\nDon't log driver probe messages after calling register_netdev().\n\nCc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>\nCc: Chris Zankel <chris@zankel.net>\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\n---\nOnly the macsonic.c changes have been tested. The other changes\nare similar but untested.","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/7dd71da677ce5bb56e4b7a9ac994631298ed05e7"},{"sha":"f4dabc544fd0ad6e50a234e01710ec9b2d376a30","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/sonic: Replace custom debug logging with netif_* calls\n\nEliminate duplicated debug code by moving it into the core driver.\nDon't log the only valid silicon revision number (it's in the source).\n\nCc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>\nCc: Chris Zankel <chris@zankel.net>\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\n---\nOnly the sonic.[ch] and macsonic.c changes have been tested. The other\nchanges are similar but untested.","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/f4dabc544fd0ad6e50a234e01710ec9b2d376a30"},{"sha":"bc2592e56f7f268fa7d04f5a57e22b99d44cc0cf","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/macmace: Drop redundant MACH_IS_MAC test\n\nThe MACH_IS_MAC test is redundant here because the platform device\nwon't get registered unless MACH_IS_MAC.\nAdopt module_platform_driver() convention.\n\nCc: Geert Uytterhoeven <geert@linux-m68k.org>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/bc2592e56f7f268fa7d04f5a57e22b99d44cc0cf"},{"sha":"4f7aea32e4648ab8cad793c01937d1b5aad5811a","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"net/macmace: Fix and clean up log messages\n\nDon't log the unexpanded \"eth%d\" format string.\nLog the chip revision in the probe message (consistent with mace.c).\nDrop redundant debug messages for FIFO events recorded in the\ninterface statistics (also consistent with mace.c).\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/4f7aea32e4648ab8cad793c01937d1b5aad5811a"},{"sha":"7bb3dd1bf5aa885b70b758fd50fa4a1cecbcd767","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"m68k/mac: Fix SWIM memory resource end address\n\nThe resource size is 0x2000 == end - start + 1.\nTherefore end == start + 0x2000 - 1.\n\nCc: Laurent Vivier <lvivier@redhat.com>\nCc: stable@vger.kernel.org # v4.14+\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\nAcked-by: Laurent Vivier <lvivier@redhat.com>\nReviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/7bb3dd1bf5aa885b70b758fd50fa4a1cecbcd767"},{"sha":"c190c136eee7a85506c20dc819e0aa5b9b87c980","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"m68k/mac: Don't remap SWIM MMIO region\n\nFor reasons I don't understand, calling ioremap() then iounmap() on\nthe SWIM MMIO region causes a hang on 68030 (but not on 68040).\n\n~# modprobe swim_mod\nSWIM floppy driver Version 0.2 (2008-10-30)\nSWIM device not found !\nwatchdog: BUG: soft lockup - CPU#0 stuck for 23s! [modprobe:285]\nModules linked in: swim_mod(+)\nFormat 00  Vector: 0064  PC: 000075aa  Status: 2000    Not tainted\nORIG_D0: ffffffff  D0: d00c0000  A2: 007c2370  A1: 003f810c\nA0: 00040000  D5: d0096800  D4: d0097e00\nD3: 00000001  D2: 00000003  D1: 00000000\nNon-Maskable Interrupt\nModules linked in: swim_mod(+)\nPC: [<000075ba>] __iounmap+0x24/0x10e\nSR: 2000  SP: 007abc48  a2: 007c2370\nd0: d00c0000    d1: 000001a0    d2: 00000019    d3: 00000001\nd4: d0097e00    d5: d0096800    a0: 00040000    a1: 003f810c\nProcess modprobe (pid: 285, task=007c2370)\nFrame format=0\nStack from 007abc7c:\n        ffffffed 00000000 006a4060 004712e0 007abca0 000076ea d0080000 00080000\n        010bb4b8 007abcd8 010ba542 d0096000 00000000 00000000 00000001 010bb59c\n        00000000 007abf30 010bb4b8 0047760a 0047763c 00477612 00616540 007abcec\n        0020a91a 00477600 0047760a 010bb4cc 007abd18 002092f2 0047760a 00333b06\n        007abd5c 00000000 0047760a 010bb4cc 00404f90 004776b8 00000001 007abd38\n        00209446 010bb4cc 0047760a 010bb4cc 0020938e 0031f8be 00616540 007abd64\nCall Trace: [<000076ea>] iounmap+0x46/0x5a\n [<00080000>] shrink_page_list+0x7f6/0xe06\n [<010ba542>] swim_probe+0xe4/0x496 [swim_mod]\n [<0020a91a>] platform_drv_probe+0x20/0x5e\n [<002092f2>] driver_probe_device+0x21c/0x2b8\n [<00333b06>] mutex_lock+0x0/0x2e\n [<00209446>] __driver_attach+0xb8/0xce\n [<0020938e>] __driver_attach+0x0/0xce\n [<0031f8be>] klist_next+0x0/0xa0\n [<00207562>] bus_for_each_dev+0x74/0xba\n [<000344c0>] blocking_notifier_call_chain+0x0/0x20\n [<00333b06>] mutex_lock+0x0/0x2e\n [<00208e44>] driver_attach+0x1a/0x1e\n [<0020938e>] __driver_attach+0x0/0xce\n [<00207e26>] bus_add_driver+0x188/0x234\n [<000344c0>] blocking_notifier_call_chain+0x0/0x20\n [<00209894>] driver_register+0x58/0x104\n [<000344c0>] blocking_notifier_call_chain+0x0/0x20\n [<010bd000>] swim_init+0x0/0x2c [swim_mod]\n [<0020a7be>] __platform_driver_register+0x38/0x3c\n [<010bd028>] swim_init+0x28/0x2c [swim_mod]\n [<000020dc>] do_one_initcall+0x38/0x196\n [<000344c0>] blocking_notifier_call_chain+0x0/0x20\n [<003331cc>] mutex_unlock+0x0/0x3e\n [<00333b06>] mutex_lock+0x0/0x2e\n [<003331cc>] mutex_unlock+0x0/0x3e\n [<00333b06>] mutex_lock+0x0/0x2e\n [<003331cc>] mutex_unlock+0x0/0x3e\n [<00333b06>] mutex_lock+0x0/0x2e\n [<003331cc>] mutex_unlock+0x0/0x3e\n [<00333b06>] mutex_lock+0x0/0x2e\n [<00075008>] __free_pages+0x0/0x38\n [<000045c0>] mangle_kernel_stack+0x30/0xda\n [<000344c0>] blocking_notifier_call_chain+0x0/0x20\n [<003331cc>] mutex_unlock+0x0/0x3e\n [<00333b06>] mutex_lock+0x0/0x2e\n [<0005ced4>] do_init_module+0x42/0x266\n [<010bd000>] swim_init+0x0/0x2c [swim_mod]\n [<000344c0>] blocking_notifier_call_chain+0x0/0x20\n [<0005eda0>] load_module+0x1a30/0x1e70\n [<0000465d>] mangle_kernel_stack+0xcd/0xda\n [<00331c64>] __generic_copy_from_user+0x0/0x46\n [<0033256e>] _cond_resched+0x0/0x32\n [<00331b9c>] memset+0x0/0x98\n [<0033256e>] _cond_resched+0x0/0x32\n [<0005f25c>] SyS_init_module+0x7c/0x112\n [<00002000>] _start+0x0/0x8\n [<00002000>] _start+0x0/0x8\n [<00331c82>] __generic_copy_from_user+0x1e/0x46\n [<0005f2b2>] SyS_init_module+0xd2/0x112\n [<0000465d>] mangle_kernel_stack+0xcd/0xda\n [<00002b40>] syscall+0x8/0xc\n [<0000465d>] mangle_kernel_stack+0xcd/0xda\n [<0008c00c>] pcpu_balance_workfn+0xb2/0x40e\nCode: 2200 7419 e4a9 e589 2841 d9fc 0000 1000 <2414> 7203 c282 7602 b681 6600 0096 0242 fe00 0482 0000 0000 e9c0 11c3 ed89 2642\n\nThere's no need to call ioremap() for the SWIM address range, as it lies\nwithin the usual IO device region at 0x5000 0000, which has already been\nmapped by head.S.\n\nRemove the redundant ioremap() and iounmap() calls to fix the hang.\n\nCc: Laurent Vivier <lvivier@redhat.com>\nCc: stable@vger.kernel.org # v4.14+\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\nAcked-by: Laurent Vivier <lvivier@redhat.com>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/c190c136eee7a85506c20dc819e0aa5b9b87c980"},{"sha":"e9f3f02d97ec9025b4e8a464f41b101be159f794","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"block/swim: Fix array bounds check\n\nIn the floppy_find() function in swim.c is a call to\nget_disk(swd->unit[drive].disk). The actual parameter to this call\ncan be a NULL pointer when drive == swd->floppy_count. This causes\nan oops in get_disk().\n\nData read fault at 0x00000198 in Super Data (pc=0x1be5b6)\nBAD KERNEL BUSERR\nOops: 00000000\nModules linked in: swim_mod ipv6 mac8390\nPC: [<001be5b6>] get_disk+0xc/0x76\nSR: 2004  SP: 9a078bc1  a2: 0213ed90\nd0: 00000000    d1: 00000000    d2: 00000000    d3: 000000ff\nd4: 00000002    d5: 02983590    a0: 02332e00    a1: 022dfd64\nProcess dd (pid: 285, task=020ab25b)\nFrame format=B ssw=074d isc=4a88 isb=6732 daddr=00000198 dobuf=00000000\nbaddr=001be5bc dibuf=bfffffff ver=f\nStack from 022dfca4:\n        00000000 0203fc00 0213ed90 022dfcc0 02982936 00000000 00200000 022dfd08\n        0020f85a 00200000 022dfd64 02332e00 004040fc 00000014 001be77e 022dfd64\n        00334e4a 001be3f8 0800001d 022dfd64 01c04b60 01c04b70 022aba80 029828f8\n        02332e00 022dfd2c 001be7ac 0203fc00 00200000 022dfd64 02103a00 01c04b60\n        01c04b60 0200e400 022dfd68 000e191a 00200000 022dfd64 02103a00 0800001d\n        00000000 00000003 000b89de 00500000 02103a00 01c04b60 02103a08 01c04c2e\nCall Trace: [<02982936>] floppy_find+0x3e/0x4a [swim_mod]\n [<00200000>] uart_remove_one_port+0x1a2/0x260\n [<0020f85a>] kobj_lookup+0xde/0x132\n [<00200000>] uart_remove_one_port+0x1a2/0x260\n [<001be77e>] get_gendisk+0x0/0x130\n [<00334e4a>] mutex_lock+0x0/0x2e\n [<001be3f8>] disk_block_events+0x0/0x6c\n [<029828f8>] floppy_find+0x0/0x4a [swim_mod]\n [<001be7ac>] get_gendisk+0x2e/0x130\n [<00200000>] uart_remove_one_port+0x1a2/0x260\n [<000e191a>] __blkdev_get+0x32/0x45a\n [<00200000>] uart_remove_one_port+0x1a2/0x260\n [<000b89de>] complete_walk+0x0/0x8a\n [<000e1e22>] blkdev_get+0xe0/0x29a\n [<000e1fdc>] blkdev_open+0x0/0xb0\n [<000b89de>] complete_walk+0x0/0x8a\n [<000e1fdc>] blkdev_open+0x0/0xb0\n [<000e01cc>] bd_acquire+0x74/0x8a\n [<000e205c>] blkdev_open+0x80/0xb0\n [<000e1fdc>] blkdev_open+0x0/0xb0\n [<000abf24>] do_dentry_open+0x1a4/0x322\n [<00020000>] __do_proc_douintvec+0x22/0x27e\n [<000b89de>] complete_walk+0x0/0x8a\n [<000baa62>] link_path_walk+0x0/0x48e\n [<000ba3f8>] inode_permission+0x20/0x54\n [<000ac0e4>] vfs_open+0x42/0x78\n [<000bc372>] path_openat+0x2b2/0xeaa\n [<000bc0c0>] path_openat+0x0/0xeaa\n [<0004463e>] __irq_wake_thread+0x0/0x4e\n [<0003a45a>] task_tick_fair+0x18/0xc8\n [<000bd00a>] do_filp_open+0xa0/0xea\n [<000abae0>] do_sys_open+0x11a/0x1ee\n [<00020000>] __do_proc_douintvec+0x22/0x27e\n [<000abbf4>] SyS_open+0x1e/0x22\n [<00020000>] __do_proc_douintvec+0x22/0x27e\n [<00002b40>] syscall+0x8/0xc\n [<00020000>] __do_proc_douintvec+0x22/0x27e\n [<0000c00b>] dyadic+0x1/0x28\nCode: 4e5e 4e75 4e56 fffc 2f0b 2f02 266e 0008 <206b> 0198 4a88 6732 2428 002c 661e 486b 0058 4eb9 0032 0b96 588f 4a88 672c 2008\nDisabling lock debugging due to kernel taint\n\nFix the array index bounds check to avoid this.\n\nCc: Laurent Vivier <lvivier@redhat.com>\nCc: Jens Axboe <axboe@kernel.dk>\nCc: stable@vger.kernel.org # v4.14+\nFixes: 8852ecd97488 (\"[PATCH] m68k: mac - Add SWIM floppy support\")\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\nAcked-by: Laurent Vivier <lvivier@redhat.com>\nReviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/e9f3f02d97ec9025b4e8a464f41b101be159f794"},{"sha":"d12081ef93fc78c08e0ad5fb90cc23f62b50cffe","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"block/swim: Remove extra put_disk() call from error path\n\nCc: Laurent Vivier <lvivier@redhat.com>\nCc: Jens Axboe <axboe@kernel.dk>\nCc: stable@vger.kernel.org # v4.14+\nFixes: 103db8b2dfa5 (\"[PATCH] swim: stop sharing request queue across multiple gendisks\")\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\nAcked-by: Laurent Vivier <lvivier@redhat.com>\nReviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/d12081ef93fc78c08e0ad5fb90cc23f62b50cffe"},{"sha":"15f86728351e4dbca405a4f959e15a8619185430","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"block/swim: Don't log an error message for an invalid ioctl\n\nThe 'eject' shell command may send various different ioctl commands.\nThis leads to error messages on the console even though the FDEJECT\nioctl succeeds.\n\n~# eject floppy\nSWIM floppy_ioctl: unknown cmd 21257\nSWIM floppy_ioctl: unknown cmd 1\n\nDon't log an error message for an invalid ioctl, just do as the\nswim3 driver does and return -ENOTTY.\n\nCc: Laurent Vivier <lvivier@redhat.com>\nCc: Jens Axboe <axboe@kernel.dk>\nCc: stable@vger.kernel.org # v4.14+\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\nAcked-by: Laurent Vivier <lvivier@redhat.com>\nReviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/15f86728351e4dbca405a4f959e15a8619185430"},{"sha":"99cd93932e4e01bf1ddcd5a79f2f6981543f5dae","author":{"name":"Finn Thain","email":"94052abb058aed443995dc4f8d236e022112765d@telegraphics.com.au"},"message":"block/swim: Rename macros to avoid inconsistent inverted logic\n\nThe Sony drive status bits use active-low logic. The swim_readbit()\nfunction converts that to 'C' logic for readability. Hence, the\nsense of the names of the status bit macros should not be inverted.\n\nMostly they are correct. However, the TWOMEG_DRIVE, MFM_MODE and\nTWOMEG_MEDIA macros have inverted sense (like MkLinux). Fix this\ninconsistency and make the following patches less confusing.\n\nThe same problem affects swim3.c so fix that too.\n\nNo functional change.\n\nThe FDHD drive status bits are documented in sonydriv.cpp from MAME\nand in swimiii.h from MkLinux.\n\nCc: Laurent Vivier <lvivier@redhat.com>\nCc: Benjamin Herrenschmidt <benh@kernel.crashing.org>\nCc: linuxppc-dev@lists.ozlabs.org\nCc: Jens Axboe <axboe@kernel.dk>\nCc: stable@vger.kernel.org # v4.14+\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\nAcked-by: Laurent Vivier <lvivier@redhat.com>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/99cd93932e4e01bf1ddcd5a79f2f6981543f5dae"}]}
{"actor":{"display_login":"fthain"}}