{"action":"created","comment":{"url":"https://api.github.com/repos/WeTransfer/WeScan/pulls/comments/225066298","pull_request_review_id":164583306,"id":225066298,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTA2NjI5OA==","diff_hunk":"@@ -18,21 +18,21 @@ enum ResourceImage: String {\n \n final class ImageFeatureTestHelpers: NSObject {\n     \n-    static func getRectangleFeatures(from resourceImage: ResourceImage, withCount count: Int) -> [CIRectangleFeature] {\n-        var rectangleFeatures = [CIRectangleFeature]()\n+    static func getRectangleFeatures(from resourceImage: ResourceImage, withCount count: Int) -> [Quadrilateral] {\n+        var rectangleFeatures = [Quadrilateral]()\n+      \n         for _ in 0 ..< count {\n             rectangleFeatures.append(ImageFeatureTestHelpers.getRectangleFeature(from: resourceImage))\n         }\n         \n         return rectangleFeatures\n     }\n     \n-    static func getRectangleFeature(from resourceImage: ResourceImage) -> CIRectangleFeature {\n+    static func getRectangleFeature(from resourceImage: ResourceImage) -> Quadrilateral {\n         let image = UIImage(named: resourceImage.rawValue, in: Bundle(for: ImageFeatureTestHelpers.self), compatibleWith: nil)\n         let ciImage = CIImage(image: image!)!\n-        let rectangleFeature = RectangleDetector.rectangle(forImage: ciImage)\n \n-        return rectangleFeature!\n+        return CIRectangleDetector.rectangle(forImage: ciImage)!","path":"WeScanTests/ImageFeatureTestHelpers.swift","position":23,"original_position":23,"commit_id":"e52ee5a3e3fd7969ff042cd59a5d4541127d1869","original_commit_id":"e52ee5a3e3fd7969ff042cd59a5d4541127d1869","user":{"login":"WeTransferOSSBot","id":30373618,"node_id":"MDQ6VXNlcjMwMzczNjE4","avatar_url":"https://avatars3.githubusercontent.com/u/30373618?v=4","gravatar_id":"","url":"https://api.github.com/users/WeTransferOSSBot","html_url":"https://github.com/WeTransferOSSBot","followers_url":"https://api.github.com/users/WeTransferOSSBot/followers","following_url":"https://api.github.com/users/WeTransferOSSBot/following{/other_user}","gists_url":"https://api.github.com/users/WeTransferOSSBot/gists{/gist_id}","starred_url":"https://api.github.com/users/WeTransferOSSBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeTransferOSSBot/subscriptions","organizations_url":"https://api.github.com/users/WeTransferOSSBot/orgs","repos_url":"https://api.github.com/users/WeTransferOSSBot/repos","events_url":"https://api.github.com/users/WeTransferOSSBot/events{/privacy}","received_events_url":"https://api.github.com/users/WeTransferOSSBot/received_events","type":"User","site_admin":false},"body":"<table data-meta=\"generated_by_danger\">\n  <tbody>\n    <tr>\n      <td>:no_entry_sign:</td>\n      <td width=\"100%\" data-sticky=\"false\"><span data-href=\"https://github.com/WeTransfer/WeScan/blob/e52ee5a3e3fd7969ff042cd59a5d4541127d1869/WeScanTests/ImageFeatureTestHelpers.swift#L35\"></span>Force unwrapping should be avoided.</td>\n    </tr>\n  </tbody>\n</table>\n\n\n\n","created_at":"2018-10-15T07:48:36Z","updated_at":"2018-10-15T07:48:37Z","html_url":"https://github.com/WeTransfer/WeScan/pull/41#discussion_r225066298","pull_request_url":"https://api.github.com/repos/WeTransfer/WeScan/pulls/41","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/WeTransfer/WeScan/pulls/comments/225066298"},"html":{"href":"https://github.com/WeTransfer/WeScan/pull/41#discussion_r225066298"},"pull_request":{"href":"https://api.github.com/repos/WeTransfer/WeScan/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/WeTransfer/WeScan/pulls/41","id":204358304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MzU4MzA0","html_url":"https://github.com/WeTransfer/WeScan/pull/41","diff_url":"https://github.com/WeTransfer/WeScan/pull/41.diff","patch_url":"https://github.com/WeTransfer/WeScan/pull/41.patch","issue_url":"https://api.github.com/repos/WeTransfer/WeScan/issues/41","number":41,"state":"open","locked":false,"title":"Add auto rotate, auto scan, and Vision support","user":{"login":"justJS","id":19729335,"node_id":"MDQ6VXNlcjE5NzI5MzM1","avatar_url":"https://avatars1.githubusercontent.com/u/19729335?v=4","gravatar_id":"","url":"https://api.github.com/users/justJS","html_url":"https://github.com/justJS","followers_url":"https://api.github.com/users/justJS/followers","following_url":"https://api.github.com/users/justJS/following{/other_user}","gists_url":"https://api.github.com/users/justJS/gists{/gist_id}","starred_url":"https://api.github.com/users/justJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justJS/subscriptions","organizations_url":"https://api.github.com/users/justJS/orgs","repos_url":"https://api.github.com/users/justJS/repos","events_url":"https://api.github.com/users/justJS/events{/privacy}","received_events_url":"https://api.github.com/users/justJS/received_events","type":"User","site_admin":false},"body":"This pull request adds support for auto rotating images to Portrait on iOS 10 and above, and uses Vision instead of CoreImage to detect rectangles on iOS 11 and above. It also adds iPad support to the sample project.\r\n\r\nAuto rotation, auto scanning, and Vision support have been fully tested by me, but I'd appreciate any feedback and improvements.","created_at":"2018-07-27T08:03:37Z","updated_at":"2018-10-15T07:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edb49e72790ff9c8edd480ab33b8cbd60161e055","assignee":null,"assignees":[],"requested_reviewers":[{"login":"renssies","id":830094,"node_id":"MDQ6VXNlcjgzMDA5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/830094?v=4","gravatar_id":"","url":"https://api.github.com/users/renssies","html_url":"https://github.com/renssies","followers_url":"https://api.github.com/users/renssies/followers","following_url":"https://api.github.com/users/renssies/following{/other_user}","gists_url":"https://api.github.com/users/renssies/gists{/gist_id}","starred_url":"https://api.github.com/users/renssies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renssies/subscriptions","organizations_url":"https://api.github.com/users/renssies/orgs","repos_url":"https://api.github.com/users/renssies/repos","events_url":"https://api.github.com/users/renssies/events{/privacy}","received_events_url":"https://api.github.com/users/renssies/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WeTransfer/WeScan/pulls/41/commits","review_comments_url":"https://api.github.com/repos/WeTransfer/WeScan/pulls/41/comments","review_comment_url":"https://api.github.com/repos/WeTransfer/WeScan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WeTransfer/WeScan/issues/41/comments","statuses_url":"https://api.github.com/repos/WeTransfer/WeScan/statuses/e52ee5a3e3fd7969ff042cd59a5d4541127d1869","head":{"label":"justJS:develop","ref":"develop","sha":"e52ee5a3e3fd7969ff042cd59a5d4541127d1869","user":{"login":"justJS","id":19729335,"node_id":"MDQ6VXNlcjE5NzI5MzM1","avatar_url":"https://avatars1.githubusercontent.com/u/19729335?v=4","gravatar_id":"","url":"https://api.github.com/users/justJS","html_url":"https://github.com/justJS","followers_url":"https://api.github.com/users/justJS/followers","following_url":"https://api.github.com/users/justJS/following{/other_user}","gists_url":"https://api.github.com/users/justJS/gists{/gist_id}","starred_url":"https://api.github.com/users/justJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justJS/subscriptions","organizations_url":"https://api.github.com/users/justJS/orgs","repos_url":"https://api.github.com/users/justJS/repos","events_url":"https://api.github.com/users/justJS/events{/privacy}","received_events_url":"https://api.github.com/users/justJS/received_events","type":"User","site_admin":false},"repo":{"id":142546894,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI1NDY4OTQ=","name":"WeScan","full_name":"justJS/WeScan","private":false,"owner":{"login":"justJS","id":19729335,"node_id":"MDQ6VXNlcjE5NzI5MzM1","avatar_url":"https://avatars1.githubusercontent.com/u/19729335?v=4","gravatar_id":"","url":"https://api.github.com/users/justJS","html_url":"https://github.com/justJS","followers_url":"https://api.github.com/users/justJS/followers","following_url":"https://api.github.com/users/justJS/following{/other_user}","gists_url":"https://api.github.com/users/justJS/gists{/gist_id}","starred_url":"https://api.github.com/users/justJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justJS/subscriptions","organizations_url":"https://api.github.com/users/justJS/orgs","repos_url":"https://api.github.com/users/justJS/repos","events_url":"https://api.github.com/users/justJS/events{/privacy}","received_events_url":"https://api.github.com/users/justJS/received_events","type":"User","site_admin":false},"html_url":"https://github.com/justJS/WeScan","description":"This will be PR'ed AFTER #41 goes in","fork":true,"url":"https://api.github.com/repos/justJS/WeScan","forks_url":"https://api.github.com/repos/justJS/WeScan/forks","keys_url":"https://api.github.com/repos/justJS/WeScan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justJS/WeScan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justJS/WeScan/teams","hooks_url":"https://api.github.com/repos/justJS/WeScan/hooks","issue_events_url":"https://api.github.com/repos/justJS/WeScan/issues/events{/number}","events_url":"https://api.github.com/repos/justJS/WeScan/events","assignees_url":"https://api.github.com/repos/justJS/WeScan/assignees{/user}","branches_url":"https://api.github.com/repos/justJS/WeScan/branches{/branch}","tags_url":"https://api.github.com/repos/justJS/WeScan/tags","blobs_url":"https://api.github.com/repos/justJS/WeScan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justJS/WeScan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justJS/WeScan/git/refs{/sha}","trees_url":"https://api.github.com/repos/justJS/WeScan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justJS/WeScan/statuses/{sha}","languages_url":"https://api.github.com/repos/justJS/WeScan/languages","stargazers_url":"https://api.github.com/repos/justJS/WeScan/stargazers","contributors_url":"https://api.github.com/repos/justJS/WeScan/contributors","subscribers_url":"https://api.github.com/repos/justJS/WeScan/subscribers","subscription_url":"https://api.github.com/repos/justJS/WeScan/subscription","commits_url":"https://api.github.com/repos/justJS/WeScan/commits{/sha}","git_commits_url":"https://api.github.com/repos/justJS/WeScan/git/commits{/sha}","comments_url":"https://api.github.com/repos/justJS/WeScan/comments{/number}","issue_comment_url":"https://api.github.com/repos/justJS/WeScan/issues/comments{/number}","contents_url":"https://api.github.com/repos/justJS/WeScan/contents/{+path}","compare_url":"https://api.github.com/repos/justJS/WeScan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justJS/WeScan/merges","archive_url":"https://api.github.com/repos/justJS/WeScan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justJS/WeScan/downloads","issues_url":"https://api.github.com/repos/justJS/WeScan/issues{/number}","pulls_url":"https://api.github.com/repos/justJS/WeScan/pulls{/number}","milestones_url":"https://api.github.com/repos/justJS/WeScan/milestones{/number}","notifications_url":"https://api.github.com/repos/justJS/WeScan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justJS/WeScan/labels{/name}","releases_url":"https://api.github.com/repos/justJS/WeScan/releases{/id}","deployments_url":"https://api.github.com/repos/justJS/WeScan/deployments","created_at":"2018-07-27T07:58:31Z","updated_at":"2018-10-10T04:57:11Z","pushed_at":"2018-10-11T10:49:43Z","git_url":"git://github.com/justJS/WeScan.git","ssh_url":"git@github.com:justJS/WeScan.git","clone_url":"https://github.com/justJS/WeScan.git","svn_url":"https://github.com/justJS/WeScan","homepage":"","size":4676,"stargazers_count":3,"watchers_count":3,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"WeTransfer:develop","ref":"develop","sha":"88e665470ad25f3f16d2f6c18d16919a0642824d","user":{"login":"WeTransfer","id":14807662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODA3NjYy","avatar_url":"https://avatars3.githubusercontent.com/u/14807662?v=4","gravatar_id":"","url":"https://api.github.com/users/WeTransfer","html_url":"https://github.com/WeTransfer","followers_url":"https://api.github.com/users/WeTransfer/followers","following_url":"https://api.github.com/users/WeTransfer/following{/other_user}","gists_url":"https://api.github.com/users/WeTransfer/gists{/gist_id}","starred_url":"https://api.github.com/users/WeTransfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeTransfer/subscriptions","organizations_url":"https://api.github.com/users/WeTransfer/orgs","repos_url":"https://api.github.com/users/WeTransfer/repos","events_url":"https://api.github.com/users/WeTransfer/events{/privacy}","received_events_url":"https://api.github.com/users/WeTransfer/received_events","type":"Organization","site_admin":false},"repo":{"id":123019725,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwMTk3MjU=","name":"WeScan","full_name":"WeTransfer/WeScan","private":false,"owner":{"login":"WeTransfer","id":14807662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODA3NjYy","avatar_url":"https://avatars3.githubusercontent.com/u/14807662?v=4","gravatar_id":"","url":"https://api.github.com/users/WeTransfer","html_url":"https://github.com/WeTransfer","followers_url":"https://api.github.com/users/WeTransfer/followers","following_url":"https://api.github.com/users/WeTransfer/following{/other_user}","gists_url":"https://api.github.com/users/WeTransfer/gists{/gist_id}","starred_url":"https://api.github.com/users/WeTransfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeTransfer/subscriptions","organizations_url":"https://api.github.com/users/WeTransfer/orgs","repos_url":"https://api.github.com/users/WeTransfer/repos","events_url":"https://api.github.com/users/WeTransfer/events{/privacy}","received_events_url":"https://api.github.com/users/WeTransfer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WeTransfer/WeScan","description":"Document Scanning Made Easy for iOS","fork":false,"url":"https://api.github.com/repos/WeTransfer/WeScan","forks_url":"https://api.github.com/repos/WeTransfer/WeScan/forks","keys_url":"https://api.github.com/repos/WeTransfer/WeScan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WeTransfer/WeScan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WeTransfer/WeScan/teams","hooks_url":"https://api.github.com/repos/WeTransfer/WeScan/hooks","issue_events_url":"https://api.github.com/repos/WeTransfer/WeScan/issues/events{/number}","events_url":"https://api.github.com/repos/WeTransfer/WeScan/events","assignees_url":"https://api.github.com/repos/WeTransfer/WeScan/assignees{/user}","branches_url":"https://api.github.com/repos/WeTransfer/WeScan/branches{/branch}","tags_url":"https://api.github.com/repos/WeTransfer/WeScan/tags","blobs_url":"https://api.github.com/repos/WeTransfer/WeScan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WeTransfer/WeScan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WeTransfer/WeScan/git/refs{/sha}","trees_url":"https://api.github.com/repos/WeTransfer/WeScan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WeTransfer/WeScan/statuses/{sha}","languages_url":"https://api.github.com/repos/WeTransfer/WeScan/languages","stargazers_url":"https://api.github.com/repos/WeTransfer/WeScan/stargazers","contributors_url":"https://api.github.com/repos/WeTransfer/WeScan/contributors","subscribers_url":"https://api.github.com/repos/WeTransfer/WeScan/subscribers","subscription_url":"https://api.github.com/repos/WeTransfer/WeScan/subscription","commits_url":"https://api.github.com/repos/WeTransfer/WeScan/commits{/sha}","git_commits_url":"https://api.github.com/repos/WeTransfer/WeScan/git/commits{/sha}","comments_url":"https://api.github.com/repos/WeTransfer/WeScan/comments{/number}","issue_comment_url":"https://api.github.com/repos/WeTransfer/WeScan/issues/comments{/number}","contents_url":"https://api.github.com/repos/WeTransfer/WeScan/contents/{+path}","compare_url":"https://api.github.com/repos/WeTransfer/WeScan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WeTransfer/WeScan/merges","archive_url":"https://api.github.com/repos/WeTransfer/WeScan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WeTransfer/WeScan/downloads","issues_url":"https://api.github.com/repos/WeTransfer/WeScan/issues{/number}","pulls_url":"https://api.github.com/repos/WeTransfer/WeScan/pulls{/number}","milestones_url":"https://api.github.com/repos/WeTransfer/WeScan/milestones{/number}","notifications_url":"https://api.github.com/repos/WeTransfer/WeScan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WeTransfer/WeScan/labels{/name}","releases_url":"https://api.github.com/repos/WeTransfer/WeScan/releases{/id}","deployments_url":"https://api.github.com/repos/WeTransfer/WeScan/deployments","created_at":"2018-02-26T19:30:05Z","updated_at":"2018-10-15T05:23:19Z","pushed_at":"2018-10-11T00:38:39Z","git_url":"git://github.com/WeTransfer/WeScan.git","ssh_url":"git@github.com:WeTransfer/WeScan.git","clone_url":"https://github.com/WeTransfer/WeScan.git","svn_url":"https://github.com/WeTransfer/WeScan","homepage":"","size":4383,"stargazers_count":782,"watchers_count":782,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":58,"open_issues":24,"watchers":782,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/WeTransfer/WeScan/pulls/41"},"html":{"href":"https://github.com/WeTransfer/WeScan/pull/41"},"issue":{"href":"https://api.github.com/repos/WeTransfer/WeScan/issues/41"},"comments":{"href":"https://api.github.com/repos/WeTransfer/WeScan/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/WeTransfer/WeScan/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/WeTransfer/WeScan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WeTransfer/WeScan/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/WeTransfer/WeScan/statuses/e52ee5a3e3fd7969ff042cd59a5d4541127d1869"}},"author_association":"NONE"}}
{"actor":{"display_login":"WeTransferOSSBot"}}