{"push_id":2712860518,"size":67,"distinct_size":67,"ref":"refs/heads/master","head":"9295f39ac70ba10b68f55024f03ce6327d5775ce","before":"cc62a06eb541a147d88ffae84ab43cd48c18adc5","commits":[{"sha":"42b1a9c13f3e003c0a0037e737ea2d4d3c823567","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Cherry-pick from next: Travis CI: Fix fred to compile\n\nby using the new Gradle builder instead of the removed Ant one.\n\nThis is a squashed cherry-pick of the commits starting at\n\t40e77e933cee0d90d30372586912e6f6f0c81d02\nup to\n\t00364b2aec3bf9347d096fa5ecd82e2f9779bbc9\nof branch next.\n\nI.e. it is the changes of branch issue-0006929-fix-travis except for the\nlast commit which amends the changelog. That commit will follow this one\nas a single cherry-pick.\n\nThe commits have been squashed because they will be merged along\nwith branch next after this branch anyway so the full history can\nalready be seen at the original commits then.\n\nWe have to cherry-pick their changes instead of merging them\nbecause branch next contains preceding changes which are not ready for\nrelease yet, but we need to release build0020 soon in order to make WoT\ncompatible with the upcoming removal of the db4o library from fred's\nfreenet-ext.jar.\n\nFixes https://bugs.freenetproject.org/view.php?id=6929\n= \"Travis CI builds fail due to changes at fred\"","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/42b1a9c13f3e003c0a0037e737ea2d4d3c823567"},{"sha":"deb01cb71c9ddfa2a6af2a0e5382820f073fa932","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Changelog: Add this branch\n\nCherry-pick of commit e3280ef603705708d0f4547ed538f763a5a778ac of branch\nnext.\n\nThe increase of the 0.4.5 version number has been removed because\nbuild0020 will not contain functional changes. It's only subject will be\nto fix Travis CI and to prepare WoT for the removal of db4o from\nfreenet-ext.jar","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/deb01cb71c9ddfa2a6af2a0e5382820f073fa932"},{"sha":"da7930b999d47b75baaa8d8ba5b2aad76fd58759","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Merge branch 'fix-travis_rebased' into build0020-development\n\nSee the merged commit 42b1a9c13f3e003c0a0037e737ea2d4d3c823567 for where\nthis comes from and what it's for.","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/da7930b999d47b75baaa8d8ba5b2aad76fd58759"},{"sha":"425e7827cb37d3b2ca7992c7d3d60fc800b8fe13","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Travis CI: Test with more recent Java versions\n\nJava 10 isn't available yet:\nhttps://github.com/travis-ci/travis-ci/issues/9368","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/425e7827cb37d3b2ca7992c7d3d60fc800b8fe13"},{"sha":"210f106d6b265c8e26d2f5a3c32723019b01f5b4","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Travis CI: Don't hardcode versions of fred libs; simplify build script\n\nfred nowadays supports copying the dependencies to the build/output/\ndirectory so we don't have to copy them from Gradle's intestines:\nhttps://github.com/freenet/fred/commit/e5a2555bde56be8f4eee7681faedab0f634c6aad\n\nThe whole logic of the if statements can be replaced by:\n- using \"-p\" to mkdir, which makes it not fail if the directories exist\n  already.\n- using \"()\" subshells to make the change of working directory not\n  persistent.\n- using the \"-f\" parameter of ln which tells it to replace the targets\n  if they already exist.\n\nInstead of using \"jna*.jar\" the jna JAR has to be referenced by\n\"jna-?.?.?.jar\" because there also is a \"jna-platform*.jar\" nowadays\n(which the following commits will add to Travis' and WoT's build.xml).","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/210f106d6b265c8e26d2f5a3c32723019b01f5b4"},{"sha":"c0abc0c20eaff863525823a5920e26b257f836b2","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Ant/Travis CI: Add new fred dependency\n\nAdded by this fred commit:\nhttps://github.com/freenet/fred/commit/94c367e8954e002be57620861516ca8927e05c09","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/c0abc0c20eaff863525823a5920e26b257f836b2"},{"sha":"afcfc992fbdde648c5f3aa1e2f0a01557c8dc936","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Travis CI: Defensive programming; simplify documentation\n\nCleaning the build directory might prevent weird problems such as code\nof deleted classes persisting due to the Travis CI cache:\nhttps://stackoverflow.com/questions/29028748/why-run-gradle-clean","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/afcfc992fbdde648c5f3aa1e2f0a01557c8dc936"},{"sha":"9571d6cbdac1039a1a80403a434b1cdf4b5bbab9","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Travis CI: Use Gradle wrapper to fix failure on Oracle Java 9\n\nGradle would fail with:\n    \"Could not determine java version from '9.0.1'.\"\n\nThat's because the Gradle which Travis CI deploys is too old for Java 9:\nhttps://github.com/travis-ci/travis-ci/issues/8975\n(Stangely it did work with Java 9 some time ago when I filed the fred\nPR we recently discussed, I don't know what they changed since.)\n\nThe Gradle wrapper will download the latest Gradle and thereby fix this.\n\nIn turn OpenJDK 7 is disabled because it doesn't work with the wrapper\nanymore.\n(I do still think it's not good that we don't test on Java 7 as that's\nwhat we officially require for fred and what Ubuntu 14.04 deploys;\nhowever testing on newer versions should be preferred to testing on\nolder versions.\nThat conflict didn't exist when I filed the aforementioned fred PR to\nsupport Java 7. Now that Java 7 is in conflict with 9 I agree that it's\nbetter to prefer testing with 9.)","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/9571d6cbdac1039a1a80403a434b1cdf4b5bbab9"},{"sha":"68ca711209034b6ebf7369a250475b7e0b5f954a","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Travis CI: Fix freenet.jar not containing class Version\n\nWould fail with:\n    [javac] [...]/WebOfTrust.java:798: error: cannot find symbol\n    [javac] \t\tif(freenet.node.Version.buildNumber() < 1457)\n\nE.g.: https://travis-ci.org/xor-freenet/plugin-WebOfTrust/jobs/378244106","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/68ca711209034b6ebf7369a250475b7e0b5f954a"},{"sha":"6f77ef4dc4f658a3780bb64d4f95ae3e305616c3","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Travis CI: Fix \"sudo: unable to resolve host freenet-plugin-WebOfTrust\"\n\nThe link cited in the nearby line from which the \"hostname\" workaround\ncame did mention configuring the hosts file like this as well:\nhttps://github.com/travis-ci/travis-ci/issues/5227#issuecomment-165131913\n\nI probably forgot to apply that part when I applied the workaround\ninitially.","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/6f77ef4dc4f658a3780bb64d4f95ae3e305616c3"},{"sha":"f3d4225d1a048173fcaa12ac37cf754df4e7467a","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Travis CI: Tweak performance\n\nSee:\nhttps://docs.travis-ci.com/user/reference/trusty/#Container-based-with-sudo%3A-false\n\nAlso fixes the documentation about Trusty to be placed at the correct\nline.","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/f3d4225d1a048173fcaa12ac37cf754df4e7467a"},{"sha":"e87e9296d4123c994eb2c197cde1c182e3416352","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Merge branch 'travis-tweaks' into build0020-development\n\nImproves code quality of Travis CI script:\n- makes it independent of changes to the versions of fred dependencies\n- speeds up builds a bit by allowing Travis to use Docker instead of VMs\n  (which is established by not requiring root anymore)\n- tests with more recent Java versions","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/e87e9296d4123c994eb2c197cde1c182e3416352"},{"sha":"31a7998cdc68e00a6fd7b33d9a006d77aba8dd68","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"AbstractJUnit3BaseTest.testClone(): Documentation","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/31a7998cdc68e00a6fd7b33d9a006d77aba8dd68"},{"sha":"2cef194d0f2df0fd21052442748c65d5d566c9f4","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"AbstractJUnit3BaseTest.testClone(): Add debug code for investigating\nJava 9 failure\n\nFor https://bugs.freenetproject.org/view.php?id=7016\n\nI need to run this on Travis CI because I cannot reproduce this locally\ndue to lack of Java 9 at hand so I'm pushing the debug code to the\nrepository.\nIt will anyway be helpful to have removal of this be part of the commit\nwhich fixes the bug because adding the output to the commit message will\nnicely visualize what's the issue here.","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/2cef194d0f2df0fd21052442748c65d5d566c9f4"},{"sha":"91025151f58161394c8d10f046192eb3ea0b587b","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"IdentityTest.testClone(): Fix failure on Java 9\n\nFixes:\n> junit.framework.AssertionFailedError: static final boolean plugins.WebOfTrust.Persistent.$assertionsDisabled expected not same\n>     at plugins.WebOfTrust.AbstractJUnit3BaseTest.testClone(AbstractJUnit3BaseTest.java:141)\n>     at plugins.WebOfTrust.IdentityTest.testClone(IdentityTest.java:88)\n\nOutput of the hereby removed debug code on Java 7:\n>  For debugging why assertNotSame() fails for $assertionsDisabled:\n>  original is Boolean: true\n>  clone is Boolean:    true\n>  ==:       false\n>  equals(): true\n>  original hash:      2099400080\n>  clone hash:         1460824350\n>  Boolean.FALSE hash: 2041797946\n>  Boolean.TRUE hash:  1856883009\n\nOn Java 9:\n>  For debugging why assertNotSame() fails for $assertionsDisabled:\n>  original is Boolean: true\n>  clone is Boolean:    true\n>  ==:       true\n>  equals(): true\n>  original hash:      224468764\n>  clone hash:         224468764\n>  Boolean.FALSE hash: 224468764\n>  Boolean.TRUE hash:  1328349514\n\nAs you can see, the trigger of our bug is that Java 9's Field.get() was\nchanged to return the static constant Boolean.FALSE for the value\n\"false\" of boolean fields instead of returning a fresh object of class\nBoolean for every call.\n\nThe fix is to disable the containing if() for primitive types such as\nboolean, int, etc. It didn't make sense to execute it for those anyway\nas the point of the if() is to check whether member objects are\nwrongly re-used by clone() instead of being cloned as well\n- but primitive types are not objects.\n\nAdditionally code is added to ignore static fields as well as those\nare the definition of intentional re-use.","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/91025151f58161394c8d10f046192eb3ea0b587b"},{"sha":"0532d6df9206a2ccbf70d64a09edffa03a6e284d","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"AbstractJUnit3BaseTest.testClone(): Indent","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/0532d6df9206a2ccbf70d64a09edffa03a6e284d"},{"sha":"6dc2371c3fef116531c0a3ffccc5d2475077d547","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Changelog: Add this branch","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/6dc2371c3fef116531c0a3ffccc5d2475077d547"},{"sha":"3e09c35cc033ef824b8dc31504499605db26fb25","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"AbstractJUnit3BaseTest: Organize imports","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/3e09c35cc033ef824b8dc31504499605db26fb25"},{"sha":"650df2dc87584e59b72c0a08ab99e81786a37459","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"Merge branch 'issue-0007016-fix-java9-test-failure' into\nbuild0020-development\n\nFixes https://bugs.freenetproject.org/view.php?id=7016\n= \"Fix unit test failure on Java 9\"","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/650df2dc87584e59b72c0a08ab99e81786a37459"},{"sha":"4329fe5601759618e8d819e8120c3f33eca0bc41","author":{"name":"xor-freenet","email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org"},"message":"XMLTransformerTest: Add workaround for isue 0007017","distinct":true,"url":"https://api.github.com/repos/ArneBab/plugin-WoT-staging/commits/4329fe5601759618e8d819e8120c3f33eca0bc41"}]}
{"actor":{"display_login":"ArneBab"}}