{"action":"opened","issue":{"url":"https://api.github.com/repos/wcannon/salt-check/issues/23","repository_url":"https://api.github.com/repos/wcannon/salt-check","labels_url":"https://api.github.com/repos/wcannon/salt-check/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/wcannon/salt-check/issues/23/comments","events_url":"https://api.github.com/repos/wcannon/salt-check/issues/23/events","html_url":"https://github.com/wcannon/salt-check/issues/23","id":315688631,"number":23,"title":"Testing examples in 2017.7.5","user":{"login":"justin-sunayu","id":33045995,"avatar_url":"https://avatars2.githubusercontent.com/u/33045995?v=4","gravatar_id":"","url":"https://api.github.com/users/justin-sunayu","html_url":"https://github.com/justin-sunayu","followers_url":"https://api.github.com/users/justin-sunayu/followers","following_url":"https://api.github.com/users/justin-sunayu/following{/other_user}","gists_url":"https://api.github.com/users/justin-sunayu/gists{/gist_id}","starred_url":"https://api.github.com/users/justin-sunayu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justin-sunayu/subscriptions","organizations_url":"https://api.github.com/users/justin-sunayu/orgs","repos_url":"https://api.github.com/users/justin-sunayu/repos","events_url":"https://api.github.com/users/justin-sunayu/events{/privacy}","received_events_url":"https://api.github.com/users/justin-sunayu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-19T00:39:58Z","updated_at":"2018-04-19T00:39:58Z","closed_at":null,"author_association":"NONE","body":"Here is my salt version info:\r\n\r\n```\r\n[root@sm saltcheck-tests]# salt --versions\r\nSalt Version:\r\n           Salt: 2017.7.5\r\n\r\nDependency Versions:\r\n           cffi: 1.11.2\r\n       cherrypy: unknown\r\n       dateutil: Not Installed\r\n      docker-py: 2.6.1\r\n          gitdb: Not Installed\r\n      gitpython: Not Installed\r\n          ioflo: Not Installed\r\n         Jinja2: 2.8.1\r\n        libgit2: Not Installed\r\n        libnacl: Not Installed\r\n       M2Crypto: 0.28.2\r\n           Mako: Not Installed\r\n   msgpack-pure: Not Installed\r\n msgpack-python: 0.5.1\r\n   mysql-python: Not Installed\r\n      pycparser: 2.14\r\n       pycrypto: 2.6.1\r\n   pycryptodome: 3.4.3\r\n         pygit2: Not Installed\r\n         Python: 2.7.5 (default, Aug  4 2017, 00:39:18)\r\n   python-gnupg: Not Installed\r\n         PyYAML: 3.12\r\n          PyZMQ: 15.3.0\r\n           RAET: Not Installed\r\n          smmap: Not Installed\r\n        timelib: Not Installed\r\n        Tornado: 4.4.2\r\n            ZMQ: 4.1.4\r\n\r\nSystem Versions:\r\n           dist: centos 7.4.1708 Core\r\n         locale: UTF-8\r\n        machine: x86_64\r\n        release: 3.10.0-693.21.1.el7.x86_64\r\n         system: Linux\r\n        version: CentOS Linux 7.4.1708 Core\r\n```\r\n\r\nI am trying your examples in https://github.com/wcannon/salt-check/tree/master/examples\r\n\r\nA couple things:\r\n- test_1 does not seem to run...I get the the following:\r\n```\r\nc71:\r\n    |_\r\n      ----------\r\n      testform:\r\n          ----------\r\n          example-test:\r\n              Fail - invalid test\r\n    |_\r\n      ----------\r\n      TEST RESULTS:\r\n          ----------\r\n          Failed:\r\n              1\r\n          Missing Tests:\r\n              0\r\n          Passed:\r\n              0\r\n```\r\n- I noticed test_2 and test_3 are the same? Not sure if thats intentional\r\n- apache_checks.tst seems to fail completely if the /etc/apache2/apache2.conf file does not exist. Is this intended? As in should it keep the other checks from being run? Once I touch the file the other tests run as expected.\r\n\r\nThanks again for this!"}}
{"actor":{"display_login":"justin-sunayu"}}