{"action":"closed","number":595,"pull_request":{"url":"https://api.github.com/repos/poanetwork/token-wizard/pulls/595","id":169197319,"html_url":"https://github.com/poanetwork/token-wizard/pull/595","diff_url":"https://github.com/poanetwork/token-wizard/pull/595.diff","patch_url":"https://github.com/poanetwork/token-wizard/pull/595.patch","issue_url":"https://api.github.com/repos/poanetwork/token-wizard/issues/595","number":595,"state":"closed","locked":false,"title":"(Feature) Show skip button if transaction fails.","user":{"login":"fvictorio","id":417134,"avatar_url":"https://avatars1.githubusercontent.com/u/417134?v=4","gravatar_id":"","url":"https://api.github.com/users/fvictorio","html_url":"https://github.com/fvictorio","followers_url":"https://api.github.com/users/fvictorio/followers","following_url":"https://api.github.com/users/fvictorio/following{/other_user}","gists_url":"https://api.github.com/users/fvictorio/gists{/gist_id}","starred_url":"https://api.github.com/users/fvictorio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvictorio/subscriptions","organizations_url":"https://api.github.com/users/fvictorio/orgs","repos_url":"https://api.github.com/users/fvictorio/repos","events_url":"https://api.github.com/users/fvictorio/events{/privacy}","received_events_url":"https://api.github.com/users/fvictorio/received_events","type":"User","site_admin":false},"body":"Depends on #594.\r\n\r\nThis is the last part of #529. If this is approved, I will create a PR for the feature branch against master.\r\n\r\nShow a skip button if a transaction fails. This is a workaround for the problem of repeated transactions. The scenario is this: suppose that a transaction can only be done once, and it fails if it's repeated. Suppose too that the deploy is in a step that performs a transaction like that. Then:\r\n\r\n1. MetaMask shows the popup for submitting that transaction.\r\n2. The user's browser crashes or they refresh the page.\r\n3. The deployment is resumed, and the same transaction is sent through MetaMask. Now MetaMask has two equal transactions in the queue, but the app only responds to the result of the second one.\r\n4. The user submits both transactions. The first one is successful, but the app doesn't know it. The second one fails, and the app stops the deployment. If the user refreshes the page to resume the deploy, the transaction will be tried again, but it will continue to fail.\r\n\r\nIn that scenario, skipping that transaction makes sense if the user knows that the transaction was executed even if the app doesn't know it.","created_at":"2018-02-14T19:14:21Z","updated_at":"2018-02-15T15:32:46Z","closed_at":"2018-02-15T15:32:46Z","merged_at":"2018-02-15T15:32:46Z","merge_commit_sha":"a6a8f33af4e0af5c6a9d5621375299335c90fb13","assignee":{"login":"fvictorio","id":417134,"avatar_url":"https://avatars1.githubusercontent.com/u/417134?v=4","gravatar_id":"","url":"https://api.github.com/users/fvictorio","html_url":"https://github.com/fvictorio","followers_url":"https://api.github.com/users/fvictorio/followers","following_url":"https://api.github.com/users/fvictorio/following{/other_user}","gists_url":"https://api.github.com/users/fvictorio/gists{/gist_id}","starred_url":"https://api.github.com/users/fvictorio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvictorio/subscriptions","organizations_url":"https://api.github.com/users/fvictorio/orgs","repos_url":"https://api.github.com/users/fvictorio/repos","events_url":"https://api.github.com/users/fvictorio/events{/privacy}","received_events_url":"https://api.github.com/users/fvictorio/received_events","type":"User","site_admin":false},"assignees":[{"login":"fvictorio","id":417134,"avatar_url":"https://avatars1.githubusercontent.com/u/417134?v=4","gravatar_id":"","url":"https://api.github.com/users/fvictorio","html_url":"https://github.com/fvictorio","followers_url":"https://api.github.com/users/fvictorio/followers","following_url":"https://api.github.com/users/fvictorio/following{/other_user}","gists_url":"https://api.github.com/users/fvictorio/gists{/gist_id}","starred_url":"https://api.github.com/users/fvictorio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvictorio/subscriptions","organizations_url":"https://api.github.com/users/fvictorio/orgs","repos_url":"https://api.github.com/users/fvictorio/repos","events_url":"https://api.github.com/users/fvictorio/events{/privacy}","received_events_url":"https://api.github.com/users/fvictorio/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":739650505,"url":"https://api.github.com/repos/poanetwork/token-wizard/labels/awaiting%20for%20review","name":"awaiting for review","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/poanetwork/token-wizard/pulls/595/commits","review_comments_url":"https://api.github.com/repos/poanetwork/token-wizard/pulls/595/comments","review_comment_url":"https://api.github.com/repos/poanetwork/token-wizard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poanetwork/token-wizard/issues/595/comments","statuses_url":"https://api.github.com/repos/poanetwork/token-wizard/statuses/ea2110f71db32139c1dd39b73e5e7690e292802b","head":{"label":"poanetwork:persist-crowdsale-state-6","ref":"persist-crowdsale-state-6","sha":"ea2110f71db32139c1dd39b73e5e7690e292802b","user":{"login":"poanetwork","id":28943015,"avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":97154721,"name":"token-wizard","full_name":"poanetwork/token-wizard","owner":{"login":"poanetwork","id":28943015,"avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poanetwork/token-wizard","description":"Create ERC20 token and crowdsale campaigns (ICO) on Ethereum networks using open source Wizard. No coding skills required. Decentralized, open source, free.","fork":false,"url":"https://api.github.com/repos/poanetwork/token-wizard","forks_url":"https://api.github.com/repos/poanetwork/token-wizard/forks","keys_url":"https://api.github.com/repos/poanetwork/token-wizard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poanetwork/token-wizard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poanetwork/token-wizard/teams","hooks_url":"https://api.github.com/repos/poanetwork/token-wizard/hooks","issue_events_url":"https://api.github.com/repos/poanetwork/token-wizard/issues/events{/number}","events_url":"https://api.github.com/repos/poanetwork/token-wizard/events","assignees_url":"https://api.github.com/repos/poanetwork/token-wizard/assignees{/user}","branches_url":"https://api.github.com/repos/poanetwork/token-wizard/branches{/branch}","tags_url":"https://api.github.com/repos/poanetwork/token-wizard/tags","blobs_url":"https://api.github.com/repos/poanetwork/token-wizard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poanetwork/token-wizard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poanetwork/token-wizard/git/refs{/sha}","trees_url":"https://api.github.com/repos/poanetwork/token-wizard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poanetwork/token-wizard/statuses/{sha}","languages_url":"https://api.github.com/repos/poanetwork/token-wizard/languages","stargazers_url":"https://api.github.com/repos/poanetwork/token-wizard/stargazers","contributors_url":"https://api.github.com/repos/poanetwork/token-wizard/contributors","subscribers_url":"https://api.github.com/repos/poanetwork/token-wizard/subscribers","subscription_url":"https://api.github.com/repos/poanetwork/token-wizard/subscription","commits_url":"https://api.github.com/repos/poanetwork/token-wizard/commits{/sha}","git_commits_url":"https://api.github.com/repos/poanetwork/token-wizard/git/commits{/sha}","comments_url":"https://api.github.com/repos/poanetwork/token-wizard/comments{/number}","issue_comment_url":"https://api.github.com/repos/poanetwork/token-wizard/issues/comments{/number}","contents_url":"https://api.github.com/repos/poanetwork/token-wizard/contents/{+path}","compare_url":"https://api.github.com/repos/poanetwork/token-wizard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poanetwork/token-wizard/merges","archive_url":"https://api.github.com/repos/poanetwork/token-wizard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poanetwork/token-wizard/downloads","issues_url":"https://api.github.com/repos/poanetwork/token-wizard/issues{/number}","pulls_url":"https://api.github.com/repos/poanetwork/token-wizard/pulls{/number}","milestones_url":"https://api.github.com/repos/poanetwork/token-wizard/milestones{/number}","notifications_url":"https://api.github.com/repos/poanetwork/token-wizard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poanetwork/token-wizard/labels{/name}","releases_url":"https://api.github.com/repos/poanetwork/token-wizard/releases{/id}","deployments_url":"https://api.github.com/repos/poanetwork/token-wizard/deployments","created_at":"2017-07-13T18:46:22Z","updated_at":"2018-02-15T10:55:52Z","pushed_at":"2018-02-15T15:32:46Z","git_url":"git://github.com/poanetwork/token-wizard.git","ssh_url":"git@github.com:poanetwork/token-wizard.git","clone_url":"https://github.com/poanetwork/token-wizard.git","svn_url":"https://github.com/poanetwork/token-wizard","homepage":"https://wizard.poa.network","size":9235,"stargazers_count":191,"watchers_count":191,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":96,"open_issues":35,"watchers":191,"default_branch":"master"}},"base":{"label":"poanetwork:persist-crowdsale-state-#529","ref":"persist-crowdsale-state-#529","sha":"9583ba4c9b1ab60acb9301474c00990dffd1577c","user":{"login":"poanetwork","id":28943015,"avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":97154721,"name":"token-wizard","full_name":"poanetwork/token-wizard","owner":{"login":"poanetwork","id":28943015,"avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poanetwork/token-wizard","description":"Create ERC20 token and crowdsale campaigns (ICO) on Ethereum networks using open source Wizard. No coding skills required. Decentralized, open source, free.","fork":false,"url":"https://api.github.com/repos/poanetwork/token-wizard","forks_url":"https://api.github.com/repos/poanetwork/token-wizard/forks","keys_url":"https://api.github.com/repos/poanetwork/token-wizard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poanetwork/token-wizard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poanetwork/token-wizard/teams","hooks_url":"https://api.github.com/repos/poanetwork/token-wizard/hooks","issue_events_url":"https://api.github.com/repos/poanetwork/token-wizard/issues/events{/number}","events_url":"https://api.github.com/repos/poanetwork/token-wizard/events","assignees_url":"https://api.github.com/repos/poanetwork/token-wizard/assignees{/user}","branches_url":"https://api.github.com/repos/poanetwork/token-wizard/branches{/branch}","tags_url":"https://api.github.com/repos/poanetwork/token-wizard/tags","blobs_url":"https://api.github.com/repos/poanetwork/token-wizard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poanetwork/token-wizard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poanetwork/token-wizard/git/refs{/sha}","trees_url":"https://api.github.com/repos/poanetwork/token-wizard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poanetwork/token-wizard/statuses/{sha}","languages_url":"https://api.github.com/repos/poanetwork/token-wizard/languages","stargazers_url":"https://api.github.com/repos/poanetwork/token-wizard/stargazers","contributors_url":"https://api.github.com/repos/poanetwork/token-wizard/contributors","subscribers_url":"https://api.github.com/repos/poanetwork/token-wizard/subscribers","subscription_url":"https://api.github.com/repos/poanetwork/token-wizard/subscription","commits_url":"https://api.github.com/repos/poanetwork/token-wizard/commits{/sha}","git_commits_url":"https://api.github.com/repos/poanetwork/token-wizard/git/commits{/sha}","comments_url":"https://api.github.com/repos/poanetwork/token-wizard/comments{/number}","issue_comment_url":"https://api.github.com/repos/poanetwork/token-wizard/issues/comments{/number}","contents_url":"https://api.github.com/repos/poanetwork/token-wizard/contents/{+path}","compare_url":"https://api.github.com/repos/poanetwork/token-wizard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poanetwork/token-wizard/merges","archive_url":"https://api.github.com/repos/poanetwork/token-wizard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poanetwork/token-wizard/downloads","issues_url":"https://api.github.com/repos/poanetwork/token-wizard/issues{/number}","pulls_url":"https://api.github.com/repos/poanetwork/token-wizard/pulls{/number}","milestones_url":"https://api.github.com/repos/poanetwork/token-wizard/milestones{/number}","notifications_url":"https://api.github.com/repos/poanetwork/token-wizard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poanetwork/token-wizard/labels{/name}","releases_url":"https://api.github.com/repos/poanetwork/token-wizard/releases{/id}","deployments_url":"https://api.github.com/repos/poanetwork/token-wizard/deployments","created_at":"2017-07-13T18:46:22Z","updated_at":"2018-02-15T10:55:52Z","pushed_at":"2018-02-15T15:32:46Z","git_url":"git://github.com/poanetwork/token-wizard.git","ssh_url":"git@github.com:poanetwork/token-wizard.git","clone_url":"https://github.com/poanetwork/token-wizard.git","svn_url":"https://github.com/poanetwork/token-wizard","homepage":"https://wizard.poa.network","size":9235,"stargazers_count":191,"watchers_count":191,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":96,"open_issues":35,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poanetwork/token-wizard/pulls/595"},"html":{"href":"https://github.com/poanetwork/token-wizard/pull/595"},"issue":{"href":"https://api.github.com/repos/poanetwork/token-wizard/issues/595"},"comments":{"href":"https://api.github.com/repos/poanetwork/token-wizard/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/poanetwork/token-wizard/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/poanetwork/token-wizard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poanetwork/token-wizard/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/poanetwork/token-wizard/statuses/ea2110f71db32139c1dd39b73e5e7690e292802b"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fvictorio","id":417134,"avatar_url":"https://avatars1.githubusercontent.com/u/417134?v=4","gravatar_id":"","url":"https://api.github.com/users/fvictorio","html_url":"https://github.com/fvictorio","followers_url":"https://api.github.com/users/fvictorio/followers","following_url":"https://api.github.com/users/fvictorio/following{/other_user}","gists_url":"https://api.github.com/users/fvictorio/gists{/gist_id}","starred_url":"https://api.github.com/users/fvictorio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvictorio/subscriptions","organizations_url":"https://api.github.com/users/fvictorio/orgs","repos_url":"https://api.github.com/users/fvictorio/repos","events_url":"https://api.github.com/users/fvictorio/events{/privacy}","received_events_url":"https://api.github.com/users/fvictorio/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":63,"deletions":10,"changed_files":5}}
{"actor":{"display_login":"fvictorio"}}