{"action":"created","issue":{"url":"https://api.github.com/repos/m-lab/tcp-info/issues/14","repository_url":"https://api.github.com/repos/m-lab/tcp-info","labels_url":"https://api.github.com/repos/m-lab/tcp-info/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/m-lab/tcp-info/issues/14/comments","events_url":"https://api.github.com/repos/m-lab/tcp-info/issues/14/events","html_url":"https://github.com/m-lab/tcp-info/pull/14","id":324083957,"number":14,"title":"Fix Dockerfile branch","user":{"login":"gfr10598","id":20915834,"avatar_url":"https://avatars3.githubusercontent.com/u/20915834?v=4","gravatar_id":"","url":"https://api.github.com/users/gfr10598","html_url":"https://github.com/gfr10598","followers_url":"https://api.github.com/users/gfr10598/followers","following_url":"https://api.github.com/users/gfr10598/following{/other_user}","gists_url":"https://api.github.com/users/gfr10598/gists{/gist_id}","starred_url":"https://api.github.com/users/gfr10598/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfr10598/subscriptions","organizations_url":"https://api.github.com/users/gfr10598/orgs","repos_url":"https://api.github.com/users/gfr10598/repos","events_url":"https://api.github.com/users/gfr10598/events{/privacy}","received_events_url":"https://api.github.com/users/gfr10598/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-17T15:52:14Z","updated_at":"2018-05-17T19:46:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/m-lab/tcp-info/pulls/14","html_url":"https://github.com/m-lab/tcp-info/pull/14","diff_url":"https://github.com/m-lab/tcp-info/pull/14.diff","patch_url":"https://github.com/m-lab/tcp-info/pull/14.patch"},"body":"Dockerfile explicitly used docker branch, instead of using the branch associated with the PR.\r\n\r\nThis PR adds docker and travis tweaks so that docker builds the appropriate branch.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/m-lab/tcp-info/14)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/m-lab/tcp-info/issues/comments/389986809","html_url":"https://github.com/m-lab/tcp-info/pull/14#issuecomment-389986809","issue_url":"https://api.github.com/repos/m-lab/tcp-info/issues/14","id":389986809,"user":{"login":"pboothe","id":143798,"avatar_url":"https://avatars1.githubusercontent.com/u/143798?v=4","gravatar_id":"","url":"https://api.github.com/users/pboothe","html_url":"https://github.com/pboothe","followers_url":"https://api.github.com/users/pboothe/followers","following_url":"https://api.github.com/users/pboothe/following{/other_user}","gists_url":"https://api.github.com/users/pboothe/gists{/gist_id}","starred_url":"https://api.github.com/users/pboothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboothe/subscriptions","organizations_url":"https://api.github.com/users/pboothe/orgs","repos_url":"https://api.github.com/users/pboothe/repos","events_url":"https://api.github.com/users/pboothe/events{/privacy}","received_events_url":"https://api.github.com/users/pboothe/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T19:46:10Z","updated_at":"2018-05-17T19:46:10Z","author_association":"NONE","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/> with one comment about the WORKDIR.\n\n---\n\nReview status: 0 of 2 files reviewed at latest revision, all discussions resolved.\n\n---\n\n*[Dockerfile, line 37 at r2](https://reviewable.io/reviews/m-lab/tcp-info/14#-LCjcC7E4r_vZ6I0B_pA:-LCjcC7E4r_vZ6I0B_pB:bt0omfj) ([raw file](https://github.com/m-lab/tcp-info/blob/a46f9028bd8c4ee1c692d8c7c029b974b0c04838/Dockerfile#L37)):*\n> ```Dockerfile\n> RUN apk --no-cache add bash\n> \n> WORKDIR /home\n> ```\n\nWhy `/home` ? Copying the binaries into `/bin` and then choosing a WORKDIR independent of that choice seems like the right thing to me.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/m-lab/tcp-info/14#-:-LCjcnlPCr4UmaOZmQ5q:b7lhga)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"pboothe"}}