{"action":"created","issue":{"url":"https://api.github.com/repos/open-contracting/standard_extension_template/issues/29","repository_url":"https://api.github.com/repos/open-contracting/standard_extension_template","labels_url":"https://api.github.com/repos/open-contracting/standard_extension_template/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/open-contracting/standard_extension_template/issues/29/comments","events_url":"https://api.github.com/repos/open-contracting/standard_extension_template/issues/29/events","html_url":"https://github.com/open-contracting/standard_extension_template/issues/29","id":325454267,"number":29,"title":"JSON Schema files optional?","user":{"login":"jpmckinney","id":26463,"avatar_url":"https://avatars1.githubusercontent.com/u/26463?v=4","gravatar_id":"","url":"https://api.github.com/users/jpmckinney","html_url":"https://github.com/jpmckinney","followers_url":"https://api.github.com/users/jpmckinney/followers","following_url":"https://api.github.com/users/jpmckinney/following{/other_user}","gists_url":"https://api.github.com/users/jpmckinney/gists{/gist_id}","starred_url":"https://api.github.com/users/jpmckinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpmckinney/subscriptions","organizations_url":"https://api.github.com/users/jpmckinney/orgs","repos_url":"https://api.github.com/users/jpmckinney/repos","events_url":"https://api.github.com/users/jpmckinney/events{/privacy}","received_events_url":"https://api.github.com/users/jpmckinney/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-22T20:38:57Z","updated_at":"2018-05-22T20:44:41Z","closed_at":null,"author_association":"MEMBER","body":"The template has:\r\n\r\n> Extensions must include at least one of those files.\r\n\r\nHowever, it's possible, as in https://github.com/INAImexico/ocds_extendedProcurementCategory_extension, to only have a modification to a codelist.\r\n\r\nI suspect that the above phrase was written before codelist modification was specified. I propose removing the sentence, to make it allowed to only modify codelists.\r\n\r\nAlso, there is no consequence to 'no-op' extensions that modify nothing, so we don't need to specifically guard against that.\r\n\r\nAgreed, @kindly @timgdavies @duncandewhurst? \r\n\r\ncc @yolile "},"comment":{"url":"https://api.github.com/repos/open-contracting/standard_extension_template/issues/comments/391134423","html_url":"https://github.com/open-contracting/standard_extension_template/issues/29#issuecomment-391134423","issue_url":"https://api.github.com/repos/open-contracting/standard_extension_template/issues/29","id":391134423,"user":{"login":"jpmckinney","id":26463,"avatar_url":"https://avatars1.githubusercontent.com/u/26463?v=4","gravatar_id":"","url":"https://api.github.com/users/jpmckinney","html_url":"https://github.com/jpmckinney","followers_url":"https://api.github.com/users/jpmckinney/followers","following_url":"https://api.github.com/users/jpmckinney/following{/other_user}","gists_url":"https://api.github.com/users/jpmckinney/gists{/gist_id}","starred_url":"https://api.github.com/users/jpmckinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpmckinney/subscriptions","organizations_url":"https://api.github.com/users/jpmckinney/orgs","repos_url":"https://api.github.com/users/jpmckinney/repos","events_url":"https://api.github.com/users/jpmckinney/events{/privacy}","received_events_url":"https://api.github.com/users/jpmckinney/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T20:44:41Z","updated_at":"2018-05-22T20:44:41Z","author_association":"MEMBER","body":"Secondly: I believe CoVE considers an extension to be invalid ('fetching failed') if it has no release-schema.json (note that the template instructions allow extensions to extend package schema without extending the release schema). It shouldn't report that.\r\n\r\nIn https://github.com/open-contracting/ocds-extensions/issues/59, I propose adding a `schemas` field to extension.json similar to the `codelists` field. I propose that CoVE's behavior should be to error if it tries to fetch a schema listed in `schemas` and fails, but reports no error if there are no `schemas` specified and it fails to optimistically retrieve the release schema."}}
{"actor":{"display_login":"jpmckinney"}}