{"action":"created","comment":{"url":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/comments/220062805","pull_request_review_id":158382797,"id":220062805,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDA2MjgwNQ==","diff_hunk":"@@ -146,8 +141,14 @@ project. The main elm file is the .elm file which contains a\n   :type '(string))\n \n (flycheck-define-checker elm\n-  \"A syntax checker for elm-mode using the json output from elm-make\"\n-  :command (\"elm-make\" \"--report=json\"\n+  \"A syntax checker for elm-mode using the json output from elm-make.\n+Users of Elm 0.19 should set `flycheck-elm-executable' to \\\"elm\\\", e.g.\n+via customization or per-project directory-local variables.\"\n+  :command (\"elm-make\"","path":"flycheck-elm.el","position":null,"original_position":119,"commit_id":"2db01ea1a41d8b546869077b863308175e172c43","original_commit_id":"9352e7b600e1d4e208dec56db77344ab4788909d","user":{"login":"purcell","id":5636,"node_id":"MDQ6VXNlcjU2MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5636?v=4","gravatar_id":"","url":"https://api.github.com/users/purcell","html_url":"https://github.com/purcell","followers_url":"https://api.github.com/users/purcell/followers","following_url":"https://api.github.com/users/purcell/following{/other_user}","gists_url":"https://api.github.com/users/purcell/gists{/gist_id}","starred_url":"https://api.github.com/users/purcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purcell/subscriptions","organizations_url":"https://api.github.com/users/purcell/orgs","repos_url":"https://api.github.com/users/purcell/repos","events_url":"https://api.github.com/users/purcell/events{/privacy}","received_events_url":"https://api.github.com/users/purcell/received_events","type":"User","site_admin":false},"body":"Now changed.","created_at":"2018-09-25T05:35:52Z","updated_at":"2018-09-25T05:35:52Z","html_url":"https://github.com/bsermons/flycheck-elm/pull/17#discussion_r220062805","pull_request_url":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/comments/220062805"},"html":{"href":"https://github.com/bsermons/flycheck-elm/pull/17#discussion_r220062805"},"pull_request":{"href":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/17"}},"in_reply_to_id":219707030},"pull_request":{"url":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/17","id":211906578,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTA2NTc4","html_url":"https://github.com/bsermons/flycheck-elm/pull/17","diff_url":"https://github.com/bsermons/flycheck-elm/pull/17.diff","patch_url":"https://github.com/bsermons/flycheck-elm/pull/17.patch","issue_url":"https://api.github.com/repos/bsermons/flycheck-elm/issues/17","number":17,"state":"open","locked":false,"title":"WIP: Make a start on Elm 0.19 compatibility","user":{"login":"purcell","id":5636,"node_id":"MDQ6VXNlcjU2MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5636?v=4","gravatar_id":"","url":"https://api.github.com/users/purcell","html_url":"https://github.com/purcell","followers_url":"https://api.github.com/users/purcell/followers","following_url":"https://api.github.com/users/purcell/following{/other_user}","gists_url":"https://api.github.com/users/purcell/gists{/gist_id}","starred_url":"https://api.github.com/users/purcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purcell/subscriptions","organizations_url":"https://api.github.com/users/purcell/orgs","repos_url":"https://api.github.com/users/purcell/repos","events_url":"https://api.github.com/users/purcell/events{/privacy}","received_events_url":"https://api.github.com/users/purcell/received_events","type":"User","site_admin":false},"body":"I started tinkering with this, and figured I'd share what I have in case someone else wants to pick it up or has feedback.\r\n\r\nThe changes so far are sufficient to correctly invoke \"elm make\" if the user has customized `flycheck-elm-executable` to `\"elm\"`. This is not sufficient to get any errors displayed via flycheck: the key issue seems to be that the JSON output of `elm make` has changed substantially, so converting the new-style JSON into flycheck errors requires code that has yet to be written.","created_at":"2018-08-29T22:33:40Z","updated_at":"2018-09-25T05:35:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"564ef5840cc51e64b1368412b72a89477cf93e00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/17/commits","review_comments_url":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/17/comments","review_comment_url":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bsermons/flycheck-elm/issues/17/comments","statuses_url":"https://api.github.com/repos/bsermons/flycheck-elm/statuses/2db01ea1a41d8b546869077b863308175e172c43","head":{"label":"purcell:elm-0.19","ref":"elm-0.19","sha":"2db01ea1a41d8b546869077b863308175e172c43","user":{"login":"purcell","id":5636,"node_id":"MDQ6VXNlcjU2MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5636?v=4","gravatar_id":"","url":"https://api.github.com/users/purcell","html_url":"https://github.com/purcell","followers_url":"https://api.github.com/users/purcell/followers","following_url":"https://api.github.com/users/purcell/following{/other_user}","gists_url":"https://api.github.com/users/purcell/gists{/gist_id}","starred_url":"https://api.github.com/users/purcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purcell/subscriptions","organizations_url":"https://api.github.com/users/purcell/orgs","repos_url":"https://api.github.com/users/purcell/repos","events_url":"https://api.github.com/users/purcell/events{/privacy}","received_events_url":"https://api.github.com/users/purcell/received_events","type":"User","site_admin":false},"repo":{"id":43044543,"node_id":"MDEwOlJlcG9zaXRvcnk0MzA0NDU0Mw==","name":"flycheck-elm","full_name":"purcell/flycheck-elm","private":false,"owner":{"login":"purcell","id":5636,"node_id":"MDQ6VXNlcjU2MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5636?v=4","gravatar_id":"","url":"https://api.github.com/users/purcell","html_url":"https://github.com/purcell","followers_url":"https://api.github.com/users/purcell/followers","following_url":"https://api.github.com/users/purcell/following{/other_user}","gists_url":"https://api.github.com/users/purcell/gists{/gist_id}","starred_url":"https://api.github.com/users/purcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purcell/subscriptions","organizations_url":"https://api.github.com/users/purcell/orgs","repos_url":"https://api.github.com/users/purcell/repos","events_url":"https://api.github.com/users/purcell/events{/privacy}","received_events_url":"https://api.github.com/users/purcell/received_events","type":"User","site_admin":false},"html_url":"https://github.com/purcell/flycheck-elm","description":"Flycheck support for the elm language","fork":true,"url":"https://api.github.com/repos/purcell/flycheck-elm","forks_url":"https://api.github.com/repos/purcell/flycheck-elm/forks","keys_url":"https://api.github.com/repos/purcell/flycheck-elm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purcell/flycheck-elm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purcell/flycheck-elm/teams","hooks_url":"https://api.github.com/repos/purcell/flycheck-elm/hooks","issue_events_url":"https://api.github.com/repos/purcell/flycheck-elm/issues/events{/number}","events_url":"https://api.github.com/repos/purcell/flycheck-elm/events","assignees_url":"https://api.github.com/repos/purcell/flycheck-elm/assignees{/user}","branches_url":"https://api.github.com/repos/purcell/flycheck-elm/branches{/branch}","tags_url":"https://api.github.com/repos/purcell/flycheck-elm/tags","blobs_url":"https://api.github.com/repos/purcell/flycheck-elm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purcell/flycheck-elm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purcell/flycheck-elm/git/refs{/sha}","trees_url":"https://api.github.com/repos/purcell/flycheck-elm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purcell/flycheck-elm/statuses/{sha}","languages_url":"https://api.github.com/repos/purcell/flycheck-elm/languages","stargazers_url":"https://api.github.com/repos/purcell/flycheck-elm/stargazers","contributors_url":"https://api.github.com/repos/purcell/flycheck-elm/contributors","subscribers_url":"https://api.github.com/repos/purcell/flycheck-elm/subscribers","subscription_url":"https://api.github.com/repos/purcell/flycheck-elm/subscription","commits_url":"https://api.github.com/repos/purcell/flycheck-elm/commits{/sha}","git_commits_url":"https://api.github.com/repos/purcell/flycheck-elm/git/commits{/sha}","comments_url":"https://api.github.com/repos/purcell/flycheck-elm/comments{/number}","issue_comment_url":"https://api.github.com/repos/purcell/flycheck-elm/issues/comments{/number}","contents_url":"https://api.github.com/repos/purcell/flycheck-elm/contents/{+path}","compare_url":"https://api.github.com/repos/purcell/flycheck-elm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purcell/flycheck-elm/merges","archive_url":"https://api.github.com/repos/purcell/flycheck-elm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purcell/flycheck-elm/downloads","issues_url":"https://api.github.com/repos/purcell/flycheck-elm/issues{/number}","pulls_url":"https://api.github.com/repos/purcell/flycheck-elm/pulls{/number}","milestones_url":"https://api.github.com/repos/purcell/flycheck-elm/milestones{/number}","notifications_url":"https://api.github.com/repos/purcell/flycheck-elm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purcell/flycheck-elm/labels{/name}","releases_url":"https://api.github.com/repos/purcell/flycheck-elm/releases{/id}","deployments_url":"https://api.github.com/repos/purcell/flycheck-elm/deployments","created_at":"2015-09-24T04:22:09Z","updated_at":"2015-11-08T16:59:02Z","pushed_at":"2018-09-25T05:35:45Z","git_url":"git://github.com/purcell/flycheck-elm.git","ssh_url":"git@github.com:purcell/flycheck-elm.git","clone_url":"https://github.com/purcell/flycheck-elm.git","svn_url":"https://github.com/purcell/flycheck-elm","homepage":null,"size":28,"stargazers_count":1,"watchers_count":1,"language":"Emacs Lisp","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"bsermons:master","ref":"master","sha":"b401873ebd2176190a0a6fb4d61c2cca97d3b9fb","user":{"login":"bsermons","id":3093423,"node_id":"MDQ6VXNlcjMwOTM0MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3093423?v=4","gravatar_id":"","url":"https://api.github.com/users/bsermons","html_url":"https://github.com/bsermons","followers_url":"https://api.github.com/users/bsermons/followers","following_url":"https://api.github.com/users/bsermons/following{/other_user}","gists_url":"https://api.github.com/users/bsermons/gists{/gist_id}","starred_url":"https://api.github.com/users/bsermons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsermons/subscriptions","organizations_url":"https://api.github.com/users/bsermons/orgs","repos_url":"https://api.github.com/users/bsermons/repos","events_url":"https://api.github.com/users/bsermons/events{/privacy}","received_events_url":"https://api.github.com/users/bsermons/received_events","type":"User","site_admin":false},"repo":{"id":38454465,"node_id":"MDEwOlJlcG9zaXRvcnkzODQ1NDQ2NQ==","name":"flycheck-elm","full_name":"bsermons/flycheck-elm","private":false,"owner":{"login":"bsermons","id":3093423,"node_id":"MDQ6VXNlcjMwOTM0MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3093423?v=4","gravatar_id":"","url":"https://api.github.com/users/bsermons","html_url":"https://github.com/bsermons","followers_url":"https://api.github.com/users/bsermons/followers","following_url":"https://api.github.com/users/bsermons/following{/other_user}","gists_url":"https://api.github.com/users/bsermons/gists{/gist_id}","starred_url":"https://api.github.com/users/bsermons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsermons/subscriptions","organizations_url":"https://api.github.com/users/bsermons/orgs","repos_url":"https://api.github.com/users/bsermons/repos","events_url":"https://api.github.com/users/bsermons/events{/privacy}","received_events_url":"https://api.github.com/users/bsermons/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bsermons/flycheck-elm","description":"Flycheck support for the elm language","fork":false,"url":"https://api.github.com/repos/bsermons/flycheck-elm","forks_url":"https://api.github.com/repos/bsermons/flycheck-elm/forks","keys_url":"https://api.github.com/repos/bsermons/flycheck-elm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsermons/flycheck-elm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsermons/flycheck-elm/teams","hooks_url":"https://api.github.com/repos/bsermons/flycheck-elm/hooks","issue_events_url":"https://api.github.com/repos/bsermons/flycheck-elm/issues/events{/number}","events_url":"https://api.github.com/repos/bsermons/flycheck-elm/events","assignees_url":"https://api.github.com/repos/bsermons/flycheck-elm/assignees{/user}","branches_url":"https://api.github.com/repos/bsermons/flycheck-elm/branches{/branch}","tags_url":"https://api.github.com/repos/bsermons/flycheck-elm/tags","blobs_url":"https://api.github.com/repos/bsermons/flycheck-elm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsermons/flycheck-elm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsermons/flycheck-elm/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsermons/flycheck-elm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsermons/flycheck-elm/statuses/{sha}","languages_url":"https://api.github.com/repos/bsermons/flycheck-elm/languages","stargazers_url":"https://api.github.com/repos/bsermons/flycheck-elm/stargazers","contributors_url":"https://api.github.com/repos/bsermons/flycheck-elm/contributors","subscribers_url":"https://api.github.com/repos/bsermons/flycheck-elm/subscribers","subscription_url":"https://api.github.com/repos/bsermons/flycheck-elm/subscription","commits_url":"https://api.github.com/repos/bsermons/flycheck-elm/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsermons/flycheck-elm/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsermons/flycheck-elm/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsermons/flycheck-elm/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsermons/flycheck-elm/contents/{+path}","compare_url":"https://api.github.com/repos/bsermons/flycheck-elm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsermons/flycheck-elm/merges","archive_url":"https://api.github.com/repos/bsermons/flycheck-elm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsermons/flycheck-elm/downloads","issues_url":"https://api.github.com/repos/bsermons/flycheck-elm/issues{/number}","pulls_url":"https://api.github.com/repos/bsermons/flycheck-elm/pulls{/number}","milestones_url":"https://api.github.com/repos/bsermons/flycheck-elm/milestones{/number}","notifications_url":"https://api.github.com/repos/bsermons/flycheck-elm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsermons/flycheck-elm/labels{/name}","releases_url":"https://api.github.com/repos/bsermons/flycheck-elm/releases{/id}","deployments_url":"https://api.github.com/repos/bsermons/flycheck-elm/deployments","created_at":"2015-07-02T20:07:12Z","updated_at":"2018-07-07T23:14:25Z","pushed_at":"2018-09-25T05:35:46Z","git_url":"git://github.com/bsermons/flycheck-elm.git","ssh_url":"git@github.com:bsermons/flycheck-elm.git","clone_url":"https://github.com/bsermons/flycheck-elm.git","svn_url":"https://github.com/bsermons/flycheck-elm","homepage":null,"size":30,"stargazers_count":16,"watchers_count":16,"language":"Emacs Lisp","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":7,"open_issues":6,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/17"},"html":{"href":"https://github.com/bsermons/flycheck-elm/pull/17"},"issue":{"href":"https://api.github.com/repos/bsermons/flycheck-elm/issues/17"},"comments":{"href":"https://api.github.com/repos/bsermons/flycheck-elm/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bsermons/flycheck-elm/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/bsermons/flycheck-elm/statuses/2db01ea1a41d8b546869077b863308175e172c43"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"purcell"}}