{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/airship/pulls/comments/205419785","pull_request_review_id":140679424,"id":205419785,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTQxOTc4NQ==","diff_hunk":"@@ -40,24 +39,30 @@ collapsed: true\n ### Toolbar\n Toolbar is a generic bar that can be used as a header to put your application logo and some options to navigate throughout your application.\n \n-The toolbar is placed in the top of your application unless you modify its position by using `left` or `right` modifiers in `airship-app` styles.\n+On mobile devices the toolbar is placed always on top but its position can be modified on desktop by using `left` or `right` modifiers in `airship-app` styles.\n   - `airship-app--nav-left`: Push the toolbar to the left of the viewport.\n   - `airship-app--nav-right`: Push the toolbar to the right of the viewport.\n \n ### Toolbar Actions\n \n-Your toolbar can contain several buttons to trigger actions in your application. These actions need to be grouped in an element with `.as-toolbar-actions` class.\n+Toolbar actions are the main toolbar's content, usually icons or links to another app's section. Actions are hidden by default on mobile devices and they are only visible when the `as-toolbar-actions--visible` modifier class is present.\n+\n+In order to [fit the W3C Accessibility guidelines](https://www.w3.org/WAI/tutorials/menus/) the menu should be an `ul` element where menu item should be a `li` element with a `as-toolbar__item` class.\n \n ```code\n lang:html\n ---\n-<nav class=\"as-toolbar-main\">\n-  <div class=\"as-toolbar-actions\">\n-    <span class=\"as-toolbar-main__item\">\n-      <img src=\"https://material.io/tools/icons/static/icons/baseline-fingerprint-24px.svg\" alt=\"Ajustes\">\n-      <p>Ajustes</p>\n-    </span>\n-  </div>\n+<nav class=\"as-toolbar__actions\">\n+  <ul>\n+    <li class=\"as-toolbar__item\">\n+      <img src=\"https://material.io/tools/icons/static/icons/baseline-fingerprint-24px.svg\" alt=\"Action 1\">\n+      <p class=\"as-toolbar__icon-text\">Action 1</p>\n+    </li>\n+    <li class=\"as-toolbar__item\">\n+      <img src=\"https://material.io/tools/icons/static/icons/baseline-add_location-24px.svg\" alt=\"Action 2\">\n+      <p class=\"as-toolbar__icon-text\">Action 2</p>\n+    </li>\n+  </ul>\n </nav>\n ```\n ","path":"packages/styles/src/core/layout/README.md","position":null,"original_position":63,"commit_id":"989326fbb2c853564841a0d908ba111932d40d0b","original_commit_id":"176700b68ecfcd6a67cbf758239389d8f9bd1c8a","user":{"login":"ivanmalagon","id":1078228,"node_id":"MDQ6VXNlcjEwNzgyMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1078228?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanmalagon","html_url":"https://github.com/ivanmalagon","followers_url":"https://api.github.com/users/ivanmalagon/followers","following_url":"https://api.github.com/users/ivanmalagon/following{/other_user}","gists_url":"https://api.github.com/users/ivanmalagon/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanmalagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanmalagon/subscriptions","organizations_url":"https://api.github.com/users/ivanmalagon/orgs","repos_url":"https://api.github.com/users/ivanmalagon/repos","events_url":"https://api.github.com/users/ivanmalagon/events{/privacy}","received_events_url":"https://api.github.com/users/ivanmalagon/received_events","type":"User","site_admin":false},"body":"`as-toolbar-main` is outdate throughout all code examples.","created_at":"2018-07-26T11:20:38Z","updated_at":"2018-07-26T11:21:58Z","html_url":"https://github.com/CartoDB/airship/pull/97#discussion_r205419785","pull_request_url":"https://api.github.com/repos/CartoDB/airship/pulls/97","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/airship/pulls/comments/205419785"},"html":{"href":"https://github.com/CartoDB/airship/pull/97#discussion_r205419785"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/airship/pulls/97"}},"in_reply_to_id":205419649},"pull_request":{"url":"https://api.github.com/repos/CartoDB/airship/pulls/97","id":204047556,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MDQ3NTU2","html_url":"https://github.com/CartoDB/airship/pull/97","diff_url":"https://github.com/CartoDB/airship/pull/97.diff","patch_url":"https://github.com/CartoDB/airship/pull/97.patch","issue_url":"https://api.github.com/repos/CartoDB/airship/issues/97","number":97,"state":"open","locked":false,"title":"Upgrade toolbar styles","user":{"login":"IagoLast","id":2657897,"node_id":"MDQ6VXNlcjI2NTc4OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2657897?v=4","gravatar_id":"","url":"https://api.github.com/users/IagoLast","html_url":"https://github.com/IagoLast","followers_url":"https://api.github.com/users/IagoLast/followers","following_url":"https://api.github.com/users/IagoLast/following{/other_user}","gists_url":"https://api.github.com/users/IagoLast/gists{/gist_id}","starred_url":"https://api.github.com/users/IagoLast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IagoLast/subscriptions","organizations_url":"https://api.github.com/users/IagoLast/orgs","repos_url":"https://api.github.com/users/IagoLast/repos","events_url":"https://api.github.com/users/IagoLast/events{/privacy}","received_events_url":"https://api.github.com/users/IagoLast/received_events","type":"User","site_admin":false},"body":"<issue-code>\r\n---","created_at":"2018-07-26T07:10:01Z","updated_at":"2018-07-26T11:21:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07968ac54ebc1e948c7b9c93ce3b9a15e38623c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/airship/pulls/97/commits","review_comments_url":"https://api.github.com/repos/CartoDB/airship/pulls/97/comments","review_comment_url":"https://api.github.com/repos/CartoDB/airship/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/airship/issues/97/comments","statuses_url":"https://api.github.com/repos/CartoDB/airship/statuses/989326fbb2c853564841a0d908ba111932d40d0b","head":{"label":"CartoDB:toolbar-refactor","ref":"toolbar-refactor","sha":"989326fbb2c853564841a0d908ba111932d40d0b","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":119569997,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk1Njk5OTc=","name":"airship","full_name":"CartoDB/airship","owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/airship","description":"A design library for building Location Intelligence applications.","fork":false,"url":"https://api.github.com/repos/CartoDB/airship","forks_url":"https://api.github.com/repos/CartoDB/airship/forks","keys_url":"https://api.github.com/repos/CartoDB/airship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/airship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/airship/teams","hooks_url":"https://api.github.com/repos/CartoDB/airship/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/airship/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/airship/events","assignees_url":"https://api.github.com/repos/CartoDB/airship/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/airship/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/airship/tags","blobs_url":"https://api.github.com/repos/CartoDB/airship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/airship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/airship/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/airship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/airship/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/airship/languages","stargazers_url":"https://api.github.com/repos/CartoDB/airship/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/airship/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/airship/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/airship/subscription","commits_url":"https://api.github.com/repos/CartoDB/airship/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/airship/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/airship/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/airship/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/airship/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/airship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/airship/merges","archive_url":"https://api.github.com/repos/CartoDB/airship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/airship/downloads","issues_url":"https://api.github.com/repos/CartoDB/airship/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/airship/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/airship/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/airship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/airship/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/airship/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/airship/deployments","created_at":"2018-01-30T17:28:26Z","updated_at":"2018-07-25T14:45:56Z","pushed_at":"2018-07-26T11:21:48Z","git_url":"git://github.com/CartoDB/airship.git","ssh_url":"git@github.com:CartoDB/airship.git","clone_url":"https://github.com/CartoDB/airship.git","svn_url":"https://github.com/CartoDB/airship","homepage":"https://carto.com/airship","size":1596,"stargazers_count":29,"watchers_count":29,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":4,"open_issues":30,"watchers":29,"default_branch":"master"}},"base":{"label":"CartoDB:test-layouts","ref":"test-layouts","sha":"640e8d2801e3b8b9a8e9c4ecf82ba664db629ea1","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":119569997,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk1Njk5OTc=","name":"airship","full_name":"CartoDB/airship","owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/airship","description":"A design library for building Location Intelligence applications.","fork":false,"url":"https://api.github.com/repos/CartoDB/airship","forks_url":"https://api.github.com/repos/CartoDB/airship/forks","keys_url":"https://api.github.com/repos/CartoDB/airship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/airship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/airship/teams","hooks_url":"https://api.github.com/repos/CartoDB/airship/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/airship/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/airship/events","assignees_url":"https://api.github.com/repos/CartoDB/airship/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/airship/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/airship/tags","blobs_url":"https://api.github.com/repos/CartoDB/airship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/airship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/airship/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/airship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/airship/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/airship/languages","stargazers_url":"https://api.github.com/repos/CartoDB/airship/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/airship/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/airship/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/airship/subscription","commits_url":"https://api.github.com/repos/CartoDB/airship/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/airship/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/airship/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/airship/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/airship/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/airship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/airship/merges","archive_url":"https://api.github.com/repos/CartoDB/airship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/airship/downloads","issues_url":"https://api.github.com/repos/CartoDB/airship/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/airship/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/airship/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/airship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/airship/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/airship/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/airship/deployments","created_at":"2018-01-30T17:28:26Z","updated_at":"2018-07-25T14:45:56Z","pushed_at":"2018-07-26T11:21:48Z","git_url":"git://github.com/CartoDB/airship.git","ssh_url":"git@github.com:CartoDB/airship.git","clone_url":"https://github.com/CartoDB/airship.git","svn_url":"https://github.com/CartoDB/airship","homepage":"https://carto.com/airship","size":1596,"stargazers_count":29,"watchers_count":29,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":4,"open_issues":30,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/airship/pulls/97"},"html":{"href":"https://github.com/CartoDB/airship/pull/97"},"issue":{"href":"https://api.github.com/repos/CartoDB/airship/issues/97"},"comments":{"href":"https://api.github.com/repos/CartoDB/airship/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/airship/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/airship/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/airship/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/airship/statuses/989326fbb2c853564841a0d908ba111932d40d0b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ivanmalagon"}}