{"action":"created","comment":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/comments/201497577","pull_request_review_id":136012992,"id":201497577,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQ5NzU3Nw==","diff_hunk":"@@ -1299,7 +1310,15 @@ def symbols(self, *args):\n         --------\n         :func:`zipline.api.set_symbol_lookup_date`\n         \"\"\"\n-        return [self.symbol(identifier) for identifier in args]\n+        country_code = kwargs.pop('country_code', None)","path":"zipline/algorithm.py","position":117,"original_position":117,"commit_id":"d19b6314e324b2ba376af8a88036712b09c06221","original_commit_id":"d19b6314e324b2ba376af8a88036712b09c06221","user":{"login":"llllllllll","id":3064397,"node_id":"MDQ6VXNlcjMwNjQzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3064397?v=4","gravatar_id":"","url":"https://api.github.com/users/llllllllll","html_url":"https://github.com/llllllllll","followers_url":"https://api.github.com/users/llllllllll/followers","following_url":"https://api.github.com/users/llllllllll/following{/other_user}","gists_url":"https://api.github.com/users/llllllllll/gists{/gist_id}","starred_url":"https://api.github.com/users/llllllllll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llllllllll/subscriptions","organizations_url":"https://api.github.com/users/llllllllll/orgs","repos_url":"https://api.github.com/users/llllllllll/repos","events_url":"https://api.github.com/users/llllllllll/events{/privacy}","received_events_url":"https://api.github.com/users/llllllllll/received_events","type":"User","site_admin":false},"body":"oh, I guess I could do that","created_at":"2018-07-10T21:16:08Z","updated_at":"2018-07-10T21:16:08Z","html_url":"https://github.com/quantopian/zipline/pull/2234#discussion_r201497577","pull_request_url":"https://api.github.com/repos/quantopian/zipline/pulls/2234","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments/201497577"},"html":{"href":"https://github.com/quantopian/zipline/pull/2234#discussion_r201497577"},"pull_request":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2234"}},"in_reply_to_id":201167436},"pull_request":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/2234","id":199089187,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDg5MTg3","html_url":"https://github.com/quantopian/zipline/pull/2234","diff_url":"https://github.com/quantopian/zipline/pull/2234.diff","patch_url":"https://github.com/quantopian/zipline/pull/2234.patch","issue_url":"https://api.github.com/repos/quantopian/zipline/issues/2234","number":2234,"state":"open","locked":false,"title":"ENH: Store more information about exchanges","user":{"login":"llllllllll","id":3064397,"node_id":"MDQ6VXNlcjMwNjQzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3064397?v=4","gravatar_id":"","url":"https://api.github.com/users/llllllllll","html_url":"https://github.com/llllllllll","followers_url":"https://api.github.com/users/llllllllll/followers","following_url":"https://api.github.com/users/llllllllll/following{/other_user}","gists_url":"https://api.github.com/users/llllllllll/gists{/gist_id}","starred_url":"https://api.github.com/users/llllllllll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llllllllll/subscriptions","organizations_url":"https://api.github.com/users/llllllllll/orgs","repos_url":"https://api.github.com/users/llllllllll/repos","events_url":"https://api.github.com/users/llllllllll/events{/privacy}","received_events_url":"https://api.github.com/users/llllllllll/received_events","type":"User","site_admin":false},"body":"Use an object to store more attributes of an exchange. This info is stored in the `exchange` table in the assets db. We will need this to be able to store international equities in the same assets db.\r\n\r\nThis PR also adds `country_code` as a parameter to `lookup_symbol` and `lifetimes`. This PR does not allow us to trade international equities yet, it just sets up the infrastructure to reference equities listed in different countries.","created_at":"2018-07-03T21:36:21Z","updated_at":"2018-07-10T21:16:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c18a7130e2b4833dc8e5c31d08a5c53749d6269a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/quantopian/zipline/pulls/2234/commits","review_comments_url":"https://api.github.com/repos/quantopian/zipline/pulls/2234/comments","review_comment_url":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quantopian/zipline/issues/2234/comments","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/d19b6314e324b2ba376af8a88036712b09c06221","head":{"label":"quantopian:exchange_info","ref":"exchange_info","sha":"d19b6314e324b2ba376af8a88036712b09c06221","user":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjk3NTIw","name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2018-07-10T18:54:19Z","pushed_at":"2018-07-10T20:37:03Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"http://www.zipline.io/","size":153764,"stargazers_count":7291,"watchers_count":7291,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2315,"mirror_url":null,"archived":false,"open_issues_count":237,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2315,"open_issues":237,"watchers":7291,"default_branch":"master"}},"base":{"label":"quantopian:master","ref":"master","sha":"845b33d0506b6be8b5d46aa76642d52474a70288","user":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjk3NTIw","name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2018-07-10T18:54:19Z","pushed_at":"2018-07-10T20:37:03Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"http://www.zipline.io/","size":153764,"stargazers_count":7291,"watchers_count":7291,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2315,"mirror_url":null,"archived":false,"open_issues_count":237,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2315,"open_issues":237,"watchers":7291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2234"},"html":{"href":"https://github.com/quantopian/zipline/pull/2234"},"issue":{"href":"https://api.github.com/repos/quantopian/zipline/issues/2234"},"comments":{"href":"https://api.github.com/repos/quantopian/zipline/issues/2234/comments"},"review_comments":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2234/comments"},"review_comment":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2234/commits"},"statuses":{"href":"https://api.github.com/repos/quantopian/zipline/statuses/d19b6314e324b2ba376af8a88036712b09c06221"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"llllllllll"}}