{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments/209131771","pull_request_review_id":145088570,"id":209131771,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTEzMTc3MQ==","diff_hunk":"@@ -980,4 +979,29 @@ public String getExcludedMethodList()\n     {\n         return String.join(\",\", getExcludedMethods());\n     }\n+\n+    /**\n+     * Set the {@link DeflaterPool} that is used to manage instances of {@link Deflater}\n+     * @param deflaterPool\n+     */\n+    public void setDeflaterPool(DeflaterPool deflaterPool)\n+    {\n+        if(isStarted())\n+            throw new IllegalStateException(getState());\n+\n+        _deflaterPool = deflaterPool;\n+    }\n+\n+    public int getDeflaterPoolCapacity()\n+    {\n+        return POOL_CAPACITY;\n+    }\n+\n+    public void setDeflaterPoolCapacity(int capacity)\n+    {\n+        if(isStarted())\n+            throw new IllegalStateException(getState());\n+\n+        POOL_CAPACITY = capacity;\n+    }","path":"jetty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipHandler.java","position":120,"original_position":120,"commit_id":"5554f3ad44b14cec7aa5bb9c2525a1b1f333fca3","original_commit_id":"5554f3ad44b14cec7aa5bb9c2525a1b1f333fca3","user":{"login":"gregw","id":70829,"node_id":"MDQ6VXNlcjcwODI5","avatar_url":"https://avatars2.githubusercontent.com/u/70829?v=4","gravatar_id":"","url":"https://api.github.com/users/gregw","html_url":"https://github.com/gregw","followers_url":"https://api.github.com/users/gregw/followers","following_url":"https://api.github.com/users/gregw/following{/other_user}","gists_url":"https://api.github.com/users/gregw/gists{/gist_id}","starred_url":"https://api.github.com/users/gregw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregw/subscriptions","organizations_url":"https://api.github.com/users/gregw/orgs","repos_url":"https://api.github.com/users/gregw/repos","events_url":"https://api.github.com/users/gregw/events{/privacy}","received_events_url":"https://api.github.com/users/gregw/received_events","type":"User","site_admin":false},"body":"I agree that both is not necessary.  But I'd prefer a setter for capacity, mostly because that will be more often used and easy to do in XML etc.\r\n\r\nInstead of `setDeflaterPool`  have a protected `newDeflaterPool(int capacity)` method that users can override if they want.","created_at":"2018-08-10T02:41:42Z","updated_at":"2018-08-10T02:41:43Z","html_url":"https://github.com/eclipse/jetty.project/pull/2784#discussion_r209131771","pull_request_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/2784","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments/209131771"},"html":{"href":"https://github.com/eclipse/jetty.project/pull/2784#discussion_r209131771"},"pull_request":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/2784"}},"in_reply_to_id":209006458},"pull_request":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/2784","id":206927455,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2OTI3NDU1","html_url":"https://github.com/eclipse/jetty.project/pull/2784","diff_url":"https://github.com/eclipse/jetty.project/pull/2784.diff","patch_url":"https://github.com/eclipse/jetty.project/pull/2784.patch","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2784","number":2784,"state":"open","locked":false,"title":"Issue #300 - Implement Deflater Pool","user":{"login":"lachlan-roberts","id":19250643,"node_id":"MDQ6VXNlcjE5MjUwNjQz","avatar_url":"https://avatars0.githubusercontent.com/u/19250643?v=4","gravatar_id":"","url":"https://api.github.com/users/lachlan-roberts","html_url":"https://github.com/lachlan-roberts","followers_url":"https://api.github.com/users/lachlan-roberts/followers","following_url":"https://api.github.com/users/lachlan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/lachlan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlan-roberts/subscriptions","organizations_url":"https://api.github.com/users/lachlan-roberts/orgs","repos_url":"https://api.github.com/users/lachlan-roberts/repos","events_url":"https://api.github.com/users/lachlan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/lachlan-roberts/received_events","type":"User","site_admin":false},"body":"Removed the ThreadLocal pooling of deflaters in GzipHandler in favour of a new DeflaterPool class\r\nGzipHttpOutputInterceptor.GzipBufferCB now recycles the Deflater in onCompleteFailure()\r\nadded benchmark for the DeflaterPool\r\n\r\n#300 ","created_at":"2018-08-08T08:19:09Z","updated_at":"2018-08-10T02:41:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be0280196eee396dac41bc434abf037f714f9166","assignee":{"login":"lachlan-roberts","id":19250643,"node_id":"MDQ6VXNlcjE5MjUwNjQz","avatar_url":"https://avatars0.githubusercontent.com/u/19250643?v=4","gravatar_id":"","url":"https://api.github.com/users/lachlan-roberts","html_url":"https://github.com/lachlan-roberts","followers_url":"https://api.github.com/users/lachlan-roberts/followers","following_url":"https://api.github.com/users/lachlan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/lachlan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlan-roberts/subscriptions","organizations_url":"https://api.github.com/users/lachlan-roberts/orgs","repos_url":"https://api.github.com/users/lachlan-roberts/repos","events_url":"https://api.github.com/users/lachlan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/lachlan-roberts/received_events","type":"User","site_admin":false},"assignees":[{"login":"lachlan-roberts","id":19250643,"node_id":"MDQ6VXNlcjE5MjUwNjQz","avatar_url":"https://avatars0.githubusercontent.com/u/19250643?v=4","gravatar_id":"","url":"https://api.github.com/users/lachlan-roberts","html_url":"https://github.com/lachlan-roberts","followers_url":"https://api.github.com/users/lachlan-roberts/followers","following_url":"https://api.github.com/users/lachlan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/lachlan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlan-roberts/subscriptions","organizations_url":"https://api.github.com/users/lachlan-roberts/orgs","repos_url":"https://api.github.com/users/lachlan-roberts/repos","events_url":"https://api.github.com/users/lachlan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/lachlan-roberts/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/2784/commits","review_comments_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/2784/comments","review_comment_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2784/comments","statuses_url":"https://api.github.com/repos/eclipse/jetty.project/statuses/5554f3ad44b14cec7aa5bb9c2525a1b1f333fca3","head":{"label":"lachlan-roberts:jetty-9.4.x-300-Deflater-ObjectPool","ref":"jetty-9.4.x-300-Deflater-ObjectPool","sha":"5554f3ad44b14cec7aa5bb9c2525a1b1f333fca3","user":{"login":"lachlan-roberts","id":19250643,"node_id":"MDQ6VXNlcjE5MjUwNjQz","avatar_url":"https://avatars0.githubusercontent.com/u/19250643?v=4","gravatar_id":"","url":"https://api.github.com/users/lachlan-roberts","html_url":"https://github.com/lachlan-roberts","followers_url":"https://api.github.com/users/lachlan-roberts/followers","following_url":"https://api.github.com/users/lachlan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/lachlan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlan-roberts/subscriptions","organizations_url":"https://api.github.com/users/lachlan-roberts/orgs","repos_url":"https://api.github.com/users/lachlan-roberts/repos","events_url":"https://api.github.com/users/lachlan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/lachlan-roberts/received_events","type":"User","site_admin":false},"repo":{"id":123038728,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwMzg3Mjg=","name":"jetty.project","full_name":"lachlan-roberts/jetty.project","owner":{"login":"lachlan-roberts","id":19250643,"node_id":"MDQ6VXNlcjE5MjUwNjQz","avatar_url":"https://avatars0.githubusercontent.com/u/19250643?v=4","gravatar_id":"","url":"https://api.github.com/users/lachlan-roberts","html_url":"https://github.com/lachlan-roberts","followers_url":"https://api.github.com/users/lachlan-roberts/followers","following_url":"https://api.github.com/users/lachlan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/lachlan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlan-roberts/subscriptions","organizations_url":"https://api.github.com/users/lachlan-roberts/orgs","repos_url":"https://api.github.com/users/lachlan-roberts/repos","events_url":"https://api.github.com/users/lachlan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/lachlan-roberts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lachlan-roberts/jetty.project","description":"Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more","fork":true,"url":"https://api.github.com/repos/lachlan-roberts/jetty.project","forks_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/forks","keys_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/teams","hooks_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/hooks","issue_events_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/issues/events{/number}","events_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/events","assignees_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/assignees{/user}","branches_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/branches{/branch}","tags_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/tags","blobs_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/refs{/sha}","trees_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/statuses/{sha}","languages_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/languages","stargazers_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/stargazers","contributors_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/contributors","subscribers_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/subscribers","subscription_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/subscription","commits_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/commits{/sha}","git_commits_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/commits{/sha}","comments_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/comments{/number}","issue_comment_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/issues/comments{/number}","contents_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/contents/{+path}","compare_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/merges","archive_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/downloads","issues_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/issues{/number}","pulls_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/pulls{/number}","milestones_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/milestones{/number}","notifications_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/labels{/name}","releases_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/releases{/id}","deployments_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/deployments","created_at":"2018-02-26T22:23:22Z","updated_at":"2018-08-07T02:30:41Z","pushed_at":"2018-08-09T06:22:38Z","git_url":"git://github.com/lachlan-roberts/jetty.project.git","ssh_url":"git@github.com:lachlan-roberts/jetty.project.git","clone_url":"https://github.com/lachlan-roberts/jetty.project.git","svn_url":"https://github.com/lachlan-roberts/jetty.project","homepage":"https://www.eclipse.org/jetty","size":114053,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"jetty-9.4.x"}},"base":{"label":"eclipse:jetty-9.4.x","ref":"jetty-9.4.x","sha":"ee68e7fdec98117d2d98bf34823439ca9fd7c4da","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":2045207,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ1MjA3","name":"jetty.project","full_name":"eclipse/jetty.project","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/jetty.project","description":"Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more","fork":false,"url":"https://api.github.com/repos/eclipse/jetty.project","forks_url":"https://api.github.com/repos/eclipse/jetty.project/forks","keys_url":"https://api.github.com/repos/eclipse/jetty.project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/jetty.project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/jetty.project/teams","hooks_url":"https://api.github.com/repos/eclipse/jetty.project/hooks","issue_events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/jetty.project/events","assignees_url":"https://api.github.com/repos/eclipse/jetty.project/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/jetty.project/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/jetty.project/tags","blobs_url":"https://api.github.com/repos/eclipse/jetty.project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/jetty.project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/jetty.project/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/jetty.project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/jetty.project/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/jetty.project/languages","stargazers_url":"https://api.github.com/repos/eclipse/jetty.project/stargazers","contributors_url":"https://api.github.com/repos/eclipse/jetty.project/contributors","subscribers_url":"https://api.github.com/repos/eclipse/jetty.project/subscribers","subscription_url":"https://api.github.com/repos/eclipse/jetty.project/subscription","commits_url":"https://api.github.com/repos/eclipse/jetty.project/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/jetty.project/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/jetty.project/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/jetty.project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/jetty.project/merges","archive_url":"https://api.github.com/repos/eclipse/jetty.project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/jetty.project/downloads","issues_url":"https://api.github.com/repos/eclipse/jetty.project/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/jetty.project/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/jetty.project/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/jetty.project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/jetty.project/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/jetty.project/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/jetty.project/deployments","created_at":"2011-07-14T01:11:57Z","updated_at":"2018-08-09T18:25:24Z","pushed_at":"2018-08-09T12:12:04Z","git_url":"git://github.com/eclipse/jetty.project.git","ssh_url":"git@github.com:eclipse/jetty.project.git","clone_url":"https://github.com/eclipse/jetty.project.git","svn_url":"https://github.com/eclipse/jetty.project","homepage":"https://www.eclipse.org/jetty","size":117444,"stargazers_count":2117,"watchers_count":2117,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1220,"mirror_url":null,"archived":false,"open_issues_count":378,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1220,"open_issues":378,"watchers":2117,"default_branch":"jetty-9.4.x"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/2784"},"html":{"href":"https://github.com/eclipse/jetty.project/pull/2784"},"issue":{"href":"https://api.github.com/repos/eclipse/jetty.project/issues/2784"},"comments":{"href":"https://api.github.com/repos/eclipse/jetty.project/issues/2784/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/2784/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/2784/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/jetty.project/statuses/5554f3ad44b14cec7aa5bb9c2525a1b1f333fca3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gregw"}}