{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/omr/pulls/comments/232079946","pull_request_review_id":173196704,"id":232079946,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjA3OTk0Ng==","diff_hunk":"@@ -153,50 +153,41 @@ look at a 'standalone' build, which hooks Eclipse OMR up to the its testing syst\n only.\n \n ### Basic configuration and compile\n-To build standalone Eclipse OMR, run the following commands from the top of the\n-source tree. The top of the Eclipse OMR source tree is the directory that contains\n-run_configure.mk.\n+To build standalone Eclipse OMR, run the following commands from the root of the\n+source tree. For more detailed instructions please read `docs/BuildingWithCmake.md`.","path":"README.md","position":8,"original_position":8,"commit_id":"268ec6cd264bae79e0c8d1a1efca021f37278f46","original_commit_id":"268ec6cd264bae79e0c8d1a1efca021f37278f46","user":{"login":"Leonardo2718","id":6710130,"node_id":"MDQ6VXNlcjY3MTAxMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6710130?v=4","gravatar_id":"","url":"https://api.github.com/users/Leonardo2718","html_url":"https://github.com/Leonardo2718","followers_url":"https://api.github.com/users/Leonardo2718/followers","following_url":"https://api.github.com/users/Leonardo2718/following{/other_user}","gists_url":"https://api.github.com/users/Leonardo2718/gists{/gist_id}","starred_url":"https://api.github.com/users/Leonardo2718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leonardo2718/subscriptions","organizations_url":"https://api.github.com/users/Leonardo2718/orgs","repos_url":"https://api.github.com/users/Leonardo2718/repos","events_url":"https://api.github.com/users/Leonardo2718/events{/privacy}","received_events_url":"https://api.github.com/users/Leonardo2718/received_events","type":"User","site_admin":false},"body":"The path should be `doc/BuildingWithCMake.md` (`doc` not `docs`).\r\n\r\nAlso, can the file path here be made into a link?","created_at":"2018-11-08T22:11:51Z","updated_at":"2018-11-08T22:11:56Z","html_url":"https://github.com/eclipse/omr/pull/3166#discussion_r232079946","pull_request_url":"https://api.github.com/repos/eclipse/omr/pulls/3166","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments/232079946"},"html":{"href":"https://github.com/eclipse/omr/pull/3166#discussion_r232079946"},"pull_request":{"href":"https://api.github.com/repos/eclipse/omr/pulls/3166"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/3166","id":229506924,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTA2OTI0","html_url":"https://github.com/eclipse/omr/pull/3166","diff_url":"https://github.com/eclipse/omr/pull/3166.diff","patch_url":"https://github.com/eclipse/omr/pull/3166.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/3166","number":3166,"state":"open","locked":false,"title":"WIP Cleanup CMake defines and modify the README.md","user":{"login":"charliegracie","id":15161849,"node_id":"MDQ6VXNlcjE1MTYxODQ5","avatar_url":"https://avatars3.githubusercontent.com/u/15161849?v=4","gravatar_id":"","url":"https://api.github.com/users/charliegracie","html_url":"https://github.com/charliegracie","followers_url":"https://api.github.com/users/charliegracie/followers","following_url":"https://api.github.com/users/charliegracie/following{/other_user}","gists_url":"https://api.github.com/users/charliegracie/gists{/gist_id}","starred_url":"https://api.github.com/users/charliegracie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliegracie/subscriptions","organizations_url":"https://api.github.com/users/charliegracie/orgs","repos_url":"https://api.github.com/users/charliegracie/repos","events_url":"https://api.github.com/users/charliegracie/events{/privacy}","received_events_url":"https://api.github.com/users/charliegracie/received_events","type":"User","site_admin":false},"body":"Clean up a bunch of CMake defines in the config, caches and correct some defaults.\r\n\r\nModify the README.md to use CMake to build instead of auto-tools","created_at":"2018-11-08T21:00:31Z","updated_at":"2018-11-08T22:11:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdb464745eb6a7cf613913902b52ebb03cc7741a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":479821033,"node_id":"MDU6TGFiZWw0Nzk4MjEwMzM=","url":"https://api.github.com/repos/eclipse/omr/labels/build%20/%20configure","name":"build / configure","color":"fbca04","default":false},{"id":650663178,"node_id":"MDU6TGFiZWw2NTA2NjMxNzg=","url":"https://api.github.com/repos/eclipse/omr/labels/cmake","name":"cmake","color":"ff087f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/3166/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/3166/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/3166/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/268ec6cd264bae79e0c8d1a1efca021f37278f46","head":{"label":"charliegracie:buildenv","ref":"buildenv","sha":"268ec6cd264bae79e0c8d1a1efca021f37278f46","user":{"login":"charliegracie","id":15161849,"node_id":"MDQ6VXNlcjE1MTYxODQ5","avatar_url":"https://avatars3.githubusercontent.com/u/15161849?v=4","gravatar_id":"","url":"https://api.github.com/users/charliegracie","html_url":"https://github.com/charliegracie","followers_url":"https://api.github.com/users/charliegracie/followers","following_url":"https://api.github.com/users/charliegracie/following{/other_user}","gists_url":"https://api.github.com/users/charliegracie/gists{/gist_id}","starred_url":"https://api.github.com/users/charliegracie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliegracie/subscriptions","organizations_url":"https://api.github.com/users/charliegracie/orgs","repos_url":"https://api.github.com/users/charliegracie/repos","events_url":"https://api.github.com/users/charliegracie/events{/privacy}","received_events_url":"https://api.github.com/users/charliegracie/received_events","type":"User","site_admin":false},"repo":{"id":53158628,"node_id":"MDEwOlJlcG9zaXRvcnk1MzE1ODYyOA==","name":"omr","full_name":"charliegracie/omr","private":false,"owner":{"login":"charliegracie","id":15161849,"node_id":"MDQ6VXNlcjE1MTYxODQ5","avatar_url":"https://avatars3.githubusercontent.com/u/15161849?v=4","gravatar_id":"","url":"https://api.github.com/users/charliegracie","html_url":"https://github.com/charliegracie","followers_url":"https://api.github.com/users/charliegracie/followers","following_url":"https://api.github.com/users/charliegracie/following{/other_user}","gists_url":"https://api.github.com/users/charliegracie/gists{/gist_id}","starred_url":"https://api.github.com/users/charliegracie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliegracie/subscriptions","organizations_url":"https://api.github.com/users/charliegracie/orgs","repos_url":"https://api.github.com/users/charliegracie/repos","events_url":"https://api.github.com/users/charliegracie/events{/privacy}","received_events_url":"https://api.github.com/users/charliegracie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/charliegracie/omr","description":"OMR project","fork":true,"url":"https://api.github.com/repos/charliegracie/omr","forks_url":"https://api.github.com/repos/charliegracie/omr/forks","keys_url":"https://api.github.com/repos/charliegracie/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charliegracie/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charliegracie/omr/teams","hooks_url":"https://api.github.com/repos/charliegracie/omr/hooks","issue_events_url":"https://api.github.com/repos/charliegracie/omr/issues/events{/number}","events_url":"https://api.github.com/repos/charliegracie/omr/events","assignees_url":"https://api.github.com/repos/charliegracie/omr/assignees{/user}","branches_url":"https://api.github.com/repos/charliegracie/omr/branches{/branch}","tags_url":"https://api.github.com/repos/charliegracie/omr/tags","blobs_url":"https://api.github.com/repos/charliegracie/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charliegracie/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charliegracie/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/charliegracie/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charliegracie/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/charliegracie/omr/languages","stargazers_url":"https://api.github.com/repos/charliegracie/omr/stargazers","contributors_url":"https://api.github.com/repos/charliegracie/omr/contributors","subscribers_url":"https://api.github.com/repos/charliegracie/omr/subscribers","subscription_url":"https://api.github.com/repos/charliegracie/omr/subscription","commits_url":"https://api.github.com/repos/charliegracie/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/charliegracie/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/charliegracie/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/charliegracie/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/charliegracie/omr/contents/{+path}","compare_url":"https://api.github.com/repos/charliegracie/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charliegracie/omr/merges","archive_url":"https://api.github.com/repos/charliegracie/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charliegracie/omr/downloads","issues_url":"https://api.github.com/repos/charliegracie/omr/issues{/number}","pulls_url":"https://api.github.com/repos/charliegracie/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/charliegracie/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/charliegracie/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charliegracie/omr/labels{/name}","releases_url":"https://api.github.com/repos/charliegracie/omr/releases{/id}","deployments_url":"https://api.github.com/repos/charliegracie/omr/deployments","created_at":"2016-03-04T18:58:44Z","updated_at":"2018-07-18T19:17:27Z","pushed_at":"2018-11-08T20:57:57Z","git_url":"git://github.com/charliegracie/omr.git","ssh_url":"git@github.com:charliegracie/omr.git","clone_url":"https://github.com/charliegracie/omr.git","svn_url":"https://github.com/charliegracie/omr","homepage":null,"size":29467,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"d5ac94e3d0977e11cdb1aae2d7f1d403e57b9756","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"node_id":"MDEwOlJlcG9zaXRvcnk1MzA3NzQ3OA==","name":"omr","full_name":"eclipse/omr","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2018-11-08T21:29:56Z","pushed_at":"2018-11-08T21:53:25Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"http://www.eclipse.org/omr","size":28816,"stargazers_count":582,"watchers_count":582,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":235,"mirror_url":null,"archived":false,"open_issues_count":515,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":235,"open_issues":515,"watchers":582,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/3166"},"html":{"href":"https://github.com/eclipse/omr/pull/3166"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/3166"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/3166/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/3166/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/3166/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/268ec6cd264bae79e0c8d1a1efca021f37278f46"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Leonardo2718"}}