{"action":"created","comment":{"url":"https://api.github.com/repos/zalando/skipper/pulls/comments/240741898","pull_request_review_id":183842052,"id":240741898,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDc0MTg5OA==","diff_hunk":"@@ -6,13 +6,22 @@ import (\n \t\"regexp\"\n )\n \n+type Regex struct{ *regexp.Regexp }","path":"filters/apiusagemonitoring/pathinfo.go","position":4,"original_position":4,"commit_id":"e31611eea44110f9f42a45d28c7b0a58905529be","original_commit_id":"9d0048ddec1f99f9e20361a4540ff008497a295c","user":{"login":"aryszka","id":733217,"node_id":"MDQ6VXNlcjczMzIxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/733217?v=4","gravatar_id":"","url":"https://api.github.com/users/aryszka","html_url":"https://github.com/aryszka","followers_url":"https://api.github.com/users/aryszka/followers","following_url":"https://api.github.com/users/aryszka/following{/other_user}","gists_url":"https://api.github.com/users/aryszka/gists{/gist_id}","starred_url":"https://api.github.com/users/aryszka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aryszka/subscriptions","organizations_url":"https://api.github.com/users/aryszka/orgs","repos_url":"https://api.github.com/users/aryszka/repos","events_url":"https://api.github.com/users/aryszka/events{/privacy}","received_events_url":"https://api.github.com/users/aryszka/received_events","type":"User","site_admin":false},"body":"following the rule of 'less is more', better keep it just regexp. Oh! Is this type referenced anywhere outside of the filter? Because if not, then we don't need to export it (meaning no need for the capital 'R')","created_at":"2018-12-11T18:44:40Z","updated_at":"2018-12-11T18:44:40Z","html_url":"https://github.com/zalando/skipper/pull/855#discussion_r240741898","pull_request_url":"https://api.github.com/repos/zalando/skipper/pulls/855","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zalando/skipper/pulls/comments/240741898"},"html":{"href":"https://github.com/zalando/skipper/pull/855#discussion_r240741898"},"pull_request":{"href":"https://api.github.com/repos/zalando/skipper/pulls/855"}},"in_reply_to_id":240214131},"pull_request":{"url":"https://api.github.com/repos/zalando/skipper/pulls/855","id":231901755,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTAxNzU1","html_url":"https://github.com/zalando/skipper/pull/855","diff_url":"https://github.com/zalando/skipper/pull/855.diff","patch_url":"https://github.com/zalando/skipper/pull/855.patch","issue_url":"https://api.github.com/repos/zalando/skipper/issues/855","number":855,"state":"open","locked":false,"title":"Clearer JSON Serialization?","user":{"login":"ddufourboivin-zalando","id":39987010,"node_id":"MDQ6VXNlcjM5OTg3MDEw","avatar_url":"https://avatars3.githubusercontent.com/u/39987010?v=4","gravatar_id":"","url":"https://api.github.com/users/ddufourboivin-zalando","html_url":"https://github.com/ddufourboivin-zalando","followers_url":"https://api.github.com/users/ddufourboivin-zalando/followers","following_url":"https://api.github.com/users/ddufourboivin-zalando/following{/other_user}","gists_url":"https://api.github.com/users/ddufourboivin-zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/ddufourboivin-zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddufourboivin-zalando/subscriptions","organizations_url":"https://api.github.com/users/ddufourboivin-zalando/orgs","repos_url":"https://api.github.com/users/ddufourboivin-zalando/repos","events_url":"https://api.github.com/users/ddufourboivin-zalando/events{/privacy}","received_events_url":"https://api.github.com/users/ddufourboivin-zalando/received_events","type":"User","site_admin":false},"body":"Interested in knowing here what you prefer in terms of customised JSON serialization.\r\n\r\n### Before\r\n\r\nImplementing `json.Marshaller` on the complete `pathInfo` struct, using a temporary anonymous struct to bypass only the `Matcher`, serialising the regular expression's string instead of the `regexp.Regexp` struct itself.\r\n\r\n### After\r\nUsing a type definition `Regex` based on `regexp.Regexp` and implementing the `json.Marshaller` interface just for itself, marshalling its string. Using that type definition inside of `pathInfo`.","created_at":"2018-11-19T09:22:05Z","updated_at":"2018-12-11T18:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00ec06b33af939d174fb2e05cfe946eb10096864","assignee":null,"assignees":[],"requested_reviewers":[{"login":"szuecs","id":50872,"node_id":"MDQ6VXNlcjUwODcy","avatar_url":"https://avatars2.githubusercontent.com/u/50872?v=4","gravatar_id":"","url":"https://api.github.com/users/szuecs","html_url":"https://github.com/szuecs","followers_url":"https://api.github.com/users/szuecs/followers","following_url":"https://api.github.com/users/szuecs/following{/other_user}","gists_url":"https://api.github.com/users/szuecs/gists{/gist_id}","starred_url":"https://api.github.com/users/szuecs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szuecs/subscriptions","organizations_url":"https://api.github.com/users/szuecs/orgs","repos_url":"https://api.github.com/users/szuecs/repos","events_url":"https://api.github.com/users/szuecs/events{/privacy}","received_events_url":"https://api.github.com/users/szuecs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":234268905,"node_id":"MDU6TGFiZWwyMzQyNjg5MDU=","url":"https://api.github.com/repos/zalando/skipper/labels/question","name":"question","color":"cc317c","default":true},{"id":869881580,"node_id":"MDU6TGFiZWw4Njk4ODE1ODA=","url":"https://api.github.com/repos/zalando/skipper/labels/refactor","name":"refactor","color":"e88c8b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zalando/skipper/pulls/855/commits","review_comments_url":"https://api.github.com/repos/zalando/skipper/pulls/855/comments","review_comment_url":"https://api.github.com/repos/zalando/skipper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/skipper/issues/855/comments","statuses_url":"https://api.github.com/repos/zalando/skipper/statuses/e31611eea44110f9f42a45d28c7b0a58905529be","head":{"label":"zalando:clearer-json-serialization","ref":"clearer-json-serialization","sha":"e31611eea44110f9f42a45d28c7b0a58905529be","user":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":38812664,"node_id":"MDEwOlJlcG9zaXRvcnkzODgxMjY2NA==","name":"skipper","full_name":"zalando/skipper","private":false,"owner":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zalando/skipper","description":"An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress","fork":false,"url":"https://api.github.com/repos/zalando/skipper","forks_url":"https://api.github.com/repos/zalando/skipper/forks","keys_url":"https://api.github.com/repos/zalando/skipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/skipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/skipper/teams","hooks_url":"https://api.github.com/repos/zalando/skipper/hooks","issue_events_url":"https://api.github.com/repos/zalando/skipper/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/skipper/events","assignees_url":"https://api.github.com/repos/zalando/skipper/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/skipper/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/skipper/tags","blobs_url":"https://api.github.com/repos/zalando/skipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/skipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/skipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/skipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/skipper/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/skipper/languages","stargazers_url":"https://api.github.com/repos/zalando/skipper/stargazers","contributors_url":"https://api.github.com/repos/zalando/skipper/contributors","subscribers_url":"https://api.github.com/repos/zalando/skipper/subscribers","subscription_url":"https://api.github.com/repos/zalando/skipper/subscription","commits_url":"https://api.github.com/repos/zalando/skipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/skipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/skipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/skipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/skipper/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/skipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/skipper/merges","archive_url":"https://api.github.com/repos/zalando/skipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/skipper/downloads","issues_url":"https://api.github.com/repos/zalando/skipper/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/skipper/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/skipper/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/skipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/skipper/labels{/name}","releases_url":"https://api.github.com/repos/zalando/skipper/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/skipper/deployments","created_at":"2015-07-09T09:54:40Z","updated_at":"2018-12-11T15:06:39Z","pushed_at":"2018-12-11T16:56:36Z","git_url":"git://github.com/zalando/skipper.git","ssh_url":"git@github.com:zalando/skipper.git","clone_url":"https://github.com/zalando/skipper.git","svn_url":"https://github.com/zalando/skipper","homepage":"https://opensource.zalando.com/skipper/","size":9235,"stargazers_count":1295,"watchers_count":1295,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":123,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":123,"open_issues":109,"watchers":1295,"default_branch":"master"}},"base":{"label":"zalando:master","ref":"master","sha":"e876b38360667c1d2bfd2338a5c16dfe783fb23f","user":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":38812664,"node_id":"MDEwOlJlcG9zaXRvcnkzODgxMjY2NA==","name":"skipper","full_name":"zalando/skipper","private":false,"owner":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zalando/skipper","description":"An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress","fork":false,"url":"https://api.github.com/repos/zalando/skipper","forks_url":"https://api.github.com/repos/zalando/skipper/forks","keys_url":"https://api.github.com/repos/zalando/skipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/skipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/skipper/teams","hooks_url":"https://api.github.com/repos/zalando/skipper/hooks","issue_events_url":"https://api.github.com/repos/zalando/skipper/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/skipper/events","assignees_url":"https://api.github.com/repos/zalando/skipper/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/skipper/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/skipper/tags","blobs_url":"https://api.github.com/repos/zalando/skipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/skipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/skipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/skipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/skipper/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/skipper/languages","stargazers_url":"https://api.github.com/repos/zalando/skipper/stargazers","contributors_url":"https://api.github.com/repos/zalando/skipper/contributors","subscribers_url":"https://api.github.com/repos/zalando/skipper/subscribers","subscription_url":"https://api.github.com/repos/zalando/skipper/subscription","commits_url":"https://api.github.com/repos/zalando/skipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/skipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/skipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/skipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/skipper/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/skipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/skipper/merges","archive_url":"https://api.github.com/repos/zalando/skipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/skipper/downloads","issues_url":"https://api.github.com/repos/zalando/skipper/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/skipper/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/skipper/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/skipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/skipper/labels{/name}","releases_url":"https://api.github.com/repos/zalando/skipper/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/skipper/deployments","created_at":"2015-07-09T09:54:40Z","updated_at":"2018-12-11T15:06:39Z","pushed_at":"2018-12-11T16:56:36Z","git_url":"git://github.com/zalando/skipper.git","ssh_url":"git@github.com:zalando/skipper.git","clone_url":"https://github.com/zalando/skipper.git","svn_url":"https://github.com/zalando/skipper","homepage":"https://opensource.zalando.com/skipper/","size":9235,"stargazers_count":1295,"watchers_count":1295,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":123,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":123,"open_issues":109,"watchers":1295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/skipper/pulls/855"},"html":{"href":"https://github.com/zalando/skipper/pull/855"},"issue":{"href":"https://api.github.com/repos/zalando/skipper/issues/855"},"comments":{"href":"https://api.github.com/repos/zalando/skipper/issues/855/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/skipper/pulls/855/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/skipper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/skipper/pulls/855/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/skipper/statuses/e31611eea44110f9f42a45d28c7b0a58905529be"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aryszka"}}