{"action":"created","comment":{"url":"https://api.github.com/repos/kimai/kimai/pulls/comments/167402152","pull_request_review_id":95625442,"id":167402152,"diff_hunk":"@@ -569,31 +569,32 @@ function($activity) {\n         $data['userID'] = $_REQUEST['userID'];\n \n         // check if the posted time values are possible\n-        $validateDate = new Zend_Validate_Date(array('format' => 'dd.MM.yyyy'));\n-        $validateTime = new Zend_Validate_Date(array('format' => 'HH:mm:ss'));\n-\n-        if (!$validateDate->isValid($_REQUEST['start_day'])) {\n-            $errors['start_day'] = $kga['lang']['TimeDateInputError'];\n-        }\n-\n-        if (!$validateTime->isValid($_REQUEST['start_time'])) {\n-            $_REQUEST['start_time'] = $_REQUEST['start_time'] . ':00';\n-            if (!$validateTime->isValid($_REQUEST['start_time'])) {\n-                $errors['start_time'] = $kga['lang']['TimeDateInputError'];\n-            }\n-        }\n-\n-        if ($_REQUEST['end_day'] != '' && !$validateDate->isValid($_REQUEST['end_day'])) {\n-            $errors['end_day'] = $kga['lang']['TimeDateInputError'];\n-        }\n-\n-        if ($_REQUEST['end_time'] != '' && !$validateTime->isValid($_REQUEST['end_time'])) {\n-            $_REQUEST['end_time'] = $_REQUEST['end_time'] . ':00';\n-            if (!$validateTime->isValid($_REQUEST['end_time'])) {\n-                $errors['end_time'] = $kga['lang']['TimeDateInputError'];\n-            }\n-        }\n-\n+     \tKimai_Logger::logfile(\"outdate: \".$_REQUEST['end_day'] .' '. $_REQUEST['end_time'].', ' .$kga->getDateFormat(3).' H:i:s');","path":"extensions/ki_timesheets/processor.php","position":29,"original_position":29,"commit_id":"32fbf29a5e4de189da52b4d67979652586b85ebc","original_commit_id":"32fbf29a5e4de189da52b4d67979652586b85ebc","user":{"login":"kevinpapst","id":533162,"avatar_url":"https://avatars0.githubusercontent.com/u/533162?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinpapst","html_url":"https://github.com/kevinpapst","followers_url":"https://api.github.com/users/kevinpapst/followers","following_url":"https://api.github.com/users/kevinpapst/following{/other_user}","gists_url":"https://api.github.com/users/kevinpapst/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinpapst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinpapst/subscriptions","organizations_url":"https://api.github.com/users/kevinpapst/orgs","repos_url":"https://api.github.com/users/kevinpapst/repos","events_url":"https://api.github.com/users/kevinpapst/events{/privacy}","received_events_url":"https://api.github.com/users/kevinpapst/received_events","type":"User","site_admin":false},"body":"do we need all these log calls?","created_at":"2018-02-10T15:52:47Z","updated_at":"2018-02-10T15:53:46Z","html_url":"https://github.com/kimai/kimai/pull/1111#discussion_r167402152","pull_request_url":"https://api.github.com/repos/kimai/kimai/pulls/1111","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kimai/kimai/pulls/comments/167402152"},"html":{"href":"https://github.com/kimai/kimai/pull/1111#discussion_r167402152"},"pull_request":{"href":"https://api.github.com/repos/kimai/kimai/pulls/1111"}}},"pull_request":{"url":"https://api.github.com/repos/kimai/kimai/pulls/1111","id":168323957,"html_url":"https://github.com/kimai/kimai/pull/1111","diff_url":"https://github.com/kimai/kimai/pull/1111.diff","patch_url":"https://github.com/kimai/kimai/pull/1111.patch","issue_url":"https://api.github.com/repos/kimai/kimai/issues/1111","number":1111,"state":"open","locked":false,"title":"Develop","user":{"login":"thedayse","id":13942194,"avatar_url":"https://avatars1.githubusercontent.com/u/13942194?v=4","gravatar_id":"","url":"https://api.github.com/users/thedayse","html_url":"https://github.com/thedayse","followers_url":"https://api.github.com/users/thedayse/followers","following_url":"https://api.github.com/users/thedayse/following{/other_user}","gists_url":"https://api.github.com/users/thedayse/gists{/gist_id}","starred_url":"https://api.github.com/users/thedayse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedayse/subscriptions","organizations_url":"https://api.github.com/users/thedayse/orgs","repos_url":"https://api.github.com/users/thedayse/repos","events_url":"https://api.github.com/users/thedayse/events{/privacy}","received_events_url":"https://api.github.com/users/thedayse/received_events","type":"User","site_admin":false},"body":"Changes proposed in this pull request:\r\n\r\n- remove phpjs library\r\n- update jquery ui and add i18n datapicker\r\n- set a global javascript var with the users date format used to format and validate dates in the timesheet entry\r\n- use the duration to set the endtime if the enddate is blank\r\n\r\nReason for this pull request:\r\n- Because nobody where I work will use this software if the dates are d.m.Y We need Y-m-d\r\n","created_at":"2018-02-09T19:33:33Z","updated_at":"2018-02-10T15:53:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b89a7f5227ccc94a113dcfe07a0ebae33d2cbea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kimai/kimai/pulls/1111/commits","review_comments_url":"https://api.github.com/repos/kimai/kimai/pulls/1111/comments","review_comment_url":"https://api.github.com/repos/kimai/kimai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kimai/kimai/issues/1111/comments","statuses_url":"https://api.github.com/repos/kimai/kimai/statuses/32fbf29a5e4de189da52b4d67979652586b85ebc","head":{"label":"thedayse:develop","ref":"develop","sha":"32fbf29a5e4de189da52b4d67979652586b85ebc","user":{"login":"thedayse","id":13942194,"avatar_url":"https://avatars1.githubusercontent.com/u/13942194?v=4","gravatar_id":"","url":"https://api.github.com/users/thedayse","html_url":"https://github.com/thedayse","followers_url":"https://api.github.com/users/thedayse/followers","following_url":"https://api.github.com/users/thedayse/following{/other_user}","gists_url":"https://api.github.com/users/thedayse/gists{/gist_id}","starred_url":"https://api.github.com/users/thedayse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedayse/subscriptions","organizations_url":"https://api.github.com/users/thedayse/orgs","repos_url":"https://api.github.com/users/thedayse/repos","events_url":"https://api.github.com/users/thedayse/events{/privacy}","received_events_url":"https://api.github.com/users/thedayse/received_events","type":"User","site_admin":false},"repo":{"id":119724342,"name":"kimai","full_name":"thedayse/kimai","owner":{"login":"thedayse","id":13942194,"avatar_url":"https://avatars1.githubusercontent.com/u/13942194?v=4","gravatar_id":"","url":"https://api.github.com/users/thedayse","html_url":"https://github.com/thedayse","followers_url":"https://api.github.com/users/thedayse/followers","following_url":"https://api.github.com/users/thedayse/following{/other_user}","gists_url":"https://api.github.com/users/thedayse/gists{/gist_id}","starred_url":"https://api.github.com/users/thedayse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedayse/subscriptions","organizations_url":"https://api.github.com/users/thedayse/orgs","repos_url":"https://api.github.com/users/thedayse/repos","events_url":"https://api.github.com/users/thedayse/events{/privacy}","received_events_url":"https://api.github.com/users/thedayse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thedayse/kimai","description":"Kimai open source time tracking","fork":true,"url":"https://api.github.com/repos/thedayse/kimai","forks_url":"https://api.github.com/repos/thedayse/kimai/forks","keys_url":"https://api.github.com/repos/thedayse/kimai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thedayse/kimai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thedayse/kimai/teams","hooks_url":"https://api.github.com/repos/thedayse/kimai/hooks","issue_events_url":"https://api.github.com/repos/thedayse/kimai/issues/events{/number}","events_url":"https://api.github.com/repos/thedayse/kimai/events","assignees_url":"https://api.github.com/repos/thedayse/kimai/assignees{/user}","branches_url":"https://api.github.com/repos/thedayse/kimai/branches{/branch}","tags_url":"https://api.github.com/repos/thedayse/kimai/tags","blobs_url":"https://api.github.com/repos/thedayse/kimai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thedayse/kimai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thedayse/kimai/git/refs{/sha}","trees_url":"https://api.github.com/repos/thedayse/kimai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thedayse/kimai/statuses/{sha}","languages_url":"https://api.github.com/repos/thedayse/kimai/languages","stargazers_url":"https://api.github.com/repos/thedayse/kimai/stargazers","contributors_url":"https://api.github.com/repos/thedayse/kimai/contributors","subscribers_url":"https://api.github.com/repos/thedayse/kimai/subscribers","subscription_url":"https://api.github.com/repos/thedayse/kimai/subscription","commits_url":"https://api.github.com/repos/thedayse/kimai/commits{/sha}","git_commits_url":"https://api.github.com/repos/thedayse/kimai/git/commits{/sha}","comments_url":"https://api.github.com/repos/thedayse/kimai/comments{/number}","issue_comment_url":"https://api.github.com/repos/thedayse/kimai/issues/comments{/number}","contents_url":"https://api.github.com/repos/thedayse/kimai/contents/{+path}","compare_url":"https://api.github.com/repos/thedayse/kimai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thedayse/kimai/merges","archive_url":"https://api.github.com/repos/thedayse/kimai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thedayse/kimai/downloads","issues_url":"https://api.github.com/repos/thedayse/kimai/issues{/number}","pulls_url":"https://api.github.com/repos/thedayse/kimai/pulls{/number}","milestones_url":"https://api.github.com/repos/thedayse/kimai/milestones{/number}","notifications_url":"https://api.github.com/repos/thedayse/kimai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thedayse/kimai/labels{/name}","releases_url":"https://api.github.com/repos/thedayse/kimai/releases{/id}","deployments_url":"https://api.github.com/repos/thedayse/kimai/deployments","created_at":"2018-01-31T18:11:14Z","updated_at":"2018-01-31T18:11:29Z","pushed_at":"2018-02-10T15:00:12Z","git_url":"git://github.com/thedayse/kimai.git","ssh_url":"git@github.com:thedayse/kimai.git","clone_url":"https://github.com/thedayse/kimai.git","svn_url":"https://github.com/thedayse/kimai","homepage":"http://www.kimai.org","size":62806,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kimai:develop","ref":"develop","sha":"1827efbbff5f494ccd6398ef39507a84bfd7f567","user":{"login":"kimai","id":981996,"avatar_url":"https://avatars0.githubusercontent.com/u/981996?v=4","gravatar_id":"","url":"https://api.github.com/users/kimai","html_url":"https://github.com/kimai","followers_url":"https://api.github.com/users/kimai/followers","following_url":"https://api.github.com/users/kimai/following{/other_user}","gists_url":"https://api.github.com/users/kimai/gists{/gist_id}","starred_url":"https://api.github.com/users/kimai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimai/subscriptions","organizations_url":"https://api.github.com/users/kimai/orgs","repos_url":"https://api.github.com/users/kimai/repos","events_url":"https://api.github.com/users/kimai/events{/privacy}","received_events_url":"https://api.github.com/users/kimai/received_events","type":"Organization","site_admin":false},"repo":{"id":2212377,"name":"kimai","full_name":"kimai/kimai","owner":{"login":"kimai","id":981996,"avatar_url":"https://avatars0.githubusercontent.com/u/981996?v=4","gravatar_id":"","url":"https://api.github.com/users/kimai","html_url":"https://github.com/kimai","followers_url":"https://api.github.com/users/kimai/followers","following_url":"https://api.github.com/users/kimai/following{/other_user}","gists_url":"https://api.github.com/users/kimai/gists{/gist_id}","starred_url":"https://api.github.com/users/kimai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimai/subscriptions","organizations_url":"https://api.github.com/users/kimai/orgs","repos_url":"https://api.github.com/users/kimai/repos","events_url":"https://api.github.com/users/kimai/events{/privacy}","received_events_url":"https://api.github.com/users/kimai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kimai/kimai","description":"Kimai open source time tracking","fork":false,"url":"https://api.github.com/repos/kimai/kimai","forks_url":"https://api.github.com/repos/kimai/kimai/forks","keys_url":"https://api.github.com/repos/kimai/kimai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kimai/kimai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kimai/kimai/teams","hooks_url":"https://api.github.com/repos/kimai/kimai/hooks","issue_events_url":"https://api.github.com/repos/kimai/kimai/issues/events{/number}","events_url":"https://api.github.com/repos/kimai/kimai/events","assignees_url":"https://api.github.com/repos/kimai/kimai/assignees{/user}","branches_url":"https://api.github.com/repos/kimai/kimai/branches{/branch}","tags_url":"https://api.github.com/repos/kimai/kimai/tags","blobs_url":"https://api.github.com/repos/kimai/kimai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kimai/kimai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kimai/kimai/git/refs{/sha}","trees_url":"https://api.github.com/repos/kimai/kimai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kimai/kimai/statuses/{sha}","languages_url":"https://api.github.com/repos/kimai/kimai/languages","stargazers_url":"https://api.github.com/repos/kimai/kimai/stargazers","contributors_url":"https://api.github.com/repos/kimai/kimai/contributors","subscribers_url":"https://api.github.com/repos/kimai/kimai/subscribers","subscription_url":"https://api.github.com/repos/kimai/kimai/subscription","commits_url":"https://api.github.com/repos/kimai/kimai/commits{/sha}","git_commits_url":"https://api.github.com/repos/kimai/kimai/git/commits{/sha}","comments_url":"https://api.github.com/repos/kimai/kimai/comments{/number}","issue_comment_url":"https://api.github.com/repos/kimai/kimai/issues/comments{/number}","contents_url":"https://api.github.com/repos/kimai/kimai/contents/{+path}","compare_url":"https://api.github.com/repos/kimai/kimai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kimai/kimai/merges","archive_url":"https://api.github.com/repos/kimai/kimai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kimai/kimai/downloads","issues_url":"https://api.github.com/repos/kimai/kimai/issues{/number}","pulls_url":"https://api.github.com/repos/kimai/kimai/pulls{/number}","milestones_url":"https://api.github.com/repos/kimai/kimai/milestones{/number}","notifications_url":"https://api.github.com/repos/kimai/kimai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kimai/kimai/labels{/name}","releases_url":"https://api.github.com/repos/kimai/kimai/releases{/id}","deployments_url":"https://api.github.com/repos/kimai/kimai/deployments","created_at":"2011-08-15T21:27:11Z","updated_at":"2018-02-10T14:04:18Z","pushed_at":"2018-02-10T14:54:16Z","git_url":"git://github.com/kimai/kimai.git","ssh_url":"git@github.com:kimai/kimai.git","clone_url":"https://github.com/kimai/kimai.git","svn_url":"https://github.com/kimai/kimai","homepage":"http://www.kimai.org","size":62415,"stargazers_count":467,"watchers_count":467,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":249,"mirror_url":null,"archived":false,"open_issues_count":175,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":249,"open_issues":175,"watchers":467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kimai/kimai/pulls/1111"},"html":{"href":"https://github.com/kimai/kimai/pull/1111"},"issue":{"href":"https://api.github.com/repos/kimai/kimai/issues/1111"},"comments":{"href":"https://api.github.com/repos/kimai/kimai/issues/1111/comments"},"review_comments":{"href":"https://api.github.com/repos/kimai/kimai/pulls/1111/comments"},"review_comment":{"href":"https://api.github.com/repos/kimai/kimai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kimai/kimai/pulls/1111/commits"},"statuses":{"href":"https://api.github.com/repos/kimai/kimai/statuses/32fbf29a5e4de189da52b4d67979652586b85ebc"}},"author_association":"NONE"}}
{"actor":{"display_login":"kevinpapst"}}