{"action":"created","comment":{"url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/comments/240584405","pull_request_review_id":183643884,"id":240584405,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDU4NDQwNQ==","diff_hunk":"@@ -82,16 +82,14 @@ - (void)streamScreenshot\n   CGFloat compressionQuality = FBConfiguration.mjpegServerScreenshotQuality / 100.0f;\n   id<XCTestManager_ManagerInterface> proxy = [FBXCTestDaemonsProxy testRunnerProxy];\n   dispatch_semaphore_t sem = dispatch_semaphore_create(0);\n-  [proxy _XCT_setAXTimeout:SCREENSHOT_TIMEOUT reply:^(int res) {","path":"WebDriverAgentLib/Utilities/FBMjpegServer.m","position":4,"original_position":4,"commit_id":"280d7afe3058a98ca34095621a1306a3e330a6da","original_commit_id":"280d7afe3058a98ca34095621a1306a3e330a6da","user":{"login":"mykola-mokhnach","id":7767781,"node_id":"MDQ6VXNlcjc3Njc3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"body":"should we also remove the unused SCREENSHOT_TIMEOUT constant?","created_at":"2018-12-11T12:10:35Z","updated_at":"2018-12-11T12:10:35Z","html_url":"https://github.com/appium/WebDriverAgent/pull/132#discussion_r240584405","pull_request_url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/132","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/comments/240584405"},"html":{"href":"https://github.com/appium/WebDriverAgent/pull/132#discussion_r240584405"},"pull_request":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/132"}}},"pull_request":{"url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/132","id":237625620,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjI1NjIw","html_url":"https://github.com/appium/WebDriverAgent/pull/132","diff_url":"https://github.com/appium/WebDriverAgent/pull/132.diff","patch_url":"https://github.com/appium/WebDriverAgent/pull/132.patch","issue_url":"https://api.github.com/repos/appium/WebDriverAgent/issues/132","number":132,"state":"open","locked":false,"title":"Removed AX Timeout","user":{"login":"danielpaulussauce","id":31534945,"node_id":"MDQ6VXNlcjMxNTM0OTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/31534945?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpaulussauce","html_url":"https://github.com/danielpaulussauce","followers_url":"https://api.github.com/users/danielpaulussauce/followers","following_url":"https://api.github.com/users/danielpaulussauce/following{/other_user}","gists_url":"https://api.github.com/users/danielpaulussauce/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpaulussauce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpaulussauce/subscriptions","organizations_url":"https://api.github.com/users/danielpaulussauce/orgs","repos_url":"https://api.github.com/users/danielpaulussauce/repos","events_url":"https://api.github.com/users/danielpaulussauce/events{/privacy}","received_events_url":"https://api.github.com/users/danielpaulussauce/received_events","type":"User","site_admin":false},"body":"## Problem\r\nThe AX Timeout and the fact that MJPEG Screenshots are taken on the main thread, were causing Appium Sessions to fail on real devices. \r\nSteps to reproduce:\r\n1. Start WDA\r\n2. Forward local port to 9100 on device\r\n3. Start MJPEG Stream using nc localhost localport\r\n4. Wait for at least one Screenshot to be taken. \r\n4. Starting any Appium test will deadlock even if MJPEG is inactive again.\r\n## Solution\r\nRemove AX Timeout.\r\n","created_at":"2018-12-11T10:31:11Z","updated_at":"2018-12-11T12:10:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"716009e0127b885ee03c3dd883ea3895bacb5f95","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/132/commits","review_comments_url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/132/comments","review_comment_url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/WebDriverAgent/issues/132/comments","statuses_url":"https://api.github.com/repos/appium/WebDriverAgent/statuses/280d7afe3058a98ca34095621a1306a3e330a6da","head":{"label":"danielpaulussauce:removeAXTimeout","ref":"removeAXTimeout","sha":"280d7afe3058a98ca34095621a1306a3e330a6da","user":{"login":"danielpaulussauce","id":31534945,"node_id":"MDQ6VXNlcjMxNTM0OTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/31534945?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpaulussauce","html_url":"https://github.com/danielpaulussauce","followers_url":"https://api.github.com/users/danielpaulussauce/followers","following_url":"https://api.github.com/users/danielpaulussauce/following{/other_user}","gists_url":"https://api.github.com/users/danielpaulussauce/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpaulussauce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpaulussauce/subscriptions","organizations_url":"https://api.github.com/users/danielpaulussauce/orgs","repos_url":"https://api.github.com/users/danielpaulussauce/repos","events_url":"https://api.github.com/users/danielpaulussauce/events{/privacy}","received_events_url":"https://api.github.com/users/danielpaulussauce/received_events","type":"User","site_admin":false},"repo":{"id":161316857,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEzMTY4NTc=","name":"WebDriverAgent","full_name":"danielpaulussauce/WebDriverAgent","private":false,"owner":{"login":"danielpaulussauce","id":31534945,"node_id":"MDQ6VXNlcjMxNTM0OTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/31534945?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpaulussauce","html_url":"https://github.com/danielpaulussauce","followers_url":"https://api.github.com/users/danielpaulussauce/followers","following_url":"https://api.github.com/users/danielpaulussauce/following{/other_user}","gists_url":"https://api.github.com/users/danielpaulussauce/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpaulussauce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpaulussauce/subscriptions","organizations_url":"https://api.github.com/users/danielpaulussauce/orgs","repos_url":"https://api.github.com/users/danielpaulussauce/repos","events_url":"https://api.github.com/users/danielpaulussauce/events{/privacy}","received_events_url":"https://api.github.com/users/danielpaulussauce/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danielpaulussauce/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":true,"url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent","forks_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/danielpaulussauce/WebDriverAgent/deployments","created_at":"2018-12-11T10:27:34Z","updated_at":"2018-12-11T10:27:37Z","pushed_at":"2018-12-11T10:28:08Z","git_url":"git://github.com/danielpaulussauce/WebDriverAgent.git","ssh_url":"git@github.com:danielpaulussauce/WebDriverAgent.git","clone_url":"https://github.com/danielpaulussauce/WebDriverAgent.git","svn_url":"https://github.com/danielpaulussauce/WebDriverAgent","homepage":null,"size":16772,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"e36114f9f770520fbd9b3f9c608ce8d7ed69d44c","user":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":84954452,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk1NDQ1Mg==","name":"WebDriverAgent","full_name":"appium/WebDriverAgent","private":false,"owner":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/appium/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":true,"url":"https://api.github.com/repos/appium/WebDriverAgent","forks_url":"https://api.github.com/repos/appium/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/appium/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/appium/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/appium/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/appium/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/appium/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/appium/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/appium/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/appium/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/appium/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/appium/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/appium/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/appium/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/appium/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/appium/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/appium/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/appium/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/appium/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/appium/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/appium/WebDriverAgent/deployments","created_at":"2017-03-14T13:50:31Z","updated_at":"2018-12-03T12:23:07Z","pushed_at":"2018-12-11T10:31:12Z","git_url":"git://github.com/appium/WebDriverAgent.git","ssh_url":"git@github.com:appium/WebDriverAgent.git","clone_url":"https://github.com/appium/WebDriverAgent.git","svn_url":"https://github.com/appium/WebDriverAgent","homepage":null,"size":16772,"stargazers_count":22,"watchers_count":22,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":36,"open_issues":1,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/132"},"html":{"href":"https://github.com/appium/WebDriverAgent/pull/132"},"issue":{"href":"https://api.github.com/repos/appium/WebDriverAgent/issues/132"},"comments":{"href":"https://api.github.com/repos/appium/WebDriverAgent/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/appium/WebDriverAgent/statuses/280d7afe3058a98ca34095621a1306a3e330a6da"}},"author_association":"NONE"}}
{"actor":{"display_login":"mykola-mokhnach"}}