{"action":"closed","number":1332,"pull_request":{"url":"https://api.github.com/repos/heketi/heketi/pulls/1332","id":210916932,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTE2OTMy","html_url":"https://github.com/heketi/heketi/pull/1332","diff_url":"https://github.com/heketi/heketi/pull/1332.diff","patch_url":"https://github.com/heketi/heketi/pull/1332.patch","issue_url":"https://api.github.com/repos/heketi/heketi/issues/1332","number":1332,"state":"closed","locked":false,"title":"executors: prevent pvcreate/vgcreate/lvcreate from displaying an interactive prompt","user":{"login":"nixpanic","id":400257,"node_id":"MDQ6VXNlcjQwMDI1Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/400257?v=4","gravatar_id":"","url":"https://api.github.com/users/nixpanic","html_url":"https://github.com/nixpanic","followers_url":"https://api.github.com/users/nixpanic/followers","following_url":"https://api.github.com/users/nixpanic/following{/other_user}","gists_url":"https://api.github.com/users/nixpanic/gists{/gist_id}","starred_url":"https://api.github.com/users/nixpanic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nixpanic/subscriptions","organizations_url":"https://api.github.com/users/nixpanic/orgs","repos_url":"https://api.github.com/users/nixpanic/repos","events_url":"https://api.github.com/users/nixpanic/events{/privacy}","received_events_url":"https://api.github.com/users/nixpanic/received_events","type":"User","site_admin":false},"body":"### What does this PR achieve? Why do we need it?\r\n\r\nIn certain circumstances LVM commands can prompt the user for a\r\nconfirmation. Users will not be able to answer the prompt in case Heketi\r\nexecutes the commands. By passing the `-qq` parameter to the LVM\r\ncommands, the default answer for the prompt will be no and the command\r\nexits with a failure.\r\n\r\n### Does this PR fix issues?\r\n\r\nFixes: gluster/gluster-kubernetes#497\r\n\r\n### Notes for the reviewer\r\n\r\nThis is very similar to commit 9c40a0e5 that fixed #1244.\r\n","created_at":"2018-08-25T19:10:12Z","updated_at":"2018-08-30T11:17:50Z","closed_at":"2018-08-30T11:17:50Z","merged_at":"2018-08-30T11:17:50Z","merge_commit_sha":"981012e5b9ea95700b5c6d2ffe0f1cb4a1227198","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heketi/heketi/pulls/1332/commits","review_comments_url":"https://api.github.com/repos/heketi/heketi/pulls/1332/comments","review_comment_url":"https://api.github.com/repos/heketi/heketi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heketi/heketi/issues/1332/comments","statuses_url":"https://api.github.com/repos/heketi/heketi/statuses/4c4854e0cc41a8f59fbe098ac2f4fc90a846b3be","head":{"label":"nixpanic:pr/no-prompt-on-pvcreate","ref":"pr/no-prompt-on-pvcreate","sha":"4c4854e0cc41a8f59fbe098ac2f4fc90a846b3be","user":{"login":"nixpanic","id":400257,"node_id":"MDQ6VXNlcjQwMDI1Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/400257?v=4","gravatar_id":"","url":"https://api.github.com/users/nixpanic","html_url":"https://github.com/nixpanic","followers_url":"https://api.github.com/users/nixpanic/followers","following_url":"https://api.github.com/users/nixpanic/following{/other_user}","gists_url":"https://api.github.com/users/nixpanic/gists{/gist_id}","starred_url":"https://api.github.com/users/nixpanic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nixpanic/subscriptions","organizations_url":"https://api.github.com/users/nixpanic/orgs","repos_url":"https://api.github.com/users/nixpanic/repos","events_url":"https://api.github.com/users/nixpanic/events{/privacy}","received_events_url":"https://api.github.com/users/nixpanic/received_events","type":"User","site_admin":false},"repo":{"id":61882111,"node_id":"MDEwOlJlcG9zaXRvcnk2MTg4MjExMQ==","name":"heketi","full_name":"nixpanic/heketi","owner":{"login":"nixpanic","id":400257,"node_id":"MDQ6VXNlcjQwMDI1Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/400257?v=4","gravatar_id":"","url":"https://api.github.com/users/nixpanic","html_url":"https://github.com/nixpanic","followers_url":"https://api.github.com/users/nixpanic/followers","following_url":"https://api.github.com/users/nixpanic/following{/other_user}","gists_url":"https://api.github.com/users/nixpanic/gists{/gist_id}","starred_url":"https://api.github.com/users/nixpanic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nixpanic/subscriptions","organizations_url":"https://api.github.com/users/nixpanic/orgs","repos_url":"https://api.github.com/users/nixpanic/repos","events_url":"https://api.github.com/users/nixpanic/events{/privacy}","received_events_url":"https://api.github.com/users/nixpanic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nixpanic/heketi","description":"RESTful based volume management framework for GlusterFS","fork":true,"url":"https://api.github.com/repos/nixpanic/heketi","forks_url":"https://api.github.com/repos/nixpanic/heketi/forks","keys_url":"https://api.github.com/repos/nixpanic/heketi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nixpanic/heketi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nixpanic/heketi/teams","hooks_url":"https://api.github.com/repos/nixpanic/heketi/hooks","issue_events_url":"https://api.github.com/repos/nixpanic/heketi/issues/events{/number}","events_url":"https://api.github.com/repos/nixpanic/heketi/events","assignees_url":"https://api.github.com/repos/nixpanic/heketi/assignees{/user}","branches_url":"https://api.github.com/repos/nixpanic/heketi/branches{/branch}","tags_url":"https://api.github.com/repos/nixpanic/heketi/tags","blobs_url":"https://api.github.com/repos/nixpanic/heketi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nixpanic/heketi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nixpanic/heketi/git/refs{/sha}","trees_url":"https://api.github.com/repos/nixpanic/heketi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nixpanic/heketi/statuses/{sha}","languages_url":"https://api.github.com/repos/nixpanic/heketi/languages","stargazers_url":"https://api.github.com/repos/nixpanic/heketi/stargazers","contributors_url":"https://api.github.com/repos/nixpanic/heketi/contributors","subscribers_url":"https://api.github.com/repos/nixpanic/heketi/subscribers","subscription_url":"https://api.github.com/repos/nixpanic/heketi/subscription","commits_url":"https://api.github.com/repos/nixpanic/heketi/commits{/sha}","git_commits_url":"https://api.github.com/repos/nixpanic/heketi/git/commits{/sha}","comments_url":"https://api.github.com/repos/nixpanic/heketi/comments{/number}","issue_comment_url":"https://api.github.com/repos/nixpanic/heketi/issues/comments{/number}","contents_url":"https://api.github.com/repos/nixpanic/heketi/contents/{+path}","compare_url":"https://api.github.com/repos/nixpanic/heketi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nixpanic/heketi/merges","archive_url":"https://api.github.com/repos/nixpanic/heketi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nixpanic/heketi/downloads","issues_url":"https://api.github.com/repos/nixpanic/heketi/issues{/number}","pulls_url":"https://api.github.com/repos/nixpanic/heketi/pulls{/number}","milestones_url":"https://api.github.com/repos/nixpanic/heketi/milestones{/number}","notifications_url":"https://api.github.com/repos/nixpanic/heketi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nixpanic/heketi/labels{/name}","releases_url":"https://api.github.com/repos/nixpanic/heketi/releases{/id}","deployments_url":"https://api.github.com/repos/nixpanic/heketi/deployments","created_at":"2016-06-24T12:12:13Z","updated_at":"2018-05-16T09:41:12Z","pushed_at":"2018-08-30T09:26:41Z","git_url":"git://github.com/nixpanic/heketi.git","ssh_url":"git@github.com:nixpanic/heketi.git","clone_url":"https://github.com/nixpanic/heketi.git","svn_url":"https://github.com/nixpanic/heketi","homepage":"","size":20804,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"heketi:master","ref":"master","sha":"c6c8b77ba3bec16efe5dca896229f958f8a49275","user":{"login":"heketi","id":12890374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODkwMzc0","avatar_url":"https://avatars0.githubusercontent.com/u/12890374?v=4","gravatar_id":"","url":"https://api.github.com/users/heketi","html_url":"https://github.com/heketi","followers_url":"https://api.github.com/users/heketi/followers","following_url":"https://api.github.com/users/heketi/following{/other_user}","gists_url":"https://api.github.com/users/heketi/gists{/gist_id}","starred_url":"https://api.github.com/users/heketi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heketi/subscriptions","organizations_url":"https://api.github.com/users/heketi/orgs","repos_url":"https://api.github.com/users/heketi/repos","events_url":"https://api.github.com/users/heketi/events{/privacy}","received_events_url":"https://api.github.com/users/heketi/received_events","type":"Organization","site_admin":false},"repo":{"id":37446835,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ0NjgzNQ==","name":"heketi","full_name":"heketi/heketi","owner":{"login":"heketi","id":12890374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODkwMzc0","avatar_url":"https://avatars0.githubusercontent.com/u/12890374?v=4","gravatar_id":"","url":"https://api.github.com/users/heketi","html_url":"https://github.com/heketi","followers_url":"https://api.github.com/users/heketi/followers","following_url":"https://api.github.com/users/heketi/following{/other_user}","gists_url":"https://api.github.com/users/heketi/gists{/gist_id}","starred_url":"https://api.github.com/users/heketi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heketi/subscriptions","organizations_url":"https://api.github.com/users/heketi/orgs","repos_url":"https://api.github.com/users/heketi/repos","events_url":"https://api.github.com/users/heketi/events{/privacy}","received_events_url":"https://api.github.com/users/heketi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heketi/heketi","description":"RESTful based volume management framework for GlusterFS","fork":false,"url":"https://api.github.com/repos/heketi/heketi","forks_url":"https://api.github.com/repos/heketi/heketi/forks","keys_url":"https://api.github.com/repos/heketi/heketi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heketi/heketi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heketi/heketi/teams","hooks_url":"https://api.github.com/repos/heketi/heketi/hooks","issue_events_url":"https://api.github.com/repos/heketi/heketi/issues/events{/number}","events_url":"https://api.github.com/repos/heketi/heketi/events","assignees_url":"https://api.github.com/repos/heketi/heketi/assignees{/user}","branches_url":"https://api.github.com/repos/heketi/heketi/branches{/branch}","tags_url":"https://api.github.com/repos/heketi/heketi/tags","blobs_url":"https://api.github.com/repos/heketi/heketi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heketi/heketi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heketi/heketi/git/refs{/sha}","trees_url":"https://api.github.com/repos/heketi/heketi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heketi/heketi/statuses/{sha}","languages_url":"https://api.github.com/repos/heketi/heketi/languages","stargazers_url":"https://api.github.com/repos/heketi/heketi/stargazers","contributors_url":"https://api.github.com/repos/heketi/heketi/contributors","subscribers_url":"https://api.github.com/repos/heketi/heketi/subscribers","subscription_url":"https://api.github.com/repos/heketi/heketi/subscription","commits_url":"https://api.github.com/repos/heketi/heketi/commits{/sha}","git_commits_url":"https://api.github.com/repos/heketi/heketi/git/commits{/sha}","comments_url":"https://api.github.com/repos/heketi/heketi/comments{/number}","issue_comment_url":"https://api.github.com/repos/heketi/heketi/issues/comments{/number}","contents_url":"https://api.github.com/repos/heketi/heketi/contents/{+path}","compare_url":"https://api.github.com/repos/heketi/heketi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heketi/heketi/merges","archive_url":"https://api.github.com/repos/heketi/heketi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heketi/heketi/downloads","issues_url":"https://api.github.com/repos/heketi/heketi/issues{/number}","pulls_url":"https://api.github.com/repos/heketi/heketi/pulls{/number}","milestones_url":"https://api.github.com/repos/heketi/heketi/milestones{/number}","notifications_url":"https://api.github.com/repos/heketi/heketi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heketi/heketi/labels{/name}","releases_url":"https://api.github.com/repos/heketi/heketi/releases{/id}","deployments_url":"https://api.github.com/repos/heketi/heketi/deployments","created_at":"2015-06-15T06:10:11Z","updated_at":"2018-08-30T09:23:16Z","pushed_at":"2018-08-30T11:17:50Z","git_url":"git://github.com/heketi/heketi.git","ssh_url":"git@github.com:heketi/heketi.git","clone_url":"https://github.com/heketi/heketi.git","svn_url":"https://github.com/heketi/heketi","homepage":"","size":20688,"stargazers_count":651,"watchers_count":651,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":201,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":201,"open_issues":202,"watchers":651,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heketi/heketi/pulls/1332"},"html":{"href":"https://github.com/heketi/heketi/pull/1332"},"issue":{"href":"https://api.github.com/repos/heketi/heketi/issues/1332"},"comments":{"href":"https://api.github.com/repos/heketi/heketi/issues/1332/comments"},"review_comments":{"href":"https://api.github.com/repos/heketi/heketi/pulls/1332/comments"},"review_comment":{"href":"https://api.github.com/repos/heketi/heketi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heketi/heketi/pulls/1332/commits"},"statuses":{"href":"https://api.github.com/repos/heketi/heketi/statuses/4c4854e0cc41a8f59fbe098ac2f4fc90a846b3be"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"obnoxxx","id":8081179,"node_id":"MDQ6VXNlcjgwODExNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8081179?v=4","gravatar_id":"","url":"https://api.github.com/users/obnoxxx","html_url":"https://github.com/obnoxxx","followers_url":"https://api.github.com/users/obnoxxx/followers","following_url":"https://api.github.com/users/obnoxxx/following{/other_user}","gists_url":"https://api.github.com/users/obnoxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/obnoxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obnoxxx/subscriptions","organizations_url":"https://api.github.com/users/obnoxxx/orgs","repos_url":"https://api.github.com/users/obnoxxx/repos","events_url":"https://api.github.com/users/obnoxxx/events{/privacy}","received_events_url":"https://api.github.com/users/obnoxxx/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":6,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"obnoxxx"}}