{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23931","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23931/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23931/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23931/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23931","id":300375248,"number":23931,"title":"[p-event] Fix test to work with latest typescript","user":{"login":"Flarna","id":18708370,"avatar_url":"https://avatars3.githubusercontent.com/u/18708370?v=4","gravatar_id":"","url":"https://api.github.com/users/Flarna","html_url":"https://github.com/Flarna","followers_url":"https://api.github.com/users/Flarna/followers","following_url":"https://api.github.com/users/Flarna/following{/other_user}","gists_url":"https://api.github.com/users/Flarna/gists{/gist_id}","starred_url":"https://api.github.com/users/Flarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flarna/subscriptions","organizations_url":"https://api.github.com/users/Flarna/orgs","repos_url":"https://api.github.com/users/Flarna/repos","events_url":"https://api.github.com/users/Flarna/events{/privacy}","received_events_url":"https://api.github.com/users/Flarna/received_events","type":"User","site_admin":false},"labels":[{"id":397523192,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-26T19:58:56Z","updated_at":"2018-02-26T20:38:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23931","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23931","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23931.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23931.patch"},"body":"- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [ ] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n- [ ] Provide a URL to documentation or source code which provides context for the suggested changes: \r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\nNo change in definition itself, just fix test as I got following error:\r\n```\r\nError: c:/Workspaces/GithubForks/DefinitelyTyped/types/p-event/p-event-tests.ts:11:5\r\nERROR: 11:5  expect  TypeScript@next compile error:\r\nProperty 'addEventListener' in type 'MyDomEmitter' is not assignable to the same property in base type 'EventTarget'.\r\n  Type '(type: \"foo\", listener?: ((event: Event) => void) | undefined) => void' is not assignable to type '(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListener...'.\r\n    Types of parameters 'listener' and 'listener' are incompatible.\r\n      Type 'EventListenerOrEventListenerObject' is not assignable to type '((event: Event) => void) | undefined'.\r\n        Type 'EventListenerObject' is not assignable to type '((event: Event) => void) | undefined'.\r\n          Type 'EventListenerObject' is not assignable to type '(event: Event) => void'.\r\n            Type 'EventListenerObject' provides no match for the signature '(event: Event): void'.\r\nERROR: 18:5  expect  TypeScript@next compile error:\r\nProperty 'removeEventListener' in type 'MyDomEmitter' is not assignable to the same property in base type 'EventTarget'.\r\n  Type '(type: \"foo\", listener?: ((event: Event) => void) | undefined) => void' is not assignable to type '(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOpt...'.\r\n    Types of parameters 'listener' and 'listener' are incompatible.\r\n      Type 'EventListenerOrEventListenerObject' is not assignable to type '((event: Event) => void) | undefined'.\r\n        Type 'EventListenerObject' is not assignable to type '((event: Event) => void) | undefined'.\r\n          Type 'EventListenerObject' is not assignable to type '(event: Event) => void'.\r\n            Type 'EventListenerObject' provides no match for the signature '(event: Event): void'.\r\n```"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/368642028","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23931#issuecomment-368642028","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23931","id":368642028,"user":{"login":"typescript-bot","id":23042052,"avatar_url":"https://avatars0.githubusercontent.com/u/23042052?v=4","gravatar_id":"","url":"https://api.github.com/users/typescript-bot","html_url":"https://github.com/typescript-bot","followers_url":"https://api.github.com/users/typescript-bot/followers","following_url":"https://api.github.com/users/typescript-bot/following{/other_user}","gists_url":"https://api.github.com/users/typescript-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/typescript-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typescript-bot/subscriptions","organizations_url":"https://api.github.com/users/typescript-bot/orgs","repos_url":"https://api.github.com/users/typescript-bot/repos","events_url":"https://api.github.com/users/typescript-bot/events{/privacy}","received_events_url":"https://api.github.com/users/typescript-bot/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T20:38:52Z","updated_at":"2018-02-26T20:38:52Z","author_association":"NONE","body":"<!--header {\"slug\":\"welcome\"} headerend-->\r\n@Flarna Thank you for submitting this PR!\n\n🔔 @BendingBender - please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23931/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on.\n\nIf no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.\r\n<!--footer bot @ 2018-2-26 12:38:52 footerend-->"}}
{"actor":{"display_login":"typescript-bot"}}