{"push_id":2948030920,"size":25,"distinct_size":25,"ref":"refs/heads/fix-local-resources-android","head":"7d6c8987ce1274ab760d419fd07250768467601d","before":"a8739c0a7373180e825dab872fcd165636d7ece4","commits":[{"sha":"0f78b13d13ed4d239c6b2c3672f9c8f02aec096c","author":{"name":"David Narbutovich","email":"237a820b9a923e3d5e4a1e4c30b709ab409324cd@gmail.com"},"message":"Remove unnecessary import.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/0f78b13d13ed4d239c6b2c3672f9c8f02aec096c"},{"sha":"efd02a307dc9aacad731325d39c325f772371d00","author":{"name":"Sam Oh","email":"e4297a2fee781c2b1a35230f1368ea8ee5f209ad@gmail.com"},"message":"Add missing breaks in converter.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/efd02a307dc9aacad731325d39c325f772371d00"},{"sha":"e08be5b66da99c2e37a84ac5944e2d2005115a02","author":{"name":"Dylan Vann","email":"dd378c4ca75f71f527acddef5b43fc35b68d5b7a@dylanvann.com"},"message":"Fix incorrect icon names in example.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/e08be5b66da99c2e37a84ac5944e2d2005115a02"},{"sha":"52b85ec577db15a3638793e6bc561db360d3f89e","author":{"name":"Dylan Vann","email":"dd378c4ca75f71f527acddef5b43fc35b68d5b7a@dylanvann.com"},"message":"v5.0.4","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/52b85ec577db15a3638793e6bc561db360d3f89e"},{"sha":"6a2fb83b3ec328e5bea2563e7ac18b2455c6d1ef","author":{"name":"Dylan Vann","email":"dd378c4ca75f71f527acddef5b43fc35b68d5b7a@dylanvann.com"},"message":"Remove incorrect focusedName prop.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/6a2fb83b3ec328e5bea2563e7ac18b2455c6d1ef"},{"sha":"5d973a8cec50efdd3c20d05b97dbe59f71677944","author":{"name":"Danish","email":"26b96b03e7b60f782b0d2d94c618b4846ebe7e14@gmail.com"},"message":"Update obsolete compile to implementation and Exclude app dependencies from test configurations.\n\nFIRST OF ALL, I am using this package from npm so I saw that the git repo one commit ahead that is this one https://github.com/DylanVann/react-native-fast-image/commit/f31a44fc07caa7d4635ae83936b8925891a1ab15#diff-7ae5a9093507568eabbf35c3b0665732 where you upgrade to glide 4 with progress listeners. I couldn't submit PR for the version I am using from NPM. so as of now explain of this PR is as follow:\n\nAs React native 0.56.0 is released with MAJOR android changes such as:\n\n-Gradle 3.5.1\n-Compile using Android SDK 26\n-Google Maven repo\n-etc\n\nmore about Change log, specially of Android Here, https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#android-projects-are-now-compiled-using-the-android-26-sdk\nand https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#android-specific-changes\n\nAslo as Per Google new \"Google Play's target API level requirement\", mentioned here  https://developer.android.com/distribute/best-practices/develop/target-sdk\n\n\"Google Play will require that new apps target at least Android 8.0 (API level 26) from August 1, 2018, and that app updates target Android 8.0 from November 1, 2018.\"\n\nIt's clear that Android would be moving to new Gradle and new SDK changes, Thus creating a new type of error that is:\n\n\"Configuration 'compile' is obsolete and has been replaced with 'implementation' or 'Api'\"\n\nmore about the Old and new configuration please see this https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration?utm_source=android-studio#new_configurations\nat the heading of \"Use the new dependency configurations\"\n\nTherefore, all old \"compile\" should be now \"implementation\" or \"provided\" should be \"compileOnly\"\n\nI have tested the with \"compile\" and \"implementation\" in my current release ready product and also by \"renaming\" \"compile\" to \"implementation\".\nAlso tested with higher andorid SDK configs such as of below:\n\n```\next {\n    buildToolsVersion = \"27.0.3\"\n    minSdkVersion = 19\n    compileSdkVersion = 27\n    targetSdkVersion = 27\n    supportLibVersion = \"27.1.1\"\n}\n```\n\nso SDK 27 was also compiled successully. test on Android phone with ADK 23 all looks good. Thus, `react-native-fast-image` was working just fine as intended. thank you so much for this package btw.\n\nTherefore, Please would it be possible to merge as i am sure many new projects and old one are going to update specially Gradle and SDK as of Google new requirements.\n\nrelated mention of Upgrading issue mention here https://github.com/facebook/react-native/issues/20273#issuecomment-405959030\n\nMoreover, if someone still have any issue after upgrading everything successfully, then he should use following in build.gradle under `andorid/build.gradle`\n\n```\n\nsubprojects {\n    afterEvaluate {project ->\n        if (project.hasProperty(\"android\")) {\n            android {\n                compileSdkVersion 27\n                buildToolsVersion '27.0.3'\n                supportLibVersion = \"27.1.1\"\n            }\n        }\n    }\n}\n```\n\nPS: as of exclude part in your build.grade, I am not 100% it will work for example mine app has something like this\n\ncompile project((':react-native-maps')) {\n        exclude group: 'com.google.android.gms', module: 'play-services-base'\n        exclude group: 'com.google.android.gms', module: 'play-services-maps'\n}\ncompile 'com.google.android.gms:play-services-base:10.0.1'\ncompile 'com.google.android.gms:play-services-maps:10.0.1'\n\nafter converting this to\n\nimplementation project(':react-native-maps')\n android.testVariants.all { variant ->\n        variant.getCompileConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-base'\n        variant.getRuntimeConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-base'\n\n        variant.getCompileConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-maps'\n        variant.getCompileConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-maps'\n}\nimplementation 'com.google.android.gms:play-services-base:10.0.1'\nimplementation 'com.google.android.gms:play-services-maps:10.0.1'\n\neverything is working fine for me. so please have a look for your just in case.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/5d973a8cec50efdd3c20d05b97dbe59f71677944"},{"sha":"649e9a8edf9d6788f71fbf1246fe846bb002e5d6","author":{"name":"Danish","email":"26b96b03e7b60f782b0d2d94c618b4846ebe7e14@gmail.com"},"message":"Update obsolete compile to implementation and Exclude app dependencies from test configurations (#250)\n\nFIRST OF ALL, I am using this package from npm so I saw that the git repo one commit ahead that is this one https://github.com/DylanVann/react-native-fast-image/commit/f31a44fc07caa7d4635ae83936b8925891a1ab15#diff-7ae5a9093507568eabbf35c3b0665732 where you upgrade to glide 4 with progress listeners. I couldn't submit PR for the version I am using from NPM. so as of now explain of this PR is as follow:\r\n\r\n\r\nAs React native 0.56.0 is released with MAJOR android changes such as:\r\n\r\n-Gradle 3.5.1\r\n-Compile using Android SDK 26\r\n-Google Maven repo\r\n-etc\r\n\r\nmore about Change log, specially of Android Here, https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#android-projects-are-now-compiled-using-the-android-26-sdk\r\nand https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#android-specific-changes\r\n\r\nAslo as Per Google new \"Google Play's target API level requirement\", mentioned here  https://developer.android.com/distribute/best-practices/develop/target-sdk\r\n\r\n\"Google Play will require that new apps target at least Android 8.0 (API level 26) from August 1, 2018, and that app updates target Android 8.0 from November 1, 2018.\"\r\n\r\nIt's clear that Android would be moving to new Gradle and new SDK changes, Thus creating a new type of error that is:\r\n\r\n\"Configuration 'compile' is obsolete and has been replaced with 'implementation' or 'Api'\" \r\n\r\nmore about the Old and new configuration please see this https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration?utm_source=android-studio#new_configurations \r\nat the heading of \"Use the new dependency configurations\"\r\n\r\nTherefore, all old \"compile\" should be now \"implementation\" or \"provided\" should be \"compileOnly\"\r\n\r\nI have tested the with \"compile\" and \"implementation\" in my current release ready product and also by \"renaming\" \"compile\" to \"implementation\".\r\nAlso tested with higher andorid SDK configs such as of below:\r\n\r\n```\r\next {\r\n    buildToolsVersion = \"27.0.3\"\r\n    minSdkVersion = 19\r\n    compileSdkVersion = 27\r\n    targetSdkVersion = 27\r\n    supportLibVersion = \"27.1.1\"\r\n}\r\n```\r\n\r\nso SDK 27 was also compiled successully. test on Android phone with ADK 23 all looks good. Thus, `react-native-fast-image` was working just fine as intended. thank you so much for this package btw.\r\n\r\nTherefore, Please would it be possible to merge as i am sure many new projects and old one are going to update specially Gradle and SDK as of Google new requirements. \r\n\r\nrelated mention of Upgrading issue mention here https://github.com/facebook/react-native/issues/20273#issuecomment-405959030\r\n\r\n\r\nMoreover, if someone still have any issue after upgrading everything successfully, then he should use following in build.gradle under `andorid/build.gradle`\r\n\r\n```\r\n\r\nsubprojects {\r\n    afterEvaluate {project ->\r\n        if (project.hasProperty(\"android\")) {\r\n            android {\r\n                compileSdkVersion 27\r\n                buildToolsVersion '27.0.3'\r\n                supportLibVersion = \"27.1.1\"\r\n            }\r\n        }\r\n    }\r\n}\r\n```\r\n\r\n\r\nPS: as of exclude part in your build.grade, I am not 100% it will work for example mine app has something like this\r\n\r\ncompile project((':react-native-maps')) {\r\n        exclude group: 'com.google.android.gms', module: 'play-services-base'\r\n        exclude group: 'com.google.android.gms', module: 'play-services-maps'\r\n}\r\ncompile 'com.google.android.gms:play-services-base:10.0.1'\r\ncompile 'com.google.android.gms:play-services-maps:10.0.1'\r\n\r\n\r\nafter converting this to\r\n\r\n\r\nimplementation project(':react-native-maps')\r\n android.testVariants.all { variant ->\r\n        variant.getCompileConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-base'\r\n        variant.getRuntimeConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-base'\r\n\r\n        variant.getCompileConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-maps'\r\n        variant.getCompileConfiguration().exclude group: 'com.google.android.gms', module: 'play-services-maps'\r\n}\r\nimplementation 'com.google.android.gms:play-services-base:10.0.1'\r\nimplementation 'com.google.android.gms:play-services-maps:10.0.1'\r\n\r\n\r\neverything is working fine for me. so please have a look for your just in case.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/649e9a8edf9d6788f71fbf1246fe846bb002e5d6"},{"sha":"a3b581014d0c2f2282e370a58377a63d1a17ba47","author":{"name":"Dylan Vann","email":"dd378c4ca75f71f527acddef5b43fc35b68d5b7a@dylanvann.com"},"message":"Fix build.gradle.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/a3b581014d0c2f2282e370a58377a63d1a17ba47"},{"sha":"b18728db84d09047bf968974d2f9da9e936ffb5d","author":{"name":"Dylan Vann","email":"dd378c4ca75f71f527acddef5b43fc35b68d5b7a@dylanvann.com"},"message":"v5.0.5","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/b18728db84d09047bf968974d2f9da9e936ffb5d"},{"sha":"b8c82c7d5ea7c4abe0b74f8976eb31e5999fc710","author":{"name":"Laurin Quast","email":"1b1a52333dcfbbd2d3beecd2d05ecb1d7141f944@googlemail.com"},"message":"Allow overwriting imageContainer styles.\n\nCloses #286","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/b8c82c7d5ea7c4abe0b74f8976eb31e5999fc710"},{"sha":"0c7e323ef0c818ff0e95f62211ad86058d9f3bb8","author":{"name":"Emanuel Quimper","email":"c1f207d57d9e383e550977b3451ff7ea1f0e0c1d@gmail.com"},"message":"Add cache enum types.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/0c7e323ef0c818ff0e95f62211ad86058d9f3bb8"},{"sha":"845ae631d59b89231a77df194a999fd08e376157","author":{"name":"Dylan Vann","email":"dd378c4ca75f71f527acddef5b43fc35b68d5b7a@dylanvann.com"},"message":"v5.0.7","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/845ae631d59b89231a77df194a999fd08e376157"},{"sha":"c265c7a79a70067a3d1459e4878916fd5a13c2e6","author":{"name":"David Narbutovich","email":"237a820b9a923e3d5e4a1e4c30b709ab409324cd@gmail.com"},"message":"Fix TypeScript types for fallback.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/c265c7a79a70067a3d1459e4878916fd5a13c2e6"},{"sha":"e66d7e0b1fe9c5dcbe5b3a06d9ef4b865c4f959f","author":{"name":"Dylan Vann","email":"dd378c4ca75f71f527acddef5b43fc35b68d5b7a@dylanvann.com"},"message":"Remove unused import in TypeScript types.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/e66d7e0b1fe9c5dcbe5b3a06d9ef4b865c4f959f"},{"sha":"11c7e9e86508be289c57cacda00d687134458e2b","author":{"name":"David Narbutovich","email":"237a820b9a923e3d5e4a1e4c30b709ab409324cd@gmail.com"},"message":"Add Flow type definitions.\n\n* Add flow definitions\r\n\r\n* Fix export default","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/11c7e9e86508be289c57cacda00d687134458e2b"},{"sha":"0087b6c7ca19880a391f435ff443dede84a02f32","author":{"name":"David Narbutovich","email":"237a820b9a923e3d5e4a1e4c30b709ab409324cd@gmail.com"},"message":"Add config files to .npmignore.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/0087b6c7ca19880a391f435ff443dede84a02f32"},{"sha":"828954867467b46adea415a4a27cd50b2858c78e","author":{"name":"Dylan Vann","email":"dd378c4ca75f71f527acddef5b43fc35b68d5b7a@dylanvann.com"},"message":"v5.0.8","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/828954867467b46adea415a4a27cd50b2858c78e"},{"sha":"75a6ce766c7fc2c1dd98a4e8d8c52c3aeeb3d506","author":{"name":"(◕ᴥ◕)","email":"e579f2298d92b73ae75506591d3e85b09cbfdcc6@users.noreply.github.com"},"message":"Handle null view.glideUrl.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/75a6ce766c7fc2c1dd98a4e8d8c52c3aeeb3d506"},{"sha":"c2aa88dd17e4b50154b27c01bb32a2ab7ddb0aac","author":{"name":"Dylan Vann","email":"dd378c4ca75f71f527acddef5b43fc35b68d5b7a@dylanvann.com"},"message":"v5.0.9","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/c2aa88dd17e4b50154b27c01bb32a2ab7ddb0aac"},{"sha":"e68fe53fbeb06bd59670d2ec9faed9fd6215561a","author":{"name":"Dylan Vann","email":"dd378c4ca75f71f527acddef5b43fc35b68d5b7a@dylanvann.com"},"message":"Replace with clean examples.","distinct":true,"url":"https://api.github.com/repos/patrickkempff/react-native-fast-image/commits/e68fe53fbeb06bd59670d2ec9faed9fd6215561a"}]}
{"actor":{"display_login":"patrickkempff"}}