{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/209398890","pull_request_review_id":145415603,"id":209398890,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTM5ODg5MA==","diff_hunk":"@@ -360,12 +361,25 @@ internal static string GetCoreVersionString()\n \n         internal static void GrpcNativeInit()\n         {\n+            if (!IsNativeShutdownAllowed && nativeInitCounter.Count > 0)\n+            {\n+                // Normally grpc_init and grpc_shutdown calls should come in pairs (C core does reference counting),","path":"src/csharp/Grpc.Core/GrpcEnvironment.cs","position":14,"original_position":14,"commit_id":"1b59cc8606026b231394ef648885ef3650d165fe","original_commit_id":"1b59cc8606026b231394ef648885ef3650d165fe","user":{"login":"apolcyn","id":9566254,"node_id":"MDQ6VXNlcjk1NjYyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"body":"yeah I can't really point to one. \r\n\r\nActually, can we not do something like:\r\n\r\n```\r\n{\r\n   if (nativeInitCounter.Increment() == 0) {\r\n     ... call grpc_init()\r\n   }\r\n   return;\r\n}\r\n```\r\n\r\n?","created_at":"2018-08-10T22:31:20Z","updated_at":"2018-08-10T22:31:20Z","html_url":"https://github.com/grpc/grpc/pull/16308#discussion_r209398890","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/16308","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/209398890"},"html":{"href":"https://github.com/grpc/grpc/pull/16308#discussion_r209398890"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/16308"}},"in_reply_to_id":209395849},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/16308","id":207555584,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTU1NTg0","html_url":"https://github.com/grpc/grpc/pull/16308","diff_url":"https://github.com/grpc/grpc/pull/16308.diff","patch_url":"https://github.com/grpc/grpc/pull/16308.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/16308","number":16308,"state":"open","locked":false,"title":"C#: avoid shutdown crash on iOS","user":{"login":"jtattermusch","id":9939684,"node_id":"MDQ6VXNlcjk5Mzk2ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"body":"By skipping grpc_shutdown invocation. This is basically a hack, but it only affects iOS which is still supported by gRPC C# experimentally and this PR should increase the usability.\r\n\r\nTentative fix for https://github.com/grpc/grpc/issues/16294.","created_at":"2018-08-10T09:27:40Z","updated_at":"2018-08-10T22:31:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2789b8d3e26710648930130fa9e108e831da98f","assignee":{"login":"yashykt","id":4181124,"node_id":"MDQ6VXNlcjQxODExMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4181124?v=4","gravatar_id":"","url":"https://api.github.com/users/yashykt","html_url":"https://github.com/yashykt","followers_url":"https://api.github.com/users/yashykt/followers","following_url":"https://api.github.com/users/yashykt/following{/other_user}","gists_url":"https://api.github.com/users/yashykt/gists{/gist_id}","starred_url":"https://api.github.com/users/yashykt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yashykt/subscriptions","organizations_url":"https://api.github.com/users/yashykt/orgs","repos_url":"https://api.github.com/users/yashykt/repos","events_url":"https://api.github.com/users/yashykt/events{/privacy}","received_events_url":"https://api.github.com/users/yashykt/received_events","type":"User","site_admin":false},"assignees":[{"login":"yashykt","id":4181124,"node_id":"MDQ6VXNlcjQxODExMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4181124?v=4","gravatar_id":"","url":"https://api.github.com/users/yashykt","html_url":"https://github.com/yashykt","followers_url":"https://api.github.com/users/yashykt/followers","following_url":"https://api.github.com/users/yashykt/following{/other_user}","gists_url":"https://api.github.com/users/yashykt/gists{/gist_id}","starred_url":"https://api.github.com/users/yashykt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yashykt/subscriptions","organizations_url":"https://api.github.com/users/yashykt/orgs","repos_url":"https://api.github.com/users/yashykt/repos","events_url":"https://api.github.com/users/yashykt/events{/privacy}","received_events_url":"https://api.github.com/users/yashykt/received_events","type":"User","site_admin":false},{"login":"apolcyn","id":9566254,"node_id":"MDQ6VXNlcjk1NjYyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":168238370,"node_id":"MDU6TGFiZWwxNjgyMzgzNzA=","url":"https://api.github.com/repos/grpc/grpc/labels/lang/C%23","name":"lang/C#","color":"fad8c7","default":false},{"id":961831639,"node_id":"MDU6TGFiZWw5NjE4MzE2Mzk=","url":"https://api.github.com/repos/grpc/grpc/labels/release%20notes:%20yes","name":"release notes: yes","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/16308/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/16308/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/16308/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/1b59cc8606026b231394ef648885ef3650d165fe","head":{"label":"jtattermusch:csharp_ios_crash_workaround","ref":"csharp_ios_crash_workaround","sha":"1b59cc8606026b231394ef648885ef3650d165fe","user":{"login":"jtattermusch","id":9939684,"node_id":"MDQ6VXNlcjk5Mzk2ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"repo":{"id":31382470,"node_id":"MDEwOlJlcG9zaXRvcnkzMTM4MjQ3MA==","name":"grpc","full_name":"jtattermusch/grpc","owner":{"login":"jtattermusch","id":9939684,"node_id":"MDQ6VXNlcjk5Mzk2ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtattermusch/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/jtattermusch/grpc","forks_url":"https://api.github.com/repos/jtattermusch/grpc/forks","keys_url":"https://api.github.com/repos/jtattermusch/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtattermusch/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtattermusch/grpc/teams","hooks_url":"https://api.github.com/repos/jtattermusch/grpc/hooks","issue_events_url":"https://api.github.com/repos/jtattermusch/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/jtattermusch/grpc/events","assignees_url":"https://api.github.com/repos/jtattermusch/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/jtattermusch/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/jtattermusch/grpc/tags","blobs_url":"https://api.github.com/repos/jtattermusch/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtattermusch/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtattermusch/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtattermusch/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtattermusch/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/jtattermusch/grpc/languages","stargazers_url":"https://api.github.com/repos/jtattermusch/grpc/stargazers","contributors_url":"https://api.github.com/repos/jtattermusch/grpc/contributors","subscribers_url":"https://api.github.com/repos/jtattermusch/grpc/subscribers","subscription_url":"https://api.github.com/repos/jtattermusch/grpc/subscription","commits_url":"https://api.github.com/repos/jtattermusch/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtattermusch/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtattermusch/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtattermusch/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtattermusch/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/jtattermusch/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtattermusch/grpc/merges","archive_url":"https://api.github.com/repos/jtattermusch/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtattermusch/grpc/downloads","issues_url":"https://api.github.com/repos/jtattermusch/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/jtattermusch/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/jtattermusch/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/jtattermusch/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtattermusch/grpc/labels{/name}","releases_url":"https://api.github.com/repos/jtattermusch/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/jtattermusch/grpc/deployments","created_at":"2015-02-26T18:39:52Z","updated_at":"2018-01-30T09:51:28Z","pushed_at":"2018-08-10T21:52:16Z","git_url":"git://github.com/jtattermusch/grpc.git","ssh_url":"git@github.com:jtattermusch/grpc.git","clone_url":"https://github.com/jtattermusch/grpc.git","svn_url":"https://github.com/jtattermusch/grpc","homepage":"","size":168771,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"69d6694409cc378df0c3cf39ae48943b77c963c4","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTg4MA==","name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2018-08-10T22:26:04Z","pushed_at":"2018-08-10T22:25:16Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"https://grpc.io","size":190483,"stargazers_count":16588,"watchers_count":16588,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3765,"mirror_url":null,"archived":false,"open_issues_count":1048,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3765,"open_issues":1048,"watchers":16588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/16308"},"html":{"href":"https://github.com/grpc/grpc/pull/16308"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/16308"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/16308/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/16308/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/16308/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/1b59cc8606026b231394ef648885ef3650d165fe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"apolcyn"}}