{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/20163","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/20163/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/20163/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/20163/events","html_url":"https://github.com/elastic/kibana/pull/20163","id":334957489,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2Nzk3NTg2","number":20163,"title":"[WIP] Add pluggable panel action tests","user":{"login":"Stacey-Gammon","id":16563603,"node_id":"MDQ6VXNlcjE2NTYzNjAz","avatar_url":"https://avatars3.githubusercontent.com/u/16563603?v=4","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"labels":[{"id":470241449,"node_id":"MDU6TGFiZWw0NzAyNDE0NDk=","url":"https://api.github.com/repos/elastic/kibana/labels/:Sharing","name":":Sharing","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-06-22T17:21:53Z","updated_at":"2018-06-27T15:40:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/20163","html_url":"https://github.com/elastic/kibana/pull/20163","diff_url":"https://github.com/elastic/kibana/pull/20163.diff","patch_url":"https://github.com/elastic/kibana/pull/20163.patch"},"body":"Adds a plugin nested in the test folder to be used for testing purposes.\r\n\r\nAdds a flyout session object that is very similar to the inspector session object - need to sync with @timroes and maybe design on the best way to move forward with that.  Should we allow multiple flyouts open at the same time?  Or only one? And if only one (which is what I would lean towards) we should probably refactor out the inspector session to be a more generic flyout session so pluggable panel actions can easily mount a flyout without it having to specifically be an inspector flyout.\r\n\r\nflyout's should also be allowed to be modal (like dashboard's `add panel`).\r\n\r\nSimilarly I'd like to expose an easy way for panel actions to display a pop up modal, which probably needs a similar session object to ensure there is only one open at any given time.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/400722811","html_url":"https://github.com/elastic/kibana/pull/20163#issuecomment-400722811","issue_url":"https://api.github.com/repos/elastic/kibana/issues/20163","id":400722811,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDcyMjgxMQ==","user":{"login":"Stacey-Gammon","id":16563603,"node_id":"MDQ6VXNlcjE2NTYzNjAz","avatar_url":"https://avatars3.githubusercontent.com/u/16563603?v=4","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T15:40:43Z","updated_at":"2018-06-27T15:40:43Z","author_association":"CONTRIBUTOR","body":"@elastic/kibana-platform - Ideally this infrastructure for the panel actions test would be generalized, so all plugins would have a place to add functional tests (rather than each plugin having it's own folder under `test` which won't be scalable).  If I go down that path I have a couple questions:\r\n\r\n- Are there any plans to deprecate the `--plugin-path` variable?\r\n- Can I list multiple folders for `--plugin-path`?  If so, would it be a comma separated list, or would I pass in multiple `--plugin-path` flags?"}}
{"actor":{"display_login":"Stacey-Gammon"}}