{"action":"created","issue":{"url":"https://api.github.com/repos/serge-sans-paille/frozen/issues/61","repository_url":"https://api.github.com/repos/serge-sans-paille/frozen","labels_url":"https://api.github.com/repos/serge-sans-paille/frozen/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/serge-sans-paille/frozen/issues/61/comments","events_url":"https://api.github.com/repos/serge-sans-paille/frozen/issues/61/events","html_url":"https://github.com/serge-sans-paille/frozen/issues/61","id":387520033,"node_id":"MDU6SXNzdWUzODc1MjAwMzM=","number":61,"title":"pmh.h has a variable name that collides with Qt keywords","user":{"login":"jpan127","id":19752007,"node_id":"MDQ6VXNlcjE5NzUyMDA3","avatar_url":"https://avatars1.githubusercontent.com/u/19752007?v=4","gravatar_id":"","url":"https://api.github.com/users/jpan127","html_url":"https://github.com/jpan127","followers_url":"https://api.github.com/users/jpan127/followers","following_url":"https://api.github.com/users/jpan127/following{/other_user}","gists_url":"https://api.github.com/users/jpan127/gists{/gist_id}","starred_url":"https://api.github.com/users/jpan127/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpan127/subscriptions","organizations_url":"https://api.github.com/users/jpan127/orgs","repos_url":"https://api.github.com/users/jpan127/repos","events_url":"https://api.github.com/users/jpan127/events{/privacy}","received_events_url":"https://api.github.com/users/jpan127/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-04T23:06:44Z","updated_at":"2018-12-08T15:50:35Z","closed_at":"2018-12-08T15:50:35Z","author_association":"NONE","body":"https://github.com/serge-sans-paille/frozen/blob/master/include/frozen/bits/pmh.h#L197\r\n\r\nThe variable name `slots` will fail compilations with any Qt application.  Would it be possible to change it to something else?\r\n\r\nCompiled with clang 6.0, -std=c++17, Ubuntu 16.04.\r\n\r\n```c++\r\n../include/frozen/bits/pmh.h:197:7: warning: declaration does not declare anything [-Wmissing-declarations]\r\n      cvector<std::size_t, decltype(step_one)::bucket_max> slots;\r\n      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n../include/frozen/bits/pmh.h:199:19: error: expected expression\r\n      while (slots.size() < bsize) {\r\n                  ^\r\n../include/frozen/bits/pmh.h:200:48: error: expected expression\r\n        auto slot = hash(key(items[bucket[slots.size()]]), static_cast<size_t>(d.value())) % M;\r\n                                               ^\r\n../include/frozen/bits/pmh.h:200:48: error: expected ']'\r\n../include/frozen/bits/pmh.h:200:42: note: to match this '['\r\n        auto slot = hash(key(items[bucket[slots.size()]]), static_cast<size_t>(d.value())) % M;\r\n                                         ^\r\n../include/frozen/bits/pmh.h:202:59: error: expected expression\r\n        if (H[slot] != UNUSED || !all_different_from(slots, slot)) {\r\n                                                          ^\r\n../include/frozen/bits/pmh.h:203:16: error: expected expression\r\n          slots.clear();\r\n               ^\r\n../include/frozen/bits/pmh.h:208:14: error: expected expression\r\n        slots.push_back(slot);\r\n             ^\r\n../include/frozen/bits/pmh.h:215:10: error: an attribute list cannot appear here\r\n        H[slots[i]] = bucket[i];\r\n         ^~~~~~~~~~\r\n1 warning and 7 errors generated.\r\n```"},"comment":{"url":"https://api.github.com/repos/serge-sans-paille/frozen/issues/comments/445468649","html_url":"https://github.com/serge-sans-paille/frozen/issues/61#issuecomment-445468649","issue_url":"https://api.github.com/repos/serge-sans-paille/frozen/issues/61","id":445468649,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTQ2ODY0OQ==","user":{"login":"serge-sans-paille","id":863807,"node_id":"MDQ6VXNlcjg2MzgwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/863807?v=4","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"created_at":"2018-12-08T15:50:35Z","updated_at":"2018-12-08T15:50:35Z","author_association":"OWNER","body":"Fixed by #62 "}}
{"actor":{"display_login":"serge-sans-paille"}}