{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/188480138","pull_request_review_id":120466650,"id":188480138,"diff_hunk":"@@ -388,20 +392,31 @@ func applyUpstreamTLSSettings(cluster *v2.Cluster, tls *networking.TLSSettings)\n \t\t\t\t\t},\n \t\t\t\t},\n \t\t\t\tValidationContext: certValidationContext,\n+\t\t\t\tAlpnProtocols:     ClusterALPNProtocols,\n \t\t\t},\n \t\t\tSni: tls.Sni,\n \t\t}\n \t}\n+\n+\tif tls.Mode != networking.TLSSettings_DISABLE {\n+\t\t// alpn is set for TLS, so specify h2 configuration.\n+\t\taddHTTP2Options(cluster)\n+\t}","path":"pilot/pkg/networking/core/v1alpha3/cluster.go","position":31,"original_position":31,"commit_id":"ab024da977253778e58832fae033dfc9e299b1d9","original_commit_id":"ab024da977253778e58832fae033dfc9e299b1d9","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"body":"All TLS support alpn, why not all tls?\r\nIf the other side is mtls http1.1, they would negotiate that.","created_at":"2018-05-16T01:17:08Z","updated_at":"2018-05-16T01:17:08Z","html_url":"https://github.com/istio/istio/pull/5618#discussion_r188480138","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/5618","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/188480138"},"html":{"href":"https://github.com/istio/istio/pull/5618#discussion_r188480138"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/5618"}},"in_reply_to_id":188477676},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/5618","id":188265657,"html_url":"https://github.com/istio/istio/pull/5618","diff_url":"https://github.com/istio/istio/pull/5618.diff","patch_url":"https://github.com/istio/istio/pull/5618.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/5618","number":5618,"state":"open","locked":false,"title":"ALPN upgrade to http/2.0","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"body":"Upgrade (m)TLS connection to H2 using ALPN.\r\n\r\nThis was either a regression or perhaps never working before.\r\n\r\n","created_at":"2018-05-15T21:49:28Z","updated_at":"2018-05-16T01:17:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25229321850b8a5b12eee08635c6aec9edd99532","assignee":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"assignees":[{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/5618/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/5618/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/5618/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/ab024da977253778e58832fae033dfc9e299b1d9","head":{"label":"mandarjog:fix_alpn","ref":"fix_alpn","sha":"ab024da977253778e58832fae033dfc9e299b1d9","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"repo":{"id":76583321,"name":"istio","full_name":"mandarjog/istio","owner":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mandarjog/istio","description":"A Service Fabric for Polyglot Microservices","fork":true,"url":"https://api.github.com/repos/mandarjog/istio","forks_url":"https://api.github.com/repos/mandarjog/istio/forks","keys_url":"https://api.github.com/repos/mandarjog/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mandarjog/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mandarjog/istio/teams","hooks_url":"https://api.github.com/repos/mandarjog/istio/hooks","issue_events_url":"https://api.github.com/repos/mandarjog/istio/issues/events{/number}","events_url":"https://api.github.com/repos/mandarjog/istio/events","assignees_url":"https://api.github.com/repos/mandarjog/istio/assignees{/user}","branches_url":"https://api.github.com/repos/mandarjog/istio/branches{/branch}","tags_url":"https://api.github.com/repos/mandarjog/istio/tags","blobs_url":"https://api.github.com/repos/mandarjog/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mandarjog/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mandarjog/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/mandarjog/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mandarjog/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/mandarjog/istio/languages","stargazers_url":"https://api.github.com/repos/mandarjog/istio/stargazers","contributors_url":"https://api.github.com/repos/mandarjog/istio/contributors","subscribers_url":"https://api.github.com/repos/mandarjog/istio/subscribers","subscription_url":"https://api.github.com/repos/mandarjog/istio/subscription","commits_url":"https://api.github.com/repos/mandarjog/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/mandarjog/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/mandarjog/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/mandarjog/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/mandarjog/istio/contents/{+path}","compare_url":"https://api.github.com/repos/mandarjog/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mandarjog/istio/merges","archive_url":"https://api.github.com/repos/mandarjog/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mandarjog/istio/downloads","issues_url":"https://api.github.com/repos/mandarjog/istio/issues{/number}","pulls_url":"https://api.github.com/repos/mandarjog/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/mandarjog/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/mandarjog/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mandarjog/istio/labels{/name}","releases_url":"https://api.github.com/repos/mandarjog/istio/releases{/id}","deployments_url":"https://api.github.com/repos/mandarjog/istio/deployments","created_at":"2016-12-15T18:01:34Z","updated_at":"2017-10-30T13:15:26Z","pushed_at":"2018-05-16T01:15:11Z","git_url":"git://github.com/mandarjog/istio.git","ssh_url":"git@github.com:mandarjog/istio.git","clone_url":"https://github.com/mandarjog/istio.git","svn_url":"https://github.com/mandarjog/istio","homepage":null,"size":133536,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-0.8","ref":"release-0.8","sha":"4a3f00f62b662580eb21610a1ac4818ac5f053da","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-05-16T00:59:26Z","pushed_at":"2018-05-16T01:00:03Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":33101,"stargazers_count":8000,"watchers_count":8000,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1075,"mirror_url":null,"archived":false,"open_issues_count":886,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1075,"open_issues":886,"watchers":8000,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/5618"},"html":{"href":"https://github.com/istio/istio/pull/5618"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/5618"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/5618/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/5618/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/5618/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/ab024da977253778e58832fae033dfc9e299b1d9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mandarjog"}}