{"action":"created","comment":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/165732674","pull_request_review_id":93724522,"id":165732674,"diff_hunk":"@@ -86,7 +91,18 @@ public void testDecommissionBookie() throws Exception {\n          * this decommisionBookie should make sure that there are no\n          * underreplicated ledgers because of this bookie\n          */\n-        bkAdmin.decommissionBookie(Bookie.getBookieAddress(killedBookieConf));\n+        bkAdmin.decommissionBookie(\n+            Bookie.getBookieAddress(killedBookieConf),\n+            () -> {\n+                Auditor auditor = recoveryProcess.getAuditor();\n+                if (null != auditor) {","path":"bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java","position":98,"original_position":49,"commit_id":"b217a143c214bd89dce28a67d3a278773954a6c5","original_commit_id":"b217a143c214bd89dce28a67d3a278773954a6c5","user":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"body":"this is just for safety guard","created_at":"2018-02-02T19:09:31Z","updated_at":"2018-02-02T19:09:31Z","html_url":"https://github.com/apache/bookkeeper/pull/1100#discussion_r165732674","pull_request_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1100","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/165732674"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1100#discussion_r165732674"},"pull_request":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1100"}},"in_reply_to_id":165722458},"pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1100","id":166519799,"html_url":"https://github.com/apache/bookkeeper/pull/1100","diff_url":"https://github.com/apache/bookkeeper/pull/1100.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1100.patch","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1100","number":1100,"state":"open","locked":false,"title":"Improve decomission test","user":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"body":"Descriptions of the changes in this PR:\r\n\r\n- remove the hardcoded 30 seconds wait time\r\n- reduce `openLedgerRereplicationGracePeriod` from 30 seconds to 100 ms\r\n- reenable `testDecommissionBookie` test case (this fixes #502)\r\n\r\nThis change is based on #1099.\r\n\r\n","created_at":"2018-02-01T12:09:13Z","updated_at":"2018-02-02T19:09:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2a4e88cd0933209f494f313662a2ea9f4bb03db","assignee":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"assignees":[{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/apache/bookkeeper/milestones/3","html_url":"https://github.com/apache/bookkeeper/milestone/3","labels_url":"https://api.github.com/repos/apache/bookkeeper/milestones/3/labels","id":2887234,"number":3,"title":"4.7.0","description":"Release 4.7.0","creator":{"login":"jiazhai","id":6348208,"avatar_url":"https://avatars2.githubusercontent.com/u/6348208?v=4","gravatar_id":"","url":"https://api.github.com/users/jiazhai","html_url":"https://github.com/jiazhai","followers_url":"https://api.github.com/users/jiazhai/followers","following_url":"https://api.github.com/users/jiazhai/following{/other_user}","gists_url":"https://api.github.com/users/jiazhai/gists{/gist_id}","starred_url":"https://api.github.com/users/jiazhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiazhai/subscriptions","organizations_url":"https://api.github.com/users/jiazhai/orgs","repos_url":"https://api.github.com/users/jiazhai/repos","events_url":"https://api.github.com/users/jiazhai/events{/privacy}","received_events_url":"https://api.github.com/users/jiazhai/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":239,"state":"open","created_at":"2017-11-04T00:04:40Z","updated_at":"2018-02-02T07:55:31Z","due_on":"2018-02-13T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1100/commits","review_comments_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1100/comments","review_comment_url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1100/comments","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/b217a143c214bd89dce28a67d3a278773954a6c5","head":{"label":"sijie:improve_decomission_test","ref":"improve_decomission_test","sha":"b217a143c214bd89dce28a67d3a278773954a6c5","user":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"repo":{"id":3747333,"name":"bookkeeper","full_name":"sijie/bookkeeper","owner":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sijie/bookkeeper","description":"Mirror of Apache Bookkeeper","fork":true,"url":"https://api.github.com/repos/sijie/bookkeeper","forks_url":"https://api.github.com/repos/sijie/bookkeeper/forks","keys_url":"https://api.github.com/repos/sijie/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sijie/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sijie/bookkeeper/teams","hooks_url":"https://api.github.com/repos/sijie/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/sijie/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/sijie/bookkeeper/events","assignees_url":"https://api.github.com/repos/sijie/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/sijie/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/sijie/bookkeeper/tags","blobs_url":"https://api.github.com/repos/sijie/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sijie/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sijie/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/sijie/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sijie/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/sijie/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/sijie/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/sijie/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/sijie/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/sijie/bookkeeper/subscription","commits_url":"https://api.github.com/repos/sijie/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/sijie/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/sijie/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/sijie/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/sijie/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/sijie/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sijie/bookkeeper/merges","archive_url":"https://api.github.com/repos/sijie/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sijie/bookkeeper/downloads","issues_url":"https://api.github.com/repos/sijie/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/sijie/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/sijie/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/sijie/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sijie/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/sijie/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/sijie/bookkeeper/deployments","created_at":"2012-03-17T11:57:47Z","updated_at":"2018-01-18T17:01:50Z","pushed_at":"2018-02-02T11:24:41Z","git_url":"git://github.com/sijie/bookkeeper.git","ssh_url":"git@github.com:sijie/bookkeeper.git","clone_url":"https://github.com/sijie/bookkeeper.git","svn_url":"https://github.com/sijie/bookkeeper","homepage":null,"size":35426,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5cd311c7bd72273e116533d0c438254b881dd653","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":1575956,"name":"bookkeeper","full_name":"apache/bookkeeper","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/bookkeeper","description":"Apache Bookkeeper","fork":false,"url":"https://api.github.com/repos/apache/bookkeeper","forks_url":"https://api.github.com/repos/apache/bookkeeper/forks","keys_url":"https://api.github.com/repos/apache/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/bookkeeper/teams","hooks_url":"https://api.github.com/repos/apache/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/bookkeeper/events","assignees_url":"https://api.github.com/repos/apache/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/bookkeeper/tags","blobs_url":"https://api.github.com/repos/apache/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/apache/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/bookkeeper/subscription","commits_url":"https://api.github.com/repos/apache/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/bookkeeper/merges","archive_url":"https://api.github.com/repos/apache/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/bookkeeper/downloads","issues_url":"https://api.github.com/repos/apache/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/bookkeeper/deployments","created_at":"2011-04-06T07:00:07Z","updated_at":"2018-02-01T23:34:15Z","pushed_at":"2018-02-02T16:20:51Z","git_url":"git://github.com/apache/bookkeeper.git","ssh_url":"git@github.com:apache/bookkeeper.git","clone_url":"https://github.com/apache/bookkeeper.git","svn_url":"https://github.com/apache/bookkeeper","homepage":"https://bookkeeper.apache.org","size":23988,"stargazers_count":258,"watchers_count":258,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":146,"mirror_url":null,"archived":false,"open_issues_count":175,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":146,"open_issues":175,"watchers":258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1100"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1100"},"issue":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1100"},"comments":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1100/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1100/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1100/commits"},"statuses":{"href":"https://api.github.com/repos/apache/bookkeeper/statuses/b217a143c214bd89dce28a67d3a278773954a6c5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sijie"}}