{"action":"created","comment":{"url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/comments/237655339","pull_request_review_id":180010015,"id":237655339,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzY1NTMzOQ==","diff_hunk":"@@ -56,6 +56,120 @@ public void testTagHoverFromXSType() throws BadLocationException {\n \r\n \t};\r\n \r\n+\t@Test\r\n+\tpublic void testTagHoverForSchemaLocation() throws BadLocationException {\r\n+\t\t// web.xml servlet, servlet-name declares their xs:annotation not in the element\r\n+\t\t// declaration but in type (servletType),\r\n+\t\t// this test check that\r\n+\t\tString xml = \"<?xml version=\\\"1.0\\\" encoding=\\\"utf-8\\\"?>\\r\\n\" + //\r\n+\t\t\t\t\"<invoice xmlns=\\\"http://invoice\\\" xmlns:xsi=\\\"http://www.w3.org/2001/XMLSchema-instance\\\"\\r\\n\"\r\n+\t\t\t\t+ \" xsi:schema|Location=\\\"http://invoice xsd/invoice.xsd \\\">\\r\\n\";\r\n+\t\tString doc = \r\n+\t\t\t\t\"The xsi:schemaLocation attribute can be used in an XML document \" +\r\n+\t\t\t\t\"to reference an XML Schema document that has a target namespace.\\r\\n  \" + \r\n+\t\t\t\t\"```xml  \\r\\n\" +\r\n+\t\t\t\t\"\\r\\n<ns:root xmlns:ns=\\\"http://example.com/ns\\\"\" +\r\n+\t\t\t\t\"  xmlns:xsi=\\\"http://www.w3.org/2001/XMLSchema-instance\\\"\" +\r\n+\t\t\t\t\"  xsi:schemaLocation=\\\"http://example.com/ns example-ns.xsd\\\">\\r\\n \" +\r\n+\t\t\t\t\"  <!-- ... -->\\r\\n  \" +\r\n+\t\t\t\t\"</ns:root>\\r\\n  \" +\r\n+\t\t\t\t\"```\" ;\r\n+\t\tXMLAssert.assertHover(new XMLLanguageService(), xml, null, \"src/test/resources/invoice.xml\",\r\n+\t\t\t\tdoc, null);\r\n+\r\n+\t};\r\n+\r\n+\t@Test\r\n+\tpublic void testTagHoverForNoNamespaceSchemaLocation() throws BadLocationException {\r\n+\t\t// web.xml servlet, servlet-name declares their xs:annotation not in the element\r\n+\t\t// declaration but in type (servletType),\r\n+\t\t// this test check that\r\n+\t\tString xml = \"<?xml version=\\\"1.0\\\" encoding=\\\"utf-8\\\"?>\\r\\n\" + //\r\n+\t\t\t\t\"<invoice xmlns=\\\"http://invoice\\\" xmlns:xsi=\\\"http://www.w3.org/2001/XMLSchema-instance\\\"\\r\\n\"\r\n+\t\t\t\t+ \" xsi:noNamespace|SchemaLocation=\\\"http://invoice xsd/invoice.xsd \\\">\\r\\n\";\r\n+\t\tString doc = \r\n+\t\t\t\t\"The xsi:noNamespaceSchemaLocation attribute can be used in an XML document \" +\r\n+\t\t\t\t\"to reference an XML Schema document that does not have a target namespace.\\r\\n  \" + \r\n+\t\t\t\t\"```xml  \\r\\n\" +\r\n+\t\t\t\t\"\\r\\n<root xmlns:xsi=\\\"http://www.w3.org/2001/XMLSchema-instance\\\"  \"+\r\n+\t\t\t\t\"  xsi:noNamespaceSchemaLocation=\\\"example.xsd\\\">  \\r\\n\" +\r\n+\t\t\t\t\"  <!-- ... -->  \\r\\n\" +\r\n+\t\t\t\t\"</root>  \\r\\n\" +\r\n+\t\t\t\t\"```\" ;\r\n+\t\tXMLAssert.assertHover(new XMLLanguageService(), xml, null, \"src/test/resources/invoice.xml\",\r\n+\t\t\t\tdoc, null);\r\n+\r\n+\t};\r\n+\r\n+\t@Test\r\n+\tpublic void testTagHoverForXSInil() throws BadLocationException {\r\n+\t\t// web.xml servlet, servlet-name declares their xs:annotation not in the element\r\n+\t\t// declaration but in type (servletType),\r\n+\t\t// this test check that\r","path":"org.eclipse.lsp4xml/src/test/java/org/eclipse/lsp4xml/extensions/contentmodel/XMLSchemaHoverExtensionsTest.java","position":53,"original_position":53,"commit_id":"9f5aae770bd817e0c0e37dd98294da21745a2935","original_commit_id":"9f5aae770bd817e0c0e37dd98294da21745a2935","user":{"login":"fbricon","id":148698,"node_id":"MDQ6VXNlcjE0ODY5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/148698?v=4","gravatar_id":"","url":"https://api.github.com/users/fbricon","html_url":"https://github.com/fbricon","followers_url":"https://api.github.com/users/fbricon/followers","following_url":"https://api.github.com/users/fbricon/following{/other_user}","gists_url":"https://api.github.com/users/fbricon/gists{/gist_id}","starred_url":"https://api.github.com/users/fbricon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbricon/subscriptions","organizations_url":"https://api.github.com/users/fbricon/orgs","repos_url":"https://api.github.com/users/fbricon/repos","events_url":"https://api.github.com/users/fbricon/events{/privacy}","received_events_url":"https://api.github.com/users/fbricon/received_events","type":"User","site_admin":false},"body":"checks","created_at":"2018-11-29T20:56:32Z","updated_at":"2018-11-29T20:56:32Z","html_url":"https://github.com/angelozerr/lsp4xml/pull/240#discussion_r237655339","pull_request_url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/240","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/comments/237655339"},"html":{"href":"https://github.com/angelozerr/lsp4xml/pull/240#discussion_r237655339"},"pull_request":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/240"}}},"pull_request":{"url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/240","id":234774520,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Nzc0NTIw","html_url":"https://github.com/angelozerr/lsp4xml/pull/240","diff_url":"https://github.com/angelozerr/lsp4xml/pull/240.diff","patch_url":"https://github.com/angelozerr/lsp4xml/pull/240.patch","issue_url":"https://api.github.com/repos/angelozerr/lsp4xml/issues/240","number":240,"state":"open","locked":false,"title":"Hover show documentation for XSI","user":{"login":"NikolasKomonen","id":32624665,"node_id":"MDQ6VXNlcjMyNjI0NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/32624665?v=4","gravatar_id":"","url":"https://api.github.com/users/NikolasKomonen","html_url":"https://github.com/NikolasKomonen","followers_url":"https://api.github.com/users/NikolasKomonen/followers","following_url":"https://api.github.com/users/NikolasKomonen/following{/other_user}","gists_url":"https://api.github.com/users/NikolasKomonen/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolasKomonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolasKomonen/subscriptions","organizations_url":"https://api.github.com/users/NikolasKomonen/orgs","repos_url":"https://api.github.com/users/NikolasKomonen/repos","events_url":"https://api.github.com/users/NikolasKomonen/events{/privacy}","received_events_url":"https://api.github.com/users/NikolasKomonen/received_events","type":"User","site_admin":false},"body":"Fixes #164","created_at":"2018-11-29T20:24:31Z","updated_at":"2018-11-29T20:56:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3cfef96fa6d18af52a89f713f4d5452260f0942","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/240/commits","review_comments_url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/240/comments","review_comment_url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angelozerr/lsp4xml/issues/240/comments","statuses_url":"https://api.github.com/repos/angelozerr/lsp4xml/statuses/9f5aae770bd817e0c0e37dd98294da21745a2935","head":{"label":"NikolasKomonen:hoverXSI","ref":"hoverXSI","sha":"9f5aae770bd817e0c0e37dd98294da21745a2935","user":{"login":"NikolasKomonen","id":32624665,"node_id":"MDQ6VXNlcjMyNjI0NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/32624665?v=4","gravatar_id":"","url":"https://api.github.com/users/NikolasKomonen","html_url":"https://github.com/NikolasKomonen","followers_url":"https://api.github.com/users/NikolasKomonen/followers","following_url":"https://api.github.com/users/NikolasKomonen/following{/other_user}","gists_url":"https://api.github.com/users/NikolasKomonen/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolasKomonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolasKomonen/subscriptions","organizations_url":"https://api.github.com/users/NikolasKomonen/orgs","repos_url":"https://api.github.com/users/NikolasKomonen/repos","events_url":"https://api.github.com/users/NikolasKomonen/events{/privacy}","received_events_url":"https://api.github.com/users/NikolasKomonen/received_events","type":"User","site_admin":false},"repo":{"id":138757816,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3NTc4MTY=","name":"lsp4xml","full_name":"NikolasKomonen/lsp4xml","private":false,"owner":{"login":"NikolasKomonen","id":32624665,"node_id":"MDQ6VXNlcjMyNjI0NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/32624665?v=4","gravatar_id":"","url":"https://api.github.com/users/NikolasKomonen","html_url":"https://github.com/NikolasKomonen","followers_url":"https://api.github.com/users/NikolasKomonen/followers","following_url":"https://api.github.com/users/NikolasKomonen/following{/other_user}","gists_url":"https://api.github.com/users/NikolasKomonen/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolasKomonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolasKomonen/subscriptions","organizations_url":"https://api.github.com/users/NikolasKomonen/orgs","repos_url":"https://api.github.com/users/NikolasKomonen/repos","events_url":"https://api.github.com/users/NikolasKomonen/events{/privacy}","received_events_url":"https://api.github.com/users/NikolasKomonen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NikolasKomonen/lsp4xml","description":"XML Language Server","fork":true,"url":"https://api.github.com/repos/NikolasKomonen/lsp4xml","forks_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/forks","keys_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/teams","hooks_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/hooks","issue_events_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/issues/events{/number}","events_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/events","assignees_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/assignees{/user}","branches_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/branches{/branch}","tags_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/tags","blobs_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/git/refs{/sha}","trees_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/statuses/{sha}","languages_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/languages","stargazers_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/stargazers","contributors_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/contributors","subscribers_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/subscribers","subscription_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/subscription","commits_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/commits{/sha}","git_commits_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/git/commits{/sha}","comments_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/comments{/number}","issue_comment_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/issues/comments{/number}","contents_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/contents/{+path}","compare_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/merges","archive_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/downloads","issues_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/issues{/number}","pulls_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/pulls{/number}","milestones_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/milestones{/number}","notifications_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/labels{/name}","releases_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/releases{/id}","deployments_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/deployments","created_at":"2018-06-26T15:29:29Z","updated_at":"2018-09-21T13:38:28Z","pushed_at":"2018-11-29T20:23:56Z","git_url":"git://github.com/NikolasKomonen/lsp4xml.git","ssh_url":"git@github.com:NikolasKomonen/lsp4xml.git","clone_url":"https://github.com/NikolasKomonen/lsp4xml.git","svn_url":"https://github.com/NikolasKomonen/lsp4xml","homepage":null,"size":7266,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angelozerr:master","ref":"master","sha":"921459bf4fc9a9ad5c91f781891f0eedad95fc6c","user":{"login":"angelozerr","id":1932211,"node_id":"MDQ6VXNlcjE5MzIyMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1932211?v=4","gravatar_id":"","url":"https://api.github.com/users/angelozerr","html_url":"https://github.com/angelozerr","followers_url":"https://api.github.com/users/angelozerr/followers","following_url":"https://api.github.com/users/angelozerr/following{/other_user}","gists_url":"https://api.github.com/users/angelozerr/gists{/gist_id}","starred_url":"https://api.github.com/users/angelozerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelozerr/subscriptions","organizations_url":"https://api.github.com/users/angelozerr/orgs","repos_url":"https://api.github.com/users/angelozerr/repos","events_url":"https://api.github.com/users/angelozerr/events{/privacy}","received_events_url":"https://api.github.com/users/angelozerr/received_events","type":"User","site_admin":false},"repo":{"id":138315669,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzMTU2Njk=","name":"lsp4xml","full_name":"angelozerr/lsp4xml","private":false,"owner":{"login":"angelozerr","id":1932211,"node_id":"MDQ6VXNlcjE5MzIyMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1932211?v=4","gravatar_id":"","url":"https://api.github.com/users/angelozerr","html_url":"https://github.com/angelozerr","followers_url":"https://api.github.com/users/angelozerr/followers","following_url":"https://api.github.com/users/angelozerr/following{/other_user}","gists_url":"https://api.github.com/users/angelozerr/gists{/gist_id}","starred_url":"https://api.github.com/users/angelozerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelozerr/subscriptions","organizations_url":"https://api.github.com/users/angelozerr/orgs","repos_url":"https://api.github.com/users/angelozerr/repos","events_url":"https://api.github.com/users/angelozerr/events{/privacy}","received_events_url":"https://api.github.com/users/angelozerr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/angelozerr/lsp4xml","description":"XML Language Server","fork":false,"url":"https://api.github.com/repos/angelozerr/lsp4xml","forks_url":"https://api.github.com/repos/angelozerr/lsp4xml/forks","keys_url":"https://api.github.com/repos/angelozerr/lsp4xml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angelozerr/lsp4xml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angelozerr/lsp4xml/teams","hooks_url":"https://api.github.com/repos/angelozerr/lsp4xml/hooks","issue_events_url":"https://api.github.com/repos/angelozerr/lsp4xml/issues/events{/number}","events_url":"https://api.github.com/repos/angelozerr/lsp4xml/events","assignees_url":"https://api.github.com/repos/angelozerr/lsp4xml/assignees{/user}","branches_url":"https://api.github.com/repos/angelozerr/lsp4xml/branches{/branch}","tags_url":"https://api.github.com/repos/angelozerr/lsp4xml/tags","blobs_url":"https://api.github.com/repos/angelozerr/lsp4xml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angelozerr/lsp4xml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angelozerr/lsp4xml/git/refs{/sha}","trees_url":"https://api.github.com/repos/angelozerr/lsp4xml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angelozerr/lsp4xml/statuses/{sha}","languages_url":"https://api.github.com/repos/angelozerr/lsp4xml/languages","stargazers_url":"https://api.github.com/repos/angelozerr/lsp4xml/stargazers","contributors_url":"https://api.github.com/repos/angelozerr/lsp4xml/contributors","subscribers_url":"https://api.github.com/repos/angelozerr/lsp4xml/subscribers","subscription_url":"https://api.github.com/repos/angelozerr/lsp4xml/subscription","commits_url":"https://api.github.com/repos/angelozerr/lsp4xml/commits{/sha}","git_commits_url":"https://api.github.com/repos/angelozerr/lsp4xml/git/commits{/sha}","comments_url":"https://api.github.com/repos/angelozerr/lsp4xml/comments{/number}","issue_comment_url":"https://api.github.com/repos/angelozerr/lsp4xml/issues/comments{/number}","contents_url":"https://api.github.com/repos/angelozerr/lsp4xml/contents/{+path}","compare_url":"https://api.github.com/repos/angelozerr/lsp4xml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angelozerr/lsp4xml/merges","archive_url":"https://api.github.com/repos/angelozerr/lsp4xml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angelozerr/lsp4xml/downloads","issues_url":"https://api.github.com/repos/angelozerr/lsp4xml/issues{/number}","pulls_url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls{/number}","milestones_url":"https://api.github.com/repos/angelozerr/lsp4xml/milestones{/number}","notifications_url":"https://api.github.com/repos/angelozerr/lsp4xml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angelozerr/lsp4xml/labels{/name}","releases_url":"https://api.github.com/repos/angelozerr/lsp4xml/releases{/id}","deployments_url":"https://api.github.com/repos/angelozerr/lsp4xml/deployments","created_at":"2018-06-22T15:00:18Z","updated_at":"2018-11-28T20:44:50Z","pushed_at":"2018-11-29T20:24:31Z","git_url":"git://github.com/angelozerr/lsp4xml.git","ssh_url":"git@github.com:angelozerr/lsp4xml.git","clone_url":"https://github.com/angelozerr/lsp4xml.git","svn_url":"https://github.com/angelozerr/lsp4xml","homepage":null,"size":7400,"stargazers_count":21,"watchers_count":21,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":11,"open_issues":58,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/240"},"html":{"href":"https://github.com/angelozerr/lsp4xml/pull/240"},"issue":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/issues/240"},"comments":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/statuses/9f5aae770bd817e0c0e37dd98294da21745a2935"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"fbricon"}}