{"action":"created","issue":{"url":"https://api.github.com/repos/BADF00D/DisposableFixer/issues/83","repository_url":"https://api.github.com/repos/BADF00D/DisposableFixer","labels_url":"https://api.github.com/repos/BADF00D/DisposableFixer/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/BADF00D/DisposableFixer/issues/83/comments","events_url":"https://api.github.com/repos/BADF00D/DisposableFixer/issues/83/events","html_url":"https://github.com/BADF00D/DisposableFixer/issues/83","id":350023162,"node_id":"MDU6SXNzdWUzNTAwMjMxNjI=","number":83,"title":"Addition to #70: Call to Close on can be seen as calls to Dispose","user":{"login":"BADF00D","id":2852160,"node_id":"MDQ6VXNlcjI4NTIxNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2852160?v=4","gravatar_id":"","url":"https://api.github.com/users/BADF00D","html_url":"https://github.com/BADF00D","followers_url":"https://api.github.com/users/BADF00D/followers","following_url":"https://api.github.com/users/BADF00D/following{/other_user}","gists_url":"https://api.github.com/users/BADF00D/gists{/gist_id}","starred_url":"https://api.github.com/users/BADF00D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BADF00D/subscriptions","organizations_url":"https://api.github.com/users/BADF00D/orgs","repos_url":"https://api.github.com/users/BADF00D/repos","events_url":"https://api.github.com/users/BADF00D/events{/privacy}","received_events_url":"https://api.github.com/users/BADF00D/received_events","type":"User","site_admin":false},"labels":[{"id":473333654,"node_id":"MDU6TGFiZWw0NzMzMzM2NTQ=","url":"https://api.github.com/repos/BADF00D/DisposableFixer/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/BADF00D/DisposableFixer/milestones/2","html_url":"https://github.com/BADF00D/DisposableFixer/milestone/2","labels_url":"https://api.github.com/repos/BADF00D/DisposableFixer/milestones/2/labels","id":2640158,"node_id":"MDk6TWlsZXN0b25lMjY0MDE1OA==","number":2,"title":"Release 2.0.0","description":"Add some CodeFixes to make usage easier.","creator":{"login":"BADF00D","id":2852160,"node_id":"MDQ6VXNlcjI4NTIxNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2852160?v=4","gravatar_id":"","url":"https://api.github.com/users/BADF00D","html_url":"https://github.com/BADF00D","followers_url":"https://api.github.com/users/BADF00D/followers","following_url":"https://api.github.com/users/BADF00D/following{/other_user}","gists_url":"https://api.github.com/users/BADF00D/gists{/gist_id}","starred_url":"https://api.github.com/users/BADF00D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BADF00D/subscriptions","organizations_url":"https://api.github.com/users/BADF00D/orgs","repos_url":"https://api.github.com/users/BADF00D/repos","events_url":"https://api.github.com/users/BADF00D/events{/privacy}","received_events_url":"https://api.github.com/users/BADF00D/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":4,"state":"open","created_at":"2017-07-13T20:03:47Z","updated_at":"2018-08-14T18:08:24Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-08-13T13:10:45Z","updated_at":"2018-08-14T18:08:24Z","closed_at":"2018-08-14T18:08:24Z","author_association":"OWNER","body":"### Prerequisites\r\n\r\n- [x] I have written a descriptive issue title\r\n- [x] I have verified that I am running the latest version of DisposableFixer: 1.0.0\r\n- [x] I have searched [open](https://github.com/BADF00D/DisposableFixer/issues) and [closed](https://github.com/BADF00D/DisposableFixer/issues?q=is%3Aissue+is%3Aclosed) issues to ensure it has not already been reported: \r\n\r\n### Description\r\nIn addition to SerialPort, there are more classes where a call to Close can be recognized, as if it was a call to Dispose: \r\n* System.Data.DataTableReader\r\n* System.Data.OdbcDataReader\r\n* System.Data.OleDbDataReader\r\n* System.Data.OracleDataReader\r\n* System.Data.SqlDataReader\r\n* System.Data.SqlDataReaderSmi\r\n\r\n### Source Code\r\n<!-- sample code, failing test or link to a project that reproduces the behavior -->\r\n```csharp\r\nSqlConnection connection = null;\r\nSqlCommand command = null;\r\nSqlDataReader reader = null;\r\ntry\r\n{\r\n    connection = new SqlConnection(connectionString);\r\n    await connection.OpenAsync();\r\n\r\n    command = connection.CreateCommand();\r\n    command.Connection = connection;\r\n    command.CommandText = \"\";\r\n    command.CommandType = CommandType.Text;\r\n    stopWatch.Start();\r\n    reader = await command.ExecuteReaderAsync(); // << warning!!!\r\n    stopWatch.Stop();\r\n    LoggerHelper.LogStress(\"LoadCustomerInformations\", \"SELECT [Name]\", stopWatch.Elapsed, \"\");\r\n    stopWatch.Restart();\r\n    while (await reader.ReadAsync())\r\n    {\r\n        customerInformations.Add(new KeyValuePair<string, string>((string)reader[\"Name\"], (string)reader[\"ConnectionString\"]));\r\n    }\r\n    LoggerHelper.LogStress(\"LoadCustomerInformations\", null, stopWatch.Elapsed, \"\");\r\n}\r\nfinally\r\n{\r\n    reader?.Close();\r\n    connection?.Dispose();\r\n    command?.Dispose();\r\n}\r\n```\r\n\r\n### Screenshot\r\n<!-- sometimes a picture is worth a thousand words -->\r\n\r\n<!-- Thanks for reporting the issue to DisposableFixer! -->"},"comment":{"url":"https://api.github.com/repos/BADF00D/DisposableFixer/issues/comments/412964584","html_url":"https://github.com/BADF00D/DisposableFixer/issues/83#issuecomment-412964584","issue_url":"https://api.github.com/repos/BADF00D/DisposableFixer/issues/83","id":412964584,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjk2NDU4NA==","user":{"login":"BADF00D","id":2852160,"node_id":"MDQ6VXNlcjI4NTIxNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2852160?v=4","gravatar_id":"","url":"https://api.github.com/users/BADF00D","html_url":"https://github.com/BADF00D","followers_url":"https://api.github.com/users/BADF00D/followers","following_url":"https://api.github.com/users/BADF00D/following{/other_user}","gists_url":"https://api.github.com/users/BADF00D/gists{/gist_id}","starred_url":"https://api.github.com/users/BADF00D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BADF00D/subscriptions","organizations_url":"https://api.github.com/users/BADF00D/orgs","repos_url":"https://api.github.com/users/BADF00D/repos","events_url":"https://api.github.com/users/BADF00D/events{/privacy}","received_events_url":"https://api.github.com/users/BADF00D/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T18:08:23Z","updated_at":"2018-08-14T18:08:23Z","author_association":"OWNER","body":"Will be part of next release (probably 1.0.1)"}}
{"actor":{"display_login":"BADF00D"}}