{"action":"created","comment":{"url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/comments/213473316","pull_request_review_id":150318471,"id":213473316,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzQ3MzMxNg==","diff_hunk":"@@ -137,19 +137,22 @@ public void onServiceConnected(final ComponentName componentName, final IBinder\n                 }\n             }\n \n-            for (Recorder recorder : this.getActiveRecorders().values()) {\n-                this.compositeDisposable.add(\n-                        ((Recorder<? extends Result>) recorder).getResult()\n-                                .subscribe((result) -> {\n-                                    for (ObservableEmitter<Result> emitter : this.observers) {\n-                                        emitter.onNext(result);\n-                                        emitter.onComplete();\n-                                    }\n-                                }, (throwable -> {\n-                                    for (ObservableEmitter<Result> emitter : this.observers) {\n-                                        emitter.onError(throwable);\n-                                    }\n-                                })));\n+            activeRecorders = this.getActiveRecorders();","path":"presentation/src/main/java/org/sagebionetworks/research/presentation/recorder/service/RecorderManager.java","position":17,"original_position":17,"commit_id":"18afbb71f3971c3f42958054680cf7528a4f00bf","original_commit_id":"18afbb71f3971c3f42958054680cf7528a4f00bf","user":{"login":"liujoshua","id":7097368,"node_id":"MDQ6VXNlcjcwOTczNjg=","avatar_url":"https://avatars3.githubusercontent.com/u/7097368?v=4","gravatar_id":"","url":"https://api.github.com/users/liujoshua","html_url":"https://github.com/liujoshua","followers_url":"https://api.github.com/users/liujoshua/followers","following_url":"https://api.github.com/users/liujoshua/following{/other_user}","gists_url":"https://api.github.com/users/liujoshua/gists{/gist_id}","starred_url":"https://api.github.com/users/liujoshua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liujoshua/subscriptions","organizations_url":"https://api.github.com/users/liujoshua/orgs","repos_url":"https://api.github.com/users/liujoshua/repos","events_url":"https://api.github.com/users/liujoshua/events{/privacy}","received_events_url":"https://api.github.com/users/liujoshua/received_events","type":"User","site_admin":false},"body":"Oh, I meant I did something like Single<RecorderManager> that returns after the service is bound. Haven't figured out how to handle unbind","created_at":"2018-08-28T21:09:54Z","updated_at":"2018-08-28T21:09:54Z","html_url":"https://github.com/Sage-Bionetworks/SageResearch-Android/pull/47#discussion_r213473316","pull_request_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/47","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/comments/213473316"},"html":{"href":"https://github.com/Sage-Bionetworks/SageResearch-Android/pull/47#discussion_r213473316"},"pull_request":{"href":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/47"}},"in_reply_to_id":213129547},"pull_request":{"url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/47","id":210775638,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzc1NjM4","html_url":"https://github.com/Sage-Bionetworks/SageResearch-Android/pull/47","diff_url":"https://github.com/Sage-Bionetworks/SageResearch-Android/pull/47.diff","patch_url":"https://github.com/Sage-Bionetworks/SageResearch-Android/pull/47.patch","issue_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/issues/47","number":47,"state":"open","locked":false,"title":"Tracking","user":{"login":"Robert-Kolmos","id":22583398,"node_id":"MDQ6VXNlcjIyNTgzMzk4","avatar_url":"https://avatars1.githubusercontent.com/u/22583398?v=4","gravatar_id":"","url":"https://api.github.com/users/Robert-Kolmos","html_url":"https://github.com/Robert-Kolmos","followers_url":"https://api.github.com/users/Robert-Kolmos/followers","following_url":"https://api.github.com/users/Robert-Kolmos/following{/other_user}","gists_url":"https://api.github.com/users/Robert-Kolmos/gists{/gist_id}","starred_url":"https://api.github.com/users/Robert-Kolmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robert-Kolmos/subscriptions","organizations_url":"https://api.github.com/users/Robert-Kolmos/orgs","repos_url":"https://api.github.com/users/Robert-Kolmos/repos","events_url":"https://api.github.com/users/Robert-Kolmos/events{/privacy}","received_events_url":"https://api.github.com/users/Robert-Kolmos/received_events","type":"User","site_admin":false},"body":"A couple of changes to be more flexible as required by Tracking.\r\n- ShowStepFragmentBase is no longer the required superclass of all fragments instead they now just have to inherit from Fragment.\r\n- Fields in ResourceTaskRepository are now protected to facilitate inheritance/overriding.\r\n- Fixed a null pointer exception in RecorderService.\r\n- Changed the form step divider to appVeryLightGray since it was too bold.","created_at":"2018-08-24T15:33:41Z","updated_at":"2018-08-28T21:09:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5a090a6eaa6316fd4f15fc3fc8083ce13d81080","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/47/commits","review_comments_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/47/comments","review_comment_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/issues/47/comments","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/statuses/18afbb71f3971c3f42958054680cf7528a4f00bf","head":{"label":"Robert-Kolmos:tracking","ref":"tracking","sha":"18afbb71f3971c3f42958054680cf7528a4f00bf","user":{"login":"Robert-Kolmos","id":22583398,"node_id":"MDQ6VXNlcjIyNTgzMzk4","avatar_url":"https://avatars1.githubusercontent.com/u/22583398?v=4","gravatar_id":"","url":"https://api.github.com/users/Robert-Kolmos","html_url":"https://github.com/Robert-Kolmos","followers_url":"https://api.github.com/users/Robert-Kolmos/followers","following_url":"https://api.github.com/users/Robert-Kolmos/following{/other_user}","gists_url":"https://api.github.com/users/Robert-Kolmos/gists{/gist_id}","starred_url":"https://api.github.com/users/Robert-Kolmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robert-Kolmos/subscriptions","organizations_url":"https://api.github.com/users/Robert-Kolmos/orgs","repos_url":"https://api.github.com/users/Robert-Kolmos/repos","events_url":"https://api.github.com/users/Robert-Kolmos/events{/privacy}","received_events_url":"https://api.github.com/users/Robert-Kolmos/received_events","type":"User","site_admin":false},"repo":{"id":129956465,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5NTY0NjU=","name":"ResearchSuite-Android","full_name":"Robert-Kolmos/ResearchSuite-Android","owner":{"login":"Robert-Kolmos","id":22583398,"node_id":"MDQ6VXNlcjIyNTgzMzk4","avatar_url":"https://avatars1.githubusercontent.com/u/22583398?v=4","gravatar_id":"","url":"https://api.github.com/users/Robert-Kolmos","html_url":"https://github.com/Robert-Kolmos","followers_url":"https://api.github.com/users/Robert-Kolmos/followers","following_url":"https://api.github.com/users/Robert-Kolmos/following{/other_user}","gists_url":"https://api.github.com/users/Robert-Kolmos/gists{/gist_id}","starred_url":"https://api.github.com/users/Robert-Kolmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robert-Kolmos/subscriptions","organizations_url":"https://api.github.com/users/Robert-Kolmos/orgs","repos_url":"https://api.github.com/users/Robert-Kolmos/repos","events_url":"https://api.github.com/users/Robert-Kolmos/events{/privacy}","received_events_url":"https://api.github.com/users/Robert-Kolmos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Robert-Kolmos/ResearchSuite-Android","description":null,"fork":true,"url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android","forks_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/forks","keys_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/teams","hooks_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/hooks","issue_events_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/issues/events{/number}","events_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/events","assignees_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/assignees{/user}","branches_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/branches{/branch}","tags_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/tags","blobs_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/languages","stargazers_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/stargazers","contributors_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/contributors","subscribers_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/subscribers","subscription_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/subscription","commits_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/contents/{+path}","compare_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/merges","archive_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/downloads","issues_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/issues{/number}","pulls_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/labels{/name}","releases_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/releases{/id}","deployments_url":"https://api.github.com/repos/Robert-Kolmos/ResearchSuite-Android/deployments","created_at":"2018-04-17T19:44:47Z","updated_at":"2018-04-17T19:44:49Z","pushed_at":"2018-08-24T21:35:43Z","git_url":"git://github.com/Robert-Kolmos/ResearchSuite-Android.git","ssh_url":"git@github.com:Robert-Kolmos/ResearchSuite-Android.git","clone_url":"https://github.com/Robert-Kolmos/ResearchSuite-Android.git","svn_url":"https://github.com/Robert-Kolmos/ResearchSuite-Android","homepage":null,"size":2924,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sage-Bionetworks:master","ref":"master","sha":"f1a1f222c863f872240559f7e779361556efc10f","user":{"login":"Sage-Bionetworks","id":1250897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1250897?v=4","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":103464665,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM0NjQ2NjU=","name":"SageResearch-Android","full_name":"Sage-Bionetworks/SageResearch-Android","owner":{"login":"Sage-Bionetworks","id":1250897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1250897?v=4","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sage-Bionetworks/SageResearch-Android","description":null,"fork":false,"url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android","forks_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/forks","keys_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/teams","hooks_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/hooks","issue_events_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/issues/events{/number}","events_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/events","assignees_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/assignees{/user}","branches_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/branches{/branch}","tags_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/tags","blobs_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/languages","stargazers_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/stargazers","contributors_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/contributors","subscribers_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/subscribers","subscription_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/subscription","commits_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/contents/{+path}","compare_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/merges","archive_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/downloads","issues_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/issues{/number}","pulls_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/labels{/name}","releases_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/releases{/id}","deployments_url":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/deployments","created_at":"2017-09-14T00:13:57Z","updated_at":"2018-08-24T16:02:23Z","pushed_at":"2018-08-28T00:17:23Z","git_url":"git://github.com/Sage-Bionetworks/SageResearch-Android.git","ssh_url":"git@github.com:Sage-Bionetworks/SageResearch-Android.git","clone_url":"https://github.com/Sage-Bionetworks/SageResearch-Android.git","svn_url":"https://github.com/Sage-Bionetworks/SageResearch-Android","homepage":null,"size":2988,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/47"},"html":{"href":"https://github.com/Sage-Bionetworks/SageResearch-Android/pull/47"},"issue":{"href":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/issues/47"},"comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/Sage-Bionetworks/SageResearch-Android/statuses/18afbb71f3971c3f42958054680cf7528a4f00bf"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"liujoshua"}}