{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/189413940","pull_request_review_id":121597073,"id":189413940,"diff_hunk":"@@ -16,6 +16,14 @@ imports:\n - path: cluster.jinja\n \n resources:\n+  # Deployment manager doesn't support depends on references in template type.\n+  # So the two possible work arounds are\n+  # 1. Use a single template (.jinja file for all resources) or\n+  # 2. Create two separate deployments and launch the boot strapper\n+  # after the cluster is created.\n+  # \n+  # Two separate deployments doesn't make much sense; we could just use ","path":"docs/gke/configs/cluster-kubeflow.yaml","position":10,"original_position":10,"commit_id":"90a6c5d105846719d6e83bfe22cf75963230af6b","original_commit_id":"249c9f5ed7b71271a8b91bdf2b1dc2174a9769fd","user":{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-05-18T23:32:00Z","updated_at":"2018-05-18T23:32:00Z","html_url":"https://github.com/kubeflow/kubeflow/pull/823#discussion_r189413940","pull_request_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/823","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/189413940"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/823#discussion_r189413940"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/823"}},"in_reply_to_id":189363608},"pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/823","id":188855752,"html_url":"https://github.com/kubeflow/kubeflow/pull/823","diff_url":"https://github.com/kubeflow/kubeflow/pull/823.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/823.patch","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/823","number":823,"state":"open","locked":false,"title":"Start deploying the bootstrapper via deployment manager.","user":{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"body":"* This config creates the namespace and K8s service for the bootstrapper.\r\n* This is just a first step and primarily intended to indicate how to\r\n  start creating K8s resources via deployment manager.\r\n\r\nRelated to: #802 Use deployment manager to run bootstrapper\r\n\r\n/assign @kunmingg\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/823)\n<!-- Reviewable:end -->\n","created_at":"2018-05-17T20:42:30Z","updated_at":"2018-05-18T23:32:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dc02dff263557c707c665f1b8d37f7d79022825","assignee":{"login":"kunmingg","id":37601826,"avatar_url":"https://avatars2.githubusercontent.com/u/37601826?v=4","gravatar_id":"","url":"https://api.github.com/users/kunmingg","html_url":"https://github.com/kunmingg","followers_url":"https://api.github.com/users/kunmingg/followers","following_url":"https://api.github.com/users/kunmingg/following{/other_user}","gists_url":"https://api.github.com/users/kunmingg/gists{/gist_id}","starred_url":"https://api.github.com/users/kunmingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunmingg/subscriptions","organizations_url":"https://api.github.com/users/kunmingg/orgs","repos_url":"https://api.github.com/users/kunmingg/repos","events_url":"https://api.github.com/users/kunmingg/events{/privacy}","received_events_url":"https://api.github.com/users/kunmingg/received_events","type":"User","site_admin":false},"assignees":[{"login":"kunmingg","id":37601826,"avatar_url":"https://avatars2.githubusercontent.com/u/37601826?v=4","gravatar_id":"","url":"https://api.github.com/users/kunmingg","html_url":"https://github.com/kunmingg","followers_url":"https://api.github.com/users/kunmingg/followers","following_url":"https://api.github.com/users/kunmingg/following{/other_user}","gists_url":"https://api.github.com/users/kunmingg/gists{/gist_id}","starred_url":"https://api.github.com/users/kunmingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunmingg/subscriptions","organizations_url":"https://api.github.com/users/kunmingg/orgs","repos_url":"https://api.github.com/users/kunmingg/repos","events_url":"https://api.github.com/users/kunmingg/events{/privacy}","received_events_url":"https://api.github.com/users/kunmingg/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"wbuchwalter","id":3621290,"avatar_url":"https://avatars0.githubusercontent.com/u/3621290?v=4","gravatar_id":"","url":"https://api.github.com/users/wbuchwalter","html_url":"https://github.com/wbuchwalter","followers_url":"https://api.github.com/users/wbuchwalter/followers","following_url":"https://api.github.com/users/wbuchwalter/following{/other_user}","gists_url":"https://api.github.com/users/wbuchwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/wbuchwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbuchwalter/subscriptions","organizations_url":"https://api.github.com/users/wbuchwalter/orgs","repos_url":"https://api.github.com/users/wbuchwalter/repos","events_url":"https://api.github.com/users/wbuchwalter/events{/privacy}","received_events_url":"https://api.github.com/users/wbuchwalter/received_events","type":"User","site_admin":false},{"login":"kunmingg","id":37601826,"avatar_url":"https://avatars2.githubusercontent.com/u/37601826?v=4","gravatar_id":"","url":"https://api.github.com/users/kunmingg","html_url":"https://github.com/kunmingg","followers_url":"https://api.github.com/users/kunmingg/followers","following_url":"https://api.github.com/users/kunmingg/following{/other_user}","gists_url":"https://api.github.com/users/kunmingg/gists{/gist_id}","starred_url":"https://api.github.com/users/kunmingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunmingg/subscriptions","organizations_url":"https://api.github.com/users/kunmingg/orgs","repos_url":"https://api.github.com/users/kunmingg/repos","events_url":"https://api.github.com/users/kunmingg/events{/privacy}","received_events_url":"https://api.github.com/users/kunmingg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":796399084,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/L","name":"size/L","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/823/commits","review_comments_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/823/comments","review_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/823/comments","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/90a6c5d105846719d6e83bfe22cf75963230af6b","head":{"label":"jlewi:gke_bootstrapper","ref":"gke_bootstrapper","sha":"90a6c5d105846719d6e83bfe22cf75963230af6b","user":{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"repo":{"id":112704197,"name":"kubeflow","full_name":"jlewi/kubeflow","owner":{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlewi/kubeflow","description":null,"fork":true,"url":"https://api.github.com/repos/jlewi/kubeflow","forks_url":"https://api.github.com/repos/jlewi/kubeflow/forks","keys_url":"https://api.github.com/repos/jlewi/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlewi/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlewi/kubeflow/teams","hooks_url":"https://api.github.com/repos/jlewi/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/jlewi/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/jlewi/kubeflow/events","assignees_url":"https://api.github.com/repos/jlewi/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/jlewi/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/jlewi/kubeflow/tags","blobs_url":"https://api.github.com/repos/jlewi/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlewi/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlewi/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlewi/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlewi/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/jlewi/kubeflow/languages","stargazers_url":"https://api.github.com/repos/jlewi/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/jlewi/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/jlewi/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/jlewi/kubeflow/subscription","commits_url":"https://api.github.com/repos/jlewi/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlewi/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlewi/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlewi/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlewi/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/jlewi/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlewi/kubeflow/merges","archive_url":"https://api.github.com/repos/jlewi/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlewi/kubeflow/downloads","issues_url":"https://api.github.com/repos/jlewi/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/jlewi/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/jlewi/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/jlewi/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlewi/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/jlewi/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/jlewi/kubeflow/deployments","created_at":"2017-12-01T06:35:05Z","updated_at":"2018-05-10T11:13:27Z","pushed_at":"2018-05-18T20:23:57Z","git_url":"git://github.com/jlewi/kubeflow.git","ssh_url":"git@github.com:jlewi/kubeflow.git","clone_url":"https://github.com/jlewi/kubeflow.git","svn_url":"https://github.com/jlewi/kubeflow","homepage":null,"size":121310,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"730df5c2c58cf6028d26a7e10e54e68743b22b25","user":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":112647343,"name":"kubeflow","full_name":"kubeflow/kubeflow","owner":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeflow/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubeflow/kubeflow","forks_url":"https://api.github.com/repos/kubeflow/kubeflow/forks","keys_url":"https://api.github.com/repos/kubeflow/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/kubeflow/teams","hooks_url":"https://api.github.com/repos/kubeflow/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/kubeflow/events","assignees_url":"https://api.github.com/repos/kubeflow/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/kubeflow/tags","blobs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/kubeflow/languages","stargazers_url":"https://api.github.com/repos/kubeflow/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/kubeflow/subscription","commits_url":"https://api.github.com/repos/kubeflow/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/kubeflow/merges","archive_url":"https://api.github.com/repos/kubeflow/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/kubeflow/downloads","issues_url":"https://api.github.com/repos/kubeflow/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/kubeflow/deployments","created_at":"2017-11-30T18:44:19Z","updated_at":"2018-05-18T20:29:16Z","pushed_at":"2018-05-18T22:54:27Z","git_url":"git://github.com/kubeflow/kubeflow.git","ssh_url":"git@github.com:kubeflow/kubeflow.git","clone_url":"https://github.com/kubeflow/kubeflow.git","svn_url":"https://github.com/kubeflow/kubeflow","homepage":"","size":121870,"stargazers_count":3578,"watchers_count":3578,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":424,"mirror_url":null,"archived":false,"open_issues_count":193,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":424,"open_issues":193,"watchers":3578,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/823"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/823"},"issue":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/823"},"comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/823/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/823/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/823/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/kubeflow/statuses/90a6c5d105846719d6e83bfe22cf75963230af6b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jlewi"}}