{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/216059640","pull_request_review_id":153467845,"id":216059640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjA1OTY0MA==","diff_hunk":"@@ -116,7 +116,7 @@ func handleCommonEnvVars() {\n \n \t// In distributed setup users need to set ENVs always.\n \tif !globalIsEnvCreds && globalIsDistXL {\n-\t\tlogger.Fatal(uiErrEnvCredentialsMissingServer(nil), \"Unable to start distributed server mode\")\n+\t\tlogger.Fatal(uiErrEnvCredentialsMissingDistributed(nil), \"Unable to start distributed server mode\")","path":"cmd/common-main.go","position":null,"original_position":5,"commit_id":"5de987f925d0b16ec6e09f1afb126c3d84990944","original_commit_id":"459a7d05a4740ad5c8420ed3d7aa211326a5d110","user":{"login":"vadmeste","id":283197,"node_id":"MDQ6VXNlcjI4MzE5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/283197?v=4","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"body":"> is this better unable to start server in distributed mode\r\n\r\nDone","created_at":"2018-09-07T19:07:03Z","updated_at":"2018-09-07T19:07:03Z","html_url":"https://github.com/minio/minio/pull/6418#discussion_r216059640","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/6418","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/216059640"},"html":{"href":"https://github.com/minio/minio/pull/6418#discussion_r216059640"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/6418"}},"in_reply_to_id":216026456},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/6418","id":213271049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjcxMDQ5","html_url":"https://github.com/minio/minio/pull/6418","diff_url":"https://github.com/minio/minio/pull/6418.diff","patch_url":"https://github.com/minio/minio/pull/6418.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/6418","number":6418,"state":"open","locked":false,"title":"Reword missing credentials error msg","user":{"login":"vadmeste","id":283197,"node_id":"MDQ6VXNlcjI4MzE5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/283197?v=4","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"body":"## Description\r\nEnhance a little bit the error message that is showing\r\nwhen access & secret keys are not specified in the\r\nenvironment when running Minio in gateway and server mode.\r\n\r\nThis commit also removes a redundant check for access/secret keys.\r\n\r\n## Motivation and Context\r\nEnhancing an error message\r\n\r\n## Regression\r\nNo\r\n\r\n## How Has This Been Tested?\r\nManually\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed.","created_at":"2018-09-05T12:12:10Z","updated_at":"2018-09-07T19:07:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6949a1b9c3c006c0de0a84a04723dfc59f1cfc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/6418/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/6418/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/6418/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/5de987f925d0b16ec6e09f1afb126c3d84990944","head":{"label":"vadmeste:fix-err-wording","ref":"fix-err-wording","sha":"5de987f925d0b16ec6e09f1afb126c3d84990944","user":{"login":"vadmeste","id":283197,"node_id":"MDQ6VXNlcjI4MzE5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/283197?v=4","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"repo":{"id":30432336,"node_id":"MDEwOlJlcG9zaXRvcnkzMDQzMjMzNg==","name":"minio","full_name":"vadmeste/minio","owner":{"login":"vadmeste","id":283197,"node_id":"MDQ6VXNlcjI4MzE5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/283197?v=4","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vadmeste/minio","description":"Minio is an open source object storage inspired by Amazon S3 and Facebook Haystack ","fork":true,"url":"https://api.github.com/repos/vadmeste/minio","forks_url":"https://api.github.com/repos/vadmeste/minio/forks","keys_url":"https://api.github.com/repos/vadmeste/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vadmeste/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vadmeste/minio/teams","hooks_url":"https://api.github.com/repos/vadmeste/minio/hooks","issue_events_url":"https://api.github.com/repos/vadmeste/minio/issues/events{/number}","events_url":"https://api.github.com/repos/vadmeste/minio/events","assignees_url":"https://api.github.com/repos/vadmeste/minio/assignees{/user}","branches_url":"https://api.github.com/repos/vadmeste/minio/branches{/branch}","tags_url":"https://api.github.com/repos/vadmeste/minio/tags","blobs_url":"https://api.github.com/repos/vadmeste/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vadmeste/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vadmeste/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/vadmeste/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vadmeste/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/vadmeste/minio/languages","stargazers_url":"https://api.github.com/repos/vadmeste/minio/stargazers","contributors_url":"https://api.github.com/repos/vadmeste/minio/contributors","subscribers_url":"https://api.github.com/repos/vadmeste/minio/subscribers","subscription_url":"https://api.github.com/repos/vadmeste/minio/subscription","commits_url":"https://api.github.com/repos/vadmeste/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/vadmeste/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/vadmeste/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/vadmeste/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/vadmeste/minio/contents/{+path}","compare_url":"https://api.github.com/repos/vadmeste/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vadmeste/minio/merges","archive_url":"https://api.github.com/repos/vadmeste/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vadmeste/minio/downloads","issues_url":"https://api.github.com/repos/vadmeste/minio/issues{/number}","pulls_url":"https://api.github.com/repos/vadmeste/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/vadmeste/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/vadmeste/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vadmeste/minio/labels{/name}","releases_url":"https://api.github.com/repos/vadmeste/minio/releases{/id}","deployments_url":"https://api.github.com/repos/vadmeste/minio/deployments","created_at":"2015-02-06T20:48:08Z","updated_at":"2018-04-11T00:18:07Z","pushed_at":"2018-09-07T18:47:54Z","git_url":"git://github.com/vadmeste/minio.git","ssh_url":"git@github.com:vadmeste/minio.git","clone_url":"https://github.com/vadmeste/minio.git","svn_url":"https://github.com/vadmeste/minio","homepage":"http://minio.io","size":41040,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"19202bae813cbef60f0fb87384c13140b2eefc21","user":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI2MTQ3Mw==","name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2018-09-07T18:49:37Z","pushed_at":"2018-09-07T18:47:55Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads.html#download-server","size":41055,"stargazers_count":12804,"watchers_count":12804,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1135,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1135,"open_issues":141,"watchers":12804,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/6418"},"html":{"href":"https://github.com/minio/minio/pull/6418"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/6418"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/6418/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/6418/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/6418/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/5de987f925d0b16ec6e09f1afb126c3d84990944"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vadmeste"}}