{"action":"opened","number":2390,"pull_request":{"url":"https://api.github.com/repos/facebook/prepack/pulls/2390","id":206272367,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjcyMzY3","html_url":"https://github.com/facebook/prepack/pull/2390","diff_url":"https://github.com/facebook/prepack/pull/2390.diff","patch_url":"https://github.com/facebook/prepack/pull/2390.patch","issue_url":"https://api.github.com/repos/facebook/prepack/issues/2390","number":2390,"state":"open","locked":false,"title":"Fix default attributes in joined descriptor","user":{"login":"sebmarkbage","id":63648,"node_id":"MDQ6VXNlcjYzNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/63648?v=4","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"body":"When we create a joined descriptor in an abstract object we need to preserve any attributes of that property that were already there. To do that, we just need to read the first descriptor of the elements since all elements must have the same attributes (or we fatal).","created_at":"2018-08-06T02:01:36Z","updated_at":"2018-08-06T02:01:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/prepack/pulls/2390/commits","review_comments_url":"https://api.github.com/repos/facebook/prepack/pulls/2390/comments","review_comment_url":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/prepack/issues/2390/comments","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/df8cd90220d9f681ddfcfa3c92c1bb79bde59ac7","head":{"label":"sebmarkbage:fixdefaultargs","ref":"fixdefaultargs","sha":"df8cd90220d9f681ddfcfa3c92c1bb79bde59ac7","user":{"login":"sebmarkbage","id":63648,"node_id":"MDQ6VXNlcjYzNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/63648?v=4","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"repo":{"id":90206509,"node_id":"MDEwOlJlcG9zaXRvcnk5MDIwNjUwOQ==","name":"prepack","full_name":"sebmarkbage/prepack","owner":{"login":"sebmarkbage","id":63648,"node_id":"MDQ6VXNlcjYzNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/63648?v=4","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebmarkbage/prepack","description":"Prepack is a partial evaluator for JavaScript. Prepack rewrites a JavaScript bundle, resulting in JavaScript code that executes more efficiently.","fork":true,"url":"https://api.github.com/repos/sebmarkbage/prepack","forks_url":"https://api.github.com/repos/sebmarkbage/prepack/forks","keys_url":"https://api.github.com/repos/sebmarkbage/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebmarkbage/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebmarkbage/prepack/teams","hooks_url":"https://api.github.com/repos/sebmarkbage/prepack/hooks","issue_events_url":"https://api.github.com/repos/sebmarkbage/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/sebmarkbage/prepack/events","assignees_url":"https://api.github.com/repos/sebmarkbage/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/sebmarkbage/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/sebmarkbage/prepack/tags","blobs_url":"https://api.github.com/repos/sebmarkbage/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebmarkbage/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebmarkbage/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebmarkbage/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebmarkbage/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/sebmarkbage/prepack/languages","stargazers_url":"https://api.github.com/repos/sebmarkbage/prepack/stargazers","contributors_url":"https://api.github.com/repos/sebmarkbage/prepack/contributors","subscribers_url":"https://api.github.com/repos/sebmarkbage/prepack/subscribers","subscription_url":"https://api.github.com/repos/sebmarkbage/prepack/subscription","commits_url":"https://api.github.com/repos/sebmarkbage/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebmarkbage/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebmarkbage/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebmarkbage/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebmarkbage/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/sebmarkbage/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebmarkbage/prepack/merges","archive_url":"https://api.github.com/repos/sebmarkbage/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebmarkbage/prepack/downloads","issues_url":"https://api.github.com/repos/sebmarkbage/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/sebmarkbage/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/sebmarkbage/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/sebmarkbage/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebmarkbage/prepack/labels{/name}","releases_url":"https://api.github.com/repos/sebmarkbage/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/sebmarkbage/prepack/deployments","created_at":"2017-05-04T00:58:17Z","updated_at":"2017-05-07T09:32:56Z","pushed_at":"2018-08-06T02:00:34Z","git_url":"git://github.com/sebmarkbage/prepack.git","ssh_url":"git@github.com:sebmarkbage/prepack.git","clone_url":"https://github.com/sebmarkbage/prepack.git","svn_url":"https://github.com/sebmarkbage/prepack","homepage":"https://prepack.io","size":9480,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"6beaf8e0fa204dd001b8aea9af385dbe46e15b3e","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":45147841,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE0Nzg0MQ==","name":"prepack","full_name":"facebook/prepack","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/prepack","description":"A JavaScript bundle optimizer.","fork":false,"url":"https://api.github.com/repos/facebook/prepack","forks_url":"https://api.github.com/repos/facebook/prepack/forks","keys_url":"https://api.github.com/repos/facebook/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/prepack/teams","hooks_url":"https://api.github.com/repos/facebook/prepack/hooks","issue_events_url":"https://api.github.com/repos/facebook/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/prepack/events","assignees_url":"https://api.github.com/repos/facebook/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/prepack/tags","blobs_url":"https://api.github.com/repos/facebook/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/prepack/languages","stargazers_url":"https://api.github.com/repos/facebook/prepack/stargazers","contributors_url":"https://api.github.com/repos/facebook/prepack/contributors","subscribers_url":"https://api.github.com/repos/facebook/prepack/subscribers","subscription_url":"https://api.github.com/repos/facebook/prepack/subscription","commits_url":"https://api.github.com/repos/facebook/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/prepack/merges","archive_url":"https://api.github.com/repos/facebook/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/prepack/downloads","issues_url":"https://api.github.com/repos/facebook/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/prepack/labels{/name}","releases_url":"https://api.github.com/repos/facebook/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/prepack/deployments","created_at":"2015-10-28T23:25:08Z","updated_at":"2018-08-06T01:04:32Z","pushed_at":"2018-08-06T01:30:59Z","git_url":"git://github.com/facebook/prepack.git","ssh_url":"git@github.com:facebook/prepack.git","clone_url":"https://github.com/facebook/prepack.git","svn_url":"https://github.com/facebook/prepack","homepage":"prepack.io","size":16396,"stargazers_count":12580,"watchers_count":12580,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":400,"mirror_url":null,"archived":false,"open_issues_count":238,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":400,"open_issues":238,"watchers":12580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/prepack/pulls/2390"},"html":{"href":"https://github.com/facebook/prepack/pull/2390"},"issue":{"href":"https://api.github.com/repos/facebook/prepack/issues/2390"},"comments":{"href":"https://api.github.com/repos/facebook/prepack/issues/2390/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/prepack/pulls/2390/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/prepack/pulls/2390/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/prepack/statuses/df8cd90220d9f681ddfcfa3c92c1bb79bde59ac7"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":26,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"sebmarkbage"}}