{"action":"created","comment":{"url":"https://api.github.com/repos/shopsys/shopsys/pulls/comments/206127302","pull_request_review_id":141525710,"id":206127302,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjEyNzMwMg==","diff_hunk":"@@ -80,22 +82,68 @@ public function buildForm(FormBuilderInterface $builder, array $options)\n             ];\n         }\n \n-        $builder\n+        $builderBasicInformationGroup = $builder->create('basicInformation', GroupType::class, [\n+            'label' => t('Basic information'),\n+        ]);\n+        $builderBasicInformationGroup\n+            ->add('id', DisplayOnlyType::class, [\n+                'label' => t('ID'),\n+                'data' => $brand !== null ? $brand->getId() : '',\n+            ])\n             ->add('name', TextType::class, [\n                 'required' => true,\n                 'constraints' => [\n                     new Constraints\\NotBlank(['message' => 'Please enter name']),\n                     new Constraints\\Length(['max' => 255, 'maxMessage' => 'Name cannot be longer than {{ limit }} characters']),\n                 ],\n+                'label' => t('Name')\n             ])\n             ->add('descriptions', LocalizedType::class, [\n                 'entry_type' => CKEditorType::class,\n                 'required' => false,\n+                'label' => t('Description')\n+            ]);\n+\n+        $builderSeoGroup = $builder->create('seo', GroupType::class, [\n+            'label' => t('Seo'),\n+        ]);\n+        $builderSeoGroup\n+            ->add('seoTitles', MultidomainType::class, [\n+                'entry_type' => TextType::class,\n+                'required' => false,\n+                'options_by_domain_id' => $seoTitlesOptionsByDomainId,\n+                'macro' => [\n+                    'name' => 'seoFormRowMacros.multidomainRow',\n+                    'recommended_length' => 60,\n+                ],\n+                'label' => t('Page title')\n+            ])\n+            ->add('seoMetaDescriptions', MultidomainType::class, [\n+                'entry_type' => TextareaType::class,\n+                'required' => false,\n+                'options_by_domain_id' => $seoMetaDescriptionsOptionsByDomainId,\n+                'macro' => [\n+                    'name' => 'seoFormRowMacros.multidomainRow',\n+                    'recommended_length' => 155,\n+                ],\n+                'label' => t('Meta description'),\n+            ])\n+            ->add('seoH1s', MultidomainType::class, [\n+                'entry_type' => TextType::class,\n+                'required' => false,\n+                'options_by_domain_id' => $seoH1sOptionsByDomainId,\n+                'label' => t('Heading (H1)')\n             ])\n             ->add('urls', UrlListType::class, [","path":"packages/framework/src/Form/Admin/Product/Brand/BrandFormType.php","position":66,"original_position":66,"commit_id":"446930509e404b7617dece83eb9572dcdb2ee2d4","original_commit_id":"446930509e404b7617dece83eb9572dcdb2ee2d4","user":{"login":"PetrHeinz","id":10008612,"node_id":"MDQ6VXNlcjEwMDA4NjEy","avatar_url":"https://avatars1.githubusercontent.com/u/10008612?v=4","gravatar_id":"","url":"https://api.github.com/users/PetrHeinz","html_url":"https://github.com/PetrHeinz","followers_url":"https://api.github.com/users/PetrHeinz/followers","following_url":"https://api.github.com/users/PetrHeinz/following{/other_user}","gists_url":"https://api.github.com/users/PetrHeinz/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrHeinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrHeinz/subscriptions","organizations_url":"https://api.github.com/users/PetrHeinz/orgs","repos_url":"https://api.github.com/users/PetrHeinz/repos","events_url":"https://api.github.com/users/PetrHeinz/events{/privacy}","received_events_url":"https://api.github.com/users/PetrHeinz/received_events","type":"User","site_admin":false},"body":"The `urls` shouldn't be a part of the form at all when a new Brand is created (i.e. when `$options['brand']` is `null`).\r\n\r\nSee the new Brand page on *master*.","created_at":"2018-07-30T13:13:43Z","updated_at":"2018-07-30T13:17:00Z","html_url":"https://github.com/shopsys/shopsys/pull/364#discussion_r206127302","pull_request_url":"https://api.github.com/repos/shopsys/shopsys/pulls/364","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/comments/206127302"},"html":{"href":"https://github.com/shopsys/shopsys/pull/364#discussion_r206127302"},"pull_request":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/shopsys/shopsys/pulls/364","id":204388710,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Mzg4NzEw","html_url":"https://github.com/shopsys/shopsys/pull/364","diff_url":"https://github.com/shopsys/shopsys/pull/364.diff","patch_url":"https://github.com/shopsys/shopsys/pull/364.patch","issue_url":"https://api.github.com/repos/shopsys/shopsys/issues/364","number":364,"state":"open","locked":false,"title":"Admin: brand form is rendered via BrandFormType","user":{"login":"boris-brtan","id":39240194,"node_id":"MDQ6VXNlcjM5MjQwMTk0","avatar_url":"https://avatars0.githubusercontent.com/u/39240194?v=4","gravatar_id":"","url":"https://api.github.com/users/boris-brtan","html_url":"https://github.com/boris-brtan","followers_url":"https://api.github.com/users/boris-brtan/followers","following_url":"https://api.github.com/users/boris-brtan/following{/other_user}","gists_url":"https://api.github.com/users/boris-brtan/gists{/gist_id}","starred_url":"https://api.github.com/users/boris-brtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boris-brtan/subscriptions","organizations_url":"https://api.github.com/users/boris-brtan/orgs","repos_url":"https://api.github.com/users/boris-brtan/repos","events_url":"https://api.github.com/users/boris-brtan/events{/privacy}","received_events_url":"https://api.github.com/users/boris-brtan/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n|Description, reason for the PR| brand form should be fully extensible via BrandFormType\r\n|New feature| No <!-- Do not forget to update CHANGELOG.md and possibly docs/ -->\r\n|BC breaks| No <!-- Do not forget to update UPGRADE.md -->\r\n|Fixes issues| \r\n|Standards and tests pass| Yes\r\n|Have you read and signed our [License Agreement for contributions](https://www.shopsys.com/license-agreement)?| Yes\r\n","created_at":"2018-07-27T10:13:35Z","updated_at":"2018-07-30T13:17:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3061c19cbd700d34f07ecca4dba14e1a748937c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shopsys/shopsys/pulls/364/commits","review_comments_url":"https://api.github.com/repos/shopsys/shopsys/pulls/364/comments","review_comment_url":"https://api.github.com/repos/shopsys/shopsys/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shopsys/shopsys/issues/364/comments","statuses_url":"https://api.github.com/repos/shopsys/shopsys/statuses/446930509e404b7617dece83eb9572dcdb2ee2d4","head":{"label":"shopsys:bb-brand-form-type","ref":"bb-brand-form-type","sha":"446930509e404b7617dece83eb9572dcdb2ee2d4","user":{"login":"shopsys","id":17828168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODI4MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/17828168?v=4","gravatar_id":"","url":"https://api.github.com/users/shopsys","html_url":"https://github.com/shopsys","followers_url":"https://api.github.com/users/shopsys/followers","following_url":"https://api.github.com/users/shopsys/following{/other_user}","gists_url":"https://api.github.com/users/shopsys/gists{/gist_id}","starred_url":"https://api.github.com/users/shopsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopsys/subscriptions","organizations_url":"https://api.github.com/users/shopsys/orgs","repos_url":"https://api.github.com/users/shopsys/repos","events_url":"https://api.github.com/users/shopsys/events{/privacy}","received_events_url":"https://api.github.com/users/shopsys/received_events","type":"Organization","site_admin":false},"repo":{"id":119832166,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4MzIxNjY=","name":"shopsys","full_name":"shopsys/shopsys","owner":{"login":"shopsys","id":17828168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODI4MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/17828168?v=4","gravatar_id":"","url":"https://api.github.com/users/shopsys","html_url":"https://github.com/shopsys","followers_url":"https://api.github.com/users/shopsys/followers","following_url":"https://api.github.com/users/shopsys/following{/other_user}","gists_url":"https://api.github.com/users/shopsys/gists{/gist_id}","starred_url":"https://api.github.com/users/shopsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopsys/subscriptions","organizations_url":"https://api.github.com/users/shopsys/orgs","repos_url":"https://api.github.com/users/shopsys/repos","events_url":"https://api.github.com/users/shopsys/events{/privacy}","received_events_url":"https://api.github.com/users/shopsys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopsys/shopsys","description":"Main repository for maintaining Shopsys Framework packages. Open for ISSUES and PULL REQUESTS. ","fork":false,"url":"https://api.github.com/repos/shopsys/shopsys","forks_url":"https://api.github.com/repos/shopsys/shopsys/forks","keys_url":"https://api.github.com/repos/shopsys/shopsys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopsys/shopsys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopsys/shopsys/teams","hooks_url":"https://api.github.com/repos/shopsys/shopsys/hooks","issue_events_url":"https://api.github.com/repos/shopsys/shopsys/issues/events{/number}","events_url":"https://api.github.com/repos/shopsys/shopsys/events","assignees_url":"https://api.github.com/repos/shopsys/shopsys/assignees{/user}","branches_url":"https://api.github.com/repos/shopsys/shopsys/branches{/branch}","tags_url":"https://api.github.com/repos/shopsys/shopsys/tags","blobs_url":"https://api.github.com/repos/shopsys/shopsys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopsys/shopsys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopsys/shopsys/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopsys/shopsys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopsys/shopsys/statuses/{sha}","languages_url":"https://api.github.com/repos/shopsys/shopsys/languages","stargazers_url":"https://api.github.com/repos/shopsys/shopsys/stargazers","contributors_url":"https://api.github.com/repos/shopsys/shopsys/contributors","subscribers_url":"https://api.github.com/repos/shopsys/shopsys/subscribers","subscription_url":"https://api.github.com/repos/shopsys/shopsys/subscription","commits_url":"https://api.github.com/repos/shopsys/shopsys/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopsys/shopsys/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopsys/shopsys/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopsys/shopsys/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopsys/shopsys/contents/{+path}","compare_url":"https://api.github.com/repos/shopsys/shopsys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopsys/shopsys/merges","archive_url":"https://api.github.com/repos/shopsys/shopsys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopsys/shopsys/downloads","issues_url":"https://api.github.com/repos/shopsys/shopsys/issues{/number}","pulls_url":"https://api.github.com/repos/shopsys/shopsys/pulls{/number}","milestones_url":"https://api.github.com/repos/shopsys/shopsys/milestones{/number}","notifications_url":"https://api.github.com/repos/shopsys/shopsys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopsys/shopsys/labels{/name}","releases_url":"https://api.github.com/repos/shopsys/shopsys/releases{/id}","deployments_url":"https://api.github.com/repos/shopsys/shopsys/deployments","created_at":"2018-02-01T12:21:09Z","updated_at":"2018-07-30T12:21:47Z","pushed_at":"2018-07-30T12:54:53Z","git_url":"git://github.com/shopsys/shopsys.git","ssh_url":"git@github.com:shopsys/shopsys.git","clone_url":"https://github.com/shopsys/shopsys.git","svn_url":"https://github.com/shopsys/shopsys","homepage":"https://www.shopsys.com","size":19700,"stargazers_count":83,"watchers_count":83,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":88,"watchers":83,"default_branch":"master"}},"base":{"label":"shopsys:master","ref":"master","sha":"3efb92d99dad0fabe05c3bb797f9fd2e7818a45b","user":{"login":"shopsys","id":17828168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODI4MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/17828168?v=4","gravatar_id":"","url":"https://api.github.com/users/shopsys","html_url":"https://github.com/shopsys","followers_url":"https://api.github.com/users/shopsys/followers","following_url":"https://api.github.com/users/shopsys/following{/other_user}","gists_url":"https://api.github.com/users/shopsys/gists{/gist_id}","starred_url":"https://api.github.com/users/shopsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopsys/subscriptions","organizations_url":"https://api.github.com/users/shopsys/orgs","repos_url":"https://api.github.com/users/shopsys/repos","events_url":"https://api.github.com/users/shopsys/events{/privacy}","received_events_url":"https://api.github.com/users/shopsys/received_events","type":"Organization","site_admin":false},"repo":{"id":119832166,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4MzIxNjY=","name":"shopsys","full_name":"shopsys/shopsys","owner":{"login":"shopsys","id":17828168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODI4MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/17828168?v=4","gravatar_id":"","url":"https://api.github.com/users/shopsys","html_url":"https://github.com/shopsys","followers_url":"https://api.github.com/users/shopsys/followers","following_url":"https://api.github.com/users/shopsys/following{/other_user}","gists_url":"https://api.github.com/users/shopsys/gists{/gist_id}","starred_url":"https://api.github.com/users/shopsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopsys/subscriptions","organizations_url":"https://api.github.com/users/shopsys/orgs","repos_url":"https://api.github.com/users/shopsys/repos","events_url":"https://api.github.com/users/shopsys/events{/privacy}","received_events_url":"https://api.github.com/users/shopsys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopsys/shopsys","description":"Main repository for maintaining Shopsys Framework packages. Open for ISSUES and PULL REQUESTS. ","fork":false,"url":"https://api.github.com/repos/shopsys/shopsys","forks_url":"https://api.github.com/repos/shopsys/shopsys/forks","keys_url":"https://api.github.com/repos/shopsys/shopsys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopsys/shopsys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopsys/shopsys/teams","hooks_url":"https://api.github.com/repos/shopsys/shopsys/hooks","issue_events_url":"https://api.github.com/repos/shopsys/shopsys/issues/events{/number}","events_url":"https://api.github.com/repos/shopsys/shopsys/events","assignees_url":"https://api.github.com/repos/shopsys/shopsys/assignees{/user}","branches_url":"https://api.github.com/repos/shopsys/shopsys/branches{/branch}","tags_url":"https://api.github.com/repos/shopsys/shopsys/tags","blobs_url":"https://api.github.com/repos/shopsys/shopsys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopsys/shopsys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopsys/shopsys/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopsys/shopsys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopsys/shopsys/statuses/{sha}","languages_url":"https://api.github.com/repos/shopsys/shopsys/languages","stargazers_url":"https://api.github.com/repos/shopsys/shopsys/stargazers","contributors_url":"https://api.github.com/repos/shopsys/shopsys/contributors","subscribers_url":"https://api.github.com/repos/shopsys/shopsys/subscribers","subscription_url":"https://api.github.com/repos/shopsys/shopsys/subscription","commits_url":"https://api.github.com/repos/shopsys/shopsys/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopsys/shopsys/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopsys/shopsys/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopsys/shopsys/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopsys/shopsys/contents/{+path}","compare_url":"https://api.github.com/repos/shopsys/shopsys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopsys/shopsys/merges","archive_url":"https://api.github.com/repos/shopsys/shopsys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopsys/shopsys/downloads","issues_url":"https://api.github.com/repos/shopsys/shopsys/issues{/number}","pulls_url":"https://api.github.com/repos/shopsys/shopsys/pulls{/number}","milestones_url":"https://api.github.com/repos/shopsys/shopsys/milestones{/number}","notifications_url":"https://api.github.com/repos/shopsys/shopsys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopsys/shopsys/labels{/name}","releases_url":"https://api.github.com/repos/shopsys/shopsys/releases{/id}","deployments_url":"https://api.github.com/repos/shopsys/shopsys/deployments","created_at":"2018-02-01T12:21:09Z","updated_at":"2018-07-30T12:21:47Z","pushed_at":"2018-07-30T12:54:53Z","git_url":"git://github.com/shopsys/shopsys.git","ssh_url":"git@github.com:shopsys/shopsys.git","clone_url":"https://github.com/shopsys/shopsys.git","svn_url":"https://github.com/shopsys/shopsys","homepage":"https://www.shopsys.com","size":19700,"stargazers_count":83,"watchers_count":83,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":88,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/364"},"html":{"href":"https://github.com/shopsys/shopsys/pull/364"},"issue":{"href":"https://api.github.com/repos/shopsys/shopsys/issues/364"},"comments":{"href":"https://api.github.com/repos/shopsys/shopsys/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/shopsys/shopsys/statuses/446930509e404b7617dece83eb9572dcdb2ee2d4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PetrHeinz"}}