{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/223486674","pull_request_review_id":162624238,"id":223486674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzQ4NjY3NA==","diff_hunk":"@@ -0,0 +1,41 @@\n+(ns puppetlabs.puppetdb.cli.util\n+  \"As this namespace is required by both the tk and non-tk subcommands,\n+  it must remain very lightweight, so that subcommands like\n+  \\\"version\\\" aren't slowed down by loading the entire logging\n+  subsystem or trapperkeeper, etc.\"\n+  (:require\n+   [puppetlabs.i18n.core :refer [trs]]))\n+\n+(def err-exit-status 1)\n+\n+;; Testing hook\n+(defn java-version [] (System/getProperty \"java.version\"))\n+\n+(defn jdk-support-status [version]\n+  \"Returns :official, :tested, or :unknown, or :no.\"\n+  (cond\n+    (re-matches #\"1.[123456]($|(\\..*))\" version) :no\n+    (re-matches #\"1.7($|(\\..*))\" version) :unknown\n+    (re-matches #\"1.8($|(\\..*))*\" version) :official\n+    (re-matches #\"1.10($|(\\..*))*\" version) :tested\n+    :else :unknown))\n+\n+(defn jdk-unsupported-msg [version]\n+  (let [status (jdk-support-status version)]\n+    (case status\n+      (:official :tested :unknown) nil","path":"src/puppetlabs/puppetdb/cli/util.clj","position":26,"original_position":26,"commit_id":"6c947e56e3512aec7ebdd0d211efaf830569ea3e","original_commit_id":"6c947e56e3512aec7ebdd0d211efaf830569ea3e","user":{"login":"austb","id":4520807,"node_id":"MDQ6VXNlcjQ1MjA4MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/4520807?v=4","gravatar_id":"","url":"https://api.github.com/users/austb","html_url":"https://github.com/austb","followers_url":"https://api.github.com/users/austb/followers","following_url":"https://api.github.com/users/austb/following{/other_user}","gists_url":"https://api.github.com/users/austb/gists{/gist_id}","starred_url":"https://api.github.com/users/austb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austb/subscriptions","organizations_url":"https://api.github.com/users/austb/orgs","repos_url":"https://api.github.com/users/austb/repos","events_url":"https://api.github.com/users/austb/events{/privacy}","received_events_url":"https://api.github.com/users/austb/received_events","type":"User","site_admin":false},"body":"Would it be difficult to log a warning when the java version is untested since we don't want to load the logging libraries?","created_at":"2018-10-08T20:23:59Z","updated_at":"2018-10-08T20:56:43Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/2602#discussion_r223486674","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2602","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/223486674"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/2602#discussion_r223486674"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2602"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2602","id":217059314,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDU5MzE0","html_url":"https://github.com/puppetlabs/puppetdb/pull/2602","diff_url":"https://github.com/puppetlabs/puppetdb/pull/2602.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/2602.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2602","number":2602,"state":"open","locked":false,"title":"(PDB-4108) Fix AOT issues and compile uberjar","user":{"login":"rbrw","id":10120698,"node_id":"MDQ6VXNlcjEwMTIwNjk4","avatar_url":"https://avatars0.githubusercontent.com/u/10120698?v=4","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-20T18:03:29Z","updated_at":"2018-10-08T20:56:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58a44401cd439b99a33265a58e4c01e6e9b9d9f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2602/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2602/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2602/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/6c947e56e3512aec7ebdd0d211efaf830569ea3e","head":{"label":"rbrw:pdb-4108-compile-pdb","ref":"pdb-4108-compile-pdb","sha":"6c947e56e3512aec7ebdd0d211efaf830569ea3e","user":{"login":"rbrw","id":10120698,"node_id":"MDQ6VXNlcjEwMTIwNjk4","avatar_url":"https://avatars0.githubusercontent.com/u/10120698?v=4","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"repo":{"id":27739513,"node_id":"MDEwOlJlcG9zaXRvcnkyNzczOTUxMw==","name":"puppetdb","full_name":"rbrw/puppetdb","private":false,"owner":{"login":"rbrw","id":10120698,"node_id":"MDQ6VXNlcjEwMTIwNjk4","avatar_url":"https://avatars0.githubusercontent.com/u/10120698?v=4","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rbrw/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/rbrw/puppetdb","forks_url":"https://api.github.com/repos/rbrw/puppetdb/forks","keys_url":"https://api.github.com/repos/rbrw/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbrw/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbrw/puppetdb/teams","hooks_url":"https://api.github.com/repos/rbrw/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/rbrw/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/rbrw/puppetdb/events","assignees_url":"https://api.github.com/repos/rbrw/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/rbrw/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/rbrw/puppetdb/tags","blobs_url":"https://api.github.com/repos/rbrw/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbrw/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbrw/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbrw/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbrw/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/rbrw/puppetdb/languages","stargazers_url":"https://api.github.com/repos/rbrw/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/rbrw/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/rbrw/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/rbrw/puppetdb/subscription","commits_url":"https://api.github.com/repos/rbrw/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbrw/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbrw/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbrw/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/rbrw/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/rbrw/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbrw/puppetdb/merges","archive_url":"https://api.github.com/repos/rbrw/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbrw/puppetdb/downloads","issues_url":"https://api.github.com/repos/rbrw/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/rbrw/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/rbrw/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/rbrw/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbrw/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/rbrw/puppetdb/releases{/id}","deployments_url":"https://api.github.com/repos/rbrw/puppetdb/deployments","created_at":"2014-12-08T23:03:46Z","updated_at":"2018-06-14T22:10:11Z","pushed_at":"2018-10-04T17:18:51Z","git_url":"git://github.com/rbrw/puppetdb.git","ssh_url":"git@github.com:rbrw/puppetdb.git","clone_url":"https://github.com/rbrw/puppetdb.git","svn_url":"https://github.com/rbrw/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":19191,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"48b69770457225bde3bcbe4a2bc741efe676899f","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"node_id":"MDEwOlJlcG9zaXRvcnkyMTkzMDMy","name":"puppetdb","full_name":"puppetlabs/puppetdb","private":false,"owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetdb/deployments","created_at":"2011-08-11T18:54:46Z","updated_at":"2018-10-05T16:04:25Z","pushed_at":"2018-10-05T21:31:49Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":18841,"stargazers_count":226,"watchers_count":226,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":196,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":196,"open_issues":21,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2602"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/2602"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2602"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2602/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2602/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2602/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/6c947e56e3512aec7ebdd0d211efaf830569ea3e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"austb"}}