{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/comments/210281114","pull_request_review_id":146461009,"id":210281114,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDI4MTExNA==","diff_hunk":"@@ -181,9 +181,21 @@ def warn_static_attribute_deprecation(name, value)\n         attribute_caller = caller(3)\n       end\n \n-      ActiveSupport::Deprecation.warn(\"Static attributes will be removed in \"\\\n-        \"FactoryBot 5.0. Please use dynamic attributes instead. Static \"\\\n-        \"attribute=#{name.inspect} value=#{value.inspect}\", attribute_caller)\n+      ActiveSupport::Deprecation.warn(<<-MSG, attribute_caller)\n+Static attributes will be removed in FactoryBot 5.0. Please use dynamic\n+attributes instead by wrapping the attribute value in a block:\n+\n+#{name} { #{value.inspect} }\n+\n+To automatically update from static attributes to dynamic ones,\n+install rubocop-rspec and run:\n+\n+rubocop \\\\","path":"lib/factory_bot/definition_proxy.rb","position":16,"original_position":16,"commit_id":"ef6cbd472ec09e92129c3eb21c216a60fa1d2d8b","original_commit_id":"ef6cbd472ec09e92129c3eb21c216a60fa1d2d8b","user":{"login":"mike-burns","id":4550,"node_id":"MDQ6VXNlcjQ1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4550?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-burns","html_url":"https://github.com/mike-burns","followers_url":"https://api.github.com/users/mike-burns/followers","following_url":"https://api.github.com/users/mike-burns/following{/other_user}","gists_url":"https://api.github.com/users/mike-burns/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-burns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-burns/subscriptions","organizations_url":"https://api.github.com/users/mike-burns/orgs","repos_url":"https://api.github.com/users/mike-burns/repos","events_url":"https://api.github.com/users/mike-burns/events{/privacy}","received_events_url":"https://api.github.com/users/mike-burns/received_events","type":"User","site_admin":false},"body":"Huh, yeah, a `\\\\` is needed. That's wild.","created_at":"2018-08-15T14:11:29Z","updated_at":"2018-08-15T14:12:02Z","html_url":"https://github.com/thoughtbot/factory_bot/pull/1166#discussion_r210281114","pull_request_url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1166","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/comments/210281114"},"html":{"href":"https://github.com/thoughtbot/factory_bot/pull/1166#discussion_r210281114"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1166"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1166","id":207790826,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzkwODI2","html_url":"https://github.com/thoughtbot/factory_bot/pull/1166","diff_url":"https://github.com/thoughtbot/factory_bot/pull/1166.diff","patch_url":"https://github.com/thoughtbot/factory_bot/pull/1166.patch","issue_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1166","number":1166,"state":"open","locked":false,"title":"Include rubocop-rspec autocorrect in deprecation","user":{"login":"composerinteralia","id":13696143,"node_id":"MDQ6VXNlcjEzNjk2MTQz","avatar_url":"https://avatars3.githubusercontent.com/u/13696143?v=4","gravatar_id":"","url":"https://api.github.com/users/composerinteralia","html_url":"https://github.com/composerinteralia","followers_url":"https://api.github.com/users/composerinteralia/followers","following_url":"https://api.github.com/users/composerinteralia/following{/other_user}","gists_url":"https://api.github.com/users/composerinteralia/gists{/gist_id}","starred_url":"https://api.github.com/users/composerinteralia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/composerinteralia/subscriptions","organizations_url":"https://api.github.com/users/composerinteralia/orgs","repos_url":"https://api.github.com/users/composerinteralia/repos","events_url":"https://api.github.com/users/composerinteralia/events{/privacy}","received_events_url":"https://api.github.com/users/composerinteralia/received_events","type":"User","site_admin":false},"body":"Fixes #1160\r\n\r\nhttps://github.com/rubocop-hq/rubocop-rspec/pull/666 was merged. I\r\nwould like to wait until the next version of rubocop-rspec is\r\nreleased, then release factory_bot 4.11 with this deprecation.","created_at":"2018-08-11T20:16:26Z","updated_at":"2018-08-15T14:12:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5801249eee3a43bef6e1b9ae7becfb8b47fbfc14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/thoughtbot/factory_bot/milestones/4","html_url":"https://github.com/thoughtbot/factory_bot/milestone/4","labels_url":"https://api.github.com/repos/thoughtbot/factory_bot/milestones/4/labels","id":3546342,"node_id":"MDk6TWlsZXN0b25lMzU0NjM0Mg==","number":4,"title":"4.11 Release","description":"","creator":{"login":"composerinteralia","id":13696143,"node_id":"MDQ6VXNlcjEzNjk2MTQz","avatar_url":"https://avatars3.githubusercontent.com/u/13696143?v=4","gravatar_id":"","url":"https://api.github.com/users/composerinteralia","html_url":"https://github.com/composerinteralia","followers_url":"https://api.github.com/users/composerinteralia/followers","following_url":"https://api.github.com/users/composerinteralia/following{/other_user}","gists_url":"https://api.github.com/users/composerinteralia/gists{/gist_id}","starred_url":"https://api.github.com/users/composerinteralia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/composerinteralia/subscriptions","organizations_url":"https://api.github.com/users/composerinteralia/orgs","repos_url":"https://api.github.com/users/composerinteralia/repos","events_url":"https://api.github.com/users/composerinteralia/events{/privacy}","received_events_url":"https://api.github.com/users/composerinteralia/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2018-08-04T14:16:33Z","updated_at":"2018-08-11T20:58:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1166/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1166/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1166/comments","statuses_url":"https://api.github.com/repos/thoughtbot/factory_bot/statuses/ef6cbd472ec09e92129c3eb21c216a60fa1d2d8b","head":{"label":"thoughtbot:dc-static-attribute-warning","ref":"dc-static-attribute-warning","sha":"ef6cbd472ec09e92129c3eb21c216a60fa1d2d8b","user":{"login":"thoughtbot","id":6183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":21829,"node_id":"MDEwOlJlcG9zaXRvcnkyMTgyOQ==","name":"factory_bot","full_name":"thoughtbot/factory_bot","owner":{"login":"thoughtbot","id":6183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/factory_bot","description":"A library for setting up Ruby objects as test data.","fork":false,"url":"https://api.github.com/repos/thoughtbot/factory_bot","forks_url":"https://api.github.com/repos/thoughtbot/factory_bot/forks","keys_url":"https://api.github.com/repos/thoughtbot/factory_bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/factory_bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/factory_bot/teams","hooks_url":"https://api.github.com/repos/thoughtbot/factory_bot/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/factory_bot/events","assignees_url":"https://api.github.com/repos/thoughtbot/factory_bot/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/factory_bot/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/factory_bot/tags","blobs_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/factory_bot/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/factory_bot/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/factory_bot/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/factory_bot/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/factory_bot/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/factory_bot/subscription","commits_url":"https://api.github.com/repos/thoughtbot/factory_bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/factory_bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/factory_bot/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/factory_bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/factory_bot/merges","archive_url":"https://api.github.com/repos/thoughtbot/factory_bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/factory_bot/downloads","issues_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/factory_bot/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/factory_bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/factory_bot/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/factory_bot/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/factory_bot/deployments","created_at":"2008-06-03T13:55:37Z","updated_at":"2018-08-15T14:04:06Z","pushed_at":"2018-08-11T21:04:29Z","git_url":"git://github.com/thoughtbot/factory_bot.git","ssh_url":"git@github.com:thoughtbot/factory_bot.git","clone_url":"https://github.com/thoughtbot/factory_bot.git","svn_url":"https://github.com/thoughtbot/factory_bot","homepage":"https://thoughtbot.com/open-source","size":2024,"stargazers_count":6077,"watchers_count":6077,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1594,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1594,"open_issues":45,"watchers":6077,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"40eed88bb9222ee09001fbc7d301527836e0d085","user":{"login":"thoughtbot","id":6183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":21829,"node_id":"MDEwOlJlcG9zaXRvcnkyMTgyOQ==","name":"factory_bot","full_name":"thoughtbot/factory_bot","owner":{"login":"thoughtbot","id":6183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/factory_bot","description":"A library for setting up Ruby objects as test data.","fork":false,"url":"https://api.github.com/repos/thoughtbot/factory_bot","forks_url":"https://api.github.com/repos/thoughtbot/factory_bot/forks","keys_url":"https://api.github.com/repos/thoughtbot/factory_bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/factory_bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/factory_bot/teams","hooks_url":"https://api.github.com/repos/thoughtbot/factory_bot/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/factory_bot/events","assignees_url":"https://api.github.com/repos/thoughtbot/factory_bot/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/factory_bot/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/factory_bot/tags","blobs_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/factory_bot/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/factory_bot/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/factory_bot/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/factory_bot/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/factory_bot/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/factory_bot/subscription","commits_url":"https://api.github.com/repos/thoughtbot/factory_bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/factory_bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/factory_bot/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/factory_bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/factory_bot/merges","archive_url":"https://api.github.com/repos/thoughtbot/factory_bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/factory_bot/downloads","issues_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/factory_bot/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/factory_bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/factory_bot/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/factory_bot/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/factory_bot/deployments","created_at":"2008-06-03T13:55:37Z","updated_at":"2018-08-15T14:04:06Z","pushed_at":"2018-08-11T21:04:29Z","git_url":"git://github.com/thoughtbot/factory_bot.git","ssh_url":"git@github.com:thoughtbot/factory_bot.git","clone_url":"https://github.com/thoughtbot/factory_bot.git","svn_url":"https://github.com/thoughtbot/factory_bot","homepage":"https://thoughtbot.com/open-source","size":2024,"stargazers_count":6077,"watchers_count":6077,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1594,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1594,"open_issues":45,"watchers":6077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1166"},"html":{"href":"https://github.com/thoughtbot/factory_bot/pull/1166"},"issue":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1166"},"comments":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1166/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1166/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1166/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/statuses/ef6cbd472ec09e92129c3eb21c216a60fa1d2d8b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mike-burns"}}