{"action":"closed","issue":{"url":"https://api.github.com/repos/govau/uikit/issues/533","repository_url":"https://api.github.com/repos/govau/uikit","labels_url":"https://api.github.com/repos/govau/uikit/issues/533/labels{/name}","comments_url":"https://api.github.com/repos/govau/uikit/issues/533/comments","events_url":"https://api.github.com/repos/govau/uikit/issues/533/events","html_url":"https://github.com/govau/uikit/issues/533","id":370007665,"node_id":"MDU6SXNzdWUzNzAwMDc2NjU=","number":533,"title":".au-footer__end only adds styles when it follows .au-footer__navigation","user":{"login":"alex-page","id":19199063,"node_id":"MDQ6VXNlcjE5MTk5MDYz","avatar_url":"https://avatars1.githubusercontent.com/u/19199063?v=4","gravatar_id":"","url":"https://api.github.com/users/alex-page","html_url":"https://github.com/alex-page","followers_url":"https://api.github.com/users/alex-page/followers","following_url":"https://api.github.com/users/alex-page/following{/other_user}","gists_url":"https://api.github.com/users/alex-page/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-page/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-page/subscriptions","organizations_url":"https://api.github.com/users/alex-page/orgs","repos_url":"https://api.github.com/users/alex-page/repos","events_url":"https://api.github.com/users/alex-page/events{/privacy}","received_events_url":"https://api.github.com/users/alex-page/received_events","type":"User","site_admin":false},"labels":[{"id":515713714,"node_id":"MDU6TGFiZWw1MTU3MTM3MTQ=","url":"https://api.github.com/repos/govau/uikit/labels/enhancement","name":"enhancement","color":"d4c5f9","default":true}],"state":"closed","locked":false,"assignee":{"login":"sukhrajghuman","id":20184809,"node_id":"MDQ6VXNlcjIwMTg0ODA5","avatar_url":"https://avatars1.githubusercontent.com/u/20184809?v=4","gravatar_id":"","url":"https://api.github.com/users/sukhrajghuman","html_url":"https://github.com/sukhrajghuman","followers_url":"https://api.github.com/users/sukhrajghuman/followers","following_url":"https://api.github.com/users/sukhrajghuman/following{/other_user}","gists_url":"https://api.github.com/users/sukhrajghuman/gists{/gist_id}","starred_url":"https://api.github.com/users/sukhrajghuman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sukhrajghuman/subscriptions","organizations_url":"https://api.github.com/users/sukhrajghuman/orgs","repos_url":"https://api.github.com/users/sukhrajghuman/repos","events_url":"https://api.github.com/users/sukhrajghuman/events{/privacy}","received_events_url":"https://api.github.com/users/sukhrajghuman/received_events","type":"User","site_admin":false},"assignees":[{"login":"sukhrajghuman","id":20184809,"node_id":"MDQ6VXNlcjIwMTg0ODA5","avatar_url":"https://avatars1.githubusercontent.com/u/20184809?v=4","gravatar_id":"","url":"https://api.github.com/users/sukhrajghuman","html_url":"https://github.com/sukhrajghuman","followers_url":"https://api.github.com/users/sukhrajghuman/followers","following_url":"https://api.github.com/users/sukhrajghuman/following{/other_user}","gists_url":"https://api.github.com/users/sukhrajghuman/gists{/gist_id}","starred_url":"https://api.github.com/users/sukhrajghuman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sukhrajghuman/subscriptions","organizations_url":"https://api.github.com/users/sukhrajghuman/orgs","repos_url":"https://api.github.com/users/sukhrajghuman/repos","events_url":"https://api.github.com/users/sukhrajghuman/events{/privacy}","received_events_url":"https://api.github.com/users/sukhrajghuman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-10-15T05:48:12Z","updated_at":"2018-10-17T04:38:58Z","closed_at":"2018-10-17T04:38:58Z","author_association":"MEMBER","body":"# Bug Report\r\n\r\n- [x] I’ve read and understood the [Contributing guidelines](https://github.com/govau/uikit/blob/master/CONTRIBUTING.md) and have done my best effort to follow them.\r\n- [x] I’ve read and agree to the [Code of Conduct](https://github.com/govau/uikit/blob/master/CODE_OF_CONDUCT.md).\r\n- [x] I’ve searched for any related issues and avoided creating a duplicate issue.\r\n\r\n## What happened\r\n\r\nUsing `.au-footer__end` when it doesn't follow `.au-footer__navigation` applies no styles. The only purpose of this class is to add the border top and spacing.\r\n\r\nThe other issue is when you want to use this class but inside a grid element. It no longer follows the navigation and doesn't show the border top. \r\n\r\nIf you do add the class to the grid element the border is wider than the content inside of it.\r\n\r\n```\r\n<nav class=\"col-md-12 au-footer__nav\">\r\n</nav>\r\n<section class=\"col-md-12 au-footer__end\">\r\n</section>\r\n```\r\n\r\n## What I expected to happen\r\n\r\nThis style should always add the border top and spacing, if a user doesn't want the border top and spacing they don't have to use the class.\r\n\r\nThe component should not have to follow the `.au-footer__navigation`.\r\n\r\n## Reproducing\r\n\r\n- Module name: footer\r\n- Module version: 2.1.9"}}
{"actor":{"display_login":"alex-page"}}