{"action":"opened","number":5245,"pull_request":{"url":"https://api.github.com/repos/gohugoio/hugo/pulls/5245","id":217375061,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Mzc1MDYx","html_url":"https://github.com/gohugoio/hugo/pull/5245","diff_url":"https://github.com/gohugoio/hugo/pull/5245.diff","patch_url":"https://github.com/gohugoio/hugo/pull/5245.patch","issue_url":"https://api.github.com/repos/gohugoio/hugo/issues/5245","number":5245,"state":"open","locked":false,"title":"hugolib: Normalize permalink path segments","user":{"login":"moorereason","id":131056,"node_id":"MDQ6VXNlcjEzMTA1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/131056?v=4","gravatar_id":"","url":"https://api.github.com/users/moorereason","html_url":"https://github.com/moorereason","followers_url":"https://api.github.com/users/moorereason/followers","following_url":"https://api.github.com/users/moorereason/following{/other_user}","gists_url":"https://api.github.com/users/moorereason/gists{/gist_id}","starred_url":"https://api.github.com/users/moorereason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorereason/subscriptions","organizations_url":"https://api.github.com/users/moorereason/orgs","repos_url":"https://api.github.com/users/moorereason/repos","events_url":"https://api.github.com/users/moorereason/events{/privacy}","received_events_url":"https://api.github.com/users/moorereason/received_events","type":"User","site_admin":false},"body":"When constructing permalinks, ensure that most inputs used as path\r\nsegments are normalized with PathSpec.MakeSegment instead of\r\nPathSpec.URLize.\r\n\r\nThe primary exception to that rule is with taxonomy titles in\r\npageToPermalinkTitle(). The approach taken here is to use URLize for\r\ntaxonomy pages. Everything else will use MakeSegment. The reason for\r\nthis exception is that people use taxonomies such as \"s1/p1\" to generate\r\nURLs precisely they way they wish (see #5223). Tests have been added to\r\ncheck for this case.\r\n\r\nFixes #4926","created_at":"2018-09-21T19:09:20Z","updated_at":"2018-09-21T19:09:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gohugoio/hugo/pulls/5245/commits","review_comments_url":"https://api.github.com/repos/gohugoio/hugo/pulls/5245/comments","review_comment_url":"https://api.github.com/repos/gohugoio/hugo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gohugoio/hugo/issues/5245/comments","statuses_url":"https://api.github.com/repos/gohugoio/hugo/statuses/bc9645cae282eb2265b8c25c1a022953a33801ac","head":{"label":"moorereason:iss4926v2","ref":"iss4926v2","sha":"bc9645cae282eb2265b8c25c1a022953a33801ac","user":{"login":"moorereason","id":131056,"node_id":"MDQ6VXNlcjEzMTA1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/131056?v=4","gravatar_id":"","url":"https://api.github.com/users/moorereason","html_url":"https://github.com/moorereason","followers_url":"https://api.github.com/users/moorereason/followers","following_url":"https://api.github.com/users/moorereason/following{/other_user}","gists_url":"https://api.github.com/users/moorereason/gists{/gist_id}","starred_url":"https://api.github.com/users/moorereason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorereason/subscriptions","organizations_url":"https://api.github.com/users/moorereason/orgs","repos_url":"https://api.github.com/users/moorereason/repos","events_url":"https://api.github.com/users/moorereason/events{/privacy}","received_events_url":"https://api.github.com/users/moorereason/received_events","type":"User","site_admin":false},"repo":{"id":45879373,"node_id":"MDEwOlJlcG9zaXRvcnk0NTg3OTM3Mw==","name":"hugo","full_name":"moorereason/hugo","private":false,"owner":{"login":"moorereason","id":131056,"node_id":"MDQ6VXNlcjEzMTA1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/131056?v=4","gravatar_id":"","url":"https://api.github.com/users/moorereason","html_url":"https://github.com/moorereason","followers_url":"https://api.github.com/users/moorereason/followers","following_url":"https://api.github.com/users/moorereason/following{/other_user}","gists_url":"https://api.github.com/users/moorereason/gists{/gist_id}","starred_url":"https://api.github.com/users/moorereason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorereason/subscriptions","organizations_url":"https://api.github.com/users/moorereason/orgs","repos_url":"https://api.github.com/users/moorereason/repos","events_url":"https://api.github.com/users/moorereason/events{/privacy}","received_events_url":"https://api.github.com/users/moorereason/received_events","type":"User","site_admin":false},"html_url":"https://github.com/moorereason/hugo","description":"A Fast and Flexible Static Site Generator built with love by spf13 in GoLang","fork":true,"url":"https://api.github.com/repos/moorereason/hugo","forks_url":"https://api.github.com/repos/moorereason/hugo/forks","keys_url":"https://api.github.com/repos/moorereason/hugo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moorereason/hugo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moorereason/hugo/teams","hooks_url":"https://api.github.com/repos/moorereason/hugo/hooks","issue_events_url":"https://api.github.com/repos/moorereason/hugo/issues/events{/number}","events_url":"https://api.github.com/repos/moorereason/hugo/events","assignees_url":"https://api.github.com/repos/moorereason/hugo/assignees{/user}","branches_url":"https://api.github.com/repos/moorereason/hugo/branches{/branch}","tags_url":"https://api.github.com/repos/moorereason/hugo/tags","blobs_url":"https://api.github.com/repos/moorereason/hugo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moorereason/hugo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moorereason/hugo/git/refs{/sha}","trees_url":"https://api.github.com/repos/moorereason/hugo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moorereason/hugo/statuses/{sha}","languages_url":"https://api.github.com/repos/moorereason/hugo/languages","stargazers_url":"https://api.github.com/repos/moorereason/hugo/stargazers","contributors_url":"https://api.github.com/repos/moorereason/hugo/contributors","subscribers_url":"https://api.github.com/repos/moorereason/hugo/subscribers","subscription_url":"https://api.github.com/repos/moorereason/hugo/subscription","commits_url":"https://api.github.com/repos/moorereason/hugo/commits{/sha}","git_commits_url":"https://api.github.com/repos/moorereason/hugo/git/commits{/sha}","comments_url":"https://api.github.com/repos/moorereason/hugo/comments{/number}","issue_comment_url":"https://api.github.com/repos/moorereason/hugo/issues/comments{/number}","contents_url":"https://api.github.com/repos/moorereason/hugo/contents/{+path}","compare_url":"https://api.github.com/repos/moorereason/hugo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moorereason/hugo/merges","archive_url":"https://api.github.com/repos/moorereason/hugo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moorereason/hugo/downloads","issues_url":"https://api.github.com/repos/moorereason/hugo/issues{/number}","pulls_url":"https://api.github.com/repos/moorereason/hugo/pulls{/number}","milestones_url":"https://api.github.com/repos/moorereason/hugo/milestones{/number}","notifications_url":"https://api.github.com/repos/moorereason/hugo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moorereason/hugo/labels{/name}","releases_url":"https://api.github.com/repos/moorereason/hugo/releases{/id}","deployments_url":"https://api.github.com/repos/moorereason/hugo/deployments","created_at":"2015-11-10T01:35:23Z","updated_at":"2017-04-12T02:15:24Z","pushed_at":"2018-09-21T19:07:41Z","git_url":"git://github.com/moorereason/hugo.git","ssh_url":"git@github.com:moorereason/hugo.git","clone_url":"https://github.com/moorereason/hugo.git","svn_url":"https://github.com/moorereason/hugo","homepage":"http://gohugo.io","size":60461,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gohugoio:master","ref":"master","sha":"f1a00b2069ede85feb487d29b9f690396e2402c6","user":{"login":"gohugoio","id":29385237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mzg1MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/29385237?v=4","gravatar_id":"","url":"https://api.github.com/users/gohugoio","html_url":"https://github.com/gohugoio","followers_url":"https://api.github.com/users/gohugoio/followers","following_url":"https://api.github.com/users/gohugoio/following{/other_user}","gists_url":"https://api.github.com/users/gohugoio/gists{/gist_id}","starred_url":"https://api.github.com/users/gohugoio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gohugoio/subscriptions","organizations_url":"https://api.github.com/users/gohugoio/orgs","repos_url":"https://api.github.com/users/gohugoio/repos","events_url":"https://api.github.com/users/gohugoio/events{/privacy}","received_events_url":"https://api.github.com/users/gohugoio/received_events","type":"Organization","site_admin":false},"repo":{"id":11180687,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4MDY4Nw==","name":"hugo","full_name":"gohugoio/hugo","private":false,"owner":{"login":"gohugoio","id":29385237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mzg1MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/29385237?v=4","gravatar_id":"","url":"https://api.github.com/users/gohugoio","html_url":"https://github.com/gohugoio","followers_url":"https://api.github.com/users/gohugoio/followers","following_url":"https://api.github.com/users/gohugoio/following{/other_user}","gists_url":"https://api.github.com/users/gohugoio/gists{/gist_id}","starred_url":"https://api.github.com/users/gohugoio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gohugoio/subscriptions","organizations_url":"https://api.github.com/users/gohugoio/orgs","repos_url":"https://api.github.com/users/gohugoio/repos","events_url":"https://api.github.com/users/gohugoio/events{/privacy}","received_events_url":"https://api.github.com/users/gohugoio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gohugoio/hugo","description":"The world’s fastest framework for building websites.","fork":false,"url":"https://api.github.com/repos/gohugoio/hugo","forks_url":"https://api.github.com/repos/gohugoio/hugo/forks","keys_url":"https://api.github.com/repos/gohugoio/hugo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gohugoio/hugo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gohugoio/hugo/teams","hooks_url":"https://api.github.com/repos/gohugoio/hugo/hooks","issue_events_url":"https://api.github.com/repos/gohugoio/hugo/issues/events{/number}","events_url":"https://api.github.com/repos/gohugoio/hugo/events","assignees_url":"https://api.github.com/repos/gohugoio/hugo/assignees{/user}","branches_url":"https://api.github.com/repos/gohugoio/hugo/branches{/branch}","tags_url":"https://api.github.com/repos/gohugoio/hugo/tags","blobs_url":"https://api.github.com/repos/gohugoio/hugo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gohugoio/hugo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gohugoio/hugo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gohugoio/hugo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gohugoio/hugo/statuses/{sha}","languages_url":"https://api.github.com/repos/gohugoio/hugo/languages","stargazers_url":"https://api.github.com/repos/gohugoio/hugo/stargazers","contributors_url":"https://api.github.com/repos/gohugoio/hugo/contributors","subscribers_url":"https://api.github.com/repos/gohugoio/hugo/subscribers","subscription_url":"https://api.github.com/repos/gohugoio/hugo/subscription","commits_url":"https://api.github.com/repos/gohugoio/hugo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gohugoio/hugo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gohugoio/hugo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gohugoio/hugo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gohugoio/hugo/contents/{+path}","compare_url":"https://api.github.com/repos/gohugoio/hugo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gohugoio/hugo/merges","archive_url":"https://api.github.com/repos/gohugoio/hugo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gohugoio/hugo/downloads","issues_url":"https://api.github.com/repos/gohugoio/hugo/issues{/number}","pulls_url":"https://api.github.com/repos/gohugoio/hugo/pulls{/number}","milestones_url":"https://api.github.com/repos/gohugoio/hugo/milestones{/number}","notifications_url":"https://api.github.com/repos/gohugoio/hugo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gohugoio/hugo/labels{/name}","releases_url":"https://api.github.com/repos/gohugoio/hugo/releases{/id}","deployments_url":"https://api.github.com/repos/gohugoio/hugo/deployments","created_at":"2013-07-04T15:26:26Z","updated_at":"2018-09-21T17:48:06Z","pushed_at":"2018-09-21T15:33:36Z","git_url":"git://github.com/gohugoio/hugo.git","ssh_url":"git@github.com:gohugoio/hugo.git","clone_url":"https://github.com/gohugoio/hugo.git","svn_url":"https://github.com/gohugoio/hugo","homepage":"https://gohugo.io","size":61157,"stargazers_count":28920,"watchers_count":28920,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3375,"mirror_url":null,"archived":false,"open_issues_count":308,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3375,"open_issues":308,"watchers":28920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/5245"},"html":{"href":"https://github.com/gohugoio/hugo/pull/5245"},"issue":{"href":"https://api.github.com/repos/gohugoio/hugo/issues/5245"},"comments":{"href":"https://api.github.com/repos/gohugoio/hugo/issues/5245/comments"},"review_comments":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/5245/comments"},"review_comment":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/5245/commits"},"statuses":{"href":"https://api.github.com/repos/gohugoio/hugo/statuses/bc9645cae282eb2265b8c25c1a022953a33801ac"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":51,"deletions":36,"changed_files":3}}
{"actor":{"display_login":"moorereason"}}