{"action":"created","comment":{"url":"https://api.github.com/repos/runtimeverification/solidity/pulls/comments/187513087","pull_request_review_id":119309623,"id":187513087,"diff_hunk":"@@ -4373,9 +4373,9 @@ bool IeleCompiler::visit(const MemberAccess &memberAccess) {\n     solAssert(ExprValue,\n               \"IeleCompiler: failed to compile base expression for member \"\n               \"access.\");\n-    solAssert(!(std::set<std::string>{\"call\", \"callcode\", \"delegatecall\"}).count(member),\n-              \"IeleCompiler: member not supported in IELE\");\n-    if (member == \"transfer\" || member == \"send\") {\n+    if (member == \"call\" || member == \"callcode\" || member == \"delegatecall\") {\n+    // cannot be invoked in iele, so we don't need to create a result.","path":"libsolidity/codegen/IeleCompiler.cpp","position":8,"original_position":8,"commit_id":"309090592d82da5f9c364fcbebe25b329dbb5668","original_commit_id":"5508bdd37f2cb4ef03db8a9509ee3fa3a32d8594","user":{"login":"dwightguth","id":5104541,"avatar_url":"https://avatars0.githubusercontent.com/u/5104541?v=4","gravatar_id":"","url":"https://api.github.com/users/dwightguth","html_url":"https://github.com/dwightguth","followers_url":"https://api.github.com/users/dwightguth/followers","following_url":"https://api.github.com/users/dwightguth/following{/other_user}","gists_url":"https://api.github.com/users/dwightguth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwightguth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwightguth/subscriptions","organizations_url":"https://api.github.com/users/dwightguth/orgs","repos_url":"https://api.github.com/users/dwightguth/repos","events_url":"https://api.github.com/users/dwightguth/events{/privacy}","received_events_url":"https://api.github.com/users/dwightguth/received_events","type":"User","site_admin":false},"body":"I put the error on the function call expression instead, so this is actually now valid. You just can't ever call the function. That's why this code had to change.","created_at":"2018-05-11T03:32:16Z","updated_at":"2018-05-11T03:32:16Z","html_url":"https://github.com/runtimeverification/solidity/pull/149#discussion_r187513087","pull_request_url":"https://api.github.com/repos/runtimeverification/solidity/pulls/149","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/runtimeverification/solidity/pulls/comments/187513087"},"html":{"href":"https://github.com/runtimeverification/solidity/pull/149#discussion_r187513087"},"pull_request":{"href":"https://api.github.com/repos/runtimeverification/solidity/pulls/149"}},"in_reply_to_id":187509486},"pull_request":{"url":"https://api.github.com/repos/runtimeverification/solidity/pulls/149","id":187037719,"html_url":"https://github.com/runtimeverification/solidity/pull/149","diff_url":"https://github.com/runtimeverification/solidity/pull/149.diff","patch_url":"https://github.com/runtimeverification/solidity/pull/149.patch","issue_url":"https://api.github.com/repos/runtimeverification/solidity/issues/149","number":149,"state":"open","locked":false,"title":" add errors for unsupported solidity features ","user":{"login":"dwightguth","id":5104541,"avatar_url":"https://avatars0.githubusercontent.com/u/5104541?v=4","gravatar_id":"","url":"https://api.github.com/users/dwightguth","html_url":"https://github.com/dwightguth","followers_url":"https://api.github.com/users/dwightguth/followers","following_url":"https://api.github.com/users/dwightguth/following{/other_user}","gists_url":"https://api.github.com/users/dwightguth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwightguth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwightguth/subscriptions","organizations_url":"https://api.github.com/users/dwightguth/orgs","repos_url":"https://api.github.com/users/dwightguth/repos","events_url":"https://api.github.com/users/dwightguth/events{/privacy}","received_events_url":"https://api.github.com/users/dwightguth/received_events","type":"User","site_admin":false},"body":"Fixes #142 \r\n\r\nReady for review.","created_at":"2018-05-09T20:55:27Z","updated_at":"2018-05-11T03:32:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d70119adf75a712c5b4e8149448de7e56cfb0f54","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/runtimeverification/solidity/pulls/149/commits","review_comments_url":"https://api.github.com/repos/runtimeverification/solidity/pulls/149/comments","review_comment_url":"https://api.github.com/repos/runtimeverification/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runtimeverification/solidity/issues/149/comments","statuses_url":"https://api.github.com/repos/runtimeverification/solidity/statuses/309090592d82da5f9c364fcbebe25b329dbb5668","head":{"label":"runtimeverification:analysis","ref":"analysis","sha":"309090592d82da5f9c364fcbebe25b329dbb5668","user":{"login":"runtimeverification","id":3732719,"avatar_url":"https://avatars1.githubusercontent.com/u/3732719?v=4","gravatar_id":"","url":"https://api.github.com/users/runtimeverification","html_url":"https://github.com/runtimeverification","followers_url":"https://api.github.com/users/runtimeverification/followers","following_url":"https://api.github.com/users/runtimeverification/following{/other_user}","gists_url":"https://api.github.com/users/runtimeverification/gists{/gist_id}","starred_url":"https://api.github.com/users/runtimeverification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runtimeverification/subscriptions","organizations_url":"https://api.github.com/users/runtimeverification/orgs","repos_url":"https://api.github.com/users/runtimeverification/repos","events_url":"https://api.github.com/users/runtimeverification/events{/privacy}","received_events_url":"https://api.github.com/users/runtimeverification/received_events","type":"Organization","site_admin":false},"repo":{"id":117586276,"name":"solidity","full_name":"runtimeverification/solidity","owner":{"login":"runtimeverification","id":3732719,"avatar_url":"https://avatars1.githubusercontent.com/u/3732719?v=4","gravatar_id":"","url":"https://api.github.com/users/runtimeverification","html_url":"https://github.com/runtimeverification","followers_url":"https://api.github.com/users/runtimeverification/followers","following_url":"https://api.github.com/users/runtimeverification/following{/other_user}","gists_url":"https://api.github.com/users/runtimeverification/gists{/gist_id}","starred_url":"https://api.github.com/users/runtimeverification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runtimeverification/subscriptions","organizations_url":"https://api.github.com/users/runtimeverification/orgs","repos_url":"https://api.github.com/users/runtimeverification/repos","events_url":"https://api.github.com/users/runtimeverification/events{/privacy}","received_events_url":"https://api.github.com/users/runtimeverification/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runtimeverification/solidity","description":"Fork of the Solidity Compiler for compiling Solidity to IELE","fork":false,"url":"https://api.github.com/repos/runtimeverification/solidity","forks_url":"https://api.github.com/repos/runtimeverification/solidity/forks","keys_url":"https://api.github.com/repos/runtimeverification/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runtimeverification/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runtimeverification/solidity/teams","hooks_url":"https://api.github.com/repos/runtimeverification/solidity/hooks","issue_events_url":"https://api.github.com/repos/runtimeverification/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/runtimeverification/solidity/events","assignees_url":"https://api.github.com/repos/runtimeverification/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/runtimeverification/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/runtimeverification/solidity/tags","blobs_url":"https://api.github.com/repos/runtimeverification/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runtimeverification/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runtimeverification/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/runtimeverification/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runtimeverification/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/runtimeverification/solidity/languages","stargazers_url":"https://api.github.com/repos/runtimeverification/solidity/stargazers","contributors_url":"https://api.github.com/repos/runtimeverification/solidity/contributors","subscribers_url":"https://api.github.com/repos/runtimeverification/solidity/subscribers","subscription_url":"https://api.github.com/repos/runtimeverification/solidity/subscription","commits_url":"https://api.github.com/repos/runtimeverification/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/runtimeverification/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/runtimeverification/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/runtimeverification/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/runtimeverification/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/runtimeverification/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runtimeverification/solidity/merges","archive_url":"https://api.github.com/repos/runtimeverification/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runtimeverification/solidity/downloads","issues_url":"https://api.github.com/repos/runtimeverification/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/runtimeverification/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/runtimeverification/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/runtimeverification/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runtimeverification/solidity/labels{/name}","releases_url":"https://api.github.com/repos/runtimeverification/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/runtimeverification/solidity/deployments","created_at":"2018-01-15T19:25:16Z","updated_at":"2018-05-10T15:31:09Z","pushed_at":"2018-05-10T22:14:58Z","git_url":"git://github.com/runtimeverification/solidity.git","ssh_url":"git@github.com:runtimeverification/solidity.git","clone_url":"https://github.com/runtimeverification/solidity.git","svn_url":"https://github.com/runtimeverification/solidity","homepage":"","size":17739,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":2,"open_issues":6,"watchers":1,"default_branch":"sol2iele"}},"base":{"label":"runtimeverification:sol2iele","ref":"sol2iele","sha":"21f02814844ada7fd6e55f993e8f55dbf35eedf1","user":{"login":"runtimeverification","id":3732719,"avatar_url":"https://avatars1.githubusercontent.com/u/3732719?v=4","gravatar_id":"","url":"https://api.github.com/users/runtimeverification","html_url":"https://github.com/runtimeverification","followers_url":"https://api.github.com/users/runtimeverification/followers","following_url":"https://api.github.com/users/runtimeverification/following{/other_user}","gists_url":"https://api.github.com/users/runtimeverification/gists{/gist_id}","starred_url":"https://api.github.com/users/runtimeverification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runtimeverification/subscriptions","organizations_url":"https://api.github.com/users/runtimeverification/orgs","repos_url":"https://api.github.com/users/runtimeverification/repos","events_url":"https://api.github.com/users/runtimeverification/events{/privacy}","received_events_url":"https://api.github.com/users/runtimeverification/received_events","type":"Organization","site_admin":false},"repo":{"id":117586276,"name":"solidity","full_name":"runtimeverification/solidity","owner":{"login":"runtimeverification","id":3732719,"avatar_url":"https://avatars1.githubusercontent.com/u/3732719?v=4","gravatar_id":"","url":"https://api.github.com/users/runtimeverification","html_url":"https://github.com/runtimeverification","followers_url":"https://api.github.com/users/runtimeverification/followers","following_url":"https://api.github.com/users/runtimeverification/following{/other_user}","gists_url":"https://api.github.com/users/runtimeverification/gists{/gist_id}","starred_url":"https://api.github.com/users/runtimeverification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runtimeverification/subscriptions","organizations_url":"https://api.github.com/users/runtimeverification/orgs","repos_url":"https://api.github.com/users/runtimeverification/repos","events_url":"https://api.github.com/users/runtimeverification/events{/privacy}","received_events_url":"https://api.github.com/users/runtimeverification/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runtimeverification/solidity","description":"Fork of the Solidity Compiler for compiling Solidity to IELE","fork":false,"url":"https://api.github.com/repos/runtimeverification/solidity","forks_url":"https://api.github.com/repos/runtimeverification/solidity/forks","keys_url":"https://api.github.com/repos/runtimeverification/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runtimeverification/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runtimeverification/solidity/teams","hooks_url":"https://api.github.com/repos/runtimeverification/solidity/hooks","issue_events_url":"https://api.github.com/repos/runtimeverification/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/runtimeverification/solidity/events","assignees_url":"https://api.github.com/repos/runtimeverification/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/runtimeverification/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/runtimeverification/solidity/tags","blobs_url":"https://api.github.com/repos/runtimeverification/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runtimeverification/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runtimeverification/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/runtimeverification/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runtimeverification/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/runtimeverification/solidity/languages","stargazers_url":"https://api.github.com/repos/runtimeverification/solidity/stargazers","contributors_url":"https://api.github.com/repos/runtimeverification/solidity/contributors","subscribers_url":"https://api.github.com/repos/runtimeverification/solidity/subscribers","subscription_url":"https://api.github.com/repos/runtimeverification/solidity/subscription","commits_url":"https://api.github.com/repos/runtimeverification/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/runtimeverification/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/runtimeverification/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/runtimeverification/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/runtimeverification/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/runtimeverification/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runtimeverification/solidity/merges","archive_url":"https://api.github.com/repos/runtimeverification/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runtimeverification/solidity/downloads","issues_url":"https://api.github.com/repos/runtimeverification/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/runtimeverification/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/runtimeverification/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/runtimeverification/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runtimeverification/solidity/labels{/name}","releases_url":"https://api.github.com/repos/runtimeverification/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/runtimeverification/solidity/deployments","created_at":"2018-01-15T19:25:16Z","updated_at":"2018-05-10T15:31:09Z","pushed_at":"2018-05-10T22:14:58Z","git_url":"git://github.com/runtimeverification/solidity.git","ssh_url":"git@github.com:runtimeverification/solidity.git","clone_url":"https://github.com/runtimeverification/solidity.git","svn_url":"https://github.com/runtimeverification/solidity","homepage":"","size":17739,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":2,"open_issues":6,"watchers":1,"default_branch":"sol2iele"}},"_links":{"self":{"href":"https://api.github.com/repos/runtimeverification/solidity/pulls/149"},"html":{"href":"https://github.com/runtimeverification/solidity/pull/149"},"issue":{"href":"https://api.github.com/repos/runtimeverification/solidity/issues/149"},"comments":{"href":"https://api.github.com/repos/runtimeverification/solidity/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/runtimeverification/solidity/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/runtimeverification/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runtimeverification/solidity/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/runtimeverification/solidity/statuses/309090592d82da5f9c364fcbebe25b329dbb5668"}},"author_association":"OWNER"}}
{"actor":{"display_login":"dwightguth"}}