{"action":"created","comment":{"url":"https://api.github.com/repos/nunit/nunit/pulls/comments/190769731","pull_request_review_id":123219600,"id":190769731,"diff_hunk":"@@ -104,5 +87,92 @@ public void TryRemove(IEnumerable c)\n             foreach (object o in c)\n                 TryRemove(o);\n         }\n+\n+        private class MissingItemCollection : IEnumerable<object>","path":"src/NUnitFramework/framework/Constraints/CollectionTally.cs","position":66,"original_position":66,"commit_id":"d893d83bbd18dd19474511d9058561f6713123da","original_commit_id":"d893d83bbd18dd19474511d9058561f6713123da","user":{"login":"jnm2","id":8040367,"avatar_url":"https://avatars2.githubusercontent.com/u/8040367?v=4","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"body":"It feels like we're introducing a second collection tally class though. I'm not comfortable with it.","created_at":"2018-05-25T01:11:51Z","updated_at":"2018-05-25T01:11:52Z","html_url":"https://github.com/nunit/nunit/pull/2830#discussion_r190769731","pull_request_url":"https://api.github.com/repos/nunit/nunit/pulls/2830","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments/190769731"},"html":{"href":"https://github.com/nunit/nunit/pull/2830#discussion_r190769731"},"pull_request":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2830"}},"in_reply_to_id":190076022},"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/2830","id":184485768,"html_url":"https://github.com/nunit/nunit/pull/2830","diff_url":"https://github.com/nunit/nunit/pull/2830.diff","patch_url":"https://github.com/nunit/nunit/pull/2830.patch","issue_url":"https://api.github.com/repos/nunit/nunit/issues/2830","number":2830,"state":"open","locked":false,"title":"Fix for #2799 and #2826: slow collection equivalence tests.","user":{"login":"ggeurts","id":684925,"avatar_url":"https://avatars2.githubusercontent.com/u/684925?v=4","gravatar_id":"","url":"https://api.github.com/users/ggeurts","html_url":"https://github.com/ggeurts","followers_url":"https://api.github.com/users/ggeurts/followers","following_url":"https://api.github.com/users/ggeurts/following{/other_user}","gists_url":"https://api.github.com/users/ggeurts/gists{/gist_id}","starred_url":"https://api.github.com/users/ggeurts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggeurts/subscriptions","organizations_url":"https://api.github.com/users/ggeurts/orgs","repos_url":"https://api.github.com/users/ggeurts/repos","events_url":"https://api.github.com/users/ggeurts/events{/privacy}","received_events_url":"https://api.github.com/users/ggeurts/received_events","type":"User","site_admin":false},"body":"Fixes #2799","created_at":"2018-04-26T23:01:25Z","updated_at":"2018-05-25T01:11:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45b9bee39907b9554eab3cd571bb6f4d1f3a5efd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":805813973,"url":"https://api.github.com/repos/nunit/nunit/labels/awaiting:contributor","name":"awaiting:contributor","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nunit/nunit/pulls/2830/commits","review_comments_url":"https://api.github.com/repos/nunit/nunit/pulls/2830/comments","review_comment_url":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/2830/comments","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/d893d83bbd18dd19474511d9058561f6713123da","head":{"label":"ggeurts:issue-2799","ref":"issue-2799","sha":"d893d83bbd18dd19474511d9058561f6713123da","user":{"login":"ggeurts","id":684925,"avatar_url":"https://avatars2.githubusercontent.com/u/684925?v=4","gravatar_id":"","url":"https://api.github.com/users/ggeurts","html_url":"https://github.com/ggeurts","followers_url":"https://api.github.com/users/ggeurts/followers","following_url":"https://api.github.com/users/ggeurts/following{/other_user}","gists_url":"https://api.github.com/users/ggeurts/gists{/gist_id}","starred_url":"https://api.github.com/users/ggeurts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggeurts/subscriptions","organizations_url":"https://api.github.com/users/ggeurts/orgs","repos_url":"https://api.github.com/users/ggeurts/repos","events_url":"https://api.github.com/users/ggeurts/events{/privacy}","received_events_url":"https://api.github.com/users/ggeurts/received_events","type":"User","site_admin":false},"repo":{"id":66562778,"name":"nunit","full_name":"ggeurts/nunit","owner":{"login":"ggeurts","id":684925,"avatar_url":"https://avatars2.githubusercontent.com/u/684925?v=4","gravatar_id":"","url":"https://api.github.com/users/ggeurts","html_url":"https://github.com/ggeurts","followers_url":"https://api.github.com/users/ggeurts/followers","following_url":"https://api.github.com/users/ggeurts/following{/other_user}","gists_url":"https://api.github.com/users/ggeurts/gists{/gist_id}","starred_url":"https://api.github.com/users/ggeurts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggeurts/subscriptions","organizations_url":"https://api.github.com/users/ggeurts/orgs","repos_url":"https://api.github.com/users/ggeurts/repos","events_url":"https://api.github.com/users/ggeurts/events{/privacy}","received_events_url":"https://api.github.com/users/ggeurts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggeurts/nunit","description":"NUnit 3.0 Framework","fork":true,"url":"https://api.github.com/repos/ggeurts/nunit","forks_url":"https://api.github.com/repos/ggeurts/nunit/forks","keys_url":"https://api.github.com/repos/ggeurts/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggeurts/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggeurts/nunit/teams","hooks_url":"https://api.github.com/repos/ggeurts/nunit/hooks","issue_events_url":"https://api.github.com/repos/ggeurts/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/ggeurts/nunit/events","assignees_url":"https://api.github.com/repos/ggeurts/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/ggeurts/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/ggeurts/nunit/tags","blobs_url":"https://api.github.com/repos/ggeurts/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggeurts/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggeurts/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggeurts/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggeurts/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/ggeurts/nunit/languages","stargazers_url":"https://api.github.com/repos/ggeurts/nunit/stargazers","contributors_url":"https://api.github.com/repos/ggeurts/nunit/contributors","subscribers_url":"https://api.github.com/repos/ggeurts/nunit/subscribers","subscription_url":"https://api.github.com/repos/ggeurts/nunit/subscription","commits_url":"https://api.github.com/repos/ggeurts/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggeurts/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggeurts/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggeurts/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggeurts/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/ggeurts/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggeurts/nunit/merges","archive_url":"https://api.github.com/repos/ggeurts/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggeurts/nunit/downloads","issues_url":"https://api.github.com/repos/ggeurts/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/ggeurts/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/ggeurts/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/ggeurts/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggeurts/nunit/labels{/name}","releases_url":"https://api.github.com/repos/ggeurts/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/ggeurts/nunit/deployments","created_at":"2016-08-25T14:01:50Z","updated_at":"2018-04-26T10:12:37Z","pushed_at":"2018-05-04T11:34:26Z","git_url":"git://github.com/ggeurts/nunit.git","ssh_url":"git@github.com:ggeurts/nunit.git","clone_url":"https://github.com/ggeurts/nunit.git","svn_url":"https://github.com/ggeurts/nunit","homepage":"http://www.nunit.org/","size":34832,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nunit:master","ref":"master","sha":"662055f789a8528e851e63c6566822e9392a46d1","user":{"login":"nunit","id":2678858,"avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":13692183,"name":"nunit","full_name":"nunit/nunit","owner":{"login":"nunit","id":2678858,"avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nunit/nunit","description":"NUnit 3.0 Framework","fork":false,"url":"https://api.github.com/repos/nunit/nunit","forks_url":"https://api.github.com/repos/nunit/nunit/forks","keys_url":"https://api.github.com/repos/nunit/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/nunit/teams","hooks_url":"https://api.github.com/repos/nunit/nunit/hooks","issue_events_url":"https://api.github.com/repos/nunit/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/nunit/events","assignees_url":"https://api.github.com/repos/nunit/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/nunit/tags","blobs_url":"https://api.github.com/repos/nunit/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/nunit/languages","stargazers_url":"https://api.github.com/repos/nunit/nunit/stargazers","contributors_url":"https://api.github.com/repos/nunit/nunit/contributors","subscribers_url":"https://api.github.com/repos/nunit/nunit/subscribers","subscription_url":"https://api.github.com/repos/nunit/nunit/subscription","commits_url":"https://api.github.com/repos/nunit/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunit/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/nunit/merges","archive_url":"https://api.github.com/repos/nunit/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/nunit/downloads","issues_url":"https://api.github.com/repos/nunit/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/nunit/labels{/name}","releases_url":"https://api.github.com/repos/nunit/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/nunit/nunit/deployments","created_at":"2013-10-18T23:43:29Z","updated_at":"2018-05-24T02:50:03Z","pushed_at":"2018-05-23T12:48:32Z","git_url":"git://github.com/nunit/nunit.git","ssh_url":"git@github.com:nunit/nunit.git","clone_url":"https://github.com/nunit/nunit.git","svn_url":"https://github.com/nunit/nunit","homepage":"http://www.nunit.org/","size":34338,"stargazers_count":1315,"watchers_count":1315,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":479,"mirror_url":null,"archived":false,"open_issues_count":282,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":479,"open_issues":282,"watchers":1315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2830"},"html":{"href":"https://github.com/nunit/nunit/pull/2830"},"issue":{"href":"https://api.github.com/repos/nunit/nunit/issues/2830"},"comments":{"href":"https://api.github.com/repos/nunit/nunit/issues/2830/comments"},"review_comments":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2830/comments"},"review_comment":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2830/commits"},"statuses":{"href":"https://api.github.com/repos/nunit/nunit/statuses/d893d83bbd18dd19474511d9058561f6713123da"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jnm2"}}