{"action":"created","comment":{"url":"https://api.github.com/repos/aicis/fresco/pulls/comments/175274205","pull_request_review_id":104782365,"id":175274205,"diff_hunk":"@@ -48,23 +48,18 @@ public void shutdown() {\n     testRuntime.shutdown();\n   }\n \n-  private List<Pair<StrictBitVector, StrictBitVector>> otSend(int iterations)\n-      throws Exception {\n-    Network network = new CheatingNetwork(\n-        RuntimeForTests.defaultNetworkConfiguration(1, Arrays.asList(1, 2)));\n+  private List<Pair<StrictBitVector, StrictBitVector>> otSend(int iterations) throws Exception {\n+    Network network =\n+        new CheatingNetwork(RuntimeForTests.defaultNetworkConfiguration(1, Arrays.asList(1, 2)));\n     try {\n       Drbg rand = new AesCtrDrbg(HelperForTests.seedOne);\n-      DhParameters params = new DhParameters();\n-      Ot otSender = new NaorPinkasOt(2, rand, network, params\n-          .computeSecureDhParams(1, 2, rand, network));","path":"tools/ot/src/test/java/dk/alexandra/fresco/tools/ot/base/TestFunctionalNaorPinkas.java","position":15,"original_position":15,"commit_id":"a04e650a3fb6518635d84a64f261a763f4d1c0e2","original_commit_id":"a04e650a3fb6518635d84a64f261a763f4d1c0e2","user":{"login":"jot2re","id":33345641,"avatar_url":"https://avatars2.githubusercontent.com/u/33345641?v=4","gravatar_id":"","url":"https://api.github.com/users/jot2re","html_url":"https://github.com/jot2re","followers_url":"https://api.github.com/users/jot2re/followers","following_url":"https://api.github.com/users/jot2re/following{/other_user}","gists_url":"https://api.github.com/users/jot2re/gists{/gist_id}","starred_url":"https://api.github.com/users/jot2re/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jot2re/subscriptions","organizations_url":"https://api.github.com/users/jot2re/orgs","repos_url":"https://api.github.com/users/jot2re/repos","events_url":"https://api.github.com/users/jot2re/events{/privacy}","received_events_url":"https://api.github.com/users/jot2re/received_events","type":"User","site_admin":false},"body":"Do we want to remove the option of computing computeSecureDhParams from DhParameters? Because if not, then the testing using this method should not have been removed from all the tests in this class. On the other hand if we do want to remove the computeSecureDhParams  option then the code for this method should be removed from DhParameters.","created_at":"2018-03-18T00:43:19Z","updated_at":"2018-03-18T00:43:20Z","html_url":"https://github.com/aicis/fresco/pull/249#discussion_r175274205","pull_request_url":"https://api.github.com/repos/aicis/fresco/pulls/249","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/aicis/fresco/pulls/comments/175274205"},"html":{"href":"https://github.com/aicis/fresco/pull/249#discussion_r175274205"},"pull_request":{"href":"https://api.github.com/repos/aicis/fresco/pulls/249"}}},"pull_request":{"url":"https://api.github.com/repos/aicis/fresco/pulls/249","id":175378075,"html_url":"https://github.com/aicis/fresco/pull/249","diff_url":"https://github.com/aicis/fresco/pull/249.diff","patch_url":"https://github.com/aicis/fresco/pull/249.patch","issue_url":"https://api.github.com/repos/aicis/fresco/issues/249","number":249,"state":"open","locked":false,"title":"Minimize drbg initialization in ot extension, small optimizations and streams","user":{"login":"GuutBoy","id":6916414,"avatar_url":"https://avatars0.githubusercontent.com/u/6916414?v=4","gravatar_id":"","url":"https://api.github.com/users/GuutBoy","html_url":"https://github.com/GuutBoy","followers_url":"https://api.github.com/users/GuutBoy/followers","following_url":"https://api.github.com/users/GuutBoy/following{/other_user}","gists_url":"https://api.github.com/users/GuutBoy/gists{/gist_id}","starred_url":"https://api.github.com/users/GuutBoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuutBoy/subscriptions","organizations_url":"https://api.github.com/users/GuutBoy/orgs","repos_url":"https://api.github.com/users/GuutBoy/repos","events_url":"https://api.github.com/users/GuutBoy/events{/privacy}","received_events_url":"https://api.github.com/users/GuutBoy/received_events","type":"User","site_admin":false},"body":"This pull request:\r\n1. Reduces the number of DRBG initializations in the `BristolRotBatch` class in order to optimize OT extension performance. This is done by introducing a utility class to adjust the length a random string to match a desired length. This works by, if necessary, stretching the string using a hash function but otherwise using the provided string. An other utility uses this to implement form of OTP encryption. (fixes #248 )\r\n2. Moves many parts of the OT-extension from loops to streams.\r\n3. Improves the `Transpose` utility class by copying byte arrays bytewise instead of bitwise\r\n4. Improves the `MultiplyWithoutReduction` method in the `RotSharedImpl` class by pre-computing all possible rotations of the `bvec` input.  \r\n\r\n","created_at":"2018-03-15T21:02:50Z","updated_at":"2018-03-18T00:43:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f254819c26b6bbdd09b75fe87d5ca08c8015af20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aicis/fresco/pulls/249/commits","review_comments_url":"https://api.github.com/repos/aicis/fresco/pulls/249/comments","review_comment_url":"https://api.github.com/repos/aicis/fresco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aicis/fresco/issues/249/comments","statuses_url":"https://api.github.com/repos/aicis/fresco/statuses/a04e650a3fb6518635d84a64f261a763f4d1c0e2","head":{"label":"aicis:Minimize-DRBG-Initialization-in-OTExtension-and-MASCOT","ref":"Minimize-DRBG-Initialization-in-OTExtension-and-MASCOT","sha":"a04e650a3fb6518635d84a64f261a763f4d1c0e2","user":{"login":"aicis","id":23210753,"avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"repo":{"id":46789213,"name":"fresco","full_name":"aicis/fresco","owner":{"login":"aicis","id":23210753,"avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aicis/fresco","description":"A FRamework for Efficient Secure COmputation","fork":false,"url":"https://api.github.com/repos/aicis/fresco","forks_url":"https://api.github.com/repos/aicis/fresco/forks","keys_url":"https://api.github.com/repos/aicis/fresco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aicis/fresco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aicis/fresco/teams","hooks_url":"https://api.github.com/repos/aicis/fresco/hooks","issue_events_url":"https://api.github.com/repos/aicis/fresco/issues/events{/number}","events_url":"https://api.github.com/repos/aicis/fresco/events","assignees_url":"https://api.github.com/repos/aicis/fresco/assignees{/user}","branches_url":"https://api.github.com/repos/aicis/fresco/branches{/branch}","tags_url":"https://api.github.com/repos/aicis/fresco/tags","blobs_url":"https://api.github.com/repos/aicis/fresco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aicis/fresco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aicis/fresco/git/refs{/sha}","trees_url":"https://api.github.com/repos/aicis/fresco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aicis/fresco/statuses/{sha}","languages_url":"https://api.github.com/repos/aicis/fresco/languages","stargazers_url":"https://api.github.com/repos/aicis/fresco/stargazers","contributors_url":"https://api.github.com/repos/aicis/fresco/contributors","subscribers_url":"https://api.github.com/repos/aicis/fresco/subscribers","subscription_url":"https://api.github.com/repos/aicis/fresco/subscription","commits_url":"https://api.github.com/repos/aicis/fresco/commits{/sha}","git_commits_url":"https://api.github.com/repos/aicis/fresco/git/commits{/sha}","comments_url":"https://api.github.com/repos/aicis/fresco/comments{/number}","issue_comment_url":"https://api.github.com/repos/aicis/fresco/issues/comments{/number}","contents_url":"https://api.github.com/repos/aicis/fresco/contents/{+path}","compare_url":"https://api.github.com/repos/aicis/fresco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aicis/fresco/merges","archive_url":"https://api.github.com/repos/aicis/fresco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aicis/fresco/downloads","issues_url":"https://api.github.com/repos/aicis/fresco/issues{/number}","pulls_url":"https://api.github.com/repos/aicis/fresco/pulls{/number}","milestones_url":"https://api.github.com/repos/aicis/fresco/milestones{/number}","notifications_url":"https://api.github.com/repos/aicis/fresco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aicis/fresco/labels{/name}","releases_url":"https://api.github.com/repos/aicis/fresco/releases{/id}","deployments_url":"https://api.github.com/repos/aicis/fresco/deployments","created_at":"2015-11-24T12:05:17Z","updated_at":"2018-03-06T20:57:27Z","pushed_at":"2018-03-16T09:39:50Z","git_url":"git://github.com/aicis/fresco.git","ssh_url":"git@github.com:aicis/fresco.git","clone_url":"https://github.com/aicis/fresco.git","svn_url":"https://github.com/aicis/fresco","homepage":null,"size":15062,"stargazers_count":21,"watchers_count":21,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":16,"watchers":21,"default_branch":"master"}},"base":{"label":"aicis:master","ref":"master","sha":"c4c2e2b41d9ef6e0f322b957efbac5db97fedf9f","user":{"login":"aicis","id":23210753,"avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"repo":{"id":46789213,"name":"fresco","full_name":"aicis/fresco","owner":{"login":"aicis","id":23210753,"avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aicis/fresco","description":"A FRamework for Efficient Secure COmputation","fork":false,"url":"https://api.github.com/repos/aicis/fresco","forks_url":"https://api.github.com/repos/aicis/fresco/forks","keys_url":"https://api.github.com/repos/aicis/fresco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aicis/fresco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aicis/fresco/teams","hooks_url":"https://api.github.com/repos/aicis/fresco/hooks","issue_events_url":"https://api.github.com/repos/aicis/fresco/issues/events{/number}","events_url":"https://api.github.com/repos/aicis/fresco/events","assignees_url":"https://api.github.com/repos/aicis/fresco/assignees{/user}","branches_url":"https://api.github.com/repos/aicis/fresco/branches{/branch}","tags_url":"https://api.github.com/repos/aicis/fresco/tags","blobs_url":"https://api.github.com/repos/aicis/fresco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aicis/fresco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aicis/fresco/git/refs{/sha}","trees_url":"https://api.github.com/repos/aicis/fresco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aicis/fresco/statuses/{sha}","languages_url":"https://api.github.com/repos/aicis/fresco/languages","stargazers_url":"https://api.github.com/repos/aicis/fresco/stargazers","contributors_url":"https://api.github.com/repos/aicis/fresco/contributors","subscribers_url":"https://api.github.com/repos/aicis/fresco/subscribers","subscription_url":"https://api.github.com/repos/aicis/fresco/subscription","commits_url":"https://api.github.com/repos/aicis/fresco/commits{/sha}","git_commits_url":"https://api.github.com/repos/aicis/fresco/git/commits{/sha}","comments_url":"https://api.github.com/repos/aicis/fresco/comments{/number}","issue_comment_url":"https://api.github.com/repos/aicis/fresco/issues/comments{/number}","contents_url":"https://api.github.com/repos/aicis/fresco/contents/{+path}","compare_url":"https://api.github.com/repos/aicis/fresco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aicis/fresco/merges","archive_url":"https://api.github.com/repos/aicis/fresco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aicis/fresco/downloads","issues_url":"https://api.github.com/repos/aicis/fresco/issues{/number}","pulls_url":"https://api.github.com/repos/aicis/fresco/pulls{/number}","milestones_url":"https://api.github.com/repos/aicis/fresco/milestones{/number}","notifications_url":"https://api.github.com/repos/aicis/fresco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aicis/fresco/labels{/name}","releases_url":"https://api.github.com/repos/aicis/fresco/releases{/id}","deployments_url":"https://api.github.com/repos/aicis/fresco/deployments","created_at":"2015-11-24T12:05:17Z","updated_at":"2018-03-06T20:57:27Z","pushed_at":"2018-03-16T09:39:50Z","git_url":"git://github.com/aicis/fresco.git","ssh_url":"git@github.com:aicis/fresco.git","clone_url":"https://github.com/aicis/fresco.git","svn_url":"https://github.com/aicis/fresco","homepage":null,"size":15062,"stargazers_count":21,"watchers_count":21,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":16,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aicis/fresco/pulls/249"},"html":{"href":"https://github.com/aicis/fresco/pull/249"},"issue":{"href":"https://api.github.com/repos/aicis/fresco/issues/249"},"comments":{"href":"https://api.github.com/repos/aicis/fresco/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/aicis/fresco/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/aicis/fresco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aicis/fresco/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/aicis/fresco/statuses/a04e650a3fb6518635d84a64f261a763f4d1c0e2"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jot2re"}}