{"action":"created","issue":{"url":"https://api.github.com/repos/nextcloud/nextcloud-snap/issues/729","repository_url":"https://api.github.com/repos/nextcloud/nextcloud-snap","labels_url":"https://api.github.com/repos/nextcloud/nextcloud-snap/issues/729/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/nextcloud-snap/issues/729/comments","events_url":"https://api.github.com/repos/nextcloud/nextcloud-snap/issues/729/events","html_url":"https://github.com/nextcloud/nextcloud-snap/pull/729","id":362955800,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTE3NzE4","number":729,"title":"apache, php: add debug mode","user":{"login":"kyrofa","id":946674,"node_id":"MDQ6VXNlcjk0NjY3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/946674?v=4","gravatar_id":"","url":"https://api.github.com/users/kyrofa","html_url":"https://github.com/kyrofa","followers_url":"https://api.github.com/users/kyrofa/followers","following_url":"https://api.github.com/users/kyrofa/following{/other_user}","gists_url":"https://api.github.com/users/kyrofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrofa/subscriptions","organizations_url":"https://api.github.com/users/kyrofa/orgs","repos_url":"https://api.github.com/users/kyrofa/repos","events_url":"https://api.github.com/users/kyrofa/events{/privacy}","received_events_url":"https://api.github.com/users/kyrofa/received_events","type":"User","site_admin":false},"labels":[{"id":593477374,"node_id":"MDU6TGFiZWw1OTM0NzczNzQ=","url":"https://api.github.com/repos/nextcloud/nextcloud-snap/labels/security","name":"security","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-23T16:22:11Z","updated_at":"2018-09-23T23:40:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nextcloud/nextcloud-snap/pulls/729","html_url":"https://github.com/nextcloud/nextcloud-snap/pull/729","diff_url":"https://github.com/nextcloud/nextcloud-snap/pull/729.diff","patch_url":"https://github.com/nextcloud/nextcloud-snap/pull/729.patch"},"body":"By default, both Apache and PHP provide detailed version information in the HTTP headers and error pages. This PR resolves #612 by making the default behavior hide this information, but allows them to optionally be enabled by adding a new configuration value named `mode` which can contain two possible values: \"debug\" and \"production\"."},"comment":{"url":"https://api.github.com/repos/nextcloud/nextcloud-snap/issues/comments/423856590","html_url":"https://github.com/nextcloud/nextcloud-snap/pull/729#issuecomment-423856590","issue_url":"https://api.github.com/repos/nextcloud/nextcloud-snap/issues/729","id":423856590,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzg1NjU5MA==","user":{"login":"kyrofa","id":946674,"node_id":"MDQ6VXNlcjk0NjY3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/946674?v=4","gravatar_id":"","url":"https://api.github.com/users/kyrofa","html_url":"https://github.com/kyrofa","followers_url":"https://api.github.com/users/kyrofa/followers","following_url":"https://api.github.com/users/kyrofa/following{/other_user}","gists_url":"https://api.github.com/users/kyrofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrofa/subscriptions","organizations_url":"https://api.github.com/users/kyrofa/orgs","repos_url":"https://api.github.com/users/kyrofa/repos","events_url":"https://api.github.com/users/kyrofa/events{/privacy}","received_events_url":"https://api.github.com/users/kyrofa/received_events","type":"User","site_admin":false},"created_at":"2018-09-23T23:40:05Z","updated_at":"2018-09-23T23:40:05Z","author_association":"MEMBER","body":"@pachulo and @r4co0n, I'd like a review from at least one of you on this one. How to test it is your call, but I'll tell you how I tested it (beyond the tests in this PR, of course): `curl -I <nextcloud address>`, which should print the headers. In production mode (which should be the default, but you can also run `snap set nextcloud mode=production`), the \"server\" header should only be \"Apache\". There should be nothing at all in the headers about PHP. Also, if you navigate to a random page in Nextcloud such that a 404 is displayed, there should be nothing mentioned about Apache.\r\n\r\nIn debug mode (`snap set nextcloud mode=debug`), the \"server\" header should mention both the version of Apache as well as the operating system. There should also be a \"x-powered-by\" header that mentions the version of Apache. Finally, a 404 page should mention Apache as well."}}
{"actor":{"display_login":"kyrofa"}}