{"action":"created","comment":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments/199957424","pull_request_review_id":134178189,"id":199957424,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTk1NzQyNA==","diff_hunk":"@@ -0,0 +1,27 @@\n+# Ledger // Cosmos\n+\n+### Ledger Support for Account Keys\n+\n+`gaiacli` now supports derivation of account keys from a Ledger seed. To use this functionality you will need the following:\n+\n+- A running `gaiad` instance connected to the network you wish to use.\n+- A `gaiacli` instance configured to connect to your chosen `gaiad` instance.\n+- A LedgerNano with the `ledger-cosmos` app installed\n+  * Install the Cosmos app onto your Ledger by following the instructions in the [`ledger-cosmos`](https://github.com/cosmos/ledger-cosmos/blob/master/docs/BUILD.md) repository.\n+  * A production-ready version of this app will soon be included in the [Ledger Apps Store](https://www.ledgerwallet.com/apps)\n+\n+Once you have the Cosmos app installed on your Ledger, and the ledger is accessible from the machine you are using `gaiacli` from you can create a new Account key using the ledger:\n+\n+```bash\n+$ gaiacli keys add {{ .Key.Name }} --ledger\n+NAME:\t          TYPE:\t  ADDRESS:\t\t\t\t\t\t                                  PUBKEY:\n+{{ .Key.Name }}\tledger\tcosmosaccaddr1aw64xxr80lwqqdk8u2xhlrkxqaxamkr3e2g943\tcosmosaccpub1addwnpepqvhs678gh9aqrjc2tg2vezw86csnvgzqq530ujkunt5tkuc7lhjkz5mj629\n+```\n+\n+This key will only be accessible while the ledger is plugged in and unlocked. To send some coins with this key, run the following:\n+\n+```bash\n+$ gaiacli send --name {{ .Key.Name }} --to {{ .Destination.AccAddr }} --chain-id=gaia-7000","path":"docs/clients/ledger.md","position":24,"original_position":24,"commit_id":"223b76d3c7992fc5f4f3f96c31c4dead1bd3d99d","original_commit_id":"223b76d3c7992fc5f4f3f96c31c4dead1bd3d99d","user":{"login":"jackzampolin","id":7452680,"node_id":"MDQ6VXNlcjc0NTI2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/7452680?v=4","gravatar_id":"","url":"https://api.github.com/users/jackzampolin","html_url":"https://github.com/jackzampolin","followers_url":"https://api.github.com/users/jackzampolin/followers","following_url":"https://api.github.com/users/jackzampolin/following{/other_user}","gists_url":"https://api.github.com/users/jackzampolin/gists{/gist_id}","starred_url":"https://api.github.com/users/jackzampolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackzampolin/subscriptions","organizations_url":"https://api.github.com/users/jackzampolin/orgs","repos_url":"https://api.github.com/users/jackzampolin/repos","events_url":"https://api.github.com/users/jackzampolin/events{/privacy}","received_events_url":"https://api.github.com/users/jackzampolin/received_events","type":"User","site_admin":false},"body":"Many times docs writers use arbitrary formats for describing variables. A good example of this is our validator getting started documentation. I personally like a format like this because it can make things like this much more clear.","created_at":"2018-07-03T21:37:32Z","updated_at":"2018-07-03T21:37:32Z","html_url":"https://github.com/cosmos/cosmos-sdk/pull/1512#discussion_r199957424","pull_request_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/1512","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments/199957424"},"html":{"href":"https://github.com/cosmos/cosmos-sdk/pull/1512#discussion_r199957424"},"pull_request":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/1512"}},"in_reply_to_id":199675527},"pull_request":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/1512","id":198819797,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODE5Nzk3","html_url":"https://github.com/cosmos/cosmos-sdk/pull/1512","diff_url":"https://github.com/cosmos/cosmos-sdk/pull/1512.diff","patch_url":"https://github.com/cosmos/cosmos-sdk/pull/1512.patch","issue_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/1512","number":1512,"state":"open","locked":false,"title":"Add Ledger Instructions","user":{"login":"jackzampolin","id":7452680,"node_id":"MDQ6VXNlcjc0NTI2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/7452680?v=4","gravatar_id":"","url":"https://api.github.com/users/jackzampolin","html_url":"https://github.com/jackzampolin","followers_url":"https://api.github.com/users/jackzampolin/followers","following_url":"https://api.github.com/users/jackzampolin/following{/other_user}","gists_url":"https://api.github.com/users/jackzampolin/gists{/gist_id}","starred_url":"https://api.github.com/users/jackzampolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackzampolin/subscriptions","organizations_url":"https://api.github.com/users/jackzampolin/orgs","repos_url":"https://api.github.com/users/jackzampolin/repos","events_url":"https://api.github.com/users/jackzampolin/events{/privacy}","received_events_url":"https://api.github.com/users/jackzampolin/received_events","type":"User","site_admin":false},"body":"This adds a brief `README` that details how to use the `ledger` app with `gaiacli`.","created_at":"2018-07-03T00:16:14Z","updated_at":"2018-07-03T21:37:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0cded8f9d07618592819b12e02e779b7f417d55","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ebuchman","id":2300911,"node_id":"MDQ6VXNlcjIzMDA5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":965477209,"node_id":"MDU6TGFiZWw5NjU0NzcyMDk=","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/ready-for-review","name":"ready-for-review","color":"e6fad2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/1512/commits","review_comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/1512/comments","review_comment_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/1512/comments","statuses_url":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/223b76d3c7992fc5f4f3f96c31c4dead1bd3d99d","head":{"label":"jackzampolin:jack/ledger-readme","ref":"jack/ledger-readme","sha":"223b76d3c7992fc5f4f3f96c31c4dead1bd3d99d","user":{"login":"jackzampolin","id":7452680,"node_id":"MDQ6VXNlcjc0NTI2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/7452680?v=4","gravatar_id":"","url":"https://api.github.com/users/jackzampolin","html_url":"https://github.com/jackzampolin","followers_url":"https://api.github.com/users/jackzampolin/followers","following_url":"https://api.github.com/users/jackzampolin/following{/other_user}","gists_url":"https://api.github.com/users/jackzampolin/gists{/gist_id}","starred_url":"https://api.github.com/users/jackzampolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackzampolin/subscriptions","organizations_url":"https://api.github.com/users/jackzampolin/orgs","repos_url":"https://api.github.com/users/jackzampolin/repos","events_url":"https://api.github.com/users/jackzampolin/events{/privacy}","received_events_url":"https://api.github.com/users/jackzampolin/received_events","type":"User","site_admin":false},"repo":{"id":138095309,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgwOTUzMDk=","name":"cosmos-sdk","full_name":"jackzampolin/cosmos-sdk","owner":{"login":"jackzampolin","id":7452680,"node_id":"MDQ6VXNlcjc0NTI2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/7452680?v=4","gravatar_id":"","url":"https://api.github.com/users/jackzampolin","html_url":"https://github.com/jackzampolin","followers_url":"https://api.github.com/users/jackzampolin/followers","following_url":"https://api.github.com/users/jackzampolin/following{/other_user}","gists_url":"https://api.github.com/users/jackzampolin/gists{/gist_id}","starred_url":"https://api.github.com/users/jackzampolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackzampolin/subscriptions","organizations_url":"https://api.github.com/users/jackzampolin/orgs","repos_url":"https://api.github.com/users/jackzampolin/repos","events_url":"https://api.github.com/users/jackzampolin/events{/privacy}","received_events_url":"https://api.github.com/users/jackzampolin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackzampolin/cosmos-sdk","description":"Secure Blockchain Framework","fork":true,"url":"https://api.github.com/repos/jackzampolin/cosmos-sdk","forks_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/forks","keys_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/teams","hooks_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/hooks","issue_events_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/events","assignees_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/tags","blobs_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/languages","stargazers_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/stargazers","contributors_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/contributors","subscribers_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/subscribers","subscription_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/subscription","commits_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/merges","archive_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/downloads","issues_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/labels{/name}","releases_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/jackzampolin/cosmos-sdk/deployments","created_at":"2018-06-20T23:12:21Z","updated_at":"2018-07-03T21:28:16Z","pushed_at":"2018-07-03T21:28:14Z","git_url":"git://github.com/jackzampolin/cosmos-sdk.git","ssh_url":"git@github.com:jackzampolin/cosmos-sdk.git","clone_url":"https://github.com/jackzampolin/cosmos-sdk.git","svn_url":"https://github.com/jackzampolin/cosmos-sdk","homepage":"https://cosmos.network/","size":33745,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cosmos:develop","ref":"develop","sha":"04928825860acccf7dd9fade08e1bd304a0d20dd","user":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"repo":{"id":51193526,"node_id":"MDEwOlJlcG9zaXRvcnk1MTE5MzUyNg==","name":"cosmos-sdk","full_name":"cosmos/cosmos-sdk","owner":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cosmos/cosmos-sdk","description":"Secure Blockchain Framework","fork":false,"url":"https://api.github.com/repos/cosmos/cosmos-sdk","forks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/forks","keys_url":"https://api.github.com/repos/cosmos/cosmos-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmos/cosmos-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmos/cosmos-sdk/teams","hooks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/hooks","issue_events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/events","assignees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/cosmos/cosmos-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/tags","blobs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmos/cosmos-sdk/languages","stargazers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/stargazers","contributors_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contributors","subscribers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscribers","subscription_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscription","commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/cosmos/cosmos-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmos/cosmos-sdk/merges","archive_url":"https://api.github.com/repos/cosmos/cosmos-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmos/cosmos-sdk/downloads","issues_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmos/cosmos-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmos/cosmos-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels{/name}","releases_url":"https://api.github.com/repos/cosmos/cosmos-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/deployments","created_at":"2016-02-06T07:15:53Z","updated_at":"2018-07-03T19:31:22Z","pushed_at":"2018-07-03T21:14:33Z","git_url":"git://github.com/cosmos/cosmos-sdk.git","ssh_url":"git@github.com:cosmos/cosmos-sdk.git","clone_url":"https://github.com/cosmos/cosmos-sdk.git","svn_url":"https://github.com/cosmos/cosmos-sdk","homepage":"https://cosmos.network/","size":26485,"stargazers_count":455,"watchers_count":455,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":302,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":134,"open_issues":302,"watchers":455,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/1512"},"html":{"href":"https://github.com/cosmos/cosmos-sdk/pull/1512"},"issue":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/1512"},"comments":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/1512/comments"},"review_comments":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/1512/comments"},"review_comment":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/1512/commits"},"statuses":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/223b76d3c7992fc5f4f3f96c31c4dead1bd3d99d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jackzampolin"}}