{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/172033742","pull_request_review_id":100991603,"id":172033742,"diff_hunk":"@@ -17,16 +17,15 @@ export function BuildESQueryProvider(Private) {\n     const queriesByLanguage = groupBy(validQueries, 'language');\n \n     const kueryQuery = buildQueryFromKuery(indexPattern, queriesByLanguage.kuery);\n-    const kqlQuery = buildQueryFromKql(indexPattern, queriesByLanguage.kql);\n     const luceneQuery = buildQueryFromLucene(queriesByLanguage.lucene, decorateQuery);\n     const filterQuery = buildQueryFromFilters(filters, decorateQuery, indexPattern);\n \n     return {\n       bool: {\n-        must: [].concat(kueryQuery.must, kqlQuery.must, luceneQuery.must, filterQuery.must),\n-        filter: [].concat(kueryQuery.filter, kqlQuery.filter, luceneQuery.filter, filterQuery.filter),\n-        should: [].concat(kueryQuery.should, kqlQuery.should, luceneQuery.should, filterQuery.should),\n-        must_not: [].concat(kueryQuery.must_not, kqlQuery.must_not, luceneQuery.must_not, filterQuery.must_not),\n+        must: [].concat(kueryQuery.must, luceneQuery.must, filterQuery.must),","path":"src/ui/public/courier/data_source/build_query/build_es_query.js","position":22,"original_position":22,"commit_id":"fe8bdec10910360273a22022cfa93035e4cd37de","original_commit_id":"add467fe5cdd6ff37168bed97edfbf943c699c0f","user":{"login":"Bargs","id":6239176,"avatar_url":"https://avatars3.githubusercontent.com/u/6239176?v=4","gravatar_id":"","url":"https://api.github.com/users/Bargs","html_url":"https://github.com/Bargs","followers_url":"https://api.github.com/users/Bargs/followers","following_url":"https://api.github.com/users/Bargs/following{/other_user}","gists_url":"https://api.github.com/users/Bargs/gists{/gist_id}","starred_url":"https://api.github.com/users/Bargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bargs/subscriptions","organizations_url":"https://api.github.com/users/Bargs/orgs","repos_url":"https://api.github.com/users/Bargs/repos","events_url":"https://api.github.com/users/Bargs/events{/privacy}","received_events_url":"https://api.github.com/users/Bargs/received_events","type":"User","site_admin":false},"body":"Yep!","created_at":"2018-03-04T01:01:03Z","updated_at":"2018-03-04T01:01:03Z","html_url":"https://github.com/elastic/kibana/pull/15857#discussion_r172033742","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/15857","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/172033742"},"html":{"href":"https://github.com/elastic/kibana/pull/15857#discussion_r172033742"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/15857"}},"in_reply_to_id":170940749},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/15857","id":161235596,"html_url":"https://github.com/elastic/kibana/pull/15857","diff_url":"https://github.com/elastic/kibana/pull/15857.diff","patch_url":"https://github.com/elastic/kibana/pull/15857.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/15857","number":15857,"state":"open","locked":false,"title":"Update Kuery Syntax","user":{"login":"lukasolson","id":1178348,"avatar_url":"https://avatars3.githubusercontent.com/u/1178348?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasolson","html_url":"https://github.com/lukasolson","followers_url":"https://api.github.com/users/lukasolson/followers","following_url":"https://api.github.com/users/lukasolson/following{/other_user}","gists_url":"https://api.github.com/users/lukasolson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasolson/subscriptions","organizations_url":"https://api.github.com/users/lukasolson/orgs","repos_url":"https://api.github.com/users/lukasolson/repos","events_url":"https://api.github.com/users/lukasolson/events{/privacy}","received_events_url":"https://api.github.com/users/lukasolson/received_events","type":"User","site_admin":false},"body":"Closes #15727.\r\nRelies on #15646.\r\n\r\nThis PR evolves Kuery into a simplified, more lucene-like language. In a follow up PR we plan on getting rid of the language switcher dropdown and instead add a checkbox that will allow users to opt-in to this syntax, which will feel less like a separate language and more like a set of enhancements to the existing lucene query syntax. \r\n\r\nThis PR also updates the simple grammar we extracted in #15646 to solve the following:\r\n\r\n- [x] Wildcards in field names\r\n- [x] \"is one of\" shorthand (e.g. `foo:(bar OR baz OR qux)`)\r\n- [x] Don't split on whitespace (require explicit AND/ORs, case insensitive)\r\n- [x] \"exists\" query (e.g. `foo:*`)\r\n- [x] Improved range query shorthands (e.g. `foo <= 1`)\r\n- [x] Wildcard queries\r\n\r\nSince this new syntax is simpler and does not support every filter type like old Kuery did, this PR also brings back the filter bar when kuery is selected in the language picker.\r\n\r\nSee the documentation updates in this PR if you need an overview of the new syntax (and let us know if the documentation is lacking).","created_at":"2018-01-04T22:52:30Z","updated_at":"2018-03-04T01:01:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7408097d8b8a5e1a2941f74bb94b9572c9be1edb","assignee":{"login":"lukasolson","id":1178348,"avatar_url":"https://avatars3.githubusercontent.com/u/1178348?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasolson","html_url":"https://github.com/lukasolson","followers_url":"https://api.github.com/users/lukasolson/followers","following_url":"https://api.github.com/users/lukasolson/following{/other_user}","gists_url":"https://api.github.com/users/lukasolson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasolson/subscriptions","organizations_url":"https://api.github.com/users/lukasolson/orgs","repos_url":"https://api.github.com/users/lukasolson/repos","events_url":"https://api.github.com/users/lukasolson/events{/privacy}","received_events_url":"https://api.github.com/users/lukasolson/received_events","type":"User","site_admin":false},"assignees":[{"login":"lukasolson","id":1178348,"avatar_url":"https://avatars3.githubusercontent.com/u/1178348?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasolson","html_url":"https://github.com/lukasolson","followers_url":"https://api.github.com/users/lukasolson/followers","following_url":"https://api.github.com/users/lukasolson/following{/other_user}","gists_url":"https://api.github.com/users/lukasolson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasolson/subscriptions","organizations_url":"https://api.github.com/users/lukasolson/orgs","repos_url":"https://api.github.com/users/lukasolson/repos","events_url":"https://api.github.com/users/lukasolson/events{/privacy}","received_events_url":"https://api.github.com/users/lukasolson/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":462135575,"url":"https://api.github.com/repos/elastic/kibana/labels/:Discovery","name":":Discovery","color":"fef2c0","default":false},{"id":473043528,"url":"https://api.github.com/repos/elastic/kibana/labels/:Filters","name":":Filters","color":"009800","default":false},{"id":478075189,"url":"https://api.github.com/repos/elastic/kibana/labels/:Query%20Bar","name":":Query Bar","color":"009800","default":false},{"id":135307740,"url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false},{"id":810298373,"url":"https://api.github.com/repos/elastic/kibana/labels/v6.3.0","name":"v6.3.0","color":"ffffff","default":false},{"id":654061976,"url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/15857/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/15857/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/15857/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/fe8bdec10910360273a22022cfa93035e4cd37de","head":{"label":"lukasolson:kql","ref":"kql","sha":"fe8bdec10910360273a22022cfa93035e4cd37de","user":{"login":"lukasolson","id":1178348,"avatar_url":"https://avatars3.githubusercontent.com/u/1178348?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasolson","html_url":"https://github.com/lukasolson","followers_url":"https://api.github.com/users/lukasolson/followers","following_url":"https://api.github.com/users/lukasolson/following{/other_user}","gists_url":"https://api.github.com/users/lukasolson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasolson/subscriptions","organizations_url":"https://api.github.com/users/lukasolson/orgs","repos_url":"https://api.github.com/users/lukasolson/repos","events_url":"https://api.github.com/users/lukasolson/events{/privacy}","received_events_url":"https://api.github.com/users/lukasolson/received_events","type":"User","site_admin":false},"repo":{"id":26142062,"name":"kibana","full_name":"lukasolson/kibana","owner":{"login":"lukasolson","id":1178348,"avatar_url":"https://avatars3.githubusercontent.com/u/1178348?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasolson","html_url":"https://github.com/lukasolson","followers_url":"https://api.github.com/users/lukasolson/followers","following_url":"https://api.github.com/users/lukasolson/following{/other_user}","gists_url":"https://api.github.com/users/lukasolson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasolson/subscriptions","organizations_url":"https://api.github.com/users/lukasolson/orgs","repos_url":"https://api.github.com/users/lukasolson/repos","events_url":"https://api.github.com/users/lukasolson/events{/privacy}","received_events_url":"https://api.github.com/users/lukasolson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukasolson/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/lukasolson/kibana","forks_url":"https://api.github.com/repos/lukasolson/kibana/forks","keys_url":"https://api.github.com/repos/lukasolson/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukasolson/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukasolson/kibana/teams","hooks_url":"https://api.github.com/repos/lukasolson/kibana/hooks","issue_events_url":"https://api.github.com/repos/lukasolson/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/lukasolson/kibana/events","assignees_url":"https://api.github.com/repos/lukasolson/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/lukasolson/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/lukasolson/kibana/tags","blobs_url":"https://api.github.com/repos/lukasolson/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukasolson/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukasolson/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukasolson/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukasolson/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/lukasolson/kibana/languages","stargazers_url":"https://api.github.com/repos/lukasolson/kibana/stargazers","contributors_url":"https://api.github.com/repos/lukasolson/kibana/contributors","subscribers_url":"https://api.github.com/repos/lukasolson/kibana/subscribers","subscription_url":"https://api.github.com/repos/lukasolson/kibana/subscription","commits_url":"https://api.github.com/repos/lukasolson/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukasolson/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukasolson/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukasolson/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukasolson/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/lukasolson/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukasolson/kibana/merges","archive_url":"https://api.github.com/repos/lukasolson/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukasolson/kibana/downloads","issues_url":"https://api.github.com/repos/lukasolson/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/lukasolson/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/lukasolson/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/lukasolson/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukasolson/kibana/labels{/name}","releases_url":"https://api.github.com/repos/lukasolson/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/lukasolson/kibana/deployments","created_at":"2014-11-03T22:34:05Z","updated_at":"2016-01-12T17:24:57Z","pushed_at":"2018-03-04T00:53:40Z","git_url":"git://github.com/lukasolson/kibana.git","ssh_url":"git@github.com:lukasolson/kibana.git","clone_url":"https://github.com/lukasolson/kibana.git","svn_url":"https://github.com/lukasolson/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":308242,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"37429c0ab0a83174d9367c4019afd041c82b5705","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-03-04T00:46:49Z","pushed_at":"2018-03-04T00:53:43Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":311396,"stargazers_count":8944,"watchers_count":8944,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3456,"mirror_url":null,"archived":false,"open_issues_count":2427,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3456,"open_issues":2427,"watchers":8944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/15857"},"html":{"href":"https://github.com/elastic/kibana/pull/15857"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/15857"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/15857/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/15857/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/15857/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/fe8bdec10910360273a22022cfa93035e4cd37de"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Bargs"}}