{"action":"created","comment":{"url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments/224333441","pull_request_review_id":163670952,"id":224333441,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDMzMzQ0MQ==","diff_hunk":"@@ -196,8 +208,43 @@ func TestSyncCompletePetitionerSyncFlow(t *testing.T) {\n \t\tharness.expectCommitStateDiffTimes(4)\n \t\tharness.expectValidateWithConsensusAlgosTimes(4)\n \n+\t\t// fake the response\n \t\tharness.blockStorage.HandleBlockSyncResponse(blockSyncResponse)\n \n+\t\t// verify that we committed the blocks\n \t\tharness.verifyMocks(t, 4)\n \t})\n }\n+\n+func TestSyncNeverStartsWhenBlocksAreCommitted(t *testing.T) {\n+\ttest.WithContext(func(ctx context.Context) {\n+\t\t// let the sync time to start\n+\t\ttime.Sleep(1 * time.Millisecond)","path":"services/blockstorage/test/block_sync_test.go","position":86,"original_position":86,"commit_id":"18b750ff6995f8e8f920f88af641f3d216783fc4","original_commit_id":"4aeb4a738b51528204f92ebee8692cdf23a79579","user":{"login":"electricmonk","id":912517,"node_id":"MDQ6VXNlcjkxMjUxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/912517?v=4","gravatar_id":"","url":"https://api.github.com/users/electricmonk","html_url":"https://github.com/electricmonk","followers_url":"https://api.github.com/users/electricmonk/followers","following_url":"https://api.github.com/users/electricmonk/following{/other_user}","gists_url":"https://api.github.com/users/electricmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/electricmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electricmonk/subscriptions","organizations_url":"https://api.github.com/users/electricmonk/orgs","repos_url":"https://api.github.com/users/electricmonk/repos","events_url":"https://api.github.com/users/electricmonk/events{/privacy}","received_events_url":"https://api.github.com/users/electricmonk/received_events","type":"User","site_admin":false},"body":"can you think of a way to make this deterministic?","created_at":"2018-10-11T06:54:59Z","updated_at":"2018-10-11T06:54:59Z","html_url":"https://github.com/orbs-network/orbs-network-go/pull/317#discussion_r224333441","pull_request_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/317","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments/224333441"},"html":{"href":"https://github.com/orbs-network/orbs-network-go/pull/317#discussion_r224333441"},"pull_request":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/317"}},"in_reply_to_id":224229470},"pull_request":{"url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/317","id":221857637,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODU3NjM3","html_url":"https://github.com/orbs-network/orbs-network-go/pull/317","diff_url":"https://github.com/orbs-network/orbs-network-go/pull/317.diff","patch_url":"https://github.com/orbs-network/orbs-network-go/pull/317.patch","issue_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/317","number":317,"state":"open","locked":false,"title":"New block sync","user":{"login":"jlevison","id":1667420,"node_id":"MDQ6VXNlcjE2Njc0MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1667420?v=4","gravatar_id":"","url":"https://api.github.com/users/jlevison","html_url":"https://github.com/jlevison","followers_url":"https://api.github.com/users/jlevison/followers","following_url":"https://api.github.com/users/jlevison/following{/other_user}","gists_url":"https://api.github.com/users/jlevison/gists{/gist_id}","starred_url":"https://api.github.com/users/jlevison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlevison/subscriptions","organizations_url":"https://api.github.com/users/jlevison/orgs","repos_url":"https://api.github.com/users/jlevison/repos","events_url":"https://api.github.com/users/jlevison/events{/privacy}","received_events_url":"https://api.github.com/users/jlevison/received_events","type":"User","site_admin":false},"body":"new state machine, connected to the block storage\r\nmissing:\r\n1. the source implementation (sync server) is still running with the old logic, need to remove that\r\n2. can refactor the sync state factory to use a BlockSyncGossipClient (which is the correct abstraction)\r\n3. some more invalid responses logic, such as:\r\n- receiving an availability request with blocks older than what we have latest (need to dump it)\r\n- receiving unexpected blocks in a chunk (need to dump the entire chunk)","created_at":"2018-10-10T16:37:01Z","updated_at":"2018-10-11T06:54:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"595b749ca8ef064bf8fd9ef469593d540c7afc3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/317/commits","review_comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/317/comments","review_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/317/comments","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/18b750ff6995f8e8f920f88af641f3d216783fc4","head":{"label":"orbs-network:feature/block-sync-retransitions","ref":"feature/block-sync-retransitions","sha":"18b750ff6995f8e8f920f88af641f3d216783fc4","user":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"repo":{"id":138470435,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0NzA0MzU=","name":"orbs-network-go","full_name":"orbs-network/orbs-network-go","private":false,"owner":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/orbs-network/orbs-network-go","description":"Orbs platform reference implementation in Go","fork":false,"url":"https://api.github.com/repos/orbs-network/orbs-network-go","forks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/forks","keys_url":"https://api.github.com/repos/orbs-network/orbs-network-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orbs-network/orbs-network-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orbs-network/orbs-network-go/teams","hooks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/hooks","issue_events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/events{/number}","events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/events","assignees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/assignees{/user}","branches_url":"https://api.github.com/repos/orbs-network/orbs-network-go/branches{/branch}","tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/tags","blobs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/{sha}","languages_url":"https://api.github.com/repos/orbs-network/orbs-network-go/languages","stargazers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/stargazers","contributors_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contributors","subscribers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscribers","subscription_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscription","commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contents/{+path}","compare_url":"https://api.github.com/repos/orbs-network/orbs-network-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orbs-network/orbs-network-go/merges","archive_url":"https://api.github.com/repos/orbs-network/orbs-network-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orbs-network/orbs-network-go/downloads","issues_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues{/number}","pulls_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls{/number}","milestones_url":"https://api.github.com/repos/orbs-network/orbs-network-go/milestones{/number}","notifications_url":"https://api.github.com/repos/orbs-network/orbs-network-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orbs-network/orbs-network-go/labels{/name}","releases_url":"https://api.github.com/repos/orbs-network/orbs-network-go/releases{/id}","deployments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/deployments","created_at":"2018-06-24T09:47:23Z","updated_at":"2018-10-08T17:10:05Z","pushed_at":"2018-10-10T21:48:27Z","git_url":"git://github.com/orbs-network/orbs-network-go.git","ssh_url":"git@github.com:orbs-network/orbs-network-go.git","clone_url":"https://github.com/orbs-network/orbs-network-go.git","svn_url":"https://github.com/orbs-network/orbs-network-go","homepage":"","size":7001,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":63,"watchers":36,"default_branch":"master"}},"base":{"label":"orbs-network:master","ref":"master","sha":"bf69699e216094a6fedd4f069d80719d8c2ae59b","user":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"repo":{"id":138470435,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0NzA0MzU=","name":"orbs-network-go","full_name":"orbs-network/orbs-network-go","private":false,"owner":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/orbs-network/orbs-network-go","description":"Orbs platform reference implementation in Go","fork":false,"url":"https://api.github.com/repos/orbs-network/orbs-network-go","forks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/forks","keys_url":"https://api.github.com/repos/orbs-network/orbs-network-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orbs-network/orbs-network-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orbs-network/orbs-network-go/teams","hooks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/hooks","issue_events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/events{/number}","events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/events","assignees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/assignees{/user}","branches_url":"https://api.github.com/repos/orbs-network/orbs-network-go/branches{/branch}","tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/tags","blobs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/{sha}","languages_url":"https://api.github.com/repos/orbs-network/orbs-network-go/languages","stargazers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/stargazers","contributors_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contributors","subscribers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscribers","subscription_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscription","commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contents/{+path}","compare_url":"https://api.github.com/repos/orbs-network/orbs-network-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orbs-network/orbs-network-go/merges","archive_url":"https://api.github.com/repos/orbs-network/orbs-network-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orbs-network/orbs-network-go/downloads","issues_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues{/number}","pulls_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls{/number}","milestones_url":"https://api.github.com/repos/orbs-network/orbs-network-go/milestones{/number}","notifications_url":"https://api.github.com/repos/orbs-network/orbs-network-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orbs-network/orbs-network-go/labels{/name}","releases_url":"https://api.github.com/repos/orbs-network/orbs-network-go/releases{/id}","deployments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/deployments","created_at":"2018-06-24T09:47:23Z","updated_at":"2018-10-08T17:10:05Z","pushed_at":"2018-10-10T21:48:27Z","git_url":"git://github.com/orbs-network/orbs-network-go.git","ssh_url":"git@github.com:orbs-network/orbs-network-go.git","clone_url":"https://github.com/orbs-network/orbs-network-go.git","svn_url":"https://github.com/orbs-network/orbs-network-go","homepage":"","size":7001,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":63,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/317"},"html":{"href":"https://github.com/orbs-network/orbs-network-go/pull/317"},"issue":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/317"},"comments":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/18b750ff6995f8e8f920f88af641f3d216783fc4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"electricmonk"}}