{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/187381514","pull_request_review_id":119151179,"id":187381514,"diff_hunk":"@@ -633,6 +634,10 @@ func (config *RCConfig) applyTo(template *v1.PodTemplateSpec) {\n \tif config.MemRequest > 0 {\n \t\ttemplate.Spec.Containers[0].Resources.Requests[v1.ResourceMemory] = *resource.NewQuantity(config.MemRequest, resource.DecimalSI)\n \t}\n+\tif config.GpuLimit > 0 {\n+\t\ttemplate.Spec.Containers[0].Resources.Limits[\"nvidia.com/gpu\"] = *resource.NewQuantity(config.GpuLimit, resource.DecimalSI)\n+\t\t// TODO[losipiuk] should I use framework.NVIDIAGPUResourceName from gpu_util.go as key?","path":"test/utils/runners.go","position":23,"original_position":23,"commit_id":"49f5c87bfcdb2575eb9483e0c5cf01918a1b9e7d","original_commit_id":"49f5c87bfcdb2575eb9483e0c5cf01918a1b9e7d","user":{"login":"aleksandra-malinowska","id":4884414,"avatar_url":"https://avatars1.githubusercontent.com/u/4884414?v=4","gravatar_id":"","url":"https://api.github.com/users/aleksandra-malinowska","html_url":"https://github.com/aleksandra-malinowska","followers_url":"https://api.github.com/users/aleksandra-malinowska/followers","following_url":"https://api.github.com/users/aleksandra-malinowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-malinowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-malinowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-malinowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-malinowska/orgs","repos_url":"https://api.github.com/users/aleksandra-malinowska/repos","events_url":"https://api.github.com/users/aleksandra-malinowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-malinowska/received_events","type":"User","site_admin":false},"body":"clean up todo","created_at":"2018-05-10T16:20:11Z","updated_at":"2018-05-10T16:20:11Z","html_url":"https://github.com/kubernetes/kubernetes/pull/63246#discussion_r187381514","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63246","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/187381514"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/63246#discussion_r187381514"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63246"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63246","id":184612445,"html_url":"https://github.com/kubernetes/kubernetes/pull/63246","diff_url":"https://github.com/kubernetes/kubernetes/pull/63246.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/63246.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63246","number":63246,"state":"open","locked":false,"title":" Add scale-up test from 0 for GPU node-pool","user":{"login":"losipiuk","id":890111,"avatar_url":"https://avatars1.githubusercontent.com/u/890111?v=4","gravatar_id":"","url":"https://api.github.com/users/losipiuk","html_url":"https://github.com/losipiuk","followers_url":"https://api.github.com/users/losipiuk/followers","following_url":"https://api.github.com/users/losipiuk/following{/other_user}","gists_url":"https://api.github.com/users/losipiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/losipiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losipiuk/subscriptions","organizations_url":"https://api.github.com/users/losipiuk/orgs","repos_url":"https://api.github.com/users/losipiuk/repos","events_url":"https://api.github.com/users/losipiuk/events{/privacy}","received_events_url":"https://api.github.com/users/losipiuk/received_events","type":"User","site_admin":false},"body":"**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-04-27T12:47:30Z","updated_at":"2018-05-10T16:20:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74ba0adc76333748e09dea79ea326c3f288a8d28","assignee":{"login":"MaciekPytel","id":7901030,"avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false},"assignees":[{"login":"MaciekPytel","id":7901030,"avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"MaciekPytel","id":7901030,"avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63246/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63246/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63246/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/49f5c87bfcdb2575eb9483e0c5cf01918a1b9e7d","head":{"label":"losipiuk:lo/autoscaler-e2e-gpu-tests","ref":"lo/autoscaler-e2e-gpu-tests","sha":"49f5c87bfcdb2575eb9483e0c5cf01918a1b9e7d","user":{"login":"losipiuk","id":890111,"avatar_url":"https://avatars1.githubusercontent.com/u/890111?v=4","gravatar_id":"","url":"https://api.github.com/users/losipiuk","html_url":"https://github.com/losipiuk","followers_url":"https://api.github.com/users/losipiuk/followers","following_url":"https://api.github.com/users/losipiuk/following{/other_user}","gists_url":"https://api.github.com/users/losipiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/losipiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losipiuk/subscriptions","organizations_url":"https://api.github.com/users/losipiuk/orgs","repos_url":"https://api.github.com/users/losipiuk/repos","events_url":"https://api.github.com/users/losipiuk/events{/privacy}","received_events_url":"https://api.github.com/users/losipiuk/received_events","type":"User","site_admin":false},"repo":{"id":115144378,"name":"kubernetes","full_name":"losipiuk/kubernetes","owner":{"login":"losipiuk","id":890111,"avatar_url":"https://avatars1.githubusercontent.com/u/890111?v=4","gravatar_id":"","url":"https://api.github.com/users/losipiuk","html_url":"https://github.com/losipiuk","followers_url":"https://api.github.com/users/losipiuk/followers","following_url":"https://api.github.com/users/losipiuk/following{/other_user}","gists_url":"https://api.github.com/users/losipiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/losipiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losipiuk/subscriptions","organizations_url":"https://api.github.com/users/losipiuk/orgs","repos_url":"https://api.github.com/users/losipiuk/repos","events_url":"https://api.github.com/users/losipiuk/events{/privacy}","received_events_url":"https://api.github.com/users/losipiuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/losipiuk/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/losipiuk/kubernetes","forks_url":"https://api.github.com/repos/losipiuk/kubernetes/forks","keys_url":"https://api.github.com/repos/losipiuk/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/losipiuk/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/losipiuk/kubernetes/teams","hooks_url":"https://api.github.com/repos/losipiuk/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/losipiuk/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/losipiuk/kubernetes/events","assignees_url":"https://api.github.com/repos/losipiuk/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/losipiuk/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/losipiuk/kubernetes/tags","blobs_url":"https://api.github.com/repos/losipiuk/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/losipiuk/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/losipiuk/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/losipiuk/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/losipiuk/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/losipiuk/kubernetes/languages","stargazers_url":"https://api.github.com/repos/losipiuk/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/losipiuk/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/losipiuk/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/losipiuk/kubernetes/subscription","commits_url":"https://api.github.com/repos/losipiuk/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/losipiuk/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/losipiuk/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/losipiuk/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/losipiuk/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/losipiuk/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/losipiuk/kubernetes/merges","archive_url":"https://api.github.com/repos/losipiuk/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/losipiuk/kubernetes/downloads","issues_url":"https://api.github.com/repos/losipiuk/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/losipiuk/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/losipiuk/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/losipiuk/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/losipiuk/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/losipiuk/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/losipiuk/kubernetes/deployments","created_at":"2017-12-22T19:25:37Z","updated_at":"2017-12-22T19:26:12Z","pushed_at":"2018-05-10T13:23:19Z","git_url":"git://github.com/losipiuk/kubernetes.git","ssh_url":"git@github.com:losipiuk/kubernetes.git","clone_url":"https://github.com/losipiuk/kubernetes.git","svn_url":"https://github.com/losipiuk/kubernetes","homepage":"http://kubernetes.io","size":553012,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0ba80021c5b1e6874fdab81b3d62547ea20e84ed","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-05-10T16:18:30Z","pushed_at":"2018-05-10T16:16:09Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":776302,"stargazers_count":36128,"watchers_count":36128,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12733,"mirror_url":null,"archived":false,"open_issues_count":3323,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12733,"open_issues":3323,"watchers":36128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63246"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/63246"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/63246"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/63246/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63246/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63246/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/49f5c87bfcdb2575eb9483e0c5cf01918a1b9e7d"}},"author_association":"NONE"}}
{"actor":{"display_login":"aleksandra-malinowska"}}