{"action":"created","comment":{"url":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/comments/226635274","pull_request_review_id":166507835,"id":226635274,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjYzNTI3NA==","diff_hunk":"@@ -32,18 +32,29 @@ public static function convertValueBasedOnAttributeName(ProtobufAttribute $attri\n         {\n             case Profile::ATTR_DOCUMENT_DETAILS:\n                 return new DocumentDetails($value);\n+\n             case Profile::ATTR_STRUCTURED_POSTAL_ADDRESS:\n                 // Convert structured_postal_address value to an Array\n                 return json_encode($value, true);\n+\n+            case Profile::ATTR_SELFIE:","path":"src/Yoti/Util/Profile/AttributeConverter.php","position":9,"original_position":9,"commit_id":"1b9f9626e027e47fa3935560ed1c25c4fdbfb711","original_commit_id":"1b9f9626e027e47fa3935560ed1c25c4fdbfb711","user":{"login":"bucky-boy","id":32527026,"node_id":"MDQ6VXNlcjMyNTI3MDI2","avatar_url":"https://avatars1.githubusercontent.com/u/32527026?v=4","gravatar_id":"","url":"https://api.github.com/users/bucky-boy","html_url":"https://github.com/bucky-boy","followers_url":"https://api.github.com/users/bucky-boy/followers","following_url":"https://api.github.com/users/bucky-boy/following{/other_user}","gists_url":"https://api.github.com/users/bucky-boy/gists{/gist_id}","starred_url":"https://api.github.com/users/bucky-boy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bucky-boy/subscriptions","organizations_url":"https://api.github.com/users/bucky-boy/orgs","repos_url":"https://api.github.com/users/bucky-boy/repos","events_url":"https://api.github.com/users/bucky-boy/events{/privacy}","received_events_url":"https://api.github.com/users/bucky-boy/received_events","type":"User","site_admin":false},"body":"No, DocumentDetails is an exception.\r\n\r\nAll the _AttrProto.Attribute_ objects we get back from core (via connect) have a _contentType_ - STRING, JPEG, DATE etc.  We need to base our SDK _Attributes_ on that content type.\r\n\r\nDocumentDetails, however, is returned to us a type STRING - the protobuf definitions do not have a specific type for DocumentDetails.  So for that one, we then have to convert it from it's String representation into our custom DocumentDetails.","created_at":"2018-10-19T12:51:23Z","updated_at":"2018-10-19T12:51:24Z","html_url":"https://github.com/getyoti/yoti-php-sdk/pull/36#discussion_r226635274","pull_request_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/36","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/comments/226635274"},"html":{"href":"https://github.com/getyoti/yoti-php-sdk/pull/36#discussion_r226635274"},"pull_request":{"href":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/36"}},"in_reply_to_id":226364941},"pull_request":{"url":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/36","id":223985725,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTg1NzI1","html_url":"https://github.com/getyoti/yoti-php-sdk/pull/36","diff_url":"https://github.com/getyoti/yoti-php-sdk/pull/36.diff","patch_url":"https://github.com/getyoti/yoti-php-sdk/pull/36.patch","issue_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/issues/36","number":36,"state":"open","locked":false,"title":"SDK-596: Add new Image Object","user":{"login":"sidibos","id":3317034,"node_id":"MDQ6VXNlcjMzMTcwMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3317034?v=4","gravatar_id":"","url":"https://api.github.com/users/sidibos","html_url":"https://github.com/sidibos","followers_url":"https://api.github.com/users/sidibos/followers","following_url":"https://api.github.com/users/sidibos/following{/other_user}","gists_url":"https://api.github.com/users/sidibos/gists{/gist_id}","starred_url":"https://api.github.com/users/sidibos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidibos/subscriptions","organizations_url":"https://api.github.com/users/sidibos/orgs","repos_url":"https://api.github.com/users/sidibos/repos","events_url":"https://api.github.com/users/sidibos/events{/privacy}","received_events_url":"https://api.github.com/users/sidibos/received_events","type":"User","site_admin":false},"body":"Selfie::class will be removed in this ticket [SDK-561](https://lampkicking.atlassian.net/browse/SDK-561)","created_at":"2018-10-18T14:46:38Z","updated_at":"2018-10-19T12:51:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4b23a75e6194ff2deb3726aa75fa351a26798c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/36/commits","review_comments_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/36/comments","review_comment_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/issues/36/comments","statuses_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/statuses/1b9f9626e027e47fa3935560ed1c25c4fdbfb711","head":{"label":"getyoti:SDK-596","ref":"SDK-596","sha":"1b9f9626e027e47fa3935560ed1c25c4fdbfb711","user":{"login":"getyoti","id":19798626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk4NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/19798626?v=4","gravatar_id":"","url":"https://api.github.com/users/getyoti","html_url":"https://github.com/getyoti","followers_url":"https://api.github.com/users/getyoti/followers","following_url":"https://api.github.com/users/getyoti/following{/other_user}","gists_url":"https://api.github.com/users/getyoti/gists{/gist_id}","starred_url":"https://api.github.com/users/getyoti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyoti/subscriptions","organizations_url":"https://api.github.com/users/getyoti/orgs","repos_url":"https://api.github.com/users/getyoti/repos","events_url":"https://api.github.com/users/getyoti/events{/privacy}","received_events_url":"https://api.github.com/users/getyoti/received_events","type":"Organization","site_admin":false},"repo":{"id":66000225,"node_id":"MDEwOlJlcG9zaXRvcnk2NjAwMDIyNQ==","name":"yoti-php-sdk","full_name":"getyoti/yoti-php-sdk","private":false,"owner":{"login":"getyoti","id":19798626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk4NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/19798626?v=4","gravatar_id":"","url":"https://api.github.com/users/getyoti","html_url":"https://github.com/getyoti","followers_url":"https://api.github.com/users/getyoti/followers","following_url":"https://api.github.com/users/getyoti/following{/other_user}","gists_url":"https://api.github.com/users/getyoti/gists{/gist_id}","starred_url":"https://api.github.com/users/getyoti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyoti/subscriptions","organizations_url":"https://api.github.com/users/getyoti/orgs","repos_url":"https://api.github.com/users/getyoti/repos","events_url":"https://api.github.com/users/getyoti/events{/privacy}","received_events_url":"https://api.github.com/users/getyoti/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getyoti/yoti-php-sdk","description":"The PHP SDK for interacting with the Yoti Platform","fork":false,"url":"https://api.github.com/repos/getyoti/yoti-php-sdk","forks_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/forks","keys_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/teams","hooks_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/hooks","issue_events_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/events","assignees_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/tags","blobs_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/languages","stargazers_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/stargazers","contributors_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/contributors","subscribers_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/subscribers","subscription_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/subscription","commits_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/merges","archive_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/downloads","issues_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/labels{/name}","releases_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/deployments","created_at":"2016-08-18T13:39:37Z","updated_at":"2018-09-17T16:39:14Z","pushed_at":"2018-10-18T14:46:39Z","git_url":"git://github.com/getyoti/yoti-php-sdk.git","ssh_url":"git@github.com:getyoti/yoti-php-sdk.git","clone_url":"https://github.com/getyoti/yoti-php-sdk.git","svn_url":"https://github.com/getyoti/yoti-php-sdk","homepage":"https://www.yoti.com/developers/documentation/?php","size":1066,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"getyoti:development","ref":"development","sha":"50bc0cffb02092f72ada343c4aa0e515fa4e6fb1","user":{"login":"getyoti","id":19798626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk4NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/19798626?v=4","gravatar_id":"","url":"https://api.github.com/users/getyoti","html_url":"https://github.com/getyoti","followers_url":"https://api.github.com/users/getyoti/followers","following_url":"https://api.github.com/users/getyoti/following{/other_user}","gists_url":"https://api.github.com/users/getyoti/gists{/gist_id}","starred_url":"https://api.github.com/users/getyoti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyoti/subscriptions","organizations_url":"https://api.github.com/users/getyoti/orgs","repos_url":"https://api.github.com/users/getyoti/repos","events_url":"https://api.github.com/users/getyoti/events{/privacy}","received_events_url":"https://api.github.com/users/getyoti/received_events","type":"Organization","site_admin":false},"repo":{"id":66000225,"node_id":"MDEwOlJlcG9zaXRvcnk2NjAwMDIyNQ==","name":"yoti-php-sdk","full_name":"getyoti/yoti-php-sdk","private":false,"owner":{"login":"getyoti","id":19798626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk4NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/19798626?v=4","gravatar_id":"","url":"https://api.github.com/users/getyoti","html_url":"https://github.com/getyoti","followers_url":"https://api.github.com/users/getyoti/followers","following_url":"https://api.github.com/users/getyoti/following{/other_user}","gists_url":"https://api.github.com/users/getyoti/gists{/gist_id}","starred_url":"https://api.github.com/users/getyoti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyoti/subscriptions","organizations_url":"https://api.github.com/users/getyoti/orgs","repos_url":"https://api.github.com/users/getyoti/repos","events_url":"https://api.github.com/users/getyoti/events{/privacy}","received_events_url":"https://api.github.com/users/getyoti/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getyoti/yoti-php-sdk","description":"The PHP SDK for interacting with the Yoti Platform","fork":false,"url":"https://api.github.com/repos/getyoti/yoti-php-sdk","forks_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/forks","keys_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/teams","hooks_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/hooks","issue_events_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/events","assignees_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/tags","blobs_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/languages","stargazers_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/stargazers","contributors_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/contributors","subscribers_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/subscribers","subscription_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/subscription","commits_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/merges","archive_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/downloads","issues_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/labels{/name}","releases_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/getyoti/yoti-php-sdk/deployments","created_at":"2016-08-18T13:39:37Z","updated_at":"2018-09-17T16:39:14Z","pushed_at":"2018-10-18T14:46:39Z","git_url":"git://github.com/getyoti/yoti-php-sdk.git","ssh_url":"git@github.com:getyoti/yoti-php-sdk.git","clone_url":"https://github.com/getyoti/yoti-php-sdk.git","svn_url":"https://github.com/getyoti/yoti-php-sdk","homepage":"https://www.yoti.com/developers/documentation/?php","size":1066,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/36"},"html":{"href":"https://github.com/getyoti/yoti-php-sdk/pull/36"},"issue":{"href":"https://api.github.com/repos/getyoti/yoti-php-sdk/issues/36"},"comments":{"href":"https://api.github.com/repos/getyoti/yoti-php-sdk/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getyoti/yoti-php-sdk/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/getyoti/yoti-php-sdk/statuses/1b9f9626e027e47fa3935560ed1c25c4fdbfb711"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bucky-boy"}}