{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/TYPO3/Surf/pulls/69","id":101534876,"html_url":"https://github.com/TYPO3/Surf/pull/69","diff_url":"https://github.com/TYPO3/Surf/pull/69.diff","patch_url":"https://github.com/TYPO3/Surf/pull/69.patch","issue_url":"https://api.github.com/repos/TYPO3/Surf/issues/69","number":69,"state":"closed","locked":false,"title":"[TASK] Ensure symlinks in TYPO3 CMS projects are created in web directory","user":{"login":"markwatney2016","id":22563689,"avatar_url":"https://avatars1.githubusercontent.com/u/22563689?v=4","gravatar_id":"","url":"https://api.github.com/users/markwatney2016","html_url":"https://github.com/markwatney2016","followers_url":"https://api.github.com/users/markwatney2016/followers","following_url":"https://api.github.com/users/markwatney2016/following{/other_user}","gists_url":"https://api.github.com/users/markwatney2016/gists{/gist_id}","starred_url":"https://api.github.com/users/markwatney2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markwatney2016/subscriptions","organizations_url":"https://api.github.com/users/markwatney2016/orgs","repos_url":"https://api.github.com/users/markwatney2016/repos","events_url":"https://api.github.com/users/markwatney2016/events{/privacy}","received_events_url":"https://api.github.com/users/markwatney2016/received_events","type":"User","site_admin":false},"body":"\\TYPO3\\Surf\\Task\\TYPO3\\CMS\\SymlinkDataTask creates symlinks for the\r\n“fileadmin” and “uploads” directories. These symlinks have to be created\r\nin the web directory. Until now this will fail if a directory “fileadmin”\r\nor a directory “uploads” already exist in the web directory when this\r\ntask is executed: the symlinks would then be created inside those two\r\ndirectories.\r\n\r\nThose two directories can get created during the\r\nTYPO3\\Surf\\DefinedTask\\Composer\\LocalInstallTask when the project’s\r\nroot composer.json defines a script like this one to be run on “composer\r\ninstall”:\r\n\r\n@php vendor/bin/typo3cms install:fixfolderstructure\r\n\r\nSuch a script can be found in https://github.com/helhum/TYPO3-Distribution/blob/master/composer.json.\r\n\r\nTherefore this commit makes sure that those directories are deleted if\r\nthey exist before the symlinks are created.\r\n\r\nNote: TYPO3\\Surf\\DefinedTask\\Composer\\LocalInstallTask is defined in\r\n\\TYPO3\\Surf\\Application\\BaseApplication::registerTasksForPackageMethod()","created_at":"2017-01-13T23:25:10Z","updated_at":"2018-04-20T14:26:37Z","closed_at":"2018-04-20T14:26:37Z","merged_at":null,"merge_commit_sha":"a2eed74730b3b44bc1358123fe0c0625ed26c447","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TYPO3/Surf/pulls/69/commits","review_comments_url":"https://api.github.com/repos/TYPO3/Surf/pulls/69/comments","review_comment_url":"https://api.github.com/repos/TYPO3/Surf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TYPO3/Surf/issues/69/comments","statuses_url":"https://api.github.com/repos/TYPO3/Surf/statuses/faa0ff389aeeca720de6da52d152166179bc4fb9","head":{"label":"markwatney2016:feature/20170113_symlink_task","ref":"feature/20170113_symlink_task","sha":"faa0ff389aeeca720de6da52d152166179bc4fb9","user":{"login":"markwatney2016","id":22563689,"avatar_url":"https://avatars1.githubusercontent.com/u/22563689?v=4","gravatar_id":"","url":"https://api.github.com/users/markwatney2016","html_url":"https://github.com/markwatney2016","followers_url":"https://api.github.com/users/markwatney2016/followers","following_url":"https://api.github.com/users/markwatney2016/following{/other_user}","gists_url":"https://api.github.com/users/markwatney2016/gists{/gist_id}","starred_url":"https://api.github.com/users/markwatney2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markwatney2016/subscriptions","organizations_url":"https://api.github.com/users/markwatney2016/orgs","repos_url":"https://api.github.com/users/markwatney2016/repos","events_url":"https://api.github.com/users/markwatney2016/events{/privacy}","received_events_url":"https://api.github.com/users/markwatney2016/received_events","type":"User","site_admin":false},"repo":{"id":78647909,"name":"Surf","full_name":"markwatney2016/Surf","owner":{"login":"markwatney2016","id":22563689,"avatar_url":"https://avatars1.githubusercontent.com/u/22563689?v=4","gravatar_id":"","url":"https://api.github.com/users/markwatney2016","html_url":"https://github.com/markwatney2016","followers_url":"https://api.github.com/users/markwatney2016/followers","following_url":"https://api.github.com/users/markwatney2016/following{/other_user}","gists_url":"https://api.github.com/users/markwatney2016/gists{/gist_id}","starred_url":"https://api.github.com/users/markwatney2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markwatney2016/subscriptions","organizations_url":"https://api.github.com/users/markwatney2016/orgs","repos_url":"https://api.github.com/users/markwatney2016/repos","events_url":"https://api.github.com/users/markwatney2016/events{/privacy}","received_events_url":"https://api.github.com/users/markwatney2016/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markwatney2016/Surf","description":"Easy and powerful deployment tool","fork":true,"url":"https://api.github.com/repos/markwatney2016/Surf","forks_url":"https://api.github.com/repos/markwatney2016/Surf/forks","keys_url":"https://api.github.com/repos/markwatney2016/Surf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markwatney2016/Surf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markwatney2016/Surf/teams","hooks_url":"https://api.github.com/repos/markwatney2016/Surf/hooks","issue_events_url":"https://api.github.com/repos/markwatney2016/Surf/issues/events{/number}","events_url":"https://api.github.com/repos/markwatney2016/Surf/events","assignees_url":"https://api.github.com/repos/markwatney2016/Surf/assignees{/user}","branches_url":"https://api.github.com/repos/markwatney2016/Surf/branches{/branch}","tags_url":"https://api.github.com/repos/markwatney2016/Surf/tags","blobs_url":"https://api.github.com/repos/markwatney2016/Surf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markwatney2016/Surf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markwatney2016/Surf/git/refs{/sha}","trees_url":"https://api.github.com/repos/markwatney2016/Surf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markwatney2016/Surf/statuses/{sha}","languages_url":"https://api.github.com/repos/markwatney2016/Surf/languages","stargazers_url":"https://api.github.com/repos/markwatney2016/Surf/stargazers","contributors_url":"https://api.github.com/repos/markwatney2016/Surf/contributors","subscribers_url":"https://api.github.com/repos/markwatney2016/Surf/subscribers","subscription_url":"https://api.github.com/repos/markwatney2016/Surf/subscription","commits_url":"https://api.github.com/repos/markwatney2016/Surf/commits{/sha}","git_commits_url":"https://api.github.com/repos/markwatney2016/Surf/git/commits{/sha}","comments_url":"https://api.github.com/repos/markwatney2016/Surf/comments{/number}","issue_comment_url":"https://api.github.com/repos/markwatney2016/Surf/issues/comments{/number}","contents_url":"https://api.github.com/repos/markwatney2016/Surf/contents/{+path}","compare_url":"https://api.github.com/repos/markwatney2016/Surf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markwatney2016/Surf/merges","archive_url":"https://api.github.com/repos/markwatney2016/Surf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markwatney2016/Surf/downloads","issues_url":"https://api.github.com/repos/markwatney2016/Surf/issues{/number}","pulls_url":"https://api.github.com/repos/markwatney2016/Surf/pulls{/number}","milestones_url":"https://api.github.com/repos/markwatney2016/Surf/milestones{/number}","notifications_url":"https://api.github.com/repos/markwatney2016/Surf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markwatney2016/Surf/labels{/name}","releases_url":"https://api.github.com/repos/markwatney2016/Surf/releases{/id}","deployments_url":"https://api.github.com/repos/markwatney2016/Surf/deployments","created_at":"2017-01-11T14:41:59Z","updated_at":"2017-01-11T14:42:02Z","pushed_at":"2017-01-13T23:24:01Z","git_url":"git://github.com/markwatney2016/Surf.git","ssh_url":"git@github.com:markwatney2016/Surf.git","clone_url":"https://github.com/markwatney2016/Surf.git","svn_url":"https://github.com/markwatney2016/Surf","homepage":"","size":551,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TYPO3:master","ref":"master","sha":"cf3f783d6f7f04b08defced524a310974aede381","user":{"login":"TYPO3","id":88698,"avatar_url":"https://avatars0.githubusercontent.com/u/88698?v=4","gravatar_id":"","url":"https://api.github.com/users/TYPO3","html_url":"https://github.com/TYPO3","followers_url":"https://api.github.com/users/TYPO3/followers","following_url":"https://api.github.com/users/TYPO3/following{/other_user}","gists_url":"https://api.github.com/users/TYPO3/gists{/gist_id}","starred_url":"https://api.github.com/users/TYPO3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TYPO3/subscriptions","organizations_url":"https://api.github.com/users/TYPO3/orgs","repos_url":"https://api.github.com/users/TYPO3/repos","events_url":"https://api.github.com/users/TYPO3/events{/privacy}","received_events_url":"https://api.github.com/users/TYPO3/received_events","type":"Organization","site_admin":false},"repo":{"id":49432015,"name":"Surf","full_name":"TYPO3/Surf","owner":{"login":"TYPO3","id":88698,"avatar_url":"https://avatars0.githubusercontent.com/u/88698?v=4","gravatar_id":"","url":"https://api.github.com/users/TYPO3","html_url":"https://github.com/TYPO3","followers_url":"https://api.github.com/users/TYPO3/followers","following_url":"https://api.github.com/users/TYPO3/following{/other_user}","gists_url":"https://api.github.com/users/TYPO3/gists{/gist_id}","starred_url":"https://api.github.com/users/TYPO3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TYPO3/subscriptions","organizations_url":"https://api.github.com/users/TYPO3/orgs","repos_url":"https://api.github.com/users/TYPO3/repos","events_url":"https://api.github.com/users/TYPO3/events{/privacy}","received_events_url":"https://api.github.com/users/TYPO3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TYPO3/Surf","description":"Easy and powerful deployment tool","fork":false,"url":"https://api.github.com/repos/TYPO3/Surf","forks_url":"https://api.github.com/repos/TYPO3/Surf/forks","keys_url":"https://api.github.com/repos/TYPO3/Surf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TYPO3/Surf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TYPO3/Surf/teams","hooks_url":"https://api.github.com/repos/TYPO3/Surf/hooks","issue_events_url":"https://api.github.com/repos/TYPO3/Surf/issues/events{/number}","events_url":"https://api.github.com/repos/TYPO3/Surf/events","assignees_url":"https://api.github.com/repos/TYPO3/Surf/assignees{/user}","branches_url":"https://api.github.com/repos/TYPO3/Surf/branches{/branch}","tags_url":"https://api.github.com/repos/TYPO3/Surf/tags","blobs_url":"https://api.github.com/repos/TYPO3/Surf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TYPO3/Surf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TYPO3/Surf/git/refs{/sha}","trees_url":"https://api.github.com/repos/TYPO3/Surf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TYPO3/Surf/statuses/{sha}","languages_url":"https://api.github.com/repos/TYPO3/Surf/languages","stargazers_url":"https://api.github.com/repos/TYPO3/Surf/stargazers","contributors_url":"https://api.github.com/repos/TYPO3/Surf/contributors","subscribers_url":"https://api.github.com/repos/TYPO3/Surf/subscribers","subscription_url":"https://api.github.com/repos/TYPO3/Surf/subscription","commits_url":"https://api.github.com/repos/TYPO3/Surf/commits{/sha}","git_commits_url":"https://api.github.com/repos/TYPO3/Surf/git/commits{/sha}","comments_url":"https://api.github.com/repos/TYPO3/Surf/comments{/number}","issue_comment_url":"https://api.github.com/repos/TYPO3/Surf/issues/comments{/number}","contents_url":"https://api.github.com/repos/TYPO3/Surf/contents/{+path}","compare_url":"https://api.github.com/repos/TYPO3/Surf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TYPO3/Surf/merges","archive_url":"https://api.github.com/repos/TYPO3/Surf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TYPO3/Surf/downloads","issues_url":"https://api.github.com/repos/TYPO3/Surf/issues{/number}","pulls_url":"https://api.github.com/repos/TYPO3/Surf/pulls{/number}","milestones_url":"https://api.github.com/repos/TYPO3/Surf/milestones{/number}","notifications_url":"https://api.github.com/repos/TYPO3/Surf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TYPO3/Surf/labels{/name}","releases_url":"https://api.github.com/repos/TYPO3/Surf/releases{/id}","deployments_url":"https://api.github.com/repos/TYPO3/Surf/deployments","created_at":"2016-01-11T14:36:37Z","updated_at":"2018-04-20T10:48:40Z","pushed_at":"2018-04-20T11:36:24Z","git_url":"git://github.com/TYPO3/Surf.git","ssh_url":"git@github.com:TYPO3/Surf.git","clone_url":"https://github.com/TYPO3/Surf.git","svn_url":"https://github.com/TYPO3/Surf","homepage":"","size":641,"stargazers_count":53,"watchers_count":53,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":34,"open_issues":44,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TYPO3/Surf/pulls/69"},"html":{"href":"https://github.com/TYPO3/Surf/pull/69"},"issue":{"href":"https://api.github.com/repos/TYPO3/Surf/issues/69"},"comments":{"href":"https://api.github.com/repos/TYPO3/Surf/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/TYPO3/Surf/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/TYPO3/Surf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TYPO3/Surf/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/TYPO3/Surf/statuses/faa0ff389aeeca720de6da52d152166179bc4fb9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"sabbelasichon"}}