{"action":"created","issue":{"url":"https://api.github.com/repos/senaite/senaite.sync/issues/11","repository_url":"https://api.github.com/repos/senaite/senaite.sync","labels_url":"https://api.github.com/repos/senaite/senaite.sync/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/senaite/senaite.sync/issues/11/comments","events_url":"https://api.github.com/repos/senaite/senaite.sync/issues/11/events","html_url":"https://github.com/senaite/senaite.sync/pull/11","id":289917199,"number":11,"title":"Skip records not found in target instance registry","user":{"login":"juangallostra","id":9968427,"avatar_url":"https://avatars3.githubusercontent.com/u/9968427?v=4","gravatar_id":"","url":"https://api.github.com/users/juangallostra","html_url":"https://github.com/juangallostra","followers_url":"https://api.github.com/users/juangallostra/followers","following_url":"https://api.github.com/users/juangallostra/following{/other_user}","gists_url":"https://api.github.com/users/juangallostra/gists{/gist_id}","starred_url":"https://api.github.com/users/juangallostra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juangallostra/subscriptions","organizations_url":"https://api.github.com/users/juangallostra/orgs","repos_url":"https://api.github.com/users/juangallostra/repos","events_url":"https://api.github.com/users/juangallostra/events{/privacy}","received_events_url":"https://api.github.com/users/juangallostra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-01-19T09:47:55Z","updated_at":"2018-02-13T10:15:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/senaite/senaite.sync/pulls/11","html_url":"https://github.com/senaite/senaite.sync/pull/11","diff_url":"https://github.com/senaite/senaite.sync/pull/11.diff","patch_url":"https://github.com/senaite/senaite.sync/pull/11.patch"},"body":"## Description of the issue/feature this PR addresses\r\n\r\nWhen a record was not found in the target instance registry the following error was being raised:\r\n```\r\nTraceback (innermost last):\r\n\r\n    Module ZPublisher.Publish, line 138, in publish\r\n    Module ZPublisher.mapply, line 77, in mapply\r\n    Module ZPublisher.Publish, line 48, in call_object\r\n    Module senaite.sync.browser.views, line 102, in __call__\r\n    Module senaite.sync.browser.views, line 179, in import_registry_records\r\n    Module plone.registry.registry, line 47, in __setitem__\r\n    Module plone.registry.registry, line 212, in __getitem__\r\n    Module plone.registry.registry, line 269, in _getField\r\n\r\nKeyError: u'bika.lims.current_coa_number'\r\n``` \r\n\r\n## Current behavior before PR\r\n\r\nRecords import failed if a record from the source instance registry was missing in the target instance registry\r\n\r\n## Desired behavior after PR is merged\r\n\r\nRecords that aren't found are skipped and no error is raised\r\n\r\n--\r\nI confirm I have tested this PR thoroughly and coded it according to [PEP8][1]\r\nand [Plone's Python styleguide][2] standards.\r\n\r\n[1]: https://www.python.org/dev/peps/pep-0008\r\n[2]: https://docs.plone.org/develop/styleguide/python.html"},"comment":{"url":"https://api.github.com/repos/senaite/senaite.sync/issues/comments/365217547","html_url":"https://github.com/senaite/senaite.sync/pull/11#issuecomment-365217547","issue_url":"https://api.github.com/repos/senaite/senaite.sync/issues/11","id":365217547,"user":{"login":"juangallostra","id":9968427,"avatar_url":"https://avatars3.githubusercontent.com/u/9968427?v=4","gravatar_id":"","url":"https://api.github.com/users/juangallostra","html_url":"https://github.com/juangallostra","followers_url":"https://api.github.com/users/juangallostra/followers","following_url":"https://api.github.com/users/juangallostra/following{/other_user}","gists_url":"https://api.github.com/users/juangallostra/gists{/gist_id}","starred_url":"https://api.github.com/users/juangallostra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juangallostra/subscriptions","organizations_url":"https://api.github.com/users/juangallostra/orgs","repos_url":"https://api.github.com/users/juangallostra/repos","events_url":"https://api.github.com/users/juangallostra/events{/privacy}","received_events_url":"https://api.github.com/users/juangallostra/received_events","type":"User","site_admin":false},"created_at":"2018-02-13T10:15:57Z","updated_at":"2018-02-13T10:15:57Z","author_association":"CONTRIBUTOR","body":"@ramonski, I didn't remember that @Nihadness  already cherry-picked the commit that solved the bug (https://github.com/senaite/senaite.sync/pull/13/commits/24bd7dcc01e20c96c6e5486ebf4552ec16b35a0e) and included it in PR #13. \r\n\r\nWe can close this PR."}}
{"actor":{"display_login":"juangallostra"}}