{"action":"closed","number":248,"pull_request":{"url":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/248","id":209932847,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTMyODQ3","html_url":"https://github.com/redhat-cop/infra-ansible/pull/248","diff_url":"https://github.com/redhat-cop/infra-ansible/pull/248.diff","patch_url":"https://github.com/redhat-cop/infra-ansible/pull/248.patch","issue_url":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/248","number":248,"state":"closed","locked":false,"title":"Update firewall rules and SSL Cert Handling","user":{"login":"wkulhanek","id":8929233,"node_id":"MDQ6VXNlcjg5MjkyMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8929233?v=4","gravatar_id":"","url":"https://api.github.com/users/wkulhanek","html_url":"https://github.com/wkulhanek","followers_url":"https://api.github.com/users/wkulhanek/followers","following_url":"https://api.github.com/users/wkulhanek/following{/other_user}","gists_url":"https://api.github.com/users/wkulhanek/gists{/gist_id}","starred_url":"https://api.github.com/users/wkulhanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkulhanek/subscriptions","organizations_url":"https://api.github.com/users/wkulhanek/orgs","repos_url":"https://api.github.com/users/wkulhanek/repos","events_url":"https://api.github.com/users/wkulhanek/events{/privacy}","received_events_url":"https://api.github.com/users/wkulhanek/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nMostly updated all the firewall handling for IP Tables. When handling IP Tables it is usually not a good idea to restart the iptables service - since that loses all temporary rules. And screws up running Docker Containers. Changed the logic to both fix the iptables file and the running IPTables service.\r\n\r\nAlso updated handling of certificates. Somehow the set_fact steps got ignored since there were higher preference variables present. Fixed by using unique variables in the playbook to be set from different other variables (or default).\r\n\r\nQuay now deploys in both IPTables and Firewalld environments correctly - with or without Clair and with or without custom certificates.\r\n\r\n### People to notify\r\ncc: @redhat-cop/infra-ansible @sabre1041 \r\n","created_at":"2018-08-21T19:35:27Z","updated_at":"2018-11-13T04:47:16Z","closed_at":"2018-11-13T04:47:16Z","merged_at":null,"merge_commit_sha":"97d74e4f8dd9d09fe3c189542fd4cd47fb5f8122","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583455144,"node_id":"MDU6TGFiZWw1ODM0NTUxNDQ=","url":"https://api.github.com/repos/redhat-cop/infra-ansible/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/248/commits","review_comments_url":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/248/comments","review_comment_url":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/248/comments","statuses_url":"https://api.github.com/repos/redhat-cop/infra-ansible/statuses/dcb1c52c1f95196523e132c7a99e94cd4a4ab074","head":{"label":"wkulhanek:Update_Firewall_Rules","ref":"Update_Firewall_Rules","sha":"dcb1c52c1f95196523e132c7a99e94cd4a4ab074","user":{"login":"wkulhanek","id":8929233,"node_id":"MDQ6VXNlcjg5MjkyMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8929233?v=4","gravatar_id":"","url":"https://api.github.com/users/wkulhanek","html_url":"https://github.com/wkulhanek","followers_url":"https://api.github.com/users/wkulhanek/followers","following_url":"https://api.github.com/users/wkulhanek/following{/other_user}","gists_url":"https://api.github.com/users/wkulhanek/gists{/gist_id}","starred_url":"https://api.github.com/users/wkulhanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkulhanek/subscriptions","organizations_url":"https://api.github.com/users/wkulhanek/orgs","repos_url":"https://api.github.com/users/wkulhanek/repos","events_url":"https://api.github.com/users/wkulhanek/events{/privacy}","received_events_url":"https://api.github.com/users/wkulhanek/received_events","type":"User","site_admin":false},"repo":{"id":144751777,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3NTE3Nzc=","name":"infra-ansible","full_name":"wkulhanek/infra-ansible","private":false,"owner":{"login":"wkulhanek","id":8929233,"node_id":"MDQ6VXNlcjg5MjkyMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8929233?v=4","gravatar_id":"","url":"https://api.github.com/users/wkulhanek","html_url":"https://github.com/wkulhanek","followers_url":"https://api.github.com/users/wkulhanek/followers","following_url":"https://api.github.com/users/wkulhanek/following{/other_user}","gists_url":"https://api.github.com/users/wkulhanek/gists{/gist_id}","starred_url":"https://api.github.com/users/wkulhanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkulhanek/subscriptions","organizations_url":"https://api.github.com/users/wkulhanek/orgs","repos_url":"https://api.github.com/users/wkulhanek/repos","events_url":"https://api.github.com/users/wkulhanek/events{/privacy}","received_events_url":"https://api.github.com/users/wkulhanek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wkulhanek/infra-ansible","description":"Tooling / Ansible to support the many aspects of infrastructure installation, setup and configuration. ","fork":true,"url":"https://api.github.com/repos/wkulhanek/infra-ansible","forks_url":"https://api.github.com/repos/wkulhanek/infra-ansible/forks","keys_url":"https://api.github.com/repos/wkulhanek/infra-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wkulhanek/infra-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wkulhanek/infra-ansible/teams","hooks_url":"https://api.github.com/repos/wkulhanek/infra-ansible/hooks","issue_events_url":"https://api.github.com/repos/wkulhanek/infra-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/wkulhanek/infra-ansible/events","assignees_url":"https://api.github.com/repos/wkulhanek/infra-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/wkulhanek/infra-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/wkulhanek/infra-ansible/tags","blobs_url":"https://api.github.com/repos/wkulhanek/infra-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wkulhanek/infra-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wkulhanek/infra-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/wkulhanek/infra-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wkulhanek/infra-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/wkulhanek/infra-ansible/languages","stargazers_url":"https://api.github.com/repos/wkulhanek/infra-ansible/stargazers","contributors_url":"https://api.github.com/repos/wkulhanek/infra-ansible/contributors","subscribers_url":"https://api.github.com/repos/wkulhanek/infra-ansible/subscribers","subscription_url":"https://api.github.com/repos/wkulhanek/infra-ansible/subscription","commits_url":"https://api.github.com/repos/wkulhanek/infra-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/wkulhanek/infra-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/wkulhanek/infra-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/wkulhanek/infra-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/wkulhanek/infra-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/wkulhanek/infra-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wkulhanek/infra-ansible/merges","archive_url":"https://api.github.com/repos/wkulhanek/infra-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wkulhanek/infra-ansible/downloads","issues_url":"https://api.github.com/repos/wkulhanek/infra-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/wkulhanek/infra-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/wkulhanek/infra-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/wkulhanek/infra-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wkulhanek/infra-ansible/labels{/name}","releases_url":"https://api.github.com/repos/wkulhanek/infra-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/wkulhanek/infra-ansible/deployments","created_at":"2018-08-14T17:27:58Z","updated_at":"2018-09-04T19:29:09Z","pushed_at":"2018-09-04T19:29:08Z","git_url":"git://github.com/wkulhanek/infra-ansible.git","ssh_url":"git@github.com:wkulhanek/infra-ansible.git","clone_url":"https://github.com/wkulhanek/infra-ansible.git","svn_url":"https://github.com/wkulhanek/infra-ansible","homepage":null,"size":532,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redhat-cop:master","ref":"master","sha":"cbedf25b13d6b4d87315d5d56305b0de43ab2d02","user":{"login":"redhat-cop","id":21339385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzM5Mzg1","avatar_url":"https://avatars2.githubusercontent.com/u/21339385?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-cop","html_url":"https://github.com/redhat-cop","followers_url":"https://api.github.com/users/redhat-cop/followers","following_url":"https://api.github.com/users/redhat-cop/following{/other_user}","gists_url":"https://api.github.com/users/redhat-cop/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-cop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-cop/subscriptions","organizations_url":"https://api.github.com/users/redhat-cop/orgs","repos_url":"https://api.github.com/users/redhat-cop/repos","events_url":"https://api.github.com/users/redhat-cop/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-cop/received_events","type":"Organization","site_admin":false},"repo":{"id":88211051,"node_id":"MDEwOlJlcG9zaXRvcnk4ODIxMTA1MQ==","name":"infra-ansible","full_name":"redhat-cop/infra-ansible","private":false,"owner":{"login":"redhat-cop","id":21339385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzM5Mzg1","avatar_url":"https://avatars2.githubusercontent.com/u/21339385?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-cop","html_url":"https://github.com/redhat-cop","followers_url":"https://api.github.com/users/redhat-cop/followers","following_url":"https://api.github.com/users/redhat-cop/following{/other_user}","gists_url":"https://api.github.com/users/redhat-cop/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-cop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-cop/subscriptions","organizations_url":"https://api.github.com/users/redhat-cop/orgs","repos_url":"https://api.github.com/users/redhat-cop/repos","events_url":"https://api.github.com/users/redhat-cop/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-cop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/redhat-cop/infra-ansible","description":"Tooling / Ansible to support the many aspects of infrastructure installation, setup and configuration. ","fork":false,"url":"https://api.github.com/repos/redhat-cop/infra-ansible","forks_url":"https://api.github.com/repos/redhat-cop/infra-ansible/forks","keys_url":"https://api.github.com/repos/redhat-cop/infra-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-cop/infra-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-cop/infra-ansible/teams","hooks_url":"https://api.github.com/repos/redhat-cop/infra-ansible/hooks","issue_events_url":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-cop/infra-ansible/events","assignees_url":"https://api.github.com/repos/redhat-cop/infra-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-cop/infra-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-cop/infra-ansible/tags","blobs_url":"https://api.github.com/repos/redhat-cop/infra-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-cop/infra-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-cop/infra-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-cop/infra-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-cop/infra-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-cop/infra-ansible/languages","stargazers_url":"https://api.github.com/repos/redhat-cop/infra-ansible/stargazers","contributors_url":"https://api.github.com/repos/redhat-cop/infra-ansible/contributors","subscribers_url":"https://api.github.com/repos/redhat-cop/infra-ansible/subscribers","subscription_url":"https://api.github.com/repos/redhat-cop/infra-ansible/subscription","commits_url":"https://api.github.com/repos/redhat-cop/infra-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-cop/infra-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-cop/infra-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-cop/infra-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-cop/infra-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-cop/infra-ansible/merges","archive_url":"https://api.github.com/repos/redhat-cop/infra-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-cop/infra-ansible/downloads","issues_url":"https://api.github.com/repos/redhat-cop/infra-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-cop/infra-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-cop/infra-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-cop/infra-ansible/labels{/name}","releases_url":"https://api.github.com/repos/redhat-cop/infra-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-cop/infra-ansible/deployments","created_at":"2017-04-13T22:20:20Z","updated_at":"2018-11-13T04:46:52Z","pushed_at":"2018-11-13T04:46:50Z","git_url":"git://github.com/redhat-cop/infra-ansible.git","ssh_url":"git@github.com:redhat-cop/infra-ansible.git","clone_url":"https://github.com/redhat-cop/infra-ansible.git","svn_url":"https://github.com/redhat-cop/infra-ansible","homepage":null,"size":593,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":36,"open_issues":28,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/248"},"html":{"href":"https://github.com/redhat-cop/infra-ansible/pull/248"},"issue":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/248"},"comments":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/statuses/dcb1c52c1f95196523e132c7a99e94cd4a4ab074"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":25,"additions":133,"deletions":98,"changed_files":15}}
{"actor":{"display_login":"oybed"}}