{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/tai-frontend/pulls/comments/189205638","pull_request_review_id":121340577,"id":189205638,"diff_hunk":"@@ -321,11 +341,11 @@ class BbsiCloseAccountControllerSpec extends PlaySpec\n       \"the form is valid but user has selected that they don't have any interest\" in {\n \n         val sut = createSUT\n-        val closingInterest = \"£123.45\"\n+        val closingInterest = \"\"\n \n         val mapWithClosingInterest = Map(CloseBankAccountInterestKey -> closingInterest)\n \n-        when(sut.journeyCacheService.cache(any())(any())).thenReturn(Future.successful(mapWithClosingInterest))\n+        when(sut.journeyCacheService.cache(any(),any())(any())).thenReturn(Future.successful(mapWithClosingInterest))","path":"test/controllers/income/bbsi/BbsiCloseAccountControllerSpec.scala","position":70,"original_position":70,"commit_id":"900425081d8714e559859e87f4f3797f399892de","original_commit_id":"900425081d8714e559859e87f4f3797f399892de","user":{"login":"markhunter27","id":5548514,"avatar_url":"https://avatars2.githubusercontent.com/u/5548514?v=4","gravatar_id":"","url":"https://api.github.com/users/markhunter27","html_url":"https://github.com/markhunter27","followers_url":"https://api.github.com/users/markhunter27/followers","following_url":"https://api.github.com/users/markhunter27/following{/other_user}","gists_url":"https://api.github.com/users/markhunter27/gists{/gist_id}","starred_url":"https://api.github.com/users/markhunter27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markhunter27/subscriptions","organizations_url":"https://api.github.com/users/markhunter27/orgs","repos_url":"https://api.github.com/users/markhunter27/repos","events_url":"https://api.github.com/users/markhunter27/events{/privacy}","received_events_url":"https://api.github.com/users/markhunter27/received_events","type":"User","site_admin":false},"body":"Could actually get away with returning an empty map ","created_at":"2018-05-18T09:03:11Z","updated_at":"2018-05-18T09:03:12Z","html_url":"https://github.com/hmrc/tai-frontend/pull/102#discussion_r189205638","pull_request_url":"https://api.github.com/repos/hmrc/tai-frontend/pulls/102","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmrc/tai-frontend/pulls/comments/189205638"},"html":{"href":"https://github.com/hmrc/tai-frontend/pull/102#discussion_r189205638"},"pull_request":{"href":"https://api.github.com/repos/hmrc/tai-frontend/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/tai-frontend/pulls/102","id":188936619,"html_url":"https://github.com/hmrc/tai-frontend/pull/102","diff_url":"https://github.com/hmrc/tai-frontend/pull/102.diff","patch_url":"https://github.com/hmrc/tai-frontend/pull/102.patch","issue_url":"https://api.github.com/repos/hmrc/tai-frontend/issues/102","number":102,"state":"open","locked":false,"title":"TAI-3757 form data is now saved in cache for bbsi close account","user":{"login":"craigemmerson","id":21197340,"avatar_url":"https://avatars0.githubusercontent.com/u/21197340?v=4","gravatar_id":"","url":"https://api.github.com/users/craigemmerson","html_url":"https://github.com/craigemmerson","followers_url":"https://api.github.com/users/craigemmerson/followers","following_url":"https://api.github.com/users/craigemmerson/following{/other_user}","gists_url":"https://api.github.com/users/craigemmerson/gists{/gist_id}","starred_url":"https://api.github.com/users/craigemmerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigemmerson/subscriptions","organizations_url":"https://api.github.com/users/craigemmerson/orgs","repos_url":"https://api.github.com/users/craigemmerson/repos","events_url":"https://api.github.com/users/craigemmerson/events{/privacy}","received_events_url":"https://api.github.com/users/craigemmerson/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-18T06:55:10Z","updated_at":"2018-05-18T09:03:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c3b1403590ebe407f4b741f367b9bda66e09870","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/tai-frontend/pulls/102/commits","review_comments_url":"https://api.github.com/repos/hmrc/tai-frontend/pulls/102/comments","review_comment_url":"https://api.github.com/repos/hmrc/tai-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/tai-frontend/issues/102/comments","statuses_url":"https://api.github.com/repos/hmrc/tai-frontend/statuses/900425081d8714e559859e87f4f3797f399892de","head":{"label":"hmrc:TAI-3757","ref":"TAI-3757","sha":"900425081d8714e559859e87f4f3797f399892de","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":123573182,"name":"tai-frontend","full_name":"hmrc/tai-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/tai-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/tai-frontend","forks_url":"https://api.github.com/repos/hmrc/tai-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/tai-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/tai-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/tai-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/tai-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/tai-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/tai-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/tai-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/tai-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/tai-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/tai-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/tai-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/tai-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/tai-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/tai-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/tai-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/tai-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/tai-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/tai-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/tai-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/tai-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/tai-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/tai-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/tai-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/tai-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/tai-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/tai-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/tai-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/tai-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/tai-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/tai-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/tai-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/tai-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/tai-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/tai-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/tai-frontend/deployments","created_at":"2018-03-02T11:50:02Z","updated_at":"2018-05-18T08:26:33Z","pushed_at":"2018-05-18T08:26:35Z","git_url":"git://github.com/hmrc/tai-frontend.git","ssh_url":"git@github.com:hmrc/tai-frontend.git","clone_url":"https://github.com/hmrc/tai-frontend.git","svn_url":"https://github.com/hmrc/tai-frontend","homepage":null,"size":44633,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"18cc2ef857a07e830de70e2496d965b39df0d4d2","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":123573182,"name":"tai-frontend","full_name":"hmrc/tai-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/tai-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/tai-frontend","forks_url":"https://api.github.com/repos/hmrc/tai-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/tai-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/tai-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/tai-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/tai-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/tai-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/tai-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/tai-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/tai-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/tai-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/tai-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/tai-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/tai-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/tai-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/tai-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/tai-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/tai-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/tai-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/tai-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/tai-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/tai-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/tai-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/tai-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/tai-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/tai-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/tai-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/tai-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/tai-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/tai-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/tai-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/tai-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/tai-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/tai-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/tai-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/tai-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/tai-frontend/deployments","created_at":"2018-03-02T11:50:02Z","updated_at":"2018-05-18T08:26:33Z","pushed_at":"2018-05-18T08:26:35Z","git_url":"git://github.com/hmrc/tai-frontend.git","ssh_url":"git@github.com:hmrc/tai-frontend.git","clone_url":"https://github.com/hmrc/tai-frontend.git","svn_url":"https://github.com/hmrc/tai-frontend","homepage":null,"size":44633,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/tai-frontend/pulls/102"},"html":{"href":"https://github.com/hmrc/tai-frontend/pull/102"},"issue":{"href":"https://api.github.com/repos/hmrc/tai-frontend/issues/102"},"comments":{"href":"https://api.github.com/repos/hmrc/tai-frontend/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/tai-frontend/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/tai-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/tai-frontend/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/tai-frontend/statuses/900425081d8714e559859e87f4f3797f399892de"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"markhunter27"}}