{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/comments/175513406","pull_request_review_id":105054963,"id":175513406,"diff_hunk":"@@ -15,15 +16,15 @@ def set_extra_headers(self, path):\n         # Disable cache\n         self.set_header('Cache-Control', 'no-store, no-cache, must-revalidate, max-age=0')\n \n+    @gen.coroutine\n     def get(self, pkg, fpath):\n         dirs = self.julia_load_path\n         for d in dirs:\n             dirpath = os.path.join(d, pkg, \"assets\")\n             fullpath = os.path.join(dirpath, fpath)\n             if os.path.isdir(dirpath) and os.path.isfile(fullpath):\n                 self.root = dirpath\n-                StaticFileHandler.get(self, fpath)\n-                return\n+                yield StaticFileHandler.get(self, fpath)","path":"deps/jlstaticserve.py","position":null,"original_position":22,"commit_id":"4cd37f746e17e854e75e9a5c04526af2b1844d36","original_commit_id":"6b3368f04765a433e4dc120a212c5e4d42bbb945","user":{"login":"rdeits","id":591886,"avatar_url":"https://avatars0.githubusercontent.com/u/591886?v=4","gravatar_id":"","url":"https://api.github.com/users/rdeits","html_url":"https://github.com/rdeits","followers_url":"https://api.github.com/users/rdeits/followers","following_url":"https://api.github.com/users/rdeits/following{/other_user}","gists_url":"https://api.github.com/users/rdeits/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeits/subscriptions","organizations_url":"https://api.github.com/users/rdeits/orgs","repos_url":"https://api.github.com/users/rdeits/repos","events_url":"https://api.github.com/users/rdeits/events{/privacy}","received_events_url":"https://api.github.com/users/rdeits/received_events","type":"User","site_admin":false},"body":"Ok, how's this?","created_at":"2018-03-19T17:10:09Z","updated_at":"2018-03-19T17:10:09Z","html_url":"https://github.com/JuliaGizmos/WebIO.jl/pull/70#discussion_r175513406","pull_request_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/70","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/comments/175513406"},"html":{"href":"https://github.com/JuliaGizmos/WebIO.jl/pull/70#discussion_r175513406"},"pull_request":{"href":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/70"}},"in_reply_to_id":175511078},"pull_request":{"url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/70","id":175962136,"html_url":"https://github.com/JuliaGizmos/WebIO.jl/pull/70","diff_url":"https://github.com/JuliaGizmos/WebIO.jl/pull/70.diff","patch_url":"https://github.com/JuliaGizmos/WebIO.jl/pull/70.patch","issue_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/issues/70","number":70,"state":"open","locked":false,"title":"make `JuliaPackageAssetServer.get()` a coroutine","user":{"login":"rdeits","id":591886,"avatar_url":"https://avatars0.githubusercontent.com/u/591886?v=4","gravatar_id":"","url":"https://api.github.com/users/rdeits","html_url":"https://github.com/rdeits","followers_url":"https://api.github.com/users/rdeits/followers","following_url":"https://api.github.com/users/rdeits/following{/other_user}","gists_url":"https://api.github.com/users/rdeits/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeits/subscriptions","organizations_url":"https://api.github.com/users/rdeits/orgs","repos_url":"https://api.github.com/users/rdeits/repos","events_url":"https://api.github.com/users/rdeits/events{/privacy}","received_events_url":"https://api.github.com/users/rdeits/received_events","type":"User","site_admin":false},"body":"appears to resolve #57 ","created_at":"2018-03-19T16:55:02Z","updated_at":"2018-03-19T17:10:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d68ba5f870095fbc3cc350a98dcf8db6ac2fda41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/70/commits","review_comments_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/70/comments","review_comment_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/issues/70/comments","statuses_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/statuses/4cd37f746e17e854e75e9a5c04526af2b1844d36","head":{"label":"rdeits:coroutine","ref":"coroutine","sha":"4cd37f746e17e854e75e9a5c04526af2b1844d36","user":{"login":"rdeits","id":591886,"avatar_url":"https://avatars0.githubusercontent.com/u/591886?v=4","gravatar_id":"","url":"https://api.github.com/users/rdeits","html_url":"https://github.com/rdeits","followers_url":"https://api.github.com/users/rdeits/followers","following_url":"https://api.github.com/users/rdeits/following{/other_user}","gists_url":"https://api.github.com/users/rdeits/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeits/subscriptions","organizations_url":"https://api.github.com/users/rdeits/orgs","repos_url":"https://api.github.com/users/rdeits/repos","events_url":"https://api.github.com/users/rdeits/events{/privacy}","received_events_url":"https://api.github.com/users/rdeits/received_events","type":"User","site_admin":false},"repo":{"id":125891395,"name":"WebIO.jl","full_name":"rdeits/WebIO.jl","owner":{"login":"rdeits","id":591886,"avatar_url":"https://avatars0.githubusercontent.com/u/591886?v=4","gravatar_id":"","url":"https://api.github.com/users/rdeits","html_url":"https://github.com/rdeits","followers_url":"https://api.github.com/users/rdeits/followers","following_url":"https://api.github.com/users/rdeits/following{/other_user}","gists_url":"https://api.github.com/users/rdeits/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeits/subscriptions","organizations_url":"https://api.github.com/users/rdeits/orgs","repos_url":"https://api.github.com/users/rdeits/repos","events_url":"https://api.github.com/users/rdeits/events{/privacy}","received_events_url":"https://api.github.com/users/rdeits/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdeits/WebIO.jl","description":"a bridge between Julia and web technologies","fork":true,"url":"https://api.github.com/repos/rdeits/WebIO.jl","forks_url":"https://api.github.com/repos/rdeits/WebIO.jl/forks","keys_url":"https://api.github.com/repos/rdeits/WebIO.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdeits/WebIO.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdeits/WebIO.jl/teams","hooks_url":"https://api.github.com/repos/rdeits/WebIO.jl/hooks","issue_events_url":"https://api.github.com/repos/rdeits/WebIO.jl/issues/events{/number}","events_url":"https://api.github.com/repos/rdeits/WebIO.jl/events","assignees_url":"https://api.github.com/repos/rdeits/WebIO.jl/assignees{/user}","branches_url":"https://api.github.com/repos/rdeits/WebIO.jl/branches{/branch}","tags_url":"https://api.github.com/repos/rdeits/WebIO.jl/tags","blobs_url":"https://api.github.com/repos/rdeits/WebIO.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdeits/WebIO.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdeits/WebIO.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdeits/WebIO.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdeits/WebIO.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/rdeits/WebIO.jl/languages","stargazers_url":"https://api.github.com/repos/rdeits/WebIO.jl/stargazers","contributors_url":"https://api.github.com/repos/rdeits/WebIO.jl/contributors","subscribers_url":"https://api.github.com/repos/rdeits/WebIO.jl/subscribers","subscription_url":"https://api.github.com/repos/rdeits/WebIO.jl/subscription","commits_url":"https://api.github.com/repos/rdeits/WebIO.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdeits/WebIO.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdeits/WebIO.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdeits/WebIO.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdeits/WebIO.jl/contents/{+path}","compare_url":"https://api.github.com/repos/rdeits/WebIO.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdeits/WebIO.jl/merges","archive_url":"https://api.github.com/repos/rdeits/WebIO.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdeits/WebIO.jl/downloads","issues_url":"https://api.github.com/repos/rdeits/WebIO.jl/issues{/number}","pulls_url":"https://api.github.com/repos/rdeits/WebIO.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/rdeits/WebIO.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/rdeits/WebIO.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdeits/WebIO.jl/labels{/name}","releases_url":"https://api.github.com/repos/rdeits/WebIO.jl/releases{/id}","deployments_url":"https://api.github.com/repos/rdeits/WebIO.jl/deployments","created_at":"2018-03-19T16:54:16Z","updated_at":"2018-03-19T16:54:18Z","pushed_at":"2018-03-19T17:09:31Z","git_url":"git://github.com/rdeits/WebIO.jl.git","ssh_url":"git@github.com:rdeits/WebIO.jl.git","clone_url":"https://github.com/rdeits/WebIO.jl.git","svn_url":"https://github.com/rdeits/WebIO.jl","homepage":"","size":298,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaGizmos:master","ref":"master","sha":"11389b75f0631d01dc3bcc924d8facc0e253309a","user":{"login":"JuliaGizmos","id":24488080,"avatar_url":"https://avatars3.githubusercontent.com/u/24488080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaGizmos","html_url":"https://github.com/JuliaGizmos","followers_url":"https://api.github.com/users/JuliaGizmos/followers","following_url":"https://api.github.com/users/JuliaGizmos/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGizmos/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGizmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGizmos/subscriptions","organizations_url":"https://api.github.com/users/JuliaGizmos/orgs","repos_url":"https://api.github.com/users/JuliaGizmos/repos","events_url":"https://api.github.com/users/JuliaGizmos/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGizmos/received_events","type":"Organization","site_admin":false},"repo":{"id":71904875,"name":"WebIO.jl","full_name":"JuliaGizmos/WebIO.jl","owner":{"login":"JuliaGizmos","id":24488080,"avatar_url":"https://avatars3.githubusercontent.com/u/24488080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaGizmos","html_url":"https://github.com/JuliaGizmos","followers_url":"https://api.github.com/users/JuliaGizmos/followers","following_url":"https://api.github.com/users/JuliaGizmos/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGizmos/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGizmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGizmos/subscriptions","organizations_url":"https://api.github.com/users/JuliaGizmos/orgs","repos_url":"https://api.github.com/users/JuliaGizmos/repos","events_url":"https://api.github.com/users/JuliaGizmos/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGizmos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaGizmos/WebIO.jl","description":"a bridge between Julia and web technologies","fork":false,"url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl","forks_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/forks","keys_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/teams","hooks_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/events","assignees_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/tags","blobs_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/subscription","commits_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/merges","archive_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/downloads","issues_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/deployments","created_at":"2016-10-25T14:25:40Z","updated_at":"2018-03-13T09:16:57Z","pushed_at":"2018-03-19T17:09:32Z","git_url":"git://github.com/JuliaGizmos/WebIO.jl.git","ssh_url":"git@github.com:JuliaGizmos/WebIO.jl.git","clone_url":"https://github.com/JuliaGizmos/WebIO.jl.git","svn_url":"https://github.com/JuliaGizmos/WebIO.jl","homepage":"","size":298,"stargazers_count":23,"watchers_count":23,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":14,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/70"},"html":{"href":"https://github.com/JuliaGizmos/WebIO.jl/pull/70"},"issue":{"href":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/issues/70"},"comments":{"href":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaGizmos/WebIO.jl/statuses/4cd37f746e17e854e75e9a5c04526af2b1844d36"}},"author_association":"NONE"}}
{"actor":{"display_login":"rdeits"}}