{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/214728001","pull_request_review_id":151841963,"id":214728001,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDcyODAwMQ==","diff_hunk":"@@ -91,6 +87,8 @@ private static byte[] EncodeBagValue(Oid certificateType, ReadOnlyMemory<byte> e\n         {\n             if (certificateType == null)\n                 throw new ArgumentNullException(nameof(certificateType));\n+            if (certificateType.Value == null)\n+                throw new CryptographicException(SR.Argument_InvalidOidValue);","path":"src/System.Security.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Pkcs12CertBag.cs","position":27,"original_position":27,"commit_id":"fcfbfb94fa92b212b330e997d4e704f289cb8f72","original_commit_id":"fcfbfb94fa92b212b330e997d4e704f289cb8f72","user":{"login":"filipnavara","id":1764393,"node_id":"MDQ6VXNlcjE3NjQzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1764393?v=4","gravatar_id":"","url":"https://api.github.com/users/filipnavara","html_url":"https://github.com/filipnavara","followers_url":"https://api.github.com/users/filipnavara/followers","following_url":"https://api.github.com/users/filipnavara/following{/other_user}","gists_url":"https://api.github.com/users/filipnavara/gists{/gist_id}","starred_url":"https://api.github.com/users/filipnavara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipnavara/subscriptions","organizations_url":"https://api.github.com/users/filipnavara/orgs","repos_url":"https://api.github.com/users/filipnavara/repos","events_url":"https://api.github.com/users/filipnavara/events{/privacy}","received_events_url":"https://api.github.com/users/filipnavara/received_events","type":"User","site_admin":false},"body":"I added it to match the behavior of `AsnWriter` when the field is declared as `Oid` backing type. Should it ever be changed for any reason then this is what would get thrown with `AsnWriter.WriteObjectIdentifier(new Oid(null, null) `. I believe it makes sense to keep it consistent. ","created_at":"2018-09-03T15:58:21Z","updated_at":"2018-09-03T15:58:21Z","html_url":"https://github.com/dotnet/corefx/pull/31988#discussion_r214728001","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/31988","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/214728001"},"html":{"href":"https://github.com/dotnet/corefx/pull/31988#discussion_r214728001"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31988"}},"in_reply_to_id":214412874},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/31988","id":211252768,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjUyNzY4","html_url":"https://github.com/dotnet/corefx/pull/31988","diff_url":"https://github.com/dotnet/corefx/pull/31988.diff","patch_url":"https://github.com/dotnet/corefx/pull/31988.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/31988","number":31988,"state":"open","locked":false,"title":"Convert S.S.C.Pkcs to ASN code generator.","user":{"login":"filipnavara","id":1764393,"node_id":"MDQ6VXNlcjE3NjQzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1764393?v=4","gravatar_id":"","url":"https://api.github.com/users/filipnavara","html_url":"https://github.com/filipnavara","followers_url":"https://api.github.com/users/filipnavara/followers","following_url":"https://api.github.com/users/filipnavara/following{/other_user}","gists_url":"https://api.github.com/users/filipnavara/gists{/gist_id}","starred_url":"https://api.github.com/users/filipnavara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipnavara/subscriptions","organizations_url":"https://api.github.com/users/filipnavara/orgs","repos_url":"https://api.github.com/users/filipnavara/repos","events_url":"https://api.github.com/users/filipnavara/events{/privacy}","received_events_url":"https://api.github.com/users/filipnavara/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-27T22:45:38Z","updated_at":"2018-09-03T15:58:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3f7ee4ad6b4969ccbf784ed088e7cd5df66ed4b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/31988/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/31988/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/31988/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/fcfbfb94fa92b212b330e997d4e704f289cb8f72","head":{"label":"filipnavara:asngen-pkcs","ref":"asngen-pkcs","sha":"fcfbfb94fa92b212b330e997d4e704f289cb8f72","user":{"login":"filipnavara","id":1764393,"node_id":"MDQ6VXNlcjE3NjQzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1764393?v=4","gravatar_id":"","url":"https://api.github.com/users/filipnavara","html_url":"https://github.com/filipnavara","followers_url":"https://api.github.com/users/filipnavara/followers","following_url":"https://api.github.com/users/filipnavara/following{/other_user}","gists_url":"https://api.github.com/users/filipnavara/gists{/gist_id}","starred_url":"https://api.github.com/users/filipnavara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipnavara/subscriptions","organizations_url":"https://api.github.com/users/filipnavara/orgs","repos_url":"https://api.github.com/users/filipnavara/repos","events_url":"https://api.github.com/users/filipnavara/events{/privacy}","received_events_url":"https://api.github.com/users/filipnavara/received_events","type":"User","site_admin":false},"repo":{"id":135734017,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3MzQwMTc=","name":"corefx","full_name":"filipnavara/corefx","owner":{"login":"filipnavara","id":1764393,"node_id":"MDQ6VXNlcjE3NjQzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1764393?v=4","gravatar_id":"","url":"https://api.github.com/users/filipnavara","html_url":"https://github.com/filipnavara","followers_url":"https://api.github.com/users/filipnavara/followers","following_url":"https://api.github.com/users/filipnavara/following{/other_user}","gists_url":"https://api.github.com/users/filipnavara/gists{/gist_id}","starred_url":"https://api.github.com/users/filipnavara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipnavara/subscriptions","organizations_url":"https://api.github.com/users/filipnavara/orgs","repos_url":"https://api.github.com/users/filipnavara/repos","events_url":"https://api.github.com/users/filipnavara/events{/privacy}","received_events_url":"https://api.github.com/users/filipnavara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/filipnavara/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/filipnavara/corefx","forks_url":"https://api.github.com/repos/filipnavara/corefx/forks","keys_url":"https://api.github.com/repos/filipnavara/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filipnavara/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filipnavara/corefx/teams","hooks_url":"https://api.github.com/repos/filipnavara/corefx/hooks","issue_events_url":"https://api.github.com/repos/filipnavara/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/filipnavara/corefx/events","assignees_url":"https://api.github.com/repos/filipnavara/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/filipnavara/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/filipnavara/corefx/tags","blobs_url":"https://api.github.com/repos/filipnavara/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filipnavara/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filipnavara/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/filipnavara/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filipnavara/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/filipnavara/corefx/languages","stargazers_url":"https://api.github.com/repos/filipnavara/corefx/stargazers","contributors_url":"https://api.github.com/repos/filipnavara/corefx/contributors","subscribers_url":"https://api.github.com/repos/filipnavara/corefx/subscribers","subscription_url":"https://api.github.com/repos/filipnavara/corefx/subscription","commits_url":"https://api.github.com/repos/filipnavara/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/filipnavara/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/filipnavara/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/filipnavara/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/filipnavara/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/filipnavara/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filipnavara/corefx/merges","archive_url":"https://api.github.com/repos/filipnavara/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filipnavara/corefx/downloads","issues_url":"https://api.github.com/repos/filipnavara/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/filipnavara/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/filipnavara/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/filipnavara/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filipnavara/corefx/labels{/name}","releases_url":"https://api.github.com/repos/filipnavara/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/filipnavara/corefx/deployments","created_at":"2018-06-01T15:25:02Z","updated_at":"2018-08-25T09:57:34Z","pushed_at":"2018-08-29T16:22:11Z","git_url":"git://github.com/filipnavara/corefx.git","ssh_url":"git@github.com:filipnavara/corefx.git","clone_url":"https://github.com/filipnavara/corefx.git","svn_url":"https://github.com/filipnavara/corefx","homepage":"https://github.com/dotnet/core","size":187600,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"7bb3ad18a7882e7067ee9e08240431a320c65482","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-09-03T11:12:29Z","pushed_at":"2018-09-03T15:43:16Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":186812,"stargazers_count":14720,"watchers_count":14720,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4274,"mirror_url":null,"archived":false,"open_issues_count":2554,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4274,"open_issues":2554,"watchers":14720,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31988"},"html":{"href":"https://github.com/dotnet/corefx/pull/31988"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/31988"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/31988/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31988/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31988/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/fcfbfb94fa92b212b330e997d4e704f289cb8f72"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"filipnavara"}}