{"action":"created","issue":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/676","repository_url":"https://api.github.com/repos/kubeflow/kubeflow","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/676/labels{/name}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/676/comments","events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/676/events","html_url":"https://github.com/kubeflow/kubeflow/pull/676","id":315546675,"number":676,"title":"openmpi package doesn't work on kubernetes cluster having custom dns.","user":{"login":"everpeace","id":608782,"avatar_url":"https://avatars2.githubusercontent.com/u/608782?v=4","gravatar_id":"","url":"https://api.github.com/users/everpeace","html_url":"https://github.com/everpeace","followers_url":"https://api.github.com/users/everpeace/followers","following_url":"https://api.github.com/users/everpeace/following{/other_user}","gists_url":"https://api.github.com/users/everpeace/gists{/gist_id}","starred_url":"https://api.github.com/users/everpeace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everpeace/subscriptions","organizations_url":"https://api.github.com/users/everpeace/orgs","repos_url":"https://api.github.com/users/everpeace/repos","events_url":"https://api.github.com/users/everpeace/events{/privacy}","received_events_url":"https://api.github.com/users/everpeace/received_events","type":"User","site_admin":false},"labels":[{"id":842377274,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/lgtm","name":"lgtm","color":"80cc4d","default":false},{"id":796371394,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"fbca04","default":false},{"id":796413694,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/XS","name":"size/XS","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"jiezhang","id":37601164,"avatar_url":"https://avatars3.githubusercontent.com/u/37601164?v=4","gravatar_id":"","url":"https://api.github.com/users/jiezhang","html_url":"https://github.com/jiezhang","followers_url":"https://api.github.com/users/jiezhang/followers","following_url":"https://api.github.com/users/jiezhang/following{/other_user}","gists_url":"https://api.github.com/users/jiezhang/gists{/gist_id}","starred_url":"https://api.github.com/users/jiezhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiezhang/subscriptions","organizations_url":"https://api.github.com/users/jiezhang/orgs","repos_url":"https://api.github.com/users/jiezhang/repos","events_url":"https://api.github.com/users/jiezhang/events{/privacy}","received_events_url":"https://api.github.com/users/jiezhang/received_events","type":"User","site_admin":false},"assignees":[{"login":"jiezhang","id":37601164,"avatar_url":"https://avatars3.githubusercontent.com/u/37601164?v=4","gravatar_id":"","url":"https://api.github.com/users/jiezhang","html_url":"https://github.com/jiezhang","followers_url":"https://api.github.com/users/jiezhang/followers","following_url":"https://api.github.com/users/jiezhang/following{/other_user}","gists_url":"https://api.github.com/users/jiezhang/gists{/gist_id}","starred_url":"https://api.github.com/users/jiezhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiezhang/subscriptions","organizations_url":"https://api.github.com/users/jiezhang/orgs","repos_url":"https://api.github.com/users/jiezhang/repos","events_url":"https://api.github.com/users/jiezhang/events{/privacy}","received_events_url":"https://api.github.com/users/jiezhang/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-04-18T16:09:56Z","updated_at":"2018-04-18T19:37:47Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/676","html_url":"https://github.com/kubeflow/kubeflow/pull/676","diff_url":"https://github.com/kubeflow/kubeflow/pull/676.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/676.patch"},"body":"Hi, I'm really pleased kubeflow is going to support openmpi.  I'm also happy to contribute this openmpi package.  It is because I'm also developing very similar tool of [everpeace/kube-openmpi](https://github.com/everpeace/kube-openmpi/) by myself.  \r\n\r\n## Problem this PR fixes\r\ncurrent openmpi package doesn't work well on kubernetes cluster having custom dns (other than `cluster.local`) because `hostfile` includes fixed `cluster.local` string.\r\n\r\n## How this PR fixed the problem\r\nThis PR just removed `svc.cluster.local` from `genHostfile` function.  StatefulSets depends on Headless Service to create sub-domain, and sub-domain is always under `svc.<cluster-dns>`.   So, removing `svc` is safe.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/676)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments/382504463","html_url":"https://github.com/kubeflow/kubeflow/pull/676#issuecomment-382504463","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/676","id":382504463,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T19:37:47Z","updated_at":"2018-04-18T19:37:47Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubeflow/kubeflow/pull/676#issuecomment-382504434\" title=\"Approved\">jiezhang</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **willb**\n\nAssign the PR to them by writing `/assign @willb` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubeflow/kubeflow/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"willb\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}