{"action":"created","issue":{"url":"https://api.github.com/repos/zeit/ms/issues/93","repository_url":"https://api.github.com/repos/zeit/ms","labels_url":"https://api.github.com/repos/zeit/ms/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/zeit/ms/issues/93/comments","events_url":"https://api.github.com/repos/zeit/ms/issues/93/events","html_url":"https://github.com/zeit/ms/pull/93","id":234299540,"node_id":"MDExOlB1bGxSZXF1ZXN0MTI0NDg2MzYw","number":93,"title":"Improve performance and remove str limit","user":{"login":"thevtm","id":978715,"node_id":"MDQ6VXNlcjk3ODcxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/978715?v=4","gravatar_id":"","url":"https://api.github.com/users/thevtm","html_url":"https://github.com/thevtm","followers_url":"https://api.github.com/users/thevtm/followers","following_url":"https://api.github.com/users/thevtm/following{/other_user}","gists_url":"https://api.github.com/users/thevtm/gists{/gist_id}","starred_url":"https://api.github.com/users/thevtm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thevtm/subscriptions","organizations_url":"https://api.github.com/users/thevtm/orgs","repos_url":"https://api.github.com/users/thevtm/repos","events_url":"https://api.github.com/users/thevtm/events{/privacy}","received_events_url":"https://api.github.com/users/thevtm/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2017-06-07T18:22:00Z","updated_at":"2018-12-03T17:19:01Z","closed_at":"2018-12-03T16:18:17Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/zeit/ms/pulls/93","html_url":"https://github.com/zeit/ms/pull/93","diff_url":"https://github.com/zeit/ms/pull/93.diff","patch_url":"https://github.com/zeit/ms/pull/93.patch"},"body":"Changing the Regex from:\r\n `/^((?:\\d+)?\\.?\\d+) *(milliseconds?|msecs?|ms|seconds?|secs?|s|minutes?|mins?|m|hours?|hrs?|h|days?|d|years?|yrs?|y)?$/i`\r\nto:\r\n`/^((?:\\d+)?\\.?\\d+) *(\\w{0,12})?$/i`\r\nseems to produce better performance and solve the issues with long str.\r\n\r\n[Benchmark source](https://gist.github.com/thevtm/063a834083a42af535e26196a5d3c8d5)\r\n\r\n```\r\noriginal x 38,472 ops/sec ±2.05% (88 runs sampled)\r\nmine x 74,820 ops/sec ±1.84% (84 runs sampled)\r\nFastest is mine\r\nDone in 17.97s.\r\n```"},"comment":{"url":"https://api.github.com/repos/zeit/ms/issues/comments/443791745","html_url":"https://github.com/zeit/ms/pull/93#issuecomment-443791745","issue_url":"https://api.github.com/repos/zeit/ms/issues/93","id":443791745,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mzc5MTc0NQ==","user":{"login":"sam-github","id":17607,"node_id":"MDQ6VXNlcjE3NjA3","avatar_url":"https://avatars2.githubusercontent.com/u/17607?v=4","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T17:19:01Z","updated_at":"2018-12-03T17:19:01Z","author_association":"NONE","body":"@rauchg did you push the close button instead of the comment button by accident?"}}
{"actor":{"display_login":"sam-github"}}