{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/JFleming4/Sysc3303Project/pulls/20","id":166656074,"html_url":"https://github.com/JFleming4/Sysc3303Project/pull/20","diff_url":"https://github.com/JFleming4/Sysc3303Project/pull/20.diff","patch_url":"https://github.com/JFleming4/Sysc3303Project/pull/20.patch","issue_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/issues/20","number":20,"state":"closed","locked":false,"title":"Better packet logging","user":{"login":"DerekStride","id":6456191,"avatar_url":"https://avatars2.githubusercontent.com/u/6456191?v=4","gravatar_id":"","url":"https://api.github.com/users/DerekStride","html_url":"https://github.com/DerekStride","followers_url":"https://api.github.com/users/DerekStride/followers","following_url":"https://api.github.com/users/DerekStride/following{/other_user}","gists_url":"https://api.github.com/users/DerekStride/gists{/gist_id}","starred_url":"https://api.github.com/users/DerekStride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DerekStride/subscriptions","organizations_url":"https://api.github.com/users/DerekStride/orgs","repos_url":"https://api.github.com/users/DerekStride/repos","events_url":"https://api.github.com/users/DerekStride/events{/privacy}","received_events_url":"https://api.github.com/users/DerekStride/received_events","type":"User","site_admin":false},"body":"The logger was outputting the max data buffer when the packet length was shorter.\r\n\r\nIn other words it converts\r\n```\r\n[TFTPDatagramSocket][VERBOSE]: Byte Array: { 0x00, 0x04, 0x00, 0x02, 0x00, 0x00, 0x00, \r\n0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,\r\n0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, ... OMITTED ... }\r\n```\r\nto\r\n```\r\n[TFTPDatagramSocket][VERBOSE]: Byte Array: { 0x00, 0x04, 0x00, 0x02 }\r\n```","created_at":"2018-02-01T21:26:01Z","updated_at":"2018-02-02T01:54:04Z","closed_at":"2018-02-02T01:54:04Z","merged_at":"2018-02-02T01:54:04Z","merge_commit_sha":"8484b83a1c49acd6576e5d41fce16b9ba7c266cd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"irushavm","id":3733412,"avatar_url":"https://avatars3.githubusercontent.com/u/3733412?v=4","gravatar_id":"","url":"https://api.github.com/users/irushavm","html_url":"https://github.com/irushavm","followers_url":"https://api.github.com/users/irushavm/followers","following_url":"https://api.github.com/users/irushavm/following{/other_user}","gists_url":"https://api.github.com/users/irushavm/gists{/gist_id}","starred_url":"https://api.github.com/users/irushavm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irushavm/subscriptions","organizations_url":"https://api.github.com/users/irushavm/orgs","repos_url":"https://api.github.com/users/irushavm/repos","events_url":"https://api.github.com/users/irushavm/events{/privacy}","received_events_url":"https://api.github.com/users/irushavm/received_events","type":"User","site_admin":false},{"login":"JFleming4","id":10552232,"avatar_url":"https://avatars2.githubusercontent.com/u/10552232?v=4","gravatar_id":"","url":"https://api.github.com/users/JFleming4","html_url":"https://github.com/JFleming4","followers_url":"https://api.github.com/users/JFleming4/followers","following_url":"https://api.github.com/users/JFleming4/following{/other_user}","gists_url":"https://api.github.com/users/JFleming4/gists{/gist_id}","starred_url":"https://api.github.com/users/JFleming4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFleming4/subscriptions","organizations_url":"https://api.github.com/users/JFleming4/orgs","repos_url":"https://api.github.com/users/JFleming4/repos","events_url":"https://api.github.com/users/JFleming4/events{/privacy}","received_events_url":"https://api.github.com/users/JFleming4/received_events","type":"User","site_admin":false},{"login":"noahsegal","id":11277193,"avatar_url":"https://avatars2.githubusercontent.com/u/11277193?v=4","gravatar_id":"","url":"https://api.github.com/users/noahsegal","html_url":"https://github.com/noahsegal","followers_url":"https://api.github.com/users/noahsegal/followers","following_url":"https://api.github.com/users/noahsegal/following{/other_user}","gists_url":"https://api.github.com/users/noahsegal/gists{/gist_id}","starred_url":"https://api.github.com/users/noahsegal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahsegal/subscriptions","organizations_url":"https://api.github.com/users/noahsegal/orgs","repos_url":"https://api.github.com/users/noahsegal/repos","events_url":"https://api.github.com/users/noahsegal/events{/privacy}","received_events_url":"https://api.github.com/users/noahsegal/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/pulls/20/commits","review_comments_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/pulls/20/comments","review_comment_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/issues/20/comments","statuses_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/statuses/fe71d4465f91f52c47946d6d6719076bd6c36d25","head":{"label":"JFleming4:better-packet-logging","ref":"better-packet-logging","sha":"fe71d4465f91f52c47946d6d6719076bd6c36d25","user":{"login":"JFleming4","id":10552232,"avatar_url":"https://avatars2.githubusercontent.com/u/10552232?v=4","gravatar_id":"","url":"https://api.github.com/users/JFleming4","html_url":"https://github.com/JFleming4","followers_url":"https://api.github.com/users/JFleming4/followers","following_url":"https://api.github.com/users/JFleming4/following{/other_user}","gists_url":"https://api.github.com/users/JFleming4/gists{/gist_id}","starred_url":"https://api.github.com/users/JFleming4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFleming4/subscriptions","organizations_url":"https://api.github.com/users/JFleming4/orgs","repos_url":"https://api.github.com/users/JFleming4/repos","events_url":"https://api.github.com/users/JFleming4/events{/privacy}","received_events_url":"https://api.github.com/users/JFleming4/received_events","type":"User","site_admin":false},"repo":{"id":118149552,"name":"Sysc3303Project","full_name":"JFleming4/Sysc3303Project","owner":{"login":"JFleming4","id":10552232,"avatar_url":"https://avatars2.githubusercontent.com/u/10552232?v=4","gravatar_id":"","url":"https://api.github.com/users/JFleming4","html_url":"https://github.com/JFleming4","followers_url":"https://api.github.com/users/JFleming4/followers","following_url":"https://api.github.com/users/JFleming4/following{/other_user}","gists_url":"https://api.github.com/users/JFleming4/gists{/gist_id}","starred_url":"https://api.github.com/users/JFleming4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFleming4/subscriptions","organizations_url":"https://api.github.com/users/JFleming4/orgs","repos_url":"https://api.github.com/users/JFleming4/repos","events_url":"https://api.github.com/users/JFleming4/events{/privacy}","received_events_url":"https://api.github.com/users/JFleming4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JFleming4/Sysc3303Project","description":null,"fork":false,"url":"https://api.github.com/repos/JFleming4/Sysc3303Project","forks_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/forks","keys_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/teams","hooks_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/hooks","issue_events_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/issues/events{/number}","events_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/events","assignees_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/assignees{/user}","branches_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/branches{/branch}","tags_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/tags","blobs_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/git/refs{/sha}","trees_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/statuses/{sha}","languages_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/languages","stargazers_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/stargazers","contributors_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/contributors","subscribers_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/subscribers","subscription_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/subscription","commits_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/commits{/sha}","git_commits_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/git/commits{/sha}","comments_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/comments{/number}","issue_comment_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/issues/comments{/number}","contents_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/contents/{+path}","compare_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/merges","archive_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/downloads","issues_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/issues{/number}","pulls_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/pulls{/number}","milestones_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/milestones{/number}","notifications_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/labels{/name}","releases_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/releases{/id}","deployments_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/deployments","created_at":"2018-01-19T16:29:07Z","updated_at":"2018-01-29T12:06:23Z","pushed_at":"2018-02-02T01:54:04Z","git_url":"git://github.com/JFleming4/Sysc3303Project.git","ssh_url":"git@github.com:JFleming4/Sysc3303Project.git","clone_url":"https://github.com/JFleming4/Sysc3303Project.git","svn_url":"https://github.com/JFleming4/Sysc3303Project","homepage":null,"size":1489,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"JFleming4:master","ref":"master","sha":"2019f9db50381ee18b587c55993f430cb42d09c5","user":{"login":"JFleming4","id":10552232,"avatar_url":"https://avatars2.githubusercontent.com/u/10552232?v=4","gravatar_id":"","url":"https://api.github.com/users/JFleming4","html_url":"https://github.com/JFleming4","followers_url":"https://api.github.com/users/JFleming4/followers","following_url":"https://api.github.com/users/JFleming4/following{/other_user}","gists_url":"https://api.github.com/users/JFleming4/gists{/gist_id}","starred_url":"https://api.github.com/users/JFleming4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFleming4/subscriptions","organizations_url":"https://api.github.com/users/JFleming4/orgs","repos_url":"https://api.github.com/users/JFleming4/repos","events_url":"https://api.github.com/users/JFleming4/events{/privacy}","received_events_url":"https://api.github.com/users/JFleming4/received_events","type":"User","site_admin":false},"repo":{"id":118149552,"name":"Sysc3303Project","full_name":"JFleming4/Sysc3303Project","owner":{"login":"JFleming4","id":10552232,"avatar_url":"https://avatars2.githubusercontent.com/u/10552232?v=4","gravatar_id":"","url":"https://api.github.com/users/JFleming4","html_url":"https://github.com/JFleming4","followers_url":"https://api.github.com/users/JFleming4/followers","following_url":"https://api.github.com/users/JFleming4/following{/other_user}","gists_url":"https://api.github.com/users/JFleming4/gists{/gist_id}","starred_url":"https://api.github.com/users/JFleming4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFleming4/subscriptions","organizations_url":"https://api.github.com/users/JFleming4/orgs","repos_url":"https://api.github.com/users/JFleming4/repos","events_url":"https://api.github.com/users/JFleming4/events{/privacy}","received_events_url":"https://api.github.com/users/JFleming4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JFleming4/Sysc3303Project","description":null,"fork":false,"url":"https://api.github.com/repos/JFleming4/Sysc3303Project","forks_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/forks","keys_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/teams","hooks_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/hooks","issue_events_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/issues/events{/number}","events_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/events","assignees_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/assignees{/user}","branches_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/branches{/branch}","tags_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/tags","blobs_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/git/refs{/sha}","trees_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/statuses/{sha}","languages_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/languages","stargazers_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/stargazers","contributors_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/contributors","subscribers_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/subscribers","subscription_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/subscription","commits_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/commits{/sha}","git_commits_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/git/commits{/sha}","comments_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/comments{/number}","issue_comment_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/issues/comments{/number}","contents_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/contents/{+path}","compare_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/merges","archive_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/downloads","issues_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/issues{/number}","pulls_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/pulls{/number}","milestones_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/milestones{/number}","notifications_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/labels{/name}","releases_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/releases{/id}","deployments_url":"https://api.github.com/repos/JFleming4/Sysc3303Project/deployments","created_at":"2018-01-19T16:29:07Z","updated_at":"2018-01-29T12:06:23Z","pushed_at":"2018-02-02T01:54:04Z","git_url":"git://github.com/JFleming4/Sysc3303Project.git","ssh_url":"git@github.com:JFleming4/Sysc3303Project.git","clone_url":"https://github.com/JFleming4/Sysc3303Project.git","svn_url":"https://github.com/JFleming4/Sysc3303Project","homepage":null,"size":1489,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JFleming4/Sysc3303Project/pulls/20"},"html":{"href":"https://github.com/JFleming4/Sysc3303Project/pull/20"},"issue":{"href":"https://api.github.com/repos/JFleming4/Sysc3303Project/issues/20"},"comments":{"href":"https://api.github.com/repos/JFleming4/Sysc3303Project/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/JFleming4/Sysc3303Project/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/JFleming4/Sysc3303Project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JFleming4/Sysc3303Project/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/JFleming4/Sysc3303Project/statuses/fe71d4465f91f52c47946d6d6719076bd6c36d25"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MikeVezina","id":10552190,"avatar_url":"https://avatars1.githubusercontent.com/u/10552190?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeVezina","html_url":"https://github.com/MikeVezina","followers_url":"https://api.github.com/users/MikeVezina/followers","following_url":"https://api.github.com/users/MikeVezina/following{/other_user}","gists_url":"https://api.github.com/users/MikeVezina/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeVezina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeVezina/subscriptions","organizations_url":"https://api.github.com/users/MikeVezina/orgs","repos_url":"https://api.github.com/users/MikeVezina/repos","events_url":"https://api.github.com/users/MikeVezina/events{/privacy}","received_events_url":"https://api.github.com/users/MikeVezina/received_events","type":"User","site_admin":false},"comments":0,"review_comments":7,"maintainer_can_modify":false,"commits":3,"additions":33,"deletions":10,"changed_files":3}}
{"actor":{"display_login":"MikeVezina"}}