{"action":"created","comment":{"url":"https://api.github.com/repos/golemfactory/concent/pulls/comments/186948912","pull_request_review_id":118627760,"id":186948912,"diff_hunk":"@@ -174,6 +174,55 @@ def check_settings_storage_cluster_address(app_configs, **kwargs):  # pylint: di\n     return []\n \n \n+@register()\n+def check_settings_storage_server_internal_address(app_configs, **kwargs):  # pylint: disable=unused-argument\n+    if not hasattr(settings, 'STORAGE_SERVER_INTERNAL_ADDRESS') and 'verifier' in settings.CONCENT_FEATURES:\n+        return [Error(\n+            'STORAGE_SERVER_INTERNAL_ADDRESS setting is not defined',\n+            hint = 'Set STORAGE_SERVER_INTERNAL_ADDRESS in your local_settings.py to the address of a Concent storage cluster that offers the /upload/ and /download/ endpoints.',\n+            id   = 'concent.E010',\n+        )]\n+\n+    if hasattr(settings, 'STORAGE_SERVER_INTERNAL_ADDRESS'):\n+        url_validator = URLValidator(schemes = ['http', 'https'])\n+        try:\n+            url_validator(settings.STORAGE_CLUSTER_ADDRESS)\n+        except ValidationError as error:\n+            return [Error(\n+                'STORAGE_SERVER_INTERNAL_ADDRESS is not a valid URL',\n+                hint = '{}'.format(error),\n+                id   = 'concent.E011',\n+            )]\n+\n+    return []\n+\n+\n+@register()\n+def check_settings_verifier_storage_path(app_configs, **kwargs):  # pylint: disable=unused-argument\n+    if not hasattr(settings, 'VERIFIER_STORAGE_PATH') and 'verifier' in settings.CONCENT_FEATURES:\n+        return [Error(","path":"concent_api/concent_api/system_check.py","position":30,"original_position":30,"commit_id":"8835e6ff34f8fbb1e68d41bc1d0f056a0d99405c","original_commit_id":"8835e6ff34f8fbb1e68d41bc1d0f056a0d99405c","user":{"login":"dybi","id":36961162,"avatar_url":"https://avatars0.githubusercontent.com/u/36961162?v=4","gravatar_id":"","url":"https://api.github.com/users/dybi","html_url":"https://github.com/dybi","followers_url":"https://api.github.com/users/dybi/followers","following_url":"https://api.github.com/users/dybi/following{/other_user}","gists_url":"https://api.github.com/users/dybi/gists{/gist_id}","starred_url":"https://api.github.com/users/dybi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dybi/subscriptions","organizations_url":"https://api.github.com/users/dybi/orgs","repos_url":"https://api.github.com/users/dybi/repos","events_url":"https://api.github.com/users/dybi/events{/privacy}","received_events_url":"https://api.github.com/users/dybi/received_events","type":"User","site_admin":false},"body":"please extract this error to a function","created_at":"2018-05-09T07:11:21Z","updated_at":"2018-05-09T07:27:41Z","html_url":"https://github.com/golemfactory/concent/pull/303#discussion_r186948912","pull_request_url":"https://api.github.com/repos/golemfactory/concent/pulls/303","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/comments/186948912"},"html":{"href":"https://github.com/golemfactory/concent/pull/303#discussion_r186948912"},"pull_request":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/303"}}},"pull_request":{"url":"https://api.github.com/repos/golemfactory/concent/pulls/303","id":182764756,"html_url":"https://github.com/golemfactory/concent/pull/303","diff_url":"https://github.com/golemfactory/concent/pull/303.diff","patch_url":"https://github.com/golemfactory/concent/pull/303.patch","issue_url":"https://api.github.com/repos/golemfactory/concent/issues/303","number":303,"state":"open","locked":false,"title":"[Verification 5] Feature verification verifier downloading files from the storage server","user":{"login":"rwrzesien","id":10088909,"avatar_url":"https://avatars0.githubusercontent.com/u/10088909?v=4","gravatar_id":"","url":"https://api.github.com/users/rwrzesien","html_url":"https://github.com/rwrzesien","followers_url":"https://api.github.com/users/rwrzesien/followers","following_url":"https://api.github.com/users/rwrzesien/following{/other_user}","gists_url":"https://api.github.com/users/rwrzesien/gists{/gist_id}","starred_url":"https://api.github.com/users/rwrzesien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwrzesien/subscriptions","organizations_url":"https://api.github.com/users/rwrzesien/orgs","repos_url":"https://api.github.com/users/rwrzesien/repos","events_url":"https://api.github.com/users/rwrzesien/events{/privacy}","received_events_url":"https://api.github.com/users/rwrzesien/received_events","type":"User","site_admin":false},"body":"Resolves https://github.com/golemfactory/concent/issues/221.","created_at":"2018-04-19T12:47:37Z","updated_at":"2018-05-09T07:27:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f06dd02a94fba2be9f3842ef8b11f645df77caeb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cameel","id":137030,"avatar_url":"https://avatars3.githubusercontent.com/u/137030?v=4","gravatar_id":"","url":"https://api.github.com/users/cameel","html_url":"https://github.com/cameel","followers_url":"https://api.github.com/users/cameel/followers","following_url":"https://api.github.com/users/cameel/following{/other_user}","gists_url":"https://api.github.com/users/cameel/gists{/gist_id}","starred_url":"https://api.github.com/users/cameel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameel/subscriptions","organizations_url":"https://api.github.com/users/cameel/orgs","repos_url":"https://api.github.com/users/cameel/repos","events_url":"https://api.github.com/users/cameel/events{/privacy}","received_events_url":"https://api.github.com/users/cameel/received_events","type":"User","site_admin":false},{"login":"Jakub89","id":20682491,"avatar_url":"https://avatars2.githubusercontent.com/u/20682491?v=4","gravatar_id":"","url":"https://api.github.com/users/Jakub89","html_url":"https://github.com/Jakub89","followers_url":"https://api.github.com/users/Jakub89/followers","following_url":"https://api.github.com/users/Jakub89/following{/other_user}","gists_url":"https://api.github.com/users/Jakub89/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakub89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakub89/subscriptions","organizations_url":"https://api.github.com/users/Jakub89/orgs","repos_url":"https://api.github.com/users/Jakub89/repos","events_url":"https://api.github.com/users/Jakub89/events{/privacy}","received_events_url":"https://api.github.com/users/Jakub89/received_events","type":"User","site_admin":false},{"login":"kbeker","id":26469852,"avatar_url":"https://avatars3.githubusercontent.com/u/26469852?v=4","gravatar_id":"","url":"https://api.github.com/users/kbeker","html_url":"https://github.com/kbeker","followers_url":"https://api.github.com/users/kbeker/followers","following_url":"https://api.github.com/users/kbeker/following{/other_user}","gists_url":"https://api.github.com/users/kbeker/gists{/gist_id}","starred_url":"https://api.github.com/users/kbeker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbeker/subscriptions","organizations_url":"https://api.github.com/users/kbeker/orgs","repos_url":"https://api.github.com/users/kbeker/repos","events_url":"https://api.github.com/users/kbeker/events{/privacy}","received_events_url":"https://api.github.com/users/kbeker/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":895466964,"url":"https://api.github.com/repos/golemfactory/concent/labels/urgent","name":"urgent","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/golemfactory/concent/pulls/303/commits","review_comments_url":"https://api.github.com/repos/golemfactory/concent/pulls/303/comments","review_comment_url":"https://api.github.com/repos/golemfactory/concent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/golemfactory/concent/issues/303/comments","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/8835e6ff34f8fbb1e68d41bc1d0f056a0d99405c","head":{"label":"golemfactory:feature-verification-verifier-downloading-files-from-the-storage-server","ref":"feature-verification-verifier-downloading-files-from-the-storage-server","sha":"8835e6ff34f8fbb1e68d41bc1d0f056a0d99405c","user":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":108836885,"name":"concent","full_name":"golemfactory/concent","owner":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golemfactory/concent","description":"Repository for Concent Service sources","fork":false,"url":"https://api.github.com/repos/golemfactory/concent","forks_url":"https://api.github.com/repos/golemfactory/concent/forks","keys_url":"https://api.github.com/repos/golemfactory/concent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/concent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/concent/teams","hooks_url":"https://api.github.com/repos/golemfactory/concent/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/concent/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/concent/events","assignees_url":"https://api.github.com/repos/golemfactory/concent/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/concent/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/concent/tags","blobs_url":"https://api.github.com/repos/golemfactory/concent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/concent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/concent/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/concent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/concent/languages","stargazers_url":"https://api.github.com/repos/golemfactory/concent/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/concent/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/concent/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/concent/subscription","commits_url":"https://api.github.com/repos/golemfactory/concent/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/concent/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/concent/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/concent/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/concent/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/concent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/concent/merges","archive_url":"https://api.github.com/repos/golemfactory/concent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/concent/downloads","issues_url":"https://api.github.com/repos/golemfactory/concent/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/concent/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/concent/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/concent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/concent/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/concent/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/concent/deployments","created_at":"2017-10-30T10:41:44Z","updated_at":"2018-05-09T00:26:10Z","pushed_at":"2018-05-09T06:30:56Z","git_url":"git://github.com/golemfactory/concent.git","ssh_url":"git@github.com:golemfactory/concent.git","clone_url":"https://github.com/golemfactory/concent.git","svn_url":"https://github.com/golemfactory/concent","homepage":null,"size":1228,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":61,"license":null,"forks":0,"open_issues":61,"watchers":2,"default_branch":"master"}},"base":{"label":"golemfactory:master","ref":"master","sha":"87a7a14cd941a5ba7663b13e85c7c7534633e8d7","user":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":108836885,"name":"concent","full_name":"golemfactory/concent","owner":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golemfactory/concent","description":"Repository for Concent Service sources","fork":false,"url":"https://api.github.com/repos/golemfactory/concent","forks_url":"https://api.github.com/repos/golemfactory/concent/forks","keys_url":"https://api.github.com/repos/golemfactory/concent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/concent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/concent/teams","hooks_url":"https://api.github.com/repos/golemfactory/concent/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/concent/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/concent/events","assignees_url":"https://api.github.com/repos/golemfactory/concent/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/concent/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/concent/tags","blobs_url":"https://api.github.com/repos/golemfactory/concent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/concent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/concent/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/concent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/concent/languages","stargazers_url":"https://api.github.com/repos/golemfactory/concent/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/concent/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/concent/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/concent/subscription","commits_url":"https://api.github.com/repos/golemfactory/concent/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/concent/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/concent/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/concent/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/concent/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/concent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/concent/merges","archive_url":"https://api.github.com/repos/golemfactory/concent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/concent/downloads","issues_url":"https://api.github.com/repos/golemfactory/concent/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/concent/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/concent/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/concent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/concent/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/concent/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/concent/deployments","created_at":"2017-10-30T10:41:44Z","updated_at":"2018-05-09T00:26:10Z","pushed_at":"2018-05-09T06:30:56Z","git_url":"git://github.com/golemfactory/concent.git","ssh_url":"git@github.com:golemfactory/concent.git","clone_url":"https://github.com/golemfactory/concent.git","svn_url":"https://github.com/golemfactory/concent","homepage":null,"size":1228,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":61,"license":null,"forks":0,"open_issues":61,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/303"},"html":{"href":"https://github.com/golemfactory/concent/pull/303"},"issue":{"href":"https://api.github.com/repos/golemfactory/concent/issues/303"},"comments":{"href":"https://api.github.com/repos/golemfactory/concent/issues/303/comments"},"review_comments":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/303/comments"},"review_comment":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/303/commits"},"statuses":{"href":"https://api.github.com/repos/golemfactory/concent/statuses/8835e6ff34f8fbb1e68d41bc1d0f056a0d99405c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dybi"}}