{"action":"created","comment":{"url":"https://api.github.com/repos/percona/pmm-managed/pulls/comments/232542972","pull_request_review_id":173760885,"id":232542972,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjU0Mjk3Mg==","diff_hunk":"@@ -0,0 +1,105 @@\n+// pmm-managed\n+// Copyright (C) 2017 Percona LLC\n+//\n+// This program is free software: you can redistribute it and/or modify\n+// it under the terms of the GNU Affero General Public License as published by\n+// the Free Software Foundation, either version 3 of the License, or\n+// (at your option) any later version.\n+//\n+// This program is distributed in the hope that it will be useful,\n+// but WITHOUT ANY WARRANTY; without even the implied warranty of\n+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+// GNU Affero General Public License for more details.\n+//\n+// You should have received a copy of the GNU Affero General Public License\n+// along with this program. If not, see <https://www.gnu.org/licenses/>.\n+\n+package handlers\n+\n+import (\n+\t\"context\"\n+\n+\t\"github.com/percona/pmm/api/inventory\"\n+\n+\t\"github.com/percona/pmm-managed/services/agents\"\n+)\n+\n+type NodesServer struct {\n+\tStore  *agents.Store\n+\tAgents map[uint32]*agents.Conn\n+}\n+\n+func (s *NodesServer) ListNodes(ctx context.Context, req *inventory.ListNodesRequest) (*inventory.ListNodesResponse, error) {\n+\tpanic(\"not implemented\")\n+}\n+\n+func (s *NodesServer) GetNode(ctx context.Context, req *inventory.GetNodeRequest) (*inventory.GetNodeResponse, error) {\n+\tpanic(\"not implemented\")\n+}\n+\n+func (s *NodesServer) AddNode(ctx context.Context, req *inventory.AddNodeRequest) (*inventory.AddNodeResponse, error) {\n+\tpanic(\"not implemented\")\n+}\n+\n+func (s *NodesServer) AddRemoveNode(ctx context.Context, req *inventory.AddRemoveNodeRequest) (*inventory.AddRemoveNodeResponse, error) {\n+\tpanic(\"not implemented\")\n+}\n+\n+func (s *NodesServer) AddRDSNode(ctx context.Context, req *inventory.AddRDSNodeRequest) (*inventory.AddRDSNodeResponse, error) {\n+\tpanic(\"not implemented\")\n+}\n+\n+func (s *NodesServer) RemoveNode(ctx context.Context, req *inventory.RemoveNodeRequest) (*inventory.RemoveNodeResponse, error) {\n+\tpanic(\"not implemented\")\n+}\n+\n+// func (s *NodesServer) List(ctx context.Context, req *inventory.NodesListRequest) (*inventory.NodesListResponse, error) {\n+// \tlogger.Get(ctx).Infof(\"%#v\", req)\n+// \treturn &inventory.NodesListResponse{\n+// \t\tNode: []*inventory.Node{\n+// \t\t\t{\n+// \t\t\t\tId: 1,\n+// \t\t\t},\n+// \t\t},\n+// \t\tBareMetal: []*inventory.BareMetalNode{\n+// \t\t\t{\n+// \t\t\t\tId: 2,\n+// \t\t\t},\n+// \t\t},\n+// \t\tContainer: []*inventory.ContainerNode{\n+// \t\t\t{\n+// \t\t\t\tId: 3,\n+// \t\t\t},\n+// \t\t},\n+// \t}, nil\n+// }\n+\n+// func (s *NodesServer) Get(ctx context.Context, req *inventory.NodesGetRequest) (*inventory.NodesGetResponse, error) {\n+// \tlogger.Get(ctx).Infof(\"%#v\", req)\n+// \treturn &inventory.NodesGetResponse{\n+// \t\tOnlyOne: &inventory.NodesGetResponse_BareMetal{\n+// \t\t\tBareMetal: &inventory.BareMetalNode{\n+// \t\t\t\tId: 1,\n+// \t\t\t},\n+// \t\t},\n+// \t}, nil\n+// }\n+\n+// func (s *NodesServer) AddBareMetal(ctx context.Context, req *inventory.AddBareMetalRequest) (*inventory.AddBareMetalResponse, error) {\n+// \tnode := s.Store.AddBareMetalNode(req)\n+// \treturn &inventory.AddBareMetalResponse{\n+// \t\tNode: node,\n+// \t}, nil\n+// }\n+\n+// func (s *NodesServer) AddMySQLdExporter(ctx context.Context, req *inventory.AddMySQLdExporterRequest) (*inventory.AddMySQLdExporterResponse, error) {","path":"handlers/inventory_nodes.go","position":95,"original_position":95,"commit_id":"38de573956845d9bc8b5733294b7ff1057a37642","original_commit_id":"38de573956845d9bc8b5733294b7ff1057a37642","user":{"login":"golangcibot","id":42910462,"node_id":"MDQ6VXNlcjQyOTEwNDYy","avatar_url":"https://avatars1.githubusercontent.com/u/42910462?v=4","gravatar_id":"","url":"https://api.github.com/users/golangcibot","html_url":"https://github.com/golangcibot","followers_url":"https://api.github.com/users/golangcibot/followers","following_url":"https://api.github.com/users/golangcibot/following{/other_user}","gists_url":"https://api.github.com/users/golangcibot/gists{/gist_id}","starred_url":"https://api.github.com/users/golangcibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golangcibot/subscriptions","organizations_url":"https://api.github.com/users/golangcibot/orgs","repos_url":"https://api.github.com/users/golangcibot/repos","events_url":"https://api.github.com/users/golangcibot/events{/privacy}","received_events_url":"https://api.github.com/users/golangcibot/received_events","type":"User","site_admin":false},"body":"line is 152 characters","created_at":"2018-11-12T06:09:15Z","updated_at":"2018-11-12T06:09:16Z","html_url":"https://github.com/percona/pmm-managed/pull/81#discussion_r232542972","pull_request_url":"https://api.github.com/repos/percona/pmm-managed/pulls/81","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/percona/pmm-managed/pulls/comments/232542972"},"html":{"href":"https://github.com/percona/pmm-managed/pull/81#discussion_r232542972"},"pull_request":{"href":"https://api.github.com/repos/percona/pmm-managed/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/percona/pmm-managed/pulls/81","id":230027318,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDI3MzE4","html_url":"https://github.com/percona/pmm-managed/pull/81","diff_url":"https://github.com/percona/pmm-managed/pull/81.diff","patch_url":"https://github.com/percona/pmm-managed/pull/81.patch","issue_url":"https://api.github.com/repos/percona/pmm-managed/issues/81","number":81,"state":"open","locked":false,"title":"a normal user privileges version","user":{"login":"naughtyGitCat","id":20264659,"node_id":"MDQ6VXNlcjIwMjY0NjU5","avatar_url":"https://avatars2.githubusercontent.com/u/20264659?v=4","gravatar_id":"","url":"https://api.github.com/users/naughtyGitCat","html_url":"https://github.com/naughtyGitCat","followers_url":"https://api.github.com/users/naughtyGitCat/followers","following_url":"https://api.github.com/users/naughtyGitCat/following{/other_user}","gists_url":"https://api.github.com/users/naughtyGitCat/gists{/gist_id}","starred_url":"https://api.github.com/users/naughtyGitCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naughtyGitCat/subscriptions","organizations_url":"https://api.github.com/users/naughtyGitCat/orgs","repos_url":"https://api.github.com/users/naughtyGitCat/repos","events_url":"https://api.github.com/users/naughtyGitCat/events{/privacy}","received_events_url":"https://api.github.com/users/naughtyGitCat/received_events","type":"User","site_admin":false},"body":"In some situation, the dba does not have a root privilege account.\r\nHow about a normal user privileges version, by which, we can start exporters manually or startup scripts.","created_at":"2018-11-12T06:08:21Z","updated_at":"2018-11-12T06:09:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74771c91a720a71be339f85bf0f914bb335fb6b0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AlekSi","id":11512,"node_id":"MDQ6VXNlcjExNTEy","avatar_url":"https://avatars1.githubusercontent.com/u/11512?v=4","gravatar_id":"","url":"https://api.github.com/users/AlekSi","html_url":"https://github.com/AlekSi","followers_url":"https://api.github.com/users/AlekSi/followers","following_url":"https://api.github.com/users/AlekSi/following{/other_user}","gists_url":"https://api.github.com/users/AlekSi/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekSi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekSi/subscriptions","organizations_url":"https://api.github.com/users/AlekSi/orgs","repos_url":"https://api.github.com/users/AlekSi/repos","events_url":"https://api.github.com/users/AlekSi/events{/privacy}","received_events_url":"https://api.github.com/users/AlekSi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/pmm-managed/pulls/81/commits","review_comments_url":"https://api.github.com/repos/percona/pmm-managed/pulls/81/comments","review_comment_url":"https://api.github.com/repos/percona/pmm-managed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/pmm-managed/issues/81/comments","statuses_url":"https://api.github.com/repos/percona/pmm-managed/statuses/38de573956845d9bc8b5733294b7ff1057a37642","head":{"label":"naughtyGitCat:PMM-2.0","ref":"PMM-2.0","sha":"38de573956845d9bc8b5733294b7ff1057a37642","user":{"login":"naughtyGitCat","id":20264659,"node_id":"MDQ6VXNlcjIwMjY0NjU5","avatar_url":"https://avatars2.githubusercontent.com/u/20264659?v=4","gravatar_id":"","url":"https://api.github.com/users/naughtyGitCat","html_url":"https://github.com/naughtyGitCat","followers_url":"https://api.github.com/users/naughtyGitCat/followers","following_url":"https://api.github.com/users/naughtyGitCat/following{/other_user}","gists_url":"https://api.github.com/users/naughtyGitCat/gists{/gist_id}","starred_url":"https://api.github.com/users/naughtyGitCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naughtyGitCat/subscriptions","organizations_url":"https://api.github.com/users/naughtyGitCat/orgs","repos_url":"https://api.github.com/users/naughtyGitCat/repos","events_url":"https://api.github.com/users/naughtyGitCat/events{/privacy}","received_events_url":"https://api.github.com/users/naughtyGitCat/received_events","type":"User","site_admin":false},"repo":{"id":157163334,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcxNjMzMzQ=","name":"pmm-managed","full_name":"naughtyGitCat/pmm-managed","private":false,"owner":{"login":"naughtyGitCat","id":20264659,"node_id":"MDQ6VXNlcjIwMjY0NjU5","avatar_url":"https://avatars2.githubusercontent.com/u/20264659?v=4","gravatar_id":"","url":"https://api.github.com/users/naughtyGitCat","html_url":"https://github.com/naughtyGitCat","followers_url":"https://api.github.com/users/naughtyGitCat/followers","following_url":"https://api.github.com/users/naughtyGitCat/following{/other_user}","gists_url":"https://api.github.com/users/naughtyGitCat/gists{/gist_id}","starred_url":"https://api.github.com/users/naughtyGitCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naughtyGitCat/subscriptions","organizations_url":"https://api.github.com/users/naughtyGitCat/orgs","repos_url":"https://api.github.com/users/naughtyGitCat/repos","events_url":"https://api.github.com/users/naughtyGitCat/events{/privacy}","received_events_url":"https://api.github.com/users/naughtyGitCat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/naughtyGitCat/pmm-managed","description":"pmm-managed manages configuration of PMM server components and exposes API for that.","fork":true,"url":"https://api.github.com/repos/naughtyGitCat/pmm-managed","forks_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/forks","keys_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/teams","hooks_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/hooks","issue_events_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/issues/events{/number}","events_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/events","assignees_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/assignees{/user}","branches_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/branches{/branch}","tags_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/tags","blobs_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/git/refs{/sha}","trees_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/statuses/{sha}","languages_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/languages","stargazers_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/stargazers","contributors_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/contributors","subscribers_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/subscribers","subscription_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/subscription","commits_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/commits{/sha}","git_commits_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/git/commits{/sha}","comments_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/comments{/number}","issue_comment_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/issues/comments{/number}","contents_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/contents/{+path}","compare_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/merges","archive_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/downloads","issues_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/issues{/number}","pulls_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/pulls{/number}","milestones_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/milestones{/number}","notifications_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/labels{/name}","releases_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/releases{/id}","deployments_url":"https://api.github.com/repos/naughtyGitCat/pmm-managed/deployments","created_at":"2018-11-12T05:55:25Z","updated_at":"2018-11-12T05:55:28Z","pushed_at":"2018-11-08T14:25:10Z","git_url":"git://github.com/naughtyGitCat/pmm-managed.git","ssh_url":"git@github.com:naughtyGitCat/pmm-managed.git","clone_url":"https://github.com/naughtyGitCat/pmm-managed.git","svn_url":"https://github.com/naughtyGitCat/pmm-managed","homepage":"","size":73544,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"percona:master","ref":"master","sha":"af8a7695e307e0a8a783d1bddd32c4e0265ebee9","user":{"login":"percona","id":1683025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODMwMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":97122795,"node_id":"MDEwOlJlcG9zaXRvcnk5NzEyMjc5NQ==","name":"pmm-managed","full_name":"percona/pmm-managed","private":false,"owner":{"login":"percona","id":1683025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODMwMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/percona/pmm-managed","description":"pmm-managed manages configuration of PMM server components and exposes API for that.","fork":false,"url":"https://api.github.com/repos/percona/pmm-managed","forks_url":"https://api.github.com/repos/percona/pmm-managed/forks","keys_url":"https://api.github.com/repos/percona/pmm-managed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/pmm-managed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/pmm-managed/teams","hooks_url":"https://api.github.com/repos/percona/pmm-managed/hooks","issue_events_url":"https://api.github.com/repos/percona/pmm-managed/issues/events{/number}","events_url":"https://api.github.com/repos/percona/pmm-managed/events","assignees_url":"https://api.github.com/repos/percona/pmm-managed/assignees{/user}","branches_url":"https://api.github.com/repos/percona/pmm-managed/branches{/branch}","tags_url":"https://api.github.com/repos/percona/pmm-managed/tags","blobs_url":"https://api.github.com/repos/percona/pmm-managed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/pmm-managed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/pmm-managed/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/pmm-managed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/pmm-managed/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/pmm-managed/languages","stargazers_url":"https://api.github.com/repos/percona/pmm-managed/stargazers","contributors_url":"https://api.github.com/repos/percona/pmm-managed/contributors","subscribers_url":"https://api.github.com/repos/percona/pmm-managed/subscribers","subscription_url":"https://api.github.com/repos/percona/pmm-managed/subscription","commits_url":"https://api.github.com/repos/percona/pmm-managed/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/pmm-managed/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/pmm-managed/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/pmm-managed/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/pmm-managed/contents/{+path}","compare_url":"https://api.github.com/repos/percona/pmm-managed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/pmm-managed/merges","archive_url":"https://api.github.com/repos/percona/pmm-managed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/pmm-managed/downloads","issues_url":"https://api.github.com/repos/percona/pmm-managed/issues{/number}","pulls_url":"https://api.github.com/repos/percona/pmm-managed/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/pmm-managed/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/pmm-managed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/pmm-managed/labels{/name}","releases_url":"https://api.github.com/repos/percona/pmm-managed/releases{/id}","deployments_url":"https://api.github.com/repos/percona/pmm-managed/deployments","created_at":"2017-07-13T12:58:40Z","updated_at":"2018-11-12T05:55:25Z","pushed_at":"2018-11-12T06:08:21Z","git_url":"git://github.com/percona/pmm-managed.git","ssh_url":"git@github.com:percona/pmm-managed.git","clone_url":"https://github.com/percona/pmm-managed.git","svn_url":"https://github.com/percona/pmm-managed","homepage":"","size":73544,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":4,"open_issues":3,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/pmm-managed/pulls/81"},"html":{"href":"https://github.com/percona/pmm-managed/pull/81"},"issue":{"href":"https://api.github.com/repos/percona/pmm-managed/issues/81"},"comments":{"href":"https://api.github.com/repos/percona/pmm-managed/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/pmm-managed/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/pmm-managed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/pmm-managed/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/percona/pmm-managed/statuses/38de573956845d9bc8b5733294b7ff1057a37642"}},"author_association":"NONE"}}
{"actor":{"display_login":"golangcibot"}}