{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45717","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45717/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45717/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45717/events","html_url":"https://github.com/NixOS/nixpkgs/pull/45717","id":354890257,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTQ3MTg4","number":45717,"title":"treewide: Deprecate platform aliases for 18.09","user":{"login":"Ericson2314","id":1055245,"node_id":"MDQ6VXNlcjEwNTUyNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1055245?v=4","gravatar_id":"","url":"https://api.github.com/users/Ericson2314","html_url":"https://github.com/Ericson2314","followers_url":"https://api.github.com/users/Ericson2314/followers","following_url":"https://api.github.com/users/Ericson2314/following{/other_user}","gists_url":"https://api.github.com/users/Ericson2314/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericson2314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericson2314/subscriptions","organizations_url":"https://api.github.com/users/Ericson2314/orgs","repos_url":"https://api.github.com/users/Ericson2314/repos","events_url":"https://api.github.com/users/Ericson2314/events{/privacy}","received_events_url":"https://api.github.com/users/Ericson2314/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":854046194,"node_id":"MDU6TGFiZWw4NTQwNDYxOTQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20portability","name":"6.topic: portability","color":"fef2c0","default":false},{"id":897230915,"node_id":"MDU6TGFiZWw4OTcyMzA5MTU=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20stdenv","name":"6.topic: stdenv","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NixOS/nixpkgs/milestones/13","html_url":"https://github.com/NixOS/nixpkgs/milestone/13","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones/13/labels","id":2676453,"node_id":"MDk6TWlsZXN0b25lMjY3NjQ1Mw==","number":13,"title":"18.09","description":"Nixpkgs/NixOS 18.09 stable release.\r\n\r\nRelease managers are @vcunat and @samueldr.","creator":{"login":"globin","id":1447245,"node_id":"MDQ6VXNlcjE0NDcyNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1447245?v=4","gravatar_id":"","url":"https://api.github.com/users/globin","html_url":"https://github.com/globin","followers_url":"https://api.github.com/users/globin/followers","following_url":"https://api.github.com/users/globin/following{/other_user}","gists_url":"https://api.github.com/users/globin/gists{/gist_id}","starred_url":"https://api.github.com/users/globin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globin/subscriptions","organizations_url":"https://api.github.com/users/globin/orgs","repos_url":"https://api.github.com/users/globin/repos","events_url":"https://api.github.com/users/globin/events{/privacy}","received_events_url":"https://api.github.com/users/globin/received_events","type":"User","site_admin":false},"open_issues":104,"closed_issues":66,"state":"open","created_at":"2017-08-02T12:18:49Z","updated_at":"2018-09-06T14:17:57Z","due_on":"2018-09-27T07:00:00Z","closed_at":null},"comments":60,"created_at":"2018-08-28T20:26:01Z","updated_at":"2018-09-06T14:22:21Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45717","html_url":"https://github.com/NixOS/nixpkgs/pull/45717","diff_url":"https://github.com/NixOS/nixpkgs/pull/45717.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/45717.patch"},"body":"The first commit is succinct and does the depredations. You can just read it, but they are:\r\n\r\n1. Left in this PR.\r\n   ```\r\n   system ==> stdenv.buildPlatform.system\r\n   ```\r\n2. Left in this PR.\r\n   ```\r\n   stdenv.system ==> stdenv.buildPlatform.system\r\n   ```\r\n3. Proposed in other open PR.\r\n   ```\r\n   configureFlags = \"--foo --bar\"; ==> configureFlags = [ \"--foo\" \"--bar\" ];\r\n   ```\r\n4. Message improved in other PR\r\n   ```\r\n   isArm ==> isAarch32 # Already done during 18.03\r\n   ```\r\n5. Done in other PR\r\n   ```\r\n   buildPlatform ==> stdenv.buildPlatform\r\n   ```\r\n6. Done in other PR\r\n   ```\r\n   hostPlatform ==> stdenv.hostPlatform\r\n   ```\r\n7. Done in other PR\r\n   ```\r\n   targetPlatform ==> stdenv.targetPlatform\r\n   ```\r\n\r\nThe rest make Nixpkgs itself comply. If this is accepted, sometime after 18.09 is forked I'll merge another PR to actually remove them.\r\n\r\n###### Motivation for this change\r\n\r\nSee #27069. This makes there be only one non-deprecated way to inspect the build/host/target platform in most cases. `stdenv.is*` is kept, unlike as in in the issue, since it is the most popular and already a shorthand.\r\n\r\nThe `configureFlags` change is unrelated except I earlier did the work of making nixpkgs obey it. It would be nice to deprecate that too so the work doesn't just bit-rot away.\r\n\r\n###### Things done\r\n\r\nNo hashes should be changed.\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/419111949","html_url":"https://github.com/NixOS/nixpkgs/pull/45717#issuecomment-419111949","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45717","id":419111949,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTExMTk0OQ==","user":{"login":"GrahamcOfBorg","id":25447658,"node_id":"MDQ6VXNlcjI1NDQ3NjU4","avatar_url":"https://avatars2.githubusercontent.com/u/25447658?v=4","gravatar_id":"","url":"https://api.github.com/users/GrahamcOfBorg","html_url":"https://github.com/GrahamcOfBorg","followers_url":"https://api.github.com/users/GrahamcOfBorg/followers","following_url":"https://api.github.com/users/GrahamcOfBorg/following{/other_user}","gists_url":"https://api.github.com/users/GrahamcOfBorg/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamcOfBorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamcOfBorg/subscriptions","organizations_url":"https://api.github.com/users/GrahamcOfBorg/orgs","repos_url":"https://api.github.com/users/GrahamcOfBorg/repos","events_url":"https://api.github.com/users/GrahamcOfBorg/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamcOfBorg/received_events","type":"User","site_admin":false},"created_at":"2018-09-06T14:22:21Z","updated_at":"2018-09-06T14:22:21Z","author_association":"NONE","body":"<!--REQUEST_ID=51b29698-e548-40a0-ae8f-56d8b8de7b16-->\nSuccess on x86_64-darwin [(full log)](https://logs.nix.ci/?key=nixos/nixpkgs.45717&attempt_id=92a94c95-3265-4aa3-b0d1-6388888ff924)\n\nAttempted: stdenv\n\n<details><summary>Partial log (click to expand)</summary><p>\n\n```\n/nix/store/95bw3cdcgc8c0rrvqwvhvc805pdv7rmx-stdenv-darwin\n```\n</p></details>\n\n"}}
{"actor":{"display_login":"GrahamcOfBorg"}}