{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/204973999","pull_request_review_id":140152533,"id":204973999,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDk3Mzk5OQ==","diff_hunk":"@@ -40,7 +40,7 @@ class RefArray<T> {\n // elements should be a nop.\n @inline(never)\n func genEnumArray() {\n-  _ = RefArray<Int?>(3)\n+  blackHole(RefArray<Int?>(3))\n   // should be a nop","path":"benchmark/single-source/ArrayOfGenericPOD.swift","position":6,"original_position":6,"commit_id":"bd43d54b99ca3390ebbbb3921a71c0aff7a61982","original_commit_id":"8876c24104b92be841634f8a937bae673097fc5d","user":{"login":"eeckstein","id":15270291,"node_id":"MDQ6VXNlcjE1MjcwMjkx","avatar_url":"https://avatars0.githubusercontent.com/u/15270291?v=4","gravatar_id":"","url":"https://api.github.com/users/eeckstein","html_url":"https://github.com/eeckstein","followers_url":"https://api.github.com/users/eeckstein/followers","following_url":"https://api.github.com/users/eeckstein/following{/other_user}","gists_url":"https://api.github.com/users/eeckstein/gists{/gist_id}","starred_url":"https://api.github.com/users/eeckstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeckstein/subscriptions","organizations_url":"https://api.github.com/users/eeckstein/orgs","repos_url":"https://api.github.com/users/eeckstein/repos","events_url":"https://api.github.com/users/eeckstein/events{/privacy}","received_events_url":"https://api.github.com/users/eeckstein/received_events","type":"User","site_admin":false},"body":"I _think_ it means that it's expected that the optimizer removes everything. I'm not sure if this makes sense.","created_at":"2018-07-25T03:48:57Z","updated_at":"2018-07-25T03:48:58Z","html_url":"https://github.com/apple/swift/pull/18096#discussion_r204973999","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/18096","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/204973999"},"html":{"href":"https://github.com/apple/swift/pull/18096#discussion_r204973999"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/18096"}},"in_reply_to_id":204973729},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/18096","id":202717067,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzE3MDY3","html_url":"https://github.com/apple/swift/pull/18096","diff_url":"https://github.com/apple/swift/pull/18096.diff","patch_url":"https://github.com/apple/swift/pull/18096.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/18096","number":18096,"state":"open","locked":false,"title":"benchmarks: make benchmarks more stable","user":{"login":"eeckstein","id":15270291,"node_id":"MDQ6VXNlcjE1MjcwMjkx","avatar_url":"https://avatars0.githubusercontent.com/u/15270291?v=4","gravatar_id":"","url":"https://api.github.com/users/eeckstein","html_url":"https://github.com/eeckstein","followers_url":"https://api.github.com/users/eeckstein/followers","following_url":"https://api.github.com/users/eeckstein/following{/other_user}","gists_url":"https://api.github.com/users/eeckstein/gists{/gist_id}","starred_url":"https://api.github.com/users/eeckstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeckstein/subscriptions","organizations_url":"https://api.github.com/users/eeckstein/orgs","repos_url":"https://api.github.com/users/eeckstein/repos","events_url":"https://api.github.com/users/eeckstein/events{/privacy}","received_events_url":"https://api.github.com/users/eeckstein/received_events","type":"User","site_admin":false},"body":"The time per iteration should roughly stay constant and not depend on the number of iterations.\r\n\r\n*) for benchmarks with a significant setup time, move the setup to the setUpFunction\r\n*) some benchmarks wrongly executed the loop N+1 times (\"0...N\" instead of \"0..<N\")\r\n*) added some blackHole calls to prevent the optimizer removing important parts of a benchmark\r\n*) lowered the workload for the CSVParsing benchmarks because 1 single iteration took too long\r\n*) moved the setup and teardown function calls outside the sample loop\r\n\r\nFor a few benchmarks this changed the benchmark score. I renamed those benchmarks so that they are now treated as \"new\" benchmarks.\r\n","created_at":"2018-07-20T00:24:15Z","updated_at":"2018-07-25T03:48:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80d4d00a2820d3a7b4d5d7be70fd73fbfa8f2033","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/18096/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/18096/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/18096/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/bd43d54b99ca3390ebbbb3921a71c0aff7a61982","head":{"label":"eeckstein:fix-benchmark-iteration-times","ref":"fix-benchmark-iteration-times","sha":"bd43d54b99ca3390ebbbb3921a71c0aff7a61982","user":{"login":"eeckstein","id":15270291,"node_id":"MDQ6VXNlcjE1MjcwMjkx","avatar_url":"https://avatars0.githubusercontent.com/u/15270291?v=4","gravatar_id":"","url":"https://api.github.com/users/eeckstein","html_url":"https://github.com/eeckstein","followers_url":"https://api.github.com/users/eeckstein/followers","following_url":"https://api.github.com/users/eeckstein/following{/other_user}","gists_url":"https://api.github.com/users/eeckstein/gists{/gist_id}","starred_url":"https://api.github.com/users/eeckstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeckstein/subscriptions","organizations_url":"https://api.github.com/users/eeckstein/orgs","repos_url":"https://api.github.com/users/eeckstein/repos","events_url":"https://api.github.com/users/eeckstein/events{/privacy}","received_events_url":"https://api.github.com/users/eeckstein/received_events","type":"User","site_admin":false},"repo":{"id":52555464,"node_id":"MDEwOlJlcG9zaXRvcnk1MjU1NTQ2NA==","name":"swift","full_name":"eeckstein/swift","owner":{"login":"eeckstein","id":15270291,"node_id":"MDQ6VXNlcjE1MjcwMjkx","avatar_url":"https://avatars0.githubusercontent.com/u/15270291?v=4","gravatar_id":"","url":"https://api.github.com/users/eeckstein","html_url":"https://github.com/eeckstein","followers_url":"https://api.github.com/users/eeckstein/followers","following_url":"https://api.github.com/users/eeckstein/following{/other_user}","gists_url":"https://api.github.com/users/eeckstein/gists{/gist_id}","starred_url":"https://api.github.com/users/eeckstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeckstein/subscriptions","organizations_url":"https://api.github.com/users/eeckstein/orgs","repos_url":"https://api.github.com/users/eeckstein/repos","events_url":"https://api.github.com/users/eeckstein/events{/privacy}","received_events_url":"https://api.github.com/users/eeckstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eeckstein/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/eeckstein/swift","forks_url":"https://api.github.com/repos/eeckstein/swift/forks","keys_url":"https://api.github.com/repos/eeckstein/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eeckstein/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eeckstein/swift/teams","hooks_url":"https://api.github.com/repos/eeckstein/swift/hooks","issue_events_url":"https://api.github.com/repos/eeckstein/swift/issues/events{/number}","events_url":"https://api.github.com/repos/eeckstein/swift/events","assignees_url":"https://api.github.com/repos/eeckstein/swift/assignees{/user}","branches_url":"https://api.github.com/repos/eeckstein/swift/branches{/branch}","tags_url":"https://api.github.com/repos/eeckstein/swift/tags","blobs_url":"https://api.github.com/repos/eeckstein/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eeckstein/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eeckstein/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/eeckstein/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eeckstein/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/eeckstein/swift/languages","stargazers_url":"https://api.github.com/repos/eeckstein/swift/stargazers","contributors_url":"https://api.github.com/repos/eeckstein/swift/contributors","subscribers_url":"https://api.github.com/repos/eeckstein/swift/subscribers","subscription_url":"https://api.github.com/repos/eeckstein/swift/subscription","commits_url":"https://api.github.com/repos/eeckstein/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/eeckstein/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/eeckstein/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/eeckstein/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/eeckstein/swift/contents/{+path}","compare_url":"https://api.github.com/repos/eeckstein/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eeckstein/swift/merges","archive_url":"https://api.github.com/repos/eeckstein/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eeckstein/swift/downloads","issues_url":"https://api.github.com/repos/eeckstein/swift/issues{/number}","pulls_url":"https://api.github.com/repos/eeckstein/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/eeckstein/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/eeckstein/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eeckstein/swift/labels{/name}","releases_url":"https://api.github.com/repos/eeckstein/swift/releases{/id}","deployments_url":"https://api.github.com/repos/eeckstein/swift/deployments","created_at":"2016-02-25T20:42:45Z","updated_at":"2016-02-25T20:43:11Z","pushed_at":"2018-07-25T03:24:42Z","git_url":"git://github.com/eeckstein/swift.git","ssh_url":"git@github.com:eeckstein/swift.git","clone_url":"https://github.com/eeckstein/swift.git","svn_url":"https://github.com/eeckstein/swift","homepage":"https://swift.org/","size":291186,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"c2f9a2ae5d690aa9d3e05f8e88af38afe111b4ca","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-07-25T02:50:25Z","pushed_at":"2018-07-25T03:48:00Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":316747,"stargazers_count":44639,"watchers_count":44639,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7039,"mirror_url":null,"archived":false,"open_issues_count":371,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7039,"open_issues":371,"watchers":44639,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/18096"},"html":{"href":"https://github.com/apple/swift/pull/18096"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/18096"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/18096/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/18096/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/18096/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/bd43d54b99ca3390ebbbb3921a71c0aff7a61982"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eeckstein"}}