{"action":"created","comment":{"url":"https://api.github.com/repos/strimzi/strimzi/pulls/comments/191436697","pull_request_review_id":124007223,"id":191436697,"diff_hunk":"@@ -382,4 +382,30 @@ public void testForTopicOperator() {\n         List<String> topics = listTopicsUsingPodCLI(CLUSTER_NAME, kafkaPodName(CLUSTER_NAME, 1));\n         assertThat(topics, not(hasItems(\"topic-from-cli\", \"my-topic\")));\n     }\n+\n+    @Test\n+    @JUnitGroup(name = \"regression\")\n+    @KafkaCluster(name = CLUSTER_NAME,\n+            kafkaNodes = 1,\n+            zkNodes = 1,\n+            config = {\n+                    @CmData(key = \"kafka-rack\",\n+                            value = \"{\\\"topologyKey\\\": \\\"rack-key\\\"}\")\n+            })\n+    public void testRackAware() {\n+\n+        String cm = kubeClient.get(\"cm\", CLUSTER_NAME);\n+        assertThat(cm, valueOfCmEquals(\"kafka-rack\", \"{\\\"topologyKey\\\": \\\"rack-key\\\"}\"));\n+\n+        kubeClient.waitForStatefulSet(kafkaClusterName(CLUSTER_NAME), 1);\n+        String kafkaPodName = kafkaPodName(CLUSTER_NAME, 0);\n+        kubeClient.waitForPod(kafkaPodName);\n+\n+        String out = kubeClient.exec(kafkaPodName, \"cat /opt/kafka/rack/rack.id\").out();","path":"systemtest/src/test/java/io/strimzi/systemtest/KafkaClusterIT.java","position":23,"original_position":23,"commit_id":"4b3c3804d251819edd800adc4b5fadab2b651b79","original_commit_id":"4b3c3804d251819edd800adc4b5fadab2b651b79","user":{"login":"scholzj","id":5658439,"avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"body":"Wouldn't it be better to also check the Kafka config file? That would check that the input (`/opt/kafka/rack/rack.id`) is properly used for the config.","created_at":"2018-05-29T14:05:05Z","updated_at":"2018-05-29T14:05:19Z","html_url":"https://github.com/strimzi/strimzi/pull/469#discussion_r191436697","pull_request_url":"https://api.github.com/repos/strimzi/strimzi/pulls/469","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/comments/191436697"},"html":{"href":"https://github.com/strimzi/strimzi/pull/469#discussion_r191436697"},"pull_request":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/469"}}},"pull_request":{"url":"https://api.github.com/repos/strimzi/strimzi/pulls/469","id":191155294,"html_url":"https://github.com/strimzi/strimzi/pull/469","diff_url":"https://github.com/strimzi/strimzi/pull/469.diff","patch_url":"https://github.com/strimzi/strimzi/pull/469.patch","issue_url":"https://api.github.com/repos/strimzi/strimzi/issues/469","number":469,"state":"open","locked":false,"title":"Rack support system test","user":{"login":"ppatierno","id":5842311,"avatar_url":"https://avatars0.githubusercontent.com/u/5842311?v=4","gravatar_id":"","url":"https://api.github.com/users/ppatierno","html_url":"https://github.com/ppatierno","followers_url":"https://api.github.com/users/ppatierno/followers","following_url":"https://api.github.com/users/ppatierno/following{/other_user}","gists_url":"https://api.github.com/users/ppatierno/gists{/gist_id}","starred_url":"https://api.github.com/users/ppatierno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppatierno/subscriptions","organizations_url":"https://api.github.com/users/ppatierno/orgs","repos_url":"https://api.github.com/users/ppatierno/repos","events_url":"https://api.github.com/users/ppatierno/events{/privacy}","received_events_url":"https://api.github.com/users/ppatierno/received_events","type":"User","site_admin":false},"body":"Added system tests for rack aware cluster\r\n\r\n### Type of change\r\n\r\n- Enhancement / new feature\r\n\r\n### Description\r\n\r\nThis PR adds a new system test for the rack aware feature.\r\nIn order to do that it also needs to label the minikube/minishift cluster node for having a label used as rack topology key during the related test.\r\n\r\n### Checklist\r\n\r\n_Please go through this checklist and make sure all applicable tasks have been done_\r\n\r\n- [ ] Write tests\r\n- [ ] Make sure all tests pass\r\n- [ ] Update documentation\r\n- [ ] Check RBAC rights for Kubernetes / OpenShift roles\r\n- [ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally\r\n- [ ] Reference relevant issue(s) and close them after merging\r\n\r\n","created_at":"2018-05-29T13:56:39Z","updated_at":"2018-05-29T14:05:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dc2a28223efb25d8702f8b002e5b72f559a3583","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/strimzi/strimzi/pulls/469/commits","review_comments_url":"https://api.github.com/repos/strimzi/strimzi/pulls/469/comments","review_comment_url":"https://api.github.com/repos/strimzi/strimzi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strimzi/strimzi/issues/469/comments","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/4b3c3804d251819edd800adc4b5fadab2b651b79","head":{"label":"strimzi:rack-support-test-update","ref":"rack-support-test-update","sha":"4b3c3804d251819edd800adc4b5fadab2b651b79","user":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"name":"strimzi","full_name":"strimzi/strimzi","owner":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strimzi/strimzi","description":"Apache Kafka running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi","forks_url":"https://api.github.com/repos/strimzi/strimzi/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-05-29T13:09:24Z","pushed_at":"2018-05-29T13:56:40Z","git_url":"git://github.com/strimzi/strimzi.git","ssh_url":"git@github.com:strimzi/strimzi.git","clone_url":"https://github.com/strimzi/strimzi.git","svn_url":"https://github.com/strimzi/strimzi","homepage":"http://strimzi.io/","size":10800,"stargazers_count":279,"watchers_count":279,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":55,"open_issues":66,"watchers":279,"default_branch":"master"}},"base":{"label":"strimzi:master","ref":"master","sha":"ed3c3de26ccffc2d95fe01ec09d15138896852af","user":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"name":"strimzi","full_name":"strimzi/strimzi","owner":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strimzi/strimzi","description":"Apache Kafka running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi","forks_url":"https://api.github.com/repos/strimzi/strimzi/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-05-29T13:09:24Z","pushed_at":"2018-05-29T13:56:40Z","git_url":"git://github.com/strimzi/strimzi.git","ssh_url":"git@github.com:strimzi/strimzi.git","clone_url":"https://github.com/strimzi/strimzi.git","svn_url":"https://github.com/strimzi/strimzi","homepage":"http://strimzi.io/","size":10800,"stargazers_count":279,"watchers_count":279,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":55,"open_issues":66,"watchers":279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/469"},"html":{"href":"https://github.com/strimzi/strimzi/pull/469"},"issue":{"href":"https://api.github.com/repos/strimzi/strimzi/issues/469"},"comments":{"href":"https://api.github.com/repos/strimzi/strimzi/issues/469/comments"},"review_comments":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/469/comments"},"review_comment":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/469/commits"},"statuses":{"href":"https://api.github.com/repos/strimzi/strimzi/statuses/4b3c3804d251819edd800adc4b5fadab2b651b79"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"scholzj"}}