{"action":"created","comment":{"url":"https://api.github.com/repos/xtermjs/xterm.js/pulls/comments/243784678","pull_request_review_id":187642777,"id":243784678,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc4NDY3OA==","diff_hunk":"@@ -12,6 +12,7 @@ import { FLAGS } from './renderer/Types';\n import { wcwidth } from './CharWidth';\n import { EscapeSequenceParser } from './EscapeSequenceParser';\n import { ICharset } from './core/Types';\n+import { IDisposable } from 'xterm';\n import { Disposable } from './common/Lifecycle';","path":"src/InputHandler.ts","position":5,"original_position":5,"commit_id":"48ff841d6ab23744570326201c4294a25ec16474","original_commit_id":"29cc0bf9334596fae33c922e80b24a11430c388f","user":{"login":"Tyriar","id":2193314,"node_id":"MDQ6VXNlcjIxOTMzMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2193314?v=4","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"body":"This is fine, `Disposable` just adds some niceties around disposing things inside a subclass","created_at":"2018-12-24T03:35:43Z","updated_at":"2018-12-24T03:35:43Z","html_url":"https://github.com/xtermjs/xterm.js/pull/1853#discussion_r243784678","pull_request_url":"https://api.github.com/repos/xtermjs/xterm.js/pulls/1853","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xtermjs/xterm.js/pulls/comments/243784678"},"html":{"href":"https://github.com/xtermjs/xterm.js/pull/1853#discussion_r243784678"},"pull_request":{"href":"https://api.github.com/repos/xtermjs/xterm.js/pulls/1853"}},"in_reply_to_id":243717517},"pull_request":{"url":"https://api.github.com/repos/xtermjs/xterm.js/pulls/1853","id":240551526,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTUxNTI2","html_url":"https://github.com/xtermjs/xterm.js/pull/1853","diff_url":"https://github.com/xtermjs/xterm.js/pull/1853.diff","patch_url":"https://github.com/xtermjs/xterm.js/pull/1853.patch","issue_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1853","number":1853,"state":"open","locked":false,"title":"hooks for custom control sequences (updated)","user":{"login":"PerBothner","id":10293361,"node_id":"MDQ6VXNlcjEwMjkzMzYx","avatar_url":"https://avatars2.githubusercontent.com/u/10293361?v=4","gravatar_id":"","url":"https://api.github.com/users/PerBothner","html_url":"https://github.com/PerBothner","followers_url":"https://api.github.com/users/PerBothner/followers","following_url":"https://api.github.com/users/PerBothner/following{/other_user}","gists_url":"https://api.github.com/users/PerBothner/gists{/gist_id}","starred_url":"https://api.github.com/users/PerBothner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerBothner/subscriptions","organizations_url":"https://api.github.com/users/PerBothner/orgs","repos_url":"https://api.github.com/users/PerBothner/repos","events_url":"https://api.github.com/users/PerBothner/events{/privacy}","received_events_url":"https://api.github.com/users/PerBothner/received_events","type":"User","site_admin":false},"body":"This is pull request #1813 is a separate branch as request.\r\nThat pull requst should probably be closed as a duplicate or something.\r\nThis pull request is still unnecessarily messy, as it includes commits that are just reverts of older commits.   The actual real commits are 8ceea112f7a4d11532b03d39a06d319c08c13f18 5af4626ec7d44f0536024a7a9af66b463ee5d7d9 8a5a03238fedded95e4cedfc9e80e3e0aec2ecc4 6b65ebd4aace41ddf0f7d663e5ff6c92a4a37948 .","created_at":"2018-12-21T18:53:08Z","updated_at":"2018-12-24T03:35:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09762922c1a93b0996f8c73694fed1cc440d4464","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xtermjs/xterm.js/pulls/1853/commits","review_comments_url":"https://api.github.com/repos/xtermjs/xterm.js/pulls/1853/comments","review_comment_url":"https://api.github.com/repos/xtermjs/xterm.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1853/comments","statuses_url":"https://api.github.com/repos/xtermjs/xterm.js/statuses/48ff841d6ab23744570326201c4294a25ec16474","head":{"label":"PerBothner:control-seq-handler","ref":"control-seq-handler","sha":"48ff841d6ab23744570326201c4294a25ec16474","user":{"login":"PerBothner","id":10293361,"node_id":"MDQ6VXNlcjEwMjkzMzYx","avatar_url":"https://avatars2.githubusercontent.com/u/10293361?v=4","gravatar_id":"","url":"https://api.github.com/users/PerBothner","html_url":"https://github.com/PerBothner","followers_url":"https://api.github.com/users/PerBothner/followers","following_url":"https://api.github.com/users/PerBothner/following{/other_user}","gists_url":"https://api.github.com/users/PerBothner/gists{/gist_id}","starred_url":"https://api.github.com/users/PerBothner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerBothner/subscriptions","organizations_url":"https://api.github.com/users/PerBothner/orgs","repos_url":"https://api.github.com/users/PerBothner/repos","events_url":"https://api.github.com/users/PerBothner/events{/privacy}","received_events_url":"https://api.github.com/users/PerBothner/received_events","type":"User","site_admin":false},"repo":{"id":160395782,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAzOTU3ODI=","name":"xterm.js","full_name":"PerBothner/xterm.js","private":false,"owner":{"login":"PerBothner","id":10293361,"node_id":"MDQ6VXNlcjEwMjkzMzYx","avatar_url":"https://avatars2.githubusercontent.com/u/10293361?v=4","gravatar_id":"","url":"https://api.github.com/users/PerBothner","html_url":"https://github.com/PerBothner","followers_url":"https://api.github.com/users/PerBothner/followers","following_url":"https://api.github.com/users/PerBothner/following{/other_user}","gists_url":"https://api.github.com/users/PerBothner/gists{/gist_id}","starred_url":"https://api.github.com/users/PerBothner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerBothner/subscriptions","organizations_url":"https://api.github.com/users/PerBothner/orgs","repos_url":"https://api.github.com/users/PerBothner/repos","events_url":"https://api.github.com/users/PerBothner/events{/privacy}","received_events_url":"https://api.github.com/users/PerBothner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PerBothner/xterm.js","description":"A terminal for the web","fork":true,"url":"https://api.github.com/repos/PerBothner/xterm.js","forks_url":"https://api.github.com/repos/PerBothner/xterm.js/forks","keys_url":"https://api.github.com/repos/PerBothner/xterm.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PerBothner/xterm.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PerBothner/xterm.js/teams","hooks_url":"https://api.github.com/repos/PerBothner/xterm.js/hooks","issue_events_url":"https://api.github.com/repos/PerBothner/xterm.js/issues/events{/number}","events_url":"https://api.github.com/repos/PerBothner/xterm.js/events","assignees_url":"https://api.github.com/repos/PerBothner/xterm.js/assignees{/user}","branches_url":"https://api.github.com/repos/PerBothner/xterm.js/branches{/branch}","tags_url":"https://api.github.com/repos/PerBothner/xterm.js/tags","blobs_url":"https://api.github.com/repos/PerBothner/xterm.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PerBothner/xterm.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PerBothner/xterm.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/PerBothner/xterm.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PerBothner/xterm.js/statuses/{sha}","languages_url":"https://api.github.com/repos/PerBothner/xterm.js/languages","stargazers_url":"https://api.github.com/repos/PerBothner/xterm.js/stargazers","contributors_url":"https://api.github.com/repos/PerBothner/xterm.js/contributors","subscribers_url":"https://api.github.com/repos/PerBothner/xterm.js/subscribers","subscription_url":"https://api.github.com/repos/PerBothner/xterm.js/subscription","commits_url":"https://api.github.com/repos/PerBothner/xterm.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/PerBothner/xterm.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/PerBothner/xterm.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/PerBothner/xterm.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/PerBothner/xterm.js/contents/{+path}","compare_url":"https://api.github.com/repos/PerBothner/xterm.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PerBothner/xterm.js/merges","archive_url":"https://api.github.com/repos/PerBothner/xterm.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PerBothner/xterm.js/downloads","issues_url":"https://api.github.com/repos/PerBothner/xterm.js/issues{/number}","pulls_url":"https://api.github.com/repos/PerBothner/xterm.js/pulls{/number}","milestones_url":"https://api.github.com/repos/PerBothner/xterm.js/milestones{/number}","notifications_url":"https://api.github.com/repos/PerBothner/xterm.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PerBothner/xterm.js/labels{/name}","releases_url":"https://api.github.com/repos/PerBothner/xterm.js/releases{/id}","deployments_url":"https://api.github.com/repos/PerBothner/xterm.js/deployments","created_at":"2018-12-04T17:39:11Z","updated_at":"2018-12-21T18:44:19Z","pushed_at":"2018-12-23T20:28:26Z","git_url":"git://github.com/PerBothner/xterm.js.git","ssh_url":"git@github.com:PerBothner/xterm.js.git","clone_url":"https://github.com/PerBothner/xterm.js.git","svn_url":"https://github.com/PerBothner/xterm.js","homepage":"https://xtermjs.org/","size":6072,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xtermjs:master","ref":"master","sha":"fcef4d5d286f002b36b2a17b35adf158465b55b8","user":{"login":"xtermjs","id":11927490,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTI3NDkw","avatar_url":"https://avatars1.githubusercontent.com/u/11927490?v=4","gravatar_id":"","url":"https://api.github.com/users/xtermjs","html_url":"https://github.com/xtermjs","followers_url":"https://api.github.com/users/xtermjs/followers","following_url":"https://api.github.com/users/xtermjs/following{/other_user}","gists_url":"https://api.github.com/users/xtermjs/gists{/gist_id}","starred_url":"https://api.github.com/users/xtermjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtermjs/subscriptions","organizations_url":"https://api.github.com/users/xtermjs/orgs","repos_url":"https://api.github.com/users/xtermjs/repos","events_url":"https://api.github.com/users/xtermjs/events{/privacy}","received_events_url":"https://api.github.com/users/xtermjs/received_events","type":"Organization","site_admin":false},"repo":{"id":18068542,"node_id":"MDEwOlJlcG9zaXRvcnkxODA2ODU0Mg==","name":"xterm.js","full_name":"xtermjs/xterm.js","private":false,"owner":{"login":"xtermjs","id":11927490,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTI3NDkw","avatar_url":"https://avatars1.githubusercontent.com/u/11927490?v=4","gravatar_id":"","url":"https://api.github.com/users/xtermjs","html_url":"https://github.com/xtermjs","followers_url":"https://api.github.com/users/xtermjs/followers","following_url":"https://api.github.com/users/xtermjs/following{/other_user}","gists_url":"https://api.github.com/users/xtermjs/gists{/gist_id}","starred_url":"https://api.github.com/users/xtermjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtermjs/subscriptions","organizations_url":"https://api.github.com/users/xtermjs/orgs","repos_url":"https://api.github.com/users/xtermjs/repos","events_url":"https://api.github.com/users/xtermjs/events{/privacy}","received_events_url":"https://api.github.com/users/xtermjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xtermjs/xterm.js","description":"A terminal for the web","fork":false,"url":"https://api.github.com/repos/xtermjs/xterm.js","forks_url":"https://api.github.com/repos/xtermjs/xterm.js/forks","keys_url":"https://api.github.com/repos/xtermjs/xterm.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xtermjs/xterm.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xtermjs/xterm.js/teams","hooks_url":"https://api.github.com/repos/xtermjs/xterm.js/hooks","issue_events_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/events{/number}","events_url":"https://api.github.com/repos/xtermjs/xterm.js/events","assignees_url":"https://api.github.com/repos/xtermjs/xterm.js/assignees{/user}","branches_url":"https://api.github.com/repos/xtermjs/xterm.js/branches{/branch}","tags_url":"https://api.github.com/repos/xtermjs/xterm.js/tags","blobs_url":"https://api.github.com/repos/xtermjs/xterm.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xtermjs/xterm.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xtermjs/xterm.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/xtermjs/xterm.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xtermjs/xterm.js/statuses/{sha}","languages_url":"https://api.github.com/repos/xtermjs/xterm.js/languages","stargazers_url":"https://api.github.com/repos/xtermjs/xterm.js/stargazers","contributors_url":"https://api.github.com/repos/xtermjs/xterm.js/contributors","subscribers_url":"https://api.github.com/repos/xtermjs/xterm.js/subscribers","subscription_url":"https://api.github.com/repos/xtermjs/xterm.js/subscription","commits_url":"https://api.github.com/repos/xtermjs/xterm.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/xtermjs/xterm.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/xtermjs/xterm.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/xtermjs/xterm.js/contents/{+path}","compare_url":"https://api.github.com/repos/xtermjs/xterm.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xtermjs/xterm.js/merges","archive_url":"https://api.github.com/repos/xtermjs/xterm.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xtermjs/xterm.js/downloads","issues_url":"https://api.github.com/repos/xtermjs/xterm.js/issues{/number}","pulls_url":"https://api.github.com/repos/xtermjs/xterm.js/pulls{/number}","milestones_url":"https://api.github.com/repos/xtermjs/xterm.js/milestones{/number}","notifications_url":"https://api.github.com/repos/xtermjs/xterm.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xtermjs/xterm.js/labels{/name}","releases_url":"https://api.github.com/repos/xtermjs/xterm.js/releases{/id}","deployments_url":"https://api.github.com/repos/xtermjs/xterm.js/deployments","created_at":"2014-03-24T16:04:04Z","updated_at":"2018-12-23T21:49:13Z","pushed_at":"2018-12-23T20:28:28Z","git_url":"git://github.com/xtermjs/xterm.js.git","ssh_url":"git@github.com:xtermjs/xterm.js.git","clone_url":"https://github.com/xtermjs/xterm.js.git","svn_url":"https://github.com/xtermjs/xterm.js","homepage":"https://xtermjs.org/","size":6033,"stargazers_count":5332,"watchers_count":5332,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":554,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":554,"open_issues":137,"watchers":5332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xtermjs/xterm.js/pulls/1853"},"html":{"href":"https://github.com/xtermjs/xterm.js/pull/1853"},"issue":{"href":"https://api.github.com/repos/xtermjs/xterm.js/issues/1853"},"comments":{"href":"https://api.github.com/repos/xtermjs/xterm.js/issues/1853/comments"},"review_comments":{"href":"https://api.github.com/repos/xtermjs/xterm.js/pulls/1853/comments"},"review_comment":{"href":"https://api.github.com/repos/xtermjs/xterm.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xtermjs/xterm.js/pulls/1853/commits"},"statuses":{"href":"https://api.github.com/repos/xtermjs/xterm.js/statuses/48ff841d6ab23744570326201c4294a25ec16474"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Tyriar"}}