{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/208691741","pull_request_review_id":144536866,"id":208691741,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODY5MTc0MQ==","diff_hunk":"@@ -171,9 +189,8 @@ If you are using a JavaScript framework, such as React or Angular, you can creat\n \n Method Signature | Description\n --- | ---\n-`addClass(className: string) => void` | Adds a class to the root element, or the inner icon element.\n-`removeClass(className: string) => void` | Removes a class from the root element, or the inner icon element.\n-`setText(text: string) => void` | Sets the text content of the root element, or the inner icon element.\n+`addClass(className: string) => void` | Adds a class to a icon element.","path":"packages/mdc-icon-button/README.md","position":117,"original_position":117,"commit_id":"ff8e43259f5d45f27fd1b003628b2e214f41e28d","original_commit_id":"ff8e43259f5d45f27fd1b003628b2e214f41e28d","user":{"login":"kfranqueiro","id":398379,"node_id":"MDQ6VXNlcjM5ODM3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/398379?v=4","gravatar_id":"","url":"https://api.github.com/users/kfranqueiro","html_url":"https://github.com/kfranqueiro","followers_url":"https://api.github.com/users/kfranqueiro/followers","following_url":"https://api.github.com/users/kfranqueiro/following{/other_user}","gists_url":"https://api.github.com/users/kfranqueiro/gists{/gist_id}","starred_url":"https://api.github.com/users/kfranqueiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfranqueiro/subscriptions","organizations_url":"https://api.github.com/users/kfranqueiro/orgs","repos_url":"https://api.github.com/users/kfranqueiro/repos","events_url":"https://api.github.com/users/kfranqueiro/events{/privacy}","received_events_url":"https://api.github.com/users/kfranqueiro/received_events","type":"User","site_admin":false},"body":"Why were these docs changed? Doesn't this still apply to the root element?","created_at":"2018-08-08T18:40:24Z","updated_at":"2018-08-08T18:57:37Z","html_url":"https://github.com/material-components/material-components-web/pull/3310#discussion_r208691741","pull_request_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3310","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/208691741"},"html":{"href":"https://github.com/material-components/material-components-web/pull/3310#discussion_r208691741"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3310"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/3310","id":206844900,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODQ0OTAw","html_url":"https://github.com/material-components/material-components-web/pull/3310","diff_url":"https://github.com/material-components/material-components-web/pull/3310.diff","patch_url":"https://github.com/material-components/material-components-web/pull/3310.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web/issues/3310","number":3310,"state":"open","locked":false,"title":"feat(icon-button): Add SVG support","user":{"login":"williamernest","id":34519388,"node_id":"MDQ6VXNlcjM0NTE5Mzg4","avatar_url":"https://avatars3.githubusercontent.com/u/34519388?v=4","gravatar_id":"","url":"https://api.github.com/users/williamernest","html_url":"https://github.com/williamernest","followers_url":"https://api.github.com/users/williamernest/followers","following_url":"https://api.github.com/users/williamernest/following{/other_user}","gists_url":"https://api.github.com/users/williamernest/gists{/gist_id}","starred_url":"https://api.github.com/users/williamernest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamernest/subscriptions","organizations_url":"https://api.github.com/users/williamernest/orgs","repos_url":"https://api.github.com/users/williamernest/repos","events_url":"https://api.github.com/users/williamernest/events{/privacy}","received_events_url":"https://api.github.com/users/williamernest/received_events","type":"User","site_admin":false},"body":"fixes: #3277 , resolves #3154, resolves #3107\r\nBREAKING CHANGE: Removes the previous `data` attributes and no longer dynamically changes the label. Allows developers to add both elements to the button, with one indicated as the `on` state by using a `data-toggle-on` attribute. State is now changed by adding/removing the `mdc-icon-button--on` class to the `mdc-icon-button` element. All icon elements should have the `mdc-icon-button__icon` class. ","created_at":"2018-08-07T22:31:25Z","updated_at":"2018-08-08T18:57:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e3ab679352dfbf6524fa958de70a49f841b5c4f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3310/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3310/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web/issues/3310/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/ff8e43259f5d45f27fd1b003628b2e214f41e28d","head":{"label":"material-components:feat/icon-button/svg-support","ref":"feat/icon-button/svg-support","sha":"ff8e43259f5d45f27fd1b003628b2e214f41e28d","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-08-08T17:49:43Z","pushed_at":"2018-08-08T17:49:42Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":67147,"stargazers_count":9932,"watchers_count":9932,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1160,"mirror_url":null,"archived":false,"open_issues_count":344,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1160,"open_issues":344,"watchers":9932,"default_branch":"master"}},"base":{"label":"material-components:master","ref":"master","sha":"7d5e9bd4a93d048d7b50120ad42aa5035c41eed8","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-08-08T17:49:43Z","pushed_at":"2018-08-08T17:49:42Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":67147,"stargazers_count":9932,"watchers_count":9932,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1160,"mirror_url":null,"archived":false,"open_issues_count":344,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1160,"open_issues":344,"watchers":9932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3310"},"html":{"href":"https://github.com/material-components/material-components-web/pull/3310"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/3310"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/3310/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3310/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3310/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web/statuses/ff8e43259f5d45f27fd1b003628b2e214f41e28d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kfranqueiro"}}