{"action":"closed","number":152,"pull_request":{"url":"https://api.github.com/repos/spacejam/rust-rocksdb/pulls/152","id":155743966,"html_url":"https://github.com/spacejam/rust-rocksdb/pull/152","diff_url":"https://github.com/spacejam/rust-rocksdb/pull/152.diff","patch_url":"https://github.com/spacejam/rust-rocksdb/pull/152.patch","issue_url":"https://api.github.com/repos/spacejam/rust-rocksdb/issues/152","number":152,"state":"closed","locked":false,"title":"Adding Send marker trait to Options...","user":{"login":"iSynaptic","id":142156,"avatar_url":"https://avatars3.githubusercontent.com/u/142156?v=4","gravatar_id":"","url":"https://api.github.com/users/iSynaptic","html_url":"https://github.com/iSynaptic","followers_url":"https://api.github.com/users/iSynaptic/followers","following_url":"https://api.github.com/users/iSynaptic/following{/other_user}","gists_url":"https://api.github.com/users/iSynaptic/gists{/gist_id}","starred_url":"https://api.github.com/users/iSynaptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSynaptic/subscriptions","organizations_url":"https://api.github.com/users/iSynaptic/orgs","repos_url":"https://api.github.com/users/iSynaptic/repos","events_url":"https://api.github.com/users/iSynaptic/events{/privacy}","received_events_url":"https://api.github.com/users/iSynaptic/received_events","type":"User","site_admin":false},"body":"This PR is primarily motivated by a desire to be able to retrieve database statistics from multiple threads.\r\n\r\nI couldn't find any documentation in RocksDb that indicates that `rocksdb_options_t` has any thread affinity. What documentation I did find [1] says that `rocksdb_t` is the only object that can be used without any synchronization (it's handled within).  All other objects must be have synchronization provided. \r\n\r\nBy making the `Options` struct `Send` it would allow it to be used by multiple threads, so long as it is protected by some form of synchronization (eg. `Arc<Mutex<Options>>`).\r\n\r\n1: https://github.com/facebook/rocksdb/wiki/Basic-Operations#concurrency","created_at":"2017-11-30T23:13:07Z","updated_at":"2018-02-10T16:40:18Z","closed_at":"2018-02-10T16:40:18Z","merged_at":"2018-02-10T16:40:18Z","merge_commit_sha":"27abe37abb048dbb98697ecc2e0a1318df30016b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spacejam/rust-rocksdb/pulls/152/commits","review_comments_url":"https://api.github.com/repos/spacejam/rust-rocksdb/pulls/152/comments","review_comment_url":"https://api.github.com/repos/spacejam/rust-rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacejam/rust-rocksdb/issues/152/comments","statuses_url":"https://api.github.com/repos/spacejam/rust-rocksdb/statuses/32864442287be765b8d3628767de3a46119a0169","head":{"label":"iSynaptic:master","ref":"master","sha":"32864442287be765b8d3628767de3a46119a0169","user":{"login":"iSynaptic","id":142156,"avatar_url":"https://avatars3.githubusercontent.com/u/142156?v=4","gravatar_id":"","url":"https://api.github.com/users/iSynaptic","html_url":"https://github.com/iSynaptic","followers_url":"https://api.github.com/users/iSynaptic/followers","following_url":"https://api.github.com/users/iSynaptic/following{/other_user}","gists_url":"https://api.github.com/users/iSynaptic/gists{/gist_id}","starred_url":"https://api.github.com/users/iSynaptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSynaptic/subscriptions","organizations_url":"https://api.github.com/users/iSynaptic/orgs","repos_url":"https://api.github.com/users/iSynaptic/repos","events_url":"https://api.github.com/users/iSynaptic/events{/privacy}","received_events_url":"https://api.github.com/users/iSynaptic/received_events","type":"User","site_admin":false},"repo":{"id":104937194,"name":"rust-rocksdb","full_name":"iSynaptic/rust-rocksdb","owner":{"login":"iSynaptic","id":142156,"avatar_url":"https://avatars3.githubusercontent.com/u/142156?v=4","gravatar_id":"","url":"https://api.github.com/users/iSynaptic","html_url":"https://github.com/iSynaptic","followers_url":"https://api.github.com/users/iSynaptic/followers","following_url":"https://api.github.com/users/iSynaptic/following{/other_user}","gists_url":"https://api.github.com/users/iSynaptic/gists{/gist_id}","starred_url":"https://api.github.com/users/iSynaptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSynaptic/subscriptions","organizations_url":"https://api.github.com/users/iSynaptic/orgs","repos_url":"https://api.github.com/users/iSynaptic/repos","events_url":"https://api.github.com/users/iSynaptic/events{/privacy}","received_events_url":"https://api.github.com/users/iSynaptic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iSynaptic/rust-rocksdb","description":"rust wrapper for rocksdb","fork":true,"url":"https://api.github.com/repos/iSynaptic/rust-rocksdb","forks_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/forks","keys_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/teams","hooks_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/hooks","issue_events_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/events","assignees_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/tags","blobs_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/languages","stargazers_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/stargazers","contributors_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/contributors","subscribers_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/subscribers","subscription_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/subscription","commits_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/merges","archive_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/downloads","issues_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/iSynaptic/rust-rocksdb/deployments","created_at":"2017-09-26T20:59:26Z","updated_at":"2017-09-26T20:59:28Z","pushed_at":"2017-11-30T23:00:27Z","git_url":"git://github.com/iSynaptic/rust-rocksdb.git","ssh_url":"git@github.com:iSynaptic/rust-rocksdb.git","clone_url":"https://github.com/iSynaptic/rust-rocksdb.git","svn_url":"https://github.com/iSynaptic/rust-rocksdb","homepage":null,"size":498,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spacejam:master","ref":"master","sha":"4d48b70bc2f0ce40f47254a197a1bfd4e75c739d","user":{"login":"spacejam","id":1505488,"avatar_url":"https://avatars0.githubusercontent.com/u/1505488?v=4","gravatar_id":"","url":"https://api.github.com/users/spacejam","html_url":"https://github.com/spacejam","followers_url":"https://api.github.com/users/spacejam/followers","following_url":"https://api.github.com/users/spacejam/following{/other_user}","gists_url":"https://api.github.com/users/spacejam/gists{/gist_id}","starred_url":"https://api.github.com/users/spacejam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacejam/subscriptions","organizations_url":"https://api.github.com/users/spacejam/orgs","repos_url":"https://api.github.com/users/spacejam/repos","events_url":"https://api.github.com/users/spacejam/events{/privacy}","received_events_url":"https://api.github.com/users/spacejam/received_events","type":"User","site_admin":false},"repo":{"id":26731785,"name":"rust-rocksdb","full_name":"spacejam/rust-rocksdb","owner":{"login":"spacejam","id":1505488,"avatar_url":"https://avatars0.githubusercontent.com/u/1505488?v=4","gravatar_id":"","url":"https://api.github.com/users/spacejam","html_url":"https://github.com/spacejam","followers_url":"https://api.github.com/users/spacejam/followers","following_url":"https://api.github.com/users/spacejam/following{/other_user}","gists_url":"https://api.github.com/users/spacejam/gists{/gist_id}","starred_url":"https://api.github.com/users/spacejam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacejam/subscriptions","organizations_url":"https://api.github.com/users/spacejam/orgs","repos_url":"https://api.github.com/users/spacejam/repos","events_url":"https://api.github.com/users/spacejam/events{/privacy}","received_events_url":"https://api.github.com/users/spacejam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spacejam/rust-rocksdb","description":"rust wrapper for rocksdb","fork":false,"url":"https://api.github.com/repos/spacejam/rust-rocksdb","forks_url":"https://api.github.com/repos/spacejam/rust-rocksdb/forks","keys_url":"https://api.github.com/repos/spacejam/rust-rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacejam/rust-rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacejam/rust-rocksdb/teams","hooks_url":"https://api.github.com/repos/spacejam/rust-rocksdb/hooks","issue_events_url":"https://api.github.com/repos/spacejam/rust-rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/spacejam/rust-rocksdb/events","assignees_url":"https://api.github.com/repos/spacejam/rust-rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/spacejam/rust-rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/spacejam/rust-rocksdb/tags","blobs_url":"https://api.github.com/repos/spacejam/rust-rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacejam/rust-rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacejam/rust-rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacejam/rust-rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacejam/rust-rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/spacejam/rust-rocksdb/languages","stargazers_url":"https://api.github.com/repos/spacejam/rust-rocksdb/stargazers","contributors_url":"https://api.github.com/repos/spacejam/rust-rocksdb/contributors","subscribers_url":"https://api.github.com/repos/spacejam/rust-rocksdb/subscribers","subscription_url":"https://api.github.com/repos/spacejam/rust-rocksdb/subscription","commits_url":"https://api.github.com/repos/spacejam/rust-rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacejam/rust-rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacejam/rust-rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacejam/rust-rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacejam/rust-rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/spacejam/rust-rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacejam/rust-rocksdb/merges","archive_url":"https://api.github.com/repos/spacejam/rust-rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacejam/rust-rocksdb/downloads","issues_url":"https://api.github.com/repos/spacejam/rust-rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/spacejam/rust-rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/spacejam/rust-rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/spacejam/rust-rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacejam/rust-rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/spacejam/rust-rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/spacejam/rust-rocksdb/deployments","created_at":"2014-11-16T23:19:18Z","updated_at":"2018-02-10T02:27:08Z","pushed_at":"2018-02-10T16:40:18Z","git_url":"git://github.com/spacejam/rust-rocksdb.git","ssh_url":"git@github.com:spacejam/rust-rocksdb.git","clone_url":"https://github.com/spacejam/rust-rocksdb.git","svn_url":"https://github.com/spacejam/rust-rocksdb","homepage":null,"size":508,"stargazers_count":191,"watchers_count":191,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":90,"open_issues":28,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacejam/rust-rocksdb/pulls/152"},"html":{"href":"https://github.com/spacejam/rust-rocksdb/pull/152"},"issue":{"href":"https://api.github.com/repos/spacejam/rust-rocksdb/issues/152"},"comments":{"href":"https://api.github.com/repos/spacejam/rust-rocksdb/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/spacejam/rust-rocksdb/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/spacejam/rust-rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacejam/rust-rocksdb/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/spacejam/rust-rocksdb/statuses/32864442287be765b8d3628767de3a46119a0169"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"spacejam","id":1505488,"avatar_url":"https://avatars0.githubusercontent.com/u/1505488?v=4","gravatar_id":"","url":"https://api.github.com/users/spacejam","html_url":"https://github.com/spacejam","followers_url":"https://api.github.com/users/spacejam/followers","following_url":"https://api.github.com/users/spacejam/following{/other_user}","gists_url":"https://api.github.com/users/spacejam/gists{/gist_id}","starred_url":"https://api.github.com/users/spacejam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacejam/subscriptions","organizations_url":"https://api.github.com/users/spacejam/orgs","repos_url":"https://api.github.com/users/spacejam/repos","events_url":"https://api.github.com/users/spacejam/events{/privacy}","received_events_url":"https://api.github.com/users/spacejam/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"spacejam"}}