{"action":"created","comment":{"url":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/comments/214395460","pull_request_review_id":151450010,"id":214395460,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDM5NTQ2MA==","diff_hunk":"@@ -293,7 +293,10 @@ was successful.\n run has an \"aborted\" status, usually due to the Pipeline being manually aborted.\n This is typically denoted by gray in the web UI.\n `failure`:: Only run the steps in `post` if the current Pipeline's or stage's\n-run has a \"failed\" status, typically denoted by red in the web UI.\n+run has a \"failed\" status, typically denoted by red in the web UI. Note that if\n+you manually set `currentBuild.result = 'FAILURE'` in a stage and have a\n+`failure` `post` condition on that stage, the `failure` will not fire for that\n+stage.","path":"content/doc/book/pipeline/syntax.adoc","position":8,"original_position":8,"commit_id":"166acc89c5d865bde77c51612f9060c0204619f1","original_commit_id":"166acc89c5d865bde77c51612f9060c0204619f1","user":{"login":"dwnusbaum","id":1068968,"node_id":"MDQ6VXNlcjEwNjg5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/1068968?v=4","gravatar_id":"","url":"https://api.github.com/users/dwnusbaum","html_url":"https://github.com/dwnusbaum","followers_url":"https://api.github.com/users/dwnusbaum/followers","following_url":"https://api.github.com/users/dwnusbaum/following{/other_user}","gists_url":"https://api.github.com/users/dwnusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/dwnusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwnusbaum/subscriptions","organizations_url":"https://api.github.com/users/dwnusbaum/orgs","repos_url":"https://api.github.com/users/dwnusbaum/repos","events_url":"https://api.github.com/users/dwnusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/dwnusbaum/received_events","type":"User","site_admin":false},"body":"Should we tell users what to do instead of setting `currentBuild.result = 'FAILURE'`? Would switching to using the `error` step do the right thing? ","created_at":"2018-08-31T15:42:26Z","updated_at":"2018-08-31T15:42:26Z","html_url":"https://github.com/jenkins-infra/jenkins.io/pull/1756#discussion_r214395460","pull_request_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/1756","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/comments/214395460"},"html":{"href":"https://github.com/jenkins-infra/jenkins.io/pull/1756#discussion_r214395460"},"pull_request":{"href":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/1756"}}},"pull_request":{"url":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/1756","id":212422382,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDIyMzgy","html_url":"https://github.com/jenkins-infra/jenkins.io/pull/1756","diff_url":"https://github.com/jenkins-infra/jenkins.io/pull/1756.diff","patch_url":"https://github.com/jenkins-infra/jenkins.io/pull/1756.patch","issue_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/issues/1756","number":1756,"state":"open","locked":false,"title":"[JENKINS-52114] Clarify stage post failure with manual set of result","user":{"login":"abayer","id":120218,"node_id":"MDQ6VXNlcjEyMDIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/120218?v=4","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"body":"See https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/285\r\n\r\n[JENKINS-52114](https://issues.jenkins-ci.org/browse/JENKINS-52114)\r\n\r\ncc @kshultzCB @dwnusbaum ","created_at":"2018-08-31T15:39:17Z","updated_at":"2018-08-31T15:42:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5951bb4681d029d519e1c50d1f939d4fcc56f23e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rtyler","id":26594,"node_id":"MDQ6VXNlcjI2NTk0","avatar_url":"https://avatars0.githubusercontent.com/u/26594?v=4","gravatar_id":"","url":"https://api.github.com/users/rtyler","html_url":"https://github.com/rtyler","followers_url":"https://api.github.com/users/rtyler/followers","following_url":"https://api.github.com/users/rtyler/following{/other_user}","gists_url":"https://api.github.com/users/rtyler/gists{/gist_id}","starred_url":"https://api.github.com/users/rtyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtyler/subscriptions","organizations_url":"https://api.github.com/users/rtyler/orgs","repos_url":"https://api.github.com/users/rtyler/repos","events_url":"https://api.github.com/users/rtyler/events{/privacy}","received_events_url":"https://api.github.com/users/rtyler/received_events","type":"User","site_admin":false},{"login":"daniel-beck","id":1831569,"node_id":"MDQ6VXNlcjE4MzE1Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1831569?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-beck","html_url":"https://github.com/daniel-beck","followers_url":"https://api.github.com/users/daniel-beck/followers","following_url":"https://api.github.com/users/daniel-beck/following{/other_user}","gists_url":"https://api.github.com/users/daniel-beck/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-beck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-beck/subscriptions","organizations_url":"https://api.github.com/users/daniel-beck/orgs","repos_url":"https://api.github.com/users/daniel-beck/repos","events_url":"https://api.github.com/users/daniel-beck/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-beck/received_events","type":"User","site_admin":false},{"login":"bitwiseman","id":1958953,"node_id":"MDQ6VXNlcjE5NTg5NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1958953?v=4","gravatar_id":"","url":"https://api.github.com/users/bitwiseman","html_url":"https://github.com/bitwiseman","followers_url":"https://api.github.com/users/bitwiseman/followers","following_url":"https://api.github.com/users/bitwiseman/following{/other_user}","gists_url":"https://api.github.com/users/bitwiseman/gists{/gist_id}","starred_url":"https://api.github.com/users/bitwiseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitwiseman/subscriptions","organizations_url":"https://api.github.com/users/bitwiseman/orgs","repos_url":"https://api.github.com/users/bitwiseman/repos","events_url":"https://api.github.com/users/bitwiseman/events{/privacy}","received_events_url":"https://api.github.com/users/bitwiseman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":336285993,"node_id":"MDU6TGFiZWwzMzYyODU5OTM=","url":"https://api.github.com/repos/jenkins-infra/jenkins.io/labels/work-in-progress","name":"work-in-progress","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/1756/commits","review_comments_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/1756/comments","review_comment_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/issues/1756/comments","statuses_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/statuses/166acc89c5d865bde77c51612f9060c0204619f1","head":{"label":"abayer:jenkins-52114","ref":"jenkins-52114","sha":"166acc89c5d865bde77c51612f9060c0204619f1","user":{"login":"abayer","id":120218,"node_id":"MDQ6VXNlcjEyMDIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/120218?v=4","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"repo":{"id":52119168,"node_id":"MDEwOlJlcG9zaXRvcnk1MjExOTE2OA==","name":"jenkins.io","full_name":"abayer/jenkins.io","owner":{"login":"abayer","id":120218,"node_id":"MDQ6VXNlcjEyMDIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/120218?v=4","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abayer/jenkins.io","description":"A static site for the Jenkins automation server","fork":true,"url":"https://api.github.com/repos/abayer/jenkins.io","forks_url":"https://api.github.com/repos/abayer/jenkins.io/forks","keys_url":"https://api.github.com/repos/abayer/jenkins.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abayer/jenkins.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abayer/jenkins.io/teams","hooks_url":"https://api.github.com/repos/abayer/jenkins.io/hooks","issue_events_url":"https://api.github.com/repos/abayer/jenkins.io/issues/events{/number}","events_url":"https://api.github.com/repos/abayer/jenkins.io/events","assignees_url":"https://api.github.com/repos/abayer/jenkins.io/assignees{/user}","branches_url":"https://api.github.com/repos/abayer/jenkins.io/branches{/branch}","tags_url":"https://api.github.com/repos/abayer/jenkins.io/tags","blobs_url":"https://api.github.com/repos/abayer/jenkins.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abayer/jenkins.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abayer/jenkins.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/abayer/jenkins.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abayer/jenkins.io/statuses/{sha}","languages_url":"https://api.github.com/repos/abayer/jenkins.io/languages","stargazers_url":"https://api.github.com/repos/abayer/jenkins.io/stargazers","contributors_url":"https://api.github.com/repos/abayer/jenkins.io/contributors","subscribers_url":"https://api.github.com/repos/abayer/jenkins.io/subscribers","subscription_url":"https://api.github.com/repos/abayer/jenkins.io/subscription","commits_url":"https://api.github.com/repos/abayer/jenkins.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/abayer/jenkins.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/abayer/jenkins.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/abayer/jenkins.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/abayer/jenkins.io/contents/{+path}","compare_url":"https://api.github.com/repos/abayer/jenkins.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abayer/jenkins.io/merges","archive_url":"https://api.github.com/repos/abayer/jenkins.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abayer/jenkins.io/downloads","issues_url":"https://api.github.com/repos/abayer/jenkins.io/issues{/number}","pulls_url":"https://api.github.com/repos/abayer/jenkins.io/pulls{/number}","milestones_url":"https://api.github.com/repos/abayer/jenkins.io/milestones{/number}","notifications_url":"https://api.github.com/repos/abayer/jenkins.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abayer/jenkins.io/labels{/name}","releases_url":"https://api.github.com/repos/abayer/jenkins.io/releases{/id}","deployments_url":"https://api.github.com/repos/abayer/jenkins.io/deployments","created_at":"2016-02-19T21:57:03Z","updated_at":"2018-06-07T20:05:02Z","pushed_at":"2018-08-31T15:37:58Z","git_url":"git://github.com/abayer/jenkins.io.git","ssh_url":"git@github.com:abayer/jenkins.io.git","clone_url":"https://github.com/abayer/jenkins.io.git","svn_url":"https://github.com/abayer/jenkins.io","homepage":"https://jenkins-ci.org","size":207565,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkins-infra:master","ref":"master","sha":"5985427c0972c6f0ee08ef6ec8164dce63a0cf47","user":{"login":"jenkins-infra","id":7422698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MjI2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/7422698?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkins-infra","html_url":"https://github.com/jenkins-infra","followers_url":"https://api.github.com/users/jenkins-infra/followers","following_url":"https://api.github.com/users/jenkins-infra/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-infra/subscriptions","organizations_url":"https://api.github.com/users/jenkins-infra/orgs","repos_url":"https://api.github.com/users/jenkins-infra/repos","events_url":"https://api.github.com/users/jenkins-infra/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-infra/received_events","type":"Organization","site_admin":false},"repo":{"id":44886691,"node_id":"MDEwOlJlcG9zaXRvcnk0NDg4NjY5MQ==","name":"jenkins.io","full_name":"jenkins-infra/jenkins.io","owner":{"login":"jenkins-infra","id":7422698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MjI2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/7422698?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkins-infra","html_url":"https://github.com/jenkins-infra","followers_url":"https://api.github.com/users/jenkins-infra/followers","following_url":"https://api.github.com/users/jenkins-infra/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-infra/subscriptions","organizations_url":"https://api.github.com/users/jenkins-infra/orgs","repos_url":"https://api.github.com/users/jenkins-infra/repos","events_url":"https://api.github.com/users/jenkins-infra/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-infra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkins-infra/jenkins.io","description":"A static site for the Jenkins automation server","fork":false,"url":"https://api.github.com/repos/jenkins-infra/jenkins.io","forks_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/forks","keys_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/teams","hooks_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/hooks","issue_events_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/issues/events{/number}","events_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/events","assignees_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/assignees{/user}","branches_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/branches{/branch}","tags_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/tags","blobs_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/languages","stargazers_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/stargazers","contributors_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/contributors","subscribers_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/subscribers","subscription_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/subscription","commits_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/contents/{+path}","compare_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/merges","archive_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/downloads","issues_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/issues{/number}","pulls_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/labels{/name}","releases_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/releases{/id}","deployments_url":"https://api.github.com/repos/jenkins-infra/jenkins.io/deployments","created_at":"2015-10-24T22:02:57Z","updated_at":"2018-08-31T07:22:56Z","pushed_at":"2018-08-31T15:39:18Z","git_url":"git://github.com/jenkins-infra/jenkins.io.git","ssh_url":"git@github.com:jenkins-infra/jenkins.io.git","clone_url":"https://github.com/jenkins-infra/jenkins.io.git","svn_url":"https://github.com/jenkins-infra/jenkins.io","homepage":"https://jenkins.io","size":207664,"stargazers_count":96,"watchers_count":96,"language":"HTML","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":368,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":368,"open_issues":5,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/1756"},"html":{"href":"https://github.com/jenkins-infra/jenkins.io/pull/1756"},"issue":{"href":"https://api.github.com/repos/jenkins-infra/jenkins.io/issues/1756"},"comments":{"href":"https://api.github.com/repos/jenkins-infra/jenkins.io/issues/1756/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/1756/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkins-infra/jenkins.io/pulls/1756/commits"},"statuses":{"href":"https://api.github.com/repos/jenkins-infra/jenkins.io/statuses/166acc89c5d865bde77c51612f9060c0204619f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dwnusbaum"}}