{"action":"created","comment":{"url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/comments/245104875","pull_request_review_id":189146825,"id":245104875,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTEwNDg3NQ==","diff_hunk":"@@ -387,8 +387,14 @@ def _valid_designspace(self, designspace):\n         \"\"\"Make sure that the user-provided designspace has loaded fonts and\n         that names are the same as those from the UFOs.\n         \"\"\"\n-        # TODO: (jany) really make a copy to avoid modifying the original object\n-        copy = designspace\n+        import copy\n+\n+        copy = copy.deepcopy(designspace)","path":"Lib/glyphsLib/builder/builders.py","position":8,"original_position":8,"commit_id":"af78810bc2bdd07b816f4ce9a16c54d6bed2b8a5","original_commit_id":"af78810bc2bdd07b816f4ce9a16c54d6bed2b8a5","user":{"login":"anthrotype","id":6939968,"node_id":"MDQ6VXNlcjY5Mzk5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/6939968?v=4","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"body":"if the sources have a 'font' attached with a defcon.Font, this deepcopy will probably fail\r\nhttps://github.com/typesupply/defcon/issues/210","created_at":"2019-01-03T19:19:54Z","updated_at":"2019-01-03T19:19:54Z","html_url":"https://github.com/googlei18n/glyphsLib/pull/478#discussion_r245104875","pull_request_url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/478","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/comments/245104875"},"html":{"href":"https://github.com/googlei18n/glyphsLib/pull/478#discussion_r245104875"},"pull_request":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/478"}}},"pull_request":{"url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/478","id":240537613,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTM3NjEz","html_url":"https://github.com/googlei18n/glyphsLib/pull/478","diff_url":"https://github.com/googlei18n/glyphsLib/pull/478.diff","patch_url":"https://github.com/googlei18n/glyphsLib/pull/478.patch","issue_url":"https://api.github.com/repos/googlei18n/glyphsLib/issues/478","number":478,"state":"open","locked":false,"title":"Implement generation of brace layers in .designspace files","user":{"login":"madig","id":380829,"node_id":"MDQ6VXNlcjM4MDgyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/380829?v=4","gravatar_id":"","url":"https://api.github.com/users/madig","html_url":"https://github.com/madig","followers_url":"https://api.github.com/users/madig/followers","following_url":"https://api.github.com/users/madig/following{/other_user}","gists_url":"https://api.github.com/users/madig/gists{/gist_id}","starred_url":"https://api.github.com/users/madig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madig/subscriptions","organizations_url":"https://api.github.com/users/madig/orgs","repos_url":"https://api.github.com/users/madig/repos","events_url":"https://api.github.com/users/madig/events{/privacy}","received_events_url":"https://api.github.com/users/madig/received_events","type":"User","site_admin":false},"body":"Todo:\r\n\r\n- [x] Wait for upstream work: https://github.com/fonttools/fonttools/commits/varlib-build-accept-ds-object\r\n- [ ] Ensure we are not confounding user and design space for axis locations. Glyphs brace layers and Designspace source locations are declared in design space.\r\n- [ ] Warn user about intermediate source layers in a .designspace file that aren't named like brace layers, as they aren't roundtripped.","created_at":"2018-12-21T17:46:33Z","updated_at":"2019-01-03T19:19:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71fe9d085d45be48fb4333e89e2b87bdcf96994d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/478/commits","review_comments_url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/478/comments","review_comment_url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlei18n/glyphsLib/issues/478/comments","statuses_url":"https://api.github.com/repos/googlei18n/glyphsLib/statuses/af78810bc2bdd07b816f4ce9a16c54d6bed2b8a5","head":{"label":"madig:support-brace-layers","ref":"support-brace-layers","sha":"af78810bc2bdd07b816f4ce9a16c54d6bed2b8a5","user":{"login":"madig","id":380829,"node_id":"MDQ6VXNlcjM4MDgyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/380829?v=4","gravatar_id":"","url":"https://api.github.com/users/madig","html_url":"https://github.com/madig","followers_url":"https://api.github.com/users/madig/followers","following_url":"https://api.github.com/users/madig/following{/other_user}","gists_url":"https://api.github.com/users/madig/gists{/gist_id}","starred_url":"https://api.github.com/users/madig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madig/subscriptions","organizations_url":"https://api.github.com/users/madig/orgs","repos_url":"https://api.github.com/users/madig/repos","events_url":"https://api.github.com/users/madig/events{/privacy}","received_events_url":"https://api.github.com/users/madig/received_events","type":"User","site_admin":false},"repo":{"id":110568729,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1Njg3Mjk=","name":"glyphsLib","full_name":"madig/glyphsLib","private":false,"owner":{"login":"madig","id":380829,"node_id":"MDQ6VXNlcjM4MDgyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/380829?v=4","gravatar_id":"","url":"https://api.github.com/users/madig","html_url":"https://github.com/madig","followers_url":"https://api.github.com/users/madig/followers","following_url":"https://api.github.com/users/madig/following{/other_user}","gists_url":"https://api.github.com/users/madig/gists{/gist_id}","starred_url":"https://api.github.com/users/madig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madig/subscriptions","organizations_url":"https://api.github.com/users/madig/orgs","repos_url":"https://api.github.com/users/madig/repos","events_url":"https://api.github.com/users/madig/events{/privacy}","received_events_url":"https://api.github.com/users/madig/received_events","type":"User","site_admin":false},"html_url":"https://github.com/madig/glyphsLib","description":"A bridge from Glyphs source files (.glyphs) to UFOs","fork":true,"url":"https://api.github.com/repos/madig/glyphsLib","forks_url":"https://api.github.com/repos/madig/glyphsLib/forks","keys_url":"https://api.github.com/repos/madig/glyphsLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madig/glyphsLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madig/glyphsLib/teams","hooks_url":"https://api.github.com/repos/madig/glyphsLib/hooks","issue_events_url":"https://api.github.com/repos/madig/glyphsLib/issues/events{/number}","events_url":"https://api.github.com/repos/madig/glyphsLib/events","assignees_url":"https://api.github.com/repos/madig/glyphsLib/assignees{/user}","branches_url":"https://api.github.com/repos/madig/glyphsLib/branches{/branch}","tags_url":"https://api.github.com/repos/madig/glyphsLib/tags","blobs_url":"https://api.github.com/repos/madig/glyphsLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madig/glyphsLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madig/glyphsLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/madig/glyphsLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madig/glyphsLib/statuses/{sha}","languages_url":"https://api.github.com/repos/madig/glyphsLib/languages","stargazers_url":"https://api.github.com/repos/madig/glyphsLib/stargazers","contributors_url":"https://api.github.com/repos/madig/glyphsLib/contributors","subscribers_url":"https://api.github.com/repos/madig/glyphsLib/subscribers","subscription_url":"https://api.github.com/repos/madig/glyphsLib/subscription","commits_url":"https://api.github.com/repos/madig/glyphsLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/madig/glyphsLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/madig/glyphsLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/madig/glyphsLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/madig/glyphsLib/contents/{+path}","compare_url":"https://api.github.com/repos/madig/glyphsLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madig/glyphsLib/merges","archive_url":"https://api.github.com/repos/madig/glyphsLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madig/glyphsLib/downloads","issues_url":"https://api.github.com/repos/madig/glyphsLib/issues{/number}","pulls_url":"https://api.github.com/repos/madig/glyphsLib/pulls{/number}","milestones_url":"https://api.github.com/repos/madig/glyphsLib/milestones{/number}","notifications_url":"https://api.github.com/repos/madig/glyphsLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madig/glyphsLib/labels{/name}","releases_url":"https://api.github.com/repos/madig/glyphsLib/releases{/id}","deployments_url":"https://api.github.com/repos/madig/glyphsLib/deployments","created_at":"2017-11-13T15:54:01Z","updated_at":"2018-03-26T17:14:57Z","pushed_at":"2018-12-21T17:38:08Z","git_url":"git://github.com/madig/glyphsLib.git","ssh_url":"git@github.com:madig/glyphsLib.git","clone_url":"https://github.com/madig/glyphsLib.git","svn_url":"https://github.com/madig/glyphsLib","homepage":"","size":4223,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlei18n:master","ref":"master","sha":"fba6344b4830ee527c6a52ef2e29330e5cc2abdb","user":{"login":"googlei18n","id":5503833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MDM4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5503833?v=4","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"repo":{"id":44563779,"node_id":"MDEwOlJlcG9zaXRvcnk0NDU2Mzc3OQ==","name":"glyphsLib","full_name":"googlei18n/glyphsLib","private":false,"owner":{"login":"googlei18n","id":5503833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MDM4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5503833?v=4","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googlei18n/glyphsLib","description":"A bridge from Glyphs source files (.glyphs) to UFOs","fork":false,"url":"https://api.github.com/repos/googlei18n/glyphsLib","forks_url":"https://api.github.com/repos/googlei18n/glyphsLib/forks","keys_url":"https://api.github.com/repos/googlei18n/glyphsLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlei18n/glyphsLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlei18n/glyphsLib/teams","hooks_url":"https://api.github.com/repos/googlei18n/glyphsLib/hooks","issue_events_url":"https://api.github.com/repos/googlei18n/glyphsLib/issues/events{/number}","events_url":"https://api.github.com/repos/googlei18n/glyphsLib/events","assignees_url":"https://api.github.com/repos/googlei18n/glyphsLib/assignees{/user}","branches_url":"https://api.github.com/repos/googlei18n/glyphsLib/branches{/branch}","tags_url":"https://api.github.com/repos/googlei18n/glyphsLib/tags","blobs_url":"https://api.github.com/repos/googlei18n/glyphsLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlei18n/glyphsLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlei18n/glyphsLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlei18n/glyphsLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlei18n/glyphsLib/statuses/{sha}","languages_url":"https://api.github.com/repos/googlei18n/glyphsLib/languages","stargazers_url":"https://api.github.com/repos/googlei18n/glyphsLib/stargazers","contributors_url":"https://api.github.com/repos/googlei18n/glyphsLib/contributors","subscribers_url":"https://api.github.com/repos/googlei18n/glyphsLib/subscribers","subscription_url":"https://api.github.com/repos/googlei18n/glyphsLib/subscription","commits_url":"https://api.github.com/repos/googlei18n/glyphsLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlei18n/glyphsLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlei18n/glyphsLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlei18n/glyphsLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlei18n/glyphsLib/contents/{+path}","compare_url":"https://api.github.com/repos/googlei18n/glyphsLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlei18n/glyphsLib/merges","archive_url":"https://api.github.com/repos/googlei18n/glyphsLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlei18n/glyphsLib/downloads","issues_url":"https://api.github.com/repos/googlei18n/glyphsLib/issues{/number}","pulls_url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls{/number}","milestones_url":"https://api.github.com/repos/googlei18n/glyphsLib/milestones{/number}","notifications_url":"https://api.github.com/repos/googlei18n/glyphsLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlei18n/glyphsLib/labels{/name}","releases_url":"https://api.github.com/repos/googlei18n/glyphsLib/releases{/id}","deployments_url":"https://api.github.com/repos/googlei18n/glyphsLib/deployments","created_at":"2015-10-19T21:00:22Z","updated_at":"2018-12-18T21:13:01Z","pushed_at":"2018-12-21T17:46:34Z","git_url":"git://github.com/googlei18n/glyphsLib.git","ssh_url":"git@github.com:googlei18n/glyphsLib.git","clone_url":"https://github.com/googlei18n/glyphsLib.git","svn_url":"https://github.com/googlei18n/glyphsLib","homepage":"","size":4265,"stargazers_count":53,"watchers_count":53,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":27,"open_issues":55,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/478"},"html":{"href":"https://github.com/googlei18n/glyphsLib/pull/478"},"issue":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/issues/478"},"comments":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/issues/478/comments"},"review_comments":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/478/comments"},"review_comment":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/478/commits"},"statuses":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/statuses/af78810bc2bdd07b816f4ce9a16c54d6bed2b8a5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"anthrotype"}}