{"action":"opened","number":380,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/380","id":182782632,"html_url":"https://github.com/CenterForOpenScience/ember-osf/pull/380","diff_url":"https://github.com/CenterForOpenScience/ember-osf/pull/380.diff","patch_url":"https://github.com/CenterForOpenScience/ember-osf/pull/380.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/380","number":380,"state":"open","locked":false,"title":"[IN-234][EOSF] Updated fix for long names in navbar","user":{"login":"baylee-d","id":19379783,"avatar_url":"https://avatars0.githubusercontent.com/u/19379783?v=4","gravatar_id":"","url":"https://api.github.com/users/baylee-d","html_url":"https://github.com/baylee-d","followers_url":"https://api.github.com/users/baylee-d/followers","following_url":"https://api.github.com/users/baylee-d/following{/other_user}","gists_url":"https://api.github.com/users/baylee-d/gists{/gist_id}","starred_url":"https://api.github.com/users/baylee-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baylee-d/subscriptions","organizations_url":"https://api.github.com/users/baylee-d/orgs","repos_url":"https://api.github.com/users/baylee-d/repos","events_url":"https://api.github.com/users/baylee-d/events{/privacy}","received_events_url":"https://api.github.com/users/baylee-d/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n\r\nLong names in the navbar are still not flexing properly.  This PR should fix that.\r\n\r\n## Summary of Changes\r\n\r\n- Removed wrapper from component\r\n- Added `li` tagName to the dropdown being generated with all of the necessary classes\r\n- Changed button to `a` tag\r\n- Added `<li>` to sign-in/sign-up button section (needed since the component no longer has an `li` wrapper)\r\n\r\n## Side Effects / Testing Notes\r\n\r\nThis should fix the issues with flexing on reviews/registries.  When there's a name longer than the space given it should break off with `...` ellipses at the end.  It shouldn't run off the page or break onto a new line.\r\n\r\nThis should also fix the issue of positioning in the navbar.  Before, the name would float just a bit higher than the rest of the navbar text.  This should keep the text inline with everything else.\r\n\r\n## Ticket\r\n\r\nhttps://openscience.atlassian.net/browse/IN-234\r\n\r\n# Reviewer Checklist\r\n\r\n- [ ] meets requirements\r\n- [ ] easy to understand\r\n- [ ] DRY\r\n- [ ] testable and includes test(s)\r\n- [ ] ~~changes described in `CHANGELOG.md`~~ *(changes already in CHANGELOG.md from previous PR)\r\n\r\n<!-- Please strike through any checks that you think are not relevant for this PR and indicate why, e.g.\r\n\r\n     - [ ] ~~easy to understand~~ *(necessarily complex)*\r\n-->\r\n","created_at":"2018-04-19T13:49:07Z","updated_at":"2018-04-19T13:49:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/380/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/380/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/380/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/statuses/7ced1970afcb1ba3dfd610b197b6966736942ba7","head":{"label":"baylee-d:feature/IN-234-fix-names-on-navbar","ref":"feature/IN-234-fix-names-on-navbar","sha":"7ced1970afcb1ba3dfd610b197b6966736942ba7","user":{"login":"baylee-d","id":19379783,"avatar_url":"https://avatars0.githubusercontent.com/u/19379783?v=4","gravatar_id":"","url":"https://api.github.com/users/baylee-d","html_url":"https://github.com/baylee-d","followers_url":"https://api.github.com/users/baylee-d/followers","following_url":"https://api.github.com/users/baylee-d/following{/other_user}","gists_url":"https://api.github.com/users/baylee-d/gists{/gist_id}","starred_url":"https://api.github.com/users/baylee-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baylee-d/subscriptions","organizations_url":"https://api.github.com/users/baylee-d/orgs","repos_url":"https://api.github.com/users/baylee-d/repos","events_url":"https://api.github.com/users/baylee-d/events{/privacy}","received_events_url":"https://api.github.com/users/baylee-d/received_events","type":"User","site_admin":false},"repo":{"id":78757889,"name":"ember-osf","full_name":"baylee-d/ember-osf","owner":{"login":"baylee-d","id":19379783,"avatar_url":"https://avatars0.githubusercontent.com/u/19379783?v=4","gravatar_id":"","url":"https://api.github.com/users/baylee-d","html_url":"https://github.com/baylee-d","followers_url":"https://api.github.com/users/baylee-d/followers","following_url":"https://api.github.com/users/baylee-d/following{/other_user}","gists_url":"https://api.github.com/users/baylee-d/gists{/gist_id}","starred_url":"https://api.github.com/users/baylee-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baylee-d/subscriptions","organizations_url":"https://api.github.com/users/baylee-d/orgs","repos_url":"https://api.github.com/users/baylee-d/repos","events_url":"https://api.github.com/users/baylee-d/events{/privacy}","received_events_url":"https://api.github.com/users/baylee-d/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baylee-d/ember-osf","description":"Reusable ember models and components for interacting with the Open Science Framework","fork":true,"url":"https://api.github.com/repos/baylee-d/ember-osf","forks_url":"https://api.github.com/repos/baylee-d/ember-osf/forks","keys_url":"https://api.github.com/repos/baylee-d/ember-osf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baylee-d/ember-osf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baylee-d/ember-osf/teams","hooks_url":"https://api.github.com/repos/baylee-d/ember-osf/hooks","issue_events_url":"https://api.github.com/repos/baylee-d/ember-osf/issues/events{/number}","events_url":"https://api.github.com/repos/baylee-d/ember-osf/events","assignees_url":"https://api.github.com/repos/baylee-d/ember-osf/assignees{/user}","branches_url":"https://api.github.com/repos/baylee-d/ember-osf/branches{/branch}","tags_url":"https://api.github.com/repos/baylee-d/ember-osf/tags","blobs_url":"https://api.github.com/repos/baylee-d/ember-osf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baylee-d/ember-osf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baylee-d/ember-osf/git/refs{/sha}","trees_url":"https://api.github.com/repos/baylee-d/ember-osf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baylee-d/ember-osf/statuses/{sha}","languages_url":"https://api.github.com/repos/baylee-d/ember-osf/languages","stargazers_url":"https://api.github.com/repos/baylee-d/ember-osf/stargazers","contributors_url":"https://api.github.com/repos/baylee-d/ember-osf/contributors","subscribers_url":"https://api.github.com/repos/baylee-d/ember-osf/subscribers","subscription_url":"https://api.github.com/repos/baylee-d/ember-osf/subscription","commits_url":"https://api.github.com/repos/baylee-d/ember-osf/commits{/sha}","git_commits_url":"https://api.github.com/repos/baylee-d/ember-osf/git/commits{/sha}","comments_url":"https://api.github.com/repos/baylee-d/ember-osf/comments{/number}","issue_comment_url":"https://api.github.com/repos/baylee-d/ember-osf/issues/comments{/number}","contents_url":"https://api.github.com/repos/baylee-d/ember-osf/contents/{+path}","compare_url":"https://api.github.com/repos/baylee-d/ember-osf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baylee-d/ember-osf/merges","archive_url":"https://api.github.com/repos/baylee-d/ember-osf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baylee-d/ember-osf/downloads","issues_url":"https://api.github.com/repos/baylee-d/ember-osf/issues{/number}","pulls_url":"https://api.github.com/repos/baylee-d/ember-osf/pulls{/number}","milestones_url":"https://api.github.com/repos/baylee-d/ember-osf/milestones{/number}","notifications_url":"https://api.github.com/repos/baylee-d/ember-osf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baylee-d/ember-osf/labels{/name}","releases_url":"https://api.github.com/repos/baylee-d/ember-osf/releases{/id}","deployments_url":"https://api.github.com/repos/baylee-d/ember-osf/deployments","created_at":"2017-01-12T15:15:25Z","updated_at":"2017-01-12T15:15:28Z","pushed_at":"2018-04-19T13:38:44Z","git_url":"git://github.com/baylee-d/ember-osf.git","ssh_url":"git@github.com:baylee-d/ember-osf.git","clone_url":"https://github.com/baylee-d/ember-osf.git","svn_url":"https://github.com/baylee-d/ember-osf","homepage":"http://centerforopenscience.github.io/ember-osf/","size":9359,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:release/next-interfaces","ref":"release/next-interfaces","sha":"92fe4753501e55b11cd7a9bd799b330830e9eb37","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars1.githubusercontent.com/u/3344584?v=4","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":55632427,"name":"ember-osf","full_name":"CenterForOpenScience/ember-osf","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars1.githubusercontent.com/u/3344584?v=4","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/ember-osf","description":"Ember Addon for interacting with the Open Science Framework","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/ember-osf","forks_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/deployments","created_at":"2016-04-06T18:51:35Z","updated_at":"2017-12-03T04:22:30Z","pushed_at":"2018-04-17T19:12:38Z","git_url":"git://github.com/CenterForOpenScience/ember-osf.git","ssh_url":"git@github.com:CenterForOpenScience/ember-osf.git","clone_url":"https://github.com/CenterForOpenScience/ember-osf.git","svn_url":"https://github.com/CenterForOpenScience/ember-osf","homepage":"http://centerforopenscience.github.io/ember-osf/","size":9447,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":32,"open_issues":14,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/380"},"html":{"href":"https://github.com/CenterForOpenScience/ember-osf/pull/380"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/380"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/statuses/7ced1970afcb1ba3dfd610b197b6966736942ba7"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":18,"deletions":18,"changed_files":2}}
{"actor":{"display_login":"baylee-d"}}