{"action":"created","issue":{"url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/58","repository_url":"https://api.github.com/repos/Betterment/test_track_rails_client","labels_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/58/comments","events_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/58/events","html_url":"https://github.com/Betterment/test_track_rails_client/pull/58","id":331369698,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTE4MTQ2","number":58,"title":"Sample experience events","user":{"login":"jmileham","id":40619,"node_id":"MDQ6VXNlcjQwNjE5","avatar_url":"https://avatars0.githubusercontent.com/u/40619?v=4","gravatar_id":"","url":"https://api.github.com/users/jmileham","html_url":"https://github.com/jmileham","followers_url":"https://api.github.com/users/jmileham/followers","following_url":"https://api.github.com/users/jmileham/following{/other_user}","gists_url":"https://api.github.com/users/jmileham/gists{/gist_id}","starred_url":"https://api.github.com/users/jmileham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmileham/subscriptions","organizations_url":"https://api.github.com/users/jmileham/orgs","repos_url":"https://api.github.com/users/jmileham/repos","events_url":"https://api.github.com/users/jmileham/events{/privacy}","received_events_url":"https://api.github.com/users/jmileham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-06-11T22:15:10Z","updated_at":"2018-06-14T19:59:04Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Betterment/test_track_rails_client/pulls/58","html_url":"https://github.com/Betterment/test_track_rails_client/pull/58","diff_url":"https://github.com/Betterment/test_track_rails_client/pull/58.diff","patch_url":"https://github.com/Betterment/test_track_rails_client/pull/58.patch"},"body":"/domain @Betterment/test_track_core \r\n/domain @samandmoore @aburgel \r\n\r\nOk, here's the client side lib changes that pull in the new v2 split_registry and then respect the `experience_sampling_weight` property when sending analytics events.\r\n\r\nI haven't tested this in an app yet, but I will before merging. The test suites pass. The second commit is big because it's a big hop to take that much API shape change and get the tests passing, but it's reasonably mechanical.\r\n\r\nWe continue to publish a v1-style split registry in the HTML for the JS client. At some point that'll want to change, but not til the JS client supports v2 split registries too. That'll be when we want to consider GZipping too."},"comment":{"url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/comments/397419926","html_url":"https://github.com/Betterment/test_track_rails_client/pull/58#issuecomment-397419926","issue_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/58","id":397419926,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzQxOTkyNg==","user":{"login":"nanda-prbot","id":13210998,"node_id":"MDQ6VXNlcjEzMjEwOTk4","avatar_url":"https://avatars2.githubusercontent.com/u/13210998?v=4","gravatar_id":"","url":"https://api.github.com/users/nanda-prbot","html_url":"https://github.com/nanda-prbot","followers_url":"https://api.github.com/users/nanda-prbot/followers","following_url":"https://api.github.com/users/nanda-prbot/following{/other_user}","gists_url":"https://api.github.com/users/nanda-prbot/gists{/gist_id}","starred_url":"https://api.github.com/users/nanda-prbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanda-prbot/subscriptions","organizations_url":"https://api.github.com/users/nanda-prbot/orgs","repos_url":"https://api.github.com/users/nanda-prbot/repos","events_url":"https://api.github.com/users/nanda-prbot/events{/privacy}","received_events_url":"https://api.github.com/users/nanda-prbot/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T19:59:04Z","updated_at":"2018-06-14T19:59:04Z","author_association":"NONE","body":"Needs @samandmoore to provide domain review\r\nNeeds @aburgel to provide platform review\r\n\r\nWhen you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:\r\n> `TAFN` or `DomainLGTM`\r\n\r\nIf you're too busy to review, unclaim the PR, e.g.:\r\n> `@myname >> domain`"}}
{"actor":{"display_login":"nanda-prbot"}}