{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/rcl/pulls/comments/233687182","pull_request_review_id":175160238,"id":233687182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzY4NzE4Mg==","diff_hunk":"@@ -771,16 +770,31 @@ rcl_action_server_get_options(const rcl_action_server_t * action_server);\n  * Lock-Free          | Yes\n  *\n  * \\param[in] action_server pointer to the rcl action server\n+ * \\param[out] goal_handles is set to the array of pointers to goal handles if successful.\n  * \\param[out] num_goals is set to the number of goals in the returned array if successful,\n  *   not set otherwise.\n- * \\return pointer to an array goal handles if successful, otherwise `NULL`\n+ * \\return RCL_RET_OK if successful, or\n+ * \\return RCL_RET_ACTION_SERVER_INVALID if the action server is invalid, or\n+ * \\return RCL_RET_INVALID_ARGUMENT if any arguments are invalid\n  */\n RCL_ACTION_PUBLIC\n RCL_WARN_UNUSED\n-const rcl_action_goal_handle_t *\n+rcl_ret_t\n rcl_action_server_get_goal_handles(\n   const rcl_action_server_t * action_server,\n-  uint32_t * num_goals);\n+  rcl_action_goal_handle_t *** goal_handles,\n+  size_t * num_goals);\n+\n+/// Check if a goal is already being tracked by an action server\n+/**\n+ * TODO(jacobperron): Document","path":"rcl_action/include/rcl_action/action_server.h","position":null,"original_position":217,"commit_id":"c6b436ebc7d099ff3378886142f2895210d63070","original_commit_id":"7903df9cde00a99f5521aa39225d2e1869a38dad","user":{"login":"jacobperron","id":1218431,"node_id":"MDQ6VXNlcjEyMTg0MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1218431?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobperron","html_url":"https://github.com/jacobperron","followers_url":"https://api.github.com/users/jacobperron/followers","following_url":"https://api.github.com/users/jacobperron/following{/other_user}","gists_url":"https://api.github.com/users/jacobperron/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobperron/subscriptions","organizations_url":"https://api.github.com/users/jacobperron/orgs","repos_url":"https://api.github.com/users/jacobperron/repos","events_url":"https://api.github.com/users/jacobperron/events{/privacy}","received_events_url":"https://api.github.com/users/jacobperron/received_events","type":"User","site_admin":false},"body":"Addressed in 7c4f579","created_at":"2018-11-15T01:45:16Z","updated_at":"2018-11-15T01:45:16Z","html_url":"https://github.com/ros2/rcl/pull/323#discussion_r233687182","pull_request_url":"https://api.github.com/repos/ros2/rcl/pulls/323","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ros2/rcl/pulls/comments/233687182"},"html":{"href":"https://github.com/ros2/rcl/pull/323#discussion_r233687182"},"pull_request":{"href":"https://api.github.com/repos/ros2/rcl/pulls/323"}},"in_reply_to_id":233544084},"pull_request":{"url":"https://api.github.com/repos/ros2/rcl/pulls/323","id":229467537,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDY3NTM3","html_url":"https://github.com/ros2/rcl/pull/323","diff_url":"https://github.com/ros2/rcl/pull/323.diff","patch_url":"https://github.com/ros2/rcl/pull/323.patch","issue_url":"https://api.github.com/repos/ros2/rcl/issues/323","number":323,"state":"open","locked":false,"title":"Action server implementation","user":{"login":"jacobperron","id":1218431,"node_id":"MDQ6VXNlcjEyMTg0MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1218431?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobperron","html_url":"https://github.com/jacobperron","followers_url":"https://api.github.com/users/jacobperron/followers","following_url":"https://api.github.com/users/jacobperron/following{/other_user}","gists_url":"https://api.github.com/users/jacobperron/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobperron/subscriptions","organizations_url":"https://api.github.com/users/jacobperron/orgs","repos_url":"https://api.github.com/users/jacobperron/repos","events_url":"https://api.github.com/users/jacobperron/events{/privacy}","received_events_url":"https://api.github.com/users/jacobperron/received_events","type":"User","site_admin":false},"body":"First iteration of implementation.\r\n\r\nConnects to #306 \r\nDepends on ros2/rcl_interfaces#47\r\nDepends on ros2/rosidl#310","created_at":"2018-11-08T18:36:39Z","updated_at":"2018-11-15T01:45:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19e236e3e5dfeaa4ed7e48e143dd12a48270c4c2","assignee":{"login":"jacobperron","id":1218431,"node_id":"MDQ6VXNlcjEyMTg0MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1218431?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobperron","html_url":"https://github.com/jacobperron","followers_url":"https://api.github.com/users/jacobperron/followers","following_url":"https://api.github.com/users/jacobperron/following{/other_user}","gists_url":"https://api.github.com/users/jacobperron/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobperron/subscriptions","organizations_url":"https://api.github.com/users/jacobperron/orgs","repos_url":"https://api.github.com/users/jacobperron/repos","events_url":"https://api.github.com/users/jacobperron/events{/privacy}","received_events_url":"https://api.github.com/users/jacobperron/received_events","type":"User","site_admin":false},"assignees":[{"login":"jacobperron","id":1218431,"node_id":"MDQ6VXNlcjEyMTg0MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1218431?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobperron","html_url":"https://github.com/jacobperron","followers_url":"https://api.github.com/users/jacobperron/followers","following_url":"https://api.github.com/users/jacobperron/following{/other_user}","gists_url":"https://api.github.com/users/jacobperron/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobperron/subscriptions","organizations_url":"https://api.github.com/users/jacobperron/orgs","repos_url":"https://api.github.com/users/jacobperron/repos","events_url":"https://api.github.com/users/jacobperron/events{/privacy}","received_events_url":"https://api.github.com/users/jacobperron/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":180241238,"node_id":"MDU6TGFiZWwxODAyNDEyMzg=","url":"https://api.github.com/repos/ros2/rcl/labels/in%20review","name":"in review","color":"388be2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rcl/pulls/323/commits","review_comments_url":"https://api.github.com/repos/ros2/rcl/pulls/323/comments","review_comment_url":"https://api.github.com/repos/ros2/rcl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rcl/issues/323/comments","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/c6b436ebc7d099ff3378886142f2895210d63070","head":{"label":"ros2:jacob/action_server","ref":"jacob/action_server","sha":"c6b436ebc7d099ff3378886142f2895210d63070","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":31091419,"node_id":"MDEwOlJlcG9zaXRvcnkzMTA5MTQxOQ==","name":"rcl","full_name":"ros2/rcl","private":false,"owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros2/rcl","description":"Library to support implementation of language specific ROS Client Libraries.","fork":false,"url":"https://api.github.com/repos/ros2/rcl","forks_url":"https://api.github.com/repos/ros2/rcl/forks","keys_url":"https://api.github.com/repos/ros2/rcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rcl/teams","hooks_url":"https://api.github.com/repos/ros2/rcl/hooks","issue_events_url":"https://api.github.com/repos/ros2/rcl/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rcl/events","assignees_url":"https://api.github.com/repos/ros2/rcl/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rcl/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rcl/tags","blobs_url":"https://api.github.com/repos/ros2/rcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rcl/languages","stargazers_url":"https://api.github.com/repos/ros2/rcl/stargazers","contributors_url":"https://api.github.com/repos/ros2/rcl/contributors","subscribers_url":"https://api.github.com/repos/ros2/rcl/subscribers","subscription_url":"https://api.github.com/repos/ros2/rcl/subscription","commits_url":"https://api.github.com/repos/ros2/rcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rcl/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rcl/merges","archive_url":"https://api.github.com/repos/ros2/rcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rcl/downloads","issues_url":"https://api.github.com/repos/ros2/rcl/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rcl/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rcl/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rcl/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rcl/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rcl/deployments","created_at":"2015-02-21T00:06:40Z","updated_at":"2018-11-13T22:13:28Z","pushed_at":"2018-11-15T01:44:49Z","git_url":"git://github.com/ros2/rcl.git","ssh_url":"git@github.com:ros2/rcl.git","clone_url":"https://github.com/ros2/rcl.git","svn_url":"https://github.com/ros2/rcl","homepage":null,"size":1113,"stargazers_count":22,"watchers_count":22,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":27,"open_issues":42,"watchers":22,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"8b00791a567afe7aea34e58063e52f743037228d","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":31091419,"node_id":"MDEwOlJlcG9zaXRvcnkzMTA5MTQxOQ==","name":"rcl","full_name":"ros2/rcl","private":false,"owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros2/rcl","description":"Library to support implementation of language specific ROS Client Libraries.","fork":false,"url":"https://api.github.com/repos/ros2/rcl","forks_url":"https://api.github.com/repos/ros2/rcl/forks","keys_url":"https://api.github.com/repos/ros2/rcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rcl/teams","hooks_url":"https://api.github.com/repos/ros2/rcl/hooks","issue_events_url":"https://api.github.com/repos/ros2/rcl/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rcl/events","assignees_url":"https://api.github.com/repos/ros2/rcl/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rcl/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rcl/tags","blobs_url":"https://api.github.com/repos/ros2/rcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rcl/languages","stargazers_url":"https://api.github.com/repos/ros2/rcl/stargazers","contributors_url":"https://api.github.com/repos/ros2/rcl/contributors","subscribers_url":"https://api.github.com/repos/ros2/rcl/subscribers","subscription_url":"https://api.github.com/repos/ros2/rcl/subscription","commits_url":"https://api.github.com/repos/ros2/rcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rcl/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rcl/merges","archive_url":"https://api.github.com/repos/ros2/rcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rcl/downloads","issues_url":"https://api.github.com/repos/ros2/rcl/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rcl/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rcl/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rcl/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rcl/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rcl/deployments","created_at":"2015-02-21T00:06:40Z","updated_at":"2018-11-13T22:13:28Z","pushed_at":"2018-11-15T01:44:49Z","git_url":"git://github.com/ros2/rcl.git","ssh_url":"git@github.com:ros2/rcl.git","clone_url":"https://github.com/ros2/rcl.git","svn_url":"https://github.com/ros2/rcl","homepage":null,"size":1113,"stargazers_count":22,"watchers_count":22,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":27,"open_issues":42,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rcl/pulls/323"},"html":{"href":"https://github.com/ros2/rcl/pull/323"},"issue":{"href":"https://api.github.com/repos/ros2/rcl/issues/323"},"comments":{"href":"https://api.github.com/repos/ros2/rcl/issues/323/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rcl/pulls/323/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rcl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rcl/pulls/323/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rcl/statuses/c6b436ebc7d099ff3378886142f2895210d63070"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jacobperron"}}