{"action":"created","issue":{"url":"https://api.github.com/repos/lucas-clemente/quic-go/issues/1692","repository_url":"https://api.github.com/repos/lucas-clemente/quic-go","labels_url":"https://api.github.com/repos/lucas-clemente/quic-go/issues/1692/labels{/name}","comments_url":"https://api.github.com/repos/lucas-clemente/quic-go/issues/1692/comments","events_url":"https://api.github.com/repos/lucas-clemente/quic-go/issues/1692/events","html_url":"https://github.com/lucas-clemente/quic-go/pull/1692","id":394562891,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMjc2NTk1","number":1692,"title":"unify TLP and RTO","user":{"login":"marten-seemann","id":1478487,"node_id":"MDQ6VXNlcjE0Nzg0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1478487?v=4","gravatar_id":"","url":"https://api.github.com/users/marten-seemann","html_url":"https://github.com/marten-seemann","followers_url":"https://api.github.com/users/marten-seemann/followers","following_url":"https://api.github.com/users/marten-seemann/following{/other_user}","gists_url":"https://api.github.com/users/marten-seemann/gists{/gist_id}","starred_url":"https://api.github.com/users/marten-seemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marten-seemann/subscriptions","organizations_url":"https://api.github.com/users/marten-seemann/orgs","repos_url":"https://api.github.com/users/marten-seemann/repos","events_url":"https://api.github.com/users/marten-seemann/events{/privacy}","received_events_url":"https://api.github.com/users/marten-seemann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-28T06:53:47Z","updated_at":"2018-12-28T07:09:31Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/lucas-clemente/quic-go/pulls/1692","html_url":"https://github.com/lucas-clemente/quic-go/pull/1692","diff_url":"https://github.com/lucas-clemente/quic-go/pull/1692.diff","patch_url":"https://github.com/lucas-clemente/quic-go/pull/1692.patch"},"body":"Fixes #1673.\r\n\r\nThis doesn't yet implement the persistent congestion detection (#1691), since the specification of that still is in flux."},"comment":{"url":"https://api.github.com/repos/lucas-clemente/quic-go/issues/comments/450304412","html_url":"https://github.com/lucas-clemente/quic-go/pull/1692#issuecomment-450304412","issue_url":"https://api.github.com/repos/lucas-clemente/quic-go/issues/1692","id":450304412,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDMwNDQxMg==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-12-28T07:09:31Z","updated_at":"2018-12-28T07:09:31Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692?src=pr&el=h1) Report\n> Merging [#1692](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692?src=pr&el=desc) into [master](https://codecov.io/gh/lucas-clemente/quic-go/commit/3d2d45d53ff9d48b29d8a44c88555ab67912be03?src=pr&el=desc) will **decrease** coverage by `0.07%`.\n> The diff coverage is `91.67%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692/graphs/tree.svg?width=650&token=wiCIUQmLJj&height=150&src=pr)](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1692      +/-   ##\n==========================================\n- Coverage   87.39%   87.32%   -0.07%     \n==========================================\n  Files          96       96              \n  Lines        6263     6230      -33     \n==========================================\n- Hits         5473     5440      -33     \n- Misses        558      559       +1     \n+ Partials      232      231       -1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [session.go](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `73.43% <100%> (-0.32%)` | :arrow_down: |\n| [internal/ackhandler/send\\_mode.go](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692/diff?src=pr&el=tree#diff-aW50ZXJuYWwvYWNraGFuZGxlci9zZW5kX21vZGUuZ28=) | `100% <100%> (ø)` | :arrow_up: |\n| [internal/ackhandler/sent\\_packet\\_history.go](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692/diff?src=pr&el=tree#diff-aW50ZXJuYWwvYWNraGFuZGxlci9zZW50X3BhY2tldF9oaXN0b3J5Lmdv) | `90.91% <71.43%> (ø)` | :arrow_up: |\n| [internal/ackhandler/sent\\_packet\\_handler.go](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692/diff?src=pr&el=tree#diff-aW50ZXJuYWwvYWNraGFuZGxlci9zZW50X3BhY2tldF9oYW5kbGVyLmdv) | `75.33% <94.74%> (-1.71%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692?src=pr&el=footer). Last update [3d2d45d...71e03e3](https://codecov.io/gh/lucas-clemente/quic-go/pull/1692?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}