{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/183754248","pull_request_review_id":114812145,"id":183754248,"diff_hunk":"@@ -303,11 +303,15 @@ class AdminManager(val config: KafkaConfig,\n \n           case ResourceType.TOPIC =>\n             val topic = resource.name\n-            Topic.validate(topic)\n-            // Consider optimizing this by caching the configs or retrieving them from the `Log` when possible\n-            val topicProps = adminZkClient.fetchEntityConfig(ConfigType.Topic, topic)\n-            val logConfig = LogConfig.fromProps(KafkaServer.copyKafkaConfigToLog(config), topicProps)\n-            createResponseConfig(allConfigs(logConfig), createTopicConfigEntry(logConfig, topicProps, includeSynonyms))\n+            if (metadataCache.contains(topic)) {\n+              Topic.validate(topic)\n+              // Consider optimizing this by caching the configs or retrieving them from the `Log` when possible\n+              val topicProps = adminZkClient.fetchEntityConfig(ConfigType.Topic, topic)","path":"core/src/main/scala/kafka/server/AdminManager.scala","position":12,"original_position":12,"commit_id":"85566f8f4ba4029a1ae9042ba328163c1c6686e8","original_commit_id":"85566f8f4ba4029a1ae9042ba328163c1c6686e8","user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars2.githubusercontent.com/u/24747?v=4","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"body":"I'm suggesting that it's a better approach than the one in the current PR.","created_at":"2018-04-24T14:33:40Z","updated_at":"2018-04-24T14:33:40Z","html_url":"https://github.com/apache/kafka/pull/4866#discussion_r183754248","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4866","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/183754248"},"html":{"href":"https://github.com/apache/kafka/pull/4866#discussion_r183754248"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4866"}},"in_reply_to_id":181479992},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4866","id":181435273,"html_url":"https://github.com/apache/kafka/pull/4866","diff_url":"https://github.com/apache/kafka/pull/4866.diff","patch_url":"https://github.com/apache/kafka/pull/4866.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4866","number":4866,"state":"open","locked":false,"title":"KAFKA-6778: AdminClient.describeConfigs() should return error for non-existent topics","user":{"login":"omkreddy","id":8134545,"avatar_url":"https://avatars2.githubusercontent.com/u/8134545?v=4","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-13T09:37:38Z","updated_at":"2018-04-24T14:33:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0695a0b064207fc940aebe92e6289fc8b395e7ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4866/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4866/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4866/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/85566f8f4ba4029a1ae9042ba328163c1c6686e8","head":{"label":"omkreddy:KAFKA-6778-DESCRIBE-CONFIG","ref":"KAFKA-6778-DESCRIBE-CONFIG","sha":"85566f8f4ba4029a1ae9042ba328163c1c6686e8","user":{"login":"omkreddy","id":8134545,"avatar_url":"https://avatars2.githubusercontent.com/u/8134545?v=4","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"repo":{"id":51066257,"name":"kafka","full_name":"omkreddy/kafka","owner":{"login":"omkreddy","id":8134545,"avatar_url":"https://avatars2.githubusercontent.com/u/8134545?v=4","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omkreddy/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/omkreddy/kafka","forks_url":"https://api.github.com/repos/omkreddy/kafka/forks","keys_url":"https://api.github.com/repos/omkreddy/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omkreddy/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omkreddy/kafka/teams","hooks_url":"https://api.github.com/repos/omkreddy/kafka/hooks","issue_events_url":"https://api.github.com/repos/omkreddy/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/omkreddy/kafka/events","assignees_url":"https://api.github.com/repos/omkreddy/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/omkreddy/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/omkreddy/kafka/tags","blobs_url":"https://api.github.com/repos/omkreddy/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omkreddy/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omkreddy/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/omkreddy/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omkreddy/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/omkreddy/kafka/languages","stargazers_url":"https://api.github.com/repos/omkreddy/kafka/stargazers","contributors_url":"https://api.github.com/repos/omkreddy/kafka/contributors","subscribers_url":"https://api.github.com/repos/omkreddy/kafka/subscribers","subscription_url":"https://api.github.com/repos/omkreddy/kafka/subscription","commits_url":"https://api.github.com/repos/omkreddy/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/omkreddy/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/omkreddy/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/omkreddy/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/omkreddy/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/omkreddy/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omkreddy/kafka/merges","archive_url":"https://api.github.com/repos/omkreddy/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omkreddy/kafka/downloads","issues_url":"https://api.github.com/repos/omkreddy/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/omkreddy/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/omkreddy/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/omkreddy/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omkreddy/kafka/labels{/name}","releases_url":"https://api.github.com/repos/omkreddy/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/omkreddy/kafka/deployments","created_at":"2016-02-04T09:42:20Z","updated_at":"2018-03-24T04:45:43Z","pushed_at":"2018-04-23T16:58:27Z","git_url":"git://github.com/omkreddy/kafka.git","ssh_url":"git@github.com:omkreddy/kafka.git","clone_url":"https://github.com/omkreddy/kafka.git","svn_url":"https://github.com/omkreddy/kafka","homepage":null,"size":62235,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"886daf5fca70846ad0ce5b85f2522cf08b08ee44","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-04-24T13:04:21Z","pushed_at":"2018-04-24T08:12:57Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":64393,"stargazers_count":8088,"watchers_count":8088,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4757,"mirror_url":null,"archived":false,"open_issues_count":456,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4757,"open_issues":456,"watchers":8088,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4866"},"html":{"href":"https://github.com/apache/kafka/pull/4866"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4866"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4866/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4866/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4866/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/85566f8f4ba4029a1ae9042ba328163c1c6686e8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ijuma"}}