{"action":"created","comment":{"url":"https://api.github.com/repos/edx/paragon/pulls/comments/190902402","pull_request_review_id":123382213,"id":190902402,"diff_hunk":"@@ -0,0 +1,26 @@\n+# ListBoxOption:\n+\n+Provides an ListBoxOption component that is passed as a child to the ListBox component.\n+\n+## API","path":"src/Option/README.md","position":5,"original_position":5,"commit_id":"afa006a0a04ed772593cff77c8844a2fc6080539","original_commit_id":"afa006a0a04ed772593cff77c8844a2fc6080539","user":{"login":"MichaelRoytman","id":11871801,"avatar_url":"https://avatars3.githubusercontent.com/u/11871801?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelRoytman","html_url":"https://github.com/MichaelRoytman","followers_url":"https://api.github.com/users/MichaelRoytman/followers","following_url":"https://api.github.com/users/MichaelRoytman/following{/other_user}","gists_url":"https://api.github.com/users/MichaelRoytman/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelRoytman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelRoytman/subscriptions","organizations_url":"https://api.github.com/users/MichaelRoytman/orgs","repos_url":"https://api.github.com/users/MichaelRoytman/repos","events_url":"https://api.github.com/users/MichaelRoytman/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelRoytman/received_events","type":"User","site_admin":false},"body":"My one concern is that focusing on the ListBox is the only way to interact with it with the keyboard. The pattern is that the ListBox gets focus and then you navigate through the ListBoxOptions with the arrow keys. The ListBox is also supposed to auto-select the first ListBoxOption if you focus on the ListBox for the first time, and I was a little worried about an onFocus prop providing the opportunity to break accessibility without the consumer knowing (e.g. they choose to select the last option onFocus with the selectedOptionIndex prop or something). I definitely see the use for onFocus and onBlur, and they seem to be common props to expore. Do you think we should just expose them and put the onus on the user to know when they're breaking accessibility patterns? ","created_at":"2018-05-25T13:57:47Z","updated_at":"2018-05-25T13:57:47Z","html_url":"https://github.com/edx/paragon/pull/253#discussion_r190902402","pull_request_url":"https://api.github.com/repos/edx/paragon/pulls/253","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edx/paragon/pulls/comments/190902402"},"html":{"href":"https://github.com/edx/paragon/pull/253#discussion_r190902402"},"pull_request":{"href":"https://api.github.com/repos/edx/paragon/pulls/253"}},"in_reply_to_id":190636618},"pull_request":{"url":"https://api.github.com/repos/edx/paragon/pulls/253","id":189154661,"html_url":"https://github.com/edx/paragon/pull/253","diff_url":"https://github.com/edx/paragon/pull/253.diff","patch_url":"https://github.com/edx/paragon/pull/253.patch","issue_url":"https://api.github.com/repos/edx/paragon/issues/253","number":253,"state":"open","locked":false,"title":"feat(listbox): add ListBox and Option READMEs","user":{"login":"MichaelRoytman","id":11871801,"avatar_url":"https://avatars3.githubusercontent.com/u/11871801?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelRoytman","html_url":"https://github.com/MichaelRoytman","followers_url":"https://api.github.com/users/MichaelRoytman/followers","following_url":"https://api.github.com/users/MichaelRoytman/following{/other_user}","gists_url":"https://api.github.com/users/MichaelRoytman/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelRoytman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelRoytman/subscriptions","organizations_url":"https://api.github.com/users/MichaelRoytman/orgs","repos_url":"https://api.github.com/users/MichaelRoytman/repos","events_url":"https://api.github.com/users/MichaelRoytman/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelRoytman/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-18T23:17:52Z","updated_at":"2018-05-25T13:57:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a524979a5dbb48f6bcd4e50e3d09af5fb7216c42","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":756046437,"url":"https://api.github.com/repos/edx/paragon/labels/ready%20for%20review","name":"ready for review","color":"00FF00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/edx/paragon/pulls/253/commits","review_comments_url":"https://api.github.com/repos/edx/paragon/pulls/253/comments","review_comment_url":"https://api.github.com/repos/edx/paragon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/paragon/issues/253/comments","statuses_url":"https://api.github.com/repos/edx/paragon/statuses/afa006a0a04ed772593cff77c8844a2fc6080539","head":{"label":"edx:mroytman/listbox","ref":"mroytman/listbox","sha":"afa006a0a04ed772593cff77c8844a2fc6080539","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":89630641,"name":"paragon","full_name":"edx/paragon","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/paragon","description":"💎 Accessible components done right.","fork":false,"url":"https://api.github.com/repos/edx/paragon","forks_url":"https://api.github.com/repos/edx/paragon/forks","keys_url":"https://api.github.com/repos/edx/paragon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/paragon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/paragon/teams","hooks_url":"https://api.github.com/repos/edx/paragon/hooks","issue_events_url":"https://api.github.com/repos/edx/paragon/issues/events{/number}","events_url":"https://api.github.com/repos/edx/paragon/events","assignees_url":"https://api.github.com/repos/edx/paragon/assignees{/user}","branches_url":"https://api.github.com/repos/edx/paragon/branches{/branch}","tags_url":"https://api.github.com/repos/edx/paragon/tags","blobs_url":"https://api.github.com/repos/edx/paragon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/paragon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/paragon/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/paragon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/paragon/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/paragon/languages","stargazers_url":"https://api.github.com/repos/edx/paragon/stargazers","contributors_url":"https://api.github.com/repos/edx/paragon/contributors","subscribers_url":"https://api.github.com/repos/edx/paragon/subscribers","subscription_url":"https://api.github.com/repos/edx/paragon/subscription","commits_url":"https://api.github.com/repos/edx/paragon/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/paragon/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/paragon/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/paragon/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/paragon/contents/{+path}","compare_url":"https://api.github.com/repos/edx/paragon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/paragon/merges","archive_url":"https://api.github.com/repos/edx/paragon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/paragon/downloads","issues_url":"https://api.github.com/repos/edx/paragon/issues{/number}","pulls_url":"https://api.github.com/repos/edx/paragon/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/paragon/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/paragon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/paragon/labels{/name}","releases_url":"https://api.github.com/repos/edx/paragon/releases{/id}","deployments_url":"https://api.github.com/repos/edx/paragon/deployments","created_at":"2017-04-27T18:57:22Z","updated_at":"2018-05-25T07:14:57Z","pushed_at":"2018-05-24T19:31:59Z","git_url":"git://github.com/edx/paragon.git","ssh_url":"git@github.com:edx/paragon.git","clone_url":"https://github.com/edx/paragon.git","svn_url":"https://github.com/edx/paragon","homepage":"https://edx.github.io/paragon","size":3659,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":41,"watchers":16,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"44f3733ed4d842f5480b4cd8184ca02b9cffdc77","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":89630641,"name":"paragon","full_name":"edx/paragon","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/paragon","description":"💎 Accessible components done right.","fork":false,"url":"https://api.github.com/repos/edx/paragon","forks_url":"https://api.github.com/repos/edx/paragon/forks","keys_url":"https://api.github.com/repos/edx/paragon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/paragon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/paragon/teams","hooks_url":"https://api.github.com/repos/edx/paragon/hooks","issue_events_url":"https://api.github.com/repos/edx/paragon/issues/events{/number}","events_url":"https://api.github.com/repos/edx/paragon/events","assignees_url":"https://api.github.com/repos/edx/paragon/assignees{/user}","branches_url":"https://api.github.com/repos/edx/paragon/branches{/branch}","tags_url":"https://api.github.com/repos/edx/paragon/tags","blobs_url":"https://api.github.com/repos/edx/paragon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/paragon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/paragon/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/paragon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/paragon/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/paragon/languages","stargazers_url":"https://api.github.com/repos/edx/paragon/stargazers","contributors_url":"https://api.github.com/repos/edx/paragon/contributors","subscribers_url":"https://api.github.com/repos/edx/paragon/subscribers","subscription_url":"https://api.github.com/repos/edx/paragon/subscription","commits_url":"https://api.github.com/repos/edx/paragon/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/paragon/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/paragon/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/paragon/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/paragon/contents/{+path}","compare_url":"https://api.github.com/repos/edx/paragon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/paragon/merges","archive_url":"https://api.github.com/repos/edx/paragon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/paragon/downloads","issues_url":"https://api.github.com/repos/edx/paragon/issues{/number}","pulls_url":"https://api.github.com/repos/edx/paragon/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/paragon/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/paragon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/paragon/labels{/name}","releases_url":"https://api.github.com/repos/edx/paragon/releases{/id}","deployments_url":"https://api.github.com/repos/edx/paragon/deployments","created_at":"2017-04-27T18:57:22Z","updated_at":"2018-05-25T07:14:57Z","pushed_at":"2018-05-24T19:31:59Z","git_url":"git://github.com/edx/paragon.git","ssh_url":"git@github.com:edx/paragon.git","clone_url":"https://github.com/edx/paragon.git","svn_url":"https://github.com/edx/paragon","homepage":"https://edx.github.io/paragon","size":3659,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":41,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/paragon/pulls/253"},"html":{"href":"https://github.com/edx/paragon/pull/253"},"issue":{"href":"https://api.github.com/repos/edx/paragon/issues/253"},"comments":{"href":"https://api.github.com/repos/edx/paragon/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/paragon/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/paragon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/paragon/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/edx/paragon/statuses/afa006a0a04ed772593cff77c8844a2fc6080539"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MichaelRoytman"}}