{"push_id":2402380659,"size":11,"distinct_size":3,"ref":"refs/heads/reset-rspec-inline-like-a-good-citizen","head":"c1c95de2534a1f64b68c36d17fa58cf1b7bee453","before":"7456e1ca654e05f9c61d355333e1254fbd8dacae","commits":[{"sha":"8345f07d4aa2436c99f9ebefc65d0c143911d397","author":{"name":"Thomas Leese","email":"453b5911afb76fe7e20d50f71a0e93708fcf7694@digital.cabinet-office.gov.uk"},"message":"Remove notification log table\n\nWe don't use it anymore as it was used by GovDelivery.","distinct":false,"url":"https://api.github.com/repos/alphagov/email-alert-api/commits/8345f07d4aa2436c99f9ebefc65d0c143911d397"},{"sha":"76127359866f5344ec372bc28d69bf7e2717be55","author":{"name":"Thomas Leese","email":"5f919b14acad347486cfcc925fe5476cb2791020@leese.io"},"message":"Merge pull request #521 from alphagov/remove-notification-log-table\n\nRemove notification log table","distinct":false,"url":"https://api.github.com/repos/alphagov/email-alert-api/commits/76127359866f5344ec372bc28d69bf7e2717be55"},{"sha":"a7465a265125aab780fc8c8ecadc649fd77566c2","author":{"name":"Thomas Leese","email":"453b5911afb76fe7e20d50f71a0e93708fcf7694@digital.cabinet-office.gov.uk"},"message":"Remove gov_delivery_id field\n\nIt's no longer being used, it was replaced by the slug field.","distinct":false,"url":"https://api.github.com/repos/alphagov/email-alert-api/commits/a7465a265125aab780fc8c8ecadc649fd77566c2"},{"sha":"fa5b6ddb519ad0b721a376c78e1d692f6b7f8e47","author":{"name":"Thomas Leese","email":"5f919b14acad347486cfcc925fe5476cb2791020@leese.io"},"message":"Merge pull request #519 from alphagov/remove-gov-delivery-id-field\n\nRemove gov_delivery_id field (4/4)","distinct":false,"url":"https://api.github.com/repos/alphagov/email-alert-api/commits/fa5b6ddb519ad0b721a376c78e1d692f6b7f8e47"},{"sha":"857e6d6152724bcfa3d65855331bd56a803c53bb","author":{"name":"Ruben Arakelyan","email":"726ecb119cc58a9c180801cd06edb4b28147ec93@digital.cabinet-office.gov.uk"},"message":"Fix manage rake task to use slugs\n\nThis commit changes the manage rake task to use `slug`s rather than `gov_delivery_id`s, which have been removed.","distinct":false,"url":"https://api.github.com/repos/alphagov/email-alert-api/commits/857e6d6152724bcfa3d65855331bd56a803c53bb"},{"sha":"02efd4aa89982417a3fdfc05b1a848ac46ea679a","author":{"name":"Ruben Arakelyan","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@arakelyan.uk"},"message":"Merge pull request #524 from alphagov/fix-manage-rake-task\n\nFix manage rake task to use slugs","distinct":false,"url":"https://api.github.com/repos/alphagov/email-alert-api/commits/02efd4aa89982417a3fdfc05b1a848ac46ea679a"},{"sha":"79a85e10f7e66fd8a66c3c9b6248432e602330bc","author":{"name":"Ruben Arakelyan","email":"726ecb119cc58a9c180801cd06edb4b28147ec93@digital.cabinet-office.gov.uk"},"message":"Add rake task to change a subscriber’s email address\n\nThis commit adds a rake task to change a subscriber’s email address.","distinct":false,"url":"https://api.github.com/repos/alphagov/email-alert-api/commits/79a85e10f7e66fd8a66c3c9b6248432e602330bc"},{"sha":"2e82d995bcb40bfc7bc216e3be1ba76dc341a134","author":{"name":"Ruben Arakelyan","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@arakelyan.uk"},"message":"Merge pull request #525 from alphagov/add-rake-task-to-change-email-addresses\n\nAdd rake task to change a subscriber’s email address","distinct":false,"url":"https://api.github.com/repos/alphagov/email-alert-api/commits/2e82d995bcb40bfc7bc216e3be1ba76dc341a134"},{"sha":"f26b4e02e15c664b8e3c72c53dbf7ca18b732a9e","author":{"name":"Bevan Loon","email":"c5d4925a4f4b2291eef91e4c16c12f7ac6a50091@digital.cabinet-office.gov.uk"},"message":"Use an around block to properly isolate Sidekiq's fake\n\nOur default state for our tests is for Sidekiq to be `inline`. The\nnotification handler service test relies on setting `fake` to be true.\nUse an around block so we properly isolate this and don't leak the state\nthrough to the rest of the tests.","distinct":true,"url":"https://api.github.com/repos/alphagov/email-alert-api/commits/f26b4e02e15c664b8e3c72c53dbf7ca18b732a9e"},{"sha":"e2c3f84afed13e392a2f01b5273c6b812852fd28","author":{"name":"Bevan Loon","email":"c5d4925a4f4b2291eef91e4c16c12f7ac6a50091@digital.cabinet-office.gov.uk"},"message":"Fix broken SubscriptionContentWorker test\n\nNow that Sidekiq is working as intended and running `inline`, we have a\nsmall testing anomaly:\n\nWe stub ImmediateEmailBuilder's interaction which means an Email is not\ncreated in the database. When DeliveryRequestWorker tries to find\nthat email, it fails.\n\nFix this - in this instance we don't really care about\nDeliveryRequestWorker so we can stub it to return true.","distinct":true,"url":"https://api.github.com/repos/alphagov/email-alert-api/commits/e2c3f84afed13e392a2f01b5273c6b812852fd28"},{"sha":"c1c95de2534a1f64b68c36d17fa58cf1b7bee453","author":{"name":"Bevan Loon","email":"c5d4925a4f4b2291eef91e4c16c12f7ac6a50091@digital.cabinet-office.gov.uk"},"message":"Properly isolate the temporary failure state in testing\n\nWhen an email has a temporary failure, we set it to retry delivery in 15\nminutes time. We want to  test that during the temporary failure state, we\ndo not set a `finished_sending_at` time on the Email. We have set up\n`Sidekiq::Testing.inline!` in our `spec/rails_helper.rb` which means any\nSidekiq jobs are immediately fired. The side effect of this is when\ntesting a temporary failure, we end up immediately sending a new\ndelivery attempt which succeeds and sets the `finished_sending_at` field\non the Email before we can assert that it is `nil`. To avoid this\nbehaviour, we wrap this test in `Sidekiq::Testing.fake!` which pushes\njobs on to an array rather than immediately firing them.","distinct":true,"url":"https://api.github.com/repos/alphagov/email-alert-api/commits/c1c95de2534a1f64b68c36d17fa58cf1b7bee453"}]}
{"actor":{"display_login":"bevanloon"}}