{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments/245051238","pull_request_review_id":189077469,"id":245051238,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTA1MTIzOA==","diff_hunk":"@@ -21,27 +23,43 @@\n \n class <?= $class_name; ?> extends AbstractFormLoginAuthenticator\n {\n-    use TargetPathTrait;\n-\n-<?= $user_is_entity ? \"    private \\$entityManager;\\n\" : null ?>\n+<?= $user_is_entity ? \"    /** @var EntityManagerInterface */\" . PHP_EOL . \"    private \\$entityManager;\" . PHP_EOL . PHP_EOL : null ?>","path":"src/Resources/skeleton/authenticator/LoginFormAuthenticator.tpl.php","position":29,"original_position":29,"commit_id":"4879f6dce1625ced27fa1a86cb60598b377f18a8","original_commit_id":"4879f6dce1625ced27fa1a86cb60598b377f18a8","user":{"login":"javiereguiluz","id":73419,"node_id":"MDQ6VXNlcjczNDE5","avatar_url":"https://avatars3.githubusercontent.com/u/73419?v=4","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"body":"The `@var` annotations in these properties and the `__cosntruct()` method's `@param` are not needed because constructor arguments are type-hinted and IDEs can infer the types.","created_at":"2019-01-03T16:16:46Z","updated_at":"2019-01-03T16:22:42Z","html_url":"https://github.com/symfony/maker-bundle/pull/284#discussion_r245051238","pull_request_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/284","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments/245051238"},"html":{"href":"https://github.com/symfony/maker-bundle/pull/284#discussion_r245051238"},"pull_request":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/maker-bundle/pulls/284","id":220357710,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMzU3NzEw","html_url":"https://github.com/symfony/maker-bundle/pull/284","diff_url":"https://github.com/symfony/maker-bundle/pull/284.diff","patch_url":"https://github.com/symfony/maker-bundle/pull/284.patch","issue_url":"https://api.github.com/repos/symfony/maker-bundle/issues/284","number":284,"state":"open","locked":false,"title":"Adding PHPDocs to templates","user":{"login":"wow-apps","id":2779949,"node_id":"MDQ6VXNlcjI3Nzk5NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/2779949?v=4","gravatar_id":"","url":"https://api.github.com/users/wow-apps","html_url":"https://github.com/wow-apps","followers_url":"https://api.github.com/users/wow-apps/followers","following_url":"https://api.github.com/users/wow-apps/following{/other_user}","gists_url":"https://api.github.com/users/wow-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/wow-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wow-apps/subscriptions","organizations_url":"https://api.github.com/users/wow-apps/orgs","repos_url":"https://api.github.com/users/wow-apps/repos","events_url":"https://api.github.com/users/wow-apps/events{/privacy}","received_events_url":"https://api.github.com/users/wow-apps/received_events","type":"User","site_admin":false},"body":"# PR Changelog\r\n\r\n## 99% of changes are adding PHPDocs\r\n\r\n### EmptyAuthenticator.tpl.php\r\n`src/Resources/skeleton/authenticator/EmptyAuthenticator.tpl.php`\r\n* Added PHPDocs for class and methods\r\n* Added method `createAuthenticatedToken` from `Symfony\\Component\\Security\\Guard\\AuthenticatorInterface`\r\n\r\n### EmptySecurityController.tpl.php\r\n`src/Resources/skeleton/authenticator/EmptySecurityController.tpl.php`\r\n* Added PHPDoc for class\r\n\r\n### LoginFormAuthenticator.tpl.php\r\n`src/Resources/skeleton/authenticator/LoginFormAuthenticator.tpl.php`\r\n* Added PHPDocs for class and methods\r\n* Removed `use TargetPathTrait;` - it's already used in extended class\r\n\r\n### Command.tpl.php\r\n`src/Resources/skeleton/command/Command.tpl.php`\r\n* Added PHPDocs for class, methods and variable\r\n\r\n### Controller.tpl.php\r\n`src/Resources/skeleton/controller/Controller.tpl.php`\r\n* Added PHPDocs for class and method\r\n\r\n### Controller.tpl.php\r\n`src/Resources/skeleton/crud/controller/Controller.tpl.php`\r\n* Added PHPDocs for class and method\r\n\r\n### Entity.tpl.php\r\n`src/Resources/skeleton/doctrine/Entity.tpl.php`\r\n* Added PHPDocs for class, variable and method\r\n\r\n### Fixtures.tpl.php\r\n`src/Resources/skeleton/doctrine/Fixtures.tpl.php`\r\n* Added PHPDocs for class and method\r\n\r\n### Repository.tpl.php\r\n`src/Resources/skeleton/doctrine/Repository.tpl.php`\r\n* Added PHPDocs for class and methods\r\n\r\n### Subscriber.tpl.php\r\n`src/Resources/skeleton/event/Subscriber.tpl.php`\r\n* Added PHPDocs for class and methods\r\n\r\n### Type.tpl.php\r\n`src/Resources/skeleton/form/Type.tpl.php`\r\n* Added PHPDocs for class and methods\r\n\r\n### UserProvider.tpl.php\r\n`src/Resources/skeleton/security/UserProvider.tpl.php`\r\n* Added PHPDoc for class\r\n\r\n### Voter.tpl.php\r\n`src/Resources/skeleton/security/Voter.tpl.php`\r\n* Added PHPDocs for class and methods\r\n\r\n### Encoder.tpl.php\r\n`src/Resources/skeleton/serializer/Encoder.tpl.php`\r\n* Added PHPDocs for class and methods\r\n\r\n### Functional.tpl.php\r\n`src/Resources/skeleton/test/Functional.tpl.php`\r\n* Added PHPDoc for class\r\n\r\n### Unit.tpl.php\r\n`src/Resources/skeleton/test/Unit.tpl.php`\r\n* Added PHPDoc for class\r\n\r\n### Extension.tpl.php\r\n`src/Resources/skeleton/twig/Extension.tpl.php`\r\n* Added PHPDocs for class and methods\r\n\r\n### Constraint.tpl.php\r\n`src/Resources/skeleton/validator/Constraint.tpl.php`\r\n* Added PHPDocs for class and methods\r\n\r\n### Validator.tpl.php\r\n`src/Resources/skeleton/validator/Validator.tpl.php`\r\n* Added PHPDocs for class and methods\r\n\r\n### Class.tpl.php\r\n`src/Resources/skeleton/Class.tpl.php`\r\n* Added PHPDoc for class","created_at":"2018-10-04T12:28:29Z","updated_at":"2019-01-03T16:22:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cb54cba6c7c111f064a57d2b932fff12b867be0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/284/commits","review_comments_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/284/comments","review_comment_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/maker-bundle/issues/284/comments","statuses_url":"https://api.github.com/repos/symfony/maker-bundle/statuses/4879f6dce1625ced27fa1a86cb60598b377f18a8","head":{"label":"wow-apps:psr-fix","ref":"psr-fix","sha":"4879f6dce1625ced27fa1a86cb60598b377f18a8","user":{"login":"wow-apps","id":2779949,"node_id":"MDQ6VXNlcjI3Nzk5NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/2779949?v=4","gravatar_id":"","url":"https://api.github.com/users/wow-apps","html_url":"https://github.com/wow-apps","followers_url":"https://api.github.com/users/wow-apps/followers","following_url":"https://api.github.com/users/wow-apps/following{/other_user}","gists_url":"https://api.github.com/users/wow-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/wow-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wow-apps/subscriptions","organizations_url":"https://api.github.com/users/wow-apps/orgs","repos_url":"https://api.github.com/users/wow-apps/repos","events_url":"https://api.github.com/users/wow-apps/events{/privacy}","received_events_url":"https://api.github.com/users/wow-apps/received_events","type":"User","site_admin":false},"repo":{"id":149983692,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk5ODM2OTI=","name":"maker-bundle","full_name":"wow-apps/maker-bundle","private":false,"owner":{"login":"wow-apps","id":2779949,"node_id":"MDQ6VXNlcjI3Nzk5NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/2779949?v=4","gravatar_id":"","url":"https://api.github.com/users/wow-apps","html_url":"https://github.com/wow-apps","followers_url":"https://api.github.com/users/wow-apps/followers","following_url":"https://api.github.com/users/wow-apps/following{/other_user}","gists_url":"https://api.github.com/users/wow-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/wow-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wow-apps/subscriptions","organizations_url":"https://api.github.com/users/wow-apps/orgs","repos_url":"https://api.github.com/users/wow-apps/repos","events_url":"https://api.github.com/users/wow-apps/events{/privacy}","received_events_url":"https://api.github.com/users/wow-apps/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wow-apps/maker-bundle","description":"Symfony Maker Bundle","fork":true,"url":"https://api.github.com/repos/wow-apps/maker-bundle","forks_url":"https://api.github.com/repos/wow-apps/maker-bundle/forks","keys_url":"https://api.github.com/repos/wow-apps/maker-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wow-apps/maker-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wow-apps/maker-bundle/teams","hooks_url":"https://api.github.com/repos/wow-apps/maker-bundle/hooks","issue_events_url":"https://api.github.com/repos/wow-apps/maker-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/wow-apps/maker-bundle/events","assignees_url":"https://api.github.com/repos/wow-apps/maker-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/wow-apps/maker-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/wow-apps/maker-bundle/tags","blobs_url":"https://api.github.com/repos/wow-apps/maker-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wow-apps/maker-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wow-apps/maker-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/wow-apps/maker-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wow-apps/maker-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/wow-apps/maker-bundle/languages","stargazers_url":"https://api.github.com/repos/wow-apps/maker-bundle/stargazers","contributors_url":"https://api.github.com/repos/wow-apps/maker-bundle/contributors","subscribers_url":"https://api.github.com/repos/wow-apps/maker-bundle/subscribers","subscription_url":"https://api.github.com/repos/wow-apps/maker-bundle/subscription","commits_url":"https://api.github.com/repos/wow-apps/maker-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/wow-apps/maker-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/wow-apps/maker-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/wow-apps/maker-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/wow-apps/maker-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/wow-apps/maker-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wow-apps/maker-bundle/merges","archive_url":"https://api.github.com/repos/wow-apps/maker-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wow-apps/maker-bundle/downloads","issues_url":"https://api.github.com/repos/wow-apps/maker-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/wow-apps/maker-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/wow-apps/maker-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/wow-apps/maker-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wow-apps/maker-bundle/labels{/name}","releases_url":"https://api.github.com/repos/wow-apps/maker-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/wow-apps/maker-bundle/deployments","created_at":"2018-09-23T12:46:46Z","updated_at":"2018-10-21T19:26:12Z","pushed_at":"2018-10-21T19:32:09Z","git_url":"git://github.com/wow-apps/maker-bundle.git","ssh_url":"git@github.com:wow-apps/maker-bundle.git","clone_url":"https://github.com/wow-apps/maker-bundle.git","svn_url":"https://github.com/wow-apps/maker-bundle","homepage":"https://symfony.com/","size":773,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"26643943fe19b5b47d620744907f09d1d6b3f06f","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":109984157,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5ODQxNTc=","name":"maker-bundle","full_name":"symfony/maker-bundle","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/maker-bundle","description":"Symfony Maker Bundle","fork":false,"url":"https://api.github.com/repos/symfony/maker-bundle","forks_url":"https://api.github.com/repos/symfony/maker-bundle/forks","keys_url":"https://api.github.com/repos/symfony/maker-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/maker-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/maker-bundle/teams","hooks_url":"https://api.github.com/repos/symfony/maker-bundle/hooks","issue_events_url":"https://api.github.com/repos/symfony/maker-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/maker-bundle/events","assignees_url":"https://api.github.com/repos/symfony/maker-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/maker-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/maker-bundle/tags","blobs_url":"https://api.github.com/repos/symfony/maker-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/maker-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/maker-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/maker-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/maker-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/maker-bundle/languages","stargazers_url":"https://api.github.com/repos/symfony/maker-bundle/stargazers","contributors_url":"https://api.github.com/repos/symfony/maker-bundle/contributors","subscribers_url":"https://api.github.com/repos/symfony/maker-bundle/subscribers","subscription_url":"https://api.github.com/repos/symfony/maker-bundle/subscription","commits_url":"https://api.github.com/repos/symfony/maker-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/maker-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/maker-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/maker-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/maker-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/maker-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/maker-bundle/merges","archive_url":"https://api.github.com/repos/symfony/maker-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/maker-bundle/downloads","issues_url":"https://api.github.com/repos/symfony/maker-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/maker-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/maker-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/maker-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/maker-bundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony/maker-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/maker-bundle/deployments","created_at":"2017-11-08T14:10:03Z","updated_at":"2019-01-02T15:20:37Z","pushed_at":"2019-01-03T01:23:22Z","git_url":"git://github.com/symfony/maker-bundle.git","ssh_url":"git@github.com:symfony/maker-bundle.git","clone_url":"https://github.com/symfony/maker-bundle.git","svn_url":"https://github.com/symfony/maker-bundle","homepage":"https://symfony.com/","size":899,"stargazers_count":1419,"watchers_count":1419,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":112,"open_issues":71,"watchers":1419,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/284"},"html":{"href":"https://github.com/symfony/maker-bundle/pull/284"},"issue":{"href":"https://api.github.com/repos/symfony/maker-bundle/issues/284"},"comments":{"href":"https://api.github.com/repos/symfony/maker-bundle/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/maker-bundle/statuses/4879f6dce1625ced27fa1a86cb60598b377f18a8"}},"author_association":"NONE"}}
{"actor":{"display_login":"javiereguiluz"}}