{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/halkeye/charts/pulls/1","id":223820590,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODIwNTkw","html_url":"https://github.com/halkeye/charts/pull/1","diff_url":"https://github.com/halkeye/charts/pull/1.diff","patch_url":"https://github.com/halkeye/charts/pull/1.patch","issue_url":"https://api.github.com/repos/halkeye/charts/issues/1","number":1,"state":"closed","locked":false,"title":"<!-- Thank you for contributing to helm/charts. Before you submit this PR we'd like to make sure you are aware of our technical requirements and best practices:","user":{"login":"halkeye","id":110087,"node_id":"MDQ6VXNlcjExMDA4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/110087?v=4","gravatar_id":"","url":"https://api.github.com/users/halkeye","html_url":"https://github.com/halkeye","followers_url":"https://api.github.com/users/halkeye/followers","following_url":"https://api.github.com/users/halkeye/following{/other_user}","gists_url":"https://api.github.com/users/halkeye/gists{/gist_id}","starred_url":"https://api.github.com/users/halkeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halkeye/subscriptions","organizations_url":"https://api.github.com/users/halkeye/orgs","repos_url":"https://api.github.com/users/halkeye/repos","events_url":"https://api.github.com/users/halkeye/events{/privacy}","received_events_url":"https://api.github.com/users/halkeye/received_events","type":"User","site_admin":false},"body":"* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\n\nFor a quick overview across what we will look at reviewing your PR, please read\nour review guidelines:\n\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\n\nFollowing our best practices right from the start will accelerate the review process and\nhelp get your PR merged quicker.\n\nWhen updates to your PR are requested, please add new commits and do not squash the\nhistory. This will make it easier to identify new changes. The PR will be squashed\nanyways when it is merged. Thanks.\n\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\n\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\nwill run across your changes and do some initial checks and linting. These checks run\nvery quickly. Please check the results. We would like these checks to pass before we\neven continue reviewing your changes.\n-->\n\nAdd pod and service labels.\n\n@bertinwong-saucelabs asked me to do it cause I had a bit of spare time.\nHe was planning on installing the push gateway but needed some extra\nlabels for the k8s cluster he was working on\n\n\n\nI'm not sure the method I've used with merging and stuff is best, I\ntook a look at some of the other charts, and they prefer if checks, but\nI felt always outputting was a little safer so it didn't accidently get\nbroken.\n\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\n- [X] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\n- [ ] Chart Version bumped\n- [ ] Variables are documented in the README.md","created_at":"2018-10-18T04:14:40Z","updated_at":"2018-10-18T04:17:32Z","closed_at":"2018-10-18T04:17:32Z","merged_at":null,"merge_commit_sha":"1fd29147f9c4f9a0eb77fc3605c19b3b41b357b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/halkeye/charts/pulls/1/commits","review_comments_url":"https://api.github.com/repos/halkeye/charts/pulls/1/comments","review_comment_url":"https://api.github.com/repos/halkeye/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/halkeye/charts/issues/1/comments","statuses_url":"https://api.github.com/repos/halkeye/charts/statuses/c67fa181148faa03443b9132da8c47042c62e11b","head":{"label":"halkeye:add-labels-and-annotations","ref":"add-labels-and-annotations","sha":"c67fa181148faa03443b9132da8c47042c62e11b","user":{"login":"halkeye","id":110087,"node_id":"MDQ6VXNlcjExMDA4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/110087?v=4","gravatar_id":"","url":"https://api.github.com/users/halkeye","html_url":"https://github.com/halkeye","followers_url":"https://api.github.com/users/halkeye/followers","following_url":"https://api.github.com/users/halkeye/following{/other_user}","gists_url":"https://api.github.com/users/halkeye/gists{/gist_id}","starred_url":"https://api.github.com/users/halkeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halkeye/subscriptions","organizations_url":"https://api.github.com/users/halkeye/orgs","repos_url":"https://api.github.com/users/halkeye/repos","events_url":"https://api.github.com/users/halkeye/events{/privacy}","received_events_url":"https://api.github.com/users/halkeye/received_events","type":"User","site_admin":false},"repo":{"id":152527312,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI1MjczMTI=","name":"charts","full_name":"halkeye/charts","private":false,"owner":{"login":"halkeye","id":110087,"node_id":"MDQ6VXNlcjExMDA4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/110087?v=4","gravatar_id":"","url":"https://api.github.com/users/halkeye","html_url":"https://github.com/halkeye","followers_url":"https://api.github.com/users/halkeye/followers","following_url":"https://api.github.com/users/halkeye/following{/other_user}","gists_url":"https://api.github.com/users/halkeye/gists{/gist_id}","starred_url":"https://api.github.com/users/halkeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halkeye/subscriptions","organizations_url":"https://api.github.com/users/halkeye/orgs","repos_url":"https://api.github.com/users/halkeye/repos","events_url":"https://api.github.com/users/halkeye/events{/privacy}","received_events_url":"https://api.github.com/users/halkeye/received_events","type":"User","site_admin":false},"html_url":"https://github.com/halkeye/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/halkeye/charts","forks_url":"https://api.github.com/repos/halkeye/charts/forks","keys_url":"https://api.github.com/repos/halkeye/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halkeye/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halkeye/charts/teams","hooks_url":"https://api.github.com/repos/halkeye/charts/hooks","issue_events_url":"https://api.github.com/repos/halkeye/charts/issues/events{/number}","events_url":"https://api.github.com/repos/halkeye/charts/events","assignees_url":"https://api.github.com/repos/halkeye/charts/assignees{/user}","branches_url":"https://api.github.com/repos/halkeye/charts/branches{/branch}","tags_url":"https://api.github.com/repos/halkeye/charts/tags","blobs_url":"https://api.github.com/repos/halkeye/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halkeye/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halkeye/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/halkeye/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halkeye/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/halkeye/charts/languages","stargazers_url":"https://api.github.com/repos/halkeye/charts/stargazers","contributors_url":"https://api.github.com/repos/halkeye/charts/contributors","subscribers_url":"https://api.github.com/repos/halkeye/charts/subscribers","subscription_url":"https://api.github.com/repos/halkeye/charts/subscription","commits_url":"https://api.github.com/repos/halkeye/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/halkeye/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/halkeye/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/halkeye/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/halkeye/charts/contents/{+path}","compare_url":"https://api.github.com/repos/halkeye/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halkeye/charts/merges","archive_url":"https://api.github.com/repos/halkeye/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halkeye/charts/downloads","issues_url":"https://api.github.com/repos/halkeye/charts/issues{/number}","pulls_url":"https://api.github.com/repos/halkeye/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/halkeye/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/halkeye/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halkeye/charts/labels{/name}","releases_url":"https://api.github.com/repos/halkeye/charts/releases{/id}","deployments_url":"https://api.github.com/repos/halkeye/charts/deployments","created_at":"2018-10-11T03:44:35Z","updated_at":"2018-10-11T03:44:41Z","pushed_at":"2018-10-18T04:14:41Z","git_url":"git://github.com/halkeye/charts.git","ssh_url":"git@github.com:halkeye/charts.git","clone_url":"https://github.com/halkeye/charts.git","svn_url":"https://github.com/halkeye/charts","homepage":"","size":13442,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"halkeye:master","ref":"master","sha":"2c4c2cb360f239117a653feed002aecf9696d5cc","user":{"login":"halkeye","id":110087,"node_id":"MDQ6VXNlcjExMDA4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/110087?v=4","gravatar_id":"","url":"https://api.github.com/users/halkeye","html_url":"https://github.com/halkeye","followers_url":"https://api.github.com/users/halkeye/followers","following_url":"https://api.github.com/users/halkeye/following{/other_user}","gists_url":"https://api.github.com/users/halkeye/gists{/gist_id}","starred_url":"https://api.github.com/users/halkeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halkeye/subscriptions","organizations_url":"https://api.github.com/users/halkeye/orgs","repos_url":"https://api.github.com/users/halkeye/repos","events_url":"https://api.github.com/users/halkeye/events{/privacy}","received_events_url":"https://api.github.com/users/halkeye/received_events","type":"User","site_admin":false},"repo":{"id":152527312,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI1MjczMTI=","name":"charts","full_name":"halkeye/charts","private":false,"owner":{"login":"halkeye","id":110087,"node_id":"MDQ6VXNlcjExMDA4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/110087?v=4","gravatar_id":"","url":"https://api.github.com/users/halkeye","html_url":"https://github.com/halkeye","followers_url":"https://api.github.com/users/halkeye/followers","following_url":"https://api.github.com/users/halkeye/following{/other_user}","gists_url":"https://api.github.com/users/halkeye/gists{/gist_id}","starred_url":"https://api.github.com/users/halkeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halkeye/subscriptions","organizations_url":"https://api.github.com/users/halkeye/orgs","repos_url":"https://api.github.com/users/halkeye/repos","events_url":"https://api.github.com/users/halkeye/events{/privacy}","received_events_url":"https://api.github.com/users/halkeye/received_events","type":"User","site_admin":false},"html_url":"https://github.com/halkeye/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/halkeye/charts","forks_url":"https://api.github.com/repos/halkeye/charts/forks","keys_url":"https://api.github.com/repos/halkeye/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halkeye/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halkeye/charts/teams","hooks_url":"https://api.github.com/repos/halkeye/charts/hooks","issue_events_url":"https://api.github.com/repos/halkeye/charts/issues/events{/number}","events_url":"https://api.github.com/repos/halkeye/charts/events","assignees_url":"https://api.github.com/repos/halkeye/charts/assignees{/user}","branches_url":"https://api.github.com/repos/halkeye/charts/branches{/branch}","tags_url":"https://api.github.com/repos/halkeye/charts/tags","blobs_url":"https://api.github.com/repos/halkeye/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halkeye/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halkeye/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/halkeye/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halkeye/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/halkeye/charts/languages","stargazers_url":"https://api.github.com/repos/halkeye/charts/stargazers","contributors_url":"https://api.github.com/repos/halkeye/charts/contributors","subscribers_url":"https://api.github.com/repos/halkeye/charts/subscribers","subscription_url":"https://api.github.com/repos/halkeye/charts/subscription","commits_url":"https://api.github.com/repos/halkeye/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/halkeye/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/halkeye/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/halkeye/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/halkeye/charts/contents/{+path}","compare_url":"https://api.github.com/repos/halkeye/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halkeye/charts/merges","archive_url":"https://api.github.com/repos/halkeye/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halkeye/charts/downloads","issues_url":"https://api.github.com/repos/halkeye/charts/issues{/number}","pulls_url":"https://api.github.com/repos/halkeye/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/halkeye/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/halkeye/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halkeye/charts/labels{/name}","releases_url":"https://api.github.com/repos/halkeye/charts/releases{/id}","deployments_url":"https://api.github.com/repos/halkeye/charts/deployments","created_at":"2018-10-11T03:44:35Z","updated_at":"2018-10-11T03:44:41Z","pushed_at":"2018-10-18T04:14:41Z","git_url":"git://github.com/halkeye/charts.git","ssh_url":"git@github.com:halkeye/charts.git","clone_url":"https://github.com/halkeye/charts.git","svn_url":"https://github.com/halkeye/charts","homepage":"","size":13442,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/halkeye/charts/pulls/1"},"html":{"href":"https://github.com/halkeye/charts/pull/1"},"issue":{"href":"https://api.github.com/repos/halkeye/charts/issues/1"},"comments":{"href":"https://api.github.com/repos/halkeye/charts/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/halkeye/charts/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/halkeye/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/halkeye/charts/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/halkeye/charts/statuses/c67fa181148faa03443b9132da8c47042c62e11b"}},"author_association":"OWNER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":15,"deletions":9,"changed_files":3}}
{"actor":{"display_login":"halkeye"}}