{"action":"created","comment":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments/207296062","pull_request_review_id":142878918,"id":207296062,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzI5NjA2Mg==","diff_hunk":"@@ -24,6 +24,10 @@\n #include <QStackedWidget>\n #include <QTimer>\n \n+#if defined(__linux) || defined(__linux__) || defined(linux)","path":"src/gui/DatabaseWidget.h","position":4,"original_position":4,"commit_id":"b86f14b03a4810f2fae5ea1b77ac820b41713140","original_commit_id":"b86f14b03a4810f2fae5ea1b77ac820b41713140","user":{"login":"phoerious","id":911270,"node_id":"MDQ6VXNlcjkxMTI3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/911270?v=4","gravatar_id":"","url":"https://api.github.com/users/phoerious","html_url":"https://github.com/phoerious","followers_url":"https://api.github.com/users/phoerious/followers","following_url":"https://api.github.com/users/phoerious/following{/other_user}","gists_url":"https://api.github.com/users/phoerious/gists{/gist_id}","starred_url":"https://api.github.com/users/phoerious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoerious/subscriptions","organizations_url":"https://api.github.com/users/phoerious/orgs","repos_url":"https://api.github.com/users/phoerious/repos","events_url":"https://api.github.com/users/phoerious/events{/privacy}","received_events_url":"https://api.github.com/users/phoerious/received_events","type":"User","site_admin":false},"body":"See above. Is this header available on other *nix platforms? If not, are there alternatives?","created_at":"2018-08-02T16:43:25Z","updated_at":"2018-08-02T16:44:23Z","html_url":"https://github.com/keepassxreboot/keepassxc/pull/2171#discussion_r207296062","pull_request_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/2171","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments/207296062"},"html":{"href":"https://github.com/keepassxreboot/keepassxc/pull/2171#discussion_r207296062"},"pull_request":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/2171"}}},"pull_request":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/2171","id":205195845,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTk1ODQ1","html_url":"https://github.com/keepassxreboot/keepassxc/pull/2171","diff_url":"https://github.com/keepassxreboot/keepassxc/pull/2171.diff","patch_url":"https://github.com/keepassxreboot/keepassxc/pull/2171.patch","issue_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/2171","number":2171,"state":"open","locked":false,"title":"Do polling based file watching for NFS on linux, resolves #1799","user":{"login":"vasporig","id":6736271,"node_id":"MDQ6VXNlcjY3MzYyNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6736271?v=4","gravatar_id":"","url":"https://api.github.com/users/vasporig","html_url":"https://github.com/vasporig","followers_url":"https://api.github.com/users/vasporig/followers","following_url":"https://api.github.com/users/vasporig/following{/other_user}","gists_url":"https://api.github.com/users/vasporig/gists{/gist_id}","starred_url":"https://api.github.com/users/vasporig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasporig/subscriptions","organizations_url":"https://api.github.com/users/vasporig/orgs","repos_url":"https://api.github.com/users/vasporig/repos","events_url":"https://api.github.com/users/vasporig/events{/privacy}","received_events_url":"https://api.github.com/users/vasporig/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the title above -->\r\nAdd the ability to detect changes to the opened database if it's on NFS ( linux only ).\r\n\r\n@jsachs referred to this fix\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nOnly on linux: before opening a database, check the type of the filesystem and if it's NFS use a polling FileSystemWatcher instead of the (default) inotify based one to detect changes.\r\n\r\n## Motivation and context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nI'm running KeePassXC in an NFS environment.\r\n\r\n## How has this been tested?\r\nManually.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? -->\r\n<!--- Please remove all lines which don't apply. -->\r\n- ✅ Bug fix (non-breaking change which fixes an issue)\r\n\r\n## Checklist:\r\n<!--- Please go over all the following points. -->\r\n<!--- Again, remove any lines which don't apply. -->\r\n<!--- Pull Requests that don't fulfill all [REQUIRED] requisites are likely -->\r\n<!--- to be sent back to you for correction or will be rejected.  -->\r\n- ✅ I have read the **CONTRIBUTING** document. **[REQUIRED]**\r\n- ✅ My code follows the code style of this project. **[REQUIRED]**\r\n- ✅ All new and existing tests passed. **[REQUIRED]**\r\n- ✅ I have compiled and verified my code with `-DWITH_ASAN=ON`. **[REQUIRED]**\r\n\r\n","created_at":"2018-07-31T18:03:21Z","updated_at":"2018-08-02T16:44:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc6a2837db2fbb50d2d72fc10b92f0fcb3ef8831","assignee":null,"assignees":[],"requested_reviewers":[{"login":"droidmonkey","id":2809491,"node_id":"MDQ6VXNlcjI4MDk0OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2809491?v=4","gravatar_id":"","url":"https://api.github.com/users/droidmonkey","html_url":"https://github.com/droidmonkey","followers_url":"https://api.github.com/users/droidmonkey/followers","following_url":"https://api.github.com/users/droidmonkey/following{/other_user}","gists_url":"https://api.github.com/users/droidmonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/droidmonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droidmonkey/subscriptions","organizations_url":"https://api.github.com/users/droidmonkey/orgs","repos_url":"https://api.github.com/users/droidmonkey/repos","events_url":"https://api.github.com/users/droidmonkey/events{/privacy}","received_events_url":"https://api.github.com/users/droidmonkey/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/2171/commits","review_comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/2171/comments","review_comment_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/2171/comments","statuses_url":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/b86f14b03a4810f2fae5ea1b77ac820b41713140","head":{"label":"vasporig:feature/nfs-polling","ref":"feature/nfs-polling","sha":"b86f14b03a4810f2fae5ea1b77ac820b41713140","user":{"login":"vasporig","id":6736271,"node_id":"MDQ6VXNlcjY3MzYyNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6736271?v=4","gravatar_id":"","url":"https://api.github.com/users/vasporig","html_url":"https://github.com/vasporig","followers_url":"https://api.github.com/users/vasporig/followers","following_url":"https://api.github.com/users/vasporig/following{/other_user}","gists_url":"https://api.github.com/users/vasporig/gists{/gist_id}","starred_url":"https://api.github.com/users/vasporig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasporig/subscriptions","organizations_url":"https://api.github.com/users/vasporig/orgs","repos_url":"https://api.github.com/users/vasporig/repos","events_url":"https://api.github.com/users/vasporig/events{/privacy}","received_events_url":"https://api.github.com/users/vasporig/received_events","type":"User","site_admin":false},"repo":{"id":142785703,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI3ODU3MDM=","name":"keepassxc","full_name":"vasporig/keepassxc","owner":{"login":"vasporig","id":6736271,"node_id":"MDQ6VXNlcjY3MzYyNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6736271?v=4","gravatar_id":"","url":"https://api.github.com/users/vasporig","html_url":"https://github.com/vasporig","followers_url":"https://api.github.com/users/vasporig/followers","following_url":"https://api.github.com/users/vasporig/following{/other_user}","gists_url":"https://api.github.com/users/vasporig/gists{/gist_id}","starred_url":"https://api.github.com/users/vasporig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasporig/subscriptions","organizations_url":"https://api.github.com/users/vasporig/orgs","repos_url":"https://api.github.com/users/vasporig/repos","events_url":"https://api.github.com/users/vasporig/events{/privacy}","received_events_url":"https://api.github.com/users/vasporig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vasporig/keepassxc","description":"KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.","fork":true,"url":"https://api.github.com/repos/vasporig/keepassxc","forks_url":"https://api.github.com/repos/vasporig/keepassxc/forks","keys_url":"https://api.github.com/repos/vasporig/keepassxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vasporig/keepassxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vasporig/keepassxc/teams","hooks_url":"https://api.github.com/repos/vasporig/keepassxc/hooks","issue_events_url":"https://api.github.com/repos/vasporig/keepassxc/issues/events{/number}","events_url":"https://api.github.com/repos/vasporig/keepassxc/events","assignees_url":"https://api.github.com/repos/vasporig/keepassxc/assignees{/user}","branches_url":"https://api.github.com/repos/vasporig/keepassxc/branches{/branch}","tags_url":"https://api.github.com/repos/vasporig/keepassxc/tags","blobs_url":"https://api.github.com/repos/vasporig/keepassxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vasporig/keepassxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vasporig/keepassxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/vasporig/keepassxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vasporig/keepassxc/statuses/{sha}","languages_url":"https://api.github.com/repos/vasporig/keepassxc/languages","stargazers_url":"https://api.github.com/repos/vasporig/keepassxc/stargazers","contributors_url":"https://api.github.com/repos/vasporig/keepassxc/contributors","subscribers_url":"https://api.github.com/repos/vasporig/keepassxc/subscribers","subscription_url":"https://api.github.com/repos/vasporig/keepassxc/subscription","commits_url":"https://api.github.com/repos/vasporig/keepassxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/vasporig/keepassxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/vasporig/keepassxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/vasporig/keepassxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/vasporig/keepassxc/contents/{+path}","compare_url":"https://api.github.com/repos/vasporig/keepassxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vasporig/keepassxc/merges","archive_url":"https://api.github.com/repos/vasporig/keepassxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vasporig/keepassxc/downloads","issues_url":"https://api.github.com/repos/vasporig/keepassxc/issues{/number}","pulls_url":"https://api.github.com/repos/vasporig/keepassxc/pulls{/number}","milestones_url":"https://api.github.com/repos/vasporig/keepassxc/milestones{/number}","notifications_url":"https://api.github.com/repos/vasporig/keepassxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vasporig/keepassxc/labels{/name}","releases_url":"https://api.github.com/repos/vasporig/keepassxc/releases{/id}","deployments_url":"https://api.github.com/repos/vasporig/keepassxc/deployments","created_at":"2018-07-29T18:28:21Z","updated_at":"2018-07-29T18:28:24Z","pushed_at":"2018-07-31T16:14:18Z","git_url":"git://github.com/vasporig/keepassxc.git","ssh_url":"git@github.com:vasporig/keepassxc.git","clone_url":"https://github.com/vasporig/keepassxc.git","svn_url":"https://github.com/vasporig/keepassxc","homepage":"https://keepassxc.org/","size":12867,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"keepassxreboot:develop","ref":"develop","sha":"07efabed0347605de0383857c59e02d471e08447","user":{"login":"keepassxreboot","id":22534815,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTM0ODE1","avatar_url":"https://avatars3.githubusercontent.com/u/22534815?v=4","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"repo":{"id":52729242,"node_id":"MDEwOlJlcG9zaXRvcnk1MjcyOTI0Mg==","name":"keepassxc","full_name":"keepassxreboot/keepassxc","owner":{"login":"keepassxreboot","id":22534815,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTM0ODE1","avatar_url":"https://avatars3.githubusercontent.com/u/22534815?v=4","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keepassxreboot/keepassxc","description":"KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.","fork":false,"url":"https://api.github.com/repos/keepassxreboot/keepassxc","forks_url":"https://api.github.com/repos/keepassxreboot/keepassxc/forks","keys_url":"https://api.github.com/repos/keepassxreboot/keepassxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keepassxreboot/keepassxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keepassxreboot/keepassxc/teams","hooks_url":"https://api.github.com/repos/keepassxreboot/keepassxc/hooks","issue_events_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/events{/number}","events_url":"https://api.github.com/repos/keepassxreboot/keepassxc/events","assignees_url":"https://api.github.com/repos/keepassxreboot/keepassxc/assignees{/user}","branches_url":"https://api.github.com/repos/keepassxreboot/keepassxc/branches{/branch}","tags_url":"https://api.github.com/repos/keepassxreboot/keepassxc/tags","blobs_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/{sha}","languages_url":"https://api.github.com/repos/keepassxreboot/keepassxc/languages","stargazers_url":"https://api.github.com/repos/keepassxreboot/keepassxc/stargazers","contributors_url":"https://api.github.com/repos/keepassxreboot/keepassxc/contributors","subscribers_url":"https://api.github.com/repos/keepassxreboot/keepassxc/subscribers","subscription_url":"https://api.github.com/repos/keepassxreboot/keepassxc/subscription","commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/keepassxreboot/keepassxc/contents/{+path}","compare_url":"https://api.github.com/repos/keepassxreboot/keepassxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keepassxreboot/keepassxc/merges","archive_url":"https://api.github.com/repos/keepassxreboot/keepassxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keepassxreboot/keepassxc/downloads","issues_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues{/number}","pulls_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls{/number}","milestones_url":"https://api.github.com/repos/keepassxreboot/keepassxc/milestones{/number}","notifications_url":"https://api.github.com/repos/keepassxreboot/keepassxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keepassxreboot/keepassxc/labels{/name}","releases_url":"https://api.github.com/repos/keepassxreboot/keepassxc/releases{/id}","deployments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/deployments","created_at":"2016-02-28T15:52:40Z","updated_at":"2018-08-02T14:27:20Z","pushed_at":"2018-08-01T16:51:21Z","git_url":"git://github.com/keepassxreboot/keepassxc.git","ssh_url":"git@github.com:keepassxreboot/keepassxc.git","clone_url":"https://github.com/keepassxreboot/keepassxc.git","svn_url":"https://github.com/keepassxreboot/keepassxc","homepage":"https://keepassxc.org/","size":12870,"stargazers_count":4025,"watchers_count":4025,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":300,"mirror_url":null,"archived":false,"open_issues_count":491,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":300,"open_issues":491,"watchers":4025,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/2171"},"html":{"href":"https://github.com/keepassxreboot/keepassxc/pull/2171"},"issue":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/2171"},"comments":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/2171/comments"},"review_comments":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/2171/comments"},"review_comment":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/2171/commits"},"statuses":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/b86f14b03a4810f2fae5ea1b77ac820b41713140"}},"author_association":"NONE"}}
{"actor":{"display_login":"phoerious"}}