{"action":"created","issue":{"url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8813","repository_url":"https://api.github.com/repos/TEAMMATES/teammates","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8813/labels{/name}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8813/comments","events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8813/events","html_url":"https://github.com/TEAMMATES/teammates/pull/8813","id":320071943,"number":8813,"title":"FeedbackRankQuestionUiTest.json: Fix data for Tests #8794","user":{"login":"mmoanis","id":7101613,"avatar_url":"https://avatars3.githubusercontent.com/u/7101613?v=4","gravatar_id":"","url":"https://api.github.com/users/mmoanis","html_url":"https://github.com/mmoanis","followers_url":"https://api.github.com/users/mmoanis/followers","following_url":"https://api.github.com/users/mmoanis/following{/other_user}","gists_url":"https://api.github.com/users/mmoanis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoanis/subscriptions","organizations_url":"https://api.github.com/users/mmoanis/orgs","repos_url":"https://api.github.com/users/mmoanis/repos","events_url":"https://api.github.com/users/mmoanis/events{/privacy}","received_events_url":"https://api.github.com/users/mmoanis/received_events","type":"User","site_admin":false},"labels":[{"id":98049565,"url":"https://api.github.com/repos/TEAMMATES/teammates/labels/s.ToReview","name":"s.ToReview","color":"47B74E","default":false}],"state":"open","locked":false,"assignee":{"login":"tshradheya","id":12574756,"avatar_url":"https://avatars0.githubusercontent.com/u/12574756?v=4","gravatar_id":"","url":"https://api.github.com/users/tshradheya","html_url":"https://github.com/tshradheya","followers_url":"https://api.github.com/users/tshradheya/followers","following_url":"https://api.github.com/users/tshradheya/following{/other_user}","gists_url":"https://api.github.com/users/tshradheya/gists{/gist_id}","starred_url":"https://api.github.com/users/tshradheya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tshradheya/subscriptions","organizations_url":"https://api.github.com/users/tshradheya/orgs","repos_url":"https://api.github.com/users/tshradheya/repos","events_url":"https://api.github.com/users/tshradheya/events{/privacy}","received_events_url":"https://api.github.com/users/tshradheya/received_events","type":"User","site_admin":false},"assignees":[{"login":"tshradheya","id":12574756,"avatar_url":"https://avatars0.githubusercontent.com/u/12574756?v=4","gravatar_id":"","url":"https://api.github.com/users/tshradheya","html_url":"https://github.com/tshradheya","followers_url":"https://api.github.com/users/tshradheya/followers","following_url":"https://api.github.com/users/tshradheya/following{/other_user}","gists_url":"https://api.github.com/users/tshradheya/gists{/gist_id}","starred_url":"https://api.github.com/users/tshradheya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tshradheya/subscriptions","organizations_url":"https://api.github.com/users/tshradheya/orgs","repos_url":"https://api.github.com/users/tshradheya/repos","events_url":"https://api.github.com/users/tshradheya/events{/privacy}","received_events_url":"https://api.github.com/users/tshradheya/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-05-03T20:39:36Z","updated_at":"2018-05-14T03:38:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8813","html_url":"https://github.com/TEAMMATES/teammates/pull/8813","diff_url":"https://github.com/TEAMMATES/teammates/pull/8813.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/8813.patch"},"body":"Fixes #8794 \r\nThere are 7 answers for the feedback rank question number 3 in the test data, but there are 3 scenarios that are incorrect:\r\n- Benny (team 1) gives feedback to Charlie (team 2)\r\n- Alice (team 1) gives feedback to Charlie (team 2)\r\n- Charlie (team 2) gives feedback to Alice (team 1)\r\n\r\nI corrected these scenarios and updated the baseline HTML pages for the test case that uses this JSON.\r\n\r\nPlease also review the section number in the feedback, I think they are incorrect too?\r\n"},"comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments/388688001","html_url":"https://github.com/TEAMMATES/teammates/pull/8813#issuecomment-388688001","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8813","id":388688001,"user":{"login":"tshradheya","id":12574756,"avatar_url":"https://avatars0.githubusercontent.com/u/12574756?v=4","gravatar_id":"","url":"https://api.github.com/users/tshradheya","html_url":"https://github.com/tshradheya","followers_url":"https://api.github.com/users/tshradheya/followers","following_url":"https://api.github.com/users/tshradheya/following{/other_user}","gists_url":"https://api.github.com/users/tshradheya/gists{/gist_id}","starred_url":"https://api.github.com/users/tshradheya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tshradheya/subscriptions","organizations_url":"https://api.github.com/users/tshradheya/orgs","repos_url":"https://api.github.com/users/tshradheya/repos","events_url":"https://api.github.com/users/tshradheya/events{/privacy}","received_events_url":"https://api.github.com/users/tshradheya/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T03:38:03Z","updated_at":"2018-05-14T03:38:03Z","author_association":"MEMBER","body":"Verified that after making the chnages, the HTML now shows correct data and tests are now more meaningful. \r\n\r\n@LiHaoTan @Crphang Can either of you please do the second round of review?(After the PR is synced with lastest changes in master"}}
{"actor":{"display_login":"tshradheya"}}