{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3/pulls/comments/216781971","pull_request_review_id":154346446,"id":216781971,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjc4MTk3MQ==","diff_hunk":"@@ -545,8 +543,22 @@ func (b *dbBufferBucket) finalize() {\n \tb.resetBootstrapped()\n }\n \n+func (b *dbBufferBucket) empty() bool {","path":"src/dbnode/storage/series/buffer.go","position":33,"original_position":20,"commit_id":"9bb9151a59e61e8ff84261137de594036b862e0e","original_commit_id":"9bb9151a59e61e8ff84261137de594036b862e0e","user":{"login":"robskillington","id":339615,"node_id":"MDQ6VXNlcjMzOTYxNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/339615?v=4","gravatar_id":"","url":"https://api.github.com/users/robskillington","html_url":"https://github.com/robskillington","followers_url":"https://api.github.com/users/robskillington/followers","following_url":"https://api.github.com/users/robskillington/following{/other_user}","gists_url":"https://api.github.com/users/robskillington/gists{/gist_id}","starred_url":"https://api.github.com/users/robskillington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robskillington/subscriptions","organizations_url":"https://api.github.com/users/robskillington/orgs","repos_url":"https://api.github.com/users/robskillington/repos","events_url":"https://api.github.com/users/robskillington/events{/privacy}","received_events_url":"https://api.github.com/users/robskillington/received_events","type":"User","site_admin":false},"body":"Yeah this should be fine, we don't actually call it from any high frequency code paths.  We used to have a high frequency call site with it, although now it was refactored out.","created_at":"2018-09-11T18:53:31Z","updated_at":"2018-09-11T18:53:31Z","html_url":"https://github.com/m3db/m3/pull/876#discussion_r216781971","pull_request_url":"https://api.github.com/repos/m3db/m3/pulls/876","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3/pulls/comments/216781971"},"html":{"href":"https://github.com/m3db/m3/pull/876#discussion_r216781971"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3/pulls/876"}},"in_reply_to_id":216774703},"pull_request":{"url":"https://api.github.com/repos/m3db/m3/pulls/876","id":212602065,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNjAyMDY1","html_url":"https://github.com/m3db/m3/pull/876","diff_url":"https://github.com/m3db/m3/pull/876.diff","patch_url":"https://github.com/m3db/m3/pull/876.patch","issue_url":"https://api.github.com/repos/m3db/m3/issues/876","number":876,"state":"open","locked":false,"title":"Use upsert behavior for datapoints written to the mutable series buffer","user":{"login":"robskillington","id":339615,"node_id":"MDQ6VXNlcjMzOTYxNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/339615?v=4","gravatar_id":"","url":"https://api.github.com/users/robskillington","html_url":"https://github.com/robskillington","followers_url":"https://api.github.com/users/robskillington/followers","following_url":"https://api.github.com/users/robskillington/following{/other_user}","gists_url":"https://api.github.com/users/robskillington/gists{/gist_id}","starred_url":"https://api.github.com/users/robskillington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robskillington/subscriptions","organizations_url":"https://api.github.com/users/robskillington/orgs","repos_url":"https://api.github.com/users/robskillington/repos","events_url":"https://api.github.com/users/robskillington/events{/privacy}","received_events_url":"https://api.github.com/users/robskillington/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-02T17:03:14Z","updated_at":"2018-09-11T18:53:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a13991325635513bd5082787e33b683feb731b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3/pulls/876/commits","review_comments_url":"https://api.github.com/repos/m3db/m3/pulls/876/comments","review_comment_url":"https://api.github.com/repos/m3db/m3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3/issues/876/comments","statuses_url":"https://api.github.com/repos/m3db/m3/statuses/9bb9151a59e61e8ff84261137de594036b862e0e","head":{"label":"m3db:r/upsert-datapoints","ref":"r/upsert-datapoints","sha":"9bb9151a59e61e8ff84261137de594036b862e0e","user":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":61153677,"node_id":"MDEwOlJlcG9zaXRvcnk2MTE1MzY3Nw==","name":"m3","full_name":"m3db/m3","owner":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3","description":"M3 monorepo - Distributed TSDB and Query Engine, Prometheus Sidecar, Metrics Platform","fork":false,"url":"https://api.github.com/repos/m3db/m3","forks_url":"https://api.github.com/repos/m3db/m3/forks","keys_url":"https://api.github.com/repos/m3db/m3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3/teams","hooks_url":"https://api.github.com/repos/m3db/m3/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3/events","assignees_url":"https://api.github.com/repos/m3db/m3/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3/tags","blobs_url":"https://api.github.com/repos/m3db/m3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3/languages","stargazers_url":"https://api.github.com/repos/m3db/m3/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3/subscription","commits_url":"https://api.github.com/repos/m3db/m3/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3/merges","archive_url":"https://api.github.com/repos/m3db/m3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3/downloads","issues_url":"https://api.github.com/repos/m3db/m3/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3/deployments","created_at":"2016-06-14T20:29:45Z","updated_at":"2018-09-11T18:16:26Z","pushed_at":"2018-09-11T18:36:20Z","git_url":"git://github.com/m3db/m3.git","ssh_url":"git@github.com:m3db/m3.git","clone_url":"https://github.com/m3db/m3.git","svn_url":"https://github.com/m3db/m3","homepage":"https://m3db.io/","size":13593,"stargazers_count":1085,"watchers_count":1085,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":77,"open_issues":137,"watchers":1085,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"2cf04be797594980e13ed7c79353d632f32d2c0f","user":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":61153677,"node_id":"MDEwOlJlcG9zaXRvcnk2MTE1MzY3Nw==","name":"m3","full_name":"m3db/m3","owner":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3","description":"M3 monorepo - Distributed TSDB and Query Engine, Prometheus Sidecar, Metrics Platform","fork":false,"url":"https://api.github.com/repos/m3db/m3","forks_url":"https://api.github.com/repos/m3db/m3/forks","keys_url":"https://api.github.com/repos/m3db/m3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3/teams","hooks_url":"https://api.github.com/repos/m3db/m3/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3/events","assignees_url":"https://api.github.com/repos/m3db/m3/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3/tags","blobs_url":"https://api.github.com/repos/m3db/m3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3/languages","stargazers_url":"https://api.github.com/repos/m3db/m3/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3/subscription","commits_url":"https://api.github.com/repos/m3db/m3/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3/merges","archive_url":"https://api.github.com/repos/m3db/m3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3/downloads","issues_url":"https://api.github.com/repos/m3db/m3/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3/deployments","created_at":"2016-06-14T20:29:45Z","updated_at":"2018-09-11T18:16:26Z","pushed_at":"2018-09-11T18:36:20Z","git_url":"git://github.com/m3db/m3.git","ssh_url":"git@github.com:m3db/m3.git","clone_url":"https://github.com/m3db/m3.git","svn_url":"https://github.com/m3db/m3","homepage":"https://m3db.io/","size":13593,"stargazers_count":1085,"watchers_count":1085,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":77,"open_issues":137,"watchers":1085,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3/pulls/876"},"html":{"href":"https://github.com/m3db/m3/pull/876"},"issue":{"href":"https://api.github.com/repos/m3db/m3/issues/876"},"comments":{"href":"https://api.github.com/repos/m3db/m3/issues/876/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3/pulls/876/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3/pulls/876/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3/statuses/9bb9151a59e61e8ff84261137de594036b862e0e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robskillington"}}