{"action":"created","comment":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments/195548506","pull_request_review_id":128936624,"id":195548506,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTU0ODUwNg==","diff_hunk":"@@ -342,6 +347,23 @@ function getLayerChanges(drawLayer, action) {\n             if (!isEmpty(get(drawLayer, ['drawData', 'data']))) {\n                 return attachToNewPlot(drawLayer, get(action.payload, ['plotIdAry', '0']));\n             }\n+            break;\n+        case ImagePlotCntlr.CHANGE_CENTER_OF_PROJECTION:\n+        case ImagePlotCntlr.ANY_REPLOT:\n+            console.log('type '+action.type);\n+            if (plotIdAry) {\n+                plotIdAry.forEach((pId) => {\n+                    if (isGoodPlot(pId)) {\n+                        wptObj = get(dd, ['data', pId, 'pts', '0']);\n+                        const cc = getCC(pId);\n+\n+                        if (isHiPS(cc) && wptObj && isPointInView(wptObj, cc)) {","path":"src/firefly/js/drawingLayers/FootprintTool.js","position":57,"original_position":57,"commit_id":"0d82d467bebec8ba7752ceae549fbc43faab870d","original_commit_id":"0d82d467bebec8ba7752ceae549fbc43faab870d","user":{"login":"robyww","id":6730519,"node_id":"MDQ6VXNlcjY3MzA1MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6730519?v=4","gravatar_id":"","url":"https://api.github.com/users/robyww","html_url":"https://github.com/robyww","followers_url":"https://api.github.com/users/robyww/followers","following_url":"https://api.github.com/users/robyww/following{/other_user}","gists_url":"https://api.github.com/users/robyww/gists{/gist_id}","starred_url":"https://api.github.com/users/robyww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robyww/subscriptions","organizations_url":"https://api.github.com/users/robyww/orgs","repos_url":"https://api.github.com/users/robyww/repos","events_url":"https://api.github.com/users/robyww/events{/privacy}","received_events_url":"https://api.github.com/users/robyww/received_events","type":"User","site_admin":false},"body":"should `isPointInView` be moved to `CsysConverter.js`?","created_at":"2018-06-14T19:45:23Z","updated_at":"2018-06-14T19:46:37Z","html_url":"https://github.com/Caltech-IPAC/firefly/pull/624#discussion_r195548506","pull_request_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/624","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments/195548506"},"html":{"href":"https://github.com/Caltech-IPAC/firefly/pull/624#discussion_r195548506"},"pull_request":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/624"}}},"pull_request":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/624","id":194676539,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0Njc2NTM5","html_url":"https://github.com/Caltech-IPAC/firefly/pull/624","diff_url":"https://github.com/Caltech-IPAC/firefly/pull/624.diff","patch_url":"https://github.com/Caltech-IPAC/firefly/pull/624.patch","issue_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/624","number":624,"state":"open","locked":false,"title":"DM-14673 Label for marker disappears when it is moved to the edge and footprint translation is out of shape on HiPS","user":{"login":"cwang2016","id":17187356,"node_id":"MDQ6VXNlcjE3MTg3MzU2","avatar_url":"https://avatars1.githubusercontent.com/u/17187356?v=4","gravatar_id":"","url":"https://api.github.com/users/cwang2016","html_url":"https://github.com/cwang2016","followers_url":"https://api.github.com/users/cwang2016/followers","following_url":"https://api.github.com/users/cwang2016/following{/other_user}","gists_url":"https://api.github.com/users/cwang2016/gists{/gist_id}","starred_url":"https://api.github.com/users/cwang2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwang2016/subscriptions","organizations_url":"https://api.github.com/users/cwang2016/orgs","repos_url":"https://api.github.com/users/cwang2016/repos","events_url":"https://api.github.com/users/cwang2016/events{/privacy}","received_events_url":"https://api.github.com/users/cwang2016/received_events","type":"User","site_admin":false},"body":"This development fixes the following issues, \r\n- when the marker/footprint is moved towards the edge of the display area, the label for the marker/footprint disappears.\r\n   fixing: showing the label when the marker/footprint is moved out of plot area and showing the label in alternate corner location in case the label is being moved out of plot area. \r\n- when the marker/footprint is relocated farther from the center or the target of the HiPS, the footprint  is shown out of shape as the image is zoomed. \r\n  fixing: instead of translating each region component on image domain as regular image, each component is re-rendered in world coordinate after relocating the footprint center first per original region description. \r\n\r\ntest:\r\nstart image search \r\nadd a marker or footprint overlay\r\nmove the marker/footprint to anywhere close to the plot border and view the text display\r\n\r\nstart HiPS search (no FOV entered)\r\nadd a footprint overlay\r\nclick (relocate) at a point close to the curved border of the HiPS\r\nzoom the image to see more detail of the footprint by zooming and rotating the HIPS \r\n\r\n","created_at":"2018-06-13T18:31:47Z","updated_at":"2018-06-14T19:46:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dd445523ab3a6f5e18434ebbc8ef3d62d344390","assignee":{"login":"cwang2016","id":17187356,"node_id":"MDQ6VXNlcjE3MTg3MzU2","avatar_url":"https://avatars1.githubusercontent.com/u/17187356?v=4","gravatar_id":"","url":"https://api.github.com/users/cwang2016","html_url":"https://github.com/cwang2016","followers_url":"https://api.github.com/users/cwang2016/followers","following_url":"https://api.github.com/users/cwang2016/following{/other_user}","gists_url":"https://api.github.com/users/cwang2016/gists{/gist_id}","starred_url":"https://api.github.com/users/cwang2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwang2016/subscriptions","organizations_url":"https://api.github.com/users/cwang2016/orgs","repos_url":"https://api.github.com/users/cwang2016/repos","events_url":"https://api.github.com/users/cwang2016/events{/privacy}","received_events_url":"https://api.github.com/users/cwang2016/received_events","type":"User","site_admin":false},"assignees":[{"login":"cwang2016","id":17187356,"node_id":"MDQ6VXNlcjE3MTg3MzU2","avatar_url":"https://avatars1.githubusercontent.com/u/17187356?v=4","gravatar_id":"","url":"https://api.github.com/users/cwang2016","html_url":"https://github.com/cwang2016","followers_url":"https://api.github.com/users/cwang2016/followers","following_url":"https://api.github.com/users/cwang2016/following{/other_user}","gists_url":"https://api.github.com/users/cwang2016/gists{/gist_id}","starred_url":"https://api.github.com/users/cwang2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwang2016/subscriptions","organizations_url":"https://api.github.com/users/cwang2016/orgs","repos_url":"https://api.github.com/users/cwang2016/repos","events_url":"https://api.github.com/users/cwang2016/events{/privacy}","received_events_url":"https://api.github.com/users/cwang2016/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/624/commits","review_comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/624/comments","review_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/624/comments","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/0d82d467bebec8ba7752ceae549fbc43faab870d","head":{"label":"Caltech-IPAC:DM-14673-MarkerLabel","ref":"DM-14673-MarkerLabel","sha":"0d82d467bebec8ba7752ceae549fbc43faab870d","user":{"login":"Caltech-IPAC","id":9708378,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MDgzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"repo":{"id":33508214,"node_id":"MDEwOlJlcG9zaXRvcnkzMzUwODIxNA==","name":"firefly","full_name":"Caltech-IPAC/firefly","owner":{"login":"Caltech-IPAC","id":9708378,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MDgzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Caltech-IPAC/firefly","description":"IPAC Firefly ","fork":false,"url":"https://api.github.com/repos/Caltech-IPAC/firefly","forks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/forks","keys_url":"https://api.github.com/repos/Caltech-IPAC/firefly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caltech-IPAC/firefly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caltech-IPAC/firefly/teams","hooks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/hooks","issue_events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/events{/number}","events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/events","assignees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/assignees{/user}","branches_url":"https://api.github.com/repos/Caltech-IPAC/firefly/branches{/branch}","tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/tags","blobs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/{sha}","languages_url":"https://api.github.com/repos/Caltech-IPAC/firefly/languages","stargazers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/stargazers","contributors_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contributors","subscribers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscribers","subscription_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscription","commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contents/{+path}","compare_url":"https://api.github.com/repos/Caltech-IPAC/firefly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caltech-IPAC/firefly/merges","archive_url":"https://api.github.com/repos/Caltech-IPAC/firefly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caltech-IPAC/firefly/downloads","issues_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues{/number}","pulls_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls{/number}","milestones_url":"https://api.github.com/repos/Caltech-IPAC/firefly/milestones{/number}","notifications_url":"https://api.github.com/repos/Caltech-IPAC/firefly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caltech-IPAC/firefly/labels{/name}","releases_url":"https://api.github.com/repos/Caltech-IPAC/firefly/releases{/id}","deployments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/deployments","created_at":"2015-04-06T22:03:13Z","updated_at":"2018-06-13T23:33:00Z","pushed_at":"2018-06-14T18:55:52Z","git_url":"git://github.com/Caltech-IPAC/firefly.git","ssh_url":"git@github.com:Caltech-IPAC/firefly.git","clone_url":"https://github.com/Caltech-IPAC/firefly.git","svn_url":"https://github.com/Caltech-IPAC/firefly","homepage":"","size":165441,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":8,"watchers":9,"default_branch":"dev"}},"base":{"label":"Caltech-IPAC:dev","ref":"dev","sha":"aeffc2363bfc787e31019593b0abeaab6d1ca23c","user":{"login":"Caltech-IPAC","id":9708378,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MDgzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"repo":{"id":33508214,"node_id":"MDEwOlJlcG9zaXRvcnkzMzUwODIxNA==","name":"firefly","full_name":"Caltech-IPAC/firefly","owner":{"login":"Caltech-IPAC","id":9708378,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MDgzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Caltech-IPAC/firefly","description":"IPAC Firefly ","fork":false,"url":"https://api.github.com/repos/Caltech-IPAC/firefly","forks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/forks","keys_url":"https://api.github.com/repos/Caltech-IPAC/firefly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caltech-IPAC/firefly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caltech-IPAC/firefly/teams","hooks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/hooks","issue_events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/events{/number}","events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/events","assignees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/assignees{/user}","branches_url":"https://api.github.com/repos/Caltech-IPAC/firefly/branches{/branch}","tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/tags","blobs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/{sha}","languages_url":"https://api.github.com/repos/Caltech-IPAC/firefly/languages","stargazers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/stargazers","contributors_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contributors","subscribers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscribers","subscription_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscription","commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contents/{+path}","compare_url":"https://api.github.com/repos/Caltech-IPAC/firefly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caltech-IPAC/firefly/merges","archive_url":"https://api.github.com/repos/Caltech-IPAC/firefly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caltech-IPAC/firefly/downloads","issues_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues{/number}","pulls_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls{/number}","milestones_url":"https://api.github.com/repos/Caltech-IPAC/firefly/milestones{/number}","notifications_url":"https://api.github.com/repos/Caltech-IPAC/firefly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caltech-IPAC/firefly/labels{/name}","releases_url":"https://api.github.com/repos/Caltech-IPAC/firefly/releases{/id}","deployments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/deployments","created_at":"2015-04-06T22:03:13Z","updated_at":"2018-06-13T23:33:00Z","pushed_at":"2018-06-14T18:55:52Z","git_url":"git://github.com/Caltech-IPAC/firefly.git","ssh_url":"git@github.com:Caltech-IPAC/firefly.git","clone_url":"https://github.com/Caltech-IPAC/firefly.git","svn_url":"https://github.com/Caltech-IPAC/firefly","homepage":"","size":165441,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":8,"watchers":9,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/624"},"html":{"href":"https://github.com/Caltech-IPAC/firefly/pull/624"},"issue":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/624"},"comments":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/624/comments"},"review_comments":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/624/comments"},"review_comment":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/624/commits"},"statuses":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/0d82d467bebec8ba7752ceae549fbc43faab870d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robyww"}}