{"action":"closed","number":411,"pull_request":{"url":"https://api.github.com/repos/EOSIO/eosjs/pulls/411","id":225325494,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzI1NDk0","html_url":"https://github.com/EOSIO/eosjs/pull/411","diff_url":"https://github.com/EOSIO/eosjs/pull/411.diff","patch_url":"https://github.com/EOSIO/eosjs/pull/411.patch","issue_url":"https://api.github.com/repos/EOSIO/eosjs/issues/411","number":411,"state":"closed","locked":false,"title":"Replace the use of \"Proxy\" in ripemd.js to make eosjs compatible to IE11","user":{"login":"terrylks","id":41313054,"node_id":"MDQ6VXNlcjQxMzEzMDU0","avatar_url":"https://avatars3.githubusercontent.com/u/41313054?v=4","gravatar_id":"","url":"https://api.github.com/users/terrylks","html_url":"https://github.com/terrylks","followers_url":"https://api.github.com/users/terrylks/followers","following_url":"https://api.github.com/users/terrylks/following{/other_user}","gists_url":"https://api.github.com/users/terrylks/gists{/gist_id}","starred_url":"https://api.github.com/users/terrylks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrylks/subscriptions","organizations_url":"https://api.github.com/users/terrylks/orgs","repos_url":"https://api.github.com/users/terrylks/repos","events_url":"https://api.github.com/users/terrylks/events{/privacy}","received_events_url":"https://api.github.com/users/terrylks/received_events","type":"User","site_admin":false},"body":"@tbfleming @chris-allnutt \r\nPlease refer this pull request to https://github.com/EOSIO/eosjs2/issues/76\r\nI am proposing the fix here since we have migrated eosjs2 to this repo.\r\n\r\nBackground:\r\nWhile calculating the RIPEMD160 hash with `ripemd.js` in eosjs, `Proxy` is used during the calculation. `Proxy` is not supported in IE11 hence eosjs did not work in IE11.\r\nhttps://github.com/EOSIO/eosjs/blob/master/src/ripemd.js#L382\r\nhttps://github.com/EOSIO/eosjs/blob/master/src/ripemd.es5.js#L331\r\n\r\nFix:\r\nReplace the way to access the DataView object with an anonymous function instead of a Proxy. Access it by calling the function directly.\r\n\r\nTest:\r\nI have put about 10 input cases for the fixed ripemd160 hash function and the result values are same as the original.\r\nI have included the fix locally for the simple-boilerplate-dapp and the game Elemental Battles. After the fix, both dapps works fine in IE11 now and also works fine in other browsers.\r\n\r\nRemark:\r\nAlthough only `ripemd.es5.js` will be built to the `/dist` folder, I have done the fix on `ripemd.js` first and use babel to compile it into `ripemd.es5.js`. This pull request include fixes for both JS files.\r\n\r\ncc @jeffreyssmith2nd @chris-allnutt @rickykung @andriantolie ","created_at":"2018-10-24T09:19:13Z","updated_at":"2018-11-01T22:40:15Z","closed_at":"2018-11-01T22:40:15Z","merged_at":"2018-11-01T22:40:15Z","merge_commit_sha":"941c92a9e2b3aa6bc61a4701174b64736964e466","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EOSIO/eosjs/pulls/411/commits","review_comments_url":"https://api.github.com/repos/EOSIO/eosjs/pulls/411/comments","review_comment_url":"https://api.github.com/repos/EOSIO/eosjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EOSIO/eosjs/issues/411/comments","statuses_url":"https://api.github.com/repos/EOSIO/eosjs/statuses/e08bd807283ff4a4bb5642b5095ae6b035b936c8","head":{"label":"terrylks:ripemd160-remove-proxy","ref":"ripemd160-remove-proxy","sha":"e08bd807283ff4a4bb5642b5095ae6b035b936c8","user":{"login":"terrylks","id":41313054,"node_id":"MDQ6VXNlcjQxMzEzMDU0","avatar_url":"https://avatars3.githubusercontent.com/u/41313054?v=4","gravatar_id":"","url":"https://api.github.com/users/terrylks","html_url":"https://github.com/terrylks","followers_url":"https://api.github.com/users/terrylks/followers","following_url":"https://api.github.com/users/terrylks/following{/other_user}","gists_url":"https://api.github.com/users/terrylks/gists{/gist_id}","starred_url":"https://api.github.com/users/terrylks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrylks/subscriptions","organizations_url":"https://api.github.com/users/terrylks/orgs","repos_url":"https://api.github.com/users/terrylks/repos","events_url":"https://api.github.com/users/terrylks/events{/privacy}","received_events_url":"https://api.github.com/users/terrylks/received_events","type":"User","site_admin":false},"repo":{"id":154455547,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0NTU1NDc=","name":"eosjs","full_name":"terrylks/eosjs","private":false,"owner":{"login":"terrylks","id":41313054,"node_id":"MDQ6VXNlcjQxMzEzMDU0","avatar_url":"https://avatars3.githubusercontent.com/u/41313054?v=4","gravatar_id":"","url":"https://api.github.com/users/terrylks","html_url":"https://github.com/terrylks","followers_url":"https://api.github.com/users/terrylks/followers","following_url":"https://api.github.com/users/terrylks/following{/other_user}","gists_url":"https://api.github.com/users/terrylks/gists{/gist_id}","starred_url":"https://api.github.com/users/terrylks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrylks/subscriptions","organizations_url":"https://api.github.com/users/terrylks/orgs","repos_url":"https://api.github.com/users/terrylks/repos","events_url":"https://api.github.com/users/terrylks/events{/privacy}","received_events_url":"https://api.github.com/users/terrylks/received_events","type":"User","site_admin":false},"html_url":"https://github.com/terrylks/eosjs","description":"General purpose library for the EOS blockchain. ","fork":true,"url":"https://api.github.com/repos/terrylks/eosjs","forks_url":"https://api.github.com/repos/terrylks/eosjs/forks","keys_url":"https://api.github.com/repos/terrylks/eosjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terrylks/eosjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terrylks/eosjs/teams","hooks_url":"https://api.github.com/repos/terrylks/eosjs/hooks","issue_events_url":"https://api.github.com/repos/terrylks/eosjs/issues/events{/number}","events_url":"https://api.github.com/repos/terrylks/eosjs/events","assignees_url":"https://api.github.com/repos/terrylks/eosjs/assignees{/user}","branches_url":"https://api.github.com/repos/terrylks/eosjs/branches{/branch}","tags_url":"https://api.github.com/repos/terrylks/eosjs/tags","blobs_url":"https://api.github.com/repos/terrylks/eosjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terrylks/eosjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terrylks/eosjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/terrylks/eosjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terrylks/eosjs/statuses/{sha}","languages_url":"https://api.github.com/repos/terrylks/eosjs/languages","stargazers_url":"https://api.github.com/repos/terrylks/eosjs/stargazers","contributors_url":"https://api.github.com/repos/terrylks/eosjs/contributors","subscribers_url":"https://api.github.com/repos/terrylks/eosjs/subscribers","subscription_url":"https://api.github.com/repos/terrylks/eosjs/subscription","commits_url":"https://api.github.com/repos/terrylks/eosjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/terrylks/eosjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/terrylks/eosjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/terrylks/eosjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/terrylks/eosjs/contents/{+path}","compare_url":"https://api.github.com/repos/terrylks/eosjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terrylks/eosjs/merges","archive_url":"https://api.github.com/repos/terrylks/eosjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terrylks/eosjs/downloads","issues_url":"https://api.github.com/repos/terrylks/eosjs/issues{/number}","pulls_url":"https://api.github.com/repos/terrylks/eosjs/pulls{/number}","milestones_url":"https://api.github.com/repos/terrylks/eosjs/milestones{/number}","notifications_url":"https://api.github.com/repos/terrylks/eosjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terrylks/eosjs/labels{/name}","releases_url":"https://api.github.com/repos/terrylks/eosjs/releases{/id}","deployments_url":"https://api.github.com/repos/terrylks/eosjs/deployments","created_at":"2018-10-24T07:12:42Z","updated_at":"2018-10-24T07:12:45Z","pushed_at":"2018-10-24T08:53:17Z","git_url":"git://github.com/terrylks/eosjs.git","ssh_url":"git@github.com:terrylks/eosjs.git","clone_url":"https://github.com/terrylks/eosjs.git","svn_url":"https://github.com/terrylks/eosjs","homepage":"http://eosio.github.io/eosjs","size":2631,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EOSIO:master","ref":"master","sha":"e5ca122dc06c53fa5a92ce0188e73e2fc94cd9e2","user":{"login":"EOSIO","id":26932212,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTMyMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"repo":{"id":99262393,"node_id":"MDEwOlJlcG9zaXRvcnk5OTI2MjM5Mw==","name":"eosjs","full_name":"EOSIO/eosjs","private":false,"owner":{"login":"EOSIO","id":26932212,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTMyMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EOSIO/eosjs","description":"General purpose library for the EOS blockchain. ","fork":false,"url":"https://api.github.com/repos/EOSIO/eosjs","forks_url":"https://api.github.com/repos/EOSIO/eosjs/forks","keys_url":"https://api.github.com/repos/EOSIO/eosjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EOSIO/eosjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EOSIO/eosjs/teams","hooks_url":"https://api.github.com/repos/EOSIO/eosjs/hooks","issue_events_url":"https://api.github.com/repos/EOSIO/eosjs/issues/events{/number}","events_url":"https://api.github.com/repos/EOSIO/eosjs/events","assignees_url":"https://api.github.com/repos/EOSIO/eosjs/assignees{/user}","branches_url":"https://api.github.com/repos/EOSIO/eosjs/branches{/branch}","tags_url":"https://api.github.com/repos/EOSIO/eosjs/tags","blobs_url":"https://api.github.com/repos/EOSIO/eosjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EOSIO/eosjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EOSIO/eosjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/EOSIO/eosjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EOSIO/eosjs/statuses/{sha}","languages_url":"https://api.github.com/repos/EOSIO/eosjs/languages","stargazers_url":"https://api.github.com/repos/EOSIO/eosjs/stargazers","contributors_url":"https://api.github.com/repos/EOSIO/eosjs/contributors","subscribers_url":"https://api.github.com/repos/EOSIO/eosjs/subscribers","subscription_url":"https://api.github.com/repos/EOSIO/eosjs/subscription","commits_url":"https://api.github.com/repos/EOSIO/eosjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/EOSIO/eosjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/EOSIO/eosjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/EOSIO/eosjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/EOSIO/eosjs/contents/{+path}","compare_url":"https://api.github.com/repos/EOSIO/eosjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EOSIO/eosjs/merges","archive_url":"https://api.github.com/repos/EOSIO/eosjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EOSIO/eosjs/downloads","issues_url":"https://api.github.com/repos/EOSIO/eosjs/issues{/number}","pulls_url":"https://api.github.com/repos/EOSIO/eosjs/pulls{/number}","milestones_url":"https://api.github.com/repos/EOSIO/eosjs/milestones{/number}","notifications_url":"https://api.github.com/repos/EOSIO/eosjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EOSIO/eosjs/labels{/name}","releases_url":"https://api.github.com/repos/EOSIO/eosjs/releases{/id}","deployments_url":"https://api.github.com/repos/EOSIO/eosjs/deployments","created_at":"2017-08-03T18:17:52Z","updated_at":"2018-11-01T22:40:05Z","pushed_at":"2018-11-01T22:40:15Z","git_url":"git://github.com/EOSIO/eosjs.git","ssh_url":"git@github.com:EOSIO/eosjs.git","clone_url":"https://github.com/EOSIO/eosjs.git","svn_url":"https://github.com/EOSIO/eosjs","homepage":"http://eosio.github.io/eosjs","size":2768,"stargazers_count":929,"watchers_count":929,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":247,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":247,"open_issues":57,"watchers":929,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EOSIO/eosjs/pulls/411"},"html":{"href":"https://github.com/EOSIO/eosjs/pull/411"},"issue":{"href":"https://api.github.com/repos/EOSIO/eosjs/issues/411"},"comments":{"href":"https://api.github.com/repos/EOSIO/eosjs/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/EOSIO/eosjs/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/EOSIO/eosjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EOSIO/eosjs/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/EOSIO/eosjs/statuses/e08bd807283ff4a4bb5642b5095ae6b035b936c8"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"c0d3ster","id":16199485,"node_id":"MDQ6VXNlcjE2MTk5NDg1","avatar_url":"https://avatars0.githubusercontent.com/u/16199485?v=4","gravatar_id":"","url":"https://api.github.com/users/c0d3ster","html_url":"https://github.com/c0d3ster","followers_url":"https://api.github.com/users/c0d3ster/followers","following_url":"https://api.github.com/users/c0d3ster/following{/other_user}","gists_url":"https://api.github.com/users/c0d3ster/gists{/gist_id}","starred_url":"https://api.github.com/users/c0d3ster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0d3ster/subscriptions","organizations_url":"https://api.github.com/users/c0d3ster/orgs","repos_url":"https://api.github.com/users/c0d3ster/repos","events_url":"https://api.github.com/users/c0d3ster/events{/privacy}","received_events_url":"https://api.github.com/users/c0d3ster/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"c0d3ster"}}