{"action":"created","issue":{"url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1035","repository_url":"https://api.github.com/repos/thoughtbot/factory_bot","labels_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1035/labels{/name}","comments_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1035/comments","events_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1035/events","html_url":"https://github.com/thoughtbot/factory_bot/pull/1035","id":259663686,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQyNDY5NTgz","number":1035,"title":"Update dependencies as of 2017 10","user":{"login":"abinoam","id":551790,"node_id":"MDQ6VXNlcjU1MTc5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/551790?v=4","gravatar_id":"","url":"https://api.github.com/users/abinoam","html_url":"https://github.com/abinoam","followers_url":"https://api.github.com/users/abinoam/followers","following_url":"https://api.github.com/users/abinoam/following{/other_user}","gists_url":"https://api.github.com/users/abinoam/gists{/gist_id}","starred_url":"https://api.github.com/users/abinoam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abinoam/subscriptions","organizations_url":"https://api.github.com/users/abinoam/orgs","repos_url":"https://api.github.com/users/abinoam/repos","events_url":"https://api.github.com/users/abinoam/events{/privacy}","received_events_url":"https://api.github.com/users/abinoam/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-21T23:43:15Z","updated_at":"2018-07-26T00:14:12Z","closed_at":"2018-07-26T00:14:12Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1035","html_url":"https://github.com/thoughtbot/factory_bot/pull/1035","diff_url":"https://github.com/thoughtbot/factory_bot/pull/1035.diff","patch_url":"https://github.com/thoughtbot/factory_bot/pull/1035.patch"},"body":"EDIT (23 sep 2017): I think now it's ready for review.\r\n\r\n- Adds JRuby back to travis (by adjusting gemfiles). Passing!\r\n- Adds Rubinius back to travis. Failing 3 examples.\r\n- Adds ActiveRecord 5.1 to travis filtering the right rubies to run against it\r\n- Adds Ruby 2.4.1 to travis matrix. Passing on 4.2, 5.0 and 5.1.gemfile.\r\n- Ruby-head is resolving to 2.5.0dev. Passing on 5.0 and 5.1.gemfile.\r\n- Fixes an ineffective spec (allow -> expect)\r\n- Update all dependencies. Gemnasium badge now will be green again.\r\n- Small speedup to travis builds by using the preinstalled rubies\r\n\r\nDetails on each commit message.\r\n\r\nFeel free to accept/reject/suggest/anything.\r\n\r\n---\r\nHi @joshuaclayton,\r\n\r\nThis ```dependencies out-of-date``` gemnasium badge was annoying me.\r\nThis PR updates dependencies and fixes the warnings coming from the process.\r\n\r\n`rake` and `appraisal rake` passing without any warnings or errors.\r\n\r\nOne question, is FactoryGirl policy to keep Gemfile.lock files under version control?\r\n~Could we just wipe them off and gitignore them?\r\n(I can do it and rebase before merging if you want)~\r\n\r\nThanks for your work on FactoryGirl!"},"comment":{"url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/comments/407935797","html_url":"https://github.com/thoughtbot/factory_bot/pull/1035#issuecomment-407935797","issue_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1035","id":407935797,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzkzNTc5Nw==","user":{"login":"composerinteralia","id":13696143,"node_id":"MDQ6VXNlcjEzNjk2MTQz","avatar_url":"https://avatars3.githubusercontent.com/u/13696143?v=4","gravatar_id":"","url":"https://api.github.com/users/composerinteralia","html_url":"https://github.com/composerinteralia","followers_url":"https://api.github.com/users/composerinteralia/followers","following_url":"https://api.github.com/users/composerinteralia/following{/other_user}","gists_url":"https://api.github.com/users/composerinteralia/gists{/gist_id}","starred_url":"https://api.github.com/users/composerinteralia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/composerinteralia/subscriptions","organizations_url":"https://api.github.com/users/composerinteralia/orgs","repos_url":"https://api.github.com/users/composerinteralia/repos","events_url":"https://api.github.com/users/composerinteralia/events{/privacy}","received_events_url":"https://api.github.com/users/composerinteralia/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T00:14:12Z","updated_at":"2018-07-26T00:14:12Z","author_association":"MEMBER","body":"Thanks for the PR! I'm sorry it got overlooked. I don't think it was intentional; I'm guessing people just got busy and didn't see it.\r\n\r\nI'm going to close this PR, since at this point it is pretty far out of date, and many of these changes were made in other PRs along the way.\r\n\r\nThanks again for your contribution. I am going to try to keep on top of the issues and PRs, so if you want to make any further contributions feel free to ping me with any questions!"}}
{"actor":{"display_login":"composerinteralia"}}