{"action":"created","comment":{"url":"https://api.github.com/repos/django-extensions/django-extensions/pulls/comments/209900127","pull_request_review_id":146000604,"id":209900127,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTkwMDEyNw==","diff_hunk":"@@ -82,6 +82,14 @@ class Meta:\n         app_label = 'django_extensions'\n \n \n+class SluggedTestBytesLookupValueModel(models.Model):\n+    title = models.CharField(max_length=42)\n+    slug = AutoSlugField(populate_from=b'title')","path":"tests/testapp/models.py","position":6,"original_position":6,"commit_id":"716832fb9fbe78c6970930b378e0c0962beccd2e","original_commit_id":"716832fb9fbe78c6970930b378e0c0962beccd2e","user":{"login":"trbs","id":65552,"node_id":"MDQ6VXNlcjY1NTUy","avatar_url":"https://avatars0.githubusercontent.com/u/65552?v=4","gravatar_id":"","url":"https://api.github.com/users/trbs","html_url":"https://github.com/trbs","followers_url":"https://api.github.com/users/trbs/followers","following_url":"https://api.github.com/users/trbs/following{/other_user}","gists_url":"https://api.github.com/users/trbs/gists{/gist_id}","starred_url":"https://api.github.com/users/trbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trbs/subscriptions","organizations_url":"https://api.github.com/users/trbs/orgs","repos_url":"https://api.github.com/users/trbs/repos","events_url":"https://api.github.com/users/trbs/events{/privacy}","received_events_url":"https://api.github.com/users/trbs/received_events","type":"User","site_admin":false},"body":"I would like to know why that exactly happened and I think the current test does not really do that. The test implies that `bytes` is a valid value type for this attribute and that it should work and the field should convert it. However I'm not entirely sure that the fault in that lies with the Django Extensions field.\r\n\r\n`SluggedTestModel` and `test_auto_create_slug` does already test for the normal case and  that passes the build with Python 3.6 and Django 1.11.\r\n\r\nSo the question is why does it fail for you. \r\n\r\nI'm sorry to not just quickly merge this but it feels like a workaround for me... since this should not happen in the first place.\r\n\r\n","created_at":"2018-08-14T10:18:04Z","updated_at":"2018-08-14T10:18:05Z","html_url":"https://github.com/django-extensions/django-extensions/pull/1237#discussion_r209900127","pull_request_url":"https://api.github.com/repos/django-extensions/django-extensions/pulls/1237","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/django-extensions/django-extensions/pulls/comments/209900127"},"html":{"href":"https://github.com/django-extensions/django-extensions/pull/1237#discussion_r209900127"},"pull_request":{"href":"https://api.github.com/repos/django-extensions/django-extensions/pulls/1237"}},"in_reply_to_id":209879105},"pull_request":{"url":"https://api.github.com/repos/django-extensions/django-extensions/pulls/1237","id":208197396,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTk3Mzk2","html_url":"https://github.com/django-extensions/django-extensions/pull/1237","diff_url":"https://github.com/django-extensions/django-extensions/pull/1237.diff","patch_url":"https://github.com/django-extensions/django-extensions/pull/1237.patch","issue_url":"https://api.github.com/repos/django-extensions/django-extensions/issues/1237","number":1237,"state":"open","locked":false,"title":"decode lookup_value if it is bytes instead of str","user":{"login":"behconsci","id":10358323,"node_id":"MDQ6VXNlcjEwMzU4MzIz","avatar_url":"https://avatars0.githubusercontent.com/u/10358323?v=4","gravatar_id":"","url":"https://api.github.com/users/behconsci","html_url":"https://github.com/behconsci","followers_url":"https://api.github.com/users/behconsci/followers","following_url":"https://api.github.com/users/behconsci/following{/other_user}","gists_url":"https://api.github.com/users/behconsci/gists{/gist_id}","starred_url":"https://api.github.com/users/behconsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behconsci/subscriptions","organizations_url":"https://api.github.com/users/behconsci/orgs","repos_url":"https://api.github.com/users/behconsci/repos","events_url":"https://api.github.com/users/behconsci/events{/privacy}","received_events_url":"https://api.github.com/users/behconsci/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-14T07:55:29Z","updated_at":"2018-08-14T10:18:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bf1eac7cb80a38b971ac9ad5bdbaaac68e15d1e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/django-extensions/django-extensions/pulls/1237/commits","review_comments_url":"https://api.github.com/repos/django-extensions/django-extensions/pulls/1237/comments","review_comment_url":"https://api.github.com/repos/django-extensions/django-extensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django-extensions/django-extensions/issues/1237/comments","statuses_url":"https://api.github.com/repos/django-extensions/django-extensions/statuses/716832fb9fbe78c6970930b378e0c0962beccd2e","head":{"label":"behconsci:master","ref":"master","sha":"716832fb9fbe78c6970930b378e0c0962beccd2e","user":{"login":"behconsci","id":10358323,"node_id":"MDQ6VXNlcjEwMzU4MzIz","avatar_url":"https://avatars0.githubusercontent.com/u/10358323?v=4","gravatar_id":"","url":"https://api.github.com/users/behconsci","html_url":"https://github.com/behconsci","followers_url":"https://api.github.com/users/behconsci/followers","following_url":"https://api.github.com/users/behconsci/following{/other_user}","gists_url":"https://api.github.com/users/behconsci/gists{/gist_id}","starred_url":"https://api.github.com/users/behconsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behconsci/subscriptions","organizations_url":"https://api.github.com/users/behconsci/orgs","repos_url":"https://api.github.com/users/behconsci/repos","events_url":"https://api.github.com/users/behconsci/events{/privacy}","received_events_url":"https://api.github.com/users/behconsci/received_events","type":"User","site_admin":false},"repo":{"id":144548388,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1NDgzODg=","name":"django-extensions","full_name":"behconsci/django-extensions","owner":{"login":"behconsci","id":10358323,"node_id":"MDQ6VXNlcjEwMzU4MzIz","avatar_url":"https://avatars0.githubusercontent.com/u/10358323?v=4","gravatar_id":"","url":"https://api.github.com/users/behconsci","html_url":"https://github.com/behconsci","followers_url":"https://api.github.com/users/behconsci/followers","following_url":"https://api.github.com/users/behconsci/following{/other_user}","gists_url":"https://api.github.com/users/behconsci/gists{/gist_id}","starred_url":"https://api.github.com/users/behconsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behconsci/subscriptions","organizations_url":"https://api.github.com/users/behconsci/orgs","repos_url":"https://api.github.com/users/behconsci/repos","events_url":"https://api.github.com/users/behconsci/events{/privacy}","received_events_url":"https://api.github.com/users/behconsci/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/behconsci/django-extensions","description":"This is a repository for collecting global custom management extensions for the Django Framework. ","fork":true,"url":"https://api.github.com/repos/behconsci/django-extensions","forks_url":"https://api.github.com/repos/behconsci/django-extensions/forks","keys_url":"https://api.github.com/repos/behconsci/django-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/behconsci/django-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/behconsci/django-extensions/teams","hooks_url":"https://api.github.com/repos/behconsci/django-extensions/hooks","issue_events_url":"https://api.github.com/repos/behconsci/django-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/behconsci/django-extensions/events","assignees_url":"https://api.github.com/repos/behconsci/django-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/behconsci/django-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/behconsci/django-extensions/tags","blobs_url":"https://api.github.com/repos/behconsci/django-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/behconsci/django-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/behconsci/django-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/behconsci/django-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/behconsci/django-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/behconsci/django-extensions/languages","stargazers_url":"https://api.github.com/repos/behconsci/django-extensions/stargazers","contributors_url":"https://api.github.com/repos/behconsci/django-extensions/contributors","subscribers_url":"https://api.github.com/repos/behconsci/django-extensions/subscribers","subscription_url":"https://api.github.com/repos/behconsci/django-extensions/subscription","commits_url":"https://api.github.com/repos/behconsci/django-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/behconsci/django-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/behconsci/django-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/behconsci/django-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/behconsci/django-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/behconsci/django-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/behconsci/django-extensions/merges","archive_url":"https://api.github.com/repos/behconsci/django-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/behconsci/django-extensions/downloads","issues_url":"https://api.github.com/repos/behconsci/django-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/behconsci/django-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/behconsci/django-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/behconsci/django-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/behconsci/django-extensions/labels{/name}","releases_url":"https://api.github.com/repos/behconsci/django-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/behconsci/django-extensions/deployments","created_at":"2018-08-13T08:06:43Z","updated_at":"2018-08-14T07:53:30Z","pushed_at":"2018-08-14T07:53:29Z","git_url":"git://github.com/behconsci/django-extensions.git","ssh_url":"git@github.com:behconsci/django-extensions.git","clone_url":"https://github.com/behconsci/django-extensions.git","svn_url":"https://github.com/behconsci/django-extensions","homepage":"https://django-extensions.readthedocs.io","size":2787,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django-extensions:master","ref":"master","sha":"518e3e63dc733f10c16f8f4e73a2dc48183ba186","user":{"login":"django-extensions","id":65559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NTU5","avatar_url":"https://avatars1.githubusercontent.com/u/65559?v=4","gravatar_id":"","url":"https://api.github.com/users/django-extensions","html_url":"https://github.com/django-extensions","followers_url":"https://api.github.com/users/django-extensions/followers","following_url":"https://api.github.com/users/django-extensions/following{/other_user}","gists_url":"https://api.github.com/users/django-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/django-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-extensions/subscriptions","organizations_url":"https://api.github.com/users/django-extensions/orgs","repos_url":"https://api.github.com/users/django-extensions/repos","events_url":"https://api.github.com/users/django-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/django-extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":155815,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU4MTU=","name":"django-extensions","full_name":"django-extensions/django-extensions","owner":{"login":"django-extensions","id":65559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NTU5","avatar_url":"https://avatars1.githubusercontent.com/u/65559?v=4","gravatar_id":"","url":"https://api.github.com/users/django-extensions","html_url":"https://github.com/django-extensions","followers_url":"https://api.github.com/users/django-extensions/followers","following_url":"https://api.github.com/users/django-extensions/following{/other_user}","gists_url":"https://api.github.com/users/django-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/django-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-extensions/subscriptions","organizations_url":"https://api.github.com/users/django-extensions/orgs","repos_url":"https://api.github.com/users/django-extensions/repos","events_url":"https://api.github.com/users/django-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/django-extensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django-extensions/django-extensions","description":"This is a repository for collecting global custom management extensions for the Django Framework. ","fork":false,"url":"https://api.github.com/repos/django-extensions/django-extensions","forks_url":"https://api.github.com/repos/django-extensions/django-extensions/forks","keys_url":"https://api.github.com/repos/django-extensions/django-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django-extensions/django-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django-extensions/django-extensions/teams","hooks_url":"https://api.github.com/repos/django-extensions/django-extensions/hooks","issue_events_url":"https://api.github.com/repos/django-extensions/django-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/django-extensions/django-extensions/events","assignees_url":"https://api.github.com/repos/django-extensions/django-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/django-extensions/django-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/django-extensions/django-extensions/tags","blobs_url":"https://api.github.com/repos/django-extensions/django-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django-extensions/django-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django-extensions/django-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/django-extensions/django-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django-extensions/django-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/django-extensions/django-extensions/languages","stargazers_url":"https://api.github.com/repos/django-extensions/django-extensions/stargazers","contributors_url":"https://api.github.com/repos/django-extensions/django-extensions/contributors","subscribers_url":"https://api.github.com/repos/django-extensions/django-extensions/subscribers","subscription_url":"https://api.github.com/repos/django-extensions/django-extensions/subscription","commits_url":"https://api.github.com/repos/django-extensions/django-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/django-extensions/django-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/django-extensions/django-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/django-extensions/django-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/django-extensions/django-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/django-extensions/django-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django-extensions/django-extensions/merges","archive_url":"https://api.github.com/repos/django-extensions/django-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django-extensions/django-extensions/downloads","issues_url":"https://api.github.com/repos/django-extensions/django-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/django-extensions/django-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/django-extensions/django-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/django-extensions/django-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django-extensions/django-extensions/labels{/name}","releases_url":"https://api.github.com/repos/django-extensions/django-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/django-extensions/django-extensions/deployments","created_at":"2009-03-21T16:11:19Z","updated_at":"2018-08-14T10:16:29Z","pushed_at":"2018-08-14T10:16:24Z","git_url":"git://github.com/django-extensions/django-extensions.git","ssh_url":"git@github.com:django-extensions/django-extensions.git","clone_url":"https://github.com/django-extensions/django-extensions.git","svn_url":"https://github.com/django-extensions/django-extensions","homepage":"https://django-extensions.readthedocs.io","size":2801,"stargazers_count":3801,"watchers_count":3801,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":807,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":807,"open_issues":64,"watchers":3801,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django-extensions/django-extensions/pulls/1237"},"html":{"href":"https://github.com/django-extensions/django-extensions/pull/1237"},"issue":{"href":"https://api.github.com/repos/django-extensions/django-extensions/issues/1237"},"comments":{"href":"https://api.github.com/repos/django-extensions/django-extensions/issues/1237/comments"},"review_comments":{"href":"https://api.github.com/repos/django-extensions/django-extensions/pulls/1237/comments"},"review_comment":{"href":"https://api.github.com/repos/django-extensions/django-extensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django-extensions/django-extensions/pulls/1237/commits"},"statuses":{"href":"https://api.github.com/repos/django-extensions/django-extensions/statuses/716832fb9fbe78c6970930b378e0c0962beccd2e"}},"author_association":"NONE"}}
{"actor":{"display_login":"trbs"}}