{"action":"created","comment":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/239657814","pull_request_review_id":182503286,"id":239657814,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTY1NzgxNA==","diff_hunk":"@@ -3113,6 +3114,149 @@ TEST(cpu_fusion, fuse_leaky_relu)\n     EXPECT_TRUE(test::all_close(cpu2_results.at(0), expected_result));\n }\n \n+TEST(cpu_fusion, fuse_update_slice)\n+{\n+    auto make_function = [](bool fuse = true) {\n+        auto input = std::make_shared<op::Parameter>(element::f32, Shape{4, 32, 16});\n+        Shape lower_bounds{1, 0, 0};\n+        Shape upper_bounds{2, 32, 16};\n+        auto slice = std::make_shared<op::Slice>(\n+            input, fuse ? lower_bounds : Shape{3, 0, 0}, fuse ? upper_bounds : Shape{4, 32, 16});\n+        auto update = std::make_shared<op::Parameter>(element::f32, Shape{1, 32, 16});","path":"test/cpu_fusion.cpp","position":29,"original_position":29,"commit_id":"7a465a2b6f3231746b14e325e55864ffa0b0eb05","original_commit_id":"7a465a2b6f3231746b14e325e55864ffa0b0eb05","user":{"login":"jbobba","id":21375855,"node_id":"MDQ6VXNlcjIxMzc1ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/21375855?v=4","gravatar_id":"","url":"https://api.github.com/users/jbobba","html_url":"https://github.com/jbobba","followers_url":"https://api.github.com/users/jbobba/followers","following_url":"https://api.github.com/users/jbobba/following{/other_user}","gists_url":"https://api.github.com/users/jbobba/gists{/gist_id}","starred_url":"https://api.github.com/users/jbobba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbobba/subscriptions","organizations_url":"https://api.github.com/users/jbobba/orgs","repos_url":"https://api.github.com/users/jbobba/repos","events_url":"https://api.github.com/users/jbobba/events{/privacy}","received_events_url":"https://api.github.com/users/jbobba/received_events","type":"User","site_admin":false},"body":"fusion callback should check that the slice and replace_slice are indeed working on the same portion of the tensor. Otherwise, it shouldn't fuse.","created_at":"2018-12-06T23:56:00Z","updated_at":"2018-12-06T23:56:01Z","html_url":"https://github.com/NervanaSystems/ngraph/pull/2180#discussion_r239657814","pull_request_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2180","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/239657814"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/2180#discussion_r239657814"},"pull_request":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2180"}},"in_reply_to_id":239273121},"pull_request":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2180","id":236307292,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzA3Mjky","html_url":"https://github.com/NervanaSystems/ngraph/pull/2180","diff_url":"https://github.com/NervanaSystems/ngraph/pull/2180.diff","patch_url":"https://github.com/NervanaSystems/ngraph/pull/2180.patch","issue_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/2180","number":2180,"state":"open","locked":false,"title":"Update slice kernels","user":{"login":"jbobba","id":21375855,"node_id":"MDQ6VXNlcjIxMzc1ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/21375855?v=4","gravatar_id":"","url":"https://api.github.com/users/jbobba","html_url":"https://github.com/jbobba","followers_url":"https://api.github.com/users/jbobba/followers","following_url":"https://api.github.com/users/jbobba/following{/other_user}","gists_url":"https://api.github.com/users/jbobba/gists{/gist_id}","starred_url":"https://api.github.com/users/jbobba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbobba/subscriptions","organizations_url":"https://api.github.com/users/jbobba/orgs","repos_url":"https://api.github.com/users/jbobba/repos","events_url":"https://api.github.com/users/jbobba/events{/privacy}","received_events_url":"https://api.github.com/users/jbobba/received_events","type":"User","site_admin":false},"body":"Over 5X improvement in GNMT backprop. \r\n\r\n![image](https://user-images.githubusercontent.com/21375855/49541142-c50bef80-f886-11e8-9c96-5aa6a77b2695.png)\r\n\r\nto \r\n\r\n![image](https://user-images.githubusercontent.com/21375855/49541332-58452500-f887-11e8-9a9d-4e0c747fcf61.png)\r\n\r\n\r\n\r\n","created_at":"2018-12-05T20:12:12Z","updated_at":"2018-12-06T23:56:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a559276207aa9c347668b7516ef7854ff035f31a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Krovatkin","id":5086322,"node_id":"MDQ6VXNlcjUwODYzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5086322?v=4","gravatar_id":"","url":"https://api.github.com/users/Krovatkin","html_url":"https://github.com/Krovatkin","followers_url":"https://api.github.com/users/Krovatkin/followers","following_url":"https://api.github.com/users/Krovatkin/following{/other_user}","gists_url":"https://api.github.com/users/Krovatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/Krovatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Krovatkin/subscriptions","organizations_url":"https://api.github.com/users/Krovatkin/orgs","repos_url":"https://api.github.com/users/Krovatkin/repos","events_url":"https://api.github.com/users/Krovatkin/events{/privacy}","received_events_url":"https://api.github.com/users/Krovatkin/received_events","type":"User","site_admin":false},{"login":"nbpatel","id":22088168,"node_id":"MDQ6VXNlcjIyMDg4MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/22088168?v=4","gravatar_id":"","url":"https://api.github.com/users/nbpatel","html_url":"https://github.com/nbpatel","followers_url":"https://api.github.com/users/nbpatel/followers","following_url":"https://api.github.com/users/nbpatel/following{/other_user}","gists_url":"https://api.github.com/users/nbpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/nbpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbpatel/subscriptions","organizations_url":"https://api.github.com/users/nbpatel/orgs","repos_url":"https://api.github.com/users/nbpatel/repos","events_url":"https://api.github.com/users/nbpatel/events{/privacy}","received_events_url":"https://api.github.com/users/nbpatel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1117374376,"node_id":"MDU6TGFiZWwxMTE3Mzc0Mzc2","url":"https://api.github.com/repos/NervanaSystems/ngraph/labels/IntelCPU","name":"IntelCPU","color":"a9f9f3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2180/commits","review_comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2180/comments","review_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/2180/comments","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/7a465a2b6f3231746b14e325e55864ffa0b0eb05","head":{"label":"NervanaSystems:jbobba/ngcpu-318","ref":"jbobba/ngcpu-318","sha":"7a465a2b6f3231746b14e325e55864ffa0b0eb05","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"node_id":"MDEwOlJlcG9zaXRvcnk5ODI1Mjk3Mw==","name":"ngraph","full_name":"NervanaSystems/ngraph","private":false,"owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-12-06T23:38:31Z","pushed_at":"2018-12-06T23:40:47Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"git@github.com:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":43512,"stargazers_count":737,"watchers_count":737,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":98,"open_issues":76,"watchers":737,"default_branch":"master"}},"base":{"label":"NervanaSystems:master","ref":"master","sha":"05c7fbe42494cbca053064bd741b61dea223b12f","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"node_id":"MDEwOlJlcG9zaXRvcnk5ODI1Mjk3Mw==","name":"ngraph","full_name":"NervanaSystems/ngraph","private":false,"owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-12-06T23:38:31Z","pushed_at":"2018-12-06T23:40:47Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"git@github.com:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":43512,"stargazers_count":737,"watchers_count":737,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":98,"open_issues":76,"watchers":737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2180"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/2180"},"issue":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/2180"},"comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/2180/comments"},"review_comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2180/comments"},"review_comment":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2180/commits"},"statuses":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/7a465a2b6f3231746b14e325e55864ffa0b0eb05"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jbobba"}}