{"action":"created","issue":{"url":"https://api.github.com/repos/apollographql/apollo-cli/issues/511","repository_url":"https://api.github.com/repos/apollographql/apollo-cli","labels_url":"https://api.github.com/repos/apollographql/apollo-cli/issues/511/labels{/name}","comments_url":"https://api.github.com/repos/apollographql/apollo-cli/issues/511/comments","events_url":"https://api.github.com/repos/apollographql/apollo-cli/issues/511/events","html_url":"https://github.com/apollographql/apollo-cli/pull/511","id":344243501,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjg1ODQ1","number":511,"title":"Stop default flag values from overriding custom config","user":{"login":"klujanrosas","id":4474353,"node_id":"MDQ6VXNlcjQ0NzQzNTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4474353?v=4","gravatar_id":"","url":"https://api.github.com/users/klujanrosas","html_url":"https://github.com/klujanrosas","followers_url":"https://api.github.com/users/klujanrosas/followers","following_url":"https://api.github.com/users/klujanrosas/following{/other_user}","gists_url":"https://api.github.com/users/klujanrosas/gists{/gist_id}","starred_url":"https://api.github.com/users/klujanrosas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klujanrosas/subscriptions","organizations_url":"https://api.github.com/users/klujanrosas/orgs","repos_url":"https://api.github.com/users/klujanrosas/repos","events_url":"https://api.github.com/users/klujanrosas/events{/privacy}","received_events_url":"https://api.github.com/users/klujanrosas/received_events","type":"User","site_admin":false},"labels":[{"id":1003933060,"node_id":"MDU6TGFiZWwxMDAzOTMzMDYw","url":"https://api.github.com/repos/apollographql/apollo-cli/labels/bugfix","name":"bugfix","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-24T23:54:19Z","updated_at":"2018-07-25T16:35:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-cli/pulls/511","html_url":"https://github.com/apollographql/apollo-cli/pull/511","diff_url":"https://github.com/apollographql/apollo-cli/pull/511.diff","patch_url":"https://github.com/apollographql/apollo-cli/pull/511.patch"},"body":"* Check if a custom config for queries hasn't been setup, else fallback to flags.queries\r\n\r\n\r\n<!--**Pull Request Labels**\r\n\r\nWhile not necessary, you can help organize our pull requests by labeling this issue when you open it.  To add a label automatically, simply [x] mark the appropriate box below:\r\n\r\n- [ ] feature\r\n- [ ] blocking\r\n- [ ] docs\r\n\r\n/label bugfix\r\n\r\nTo add a label not listed above, simply place `/label another-label-name` on a line by itself.\r\n-->"},"comment":{"url":"https://api.github.com/repos/apollographql/apollo-cli/issues/comments/407817529","html_url":"https://github.com/apollographql/apollo-cli/pull/511#issuecomment-407817529","issue_url":"https://api.github.com/repos/apollographql/apollo-cli/issues/511","id":407817529,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzgxNzUyOQ==","user":{"login":"shadaj","id":543055,"node_id":"MDQ6VXNlcjU0MzA1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/543055?v=4","gravatar_id":"","url":"https://api.github.com/users/shadaj","html_url":"https://github.com/shadaj","followers_url":"https://api.github.com/users/shadaj/followers","following_url":"https://api.github.com/users/shadaj/following{/other_user}","gists_url":"https://api.github.com/users/shadaj/gists{/gist_id}","starred_url":"https://api.github.com/users/shadaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadaj/subscriptions","organizations_url":"https://api.github.com/users/shadaj/orgs","repos_url":"https://api.github.com/users/shadaj/repos","events_url":"https://api.github.com/users/shadaj/events{/privacy}","received_events_url":"https://api.github.com/users/shadaj/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T16:35:20Z","updated_at":"2018-07-25T16:35:20Z","author_association":"MEMBER","body":"Hi @klujanrosas! Allowing the `queries` flag to override the config was actually an intended behavior, as users may sometimes want to specifically generate types for a subset of queries.\r\n\r\nHowever, we didn't catch that the queries would *always* be overriden by the default value. Maybe this could be fixed by only allowing overrides when the flag is not the default value?"}}
{"actor":{"display_login":"shadaj"}}