{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/30894","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/30894/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/30894/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/30894/events","html_url":"https://github.com/dotnet/roslyn/issues/30894","id":376267986,"node_id":"MDU6SXNzdWUzNzYyNjc5ODY=","number":30894,"title":"IDE0052 fires on write-only properties","user":{"login":"davkean","id":1103906,"node_id":"MDQ6VXNlcjExMDM5MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1103906?v=4","gravatar_id":"","url":"https://api.github.com/users/davkean","html_url":"https://github.com/davkean","followers_url":"https://api.github.com/users/davkean/followers","following_url":"https://api.github.com/users/davkean/following{/other_user}","gists_url":"https://api.github.com/users/davkean/gists{/gist_id}","starred_url":"https://api.github.com/users/davkean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkean/subscriptions","organizations_url":"https://api.github.com/users/davkean/orgs","repos_url":"https://api.github.com/users/davkean/repos","events_url":"https://api.github.com/users/davkean/events{/privacy}","received_events_url":"https://api.github.com/users/davkean/received_events","type":"User","site_admin":false},"labels":[{"id":166377917,"node_id":"MDU6TGFiZWwxNjYzNzc5MTc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false},{"id":165001069,"node_id":"MDU6TGFiZWwxNjUwMDEwNjk=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Bug","name":"Bug","color":"e52727","default":false},{"id":912763567,"node_id":"MDU6TGFiZWw5MTI3NjM1Njc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Need%20Design%20Review","name":"Need Design Review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"mavasani","id":10605811,"node_id":"MDQ6VXNlcjEwNjA1ODEx","avatar_url":"https://avatars2.githubusercontent.com/u/10605811?v=4","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"assignees":[{"login":"mavasani","id":10605811,"node_id":"MDQ6VXNlcjEwNjA1ODEx","avatar_url":"https://avatars2.githubusercontent.com/u/10605811?v=4","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/18","html_url":"https://github.com/dotnet/roslyn/milestone/18","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/18/labels","id":1675130,"node_id":"MDk6TWlsZXN0b25lMTY3NTEzMA==","number":18,"title":"16.0","description":"The version *after* the next major version.","creator":{"login":"gafter","id":3804346,"node_id":"MDQ6VXNlcjM4MDQzNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3804346?v=4","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"open_issues":1381,"closed_issues":820,"state":"open","created_at":"2016-03-31T00:06:25Z","updated_at":"2018-11-02T15:14:02Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-11-01T06:14:08Z","updated_at":"2018-11-02T17:32:36Z","closed_at":null,"author_association":"MEMBER","body":"While write-only properties are questionable, just because they don't have a getter doesn't mean they can be removed.\r\n\r\n``` VB\r\n        ''' <summary>\r\n        ''' Sets/Gets the Encoding used for text file resources, without undo support, and without causing the \r\n        '''  designer to be dirtied (because ComponentChangeService notifications won't get sent)\r\n        ''' </summary>\r\n        ''' <value></value>\r\n        ''' <remarks></remarks>\r\n        Private WriteOnly Property EncodingWithoutUndo() As Encoding\r\n            Set(Value As Encoding)\r\n                Debug.Assert(IsLink AndAlso ResourceTypeEditor.Equals(ResourceTypeEditors.TextFile))\r\n                If _resXDataNode.FileRef IsNot Nothing Then\r\n                    _resXDataNode = NewResXDataNode(Name, Comment, AbsoluteLinkPathAndFileName, ValueTypeName, Value)\r\n                End If\r\n            End Set\r\n        End Property\r\n```\r\n\r\nLater: \r\n\r\n``` VB\r\n\r\nEncodingWithoutUndo = GuessFileEncoding(AbsoluteLinkPathAndFileName)\r\n```\r\n\r\nExpected: No warning\r\nActual:\r\n\r\n```\r\nSeverity\tCode\tDescription\tProject\tProject Rank\tFile\tLine\tCategory\tSuppression State\tTool\r\nMessage\tIDE0052\tPrivate member 'Resource.EncodingWithoutUndo' can be removed as the value assigned to it is never read.\tMicrosoft.VisualStudio.Editors\t3\tE:\\project-system2\\src\\Microsoft.VisualStudio.Editors\\ResourceEditor\\Resource.vb\t958\tCode Quality\tActive\tCompiler\r\n```"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/435453605","html_url":"https://github.com/dotnet/roslyn/issues/30894#issuecomment-435453605","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/30894","id":435453605,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTQ1MzYwNQ==","user":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T17:32:36Z","updated_at":"2018-11-02T17:32:36Z","author_association":"CONTRIBUTOR","body":"@mavasani possibly worth having a sub-option for this?  so people can say \"actually, in my code we do use this pattern\", but others can say \"yeah... i would consider that strange, let me get rid of it\"\r\n\r\nAlso, we do have a convert-property-to-method refactoring.  But i'm not actually sure it works on write-only properties.  :D"}}
{"actor":{"display_login":"CyrusNajmabadi"}}