{"action":"created","comment":{"url":"https://api.github.com/repos/UtkarshMe/neovim/pulls/comments/206093980","pull_request_review_id":141486056,"id":206093980,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjA5Mzk4MA==","diff_hunk":"@@ -0,0 +1,704 @@\n+local helpers = require('test.functional.helpers')(after_each)\n+local Screen = require('test.functional.ui.screen')\n+local spawn, set_session, clear = helpers.spawn, helpers.set_session, helpers.clear\n+local feed, command = helpers.feed, helpers.command\n+local insert = helpers.insert\n+local eq, iswin = helpers.eq, helpers.iswin\n+\n+-- Note 1:\n+-- Global grid i.e. \"grid 1\" shows some unwanted elements because they are\n+-- not cleared when they are expected to be drawn over by window grids.\n+\n+describe('multigrid screen', function()\n+  local screen\n+  local nvim_argv = {helpers.nvim_prog, '-u', 'NONE', '-i', 'NONE', '-N',\n+                     '--cmd', 'set shortmess+=I background=light noswapfile belloff= noshowcmd noruler',\n+                     '--embed'}\n+\n+  before_each(function()\n+    local screen_nvim = spawn(nvim_argv)\n+    set_session(screen_nvim)\n+    screen = Screen.new()\n+    screen:attach({ext_multigrid=true})\n+    screen:set_default_attr_ids({\n+      [1] = {bold = true, foreground = Screen.colors.Blue1},\n+      [2] = {foreground = Screen.colors.Magenta},\n+      [3] = {foreground = Screen.colors.Brown, bold = true},\n+      [4] = {foreground = Screen.colors.SlateBlue},\n+      [5] = {bold = true, foreground = Screen.colors.SlateBlue},\n+      [6] = {foreground = Screen.colors.Cyan4},\n+      [7] = {bold = true},\n+      [8] = {underline = true, bold = true, foreground = Screen.colors.SlateBlue},\n+      [9] = {foreground = Screen.colors.SlateBlue, underline = true},\n+      [10] = {foreground = Screen.colors.Red},\n+      [11] = {bold = true, reverse = true},\n+      [12] = {reverse = true}\n+    })\n+    screen.win_position = {}\n+  end)\n+\n+  after_each(function()\n+    screen:detach()\n+  end)\n+\n+  it('default initial screen', function()\n+    screen:expect([[\n+    ## grid 1\n+                                                           |\n+                                                           |\n+                                                           |\n+                                                           |\n+                                                           |\n+                                                           |\n+                                                           |\n+                                                           |\n+                                                           |\n+                                                           |\n+                                                           |\n+                                                           |\n+      {11:[No Name]                                            }|\n+                                                           |\n+    ## grid 2\n+      ^                                                     |\n+      {1:~                                                    }|\n+      {1:~                                                    }|\n+      {1:~                                                    }|\n+      {1:~                                                    }|\n+      {1:~                                                    }|\n+      {1:~                                                    }|\n+      {1:~                                                    }|\n+      {1:~                                                    }|\n+      {1:~                                                    }|\n+      {1:~                                                    }|\n+      {1:~                                                    }|\n+    ]])\n+  end)\n+\n+  it('positions windows correctly', function()\n+    command('vsplit')\n+    screen:expect([[\n+    ## grid 1\n+                                {12:│}                          |\n+                                {12:│}                          |\n+                                {12:│}                          |\n+                                {12:│}                          |\n+                                {12:│}                          |\n+                                {12:│}                          |\n+                                {12:│}                          |\n+                                {12:│}                          |\n+                                {12:│}                          |\n+                                {12:│}                          |\n+                                {12:│}                          |\n+                                {12:│}                          |\n+      {11:[No Name]                  }{12:[No Name]                 }|\n+                                                           |\n+    ## grid 2\n+                                |\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+    ## grid 3\n+      ^                          |\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+      {1:~                         }|\n+    ]], nil, nil, function()\n+      iswin(screen.win_position[2].win)\n+      eq(0, screen.win_position[2].startrow)","path":"test/functional/ui/screen_multigrid_spec.lua","position":123,"original_position":123,"commit_id":"c14bcb910149c0eddf2185f321a8ccf70974fe93","original_commit_id":"c14bcb910149c0eddf2185f321a8ccf70974fe93","user":{"login":"bfredl","id":1363104,"node_id":"MDQ6VXNlcjEzNjMxMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1363104?v=4","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"body":"these could be written more compactly (and consistent with existing tests) as\r\n```\r\neq({\r\n  [2]={win={id=1001},startrow=0,...},\r\n  [3]={win=...},\r\n}, screen.win_position)\r\n```\r\nas a bonus, this will automatically assert that no spurious `win_position` was sent with unexpected grid ids (and make sure we cover every case if we decide to add a new key).","created_at":"2018-07-30T11:06:53Z","updated_at":"2018-07-30T11:06:53Z","html_url":"https://github.com/UtkarshMe/neovim/pull/5#discussion_r206093980","pull_request_url":"https://api.github.com/repos/UtkarshMe/neovim/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/UtkarshMe/neovim/pulls/comments/206093980"},"html":{"href":"https://github.com/UtkarshMe/neovim/pull/5#discussion_r206093980"},"pull_request":{"href":"https://api.github.com/repos/UtkarshMe/neovim/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/UtkarshMe/neovim/pulls/5","id":198659955,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NjU5OTU1","html_url":"https://github.com/UtkarshMe/neovim/pull/5","diff_url":"https://github.com/UtkarshMe/neovim/pull/5.diff","patch_url":"https://github.com/UtkarshMe/neovim/pull/5.patch","issue_url":"https://api.github.com/repos/UtkarshMe/neovim/issues/5","number":5,"state":"open","locked":false,"title":"Add grid-split tests","user":{"login":"UtkarshMe","id":8445768,"node_id":"MDQ6VXNlcjg0NDU3Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/8445768?v=4","gravatar_id":"","url":"https://api.github.com/users/UtkarshMe","html_url":"https://github.com/UtkarshMe","followers_url":"https://api.github.com/users/UtkarshMe/followers","following_url":"https://api.github.com/users/UtkarshMe/following{/other_user}","gists_url":"https://api.github.com/users/UtkarshMe/gists{/gist_id}","starred_url":"https://api.github.com/users/UtkarshMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UtkarshMe/subscriptions","organizations_url":"https://api.github.com/users/UtkarshMe/orgs","repos_url":"https://api.github.com/users/UtkarshMe/repos","events_url":"https://api.github.com/users/UtkarshMe/events{/privacy}","received_events_url":"https://api.github.com/users/UtkarshMe/received_events","type":"User","site_admin":false},"body":"Blocked by #4 ","created_at":"2018-07-02T12:11:44Z","updated_at":"2018-07-30T11:06:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6f31beeee5d90b3c0b69f81ffe0b9df79b0322c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UtkarshMe/neovim/pulls/5/commits","review_comments_url":"https://api.github.com/repos/UtkarshMe/neovim/pulls/5/comments","review_comment_url":"https://api.github.com/repos/UtkarshMe/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UtkarshMe/neovim/issues/5/comments","statuses_url":"https://api.github.com/repos/UtkarshMe/neovim/statuses/c14bcb910149c0eddf2185f321a8ccf70974fe93","head":{"label":"UtkarshMe:grid-split_add-tests","ref":"grid-split_add-tests","sha":"c14bcb910149c0eddf2185f321a8ccf70974fe93","user":{"login":"UtkarshMe","id":8445768,"node_id":"MDQ6VXNlcjg0NDU3Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/8445768?v=4","gravatar_id":"","url":"https://api.github.com/users/UtkarshMe","html_url":"https://github.com/UtkarshMe","followers_url":"https://api.github.com/users/UtkarshMe/followers","following_url":"https://api.github.com/users/UtkarshMe/following{/other_user}","gists_url":"https://api.github.com/users/UtkarshMe/gists{/gist_id}","starred_url":"https://api.github.com/users/UtkarshMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UtkarshMe/subscriptions","organizations_url":"https://api.github.com/users/UtkarshMe/orgs","repos_url":"https://api.github.com/users/UtkarshMe/repos","events_url":"https://api.github.com/users/UtkarshMe/events{/privacy}","received_events_url":"https://api.github.com/users/UtkarshMe/received_events","type":"User","site_admin":false},"repo":{"id":122367130,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIzNjcxMzA=","name":"neovim","full_name":"UtkarshMe/neovim","owner":{"login":"UtkarshMe","id":8445768,"node_id":"MDQ6VXNlcjg0NDU3Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/8445768?v=4","gravatar_id":"","url":"https://api.github.com/users/UtkarshMe","html_url":"https://github.com/UtkarshMe","followers_url":"https://api.github.com/users/UtkarshMe/followers","following_url":"https://api.github.com/users/UtkarshMe/following{/other_user}","gists_url":"https://api.github.com/users/UtkarshMe/gists{/gist_id}","starred_url":"https://api.github.com/users/UtkarshMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UtkarshMe/subscriptions","organizations_url":"https://api.github.com/users/UtkarshMe/orgs","repos_url":"https://api.github.com/users/UtkarshMe/repos","events_url":"https://api.github.com/users/UtkarshMe/events{/privacy}","received_events_url":"https://api.github.com/users/UtkarshMe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/UtkarshMe/neovim","description":"Vim-fork focused on extensibility and usability","fork":true,"url":"https://api.github.com/repos/UtkarshMe/neovim","forks_url":"https://api.github.com/repos/UtkarshMe/neovim/forks","keys_url":"https://api.github.com/repos/UtkarshMe/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UtkarshMe/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UtkarshMe/neovim/teams","hooks_url":"https://api.github.com/repos/UtkarshMe/neovim/hooks","issue_events_url":"https://api.github.com/repos/UtkarshMe/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/UtkarshMe/neovim/events","assignees_url":"https://api.github.com/repos/UtkarshMe/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/UtkarshMe/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/UtkarshMe/neovim/tags","blobs_url":"https://api.github.com/repos/UtkarshMe/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UtkarshMe/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UtkarshMe/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/UtkarshMe/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UtkarshMe/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/UtkarshMe/neovim/languages","stargazers_url":"https://api.github.com/repos/UtkarshMe/neovim/stargazers","contributors_url":"https://api.github.com/repos/UtkarshMe/neovim/contributors","subscribers_url":"https://api.github.com/repos/UtkarshMe/neovim/subscribers","subscription_url":"https://api.github.com/repos/UtkarshMe/neovim/subscription","commits_url":"https://api.github.com/repos/UtkarshMe/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/UtkarshMe/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/UtkarshMe/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/UtkarshMe/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/UtkarshMe/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/UtkarshMe/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UtkarshMe/neovim/merges","archive_url":"https://api.github.com/repos/UtkarshMe/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UtkarshMe/neovim/downloads","issues_url":"https://api.github.com/repos/UtkarshMe/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/UtkarshMe/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/UtkarshMe/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/UtkarshMe/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UtkarshMe/neovim/labels{/name}","releases_url":"https://api.github.com/repos/UtkarshMe/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/UtkarshMe/neovim/deployments","created_at":"2018-02-21T17:12:06Z","updated_at":"2018-07-01T18:47:25Z","pushed_at":"2018-07-30T09:13:17Z","git_url":"git://github.com/UtkarshMe/neovim.git","ssh_url":"git@github.com:UtkarshMe/neovim.git","clone_url":"https://github.com/UtkarshMe/neovim.git","svn_url":"https://github.com/UtkarshMe/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":72458,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"UtkarshMe:grid-split_fix-crossgrid","ref":"grid-split_fix-crossgrid","sha":"0ffb491bbee875636e23245371a4458228ea0a76","user":{"login":"UtkarshMe","id":8445768,"node_id":"MDQ6VXNlcjg0NDU3Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/8445768?v=4","gravatar_id":"","url":"https://api.github.com/users/UtkarshMe","html_url":"https://github.com/UtkarshMe","followers_url":"https://api.github.com/users/UtkarshMe/followers","following_url":"https://api.github.com/users/UtkarshMe/following{/other_user}","gists_url":"https://api.github.com/users/UtkarshMe/gists{/gist_id}","starred_url":"https://api.github.com/users/UtkarshMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UtkarshMe/subscriptions","organizations_url":"https://api.github.com/users/UtkarshMe/orgs","repos_url":"https://api.github.com/users/UtkarshMe/repos","events_url":"https://api.github.com/users/UtkarshMe/events{/privacy}","received_events_url":"https://api.github.com/users/UtkarshMe/received_events","type":"User","site_admin":false},"repo":{"id":122367130,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIzNjcxMzA=","name":"neovim","full_name":"UtkarshMe/neovim","owner":{"login":"UtkarshMe","id":8445768,"node_id":"MDQ6VXNlcjg0NDU3Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/8445768?v=4","gravatar_id":"","url":"https://api.github.com/users/UtkarshMe","html_url":"https://github.com/UtkarshMe","followers_url":"https://api.github.com/users/UtkarshMe/followers","following_url":"https://api.github.com/users/UtkarshMe/following{/other_user}","gists_url":"https://api.github.com/users/UtkarshMe/gists{/gist_id}","starred_url":"https://api.github.com/users/UtkarshMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UtkarshMe/subscriptions","organizations_url":"https://api.github.com/users/UtkarshMe/orgs","repos_url":"https://api.github.com/users/UtkarshMe/repos","events_url":"https://api.github.com/users/UtkarshMe/events{/privacy}","received_events_url":"https://api.github.com/users/UtkarshMe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/UtkarshMe/neovim","description":"Vim-fork focused on extensibility and usability","fork":true,"url":"https://api.github.com/repos/UtkarshMe/neovim","forks_url":"https://api.github.com/repos/UtkarshMe/neovim/forks","keys_url":"https://api.github.com/repos/UtkarshMe/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UtkarshMe/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UtkarshMe/neovim/teams","hooks_url":"https://api.github.com/repos/UtkarshMe/neovim/hooks","issue_events_url":"https://api.github.com/repos/UtkarshMe/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/UtkarshMe/neovim/events","assignees_url":"https://api.github.com/repos/UtkarshMe/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/UtkarshMe/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/UtkarshMe/neovim/tags","blobs_url":"https://api.github.com/repos/UtkarshMe/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UtkarshMe/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UtkarshMe/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/UtkarshMe/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UtkarshMe/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/UtkarshMe/neovim/languages","stargazers_url":"https://api.github.com/repos/UtkarshMe/neovim/stargazers","contributors_url":"https://api.github.com/repos/UtkarshMe/neovim/contributors","subscribers_url":"https://api.github.com/repos/UtkarshMe/neovim/subscribers","subscription_url":"https://api.github.com/repos/UtkarshMe/neovim/subscription","commits_url":"https://api.github.com/repos/UtkarshMe/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/UtkarshMe/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/UtkarshMe/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/UtkarshMe/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/UtkarshMe/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/UtkarshMe/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UtkarshMe/neovim/merges","archive_url":"https://api.github.com/repos/UtkarshMe/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UtkarshMe/neovim/downloads","issues_url":"https://api.github.com/repos/UtkarshMe/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/UtkarshMe/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/UtkarshMe/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/UtkarshMe/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UtkarshMe/neovim/labels{/name}","releases_url":"https://api.github.com/repos/UtkarshMe/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/UtkarshMe/neovim/deployments","created_at":"2018-02-21T17:12:06Z","updated_at":"2018-07-01T18:47:25Z","pushed_at":"2018-07-30T09:13:17Z","git_url":"git://github.com/UtkarshMe/neovim.git","ssh_url":"git@github.com:UtkarshMe/neovim.git","clone_url":"https://github.com/UtkarshMe/neovim.git","svn_url":"https://github.com/UtkarshMe/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":72458,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UtkarshMe/neovim/pulls/5"},"html":{"href":"https://github.com/UtkarshMe/neovim/pull/5"},"issue":{"href":"https://api.github.com/repos/UtkarshMe/neovim/issues/5"},"comments":{"href":"https://api.github.com/repos/UtkarshMe/neovim/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/UtkarshMe/neovim/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/UtkarshMe/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UtkarshMe/neovim/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/UtkarshMe/neovim/statuses/c14bcb910149c0eddf2185f321a8ccf70974fe93"}},"author_association":"OWNER"}}
{"actor":{"display_login":"bfredl"}}