{"action":"opened","number":10406,"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/10406","id":202403509,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDAzNTA5","html_url":"https://github.com/chapel-lang/chapel/pull/10406","diff_url":"https://github.com/chapel-lang/chapel/pull/10406.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/10406.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/10406","number":10406,"state":"open","locked":false,"title":"Convert TOML to error handling","user":{"login":"Spartee","id":13009163,"node_id":"MDQ6VXNlcjEzMDA5MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/13009163?v=4","gravatar_id":"","url":"https://api.github.com/users/Spartee","html_url":"https://github.com/Spartee","followers_url":"https://api.github.com/users/Spartee/followers","following_url":"https://api.github.com/users/Spartee/following{/other_user}","gists_url":"https://api.github.com/users/Spartee/gists{/gist_id}","starred_url":"https://api.github.com/users/Spartee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spartee/subscriptions","organizations_url":"https://api.github.com/users/Spartee/orgs","repos_url":"https://api.github.com/users/Spartee/repos","events_url":"https://api.github.com/users/Spartee/events{/privacy}","received_events_url":"https://api.github.com/users/Spartee/received_events","type":"User","site_admin":false},"body":"This PR converts the halts in `TOML.chpl` to error handling. The motivation behind this PR was a number of simple mistakes that a user might make in a `Mason.toml` when configuring a Mason project. For this reason the tests were conducted using the `mason update` feature, and the test  were placed in `/test/mason/`. Expect more tests/futures to be added as more users run into uncaught errors that represent the areas of the toml spec we do not support. \r\n\r\nIn implementing this PR I ran into #10395 which caused me to unnecessarily modify a few functions to get the error handling to work as expected. ","created_at":"2018-07-18T23:03:54Z","updated_at":"2018-07-18T23:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"Spartee","id":13009163,"node_id":"MDQ6VXNlcjEzMDA5MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/13009163?v=4","gravatar_id":"","url":"https://api.github.com/users/Spartee","html_url":"https://github.com/Spartee","followers_url":"https://api.github.com/users/Spartee/followers","following_url":"https://api.github.com/users/Spartee/following{/other_user}","gists_url":"https://api.github.com/users/Spartee/gists{/gist_id}","starred_url":"https://api.github.com/users/Spartee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spartee/subscriptions","organizations_url":"https://api.github.com/users/Spartee/orgs","repos_url":"https://api.github.com/users/Spartee/repos","events_url":"https://api.github.com/users/Spartee/events{/privacy}","received_events_url":"https://api.github.com/users/Spartee/received_events","type":"User","site_admin":false},"assignees":[{"login":"Spartee","id":13009163,"node_id":"MDQ6VXNlcjEzMDA5MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/13009163?v=4","gravatar_id":"","url":"https://api.github.com/users/Spartee","html_url":"https://github.com/Spartee","followers_url":"https://api.github.com/users/Spartee/followers","following_url":"https://api.github.com/users/Spartee/following{/other_user}","gists_url":"https://api.github.com/users/Spartee/gists{/gist_id}","starred_url":"https://api.github.com/users/Spartee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spartee/subscriptions","organizations_url":"https://api.github.com/users/Spartee/orgs","repos_url":"https://api.github.com/users/Spartee/repos","events_url":"https://api.github.com/users/Spartee/events{/privacy}","received_events_url":"https://api.github.com/users/Spartee/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/10406/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/10406/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/10406/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/c486b32ffd0683fa7d7ffdfeb2f1cae330269b3e","head":{"label":"Spartee:error-handling","ref":"error-handling","sha":"c486b32ffd0683fa7d7ffdfeb2f1cae330269b3e","user":{"login":"Spartee","id":13009163,"node_id":"MDQ6VXNlcjEzMDA5MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/13009163?v=4","gravatar_id":"","url":"https://api.github.com/users/Spartee","html_url":"https://github.com/Spartee","followers_url":"https://api.github.com/users/Spartee/followers","following_url":"https://api.github.com/users/Spartee/following{/other_user}","gists_url":"https://api.github.com/users/Spartee/gists{/gist_id}","starred_url":"https://api.github.com/users/Spartee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spartee/subscriptions","organizations_url":"https://api.github.com/users/Spartee/orgs","repos_url":"https://api.github.com/users/Spartee/repos","events_url":"https://api.github.com/users/Spartee/events{/privacy}","received_events_url":"https://api.github.com/users/Spartee/received_events","type":"User","site_admin":false},"repo":{"id":93550185,"node_id":"MDEwOlJlcG9zaXRvcnk5MzU1MDE4NQ==","name":"chapel","full_name":"Spartee/chapel","owner":{"login":"Spartee","id":13009163,"node_id":"MDQ6VXNlcjEzMDA5MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/13009163?v=4","gravatar_id":"","url":"https://api.github.com/users/Spartee","html_url":"https://github.com/Spartee","followers_url":"https://api.github.com/users/Spartee/followers","following_url":"https://api.github.com/users/Spartee/following{/other_user}","gists_url":"https://api.github.com/users/Spartee/gists{/gist_id}","starred_url":"https://api.github.com/users/Spartee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spartee/subscriptions","organizations_url":"https://api.github.com/users/Spartee/orgs","repos_url":"https://api.github.com/users/Spartee/repos","events_url":"https://api.github.com/users/Spartee/events{/privacy}","received_events_url":"https://api.github.com/users/Spartee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Spartee/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/Spartee/chapel","forks_url":"https://api.github.com/repos/Spartee/chapel/forks","keys_url":"https://api.github.com/repos/Spartee/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spartee/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spartee/chapel/teams","hooks_url":"https://api.github.com/repos/Spartee/chapel/hooks","issue_events_url":"https://api.github.com/repos/Spartee/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/Spartee/chapel/events","assignees_url":"https://api.github.com/repos/Spartee/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/Spartee/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/Spartee/chapel/tags","blobs_url":"https://api.github.com/repos/Spartee/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spartee/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spartee/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spartee/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spartee/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/Spartee/chapel/languages","stargazers_url":"https://api.github.com/repos/Spartee/chapel/stargazers","contributors_url":"https://api.github.com/repos/Spartee/chapel/contributors","subscribers_url":"https://api.github.com/repos/Spartee/chapel/subscribers","subscription_url":"https://api.github.com/repos/Spartee/chapel/subscription","commits_url":"https://api.github.com/repos/Spartee/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spartee/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spartee/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spartee/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spartee/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/Spartee/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spartee/chapel/merges","archive_url":"https://api.github.com/repos/Spartee/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spartee/chapel/downloads","issues_url":"https://api.github.com/repos/Spartee/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/Spartee/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/Spartee/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/Spartee/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spartee/chapel/labels{/name}","releases_url":"https://api.github.com/repos/Spartee/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/Spartee/chapel/deployments","created_at":"2017-06-06T18:23:35Z","updated_at":"2018-07-18T17:58:54Z","pushed_at":"2018-07-18T22:54:01Z","git_url":"git://github.com/Spartee/chapel.git","ssh_url":"git@github.com:Spartee/chapel.git","clone_url":"https://github.com/Spartee/chapel.git","svn_url":"https://github.com/Spartee/chapel","homepage":"http://chapel.cray.com/","size":524851,"stargazers_count":0,"watchers_count":0,"language":"Chapel","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"e29c3ff417ee67f41a8d66178cd3498f7e35e0c1","user":{"login":"chapel-lang","id":7597261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1OTcyNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY2MzI4NQ==","name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1OTcyNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2018-07-18T22:37:04Z","pushed_at":"2018-07-18T22:54:03Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"https://chapel-lang.org","size":535370,"stargazers_count":682,"watchers_count":682,"language":"Chapel","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":1077,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":188,"open_issues":1077,"watchers":682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/10406"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/10406"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/10406"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/10406/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/10406/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/10406/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/c486b32ffd0683fa7d7ffdfeb2f1cae330269b3e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":333,"deletions":187,"changed_files":16}}
{"actor":{"display_login":"Spartee"}}