{"action":"created","issue":{"url":"https://api.github.com/repos/theia-ide/theia/issues/2278","repository_url":"https://api.github.com/repos/theia-ide/theia","labels_url":"https://api.github.com/repos/theia-ide/theia/issues/2278/labels{/name}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/2278/comments","events_url":"https://api.github.com/repos/theia-ide/theia/issues/2278/events","html_url":"https://github.com/theia-ide/theia/issues/2278","id":338526436,"node_id":"MDU6SXNzdWUzMzg1MjY0MzY=","number":2278,"title":"[git] Commit message textArea does not resize correctly on browser refresh","user":{"login":"kittaakos","id":1405703,"node_id":"MDQ6VXNlcjE0MDU3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1405703?v=4","gravatar_id":"","url":"https://api.github.com/users/kittaakos","html_url":"https://github.com/kittaakos","followers_url":"https://api.github.com/users/kittaakos/followers","following_url":"https://api.github.com/users/kittaakos/following{/other_user}","gists_url":"https://api.github.com/users/kittaakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kittaakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittaakos/subscriptions","organizations_url":"https://api.github.com/users/kittaakos/orgs","repos_url":"https://api.github.com/users/kittaakos/repos","events_url":"https://api.github.com/users/kittaakos/events{/privacy}","received_events_url":"https://api.github.com/users/kittaakos/received_events","type":"User","site_admin":false},"labels":[{"id":547099386,"node_id":"MDU6TGFiZWw1NDcwOTkzODY=","url":"https://api.github.com/repos/theia-ide/theia/labels/bug","name":"bug","color":"ee0701","default":true},{"id":726527952,"node_id":"MDU6TGFiZWw3MjY1Mjc5NTI=","url":"https://api.github.com/repos/theia-ide/theia/labels/git","name":"git","color":"c99f20","default":false}],"state":"open","locked":false,"assignee":{"login":"kittaakos","id":1405703,"node_id":"MDQ6VXNlcjE0MDU3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1405703?v=4","gravatar_id":"","url":"https://api.github.com/users/kittaakos","html_url":"https://github.com/kittaakos","followers_url":"https://api.github.com/users/kittaakos/followers","following_url":"https://api.github.com/users/kittaakos/following{/other_user}","gists_url":"https://api.github.com/users/kittaakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kittaakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittaakos/subscriptions","organizations_url":"https://api.github.com/users/kittaakos/orgs","repos_url":"https://api.github.com/users/kittaakos/repos","events_url":"https://api.github.com/users/kittaakos/events{/privacy}","received_events_url":"https://api.github.com/users/kittaakos/received_events","type":"User","site_admin":false},"assignees":[{"login":"kittaakos","id":1405703,"node_id":"MDQ6VXNlcjE0MDU3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1405703?v=4","gravatar_id":"","url":"https://api.github.com/users/kittaakos","html_url":"https://github.com/kittaakos","followers_url":"https://api.github.com/users/kittaakos/followers","following_url":"https://api.github.com/users/kittaakos/following{/other_user}","gists_url":"https://api.github.com/users/kittaakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kittaakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittaakos/subscriptions","organizations_url":"https://api.github.com/users/kittaakos/orgs","repos_url":"https://api.github.com/users/kittaakos/repos","events_url":"https://api.github.com/users/kittaakos/events{/privacy}","received_events_url":"https://api.github.com/users/kittaakos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-07-05T10:59:13Z","updated_at":"2018-07-05T11:17:34Z","closed_at":null,"author_association":"MEMBER","body":"Steps to reproduce:\r\n - Add a commit message: `a\\n\\b\\nc`.\r\n - Activate `Files`.\r\n - Set the focus on an editor.\r\n - Refresh the browser.\r\n\r\nThis does not happen when the `Git` is active and then the user refreshes the browser.\r\n\r\nAlso: we must not restore the validation error/warnings when the commit message `textArea` is empty. Otherwise, the following happens.\r\n\r\n - Active the `Git` widget.\r\n - Press `Commit`.\r\n - Got the error which is expected.\r\n - Refresh the browser.\r\n - The error is still there, it should not be."},"comment":{"url":"https://api.github.com/repos/theia-ide/theia/issues/comments/402690136","html_url":"https://github.com/theia-ide/theia/issues/2278#issuecomment-402690136","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/2278","id":402690136,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjY5MDEzNg==","user":{"login":"kittaakos","id":1405703,"node_id":"MDQ6VXNlcjE0MDU3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1405703?v=4","gravatar_id":"","url":"https://api.github.com/users/kittaakos","html_url":"https://github.com/kittaakos","followers_url":"https://api.github.com/users/kittaakos/followers","following_url":"https://api.github.com/users/kittaakos/following{/other_user}","gists_url":"https://api.github.com/users/kittaakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kittaakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittaakos/subscriptions","organizations_url":"https://api.github.com/users/kittaakos/orgs","repos_url":"https://api.github.com/users/kittaakos/repos","events_url":"https://api.github.com/users/kittaakos/events{/privacy}","received_events_url":"https://api.github.com/users/kittaakos/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T11:17:34Z","updated_at":"2018-07-05T11:17:34Z","author_association":"MEMBER","body":"When refreshing the browser, we do not hit the `storeState` in the `Git` widget when it is not the active one. This defect seems to be a generic issue with the `storeState`/`restoreState`. Related: https://github.com/theia-ide/theia/issues/1316\r\n\r\nI can work around this, by storing the state each time there is a change in the `textArea`. What's your take on that @AlexTugarev?"}}
{"actor":{"display_login":"kittaakos"}}