{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/236825774","pull_request_review_id":178981505,"id":236825774,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjgyNTc3NA==","diff_hunk":"@@ -59,6 +59,24 @@ Note that if you run it from the source tree via leiningen, you should\n make sure to use trampoline, i.e. `lein trampoline run benchmark ...`\n so that the tool can shut down and clean up normally.\n \n+### Running on an agent other than master\n+\n+Running the PuppetDB benchmark tool on the master can cause resource constraints\n+which may significantly skew performance on the master. If you would like to run\n+the benchmark tool on an agent this can be achieved following the instructions\n+below.\n+\n+* In /etc/puppetlabs/puppetdb/conf.d/jetty.ini in the [jetty] section, set:\n+    * host = 0.0.0.0 (http access from all agents) or\n+    * host = <agent ip address> (access from specific agent)","path":"documentation/load_testing_tool.markdown","position":13,"original_position":13,"commit_id":"b18ce1671a14b4e3d42a2fe5d9f857017c021fd1","original_commit_id":"b18ce1671a14b4e3d42a2fe5d9f857017c021fd1","user":{"login":"samwoods1","id":4604901,"node_id":"MDQ6VXNlcjQ2MDQ5MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/4604901?v=4","gravatar_id":"","url":"https://api.github.com/users/samwoods1","html_url":"https://github.com/samwoods1","followers_url":"https://api.github.com/users/samwoods1/followers","following_url":"https://api.github.com/users/samwoods1/following{/other_user}","gists_url":"https://api.github.com/users/samwoods1/gists{/gist_id}","starred_url":"https://api.github.com/users/samwoods1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samwoods1/subscriptions","organizations_url":"https://api.github.com/users/samwoods1/orgs","repos_url":"https://api.github.com/users/samwoods1/repos","events_url":"https://api.github.com/users/samwoods1/events{/privacy}","received_events_url":"https://api.github.com/users/samwoods1/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n    * host = <agent ip address> # (access from specific agent)\r\n```","created_at":"2018-11-27T20:03:36Z","updated_at":"2018-11-27T20:05:07Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/2712#discussion_r236825774","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2712","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/236825774"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/2712#discussion_r236825774"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2712"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2712","id":232075716,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDc1NzE2","html_url":"https://github.com/puppetlabs/puppetdb/pull/2712","diff_url":"https://github.com/puppetlabs/puppetdb/pull/2712.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/2712.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2712","number":2712,"state":"open","locked":false,"title":"(DOCS-857) Update benchmark docs with information about running on agent","user":{"login":"Zak-Kent","id":14876008,"node_id":"MDQ6VXNlcjE0ODc2MDA4","avatar_url":"https://avatars2.githubusercontent.com/u/14876008?v=4","gravatar_id":"","url":"https://api.github.com/users/Zak-Kent","html_url":"https://github.com/Zak-Kent","followers_url":"https://api.github.com/users/Zak-Kent/followers","following_url":"https://api.github.com/users/Zak-Kent/following{/other_user}","gists_url":"https://api.github.com/users/Zak-Kent/gists{/gist_id}","starred_url":"https://api.github.com/users/Zak-Kent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zak-Kent/subscriptions","organizations_url":"https://api.github.com/users/Zak-Kent/orgs","repos_url":"https://api.github.com/users/Zak-Kent/repos","events_url":"https://api.github.com/users/Zak-Kent/events{/privacy}","received_events_url":"https://api.github.com/users/Zak-Kent/received_events","type":"User","site_admin":false},"body":"@samwoods1 this is a first pass at adding docs for running benchmark on an agent using what you described in [DOCUMENT-857](https://tickets.puppetlabs.com/browse/DOCUMENT-857).\r\n\r\nI'm wondering if puppetdb and the necessary pieces to run the benchmark tool are installed on the agent by default, or do you think we need to list doing that as an additional step?  ","created_at":"2018-11-19T18:48:36Z","updated_at":"2018-11-27T20:05:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4350de713faa8839664a40e7f5489eff1d208320","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":163190639,"node_id":"MDU6TGFiZWwxNjMxOTA2Mzk=","url":"https://api.github.com/repos/puppetlabs/puppetdb/labels/work%20in%20progress","name":"work in progress","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2712/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2712/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2712/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/b18ce1671a14b4e3d42a2fe5d9f857017c021fd1","head":{"label":"Zak-Kent:document-857-benchmark-tool","ref":"document-857-benchmark-tool","sha":"b18ce1671a14b4e3d42a2fe5d9f857017c021fd1","user":{"login":"Zak-Kent","id":14876008,"node_id":"MDQ6VXNlcjE0ODc2MDA4","avatar_url":"https://avatars2.githubusercontent.com/u/14876008?v=4","gravatar_id":"","url":"https://api.github.com/users/Zak-Kent","html_url":"https://github.com/Zak-Kent","followers_url":"https://api.github.com/users/Zak-Kent/followers","following_url":"https://api.github.com/users/Zak-Kent/following{/other_user}","gists_url":"https://api.github.com/users/Zak-Kent/gists{/gist_id}","starred_url":"https://api.github.com/users/Zak-Kent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zak-Kent/subscriptions","organizations_url":"https://api.github.com/users/Zak-Kent/orgs","repos_url":"https://api.github.com/users/Zak-Kent/repos","events_url":"https://api.github.com/users/Zak-Kent/events{/privacy}","received_events_url":"https://api.github.com/users/Zak-Kent/received_events","type":"User","site_admin":false},"repo":{"id":94945600,"node_id":"MDEwOlJlcG9zaXRvcnk5NDk0NTYwMA==","name":"puppetdb","full_name":"Zak-Kent/puppetdb","private":false,"owner":{"login":"Zak-Kent","id":14876008,"node_id":"MDQ6VXNlcjE0ODc2MDA4","avatar_url":"https://avatars2.githubusercontent.com/u/14876008?v=4","gravatar_id":"","url":"https://api.github.com/users/Zak-Kent","html_url":"https://github.com/Zak-Kent","followers_url":"https://api.github.com/users/Zak-Kent/followers","following_url":"https://api.github.com/users/Zak-Kent/following{/other_user}","gists_url":"https://api.github.com/users/Zak-Kent/gists{/gist_id}","starred_url":"https://api.github.com/users/Zak-Kent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zak-Kent/subscriptions","organizations_url":"https://api.github.com/users/Zak-Kent/orgs","repos_url":"https://api.github.com/users/Zak-Kent/repos","events_url":"https://api.github.com/users/Zak-Kent/events{/privacy}","received_events_url":"https://api.github.com/users/Zak-Kent/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Zak-Kent/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/Zak-Kent/puppetdb","forks_url":"https://api.github.com/repos/Zak-Kent/puppetdb/forks","keys_url":"https://api.github.com/repos/Zak-Kent/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zak-Kent/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zak-Kent/puppetdb/teams","hooks_url":"https://api.github.com/repos/Zak-Kent/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/Zak-Kent/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/Zak-Kent/puppetdb/events","assignees_url":"https://api.github.com/repos/Zak-Kent/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/Zak-Kent/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/Zak-Kent/puppetdb/tags","blobs_url":"https://api.github.com/repos/Zak-Kent/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zak-Kent/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zak-Kent/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zak-Kent/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zak-Kent/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/Zak-Kent/puppetdb/languages","stargazers_url":"https://api.github.com/repos/Zak-Kent/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/Zak-Kent/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/Zak-Kent/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/Zak-Kent/puppetdb/subscription","commits_url":"https://api.github.com/repos/Zak-Kent/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zak-Kent/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zak-Kent/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zak-Kent/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zak-Kent/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/Zak-Kent/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zak-Kent/puppetdb/merges","archive_url":"https://api.github.com/repos/Zak-Kent/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zak-Kent/puppetdb/downloads","issues_url":"https://api.github.com/repos/Zak-Kent/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/Zak-Kent/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/Zak-Kent/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/Zak-Kent/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zak-Kent/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/Zak-Kent/puppetdb/releases{/id}","deployments_url":"https://api.github.com/repos/Zak-Kent/puppetdb/deployments","created_at":"2017-06-21T00:12:24Z","updated_at":"2018-11-01T23:13:44Z","pushed_at":"2018-11-27T18:37:24Z","git_url":"git://github.com/Zak-Kent/puppetdb.git","ssh_url":"git@github.com:Zak-Kent/puppetdb.git","clone_url":"https://github.com/Zak-Kent/puppetdb.git","svn_url":"https://github.com/Zak-Kent/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":18984,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:5.1.x","ref":"5.1.x","sha":"54bcbc312fb444b64dc5dd972592d3b6fa4ee92f","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"node_id":"MDEwOlJlcG9zaXRvcnkyMTkzMDMy","name":"puppetdb","full_name":"puppetlabs/puppetdb","private":false,"owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetdb/deployments","created_at":"2011-08-11T18:54:46Z","updated_at":"2018-11-24T06:43:40Z","pushed_at":"2018-11-27T18:37:26Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":18992,"stargazers_count":230,"watchers_count":230,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":196,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":196,"open_issues":22,"watchers":230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2712"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/2712"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2712"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2712/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2712/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2712/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/b18ce1671a14b4e3d42a2fe5d9f857017c021fd1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"samwoods1"}}